IRC Chat : 2012-02-28 - OpenMRS

00:21:05 *** Mouseman has joined #openmrs
00:29:57 *** wyclif has joined #openmrs
00:38:52 *** Mouseman has quit IRC
00:58:10 *** chopin has joined #openmrs
01:04:32 *** pterminator has quit IRC
01:22:03 *** djazayeri has quit IRC
01:22:04 *** djazayeri has joined #openmrs
01:22:04 *** ChanServ sets mode: +o djazayeri
02:28:13 *** chopin has quit IRC
02:38:08 *** Singham has joined #openmrs
02:38:25 *** Singham is now known as Guest1913
04:12:10 *** suranga has joined #openmrs
04:27:08 *** Guest1913 has quit IRC
05:06:37 *** goutham has joined #openmrs
06:03:49 *** bryq has joined #openmrs
06:03:49 *** ChanServ sets mode: +v bryq
06:04:37 *** Mkop1 has joined #openmrs
06:04:37 *** ChanServ sets mode: +v Mkop1
06:04:49 *** Mkop has quit IRC
06:16:14 *** Mkop has joined #openmrs
06:16:14 *** ChanServ sets mode: +v Mkop
06:16:29 *** Mkop1 has quit IRC
06:30:14 *** aashishmittal has joined #openmrs
07:01:40 *** bryq has quit IRC
07:18:35 *** aashishmittal has quit IRC
07:21:33 *** dkayiwa has joined #openmrs
07:54:41 *** dkayiwa has quit IRC
07:56:14 *** dkayiwa has joined #openmrs
07:59:39 *** dkayiwa_ has joined #openmrs
08:00:47 *** dkayiwa has quit IRC
08:00:47 *** dkayiwa_ is now known as dkayiwa
08:10:23 *** aashishmittal has joined #openmrs
08:21:55 *** dkayiwa has quit IRC
08:24:31 *** dkayiwa has joined #openmrs
09:40:05 *** upul` has joined #openmrs
09:40:05 *** ChanServ sets mode: +v upul`
09:54:09 *** rafa has joined #openmrs
09:54:09 *** ChanServ sets mode: +v rafa
09:55:53 <dkayiwa> hi rafa
09:56:07 <dkayiwa> rafa: how is the standalone ticket going? :)
09:57:04 <rafa> dkayiwa: I didn't have time to get back to that one yesterday
09:57:13 <rafa> dkayiwa: I'll do it today
09:57:35 <dkayiwa> rafa: ok :)
10:02:00 *** r0bby has joined #openmrs
10:02:00 *** ChanServ sets mode: +v r0bby
10:02:31 *** robbyoconnor has quit IRC
10:21:46 *** dkayiwa has quit IRC
10:40:39 *** upul` has left #openmrs
10:42:07 *** dkayiwa has joined #openmrs
11:00:29 *** dkayiwa has quit IRC
11:12:22 *** dkayiwa has joined #openmrs
11:16:31 *** r0bby has quit IRC
12:06:33 *** james_regen has joined #openmrs
12:06:33 *** ChanServ sets mode: +v james_regen
12:24:47 *** bryq has joined #openmrs
12:24:47 *** ChanServ sets mode: +v bryq
12:59:52 <dkayiwa> hi rafa
12:59:59 <rafa> dkayiwa: hi
13:00:04 <dkayiwa> rafa: do you think we can now close TRUNK-3069
13:00:08 <dkayiwa> !ticket TRUNK-3069
13:00:10 <OpenMRSBot> dkayiwa: [#TRUNK-3069] Rename AdministrationService.validateInManualFlushMode, and refactor it and ValidateUtil - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3069
13:00:58 <rafa> dkayiwa: yes
13:03:22 <dkayiwa> rafa: did you add something to the migrating-to-1.9 page? :)
13:03:32 <rafa> dkayiwa: not yet
13:03:53 <dkayiwa> rafa: haha, then Darius will kill me if i close it now :)
13:04:27 <rafa> dkayiwa: haha no way
13:04:54 <dkayiwa> rafa: maybe you close it yourself such that he kills you instead :D
13:05:26 <rafa> dkayiwa: or else I'll add a note to that page and everyone will be happy ;)
13:05:57 <dkayiwa> rafa: meaning you will add a note and then close? :)
13:06:05 <rafa> sure
13:06:13 <dkayiwa> rafa: oh thanks!!!
13:06:31 *** Mkop1 has joined #openmrs
13:06:31 *** ChanServ sets mode: +v Mkop1
13:07:23 *** chopin has joined #openmrs
13:08:17 *** Mkop has quit IRC
13:08:22 <chopin> dkayiwa, if i want to copy an xform to another server, can i just click "download xform" on the one server and upload it to the other, if i have a form ready for it (with the same schema) on the new server?
13:09:59 <dkayiwa> chopin: looking for the wiki page .... :)
13:10:03 <chopin> haha ok
13:10:24 <chopin> dkayiwa, got it
13:10:26 <chopin> https://wiki.openmrs.org/display/docs/XForms+Module+User+Guide
13:10:27 <OpenMRSBot> <http://ln-s.net/8afL> (at wiki.openmrs.org)
13:10:42 <dkayiwa> chopin: oh you are so fast!!!
13:10:47 <chopin> haha
13:10:54 <chopin> google is my friend (and enemy)
13:11:15 <dkayiwa> chopin: hahaha. how is it your enemy?
13:11:25 <dkayiwa> chopin: when it fails to give you answers???
13:11:42 <chopin> yessss
13:11:49 <chopin> when the answers are lost in a haystack of other sites
13:11:50 <dkayiwa> :D
13:11:57 <dkayiwa> hahahha
13:17:03 *** Mkop has joined #openmrs
13:17:03 *** ChanServ sets mode: +v Mkop
13:17:32 *** Mkop1 has quit IRC
13:19:00 *** bryq has quit IRC
13:20:35 *** dkayiwa has quit IRC
13:21:33 *** dkayiwa has joined #openmrs
13:25:45 *** bwolfe_ has joined #openmrs
13:25:45 *** ChanServ sets mode: +o bwolfe_
13:45:56 *** dkayiwa_ has joined #openmrs
13:47:33 *** dkayiwa has quit IRC
13:47:34 *** dkayiwa_ is now known as dkayiwa
13:58:46 *** mnunez has joined #openmrs
14:02:20 <mnunez> Hi everyone!
14:03:24 <mnunez> @rafa: Quick question: should two concepts have the same SNOMED mapping, would they be presented as possible canditates to merge by the MDS?
14:04:03 <rafa> mnunez: yes
14:04:28 <suranga> james_regen, helooo
14:04:38 <rafa> mnunez: you can even go to configuration and choose mappings that should be considered as exact matches versus possible matches
14:08:58 <james_regen> suranga: hi
14:09:11 <suranga> james_regen, hi, not a lot to report for today
14:09:26 <suranga> Dr. Shaun was tief up with some work, so I put off the demo for tomorrow
14:09:36 <suranga> and I also discoverd and fixed PTM 55
14:09:59 <james_regen> ok, let me look up the ticket
14:10:53 <suranga> and regarding yesterdays mail on ampath and patientmatching, its looks like ampath people are getting together to discuss which procedure they will follow ...
14:11:14 <suranga> (on an unrelated note, you might note that I myself am responsible for creating PTM 55 in the first place :P
14:14:22 <james_regen> suranga: ok, i've read the ticket. do you know how to close tickets? there's several steps to do, but you probably have the permissions to do it
14:14:48 <suranga> james_regen, I will check it out... I t should be possible :-)
14:15:14 <suranga> its a stupid ticket, and practically my fault anyway :P
14:15:57 <james_regen> suranga: it's alright, we'll still let you work on the module
14:16:10 *** sgithens has joined #openmrs
14:17:06 *** goutham has quit IRC
14:17:49 <suranga> james_regen, :)
14:19:25 *** r8friedman has joined #openmrs
14:19:56 <r8friedman> bwolfe_: hi ben got a minute
14:21:10 <r8friedman> chopin: hi, got a minute?
14:22:38 <mnunez> rafa: Awesome, thanks!
14:23:22 <r8friedman> dkayiwa: hi daniel, got a minute?
14:23:57 <suranga> hi r8friedman ... mmm... if u type your question, i'll see if I can hellp in some way ... :-)
14:24:12 <r8friedman> hey suranga, tks
14:24:57 <r8friedman> the structure of the obs table in the test data set is different than that described in the hibernate mapping file in 1.8
14:25:38 <r8friedman> i'm trying to find out what's the real situation and why that would be so
14:26:48 <suranga> :-O do u mean that the table structure is different ? wow....
14:27:38 <suranga> r8friedman, u were right, we need one of the big boys for this one :-(
14:28:00 *** dkayiwa has quit IRC
14:35:51 <r8friedman> hi djazayeri, got a minute? if so, pls look at my question @ 9:25
15:06:35 *** Mkop has quit IRC
15:09:48 *** suranga has quit IRC
15:10:51 <sgithens> Is it possible to use <obs/> elements at all with a concept of datatype N/A ?
15:21:57 *** bwolfe_ has quit IRC
15:29:47 *** bwolfe_ has joined #openmrs
15:29:47 *** ChanServ sets mode: +o bwolfe_
15:32:31 <chopin> r8friedman, heyya
15:32:47 <chopin> sgithens, i have no idea ... try it! :-D
15:33:00 <r8friedman> hey, can you go up to my question @ 9:25 my time?
15:33:32 <chopin> r8friedman, re: obs table structure vs hiberante?
15:33:37 <chopin> hibernate, that is
15:33:42 <r8friedman> chopin: yep
15:33:56 <r8friedman> chopin: are you up to 1.8?
15:34:12 <sgithens> chopin: Well, it's giving me errors which is why I was wondering if there is some set of attributes that does make it work :)
15:34:14 <chopin> r8friedman, what's the difference between the two? in production we are at 1.8.2
15:34:30 <sgithens> chopin: I've just been stubbing them out, or changing them locally for now
15:35:00 <chopin> sgithens, ah
15:35:01 <r8friedman> chopin: well, we don't change data models without a minor version change
15:35:26 <chopin> r8friedman, right ... i mean, what's the difference between the table and hibernate?
15:35:56 <r8friedman> chopin: vast, the table has separate columns for answers of different types, the hbm doesn't
15:38:35 <r8friedman> chopin: don't see any indication on obs changes in release notes for 1.7 or 1.8
15:39:42 *** Mkop has joined #openmrs
15:39:42 *** ChanServ sets mode: +v Mkop
15:47:07 <chopin> hmm
15:47:31 <bwolfe_> rafa, how goes your ticket about the mvp dict?
15:47:45 <chopin> r8friedman, it's possible there is some hibernate trickery going on in the obs table
15:48:21 <r8friedman> chopin: you mean like subclassing?
15:48:54 <chopin> r8friedman, i mean there are ways to tell hibernate where to put data without using the hbm for everything ... but idk if that's what's happening.
15:48:59 <chopin> bwolfe would know better
15:49:13 <chopin> or saptarshi
15:49:37 <r8friedman> ok, but what version are you at, chopin
15:49:51 <chopin> in production, we're at 1.8.2
15:49:58 <chopin> and most of my test environments
15:50:29 <r8friedman> chopin: so what fields are you using in your forms when you store obs?
15:50:46 <chopin> we use Form Entry
15:50:52 <chopin> HL7 processor does the work
15:51:46 <r8friedman> chopin: hm, does sound like trickery somewhere
15:54:46 <r8friedman> bwolfe_: hey ben, got a minute?
15:54:54 <bwolfe_> sure
15:54:59 <r8friedman> the structure of the obs table in the test data set is different than that described in the hibernate mapping file in 1.8
15:55:15 <r8friedman> there's no mention of a data structure change in 1.7 or 1.8 release notes
15:55:37 <r8friedman> what's going on? is this related to REST/Form Entry trickery?
15:55:42 *** bwolfe_ is now known as bwolfe
15:55:53 <bwolfe> which test data?
15:56:10 <r8friedman> the middle-sized one
15:56:56 <r8friedman> 1331 patients
15:57:03 <bwolfe> !demodata
15:57:04 <OpenMRSBot> bwolfe: "demodata" --- https://wiki.openmrs.org/display/RES/Demo+Data
15:57:23 <bwolfe> from that page?
15:57:28 <r8friedman> yep
16:00:33 *** mnunez has quit IRC
16:01:01 <bwolfe> r8friedman, we're terrible about mentioning data model changes in our release notes :-/
16:01:22 <bwolfe> so there probably were changes to the table, and it just isn't listed
16:01:29 <bwolfe> r8friedman, whats the error you're running into?
16:01:53 <r8friedman> bwolfe: no error yet, was just trying to write specs for loading the obs table and ran into this
16:02:21 <r8friedman> bwolfe: i've been running 1.8 against my db without any complaints and without any updating
16:02:38 <r8friedman> although maybe i should try something explicitly touching obs
16:02:40 <bwolfe> r8friedman, best practice is to load the db with whatever demo version you choose, make sure liquibasechangelog is empty, then start the openmrs war and let it check for upgrades
16:03:26 <rafa> bwolfe: I've fixed duplicate names in spanish by changing them from the FULLY_SPECIFIED to INDEX_TERM type as agreed with Andy and now I'm running validators again.
16:03:27 <r8friedman> bwolfe: yeah, i'm trying to remember whether the upgrade question appeared in the install wizard
16:03:34 <rafa> bwolfe: they should complete in an hour or two
16:04:22 <bwolfe> r8friedman, its not a question, its a requirement. so if you ran the install wizard against an existing db, it was upgraded for you. the upgrade screen in the install wizard is not the same one you see when upgrading. its less fancy and blends in with the other stuff
16:04:32 <bwolfe> rafa, *sigh*
16:04:44 <bwolfe> andy should be very happy you're cleaning up his db. :-)
16:05:29 <rafa> bwolfe: yeah :)
16:05:38 <r8friedman> bwolfe: i'm going to do something that explicitly uses obs and get back to you
16:18:01 *** chopin has quit IRC
16:25:09 <r8friedman> bwolfe: man that xml really bites a big one
16:25:29 <r8friedman> bwolfe: but REST had no trouble using my DB
16:25:51 <bwolfe> what xml?
16:26:16 <r8friedman> bwolfe: the xml displayed in firefox when you do a REST GET
16:26:27 <bwolfe> large?
16:26:51 <r8friedman> bwolfe: incomprehensible, constantly serializing SimpleObject
16:26:57 <bwolfe> is it possible to get a firefox extension to set the accepts header and format the json output?
16:27:31 *** dewmal has joined #openmrs
16:27:31 <r8friedman> bwolfe: I'll check, maybe I'll move to curl or use the tester
16:28:08 *** dewmal has quit IRC
16:32:43 *** mvorobey has joined #openmrs
16:32:48 <mvorobey> hi all
16:33:03 *** mvorobey_ has joined #openmrs
16:38:50 <r8friedman> bwolfe: the main issue is that my DB worked even though its structure does not match obs.hbm.xml in 1.8
16:39:21 <bwolfe> r8friedman, how is it different?
16:39:24 <bwolfe> hi mvorobey
16:39:56 <r8friedman> bwolfe: vast. the actual structure has fields for each type of result, the hbm doesn't
16:40:38 <bwolfe> ??
16:40:49 <r8friedman> bwolfe: ?? yourself
16:40:49 <bwolfe> the hbm file should...look again
16:40:55 <bwolfe> lol
16:43:39 <r8friedman> bwolfe: the hbm has valueDateTime, valueNumeric, valueText, valueComplex
16:45:02 <r8friedman> the DB has value_boolean, value_coded, value_drug, value_datetime, value_numeric, value_text
16:45:44 <bwolfe> those valueDatetime/valueNumeric/etc elements have an attr named "column" in there. that attrs specifies value_datetime, value_numeric, value_text, etc
16:47:53 <r8friedman> bwolfe: value_coded and value_coded_name are in the associations but not in the properties
16:48:56 <bwolfe> which do you mean by associations and which by properties?
16:49:48 <djazayeri> r8friedman: references to other tables are associations, rather than properties
16:49:56 <r8friedman> in the hbm file, the properties are those for which there are getter/setters in the POJO, while associations are the way Hibernate is told about table relationships
16:49:58 <djazayeri> fields in the table itself are properties
16:50:04 <sgithens> chopin: All the elements I had an issue with just needed to go in obsgroups
16:52:33 <r8friedman> bwolfe: djazayeri When I have a concept_id in my data table, I have a property for that field as a Concept with concept_id as the linking field
16:53:56 <djazayeri> r8friedman: is that a question?
16:54:32 <djazayeri> bwolfe: btw, can you tweak the jira query behind the yellow box on the dashboard to not include tickets that (you) own, but are in post-commit review?
16:54:45 <r8friedman> it's a contrast. What obs.hbm.xml has is no property for value_coded but instead an association to Concept on value_coded
16:54:52 <djazayeri> e.g. if I commit a ticket, it shouldn't show up in my should-be-actively-looking-at box
16:56:11 <r8friedman> bwolfe: djazayeri oh, ok, now I see
16:56:41 <r8friedman> in obs.hbm.xml, all the properties are together, then the many-to-ones
16:57:11 <r8friedman> bwolfe: djazayeri when i do an hbm, I go in field older mixing properties and many-to-ones
16:57:45 <bwolfe> r8friedman, to each his own I suppose
16:57:49 *** mnunez has joined #openmrs
16:59:04 <r8friedman> bwolfe: djazayeri sorry to bother you with this
16:59:27 *** surangak has joined #openmrs
17:01:56 <r8friedman> bwolfe: but i do have a question about the REST test page
17:03:27 <r8friedman> bwolfe: it seems like the REF references are coming out as default reps
17:03:53 <r8friedman> don't know if that's what's in the data or if the test page is doing us a favor and following links
17:05:00 <r8friedman> bwolfe: maybe is a problem with setting of maximum depth
17:06:06 *** bryq has joined #openmrs
17:06:07 *** ChanServ sets mode: +v bryq
17:11:46 <surangak> im off for the day guys
17:11:54 <surangak> its been a very long day !
17:14:51 <mnunez> rafa: Have a minute?
17:16:55 *** surangak has quit IRC
17:27:17 <mvorobey_> bwolfe: Ben, do you have a minute?
17:27:48 *** mvorobey_ has left #openmrs
17:44:22 <bwolfe> mvorobey, sorry, was at lunch. whats up?
17:44:38 <bwolfe> wyclif, can you assess all of your new tickets and make ones that are smaller into Low Complexity ones?
17:44:41 <mvorobey> bwolfe: I have a question about TRUNK-2619.
17:44:53 <mvorobey> bwolfe: You said that I need to add unit test for getDrugOrdersByPatient(), so, do I need to create own dataSet or just use existing one?
17:45:09 <wyclif> bwolfe, i will
17:45:15 <bwolfe> r8friedman, can you give an example?
17:45:24 <bwolfe> !ticket TRUNK-2619
17:45:25 <OpenMRSBot> bwolfe: [#TRUNK-2619] When adding a regimen , the regimen does not appear , until the page is refreshed . - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2619
17:46:09 <bwolfe> mvorobey, use existing one. there is one by default loaded. the standardDataSet.xml file
17:46:36 <bwolfe> mvorobey, use TestUtils.printTableContents(getConnection(), "mytable", "myothertable"...) to see what is there when running it
17:47:11 <mvorobey> bwolfe: oh, I already saw it
17:48:13 <mvorobey> bwolfe: Can I change startDate property of some orders just to test if method correctly fetches future drug orders?
17:48:53 <bwolfe> mvorobey, you can test that way, but we don't like changing that dataset. so if you need new data, you'll have to also call your own dataset file :-/
17:50:02 <mvorobey> bwolfe: Can you tell me if dataSet files are merged when am adding own one?
17:55:55 <bwolfe> yes, both are run
17:56:17 <bwolfe> yours will overwrite the standard one if you use hte same primary keys...otherwise you just add rows to the in-memory db
17:57:18 <mvorobey> bwolfe: ok, thanks, Ben, will write test
18:02:18 <mvorobey> bwolfe: I have already added own dataSet, new unit test and ran it. Everything was fine. What to do next?
18:07:33 <bwolfe> mvorobey, redo and reupload your patch. still waiting on comment from djazayeri, iirc
18:09:11 <mvorobey> bwolfe: redone and re-uploaded :) will wait for comment from Darius
18:09:37 <djazayeri> mvorobey: which ticket #?
18:09:47 <mvorobey> 2619
18:09:58 <mvorobey> !ticket TRUNK-2619
18:09:59 <OpenMRSBot> mvorobey: [#TRUNK-2619] When adding a regimen , the regimen does not appear , until the page is refreshed . - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2619
18:19:58 <mvorobey> djazayeri: I agreed with you, but would you like to tell me if is there a way to handle bitwise OR operation on enumeration values?
18:27:58 <rafa> mvorobey: see EnumSet
18:28:22 <mvorobey> rafa: thanks :)
18:28:30 <rafa> mnunez: I'm back
18:36:23 <djazayeri> mvorobey: that said, if this will require a lot of work, I'm not sure if it's worth it.
18:38:05 <mvorobey> djazayeri: :) oh, I see, just started to implement idea with bitwise OR using EnumSet and can tell that it's a bit tricky :)
18:38:35 <djazayeri> mvorobey: briefly, why do we have to include FUTURE with CURRENT? (I coudln't tell from the ticket description)
18:39:01 <mvorobey> djazayeri: let me explain you
18:40:53 <mvorobey> djazayeri: DWROrderService basically fetches only CURRENT drug orders, and if you add new drug regimen and set its startDate in future, then that order won't appear untill you refresh the page
18:41:21 <mvorobey> because page refreshing is being done via PortletController
18:41:23 <djazayeri> mvorobey: what method is called when you first load the page? Why does that one include future, but the DWR one doesn't?
18:41:44 <mvorobey> PortletController is being called first time
18:41:54 <mvorobey> not javascript DWROrderService
18:42:03 <djazayeri> mvorobey: does the portlet controller manually combine the results from two service calls?
18:42:10 <djazayeri> or does it get current + future in a single service call?
18:42:19 <djazayeri> or does it just get everything, and only display the current + future?
18:42:23 <mvorobey> djazayeri: yes it does, it combines
18:44:07 <mvorobey> djazayeri: it gets everything and then filters only CURRENT and FUTURE ones
18:44:23 <djazayeri> mvorobey: so, my suggestion would be to just add a new method for getCurrentAndFutureOrders(patient, …) in DWROrderService, and don't touch OrderService.
18:44:57 <djazayeri> mvorobey: I wouldn't say this for any other service, but OrderService in particular is slated to be completely refactored. So I'd rather _not_ add extra useful methods to it before the refactoring.
18:45:03 <djazayeri> bwolfe: do you agree? ^^
18:45:19 <djazayeri> mvorobey: sorry if it sounds like we're going around in circles here...
18:45:29 <bwolfe> haha
18:45:35 <mvorobey> djazayeri: but how to be with voiding and discontinuing ?
18:46:01 <djazayeri> oh, sorry, I forgot about that, I just meant for the display
18:46:04 <bwolfe> I suppose that makes sense
18:46:04 <mvorobey> djazayeri: void and discontinue only CURRENT ones, but FUTURE left
18:46:43 <djazayeri> voidCurrentAndFutureDrugOrders(Patient, Something, String)
18:48:47 <mvorobey> djazayeri: I think in this case my first patch on this ticket (TRUNK-2619.patch) is perfect fit
18:49:04 <mvorobey> djazayeri, bwolfe: is not it?
18:51:26 <djazayeri> mvorobey: I'm saying that you should avoid taking a call with whatToShow==CURRENT and then showing current + future. Instead, you should change the caller so it calls the new getCurrentAndFuture.
18:51:59 <djazayeri> though...
18:52:20 <djazayeri> my head hurts trying to figure out the best way to do this.
18:52:24 <djazayeri> :-P
18:52:36 <mvorobey> djazayeri: ou, shoot :)
18:52:53 <djazayeri> So, Ben had suggested adding a CURRENT_AND_FUTURE enum value
18:53:02 <djazayeri> would that require tons of changes to OrderService?
18:53:12 <djazayeri> Or would that be pretty easy to add there?
18:53:33 <mvorobey> djazayeri: CURRENT_AND_FUTURE - as for me it's very convenient idea
18:53:35 <djazayeri> i.e. to make everything that takes one of those enums respect the new value?
18:53:55 <djazayeri> how many OrderService methods take one of those as input? 2 or 3?
18:54:15 <mvorobey> 3 +
18:55:10 <mvorobey> djazayeri: adding of new enum value is not so big deal, I have already tries it before :) can repeat it again :D
18:55:58 <djazayeri> mvorobey: so, I apologize for not having looked at the underlying code before commenting...
18:56:09 <djazayeri> I had thought that there was an ORDER_STATUS.FUTURE option
18:56:21 <djazayeri> I now see that we only have CURRENT, ANY, COMPLETE, NOTVOIDED.
18:56:24 <mvorobey> djazayeri: now it was not
18:56:42 <djazayeri> so, given that, I do not think it's necessary to add CURRENT_AND_FUTURE
18:56:54 <mvorobey> djazayeri: we thought out it with Ben :)
18:57:01 <djazayeri> instead, just change the documentation on CURRENT to say that it also includes scheduled ones.
18:57:11 <djazayeri> "future scheduled" ones
18:57:25 <djazayeri> and then change the behavior in OrderService so that getting CURRENT also includes FUTURE.
18:57:29 <mvorobey> djazayeri: will do as you said
18:57:47 <djazayeri> Sorry for having derailed that without looking back at the code. :-)
18:57:53 <djazayeri> bwolfe: agreed? ^^
18:58:16 <mvorobey> djazayeri: no problem, we are looking for better solution :)
18:58:58 <bwolfe> djazayeri, I defer to your orderservice prowess. my concern was anyone depending on CURRENT to NOT include future ones. is that not an issue? would devs/users not have that requirement?
19:00:14 <djazayeri> mvorobey: for the methods whose behaviors will change, can you do a search (ctrl-h in eclipse) to see where they're referenced, and check whether any of those references in the core codebase assume not-future?
19:01:09 <djazayeri> bwolfe: I think that it's fair to treat CURRENT as really meaning "not completed", and I doubt there's anyone relying on the current behavior in modules
19:01:13 <mvorobey> djazayeri: I did it yesterday :D everuthing fine
19:01:31 <mvorobey> everuthing = everything
19:01:31 <djazayeri> but we should ask mseaton, regarding simple lab entry, and r8friedman, regarding his lab stuff.
19:02:38 <mvorobey> djazayeri: maybe at least it would e easier to add new state rather than trouble them?
19:02:39 <djazayeri> mvorobey: so, actually, you should email the dev list saying that we're planning to change the meaning of that enum value (and point out what the existing enum values are), and ask if that's going to break things for anyone's modules.
19:02:48 <mvorobey> djazayeri: ok
19:02:59 <djazayeri> mvorobey: you can say that the alternative is to add a new state.
19:03:37 <mvorobey> djazayeri: ok, will write a letter ;)
19:05:28 <mvorobey> djazayeri, bwolfe: thanks, guys, a lot for helping me in this stuff :)
19:05:46 <djazayeri> mvorobey: thanks for doing the tickets!
19:07:20 <mvorobey> djazayeri: np, we're both doing the tickets :D
19:36:18 *** james_regen has left #openmrs
19:49:07 *** dkayiwa has joined #openmrs
19:55:33 *** bwolfe has quit IRC
20:07:30 *** mvorobey has quit IRC
20:13:04 *** Mkop1 has joined #openmrs
20:13:04 *** ChanServ sets mode: +v Mkop1
20:13:07 *** Mkop has quit IRC
20:24:57 *** bwolfe has joined #openmrs
20:24:57 *** ChanServ sets mode: +o bwolfe
20:31:38 <bwolfe> /whereis dawn
20:32:03 <djazayeri> dunno, but it's scrum-time, right?
20:32:21 <bwolfe> yeah, thats why I was asking
20:32:22 <djazayeri> bwolfe, rafa, dkayiwa, wyclif: scrum?
20:32:30 <bwolfe> !scrumon djazayeri
20:32:30 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster djazayeri- you may begin when ready.
20:32:39 <rafa> hi
20:33:06 <djazayeri> Okay, today's order is alphabetical by 3rd letter of username: dkayiwa, wyclif, rafa, bwolfe, djazayeri
20:33:10 <djazayeri> (I'm last because I feel like it.)
20:33:13 <djazayeri> dkayiwa:
20:33:55 <bwolfe> um, you should have just chosen 4th letter then...
20:34:08 <djazayeri> okay, let's save dkayiwa for later
20:34:11 <djazayeri> wyclif: ?
20:34:22 <wyclif> monday:
20:34:22 <wyclif> * revisted TRUNK-3049 - Ugly screen when upgrading to OpenMRS 1.9
20:34:22 <wyclif> * TRUNK-3048 - When searching for patients by name, exact matches should be shown first
20:34:22 <wyclif> * TRUNK-3082 - Missing label for an encounter with no visit on patient dashboard
20:34:22 <wyclif> Today:
20:34:23 <wyclif> * revisit and complete TRUNK-3048 - When searching for patients by name, exact matches should be shown first
20:34:26 <wyclif> * TRUNK-324 - Go through the TODO items code and create tickets out of them
20:34:28 <wyclif> * RCM-43 - Report objects are removed rather than retired from the system
20:34:30 <wyclif> Blockers: none
20:34:54 <rafa> Today:
20:34:54 <rafa> * Worked on STAND-36: Automatically create MVP/CIEL dictionary-based dataset as part of the standalone build process
20:34:54 <rafa> https://tickets.openmrs.org/browse/STAND-36: fixed 4k invalid concepts, now re-running validation (around 5k left with only 10 invalid so far), will need to modify the standalone wizard tomorrow to use the fixed mvp.
20:34:54 <rafa> Blockers: I need a spare PC to run the validation :)
20:35:16 *** dawn_ has joined #openmrs
20:35:19 *** ChanServ sets mode: +v dawn_
20:35:26 <wyclif> rafa, cool
20:35:44 <djazayeri> wyclif: how did TRUNK-324 get to be high-priority? just wondering...
20:35:45 <dawn_> bwolfe: djazayeri rafa dkayiwa and wyclif : hi. sorry i'm late
20:35:59 <bwolfe> djazayeri, it was voted on...
20:36:02 <rafa> hi dawn_
20:36:02 <djazayeri> dawn_: no worries, we got started on
20:36:07 <bwolfe> dawn--
20:36:08 <djazayeri> bwolfe: wow, okay
20:36:49 <wyclif> djazayeri, not sure, i just recall finding it among tickets with high priority
20:36:51 <bwolfe> yeah, not sure who/why
20:37:08 <bwolfe> rafa, is your machine dual core at least?
20:37:16 <bwolfe> triaged 4 trunk tickets
20:37:17 <bwolfe> reviewed TRUNK-2305, default locale with new users
20:37:17 <bwolfe> reviewed TRUNK-3059, voided encounterproviders
20:37:17 <bwolfe> helped a unicorn bathe in our pond
20:37:17 <bwolfe> reviewed TRUNK-3066, deserialization problem
20:37:17 <bwolfe> reviewed/applied TRUNK-1800, become this user locale problem
20:37:19 <bwolfe> worked on TRUNK-33, reduce object use
20:37:23 <rafa> bwolfe: yeah intel i5
20:37:39 <dkayiwa> sorry was talking to someone here
20:37:47 <bwolfe> figured out why we have high memory use (no gc of our classloaders due to threads)...just need to try and fix it now
20:37:53 <djazayeri> bwolfe: backport the unicorn
20:37:54 <bwolfe> dkayiwa, you're next
20:38:11 <bwolfe> djazayeri, sorry, its a new feature
20:38:20 <djazayeri> bwolfe: I want it in 1.8. :-(
20:38:25 <djazayeri> dkayiwa: your turn
20:38:32 <bwolfe> djazayeri, you'll have to start a custom build then
20:38:42 <dkayiwa> Created 1.9 release candidate dashboard
20:38:42 <dkayiwa> Reviewed and tested: Small fixes for newpatient.form - TRUNK-198
20:38:42 <dkayiwa> Reviewed and tested: Ugly screen when upgrading to OpenMRS 1.9 - TRUNK-3049
20:38:42 <dkayiwa> Reviewed and tested: Missing label for an encounter with no visit on patient dashboard - TRUNK-3082
20:38:42 <dkayiwa> Applied patch and made some changes for: Encounter.removeProvider and setProvider should void the EncounterProvider, not remove it - TRUNK-3059
20:38:42 <dkayiwa> Did some 1.9 ticket administration
20:38:42 <dkayiwa> Now reviewing: Add delete/purge for program states in the workflow - TRUNK-3087
20:38:43 <dkayiwa> No Blockers
20:38:49 <djazayeri> bwolfe: fine. fwiw, it was downey who voted on trunk-324.
20:38:56 <rafa> !ticket TRUNK-33
20:38:57 <OpenMRSBot> rafa: [#TRUNK-33] Reduce the object/memory usage of openmrs - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-33
20:39:31 <bwolfe> djazayeri, oh, his votes don't count. ;-)
20:39:31 <djazayeri> Monday 27-Feb-2012
20:39:31 <djazayeri> * Committed quick-fix for TRUNK-3072 for skathol
20:39:31 <djazayeri> * Quick review of TRUNK-3069
20:39:31 <djazayeri> * Committed TRUNK-3066 - deserializing a SerializedObject should rethrow errors
20:39:31 <djazayeri> * Worked on OpenMRS University presentation for Wednesday
20:39:31 <djazayeri> * (got stuck building the standalone; eventually I gave it enough memory)
20:39:32 <djazayeri> Tuesday 28-Feb-2012
20:39:33 <djazayeri> * Committed @since for TRUNK-3066 (backporting is annoying...)
20:39:33 <djazayeri> * Discussed TRUNK-2619 with mvorobey
20:39:33 <djazayeri> * Working on OpenMRS University presentation for tomorrow
20:39:34 <djazayeri> * Another sprint ticket or 1.9 ticket?
20:39:54 <rafa> !ticket TRUNK-324
20:39:55 <OpenMRSBot> rafa: [#TRUNK-324] Go through the TODO items code and create tickets out of them - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-324
20:40:01 *** Mkop has joined #openmrs
20:40:01 *** ChanServ sets mode: +v Mkop
20:40:09 <djazayeri> no blockers, except that I'd like dkayiwa to tell me whether I need to work on 1.9, or the bugfix sprint.
20:40:24 <dkayiwa> djazayeri: 1.9
20:40:27 *** Mkop1 has quit IRC
20:41:19 <bwolfe> !scrumoff
20:41:19 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
20:41:36 <bwolfe> no discussion points unless we're taking up a collection for rafal to get a second computer
20:41:46 <djazayeri> I have some
20:41:52 <rafa> :D
20:41:52 <djazayeri> dkayiwa: 1.9 status update?
20:42:05 <bwolfe> rafa, I'm sure you could get just some old used computer parts for $100 and put that on a pegboard somewhere to ssh into. :-)
20:42:37 <dkayiwa> djazayeri: i ticket is ready for work , 3 in progress, 5 in post commit review
20:42:44 <dkayiwa> i = 1
20:43:38 <djazayeri> dkayiwa: do you know who's supposed to be handling those 5 post-commit tickets?
20:44:12 <dkayiwa> djazayeri: one in for htmlformentry
20:44:56 <dkayiwa> djazayeri: will need to check the rest. last checked them yesterday
20:45:59 <djazayeri> dkayiwa: everyday the first thing you do should be to look at what still needs to be done for 1.9, and tell us what we need to do to support getting it out.
20:46:06 <rafa> bwolfe: yeah I wanted to try something like that for builds and executing junits once :D
20:46:19 *** djazayeri has left #openmrs
20:46:27 *** djazayeri has joined #openmrs
20:46:27 *** ChanServ sets mode: +o djazayeri
20:46:39 <rafa> bwolfe: maybe when I have more time to play with that
20:46:43 <djazayeri> (oops, accidentally closed the window)
20:46:56 <dkayiwa> djazayeri: they were sleeping, so i waited for them to wake up :)
20:47:08 <djazayeri> dkayiwa: you can email us :-P
20:47:18 <djazayeri> or better, email the dev list.
20:47:21 <dkayiwa> ok :)
20:47:56 <djazayeri> say "here's what is holding up 1.9 RC, and here's what has to happen on those tickets"
20:48:06 <djazayeri> dkayiwa: can you please send such an email tonight or tomorrow morning?
20:48:21 <dkayiwa> djazayeri: to the dev list?
20:48:25 <djazayeri> dkayiwa: yes
20:49:40 <djazayeri> dkayiwa: what are you planning to do with bundled modules in 1.9 RC?
20:50:35 <dawn_> dkayiwa: djazayeri : I would recommend putting a deadline in that email so ppl know how much time they have based on when we can realistically release 1.9 RC. From a previous dev call, we said it would be release on 11th March
20:51:08 <djazayeri> dawn_: that's the release date for 1.9 (final); we need to get the RC out ASAP.
20:51:46 <dawn_> djazayeri: thnx
20:51:49 <djazayeri> dkayiwa, dawn_: I agree that in the email you should say "we want to get this out tomorrow (or whenever)" so I need you to do these tickets now.
20:52:15 <dkayiwa> djazayeri: Baily, Pushkar, and Rafal
20:52:15 <dkayiwa> are the ones with tickets in progress
20:52:16 <dkayiwa> djazayeri: then one ready for work ticket
20:52:16 <dkayiwa> djazayeri: Bailly has just submitted a patch which am looking at
20:52:16 <dkayiwa> djazayeri: so that leaves Pushjkar and Rafal
20:52:17 <dkayiwa> djazayeri: so we can steal Pushkar's ticket
20:52:18 <dkayiwa> djazayeri: and also work on the un claimed remaining one ticket
20:52:52 <djazayeri> dkayiwa: okay, you have us online now, and you can tell us what to do
20:53:04 <djazayeri> do you want someone to steal pushkar's ticket? if so, who?
20:53:27 <dkayiwa> djazayeri: can you work on the remaining ready for work ticket?
20:53:47 <djazayeri> dkayiwa: yes
20:54:07 <dkayiwa> then since Rafal, already has a ticket, Ben or Wyclif could steal Pushkar's ticket
20:54:14 <djazayeri> dkayiwa: pick one of them
20:54:18 <djazayeri> you're the boss
20:54:22 <djazayeri> :-)
20:54:25 <dkayiwa> djazayeri: Ben :)
20:54:41 <djazayeri> ask them who has time if you want, but before we all leave this conversation, pick one, and assign it.
20:55:18 <djazayeri> dkayiwa: also, do you know what bundled modules you'll be including in the RC?
20:55:19 <dkayiwa> bwolfe: do you have the time to steal pushkar's ticket?
20:55:52 <dkayiwa> djazayeri: the same as for the 1.9 beta plus just one more module
20:56:06 <djazayeri> dkayiwa: which module?
20:56:11 <dkayiwa> djazayeri: where the htmlformentry version is that i will get from Mark
20:56:19 <dkayiwa> djazayeri: patient matching module
20:56:28 <djazayeri> dkayiwa: patient matching? or patient flags?
20:57:59 <dkayiwa> djazayeri: oh will check my emails first to confirm which
20:58:18 <djazayeri> dkayiwa: patient flags was the one we decided to bundle a long time ago.
20:58:27 <dkayiwa> djazayeri: ok
20:58:28 <djazayeri> dkayiwa: what about the versions of other modules? are they the same as the beta?
20:58:45 <djazayeri> also, when Mark gives you the new HFE, we should include HFE19ext.
20:58:47 <bwolfe> is this the one I'm stealing? https://tickets.openmrs.org/browse/TRUNK-2240
20:58:47 <dkayiwa> djazayeri: will check the module repository for each
20:59:15 <dkayiwa> bwolfe: yes
21:01:43 <djazayeri> okay, gotta get lunch
21:12:10 *** wyclif has quit IRC
21:16:22 *** dkayiwa has quit IRC
21:16:26 *** magicaltrout has quit IRC
21:16:27 *** dawn_ has quit IRC
21:16:29 *** Mkop has quit IRC
21:16:32 *** bwolfe has quit IRC
21:16:32 *** bryq has quit IRC
21:16:32 *** djazayeri has quit IRC
21:16:34 *** Echidna has quit IRC
21:17:04 *** mnunez has left #openmrs
21:18:29 *** djazayeri has joined #openmrs
21:18:29 *** Mkop has joined #openmrs
21:18:29 *** dawn_ has joined #openmrs
21:18:29 *** bwolfe has joined #openmrs
21:18:29 *** zelazny.freenode.net sets mode: +ovvo djazayeri Mkop dawn_ bwolfe
21:18:29 *** dkayiwa has joined #openmrs
21:18:29 *** Echidna has joined #openmrs
21:18:29 *** magicaltrout has joined #openmrs
21:18:29 *** zelazny.freenode.net sets mode: +v Echidna
21:34:54 *** dawn_ has quit IRC
21:45:28 *** wyclif has joined #openmrs
22:02:12 *** sgithens has quit IRC
22:08:41 *** dkayiwa has quit IRC
22:23:53 *** r8friedman has quit IRC
22:26:15 *** dkayiwa has joined #openmrs
22:32:28 *** dkayiwa has quit IRC
23:01:44 *** robbyoconnor has joined #openmrs
23:01:44 *** ChanServ sets mode: +v robbyoconnor
23:08:57 *** rafa has quit IRC
23:53:18 *** wyclif has quit IRC