00:15:48
|
*** wyclif has joined #openmrs
|
01:41:50
|
*** bryq has joined #openmrs
|
01:41:50
|
*** ChanServ sets mode: +v bryq
|
02:24:29
|
*** chopin_ has joined #openmrs
|
02:56:58
|
*** djazayeri has quit IRC
|
03:08:14
|
*** djazayeri has joined #openmrs
|
03:08:14
|
*** ChanServ sets mode: +o djazayeri
|
03:10:14
|
*** bwolfe has joined #openmrs
|
03:10:14
|
*** ChanServ sets mode: +o bwolfe
|
03:18:40
|
*** chopin_ has quit IRC
|
03:40:14
|
*** bryq has quit IRC
|
04:34:59
|
*** suranga has joined #openmrs
|
04:37:24
|
<suranga> mm... guys, is the server down... I cant seem to access the wiki
|
04:37:25
|
<suranga> :(
|
04:51:22
|
<bwolfe> suranga, http://status.openmrs.org
|
04:51:49
|
<suranga> sorry bwolfe , i kep forgetting that link :(
|
04:51:55
|
<suranga> *keep
|
04:52:34
|
<bwolfe> no worries
|
04:52:56
|
<bwolfe> suranga, the other cool on is something like http://downforeveryoneorjustme.com
|
04:53:02
|
<bwolfe> and with that I'm off to bed
|
04:53:03
|
<bwolfe> g'night
|
04:53:10
|
<djazayeri> gnight
|
04:53:10
|
<suranga> goodnight ben
|
04:53:10
|
*** bwolfe has quit IRC
|
04:53:15
|
<suranga> seee you tomorrowww
|
05:12:17
|
*** djazayeri1 has joined #openmrs
|
05:13:55
|
*** djazayeri has quit IRC
|
05:38:38
|
*** djazayeri has joined #openmrs
|
05:38:39
|
*** ChanServ sets mode: +o djazayeri
|
05:39:20
|
*** djazayeri1 has quit IRC
|
05:50:52
|
*** djazayeri1 has joined #openmrs
|
05:50:52
|
*** djazayeri has quit IRC
|
06:05:03
|
*** djazayeri1 has quit IRC
|
06:16:46
|
*** djazayeri has joined #openmrs
|
06:16:46
|
*** ChanServ sets mode: +o djazayeri
|
07:33:39
|
*** dkayiwa has joined #openmrs
|
07:53:53
|
*** dkayiwa has quit IRC
|
08:01:04
|
*** dkayiwa has joined #openmrs
|
08:16:15
|
*** wyclif has quit IRC
|
08:16:35
|
*** wyclif has joined #openmrs
|
08:23:07
|
*** bryq has joined #openmrs
|
08:23:07
|
*** ChanServ sets mode: +v bryq
|
08:51:41
|
*** upul` has joined #openmrs
|
08:51:41
|
*** ChanServ sets mode: +v upul`
|
08:59:22
|
*** rafa has joined #openmrs
|
08:59:22
|
*** ChanServ sets mode: +v rafa
|
09:33:54
|
*** dkayiwa_ has joined #openmrs
|
09:35:18
|
*** dkayiwa has quit IRC
|
09:35:18
|
*** dkayiwa_ is now known as dkayiwa
|
09:37:21
|
*** suranga has quit IRC
|
11:01:16
|
*** bryq has quit IRC
|
11:17:57
|
*** dkayiwa has quit IRC
|
11:20:45
|
*** dkayiwa has joined #openmrs
|
11:27:23
|
*** upul` has quit IRC
|
11:35:41
|
*** james_regen has joined #openmrs
|
11:35:41
|
*** ChanServ sets mode: +v james_regen
|
12:32:27
|
*** dkayiwa_ has joined #openmrs
|
12:32:39
|
*** dkayiwa has quit IRC
|
12:33:36
|
*** dkayiwa_ is now known as dkayiwa
|
12:59:40
|
*** dkayiwa has quit IRC
|
13:02:58
|
*** dkayiwa has joined #openmrs
|
13:21:41
|
*** rafa has quit IRC
|
13:24:30
|
*** downey has joined #openmrs
|
13:24:30
|
*** ChanServ sets mode: +o downey
|
13:24:30
|
*** OpenMRSBot sets mode: +o downey
|
13:27:18
|
*** robbyoconnor has quit IRC
|
13:30:17
|
*** rafa has joined #openmrs
|
13:30:17
|
*** ChanServ sets mode: +v rafa
|
13:47:36
|
*** chopin_ has joined #openmrs
|
13:48:35
|
*** wyclif has quit IRC
|
14:10:31
|
*** sgithens has joined #openmrs
|
14:13:17
|
*** bwolfe has joined #openmrs
|
14:13:17
|
*** ChanServ sets mode: +o bwolfe
|
14:35:45
|
<sgithens> Are the config and manifest files inside .omad bundles something we made up, or do they follow a 'module loading' spec of some kind that there is a library for that we use?
|
14:48:47
|
<chopin_> s/omad/omod
|
14:48:53
|
<chopin_> hi sgithens (jkeiper here)
|
14:49:25
|
<chopin_> sgithens, and i think the omod is just a jar, really ... bwolfe will be able to tell you more about that
|
14:50:44
|
<sgithens> chopin_: Yeah, I unzipped it, just curious if all the configuration schemas are part of a standard Spring 'module' system, or if we made them up
|
14:51:06
|
<sgithens> good to know your handle :p
|
14:53:32
|
<chopin_> sgithens, ah. not sure about that, but we do have a service for loading modules that you can look at ...
|
14:55:10
|
<bwolfe> sgithens, made them up
|
14:55:18
|
<bwolfe> our modules were before spring modules
|
14:55:30
|
<sgithens> bwolfe: cool, thx
|
14:56:09
|
<bwolfe> and even before osgi
|
15:00:28
|
<bwolfe> scrum time djazayeri, rafa, dkayiwa
|
15:00:49
|
<dkayiwa> hi bwolfe
|
15:01:06
|
<rafa> I'm here :)
|
15:01:15
|
<djazayeri> hi
|
15:01:33
|
*** wyclif has joined #openmrs
|
15:01:34
|
*** downey has quit IRC
|
15:02:51
|
<wyclif> sorry guys, apparently my clock was off by about 3-4 min
|
15:02:53
|
<bwolfe> (and now wyclif)
|
15:03:01
|
<djazayeri> !scrumon bwolfe
|
15:03:01
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster bwolfe- you may begin when ready.
|
15:03:14
|
*** downey has joined #openmrs
|
15:03:14
|
*** ChanServ sets mode: +o downey
|
15:03:14
|
*** OpenMRSBot sets mode: +o downey
|
15:03:15
|
<bwolfe> alphabetical order today
|
15:03:40
|
<djazayeri> bwolfe, djazayeri, dkayiwa, rafa, wyclif
|
15:03:54
|
<rafa> djazayeri: that's helpful :D
|
15:03:54
|
<bwolfe> today:
|
15:03:54
|
<bwolfe> upgraded mvp to 1.9.x to work on TRUNK-3068
|
15:03:54
|
<bwolfe> reviewed trunk tickets for daniel
|
15:03:54
|
<bwolfe> cleaned out some old reviews
|
15:04:19
|
<bwolfe> c'mon, djazayeri, I was testing how well you all could pay attention!
|
15:04:54
|
<djazayeri> Well, I didn't realize that was your whole report. :-)
|
15:04:55
|
<djazayeri> blockers?
|
15:05:10
|
<djazayeri> oh, you mean the alphabetical order thing...
|
15:05:12
|
<bwolfe> sorry, yes, slow morning. stuck on upgrading andy's silly db
|
15:05:25
|
<bwolfe> had a strnage error, now am trying to delete obs so that the upgrade will finish before monday :-p
|
15:05:42
|
<rafa> bwolfe: it wasn't that long for me...
|
15:05:50
|
<dkayiwa> bwolfe: i tried upgrade mine and it took so long that i cancelled it :)
|
15:06:05
|
<bwolfe> rafa, you still have the 6 mil obs?
|
15:06:19
|
<rafa> bwolfe: nope just andy's :P
|
15:06:30
|
<rafa> bwolfe: I mean the concept dict
|
15:06:31
|
<dkayiwa> aha, i think i was dealing with the pentaho MVP db :)
|
15:06:40
|
<bwolfe> same
|
15:06:51
|
<rafa> bwolfe: don't go that path :P
|
15:07:07
|
<djazayeri> ah, FWIW, the pentaho dictionary is a bit of a frankenstein that involves some deidentification done by andy + some splicing done by gretchen
|
15:07:49
|
<djazayeri> It's of limited use as a test-case, since I don't think it's actually correct.
|
15:08:05
|
<rafa> bwolfe: I'd really recommend to do it only on the MVP concept dict
|
15:08:08
|
<bwolfe> good, then I will delete the obs table
|
15:08:27
|
<djazayeri> Okay, my report:
|
15:08:32
|
<djazayeri> Thursday 23-Feb-2012
|
15:08:32
|
<djazayeri> * Dev call
|
15:08:32
|
<djazayeri> * Leadership call
|
15:08:32
|
<djazayeri> * Call with Andy, Ben, and Bruce about openmrs-motech integration
|
15:08:32
|
<djazayeri> * Review lots of tickets
|
15:08:33
|
<djazayeri> ** Reviewed TRUNK-57
|
15:08:33
|
<djazayeri> ** Reviewed TRUNK-2273
|
15:08:34
|
<djazayeri> ** Reviewed TRUNK-2240
|
15:08:34
|
<djazayeri> ** Reviewed/followup commit for TRUNK-3055
|
15:08:35
|
<djazayeri> ** Fixed & closed TRUNK-3033
|
15:08:35
|
<djazayeri> ** Reviewed TRUNK-2198
|
15:08:36
|
<djazayeri> ** Added unit test and closed TRUNK-2589
|
15:08:37
|
<djazayeri> Friday 24-Feb-2012
|
15:08:37
|
<djazayeri> * Review more 1.9 tickets, if there are any left
|
15:08:38
|
<djazayeri> * Release the Reporting REST module as alpha
|
15:08:38
|
<djazayeri> * ???
|
15:09:11
|
<dkayiwa> Reviewed, tested and closed: Add initialization/update wizard messages for languages other than english - TRUNK-3001
|
15:09:11
|
<rafa> motech?
|
15:09:11
|
<dkayiwa> Reviewed and tested: Small fixes for newpatient.form - TRUNK-198
|
15:09:11
|
<dkayiwa> Back ported to 1.9.x: Avoid Duplicate Rows in Patient_State Table - TRUNK-2273
|
15:09:12
|
<dkayiwa> Back ported to 1.9.x: Fix validation logic for Openmrs Objects in controllers - TRUNK-3002
|
15:09:12
|
<dkayiwa> Back ported to 1.9.x a commit for: AuditableInterceptor fails with a NPE at startup if there are scheduled tasks to run at startup - TRUNK-2903
|
15:09:12
|
<dkayiwa> Back ported to 1.9.x and closed: Implement voiding of PersonNames - TRUNK-2198
|
15:09:13
|
<dkayiwa> Back ported to 1.9.x: Determine correct length for datatype and handler config hibernate properties - TRUNK-3029
|
15:09:13
|
<dkayiwa> Back ported to 1.9.x: Add logging table for merged patients - TRUNK-37
|
15:09:13
|
<dkayiwa> Back ported to 1.9.x: JspException thrown on clicking the Visits category under settings - TRUNK-3055
|
15:09:13
|
<dkayiwa> No Blockers
|
15:09:25
|
<rafa> Today:
|
15:09:25
|
<rafa> * Finished TRUNK-3069: Rename AdministrationService.validateInManualFlushMode, and refactor it and ValidateUtil
|
15:09:25
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3069
|
15:09:25
|
<rafa> * Committed TRUNK-3057: Creating concept mappings fails with legacy code
|
15:09:25
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3057
|
15:09:26
|
<rafa> * Picked up STAND-36: Automatically create MVP/CIEL dictionary-based dataset as part of the standalone build process
|
15:09:26
|
<rafa> https://tickets.openmrs.org/browse/STAND-36
|
15:09:27
|
<rafa> No blockers.
|
15:09:43
|
<wyclif> yesterday:
|
15:09:43
|
<wyclif> * dev call
|
15:09:43
|
<wyclif> * Completing work on datebased results
|
15:09:43
|
<wyclif> * TODOs for TRUNK-3001 - Add initialization/update wizard messages for languages other than english
|
15:09:43
|
<wyclif> * TRUNK-198 - Small fixes for newpatient.form
|
15:09:43
|
<wyclif> today:
|
15:09:45
|
<wyclif> * TRUNK-3049 - UGLY screen in init wizard
|
15:09:47
|
<wyclif> * Create tickets for pending tasks for logic 2.0 module
|
15:09:49
|
<wyclif> * Create wiki page for developer documentation for logic 2.0 module
|
15:09:51
|
<wyclif> Blockers: none
|
15:10:31
|
<wyclif> dkayiwa, i made a fix for TRUNK-198, thanks for figuring that out with me
|
15:10:31
|
<djazayeri> you all need to paste your reports a bit more slowly :-)
|
15:10:45
|
<rafa> djazayeri: use scroll :P
|
15:11:00
|
<djazayeri> yeah, but I don't believe you read dkayiwa's report before you pasted yours. :-P
|
15:11:01
|
<bwolfe> haha
|
15:11:15
|
<dkayiwa> :D
|
15:11:25
|
<rafa> djazayeri: okay you got me :P
|
15:12:16
|
<bwolfe> worlds fastest reader...
|
15:12:23
|
<djazayeri> rafa: motech is a project by the Grameen Foundation "Mobile Technology for Community Health"
|
15:12:40
|
<djazayeri> (also by Columbia University)
|
15:12:45
|
<wyclif> do you guys still get notifications from jira e.g about tickets comments, status changes etc, because i dont
|
15:12:46
|
<bwolfe> they have some mobile clients and their own server of sorts
|
15:12:49
|
<rafa> djazayeri: thx just googled it ;)
|
15:12:59
|
<bwolfe> wyclif, as of when?
|
15:13:07
|
<wyclif> its bee a while
|
15:13:16
|
<wyclif> probably the whole of this week
|
15:13:27
|
<rafa> I do get them
|
15:13:58
|
<djazayeri> Yeah, I'm getting them (and tons of them with dkayiwa closing all these tickets...)
|
15:14:01
|
<wyclif> forinstance someone closed TRUNK-3001 and i got no notification
|
15:14:25
|
<wyclif> may be i changed my email setting my mistake and they are being moved to junk
|
15:14:32
|
<djazayeri> that said, I sometimes feel like I don't get *all* the JIRA emails. Sometimes I'll get a Closed without a Comment, or vice versa.
|
15:14:52
|
<wyclif> and you all still get svn updates?
|
15:15:06
|
<wyclif> because i dont get those either
|
15:15:18
|
<bwolfe> what do you mean by svn update?
|
15:15:34
|
<djazayeri> !scrumoff
|
15:15:34
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:15:37
|
<bwolfe> yes, I seem to lose some jira emails as well. but is mainly in the ITSM project
|
15:15:42
|
<bwolfe> ah yes, thanks for the scrumoff
|
15:16:05
|
<wyclif> i have noticed they are in junk
|
15:16:19
|
<wyclif> hmm, i wonder how i set this
|
15:17:46
|
<djazayeri> dkayiwa: do you have the "tickets that need to be closed to release 1.9 RC" jira query/filter?
|
15:18:55
|
*** dkayiwa has quit IRC
|
15:19:57
|
<djazayeri> oops, lost dkayiwa
|
15:21:28
|
<djazayeri> bwolfe, wyclif, rafa: any discussion points?
|
15:21:55
|
<rafa> djazayeri: I don't finish with STAND-36 before the RC.
|
15:22:05
|
<rafa> djazayeri: I guess it shouldn't be a problem
|
15:22:19
|
<rafa> djazayeri: if the RC is supposed to go out today.
|
15:22:26
|
<djazayeri> rafa: I think STAND-36 is arguably a blocker for the RC
|
15:22:42
|
<djazayeri> when do you think it'll be done?
|
15:23:25
|
<djazayeri> I guess that in theory we could release an RC without the MVP dictionary, and then rebuild just the standalone when we do the real release...
|
15:23:27
|
<rafa> djazayeri: It depends if we want to have all concepts valid or it's okay to have some invalid
|
15:23:41
|
<djazayeri> rafa: gotta get them valid.
|
15:23:47
|
<djazayeri> how many are left?
|
15:23:56
|
<djazayeri> and is it something that you have to do, or can be parallelized?
|
15:24:22
|
<rafa> djazayeri: I got an updated dict from Andy that I need to validate again
|
15:24:56
|
<rafa> djazayeri: I don't know what will be the result
|
15:25:17
|
<djazayeri> ah, and that's going to take a full day to run the validation, right?
|
15:25:40
|
<rafa> djazayeri: not I tweaked the validation tool so it's a few hours now
|
15:26:18
|
<rafa> djazayeri: but the dict I got from Andy has some references to non existing users
|
15:26:29
|
<rafa> djazayeri: I need to clean it up
|
15:27:05
|
<djazayeri> rafa: yeah, do something like: update concept* set creator|changed_by = 1 where creator|changed_by is not null
|
15:27:37
|
<djazayeri> rafa: anyway, so I imagine you'll leave the tool validating when you stop working for the day?
|
15:27:38
|
<rafa> does * work?
|
15:27:44
|
<djazayeri> no
|
15:27:48
|
<rafa> :(
|
15:27:49
|
<djazayeri> I wish it did
|
15:27:53
|
<rafa> me too
|
15:27:58
|
<sgithens> What do these '^99DCT' suffixes on openmrs_concept attributs in xform definitions signify?
|
15:28:11
|
<rafa> djazayeri: yes, that's the plan
|
15:28:40
|
<djazayeri> rafa: okay, once you've got the list of SQL commands for this, can you put them on the wiki
|
15:29:08
|
<rafa> djazayeri: cool
|
15:29:20
|
<djazayeri> make a "Helpful SQL scripts" page
|
15:30:33
|
<djazayeri> rafa: anyway, send an email tomorrow morning just summarizing the outcome of the validation
|
15:30:38
|
<djazayeri> and we'll figure out where to go from there
|
15:30:51
|
<djazayeri> I guess it's okay to release the RC without the MVP dictionary, but not the final release
|
15:31:34
|
<djazayeri> sgithens: It means that the naming authority is "99DCT", where I think the 99 is the prefix for "other" or "user-defined", and DCT is short for "Dictionary"
|
15:33:48
|
<sgithens> djazayeri: Ah. So, in the event that two different installations had different concept ID's for the same thing because they were using a different naming authority, you could eventually go back and map similar concepts between naming authorities and eventually link them back up?
|
15:33:58
|
<djazayeri> sgithens: well, no
|
15:34:46
|
<djazayeri> sgithens: my concept ID #1 is likely different from yours, and if you somehow submitted an xform constructed on your server to my server, that would be bad
|
15:34:50
|
*** r4friedman has joined #openmrs
|
15:35:04
|
<r4friedman> nick r.friedman
|
15:35:25
|
<r4friedman> bwolfe: hi ben, got a minute?
|
15:36:08
|
<bwolfe> r4friedman, maybe even 2 minutes
|
15:36:16
|
<r4friedman> great
|
15:36:35
|
<r4friedman> i was looking at order/drugorder, in which you and djazayeri had a hand
|
15:36:55
|
<r4friedman> it seems to me that ordertype is acting sort of like a discriminator
|
15:36:56
|
<djazayeri> r4friedman: new design, or existing?
|
15:37:01
|
<r4friedman> existing
|
15:37:16
|
<r4friedman> so get/setordertype oughtn't act the usual way
|
15:37:19
|
*** djazayeri has left #openmrs
|
15:37:28
|
<bwolfe> what do you mean usual way ?
|
15:37:29
|
*** djazayeri has joined #openmrs
|
15:37:35
|
*** ChanServ sets mode: +o djazayeri
|
15:37:43
|
<r4friedman> take what's sent and stuff it in there
|
15:37:48
|
<sgithens> djazayeri: Is the naming authority responsible for actually maintaining the Id's and UUID's for their dictionary of concepts? I guess I'm assuming their role is to maintain their specific concept dictionary.
|
15:38:42
|
<r4friedman> because once it's saved, there will be consequences for the subclass tables
|
15:38:43
|
<djazayeri> (sorry, I accidentally quite IRC so I missed a few messages. r4friedman, what did you say between "so get/setordertype oughtn't" and "take what's sent..."?
|
15:39:00
|
<r4friedman> djazayeri: also u missed sgithens long piece
|
15:39:32
|
<bwolfe> r4friedman, if we're defining that in hibernate, then yes, its a bigger deal
|
15:39:40
|
<r4friedman> setordertype oughtn't work if the object is a subclass of order because of the consequences
|
15:39:50
|
<bwolfe> with concepts/concept_numeric, hibernate actually looks for a row in concpet_numeric, iirc
|
15:40:19
|
<djazayeri> sgithens: the specific naming authority of "99DCT" is a bit of a hack that means "my local dictionary". If we were saying "SNM" (e.g. snomed), that's a reference to a real naming authority. 99DCT isn't _really_ a naming authority.
|
15:41:23
|
<r4friedman> bwolfe: so you are saying that Hibernate knows that ID x is a drugorder even if you do setobjecttype=(DIETORDER)
|
15:41:28
|
<sgithens> djazayeri: Nice. :) These naming authorities are a general medical thing though right? Not just for OpenMRS, you might use a particular naming authority for any number of medical systesm to denote concepts?
|
15:41:50
|
<bwolfe> r4friedman, if I'm remembering right, yes. let me look at the mappings real quick
|
15:42:55
|
<djazayeri> sgithens: well, that's the theory. There are "authorities" for different things. SNOMED and ICD for concepts.
|
15:43:08
|
<bwolfe> r4friedman, looking at Order.hbm.xml, the descriminator is not set to the order type
|
15:43:20
|
<djazayeri> Someone might have a registry of providers, locations, etc, that's published as an authority
|
15:43:30
|
<djazayeri> sgithens: HL7 lets you refer to those things
|
15:43:37
|
<r4friedman> bwolfe: right, it was autogenerated -- but it doesn't matter per hibernate manual
|
15:43:52
|
<bwolfe> r4friedman, so if you tell hibernate to print out its queries and then do a GET on an order, you will see it doing a lookup to know if there is a row in drug_order with the same id
|
15:44:06
|
<djazayeri> sgithens: but (for now) OpenMRS only supports HL7 messages referring to your local dictionary
|
15:44:20
|
<sgithens> djazayeri: Ah, ok.
|
15:44:39
|
<r4friedman> i think problem is other direction. If ordertype=DRUG then there is a drugorder table with the drugorder fields
|
15:44:44
|
<djazayeri> sgithens: though given that we support concept mappings, it would be doable to handle concept codes from another authority
|
15:44:54
|
<r4friedman> bwolfe: that is, if I created a drugorder
|
15:45:37
|
<r4friedman> but if i then change it to laborder, then i try to do laborder methods and there is no laborder record
|
15:46:32
|
<r4friedman> bwolfe: of course, there is isDrugOrder, but that's only good for drug orders and can't change
|
15:47:35
|
<r4friedman> bwolfe: i guess you could do something like mysteryOrder.class.getName() or whatever the right method is
|
15:47:44
|
<sgithens> So, should it be possible to create an entire form from scratch (or by duplicating Basic) right now usign the GWT XForm Designer? I'm sort going through the corresponding xform xml from a big existing form, and comparing it with the UI trying to figure out how to set various things.
|
15:48:13
|
<djazayeri> sgithens: yeah, you should definitely use the designer to build your xform
|
15:48:25
|
<bwolfe> r4friedman, correct, we need a way to clean out the drug_order table row and create a lab_order row. the concept/conceptNumeric has special logic for this
|
15:48:46
|
<bwolfe> sgithens, wouldn't htmlformentry be easier for you? why are you using xforms?
|
15:49:10
|
* bwolfe wants all AMPATH forms to be turned into htmlforms (instead of infopath forms and/or xforms)
|
15:50:06
|
<r4friedman> bwolfe: of course the idea is you can't change orders once they're ordered, you can only discontinue them and write a new one
|
15:50:41
|
<sgithens> bwolfe: I think we're using XForm for our other forms. Also... I don't know, it seems like just pumping stuff into HTMLforms lacks some of the rigor and spec you might get from XForms?
|
15:50:44
|
<r4friedman> bwolfe: but maybe we could allow an order to be deleted before it's persisted
|
15:53:30
|
<r4friedman> bwolfe: if i do getOrder(x) and x is a drug order, I get an object with data elements from both parts, right?
|
15:53:51
|
<sgithens> bwolfe: I'm happy to try them both for this first form though.
|
15:54:26
|
<r4friedman> bwolfe: there's no way I can do something like (Order) getOrder(x) and just get the order part
|
15:54:40
|
<bwolfe> sgithens, I looked at the form with ada. looks pretty small. doing it in both seems doable. :-)
|
15:54:57
|
<r4friedman> sgithens: twice the progress
|
15:55:20
|
<bwolfe> r4friedman, I don't remember hte old api. but yes, since DrugOrder extends Order, when you get back a DrugOrder you can be guaranteed it is an Order as well
|
15:55:46
|
<sgithens> bwolfe: Yeah, it'll be a good way to get familier with them both. I'm not necessarily a huge fan of sprawling w3c xml specs, but it seems like there is useful tooling their for folks that don't spend all day in a text editor. :)
|
15:55:47
|
<bwolfe> sgithens / r4friedman: Why do it once when you can do it twice at double the cost (time).
|
15:56:01
|
<sgithens> s/their/there/
|
15:56:19
|
<r4friedman> bwolfe: yeah, but I'm trying to make sure that you can't get just the order and mung the order type if the subclass doesn't want you to
|
15:57:20
|
<bwolfe> r4friedman, I THINK, if you cast something to an Order and call setOrderType() it will still call DrugOrder.setOrderType first (if it exists)
|
15:58:12
|
<r4friedman> bwolfe: my logic too. why did you decide that the drugorder constructor would not set the order type?
|
15:58:54
|
<bwolfe> is that order type available?
|
15:59:08
|
<bwolfe> we didn't start hard coding *types until recently
|
15:59:28
|
<r4friedman> bwolfe: probably would need to become a global property or a "known" value like yes/no
|
16:01:20
|
<bwolfe> rafa, which patient did you use?
|
16:01:28
|
<bwolfe> (for the slow-to-load-dashboard)
|
16:01:33
|
<bwolfe> r4friedman, bleh
|
16:01:48
|
<rafa> bwolfe: I didn't have any
|
16:01:52
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @cdparra Thanks for taking a look! #OpenMRS <http://twitter.com/OpenMRS/statuses/173072335325237248>
|
16:01:53
|
<rafa> bwolfe: I used newly created
|
16:01:55
|
<bwolfe> I wish we had a better way of doing things like this. just feels wrong, but we don't have a better way
|
16:02:24
|
<bwolfe> rafa, loading takes 4 seconds for me. and thats with concept name updating happening in the bg
|
16:02:46
|
<rafa> bwolfe: that's good I guess
|
16:02:53
|
<rafa> bwolfe: it must be something with my db
|
16:03:06
|
<r4friedman> bwolfe: yah, too bad the original programmers are still working here, otherwise we could blame them
|
16:03:36
|
<r4friedman> bwolfe: although we surely can blame burke
|
16:05:04
|
<bwolfe> its always easy to blame burke...
|
16:05:59
|
<bwolfe> (and occasionally accurate)
|
16:09:22
|
<djazayeri> rafa: can you run with the debugger and see *which* concepts are being looked up by name?
|
16:09:39
|
<djazayeri> and then check whether there are any dashboard-related global properties with those names?
|
16:18:19
|
*** bwolfe_ has joined #openmrs
|
16:18:19
|
*** ChanServ sets mode: +o bwolfe_
|
16:18:36
|
*** bwolfe has quit IRC
|
16:18:38
|
*** bwolfe_ is now known as bwolfe
|
16:33:02
|
*** r4friedman has quit IRC
|
16:38:15
|
*** suranga has joined #openmrs
|
16:41:49
|
<suranga> hi james_regen
|
16:42:37
|
<djazayeri> rafa: when was the last time you presented MDS on the dev call or the Implementers call?
|
16:43:20
|
<rafa> djazayeri: at the end of december
|
16:54:04
|
<james_regen> suranga: hi
|
17:03:55
|
<djazayeri> bwolfe: any thoughts about things that need fixing before releasing alpha of the Reporting REST module?
|
17:04:08
|
<djazayeri> We need to make sure the hrefs are right.
|
17:08:59
|
*** bwolfe has quit IRC
|
17:17:20
|
*** mnunez has joined #openmrs
|
17:17:51
|
<mnunez> Hi everyone!
|
17:19:14
|
<mnunez> rafa: have you noticed that when in the MDS, the size of the navigation bar changes? Fonts get bigger, at least in both my OMRS versions.
|
17:19:46
|
<mnunez> rafa: In one of them, I have so many modules installed that the navigation bar actually disappears.
|
17:22:36
|
*** bwolfe has joined #openmrs
|
17:22:38
|
*** ChanServ sets mode: +o bwolfe
|
17:33:54
|
*** batkinson has joined #openmrs
|
17:49:38
|
*** suranga has quit IRC
|
18:02:03
|
*** rafa has quit IRC
|
18:06:51
|
<bwolfe> djazayeri, check the TODOs in the code
|
18:07:33
|
*** magicaltrout has quit IRC
|
18:07:38
|
*** magicaltrout has joined #openmrs
|
18:20:47
|
<djazayeri> bwolfe: will do
|
18:37:09
|
*** rafa has joined #openmrs
|
18:37:09
|
*** ChanServ sets mode: +v rafa
|
18:37:15
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Video: #OpenMRS co-founder @pbiondich speaks on #HealthIT in underserved populations http://t.co/nZ2H1tqT #ICT4D #eHealth <http://twitter.com/OpenMRS/statuses/173108599277621248>
|
18:57:53
|
<wyclif> hi ben
|
18:58:02
|
<wyclif> hi bwolfe
|
19:01:35
|
<sgithens> oh i see, there is a wysiwyg editor the html forms too
|
19:07:36
|
*** mvorobey has joined #openmrs
|
19:07:46
|
<mvorobey> hi all
|
19:14:40
|
<mnunez> rafa: Do you have a minute?
|
19:14:50
|
<mnunez> mvorobey: hi
|
19:41:52
|
*** robbyoconnor has joined #openmrs
|
19:41:52
|
*** ChanServ sets mode: +v robbyoconnor
|
19:42:35
|
*** robbyoconnor has quit IRC
|
19:42:47
|
*** robbyoconnor has joined #openmrs
|
19:42:47
|
*** ChanServ sets mode: +v robbyoconnor
|
19:48:36
|
*** bwolfe has quit IRC
|
19:53:57
|
*** mvorobey has quit IRC
|
19:57:52
|
*** james_regen has left #openmrs
|
19:59:30
|
*** mvorobey has joined #openmrs
|
20:03:00
|
*** bwolfe has joined #openmrs
|
20:03:00
|
*** ChanServ sets mode: +o bwolfe
|
20:34:56
|
*** mnunez has quit IRC
|
20:37:18
|
<wyclif> hi rafa
|
20:37:31
|
<wyclif> did you back port TRUNK-3057?
|
20:42:47
|
* downey hears the BP word and covers his ears
|
20:52:55
|
*** mvorobey_ has joined #openmrs
|
20:53:02
|
<downey> Hi mvorobey_ and welcome to the #openmrs IRC channel.
|
20:53:15
|
*** mvorobey has quit IRC
|
21:00:46
|
*** chopin_ has quit IRC
|
21:15:04
|
*** mvorobey_ has quit IRC
|
21:24:25
|
*** mvorobey has joined #openmrs
|
21:43:39
|
*** downey_ has joined #openmrs
|
21:43:39
|
*** ChanServ sets mode: +o downey_
|
21:46:19
|
*** downey has quit IRC
|
21:46:19
|
*** downey_ is now known as downey
|
21:59:38
|
*** bwolfe has quit IRC
|
21:59:41
|
*** bwolfe_ has joined #openmrs
|
21:59:41
|
*** ChanServ sets mode: +o bwolfe_
|
22:02:54
|
*** bryq has joined #openmrs
|
22:02:54
|
*** ChanServ sets mode: +v bryq
|
22:04:17
|
*** bwolfe_ has quit IRC
|
22:11:45
|
*** downey has quit IRC
|
22:18:35
|
*** robbyoconnor has quit IRC
|
22:33:55
|
*** sgithens has quit IRC
|
22:58:45
|
*** bryq has quit IRC
|
23:17:12
|
*** wyclif has quit IRC
|
23:37:23
|
*** rafa has quit IRC
|
23:53:10
|
*** mvorobey has quit IRC
|