| 00:22:24 | *** djazayeri has quit IRC |
| 00:28:12 | *** djazayeri has joined #openmrs |
| 00:28:12 | *** zelazny.freenode.net sets mode: +o djazayeri |
| 00:43:20 | *** wyclif has joined #openmrs |
| 01:21:53 | *** dewmal has joined #openmrs |
| 01:27:37 | *** pterminator has joined #openmrs |
| 02:06:34 | *** bwolfe has joined #openmrs |
| 02:06:34 | *** ChanServ sets mode: +o bwolfe |
| 02:08:11 | *** chopin has joined #openmrs |
| 02:46:31 | *** dewmal has quit IRC |
| 02:50:25 | <pterminator> Hi, I'm working on an introductory ticket - TRUNK-2452, and I ran into something I don't understand. Does someone have time to take a look? |
| 03:06:24 | <pterminator> OK, I'm just going to ask - hopefully someone will see eventually :) |
| 03:06:38 | <pterminator> Here's the code: http://pastebin.com/EdAnEtSq |
| 03:10:28 | <pterminator> I created a getter on Extension called getOrder, and implemented it on two Extension classes in a test module. In the code listing, sorting does not appear to have any effect. I did some debugging, and getOrder() calls the Extension version - not the version in my subclass. |
| 03:12:23 | <pterminator> I wrote a test to recreate the sorting, and it called the subclass getOrder() as I expected. Just doesn't do it when running in Jetty. |
| 03:13:13 | <pterminator> BTW, the code listing is a modification of ModuleFactory#startModuleInternal for TRUNK-2452 |
| 03:14:40 | *** chopin has quit IRC |
| 03:20:29 | *** chopin has joined #openmrs |
| 03:33:30 | <pterminator> Gotta go - guess I'll try back a different time. |
| 03:35:51 | *** pterminator has left #openmrs |
| 03:42:04 | *** upul` has joined #openmrs |
| 03:42:04 | *** ChanServ sets mode: +v upul` |
| 04:06:41 | *** bwolfe has quit IRC |
| 04:23:05 | *** sunbiz has joined #openmrs |
| 04:23:05 | *** ChanServ sets mode: +v sunbiz |
| 04:31:18 | *** chopin has quit IRC |
| 05:01:23 | *** suranga has joined #openmrs |
| 06:01:19 | *** dkayiwa has joined #openmrs |
| 06:09:37 | *** sunbiz has quit IRC |
| 06:35:05 | *** sunbiz has joined #openmrs |
| 06:35:05 | *** ChanServ sets mode: +v sunbiz |
| 06:39:15 | *** sunbiz has quit IRC |
| 08:16:00 | *** bryq has joined #openmrs |
| 08:16:00 | *** ChanServ sets mode: +v bryq |
| 08:27:11 | *** rafa has joined #openmrs |
| 08:27:11 | *** ChanServ sets mode: +v rafa |
| 08:31:15 | *** dkayiwa has quit IRC |
| 08:32:37 | *** dkayiwa has joined #openmrs |
| 08:54:24 | *** dkayiwa has quit IRC |
| 09:07:16 | *** suranga_ has joined #openmrs |
| 09:10:35 | *** suranga has quit IRC |
| 09:42:56 | *** upul` has quit IRC |
| 11:02:47 | *** suranga_ has quit IRC |
| 11:14:27 | *** bryq has quit IRC |
| 11:56:44 | *** akhil_ has joined #openmrs |
| 12:06:16 | *** james_regen has joined #openmrs |
| 12:06:16 | *** ChanServ sets mode: +v james_regen |
| 12:41:58 | *** bwolfe has joined #openmrs |
| 12:41:58 | *** ChanServ sets mode: +o bwolfe |
| 12:43:55 | *** chopin has joined #openmrs |
| 12:59:15 | *** wyclif has quit IRC |
| 13:08:06 | *** chopin has quit IRC |
| 13:08:21 | *** chopin has joined #openmrs |
| 13:20:05 | *** sunbiz has joined #openmrs |
| 13:20:05 | *** ChanServ sets mode: +v sunbiz |
| 13:22:01 | *** sunbiz has left #openmrs |
| 13:33:59 | *** ChanServ sets mode: +v chopin |
| 13:34:19 | *** wyclif has joined #openmrs |
| 13:34:32 | *** wyclif has joined #openmrs |
| 13:35:16 | *** mvorobey has joined #openmrs |
| 13:35:21 | <mvorobey> hi all |
| 13:38:20 | *** sgithens has joined #openmrs |
| 13:42:08 | *** dkayiwa has joined #openmrs |
| 13:56:39 | *** downey has joined #openmrs |
| 13:56:39 | *** ChanServ sets mode: +o downey |
| 13:56:39 | *** OpenMRSBot sets mode: +o downey |
| 14:04:11 | *** akhil_ has quit IRC |
| 14:14:51 | <OpenMRSBot> Recent updates in the world of openmrs: Implementer ML: Translation to french help is needed <https://listserv.iupui.edu/cgi-bin/wa-iupui.exe?A2=ind1202&L=openmrs-implement-l&P=71158> |
| 14:19:44 | *** chopin_ has joined #openmrs |
| 14:20:18 | *** chopin has quit IRC |
| 14:35:12 | <bwolfe> hi mvorobey (a late hello) |
| 14:39:59 | <mvorobey> bwolfe: hi Ben ! that is good-good :) it's better to do it later then never :D |
| 14:42:30 | *** pterminator has joined #openmrs |
| 14:42:37 | <downey> Hi pterminator and welcome to the #openmrs IRC channel. |
| 14:43:13 | <pterminator> Hi |
| 14:44:35 | <pterminator> I have a question about a ticket I'm working on... Anyone have time to help? |
| 14:54:47 | <dkayiwa> pterminator: just ask and anyone can answer |
| 14:56:47 | <pterminator> I'm trying to sort extensions for a given extension point before display, and I added a new property to the Extension class that can be overridden in subclasses. |
| 14:57:54 | <pterminator> I put everything in a collection, and call Collections.sort, passing a comparator that looks to the new 'order' property. |
| 14:58:10 | *** james_regen has left #openmrs |
| 14:59:40 | <pterminator> The problem is, Extension.getOrder is called instead of ExtImpl.getOrder, so nothing sorts. |
| 15:03:21 | *** wyclif has quit IRC |
| 15:03:36 | *** wyclif has joined #openmrs |
| 15:04:26 | *** bwolfe has quit IRC |
| 15:05:16 | *** chopin_ has quit IRC |
| 15:05:57 | <pterminator> I set up a test case that just creates new instances of Extension subclasses (simply using new), adds them to a list, and sorts using the same comparator. That works as I'd expect, calling the subclass's getOrder, and sort succeeds. I get the unexpected behavior when running the full webapp under Jetty. |
| 15:06:09 | *** chopin_ has joined #openmrs |
| 15:09:33 | *** dkayiwa has quit IRC |
| 15:11:16 | *** mccallumg has joined #openmrs |
| 15:11:16 | *** ChanServ sets mode: +v mccallumg |
| 15:12:05 | *** james_regen has joined #openmrs |
| 15:12:05 | *** ChanServ sets mode: +v james_regen |
| 15:19:53 | *** bwolfe has joined #openmrs |
| 15:19:53 | *** ChanServ sets mode: +o bwolfe |
| 15:25:55 | *** bwolfe_ has joined #openmrs |
| 15:25:55 | *** ChanServ sets mode: +o bwolfe_ |
| 15:28:55 | *** bwolfe has quit IRC |
| 16:07:29 | *** bwolfe__ has joined #openmrs |
| 16:07:29 | *** bwolfe_ has quit IRC |
| 16:08:24 | <djazayeri> pterminator: you still have that question? |
| 16:09:14 | *** chopin_ has quit IRC |
| 16:10:52 | <pterminator> I have an idea of what my problem might be. I'll let you know whether I'm able to fix it soon. |
| 16:10:58 | <djazayeri> ok |
| 16:32:52 | <pterminator> I figured it out. I must have had an error somewhere along the line when I first updated the module I'm using for testing. Therefore, I was using old module code that didn't override the new method I'm testing. It's working nicely now. |
| 16:43:42 | *** dkayiwa has joined #openmrs |
| 16:50:04 | *** mccallumg has quit IRC |
| 16:54:41 | <dkayiwa> rafa: am trying to upgrade a 1.6 MVP database to 1.10 to look into TRUNK-3068 but it is taking ages. was it the same with you? |
| 16:54:51 | *** mccallumg has joined #openmrs |
| 16:54:51 | *** ChanServ sets mode: +v mccallumg |
| 17:06:08 | <rafa> dkayiwa: yes, it's a long process |
| 17:06:29 | <rafa> dkayiwa: but it shouldn't take more than a few hours |
| 17:06:38 | <dkayiwa> rafa: do you have a database script i can just run? |
| 17:07:36 | <dkayiwa> rafa: how are the 1.9 tickets going? :) |
| 17:07:50 | <rafa> dkayiwa: I could send you a dump of my db, but it would be better if you actually upgrade it |
| 17:08:15 | <rafa> dkayiwa: because I may have broken something in my db |
| 17:08:16 | <dkayiwa> rafa: why would it be better to upgrade than use your dump? :) |
| 17:08:24 | <rafa> dkayiwa: and that's why it's getting that long |
| 17:08:25 | <dkayiwa> rafa: oh i see!!! |
| 17:08:35 | *** bwolfe__ has quit IRC |
| 17:12:29 | <rafa> dkayiwa: you won't be happy with my progress |
| 17:12:42 | <dkayiwa> rafa: oh why? :) |
| 17:12:44 | <rafa> dkayiwa: I worked almost all day on TRUNK-3069 |
| 17:13:03 | <rafa> dkayiwa: but I fixed the search widget |
| 17:13:17 | <dkayiwa> rafa: looking at its complexity, i think it is worth it. :D |
| 17:14:41 | <rafa> dkayiwa: well the solution in TRUNK-3069 is pretty neat and not that complex |
| 17:14:51 | <rafa> dkayiwa: but it took hours to come to that |
| 17:14:52 | <dkayiwa> rafa: one small thing on the search widget ticket is that after typing empty space, pressing back space triggers a searcg |
| 17:14:52 | <dkayiwa> search |
| 17:14:52 | <dkayiwa> rafa: but i think we can ignore that for now :) |
| 17:14:58 | *** suranga has joined #openmrs |
| 17:15:21 | <rafa> dkayiwa: oh really? |
| 17:15:31 | <rafa> dkayiwa: I thought I tested that |
| 17:15:44 | <dkayiwa> rafa: the beauty is that you atleast ended with something neat |
| 17:16:14 | <rafa> dkayiwa: I need to go eat :D |
| 17:16:22 | <rafa> ttyl |
| 17:16:23 | <dkayiwa> rafa: backspace to clear the empty space always triggers a search yet when the search text has not changed |
| 17:16:24 | <dkayiwa> rafa: dinner??? :) |
| 17:16:30 | <rafa> yeah |
| 17:17:02 | <dkayiwa> rafa: who prepares it for you? |
| 17:17:06 | <dkayiwa> :) |
| 17:17:25 | <rafa> myself or some random people :D |
| 17:17:42 | <rafa> today myself |
| 17:17:44 | <dkayiwa> rafa: random people (gal friends?) :) |
| 17:18:09 | <rafa> dkayiwa: haha guys frum pizza or any other place ;) |
| 17:18:16 | <dkayiwa> rafa: oh i see :) |
| 17:18:29 | <dkayiwa> rafa: ok go enjoy it before it gets cold :) |
| 17:18:36 | <rafa> thx! |
| 17:36:30 | *** dewmal has joined #openmrs |
| 17:37:15 | *** dewmal has quit IRC |
| 17:39:04 | *** suranga_ has joined #openmrs |
| 17:42:08 | *** suranga has quit IRC |
| 17:46:21 | *** chopin_ has joined #openmrs |
| 17:51:04 | *** bwolfe__ has joined #openmrs |
| 18:00:03 | *** suranga__ has joined #openmrs |
| 18:03:02 | *** bryq has joined #openmrs |
| 18:03:02 | *** ChanServ sets mode: +v bryq |
| 18:04:21 | *** suranga_ has quit IRC |
| 18:04:38 | *** bwolfe__ is now known as bwolfe |
| 18:04:41 | *** ChanServ sets mode: +o bwolfe |
| 18:06:12 | *** rafa has quit IRC |
| 18:08:46 | *** pterminator has left #openmrs |
| 18:09:27 | <suranga__> james_regen, heloo |
| 18:09:33 | <suranga__> :) |
| 18:21:14 | <OpenMRSBot> Recent updates in the world of openmrs: Developer ML: Feedback on OpenMRS REST web service module <https://listserv.iupui.edu/cgi-bin/wa-iupui.exe?A2=ind1202&L=openmrs-devel-l&P=142992> || On Twitter: OpenMRS: Bridging the gap between doctors and hackers to upgrade health care http://t.co/K2ZdMu2z #HealthIT #eHealth <http://twitter.com/OpenMRS/statuses/172724197515202562> || On Twitter: OpenMRS: RT @djazayeri: We have a working prototype of an #OpenMRS reporting #Pentaho PDI plugin! See it on our dev call tomorrow: https://t.co/4 ... <http://twitter.com/OpenMRS/statuses/172723257932394496> || OpenMRS Modules: Metadata Sharing 1.0.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=metadatasharing&version=&1.0.1> |
| 18:22:46 | <james_regen> suranga__: hi |
| 18:23:00 | <suranga__> howdy james_regen ! |
| 18:23:19 | <suranga__> today, im afaid I have a small problem for you.... |
| 18:23:30 | <suranga__> hoping u sould help me out with it.... |
| 18:23:38 | <suranga__> *hoping u could |
| 18:30:52 | *** rafa has joined #openmrs |
| 18:30:52 | *** ChanServ sets mode: +v rafa |
| 18:39:27 | *** mccallumg has left #openmrs |
| 18:40:14 | <james_regen> suranga__: sure. sorry, got distracted by some other work. what's the problem? |
| 18:40:44 | <suranga__> no worries, im recreatig my problem actually... |
| 18:55:11 | *** mvorobey has quit IRC |
| 19:01:15 | *** bwolfe has quit IRC |
| 19:02:21 | *** bwolfe has joined #openmrs |
| 19:02:21 | *** ChanServ sets mode: +o bwolfe |
| 19:05:04 | <suranga__> hi james_regen :) |
| 19:05:16 | <suranga__> so my (really silly) question is... |
| 19:05:17 | <suranga__> this is my problem... |
| 19:05:18 | <suranga__> Im generating a report using a user defined strategy. |
| 19:05:18 | <suranga__> I need to intercept the patient id pairs, and list 'true' or 'false' in front of each column. |
| 19:05:18 | <suranga__> I can get the patient id pairs easily using pair[0].getDemographic("org.openmrs.Patient.personId") |
| 19:05:18 | <suranga__> but my problem is, how to retreive the scores (true, false etc. etc.) for the columns. |
| 19:05:19 | <suranga__> I tried scorepair.getObservedVectors(); |
| 19:05:21 | <suranga__> is this the right choice ? |
| 19:07:13 | <james_regen> what does that method return: |
| 19:07:16 | <james_regen> ? |
| 19:08:32 | <suranga__> let me get u some data... :) |
| 19:08:39 | * suranga__ goes to look |
| 19:10:31 | <james_regen> scorePair returns a MatchResult object when it compares records. a score is in there, as well as some other stuff. getting observed vectors should, at the end of the run, tell you things like how many of each different vector you've seen. you should be able to get the scores from there, or at least the number of different scores, but not information like "pair 24 had a score of 12" |
| 19:18:48 | *** mnunez has joined #openmrs |
| 19:18:59 | *** rafa has quit IRC |
| 19:22:24 | <suranga__> james_regen, mmm.... my problem is like this.... |
| 19:22:28 | <suranga__> hi, |
| 19:22:29 | <suranga__> its like this. Assuming i have 5 matching recordpairs. |
| 19:22:29 | <suranga__> therefore, my thought is that the scorepair class will generate five sets of 'yes', 'no' strings. (one scorepair value per each record pair.) |
| 19:22:29 | <suranga__> However, it seems the display only two data sets. (and not five) |
| 19:22:29 | <suranga__> im getting something like 'true', 'true' and 'true', 'false'. just this two, nothing more |
| 19:24:45 | <james_regen> are the two datasets from a getObservedVectors() method call? |
| 19:24:57 | *** rafa has joined #openmrs |
| 19:24:57 | *** ChanServ sets mode: +v rafa |
| 19:24:59 | <james_regen> or from the different MatchResult objects that is returned five times? |
| 19:25:21 | <suranga__> from a getObservedVectors() |
| 19:25:22 | <suranga__> method |
| 19:25:50 | <suranga__> basically i need to retreive something like pair[o] true|true|false|true |
| 19:28:05 | <james_regen> okay. getObservedVectors returns a hashtable of how commong different vectors were. i'd guess you saw two different vectors returned because of the 5 pairs, there were only two ways the fields happened to agree and disagree |
| 19:28:25 | <suranga__> oooops... |
| 19:28:42 | <suranga__> james_regen, i seem to make many embarassing mistakes :) |
| 19:29:15 | <james_regen> no problem, there are lots of objects doing their part in the code. if you want to see what the field agreements were for a specific pair, you can look at the MatchResult object given for that pair |
| 19:29:17 | <suranga__> how can I retreive something like pair[o] true|true|false|true :) |
| 19:29:35 | *** bwolfe has quit IRC |
| 19:29:41 | <james_regen> along with the getScore, you can also call something like a mr.matchedOn(demographic) |
| 19:30:12 | <james_regen> it'll return a boolean true or false depending on whether the field agreed |
| 19:31:44 | <james_regen> i think there's also a method in there to list what demographics were compared, so you can loop over the list from that, calling that method for each one |
| 19:34:19 | <suranga__> but... mmm... the scorePair doesnt have a MatchResult object, right ? |
| 19:35:48 | <james_regen> scorePair has a method that returns a MatchREsult, public MatchResult scorePair(Record rec1, Record rec2) |
| 19:39:13 | * suranga__ is embarassed at his idiocy :( |
| 19:45:12 | *** chopin_ has quit IRC |
| 19:45:16 | *** bwolfe has joined #openmrs |
| 19:45:16 | *** ChanServ sets mode: +o bwolfe |
| 19:53:39 | <mnunez> rafa: Hi! MDS question: is there a way to merge two concepts as synonyms? Or as translations of the same concept in another language? |
| 19:55:04 | <rafa> mnunez: you need to decide between prefer mine vs prefer theirs |
| 19:55:29 | <rafa> mnunez: prefer mine will preserve most of your original concept |
| 19:55:48 | <rafa> mnunez: it'll add extra concept names, answers, etc. |
| 19:56:37 | <rafa> mnunez: it'll only modify extend collections |
| 19:57:11 | <rafa> mnunez: simple fields that are not collections will remain untouched |
| 19:57:21 | <mnunez> rafa: But it will merge "epilepsia" and "epilepsy" in their respective languages, would it? |
| 19:57:44 | <mnunez> rafa: ah, so it won't |
| 19:57:45 | <rafa> mnunez: yes, it'll move over all names from the incoming concept |
| 19:57:53 | <rafa> mnunez: names are collections |
| 19:58:37 | <rafa> mnunez: so if you have in your concept "epilepsia" and merge with one that is "epilepsy" then you'll have concept with both names |
| 19:58:43 | <mnunez> rafa: awesome. As soon as this works is working in the MCV you'll have a couple dozen new translations then :) |
| 19:59:24 | <rafa> mnunez: great :D |
| 19:59:32 | *** chopin_ has joined #openmrs |
| 20:01:02 | *** suranga__ has quit IRC |
| 20:02:33 | *** djazayeri1 has joined #openmrs |
| 20:03:34 | *** djazayeri has quit IRC |
| 20:03:34 | *** suranga has joined #openmrs |
| 20:03:48 | <rafa> bwolfe: djazayeri, djazayeri1, wyclif, dkayiwa shall we scrum? |
| 20:03:58 | <bwolfe> rafa, give me 15 mins |
| 20:04:23 | <rafa> bwolfe: I'm fine with that |
| 20:07:25 | <wyclif> ok |
| 20:15:52 | <downey> FYI: jira will be unavailable for a few moments |
| 20:26:35 | <rafa> bwolfe: ready? |
| 20:28:52 | <djazayeri1> rafa: bwolfe and I are on a call that was supposed to be "5 minutes", and is now pushing 30... |
| 20:29:08 | *** djazayeri1 is now known as djazayeri |
| 20:29:08 | *** ChanServ sets mode: +o djazayeri |
| 20:29:18 | <rafa> djazayeri: I see :) |
| 20:29:26 | <rafa> djazayeri: no problem |
| 20:33:25 | <rafa> anyone know why none of the VisitService methods are not annotated with @Transactional? |
| 20:33:37 | <djazayeri> rafa: are they in the DAO? |
| 20:33:47 | <djazayeri> or the ServiceImpl? |
| 20:34:30 | <djazayeri> rafa: they're on the HibernateVisitDAO |
| 20:34:38 | <rafa> djazayeri: yeah I see |
| 20:35:01 | <rafa> djazayeri: any reason for that? |
| 20:35:20 | <djazayeri> rafa: that's how we're _supposed_ to be doing things, I think... |
| 20:35:34 | <rafa> djazayeri: I don't get it why :P |
| 20:36:31 | <djazayeri> rafa: first off, we've been doing things wrong by putting @Transactional on the interface rather than the Impl. Spring strongly recommends putting it on the implementation |
| 20:37:19 | <djazayeri> Further, I believe the @Transactional should be on the DAO where it actually hits the datastore, not in the service where it _assumes_ that will happen |
| 20:45:16 | <djazayeri> rafa: if a ServiceImpl method calls multiple transactional DAO methods, that serviceimpl method should also be @Transactional |
| 20:45:18 | <bwolfe> ok, off the other "5 min" call now |
| 20:45:32 | <djazayeri> bwolfe, rafa, dkayiwa, wyclif: scrum time |
| 20:45:36 | <djazayeri> apologies for being late |
| 20:45:40 | <djazayeri> !scrumon bwolfe |
| 20:45:40 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster bwolfe- you may begin when ready. |
| 20:45:50 | <bwolfe> djazayeri, yes, service methods are @transactional because they might call multiple daos |
| 20:46:06 | <bwolfe> but then that means we should actually make our controller methods transactional |
| 20:46:24 | <djazayeri> bwolfe: let's scrum and then revisit this during discusssion time |
| 20:46:35 | <bwolfe> yep |
| 20:47:31 | <bwolfe> djazayeri, you want to go first? |
| 20:47:39 | <bwolfe> then rafa, dkayiwa, wyclif |
| 20:47:59 | <djazayeri> Wednesday 22-Feb-2012 |
| 20:47:59 | <djazayeri> * University call (Balsamiq Mockups) |
| 20:47:59 | <djazayeri> * Design call |
| 20:47:59 | <djazayeri> * Project Management call |
| 20:47:59 | <djazayeri> * Finished Reporting REST module (at least enough for the prototype) |
| 20:47:59 | <djazayeri> * Finished Pentaho PDI plugin (at least enough for the prototype) |
| 20:48:00 | <djazayeri> Thursday 23-Feb-2012 |
| 20:48:00 | <djazayeri> * Dev call |
| 20:48:01 | <djazayeri> * Leadership call |
| 20:48:02 | <djazayeri> * Call with Andy, Ben, and Bruce about openmrs-motech integration |
| 20:48:02 | <djazayeri> * Review lots of tickets |
| 20:48:02 | <djazayeri> ** Reviewed TRUNK-57 |
| 20:48:03 | <djazayeri> ** Reviewed TRUNK-2273 |
| 20:48:04 | <djazayeri> ** Reviewed TRUNK-2240 |
| 20:48:05 | <djazayeri> ** TODO: review more |
| 20:48:05 | <djazayeri> no blockers |
| 20:48:45 | <djazayeri> discussion points: what can we do to help daniel get the RC out. |
| 20:49:05 | <bwolfe> ok, rafa? |
| 20:49:29 | <rafa> ahh my turn |
| 20:49:30 | <rafa> Today: |
| 20:49:30 | <rafa> * Was impressed to see the OpenMRS Spoon plugin demo! |
| 20:49:30 | <rafa> * Committed TRUNK-222 and TRUNK-3069 |
| 20:49:30 | <rafa> * Tested TRUNK-3068 again |
| 20:49:30 | <rafa> Tomorrow: |
| 20:49:30 | <rafa> * Probably try to fix TRUNK-3068 |
| 20:49:30 | <rafa> No blockers. |
| 20:49:44 | <bwolfe> TRUNK-222 |
| 20:49:49 | <bwolfe> !ticket TRUNK-222 |
| 20:49:51 | <OpenMRSBot> bwolfe: [#TRUNK-222] Unable to find patients if their name is less than 3 characters - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-222 |
| 20:50:00 | <bwolfe> !ticket TRUNK-3069 |
| 20:50:02 | <OpenMRSBot> bwolfe: [#TRUNK-3069] Rename AdministrationService.validateInManualFlushMode, and refactor it and ValidateUtil - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3069 |
| 20:50:16 | <bwolfe> !TRUNK-3068 |
| 20:50:17 | <OpenMRSBot> bwolfe: Error: "TRUNK-3068" is not a valid command. |
| 20:50:20 | <bwolfe> !ticket TRUNK-3068 |
| 20:50:22 | <OpenMRSBot> bwolfe: [#TRUNK-3068] Patient Dashboard is slow to load - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3068 |
| 20:50:43 | <bwolfe> rafa, 3068 is probably a missing index on concept or concept_name |
| 20:50:54 | <bwolfe> dkayiwa? |
| 20:51:04 | <bwolfe> (and wyclif, you're after dkayiwa) |
| 20:51:09 | <djazayeri> rafa: we should really get someone else to verify the 1.9 slowness |
| 20:51:09 | <dkayiwa> Committed: AlertServiceTest.notifySuperUsers_shouldAddAnAlertToTheDatabase fails on some computers - TRUNK-3067 |
| 20:51:19 | <wyclif> ok |
| 20:51:19 | <dkayiwa> Reviewed and applied another patch for: Allow "end this visit now" from edit visit page - TRUNK-2240 |
| 20:52:19 | <dkayiwa> Done some 1.9 ticket administration |
| 20:52:34 | *** james_regen has quit IRC |
| 20:52:35 | <dkayiwa> Started on but paused: Patient Dashboard is slow to load - TRUNK-3068 |
| 20:52:35 | <dkayiwa> Now looking into the remaining issue for: Small fixes for newpatient.form - TRUNK-198 |
| 20:52:35 | <dkayiwa> No Blockers |
| 20:52:48 | <wyclif> yesterday: |
| 20:52:48 | <wyclif> * Design call |
| 20:52:48 | <wyclif> * TRUNK-3001 - Add initialization/update wizard messages for languages other than english |
| 20:52:48 | <wyclif> * Switch back to current sprint tasks(implementation of DateBasedResults) |
| 20:52:48 | <wyclif> today: |
| 20:52:49 | <wyclif> * dev call |
| 20:52:51 | <wyclif> * Completing work on datebased results |
| 20:52:53 | <wyclif> * Add tests for calculations for registered tokens and working on the implementation logic |
| 20:52:55 | <wyclif> Blockers: none |
| 20:53:24 | <djazayeri> wyclif: have you dealt with all tickets and reviews that dkayiwa needs? |
| 20:53:25 | <wyclif> dkayiwa, see my last comment for TRUNK-198 |
| 20:53:34 | <wyclif> yes |
| 20:53:49 | <dkayiwa> wyclif: the one for yesterday? |
| 20:53:53 | <bwolfe> we want an RC out soon, so we need all 1.9 tickets done... |
| 20:54:47 | <wyclif> FYI visit service has the transactional annotations in the dao |
| 20:55:04 | <djazayeri> bwolfe: ? |
| 20:55:26 | <bwolfe> today: |
| 20:55:26 | <bwolfe> set up sprint page for next week |
| 20:55:26 | <bwolfe> dev call |
| 20:55:26 | <bwolfe> ldrship call |
| 20:55:26 | <bwolfe> mvp call |
| 20:55:26 | <bwolfe> reviewed a few trunk tickets |
| 20:55:28 | <bwolfe> triaged a few ERR tickets |
| 20:55:44 | <bwolfe> no blockers because I haven't done any coding. :-/ |
| 20:55:57 | <bwolfe> !scrumoff |
| 20:55:57 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 20:56:01 | <bwolfe> discussion points: what can we do to help daniel get the RC out. |
| 20:56:09 | <djazayeri> bwolfe: regarding the sprint page, if you can simultaneously create an ongoing-forever list of bugs, that'd be good. |
| 20:56:18 | <bwolfe> and wyclif, what is the ticket for the initial wizard not defaulting to english? |
| 20:56:35 | <bwolfe> djazayeri, a bug dashboard? sure |
| 20:56:35 | <dkayiwa> wyclif: i commented on your yesterday comment. have not yet got a response from you |
| 20:56:48 | <djazayeri> bwolfe: Yeah, that's what I mean. |
| 20:56:50 | <wyclif> the one with 'ugly bug' phrase in it |
| 20:57:07 | <wyclif> we might want that fixed in 1.9 |
| 20:57:10 | <bwolfe> https://tickets.openmrs.org/browse/TRUNK-3049 |
| 20:57:14 | <djazayeri> It might almost be better to just make a "bug dashboard" that shows open bugs sorted by votes, and use that for the sprint, rather than a specific sprint dashboard. |
| 20:57:25 | <djazayeri> !scrumoff |
| 20:57:25 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 20:57:37 | <bwolfe> it ended twice? :-) |
| 20:57:45 | <dkayiwa> :D |
| 20:57:49 | <bwolfe> djazayeri, I like having closure though... |
| 20:57:49 | <wyclif> FYI visit service has the transactional annotations in the dao |
| 20:57:56 | <djazayeri> oops, missed it before. :-) |
| 20:58:17 | <djazayeri> so, dkayiwa, how do we help you get the RC out ASAP? |
| 20:58:30 | <wyclif> dkayiwa, you might want to move the visit @transactional to VisitServiceImpl |
| 20:58:35 | <dkayiwa> djazayeri: as i responded in the email |
| 20:58:53 | <djazayeri> dkayiwa: we're discussing it on the scrum now, so enlighten us here. :-) |
| 20:59:03 | <dkayiwa> wyclif: are you talking of TRUNK-198? |
| 20:59:06 | <bwolfe> wyclif, are you meaning to say that to rafa? we had mentioned that above |
| 20:59:17 | <wyclif> !ticket TRUNK-198 |
| 20:59:18 | <OpenMRSBot> wyclif: [#TRUNK-198] Small fixes for newpatient.form - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-198 |
| 20:59:21 | <wyclif> yes |
| 20:59:22 | <dkayiwa> djazayeri: working on the remaining reviews and tickets :) |
| 20:59:34 | <dkayiwa> wyclif: can you comment on the ticket? |
| 20:59:36 | <wyclif> dkayiwa, i just had to backport the fix |
| 20:59:42 | <djazayeri> dkayiwa: I'm going to finish all my reviews today. |
| 20:59:46 | <bwolfe> dkayiwa, how many hands do you need to get that done by this weekend? |
| 20:59:49 | <dkayiwa> wyclif: did you see my response to that? |
| 20:59:52 | <wyclif> dkayiwa, i already did like a couple of days ago |
| 21:00:25 | <rafa> yeah does anyone object to move @Transactional back to VisitService for now? |
| 21:00:26 | <dkayiwa> wyclif: i got the same problem on trunk. so the backporting did not fix it |
| 21:00:26 | <dkayiwa> bwolfe: as many as possible :) |
| 21:00:28 | <wyclif> dkayiwa, i cant seem to reproduce it |
| 21:00:47 | <dkayiwa> wyclif: very easy to reproduce. can i take you through it now? |
| 21:00:49 | <djazayeri> dkayiwa: can you be more specific about what we can do? |
| 21:00:55 | <djazayeri> i.e. is there a ticket that needs someone to work on it? |
| 21:00:58 | <wyclif> wait after this chat |
| 21:01:06 | <dkayiwa> djazayeri: first of all finish all your reviews :) |
| 21:01:11 | <wyclif> wait after this chat to end |
| 21:01:12 | <djazayeri> dkayiwa: I will do that |
| 21:01:21 | <djazayeri> can bwolfe do anything? |
| 21:01:38 | <dkayiwa> djazayeri: bwolfe also have reviews pending :) |
| 21:01:50 | <bwolfe> I do? shoot... |
| 21:02:34 | <bwolfe> I'll do those asap |
| 21:02:39 | <bwolfe> that may or may not be tonight |
| 21:02:49 | <wyclif> This is the ticket TRUNK-3048 bwolfe , djazayeri you meant |
| 21:02:59 | <djazayeri> dkayiwa: is there a JIRA query you have saved that shows everything that must be done for the RC to be released? |
| 21:03:09 | <djazayeri> including, for example, STAND-36? |
| 21:03:11 | <wyclif> dkayiwa, have you looked at TRUNK-3048 |
| 21:03:24 | <dkayiwa> !ticket TRUNK-3048 |
| 21:03:25 | <OpenMRSBot> dkayiwa: [#TRUNK-3048] When searching for patients by name, exact matches should be shown first - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3048 |
| 21:03:30 | <wyclif> dkayiwa, do you want to oinclude that in 1.9 |
| 21:03:40 | <dkayiwa> wyclif: not yet looked into that |
| 21:03:59 | <wyclif> and this TRUNK-3049 |
| 21:04:09 | <wyclif> djazayeri, dkayiwa bwolfe and this TRUNK-3049 |
| 21:04:20 | <djazayeri> !ticket runk-3049 |
| 21:04:20 | <bwolfe> !ticket trunk-3049 |
| 21:04:20 | <dkayiwa> djazayeri: was using this: https://tickets.openmrs.org/browse/TRUNK/fixforversion/12563#atl_token=BLWS-FDA8-JYTS-L2S1|b19c9d10b8b74ecdd8f54b3ac704054e9d447ca6|lin&selectedTab=com.atlassian.jira.plugin.system.project%3Aversion-issues-panel |
| 21:04:20 | <OpenMRSBot> djazayeri: Issue Does Not Exist - OpenMRS JIRA - https://tickets.openmrs.org/browse/runk-3049 |
| 21:04:21 | <OpenMRSBot> bwolfe: [#TRUNK-3049] Ugly screen when upgrading to OpenMRS 1.9 - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3049 |
| 21:04:38 | <bwolfe> 3049, yes. 3048, no |
| 21:04:51 | <wyclif> ok |
| 21:04:53 | <djazayeri> dkayiwa: don't forget about the standalone! |
| 21:05:02 | <wyclif> i think i know the fix to 3049 |
| 21:05:02 | <dkayiwa> djazayeri: ok |
| 21:05:39 | <dkayiwa> !ticket STAND-36 |
| 21:05:41 | <OpenMRSBot> dkayiwa: [#STAND-36] Automatically create MVP/CIEL dictionary-based dataset as part of the standalone build process - OpenMRS JIRA - https://tickets.openmrs.org/browse/STAND-36 |
| 21:05:41 | <djazayeri> dkayiwa: could you create a jira query (or maybe they're called filters), save it, and publish it? |
| 21:05:50 | <dkayiwa> djazayeri: ok |
| 21:06:42 | <dkayiwa> djazayeri: is STAND-36 still waiting on Andy? |
| 21:07:02 | <djazayeri> rafa knows the status of that ticket |
| 21:07:15 | <dkayiwa> rafa: any updates??? |
| 21:07:16 | <rafa> djazayeri: it's waiting on me |
| 21:07:21 | <dkayiwa> :) |
| 21:07:28 | *** pterminator has joined #openmrs |
| 21:08:19 | <djazayeri> bwolfe: do you have "free time" tomorrow? E.g. can dkayiwa assign you a ticket for 1.9 RC? (After you've done reviews...) |
| 21:08:43 | <rafa> dkayiwa: There's still at least a day of work for STAND-36. |
| 21:08:51 | <dkayiwa> rafa: ok |
| 21:08:58 | <bwolfe> yes, assign me a ticket |
| 21:09:06 | <bwolfe> dkayiwa ^^ |
| 21:09:37 | <bwolfe> rafa, make that half a day and you've got a deal |
| 21:09:43 | <dkayiwa> bwolfe: should i give you TRUNK-3068 ? :) |
| 21:10:28 | <bwolfe> you could, unless rafa was going to take that one |
| 21:10:47 | <dkayiwa> bwolfe: looks like rafa already has enough :) |
| 21:10:57 | <downey> s/spellcheck/bwolfe/g |
| 21:11:20 | <downey> s/spellcheck/proofreading/ |
| 21:12:39 | <bwolfe> ok, assign it to me then. :-) |
| 21:12:50 | * bwolfe upgrades his mvp dictionary so he can test it out... |
| 21:13:02 | <dkayiwa> bwolfe: deal!!! :D |
| 21:13:55 | <bwolfe> brb |
| 21:14:14 | <djazayeri> dkayiwa: anyway, i'm off to review tickets now (and eat lunch) |
| 21:14:26 | <dkayiwa> djazayeri: thanks :) |
| 21:14:43 | <djazayeri> but dkayiwa, please put together a single JIRA query that shows the list that we need to get down to zero before doing the RC. |
| 21:14:57 | <djazayeri> and please assign bwolfe and rafa specific tickets to work on |
| 21:15:03 | <dkayiwa> djazayeri: ok |
| 21:15:17 | <djazayeri> wyclif: something I wanted to mention |
| 21:15:23 | <wyclif> djazayeri, sure |
| 21:15:58 | <djazayeri> wyclif: I don't know if ben or dawn mentioned this to you, but we may want you to run the Logic 2.0 sprint (if Mike is busy). |
| 21:16:09 | <wyclif> djazayeri, sure |
| 21:16:21 | <bwolfe> I have not emailed him about that yet |
| 21:16:38 | <bwolfe> now my email will be less suspenseful :-/ |
| 21:16:44 | <wyclif> djazayeri, it wans't mentioned to me, but it is fine, in anycase it would be implied |
| 21:16:58 | <djazayeri> wyclif: one of your tasks tomorrow should be to create tickets describing any hacks-that-need-refactoring, TODOs, etc from your code. |
| 21:17:08 | <wyclif> djazayeri, yeas |
| 21:17:11 | <djazayeri> before _really_ creating all the sprint tickets, you should talk with Mike. |
| 21:17:18 | <wyclif> djazayeri, ok |
| 21:17:25 | <djazayeri> but you can do some of them tomorrow. |
| 21:17:46 | <wyclif> ok |
| 21:18:14 | <wyclif> djazayeri, i thought the logic 2.0 sprint is after next week |
| 21:19:01 | <bwolfe> it is |
| 21:19:11 | <bwolfe> but you will be on the bug fixing sprint next week |
| 21:19:15 | <wyclif> ok |
| 21:19:19 | <bwolfe> and you are on the logic stuff this week |
| 21:19:26 | <wyclif> yeah |
| 21:19:34 | <bwolfe> so part of your logic stuff is to make it possible for others to also work on logic |
| 21:19:46 | <bwolfe> this includes tickets, documentation on current functionality, etc |
| 21:19:56 | <bwolfe> (or at least rough documentation) |
| 21:25:21 | <djazayeri> wyclif: do you have a single test class that has all the behavior tests now? |
| 21:38:01 | <wyclif> djazayeri, |
| 21:38:07 | <wyclif> djazayeri, yes |
| 21:43:25 | <djazayeri> wyclif: what's it called? |
| 21:44:23 | <wyclif> PatientBehaviorTest |
| 21:44:35 | <wyclif> since all those tests are specific to patients |
| 21:48:46 | *** bryq has quit IRC |
| 21:52:21 | *** suranga has quit IRC |
| 21:53:37 | *** pterminator has left #openmrs |
| 21:56:26 | *** bwolfe has quit IRC |
| 21:56:29 | *** bwolfe_ has joined #openmrs |
| 21:56:29 | *** ChanServ sets mode: +o bwolfe_ |
| 22:00:35 | *** bwolfe_ has quit IRC |
| 22:01:51 | *** dkayiwa has quit IRC |
| 22:01:54 | *** dkayiwa_ has joined #openmrs |
| 22:03:04 | *** mnunez has left #openmrs |
| 22:07:16 | *** dkayiwa has joined #openmrs |
| 22:07:17 | *** dkayiwa_ has quit IRC |
| 22:07:31 | <wyclif> hi djazayeri |
| 22:07:52 | <djazayeri> hi wyclif |
| 22:10:37 | <wyclif> on the short patient form, i submit a form when you add patient indentifier for an identifier type whose location is required, it doesn't show the location dropdown if it set, it that right? |
| 22:11:16 | <dkayiwa> that is after trying to submit and you get errors |
| 22:12:38 | <dkayiwa> and to give some more context, we are discussing the last comments for TRUNK-198 |
| 22:13:24 | *** chopin_ has quit IRC |
| 22:17:14 | <wyclif> dkayiwa, that comment is nto descriptive of the actual issue |
| 22:19:49 | *** dkayiwa has quit IRC |
| 22:25:48 | *** sgithens has quit IRC |
| 22:33:24 | *** downey has quit IRC |
| 22:34:55 | *** downey has joined #openmrs |
| 22:34:55 | *** OpenMRSBot sets mode: +o downey |
| 22:34:55 | *** ChanServ sets mode: +o downey |
| 22:54:23 | *** downey has quit IRC |
| 22:54:57 | *** downey has joined #openmrs |
| 22:54:57 | *** ChanServ sets mode: +o downey |
| 22:54:57 | *** OpenMRSBot sets mode: +o downey |
| 22:59:27 | <djazayeri> wyclif: sorry, I missed your comment earlier |
| 22:59:31 | <djazayeri> is it still relevant? |
| 23:00:10 | <wyclif> not any more |
| 23:00:20 | *** downey has quit IRC |
| 23:25:44 | *** wyclif has quit IRC |
| 23:37:26 | *** rafa has quit IRC |