00:17:10
|
*** bwolfe has joined #openmrs
|
00:17:10
|
*** ChanServ sets mode: +o bwolfe
|
00:21:38
|
*** bwolfe has quit IRC
|
00:21:46
|
*** bwolfe has joined #openmrs
|
00:21:46
|
*** ChanServ sets mode: +o bwolfe
|
00:56:51
|
*** wyclif has quit IRC
|
00:59:39
|
*** burke has joined #openmrs
|
00:59:39
|
*** ChanServ sets mode: +o burke
|
01:08:56
|
*** dewmal has joined #openmrs
|
01:25:42
|
*** burke has quit IRC
|
01:32:19
|
*** wyclif has joined #openmrs
|
02:45:14
|
<djazayeri> bwolfe: I have a newbie maven question
|
02:45:26
|
<bwolfe> djazayeri, ok
|
02:45:59
|
<djazayeri> for the PDI plugin, I need to have the maven build put the dependencies in the jar in a /lib folder
|
02:46:05
|
<djazayeri> I can't figure out how to do that...
|
02:47:54
|
<djazayeri> seems like it should be easy
|
02:48:00
|
<djazayeri> and it probably is...
|
02:48:51
|
<bwolfe> djazayeri, is it putting them somewhere else by default? or just not including them?
|
02:48:58
|
<djazayeri> not including them
|
02:50:06
|
<djazayeri> I see how to use the maven-dependency-plugin to copy them
|
02:50:25
|
<djazayeri> bwolfe: ah, figured it out
|
02:50:57
|
<djazayeri> if I copy them into /classes/lib (with maven-dependency-plugin) they'll end up copied to the right place. It hadn't occurred to me to put them in /classes.
|
02:51:00
|
<djazayeri> seems hacky, but will do
|
02:51:25
|
<bwolfe> are you using scope=provided?
|
02:51:58
|
<djazayeri> I'm using that where I'm supposed to be (i.e. on the dependencies that I don't want to include)
|
02:52:28
|
<djazayeri> anyway, I've got it now
|
03:27:08
|
*** chopin has joined #openmrs
|
03:40:01
|
*** upul` has joined #openmrs
|
03:40:01
|
*** ChanServ sets mode: +v upul`
|
03:53:35
|
*** chopin has quit IRC
|
03:53:47
|
*** chopin has joined #openmrs
|
04:11:52
|
*** dewmal has quit IRC
|
04:16:32
|
*** chopin has quit IRC
|
04:23:53
|
*** dewmal has joined #openmrs
|
04:37:03
|
*** suranga has joined #openmrs
|
05:15:41
|
*** djazayeri1 has joined #openmrs
|
05:17:58
|
*** djazayeri has quit IRC
|
06:29:38
|
*** dkayiwa has joined #openmrs
|
06:56:01
|
*** ibewes has joined #openmrs
|
06:56:29
|
<ibewes> Good morning all (or whatever time it is where you are!)
|
06:59:20
|
<dkayiwa> ibewes: morning :)
|
07:01:05
|
<suranga> morning all !
|
07:24:44
|
<ibewes> that conference call today is open to anyone, correct?
|
07:51:46
|
<dkayiwa> ibewes: YES :D
|
07:51:49
|
*** ibewes has quit IRC
|
08:10:46
|
*** djazayeri1 has quit IRC
|
08:11:04
|
*** djazayeri has joined #openmrs
|
08:11:04
|
*** ChanServ sets mode: +o djazayeri
|
08:42:59
|
*** bryq has joined #openmrs
|
08:42:59
|
*** ChanServ sets mode: +v bryq
|
09:39:06
|
*** upul` has quit IRC
|
09:47:33
|
*** bryq has quit IRC
|
09:50:22
|
*** goutham has joined #openmrs
|
09:52:01
|
*** catchmrbharath has joined #openmrs
|
10:22:06
|
*** catchmrbharath has quit IRC
|
11:01:46
|
*** suranga has quit IRC
|
11:08:26
|
*** ibewes has joined #openmrs
|
11:13:56
|
*** ibewes is now known as ibewes_
|
11:15:22
|
*** ibewes_ has quit IRC
|
11:15:57
|
*** ibewes has joined #openmrs
|
11:20:52
|
*** dewmal has quit IRC
|
11:31:05
|
*** rafa has joined #openmrs
|
11:31:05
|
*** ChanServ sets mode: +v rafa
|
11:37:18
|
*** dewmal has joined #openmrs
|
11:45:11
|
*** catchmrbharath has joined #openmrs
|
11:48:51
|
<dkayiwa> hi rafa
|
11:49:11
|
<dkayiwa> rafa: how is TRUNK-3054 going? :)
|
11:51:08
|
<rafa> hi dkayiwa, I'm starting with that right now
|
11:51:39
|
<dkayiwa> rafa: ok 8)
|
11:51:41
|
*** catchmrbharath has quit IRC
|
12:01:37
|
*** bryq has joined #openmrs
|
12:01:37
|
*** ChanServ sets mode: +v bryq
|
12:06:14
|
*** dewmal has quit IRC
|
12:07:39
|
*** dkayiwa has quit IRC
|
12:10:29
|
*** dkayiwa has joined #openmrs
|
12:17:15
|
*** wyclif has quit IRC
|
12:18:49
|
*** wyclif has joined #openmrs
|
12:20:01
|
*** goutham has quit IRC
|
12:48:47
|
<rafa> dkayiwa: do you have a list of all bundled modules at hand?
|
12:49:06
|
<dkayiwa> rafa: their names?
|
12:49:12
|
<rafa> dkayiwa: names and versions
|
12:49:22
|
<rafa> dkayiwa: for some reason I don't have them installed in my 1.10
|
12:49:28
|
<dkayiwa> rafa: on the beta release notes page
|
12:49:52
|
<rafa> dkayiwa: cool thanks
|
12:50:58
|
<rafa> dkayiwa: HFE 1.8.2?
|
12:51:01
|
*** ibewes has quit IRC
|
12:51:05
|
<rafa> dkayiwa: there's only 1.8.1 in the repo
|
12:51:09
|
<dkayiwa> rafa: yes
|
12:51:24
|
<dkayiwa> rafa: custom build from trunk
|
12:51:56
|
<rafa> dkayiwa: hmm can you simply e-mail me them? :)
|
12:53:00
|
<rafa> dkayiwa: or should I have them somewhere in svn for trunk?
|
12:53:22
|
<dkayiwa> rafa: in the 1.9 beta tag
|
12:53:32
|
<dkayiwa> rafa: under bundled modules
|
12:53:35
|
<rafa> great
|
12:53:40
|
<rafa> thanks
|
13:06:35
|
*** wyclif has quit IRC
|
13:13:42
|
<rafa> dkayiwa: upgrading jquery breaks the concept dictionary search
|
13:13:55
|
<dkayiwa> rafa: i got the same problem too
|
13:14:08
|
<rafa> dkayiwa: did you look into that?
|
13:14:23
|
<rafa> dkayiwa: other things seem to work
|
13:14:29
|
<dkayiwa> rafa: it would take alot of my time. so i did not
|
13:14:32
|
<rafa> dkayiwa: have you experienced problems anywhere else?
|
13:14:50
|
<dkayiwa> rafa: never tested anything else apart from concept search
|
13:15:20
|
<rafa> dkayiwa: hmmm I started from modules ;)
|
13:15:42
|
<dkayiwa> rafa: i started with core, and stopped when basic concept search got broken :)
|
13:16:21
|
<rafa> dkayiwa: I don't know how to test the modules right :/
|
13:16:46
|
<rafa> dkayiwa: I've just clicked everything I could to see js errors.
|
13:16:49
|
<dkayiwa> rafa: may be clicking all links for modules
|
13:17:41
|
<rafa> dkayiwa: yeah I guess it must suffice
|
13:17:52
|
<dkayiwa> rafa: probably
|
13:22:00
|
*** mnunez has joined #openmrs
|
13:27:53
|
*** sgithens has joined #openmrs
|
13:28:46
|
<bryq> rafa: Hi, are there any docs/wiki pages about changes between 0.10 and 1.0 version of MDS module? :)
|
13:29:52
|
<rafa> bryq: Hi, I've only listed new features, wiki is updated only partially
|
13:30:35
|
<bryq> rafa: Okay, I'll look into source code then
|
13:30:57
|
<rafa> bryq: sure, go ahead
|
13:38:42
|
*** james_regen has joined #openmrs
|
13:38:42
|
*** ChanServ sets mode: +v james_regen
|
13:38:42
|
*** mnunez has quit IRC
|
13:52:34
|
*** wyclif has joined #openmrs
|
13:56:55
|
*** mnunez has joined #openmrs
|
13:57:06
|
<mnunez> Hi everyone!
|
13:57:44
|
<mnunez> Question: regarding the MDS module, is the MCL publishing concepts for the 1.0 version?
|
14:02:22
|
<mnunez> Does anyone happen to know the publishing URL?
|
14:05:07
|
*** wyclif has quit IRC
|
14:05:13
|
*** wyclif has joined #openmrs
|
14:08:35
|
*** pushkar has joined #openmrs
|
14:16:42
|
<rafa> bwolfe: what is a recognized ext for a patch file in JIRA?
|
14:17:08
|
<bwolfe> rafa, .diff or .patch I think
|
14:17:19
|
<rafa> .patch doesn't work. I'll try with .diff :)
|
14:19:28
|
<rafa> bwolfe: hmmm I thought there was a way to view patches as diffs in JIRA but none of the above exts work :/
|
14:21:42
|
<bwolfe> rafa, they always download for me
|
14:21:58
|
<bwolfe> rafa, when we used trac, it would show them in the web with syntax highlighting
|
14:22:08
|
<bwolfe> there might be a jira plugin we could get to show them, check with downey
|
14:22:25
|
<rafa> trac++
|
14:23:48
|
<sgithens> I'll have to join the uni call next week. I had to dial the account like 5 times to figure out how to turn on the dialpad on the windows version of skype and freeconferencing seems to have temporarily blocked my user id from the repeat calling.
|
14:24:48
|
<rafa> sgithens: haha Skype is awesome :D
|
14:25:33
|
<sgithens> rafa: Well, the windows version is filled up with a lot more buttons than the linux client :p
|
14:25:41
|
*** mnunez has quit IRC
|
14:25:45
|
<sgithens> and menus
|
14:25:54
|
*** mnunez has joined #openmrs
|
14:26:59
|
<rafa> sgithens: I had the very same problem lately
|
14:27:53
|
<sgithens> rafa: I tried to use Eclipse to do everything on windows, and lasted almost 48 hours... almost done ramping up this virtualbox ubuntu instance
|
14:29:35
|
<rafa> sgithens: Eclipse on Windows works just fine for me :)
|
14:30:58
|
<rafa> sgithens: I only needed to hack eclipse.ini a bit
|
14:31:19
|
<sgithens> rafa: I guess I'm a hybrid sort of user. I was never able to get comfortable using it for everything. I still prefer doing my maven builds and svn/git commits from bash or other stuff.
|
14:32:32
|
<rafa> sgithens: whatever works for you :)
|
14:33:18
|
<rafa> dkayiwa: what next ticket do you want me to do? :D
|
14:33:24
|
<sgithens> rafa: Although, I am interested in potentially having the eclipse hot deploy work. Do folks have that working with OpenMRS? It's stubbed out on the wiki
|
14:33:28
|
<dkayiwa> rafa: let me check :)
|
14:33:43
|
<rafa> sgithens: I do have
|
14:33:48
|
<rafa> sgithens: with jrebel
|
14:34:02
|
<mnunez> Hi rafa! I'm trying the MDS module, do you know what's the URL to suscribe to the MCL?
|
14:34:23
|
<rafa> mnunez: the MCL is not yet upgraded to the latest version
|
14:34:32
|
<sgithens> rafa: Cool. Does that handle static files as well? JSP's, js, maybe even reloading if you update web.xml?
|
14:34:43
|
<mnunez> rafa: any other sources available to try?
|
14:35:01
|
<sgithens> mvn jetty:run just starts up whats in the target dir right?
|
14:35:02
|
<rafa> mnunez: not really yet
|
14:35:40
|
<mnunez> rafa: Alright, thanks!
|
14:35:43
|
*** mnunez has left #openmrs
|
14:35:57
|
<dkayiwa> rafa: do you think you can handle TRUNK-222 ?
|
14:36:42
|
<rafa> sgithens: mvn jetty:run is good enough for jsps, it doesn't handle changes in java files well
|
14:36:52
|
<rafa> sgithens: for java files you need to use jrebel
|
14:37:01
|
<rafa> !ticket TRUNK-222
|
14:37:02
|
<OpenMRSBot> rafa: [#TRUNK-222] Unable to find patients if their name is less than 3 characters - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-222
|
14:37:25
|
<rafa> sgithens: jrebel is pretty straightforward
|
14:37:40
|
<rafa> sgithens: you only need to install the eclipse plugin
|
14:37:58
|
<rafa> sgithens: and use jrebel profile while starting jetty
|
14:39:22
|
<rafa> dkayiwa: sure
|
14:39:26
|
<rafa> dkayiwa: I need to steal it
|
14:39:40
|
<dkayiwa> rafa: thanks :) oh yes please do
|
14:41:43
|
*** bryq has quit IRC
|
14:43:36
|
<dkayiwa> rafa: if you finish that quickly, you could also help wyclif with TRUNK-3057 :)
|
14:44:03
|
<dkayiwa> rafa: that would also require you to steal again :)
|
14:44:42
|
<wyclif> i have a solution to TRUNK-3057 but has one downside
|
14:45:00
|
<wyclif> dkayiwa, rafa i have a solution to TRUNK-3057 but has one downside
|
14:45:05
|
<dkayiwa> ok
|
14:45:25
|
<dkayiwa> wyclif: can you comment on the ticket?
|
14:46:02
|
<wyclif> dkayiwa, rafa , sure
|
14:50:51
|
*** pushkar has quit IRC
|
14:51:22
|
*** downey has joined #openmrs
|
14:51:22
|
*** ChanServ sets mode: +o downey
|
14:51:22
|
*** OpenMRSBot sets mode: +o downey
|
15:03:01
|
*** dkayiwa has quit IRC
|
15:10:52
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Announcements List: Reminder: 2012 Implementers Meeting Proposals Due March 6th! <https://listserv.iupui.edu/cgi-bin/wa-iupui.exe?A2=ind1202&L=openmrs-announce-l&P=732>
|
15:20:43
|
*** chopin has joined #openmrs
|
15:23:20
|
*** dawn_ has joined #openmrs
|
15:23:20
|
<dawn_> r
|
15:23:30
|
*** ChanServ sets mode: +v dawn_
|
15:25:57
|
*** james_regen1 has joined #openmrs
|
15:27:38
|
*** james_regen has quit IRC
|
15:30:13
|
<dawn_> !scrumon dawn
|
15:30:13
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
|
15:30:32
|
<dawn_> bwolfe: djazayeri rafa wyclif : aloha! 8)
|
15:30:49
|
<djazayeri> hola
|
15:30:49
|
<dawn_> Today's order: bwolfe , djazayeri , rafa , and wyclif
|
15:30:57
|
<rafa> hey!
|
15:31:36
|
<wyclif> can i go first
|
15:31:48
|
<djazayeri> yes
|
15:31:50
|
<dawn_> wyclif: sure. forgot you have to go soon
|
15:31:50
|
<wyclif> i need to to leave for my doc appointment in the next 5min
|
15:32:39
|
<wyclif> yesterday:
|
15:32:39
|
<wyclif> -Added behavior tests for Cohorts similar to those for a single patient
|
15:32:39
|
<wyclif> -Add integration tests for Datebasedresult and add the logic to make it pass
|
15:32:39
|
<wyclif> -Started on implementation code fof DateBasedResults
|
15:32:39
|
<wyclif> -TRUNK-3057 - Creating concept mappings fails with legacy code
|
15:32:40
|
<wyclif> today:
|
15:32:42
|
<wyclif> -Design call
|
15:32:44
|
<wyclif> -TRUNK-3001 - Add initialization/update wizard messages for languages other than english
|
15:32:46
|
<wyclif> -Switch back to current sprint tasks(complete implementation code of DateBasedResults)
|
15:32:50
|
<wyclif> Blockers: TRUNK-3057- hibernate early flushes
|
15:33:59
|
<djazayeri> wyclif: did you look more at TRUNK-3057, and not find the solution?
|
15:34:15
|
<djazayeri> do you want rafa to look at it?
|
15:34:35
|
<wyclif> i will add the patch
|
15:35:00
|
<djazayeri> I'll go next, since we haven't heard from bwolfe yet
|
15:35:08
|
<dawn_> djazayeri: sounds good
|
15:35:11
|
<wyclif> i have a solution if i use concept map type with id 1 as default but what if it is deleted
|
15:35:17
|
<djazayeri> Tuesday 21-Feb-2012
|
15:35:17
|
<djazayeri> * Continue working on Reporting REST
|
15:35:17
|
<djazayeri> * Call with Slawomir Chodnicki from Pentaho
|
15:35:17
|
<djazayeri> * Continue working on the Pentaho PDI plugin
|
15:35:18
|
<djazayeri> Wednesday 22-Feb-2012
|
15:35:18
|
<djazayeri> * University call (Balsamiq Mockups)
|
15:35:19
|
<djazayeri> * Design call
|
15:35:19
|
<djazayeri> * Project Management call
|
15:35:20
|
<djazayeri> * Continue working on the Pentaho PDI plugin (it "runs" but needs debugging)
|
15:35:21
|
<djazayeri> Blocker: Eclipse hangs on "Building workspace" whenever I start it. Does anybody know if I can edit a file somewhere to tell Eclipse *not* to open some projects when I start up?
|
15:35:25
|
<wyclif> bye
|
15:35:30
|
<djazayeri> bye wyclif
|
15:35:46
|
<rafa> cya
|
15:35:46
|
<dawn_> bye wyclif
|
15:35:51
|
<dawn_> rafa: your turn
|
15:35:53
|
*** dewmal has joined #openmrs
|
15:36:00
|
<rafa> Today:
|
15:36:00
|
<rafa> * TRUNK-3054: Upgrade to the latest stable release of jquery
|
15:36:00
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3054
|
15:36:00
|
<rafa> * Started with TRUNK-222: Unable to find patients if their name is less than 3 characters
|
15:36:00
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-222
|
15:36:01
|
<rafa> * 3.5 h more today
|
15:36:01
|
<rafa> Blockers: TRUNK-3054: to commit or not to commit?
|
15:36:47
|
<dawn_> djazayeri: and rafa : it's just the two of you for now until I can get a hold of bwolfe and dkayiwa
|
15:37:08
|
<dawn_> so let's work through the blockers, and I'll try to get them into IRC to help and give their updates
|
15:37:14
|
<dawn_> !scrumoff dawn
|
15:37:14
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:37:28
|
<rafa> djazayeri: I'd move simply the project from workspace folder
|
15:37:41
|
<rafa> djazayeri: don't know any better way
|
15:37:45
|
<djazayeri> I guess that would work, though I'll want it back
|
15:38:02
|
<rafa> djazayeri: maybe importing again will help
|
15:39:40
|
<djazayeri> rafa: maybe—I'll google around and/or try that
|
15:40:18
|
<rafa> djazayeri: cool what do you think about TRUNK-3054?
|
15:40:21
|
<djazayeri> rafa: regarding the jquery upgrade...
|
15:40:42
|
*** wyclif has quit IRC
|
15:41:19
|
<djazayeri> If the only error you found was the need to change from .attr to .prop in one of our widgets...
|
15:41:36
|
<djazayeri> I think we could make an argument for doing the upgrade
|
15:41:44
|
<djazayeri> but I guess we really should defer this for 1.10
|
15:42:09
|
<djazayeri> I think you should commit the fix to trunk now though.
|
15:42:12
|
<djazayeri> We just won't backport to 1.9.x
|
15:42:25
|
<rafa> djazayeri: fine
|
15:42:51
|
<djazayeri> rafa: did you have to actually do any work to create four different color schemes for the themes on jquery-ui?
|
15:43:27
|
<rafa> djazayeri: no I haven't even updated them
|
15:43:36
|
<rafa> djazayeri: jquery-ui was pretty up to date
|
15:44:00
|
<djazayeri> oh, okay, I thought we'd need to update jquery-ui too
|
15:44:04
|
<djazayeri> if no need, even better
|
15:44:12
|
<rafa> djazayeri: I updated the js file
|
15:44:27
|
*** mnunez has joined #openmrs
|
15:44:58
|
<djazayeri> rafa: oh, I think that can lead to problems
|
15:45:21
|
<rafa> djazayeri: it was from 1.8.2 to 1.8.17
|
15:45:42
|
<rafa> djazayeri: not a big change
|
15:46:15
|
<djazayeri> I know, but I've seen problems just within 1.8.x to 1.8.y, e.g. the left and right icons not showing up in the datepicker popup
|
15:47:04
|
<rafa> djazayeri: ha I didn't test that thoroughly
|
15:47:26
|
<rafa> djazayeri: it should be fine to leave it in the old version
|
15:47:33
|
<djazayeri> rafa: anyway, yeah, leave that
|
15:47:39
|
<djazayeri> just upgrade jquery in trunk
|
15:48:01
|
<rafa> okay
|
15:49:07
|
<djazayeri> okay, I'm set
|
15:49:15
|
<djazayeri> You know what tickets to work on?
|
15:49:18
|
<rafa> yes
|
15:50:16
|
<djazayeri> cool
|
16:01:45
|
*** downey_ has joined #openmrs
|
16:01:45
|
*** ChanServ sets mode: +o downey_
|
16:01:54
|
*** james_regen has joined #openmrs
|
16:01:54
|
*** ChanServ sets mode: +v james_regen
|
16:01:59
|
*** shyam057cs has joined #openmrs
|
16:03:20
|
*** chopin has quit IRC
|
16:03:33
|
*** james_regen1 has quit IRC
|
16:03:35
|
*** downey has quit IRC
|
16:03:35
|
*** downey_ is now known as downey
|
16:06:36
|
*** downey_ has joined #openmrs
|
16:06:36
|
*** ChanServ sets mode: +o downey_
|
16:08:31
|
*** downey has quit IRC
|
16:08:31
|
*** downey_ is now known as downey
|
16:15:57
|
*** chopin has joined #openmrs
|
16:39:49
|
*** dkayiwa has joined #openmrs
|
16:40:16
|
*** bryq has joined #openmrs
|
16:40:16
|
*** ChanServ sets mode: +v bryq
|
16:47:35
|
<dkayiwa> hi rafa
|
16:47:56
|
<rafa> hi dkayiwa
|
16:48:00
|
<dkayiwa> rafa: could you be knowing why the AlertServiceTest fails one my and Darius's laptop
|
16:48:26
|
<rafa> dkayiwa: what is the error?
|
16:48:31
|
<dkayiwa> rafa: when run as jnunit test from eclipse, it succeeds
|
16:48:38
|
<dkayiwa> rafa: but not as a maven build
|
16:48:47
|
<dkayiwa> rafa: the assert just fails
|
16:48:54
|
<rafa> dkayiwa: which one?
|
16:49:07
|
<rafa> dkayiwa: there are 3
|
16:49:07
|
<djazayeri> the one test in AlertServiceTest
|
16:49:13
|
<djazayeri> oh, there was just one before
|
16:49:28
|
<dkayiwa> rafa: i have one
|
16:49:28
|
<djazayeri> notify superuser, or something like that
|
16:49:28
|
<rafa> djazayeri: there are 3 asserts I mean
|
16:49:52
|
<dkayiwa> rafa: oh let me run again and confirm which one
|
16:51:22
|
<rafa> mac is what you have in common so I'd blame that :P
|
16:51:47
|
<dkayiwa> rafa: oh yes :)
|
16:54:11
|
*** shyam057cs has quit IRC
|
16:56:01
|
*** suranga has joined #openmrs
|
16:57:11
|
*** downey has quit IRC
|
16:58:22
|
*** mvorobey has joined #openmrs
|
16:58:42
|
<suranga> james_regen, hellloo
|
16:58:46
|
<mvorobey> hi all
|
16:58:54
|
<suranga> james_regen, r u there ?
|
16:59:57
|
*** downey has joined #openmrs
|
16:59:57
|
*** ChanServ sets mode: +o downey
|
16:59:57
|
*** OpenMRSBot sets mode: +o downey
|
17:01:54
|
<djazayeri> dkayiwa: hey, did you backport all the revisions I mentioned in TRUNK-3034?
|
17:02:12
|
*** mnunez has left #openmrs
|
17:02:18
|
<james_regen> suranga: hi
|
17:02:20
|
<dkayiwa> djazayeri: yes
|
17:02:26
|
<djazayeri> great!
|
17:02:38
|
*** dawn_ has quit IRC
|
17:03:15
|
<suranga> james_regen, the good news is that Im progressing well thanks to the pointers u gave yesterday :)
|
17:03:16
|
<suranga> all is well
|
17:03:33
|
<james_regen> suranga: great, anything not making sense?
|
17:03:43
|
*** suranga has quit IRC
|
17:04:04
|
*** suranga has joined #openmrs
|
17:04:16
|
<suranga> james_regen, sorry, just got disconnected...
|
17:04:42
|
<suranga> james_regen, I do have some fresh issues, but I figure that I dont need to bug u with them :P
|
17:05:10
|
<james_regen> ok. if you get stuck, feel free to ask and i'll try to help
|
17:06:03
|
<suranga> sure ! its great to have you around :P
|
17:06:14
|
<suranga> hopefully we'll meet one day...
|
17:12:15
|
*** dawn_ has joined #openmrs
|
17:12:15
|
*** ChanServ sets mode: +v dawn_
|
17:12:33
|
<rafa> dkayiwa: do you know which assert fails?
|
17:12:57
|
<dkayiwa> rafa: the last (third) one
|
17:13:26
|
<rafa> dkayiwa: and what is the message then?
|
17:13:40
|
<rafa> dkayiwa: it's Assert.assertTrue(alertOne.getText().equals("Module.startupError.notification.message"));
|
17:13:49
|
<dkayiwa> rafa: yes
|
17:14:06
|
<rafa> dkayiwa: so maybe change it to Assser.assertEquals and see what is in getText()
|
17:14:18
|
<dkayiwa> rafa: ok
|
17:14:42
|
*** suranga_ has joined #openmrs
|
17:14:44
|
<dkayiwa> rafa: alertOne is null
|
17:15:27
|
<rafa> dkayiwa: so it seems like it gets assigned a different id than 1
|
17:15:43
|
<dkayiwa> rafa: could be
|
17:15:55
|
*** suranga has quit IRC
|
17:16:03
|
<rafa> dkayiwa: can you see what Context.getAlertService().getAlertsByUser(null).iterate().next.getId() returns
|
17:16:18
|
<dkayiwa> rafa: ok let me do that
|
17:16:49
|
<rafa> dkayiwa: you can do that with an assert as well :)
|
17:17:06
|
<dkayiwa> rafa: sure :)
|
17:17:31
|
*** dawn_ has quit IRC
|
17:32:45
|
<dkayiwa> djazayeri: do you have a minute to respond to my question on TRUNK-3038 ?
|
17:32:54
|
<djazayeri> !ticket trunk-3038
|
17:32:56
|
<OpenMRSBot> djazayeri: [#TRUNK-3038] FieldGenDatatypeHandler and WebDatatypeHandler should both extend a new interface - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3038
|
17:33:32
|
<djazayeri> dkayiwa: yes, they're the same commits
|
17:33:47
|
<dkayiwa> djazayeri: ok thanks. so let me close it too
|
17:33:59
|
<djazayeri> You should be able to trust the list of revisions I put in TRUNK-3034
|
17:34:09
|
<dkayiwa> djazayeri: ok :)
|
17:42:26
|
<dkayiwa> rafa: the id for alert is 2 as you suspected :)
|
17:42:51
|
*** downey has quit IRC
|
17:43:07
|
<rafa> dkayiwa: I still wonder why it is different when run in eclipse and maven
|
17:43:21
|
<rafa> dkayiwa: but we shouldn't assume in the unit test that it's 1 :)
|
17:43:23
|
<dkayiwa> rafa: same here :(
|
17:43:31
|
<dkayiwa> rafa: i agree
|
17:43:41
|
<rafa> dkayiwa: so you can change it to get the first one
|
17:43:59
|
<rafa> dkayiwa: with iterate().next()
|
17:44:32
|
<dkayiwa> rafa: sure. thanks for the advice
|
17:44:42
|
*** downey has joined #openmrs
|
17:44:42
|
*** ChanServ sets mode: +o downey
|
17:44:42
|
*** OpenMRSBot sets mode: +o downey
|
17:44:50
|
<dkayiwa> rafa: let me do so and commit
|
17:44:56
|
<rafa> dkayiwa: np
|
17:46:32
|
<rafa> dkayiwa: I have a question for you
|
17:46:38
|
<dkayiwa> rafa: ok
|
17:46:55
|
<rafa> dkayiwa: I've got huge lags using 1.10
|
17:47:18
|
<rafa> dkayiwa: when I try to open a patient dashbaord for instance
|
17:47:26
|
<rafa> dkayiwa: it takes 60 secs!
|
17:47:43
|
<rafa> dkayiwa: I've just checked and all this time is spent in Concept.getNames
|
17:47:58
|
<rafa> dkayiwa: do you experience anything like that?
|
17:48:16
|
<dkayiwa> rafa: had not noticed but i can try it now
|
17:48:23
|
<dkayiwa> rafa: were you using the compiled version?
|
17:48:35
|
<dkayiwa> rafa: or running from eclipse?
|
17:48:41
|
<rafa> dkayiwa: it's every time I try
|
17:49:01
|
<rafa> dkayiwa: running mvn jetty:run from trunk in eclipse
|
17:49:17
|
<rafa> dkayiwa: (I'm not sure why that matters)
|
17:49:32
|
<dkayiwa> rafa: let em try it out
|
17:49:38
|
<rafa> dkayiwa: and I restarted and still the same
|
17:50:07
|
<rafa> dkayiwa: I'm running with MVP
|
17:50:16
|
<rafa> dkayiwa: so it's 40k+ concepts
|
17:50:26
|
<rafa> dkayiwa: but it wasn't that slow before
|
17:50:38
|
<dkayiwa> rafa: oh was used our usual demo data
|
17:50:45
|
<dkayiwa> used = using
|
17:51:18
|
<dkayiwa> rafa: i guess that is why i had not noticed it
|
17:51:50
|
<rafa> dkayiwa: hmm let me restart my pc and see if it helps
|
17:51:58
|
<dkayiwa> rafa: ok
|
17:54:39
|
*** james_regen has quit IRC
|
17:54:46
|
*** bwolfe has quit IRC
|
17:54:56
|
*** rafa has quit IRC
|
17:55:00
|
<sgithens> Anyone having problems gettign to the wiki?
|
17:55:06
|
*** james_regen has joined #openmrs
|
17:55:06
|
*** ChanServ sets mode: +v james_regen
|
17:55:11
|
<sgithens> I'm getting a 503
|
17:55:20
|
<dkayiwa> sgithens: yes
|
17:55:38
|
<dkayiwa> but now fine :)
|
17:58:06
|
*** rafa has joined #openmrs
|
17:58:06
|
*** ChanServ sets mode: +v rafa
|
17:58:47
|
<djazayeri> rafa: what happened with the patient dashboard? still slow?
|
17:59:19
|
<rafa> djazayeri: I've just restarted my pc. I'll test it again
|
18:09:43
|
<dkayiwa> hi rafa
|
18:09:51
|
<rafa> dkayiwa: yes?
|
18:10:06
|
<dkayiwa> rafa: will you be helping Wyclif on TRUNK-3057?
|
18:10:26
|
<rafa> wyclif said he'll attach a patch
|
18:10:42
|
<dkayiwa> rafa: but he says it is not satisfactory :)
|
18:10:45
|
<rafa> wyclif I'll look into that
|
18:11:08
|
<dewmal> hi, i am new for openmrs i am trying to build project using eclipse but i got this error [ERROR] No goals have been specified for this build. You must specify a valid lifecycle phase or a goal in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]:<goal>. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, genera
|
18:11:09
|
<dewmal> te-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-site, site, post-site, site-deploy, pre-clean, clean, post-clean. -> [Help 1]
|
18:11:09
|
<dewmal> [ERROR]
|
18:11:10
|
<dewmal> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
|
18:11:12
|
<dkayiwa> rafa: and besides he has another ticket i want him finish
|
18:11:12
|
<dewmal> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
|
18:11:13
|
<rafa> dkayiwa: I'll look into his patch :)
|
18:11:14
|
<dewmal> [ERROR]
|
18:11:16
|
<dewmal> [ERROR] For more information about the errors and possible solutions, please read the following articles:
|
18:11:18
|
<dewmal> [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/NoGoalSpecifiedException
|
18:11:21
|
<OpenMRSBot> <http://ln-s.net/9fIj> (at cwiki.apache.org)
|
18:11:21
|
<dkayiwa> rafa: thanks :)
|
18:11:38
|
<dkayiwa> dewmal: can you use pastebin.com?
|
18:11:54
|
<rafa> dkayiwa: djazayeri patient dashboard still very slow... :/
|
18:12:14
|
<djazayeri> rafa: must be a recent commit...
|
18:12:20
|
<rafa> djazayeri: I think so
|
18:12:26
|
<djazayeri> downey: do you know what's up with our performance testing rig?
|
18:12:43
|
<djazayeri> who needs to intervene to get that back up and running regularly?
|
18:12:48
|
<dewmal> dkayiwa : for what i haven idea about it
|
18:13:08
|
<dkayiwa> rafa: was it ok with the 1.9 beta release?
|
18:13:43
|
<rafa> dkayiwa: I can't say for sure
|
18:13:57
|
<rafa> dkayiwa: but I think I looked in there before and it worked fine
|
18:14:01
|
<djazayeri> rafa: you could profile, I guess
|
18:14:11
|
<downey> djazayeri: the system is working fine - http://buea.openmrs.org:8080/openmrs - i think it's the tests that are broken
|
18:14:32
|
<dewmal> http://pastebin.com/CP348KPK
|
18:14:33
|
<djazayeri> downey: do you remember if that system resets its DB every run?
|
18:15:34
|
<dewmal> http://pastebin.com/CP348KPK this is the error msg i got when try to built it
|
18:16:03
|
<downey> djazayeri: i don't believe so, no
|
18:16:32
|
<djazayeri> downey: I'm looking at the TEST-PERF in CI, and I can't figure out what the relevant error message would be
|
18:16:37
|
*** suranga__ has joined #openmrs
|
18:17:24
|
<downey> djazayeri: no messages IIRC, it just hung. https://ci.openmrs.org/browse/TEST-PERF-JOB1-982/log
|
18:18:26
|
<rafa> djazayeri: I've just done it. It's definitely something around concepts. It took 66787 secs to execute getConcept(String)
|
18:18:28
|
<djazayeri> downey: can we access the buea logs for that time?
|
18:18:40
|
<rafa> djazayeri: I'll create a ticket and attach the snapshot
|
18:18:45
|
<djazayeri> rafa: interesting. okay
|
18:19:07
|
<downey> djazayeri: they've long since rolled away unfortunately. we can try to recreate the error
|
18:19:15
|
<djazayeri> downey: alternately, can we re-run the tests now, and look at the logs now
|
18:19:16
|
<djazayeri> yeah
|
18:19:18
|
<djazayeri> recreate it
|
18:19:38
|
<dewmal> I got this message when 1st building openmrs project
|
18:19:40
|
<dewmal> http://pastebin.com/CP348KPK
|
18:20:10
|
<djazayeri> dewmal: what command did you run?
|
18:20:41
|
*** mnunez has joined #openmrs
|
18:20:41
|
<dewmal> maven-build
|
18:20:46
|
*** suranga_ has quit IRC
|
18:20:56
|
<djazayeri> dewmal: the first time you need to do "mvn install"
|
18:21:01
|
<djazayeri> or maven install in the IDE
|
18:22:08
|
<dewmal> ok
|
18:22:40
|
<suranga__> james_regen, i'll be going off now... will talk to you again tomorrow ? :)
|
18:22:56
|
<dewmal> djazayeri: it take long time , i will let you know after i did it. thank you
|
18:23:03
|
<mnunez> rafa: I'm using the new MDS to copy most of the items from a 1.8.2 to a 1.8.3 we'll be using for production stage. Problem is I'm getting lot's of "Concept [adsfadsfa] failed validation".
|
18:23:32
|
<mnunez> rafa: Is there a way to validate all concepts before export? Will the Validation Module work in 1.8.2?
|
18:23:55
|
<rafa> mnunez: yes, the validation module is your best bet
|
18:24:24
|
<rafa> mnunez: you need to fix concepts before exporting them
|
18:24:33
|
*** suranga has joined #openmrs
|
18:24:56
|
<mnunez> rafa: They're from the MCL database. Nearly 5K concepts... this is going to take a while...
|
18:25:15
|
<rafa> mnunez: I ran it on 40k concepts.
|
18:25:33
|
<rafa> mnunez: I've tweaked it a lot
|
18:25:39
|
<rafa> mnunez: it uses multiple threads
|
18:26:06
|
<rafa> mnunez: so it's resource intensive
|
18:26:56
|
<downey> djazayeri - https://ci.openmrs.org/browse/TEST-PERF-JOB1-984/log -- nothing at all in catalina.out
|
18:27:32
|
<rafa> mnunez: but it should take at most a few hours
|
18:28:01
|
*** suranga__ has quit IRC
|
18:28:45
|
<mnunez> rafa: Great. Giving it a try. It should be a good idea to run it in the MCL main database
|
18:29:41
|
<mnunez> rafa: also, it would be nice to have a "kill task" button in Task Managment in the MDS.
|
18:30:24
|
<djazayeri> downey: thanks, I've tagged this for next week's bugfix sprint
|
18:30:28
|
<djazayeri> TRUNK-2967
|
18:30:44
|
<downey> djazayeri: actually i found a problem, sorry
|
18:30:54
|
<rafa> mnunez: sure, I'll add that. Can you enter a ticket so that I remember? :)
|
18:31:03
|
<mnunez> rafa: On it. Thanks!
|
18:31:09
|
<downey> djazayeri: still was looking for 180 context
|
18:31:54
|
<rafa> mnunez: You should probably build the validation module from trunk
|
18:32:00
|
<djazayeri> downey: that'd explain it
|
18:32:04
|
<rafa> mnunez: I'm not sure if I uploaded the latest version to the repo
|
18:32:04
|
<dewmal> hi now i got this error http://pastebin.com/8Ynj4Cmm
|
18:32:06
|
<djazayeri> that said, buea is running 1.9-alpha
|
18:32:28
|
<downey> djazayeri, yeah, but we can easily change what is deployed there
|
18:32:29
|
<djazayeri> downey: we need to have it use trunk, e.g. to identify issues like the one rafa just ran into
|
18:32:35
|
<downey> djazayeri: ok
|
18:33:04
|
<djazayeri> dewmal: can you paste the *complete* output?
|
18:33:12
|
<djazayeri> e.g. it says tests failed, but which ones?
|
18:37:08
|
*** suranga has quit IRC
|
18:39:57
|
<dewmal> djazayeri : pasting but some parts are not yet with it.they were removed by ide.
|
18:40:14
|
<djazayeri> dewmal: did you do a clean checkout of trunk?
|
18:40:19
|
<djazayeri> and you've done an svn update?
|
18:41:19
|
<dewmal> no i did only svn check out.let me try with it.and i will let you know about next
|
18:41:33
|
<djazayeri> dewmal: if you did an svn checkout recently, it should be working
|
18:41:47
|
<djazayeri> you need to figure out which tests failed when you did mvn install
|
18:41:51
|
<djazayeri> (are you on a Mac?)
|
18:42:07
|
<dewmal> no i am on ubuntu 11.10
|
18:42:31
|
<djazayeri> hmm, okay, well, figure out which test is failing
|
18:44:11
|
<dewmal> yes it is still uploading
|
18:44:30
|
<dewmal> to pastbin.com give me a few minutes
|
18:45:37
|
*** maurya has joined #openmrs
|
18:47:17
|
<djazayeri> dewmal: use pastebin, and paste a link on the public channel
|
18:48:38
|
*** mvorobey has quit IRC
|
18:51:15
|
*** james_regen has left #openmrs
|
18:57:33
|
*** dewmal has quit IRC
|
18:58:54
|
<mnunez> djazayeri: I do not have the "Maven -- Run as package" in my Eclipse. Would you know how to add it?
|
18:59:27
|
<djazayeri> mnunez: you mean Run As -> Maven package?
|
18:59:29
|
<mnunez> djazayeri: run as -- Maven package
|
18:59:44
|
<mnunez> djazayeri: yeah, that's the one
|
18:59:44
|
<djazayeri> mnunez: do you see the Run As -> Maven * options at all?
|
18:59:55
|
<mnunez> djazayeri: yeap
|
19:00:19
|
<mnunez> djazayeri: Maven is working. OpenMRS 1.8.3 deployed in Eclipse
|
19:01:34
|
<djazayeri> mnunez: no idea then
|
19:01:48
|
<djazayeri> just package is missing? I haven't seen that before
|
19:01:49
|
<rafa> mnunez: if you choose run as -- maven build you should see a dialog to enter a goal you want
|
19:01:59
|
<rafa> mnunez: you can enter there package
|
19:02:12
|
<rafa> mnunez: next time you click run as -- mavne build
|
19:02:33
|
<rafa> mnunez: you won't see the dialog and it'll be packaged
|
19:02:48
|
*** mvorobey has joined #openmrs
|
19:02:56
|
<mnunez> rafa: Thanks rafa, giving it a try
|
19:05:14
|
<rafa> mnunez: note that if you have more launch configuations for a project you'll see the "select configuration" dialog
|
19:05:54
|
<rafa> mnunez: to edit them you need to go to run - run configurations...
|
19:06:57
|
*** wyclif has joined #openmrs
|
19:07:26
|
<rafa> mnunez: alt + shift + x then m is a great shortcut ;)
|
19:09:03
|
<mnunez> rafa: it fails to build the omod itself... http://pastebin.com/MK6hw9jL
|
19:09:29
|
<rafa> mnunez: ohh the first time you need to install
|
19:09:33
|
*** dewmal has joined #openmrs
|
19:09:34
|
<rafa> mnunez: goal install
|
19:10:04
|
<rafa> mnunez: so that the api subproject gets installed in your local repo and the omod subproject can use it for build
|
19:10:06
|
<mnunez> rafa: ah ok
|
19:10:21
|
<rafa> mnunez: actually I always use install
|
19:10:36
|
<dewmal> it is not working.i will try again
|
19:10:42
|
<rafa> mnunez: not sure if there's any reason to use package
|
19:10:45
|
<dewmal> i mean pastbin.com
|
19:11:36
|
<rafa> mnunez: maybe to skip tests, but that you can achieve in install too
|
19:11:57
|
*** mvorobey has quit IRC
|
19:23:36
|
<chopin> i always use install -DskipTests
|
19:23:37
|
<chopin> :-Dx
|
19:23:46
|
<chopin> until i'm done testing by hand
|
19:23:54
|
<chopin> but i'd never do that before releasing a new version
|
19:23:57
|
<chopin> fyi
|
19:25:51
|
*** Echidna has quit IRC
|
19:29:26
|
<mnunez> rafa: I asked about package because the tutorial says so... never got into maven. First two subprojects build fine, but the omod is having problems http://pastebin.com/index/MK6hw9jL
|
19:29:54
|
<mnunez> rafa: any hints?
|
19:32:31
|
<rafa> mnunez: the api is still not installed to your local repo
|
19:32:41
|
<rafa> mnunez: did you run mvn install?
|
19:34:03
|
<rafa> mnunez: from your pastebin I can tell you ran mvn package
|
19:34:55
|
<mnunez> rafa: That's an old pastebin. I'm running Maven Install in the main project folder (validation)
|
19:35:33
|
<rafa> mnunez: and can you show me a new pastebin :) ?
|
19:36:25
|
<mnunez> rafa: http://pastebin.com/7MyWC6ZV sorry, wrong pastebin :p
|
19:37:31
|
<mnunez> rafa: I copied the URL before writing the captcha :D
|
19:37:43
|
<rafa> mnunez: I fixed it
|
19:37:50
|
<rafa> mnunez: do svn update
|
19:37:55
|
<rafa> mnunez: should build fine now
|
19:38:16
|
<rafa> mnunez: omod required api in verion 1.0, but it should have been 1.0.1
|
19:40:14
|
*** dkayiwa_ has joined #openmrs
|
19:40:56
|
*** dkayiwa has quit IRC
|
19:40:57
|
*** dkayiwa_ is now known as dkayiwa
|
19:41:03
|
<mnunez> rafa: Glad to know, thanks!
|
19:42:37
|
<rafa> mnunez: you're welcome
|
19:42:59
|
<mnunez> rafa: There's no documentation available for this module, mind if I start a wiki?
|
19:43:32
|
<rafa> mnunez: go ahead!
|
19:43:35
|
*** Echidna has joined #openmrs
|
19:43:35
|
*** ChanServ sets mode: +v Echidna
|
19:43:38
|
<rafa> mnunez: thanks in advance! :D
|
19:47:15
|
<mnunez> rafa: Actually, how does it works? I enter "org.openmrs.Concept" in "Enter type to validate", click send...
|
19:47:41
|
<mnunez> rafa: And nothing seems to happen, at least in the interface.
|
19:47:51
|
<rafa> mnunez: can you refresh?
|
19:48:16
|
<mnunez> rafa: Done. Still nothing.
|
19:48:27
|
<rafa> mnunez: hmm
|
19:48:39
|
<mnunez> rafa: want a log?
|
19:48:53
|
<rafa> mnunez: let me try it myself first
|
19:49:28
|
<mnunez> rafa: FYI, I'm using a 1.8.2 OMRS
|
19:50:06
|
<mnunez> rafa: I want to validate the concept database so I can move it to a 1.8.3 production version.
|
19:50:31
|
<rafa> mnunez: hmm works fine on 1.9, let me start 1.8
|
19:53:30
|
<rafa> mnunez: it doesn't work on 1.8
|
19:53:32
|
<rafa> :)
|
19:53:37
|
<rafa> mnunez: but the fix should be easy
|
19:55:10
|
<mnunez> rafa: Perfect. Are you free right now or shoud I make a ticket?
|
19:55:26
|
<rafa> mnunez: I'll commit in a moment
|
19:55:54
|
<mnunez> hug(rafa)
|
19:59:38
|
<rafa> mnunez: done
|
20:02:38
|
<rafa> mnunez: just to be clear it'll only produce a report for you which concepts need to be fixed
|
20:02:45
|
<rafa> mnunez: you'll have to fix them manually
|
20:02:56
|
*** maurya has quit IRC
|
20:06:06
|
<mnunez> rafa: Good. What validators can be used?
|
20:06:26
|
<rafa> mnunez: It's ConceptValidator
|
20:06:49
|
<rafa> mnunez: most likely you'll see errors like duplicate concept names
|
20:07:24
|
<rafa> mnunez: if you change one of duplicate names, you'll be fine
|
20:08:38
|
<mnunez> rafa: worse, I'm looking at lot's of "At least one non-empty name is required". Those cannot be deleted from the UI...
|
20:09:28
|
<rafa> mnunez: That means you need to add a name. It's doable from the UI.
|
20:09:58
|
<mnunez> rafa: whenever I search for the concept to add a name, I get a "Error while attempting to find concepts - null"
|
20:10:10
|
<rafa> mnunez: If you open an invalid concept, you shouldn't be able to save it until it's valid
|
20:10:19
|
<rafa> mnunez: Can you search by id?
|
20:10:55
|
<rafa> mnunez: If you know the id you can open a concept with a URL
|
20:11:38
|
<rafa> mnunez: it goes like: http://localhost:8080/openmrs/dictionary/concept.htm?conceptId=1065
|
20:12:49
|
<mnunez> rafa: allright, I just tried from the search box. That's working, thanks.
|
20:13:04
|
<mnunez> rafa: This is going to take a while...
|
20:13:38
|
<rafa> mnunez: yeah... I know :/
|
20:14:05
|
<rafa> mnunez: but there's no workaround. OpenMRS doesn't allow to save invalid concepts.
|
20:14:13
|
<mnunez> rafa: what if the MDS had an option to export only valid concepts?
|
20:15:30
|
<rafa> mnunez: yeah we could display a warning when you try to add invalid concepts
|
20:15:40
|
<mnunez> rafa: such as "Add all", "Add non-retired", "Add only valids"
|
20:16:59
|
<rafa> mnunez: I'd rather say that if you choose concepts we would display invalid concepts and let you skip them
|
20:17:01
|
<mnunez> rafa: I'm not sure if it's worth it... there shouldn't be invalids concepts anyways...
|
20:17:30
|
<rafa> mnunez: we do the validation anyway so it's a matter of doing it in an earlier step
|
20:17:41
|
<rafa> mnunez: it's worth considering
|
20:19:06
|
<mnunez> rafa: for the wiki: I have 10 tasks in running in the validator, each with 4849 concepts I guess, is that so?
|
20:19:16
|
<mnunez> rafa: are they running in parallel?
|
20:19:23
|
<rafa> mnunez: yes
|
20:19:34
|
<rafa> mnunez: to make it faster
|
20:19:47
|
<rafa> mnunez: so you have 48490 concepts in total
|
20:19:57
|
<mnunez> rafa: allways 10?
|
20:20:12
|
<rafa> mnunez: yeah I make it constant
|
20:20:28
|
<mnunez> rafa: good.
|
20:20:37
|
<rafa> mnunez: actually I don't think you should be trying to fix the dict yourself
|
20:20:56
|
<rafa> mnunez: as I said I'm working on fixing the MVP dict
|
20:21:08
|
<rafa> mnunez: which happens to be the MCL dict :)
|
20:21:43
|
<mnunez> rafa: Are you the one that made the scripts for importing it to 1.8?
|
20:21:52
|
<rafa> mnunez: no
|
20:22:31
|
<rafa> mnunez: but my point is that we'll fix it sooner or later
|
20:22:46
|
<rafa> mnunez: I only can't give you precise date
|
20:23:34
|
*** dkayiwa has quit IRC
|
20:24:02
|
<mnunez> rafa: Ok. So if I build some forms now against a custom database, would I be able to import later the MVP dictionary from the MDS module? This time keeping my own IDs.
|
20:25:01
|
<rafa> mnunez: the MDS is not really intended to work this way
|
20:25:46
|
<rafa> mnunez: it's better suited if you only want to import some concepts
|
20:25:55
|
<mnunez> rafa: I thought they shared UUIDs among dictionaries, but IDs were implementation dependand...
|
20:26:01
|
<rafa> mnunez: or a form with concepts
|
20:27:25
|
<rafa> mnunez: my point is that if you have a custom db, you'll want to merge some of your concepts with the ones from the MVP dict
|
20:27:45
|
<rafa> mnunez: if you have thousands of concepts, the merging will be really painful
|
20:27:48
|
<mnunez> rafa: and the opposite as well.
|
20:28:55
|
<mnunez> rafa: If I were looking for 1000 maternity concepts, would I be able to import them?
|
20:29:49
|
<mnunez> rafa: So that I shared my neurological concepts and recieved maternity concept, for example.
|
20:30:11
|
<rafa> mnunez: and would they be newly created concepts or requried merging?
|
20:30:12
|
<mnunez> rafa: Without concept colisions
|
20:31:30
|
<mnunez> rafa: I'll guess it will require merging. There would be new concepts added to each local dictionary often.
|
20:31:45
|
<mnunez> rafa: It's that the use case it is intended for?
|
20:32:40
|
<mnunez> rafa: synonyms are bound to happen. I've seen concepts in the MVP mapped to another concept in the same dictionary...
|
20:33:13
|
<rafa> mnunez: yeah it only gets complicated when you have a lot of colisions
|
20:33:25
|
<rafa> mnunez: they cannot always be resolved
|
20:33:40
|
<rafa> mnunez: you can't merge concepts with different datatypes or classes for instance
|
20:33:57
|
<mnunez> rafa: my way to try and avoid them was to import the whole MVP database before starting with the forms. But since it has so many invalids...
|
20:34:36
|
<rafa> mnunez: yeah that would be the right way to go
|
20:34:45
|
*** dewmal has quit IRC
|
20:35:41
|
<rafa> it's a lot easier to start with the MVP db
|
20:35:47
|
<mnunez> mnunez: I was hoping to avoid importing the .sql script I imported in the 1.8.2 again in the 1.8.3
|
20:36:40
|
<mnunez> mnunez: But it looks like I'll just have to. And with that I'll import a couple of thousand invalids aswell...
|
20:37:50
|
<rafa> mnunez: I'll look into those invalid concepts again by Monday.
|
20:38:28
|
<rafa> mnunez: If I find a straightforward way to fix them. I'll also be able to export them as the MDS package.
|
20:43:47
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Validation Module 1.0.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=validation&version=&1.0.1>
|
20:52:15
|
<mnunez> rafa: https://wiki.openmrs.org/display/docs/Validation+Module
|
20:54:15
|
<mnunez> rafa: something to add there?
|
20:54:33
|
<rafa> mnunez: Thanks!
|
20:54:42
|
<rafa> mnunez: You can validate basically any type. org.openmrs.Patient should work for instance.
|
20:55:04
|
<rafa> or org.openmrs.Location
|
20:55:44
|
<mnunez> rafa: Right. Changing
|
20:58:48
|
<rafa> mnunez: it would be good to include a link to svn
|
21:01:36
|
<mnunez> rafa: done
|
21:02:43
|
<rafa> mnunez: well done :)
|
21:02:48
|
<mnunez> rafa: not a great work of art, but it's a pretty straighforward module.
|
21:03:30
|
<rafa> I've uploaded the latest version to the module repo as well :)
|
21:03:53
|
*** downey_ has joined #openmrs
|
21:03:53
|
*** ChanServ sets mode: +o downey_
|
21:06:55
|
*** downey has quit IRC
|
21:06:55
|
*** downey_ is now known as downey
|
21:29:47
|
<sgithens> Where do jsp's get mapped to their controllers? ( like /dictionary/concept.htm: concept.jsp -> ConceptFormController.java )
|
21:30:04
|
<sgithens> or if it's not excplicitly listed somewhere, what metadata gets used to map them?
|
21:36:31
|
*** bryq has quit IRC
|
21:42:44
|
*** rafa has quit IRC
|
21:43:26
|
*** chopin has quit IRC
|
21:49:20
|
*** Echidna has quit IRC
|
21:56:42
|
*** Echidna has joined #openmrs
|
21:56:42
|
*** ChanServ sets mode: +v Echidna
|
22:11:56
|
*** sgithens has quit IRC
|
22:25:36
|
*** downey has quit IRC
|
22:26:29
|
*** bryq has joined #openmrs
|
22:26:29
|
*** ChanServ sets mode: +v bryq
|
22:28:54
|
*** mnunez has left #openmrs
|
22:38:20
|
*** bryq has quit IRC
|
23:08:15
|
*** wyclif has quit IRC
|
23:43:46
|
*** Echidna has quit IRC
|
23:43:54
|
*** Echidna has joined #openmrs
|
23:43:54
|
*** ChanServ sets mode: +v Echidna
|