| 00:31:34 | *** wyclif has joined #openmrs |
| 00:53:14 | *** harshadura has quit IRC |
| 01:44:48 | *** Jibesh has joined #openmrs |
| 01:45:49 | *** Jibesh has quit IRC |
| 02:44:35 | *** suranga has joined #openmrs |
| 03:23:15 | *** harshadura has joined #openmrs |
| 03:33:04 | <suranga> hello harshadura |
| 03:33:08 | <suranga> r u there ? |
| 03:34:48 | <harshadura> hi ayya |
| 03:35:46 | <suranga> hello dude, sorry about yesterday |
| 03:36:06 | <suranga> office eke wada adagana naaanawa :P |
| 03:36:50 | <harshadura> its okay ayya. :) |
| 03:37:03 | <suranga> tell me your problem, mama office eke inne, i'll try to answer.... |
| 03:38:58 | *** burke has quit IRC |
| 05:04:16 | *** harshadura has quit IRC |
| 05:04:29 | *** dewmal has joined #openmrs |
| 05:04:37 | *** harshadura has joined #openmrs |
| 05:08:31 | *** harshadura has quit IRC |
| 05:08:40 | *** dewmal has left #openmrs |
| 05:11:09 | *** dewmal has joined #openmrs |
| 05:11:25 | *** harshadura has joined #openmrs |
| 05:13:48 | <dewmal> msg nickserv register dewmal91 dewmalnilanka@gmail.com |
| 05:15:50 | <dewmal> sorry |
| 05:31:13 | *** harshadura has quit IRC |
| 05:52:47 | *** harshadura has joined #openmrs |
| 05:53:05 | <harshadura> hi anyone thr |
| 05:53:41 | <djazayeri> harshadura: hi |
| 05:53:58 | <harshadura> i hv small problem on this bug > https://tickets.openmrs.org/browse/TRUNK-2768 |
| 05:54:35 | <harshadura> i hv created the changeset regarding death date estimated |
| 05:54:47 | <harshadura> but when building it gives a problem |
| 05:54:56 | <harshadura> heres what i hv added for the changeset |
| 05:55:54 | <harshadura> http://pastebin.com/JCXpeghG |
| 05:56:04 | <harshadura> pls can u tell me whats the error |
| 05:56:13 | <harshadura> i am getting an error like this |
| 05:56:36 | <harshadura> ERROR - JDBCExceptionReporter.logExceptions(234) |2012-02-21 10:27:37,766| Unknown column 'person0_.death_date_estimated' in 'field list' |
| 05:57:52 | <djazayeri> harshadura: there are a couple errors in there, I assume caused by copying-and-pasting without changing everything necessary |
| 05:58:02 | <djazayeri> first, the precondition is wrong |
| 05:58:18 | <harshadura> sorry is that |
| 05:58:27 | <djazayeri> the precondition should check whether the person.death_date_estimated column exists |
| 05:58:42 | <harshadura> pls can u point me the errors im bit new to liquibase |
| 05:58:49 | <harshadura> thx lot for helping |
| 05:58:56 | <djazayeri> harshadura: then, you are adding a column to the wrong table. |
| 05:59:26 | <djazayeri> As I mentioned on email, you should be adding death_date_estimated to the *person* table. |
| 05:59:45 | <djazayeri> harshadura: you're doing this addColumn tableName="relationship_type" |
| 05:59:53 | <djazayeri> which will add the column to the relationship_type table. |
| 06:00:10 | <harshadura> oops |
| 06:00:18 | <harshadura> yes it was a mistake |
| 06:00:37 | <djazayeri> also, the comment is wrong in that it also mentions the relationship type table |
| 06:01:13 | <djazayeri> you're going to need to change this, rebuild, and you're going to need to manually delete the changeset from your database |
| 06:01:23 | <harshadura> djazayeri : pls can u tell whats this line does |
| 06:01:24 | <harshadura> <preConditions onFail="MARK_RAN"> |
| 06:01:38 | <djazayeri> e.g. delete from liquibasechangelog where id = ''20120218-1050' |
| 06:01:52 | <harshadura> ok |
| 06:02:04 | <djazayeri> because when you change the content of the changeset, it will have a different checksum |
| 06:02:23 | <harshadura> yes |
| 06:02:52 | <djazayeri> harshadura: regarding precondition, that means "first, check the following condition. And if it fails, just mark the changeset as 'already ran'" |
| 06:03:28 | <djazayeri> e.g. you should have a precondition that checks whether person.death_date_estimated does not already exist. |
| 06:03:42 | <harshadura> thx lot djazayeri. now i got the case |
| 06:03:48 | <djazayeri> if the precondition fails (i.e. the column *does* exist), you just do MARK_RAN, and that skips the changeset |
| 06:03:48 | <harshadura> thx again |
| 06:03:50 | <djazayeri> good luck |
| 06:05:49 | *** dkayiwa has joined #openmrs |
| 06:16:07 | <harshadura> hi djazayeri |
| 06:16:09 | <harshadura> u thr |
| 06:16:15 | <djazayeri> yes |
| 06:16:34 | <harshadura> thx that error resolved nw |
| 06:16:50 | <harshadura> now im working for the view part the jsp thing |
| 06:17:30 | <harshadura> so the thing i want to knw frm u is where the labels of the view are saved? |
| 06:17:43 | <harshadura> is thr any property file |
| 06:21:12 | <harshadura> okay sorry i got it |
| 06:21:15 | <harshadura> thx |
| 06:23:29 | *** dewmal has quit IRC |
| 06:25:01 | <suranga> harshadura, dude r u there ? |
| 06:25:21 | <harshadura> yes ayya |
| 06:25:24 | *** sthaiya has joined #openmrs |
| 06:25:43 | <suranga> machan, ada enna epa |
| 06:25:52 | <suranga> small problem, I have to drop all and go to campus |
| 06:26:23 | <suranga> I will buzz u in the evening, to tell whats happening |
| 06:26:52 | <harshadura> okay ayye catch u later shape |
| 06:27:01 | <suranga> sorry dude, will call u |
| 06:27:06 | <suranga> urgent problem :-( |
| 06:27:40 | <harshadura> aioo kamak naha ayye shape |
| 06:28:51 | *** dkayiwa_ has joined #openmrs |
| 06:29:55 | *** dkayiwa has quit IRC |
| 06:29:55 | *** dkayiwa_ is now known as dkayiwa |
| 06:35:15 | *** dkayiwa_ has joined #openmrs |
| 06:35:33 | *** dkayiwa has quit IRC |
| 06:35:34 | *** dkayiwa_ is now known as dkayiwa |
| 06:37:17 | *** ibewes has joined #openmrs |
| 06:40:32 | *** dewmal has joined #openmrs |
| 06:41:12 | <ibewes> hello all! |
| 06:42:11 | <dkayiwa> hey |
| 06:46:58 | <ibewes> I've got a newb question about the module tutorial, can you help? |
| 06:48:08 | <dkayiwa> here you just ask and anyone can respond. in otherwards you do not wait for someone to say, "i will help" :) |
| 06:49:29 | <ibewes> heh, ah yes... newb all the way around :) |
| 06:49:31 | <ibewes> I'm just trying to follow steps here: https://wiki.openmrs.org/display/docs/Creating+Your+First+Module |
| 06:49:32 | <OpenMRSBot> <http://ln-s.net/8c6T> (at wiki.openmrs.org) |
| 06:50:34 | <ibewes> when I get to step 3d it assumes that I have a package in the project, but it is just the plain java files... I know I'm missing something basic, but I'm not sure what |
| 06:59:49 | *** dkayiwa has quit IRC |
| 07:00:04 | *** dkayiwa has joined #openmrs |
| 07:04:42 | <harshadura> hi thr I am working on TRUNK 2768 bug. I want to knw is whether the system hv to store estimated death date or not? or only jz the check box |
| 07:04:54 | <harshadura> https://tickets.openmrs.org/browse/TRUNK-2768 |
| 07:05:01 | *** dewmal has quit IRC |
| 07:30:05 | <dkayiwa> ibewes am not sure i understand your question :) |
| 07:30:37 | <ibewes> yeah, I'm not sure I understand the problem... heh |
| 07:31:22 | <ibewes> I *think* the issue is that the maven project is not creating (or whatever) the <module_name>-api and <module_name>-omod projects in eclipse |
| 07:31:25 | <dkayiwa> harshadura: yes it has to store the estimated death date flag |
| 07:32:01 | <ibewes> for example, when I check out the registration module it shows up as three projects in eclipse, registration, registration-api, and registration-omod |
| 07:32:04 | <dkayiwa> harshadura: just like it stores the estimated birth date flag |
| 07:32:56 | <dkayiwa> ibewes: you could as well create a new module from scratch using the maven module architype |
| 07:33:59 | <ibewes> ok, i'll try that out |
| 07:50:08 | *** dkayiwa has quit IRC |
| 07:53:02 | *** dewmal has joined #openmrs |
| 07:54:35 | *** dkayiwa has joined #openmrs |
| 08:05:35 | *** bryq has joined #openmrs |
| 08:05:35 | *** ChanServ sets mode: +v bryq |
| 08:30:53 | *** dewmal has quit IRC |
| 08:54:43 | *** dkayiwa has quit IRC |
| 08:54:49 | *** michael has joined #openmrs |
| 08:55:11 | <michael> hi cyclif |
| 08:55:15 | *** michael is now known as Guest2132 |
| 08:55:59 | <Guest2132> helo wyclif |
| 09:01:24 | *** suranga_ has joined #openmrs |
| 09:01:24 | *** suranga has quit IRC |
| 09:02:16 | *** dewmal has joined #openmrs |
| 09:05:01 | *** Guest2132 has quit IRC |
| 09:15:40 | *** rafa has joined #openmrs |
| 09:15:40 | *** ChanServ sets mode: +v rafa |
| 09:48:47 | <harshadura> hi anyone thr |
| 09:48:59 | <harshadura> anyone knw whats the jsp code |
| 09:49:07 | <harshadura> showCalendar(this, 60) means? |
| 09:49:58 | <harshadura> for the death date estimated i want to enable future dates rather than stick with the existing birthdate range. |
| 09:50:10 | <harshadura> so how could i increase the date range? |
| 09:50:12 | <harshadura> any ideas? |
| 10:08:04 | *** dkayiwa has joined #openmrs |
| 10:30:03 | *** dkayiwa has quit IRC |
| 10:33:51 | *** dkayiwa has joined #openmrs |
| 10:35:23 | *** djazayeri has quit IRC |
| 10:35:45 | *** djazayeri has joined #openmrs |
| 10:35:45 | *** ChanServ sets mode: +o djazayeri |
| 10:46:00 | *** chopin has joined #openmrs |
| 10:49:18 | *** ChanServ sets mode: +v chopin |
| 10:57:17 | *** suranga_ has quit IRC |
| 11:41:21 | <dkayiwa> hahahaha hi chopin :D |
| 11:45:35 | *** pushkar has joined #openmrs |
| 11:59:08 | *** harshadura has quit IRC |
| 12:07:48 | <dkayiwa> djazayeri: are you awake? |
| 12:17:31 | *** harshadura has joined #openmrs |
| 12:25:58 | *** james_regen has joined #openmrs |
| 12:25:58 | *** ChanServ sets mode: +v james_regen |
| 12:35:51 | *** pushkar has quit IRC |
| 12:42:22 | *** dkayiwa has quit IRC |
| 12:55:50 | *** downey has joined #openmrs |
| 12:55:50 | *** ChanServ sets mode: +o downey |
| 12:55:50 | *** OpenMRSBot sets mode: +o downey |
| 13:08:59 | *** bryq has quit IRC |
| 13:10:34 | <harshadura> hi anyone thr |
| 13:27:39 | *** ibewes has quit IRC |
| 13:30:06 | <harshadura> hi |
| 13:30:11 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Learn how #OpenMRS & others are improving & saving lives with mobile phones: "Kenya's Startup Boom": http://t.co/MJZtktas #ICT4D #mHealth <http://twitter.com/OpenMRS/statuses/171942015058194432> |
| 13:31:36 | <harshadura> I have halfway completed the bug ticket of TRUNK-2768. so can I commit those changes to the repo? |
| 13:36:56 | *** sgithens has joined #openmrs |
| 13:37:08 | <downey> Hi sgithens and welcome to the #openmrs IRC channel. |
| 13:37:19 | <sgithens> downey: cheers! |
| 13:38:19 | <harshadura> hi downey : u thr |
| 13:43:32 | *** bwolfe has joined #openmrs |
| 13:43:32 | *** ChanServ sets mode: +o bwolfe |
| 13:45:49 | *** dewmal has quit IRC |
| 13:46:32 | *** harshadura has quit IRC |
| 13:47:30 | *** harshadura has joined #openmrs |
| 14:00:12 | *** dewmal has joined #openmrs |
| 14:00:17 | <downey> Hi dewmal and welcome to the #openmrs IRC channel. |
| 14:11:30 | <dewmal> hi |
| 14:20:02 | *** sthaiya has quit IRC |
| 14:28:18 | <harshadura> hi downey |
| 14:28:22 | <harshadura> u thr |
| 14:31:45 | *** sgithens has quit IRC |
| 14:31:47 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Metadata Sharing 1.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=metadatasharing&version=&1.0> |
| 14:37:03 | <bwolfe> rafa++ |
| 14:37:04 | <bwolfe> :-) |
| 14:37:58 | <harshadura> hi bwolfe |
| 14:37:59 | <harshadura> u thr |
| 14:54:12 | <bwolfe> hi harshadura |
| 14:54:17 | *** sgithens has joined #openmrs |
| 14:54:47 | <sgithens> Is it expected that all test cases in trunk should be passing right now when doing a maven build? |
| 14:58:32 | <harshadura> hi bwolfe : I have halfway completed the bug ticket of TRUNK-2768. so can I commit those changes to the repo? |
| 14:58:45 | <harshadura> https://tickets.openmrs.org/browse/TRUNK-2768 |
| 15:05:08 | <bwolfe> sgithens, yes, all should pass. what isn't? |
| 15:05:22 | <bwolfe> sgithens, http://ci.openmrs.org runs the tests after each commit |
| 15:06:19 | <bwolfe> harshadura, great! |
| 15:06:26 | <bwolfe> harshadura, you should attach a patch to the ticket. see https://wiki.openmrs.org/display/docs/Patches |
| 15:06:59 | <sgithens> bwolfe: Will another build with tests on in just a sec |
| 15:07:06 | <sgithens> s/Will/Will run/ |
| 15:18:06 | *** downey has quit IRC |
| 15:44:15 | <sgithens> bwolfe: http://pastebin.com/kJ2ewinG |
| 16:00:28 | <harshadura> hi bwolfe |
| 16:01:21 | <harshadura> i hv jz added the patch to the ticket and requested code review. |
| 16:01:41 | <harshadura> hope to hear from you soon. thanks |
| 16:18:23 | <bwolfe> sgithens, sorry, I just upgraded ubuntu and am trying out Unity again...the notifications suck! |
| 16:18:35 | <bwolfe> a tiny blue light?? how is that supposed to get my attention? :-/ |
| 16:18:52 | <bwolfe> harshadura, is this the half-way one, or a complete one? |
| 16:19:00 | <bwolfe> harshadura, do you need feedback from me asap? |
| 16:19:08 | <bwolfe> sgithens, https://ci.openmrs.org/browse/JUNIT-TRUNK/latest is passing |
| 16:19:16 | <sgithens> bwolfe: hahahah. I usually use xchat, and it just kind of bounces on the dock bar a few times, so if I don't see it right away I miss it. |
| 16:19:16 | <bwolfe> sgithens, I'm updating my local to see if it fails for me too |
| 16:20:32 | *** dewmal has quit IRC |
| 16:20:45 | <harshadura> bwolfe : yeah still few things yet to be done, but halfway completed. I am glad if you can review asap. thx |
| 16:24:16 | <bwolfe> sgithens, yeah, I'm in xchat and get the single wobble...which I usually miss |
| 16:24:34 | <bwolfe> I'm thinking of switching from unity to gnome3 to see if there are more options for that |
| 16:27:54 | <sgithens> bwolfe: I tried the gnome-shell for the first time last week, and was a little discombobulated. I might just need more time to get use to it. Unity leaves a bit to be desired, but at least it's really simple. Gnome3 felt like everything was just scattered all over the place, but I probably need to spend some more time with it. |
| 16:28:22 | <sgithens> Does OpenMRS have scaffolding for background tasks? Like with quartz or something? |
| 16:30:18 | <bwolfe> sgithens, it has Scheduled Tasks |
| 16:30:44 | <bwolfe> Context.getSchedulerService() maybe? |
| 16:31:32 | <sgithens> bwolfe: Ah, great I see the API |
| 16:37:08 | *** dewmal has joined #openmrs |
| 17:03:38 | *** harshadura has quit IRC |
| 17:06:06 | *** bwolfe has quit IRC |
| 17:06:28 | *** dewmal has quit IRC |
| 17:07:33 | *** magicaltrout has quit IRC |
| 17:07:38 | *** magicaltrout has joined #openmrs |
| 17:09:24 | *** magicaltrout has quit IRC |
| 17:09:29 | *** magicaltrout has joined #openmrs |
| 17:23:23 | *** suranga has joined #openmrs |
| 17:29:19 | *** dewmal has joined #openmrs |
| 17:37:37 | *** bryq has joined #openmrs |
| 17:37:37 | *** ChanServ sets mode: +v bryq |
| 17:45:35 | <suranga> hi james_regen .. |
| 17:45:49 | <suranga> thanks for hangning around till I came online |
| 17:47:26 | <dewmal> hi suranga aiyya |
| 17:47:52 | <suranga> hello... u sound Sri Lankan ! :P |
| 17:47:56 | <dewmal> Harsh is my friend |
| 17:48:00 | <dewmal> yes yes |
| 17:48:25 | <dewmal> *harshadura |
| 17:50:14 | <james_regen> suranga: hi |
| 17:58:23 | *** suranga has quit IRC |
| 17:58:46 | *** suranga has joined #openmrs |
| 18:06:15 | *** wyclif has quit IRC |
| 18:07:50 | *** dkayiwa has joined #openmrs |
| 18:26:40 | <djazayeri> Does anybody know if we have an icon-sized OpenMRS logo somewhere on the wiki? |
| 18:32:14 | <mvorobey> djazayeri: I only saw link to Adobe Illustrator prototype of current logo here https://wiki.openmrs.org/download/attachments/2425783/OpenMRS_2008_logo.zip?version=1&modificationDate=1282587811000 |
| 18:33:36 | <djazayeri> thanks mvorobey. I'll use openmrs_logo_tiny.png in our source distribution, but at some point we should put those on the wiki page. Or at least link to them. |
| 18:35:19 | *** suranga_ has joined #openmrs |
| 18:35:36 | <mvorobey> djazayeri: np, I think we ultimately should have icon-sized logos of openmrs |
| 18:36:37 | *** suranga has quit IRC |
| 19:06:48 | *** chopin has quit IRC |
| 19:07:56 | *** dewmal has quit IRC |
| 19:10:30 | *** suranga__ has joined #openmrs |
| 19:11:18 | *** mvorobey has quit IRC |
| 19:11:23 | *** wyclif has joined #openmrs |
| 19:12:41 | *** wyclif has joined #openmrs |
| 19:14:38 | *** suranga_ has quit IRC |
| 19:16:25 | *** shyam057cs has joined #openmrs |
| 19:27:06 | *** shyam057cs has quit IRC |
| 19:30:48 | *** bryq1 has joined #openmrs |
| 19:33:06 | *** bryq has quit IRC |
| 19:36:03 | <djazayeri> rafa, dkayiwa, wyclif: scrum is now, right? |
| 19:36:12 | <djazayeri> I'm on a call now, with a pentaho kettle guy |
| 19:36:25 | <rafa> in an hour |
| 19:36:25 | <djazayeri> and Ben is out |
| 19:36:25 | <djazayeri> can you all run the scrum? |
| 19:36:30 | <wyclif> djazayeri, in an hr |
| 19:36:31 | <djazayeri> oh, in an hour, great |
| 19:36:50 | <dkayiwa> :) |
| 19:59:34 | *** chopin has joined #openmrs |
| 20:03:10 | *** Mkop has quit IRC |
| 20:09:30 | *** Mkop has joined #openmrs |
| 20:09:30 | *** ChanServ sets mode: +v Mkop |
| 20:09:44 | *** suranga has joined #openmrs |
| 20:12:51 | *** suranga__ has quit IRC |
| 20:13:15 | *** suranga has quit IRC |
| 20:13:58 | *** Mkop has quit IRC |
| 20:21:42 | <wyclif> djazayeri, i haven't got any feedback for the past 24hrs about the updates and the comments on the logic 2.0 design page |
| 20:22:51 | <djazayeri> wyclif: honestly I opened it, and immediately put it in the "look at this later" pile because you've got too many small details there |
| 20:23:05 | <djazayeri> :-) |
| 20:23:36 | <djazayeri> What I want to see is an *executive summary* (still written as java code or pseudocode) of high-level functionality |
| 20:23:49 | *** Mkop has joined #openmrs |
| 20:23:49 | *** ChanServ sets mode: +v Mkop |
| 20:23:58 | <djazayeri> wyclif: I don't want to see the junit test for every @should, just high-level integration tests |
| 20:24:24 | <djazayeri> e.g. you just show us one example of ResultUtil.convert, not 20. |
| 20:25:06 | <djazayeri> and generally, what you should be emailing around are high-level "behavior tests" written like integration tests, not the low-level unit tests. |
| 20:25:52 | <djazayeri> also, wyclif, the most important thing is to send us pseudocode describing the code you're about to write. |
| 20:26:04 | <djazayeri> in your email you said "Next i will writing a behavior test for a DateBasedResult and and then i will go ahead to make it pass." |
| 20:26:22 | <djazayeri> We can't give any useful feedback until you've actually written that behavior test and shared it with us. |
| 20:29:35 | <djazayeri> wyclif: I don't see any unreplied-to comments on the wiki page (I just now replied to the one from an hour ago) |
| 20:29:46 | <djazayeri> let's talk during the sprint in 2 minutes |
| 20:29:50 | <djazayeri> sprint -> scrum |
| 20:30:32 | <wyclif> djazayeri, ia sked about the CalculationService.getCalculation |
| 20:30:48 | <wyclif> djazayeri, i have just seen it |
| 20:30:57 | <wyclif> djazayeri, ok |
| 20:31:35 | <djazayeri> !scrumon djazayeri |
| 20:31:35 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster djazayeri- you may begin when ready. |
| 20:31:43 | <djazayeri> hi rafa, dkayiwa, wyclif |
| 20:31:46 | <djazayeri> scrum time now, right? |
| 20:31:48 | <rafa> hi |
| 20:31:50 | <rafa> right |
| 20:31:56 | *** Mkop has quit IRC |
| 20:32:27 | <dkayiwa> hi |
| 20:32:31 | <djazayeri> let's go rafa, dkayiwa, wyclif, djazayeri |
| 20:32:44 | <rafa> Today: |
| 20:32:44 | <rafa> * Further tested and fixed bugs in MDS |
| 20:32:44 | <rafa> * Released MDS 1.0 |
| 20:32:44 | <rafa> Tomorrow: |
| 20:32:44 | <rafa> * STAND-36: Automatically create MVP/CIEL dictionary-based dataset as part of the standalone build process |
| 20:32:44 | <rafa> https://tickets.openmrs.org/browse/STAND-36 |
| 20:32:44 | <rafa> * Other trunk tickets |
| 20:32:45 | <rafa> No blockers |
| 20:32:57 | <dkayiwa> Committed response to review comments for: JspException thrown on clicking the Visits category under settings - TRUNK-3055 |
| 20:32:57 | <dkayiwa> Reviewed: Allow "end this visit now" from edit visit page - TRUNK-2240 |
| 20:32:57 | <dkayiwa> Back ported and closed: Database setup wizard fails to complete - TRUNK-3060 |
| 20:32:58 | <dkayiwa> Done some 1.9 ticket administration |
| 20:32:58 | <dkayiwa> Attempted to work on but later abandoned: Upgrade to the latest stable release of jquery - TRUNK-3054 :) |
| 20:32:58 | <dkayiwa> Thinking of what to work on next??? |
| 20:32:58 | <dkayiwa> No Blockers |
| 20:33:16 | <rafa> should I look into TRUNK-3054? |
| 20:33:35 | <rafa> !ticket TRUNK-3054 |
| 20:33:36 | <OpenMRSBot> rafa: [#TRUNK-3054] Upgrade to the latest stable release of jquery - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3054 |
| 20:33:49 | <djazayeri> dkayiwa: certainly all the tickets labeled as bugfix-mar-2012 (or something similar) are fair game |
| 20:34:06 | <dkayiwa> rafa: that would be great!!! :) |
| 20:34:09 | <djazayeri> dkayiwa: and we're going to talk about 1.9 status tomorrow, right? |
| 20:34:19 | <djazayeri> dkayiwa: can you give us a general overview? |
| 20:34:25 | <dkayiwa> djazayeri: we can do today. electricity has come back :) |
| 20:34:34 | <djazayeri> dkayiwa: great, after the scrum then |
| 20:34:39 | <dkayiwa> djazayeri: yes |
| 20:35:07 | <djazayeri> dkayiwa: what are the chances we can get to Release Candidate by the end of this week? |
| 20:35:39 | <dkayiwa> djazayeri: not sure because am not getting much response from the devs hanging on the remaining tickets |
| 20:35:56 | <djazayeri> dkayiwa: are some of them on the scrum now? |
| 20:36:01 | <djazayeri> e.g. are some of them me? |
| 20:36:03 | <djazayeri> wyclif? |
| 20:36:05 | <rafa> dkayiwa: is it me? :) |
| 20:36:09 | <wyclif> yesterday: |
| 20:36:10 | <wyclif> -Added the implementation logic for ResultUtil and required parameter definitions |
| 20:36:10 | <wyclif> -Added extra unit tests to widen their converage for ResultUtil and required parameters logic |
| 20:36:10 | <wyclif> Today: |
| 20:36:10 | <wyclif> -Added behavior tests for Cohorts similar to those for a single patient |
| 20:36:10 | <wyclif> -Add An integration test for Datebasedresult and add the logic to make it pass |
| 20:36:12 | <wyclif> -Add integration test for getting a calculation for a registered token |
| 20:36:13 | <dkayiwa> yes apart from rafa :) |
| 20:36:44 | <rafa> cool :D |
| 20:36:48 | <djazayeri> wyclif: You have already added behavior tests for Cohorts? |
| 20:36:53 | <djazayeri> did you email about those? |
| 20:37:34 | <wyclif> djazayeri, yesh, they are not any different from the ones for patients, that is i didnt email them and besides they were passing |
| 20:37:45 | <djazayeri> wyclif: please email them anyway |
| 20:37:59 | <wyclif> ok |
| 20:38:07 | <djazayeri> the idea is that there's a group of interested people, who are too busy to follow closely, but want to know about the high-level developments, and comment on them. |
| 20:38:12 | <djazayeri> (I'm one of those people) |
| 20:38:28 | <wyclif> ok |
| 20:38:52 | <djazayeri> basically you should email every time you *create* a new behavior test. |
| 20:39:33 | *** Mkop has joined #openmrs |
| 20:39:33 | *** ChanServ sets mode: +v Mkop |
| 20:39:59 | <djazayeri> my turn |
| 20:40:01 | <djazayeri> Monday 20-Feb-2012 |
| 20:40:01 | <djazayeri> * Continue working on Reporting REST |
| 20:40:01 | <djazayeri> ** Ran into a bunch of errors: TRUNK-3066, REPORT-318, incorrect maven setup |
| 20:40:01 | <djazayeri> * Continue working on the Pentaho PDI plugin |
| 20:40:01 | <djazayeri> Tuesday 21-Feb-2012 |
| 20:40:02 | <djazayeri> * Continue working on Reporting REST |
| 20:40:02 | <djazayeri> * Call with Slawomir Chodnicki from Pentaho |
| 20:40:03 | <djazayeri> * Continue working on the Pentaho PDI plugin |
| 20:40:37 | <djazayeri> slowdowns: troubles I mentioned around exception throwing in reporting rest |
| 20:41:17 | <djazayeri> also, it's a real pain to deal with all the necessary modules. These are all required for me to be able to test my new module: htmlwidgets, serialization.xstream, reporting, webservices.rest |
| 20:41:38 | <djazayeri> Okay, so discussion points: |
| 20:42:11 | <djazayeri> dkayiwa: now would be a good time for you to publicly shame those of us who are holding up the 1.9 Release Candidate because we've been ignoring your ticket comments. |
| 20:42:29 | <dkayiwa> djazayeri: all of you apart from rafa :) |
| 20:42:36 | <djazayeri> dkayiwa: be more specific. |
| 20:42:50 | <dkayiwa> djazayeri: by mentioning which tickets? |
| 20:42:55 | <djazayeri> dkayiwa: if you want |
| 20:43:10 | <dkayiwa> djazayeri: would have to go through them first, one by one |
| 20:43:16 | <djazayeri> dkayiwa: then summarize |
| 20:43:36 | <djazayeri> basically, we haven't been doing what we need to do to support you getting the release out, so I'd like to discuss that here. |
| 20:43:42 | <djazayeri> I know that I've got a bunch of code reviews to do. |
| 20:43:44 | <wyclif> i know i have 2 tickets |
| 20:44:01 | <dkayiwa> djazayeri: yes |
| 20:44:03 | <djazayeri> wyclif: okay, can you take an hour a day to close those tickets out? |
| 20:44:42 | <dkayiwa> djazayeri: but like half of them are waiting on chopin :) |
| 20:44:54 | <djazayeri> chopin: you there? |
| 20:45:04 | <chopin> heyya |
| 20:45:09 | <wyclif> one of them i ran into issues related to the early hibernate flushes when creating reference terms on the fly |
| 20:45:13 | <chopin> i'm in class atm |
| 20:45:31 | <chopin> dkayiwa, saw your comments, hope to address them soon ... |
| 20:45:43 | <dkayiwa> chopin: hahaha :) |
| 20:45:44 | <djazayeri> chopin: are any of these tickets things that other people can do? |
| 20:45:44 | <chopin> I've been in the middle of a data migration |
| 20:46:00 | <chopin> djazayeri, i'm happy to let anyone else do whatever i've got in the queue there |
| 20:46:02 | <rafa> wyclif: is it the concept mappings ticket? |
| 20:46:19 | <chopin> i think in one case it's just backporting something that can be done from the related commit |
| 20:46:37 | <dkayiwa> chopin: yes |
| 20:46:38 | <djazayeri> rafa is our expert on early hibernate flushes, so maybe he can look into that this week. wyclif are you blocked on that one? |
| 20:46:40 | <wyclif> TRUNK-3057 |
| 20:46:48 | <rafa> wyclif: do you have an idea how to resolve that or do you want me to look into that? |
| 20:47:01 | <rafa> !ticket TRUNK-3057 |
| 20:47:02 | <OpenMRSBot> rafa: [#TRUNK-3057] Creating concept mappings fails with legacy code - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3057 |
| 20:47:15 | <djazayeri> backporting TRUNK-2734 is a blocker for a bunch of stuff that I have to backport, so maybe someone else can do that for chopin. |
| 20:47:50 | <chopin> if anyone has a question about it, happy to help |
| 20:48:00 | <chopin> it's relatively easy to do, just have to spend every waking minute on this data merge |
| 20:48:01 | <wyclif> i have written some code, i will look at it today and then i communicate if i still ran into issues |
| 20:48:03 | <djazayeri> dkayiwa, rafa: can one of you try that? ask for help immediately if it doesn't backport cleanly |
| 20:48:08 | <chopin> (or in class) |
| 20:48:23 | *** sgithens_ has joined #openmrs |
| 20:48:24 | <wyclif> rafa, i have done some work about it but didnt complete it |
| 20:48:53 | <rafa> wyclif: okay, let me know if you still have troubles |
| 20:49:00 | <wyclif> i will spare sometime today for the 2 tickets |
| 20:49:08 | <wyclif> rafa, sure thanks |
| 20:49:29 | *** sgithens has quit IRC |
| 20:49:51 | <djazayeri> dkayiwa: maybe you can create a JIRA label like "okay-to-steal", and create a JIRA query that shows all open 1.9 tickets, as well as all those that are okay-to-steal. |
| 20:50:00 | <djazayeri> And you and rafa can finish all those off this week. |
| 20:50:06 | <djazayeri> !scrumoff |
| 20:50:06 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 20:50:08 | <djazayeri> (by the way) |
| 20:50:23 | <rafa> djazayeri: that would be good |
| 20:50:43 | <dkayiwa> djazayeri: any time rafa is free to do any, i can immediately assign him one (or a pool of them) :) |
| 20:50:44 | <rafa> djazayeri: !ticket TRUNK-2734 |
| 20:50:53 | <rafa> !ticket TRUNK-2734 |
| 20:50:54 | <OpenMRSBot> rafa: [#TRUNK-2734] Refactor Form Resources to use Custom Datatypes - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2734 |
| 20:51:11 | <djazayeri> dkayiwa: you have full ownership of rafa's time for the rest of the week. |
| 20:51:11 | <rafa> dkayiwa: I like that :D |
| 20:51:20 | <djazayeri> (at least his work time) |
| 20:51:20 | <dkayiwa> hahaha |
| 20:51:28 | <rafa> haha |
| 20:51:29 | <dkayiwa> rafa: can you start with TRUNK-3054 ? :) |
| 20:51:40 | <rafa> !ticket TRUNK-3054 |
| 20:51:41 | <OpenMRSBot> rafa: [#TRUNK-3054] Upgrade to the latest stable release of jquery - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3054 |
| 20:52:05 | <rafa> sure though I'm not conviced it's the right time to do it ;) |
| 20:52:10 | <rafa> I mean just before the rc |
| 20:52:24 | <dkayiwa> rafa: i completely agree 900% :D |
| 20:52:32 | <wyclif> it would be good to test the autocompletes and search widgets since the use jquery heavily |
| 20:52:43 | <chopin> that's a lot of % |
| 20:52:44 | <djazayeri> rafa: the point is to drop in the new version of jquery and jquery ui (don't worry about doign the 4 different customizations) |
| 20:52:52 | <rafa> wyclif: yeah and we have customized them |
| 20:52:55 | <djazayeri> then quickly try bundled modules |
| 20:52:56 | <dkayiwa> chopin: :D |
| 20:53:04 | <wyclif> rafa, cool |
| 20:53:13 | <djazayeri> if things break, we abort and push this to OpenMRS 1.10. |
| 20:53:18 | <rafa> djazayeri: okay |
| 20:53:47 | <djazayeri> if everything magically works, then we'll decide whether to proceed or not. |
| 20:53:56 | <djazayeri> (But I guess you all are right, and upgrading isn't a great idea now.) |
| 20:55:38 | <djazayeri> so, dkayiwa, rafa, can you two work to get us as close as possible to 1.9 RC by the end of the week? |
| 20:55:55 | <djazayeri> If this means stealing tickets from people who have had more than enough time to do it themselves, great. |
| 20:55:59 | <rafa> djazayeri: I've got no other plans :) |
| 20:56:08 | <chopin> is it okay if FormEntry gets a change after RC before release? |
| 20:56:25 | <djazayeri> chopin: yes |
| 20:56:34 | <dkayiwa> djazayeri: sure. And if chopin can steal some time for TRUNK-2734 That would be fantastic!!! :D |
| 20:57:22 | <djazayeri> Also, dkayiwa, please email the dev list mentioning that we're doing a final few days of work leading up to a RC, and that we need tickets committed/reviewed ASAP. And you should list the names of the people you're specifically talking to. (You don't need to list all the tickets, but do be specific about who is holding us up.) |
| 20:57:54 | <dkayiwa> djazayeri: they are all on IRC :) |
| 20:57:59 | <djazayeri> dkayiwa: let's assume that chopin is too busy, and have you or rafa try backporting TRUNK-2734. |
| 20:58:01 | <dkayiwa> now |
| 20:58:29 | <djazayeri> dkayiwa: that's fine. email the dev list anyway. |
| 20:58:37 | <dkayiwa> djazayeri: ok |
| 21:05:37 | *** james_regen has left #openmrs |
| 21:23:36 | *** djazayeri1 has joined #openmrs |
| 21:25:11 | *** djazayeri has quit IRC |
| 21:30:27 | *** dkayiwa has quit IRC |
| 21:35:17 | *** rafa has quit IRC |
| 21:43:30 | *** djazayeri1 is now known as djazayeri |
| 21:43:31 | *** ChanServ sets mode: +o djazayeri |
| 22:01:29 | <wyclif> djazayeri, for DateBasedResult, the date is the date of evaluation or the value of CalculationContext.getNow() |
| 22:01:57 | <wyclif> djazayeri, the design page has no description |
| 22:02:31 | <djazayeri> wyclif: no, the date of evaluation is *not* the same thing as getNow. |
| 22:03:14 | *** sgithens_ has quit IRC |
| 22:03:40 | <wyclif> djazayeri, am aware of that , i meant the date returned by DateBasedResult.getDateOfResult |
| 22:03:57 | <wyclif> djazayeri, which of the above it it? |
| 22:04:35 | <wyclif> i.e do is set it to getNow() or to new Date() |
| 22:04:47 | <djazayeri> wyclif: it's the natural date of the type of result. you don't use either of those options |
| 22:05:03 | *** bryq1 has quit IRC |
| 22:05:03 | <wyclif> djazayeri, oh i get it, thanks |
| 22:05:34 | <djazayeri> wyclif: e.g. an ObsResult would use obsDatetime |
| 22:05:35 | <wyclif> e.g if encounter, it becomes encounterDattime |
| 22:05:42 | <wyclif> djazayeri, got you |
| 22:05:47 | <wyclif> thanks |
| 22:06:09 | <wyclif> djazayeri, i think i will need to implement in the coming days |
| 22:06:30 | <wyclif> djazayeri, i think i will need to implement those datebasedresults in the coming days |
| 22:06:33 | <djazayeri> wyclif: the point is that only things that have a natural date implement DateBasedResult. |
| 22:06:45 | <wyclif> djazayeri, ok |
| 22:42:46 | *** chopin has quit IRC |
| 22:51:49 | *** bryq has joined #openmrs |
| 22:51:49 | *** ChanServ sets mode: +v bryq |
| 22:55:50 | *** bryq has quit IRC |
| 23:41:46 | *** rafa has joined #openmrs |
| 23:41:46 | *** ChanServ sets mode: +v rafa |
| 23:57:26 | *** rafa has quit IRC |