| 00:46:54 | *** wyclif has joined #openmrs |
| 00:56:03 | <deadpool> djazayeri: if i wanted to override a portlet do i do the same thing as overriding the page and then add a portletext.java or is that different? |
| 00:56:24 | <djazayeri> override an existing portlet? |
| 00:56:37 | <deadpool> i want to override the demographics tab |
| 00:56:53 | <deadpool> i see in the source that is referenced as a portlet |
| 00:57:13 | <djazayeri> Yes. So you'll do this in a module. |
| 00:57:18 | <deadpool> yeah |
| 00:57:40 | <deadpool> or do i just override the patientDemographics.jsp as any other page |
| 00:57:53 | <djazayeri> I think it's exactly like adding a new portlet, but you need to name it (and set up its spring mvc mapping) |
| 00:59:01 | <djazayeri> deadpool: e.g. you set up a portlet like the reporting module does here: http://svn.openmrs.org/openmrs-modules/reporting/trunk/metadata/webModuleApplicationContext.xml |
| 00:59:29 | <djazayeri> but you need to map **/patientDemographics.portlet to your own controller |
| 01:00:05 | <djazayeri> ("your own controller" is a bean you'd also define in webModuleApplicationContext.xml; it should override PortletController) |
| 01:00:19 | <djazayeri> At least, I *think* that will work. ;_0 |
| 01:00:20 | <djazayeri> :-) |
| 01:02:03 | <deadpool> will that let me override that demographics tab then? |
| 01:03:44 | <djazayeri> deadpool: I think so |
| 01:03:57 | <djazayeri> have you searched the mailing list archive for overriding an existing portlet? |
| 01:04:21 | <deadpool> not the mailing list the wiki i have |
| 01:06:10 | <deadpool> and it kinda explains it but not fully |
| 01:06:54 | <djazayeri> okay, well, try overriding as I describe, i.e. overriding the **/patientDemographics.portlet url to your own controller |
| 01:07:18 | <djazayeri> deadpool: also, note that you need to set the order of the SimpleUrlHandlerMapping in your xml to take precedence over the core one |
| 01:07:36 | <djazayeri> I assume that copying it from any module (e.g. copy the value of 50 from the reporting module link I sent) will do that |
| 01:07:38 | <deadpool> yeah i have done that i already overrode the findPatient.jsp |
| 01:07:42 | <djazayeri> I forget whether it's supposed to be > or < |
| 01:07:49 | <deadpool> less than |
| 01:09:10 | <djazayeri> ok |
| 01:12:42 | <deadpool> djazayeri: thanks |
| 03:51:57 | *** deadpool has quit IRC |
| 03:58:54 | *** suranga has joined #openmrs |
| 03:59:05 | <suranga> bwolfe, still here ? |
| 03:59:15 | <bwolfe> yeah |
| 03:59:19 | <suranga> mm.... its kinda wierd, not that you've become one of the night people :-( |
| 04:01:16 | <bwolfe> heh |
| 04:01:24 | <bwolfe> I have some stuff to get done for my bro-in-law |
| 04:01:32 | <bwolfe> I'd rather be sleeping... :-) |
| 04:04:45 | <suranga> ah... married peoples troubles :P |
| 04:04:56 | <suranga> oops, I forgot I have a brother in law too |
| 04:05:05 | <suranga> but thankfully... NO girlfriends :P |
| 05:18:36 | *** magicaltrout has quit IRC |
| 05:25:00 | *** bwolfe has quit IRC |
| 05:27:45 | *** magicaltrout has joined #openmrs |
| 05:33:53 | *** harshadura has quit IRC |
| 05:51:27 | *** magicaltrout has quit IRC |
| 05:55:14 | *** magicaltrout has joined #openmrs |
| 06:13:28 | *** dkayiwa has joined #openmrs |
| 06:25:46 | *** magicaltrout has quit IRC |
| 06:26:29 | *** magicaltrout has joined #openmrs |
| 06:56:10 | *** dkayiwa has quit IRC |
| 07:06:42 | *** dkayiwa has joined #openmrs |
| 07:13:26 | *** dkayiwa has quit IRC |
| 07:35:31 | *** harshadura has joined #openmrs |
| 07:40:33 | *** sthaiya has joined #openmrs |
| 07:49:14 | *** bryq has joined #openmrs |
| 07:49:14 | *** ChanServ sets mode: +v bryq |
| 08:06:10 | <sthaiya> anybody successfully installed latest nightly |
| 08:15:26 | <harshadura> hi |
| 08:16:31 | *** ibewes has joined #openmrs |
| 08:21:50 | <harshadura> hi sthaiya : is their any problem with the latest nightly build |
| 08:22:16 | <harshadura> i can give it a try if u want to |
| 08:22:25 | <sthaiya> yeah |
| 08:22:30 | <harshadura> pls can u provide me the link |
| 08:22:40 | <sthaiya> its failing on updating database |
| 08:22:54 | <sthaiya> giving me a Null error |
| 08:23:04 | <harshadura> oops thats bad |
| 08:24:34 | <sthaiya> try downloading the latest nightly from openmrs website and doing a clean install |
| 08:24:50 | <harshadura> okay sure |
| 08:25:03 | <sthaiya> the actuall error displayed is: |
| 08:25:04 | <sthaiya> There was an error while updating the database to the latest. file: liquibase-update-to-latest.xml. Error: null Error while trying to update to the latest database version |
| 08:25:44 | <harshadura> seems like something buggy on the db |
| 08:25:54 | <sthaiya> my db? |
| 08:26:01 | <harshadura> will see ill try now and inform asap |
| 08:26:11 | <sthaiya> ok will appreciate |
| 08:29:04 | <harshadura> sthaiya : pls can u confirm this one ryt? http://sourceforge.net/projects/openmrs/files/nightly/2012-02-14/ |
| 08:29:15 | <OpenMRSBot> <http://ln-s.net/9dJx> (at sourceforge.net) |
| 08:32:15 | <sthaiya> yeah that one |
| 08:32:29 | <harshadura> okay thx |
| 08:36:19 | *** bryq has quit IRC |
| 08:50:10 | *** rafa has joined #openmrs |
| 08:50:10 | *** ChanServ sets mode: +v rafa |
| 08:54:17 | <harshadura> hi sthaiya : u thr |
| 08:54:37 | <harshadura> me too getting the same error |
| 08:54:42 | <harshadura> "There was an error while updating the database to the latest. file: liquibase-update-to-latest.xml. Error: null Error while trying to update to the latest database version" |
| 08:54:44 | <sthaiya> hmm |
| 08:56:32 | <sthaiya> thanks for testing this |
| 08:58:11 | <harshadura> sure anytime :) |
| 09:13:38 | * robbyoconnor yawns |
| 09:19:09 | *** suranga_ has joined #openmrs |
| 09:19:09 | *** suranga has quit IRC |
| 09:25:51 | *** harshadura has quit IRC |
| 09:37:22 | *** harshadura has joined #openmrs |
| 09:39:41 | <harshadura> suranga_ : ayya u thr |
| 10:10:52 | *** ibewes has quit IRC |
| 10:26:28 | *** bryq has joined #openmrs |
| 10:26:28 | *** ChanServ sets mode: +v bryq |
| 10:30:50 | *** bryq has quit IRC |
| 10:32:04 | <harshadura> anyone thr |
| 10:32:48 | <harshadura> im jz stucked with solving an introductory ticket |
| 10:37:23 | *** suranga__ has joined #openmrs |
| 10:37:23 | *** suranga_ has quit IRC |
| 10:45:43 | *** suranga_ has joined #openmrs |
| 10:45:43 | *** suranga__ has quit IRC |
| 11:02:06 | *** harshadura has quit IRC |
| 11:20:34 | *** robbyoconnor has quit IRC |
| 11:26:23 | *** rafa has quit IRC |
| 11:32:54 | *** dkayiwa has joined #openmrs |
| 11:32:54 | *** rafa has joined #openmrs |
| 11:32:54 | *** zelazny.freenode.net sets mode: +v rafa |
| 11:41:01 | *** bryq has joined #openmrs |
| 11:41:01 | *** ChanServ sets mode: +v bryq |
| 12:03:13 | *** magicaltrout has quit IRC |
| 12:09:40 | *** magicaltrout has joined #openmrs |
| 12:11:55 | *** sthaiya has quit IRC |
| 12:34:44 | *** bryq has quit IRC |
| 12:44:44 | *** suranga_ has quit IRC |
| 12:49:45 | <dkayiwa> hi rafa |
| 12:49:52 | <rafa> hi dkayiwa |
| 12:50:32 | <dkayiwa> rafa: do you happen to have any documentation url that has steps on how to create a transformation? |
| 12:50:43 | <dkayiwa> pentaho |
| 12:51:03 | <rafa> dkayiwa: there's a recording from yesterday |
| 12:51:13 | <dkayiwa> oh great |
| 12:51:15 | <dkayiwa> url? |
| 12:51:39 | <rafa> dkayiwa: yeah not until djazayeri shares it :/ |
| 12:51:57 | <dkayiwa> :( |
| 12:52:28 | <rafa> dkayiwa: http://wiki.pentaho.com/display/EAI/03.+Hello+World+Example |
| 12:52:33 | <OpenMRSBot> <http://ln-s.net/9dNB> (at wiki.pentaho.com) |
| 12:52:40 | <dkayiwa> ok thanks :) |
| 12:53:24 | <rafa> dkayiwa: you'll start with Table Input step |
| 12:53:42 | <rafa> dkayiwa: see PENT-12 |
| 12:53:57 | <rafa> dkayiwa: which is your ticket? |
| 12:54:06 | <dkayiwa> rafa: pent-11 |
| 12:55:11 | <rafa> dkayiwa: cool I'll play with it as well |
| 12:55:27 | <dkayiwa> rafa: cool thanks :) |
| 13:04:10 | *** suranga has joined #openmrs |
| 13:44:23 | *** bwolfe has joined #openmrs |
| 13:44:23 | *** ChanServ sets mode: +o bwolfe |
| 13:55:46 | <rafa> dkayiwa: I've just added what I felt was right to the pent-11. |
| 13:55:57 | <dkayiwa> rafa: oh thanks :) |
| 13:56:16 | <rafa> dkayiwa: you'll need to change db details |
| 13:56:23 | <rafa> dkayiwa: do you remember how? |
| 13:56:45 | <dkayiwa> rafa: atleast i remember setting up a new connection :) |
| 13:57:40 | <rafa> dkayiwa: just open the file, go to the view tab, expand Database connections, right click and edit |
| 13:58:05 | <dkayiwa> rafa: thanks :) |
| 13:59:01 | <rafa> dkayiwa: I forgot to get rid of voided persons and obs so you can add that :) |
| 13:59:25 | <dkayiwa> rafa: hahahha :D |
| 14:05:38 | <bwolfe> rafal, how much time do you need to finish that MDS thing? |
| 14:06:59 | <rafa> bwolfe: I'll finish my tickets on the weekend, but I may not have enough time to test it thoroughly |
| 14:07:13 | <bwolfe> rafa, time estimate though? |
| 14:07:42 | <rafa> bwolfe: 16 hours to finish my tickets |
| 14:07:51 | <rafa> bwolfe: testing another 8 hours |
| 14:08:10 | <djazayeri> rafa, bwolfe, dkayiwa: join breeze.iu.edu/openmrsdev |
| 14:08:26 | <rafa> djazayeri: ok |
| 14:09:33 | <bwolfe> djazayeri, need me to call into free conf? |
| 14:09:42 | <dkayiwa> djazayeri: sorry am stepping out and will be back later :( |
| 14:10:02 | <djazayeri> I'm called in bwolfe, but if you were planning to do connect directly, you can |
| 14:10:04 | <bwolfe> dkayiwa, :-/ where are you off to? |
| 14:10:06 | <djazayeri> if you can get audio |
| 14:10:43 | <dkayiwa> bwolfe: every am checking on some people in the hospital :( |
| 14:16:22 | <bwolfe> dkayiwa, hmm, ouch. means you're missing another intro from Gretchie today |
| 14:19:16 | *** dkayiwa has quit IRC |
| 14:19:48 | *** MarkG has joined #openmrs |
| 14:28:36 | *** magicaltrout has quit IRC |
| 14:30:15 | *** magicaltrout has joined #openmrs |
| 14:49:43 | *** suranga has quit IRC |
| 15:47:04 | <bwolfe> rafa, which software is the schema designer? |
| 15:47:42 | <rafa> bwolfe: schema workbench |
| 15:47:55 | <rafa> bwolfe: it's in psw-ce-3.3.0.14703 |
| 15:47:59 | <bwolfe> hmm, perhaps I'm not seeing it because I didn't download it... |
| 15:48:10 | <rafa> :) |
| 15:52:13 | <wyclif> hi djazayeri |
| 15:54:07 | <djazayeri> hi wyclif |
| 15:56:28 | <wyclif> i'm supposed to write my own map implementation for Cohort result or it is supposed to extends a concrete map implementation like linkedHashMap? |
| 15:57:03 | <djazayeri> wyclif: you can extend |
| 15:57:42 | <wyclif> djazayeri, i was just trying to make sure i didnt have to write unnecessary code |
| 15:57:57 | <djazayeri> wyclif: fair question |
| 15:58:07 | <djazayeri> but indeed you do not need to write unnecessary code |
| 15:58:49 | <wyclif> thanks |
| 16:41:40 | <wyclif> so CohortResult.getAllResults() is supposed to return itself, i.e the methods contains one line "return this;" right? |
| 16:42:14 | <wyclif> djazayeri, so CohortResult.getAllResults() is supposed to return itself, i.e the methods contains one line "return this;" right? |
| 16:43:04 | <djazayeri> wyclif: sureâ¦thinking back, it doesn't really make sense to both have that method *and* implement Map |
| 16:47:22 | <wyclif> djazayeri, is it supposed to return something similar to a map entry returned by a map.keySet()? |
| 16:47:40 | <wyclif> djazayeri, let me add a comment to the wiki page |
| 16:48:59 | <djazayeri> wyclif: if it implements Map, it does *not* need to have a getAllResults that returns itself |
| 17:15:28 | <djazayeri> rafa, bwolfe, can you hear anything? |
| 17:15:40 | <bwolfe> yes |
| 17:15:42 | <rafa> djazayeri: yes |
| 17:17:24 | <MarkG> djazayeri: do you remember what happens in HFE if an exception is thrown during handleFormSubmission? Does it stack trace, or does it handle it gracefully? |
| 17:18:59 | <djazayeri> MarkG: I don't remember, but that's never supposed to failâthat's what validateSubmission is for |
| 17:19:05 | <djazayeri> rafa, bwolfe: I'm restarting my computer |
| 17:19:22 | <MarkG> djazayeri: rafa: i'm trying to figure out how to handle Rafal's case of throwing an error if the user changes the encounter date on a form that has a workflowstate element... and it looks like we won't have access to both the old and new encounter dates during the handleFormSubmission stage |
| 17:20:05 | <MarkG> validateSubmission is passed the Context, but not the Session |
| 17:22:43 | *** djazayeri has quit IRC |
| 17:28:12 | *** djazayeri has joined #openmrs |
| 17:28:12 | *** ChanServ sets mode: +o djazayeri |
| 17:29:15 | *** suranga has joined #openmrs |
| 17:42:34 | *** djazayeri has quit IRC |
| 17:43:08 | *** suranga has quit IRC |
| 17:43:27 | *** suranga has joined #openmrs |
| 17:43:54 | *** djazayeri has joined #openmrs |
| 17:43:54 | *** ChanServ sets mode: +o djazayeri |
| 17:51:00 | <djazayeri> MarkG: I just restarted and lost your last message |
| 17:51:02 | <djazayeri> what did you say? |
| 17:55:03 | *** magicaltrout has quit IRC |
| 17:55:03 | *** Mkop has quit IRC |
| 17:55:04 | *** MarkG has quit IRC |
| 17:55:04 | *** bwolfe has quit IRC |
| 17:55:05 | *** rafa has quit IRC |
| 17:56:50 | *** magicaltrout has joined #openmrs |
| 17:56:50 | *** MarkG has joined #openmrs |
| 17:56:50 | *** bwolfe has joined #openmrs |
| 17:56:50 | *** rafa has joined #openmrs |
| 17:56:50 | *** zelazny.freenode.net sets mode: +ov bwolfe rafa |
| 17:58:16 | <wyclif> djazayeri, question; |
| 17:58:30 | <djazayeri> yes? |
| 17:58:47 | <wyclif> CalculationContext.getFromCache(Cohort cohort, Calculation calculation, Map<String, Object> result); |
| 17:59:11 | <wyclif> djazayeri, for that last argument, is that a amp for the configuration to amcth against |
| 17:59:54 | <wyclif> djazayeri, sorry!! map of configuration properties to match against |
| 18:00:06 | <djazayeri> wyclif: actually, we should get rid of that |
| 18:00:26 | <djazayeri> I accidentally left that in when I added the three coche methods after the comment |
| 18:00:56 | <wyclif> djazayeri, ok, i plan to edit that page later today to match what i have coded |
| 18:01:10 | <wyclif> djazayeri, just to have you guys updated |
| 18:01:13 | <djazayeri> wyclif: that page is really just for design |
| 18:01:36 | <wyclif> ok, so i start writing implementation code today |
| 18:01:45 | <djazayeri> I would prefer that instead of spending time keeping that page up-to-date at every moment, you should spend that time writing the failing unit tests I asked for. :-) |
| 18:01:50 | <djazayeri> did you get that email? |
| 18:02:16 | <wyclif> yes, so i will write the tests as you suggested prior to coding features |
| 18:02:43 | <djazayeri> wyclif: okay |
| 18:03:04 | <djazayeri> FWIW, writing these tests can also help validate the design you're looking at now |
| 18:03:16 | <wyclif> djazayeri, sure |
| 18:03:36 | *** Mkop has joined #openmrs |
| 18:03:36 | *** ChanServ sets mode: +v Mkop |
| 18:07:29 | *** satyag has joined #openmrs |
| 18:11:05 | *** satyag has quit IRC |
| 18:11:21 | *** satyag has joined #openmrs |
| 18:14:52 | *** suranga has quit IRC |
| 18:15:41 | *** rafa has quit IRC |
| 18:21:13 | *** rafa has joined #openmrs |
| 18:21:13 | *** zelazny.freenode.net sets mode: +v rafa |
| 18:40:02 | <bwolfe> theres a freenode node named "wolfe"? sweet |
| 18:40:17 | <bwolfe> ooo, and I'm even connected to it! |
| 18:40:18 | <bwolfe> :-) |
| 19:18:32 | *** satyag has quit IRC |
| 19:31:59 | *** Echidna has quit IRC |
| 19:32:18 | *** Mkop has quit IRC |
| 19:34:14 | *** satyag has joined #openmrs |
| 19:36:41 | <satyag> OpenMRSBot, help |
| 19:36:41 | <OpenMRSBot> satyag: (help [<plugin>] [<command>]) -- This command gives a useful description of what <command> does. <plugin> is only necessary if the command is in more than one plugin. |
| 19:36:56 | *** Echidna has joined #openmrs |
| 19:36:56 | *** ChanServ sets mode: +v Echidna |
| 19:37:22 | <satyag> OpenMRSBot, help login |
| 19:37:22 | <OpenMRSBot> satyag: Error: There is no command "login". |
| 19:38:48 | <satyag> hi |
| 19:38:52 | <bwolfe> satyag, hey |
| 19:39:01 | <bwolfe> where are you needing help logging in? |
| 19:39:25 | <satyag> i am trying raxajss , do not know default user/pass |
| 19:42:05 | <bwolfe> admin/test? |
| 19:42:11 | <bwolfe> admin/Welcome123? |
| 19:42:14 | <bwolfe> admin/Admin123 ? |
| 19:42:27 | <bwolfe> satyag, do they not list it on their wiki page(s) ? |
| 19:44:06 | <satyag> bwolfe, i started with this page https://raxaemr.atlassian.net/wiki/display/RAXAJSS/Getting+Started+Guide |
| 19:44:12 | <OpenMRSBot> <http://ln-s.net/9dU9> (at raxaemr.atlassian.net) |
| 19:44:14 | <satyag> no luck for me |
| 19:48:50 | <satyag> bwolfe, will wait for reply from dev there |
| 19:49:22 | <satyag> bwolfe, ttyl |
| 19:50:07 | *** satyag has quit IRC |
| 20:04:29 | *** bryq has joined #openmrs |
| 20:04:29 | *** ChanServ sets mode: +v bryq |
| 20:10:11 | *** djazayeri has quit IRC |
| 20:22:25 | *** dawn_ has joined #openmrs |
| 20:22:37 | *** ChanServ sets mode: +v dawn_ |
| 20:26:06 | *** bryq has quit IRC |
| 20:26:44 | *** dawn_ has quit IRC |
| 20:39:16 | <bwolfe> wyclif, can we do a quick scrum? |
| 20:39:38 | <wyclif> sure |
| 20:40:11 | <bwolfe> you go first. :-) |
| 20:40:28 | <wyclif> Today: |
| 20:40:28 | <wyclif> * Create new calculation module project |
| 20:40:28 | <wyclif> * Add all the marker interfaces and superclasses |
| 20:40:28 | <wyclif> * Did some work on TRUNK-3057 (Ran into premature hibernate flushes) - Creating concept mappings fails with legacy code |
| 20:40:28 | <wyclif> Today: |
| 20:40:29 | <wyclif> * Add hibernate mappings, liquibase changesets for Registration token |
| 20:40:31 | <wyclif> * Write unit tests for the service methods to to be implemeneted intially |
| 20:40:33 | <wyclif> * Write DAO implementation code for the CRUD operations for TokenRegistration |
| 20:41:02 | <wyclif> the first is monday's |
| 20:41:45 | <bwolfe> are you committing regularly to the new module? and/or did you request the id from code@o.o? |
| 20:42:02 | <wyclif> am committing |
| 20:42:19 | <wyclif> i will be starting code reviews as i write implementation code |
| 20:42:42 | <bwolfe> and have you been writing unit tests first? |
| 20:43:21 | <wyclif> that is what am doing today since it is when i have started writing implementation code |
| 20:43:53 | <wyclif> yesterday i was just adding the interfaces and other classes |
| 20:44:52 | <bwolfe> after interfaces and before implementation is the perfect time to do it |
| 20:44:56 | <wyclif> am still waiting for michael to set up a jira project before creating reviews |
| 20:45:24 | <bwolfe> did you open a ticket for that? |
| 20:45:25 | <wyclif> yeah |
| 20:45:43 | <wyclif> bwolfe, yes i did |
| 20:45:59 | <wyclif> https://tickets.openmrs.org/browse/ITSM-2284 |
| 20:48:36 | <wyclif> bwolfe, i already filled that form for project setup |
| 21:28:18 | *** chopin has joined #openmrs |
| 21:28:25 | <chopin> hey folks |
| 21:28:56 | <bwolfe> hi chopin |
| 21:30:04 | <chopin> if i want to store an object with a property meant for holding json results from webservices queries, should i go ahead and use a text column in the db or put them to the filesystem (which i already have working ... but worry about disjointed data)? |
| 21:31:17 | <chopin> right now, i just store a filesystem reference (getAbsolutePath()) |
| 21:31:19 | <chopin> and it's easdy |
| 21:31:21 | <chopin> eas |
| 21:31:21 | <chopin> y |
| 21:31:22 | <chopin> . |
| 21:31:35 | <chopin> but ... they're files |
| 21:31:37 | <chopin> :| |
| 21:34:56 | <bwolfe> putting it in the table you already have should be a simple step |
| 21:35:10 | <bwolfe> and you should default to putting things in the db |
| 21:35:52 | <chopin> right, just wondered if i should expect to exceed a 1.6M limit with a rest query |
| 21:35:56 | <chopin> probably not, right? |
| 21:36:16 | <chopin> sure makes my dao methods easier |
| 21:36:19 | <bwolfe> hopefully not |
| 21:36:30 | <chopin> if so, i could just request for the user to narrow the query |
| 21:36:51 | <bwolfe> or just drop random parts of it |
| 21:36:59 | <bwolfe> every 4th result |
| 21:36:59 | <chopin> ../ws/rest/v1/person/q=A |
| 21:37:05 | <chopin> true |
| 21:37:14 | <bwolfe> would save you 25% |
| 21:37:15 | <chopin> ../ws/rest/v1/person/q=% |
| 21:37:24 | <chopin> can i send a %? |
| 21:37:27 | <chopin> hmmm |
| 21:37:31 | * chopin tries that sometime |
| 21:37:34 | <bwolfe> rest has a limit on the rows |
| 21:37:36 | <chopin> ohh |
| 21:37:42 | <bwolfe> both at the query level and at the server admin level |
| 21:37:42 | <chopin> well that would decide it then |
| 21:37:48 | <chopin> okay |
| 21:37:51 | <bwolfe> s/rows/results |
| 21:37:54 | <chopin> reasonable, i hope |
| 21:37:58 | <chopin> and it's in the GPs |
| 21:38:04 | <bwolfe> max of 2 billion |
| 21:38:06 | <chopin> oh |
| 21:38:08 | <bwolfe> yes, its a gp |
| 21:38:17 | <bwolfe> kidding, I think max default is only 100 or 200 |
| 21:38:19 | <chopin> Good Point |
| 21:38:23 | <chopin> ok |
| 21:38:38 | <chopin> if someone has more encounters than that, we can go in batches i guess |
| 21:38:47 | <chopin> easy to have more obs tho |
| 21:38:53 | <chopin> oy veh |
| 21:38:58 | <chopin> labs |
| 21:39:01 | * chopin slams head against wall |
| 21:39:41 | <bwolfe> then admin should set max higher |
| 21:39:57 | <chopin> ok |
| 21:40:04 | <chopin> you convinced me |
| 21:40:11 | <chopin> btw, i'm calling my module Yank |
| 21:40:19 | <chopin> i hope that's okay with code@o.o |
| 21:40:35 | <bwolfe> I think you should go with Gank |
| 21:40:41 | <chopin> hmmmm |
| 21:40:45 | <chopin> that would require google code hosting |
| 21:40:58 | <chopin> also, you have to authenticate ... |
| 21:41:01 | <chopin> so it's not really ganking |
| 21:48:48 | *** bryq has joined #openmrs |
| 21:48:48 | *** ChanServ sets mode: +v bryq |
| 22:00:15 | *** bwolfe has quit IRC |
| 22:02:21 | *** mseaton has joined #openmrs |
| 22:03:07 | *** wyclif has quit IRC |
| 22:05:01 | *** djazayeri has joined #openmrs |
| 22:05:01 | *** ChanServ sets mode: +o djazayeri |
| 22:10:41 | *** rafa has quit IRC |
| 22:32:42 | *** mseaton has quit IRC |
| 22:45:54 | *** wyclif has joined #openmrs |
| 22:46:01 | *** chopin has quit IRC |
| 22:51:12 | <wyclif> hi djazayeri |
| 22:55:54 | <wyclif> am trying to conceptualize the workflow of getting a result, i know that the i need an evaluator to invoke and pass it to calculator/rule that and the parameter for the calculator, the question is that, dont we need some some sort of factory for evaluators and providers through a static method on the CalculatorContex? |
| 22:57:02 | <wyclif> sorry i could have mistyped something, |
| 22:57:08 | <wyclif> about the evaluator |
| 22:57:48 | <wyclif> pass the calculator, parameter values and context to the evaluator |
| 23:00:55 | <djazayeri> hi wyclif |
| 23:01:00 | <wyclif> hey |
| 23:01:28 | <djazayeri> Evaluators are provided by other modules |
| 23:01:43 | <djazayeri> Let me rephrase: some will be provided by this module. |
| 23:02:07 | <djazayeri> But, for example, the old logic module, and the reporting module, will provide evaluators/providers as well. |
| 23:02:27 | <djazayeri> I imagine they should be registered by those other modules (and by the calculation module) via sprint |
| 23:02:29 | <djazayeri> spring |
| 23:03:13 | <djazayeri> So, yes, there needs to be a way to register providers and evaluators |
| 23:03:40 | <djazayeri> I think it should be on CalculatorService, though, not on CalculatorContext. |
| 23:03:43 | <djazayeri> Why on the context? |
| 23:04:11 | <wyclif> djazayeri, i take that back, i think mike suggested annotations or some sort of registry, i vote for annotations |
| 23:04:28 | <djazayeri> wyclif: mike surely suggested or will suggest using the @Handler annotation. |
| 23:05:04 | <wyclif> djazayeri, sorry what i said was for wiring them |
| 23:05:24 | <djazayeri> I'm slightly concerned that using that will introduce unnecessary overhead, e.g. if you're running 100 calculations to do a patient summary. |
| 23:06:58 | <djazayeri> wyclif: in any case, I think that modules that depend on calculation should be the ones to instantiate their Providers and Validators via spring. |
| 23:07:08 | <djazayeri> I think we're agreeing. |
| 23:07:14 | <wyclif> djazayeri, yes |
| 23:15:18 | *** MarkG has quit IRC |
| 23:15:47 | *** MarkG has joined #openmrs |
| 23:19:41 | <wyclif> djazayeri, and shouldn't the context be created at module start up? rather than having a public method like createContext in the service |
| 23:20:08 | <djazayeri> wyclif: it's not that kind of context |
| 23:20:28 | *** MarkG has quit IRC |
| 23:20:42 | <djazayeri> it's a context that represents running a bunch of calculations with a shared cache, and shared parameters. |
| 23:20:54 | <djazayeri> e.g. it's like EvaluationContext in the reporting modules |
| 23:21:34 | <djazayeri> e.g. you can simply do service.eval(rule) |
| 23:21:46 | <djazayeri> but if you want more control you can do: |
| 23:21:57 | <djazayeri> ctx = service.createContext(); |
| 23:22:02 | <djazayeri> service.eval(rule1, ctx) |
| 23:22:07 | <djazayeri> service.eval(rule2, ctx) |
| 23:22:09 | <djazayeri> etc |
| 23:23:07 | <djazayeri> (if you just do service.eval(rule) it will create a context for you |
| 23:23:11 | <wyclif> ok |
| 23:24:00 | <wyclif> got you, thanks |