01:45:43
|
*** harshadura has joined #openmrs
|
02:00:35
|
<harshadura> hi
|
02:00:39
|
<harshadura> anyone thr
|
02:20:18
|
*** harshadura has quit IRC
|
02:51:16
|
*** maurya has joined #openmrs
|
03:52:06
|
*** maurya has quit IRC
|
04:09:47
|
*** djazayeri has quit IRC
|
04:13:50
|
*** upul` has joined #openmrs
|
04:13:50
|
*** ChanServ sets mode: +v upul`
|
05:05:59
|
*** suranga has joined #openmrs
|
05:26:30
|
*** djazayeri has joined #openmrs
|
05:26:30
|
*** ChanServ sets mode: +o djazayeri
|
05:42:28
|
*** dkayiwa has joined #openmrs
|
05:50:28
|
<suranga> wondering if any experts who are familiar with the use of R statistial module hang out here :P
|
05:50:34
|
<suranga> (but some rare chance :-)
|
05:53:43
|
<dkayiwa> suranga: for that, you would need to get to your knees and pray to God. :)
|
05:54:09
|
<suranga> dkayiwa, by some chance, have u tried working with it ?
|
05:54:21
|
<suranga> based on your tone, I feel tjhat you have prior experiance with it :)
|
05:54:35
|
<dkayiwa> suranga: i do not even know what it is used for :D
|
05:54:51
|
<suranga> ooops :D
|
05:55:32
|
<suranga> looks like praying may be my only option :-)
|
05:55:43
|
<suranga> dkayiwa, any news on Bens reapperance ?
|
05:55:59
|
<dkayiwa> suranga: still taking care of the little one :)
|
05:56:34
|
<suranga> I dont think I'll raise a family... it seems too much commitment to me :P
|
05:56:57
|
<dkayiwa> suranga: if it did not require so, it would cease to be enjoyable
|
05:57:07
|
<dkayiwa> suranga: is more than just coding :)
|
05:57:15
|
<dkayiwa> life is
|
05:57:50
|
<dkayiwa> suranga: the day you will fall in love with a young gal, you will forget all about what you have said :)
|
05:59:19
|
<suranga> dkayiwa, dear god, I hope that doesnt happen until Im too old to code :P
|
05:59:49
|
<dkayiwa> suranga: you do not plan for it. it just happens :)
|
06:11:15
|
*** maurya has joined #openmrs
|
06:27:56
|
*** maurya has quit IRC
|
06:27:58
|
*** djazayeri has quit IRC
|
06:28:01
|
*** djazayeri1 has joined #openmrs
|
06:36:48
|
*** djazayeri has joined #openmrs
|
06:36:48
|
*** ChanServ sets mode: +o djazayeri
|
06:36:49
|
*** djazayeri1 has quit IRC
|
06:43:53
|
*** morristic has joined #openmrs
|
06:48:49
|
*** dkayiwa_ has joined #openmrs
|
06:50:34
|
*** dkayiwa has quit IRC
|
06:50:34
|
*** dkayiwa_ is now known as dkayiwa
|
07:16:40
|
*** djazayeri has quit IRC
|
07:20:38
|
*** ibewes has joined #openmrs
|
07:21:09
|
<ibewes> hello!
|
07:22:15
|
<ibewes> I'm getting up to speed on the openmrs codebase, is svn still the most current version or is there has the github repo replaced it?
|
07:22:44
|
<dkayiwa> ibewes: svn is the most current as far as i know
|
07:23:16
|
<ibewes> ok, looking through the wiki it seems like some things are being moved to github, is that correct?
|
07:24:48
|
<dkayiwa> ibewes: some modules. as for core, still under discussion
|
07:25:07
|
<ibewes> gotcha, thanks for the info!
|
07:25:14
|
<dkayiwa> yo welcome
|
07:38:13
|
*** djazayeri has joined #openmrs
|
07:38:13
|
*** ChanServ sets mode: +o djazayeri
|
07:55:21
|
*** djazayeri has quit IRC
|
07:57:08
|
*** morristic has quit IRC
|
07:58:17
|
*** morristic has joined #openmrs
|
07:58:36
|
*** morristic has left #openmrs
|
08:32:43
|
*** dkayiwa has quit IRC
|
08:35:31
|
*** dkayiwa has joined #openmrs
|
08:38:17
|
*** allan_ has joined #openmrs
|
08:39:14
|
<allan_> just downloaded 1.8.3 and have existing database how do i update my database
|
08:40:07
|
<dkayiwa> allan_: first of all do a database backup
|
08:41:44
|
<allan_> ok
|
08:41:57
|
<allan_> finished
|
08:42:16
|
<dkayiwa> allan_: one of the ways is
|
08:43:16
|
<dkayiwa> allan_: 1) stop tomcat 2) delete the openmrs expanded folder under ../tomcat/webapps 3)overwrite the war file in ../tomcat/webapps with the one you have just downloaded 4) then start tomcat
|
08:46:56
|
<allan_> is ../tomcat/webapps in c:/m drive
|
08:58:41
|
<dkayiwa> allan_: it is wherever you installed tomcat
|
08:58:49
|
*** dkayiwa has quit IRC
|
09:13:01
|
*** harshadura has joined #openmrs
|
09:17:47
|
*** kishoreyekkanti has joined #openmrs
|
09:19:07
|
*** rafa has joined #openmrs
|
09:19:07
|
*** ChanServ sets mode: +v rafa
|
09:20:41
|
*** kishoreyekkanti_ has joined #openmrs
|
09:20:55
|
*** kishoreyekkanti has quit IRC
|
09:20:56
|
*** kishoreyekkanti_ is now known as kishoreyekkanti
|
09:24:24
|
<allan_> please someone help me
|
09:25:46
|
*** kishoreyekkanti_ has joined #openmrs
|
09:28:55
|
<suranga> allan_, the webaopps folder is inside your tomcat folder
|
09:28:56
|
*** allan_ has quit IRC
|
09:29:03
|
*** kishoreyekkanti has quit IRC
|
09:29:10
|
<suranga> u need to go into that folder .
|
09:29:18
|
<suranga> oops, he has left already :(
|
09:31:21
|
*** kishoreyekkanti_ has quit IRC
|
09:34:12
|
<harshadura> suranga ayya u thr
|
09:36:08
|
<suranga> hello hello
|
09:36:32
|
<suranga> Wellcome to our humble IRC channel
|
09:38:36
|
<harshadura> hi ayya :)
|
09:39:06
|
<suranga> so hows it going ? looked at any bugs lately ?
|
09:41:21
|
<harshadura> im started working on a intro ticket ayya > https://tickets.openmrs.org/browse/TRUNK-2768 but the thing is i cant jz figure out whr to start
|
09:41:26
|
<harshadura> pls can u help me ayya
|
09:48:15
|
<suranga> hi.. its like this...
|
09:48:30
|
<suranga> the aim of that ticket is to add an extra parameter to the model class and the database
|
09:48:54
|
<harshadura> okay yes
|
09:49:18
|
<suranga> so they want us to add a boolean value to the model class, and reflect that in the hbm, and finally add a column to the database...
|
09:49:27
|
<suranga> what part are u specifically stuck with ?
|
09:49:49
|
<suranga> first, u will need to add the variable into the model class, and write getters and setters
|
09:50:11
|
<suranga> next, u will need to add an Hibernate mapping to the hbm.xml file of the model class
|
09:50:42
|
<harshadura> okay ayya then
|
09:51:15
|
<harshadura> do i hv to edit the view
|
09:51:53
|
<suranga> thirdly, u will need to add a liquibase changeset so that the database table will be modified to include the new column
|
09:52:23
|
<suranga> and yep, u will also need to edit the jsp page (probably a tick box) so users can set it manually
|
09:52:43
|
<suranga> mm... how are u planning to proceed with this one ? :-)
|
09:53:45
|
<harshadura> i never used liquibase before. is that too difficult to getting started ayya
|
09:53:58
|
<suranga> no, not very
|
09:54:20
|
<suranga> basically liquibase is an xml file.. when we need to modify a database table, we code it into the liquibase file
|
09:54:26
|
<suranga> its not that hard
|
09:54:41
|
<suranga> actually, this is a good ticket to start learning, it covers all the basic angls
|
09:55:23
|
<suranga> I dont have openmrs checked out with me right now, but i think theres an xml file called liquibasechangeset.xml (something like that)
|
09:56:06
|
*** ibewes has quit IRC
|
09:56:20
|
<harshadura> okay ayya thanks lot I will look into it inform u later if i got any probs
|
09:56:23
|
<harshadura> thx again
|
09:57:18
|
<suranga> sure, no problem... Ill come online later tonight
|
09:57:31
|
<suranga> no worries, all the best !
|
10:00:13
|
*** ibewes has joined #openmrs
|
10:02:31
|
*** upul` has quit IRC
|
10:17:48
|
*** bryq has joined #openmrs
|
10:17:48
|
*** ChanServ sets mode: +v bryq
|
10:37:48
|
*** ibewes has quit IRC
|
10:37:51
|
*** suranga has quit IRC
|
10:39:19
|
*** ibewes has joined #openmrs
|
10:40:36
|
*** sthaiya has joined #openmrs
|
10:40:36
|
<sthaiya> hi all
|
10:40:36
|
<sthaiya> Just compiled openmrs war file from latest repo code
|
10:40:36
|
<sthaiya> while trying to install, i get an error at the last step "updating database"
|
10:40:36
|
<sthaiya> The error is
|
10:40:36
|
<sthaiya> There was an error while updating the database to the latest. file: liquibase-update-to-latest.xml. Error: null Error while trying to update to the latest database version
|
10:44:12
|
*** ibewes has quit IRC
|
10:46:31
|
*** sthaiya has quit IRC
|
10:46:47
|
*** sthaiya has joined #openmrs
|
10:50:27
|
*** sthaiya has joined #openmrs
|
10:55:21
|
*** sthaiya has quit IRC
|
10:55:31
|
*** sthaiya has joined #openmrs
|
10:56:00
|
*** sthaiya has joined #openmrs
|
11:15:18
|
*** morristic has joined #openmrs
|
11:33:29
|
*** harshadura has quit IRC
|
12:25:19
|
*** morristic has quit IRC
|
12:25:31
|
*** dkayiwa has joined #openmrs
|
12:29:59
|
<dkayiwa> hi rafa
|
12:30:24
|
<dkayiwa> rafa: do you know where i can find instructions on how to install pentaho components for this sprint?
|
12:30:52
|
<rafa> dkayiwa: I haven't looked at it yet.
|
12:31:07
|
<dkayiwa> rafa: ok
|
12:33:41
|
*** sthaiya has quit IRC
|
12:59:34
|
*** wyclif has quit IRC
|
13:17:34
|
<rafa> dkayiwa: seems like no installation is required for the pentaho components just download and unpack
|
13:17:57
|
<rafa> dkayiwa: don't ask me how to use it though ;)
|
13:43:40
|
*** bwolfe has joined #openmrs
|
13:43:40
|
*** ChanServ sets mode: +o bwolfe
|
13:47:05
|
*** Gretchie has joined #openmrs
|
13:51:44
|
*** wyclif has joined #openmrs
|
14:18:55
|
*** downeym has joined #openmrs
|
14:18:55
|
*** ChanServ sets mode: +o downeym
|
14:18:55
|
*** OpenMRSBot sets mode: +o downeym
|
14:27:25
|
*** mvorobey has joined #openmrs
|
14:29:22
|
<mvorobey> hi all
|
14:30:27
|
*** MarkG has joined #openmrs
|
14:33:04
|
<downeym> hey there mvorobey
|
14:33:17
|
<dkayiwa> rafa: hahahha
|
14:33:48
|
<dkayiwa> bwolfe: welcome back :D
|
14:34:08
|
<bwolfe> thanks dkayiwa
|
14:34:34
|
<dkayiwa> you are welcome :)
|
14:35:09
|
<downeym> bwolfe++
|
14:39:35
|
*** 13WAAGHWE has joined #openmrs
|
14:39:45
|
<downeym> Hi 13WAAGHWE and welcome to the #openmrs IRC channel.
|
14:40:12
|
<13WAAGHWE> dkayiwa, have you ever run more than one standalone instance at the same time?
|
14:40:16
|
<dkayiwa> 13WAAGHWE: what a name!!!! :)
|
14:40:26
|
<13WAAGHWE> wow
|
14:40:28
|
<13WAAGHWE> hehe
|
14:40:30
|
*** 13WAAGHWE is now known as chopin
|
14:40:41
|
<dkayiwa> 13WAAGHWE: oh yes. all i do is change the mysql and tomcat ports for each
|
14:40:48
|
<downeym> I kind of like 13WAAGHWE.
|
14:41:00
|
<downeym> it's catchy.
|
14:41:02
|
<chopin> dkayiwa, strange ... seems like the second instance is picking up on the first instance's MySQL port
|
14:41:03
|
<chopin> :-/
|
14:41:04
|
<chopin> heh
|
14:41:09
|
<chopin> not sure how to pronounce it
|
14:41:13
|
<chopin> or make it happen again, for that matter
|
14:41:31
|
<dkayiwa> chopin: you need to change the port number from the runtime properties file before you run it
|
14:41:38
|
<chopin> dkayiwa, ah set it there?
|
14:41:43
|
* chopin tries that
|
14:42:03
|
<bwolfe> 13wwaaghwe rolls right off the tongue too
|
14:42:22
|
<dkayiwa> chopin: yes
|
14:45:28
|
*** goutham has joined #openmrs
|
14:50:32
|
*** ChanServ sets mode: +v chopin
|
14:50:38
|
*** ChanServ sets mode: +v dkayiwa
|
14:50:42
|
*** ChanServ sets mode: +v MarkG
|
14:50:46
|
*** ChanServ sets mode: +v wyclif
|
14:53:03
|
*** goutham_ has joined #openmrs
|
14:53:51
|
*** djazayeri has joined #openmrs
|
14:53:51
|
*** ChanServ sets mode: +o djazayeri
|
14:55:51
|
*** goutham has quit IRC
|
14:59:17
|
<djazayeri> dkayiwa, rafa, bwolfe, mvorobey, Gretchie, join us at breeze.iu.edu/openmrsdev
|
14:59:27
|
<dkayiwa> djazayeri: ok
|
14:59:28
|
<djazayeri> (I see Gretchie and mvorobey there already.)
|
14:59:43
|
<rafa> ok
|
15:17:49
|
*** mseaton has joined #openmrs
|
15:41:11
|
*** mseaton has quit IRC
|
15:57:22
|
*** dawn_ has joined #openmrs
|
15:57:35
|
*** ChanServ sets mode: +v dawn_
|
15:58:16
|
*** deadpool has joined #openmrs
|
15:59:22
|
<dawn_> djazayeri: is there no sprint dashboard for Pentaho yet?
|
15:59:33
|
<djazayeri> dawn_: no
|
15:59:52
|
<djazayeri> dawn_: no scrum today—we're in the middle of an intro presentation from gretchen
|
15:59:59
|
<dawn_> k
|
16:00:07
|
<bwolfe> or delayed scrum?
|
16:00:24
|
<djazayeri> bwolfe: we can do it delayed. in 1 hour maybe?
|
16:00:26
|
<dawn_> djazayeri: will there be a dashboard after this meeting with gretchen?
|
16:00:51
|
<bwolfe> lunch time, perfect. :-)
|
16:00:53
|
<djazayeri> dawn_: I'm not creating a dashboard until I'm more clear what's going to go on it. (This sprint is unusual)
|
16:01:11
|
<dkayiwa> :D
|
16:01:35
|
<dawn_> djazayeri: bwolfe : i have meetings after this time until 12:30. If you have a scrum, I'll check the logs on the wiki
|
16:02:36
|
*** harshadura has joined #openmrs
|
16:02:51
|
<downeym> Hi harshadura and welcome to the #openmrs IRC channel.
|
16:03:56
|
<harshadura> hi thx :)
|
16:14:38
|
*** dkayiwa has quit IRC
|
16:18:20
|
*** dkayiwa has joined #openmrs
|
16:22:37
|
*** r0bby has joined #openmrs
|
16:22:37
|
*** ChanServ sets mode: +v r0bby
|
16:25:34
|
*** dkayiwa_ has joined #openmrs
|
16:25:37
|
*** r0bby_ has joined #openmrs
|
16:25:37
|
*** ChanServ sets mode: +v r0bby_
|
16:25:38
|
*** robbyoconnor has quit IRC
|
16:26:38
|
*** dkayiwa has quit IRC
|
16:26:39
|
*** dkayiwa_ is now known as dkayiwa
|
16:27:51
|
*** r0bby has quit IRC
|
16:48:45
|
<MarkG> djazayeri: do you know where/how in HFE we enforce that encounter form submission actions are handled before other tags?
|
16:48:54
|
<MarkG> i've got a form that works if I define it this way:
|
16:48:57
|
<djazayeri> MarkG: I don't hink we do.
|
16:49:10
|
<djazayeri> they happen sequentially based on where they live in the file
|
16:49:17
|
<MarkG> <htmlform>
|
16:49:17
|
<MarkG> Encounter Date: <encounterDate/>
|
16:49:17
|
<MarkG> Encounter Location: <encounterLocation/>
|
16:49:17
|
<MarkG> Encounter Provider: <encounterProvider role="Provider"/>
|
16:49:17
|
<MarkG> <enrollInProgram programId="10" />
|
16:49:17
|
<MarkG> <submit/>
|
16:49:17
|
<MarkG> </htmlform>
|
16:50:00
|
<MarkG> but fails if defined with "enrollInProgram" before encounterDate, since the enroll in program tag doesn't have a valid encounter date?
|
16:50:27
|
<djazayeri> Something we ought to do is add an <encounter></encounter> tag, and also make tag handlers have a tagStarted and tagEnded callbacks...
|
16:50:30
|
<MarkG> djazayeri: are you saying you think this is a known/existing limitation, and not a regression?
|
16:50:38
|
<djazayeri> MarkG: yes
|
16:50:49
|
<MarkG> djazayeri: okay, cool, that makes it easier... thanks...
|
16:51:20
|
<MarkG> djazayeri: i will enter a ticket/note about this somewhere...
|
17:02:23
|
*** mseaton has joined #openmrs
|
17:02:49
|
*** suranga has joined #openmrs
|
17:05:39
|
<mseaton> wyclif - have you started looking at logic today?
|
17:16:51
|
*** ploerch has joined #openmrs
|
17:17:04
|
<downeym> Hi ploerch and welcome to the #openmrs IRC channel.
|
17:18:20
|
*** ploerch has left #openmrs
|
17:22:16
|
*** suranga_ has joined #openmrs
|
17:22:17
|
*** suranga has quit IRC
|
17:22:39
|
*** dawn_ has quit IRC
|
17:28:06
|
*** maurya has joined #openmrs
|
17:41:58
|
<djazayeri> wyclif: have you and mseaton caught up yet?
|
17:56:00
|
<wyclif> djazayeri, mike just responded to the email thread i started
|
17:56:22
|
<djazayeri> wyclif: okay, you should also feel free to talk by phone, etc.
|
17:59:58
|
<wyclif> djazayeri, sure
|
18:05:51
|
*** maurya has quit IRC
|
18:12:37
|
*** mseaton has quit IRC
|
18:15:53
|
*** dkayiwa_ has joined #openmrs
|
18:16:19
|
*** mseaton has joined #openmrs
|
18:17:50
|
*** dkayiwa has quit IRC
|
18:17:50
|
*** dkayiwa_ is now known as dkayiwa
|
18:18:49
|
*** mnunez has joined #openmrs
|
18:20:23
|
*** mnunez has quit IRC
|
18:36:04
|
*** wyclif has quit IRC
|
18:38:43
|
*** wyclif has joined #openmrs
|
18:57:00
|
*** wyclif has joined #openmrs
|
18:57:49
|
<wyclif> mseaton, djazayeri am calling the module rule
|
18:58:17
|
<djazayeri> wyclif: I don't like that because rule implies an "action", not just a calculation, at least to me as a computer guy
|
18:58:25
|
<djazayeri> but it does have the advantage of being shrot
|
19:01:03
|
*** suranga_ has quit IRC
|
19:06:41
|
*** goutham_ has quit IRC
|
19:11:46
|
<chopin> djazayeri, (or any other ws person): when you do not include a field in someone's name or address (for example), is it because the value of that field (address4 for example) is "" or null?
|
19:12:16
|
<chopin> djazayeri, also do you have plans on exposing relationships in ws?
|
19:12:23
|
<djazayeri> chopin: it *should* be null, but I don't know how we coded it.
|
19:12:31
|
<djazayeri> chopin: yes, we'll do that eventually.
|
19:12:33
|
<djazayeri> chopin: busy now
|
19:12:39
|
<chopin> djazayeri, thought so ... k
|
19:12:43
|
<bwolfe> chopin, correct, to save bandwidth those are excluded from the output
|
19:12:50
|
<bwolfe> chopin, make a ticket for it
|
19:12:56
|
<bwolfe> (for the relationships)
|
19:13:22
|
<chopin> bwolfe, ah k ... i think i might be working with a slightly older version of ws on one instance because it is showing me nulls
|
19:13:30
|
<wyclif> bwolfe, mseaton djazayeri what version of the core should the new logic module require?
|
19:16:03
|
<bwolfe> wyclif, 1.15, since thats when it will be done ;-)
|
19:16:32
|
<wyclif> bwolfe, hmm
|
19:17:01
|
<bwolfe> chopin, hmm, maybe that wasn't implemented? :-/
|
19:17:20
|
<chopin> bwolfe, it does not show them in the most recent version
|
19:17:34
|
<chopin> bwolfe, i think the 1.8.1-with-ws standalone might have an older version?
|
19:17:54
|
<bwolfe> chopin, thats a pre-alpha, for sure
|
19:18:17
|
<chopin> k
|
19:18:26
|
<bwolfe> chopin, what version of openmrs are you using with the latest?
|
19:18:36
|
<chopin> 1.8.2
|
19:18:58
|
<wyclif> djazayeri, if we are having things like Rule, RuleContext, RuleService etc why not call them Calculation etc
|
19:18:59
|
<bwolfe> ok
|
19:19:11
|
<djazayeri> wyclif: you and mseaton can decide on the name
|
19:19:21
|
<djazayeri> I agree that if we call the module calculation, we should name things Calculaiton instead
|
19:19:32
|
<djazayeri> you two just decide something, and the rest of us will have to deal with it
|
19:20:48
|
<wyclif> djazayeri, i think renaming things things an an IDE is trivial, so i will use rule in the meantime and will rename them once i come to an agreement with mike
|
19:20:49
|
<mseaton> wyclif: yes, see the wiki page. it says basically if we change the name rule, everything that has rule in it should be changed to have the new thing in it
|
19:21:07
|
<wyclif> mseaton, are you fine with rule?
|
19:21:15
|
<wyclif> mseaton, sorry calculation
|
19:21:27
|
<mseaton> wyclif: my suggestion in my last email was calculation.patient, but no one responded.
|
19:21:34
|
<mseaton> this was last week
|
19:22:21
|
<wyclif> i think calculation is more inclusive than calculation.patient
|
19:22:21
|
<mseaton> this way, if we decide to have encounter-based calculations (like number of encounters per day at location x), then we can do that with calculation.encounter
|
19:22:39
|
<mseaton> yes it is, but we are only writing code for patient calculations here.
|
19:23:22
|
<wyclif> mseaton, then why not patientcalculation rather then calculation.patient
|
19:23:30
|
<mseaton> i'm happy if the module is called calculation, as long as the specific packages we write for the logic replacement are in the "patient" org.openmrs.module.calculation.patient subpackage
|
19:24:04
|
<mseaton> that way we keep all of the code in the one module, but we leave the door open for other types of calculations.
|
19:24:19
|
<mseaton> so i think using the moduleid "calculation" is good.
|
19:24:46
|
<wyclif> mseaton, i will take care of the packages, am using org.openmrs namespace and not org.openmrs.module
|
19:31:01
|
<mseaton> oh right. org.openmrs.calculation is great.
|
19:31:06
|
*** deadpool has quit IRC
|
19:31:37
|
<mseaton> thanks wyclif! i'm about to go offline. email me if you want to connect today.
|
19:32:14
|
*** mseaton has quit IRC
|
19:32:31
|
<wyclif> mseaton. ok, so you are fine with the package name not including module as you initially suggested on the project design page?
|
19:33:05
|
<wyclif> djazayeri, did we agree that wer are using the org.openmrs namespace rather than the org.openmrs.module?
|
19:33:31
|
<djazayeri> wyclif: do it the way mseaton says
|
19:33:46
|
<djazayeri> yes, don't use .module, since we intend to pull this into core when it's ready
|
19:33:55
|
<wyclif> djazayeri, ok
|
19:59:46
|
*** deadpool has joined #openmrs
|
20:00:16
|
<dkayiwa> anyone familiar with this? ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/tmp/mysql.sock' (2)
|
20:02:18
|
<r0bby_> hey all!
|
20:02:48
|
*** r0bby_ is now known as robbyoconnor
|
20:18:01
|
*** dkayiwa has quit IRC
|
20:18:21
|
<mvorobey> bye all!!!
|
20:18:34
|
<mvorobey> gotta sleeep :)
|
20:18:38
|
*** mvorobey has quit IRC
|
20:28:45
|
*** downeym has quit IRC
|
20:39:59
|
*** kishoreyekkanti has joined #openmrs
|
21:02:17
|
<rafa> djazayeri: btw removing select min(obs_datetime) from that query makes it execute in 1,5 sec ;)
|
21:02:25
|
<MarkG> fyi, if anyone has been trying to reach anyone at PIH, our email has been down for most of the day
|
21:03:00
|
<rafa> djazayeri: I suppose we could execute that part as a separate query or some transformation
|
21:03:36
|
<djazayeri> rafa: maybe for something that (we know) very rarely recurs, we can flatten to one-per-patient manually in java faster
|
21:05:02
|
<rafa> djazayeri: right doing this kind of filter on 4k rows should be fast in java
|
21:05:44
|
<djazayeri> rafa: but I don't know how we'll represent that as we try to generalize for OpenMRS...
|
21:06:08
|
<djazayeri> I guess as "obs that should only happen once per patient"
|
21:06:24
|
<djazayeri> have you tried running the 1.6 webapp against this database?
|
21:06:37
|
<rafa> djazayeri: nope
|
21:06:41
|
<djazayeri> okay
|
21:07:03
|
<djazayeri> I was just trying the same query in the reporting module, but I'm getting an error with something about the location_tag table being misformed
|
21:07:27
|
<djazayeri> oh well, never mind that...
|
21:11:08
|
*** lefam has joined #openmrs
|
21:12:32
|
*** lefam has quit IRC
|
21:18:06
|
<rafa> djazayeri: still there?
|
21:18:12
|
<djazayeri> yes
|
21:18:26
|
<rafa> I've come up with such a query:
|
21:18:27
|
<rafa> select obs.person_id, person.birthdate, value_numeric, obs_datetime
|
21:18:27
|
<rafa> from obs
|
21:18:27
|
<rafa> left join person on obs.person_id = person.person_id
|
21:18:27
|
<rafa> left join patient on patient.patient_id = person.person_id
|
21:18:27
|
<rafa> where person.voided = 0 and obs.voided = 0 and patient.voided = 0
|
21:18:28
|
<rafa> and concept_id = 5916
|
21:18:28
|
<rafa> group by obs.person_id
|
21:18:29
|
<rafa> having min(obs_datetime) = obs_datetime;
|
21:19:18
|
<rafa> Ohh sorry thought it was faster, but it wasn't even started :P
|
21:19:40
|
<djazayeri> It's possible that turning the subquery into a join is faster. I think it is.
|
21:21:31
|
<rafa> djazayeri: okay it seems to be much faster
|
21:21:46
|
<rafa> djazayeri: I'm not sure if results are still good
|
21:22:18
|
<bwolfe> rafa: results probably arent good. the other columns will be random
|
21:22:24
|
*** dkayiwa has joined #openmrs
|
21:22:34
|
<bwolfe> they won't necessarily be the same as the values from the row with the min
|
21:23:23
|
<rafa> bwolfe: you're probabaly right
|
21:25:54
|
<bwolfe> rafa:
|
21:25:55
|
<bwolfe> SELECT o1.*
|
21:25:55
|
<bwolfe> from (
|
21:25:55
|
<bwolfe> select person_id, min(obs_datetime) as first_obs_date
|
21:25:55
|
<bwolfe> from obs
|
21:25:55
|
<bwolfe> group by person_id) as o2
|
21:25:56
|
<bwolfe> inner join obs as o1
|
21:25:58
|
<bwolfe> on
|
21:26:00
|
<bwolfe> (o1.person_id=o2.person_id and o1.obs_datetime=o2.first_obs_date)
|
21:26:02
|
<bwolfe> where
|
21:26:04
|
<bwolfe> o1.concept_id = 1234
|
21:26:37
|
<bwolfe> ada happened to be struggling with this same thing today, and got this to be the fastest way to select rows out of the encounter table with 3.8m rows in it. I adapted it to obs here
|
21:27:04
|
*** kishoreyekkanti has quit IRC
|
21:29:39
|
<rafa> bwolfe: seems like what Darius originally suggested, but maybe there's some subtle difference that seeds it up :)
|
21:29:57
|
<bwolfe> is it faster?
|
21:30:16
|
<bwolfe> I don't see darius' suggestion
|
21:30:19
|
<rafa> bwolfe: I haven't tried
|
21:30:38
|
<djazayeri> rafa: bwolfe has done it subtly differently, so that the group by happens in the from, rather than the where. I think that may be faster
|
21:37:13
|
*** chopin has quit IRC
|
21:37:13
|
<bwolfe> rafa, needs a voided = 0 in the inner from
|
21:41:13
|
<bwolfe> only took 90 seconds to get the birth weights
|
21:49:00
|
*** dkayiwa has quit IRC
|
22:33:46
|
<wyclif> hi djazayeri
|
22:34:00
|
<djazayeri> hi wyclif
|
22:35:29
|
<wyclif> so the persistent class is TokenRegistration, but i wanted to call it something else, i plan to edit the wiki page so as to keep it updated with changes in the domain objects and services
|
22:35:40
|
<wyclif> djazayeri, so the persistent class is TokenRegistration, but i wanted to call it something else, i plan to edit the wiki page so as to keep it updated with changes in the domain objects and services
|
22:35:53
|
<wyclif> djazayeri, probably Calculation
|
22:36:00
|
<djazayeri> wyclif: you don't strictly have to keep the wiki page up to date
|
22:36:05
|
<djazayeri> you could just comment.
|
22:36:14
|
<djazayeri> i.e. comment on the wiki page.
|
22:37:05
|
<djazayeri> wyclif: so as not to cost you lots of time
|
22:59:26
|
*** bryq has quit IRC
|
23:07:14
|
*** MarkG has quit IRC
|
23:07:53
|
*** MarkG has joined #openmrs
|
23:12:21
|
*** MarkG has quit IRC
|
23:25:24
|
<wyclif> djazayeri, was it agreed to use custom datatypes and handler interfaces?
|
23:25:33
|
<djazayeri> wyclif: we didn't discuss it
|
23:25:37
|
<djazayeri> I think it'd be too much of a pain
|
23:25:43
|
<wyclif> djazayeri, thought it seems like we want to support older versions
|
23:25:48
|
<djazayeri> exactly
|
23:26:31
|
<wyclif> djazayeri, ParameterDefinitionis an interface, what would be a typical implementation
|
23:26:46
|
<djazayeri> Oh, I thought ParameterDefinition was a class
|
23:26:55
|
<djazayeri> if it's an interface, make a BaseParameterDefinition
|
23:28:07
|
*** rafa has quit IRC
|
23:42:39
|
*** wyclif has quit IRC
|