IRC Chat : 2012-02-10 - OpenMRS

00:16:58 *** downeym has quit IRC
00:26:33 <MarkG> djazayeri: no hurry, i'm done for the night (and i'm assuming rafal is done)... but check out my long-winded comment on this ticket when you get a chance...
00:26:38 <MarkG> !ticket HTML-64
00:26:39 <OpenMRSBot> MarkG: [#HTML-64] Additions to htmlforms for workflow and states - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-64
00:27:17 <djazayeri> MarkG: okay, I'll put it on the list
00:32:09 <MarkG> djazayeri: thanks
00:33:29 *** MarkG has quit IRC
00:49:53 *** Maieuto has joined #openmrs
00:57:14 *** wyclif has joined #openmrs
01:31:19 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Google Summer of Code is coming. Find out how #OpenMRS plans to participate: http://t.co/iMQ0OW1X #GSoC #ICT4D #HealthIT #eHealth <http://twitter.com/OpenMRS/statuses/167779270251380737>
01:40:26 <deadpool> djazayeri: when saving a patient it creates a person but at the same time how does it save the person address to that person?
01:40:42 <deadpool> does that happen automatically when you call savePatient?
01:41:37 <djazayeri> deadpool: yes
01:42:13 <deadpool> how does the person address and person get linked is my quesion i don't see how it does it
01:42:27 <deadpool> i have created a new patient and i have created a new person address
01:42:30 <djazayeri> deadpool: "how" in what sense?
01:42:35 <djazayeri> You ought to be able to do something like:
01:42:42 <djazayeri> Patient p = new Patient();
01:42:46 <deadpool> yeah did that
01:42:48 <djazayeri> p.addAddress(new PersonAddress(…));
01:42:52 <deadpool> did
01:42:53 <deadpool> that
01:42:54 <deadpool> too
01:42:59 <djazayeri> Context.getPatientService().savePatient(p);
01:43:04 <deadpool> that is done
01:43:14 <djazayeri> Okay, so what's the question?
01:43:30 <deadpool> so i am not understanding is how the person address gets the person id
01:43:58 <deadpool> because the patient gets a person id once he has savePatient has been called
01:44:10 <djazayeri> deadpool: Hibernate takes care of all that by magic.
01:44:20 <deadpool> huh
01:44:20 <djazayeri> Because of the relationships defined in the hbm.xml files
01:44:22 <deadpool> all right
01:44:24 <deadpool> ah
01:44:25 <deadpool> ok
01:44:51 <djazayeri> deadpool: in Person.hbm.xml there's this snippet
01:44:52 <djazayeri> <set name="addresses" lazy="false" inverse="true" batch-size="1000"
01:44:52 <djazayeri> cascade="all-delete-orphan" sort="natural"
01:44:52 <djazayeri> order-by="voided asc, preferred desc, date_created desc">
01:44:52 <djazayeri> <key column="person_id" not-null="true" />
01:44:52 <djazayeri> <one-to-many class="PersonAddress" />
01:44:52 <djazayeri> </set>
01:45:22 <djazayeri> without going into the gory details, when we tell hibernate to save a Person, it cascades to also save the addresses on the person
01:45:29 <deadpool> ah ok
01:47:49 <deadpool> djazayeri: another question i have looked at the person address and it seems that you can add multiple address to a patient but i don't see how to do that in the webapp? is there a way or do i have to add it through a module?
01:48:40 <djazayeri> deadpool: the long version of the edit patient page lets you do this:
01:48:40 <djazayeri> http://demo.openmrs.org/openmrs/admin/patients/patient.form?patientId=2
01:51:17 <deadpool> but not through registration
01:51:35 <djazayeri> deadpool: correct, at patient creation time you only see the short form
01:51:43 <deadpool> gotcha
02:21:35 <deadpool> djazayeri: in maven how do i change the dependency of openmrs from 1.7 to 1.8?
02:21:52 <djazayeri> deadpool: in a module you created with the archetype?
02:22:08 <deadpool> yeah
02:22:14 <deadpool> i downloaded the registration module
02:22:20 <deadpool> hacking it and doing some updates
02:22:27 <deadpool> and it uses 1.7.0
02:22:44 <djazayeri> deadpool: and it's a mavenized module, right?
02:22:56 <deadpool> yeah
02:23:47 <djazayeri> deadpool: typically in the pom.xml in the root/parent project there's a variable declared for openmrsVersion
02:23:50 <djazayeri> you'd just change that
02:26:57 <deadpool> djazayeri: gotcha thanks i saw that
02:27:24 <djazayeri> deadpool: do you need to use some new functionality in 1.8 that wasn't in 1.7?
02:27:40 <djazayeri> because we didn't really add much new in 1.8 at the API level...
02:27:43 <deadpool> uhh no just doing some updating
02:27:47 <deadpool> it might be usefull
02:27:57 <djazayeri> I'd think most things do fine if you leave them as 1.7, so they're more broadly installable
02:28:34 <djazayeri> up to you
02:31:48 <deadpool> ah ok
02:32:25 <deadpool> djazayeri: i did have one more question about the permgen error
02:32:36 <deadpool> is there a way to clear the classloading from the memory?
02:32:58 <deadpool> cause increasing memory doesn't really seem like a solution because all it does it delay a pergen memory error
02:36:15 <djazayeri> deadpool: not really
02:36:33 <djazayeri> apparently tomcat and java argue about whose fault it is
02:36:43 <djazayeri> anyway, you do have to eventually restart
02:36:46 <deadpool> huh so we can't do it manually
02:36:51 <djazayeri> no
02:37:01 <deadpool> so it is not really stable then
02:37:14 <djazayeri> stable?
02:37:25 <deadpool> like is 1.8 in actual use?
02:37:25 <djazayeri> the memory leak exists when you redeploy the web application
02:37:38 <djazayeri> Yes, 1.8 is the recommended stable version
02:37:54 <deadpool> but in deployment has anyone had to restart?
02:37:55 <djazayeri> The permgen-related errors are about redeploying the webapp multiple times in development
02:38:08 <deadpool> ah not in implementation
02:38:18 <djazayeri> correct
02:38:40 <djazayeri> if you just start up the server and use it normally, it should run "forever" without a restart.
02:38:53 <djazayeri> "forever" means months on linux, I'd guess.
02:40:02 <djazayeri> gotta run for a bit
02:40:33 <deadpool> ok
02:50:59 *** Maieuto has quit IRC
02:59:14 *** morristic has joined #openmrs
03:26:09 *** upul` has joined #openmrs
03:26:09 *** ChanServ sets mode: +v upul`
03:41:54 *** morristic has left #openmrs
04:23:29 *** suranga has joined #openmrs
04:27:12 *** deadpool has quit IRC
06:25:30 *** dkayiwa has joined #openmrs
06:44:33 *** yOgi has joined #openmrs
06:56:16 *** upul` has quit IRC
06:57:18 *** magicaltrout has quit IRC
06:57:24 *** magicaltrout has joined #openmrs
07:02:14 *** r0bby has joined #openmrs
07:02:14 *** ChanServ sets mode: +v r0bby
07:02:21 *** robbyoconnor has quit IRC
07:11:40 *** wyclif has quit IRC
07:15:12 *** r0bby is now known as robbyoconnor
07:33:34 *** Mkop1 has joined #openmrs
07:33:34 *** ChanServ sets mode: +v Mkop1
07:33:55 *** Mkop has quit IRC
07:33:56 *** djazayeri has quit IRC
07:33:58 *** wyclif has joined #openmrs
07:34:01 *** djazayeri has joined #openmrs
07:34:01 *** ChanServ sets mode: +o djazayeri
07:50:08 *** djazayeri1 has joined #openmrs
07:53:16 *** djazayeri has quit IRC
07:57:45 *** dkayiwa has quit IRC
08:03:47 *** djazayeri has joined #openmrs
08:03:47 *** ChanServ sets mode: +o djazayeri
08:06:08 *** djazayeri1 has quit IRC
08:28:45 *** dkayiwa has joined #openmrs
08:52:24 *** sthaiya has joined #openmrs
08:58:11 <sthaiya> hello
09:02:14 *** yOgi has quit IRC
09:45:51 *** suranga has quit IRC
09:49:26 *** rafa has joined #openmrs
09:49:26 *** ChanServ sets mode: +v rafa
10:51:52 *** brajesh has joined #openmrs
10:52:06 <brajesh> hi
11:02:26 *** sthaiya has quit IRC
11:05:58 *** james_regen has joined #openmrs
11:05:58 *** ChanServ sets mode: +v james_regen
11:32:28 *** morristic has joined #openmrs
11:34:46 *** robbyoconnor has quit IRC
11:36:19 *** brajesh has quit IRC
12:01:49 *** harshadura has joined #openmrs
12:05:13 *** morristic has quit IRC
12:06:42 *** harshadura has quit IRC
12:10:49 *** mvorobey has joined #openmrs
12:10:56 <mvorobey> hi all
12:11:16 <dkayiwa> hey you :)
12:34:02 <mvorobey> dkayiwa: I would like to take a part in OpenMRS Pentaho sprint. I read this wiki page https://wiki.openmrs.org/display/RES/2012-02-13+Pentaho+Sprint. Truly, I'm new to ETL and OLAP technologies and would ask you to give me some advices what to read to speed up myself in this stuff
12:35:24 <dkayiwa> mvorobey: hahahah :) Am in the same boat as you when it comes to Pentaho
12:35:41 <dkayiwa> mvorobey: but you can ping Darius
12:35:55 <dkayiwa> mvorobey: or sent him mail
12:36:15 <mvorobey> dkayiwa: thanx
12:36:26 <mvorobey> dkayiwa: so, will learn it together :)
12:36:36 <dkayiwa> mvorobey: oh yes :)
12:36:48 <dkayiwa> mvorobey: faster learning when we are more than one :)
12:37:00 <mvorobey> dkayiwa: yep
12:38:04 <mvorobey> I have already read some wiki pages about ETL, OLAP and Pentaho and can say that it's really big thing and involves lot of features
12:38:22 <dkayiwa> mvorobey: correct!!!
12:43:38 <mvorobey> dkayiwa: but the main point which I got from that was that it brings analitics data collection and reporting to principally new level
12:43:58 <dkayiwa> mvorobey: very very very true :)
12:45:37 <mvorobey> dkayiwa: Am currently working on installing Pentaho components onto my system
12:45:54 <dkayiwa> mvorobey: oh now you are ahead of me :)
12:48:05 <mvorobey> dkayiwa: am I ?:) I'm afraid that it will be a long process while I'll have them installed and correctly configured :)
12:48:47 <dkayiwa> mvorobey: when my turn comes, now i know to to run to for help :D
12:49:41 *** Maieuto has joined #openmrs
12:49:57 <mvorobey> dkayiwa: with pleasure will share all my experience with you :)
12:50:17 <dkayiwa> mvorobey: oh that is so sweet!!! :)
12:54:50 <mvorobey> dkayiwa: will be more sweet if I'll overcame of all wisdoms of Pentaho :)
12:55:21 <dkayiwa> mvorobey: you do not have to overcome all for it to be sweet enough :)
13:01:38 <mvorobey> dkayiwa: you sure :D either I do it or it does me )))
13:01:54 <dkayiwa> mvorobey: hahhaahahahah
13:03:08 <mvorobey> dkayiwa: but anyway, will continue work.
13:03:13 <mvorobey> dkayiwa: thanx, Daniel for nice conversation :)
13:03:43 <dkayiwa> mvorobey: you are welcome. Thanks too for joining efforts that write code to save loves!!! :D
13:03:56 <dkayiwa> loves = lives :)
13:04:41 <mvorobey> dkayiwa: no-no :) loves it's right word, especially before Saint Valentine Day :)
13:04:54 <dkayiwa> mvorobey: hahaahahahah
13:07:57 *** harshadura has joined #openmrs
13:12:42 <dkayiwa> hi djazayeri
13:13:25 *** bryq has joined #openmrs
13:13:25 *** ChanServ sets mode: +v bryq
13:19:57 *** mvorobey has quit IRC
13:37:42 *** Maieuto has quit IRC
13:39:56 *** Maieuto has joined #openmrs
13:47:49 *** Mkop1 is now known as Mkop
13:48:10 *** wyclif has quit IRC
13:55:34 *** harshadura has quit IRC
14:09:11 *** downeym has joined #openmrs
14:09:11 *** ChanServ sets mode: +o downeym
14:09:11 *** OpenMRSBot sets mode: +o downeym
14:23:04 <dkayiwa> hi downeym
14:26:20 *** downeym has quit IRC
14:26:57 *** downeym has joined #openmrs
14:26:57 *** ChanServ sets mode: +o downeym
14:26:57 *** OpenMRSBot sets mode: +o downeym
14:31:57 *** wyclif has joined #openmrs
14:36:11 *** MarkG has joined #openmrs
14:36:12 <OpenMRSBot> Recent updates in the world of openmrs: Shazin Sadakath: Time Based SQL Injection using heavy queries in MySQL <http://shazsterblog.blogspot.com/2012/02/time-based-sql-injection-using-heavy.html>
14:46:11 <dkayiwa> thanks downeym :)
14:46:34 <downeym> dkayiwa: no problem :)
14:54:07 <rafa> wyclif: failed to validate with reason: conceptMappings[0].conceptReferenceTerm: Concept.map.termRequired?
14:54:12 <rafa> wyclif: how do I set it?
14:54:37 <rafa> wyclif: I can't use 1.9 or 1.10 methods
14:55:14 *** dawn_ has joined #openmrs
14:55:32 *** ChanServ sets mode: +v dawn_
14:55:54 <wyclif> hi rafa
14:56:03 <rafa> wyclif: hi :)
14:56:26 <rafa> wyclif: is there a way?
14:56:39 <wyclif> you need to create a ConceptReferenceTerm object and set it on the conceptMap one
14:56:54 <rafa> wyclif: yeah but that was added in 1.9 right?
14:57:03 <wyclif> rafa, yes
14:57:04 <rafa> wyclif: I can only use 1.6 stuff
14:57:14 <MarkG> rafa: what is failing?
14:57:30 <wyclif> rafa, it is not required in 1.6
14:57:47 <rafa> MarkG: I want to create concept mapping in org.openmrs.module.htmlformentry.WorkflowStateTagTest.shouldDisplayStateSpecifiedByMapping()
14:58:07 <rafa> wyclif: yes, but when I run old 1.6 code against 1.9 it fails
14:58:16 <wyclif> rafa, the test dataset for 1.8 and below should be different from that of 1.9+
14:58:37 <MarkG> rafa: yeah, you will probably just need to define the mapping in the dataset, unfortunately...
14:58:46 <wyclif> wyclif, that is expected
14:58:47 <rafa> wyclif: I understand, but still when I try to create a concept mapping programatically it should work in all versions
14:58:56 <wyclif> rafa yes
14:59:05 <rafa> wyclif: it doesn't
14:59:22 <wyclif> rafa, and what error are you getting?
14:59:35 <rafa> '10002' failed to validate with reason: conceptMappings[0].conceptReferenceTerm: Concept.map.termRequired
14:59:41 <wyclif> rafa, is this in a module?
14:59:51 <rafa> wyclif: yes in hfe
14:59:54 <rafa> ConceptMap conceptMap = new ConceptMap();
14:59:55 <rafa> conceptMap.setConcept(state.getConcept());
14:59:55 <rafa> conceptMap.setSource(Context.getConceptService().getConceptSource(1));
14:59:55 <rafa> conceptMap.setSourceCode(state.getConcept().getId().toString());
14:59:55 <rafa> state.getConcept().addConceptMapping(conceptMap);
14:59:56 <rafa> Context.getConceptService().saveConcept(state.getConcept());
15:00:03 <rafa> it's how I create mapping
15:00:12 <wyclif> rafa, this if HFE, right?
15:00:32 <rafa> wyclif: right
15:00:43 <dawn_> djazayeri: , rafa , dkayiwa , MarkG , wyclif : hi. Ben and family says hi too (they're here for a quick stop)
15:00:48 <MarkG> rafa: wyclif: ah, so the problem is that the change to concept mapping may break legacy code...
15:00:50 <MarkG> hi ben
15:00:57 <dawn_> !scrumon dawn
15:00:57 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
15:00:57 <rafa> MarkG: correct
15:01:05 <dkayiwa> dawn_: oh please send our regards!!! :)
15:01:06 <rafa> MarkG: okay hold let's hold on :)
15:01:16 <dawn_> Today's order: rafa , dkayiwa , djazayeri , wyclif , MarkG
15:01:22 <wyclif> rafa, HFE requires 1.6, so we have to deal with that, you have to find a way to know the version you are working with
15:01:48 <rafa> Today:
15:01:48 <rafa> * Committed HTML-297: defaultValue and defaultDatetime Attributes re-inserting default values after manually cleared
15:01:48 <rafa> https://tickets.openmrs.org/browse/HTML-297
15:01:48 <rafa> * Addressed review comments for HTML-64: Additions to htmlforms for workflow and states
15:01:48 <rafa> https://tickets.openmrs.org/browse/HTML-64
15:01:49 <rafa> * Still working on HTML-64: Additions to htmlforms for workflow and states
15:01:49 <rafa> https://tickets.openmrs.org/browse/HTML-64
15:01:50 <rafa> No blockers.
15:01:53 <dkayiwa> Reviewed and committed some changes for: Add delete (and retire?) for program states in the workflow - TRUNK-251
15:01:54 <dkayiwa> Reviewed: Concept doesn't have flexible methods for getting a name by locale, type, and tags - TRUNK-2589
15:01:54 <dkayiwa> Committed: Release logic 0.5.1 bundled with OpenMRS 1.9 - TRUNK-3045
15:01:54 <dkayiwa> Done some 1.9 ticket administration
15:01:55 <dkayiwa> Now reviewing: Drug regimen "Scheduled Stop Date" not shown in regimen list or cannot stop regimen with future dates - TRUNK-1962
15:01:55 <dkayiwa> No Blockers
15:02:21 <dawn_> djazayeri: you ready?
15:04:13 <dawn_> wyclif: can you go now?
15:04:18 <wyclif> Thursday:
15:04:18 <wyclif> * TODOs for HTML-246 - program enrollment tag and updating the wiki
15:04:18 <wyclif> * TRUNK-198 - Small fixes for newpatient.form
15:04:18 <wyclif> * Dev call
15:04:18 <wyclif> * Code reviews for custom datatypes
15:04:19 <wyclif> Today:
15:04:21 <wyclif> * Update the wiki for program tag for HFE
15:04:23 <wyclif> * TRUNK-3001 - Add initialization/update wizard messages for languages other than english
15:04:27 <wyclif> * Any pending TODOs in teh current sprint
15:04:29 <wyclif> * prepare for next week's sprint
15:04:31 <wyclif> blockers:none
15:04:45 <dawn_> MarkG: your turn
15:05:42 <MarkG> not much new to report... seems like we just did a scrum
15:05:50 <MarkG> * continue reviewing HFE sprint commits
15:06:20 <MarkG> * plan to attempt HTML-205
15:06:24 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Logic 0.5.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=logic&ampversion=&amp0.5.1>
15:06:29 <rafa> !ticket HTML-205
15:06:30 <OpenMRSBot> rafa: [#HTML-205] Enable javascript id tag on encounter date - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-205
15:06:33 <MarkG> * write email about state of HFE sprint to dev list
15:06:51 <MarkG> * no blockers
15:06:57 <MarkG> oh..
15:07:21 <MarkG> * write unit tests for testing exporting forms with new workflowState tag and updated enrollInProgram tag
15:07:24 <MarkG> that's it
15:07:41 <dawn_> MarkG: do you feel things are still moving along at a good pace to finish this sprint before the Pentaho sprint begins?
15:07:44 <dawn_> djazayeri: you there?
15:08:59 <MarkG> wyclif: rafa: so the issue, i believe, is that any modules that create concept maps programmatically will fail when upgrading to 1.9?
15:09:01 <dawn_> !scrumoff dawn
15:09:01 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
15:09:14 <wyclif> MarkG, probably
15:09:20 <rafa> for sure :)
15:09:44 <wyclif> MarkG, we probably need to fix that in trunk before releasing 1.9
15:10:11 <MarkG> rafa: wyclif: right, sounds like a trunk issue--Rafal, do you want to create a ticket, if one does't already exist? :)
15:11:34 <rafa> MarkG: ok
15:14:05 <wyclif> MarkG, rafa though i recall as though i was able to do this in occ module
15:14:48 <rafa> wyclif: can you point to a piece of code?
15:17:11 <wyclif> rafa, cant recall exactly
15:17:21 <wyclif> rafa, may be not
15:17:34 <rafa> wyclif: okay no worries
15:17:48 <wyclif> rafa, i will add a test to trunk and make sure it works, i have put it on my todo list for today
15:18:00 <wyclif> rafa, if it doesnt , i will fix it
15:18:47 *** dkayiwa has left #openmrs
15:18:54 <rafa> wyclif: I've just created a ticket for you then: TRUNK-3057 :)
15:19:36 *** dawn_ has quit IRC
15:22:54 *** bryq has quit IRC
15:23:57 <wyclif> rafa, MarkG the fix could be as simple as editing the getter for conceptReferenceTerm in ConceptMap to return a new object if the field is null, can you try that and see if the test passes
15:24:47 <wyclif> if it works, only a unit test in trunk would be required and the ticket is fixed
15:25:09 <rafa> wyclif: okay I'll test it quick.
15:26:09 *** dawn_ has joined #openmrs
15:26:09 *** ChanServ sets mode: +v dawn_
15:26:49 <wyclif> rafa it might fail with the map type missing on the type, and that fix to that would be to set the type to same as as default for older versions in that getter still
15:27:02 <wyclif> sorry on the reference term
15:29:10 *** Maieuto has quit IRC
15:29:31 <rafa> wyclif: it's faster to actually write the test in core ;)
15:31:17 <wyclif> rafa, i meant that test in HFE, if it passes, give me about and a hr, i just wanted you to test your HFE test agiansst what i believe is the solution withough being blocked
15:32:03 <rafa> wyclif: yeah but I can't overwrite the getter in HFE :)
15:32:11 <wyclif> the getter for ConceptMap.conceptReferenceTerm and that of BaseConceptMap.conceptMapType should not return null
15:32:28 <rafa> wyclif: and I need to rebuild the whole core and install it
15:32:42 <rafa> wyclif: to test it ;)
15:32:44 <wyclif> rafa, i meant to add these changes to trunk and test agianst it since 1.9 and trunk have the same concept mapping structure
15:33:21 <wyclif> rafa, what 1.9 api version are we using?
15:33:45 <wyclif> rafa, i will make the test in trunk and commit it probably in the next 1hr or so
15:34:10 <rafa> wyclif: no need to hurry, it's not a blocker to me :)
15:34:18 <wyclif> rafa, cool
15:52:46 *** james_regen has left #openmrs
16:02:28 *** robbyoconnor has joined #openmrs
16:02:39 *** ChanServ sets mode: +v robbyoconnor
16:03:28 <djazayeri> whoops, sorry, somehow the scrum times haven't percolated through my google calendars correctly
16:12:05 *** robbyoconnor has quit IRC
16:15:07 *** robbyoconnor has joined #openmrs
16:15:07 *** ChanServ sets mode: +v robbyoconnor
16:16:45 *** Maieuto has joined #openmrs
16:16:52 <downeym> Hi Maieuto and welcome to the #openmrs IRC channel.
16:18:21 *** dawn_ has quit IRC
16:24:56 *** r0bby has joined #openmrs
16:24:56 *** ChanServ sets mode: +v r0bby
16:26:30 *** robbyoconnor has quit IRC
16:28:17 *** dawn_ has joined #openmrs
16:28:17 *** ChanServ sets mode: +v dawn_
16:33:54 *** r0bby has quit IRC
16:35:05 *** dawn_ has quit IRC
16:44:11 *** Maieuto has quit IRC
16:46:42 *** Maieuto has joined #openmrs
16:51:06 *** suranga has joined #openmrs
17:03:22 *** Pupuser has joined #openmrs
17:03:28 <downeym> Hi Pupuser and welcome to the #openmrs IRC channel.
17:05:24 *** suranga_ has joined #openmrs
17:05:25 *** suranga has quit IRC
17:05:55 *** downeym has quit IRC
17:23:03 *** r0bby has joined #openmrs
17:23:03 *** ChanServ sets mode: +v r0bby
17:31:25 *** Maieuto has quit IRC
17:36:31 *** Maieuto has joined #openmrs
17:38:08 *** r0bby has quit IRC
17:48:35 *** Maieuto has quit IRC
17:50:23 *** Maieuto has joined #openmrs
17:52:16 *** bryq has joined #openmrs
17:52:16 *** ChanServ sets mode: +v bryq
17:56:11 *** r0bby has joined #openmrs
17:56:11 *** ChanServ sets mode: +v r0bby
17:59:42 *** downeym has joined #openmrs
17:59:42 *** ChanServ sets mode: +o downeym
17:59:42 *** OpenMRSBot sets mode: +o downeym
18:18:31 *** Pupuser has quit IRC
18:31:18 *** Maieuto has quit IRC
18:44:34 *** downeym has quit IRC
18:46:10 *** rafa has quit IRC
18:48:55 *** suranga has joined #openmrs
18:51:38 *** suranga_ has quit IRC
18:57:31 *** suranga has quit IRC
19:05:37 *** downeym has joined #openmrs
19:05:37 *** ChanServ sets mode: +o downeym
19:05:37 *** OpenMRSBot sets mode: +o downeym
19:18:11 *** r0bby has quit IRC
19:33:40 *** sudo has joined #openmrs
19:33:49 <downeym> Hi sudo and welcome to the #openmrs IRC channel.
19:33:56 <sudo> Hey, thanks!
19:34:07 <sudo> Having some trouble getting OpenMRS working on amazon ec2
19:34:25 <sudo> When I run ./startup.sh, is it supposed to run the service infinitley?
19:34:54 <sudo> when I go to :8080 on the private IP amazon gave me, I can't see anything
19:42:10 <downeym> sudo: have you had a look at https://wiki.openmrs.org/display/docs/Installing+OpenMRS+on+Amazon+EC2 ?
19:57:17 *** chopin has joined #openmrs
19:57:44 <chopin> djazayeri, what lib do you prefer for making web requests and handling responses from java code?
19:58:15 <chopin> apparently org.apache.httpcomponents is throwing some conflicts with tomcat classes
20:00:31 <djazayeri> chopin: I did a hacky client example for the web service module that's here:
20:00:32 <djazayeri> http://svn.openmrs.org/openmrs-contrib/examples/webservices/hackyswingexample/
20:00:33 <OpenMRSBot> <http://ln-s.net/9H0d> (at svn.openmrs.org)
20:00:41 <djazayeri> Apparently I used jersey
20:00:55 <chopin> ah k .. apace httpclient would be fine if tomcat didn't barf on it
20:01:32 <djazayeri> chopin: I've also used httpclient before, with OpenMRS, I thought.
20:01:56 <chopin> for some reason i'm getting a conflict, and if i use scope: provided it definitely dies
20:03:21 <chopin> i like jersey too
20:03:22 <chopin> so
20:03:36 <chopin> if it works, i'll be fine :D
20:06:16 <chopin> djazayeri, after installing the module, pages work until i hit the one whose controller's POST method references httpclient instances (even if I'm doing just a GET) ... then i get this on every page (besides index.htm): http://pastebin.com/ykgLk1pa
20:07:50 <djazayeri> chopin: odd, and I have no idea what's up with that
20:08:03 <djazayeri> (I've used HttpClient to connect *to* OpenMRS, but not within an OpenMRS module.)
20:08:24 <chopin> ah, i think that's where the trickiness is
20:08:39 <chopin> tomcat must have something in a lib somewhere that is conflicting
20:08:43 * chopin doesn't care to figure that out
20:08:46 <chopin> i'll try jersey
20:22:46 <chopin> much better
20:22:47 <chopin> :|
20:28:04 <djazayeri> MarkG: I just commented on HTML-286, but basically some unit tests are failing for me now. I think it's a trivial fix of moving one line earlier in the code in TestUtil, but have you done this already?
20:29:49 <MarkG> djazayeri: i haven't done that, but i'm looking at the failing tests now...
20:30:23 <MarkG> djazayeri: i think it is actually the fix i put in for james earlier today...
20:30:59 <MarkG> djazayeri: not quite sure what is happening yet tho
20:31:16 <MarkG> djazayeri: dave just also commited the new regimen tab, but i haven't updated yet
20:31:37 <djazayeri> okay. the unit test failures I'm seeing are because this line isn't working:
20:31:38 <djazayeri> string = string.replaceAll("<div class=\"htmlform\">(.*)</div>", "$1");
20:31:46 <djazayeri> in TestUtil.stripTagsAndWhitespace
20:32:12 <djazayeri> I can't tell why it didn't work though
20:33:08 <MarkG> aaah.. the parameter to tell it to include the line breaks needs to be added there too... i will do that now...
20:33:21 *** sudo has quit IRC
20:34:35 <MarkG> just added a (?s) to that, let me see what happens when i run the tests...
20:36:36 <MarkG> djazayeri: something weird is going on...
20:37:17 <djazayeri> MarkG: in this case I think we need the "Dot matches line terminator [DOTALL] (s flag)"
20:37:20 <djazayeri> which is what you're saying
20:40:03 <MarkG> djazayeri: on a form, there is a single encounter details submission element that backs all of the encounter tags?
20:40:15 <djazayeri> MarkG: I don't think so
20:40:38 *** chopin has quit IRC
20:40:48 <djazayeri> Each <encounterXyz/> should instantiate a new EncounterDetailSubmissionElement
20:41:00 <MarkG> djazayeri: oh, cool, that's what i originally thought...
20:41:11 <djazayeri> MarkG: I have fixed the TestUtil method, should I commit?
20:41:25 <MarkG> sure...
20:41:48 <MarkG> so did you have to change the <span class="value"> matcher as well?
20:42:14 <djazayeri> not for the unit tests I was looking at, but I guess I might as well...
20:43:35 <MarkG> huh... were the unit tests you were looking at failing because the <span> was not getting removed? that is the problem i am seeing
20:43:56 <djazayeri> MarkG: what I'm seeing is that the <div class="htmlform"> isn't getting removed
20:44:06 <djazayeri> but I'm also seeing a failure due to classcastexeption...
20:44:16 <djazayeri> And I think I have a clean, up-to-date, checkout
20:44:40 <MarkG> yeah, i was going to look at that as well...
20:45:47 <MarkG> djazayeri: duh... i see where i was going wrong now...
20:46:09 <djazayeri> MarkG: anyway, I just did a commit to add the (?s) flag to those replaceAlls.
20:46:13 <djazayeri> off to lunch now
20:46:27 <MarkG> djazayeri: okay, thanks... i will take a look at the class exception error
21:18:14 <MarkG> djazayeri: i had to remove the (?s) from the <span> replaces, b/c since (.*) is greedy it was screwing up if there were multiple <span class="value"> over multiple lines
21:43:30 <djazayeri> MarkG: You could have made it reluctant, like (.*?)
21:45:50 <MarkG> djazayeri: yeah, that was the other option... i figured i'd just revert it to the way it was...
21:46:09 <djazayeri> that's fine
21:55:28 <MarkG> djazayeri: should have waited on responding to HTML-216, you might have saved me a little time... :)
21:57:49 <djazayeri> MarkG: maybe I should have tweeted "about to reply to HTML-216 #openmrs #toomuchinformation"
21:58:25 <MarkG> djazayeri: at least we agreed, so i didn't have to decide if i wanted to rethink my comments
22:11:16 <MarkG> djazayeri: can i close
22:11:21 <MarkG> !ticket HTML-296
22:11:22 <OpenMRSBot> MarkG: [#HTML-296] Bug in substituting uuids for ids when tags are similar - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-296
22:12:42 <djazayeri> MarkG: I'm about to test that now
22:12:45 <djazayeri> I'll close it when I do
22:13:19 <MarkG> djazayeri: cool, sounds good
22:14:06 <djazayeri> MarkG: except that the HFE unit tests are still not passing, so I can't do a clean build. :-)
22:14:24 <MarkG> -DskipTests
22:15:08 <MarkG> djazayeri: you saw i created a ticket for one of them...
22:15:18 <djazayeri> I only see one failing test now
22:15:24 <djazayeri> the one about WorkflowStateTagTest
22:15:27 <djazayeri> classcastexception
22:15:56 <MarkG> djazayeri: yeah, i created a ticket for that... looks like an easy fix, just wanted Rafal to confirm what he was actually trying to pass to the method
22:16:41 <djazayeri> it's a hidden field widget, so it must be a String that he's setting...
22:17:42 <djazayeri> MarkG: okay, I'll @Ignore it and continue.
22:17:53 <MarkG> djazayeri: yeah, i could probably figure it out, but figured i'd be safe and ask him, see my notes
22:17:57 <MarkG> !ticket HTML-299
22:17:58 <OpenMRSBot> MarkG: [#HTML-299] failing unit test: shouldDisplayIfSpecifiedStateAndHiddenStyle(org.openmrs.module.htmlformentry.WorkflowStateTagTest) Time elapsed: 0.583 sec <<< ERROR! - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-299
22:18:52 <MarkG> once you start testing against 1.9 & 1.10 you get a few more failing tests... one is one that Wyclif should know about, the others are more WorkflowState failings... I will work on them on Monday...
22:19:13 *** judy has joined #openmrs
22:20:14 <MarkG> djazayeri: i'm going to try your suggested fix for HTML-297 now
22:20:19 <MarkG> !ticket HTML-297
22:20:20 <OpenMRSBot> MarkG: [#HTML-297] defaultValue and defaultDatetime Attributes re-inserting default values after manually cleared - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-297
22:20:20 <wyclif> MarkG, am working on the some of the issues, almost there
22:21:14 <MarkG> wyclif: great, thanks
22:21:23 <judy> hey mark...just realised that i may have been confused abt sonething...
22:21:52 <judy> whats tge difference btwn an obs val and obs datr.ur comments on the ticket...
22:22:54 <MarkG> judy: an obs can have both a value (the actual value of the obs) and a date (the date the observation was made)
22:23:20 <judy> cos i thought each obs has a value.whose attribute can be .showdate=true. ..and hence this is becomes a date
22:23:54 <judy> oops...had the wrong path..
22:25:09 <MarkG> judy: if you look at an Obs object, you will see that it has a obsDatetime property--that is where the date entered by the showDate widget should be stored
22:26:05 *** downeym has quit IRC
22:28:44 <judy> ok.. back on track....
22:28:50 <judy> thanks...
22:28:57 <MarkG> judy: np
22:30:14 <judy> will hopefully get my ticket done by the wknd
22:30:33 <MarkG> judy: great
22:31:09 <MarkG> djazayeri: is HFE compiling for you with the @Ignore?
22:31:36 <djazayeri> MarkG: I also had to @Ignore the whole HFERegimenUtilTest class
22:32:00 <djazayeri> I'm now building and it's still downloading maven stuff
22:32:17 <MarkG> djazayeri: yeah, i ran into a problem with REgimen Util
22:32:30 <MarkG> djazayeri: that just came in from Dave... I will take a look...
22:32:43 *** bryq has quit IRC
22:33:16 <MarkG> djazayeri: looks like it is in the omod instead of the api...
22:33:36 <djazayeri> yes
22:33:50 <djazayeri> I don't look at what the actual exception message was—something about application context
22:34:26 <MarkG> djazayeri: i figured it was where it was located... just moved them, will test to see if it works now...
22:34:51 <djazayeri> MarkG: the way things are currently set up, doing a mvn install needs to download the 40mb 1.10-SNAPSHOT war file.
22:35:14 <djazayeri> that's not good
22:35:29 <MarkG> djazayeri: is it the release-tests?
22:35:32 <djazayeri> yeah
22:35:44 <djazayeri> we need to disable those unless the right profile is specified, or something
22:35:56 <MarkG> djazayeri: i made a mental note to email Kishore to see if there was a way to disable them...
22:36:03 <MarkG> djazayeri: ... but I haven't emailed him yet
22:36:35 <MarkG> djazayeri: it also just makes the build slow... and if you are just trying to run tests, it is still slow
22:37:16 <djazayeri> MarkG: it just makes builds slow for us, but for someone in Rwanda, a 40MB download the first time you build HTML Form Entry everyday is kind of a blocker. :-)
22:37:48 <MarkG> yeah, remove the "just" from my last line...
22:38:05 <MarkG> djazayeri: ah, good point, since it is updated nightly...
22:40:03 <MarkG> djazayeri: looks like it might be as simple as moving that into a profile... i will try now...
22:42:03 *** deadpool has joined #openmrs
22:49:39 <MarkG> djazayeri: am i reading it wrong, or is the comment "Returns the last AJAX submission made" for getSetLastSubmissionFieldsJavascript inaccurate? where does AJAX come in?
22:50:25 <djazayeri> MarkG: yeah, I think that's completely wrong. I imagine at some point I was considering AJAX...
22:50:45 <MarkG> djazayeri: i'll fix it... just wanted to make sure i wasn't missing something
22:50:56 <djazayeri> np
23:02:06 *** judy has quit IRC
23:05:35 <MarkG> djazayeri: moving the <module>release-tests</module> into a profile worked... it isn't build by default now... I'll commit the change... at some point we will will have to modify Kishore's shell script...
23:06:07 <MarkG> djazayeri: i commited the move of the RegimenTests as well, so they work now...
23:07:24 <MarkG> i'm heading out... have a good weekend everyone...
23:07:47 *** MarkG has left #openmrs
23:26:37 *** wyclif has quit IRC
23:30:37 <deadpool> djazayeri: quick question i compiled the registration omod yesturday and it worked and all i changed was the openmrs version and now it won't compile and i changed it back and i get this error http://pastebin.com/pvmhLV5W
23:56:11 <djazayeri> deadpool: what's the maven command you're running?
23:56:20 <deadpool> djazayeri: running sudo mvn package
23:57:50 <djazayeri> deadpool: are you doing it on the root project?
23:57:57 <djazayeri> seems like you might have just run it on the omod
23:58:10 <deadpool> no i am doing it in the root of the project
23:58:22 <deadpool> oh wait nope i was wrong
23:58:30 <deadpool> what is the point of having a omod in the omod?
23:58:56 <djazayeri> there shouldn't be an omod in the omod
23:59:04 <deadpool> sorry a pom in the omod
23:59:39 <djazayeri> deadpool: there shouldn't be a pom either afaik
23:59:57 <djazayeri> you mean the fact that there's a root/omod/pom.xml?