IRC Chat : 2012-02-08 - OpenMRS

00:26:29 *** r0bby has quit IRC
00:26:52 *** r0bby has joined #openmrs
00:26:52 *** ChanServ sets mode: +v r0bby
00:42:46 *** MarkG1 has quit IRC
00:43:14 *** MarkG has joined #openmrs
00:47:18 *** rafa has quit IRC
00:48:01 *** MarkG has quit IRC
00:49:38 *** Maieuto has quit IRC
00:51:32 *** Maieuto has joined #openmrs
00:56:16 *** jehds has quit IRC
01:12:45 *** Maieuto has quit IRC
01:43:32 *** wyclif has joined #openmrs
01:57:03 *** magicaltrout has quit IRC
01:59:05 *** magicaltrout has joined #openmrs
02:12:13 *** r0bby has quit IRC
02:12:41 *** r0bby has joined #openmrs
02:12:41 *** zelazny.freenode.net sets mode: +v r0bby
02:15:27 *** r0bby has quit IRC
02:16:15 *** wyclif has quit IRC
02:16:48 *** wyclif has joined #openmrs
02:20:46 *** r0bby has joined #openmrs
02:20:46 *** ChanServ sets mode: +v r0bby
02:25:16 *** r0bby is now known as robbyoconnor
03:04:20 *** bryq has quit IRC
03:54:12 *** suranga has joined #openmrs
04:09:55 <wyclif> hi djazayeri
04:28:49 *** morristic has joined #openmrs
04:41:29 *** morristic_ has joined #openmrs
04:41:29 *** morristic has quit IRC
04:41:29 *** morristic_ is now known as morristic
05:32:25 *** magicalt1out has joined #openmrs
05:32:56 *** magicaltrout has quit IRC
05:40:18 *** suranga_ has joined #openmrs
05:44:20 *** pushkar has joined #openmrs
05:46:18 *** Echidna has quit IRC
05:46:36 *** suranga has quit IRC
05:46:36 *** Echidna_ has joined #openmrs
05:53:11 <djazayeri> hi wyclif
06:26:16 *** pushkar has quit IRC
07:04:12 *** dkayiwa has joined #openmrs
07:21:55 *** dkayiwa has quit IRC
07:23:56 *** dkayiwa has joined #openmrs
07:32:10 *** dkayiwa has quit IRC
07:36:02 *** dkayiwa has joined #openmrs
07:43:19 *** bryq has joined #openmrs
07:43:19 *** ChanServ sets mode: +v bryq
08:18:44 *** magicalt1out is now known as magicaltrout
08:32:55 *** dkayiwa has quit IRC
09:18:54 *** Echidna_ has quit IRC
09:19:02 *** Echidna has joined #openmrs
09:19:02 *** ChanServ sets mode: +v Echidna
09:57:47 *** rafa has joined #openmrs
09:57:47 *** ChanServ sets mode: +v rafa
10:32:14 *** maurya has joined #openmrs
10:54:10 *** suranga_ has quit IRC
11:10:01 *** maurya has quit IRC
12:04:59 *** morristic has quit IRC
12:07:36 *** morristic has joined #openmrs
12:10:07 *** james_regen has joined #openmrs
12:10:07 *** ChanServ sets mode: +v james_regen
12:11:00 *** morristic has quit IRC
12:57:19 *** wyclif has quit IRC
13:06:45 *** rafa has quit IRC
13:09:43 *** rafa has joined #openmrs
13:09:43 *** ChanServ sets mode: +v rafa
13:39:36 *** dkayiwa has joined #openmrs
13:56:58 *** wyclif has joined #openmrs
13:59:24 *** MarkG has joined #openmrs
14:35:34 *** nribeka has joined #openmrs
14:35:34 *** ChanServ sets mode: +v nribeka
15:30:45 *** dawn_ has joined #openmrs
15:30:45 *** ChanServ sets mode: +v dawn_
15:31:07 <dawn_> !scrumon dawn
15:31:07 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
15:31:15 <dawn_> hi!
15:31:47 <dawn_> Today's order: rafa , djazayeri , dkayiwa , wyclif , MarkG
15:31:59 <rafa> hey
15:32:47 <dawn_> hey
15:32:49 <dawn_> rafa: you ready?
15:32:54 <rafa> sure
15:32:55 <rafa> Today:
15:32:55 <rafa> * HTML-293: Create test jar
15:32:55 <rafa> https://tickets.openmrs.org/browse/HTML-293
15:32:55 <rafa> * Working on HTML-64: Additions to htmlforms for workflow and states
15:32:55 <rafa> https://tickets.openmrs.org/browse/HTML-64 and will continue for a few more hours as I started later today
15:32:56 <rafa> No blockers.
15:33:52 <dawn_> djazayeri: your turn
15:34:00 <djazayeri> sorry, skip me for a sec
15:34:15 <dawn_> booo
15:34:22 <dawn_> dkayiwa: can you go now? please :)
15:35:03 <djazayeri> I'll go
15:35:05 <djazayeri> Tuesday 7-Feb-2012
15:35:05 <djazayeri> * Failed to write unit tests and commit code for HTML-268 (1.9 Providers in HFE) due to two blockers
15:35:05 <djazayeri> * Addressed code review comments for TRUNK-39 (merging of multiple-providers-per-encounter branch)
15:35:05 <djazayeri> * Plan for upcoming Pentaho sprint
15:35:05 <djazayeri> * Call with Mike to discuss Pentaho
15:35:06 <djazayeri> Wednesday 8-Feb-2012
15:35:07 <djazayeri> * University call
15:35:07 <djazayeri> * call with Gretchen for Pentaho sprint planning
15:35:08 <djazayeri> * more planning for Pentaho sprint
15:35:08 <djazayeri> * Design call
15:35:09 <djazayeri> * Project Management call
15:35:09 <djazayeri> * write unit tests and commit code for HTML-268 (1.9 Providers in HFE) due to two blockers
15:35:10 <djazayeri> * Check whether I've also broken the id + javascript set value with my datepicker changes
15:35:22 <djazayeri> blockers: github privileges, HFE test jars
15:36:30 <djazayeri> dkayiwa: ?
15:37:02 <rafa> djazayeri: test jars should be fine now, just note that they are created for different openmrs versions depending on the profile you select
15:37:12 <dawn_> dkayiwa: you ready?
15:37:22 <djazayeri> rafa: shouldn't they be installed in the maven repo though?
15:37:31 <djazayeri> (for the default profile)
15:37:36 <dawn_> wyclif: can you give your updates?
15:37:39 <dawn_> plz
15:37:45 <wyclif> unfortunately i have just confirmed we can't support 1.7 in SMART module, the actual url blockers:(slowed down) getting SMART apps to work in 1.7
15:38:05 <wyclif> sorry
15:38:06 <rafa> djazayeri: they will be installed when Mark decides to deploy them :)
15:38:15 <wyclif> bad copy and paste
15:38:27 <djazayeri> wyclif: try again. :-)
15:38:53 <wyclif> Tuesday:
15:38:53 <wyclif> * Catching up with email back log
15:38:53 <wyclif> * SMART TODOs
15:38:53 <wyclif> * Code review for DownloadableCustomDatatype and Cusstom resource(review had been closed)
15:38:53 <wyclif> * went through trunk tickets that were open
15:38:54 <wyclif> TODOs Wednesday:
15:38:56 <wyclif> * TRUNK-2273 - Avoid Duplicate Rows in Patient_State Table
15:38:58 <wyclif> * TRUNK-222 - Unable to find patients if their name is less than 3 characters
15:39:00 <wyclif> * TRUNK-198 - Small fixes for newpatient.form
15:39:02 <wyclif> blockers:(slowed down) getting SMART apps to work in 1.7
15:39:44 <dawn_> MarkG: your turn :)
15:40:08 <MarkG> * spent most of yesterday afternoon working Haiti Patient Registration stuff
15:40:11 <MarkG> today
15:40:18 <MarkG> * code review HFE tickets
15:40:28 <MarkG> * answer HFE questions
15:40:40 <MarkG> no blockers
15:41:05 <djazayeri> wyclif: There are ~5 reviews about custom datatype refactoring that I assigned to you. Only one was closed, right?
15:41:27 <wyclif> djazayeri, yes
15:41:31 <dawn_> !scrumoff dawn
15:41:31 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
15:41:36 <dawn_> i didn't see any discussion points
15:41:38 <wyclif> djazayeri, the other was jeremy's form resource
15:41:43 <dawn_> dkayiwa: if you're around, let us know your updates
15:41:56 <djazayeri> Also, if SMART apps working with 1.7 is slowing you down, just give up on 1.7-compatibility
15:42:01 <djazayeri> and go straight to 1.8.
15:42:36 <MarkG> wyclif: HTML-246 looks good overall, but I just put it in rework state and asked you to change one thing, look into a failing unit test against 1.9+, and write a few more unit tests...
15:43:07 <djazayeri> wyclif: I thought most of TRUNK-3035, TRUNK-3036, TRUNK-3037, TRUNK-3038 had reviews for you
15:44:03 <MarkG> rafa: djazayeri: we still need to decide what the correct behavior is for state editing, taking into account that a user might change the associated encouter date
15:44:24 <MarkG> rafa: i forward our email chain on to you, but i don't think we ever resolved it... what is your current approach?
15:44:45 <wyclif> djazayeri, i have gotten hacky workarounds,
15:45:18 <MarkG> and overall, i wanted to thank everybody for their work over the past week-and-a-half... I feel like we have been very productive... looking forward to doing it again... :)
15:45:20 <djazayeri> MarkG, rafa: I don't know if it *is* solvable, without a ton of work
15:45:29 <wyclif> MarkG, ok
15:46:13 <djazayeri> downeym isn't here, huh
15:46:20 <MarkG> djazayeri: rafa: yeah, we need to "resolve" how we want to handle it, but we probably won't "solve" it
15:46:22 <wyclif> MarkG, a few more unit about which area in the code
15:46:51 <MarkG> wyclif: i wrote it all up in a comment on the ticket...
15:46:58 <wyclif> MarkG, cool\
15:47:01 <wyclif> MarkG, cool
15:48:04 <MarkG> wyclif: sorry for being a unit test taskmaster... but it is a REALLY good way to catch edge cases...
15:48:28 <djazayeri> MarkG: take that back!
15:48:32 <djazayeri> MarkG: don't *ever* apologize for asking someone to write a unit test!
15:49:43 <wyclif> djazayeri, he he he
15:50:42 <MarkG> djazayeri: wyclif: well, i'm not that sorry... and i'm asking him to write four, in addition to the four he already wrote...
15:50:56 <wyclif> MarkG, i will add them
15:52:38 <wyclif> MarkG, that ticket has 3 commits, did you notice that
15:53:36 <MarkG> wyclif: yep... i just reviewed the latest version of the test class you created...
15:55:14 <MarkG> djazayeri: even with michael's changes, you still can't commit the new module?
15:55:26 <djazayeri> MarkG: after restarting I was able to
15:55:48 <djazayeri> not sure what the issue was
15:55:50 <MarkG> djazayeri: oh, good...
15:56:10 <MarkG> djazayeri: github appeared to be down a bit this morning, fwiw...
15:56:19 <djazayeri> oh, maybe that was it
15:58:03 <dkayiwa> sorry guys, is it still scrum time? djazayeri , dawn_
15:58:15 <djazayeri> too late, but we're still here
15:58:20 <djazayeri> go ahead and give your update :-)
15:58:25 <dkayiwa> Some 1.9 ticket administration
15:58:25 <dkayiwa> Working on: Release logic 0.5.1 bundled with OpenMRS 1.9 - TRUNK-3045
15:58:26 <dkayiwa> Attended University call
15:58:26 <dkayiwa> No Blockers
15:58:33 <dkayiwa> :)
15:59:21 <dawn_> dkayiwa: : thanks
15:59:34 <dkayiwa> yo welcome dawn_ :)
16:07:47 <MarkG> djazayeri: just added this
16:07:52 <MarkG> !ticket HTML-294
16:07:53 <OpenMRSBot> MarkG: [#HTML-294] Assess impact of removing Mode.ENTER and then remove it if possible - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-294
16:09:19 *** magicaltrout is now known as bugg_tb
16:09:46 *** bugg_tb is now known as magicaltrout
16:17:31 *** dkayiwa has quit IRC
16:20:01 *** dkayiwa has joined #openmrs
16:25:07 *** dawn_ has quit IRC
16:25:21 *** dawn_ has joined #openmrs
16:55:18 *** dkayiwa has quit IRC
16:55:58 *** dkayiwa has joined #openmrs
17:14:16 *** dkayiwa has quit IRC
17:16:03 *** bryq has quit IRC
17:32:36 *** deadpool_ has joined #openmrs
17:33:39 *** dkayiwa_ has joined #openmrs
17:41:59 *** nribeka has quit IRC
17:43:39 <dkayiwa_> hi wyclif
17:44:11 <wyclif> hi dkayiwa_
17:44:16 <dkayiwa_> wyclif: TRUNK-198
17:44:50 <dkayiwa_> location drop down is displayed before you submit form. it only vanishes after submitting and the form has errors
17:44:59 <dkayiwa_> wyclif: is that the intended behavior?
17:52:10 *** suranga has joined #openmrs
18:03:04 *** nribeka has joined #openmrs
18:03:04 *** ChanServ sets mode: +v nribeka
18:08:58 <wyclif> hi dkayiwa_
18:09:09 <dkayiwa_> hi wyclif
18:09:30 <wyclif> dkayiwa_, i will look at it, what indentifier type is that?
18:09:49 <dkayiwa_> wyclif: both demo data identifiers
18:10:10 <dkayiwa_> wyclif: actually whatever identifier you create regardless of its properties
18:10:14 <wyclif> dkayiwa_, i will look at it, are you testing against trunk?
18:10:25 <dkayiwa_> wyclif: yes
18:10:28 <wyclif> hmm
18:10:37 <wyclif> dkayiwa_, will look at it
18:10:44 <dkayiwa_> wyclif: ok thanks!!!
18:16:05 *** james_regen has quit IRC
18:17:20 <dkayiwa_> hi djazayeri
18:17:29 <djazayeri> hi dkayiwa_
18:17:54 <dkayiwa_> djazayeri: tested and confirmed the logic module trunk runs on 1.8. should i also test for 1.7? TRUNK-3045
18:18:22 <djazayeri> Ideally you'd also check 1.6 and 1.7
18:18:29 <djazayeri> do you have them available?
18:18:47 <dkayiwa_> djazayeri: i can setup standalone versions for each
18:19:16 <djazayeri> There aren't standalones packaged for 1.6 and 1.7...
18:19:26 <djazayeri> do you have the code checked out that you could run 1.6.x and 1.7.x in jetty?
18:19:54 <dkayiwa_> djazayeri: it is just a matter of dropping the appropriate war file in the standalone unzipped folder :)
18:20:04 <djazayeri> ah, okay
18:20:29 <dkayiwa_> djazayeri: does it make sense testing for 1.6 when the logic module has this? <require_version>1.7.2.17710-1.9.*</require_version>
18:20:30 <djazayeri> also, for one of the versions, can you check that if you start with logic 0.5, and then upgrade to 0.5.1, it doesn't mess things up?
18:21:31 <djazayeri> dkayiwa_: you'll have to do a custom build for 1.6.3+ actually
18:21:45 <djazayeri> See "in the 1.6.x line" under 0.5 on https://wiki.openmrs.org/x/6ACw
18:21:50 <djazayeri> you'll need to do the same for 0.5.1
18:21:56 <dkayiwa_> djazayeri: ok
18:22:51 <djazayeri> the issue is that we want it to work for 1.6.3.17711-1.6.* and 1.7.2.17710+, but that isn't allowed
18:23:08 <dkayiwa_> djazayeri: ok
18:23:16 <djazayeri> dkayiwa_: actually, when you release this, can you remove the upper limit of 1.9.*? That was ill-advised when I put it in.
18:23:54 <dkayiwa_> djazayeri: surely. no wonder it made me fail to run the trunk version of logic on trunk which is 1.10
18:35:00 <dkayiwa_> djazayeri: as for the custom build for 1.6.3+, what would i need to change from the trunk version of logic?
18:35:08 *** suranga has quit IRC
18:35:26 <djazayeri> just change the required openmrs version in config.xml to 1.6.3.17711-*
18:35:34 <djazayeri> no other changes
18:36:08 <dkayiwa_> djazayeri: if it is only that, why don't we have the same for 1.6.3 - 1.9 ?
18:36:26 <dkayiwa_> djazayeri: such that we do not have a custom version
18:36:29 <djazayeri> dkayiwa_: because it is *not* allowed for 1.7-1.7.1.*
18:37:22 <dkayiwa_> djazayeri: does that mean core hardcoded the logic version that is required?
18:38:10 <djazayeri> dkayiwa_: core defines a minimum logic version
18:38:34 <dkayiwa_> djazayeri: ok
18:44:31 *** dkayiwa has joined #openmrs
18:45:31 *** dkayiwa_ has quit IRC
18:48:46 *** dkayiwa_ has joined #openmrs
18:50:33 *** dkayiwa has quit IRC
18:50:34 *** dkayiwa_ is now known as dkayiwa
18:52:21 *** dkayiwa_ has joined #openmrs
18:55:03 *** dkayiwa has quit IRC
18:55:03 *** dkayiwa_ is now known as dkayiwa
19:03:41 *** suranga has joined #openmrs
19:04:52 *** MarkG1 has joined #openmrs
19:06:55 *** MarkG has quit IRC
19:17:24 *** downeym has joined #openmrs
19:17:24 *** OpenMRSBot sets mode: +o downeym
19:17:38 *** ChanServ sets mode: +o downeym
19:23:00 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: What's bugging you with #OpenMRS? Help fix/report problems in our bug-fixing development sprint! http://t.co/JJKwvluU #eHealth #HealthIT <http://twitter.com/OpenMRS/statuses/167321919916490753> || OpenMRS Modules: Patient Flags 1.3.3-r25745 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=patientflags&ampversion=&amp1.3.3-r25745>
19:30:15 *** rafa has quit IRC
19:56:31 *** suranga has quit IRC
19:56:34 *** rafa has joined #openmrs
19:56:34 *** ChanServ sets mode: +v rafa
19:56:57 <dkayiwa> rafa: no design forum today?
19:57:31 <rafa> dkayiwa: I don't know
19:57:42 <dkayiwa> :)
19:58:46 * downeym shrugs
20:02:09 *** MarkG has joined #openmrs
20:03:13 <wyclif> hi djazayeri
20:03:19 <djazayeri> hi wyclif
20:03:32 <wyclif> have you released a module before with mvn release plugin?
20:03:56 <djazayeri> wyclif: if I have, I just typed "mvn release" and it worked...
20:04:22 <wyclif> i did it for trunk but not a module
20:04:37 <wyclif> i will try it thanks
20:05:40 *** MarkG1 has quit IRC
20:23:30 *** nadee has joined #openmrs
20:23:36 <downeym> Hi nadee and welcome to the #openmrs IRC channel.
20:34:13 *** bryq has joined #openmrs
20:34:13 *** ChanServ sets mode: +v bryq
20:34:26 <dkayiwa> hi djazayeri
20:34:47 <dkayiwa> djazayeri: do you think we should fix LOGIC-98 before releasing logic?
20:38:13 *** daver12 has joined #openmrs
20:38:24 <downeym> Hi daver12 and welcome to the #openmrs IRC channel.
20:38:34 <daver12> Hi
20:39:13 <daver12> I have a question. Do you need both the api jar and web jar to use openmrs within another application?
20:45:35 *** dkayiwa_ has joined #openmrs
20:45:47 <dkayiwa_> daver12: not necesarilly
20:46:22 *** dkayiwa has quit IRC
20:46:22 *** dkayiwa_ is now known as dkayiwa
20:47:40 <daver12> if I just include the api jar, I get a ClassNotFound exception for a class in the web jar
20:47:57 <dkayiwa> daver12: which class?
20:49:10 <daver12> 1 sec, let me look
20:51:04 <daver12> NoClassDefFoundError: org/openmrs/module/web/extension/AdministrationSectionExt
20:51:46 <dkayiwa> daver12: which exact api class and method are you using?
20:52:04 <daver12> above that, it says: "org.openmrs.module.Module Unable to find class definition for extension: org.openmrs.admin.list
20:52:38 <daver12> I'm included the openmrs-api 1.8.2 jar in my maven project, then I'm calling Context.startup()
20:53:34 <dkayiwa> daver12: can you pastebin.com the stack trace?
20:56:16 <djazayeri> dkayiwa: yeah, we need to deal with LOGIC-98...
20:56:39 <djazayeri> assuming that 1.9.x includes the new asm jar that's incompatible with what logic is expecting
20:57:10 <daver12> http://pastebin.com/2SriFhgY
20:57:17 <dkayiwa> djazayeri: it seems to fail with even the other versions, thought with a slightly different error message
20:57:33 <djazayeri> dkayiwa: what's that different error message?
20:57:44 <dkayiwa> djazayeri: let me fire it up
21:04:52 *** wyclif has quit IRC
21:08:33 <daver12> oh, relating to the logic. I also had to copy the logic-0.5.omod from the openmrs folder in tomcat (webapps/openmrs/WEB-INF/bundledModules) to the OpenMRS/module folder in my application home directory. is that typical?
21:11:13 *** chopin has joined #openmrs
21:11:31 <chopin> dkayiwa, have you ever reverse-engineered an encounter back into an xform file?
21:12:06 *** nadee has quit IRC
21:17:39 <dkayiwa> chopin: i have never, but i can resubmit the same xform from the archive
21:17:59 <dkayiwa> chopin: or even edit the xform to result into the encounter that i want
21:18:24 <dkayiwa> daver12: yes
21:18:46 <chopin> dkayiwa, ah but my encounters have been modified in the database. looking for a way to export them to be reimported.
21:18:54 <chopin> into another db.
21:19:41 <dkayiwa> chopin: without editing the originally submitted xform?
21:20:56 <chopin> dkayiwa, by generating a new xform from the encounter data :-D
21:21:04 <chopin> s/xform/xform submission
21:21:22 <daver12> dkayiwa: if they are moved to the OpenMRS in app home, the webapp will also see them there right?
21:22:28 <dkayiwa> chopin: using a global property, you tell the module where to look for the xforms queue on the file system
21:23:08 <chopin> dkayiwa, you mean daver12?
21:23:32 <dkayiwa> chopin: hahahahha!!!! Yes :D
21:24:35 <daver12> dkayiwa: oh, i meant if i move modules from webapp/openmrs/web-inf/bundledmodules to openmrs/modules in the home directory
21:25:47 <dkayiwa> daver12: you are not supposed to do so. :)
21:30:13 <daver12> dkayiwa: if i don't have the logic-0.5.omod in my app home openmrs folder, I get an exception including the openmrs-api jar though?
21:31:03 <dkayiwa> daver12: oh i see!!!
21:40:22 <chopin> dkayiwa, well, i might be writing an xform export module in the very near future ;-) cya!
21:40:56 <dkayiwa> chopin: sure :D
21:44:20 <daver12> dkayiwa: have you had time to review the pastebin link I put in the chat?
21:44:29 <dkayiwa> djazayeri: i put the error message in the ticket description
21:44:38 *** chopin has quit IRC
21:44:51 <dkayiwa> daver12: the url does not work
21:45:31 <daver12> http://pastebin.com/2SriFhgY ?
22:03:01 <dkayiwa> daver12: i keep getting The connection has timed out
22:06:22 *** nribeka has quit IRC
22:07:37 *** dkayiwa has quit IRC
22:17:15 *** downeym has quit IRC
22:28:16 *** morristic has joined #openmrs
22:31:39 *** bryq has quit IRC
22:35:39 *** djazayeri1 has joined #openmrs
22:35:44 *** djazayeri has quit IRC
22:59:02 *** MarkG has quit IRC
23:01:10 *** morristic has quit IRC
23:16:10 *** rafa has quit IRC
23:38:35 *** deadpool_ has quit IRC