IRC Chat : 2012-02-06 - OpenMRS

01:25:33 *** morristic has joined #openmrs
01:29:44 *** morristic has quit IRC
01:36:28 *** morristic has joined #openmrs
02:37:41 *** morristic has quit IRC
03:04:31 *** upul` has joined #openmrs
03:04:31 *** ChanServ sets mode: +v upul`
03:21:53 *** morristic has joined #openmrs
04:03:48 *** djazayeri has joined #openmrs
04:03:48 *** ChanServ sets mode: +o djazayeri
04:06:27 *** djazayeri has quit IRC
04:06:38 *** djazayeri has joined #openmrs
04:06:38 *** ChanServ sets mode: +o djazayeri
04:14:30 *** djazayeri has quit IRC
06:22:28 *** Echidna has quit IRC
06:22:37 *** Echidna has joined #openmrs
06:22:37 *** ChanServ sets mode: +v Echidna
06:23:22 *** dkayiwa has joined #openmrs
07:47:17 *** dkayiwa has quit IRC
08:02:33 *** harshadura has joined #openmrs
08:04:52 <harshadura> hi
08:05:00 <harshadura> anyone there!
08:08:08 *** harshadura_ has joined #openmrs
08:09:00 *** harshadura_ has quit IRC
08:13:34 *** bryq has joined #openmrs
08:13:34 *** ChanServ sets mode: +v bryq
08:18:05 *** harshadura has quit IRC
08:30:20 *** morristic has quit IRC
08:33:13 *** Lycan has joined #openmrs
08:37:16 *** harshadura has joined #openmrs
08:38:00 *** Lycan has quit IRC
08:44:16 <harshadura> ls
08:47:17 *** rafa has joined #openmrs
08:47:17 *** ChanServ sets mode: +v rafa
08:56:09 *** harshadura has quit IRC
08:58:16 *** harshadura has joined #openmrs
08:58:49 *** harshadura has quit IRC
09:05:37 *** dkayiwa has joined #openmrs
09:43:19 *** r0bby has joined #openmrs
09:43:19 *** ChanServ sets mode: +v r0bby
09:43:43 *** robbyoconnor has quit IRC
09:44:14 *** dkayiwa has quit IRC
09:46:54 *** dkayiwa has joined #openmrs
11:25:26 *** upul` has quit IRC
11:30:24 *** morristic has joined #openmrs
11:58:04 *** goutham has joined #openmrs
12:01:01 *** morristic has quit IRC
12:04:36 *** dkayiwa has quit IRC
12:06:07 *** james_regen has joined #openmrs
12:06:07 *** ChanServ sets mode: +v james_regen
13:17:08 *** goutham has quit IRC
13:26:32 *** bryq has left #openmrs
13:50:49 *** wyclif has quit IRC
14:08:09 *** pushkar has joined #openmrs
14:34:40 *** mvorobey has joined #openmrs
14:34:40 <mvorobey> hi all
14:40:29 *** wyclif has joined #openmrs
14:41:00 *** MarkG has joined #openmrs
14:50:37 *** rafa has quit IRC
15:20:12 *** rafa has joined #openmrs
15:20:12 *** ChanServ sets mode: +v rafa
15:21:59 <wyclif> hi MarkG how doe register errors to get displayed in an html form?
15:23:26 <MarkG> wyclif: don't know off the top of my head... you mean how our validation errors passed back to the data entry user?
15:23:54 <wyclif> MarkG, yes
15:24:47 <MarkG> wyclif: let me take a look...
15:27:19 *** judy_ has joined #openmrs
15:27:31 *** pushkar has quit IRC
15:28:27 <judy_> hey @MarkG
15:28:39 <MarkG> judy_: hey Judy
15:29:42 <judy_> i have a question about HTML-28
15:29:58 <judy_> ticket on Funky behavior with <obs showDate="true"> and missing values
15:30:32 <MarkG> judy_: sure, go ahead
15:31:15 <judy_> the description was about a repeating segment for the tag
15:32:20 <judy_> is it okey to write the unit tests just to check that on save , the dat eis present(as part of validation)
15:32:47 <judy_> and then that a test that is displayed...or do i approach it during teh repeat activitiy?
15:33:44 <MarkG> judy_: i've got to refresh myself on the ticket... I will take a look... wyclif is waiting on an answer from me as well that i need to answer first... so it may take me a few minutes to get back to you... :)
15:34:27 <judy_> sure
15:40:12 <wyclif> MarkG, seems i have figured out how to handle a form submission error, how about an error when designing a form?
15:40:35 *** bryq has joined #openmrs
15:40:35 *** ChanServ sets mode: +v bryq
15:42:56 <MarkG> wyclif: cool
15:43:02 *** suranga has joined #openmrs
15:43:07 <MarkG> wyclif: there is a form validator when designing a form...
15:43:23 <MarkG> HtmlFormValidator
15:44:02 <MarkG> it basically tries to render the form with a fake patient and see if there are any errors
15:44:21 <MarkG> if there are any exceptions during rendering, it displays those as an error...
15:44:36 <MarkG> so i think we handle bad form design generally using exceptions...
15:45:33 <MarkG> wyclif: try entering a bad conceptId on a form you create, and you'll see how it handles the error
15:47:28 <MarkG> wyclif: HtmlFormEntryUtikl.getConcept(id, errorMessageIfNotFound) throws an exception if the concept is not found, which is then caught and displayed as an error message by the HtmlFormValidtor
15:48:11 <wyclif> MarkG, ok will try that, thanks
15:50:44 *** dawn_ has joined #openmrs
15:51:19 *** ChanServ sets mode: +v dawn_
15:52:53 *** mvorobey has quit IRC
15:55:54 *** djazayeri has joined #openmrs
15:55:54 *** ChanServ sets mode: +o djazayeri
15:57:01 <MarkG> judy_: i just updated the ticket with a bunch of unit tests that i think should be written
15:57:41 <MarkG> judy_: you should write the unit test you mentioned, with a single obs, but then also write one that tests the repeating functionality
15:58:29 <MarkG> judy_: (you should double check to make sure that these tests don't exist--they'd probably be in the RegressionTest class--but I wouldn't be surprised if they didn't)
16:00:30 <dawn_> !scrumon dawn
16:00:30 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
16:00:51 <dawn_> djazayeri: rafa judy_ MarkG wyclif : HI!
16:00:57 <rafa> hi!
16:01:07 <djazayeri> hi
16:01:14 <dawn_> Today's order: rafa , djazayeri , wyclif , MarkG , judy_
16:01:25 <MarkG> judy_: the #2 & #3 tests I wrote will probably fail, so you will need to add a validation check to make sure you can't submit an obs with showDate="true" without entering both a value and date; i want to check with djazayeri after the scrum to make sure he agrees with the funcitonality
16:01:34 <rafa> MarkG: hold on :D
16:01:37 <rafa> Today:
16:01:37 <rafa> * Started with HTML-64: Additions to htmlforms for workflow and states
16:01:37 <rafa> https://tickets.openmrs.org/browse/HTML-64
16:01:37 <rafa> Tomorrow:
16:01:37 <rafa> * Continue with HTML-64
16:01:38 <rafa> No blockers.
16:02:04 <djazayeri> wyclif: can you go before me, I need a second to organize
16:02:56 <wyclif> sure
16:03:08 <wyclif> Friday:
16:03:08 <wyclif> * HTML-246 - Update Enrollment in Program to allow a date input, and to set current states
16:03:08 <wyclif> * Made changes in SMART module so that it can be run in OpenMRS 1.7
16:03:08 <wyclif> * Code review for trunk tickets
16:03:08 <wyclif> Monday:
16:03:09 <wyclif> * HTML-346
16:03:11 <wyclif> * Release SMART module(Had blockers on friday)
16:03:13 <wyclif> * Pick another sprint ticket
16:03:15 <wyclif> No Blocker
16:03:45 <wyclif> * did a partial commit for HTML-246
16:04:39 <djazayeri> I'll go
16:04:42 <djazayeri> Friday 3-Feb-2012
16:04:42 <djazayeri> * Call with Captricity and Andy Kanter about integration with OpenMRS
16:04:42 <djazayeri> * Started HTML-268 (1.9 Providers in HFE)
16:04:42 <djazayeri> * Plan for upcoming Pentaho sprint
16:04:42 <djazayeri> Monday 6-Feb-2012
16:04:43 <djazayeri> * Finish HTML-268 (1.9 Providers in HFE)
16:04:43 <djazayeri> * Check whether I've also broken the id + javascript set value with my datepicker changes
16:04:44 <djazayeri> * Call with Gretchen, and plan for upcoming Pentaho sprint
16:04:46 <djazayeri> no blockers
16:05:26 <djazayeri> MarkG: your turn
16:05:31 <MarkG> not much for me... mainly just reviewing HFE sprint tickets and answering questions
16:05:36 <MarkG> no blocker
16:06:06 <dawn_> judy_: are there any updates you want to add here?
16:07:27 <dawn_> not sure if she's near her computer
16:07:30 <dawn_> i don't see any discussion points
16:07:36 <dawn_> !scrumoff dawn
16:07:36 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
16:07:49 <MarkG> djazayeri: do you agree with my spec that if you have an obs with showDate="true" form validation should fail if you try to enter an obs value without an obs date, or vice versa?
16:07:50 <djazayeri> MarkG: any overall sprint comments or directions you want to give us?
16:08:04 <MarkG> i feel like things are going well...
16:08:19 <djazayeri> MarkG: I intentionally didn't do it that way, back in the beginning
16:08:20 <MarkG> looks like we are on track to finish all or most of the tickets, so i am happy...
16:08:37 <djazayeri> I suppose for consistency with infopath
16:08:40 <MarkG> djazayeri: so your answer is no, then... :)
16:09:01 <djazayeri> MarkG: well, it's hard to say.
16:09:20 <MarkG> djazayeri: obviously, the other option would be to default to encounter date?
16:09:36 <MarkG> djazayeri: i assume an obs with a obs date but no obs value should be disallowed?
16:10:02 <djazayeri> MarkG: I can see your point, were allowing the entry of obsDatetime really means that it _must_ be entered, and (typically) different from the encounter date.
16:10:19 *** suranga_ has joined #openmrs
16:10:21 <djazayeri> MarkG: definitely date-without-value is bad
16:11:18 <MarkG> djazayeri: just discussing it with Mike... you guys have convinced me...
16:11:48 <MarkG> djazayeri: this is in reference to
16:11:53 <MarkG> !ticket HTML-28
16:11:55 <OpenMRSBot> MarkG: [#HTML-28] Funky behavior with and missing values - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-28
16:13:12 <MarkG> djazayeri: i guess that if you enter a obs value without an obs date, and then edit/view that form, the obs date will be displayed? (or is there a way around this i'm not thinking of?)
16:13:15 *** suranga has quit IRC
16:13:47 <MarkG> judy_: i'm going to edit the comments i just made in re: to my discuss with darius
16:13:59 <djazayeri> MarkG: my original thinking was that we should display any obsDatetime that differs from the encounter's encounterDatetime
16:14:42 *** suranga has joined #openmrs
16:15:19 <MarkG> djazayeri: so, if for some reason the user manually enters an obs date that is the same as the encounter datetime, that date would not be redisplayed?
16:15:34 <djazayeri> MarkG: yeah. (I don't see a way around that)
16:15:50 *** suranga_ has quit IRC
16:29:33 *** rafa has quit IRC
16:41:28 *** dawn_ has quit IRC
16:51:55 <judy_> hey @MarcG ..i stepped away from my PC...let me check the comments that you made on the ticket
16:52:06 <MarkG> judy_: sounds good...
17:02:59 *** pushkar has joined #openmrs
17:12:29 *** judy_ has quit IRC
17:15:04 <wyclif> MarkG, how do you run the test against an openmrs version?
17:17:41 <MarkG> wyclif: see "unit testing" here:
17:17:44 <MarkG> wyclif: https://wiki.openmrs.org/display/RES/2012-1-30+HTML+Form+Entry+Sprint
17:19:36 *** pushkar has quit IRC
17:22:26 <wyclif> MarkG, i meant for a single test
17:22:51 *** deadpool has joined #openmrs
17:23:27 <MarkG> wyclif: you can specify this parameter on the command line -Dtest=TestClassName#TestMethodName
17:23:49 <MarkG> wyclif: I usually just specify it at the class level, since our test names are so long: -Dtest=TestClassName
17:24:26 <wyclif> MarkG, ok thanks
17:26:25 <MarkG> wyclif: re: preferred name... what are the current restrictions on names within OpenMRS? i.e., whatever we allow users to specify for the tag shold be unique...
17:26:55 <MarkG> wyclif: can two concepts have a same full_specified name if they are for different locales?
17:29:21 <MarkG> wyclif: another option (to give people options besides specifying by id and uuid) would be to allow users to specify a concept by tag
17:30:35 <wyclif> MarkG, we try to avoid programming against tags
17:31:01 <wyclif> MarkG, since they are actually ment to be dropped
17:31:20 <MarkG> wyclif: sorry, my mistake...
17:31:32 <MarkG> wyclif: i meant a concept mapping, not a concept name tag...
17:31:46 <wyclif> MarkG, that is possible
17:32:54 <wyclif> MarkG, but since we are supporting 1.6 we have to stick to preferred name since get getFullySpecifiedName isnt present in 1.6
17:33:25 <MarkG> wyclif: yeah, that's why it gets complicated!
17:35:14 <MarkG> wyclif: i say we don't allowed referencing by name, but allow referencing by mapping in the format "concept_source:concept_map"... what do you think about that? this is basically how we let users specify concepts (see getConcept(String id)) in the HtmlFormEntryUtil
17:35:53 <wyclif> MarkG, + for dropping get by name
17:36:07 <wyclif> MarkG, will fix that
17:37:02 <MarkG> wyclif: cool, great... sorry for changing the specs on you...
17:37:15 <wyclif> MarkG, no problem
17:39:29 *** suranga_ has joined #openmrs
17:39:48 *** suranga has quit IRC
17:44:21 *** suranga_ has quit IRC
18:07:36 <wyclif> MarkG, is it fine to change the signatures for methods in FormSubmissionAction e.g enrollInProgram?
18:09:00 <djazayeri> wyclif: what do you want to change there?
18:09:32 <wyclif> djazayeri, i want to add enrollment date to the arguments
18:09:44 <djazayeri> sounds necessary
18:11:31 <wyclif> djazayeri, so these methods are not part of the public API for the module, right?
18:12:01 *** mvorobey has joined #openmrs
18:12:25 <djazayeri> wyclif: well, they are, but AFAIK the only modules depending on this are htmlformflowsheet, and register, and they can be changed.
18:12:37 <djazayeri> it's not like core, where we *must* maintain those.
18:12:47 <wyclif> djazayeri, ok, thanks
18:12:53 <djazayeri> Though I guess you can just add a second enrollInProgram method and deprecate the first
18:13:03 <djazayeri> and have the existing one call enrollInProgram(program, new Date())
18:13:15 <djazayeri> or rather use the encounter date
18:18:57 <MarkG> wyclif: djazayeri: sorry, out to lunch. but i wouild agree with Darius... deprecate the old one put you can keep it around...
18:23:17 *** dkayiwa has joined #openmrs
18:33:03 *** wluyima has joined #openmrs
18:33:04 *** wyclif has quit IRC
18:33:10 *** wluyima has quit IRC
18:33:23 *** wyclif has joined #openmrs
18:40:12 *** wluyima has joined #openmrs
18:40:12 *** wyclif has quit IRC
18:54:15 *** wyclif has joined #openmrs
18:54:34 *** wluyima has joined #openmrs
18:58:06 <djazayeri> MarkG: I see that dkayiwa is working on one of the TEST/DOCUMENT tickets. Are those fair game, or did you intend to save them for Cordt?
18:58:25 <dkayiwa> :)
18:58:36 <MarkG> djazayeri dkayiwa: fair game
18:58:54 <djazayeri> cool
18:58:57 <MarkG> but it probably makes sense to do the non-TEST tickets first
18:59:27 <dkayiwa> MarkG: do you recommend i do another ticket?
18:59:49 <MarkG> dkayiwa: hold on, let me take a look...
19:00:05 <dkayiwa> MarkG: ok
19:01:23 <djazayeri> dkayiwa: let's talk now re 1.9
19:01:27 <djazayeri> skype maybe?
19:01:30 <dkayiwa> ok
19:01:33 <djazayeri> or google talk, whichever is easier
19:01:39 <MarkG> dkayiwa: yeah, to clarify, the tickets marked "TEST" have actually already been done, they are just tickets to test that feature...
19:01:53 <dkayiwa> MarkG: ok thanks
19:02:05 <MarkG> dkayiwa: HTML-292 links to HTML-112... thought I assigned them all to Cordt, but maybe i didn't...
19:02:31 <dkayiwa> MarkG: ok
19:02:50 <MarkG> i'd take on the last remaining unassigned non-testing ticket:
19:02:56 <MarkG> !ticket HTML-216
19:02:57 <OpenMRSBot> MarkG: [#HTML-216] View/edit within an obsgroup messes up with the order of the list - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-216
19:03:15 <dkayiwa> MarkG: you recommend i do HTML-216?
19:03:21 <dkayiwa> instead
19:03:28 <MarkG> dkayiwa: yes
19:03:34 <dkayiwa> MarkG: ok
19:03:47 <MarkG> can anyone explain to me what a "deadpool" is in IRC?
19:04:18 <dkayiwa> :D
19:04:48 *** rafa has joined #openmrs
19:04:48 *** ChanServ sets mode: +v rafa
19:04:54 <deadpool> MarkG: there are many definitions of deadpool in irc
19:05:25 <deadpool> but i would go with the simplest one because that is usually the right one
19:06:05 <MarkG> deadpool: oh, right, it is a person...
19:06:30 <MarkG> i get it... it was my chat client simulating autocomplete for me
19:07:12 <MarkG> i would type "d" followed by a tab and I'd get something like "deadpool djazayeri" pop up on the chat line...
19:07:28 <MarkG> i thought it was some kind of way to add darius to the irc deadpool...
19:07:32 <deadpool> ah nope
19:07:37 <MarkG> :)
19:09:36 *** james_regen has left #openmrs
19:29:54 *** max has joined #openmrs
19:30:20 *** max is now known as Guest61709
19:35:00 <dkayiwa> hi wyclif
19:54:36 *** Guest61709 has quit IRC
20:01:24 <MarkG> dkayiwa: looks like stephen lorenz beat you to HTML-216
20:01:38 <MarkG> dkayiwa: i am going to pull in some of the other bug fix tickets from release 1.9.1
20:02:45 <dkayiwa> MarkG: hahahahha :D
20:07:47 <MarkG> dkayiwa: judy had two tickets assigned to her, so i asked her to drop the one she wasn't working on, so HTML-217 is now available...
20:08:25 <dkayiwa> MarkG: ok thanks :)
20:22:13 *** mvorobey has quit IRC
21:48:35 *** dkayiwa has quit IRC
22:19:11 <wluyima> djazayeri, when enrolling a patient in a program, what encounters is used, or one is created?
22:19:35 <djazayeri> wluyima: enrolling a patient in a program doesn't require an encounter
22:19:47 <djazayeri> so AFAIK none is created
22:20:33 <wluyima> djazayeri, the logic in formentry uses encounterdatetime for enrollment date by default
22:21:00 <djazayeri> wluyima: so, when I originally wrote the code, the assumption was that every HTML Form created an encounter
22:21:13 <djazayeri> that's not strictly true anymore
22:21:20 <wluyima> djazayeri, so should i change it?
22:21:33 <djazayeri> but in any case you should be able to get the current encounter's datetime
22:22:11 <wluyima> djazayeri, does every html form have a backing encounter?
22:22:31 <djazayeri> wluyima: not exactly—you can have an html form that just creates a patient, and doesn't create an encounter
22:22:49 <djazayeri> I imagine such a form could also enroll the patient in a program
22:23:06 <djazayeri> look at FormEntrySession for this: // propagate encounterDatetime to PatientPrograms where necessary
22:23:15 <wluyima> so htmlFormSession.getEncounter() can return null, right?
22:23:33 <djazayeri> yes it can
22:23:38 <wluyima> ok, thanks
22:23:43 <djazayeri> But in most cases it won't return null
22:23:48 <djazayeri> so you should try to use that return value first.
22:23:59 <wluyima> djazayeri, ok thanks
22:24:40 <wluyima> heading home, talk to you later guys
22:24:52 <djazayeri> ciao wluyima
22:25:20 <djazayeri> rafa: I'm running into a problem with the module I just created with the new version of the archetype
22:25:32 <djazayeri> it's the htmlformentry19ext module, and it required the htmlformentry module
22:26:03 <djazayeri> The problem is that when I load the hfe19ext module, the regular HFE module stops working with Service not found: interface org.openmrs.module.htmlformentry.HtmlFormEntryService
22:26:50 <djazayeri> rafa: I believe this is because the build omod file includes htmlformentry-api.jar in its lib folder
22:27:15 <djazayeri> Presumably you're not really online now, so I'll email.
22:29:10 *** wluyima has quit IRC
22:29:17 <MarkG> djazayeri: thanks... was chatting with ellen in haiti so i couldn't jump in...
22:29:44 *** wyclif has quit IRC
22:33:24 <MarkG> djazayeri: so if there is no <encounter*> tags on the form, htmlFormEntrySesion.getEncounter will be null?
22:39:43 <rafa> djazayeri: hi
22:40:00 <djazayeri> rafa: hi, on a call now
22:41:42 <rafa> djazayeri: okay, it should be enough to add <scope>provided<scope> in the main pom for htmlformentry-api
22:42:05 <djazayeri> rafa: okay, is this something you can fix in the archetype (not now)
22:42:20 <rafa> djazayeri: yes
22:42:48 <rafa> djazayeri: deploying takes some time so I'll do it tomorrow
22:43:05 <rafa> djazayeri: just let me know if it helps
22:43:26 <djazayeri> rafa: I'll reply to my email saying whether scope=provided works
22:43:39 <rafa> ok, thanks
22:45:53 *** rafa has quit IRC
23:04:02 *** MarkG has quit IRC
23:16:54 *** bryq has quit IRC
23:24:19 *** deadpool has quit IRC
23:25:49 *** djazayeri1 has joined #openmrs
23:28:32 *** djazayeri has quit IRC
23:40:15 *** djazayeri1 is now known as djazayeri
23:40:15 *** ChanServ sets mode: +o djazayeri