| 00:50:29 | *** sunbiz has quit IRC |
| 00:58:55 | *** wyclif has joined #openmrs |
| 03:08:45 | *** morristic has quit IRC |
| 03:09:16 | *** morristic has joined #openmrs |
| 03:45:34 | *** morristic has quit IRC |
| 04:49:35 | *** morristic has joined #openmrs |
| 05:03:30 | *** suranga has joined #openmrs |
| 05:05:47 | *** matt_uofa has joined #openmrs |
| 05:09:44 | <matt_uofa> Hello, hoping someone here can help me. I'm trying to setup an install of OpenMRS 1.6.5 with the MDR-TB 2.1.8. I've got everything installed and running, but when I load a patient and click the "see MDR-TB overview for this patient" I get the following error. "org.openmrs.module.mdrtb.regimen.RegimenType cannot be cast to org.openmrs.module.mdrtb.regimen.RegimenType", anyone have any ideas? :-) |
| 05:50:30 | *** bryq has joined #openmrs |
| 05:50:30 | *** ChanServ sets mode: +v bryq |
| 05:55:40 | *** bryq has quit IRC |
| 06:12:20 | *** morristic has quit IRC |
| 06:12:47 | *** morristic has joined #openmrs |
| 06:35:38 | *** robbyoconnor has quit IRC |
| 06:54:45 | *** robbyoconnor has joined #openmrs |
| 06:54:45 | *** ChanServ sets mode: +v robbyoconnor |
| 06:59:03 | *** morristic has quit IRC |
| 07:04:19 | *** morristic has joined #openmrs |
| 07:07:56 | *** kishoreyekkanti has joined #openmrs |
| 07:08:36 | *** morristic has quit IRC |
| 07:25:26 | *** matt_uofa has quit IRC |
| 07:44:27 | *** dkayiwa has joined #openmrs |
| 08:43:51 | *** dkayiwa_ has joined #openmrs |
| 08:44:36 | *** dkayiwa has quit IRC |
| 08:44:36 | *** dkayiwa_ is now known as dkayiwa |
| 08:52:57 | *** bryq has joined #openmrs |
| 08:52:57 | *** ChanServ sets mode: +v bryq |
| 09:06:05 | *** sunbiz has joined #openmrs |
| 09:06:05 | *** ChanServ sets mode: +v sunbiz |
| 09:44:49 | *** kishoreyekkanti_ has joined #openmrs |
| 09:48:06 | *** suranga has quit IRC |
| 09:48:09 | *** kishoreyekkanti has quit IRC |
| 09:48:09 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 10:04:30 | *** bryq has quit IRC |
| 10:20:34 | *** dkayiwa_ has joined #openmrs |
| 10:23:56 | *** dkayiwa has quit IRC |
| 10:23:56 | *** dkayiwa_ is now known as dkayiwa |
| 10:48:18 | *** kishoreyekkanti has quit IRC |
| 10:48:36 | *** kishoreyekkanti has joined #openmrs |
| 11:00:20 | *** morristic has joined #openmrs |
| 11:28:27 | *** rafa has joined #openmrs |
| 11:28:27 | *** ChanServ sets mode: +v rafa |
| 11:38:41 | *** sunbiz has left #openmrs |
| 11:38:45 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Data Entry Statistics 1.3.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=dataentrystatistics&version=&1.3.2> |
| 11:46:19 | *** morristic has quit IRC |
| 12:07:43 | *** robbyoconnor has quit IRC |
| 12:32:40 | *** james_regen has joined #openmrs |
| 12:32:40 | *** ChanServ sets mode: +v james_regen |
| 13:04:25 | *** kishoreyekkanti has quit IRC |
| 13:10:54 | *** rafa has quit IRC |
| 13:12:01 | *** rafa has joined #openmrs |
| 13:12:01 | *** ChanServ sets mode: +v rafa |
| 13:13:05 | *** rafa has quit IRC |
| 13:20:22 | *** dkayiwa_ has joined #openmrs |
| 13:23:06 | *** dkayiwa has quit IRC |
| 13:24:44 | *** dkayiwa_ has quit IRC |
| 13:28:05 | *** liz_ has joined #openmrs |
| 13:29:33 | <liz_> hi |
| 13:30:19 | <liz_> anyone in here |
| 13:32:58 | <james_regen> hi liz_ at least one person is here |
| 13:38:52 | <liz_> hi james |
| 13:39:12 | <liz_> have some problems while installing openmrs |
| 13:39:29 | <liz_> http://pastebin.com/reZzmesj |
| 13:41:21 | *** dkayiwa has joined #openmrs |
| 13:42:40 | <james_regen> i'm not sure i can help. once other people show up others might have ideas |
| 13:44:50 | <liz_> okay, will wait |
| 13:45:24 | <dkayiwa> liz_: what were you asking? |
| 13:49:15 | *** sgrannis has joined #openmrs |
| 13:49:15 | *** ChanServ sets mode: +v sgrannis |
| 13:49:56 | <liz_> am doing installation of openmrs |
| 13:50:04 | <liz_> and ending with this |
| 13:50:06 | <liz_> http://pastebin.com/reZzmesj |
| 13:50:18 | <dkayiwa> liz_: how are you installing it? |
| 13:50:45 | <sgrannis> james: how's the data extract for Joanne coming? |
| 13:50:47 | <liz_> i checked out openmrs to eclipse |
| 13:51:29 | <liz_> now i need to install openmrs, |
| 13:51:40 | <james_regen> sgrannis: it should be down today. i need to go through 4 files to get everything together, but i think i'll get it right |
| 13:51:53 | <dkayiwa> liz_: what url do you use in the browser? |
| 13:52:10 | <liz_> http://localhost:8080/openmrs |
| 13:52:58 | <dkayiwa> liz_: and what do you see in the browser? |
| 13:53:32 | <liz_> am getting the wizard as usul |
| 13:53:39 | <james_regen> sgrannis: well, i might need to do some more work. i have scores for the pairs, but not the vectors, so i'll have to look those up. and i have to double check if i have the full output file instead of jus the 5 percent sample |
| 13:53:39 | <sgrannis> Thanks for working on the extract. I should have my SSN pairs finished shortly as well |
| 13:53:52 | <dkayiwa> liz_: can you proceed with the wizard steps? |
| 13:53:55 | <liz_> meant usual |
| 13:54:18 | <liz_> go to the end and then having those errors |
| 13:54:21 | <liz_> http://pastebin.com/reZzmesj |
| 13:54:34 | <dkayiwa> liz_: do you have mysql installed and running? |
| 13:54:44 | <liz_> yes |
| 13:55:02 | <liz_> the browser ends with: http://localhost:8080/openmrs/index.htm |
| 13:55:14 | <liz_> and then errors |
| 13:55:18 | <dkayiwa> liz_: at what wizard step do you get the error? |
| 13:55:39 | <james_regen> sgrannis: since i have the raw data files, though, whatever jessica has andy don't have i should be able to recreate to get exact pair counts for the block and figure out overall vector counts |
| 13:56:22 | <liz_> it goes up to the poing where it loads data to the database, and then says something like finalising installation |
| 13:56:30 | <liz_> meant point |
| 13:56:57 | <dkayiwa> liz_: what error message does it display in the browser? |
| 13:57:25 | <liz_> in the browser, nothing is displayed after that |
| 13:58:06 | <sgrannis> James: didn't follow your last |
| 13:58:17 | <dkayiwa> liz_: when a step before the page where stuff fails, can you clear the console output before you now execute the failing step such that i can see a clean log output? |
| 13:59:53 | <james_regen> sgrannis: the file we manually reviewed was a 5 percent sample of the LNFN block. jessica made the full output file and did the sampling for review. i'm not sure if we ever got the full output file she sampled from, which i think is needed for the <# not classified> field in the file |
| 14:02:07 | <james_regen> sgrannis: we did clean the files she used, though, and we still have the full raw data file she deduped. if i need to do something with the 200k pairs that were sampled to get the 10k we reviewed, i should be able to recreate the file jessiea sampled from |
| 14:02:14 | *** sgrannis has quit IRC |
| 14:05:30 | *** sgrannis has joined #openmrs |
| 14:05:30 | *** ChanServ sets mode: +v sgrannis |
| 14:20:35 | *** rafa has joined #openmrs |
| 14:20:35 | *** ChanServ sets mode: +v rafa |
| 14:24:11 | *** MarkG has joined #openmrs |
| 14:25:20 | <MarkG> wyclif: did you ever get git to work for you yesterday? |
| 14:26:58 | <dkayiwa> MarkG: as wyclif responds, as for HTML-218, do we have use cases where one would on the same form, selectively turn on or off showing date format for certain date widgets? Am comparing this with simply using a global property. |
| 14:27:43 | <dkayiwa> MarkG: global property vs widget attribute. or simply do both :) |
| 14:28:10 | <dkayiwa> MarkG: where widget attribute overrides global property value :) |
| 14:28:12 | <MarkG> dkayiwa: i will look at the ticket and refresh my memory... |
| 14:28:20 | <dkayiwa> :D |
| 14:35:30 | <MarkG> dkayiwa: let's just do a global property, htmlformentry.showDateFormat, even those this isn't what the ticket said, since this is what we ended up doing for |
| 14:35:36 | <MarkG> !ticket HTML-36 |
| 14:35:38 | <OpenMRSBot> MarkG: [#HTML-36] htmlformentry: change date widget formatting - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-36 |
| 14:36:10 | <dkayiwa> MarkG: ok |
| 14:38:04 | <MarkG> dkayiwa: also, bonus points if you can get it work well displaying in the text field itself, instead of off to the side, per Darius's comment, but this is not a requirement so definitely don't waste too much time if it is problematic to get it work with the date widget |
| 14:38:32 | <dkayiwa> MarkG: ok |
| 14:39:54 | *** sgrannis has quit IRC |
| 14:40:11 | <wyclif> hi MarkG yes i did |
| 14:42:29 | *** sgrannis has joined #openmrs |
| 14:42:38 | *** ChanServ sets mode: +v sgrannis |
| 14:42:55 | <MarkG> wyclif: greast |
| 14:49:59 | *** kishoreyekkanti has joined #openmrs |
| 15:21:36 | *** dkayiwa has left #openmrs |
| 15:28:10 | *** MedMan has joined #openmrs |
| 15:29:36 | *** MedMan has quit IRC |
| 15:29:54 | *** sgrannis has left #openmrs |
| 16:09:14 | <MarkG> wyclif rafa: looks like your IDE is formatting the HFE code... probably not a bad thing, but it can make it difficult to read changesets... for the files you work on, do you mind formatting and committing before you make changes and then making your changes in a separate commit? thanks... |
| 16:09:39 | <wyclif> MarkG, sure |
| 16:09:47 | <rafa> MarkG: I try not to do that anymore |
| 16:09:51 | <rafa> MarkG: which commit? |
| 16:12:08 | <rafa> MarkG: ahh yes, I have an auto formatting, sorry :/ |
| 16:12:47 | <MarkG> yeah, we probably should have gone through an auto-formatted HFE at some point, but we haven't... thanks... |
| 16:21:16 | *** liz_ has quit IRC |
| 16:27:17 | <wyclif> hi MarkG |
| 16:29:53 | <MarkG> wyclif: hey Wyclif, what's up? |
| 16:32:15 | <wyclif> MarkG, i see that when adding attribute descriptors only subclasses of OpenmrsObject are allowed, how do i add boolean? |
| 16:32:56 | <wyclif> attributes and how do i define allowed values or it goes in validation logic |
| 16:33:39 | <MarkG> wyclif: all attribute descriptors are used for so far are to allow forms to be shared... so they just need to be added for attributes that reference openmrs objects |
| 16:34:39 | <MarkG> wyclif: attribute values go in validation logic... |
| 16:35:00 | <MarkG> wyclif: fyi, there is a bit about attribute descriptors at the bottom of this apge |
| 16:35:10 | <MarkG> https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module+Technical+Overview |
| 17:34:36 | *** suranga has joined #openmrs |
| 17:34:50 | <suranga> hi james_regen :-) |
| 17:35:09 | <james_regen> hi |
| 17:38:30 | <djazayeri> rafa: what could we do about validating twice? We definitely want to do it in the service as a fail-safe, and we definitely want to populate the errors object for the controller. I don't see a way to make that happen in the service's save. |
| 17:48:45 | <wyclif> hi MarkG |
| 17:49:26 | <MarkG> wyclif: hey wyclif, what's up? |
| 17:49:45 | <wyclif> for HTML-246, doe stateIds have to be one of state_id, uuid, pref name or all |
| 17:50:07 | <wyclif> MarkG, for HTML-246, doe stateIds have to be one of state_id, uuid, pref name or all |
| 17:50:14 | <wyclif> MarkG, for HTML-246, does stateIds have to be one of state_id, uuid, pref name or all |
| 17:51:31 | <wyclif> MarkG, and i though a patient can only be in one state per workflow in a program, does it mean that the multiple states provided will be matched per workflow? |
| 17:51:45 | <rafa> djazayeri: hi! we could try to save first and if it fails validate in the controller :) |
| 17:51:49 | <MarkG> wyclif: you should definately be able to specify a state by uuid or id |
| 17:52:03 | <djazayeri> rafa: interesting idea... |
| 17:52:18 | <MarkG> wyclif: ellen also asked to be able to specify it by the preferred name of the underlying concept (the way you can for workflow) |
| 17:52:27 | <djazayeri> rafa: I was just going to open up the snapshot and see what part of validation is slow, and see if we can speed that bit up |
| 17:52:40 | <rafa> djazayeri: it's getConceptsByName |
| 17:52:52 | <MarkG> wyclif: but i'd be willing to skip that for now since the ProgramWorkflow API is pretty bad... |
| 17:52:54 | <rafa> djazayeri: from ConceptDao |
| 17:53:35 | <MarkG> wyclif: fyi, i believe the HtmlFormEntryService has both a getByUuid and getById method that you can use... |
| 17:53:59 | <djazayeri> rafa: hmmâ¦that's the part that's preventing two concepts from having the same fully_specified or preferred name in a locale? |
| 17:54:15 | <rafa> djazayeri: yes |
| 17:54:32 | <djazayeri> perhaps that query can be optimized |
| 17:55:07 | <MarkG> wyclif: if i understand your other question, if two of the states in the stateIds list are in the same workflow, that should be an error case... |
| 17:55:34 | <MarkG> wyclif: i forget how tags handle error cases (prob throw an exception) but you can probably find an example in another tag |
| 17:56:37 | <djazayeri> rafa: you're leading the sprint today, right? |
| 17:56:38 | <rafa> djazayeri: it looks good to me |
| 17:56:52 | <rafa> djazayeri: yes in 5 minutes :) |
| 17:57:08 | <djazayeri> FYI I've managed to schedule a phone call for the same time so I'll paste my update but not be following closely (if at all) |
| 17:57:35 | <rafa> cool |
| 17:57:37 | <djazayeri> remember to ask MarkG to give a comment on how we're doing on the overall sprint, now that we're halfway done. |
| 17:59:05 | <MarkG> i think things are going well... we are making good progress through tickets... |
| 17:59:25 | <wyclif> MarkG, mark what did you mean to skip for now |
| 18:00:07 | <MarkG> wyclif: i mean it is okay if you can only specify a state by id or uuid, but not by preferred concept name |
| 18:00:27 | *** kishoreyekkanti has quit IRC |
| 18:01:32 | <rafa> !scrumon rafa |
| 18:01:32 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster rafa- you may begin when ready. |
| 18:01:43 | <rafa> hi djazayeri, magicaltrout, wyclif |
| 18:01:49 | <rafa> hi MarkG :) |
| 18:02:05 | <rafa> today's order: djazayeri, MarkG, wyclif, me |
| 18:02:34 | <wyclif> ok |
| 18:03:38 | <rafa> I guess djazayeri is setting up for the call so go ahead MarkG |
| 18:04:16 | <MarkG> * started to play around with htmlform release-tests |
| 18:04:24 | <djazayeri> sorry, here's my |
| 18:04:25 | <djazayeri> update |
| 18:04:28 | <djazayeri> Thursday 2-Feb-2012 |
| 18:04:28 | <djazayeri> * Developers call |
| 18:04:28 | <djazayeri> * Leadership call |
| 18:04:28 | <djazayeri> * Applied TRUNK-3032 |
| 18:04:28 | <djazayeri> * Commented on and/or closed some 1.9 tickets |
| 18:04:28 | <djazayeri> * Re-created the HFE eclipse projects |
| 18:04:28 | <djazayeri> * plan for pentaho sprint |
| 18:04:29 | <djazayeri> * Fixed HTML-287 (a bug I introduced with datepicker changes) |
| 18:04:29 | <djazayeri> * Fixed HTML-288 (another bug I introduced with date picker changes) |
| 18:04:30 | <djazayeri> * Dealt with some code@openmrs.org requests. |
| 18:04:31 | <djazayeri> Friday 3-Feb-2012 |
| 18:04:31 | <djazayeri> * Call with Captricity and Andy Kanter about integration |
| 18:04:32 | <djazayeri> * Check whether I've also broken the id + javascript set value with my datepicker changes |
| 18:04:32 | <djazayeri> * Do some sprint tickets not caused by my own bugs |
| 18:04:33 | <djazayeri> logging off now so I don't get beeps |
| 18:04:40 | *** djazayeri has left #openmrs |
| 18:05:04 | <rafa> ~-+99768128+-~okay continue MarkG :) |
| 18:05:40 | <MarkG> * reviewing HFE tickets in Review State |
| 18:05:46 | <MarkG> * misc Haiti support |
| 18:05:58 | <MarkG> * will continue to review tickets and explore release-tests this afternoon |
| 18:06:09 | <MarkG> i think the sprint is going well, and we've made good progress |
| 18:06:40 | <rafa> 5 tickets left right? or are there any other needing desing? |
| 18:06:45 | <MarkG> one risk is that it is mainly the more difficult tickets that are left, but that is somewhat unavoidable because we didn't get them into Ready for Work state right away |
| 18:07:01 | <MarkG> also it was probably good for people to do easy tickets first... |
| 18:07:26 | <MarkG> i see 6 six tickets as ready for work |
| 18:07:32 | <MarkG> 3 in progress |
| 18:07:35 | <MarkG> 1 needs assessment |
| 18:07:46 | <rafa> MarkG: cool |
| 18:07:51 | <rafa> wyclif: you're up |
| 18:07:54 | <wyclif> thursday(i wasn't that productive): |
| 18:07:54 | <wyclif> * dev call |
| 18:07:54 | <wyclif> * Got blocked for a while about GIT commits, i kept on losing my changes in the process |
| 18:07:54 | <wyclif> * HTML-246 - Update Enrollment in Program to allow a date input, and to set current states |
| 18:07:54 | <wyclif> Friday: |
| 18:07:55 | <wyclif> * Complete work on HTML-246 and add tests for the tag in line with the changes |
| 18:07:56 | <wyclif> * I plan to FINALLY release SMART module since i had no feedback from the DEVs i emailed on monday |
| 18:07:58 | <wyclif> * Code review for trunk tickets |
| 18:08:00 | <wyclif> No Blocker though i feel like i still get slowed by the git workflows\ |
| 18:08:25 | <rafa> wyclif: have you seen http://wiki.eclipse.org/EGit/User_Guide? |
| 18:08:33 | <rafa> wyclif: it's a good tutorial to egit/git |
| 18:08:42 | <rafa> okay my turn: |
| 18:08:50 | <rafa> Today: |
| 18:08:50 | <rafa> * Committed: |
| 18:08:50 | <rafa> + HTML-264: Test forms that modify a Patient and an Encounter at the sames |
| 18:08:50 | <rafa> https://tickets.openmrs.org/browse/HTML-264 |
| 18:08:50 | <rafa> + HTML-283: Fix problem with entering a form that creates a new encounter but also edits an existing patient record |
| 18:08:50 | <rafa> https://tickets.openmrs.org/browse/HTML-283 |
| 18:08:50 | <rafa> + HTML-286: Add master div to an HTML Form |
| 18:08:51 | <rafa> https://tickets.openmrs.org/browse/HTML-286 |
| 18:08:51 | <rafa> No blockers. |
| 18:09:25 | <rafa> Possible topics to discuss: git workflows |
| 18:09:28 | <rafa> !scrumoff |
| 18:09:28 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 18:09:29 | <MarkG> wyclif: looks like i got the Address test to run... i had to add openmrs-servlet to the context |
| 18:09:44 | <wyclif> MarkG, cool |
| 18:09:53 | <rafa> wyclif: do you have any specific question regarding git? |
| 18:10:11 | <wyclif> i later figured out the things last evening |
| 18:10:35 | <wyclif> rafa, how to create a review |
| 18:10:47 | <wyclif> rafa in githug |
| 18:10:50 | <wyclif> rafa in github |
| 18:11:10 | <rafa> wyclif: we use comments on commits for that |
| 18:11:20 | <wyclif> MarkG, but that tells me that the it is still specific to 1.6, |
| 18:11:31 | <rafa> wyclif: if you go to the github tab on the ticket |
| 18:11:42 | <rafa> wyclif: and click on commit's uuid |
| 18:11:48 | <wyclif> rafa yes |
| 18:11:57 | <rafa> wyclif: you can see a diff where you can review and add comments |
| 18:12:06 | <rafa> wyclif: it's all we have at the moment |
| 18:12:38 | <wyclif> rafa, cool thanks |
| 18:13:03 | <rafa> wyclif: you're welcome |
| 18:15:18 | <wyclif> MarkG, was that for 1.6 or later? |
| 18:15:59 | <MarkG> wyclif: got it working on 1.6... going to run through all the tests shortly... |
| 18:16:13 | <MarkG> wyclif: all tests against all versions, that is |
| 18:17:28 | *** djazayeri has joined #openmrs |
| 18:17:38 | *** ChanServ sets mode: +o djazayeri |
| 18:18:03 | <wyclif> MarkG, does this mean you are having 2 versions of the openmrs-servlet.xml file , one for 1.6 and for the other |
| 18:20:26 | <MarkG> wyclif: i am just including it at the top of the test file using the @ContextConfiguration annotation... not sure exactly where this pulls it from... |
| 18:22:35 | <wyclif> MarkG, in older versions i know that the address lay out is pulled from the openmrs-servlet and that is why it finally worked after that inclusion, in 1.8 it was changed to pull it from a GP table |
| 18:24:11 | <wyclif> MarkG, and i was thinking the test should probably consider set the GP before running it in case it a 1.8 or later |
| 18:25:27 | <wyclif> MarkG, but in the web app that is taken care of inside the logic of getDefaultLayout |
| 18:29:14 | <MarkG> wyclif: hmm, yeah, we will see what happens against 1.10 |
| 18:32:22 | <wyclif> MarkG, it will probably pass simply because the default layout in case the GP is blank which actually contains all the fields i included in the test, A more concrete test would set the GP with a template with specific fields and in the unit test it asserts that ONLY the defined fields are populated and the ret are null |
| 18:33:14 | <wyclif> MarkG, ret ->rest |
| 18:45:01 | *** lh has joined #openmrs |
| 18:45:14 | *** lh has joined #openmrs |
| 19:05:35 | <wyclif> hi MarkG |
| 19:11:06 | <MarkG> wyclif: hey, what's up? |
| 19:11:46 | <wyclif> MarkG, what is the point of the user to specify states and we can get the intial states from the work flow itself after all we wont accept anyhing besides the initial? |
| 19:12:50 | <wyclif> MarkG, i can loop through all the workflows and set the intial state for each |
| 19:13:52 | <MarkG> wyclif: are workflows not allowed to have more than one initial state? |
| 19:14:17 | <wyclif> hmm, good question |
| 19:14:24 | <wyclif> MarkG, hmm, good question |
| 19:14:33 | <MarkG> wyclif: my assumption was that they are... |
| 19:14:41 | <MarkG> wyclif: and i think they can via the UI |
| 19:14:52 | <MarkG> wyclif: but, yes, if they can't, there is no point in having them specified in the tag |
| 19:16:14 | <wyclif> djazayeri, MarkG and i wanted to know if a workflow can have multiple initial and terminal states |
| 19:20:22 | <wyclif> MarkG, |
| 19:20:42 | <djazayeri> wyclif: there are allowed to be multiple *possible* initial and terminal states in a workflow |
| 19:20:52 | <djazayeri> it's also possible for a state to be both initial, and intermediate. |
| 19:21:21 | <djazayeri> so it's possible that one patient is in two different initial states in the same workflow (at different times) |
| 19:22:21 | <wyclif> djazayeri, meaning a state can have multiple initial states, right? |
| 19:22:39 | <MarkG> wyclif: yes... |
| 19:22:47 | <wyclif> thank guys |
| 19:22:53 | <wyclif> thanks guys |
| 19:22:55 | <MarkG> np |
| 19:23:38 | <djazayeri> wyclif: a patient's list of states can have multiple initial ones |
| 19:26:43 | <wyclif> djazayeri, in the samw workflow? |
| 19:26:49 | <wyclif> djazayeri, in the same workflow? |
| 19:27:19 | <MarkG> wyclif: a patient can only be in one state in a given workflow at any time, but a workflow may have many possible initial states |
| 19:28:11 | <wyclif> i got that, djazayeri 's last comment almost got me thinking otherwise |
| 19:28:19 | <wyclif> MarkG, i got that, djazayeri 's last comment almost got me thinking otherwise |
| 19:30:38 | <MarkG> question for anyone-- |
| 19:30:53 | <djazayeri> (I'm on a phone call for next 10 mins) |
| 19:31:18 | <MarkG> I;m working on a test for HFE that needs to access the default address template |
| 19:31:46 | <MarkG> originally, this wasn't working, however i was able to get it working by adding: |
| 19:31:57 | <MarkG> @ContextConfiguration(locations = { "classpath:openmrs-servlet.xml"}, inheritLocations = true) |
| 19:32:04 | <MarkG> at the top of the respective class file |
| 19:32:32 | <MarkG> the thing is, when i run all the tests, tests in classes that are executed after the class I added @ContextConfiguration to fail... |
| 19:32:56 | <MarkG> anyone know how to deal with it... I tried @DirtiesContext on the last test in that class |
| 19:34:32 | <MarkG> rafa: do you think i should move this test back into the omod project? is this possible? |
| 19:40:02 | <djazayeri> MarkG: if the test requires openmrs-servlet.xml, then I think it should be in the omod. |
| 19:40:31 | <MarkG> djazayeri: thanks... that is what i thought |
| 19:40:49 | <djazayeri> wyclif: the "initial" flag on State (which is metadata) just means "is this allowed to be the first state that a patient is in for its workflow. |
| 19:41:15 | <djazayeri> e.g. for a treatment status workflow you might have made "needs assessment" and "in treatment" both allowed initial states. |
| 19:42:00 | <wyclif> ok |
| 19:42:16 | <MarkG> rafal: do you know if there are any special instructions i need to follow to add some new testse into the omod project of a module? |
| 19:42:52 | <djazayeri> wyclif: when we're talking about an individual patient, the only thing that matters is that their first PatientState in a workflow should be have state.initial == true. besides that, we ignore state.initial. |
| 19:43:28 | <rafa> MarkG: It shoud work if you simply put it in src/test/java |
| 19:43:29 | <wyclif> djazayeri, ok |
| 19:44:08 | <rafa> MarkG: I'm not sure about your tricky test profiles |
| 19:44:26 | <MarkG> rafa: i will have to copy over the testApplicationContext, etc, correct? |
| 19:45:04 | <rafa> MarkG: hmm it may be necessary |
| 19:45:27 | <rafa> MarkG: we could write a method to do that automatically |
| 19:45:55 | <rafa> MarkG: I mean copying needed test resources |
| 19:46:12 | <rafa> MarkG: but for now just try to make it work |
| 19:46:31 | <rafa> MarkG: or write a ticket and assign it to me :) |
| 19:46:46 | <MarkG> rafa: you asked for it... :) |
| 19:46:48 | <rafa> MarkG: I'll deal with it on Monday |
| 19:46:51 | <rafa> though |
| 19:46:52 | <rafa> ;) |
| 19:54:29 | <MarkG> rafa: i think i will take a first pass and if it fails, leave it to you... |
| 20:02:10 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #OpenSource Tackles #Healthcare In Places Microsoft Can't: http://t.co/WUncTWOu #HealthIT #eHealth #ICT4D #OpenMRS #HFOSS #FOSS <http://twitter.com/OpenMRS/statuses/165524040180699136> |
| 20:38:13 | *** suranga has quit IRC |
| 21:01:42 | <lh> impressive |
| 21:11:00 | *** bryq has joined #openmrs |
| 21:11:00 | *** ChanServ sets mode: +v bryq |
| 21:19:44 | <MarkG> rafa: is there a way I can include classes in test in my api project as dependencies in my omod project? |
| 21:22:39 | <MarkG> rafa: looks like i can just package up my test-jar... |
| 22:01:44 | *** james_regen has quit IRC |
| 22:27:41 | *** rafa has quit IRC |
| 22:40:37 | *** bryq has quit IRC |
| 22:42:35 | *** MarkG has left #openmrs |