| 00:34:02 | *** wyclif has quit IRC |
| 01:02:50 | <sunbiz> djazayeri: do you get beans.xml errors?? |
| 01:02:59 | <sunbiz> on trunk?? |
| 01:03:20 | <djazayeri> sunbiz: let me do an update and check |
| 01:03:23 | <djazayeri> what's the full error? |
| 01:04:32 | <sunbiz> Error creating bean with name 'sessionFactory': FactoryBean which is currently in creation returned null from getObject |
| 01:04:39 | <sunbiz> every bean instatiation failed |
| 01:05:29 | <sunbiz> also says, Unable to start openmrs as Daemon |
| 01:08:11 | <sunbiz> djazayeri: what version of logic is going to be released with 1.9?? |
| 01:08:32 | <djazayeri> probably 0.5.1 or some maintenance release on top of 0.5 |
| 01:08:56 | <sunbiz> that doesn't work with postgres |
| 01:09:03 | <sunbiz> and hence OpenMRS doesnt start |
| 01:09:15 | <sunbiz> I had converted it to maven and used liquibase.xml |
| 01:09:23 | <sunbiz> !ticket LOGIC-90 |
| 01:09:24 | <OpenMRSBot> sunbiz: [#LOGIC-90] Logic uses MySQL specific SQL scripts - OpenMRS JIRA - https://tickets.openmrs.org/browse/LOGIC-90 |
| 01:09:24 | <djazayeri> sunbiz: 0.5.1? or 0.5? |
| 01:10:38 | <sunbiz> 0.5.0.1 still uses sqldiff |
| 01:18:39 | <djazayeri> sunbiz: so we need to replace that with a liquibase file? |
| 01:19:15 | <sunbiz> yes |
| 01:19:25 | <sunbiz> and that will work on with 1.7+ |
| 01:19:42 | <djazayeri> sunbiz: have you already done this in 0.5.1? |
| 01:20:03 | <sunbiz> I dont see 0.5.1 |
| 01:20:08 | <sunbiz> do u mean 0.5.0.1 |
| 01:20:39 | <djazayeri> sunbiz: I haven't done that |
| 01:21:20 | <sunbiz> djazayeri: what have u not done?? |
| 01:21:22 | <djazayeri> sorry, I thought that maybe you had |
| 01:21:30 | <djazayeri> made a version of logic with liquibase |
| 01:21:33 | <sunbiz> yes, the trunk has been done |
| 01:21:42 | <djazayeri> sunbiz: of logic? |
| 01:21:46 | <sunbiz> 0.5-SNAPSHOT |
| 01:21:50 | <djazayeri> ah, okay |
| 01:21:56 | <sunbiz> http://svn.openmrs.org/openmrs-modules/logic/trunk/ |
| 01:21:58 | <djazayeri> so you're saying we have to release a new version with 1.9 |
| 01:22:09 | <sunbiz> yes |
| 01:23:13 | <djazayeri> sunbiz: ah, okayâwe need a ticket for that. |
| 01:23:24 | <djazayeri> want to create one? |
| 01:24:17 | *** lh has quit IRC |
| 01:24:28 | <sunbiz> isnt LOGIC-90 good enough?? |
| 01:24:52 | <sunbiz> or should the ticket say release 0.6 with 1.9?? |
| 01:42:08 | <sunbiz> so the problem is with trunk of logic... with that Im getting the spring bean errors |
| 01:42:15 | <sunbiz> djazayeri: any help?? |
| 01:43:03 | <djazayeri> sunbiz: I mean we need a ticket in TRUNK, with fixVersion 1.9, like "release logic 0.5.1" as a Must. |
| 01:43:14 | <djazayeri> sunbiz: you're saying that trunk of *logic* won't build? |
| 01:44:12 | <sunbiz> it builds... but when added to trunk/WEB-INF/bundledModules then OpenMRS cant instantiate beans.xml |
| 01:44:28 | <sunbiz> that earlier error I was asking about... getObject returns null |
| 01:45:06 | <sunbiz> djazayeri: is there anything else to be done... I changed in ModuleConstants, from 0.5 to 0.5-SNAPSHOT |
| 01:45:17 | <sunbiz> earlier it would work fine that way |
| 01:45:44 | <djazayeri> sunbiz: ah. I don't know |
| 01:46:25 | <sunbiz> djazayeri: :( ok |
| 01:47:12 | <djazayeri> sunbiz: what if you call it logic-0.5.1? |
| 01:47:23 | <djazayeri> could it be because of a bug with -SNAPSHOT? |
| 01:47:35 | <djazayeri> or can you pastebin the whole error message? |
| 01:48:18 | <sunbiz> hmmm... lemme try that |
| 02:02:40 | <sunbiz> djazayeri: changing from SNAPSHOT didnt help |
| 02:02:45 | <sunbiz> and the pastebin was too long |
| 02:02:52 | <sunbiz> I'll just paste the starting |
| 02:02:55 | <djazayeri> okay |
| 02:04:47 | <sunbiz> djazayeri: http://pastebin.com/9sPeVLQN |
| 02:06:21 | <djazayeri> sunbiz: this seems to be relevant: Invocation of init method failed;nested exception is org.hibernate.HibernateException: Unable to parse order-by fragment |
| 02:06:59 | <djazayeri> sunbiz: does "order-by" show up somewhere in the logic module badly? |
| 02:07:03 | <djazayeri> (gotta run for a bit) |
| 02:07:57 | <sunbiz> hmm... lemme se |
| 02:07:58 | <sunbiz> okies |
| 02:19:20 | *** chopin_ has joined #openmrs |
| 02:21:10 | *** chopin_ has quit IRC |
| 03:02:07 | *** sunbiz1 has joined #openmrs |
| 03:04:46 | *** sunbiz has quit IRC |
| 03:16:50 | *** maurya has joined #openmrs |
| 03:18:14 | *** upul` has joined #openmrs |
| 03:18:14 | *** ChanServ sets mode: +v upul` |
| 03:22:09 | <maurya> djazayeri: https://tickets.openmrs.org/browse/TRUNK-2091 , is it the same functionality as that of manage drug orders ,but only being specific to the person directly? |
| 03:47:28 | <sunbiz1> djazayeri: the real error is this: Caused by: java.lang.ClassCastException: antlr.CommonToken cannot be cast to antlr.Token |
| 03:47:28 | <sunbiz1> at antlr.CharScanner.makeToken(CharScanner.java:173) |
| 03:47:28 | <sunbiz1> at org.hibernate.sql.ordering.antlr.GeneratedOrderByLexer.mIDENT(GeneratedOrderByLexer.java:238) |
| 03:47:28 | <sunbiz1> at org.hibernate.sql.ordering.antlr.GeneratedOrderByLexer.nextToken(GeneratedOrderByLexer.java:138) |
| 03:47:28 | <sunbiz1> at antlr.TokenBuffer.fill(TokenBuffer.java:69) |
| 03:47:29 | <sunbiz1> at antlr.TokenBuffer.LA(TokenBuffer.java:80) |
| 03:47:29 | <sunbiz1> at antlr.LLkParser.LA(LLkParser.java:52) |
| 03:47:30 | <sunbiz1> at org.hibernate.sql.ordering.antlr.GeneratedOrderByFragmentParser.expression(GeneratedOrderByFragmentParser.java:531) |
| 03:47:30 | <sunbiz1> at org.hibernate.sql.ordering.antlr.GeneratedOrderByFragmentParser.sortKey(GeneratedOrderByFragmentParser.java:337) |
| 03:47:31 | <sunbiz1> at org.hibernate.sql.ordering.antlr.GeneratedOrderByFragmentParser.sortSpecification(GeneratedOrderByFragmentParser.java:248) |
| 03:47:31 | <sunbiz1> at org.hibernate.sql.ordering.antlr.GeneratedOrderByFragmentParser.orderByFragment(GeneratedOrderByFragmentParser.java:192) |
| 03:47:32 | <sunbiz1> at org.hibernate.sql.ordering.antlr.OrderByFragmentTranslator.render(OrderByFragmentTranslator.java:60) |
| 03:48:13 | *** sunbiz1 has quit IRC |
| 04:18:19 | *** suranga has joined #openmrs |
| 04:18:21 | *** maurya has quit IRC |
| 04:45:49 | *** morristic has joined #openmrs |
| 05:46:52 | *** kishoreyekkanti has joined #openmrs |
| 06:04:46 | *** kishoreyekkanti has quit IRC |
| 06:56:59 | *** kishoreyekkanti has joined #openmrs |
| 06:57:09 | *** dkayiwa has joined #openmrs |
| 07:11:31 | *** dkayiwa has left #openmrs |
| 07:13:47 | *** dkayiwa has joined #openmrs |
| 08:07:19 | *** suranga has quit IRC |
| 08:18:56 | *** suranga has joined #openmrs |
| 08:26:26 | *** bryq has joined #openmrs |
| 08:26:26 | *** ChanServ sets mode: +v bryq |
| 08:41:41 | <suranga> dkayiwa, hi, r u there ? may I have some design advice please ? :-) |
| 08:41:53 | <dkayiwa> suranga: 8) |
| 08:43:07 | <suranga> mm.. its like this, Im enhancing some old code to use hibernate... Some of the classes I will be needing are really really small, with two or so variables. |
| 08:43:30 | <suranga> So im feeling that its overkill to create model classes and hbm files for them... mmm... have u ever faced such a scenario ? :-) |
| 08:43:54 | <dkayiwa> suranga: no |
| 08:44:04 | <suranga> dkayiwa, ooops :-( |
| 08:44:14 | <dkayiwa> suranga: how about model classes and annotations? :) |
| 08:44:42 | <suranga> oho... but problem is that I had already used hbm files for the other stuff :-) |
| 08:44:49 | <dkayiwa> ok |
| 08:45:04 | <suranga> can I interchange hbm and annotations ? :-) |
| 08:45:30 | <dkayiwa> suranga: not sure. but i guess it should be possible somehow :) |
| 08:46:28 | <suranga> dkayiwa, I will try that out and see... :P |
| 08:46:39 | <dkayiwa> suranga: 8) |
| 08:46:42 | <suranga> IRC is rather boring without Ben around :-) |
| 08:46:55 | <dkayiwa> suranga: lolllll |
| 08:47:16 | <suranga> its like school without the principal :P |
| 08:54:07 | <dkayiwa> :D |
| 09:15:44 | *** dkayiwa has quit IRC |
| 09:21:19 | *** sunbiz has joined #openmrs |
| 09:21:19 | *** ChanServ sets mode: +v sunbiz |
| 09:21:28 | *** rafa has joined #openmrs |
| 09:21:28 | *** ChanServ sets mode: +v rafa |
| 09:28:07 | <sunbiz> hey rafa |
| 09:28:14 | <rafa> hey |
| 09:28:45 | <sunbiz> I get a Caused by: java.lang.ClassCastException: antlr.CommonToken cannot be cast to antlr.Token when I deploy the trunk of logic module with OpenMRS trunk |
| 09:30:08 | <rafa> sunbiz: why do you need to deploy the logic module? |
| 09:32:59 | <sunbiz> because the 0.5.1 of logic wont work with postgres |
| 09:33:13 | <sunbiz> hence the trunk was mavenized and made to work with postgres |
| 09:33:21 | <sunbiz> using the liquibase.xml |
| 09:35:08 | <rafa> sunbiz: okay quick googling says it's incompatible version of antlr with some other lib |
| 09:35:10 | <sunbiz> rafa: On the web they say there are two antlr on the classpath |
| 09:35:13 | <sunbiz> yes |
| 09:35:13 | <rafa> sunbiz: what is the full stack trace? |
| 09:36:12 | <sunbiz> http://pastebin.com/85zf7tzq |
| 09:36:18 | <sunbiz> the full stack trace is huge |
| 09:36:34 | <sunbiz> prvents all the beans.xml from the openmrs universe to fail |
| 09:36:42 | <sunbiz> over 500KB |
| 09:37:24 | <rafa> :) |
| 09:38:34 | <sunbiz> the stacktrace starts with this: http://pastebin.com/Fr3ZrAtv |
| 09:38:49 | <sunbiz> and ends with the earlier pastebin |
| 09:45:40 | <rafa> sunbiz: can you try adding antlr-runtime in version 2.7.6 to the pom for OpenMRS trunk? |
| 09:48:28 | <rafa> sunbiz: I mean: |
| 09:48:29 | <rafa> <dependency> |
| 09:48:29 | <rafa> <groupId>antlr</groupId> |
| 09:48:29 | <rafa> <artifactId>antlr</artifactId> |
| 09:48:29 | <rafa> <version>2.7.7</version> |
| 09:48:29 | <rafa> </dependency> |
| 09:51:13 | <rafa> it may be that it picks up automatically a different version that is not compatible with Hibernate version we're using |
| 09:56:06 | <sunbiz> hmm... tried that |
| 09:56:10 | <sunbiz> gives the same error |
| 09:56:36 | <rafa> sunbiz: is logic packaged with any jars? |
| 09:56:38 | <sunbiz> Im wondering that the groovy has conflicting version of antlr |
| 09:56:53 | <sunbiz> that is incompatible with hibernate's antlr |
| 09:57:04 | <rafa> sunbiz: what version does groovy use? |
| 09:59:44 | <rafa> sunbiz: I know where's the problem |
| 10:00:04 | <rafa> sunbiz: I've just checked out the logic module and built it |
| 10:00:05 | <sunbiz> rafa: do u?? where?? |
| 10:00:13 | <rafa> sunbiz: it packages antlr-2.7.6.jar |
| 10:00:19 | <rafa> sunbiz: it shouldn't |
| 10:00:25 | <sunbiz> thats from the openmrs-api |
| 10:00:28 | <sunbiz> 1.6.3 |
| 10:00:43 | <rafa> sunbiz: we should exclude antlr and asm jars |
| 10:01:15 | <sunbiz> do u know (off the top of ur head) antlr exclusion |
| 10:01:26 | <sunbiz> groupId and artifactId |
| 10:01:52 | <rafa> yes, I'll change it |
| 10:02:23 | <rafa> sunbiz: I think it goes with groovy not with openmrs-api |
| 10:02:55 | *** kishoreyekkanti has quit IRC |
| 10:03:07 | *** kishoreyekkanti has joined #openmrs |
| 10:05:39 | <rafa> sunbiz: can you try quickly removing antrl-*.jar from omod and installing? |
| 10:05:50 | <sunbiz> yes... I can try that |
| 10:07:04 | <rafa> and all asm*.jars as well |
| 10:08:36 | <sunbiz> rafa: hurray!! |
| 10:08:39 | <sunbiz> it worked |
| 10:08:49 | <rafa> good |
| 10:08:52 | <sunbiz> lemme create a ticket |
| 10:08:54 | <rafa> I'll change the pom then |
| 10:08:56 | <sunbiz> and commit |
| 10:09:09 | <rafa> sunbiz: ohh I almost got it |
| 10:09:12 | <rafa> I can commit |
| 10:09:16 | <sunbiz> gr8 |
| 10:09:30 | <sunbiz> djazayeri: mentioned that we should create a ticket |
| 10:09:42 | <sunbiz> that with the 1.9 release the logic should be upgraded |
| 10:09:53 | <sunbiz> this can be another ticket |
| 10:09:57 | <sunbiz> in LOGIC |
| 10:10:22 | <sunbiz> don't know though if this change will cause trouble with earlier versions of OpenMRS |
| 10:10:36 | <rafa> sunbiz: it shouldn't |
| 10:10:45 | <rafa> sunbiz: all earlier versions have these jars |
| 10:10:54 | <sunbiz> ok |
| 10:30:51 | <sunbiz> thanks rafa... created linkages to other issues from that ticket |
| 10:33:29 | <rafa> np |
| 10:33:29 | <sunbiz> rafa: should this be backported to the other logic branches?? |
| 10:34:56 | <rafa> sunbiz: I don't know much about logic |
| 10:35:03 | <rafa> sunbiz: I'll let Darius decide |
| 10:37:05 | <sunbiz> rafa: okies |
| 10:39:01 | *** kishoreyekkanti_ has joined #openmrs |
| 10:39:31 | *** kishoreyekkanti_ has joined #openmrs |
| 10:39:35 | *** kishoreyekkanti has quit IRC |
| 10:39:35 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 11:43:06 | *** kishoreyekkanti_ has joined #openmrs |
| 11:43:17 | *** kishoreyekkanti has quit IRC |
| 11:43:29 | *** kishoreyekkanti has joined #openmrs |
| 11:57:35 | *** morristic has quit IRC |
| 12:02:35 | *** rafa has quit IRC |
| 12:04:07 | *** dkayiwa has joined #openmrs |
| 12:04:52 | *** upul` has quit IRC |
| 12:06:16 | *** kishoreyekkanti_ has joined #openmrs |
| 12:06:28 | *** kishoreyekkanti has quit IRC |
| 12:06:41 | *** kishoreyekkanti has joined #openmrs |
| 12:08:08 | *** james_regen has joined #openmrs |
| 12:08:08 | *** ChanServ sets mode: +v james_regen |
| 12:21:39 | <suranga> hi james_regen |
| 12:21:48 | <james_regen> hi suranga |
| 12:21:57 | <suranga> terribly sorry about yesterday, I got late signin in, and missed you :-( |
| 12:22:01 | <james_regen> sorry i missed you ysterday, i was in a meeting |
| 12:22:15 | <suranga> james_regen, I have some progress to report today :-) |
| 12:23:01 | <suranga> firstly, it seems that storing matchingconfigurations in the db is not that hard, and that I dont really need to create matchingCOnfigs or database sources... |
| 12:23:34 | <sunbiz> dkayiwa: backported it |
| 12:23:38 | <sunbiz> and edited my comment |
| 12:23:43 | <suranga> Basically I needed to call createpatientMatchingCOnfig method, and reset some values using the stuff im storing in the database... |
| 12:24:04 | <sunbiz> dkayiwa: re-closed... it sorry |
| 12:24:08 | <dkayiwa> sunbiz: you are so fast!!! thanks :) |
| 12:24:13 | <sunbiz> :D |
| 12:24:19 | <suranga> in the old flat file system, they were reading all the configurations into a matchingConfig list, so they had to use the database source etc. |
| 12:25:07 | <suranga> My matchingconfiguration save / restore process is not linked to the flat file any more, and to the best of my knowlege, it seems to work fine :-) |
| 12:26:55 | <james_regen> suranga: great. have you tried deleting the file and seeing if it sill works, and making changes? do you know how the file is made the first time, and if that's removed, too? i wouldn't want a blank file created when the module first runs, even if it is never used |
| 12:27:45 | <james_regen> i'd guess you have everything working fine, but that's the only few details i can think of to check |
| 12:28:54 | <suranga> james_regen, I did not mess with the flat file. right now, its intact (just as it was) :-) |
| 12:29:41 | <suranga> but assuming that I store a matching config, and then delete it from the database only, it will remain in the flat file, but wont get displayed in the list shown on the web page .... |
| 12:29:46 | <suranga> hope that this is ok... |
| 12:30:28 | <james_regen> yeah. it is safer to keep it around if it's already there. i'm assuming new uses of the module will never have a file at all after this code is committed? |
| 12:30:34 | <suranga> One more thing I noted, when you edit a matchingconfiguration, it actually creates a nw copy, as opposed to updating itself.... |
| 12:31:34 | <suranga> james_regen, ummm... the file will be there, and it will get updated... only we wont be actually using it... im rather hesitant to get rid of it altogether... |
| 12:33:35 | <james_regen> oh, i see. i understand now |
| 12:34:37 | <suranga> The flat file based sistem is really complicated (lots of values) but I think I have managed to get it done sucessfully... |
| 12:34:55 | <suranga> I wonder if you can take a look at it, just to double check ;-) |
| 12:36:56 | <james_regen> ok |
| 12:37:33 | <suranga> mm.. maybe I should send you a zip file, instead of commiting anything... |
| 12:37:55 | <suranga> I could point you to the files that need to get checked etc... |
| 12:39:48 | <james_regen> either way is fine. |
| 12:40:21 | <suranga> james_regen, let me take one last look at it, and send it over to you tomorrow :-) |
| 12:40:31 | <suranga> mm.. I have one more question .. :-) |
| 12:42:05 | <james_regen> ok |
| 12:42:35 | <suranga> well... these are my thoughts on phase 2 ... what do you think ?.... |
| 12:42:38 | <suranga> ---------------------- |
| 12:42:39 | <suranga> Problem : Store user generated reports in a database. |
| 12:42:39 | <suranga> A report consists of a report id, Report name and strategy. |
| 12:42:39 | <suranga> A strategy may consist of one or many patientMatching configurations. |
| 12:42:39 | <suranga> Question : is there some form of domain object to represent strategies ? some sort of object that acts like a list of <patientmatchingconfigurations> |
| 12:42:40 | <suranga> question : to store these strategies in the database, I should follow some sort of foreign key system with the patientmacthing configuration table |
| 12:42:43 | <suranga> We also need to record which patient records were identified as duplicates by each report. I guess this can be done easily. |
| 12:42:46 | <suranga> Untimately, we will be able to either streamline, or ultimately remove the entire persistrecorddata table from the database. |
| 12:42:51 | <suranga> -------------- |
| 12:46:22 | <james_regen> a strategy should match up exactly with a MatchingConfig object. it might say "strategy" to the user, but the matching code uses MatchingConfig. i would think in the database the report can just reference what you just created |
| 12:47:39 | <suranga> oh, I see... to if a report needs 1 or more strategies, we stuff them into a matchingCOnfig, and go with that... |
| 12:48:22 | <james_regen> we might want to think about how we handle deleting strategies. a user might want to delete or change a strategy while there still exists a report using a previous or previous version of a strategy. |
| 12:49:21 | <james_regen> i'm not sure i'd use "stuff them into." i would phrase what i'm thinking more as "associate the reports with the right matching configs" |
| 12:50:58 | <suranga> james_regen, I guess we should test out what I have done so far before going any further... it seems that what I've done so far is rather interrelated with the rest.... |
| 12:51:49 | <james_regen> yeah, it could be good to know we're starting the second part with a correctly finished first part |
| 12:53:25 | <suranga> I hope I got it right... sometimes the terminology used was rather hard to understand :P |
| 13:16:35 | *** rafa has joined #openmrs |
| 13:16:35 | *** ChanServ sets mode: +v rafa |
| 13:34:13 | *** kishoreyekkanti has quit IRC |
| 13:57:16 | *** wyclif has joined #openmrs |
| 14:00:17 | *** dkayiwa has quit IRC |
| 14:00:45 | *** dkayiwa has joined #openmrs |
| 14:18:32 | *** MarkG has joined #openmrs |
| 14:19:19 | *** dkayiwa has quit IRC |
| 14:20:29 | *** dkayiwa has joined #openmrs |
| 14:20:31 | <suranga> james_regen, ill be going off for today.... |
| 14:20:44 | <suranga> james_regen, I will send you the zip file tomorrow :-) |
| 14:32:48 | *** suranga has quit IRC |
| 14:52:33 | *** sunbiz has left #openmrs |
| 14:52:39 | *** dkayiwa has quit IRC |
| 15:01:05 | *** dkayiwa has joined #openmrs |
| 15:12:38 | <wyclif> hi MarkG, |
| 15:13:59 | <MarkG> wyclif: hey, what's up? |
| 15:15:21 | <wyclif> MarkG, i think the reason tests fail in eclipse could be because they were put in the ap/src/text/java pkge, they have to be in omod/src/test/java |
| 15:15:30 | *** james_regen has left #openmrs |
| 15:16:56 | <MarkG> wyclif: interesting, rafa just recently moved them into the api package, b/c i think we decided in general that was where module tests should be (since they are really testing the api) |
| 15:17:08 | <MarkG> wyclif: we probably didn't think of the eclipse issue |
| 15:17:26 | <rafa> wyclif: they work for me in eclipse |
| 15:17:27 | <MarkG> rafa: any thoughts? how do you usually run unit tests? via mvn/surefire, or eclipse directly? |
| 15:17:33 | <rafa> wyclif: what error do you get? |
| 15:18:16 | <wyclif> rafa, the application context doesn't load up |
| 15:18:28 | <wyclif> rafa, can you try running an individual test |
| 15:18:29 | <rafa> wyclif: try cleaning the project |
| 15:18:39 | <rafa> wyclif: they run with no problem |
| 15:19:13 | <rafa> wyclif: I mean cleaning via Project -> Clean... |
| 15:19:23 | <rafa> wyclif: then do mvn install |
| 15:20:29 | <wyclif> rafa, i already did that, can you try running a single test class by right clicking it and select run as junit test |
| 15:20:48 | <rafa> wyclif: haha I say it runs :) |
| 15:21:25 | <wyclif> rafa, it can't for me and MarkG says they dont for him |
| 15:21:46 | <rafa> MarkG: did you try it? |
| 15:21:56 | <wyclif> rafa, they only run when i do mvn test |
| 15:23:25 | <MarkG> wyclif: that's not entirely true... i had problems running tests via Eclipse for mvn projects in the past, so i haven't tried it in months... i will try it now... |
| 15:23:50 | <wyclif> this is the error i get Error creating bean with name 'configureVisitsFormController': Autowiring of fields failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private org.openmrs.api.EncounterService org.openmrs.web.controller.visit.ConfigureVisitsFormController.encounterService; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No unique bean of type |
| 15:23:50 | <wyclif> [org.openmrs.api.EncounterService] is defined: expected single matching bean but found 2: [encounterServiceTarget, encounterService] |
| 15:24:02 | <wyclif> and i have made no changes to the code |
| 15:27:44 | <MarkG> rafa: since the tests have been moved, in eclipse there is no longer a src/main/test folder... i have to navigate to the tests directly via the src folder... and then it doesn't even recognize the class as a test class... |
| 15:28:05 | <rafa> MarkG: ohh you need to import the project again to Eclipse |
| 15:28:20 | <MarkG> cool... let me try that... |
| 15:28:25 | <rafa> MarkG: or try updating mavne configuration |
| 15:28:48 | <rafa> Right-click -> Maven -> Update project configuration |
| 15:29:41 | <MarkG> rafa: yep, found it and that worked... i will try the tests again |
| 15:35:37 | <MarkG> rafa wyclif: they run through eclipse for me now... |
| 15:36:33 | <rafa> wyclif: have you imported as maven project? |
| 15:36:36 | *** maurya has joined #openmrs |
| 15:37:34 | <wyclif> yeah |
| 15:37:40 | <wyclif> rafa, yeah |
| 15:38:49 | <rafa> wyclif: do you see src/main/resources, src/test/java, src/test/resources as source folders in eclipse? |
| 15:38:59 | <rafa> wyclif: in the api project |
| 15:39:20 | <wyclif> yeah |
| 15:39:24 | <wyclif> rafa yeah |
| 15:39:37 | <rafa> wyclif: did you try maven clean? |
| 15:39:58 | <rafa> wyclif: maven clean, then eclipse clean, then install |
| 15:40:33 | <wyclif> yes, about 20 time now |
| 15:40:54 | <rafa> :D |
| 15:42:10 | <rafa> so the error indicates that the context configuration was found |
| 15:42:21 | <rafa> there's only something wrong with it |
| 15:42:57 | <rafa> I'm not sure why you have two beans created for encounterService |
| 15:43:20 | <rafa> but if you go to ConfigureVisitsFormController you can say explicitly which one to use |
| 15:43:44 | <rafa> and it should be the one named "encounterService" I guess |
| 15:44:00 | <rafa> wyclif: |
| 15:44:38 | <wyclif> rafa, i think the problem i that my intall target ic actually failing |
| 15:44:52 | <rafa> wyclif: ohh :D |
| 15:44:59 | <rafa> wyclif: you should have said that |
| 15:45:12 | <rafa> wyclif: if it fails jars are not built |
| 15:45:22 | <rafa> wyclif: tests in Eclipse won't work |
| 15:46:42 | <MarkG> rafa: does this mean when you change something in the api, you need to do a mvn install or the test will be running off the old jar? |
| 15:47:47 | <rafa> MarkG: no it's just that usually those jars are needed to initialize Spring context properly |
| 15:48:04 | <MarkG> rafa: got it, thanks... |
| 15:48:42 | <rafa> MarkG: regarding HTML-112 |
| 15:48:59 | <rafa> MarkG: from what I see there's defaultDatetime |
| 15:49:30 | <rafa> MarkG: should I change it to defaultValue? |
| 15:49:49 | <rafa> MarkG: or try with defaultDatetime first and then defaultValue? |
| 15:50:20 | <rafa> MarkG: it depends on when this attribute was added and if someone is using it |
| 15:50:45 | <wyclif> the problem is that hfe-release-tests jar is not getting created causing my built ot stop before tha module API i creates |
| 15:51:35 | <MarkG> rafa: saw your question, I will look into it |
| 15:51:52 | <dkayiwa> is anyone familiar with? ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/tmp/mysql.sock' (2) |
| 15:52:16 | <rafa> MarkG: I'll copy it to ticket then :) |
| 15:52:44 | <MarkG> dkayiwa: i think i may have ran into that once and just restarted mysql... :) |
| 15:53:03 | <dkayiwa> MarkG: ok let me try restart. thanks :) |
| 15:53:31 | <MarkG> rafa: i think the answer is that defaultValue just shouldn' |
| 15:53:44 | <MarkG> handle datetime then... |
| 15:54:01 | <rafa> okay |
| 15:54:35 | <MarkG> rafa: let me take a look tho and think about it... i will update the ticket... |
| 15:55:33 | <rafa> okay |
| 15:56:08 | <dkayiwa> wyclif: do you have any comments for TRUNK-2330 :) |
| 15:58:28 | *** kishoreyekkanti has joined #openmrs |
| 15:59:03 | <MarkG> rafa: just updated the ticket... thinking about it a bit more I would throw an exception/give an error if you try to save a form that has an obs tag that has both a defaultValue and a defaultDatetime, and handle the defaultValue with type=Date using the existing code that handles defaultDatetime. |
| 15:59:26 | <MarkG> rafa: let me know if you think there are any issues with handling that way or use cases i missed.. |
| 15:59:26 | <rafa> MarkG: sounds good |
| 16:01:32 | <wyclif> dkayiwa, i have commented |
| 16:01:48 | <dkayiwa> wyclif: ok thanks wyclif |
| 16:05:36 | <dkayiwa> wyclif: should i make it ready for work? |
| 16:08:00 | <wyclif> dkayiwa, you can check to see that actually that is not included, if not then make it ready for work |
| 16:08:12 | <dkayiwa> wyclif: ok |
| 16:13:59 | *** sunbiz has joined #openmrs |
| 16:13:59 | *** ChanServ sets mode: +v sunbiz |
| 16:15:10 | *** dkayiwa has quit IRC |
| 16:15:13 | *** dkayiwa_ has joined #openmrs |
| 16:17:08 | <wyclif> MarkG, what does this message mean Not Yet Instantiated |
| 16:21:48 | <MarkG> wyclif: where are you seeing it? |
| 16:24:40 | <wyclif> MarkG, when i run a test that i have added |
| 16:28:08 | <MarkG> wyclif: is that an exception that hfe is throwing? i can't find reference to it within the code? |
| 16:29:15 | *** wyclif has quit IRC |
| 17:31:16 | *** maurya has quit IRC |
| 18:16:38 | *** galinganmd has joined #openmrs |
| 18:17:23 | <galinganmd> Good day, would anybody know how to get the current user id in HTML Form Entry? |
| 18:18:10 | *** lh has joined #openmrs |
| 18:18:41 | *** lh has joined #openmrs |
| 18:19:49 | <MarkG> galinganmd: do you mean you want access to the current user within a form? |
| 18:20:46 | <galinganmd> yes MarkG, I want to get the current user id so I could do some security using javascript |
| 18:22:27 | <galinganmd> the javascript would allow only certain users to view the form |
| 18:23:28 | *** r0bby has joined #openmrs |
| 18:23:28 | *** ChanServ sets mode: +v r0bby |
| 18:23:42 | <MarkG> galinganmd: you can use the <lookup> tag to evaluate a velocity session... i haven't really used velocity, but it may provide access to the curent user... |
| 18:24:10 | <MarkG> galinganmd: although, from the wiki it looks like it doesn't |
| 18:24:24 | <MarkG> https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module+HTML+Reference#HTMLFormEntryModuleHTMLReference-%3Clookup%3E |
| 18:24:39 | <galinganmd> I checked it and it only shows how to get patient data |
| 18:24:43 | <MarkG> djazayeri: do you know if you can access the current user via velocity? |
| 18:25:19 | <djazayeri> MarkG: I don't knowâlook at where the velocity context is being set up |
| 18:25:38 | <djazayeri> 50-50 on whether I thought of the current user in the first place |
| 18:26:38 | *** robbyoconnor has quit IRC |
| 18:26:52 | <MarkG> MarkG: is isn't one of the things listed in the docs, so the answer is prob no but i will check |
| 18:27:06 | <MarkG> djazayeri: i assume you can't do it via logic? |
| 18:27:38 | <djazayeri> MarkG: I don't think so |
| 18:29:39 | <galinganmd> djazayeri and MarkG: I'm not that familiar with AJAX and dwr but could the current user id be taken using it? |
| 18:30:06 | *** wyclif has joined #openmrs |
| 18:30:20 | <djazayeri> galinganmd: probably, but that would be pretty inefficient, since it has to make a roundtrip to the server. |
| 18:30:48 | <djazayeri> I don't know what exactly MarkG is trying to do, but making the current user available in the velocity context is a one-line fix. |
| 18:31:23 | <MarkG> djazayeri: i was trying to answer a question for galinganmd... :) |
| 18:31:44 | <MarkG> galinganmd: it is an easy fix... could you enter a ticket for this and we should be able to get it added? |
| 18:31:45 | <galinganmd> djazayeri: yes, I just need it to get my implementation going before I get my security module made. |
| 18:32:48 | <djazayeri> galinganmd: we're in the middle of an HTML Form Entry sprint now, so if you create a ticket for this, we should be able to have it in a new HFE version released in about 10 days. (Or you could build from trunk...) |
| 18:33:15 | <djazayeri> rafa, dkayiwa_, MarkG, wyclif, do we have a scrum now? |
| 18:33:27 | <rafa> yes |
| 18:33:30 | <galinganmd> djazayeri and MarkG: thanks, I'll write one down. |
| 18:33:32 | <rafa> at least it's time :) |
| 18:33:39 | <djazayeri> Okay, let's roll. |
| 18:33:44 | <djazayeri> !scrumon djazayeri |
| 18:33:44 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster djazayeri- you may begin when ready. |
| 18:34:04 | <wyclif> yeah |
| 18:34:16 | <djazayeri> let's go in reverse order as shown in my irc client: wyclif, MarkG, dkayiwa_, rafa, djazayeri |
| 18:34:24 | <djazayeri> wyclif: you there? |
| 18:35:00 | <wyclif> yeah |
| 18:35:13 | <wyclif> Wednesday: |
| 18:35:13 | <wyclif> * design call |
| 18:35:13 | <wyclif> * Finish work for HTML-255 (spent some time trying to figure out how things are tailored in the module) |
| 18:35:13 | <wyclif> * Send out an email for to josh, ben, burke, darius about the status of the SMART module and it future |
| 18:35:13 | <wyclif> thursday: |
| 18:35:14 | <wyclif> * dev call |
| 18:35:16 | <wyclif> * HTML-246 - Update Enrollment in Program to allow a date input, and to set current states |
| 18:35:34 | <wyclif> blocker: Still struggling with unit tests |
| 18:35:49 | <djazayeri> wyclif: they won't run? |
| 18:36:16 | <djazayeri> in eclipse? or you mean with writing them? |
| 18:37:05 | *** galinganmd has quit IRC |
| 18:37:08 | <djazayeri> wyclif: ? |
| 18:37:12 | <wyclif> djazayeri, mvn clean install fails for me for both |
| 18:37:25 | <djazayeri> MarkG: thoughts? |
| 18:37:52 | <rafa> for both? |
| 18:37:53 | <wyclif> djazayeri, so the jar file is not getting to my repo, looks like i have to deploy it manually for the tests to pass |
| 18:38:07 | <rafa> wyclif: -DskipTests |
| 18:38:26 | <MarkG> rafa: that doesn't really help when his ticket is to write unit test... :) |
| 18:38:29 | <djazayeri> wyclif: one of the HFE jars isn't getting deployed? |
| 18:38:37 | <MarkG> rafa: ah, got it! |
| 18:38:44 | <MarkG> rafa: yes, wyclif... try that... |
| 18:38:46 | <wyclif> djazayeri, yes |
| 18:39:18 | <MarkG> wyclif: it may be something stupid where the unit tests need to jar to run, but the jar won't be installed until the tests are run... |
| 18:39:41 | <djazayeri> wyclif: okay, so try doing mvn clean install with skip-tests |
| 18:39:50 | <wyclif> MarkG, something like that |
| 18:39:54 | <MarkG> i've noticed some funky behavior around this, but never often enough to figure it out and write something up about it |
| 18:40:00 | <djazayeri> next up: MarkG |
| 18:40:10 | <wyclif> that still fails |
| 18:40:13 | <MarkG> not too much to report |
| 18:40:22 | <MarkG> * reviewed HFE sprint tickets |
| 18:40:33 | <MarkG> * got final tickets in Ready for Work state |
| 18:40:36 | <MarkG> * dev call |
| 18:40:49 | <MarkG> * looked in JAXA\JSS (sp?) |
| 18:41:02 | <djazayeri> RAXA/JSS |
| 18:41:17 | <MarkG> * want to look into the new release tests test this afternoon |
| 18:41:23 | <MarkG> * and continue to review/update tickets |
| 18:41:46 | <djazayeri> okay, any blockers? |
| 18:41:52 | <MarkG> no blockers |
| 18:42:01 | <djazayeri> okay |
| 18:42:03 | <djazayeri> dkayiwa_: your turn |
| 18:42:11 | <dkayiwa_> design call |
| 18:42:11 | <dkayiwa_> dev call |
| 18:42:11 | <dkayiwa_> Reviewed and closed: Installation Wizard Should Automatically Select Correct Hibernate Dialect - TRUNK-2621 |
| 18:42:12 | <dkayiwa_> Reviewed: Liquibase Updates Need to be Backward-Consistent, Yet Support All Databases - TRUNK-2652 |
| 18:42:12 | <dkayiwa_> Reviewed and closed: Fix build on JDK7 - TRUNK-3041 |
| 18:42:12 | <dkayiwa_> Reviewed: Include the default locale value when getting locales in order - TRUNK-2330 |
| 18:42:13 | <dkayiwa_> Reviewed: Implement voiding of PersonNames - TRUNK-2198 |
| 18:42:13 | <dkayiwa_> Looked into: Release logic 0.5.1 bundled with OpenMRS 1.9 - TRUNK-3045 |
| 18:42:13 | <dkayiwa_> Did some 1.9 ticket administration |
| 18:42:14 | <dkayiwa_> Now going through the remaining post commit tickets and see if there are some which need to be closed. |
| 18:42:14 | <dkayiwa_> No Blockers |
| 18:42:20 | <MarkG> djazayeri: it sounds like wyclif may be having the same isse as Dave? let's continue to talk after the scrum... |
| 18:42:39 | <rafa> Today: |
| 18:42:39 | <rafa> * Committed HTML-112: Add default argument to an obs htmlform tag |
| 18:42:39 | <rafa> https://tickets.openmrs.org/browse/HTML-112 |
| 18:42:39 | <rafa> * Committed LOGIC-97: Do not package extra jars in omod |
| 18:42:39 | <rafa> https://tickets.openmrs.org/browse/LOGIC-97 |
| 18:42:40 | <rafa> Tomorrow: |
| 18:42:40 | <rafa> * Try again with HTML-264: Test forms that modify a Patient and an Encounter at the sames |
| 18:42:41 | <rafa> https://tickets.openmrs.org/browse/HTML-264 |
| 18:42:41 | <rafa> * Start with HTML-283: Fix problem with entering a form that creates a new encounter but also edits an existing patient record |
| 18:42:42 | <rafa> https://tickets.openmrs.org/browse/HTML-283 |
| 18:42:42 | <rafa> No blockers. |
| 18:44:12 | <djazayeri> me |
| 18:44:12 | <djazayeri> Wednesday 1-Feb-2012 |
| 18:44:12 | <djazayeri> * University call |
| 18:44:12 | <djazayeri> * Catchup with TW and MarkG on release tests for HFE |
| 18:44:12 | <djazayeri> * Design call |
| 18:44:12 | <djazayeri> * Project Management call |
| 18:44:13 | <djazayeri> * Reviewed TRUNK-3032 |
| 18:44:13 | <djazayeri> * Design HTML-268 (integrate Provider model into HFE) |
| 18:44:14 | <djazayeri> Thursday 2-Feb-2012 |
| 18:44:15 | <djazayeri> * Developers call |
| 18:44:15 | <djazayeri> * Leadership call |
| 18:44:16 | <djazayeri> * Applied TRUNK-3032 |
| 18:44:16 | <djazayeri> * Commented on and/or closed some 1.9 tickets |
| 18:44:17 | <djazayeri> * Need to re-create the HFE eclipse projects |
| 18:44:17 | <djazayeri> * plan for pentaho sprint |
| 18:44:18 | <djazayeri> * Another sprint ticket |
| 18:44:40 | <djazayeri> no blockers |
| 18:44:44 | <djazayeri> !scrumoff |
| 18:44:44 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 18:44:46 | <MarkG> djazayeri: did you see my skype re: recreating HFE project? |
| 18:45:13 | <djazayeri> MarkG: that didn't work so I deleted and am recreating |
| 18:45:21 | <djazayeri> Possible discussion topics: |
| 18:45:28 | <MarkG> djazayeri: well, that should work... :) |
| 18:45:30 | <djazayeri> MarkG: comment on overall status? |
| 18:45:30 | <djazayeri> wyclif can't build |
| 18:45:30 | <djazayeri> rafa: HTML-264 (patient and encounter) |
| 18:45:53 | <djazayeri> wyclif: you said that doing the build with -DskipTests doens't work either? |
| 18:45:59 | <wyclif> djazayeri, yeah |
| 18:46:18 | <MarkG> wyclif: so if you do a mvn clean install from the command line, what is the error you get? |
| 18:46:20 | <wyclif> i have realised that this jar file is not getting built htmlformentry-release-tests:jar:1.8.3-SNAPSHOT |
| 18:46:31 | <wyclif> i have realised that this jar file is not getting built htmlformentry-release-tests-1.8.3-SNAPSHOT.jar |
| 18:46:34 | <djazayeri> wyclif: do you have a clean checkout? |
| 18:46:48 | <wyclif> djazayeri, yeah |
| 18:46:52 | <MarkG> wyclif: aah... so it is something to do with the release-test that TW just added... |
| 18:47:02 | <wyclif> MarkG, yes, |
| 18:47:04 | <MarkG> wyclif: they really should have no bearing on what you are doing... |
| 18:47:23 | <MarkG> wyclif: it didn't screw up anything for me, but for some reason it has for you... |
| 18:47:24 | <wyclif> when that fails then the module jar doesn't get build too |
| 18:47:34 | <rafa> wyclif: why is it failing? |
| 18:47:39 | <rafa> wyclif: what's the error? |
| 18:47:44 | <djazayeri> is there a way to tell maven to skip a particular child maven module? |
| 18:47:55 | <wyclif> MarkG, i think this is what dave is running into, have you seen that email thread |
| 18:48:19 | <MarkG> it should skip that child... let me take a look at what is happening when i build... |
| 18:48:32 | <djazayeri> wyclif: can you paste us the full error? |
| 18:48:35 | *** mal__ has joined #openmrs |
| 18:48:37 | <rafa> wyclif: remove release-tests from the main pom <modules> |
| 18:48:37 | <MarkG> wyclif: that's what i was thinking, but the release tests weren't added until this monday |
| 18:48:37 | <wyclif> the error message is that the artifact for the release tests and module are missing |
| 18:48:50 | <rafa> wyclif: it should disbale building release-test |
| 18:48:52 | <djazayeri> wyclif: can you paste the full output? |
| 18:48:56 | <mal__> hi |
| 18:49:19 | <mal__> am having problem while running the wizard |
| 18:49:25 | <wyclif> http://pastebin.com/xiTXG97V |
| 18:49:30 | <mal__> anyone for help |
| 18:49:46 | <wyclif> mal__, hold on |
| 18:49:53 | <mal__> okay |
| 18:50:05 | <djazayeri> wyclif: the missing thing is "org.openmrs.api:openmrs-api:test-jar:tests:1.10.0-SNAPSHOT" |
| 18:50:10 | <wyclif> mal__, we are still figuring out something |
| 18:50:16 | <wyclif> djazayeri, yes |
| 18:50:24 | <djazayeri> wyclif: can you do a mvn install on OpenMRS *trunk*? |
| 18:50:39 | <wyclif> djazayeri, and when i look in the project, that artifact is not getting build by the scripts |
| 18:50:46 | <wyclif> djazayeri, that works |
| 18:51:01 | <djazayeri> You've built trunk *with tests*? |
| 18:51:06 | <wyclif> djazayeri, yes |
| 18:51:46 | <djazayeri> can you look in your local maven repo to see if openmrs-api:test-jar is there? |
| 18:52:10 | <wyclif> djazayeri, the jar file for the release tests subproject is not created hence the missing artifact |
| 18:52:11 | <MarkG> looks like we need to modify the pom so that the release-tests subproject is not built by default? |
| 18:52:28 | <djazayeri> MarkG: that seems like the quick-fix |
| 18:52:44 | <wyclif> i think that will help for now |
| 18:52:53 | <wyclif> djazayeri, am checking |
| 18:53:00 | <MarkG> wyclif: i think it is the opposite, the jar file for the release test projects is not built because it can't find the required artifact |
| 18:53:04 | *** mal__ has quit IRC |
| 18:53:17 | <wyclif> MarkG, ok |
| 18:53:42 | <djazayeri> wyclif: indeed, it says that one of the OpenMRS trunk artifacts is missing. |
| 18:53:55 | <djazayeri> specifically one that gets built if you mvn install trunk with tests |
| 18:54:02 | <wyclif> you are guys are not running into this because you already have it, if you delete it from your mvn repo it will fail for you too |
| 18:54:12 | <MarkG> wyclif: test, probably |
| 18:54:43 | <wyclif> FYI, everything was working fine when i did all this before deleted my old project and checked out a new copy from GIT |
| 18:55:08 | <djazayeri> wyclif: I just checked out clean from GIT, so I'll see if I run into the same issue. |
| 18:57:14 | <MarkG> it looks like in the nighlty SNAPSHOT post to the maven repo, the openmrs-api-tests jar is not being posted |
| 18:57:29 | <MarkG> if we want to include this jar as a dependency, it needs to be posted... |
| 18:58:51 | <MarkG> i will write a ticket to michael d... |
| 18:59:43 | <wyclif> MarkG, right the jar file is not getting created and installed for the nightly build, |
| 19:00:02 | <wyclif> MarkG, i guess adding it manually will do for now |
| 19:00:07 | <rafa> it's a strange idea for tests to be a dependency |
| 19:00:36 | <MarkG> rafa: it is the new release-tests subproject that has that dependency... |
| 19:00:52 | <wyclif> MarkG, but why is it getting created for trunk and not for the module |
| 19:01:06 | <MarkG> rafa: is it strange that a module of tests would reply on the api-test? (i'm not being sarcastic... :) |
| 19:01:28 | <MarkG> wyclif: it creates it, but it must not install it... |
| 19:01:40 | <MarkG> wyclif: on trunk, did you do a mvn package or a mvn install? |
| 19:01:57 | <rafa> MarkG: Not only release-tests. Even the maven module archetype lists it in dependencies. |
| 19:01:57 | <wyclif> MarkG, install |
| 19:02:27 | <MarkG> rafa: huh, maybe that is wrong... a question for Ben |
| 19:03:11 | <MarkG> wyclif: i guess that makes sense... it doesn't install the test jars, just the main jars |
| 19:03:22 | <rafa> MarkG: it's there for some reason, the question is if it's a good one ;) |
| 19:04:44 | <MarkG> so, it looks like the idea is that the test jars aren't "installed" because generally they are something that aren't used as dependencies, are only used locally within the project they are tied do, but that is not the case for us... |
| 19:05:59 | <MarkG> wyclif: try removing the <module>release-tests</module> line from your main pom.. |
| 19:06:09 | <MarkG> after that, i think that a mvn clean package will work |
| 19:06:36 | <MarkG> but i bet if you try to build against trunk via mvn clean package -Dopenmrs-1.10 that will still fail with the same error |
| 19:08:47 | <wyclif> removing the module worked |
| 19:09:16 | <MarkG> wyclif: can you try mvn clean package -Dopenmrs-1.10 just out of curiosity? |
| 19:09:58 | <MarkG> wyclif: you don't need the module, it was something added a few days ago, so just leave your pom like that until we fix the dependency issue and everything should be fine... |
| 19:12:43 | <MarkG> just sent an email to michaeld/dev list asking to add the snapshots to the nightly build... |
| 19:12:46 | <MarkG> isn't maven fun! |
| 19:12:55 | <wyclif> MarkG, though when i remove the module then the code in it doen't compile |
| 19:13:11 | <wyclif> FYI the bui;d against 1 10 worked |
| 19:13:35 | <MarkG> wyclif: so does it compile against 1.10? |
| 19:13:36 | <wyclif> FYI the build against 1 10 worked |
| 19:13:47 | <wyclif> MarkG, yes |
| 19:13:59 | <MarkG> but not if you don't build against 1.10? |
| 19:16:25 | <MarkG> i will do some testing of all this now... |
| 19:20:50 | <wyclif> MarkG, is there a way i can no the version from a unit test |
| 19:21:02 | <wyclif> MarkG, the OpenMRS version |
| 19:23:43 | <MarkG> wyclif: you mean the version you are testing against? |
| 19:25:23 | <wyclif> MarkG, yes |
| 19:25:57 | <MarkG> i've set it up so that if you run just a mvn clean test, it tests against 1.6.5 |
| 19:26:28 | <MarkG> if you set a -Popenmrs-1.6, or -Popenmrs-1.7, or -Popenmrs-1.8, it tests against the latest released versions of those releases |
| 19:27:00 | <MarkG> to test a against a specific version, you need to have two profiles, for instance to compile against 1.6.3: -Popenmrs-1.6,openmrs-1.6.3 |
| 19:27:27 | <MarkG> if you do a -Popenmrs-1.10 it compiles against the latest trunk snapshot build in the mavenrepo |
| 19:27:55 | <MarkG> -Popenmrs-1.9 tests against the 1.9.0-beta |
| 19:51:10 | *** chopin has joined #openmrs |
| 19:52:06 | <chopin> dkayiwa_, is xforms mavenized yet, and do you mind if i add the latest version of it to the nexus repository? |
| 19:54:44 | <dkayiwa_> chopin: not yet mavenized :) |
| 19:55:09 | <chopin> dkayiwa_, okay if i post the jar in nexus repo tho? |
| 19:55:28 | <dkayiwa_> oh that would be great |
| 19:55:39 | <chopin> ok, i need it for amrsmobileforms |
| 19:55:40 | <chopin> :-) |
| 19:55:53 | <dkayiwa_> chopin: just go ahead :) |
| 19:55:59 | <chopin> ok then |
| 19:56:46 | <chopin> 3.9.5? |
| 19:57:13 | <MarkG> what version of openmrs is the current openmrs standalone? 1.8 something, I assume? |
| 19:57:22 | <chopin> should be 1.8.3 |
| 19:57:44 | <chopin> i think you can get a bleeding edge version too |
| 19:57:57 | <MarkG> chopin: cool, thanks |
| 20:02:11 | <chopin> dkayiwa_, that was easy :-D |
| 20:02:32 | <dkayiwa_> chopin: easier because it is not yet mavenized? :D |
| 20:03:38 | <chopin> dkayiwa_, honestly it's easy either way ... nexus site is nice |
| 20:03:51 | <dkayiwa_> :D |
| 20:12:05 | <MarkG> to all sprinters--i just added this to the openmrs HFE wiki, but, for better or worse, the HFE module code base has not been run through the OpenMRS code formatter, so let's not use the formatter after we make changes or we won't be able to pick out the diffs easily... |
| 20:12:50 | <MarkG> if it really bugs you, go ahead and format it but do it in a separete commit... |
| 20:13:47 | <dkayiwa_> hi wyclif |
| 20:15:05 | <wyclif> hi dkayiwa_ |
| 20:15:11 | <dkayiwa_> wyclif: whenever you get some time, you could have a look at my comment on TRUNK-2330 |
| 20:17:37 | <wyclif> dkayiwa_, it doesnt |
| 20:18:31 | <wyclif> dkayiwa_, it only adds the allowed locales list, default locale and english |
| 20:19:16 | <wyclif> the call to getDefaultLocale will always return the GP value if it is set |
| 20:19:19 | <dkayiwa_> wyclif: have you looked at the method calls within that method? |
| 20:19:33 | <wyclif> dkayiwa_, yes, you mean getDefaultLocale() |
| 20:19:40 | <dkayiwa_> wyclif: yes |
| 20:19:56 | <wyclif> dkayiwa_, that returns the default locale defined by the GP |
| 20:20:16 | <wyclif> and not the hardcoded costant en_GB |
| 20:20:44 | <dkayiwa_> wyclif: do you see this comment: // if we weren't able to load the locale from the global property, |
| 20:20:54 | <dkayiwa_> wyclif: // use the default one |
| 20:23:44 | <dkayiwa_> wyclif: LocaleUtility.getDefaultLocale() line 92 |
| 20:24:17 | <wyclif> dkayiwa_, i see it but that means it only returns it if there is default locale and am saying i want it to always include it |
| 20:24:31 | <MarkG> wyclif: i just backed up my entire .m2 repo and then deleted it... i am going to try to build against each version of openmrs now and see what happens |
| 20:24:40 | <wyclif> dkayiwa_, do you get what i mean, that is conditional |
| 20:24:49 | <wyclif> just like we always add 'en' |
| 20:25:12 | <wyclif> dkayiwa_, my point, check of the value isn't in the list and add it |
| 20:25:30 | <wyclif> dkayiwa_, am commenting on the ticket |
| 20:26:43 | <dkayiwa_> wyclif: so do you mean we should just add this? locales.add(fromSpecification(OpenmrsConstants.GLOBAL_PROPERTY_DEFAULT_LOCALE_DEFAULT_VALUE)); |
| 20:27:06 | <dkayiwa_> wyclif: just the same way we do? locales.add(Locale.ENGLISH); |
| 20:27:53 | <wyclif> dkayiwa_, yeah |
| 20:28:12 | <dkayiwa_> wyclif: ok will do so now |
| 20:28:41 | <wyclif> dkayiwa_, but i want to add an if clause before each is added to check if it is missing, i know we missed this if for english |
| 20:28:48 | <wyclif> dkayiwa_, do you get what am saying |
| 20:29:45 | <dkayiwa_> wyclif: i get you now. i though the missing if was intentional because we are using a set data structure which does not allow duplicates. am i correct about this? |
| 20:30:45 | <wyclif> dkayiwa_, correct |
| 20:31:09 | <dkayiwa_> wyclif: so should i leave out the if? |
| 20:31:43 | <wyclif> dkayiwa_, sure since it is a set, it will ignore it |
| 20:32:00 | <dkayiwa_> wyclif: ok |
| 20:35:31 | <MarkG> wyclif: so, i deleted my .m2 repo, did a mvn clean package, and failed, but only because the htmlformentry jar had not been installed... i did mvn clean install, and everything worked fine... |
| 20:35:50 | <MarkG> wyclif: i'm at a loss as to what is going wrong for you... |
| 20:39:24 | <wyclif> MarkG, i just got my hacks in place to get me working, i will look into it later, thanks for the follow up though |
| 20:45:45 | <chopin> blargh, how do we generate jars from maven? :-./ |
| 20:45:48 | * chopin keeps forgetting stuff |
| 20:45:54 | *** kishoreyekkanti has left #openmrs |
| 20:46:02 | <chopin> is it mvn jar:jar ? |
| 20:50:04 | <chopin> er, perhaps i need a clue on how to install a mavenized module to the nexus repo |
| 20:50:05 | <chopin> :-/ |
| 20:50:31 | <MarkG> chopin: did mvn deploy not work for you? |
| 20:50:38 | <chopin> ah ha |
| 20:50:44 | <chopin> did not know about deploy |
| 20:51:50 | <dkayiwa_> chopin: you can read more about it from: https://wiki.openmrs.org/display/docs/Release+Process :) |
| 20:52:41 | <MarkG> chopin: there is also some module-specific info here: https://wiki.openmrs.org/display/docs/Managing+the+Maven+Repository |
| 20:52:57 | <chopin> there we go |
| 20:52:58 | <chopin> thanks |
| 21:00:13 | <dkayiwa_> chopin: have you ever used eclipse? :D |
| 21:01:56 | <chopin> dkayiwa_, yes |
| 21:02:04 | <chopin> dkayiwa_, netbeans >> eclipse ;-) |
| 21:02:21 | <dkayiwa_> chopin: :D |
| 21:02:37 | *** sunbiz1 has joined #openmrs |
| 21:03:03 | <chopin> sunbiz would agree :-D |
| 21:03:29 | <dkayiwa_> chopin: yes am very sure he will. That is why he logged in just on time :D |
| 21:04:09 | *** sunbiz has quit IRC |
| 21:04:14 | <sunbiz1> chopin: are we referring to netbeans++ |
| 21:04:30 | <chopin> sunbiz1, certainly are |
| 21:04:39 | <sunbiz1> yes netbeans++ |
| 21:04:39 | <dkayiwa_> chopin: whenever one talks about netbeans, sunbiz1 just logs in automatically, regardless of where he is :) |
| 21:04:45 | <chopin> hahahaha |
| 21:05:20 | <chopin> arrgh, deploy is not working for me ... getting a 401 |
| 21:05:48 | <MarkG> chopin: yes, you need to have your username/password confiugred in your settings file... |
| 21:05:57 | <MarkG> chopin: or i think you can add it at the command line |
| 21:06:04 | <sunbiz1> chopin: u need to create a settings.xml |
| 21:06:13 | <chopin> i created one, per the web page |
| 21:06:14 | <MarkG> chopin: the link above i added has the info |
| 21:06:14 | <chopin> :-/ |
| 21:06:20 | <chopin> in [home]/.m2 |
| 21:06:29 | <dkayiwa_> chopin: you can look at the troubleshooting section at the bottom on https://wiki.openmrs.org/display/docs/Release+Process |
| 21:06:34 | <dkayiwa_> just incase |
| 21:06:50 | <MarkG> chopin: it may be that you don't have the proper rights... but you had rights to add an artifact via the web ui, correct? |
| 21:07:03 | <chopin> yes, added to 3rd party though |
| 21:07:10 | <chopin> not sure if that is the same as the "modules" repo |
| 21:07:24 | <chopin> only one in "modules" is htmlwidgets |
| 21:07:25 | <chopin> i think |
| 21:07:43 | <dkayiwa_> chopin: When running: mvn clean deploy --batch-mode You may get an error message like this: Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.5:deploy (default-deploy) on project openmrs: Failed to deploy artifacts: Could not transfer artifact ............ Failed to transfer file ......... Return code is: 401 -> [Help 1]. Solving this requires you to have a nexus repository account, under the openmrs-repo-releases section, in your ma |
| 21:07:43 | <dkayiwa_> settings.xml file which should be in your MAVEN_HOME folder. If this file does not already exist, you need to create one. See the example maven settings.xml file attached: settings-example-mvnrepo.xml. |
| 21:10:11 | <MarkG> chopin: fwiw, we decided recently that we should start deploying all mavenized modules to the "modules" repo... |
| 21:10:30 | <MarkG> chopin: we may have decided that non-mavenized modules are goiung to start going there as well.. |
| 21:10:54 | <MarkG> chopin: as for the authentication issue, i would open up a ITSM ticket to confirm that you have rights to deploy to the repo via maven... |
| 21:11:01 | <MarkG> chopin: i was having some permission issues at first... |
| 21:11:03 | <chopin> ahh |
| 21:11:47 | <chopin> oh, i need to encrypt my password |
| 21:11:47 | <chopin> perhaps |
| 21:11:47 | <chopin> MSH'd? |
| 21:13:28 | <MarkG> chopin: does your module pom have a <distributionManagement> section? |
| 21:14:48 | <chopin> MarkG, yep |
| 21:14:55 | <MarkG> chopin: i'm getting the same error when i try to deploy to the modules repo... the only repo i've successfully been able to deploy to is the releases repo |
| 21:14:55 | <chopin> i just added the encrypted password |
| 21:14:57 | <chopin> seeing if that helps |
| 21:15:05 | <chopin> blargh, it didn't |
| 21:15:08 | <MarkG> chopin: (sorry, just remembering all this) |
| 21:15:13 | <chopin> heheh |
| 21:16:20 | <sunbiz1> chopin: the id of the repo |
| 21:16:25 | <sunbiz1> that has to be the same |
| 21:16:36 | <sunbiz1> in the settings.xml and the module that u want to deploy |
| 21:18:46 | <chopin> sunbiz1, ahh ... modules is not in the settings file :| |
| 21:19:09 | *** sunbiz1 has left #openmrs |
| 21:19:33 | *** sunbiz has joined #openmrs |
| 21:19:33 | *** ChanServ sets mode: +v sunbiz |
| 21:19:39 | <MarkG> chopin: that was probably my issue as well... |
| 21:19:44 | <MarkG> sunbiz: thanks sunbiz... |
| 21:20:20 | <sunbiz> gr8... chopin, so it worked?? I got dc |
| 21:20:33 | <chopin> lookin good |
| 21:20:35 | * chopin watches |
| 21:20:52 | * sunbiz watches |
| 21:21:02 | <chopin> moved past the initial upload phase for the pom |
| 21:21:05 | <dkayiwa_> watches too :) |
| 21:21:17 | <chopin> household module 1.0.0 incoming |
| 21:21:18 | <chopin> :-D |
| 21:21:30 | <chopin> guess formentry should be up next |
| 21:21:39 | <chopin> ookay there it be |
| 21:21:48 | <sunbiz> looks like household got deployed |
| 21:21:56 | <sunbiz> chopin: gr8 |
| 21:22:03 | <chopin> http://mavenrepo.openmrs.org/nexus/content/repositories/modules/org/openmrs/module/ |
| 21:22:05 | <chopin> household ftw |
| 21:22:14 | <chopin> and MarkG's addresshierarchy |
| 21:22:15 | <chopin> :-D |
| 21:22:22 | <sunbiz> addressheirarchy by MarkG |
| 21:22:35 | <sunbiz> I have a feed :) |
| 21:23:00 | <chopin> literally within seconds of each other |
| 21:23:24 | <MarkG> a good day |
| 21:24:19 | <chopin> yes |
| 21:24:19 | <chopin> thanks fellas! |
| 21:40:12 | *** chopin has quit IRC |
| 21:55:52 | *** dkayiwa_ has left #openmrs |
| 22:03:09 | *** bryq has quit IRC |
| 22:11:21 | *** wluyima has joined #openmrs |
| 22:11:21 | *** wyclif has quit IRC |
| 22:11:48 | *** wluyima has quit IRC |
| 22:25:00 | *** lh has quit IRC |
| 22:31:33 | *** wyclif has joined #openmrs |
| 22:32:14 | <wyclif> MarkG, am tryin gto push my changes to origin master but it seems like it is failing |
| 22:32:40 | <MarkG> wyclif: what is the error you are getting? |
| 22:33:44 | <wyclif> is up to date |
| 22:34:40 | <MarkG> wyclif: Git seems a little confusing with this... I haven't totally figured it out yet, but i can try to step you through it... |
| 22:34:57 | <MarkG> wyclif: are your changes in your master branch, or in a topic branch you created? |
| 22:35:09 | <wyclif> MarkG, am doint it through eclipse |
| 22:35:53 | <MarkG> wyclif: did you create any branches using eclipse? |
| 22:35:59 | <wyclif> they in a topic, then i committed them to my local repo, but my local repo cant be pushed to github |
| 22:36:28 | <MarkG> is your local master branch up-to-date? |
| 22:36:43 | <MarkG> ie, team->fetch from upstream |
| 22:36:51 | <MarkG> (while you are in the master branch) |
| 22:37:10 | <MarkG> and then team->pull (while you are still in the master branch) |
| 22:38:07 | <wyclif> MarkG, yes |
| 22:38:21 | *** r0bby is now known as r0bby_ |
| 22:38:24 | *** r0bby_ is now known as robbyoconnor |
| 22:39:21 | <MarkG> wyclif: and you merged your topic branch into your master, and then committed you master if need be? |
| 22:39:36 | <wyclif> MarkG, apparently the changes from my topic didnt make into my local repo(i hope this is what you are calling the master branch) |
| 22:40:10 | <MarkG> your local repo contains all your local branches |
| 22:40:57 | <MarkG> you want (i think--i'm still learning git as well)--to get all your changes into your local master and then you can push that up to the main repo |
| 22:41:15 | <wyclif> MarkG, hmm |
| 22:41:40 | <MarkG> the team->show in history view is confusing but also somewhat helpful... |
| 22:43:11 | <MarkG> wyclif: sorry, i have to take off but i can try to help you out tomorrow morning if you don't figure it out... |
| 22:43:23 | <wyclif> MarkG, ok thanks |
| 22:43:39 | <MarkG> wyclif: good luck |
| 22:45:06 | <wyclif> MarkG, thanks |
| 22:45:09 | *** MarkG has left #openmrs |
| 22:52:14 | *** sunbiz has left #openmrs |
| 23:09:26 | *** wyclif has quit IRC |
| 23:16:02 | *** sunbiz has joined #openmrs |
| 23:16:02 | *** ChanServ sets mode: +v sunbiz |
| 23:32:04 | *** morristic has joined #openmrs |
| 23:57:13 | *** rafa has quit IRC |