00:09:05
|
*** robbyoconnor has joined #openmrs
|
00:09:05
|
*** ChanServ sets mode: +v robbyoconnor
|
00:17:09
|
*** robbyoconnor has quit IRC
|
00:32:06
|
*** robbyoconnor has joined #openmrs
|
00:32:06
|
*** ChanServ sets mode: +v robbyoconnor
|
00:46:26
|
*** robbyoconnor has quit IRC
|
00:46:44
|
*** robbyoconnor has joined #openmrs
|
00:46:44
|
*** ChanServ sets mode: +v robbyoconnor
|
00:47:35
|
*** robbyoconnor has quit IRC
|
00:47:53
|
*** robbyoconnor has joined #openmrs
|
00:47:53
|
*** ChanServ sets mode: +v robbyoconnor
|
01:00:39
|
*** robbyoconnor has quit IRC
|
01:02:26
|
*** robbyoconnor has joined #openmrs
|
01:02:35
|
*** ChanServ sets mode: +v robbyoconnor
|
01:08:26
|
*** robbyoconnor has quit IRC
|
01:08:44
|
*** robbyoconnor has joined #openmrs
|
01:08:44
|
*** ChanServ sets mode: +v robbyoconnor
|
01:14:18
|
*** robbyoconnor has quit IRC
|
02:13:23
|
*** msudarmono has joined #openmrs
|
03:21:46
|
*** msudarmono has quit IRC
|
03:42:52
|
*** morristic has quit IRC
|
03:44:33
|
*** upul` has joined #openmrs
|
03:44:33
|
*** ChanServ sets mode: +v upul`
|
06:22:48
|
*** robbyoconnor has joined #openmrs
|
06:22:48
|
*** ChanServ sets mode: +v robbyoconnor
|
07:08:14
|
*** pushkar has joined #openmrs
|
07:09:18
|
<pushkar> djazayeri: https://tickets.openmrs.org/browse/TRUNK-2240
|
07:10:45
|
<pushkar> only the date and time should be taken here ??
|
07:14:02
|
<pushkar> djazayeri:
|
07:28:46
|
*** pushkar has quit IRC
|
07:50:31
|
*** pushkar has joined #openmrs
|
07:54:36
|
*** pushkar has quit IRC
|
08:19:58
|
*** pascal` has joined #openmrs
|
08:19:58
|
*** ChanServ sets mode: +v pascal`
|
08:26:51
|
*** suranga has joined #openmrs
|
08:42:20
|
*** bryq has joined #openmrs
|
08:42:20
|
*** ChanServ sets mode: +v bryq
|
09:37:40
|
*** rafa has joined #openmrs
|
09:37:40
|
*** ChanServ sets mode: +v rafa
|
09:49:09
|
*** suranga has quit IRC
|
10:14:25
|
*** kishoreyekkanti has joined #openmrs
|
10:39:22
|
*** kishoreyekkanti_ has joined #openmrs
|
10:40:42
|
*** kishoreyekkanti has quit IRC
|
10:42:02
|
*** kishoreyekkanti has joined #openmrs
|
10:43:46
|
*** kishoreyekkanti_ has quit IRC
|
10:58:43
|
*** bryq has quit IRC
|
11:00:23
|
*** upul` has quit IRC
|
11:10:16
|
<pascal`> Anyone seen this before: WARN - CohortDefinitionServiceImpl.evaluate(213) |2012-02-01 13:09:21,327| An error occurred while attempting to access the cache.
|
11:10:17
|
<pascal`> java.lang.NullPointerException
|
11:10:17
|
<pascal`> at org.openmrs.module.reporting.cohort.query.db.hibernate.HibernateCohortQueryDAO.getPatientsHavingObs(HibernateCohortQueryDAO.java:969) ?
|
11:10:35
|
<pascal`> Maybe rafa or djazayeri?
|
11:11:04
|
<rafa> pascal`: hey
|
11:11:22
|
<rafa> pascal`: I haven't
|
11:11:50
|
<pascal`> rafa, Okay cool, I'm just trying to create a simple Coded Obs Cohort Definition :S
|
11:13:45
|
<pascal`> Full stack trace if anyone is interested: http://pastie.org/3295059
|
11:15:09
|
*** morristic has joined #openmrs
|
11:23:57
|
<pascal`> rafa, every tried running a coded observation query?
|
11:24:21
|
*** kishoreyekkanti has quit IRC
|
11:24:29
|
<rafa> pascal`: no I'm sorry. I'm not familiar with the reporting module at all.
|
11:28:18
|
<pascal`> rafa, okay cool. I can't get anything to run :(
|
11:29:38
|
<pascal`> !seen mseaton
|
11:29:38
|
<OpenMRSBot> pascal`: mseaton was last seen in #openmrs 36 weeks, 0 days, 19 hours, 47 minutes, and 39 seconds ago: <mseaton> great, thanks!
|
11:30:15
|
<rafa> pascal`: I saw him yesterday :)
|
11:30:23
|
<rafa> pascal`: I guess he was using a different nick
|
11:31:25
|
<pascal`> rafa, all I'm getting is NPE's when I try and run any cohort query.
|
11:35:50
|
*** james_regen has joined #openmrs
|
11:35:50
|
*** ChanServ sets mode: +v james_regen
|
11:35:54
|
<pascal`> As soon as I add a value contraint to the coded obs query it just dies
|
11:36:05
|
*** kishoreyekkanti has joined #openmrs
|
11:39:58
|
*** bryq has joined #openmrs
|
11:39:58
|
*** ChanServ sets mode: +v bryq
|
11:46:42
|
*** james_regen has quit IRC
|
11:48:54
|
*** james_regen has joined #openmrs
|
11:48:54
|
*** ChanServ sets mode: +v james_regen
|
12:03:04
|
*** morristic has quit IRC
|
12:31:28
|
*** bryq has quit IRC
|
13:14:46
|
*** kishoreyekkanti has quit IRC
|
13:47:49
|
*** wyclif has quit IRC
|
13:54:26
|
*** downeym has joined #openmrs
|
13:54:26
|
*** ChanServ sets mode: +o downeym
|
13:54:26
|
*** OpenMRSBot sets mode: +o downeym
|
14:02:08
|
*** bryq has joined #openmrs
|
14:02:08
|
*** ChanServ sets mode: +v bryq
|
14:03:44
|
*** jriley has joined #openmrs
|
14:06:29
|
*** pushkar has joined #openmrs
|
14:07:16
|
<pushkar> djazayeri:
|
14:07:19
|
<pushkar> https://tickets.openmrs.org/browse/TRUNK-2240
|
14:08:16
|
<pushkar> here on pressing the End the visit button i shold show the date and time ??
|
14:08:38
|
<pushkar> for user to select
|
14:16:10
|
*** jriley has left #openmrs
|
14:32:40
|
*** pascal` has quit IRC
|
14:40:53
|
*** wyclif has joined #openmrs
|
14:56:09
|
<djazayeri> hi pushkar
|
14:56:16
|
<djazayeri> what's the question?
|
14:57:17
|
<djazayeri> pushkar: yes, as described in the ticket, we want an "End Visit" button, which opens a popup letting you specify the end date & time.
|
14:57:29
|
*** kishoreyekkanti has joined #openmrs
|
15:03:36
|
<wyclif> hi djazayeri
|
15:03:38
|
<pushkar> but if we want to end on a specified date we can just set the date and time in the same page
|
15:03:42
|
<pushkar> djazayeri:
|
15:05:25
|
<djazayeri> pushkar: yes, there's an end date field, and a save button, but "end the visit" is a common task that we want to automate, but having an obvious button up top
|
15:13:26
|
<pushkar> djazayeri: okay
|
15:30:27
|
*** mseaton has joined #openmrs
|
15:43:36
|
*** mseaton has quit IRC
|
16:01:28
|
*** MarkG has joined #openmrs
|
16:01:45
|
<MarkG> sorry guys... I totally forgot to sign into IRC this morning...
|
16:12:31
|
*** maurya has joined #openmrs
|
16:14:57
|
<djazayeri> MarkG: you there? can you join a skype call with me and kishoreyekkanti?
|
16:15:17
|
<djazayeri> he'll explain the release testing maven setup
|
16:16:14
|
<MarkG> sure
|
16:24:25
|
<rafa> MarkG: where is <htmlform> translated to the actual HTML <form> tag?
|
16:27:28
|
<rafa> MarkG: nevermind, I've found it :)
|
16:35:24
|
*** Mkop has quit IRC
|
16:42:44
|
<MarkG> rafa: sorry, was on a call with darius...
|
16:42:56
|
<rafa> MarkG: no worries
|
16:56:14
|
*** Mkop has joined #openmrs
|
16:56:14
|
*** ChanServ sets mode: +v Mkop
|
17:06:19
|
<MarkG> rafa: Just reading your comments on HTML-264
|
17:06:26
|
<MarkG> !ticket HTML-264
|
17:06:28
|
<OpenMRSBot> MarkG: [#HTML-264] Test forms that modify a Patient and an Encounter at the sames - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-264
|
17:06:50
|
<MarkG> darius wrote regression test helper so you can tell him he should have documented it better... :)
|
17:07:03
|
<rafa> djazayeri: Darius I'm telling you :)
|
17:07:04
|
<MarkG> anyway, i have used it before so i will take a look at what you did...
|
17:08:12
|
<rafa> MarkG: cool note that I've marked that one test as ignored
|
17:08:27
|
<rafa> MarkG: I couldn't make it pass
|
17:09:03
|
<MarkG> @rafa: yes, i saw that... thanks... i will take a look, probably later today, maybe tomorrow...
|
17:09:23
|
<MarkG> if anyone is looking for me, i'll be out at lunch for the next half-hour or so...
|
17:09:24
|
<rafa> MarkG: thanks
|
17:09:44
|
<rafa> ok
|
17:24:54
|
*** pushkar has quit IRC
|
17:37:33
|
*** suranga has joined #openmrs
|
17:38:21
|
<suranga> hi james_regen
|
17:38:35
|
<suranga> james_regen, Im rather late today, hope you are still here :-)
|
17:49:57
|
<downeym> hey suranga
|
17:50:11
|
<suranga> howdy Michael !
|
17:50:18
|
<suranga> Long time no see !
|
17:50:57
|
<suranga> I returned home last week after an awesome trip. it was marvellous (with a few hicups :P)
|
17:53:46
|
*** dawn_ has joined #openmrs
|
17:53:49
|
<downeym> suranga: that's great to hear. hope you got a lot of photos.
|
17:54:04
|
*** dawn_ has quit IRC
|
17:54:05
|
*** dawn__ has joined #openmrs
|
17:54:15
|
*** ChanServ sets mode: +v dawn__
|
17:54:16
|
<suranga> well.. last year I had a problem because my battery kept getting low...
|
17:54:27
|
<suranga> this year I solved it by taking two cameras :P
|
17:54:33
|
<suranga> (as in two phones)
|
17:55:12
|
<suranga> but the impirtaint thing was that I presented two papers (really imporaint for my ultimate target:P)
|
17:58:37
|
<downeym> suranga: indeed
|
17:59:11
|
<suranga> actually, this time I didnt take as half as much photoes, because I didnt want to look silly... :-(
|
17:59:31
|
<suranga> mm.. Ben seems to be missing... I didnt see him in a few days...
|
18:00:23
|
<dawn__> !srumon dawn
|
18:00:24
|
<OpenMRSBot> dawn__: Error: "srumon" is not a valid command.
|
18:00:29
|
<dawn__> lol
|
18:00:33
|
<dawn__> !scrumon dawn
|
18:00:33
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
|
18:00:59
|
<dawn__> djazayeri: , rafa , MarkG , wyclif : hi
|
18:01:08
|
<djazayeri> hi
|
18:01:09
|
<rafa> hi
|
18:01:37
|
<dawn__> Today's order: rafa , djazayeri , wyclif , MarkG
|
18:01:49
|
<rafa> Today:
|
18:01:50
|
<rafa> * HTML-264: Test forms that modify a Patient and an Encounter at the sames
|
18:01:50
|
<rafa> https://tickets.openmrs.org/browse/HTML-264
|
18:01:50
|
<rafa> * HTML-279: Add deploy-web to HFE
|
18:01:50
|
<rafa> https://tickets.openmrs.org/browse/HTML-279
|
18:01:50
|
<rafa> * Started with HTML-112: Add default argument to an obs htmlform tag
|
18:01:50
|
<rafa> https://tickets.openmrs.org/browse/HTML-112
|
18:01:51
|
<rafa> Tomorrow:
|
18:01:51
|
<rafa> * Continue with HTML-112: Add default argument to an obs htmlform tag
|
18:01:52
|
<rafa> https://tickets.openmrs.org/browse/HTML-112
|
18:01:52
|
<rafa> * Other sprint tickets
|
18:01:53
|
<rafa> No blockers now, but lost much time on figuring out how to write tests for HFE.
|
18:01:54
|
<MarkG> wasn't this at 2 yesterday? :)
|
18:02:28
|
<wyclif> hi
|
18:02:31
|
<rafa> MarkG: we like change things :D
|
18:03:04
|
<djazayeri> MarkG: dawn__ is going to send out an email with a revised schedule for next week's scrums.
|
18:03:16
|
<dawn__> i can finally do that today since i have this proposal off my desk
|
18:03:25
|
<djazayeri> rafa: have you figured out how to write tests for HFE?
|
18:03:28
|
<dawn__> djazayeri: you ready?
|
18:03:34
|
<djazayeri> or does that still need documentation urgently?
|
18:03:42
|
<djazayeri> Tuesday 31-Jan-2012
|
18:03:42
|
<djazayeri> * finish HTML-36 (took a long time due to lack of deploy-web. Thanks Rafal!)
|
18:03:42
|
<djazayeri> * write a recommendation letter
|
18:03:42
|
<djazayeri> Wednesday 1-Feb-2012
|
18:03:43
|
<djazayeri> * University call
|
18:03:43
|
<djazayeri> * Catchup with TW and MarkG on release tests for HFE
|
18:03:44
|
<djazayeri> * Design call
|
18:03:44
|
<djazayeri> * Project Management call
|
18:03:45
|
<djazayeri> * Design HTML-268 (integrate Provider model into HFE)
|
18:03:45
|
<djazayeri> * Another sprint ticket
|
18:03:50
|
<rafa> djazayeri: kind of
|
18:04:09
|
<djazayeri> no blockers for me now that rafa has done a deploy-web equivalent
|
18:05:06
|
<dawn__> wyclif: your turn
|
18:05:28
|
<wyclif> tueday:
|
18:05:28
|
<wyclif> * Fixed some issues in SMART in 1.8(dropped 1.8 as required version)
|
18:05:28
|
<wyclif> * Getting up to speed with HFE module and git
|
18:05:28
|
<wyclif> * HTML-255 - Additional unit tests of <patient> tag
|
18:05:28
|
<wyclif> Wednesday:
|
18:05:29
|
<wyclif> * design call
|
18:05:30
|
<wyclif> * Commit code for HTML-255
|
18:05:32
|
<wyclif> * Send out an email for to josh, ben, burke, darius about the status of the SMART module
|
18:05:36
|
<wyclif> * sprint tickets
|
18:05:38
|
<wyclif> No blockers:
|
18:05:40
|
<wyclif> none
|
18:06:13
|
<dawn__> MarkG: are you ready or do you need some time?
|
18:06:14
|
<MarkG> not too much to add
|
18:06:17
|
<rafa> !ticket HTML-255
|
18:06:18
|
<OpenMRSBot> rafa: [#HTML-255] Additional unit tests of tag - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-255
|
18:06:31
|
<MarkG> i am working on reviewing existing tickets in code review state
|
18:06:57
|
<MarkG> also took some time yesterday trying to get HTML-246 and HTML-64 in "Ready for Work" state
|
18:07:10
|
<djazayeri> !ticket HTML-246
|
18:07:11
|
<OpenMRSBot> djazayeri: [#HTML-246] Update Enrollment in Program to allow a date input, and to set current states - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-246
|
18:07:12
|
<MarkG> i am soliciting feedback on those two, but plan to have them ready by end of day
|
18:07:16
|
<djazayeri> !ticket HTML-64
|
18:07:17
|
<OpenMRSBot> djazayeri: [#HTML-64] Additions to htmlforms for workflow and states - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-64
|
18:07:18
|
<MarkG> no blockers
|
18:07:39
|
<MarkG> djazayeri: thanks
|
18:07:50
|
<dawn__> thnx!
|
18:08:14
|
<dawn__> any discussion points today?
|
18:08:17
|
<dawn__> wyclif: can you forward that email about the SMART module to me, plz? :)
|
18:08:31
|
<wyclif> dawn__, sure
|
18:08:43
|
<djazayeri> I don't know of any discussion points.
|
18:08:55
|
<djazayeri> MarkG: I saw lara's comment on the workflow/state ticket
|
18:09:11
|
<djazayeri> It's an annoying, small-but-real use case
|
18:09:22
|
<dawn__> !scrumoff dawn
|
18:09:22
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
18:09:24
|
<dawn__> wyclif: thanks!
|
18:09:56
|
<djazayeri> I think people would be surprised to have status = X followed by status = X (the same status) as the next state.
|
18:10:00
|
<rafa> MarkG: my feedback for in design tickets: mention class names that are relevant to them. It makes an easier start :)
|
18:10:02
|
<djazayeri> but that's not strictly prevented anywhere
|
18:10:58
|
<MarkG> rafa: good point... i will try to do that more...
|
18:11:27
|
<MarkG> rafa: or i could say that it gives you a chance to explore the module in greater detail... :)
|
18:11:59
|
*** lh has joined #openmrs
|
18:12:14
|
<rafa> MarkG: haha
|
18:12:21
|
*** lh has quit IRC
|
18:12:21
|
*** lh has joined #openmrs
|
18:12:27
|
<MarkG> djazayeri: so your vote is for the logic I thought of (just role back the state start date, don't create a new state occurence?)
|
18:12:52
|
<djazayeri> MarkG: well, I originally agreed with that, but I think lara is right.
|
18:12:55
|
<rafa> !scrumoff
|
18:12:55
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
18:12:57
|
<rafa> ;)
|
18:13:05
|
<rafa> ohh fail
|
18:13:11
|
<rafa> i missed it
|
18:13:16
|
<djazayeri> MarkG: and, is there really anything wrong with having the same state twice in a row?
|
18:13:26
|
<djazayeri> rafa: you just broke someone's regex
|
18:13:37
|
<rafa> djazayeri: lol
|
18:14:05
|
<MarkG> dajayeri: no, i don't think so... i am in the process of writing an email saying let's go with lara's solution, so it is good that you agree with her now so i don't have to think it over again... :)
|
18:14:51
|
<MarkG> need a better chat client or need to figure out how to get this one to populate peoples name automatically...
|
18:14:54
|
<djazayeri> it's basically like recording an extra (unnecessary at the time) observation in the past
|
18:15:02
|
<djazayeri> MarkG: tab doesn't do it?
|
18:15:16
|
<MarkG> djazayeri: beautiful, thanks...
|
18:16:11
|
<MarkG> djazayeri: i don't have a problem, per se, with the same state twice in a row... but it might lead to the faulty case i mentioned in my email
|
18:16:23
|
<djazayeri> which was that actually?
|
18:16:23
|
<MarkG> djazayeri: but there is no "right" solution
|
18:18:33
|
<djazayeri> MarkG: ah, I see, you mean when you edit the form.
|
18:18:51
|
<MarkG> djazayeri: yeah, i was going to reforward my email, but you found it...
|
18:19:39
|
<djazayeri> technically we could add some sort of callback for encounter-date-changed, and the workflow/state tag could try to do something about it
|
18:19:50
|
<djazayeri> but that's a ton of work
|
18:20:34
|
<djazayeri> Mike has made the point that this would be better solved by having the encounter actually contain an obs to represent the state, and this should be handled by some event-handling about the obs
|
18:20:41
|
<MarkG> djazayeri: I think we just pick one way and document it well, and reassess when we reassess programs/workflows/states
|
18:20:45
|
<djazayeri> but again, a lot of work
|
18:20:56
|
<djazayeri> anyway, I'm fine going with lara's way and documenting it
|
18:21:24
|
<MarkG> djazayeri: i'm more concerned about the "current state" when editing a form... but I am sending out an email now about it...
|
18:22:06
|
<djazayeri> okay, gotta run for a bit
|
18:24:28
|
*** chopin_ has joined #openmrs
|
18:29:17
|
<chopin_> where are the address templates in 1.8.2+?
|
18:29:31
|
<chopin_> (obviously they are not in openmrs-servlet.xml anymore)
|
18:29:54
|
*** suranga has quit IRC
|
18:30:10
|
<MarkG> chopin_: i don't remember specifically, but they have been moved out into global properties so they can be specified without modifying the code, i believe...
|
18:30:23
|
<chopin_> MarkG, ah ... i'll check it out
|
18:30:27
|
<chopin_> thanks
|
18:32:54
|
<chopin_> MarkG, you can specify your layout in layout.address.format but the actual mapping isn't there ... looking still
|
18:34:12
|
<MarkG> chopin_:https://wiki.openmrs.org/display/docs/Administering+Address+Templates
|
18:34:13
|
<OpenMRSBot> <http://ln-s.net/8cEb> (at wiki.openmrs.org)
|
18:36:12
|
<chopin_> MarkG, THANK YOU.
|
18:37:00
|
*** dawn__ has quit IRC
|
18:41:27
|
*** kronos1981 has joined #openmrs
|
18:41:36
|
<kronos1981> Could you tell me where to start with OpenMRS? I am a new kid in this and I would like to learn more about this platform.
|
18:41:38
|
<downeym> Hi kronos1981 and welcome to the #openmrs IRC channel.
|
18:41:39
|
*** suranga has joined #openmrs
|
18:41:54
|
<kronos1981> HI
|
18:42:21
|
<kronos1981> as are all?
|
18:44:37
|
<kronos1981> hi
|
18:46:51
|
<kronos1981> hi could someone help me
|
18:53:53
|
<james_regen> suranga: hi, i was in a meeting earlier, but i'm back now
|
18:57:41
|
<djazayeri> kronos1981: what's the issue?
|
18:58:02
|
<djazayeri> ah, I have a call to lead in 3 minutes, so I can't give you a ton of background now
|
18:58:38
|
<djazayeri> kronos1981: some good (non-technical) introductory material is here: http://flossmanuals.net/openmrs-guide/
|
19:00:48
|
*** suranga has quit IRC
|
19:04:58
|
<djazayeri> Design call now. Planning the Pentaho sprint...
|
19:05:51
|
*** maurya has quit IRC
|
19:08:22
|
<chopin_> arrrrrgh
|
19:08:31
|
* chopin_ wishes days had more hours
|
19:13:49
|
*** dawn_ has joined #openmrs
|
19:13:49
|
*** ChanServ sets mode: +v dawn_
|
19:13:51
|
*** dawn_ has quit IRC
|
19:18:09
|
*** dkayiwa has joined #openmrs
|
19:30:30
|
*** Mkop has quit IRC
|
19:31:03
|
*** Mkop has joined #openmrs
|
19:31:03
|
*** ChanServ sets mode: +v Mkop
|
19:35:46
|
*** MarkG1 has joined #openmrs
|
19:36:01
|
<downeym> Hi MarkG1 and welcome to the #openmrs IRC channel.
|
19:36:20
|
*** MarkG has quit IRC
|
19:58:19
|
*** james_regen has left #openmrs
|
20:00:24
|
*** kishoreyekkanti has quit IRC
|
20:20:51
|
*** kronos1981 has quit IRC
|
20:46:38
|
*** chopin_ has quit IRC
|
21:04:20
|
*** downeym has quit IRC
|
21:04:38
|
*** downeym has joined #openmrs
|
21:04:38
|
*** ChanServ sets mode: +o downeym
|
21:04:38
|
*** OpenMRSBot sets mode: +o downeym
|
21:05:33
|
*** downeym has quit IRC
|
21:05:42
|
*** downeym has joined #openmrs
|
21:05:42
|
*** ChanServ sets mode: +o downeym
|
21:05:42
|
*** OpenMRSBot sets mode: +o downeym
|
21:07:10
|
*** downeym has quit IRC
|
21:16:51
|
*** rafa has quit IRC
|
21:18:14
|
<MarkG1> rafa: do you know what the current status is of
|
21:18:19
|
<MarkG1> !ticket META-155
|
21:18:20
|
<OpenMRSBot> MarkG1: [#META-155] incomingToExisting map passed to onSave method does not include objects that have previously been mapped to an existing object - OpenMRS JIRA - https://tickets.openmrs.org/browse/META-155
|
21:26:20
|
*** sunbiz has joined #openmrs
|
21:26:20
|
*** ChanServ sets mode: +v sunbiz
|
22:01:34
|
*** sunbiz has quit IRC
|
22:01:46
|
*** sunbiz has joined #openmrs
|
22:01:46
|
*** ChanServ sets mode: +v sunbiz
|
22:14:52
|
*** dkayiwa has quit IRC
|
22:23:19
|
<wyclif> djazayeri, are you able to run individual tests classes?
|
22:23:30
|
<djazayeri> wyclif: where?
|
22:23:45
|
<wyclif> in HFE?
|
22:23:49
|
<MarkG1> wyclif: -Dtest=TestClassName
|
22:24:06
|
<djazayeri> wyclif: I have been able to just say Run As -> Junit test in the usual way
|
22:24:09
|
<djazayeri> I haven't updated today
|
22:24:12
|
<wyclif> MarkG1, can't do it in eclipse?
|
22:24:45
|
<MarkG1> wyclif: i was getting some oddness in eclipse, so i've just been testing from the mvn command line...
|
22:24:59
|
<wyclif> MarkG1, djazayeri can you update, i get this error Error creating bean with name 'configureVisitsFormController': Autowiring of fields failed; nested exception is org.springframework.beans.factory.BeanCreationException: Could not autowire field: private org.openmrs.api.EncounterService
|
22:25:24
|
<djazayeri> wyclif: in trunk?
|
22:25:36
|
<wyclif> djazayeri, HFE
|
22:25:55
|
<MarkG1> wyclif: is this when running the unit tests via eclipse?
|
22:26:05
|
<djazayeri> what does configureVisitsFormController have to do with anything?
|
22:26:33
|
<wyclif> MarkG1, yes
|
22:26:56
|
<MarkG1> wyclif: try running all the tests from the mvn command line and see if they pass that way
|
22:27:30
|
<wyclif> MarkG1, that works except for those under the release-tests
|
22:29:36
|
<MarkG1> wyclif: release-tests are something different... they don't run for me when i run mvn clean test... don't know why they run for you...
|
22:29:56
|
<MarkG1> wyclif: so don't worry about them yet...
|
22:30:15
|
<MarkG1> wyclif: as for the other issue, i don't know why the tests pass when run at the command line but fail through eclipse/junit
|
22:30:53
|
<MarkG1> wyclif: i got frustrated and that is why i just decided to stick to the command line... i probably should have documented that in the HFE notes, but honestly i've been using the command line for awhile now i didn't even think of it
|
22:31:15
|
<MarkG1> wyclif: if you do figure it out, lmk... i will add something to the sprint wiki now...
|
22:31:47
|
<wyclif> MarkG1, on thanks
|
22:31:59
|
<MarkG1> wyclif: hope that made sense!
|
22:32:40
|
<wyclif> MarkG1, sure thanks, am working on HTML-255 and it seems to me like we need to test that addresses are handled right?
|
22:33:14
|
<wyclif> MarkG1, is there anything else you wish to get tested?
|
22:33:27
|
<MarkG1> djazayeri: no hurry, b/c i probably won't look at this until tomorrow, but check out my comments here when you get a chance:
|
22:33:34
|
<MarkG1> !ticket HTML-264
|
22:33:35
|
<OpenMRSBot> MarkG1: [#HTML-264] Test forms that modify a Patient and an Encounter at the sames - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-264
|
22:33:56
|
<MarkG1> wyclif: let me take a look at the ticket
|
22:34:22
|
*** bryq has quit IRC
|
22:36:52
|
<MarkG1> wyclif: i think it is mainly addresses
|
22:37:25
|
<MarkG1> wyclif: there is a related ticket around testing the creation of patients and encounters together,but rafal has already taken care of that (it is the ticket i linked to above)
|
22:37:58
|
<MarkG1> wyclif: we also should test entering an age insted of a birthdate
|
22:38:35
|
<MarkG1> wyclif: and test that if you enter a birthdate and an age, the birthdate takes priority as it says in the wiki
|
22:39:17
|
<wyclif> MarkG1, ok
|
22:39:23
|
<MarkG1> wyclif: basically, if you look at the "patient" entry in the html form entry wiki, and see and fields that aren't covered in the unit tests, we should add tests for them:
|
22:39:35
|
<MarkG1> https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module+HTML+Reference#HTMLFormEntryModuleHTMLReference-%3Cpatient%3E
|
22:40:14
|
<MarkG1> wyclif: your challenge is to create a test that breaks it... :)
|
22:43:18
|
<wyclif> MarkG1, got you
|
22:44:57
|
<MarkG1> wyclif: thanks
|
22:45:07
|
<MarkG1> i'm heading home for the night... talk with you all tomorrow...
|
22:46:13
|
<wyclif> MarkG1, out of curiosity, are these xxxForm.xml files an example of what the xml would be in the form?
|
22:47:05
|
<MarkG1> wyclif: yes... these are actually test forms that are processed via RegressionTestHelper
|
22:47:53
|
<MarkG1> wyclif: if you look in PatientTagTest, you will see an example of how they are used... the first test, "testCreateMinimalPatient" uses the "simpleCreatePatientForm"
|
22:49:09
|
<MarkG1> wyclif: RegressionTestHelper simulates the steps of submitting a form, viewing that form, and then resubmitting that form with changes...
|
22:49:12
|
<wyclif> MarkG1, got you thanks
|
22:49:44
|
<wyclif> MarkG1, i have read the docs for RegressionTestHelper
|
22:49:48
|
<MarkG1> wyclif: Rafal was complaining today that it wasn't well documented, so i told him to blame Darius, since he wrote it... :)
|
22:50:08
|
<MarkG1> wyclif: but, in all honesty, it is very useable and was sorely needed when darius added it
|
22:50:21
|
<wyclif> MarkG1, let see what i can get done, thanks for you time
|
22:51:12
|
<wyclif> MarkG1, let me see what i can get done, thanks for your time
|
22:51:35
|
<MarkG1> wyclif: np, take care
|
22:51:55
|
*** MarkG1 has left #openmrs
|
23:30:26
|
<wyclif> djazayeri, how are address layouts managed in hfe to be forward compartible in the module?
|
23:30:54
|
<djazayeri> wyclif: I don't know how they were implemented
|