IRC Chat : 2012-01-30 - OpenMRS

00:06:39 *** rafa has quit IRC
04:02:42 *** upul` has joined #openmrs
04:02:42 *** ChanServ sets mode: +v upul`
05:01:56 *** morristic has joined #openmrs
05:08:42 *** suranga has joined #openmrs
05:15:29 *** morristic has quit IRC
05:27:36 *** morristic has joined #openmrs
05:43:02 *** r0bby is now known as robbyoconnor
05:49:20 *** morristic has quit IRC
06:02:41 *** morristic has joined #openmrs
06:07:28 *** morristic has quit IRC
06:08:16 *** morristic has joined #openmrs
07:52:21 *** bryq has joined #openmrs
07:52:21 *** ChanServ sets mode: +v bryq
07:55:00 *** dkayiwa has joined #openmrs
08:06:55 *** bryq has quit IRC
08:18:44 <dkayiwa> Is Mark Goodrich in here? :)
08:20:05 <suranga> dkayiwa, I didnt see him this morning :-(
08:20:17 <dkayiwa> suranga: ok :)
08:20:29 <suranga> dkayiwa, I ididnt know that u were a keynote speaker at Pakistan last year !
08:20:35 <suranga> dodo had to tell me :-)
08:20:50 <dkayiwa> suranga: i have never been in pakistan :)
08:21:02 <suranga> mm... u wernt ?
08:21:18 <dkayiwa> suranga: i have never been there
08:21:29 <suranga> mm... maybe a mix up.. Dodo Khan told me that you were at last years conference... sorry :-)
08:21:32 <dkayiwa> suranga: dodo must have mistaken me with someone else :)
08:21:42 <suranga> maybe some other Openmrs related guy :-)
08:21:49 <dkayiwa> suranga: maybe
08:21:51 <dkayiwa> :)
08:33:15 <OpenMRSBot> Recent updates in the world of openmrs: Shazin Sadakath: Thread Safe Blocking List <http://shazsterblog.blogspot.com/2012/01/blocking-list.html>
08:49:36 *** upul` has quit IRC
09:01:26 *** dkayiwa has quit IRC
09:03:40 *** dkayiwa has joined #openmrs
09:46:34 <dkayiwa> does anyone know the htmlformentry checkout git url
09:47:54 *** rafa has joined #openmrs
09:47:54 *** ChanServ sets mode: +v rafa
10:00:46 <robbyoconnor> hai all
10:01:15 <dkayiwa> hey
10:02:03 <robbyoconnor> dkayiwa: just FYI it was on the OpenMRS github org page but here's the URL: https://github.com/OpenMRS/openmrs-module-htmlformentry.git
10:02:15 <robbyoconnor> also: git://github.com/OpenMRS/openmrs-module-htmlformentry.git
10:02:21 <robbyoconnor> either will work
10:02:28 <dkayiwa> ok thanks :)
10:02:45 <robbyoconnor> here is the github project: https://github.com/OpenMRS/openmrs-module-htmlformentry
10:02:48 <OpenMRSBot> <http://ln-s.net/9_Uo> (at github.com)
10:02:54 <dkayiwa> ok
10:03:14 <robbyoconnor> you can just fork it on github ;)
10:03:23 <dkayiwa> ok :)
10:03:38 <robbyoconnor> Didn't know if you knew that or not...
10:03:51 <dkayiwa> am very much of a newbie :)
10:05:09 <dkayiwa> robbyoconnor: am trying to import the project into eclipse. i have a screen with this text "Select branches to clone from remote repository." should i select master?
10:05:09 <robbyoconnor> I know very little about git but going to learn how to use it -- I have a few android app ideas in my head but am too lazy to do the planning
10:05:20 <robbyoconnor> yeh master
10:05:23 <dkayiwa> ok
10:05:34 <robbyoconnor> master is trunk
10:05:44 <dkayiwa> oh i see!!! :)
10:06:09 <robbyoconnor> the extent of my knowledge is scattered
10:06:17 <dkayiwa> oh
10:06:51 <robbyoconnor> I know just enough about bazaar to get by; I know just very little about git and enough about subversion to get by :)
10:07:07 <robbyoconnor> good luck
10:07:10 <dkayiwa> :D
10:08:00 <robbyoconnor> oh and mercurial -- I know enough about that to get by too :)
10:08:10 <dkayiwa> :D
11:05:52 *** dkayiwa has quit IRC
11:08:13 *** dkayiwa has joined #openmrs
11:19:03 <dkayiwa> hi rafa
11:19:09 <dkayiwa> [WARNING] The requested profile "openmrs-1.9" could not be activated because it does not exist.
11:19:10 <rafa> hi dkayiwa
11:19:28 <dkayiwa> rafa: are you working on htmlformentry?
11:19:50 <rafa> dkayiwa: yes
11:20:01 <rafa> dkayiwa: I was about to check it out
11:20:13 <dkayiwa> rafa: if yes, do you know how i can switch to different profiles?
11:20:40 <dkayiwa> am working on HTML-266
11:20:49 <rafa> dkayiwa: !ticket HTML-266
11:21:03 <rafa> !ticket HTML-266
11:21:04 <OpenMRSBot> rafa: [#HTML-266] unit test getProviderStub_shouldReturnAllProviderStubs(org.openmrs.module.htmlformentry.HtmlFormEntryServiceTest) fails against 1.10.0-SNAPSHOT - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-266
11:21:50 <rafa> dkayiwa: you need to use -P in maven I guess
11:22:17 <dkayiwa> rafa: am using eclipse
11:22:29 <dkayiwa> and i get that error message
11:22:40 <rafa> dkayiwa: let me check
11:22:55 <dkayiwa> when i put the profile in the run configuration
11:24:43 *** liz_ has joined #openmrs
11:27:24 <liz_> hiya
11:27:46 <liz_> anyone around?
11:27:56 <dkayiwa> :D
11:29:32 <liz_> one quick question...after running web application in openmrs, what will I be able to see?
11:30:05 <dkayiwa> liz_: login page :)
11:30:24 <liz_> cant see that, and no errors
11:30:24 <dkayiwa> liz_: or setup wixard
11:30:34 <dkayiwa> wizard
11:30:49 <dkayiwa> liz_: what do you see
11:31:22 <liz_> http://pastebin.com/vtJyAUGB
11:31:55 <liz_> in console that what I get
11:33:17 <dkayiwa> liz_: which url are you using in the browser?
11:34:21 <liz_> am running it from eclipse
11:34:44 <liz_> should I run it from the browser?
11:34:53 <dkayiwa> liz_: yes you will need to manually launch the browser and type in the url
11:35:10 <dkayiwa> e.g http://localhost:8080/openmrs/
11:35:54 <liz_> okay
11:36:22 <liz_> got that
11:36:26 <liz_> thanx
11:40:26 <rafa> dkayiwa: openmrs-1.9 profile works for me
11:40:43 <dkayiwa> rafa: how do you run it?
11:40:46 <rafa> dkayiwa: do you use install goal?
11:40:58 <dkayiwa> rafa: yes from eclipse
11:41:13 <dkayiwa> rafa: and then put the profile below in the profile box
11:41:36 <dkayiwa> rafa: and base directory is: ${workspace_loc:/htmlformentry}
11:42:28 <rafa> dkayiwa: are you sure it is the right path?
11:42:53 <dkayiwa> rafa: what do you have in your base directory?
11:43:51 <rafa> dkayiwa: a typical maven structure api, omod, pom.xml and README.txt
11:44:36 <dkayiwa> rafa: yes i have that. and it works without that warning if i leave the profile textbox empty
11:44:58 <rafa> dkayiwa: can you open pom.xml and see if openmrs-1.9 profile is there?
11:45:33 <dkayiwa> rafa: it is in the poms for api and omod only
11:46:07 <dkayiwa> rafa: if i put basedirector as ${workspace_loc:/htmlformentry-api}, all goes well
11:46:25 <rafa> dkayiwa: it should be in the parent pom as well
11:46:37 <dkayiwa> rafa: ok
11:46:43 <rafa> dkayiwa: seems like you haven't checked out or imported the project right
11:47:09 <dkayiwa> rafa: do you mean i left out some files?
11:47:25 <dkayiwa> rafa: or do you mean i checked out wrong project?
11:47:31 <rafa> dkayiwa: I mean a wrong project
11:47:37 <rafa> dkayiwa: I chose master
11:47:52 <dkayiwa> rafa: i also chose master
11:48:30 <rafa> dkayiwa: can you check in git what is your working directory for master?
11:48:51 <rafa> dkayiwa: you can see it easily on the Git Repositories view?
11:48:54 <dkayiwa> rafa: let me figure out how to check that :)
11:49:40 <dkayiwa> rafa: do your unit tests pass for the 1.9 profile?
11:49:49 <rafa> dkayiwa: no there's one test failing
11:50:02 <dkayiwa> rafa: if yes, then it looks like i did not understand HTML-266
11:50:16 <rafa> dkayiwa: getProviderStub_shouldReturnAllProviderStubs(org.openmrs.module.htmlformentry.HtmlFormEntryServiceTest): 'butch' failed to validate with reason: person: Person.names.length
11:50:26 <dkayiwa> rafa: ok that makes sense :)
11:51:04 <rafa> dkayiwa: did you find the working directory?
11:51:04 <liz_> dkayiwa: I have managed to get into the wizard but ending up with this error
11:51:15 <liz_> ???Error executing sql: create database if not exists `?` default character set utf8 - Could not create connection to database server. Attempted reconnect 3 times. Giving up.??? Failed to create the test database, see logs for details
11:51:26 <dkayiwa> rafa: /Users/danielkayiwa/Documents/openmrs/openmrs-module-htmlformentry
11:51:48 <rafa> dkayiwa: so that is where your project is
11:51:56 <dkayiwa> rafa: yes
11:52:08 <rafa> dkayiwa: you should probably change default repository folder to point to your eclipse workspace
11:52:23 <dkayiwa> rafa: how?
11:52:29 <rafa> dkayiwa: you can do it in Preferences -> Team -> Git
11:53:08 <rafa> dkayiwa: then delete the repository and clone it again so that it is in the right place
11:53:18 <dkayiwa> rafa: ok
11:53:46 <dkayiwa> liz_: have you tried out the standalone version?
11:54:40 <liz_> you mean simple installation?
11:55:19 <dkayiwa> liz_: just the standalone version of openmrs. you can get it from the downloads page
11:56:14 <liz_> i have checked out openmrs from svn
11:56:53 <dkayiwa> liz_: looks like you are a first timer and the standalone version is easier
11:57:33 <liz_> dont want to just download and install, needed the source code as I need to look at somethings
11:57:55 <dkayiwa> liz_: do you have mysql installed?
12:01:41 *** liz_ has quit IRC
12:07:45 *** bryq has joined #openmrs
12:07:45 *** ChanServ sets mode: +v bryq
12:20:04 *** james_regen has joined #openmrs
12:20:04 *** ChanServ sets mode: +v james_regen
12:22:10 <rafa> dkayiwa: have you fixed it?
12:22:32 <dkayiwa> rafa: was having lunch. now back on it. Thanks!!! :)
12:22:55 <rafa> dkayiwa: cool, let me know if you need me
12:25:09 *** dkayiwa_ has joined #openmrs
12:25:20 <dkayiwa_> sure i will. thanks rafa !!!
12:26:49 *** dkayiwa has quit IRC
12:26:49 *** dkayiwa_ is now known as dkayiwa
12:31:06 *** dkayiwa has quit IRC
12:41:24 <suranga> hi james_regen !
12:41:30 <suranga> good morning
12:41:32 <james_regen> hi suranga
12:41:32 <suranga> im back !
12:41:39 <suranga> long time no see :-)
12:42:30 <james_regen> yeah, you've been busy. everytyhing work out?
12:42:50 <suranga> james_regen, thankfully yes :-)
12:43:00 <suranga> two papers published
12:43:34 <suranga> so now that all thats over, I can focus on patientmatching as usual :-)
12:44:02 <suranga> mm.. u mentioned something about taking up mutual information scores again, right ?
12:44:55 <james_regen> yes, shaun mentioned that in a meeting last week. you might want to email him and let him know how that code is doing and what he wants to do next. was that code committed?
12:45:17 *** morristic has joined #openmrs
12:46:13 <suranga> oh yes, all the completed MI work was committed
12:46:31 <suranga> I will mail Dr. Shaun regarding the Mi work...
12:47:28 <james_regen> ok. the other thing i remember is the database work to move the configuration into the database and eventually the reports
12:48:10 <suranga> yep, I need to restart on that as well...
12:48:44 <suranga> I wanted to ask if anything new had happend with patientmatching module over the past weeks, or if there were any other top priority work that we need to take care of ?
12:49:48 <james_regen> there are 2 people with AMPATH working on the module. they had some questions about making it work two weeks ago. ada's using it to merge some data, but i haven't heard of any problems with it yet
12:50:17 <suranga> oh, I see... are these two regnstrief devs, or from the kenyan team ? :-)
12:50:28 *** wyclif has quit IRC
12:50:30 <james_regen> from kenya
12:50:43 <suranga> oh, I see
12:51:03 <suranga> so I take it that the database stuff and the MI work are outstanding from my end, isnt it ?
12:51:25 <james_regen> i think so
12:51:59 <suranga> aha... so I'll start work on the database work from now on.... Ill also e mail Dr. Shaun
12:52:10 <suranga> we can work on both concurrently, I guess
12:53:25 <james_regen> yeah, the MI might progress slowly. i'm not sure how busy shaun is. hopefully he'll make this a priority
12:54:58 <suranga> james_regen, no worries... will do
12:55:48 *** rafa has quit IRC
12:55:55 <suranga> james_regen, I need to dig up what I had done on the databases, the Pakistan trip came up so suddenly I had to drop everything :-(
12:56:05 <suranga> I will keep u updated on the progress ....
12:56:50 <james_regen> great, thanks
12:58:46 *** rafa has joined #openmrs
12:58:46 *** ChanServ sets mode: +v rafa
13:08:11 *** bryq has quit IRC
13:08:34 *** dkayiwa has joined #openmrs
13:15:22 *** morristic has quit IRC
13:20:46 *** dkayiwa has quit IRC
13:30:02 *** dkayiwa has joined #openmrs
13:34:31 *** dkayiwa has quit IRC
13:35:07 *** nribeka has joined #openmrs
13:35:07 *** ChanServ sets mode: +v nribeka
13:36:01 *** pushkar has joined #openmrs
13:37:28 *** wyclif has joined #openmrs
13:40:38 *** dkayiwa has joined #openmrs
14:20:29 *** nribeka has quit IRC
14:39:39 *** suranga has quit IRC
14:54:31 *** nribeka has joined #openmrs
14:54:31 *** ChanServ sets mode: +v nribeka
14:55:20 <nribeka> dkayiwa, now there's another issue. after pressing submit, it's throwing the "Purge HL7 Inbound Queue" privilege exception
14:55:27 <nribeka> is this the same openmrs bug dkayiwa?
14:55:36 <dkayiwa> nribeka: yes :)
14:55:49 <dkayiwa> nribeka: you need to add it too :)
14:56:07 <nribeka> any other privileges other than that? ;)
14:59:54 *** dkayiwa has quit IRC
15:00:24 *** MarkG has joined #openmrs
15:00:44 <MarkG> sorry guys, a little late getting on to chat this morning...
15:01:22 <MarkG> i will be around all day, so feel free to ping me if you need me...
15:01:50 <rafa> welcome MarkG :)
15:02:49 <rafa> MarkG: Is there something like rev:24343 for GIT ticket comments?
15:04:08 <MarkG> unfortunately, I don't think so... you could cut-and-paste the link to the to the actual commit on github, but if you include the ticket number in the commit message...
15:04:39 <MarkG> ... jira should pick it up link it in the "github" tab...
15:05:01 *** mseaton has joined #openmrs
15:05:53 <MarkG> you can see an example of what it does by checking out the github tab in HTML-159
15:06:00 <rafa> MarkG: cool, I've noticed that tab and it works better than for svn so it's fine
15:06:48 *** Rahul_ has joined #openmrs
15:06:53 <MarkG> i also don't think there is an easy way to include github code in a crucible review, so i was planning on doing reviews from this tab... you can click on the commit uuid and it
15:07:06 *** Rahul_ has quit IRC
15:07:11 <MarkG> will go to a github page where you can leave line code comments, etc...
15:07:14 *** dkayiwa has joined #openmrs
15:08:51 <rafa> MarkG: okay, that's good enough and there are e-mail notifications for comments as well
15:09:00 <MarkG> great
15:15:50 <rafa> MarkG: Do we have a JIRA dashboard for the sprint?
15:17:31 <MarkG> Rafa: I did have Michael D set up Greenhopper functionality, but I haven't done much configuration of the dashboard...however, i did set up an Issue filter "HFE Sprint" that shows all the tickets in the sprint
15:18:01 <MarkG> i set the filter to be public and viewable by anyone... can you confirm that you can see it?
15:18:09 <rafa> MarkG: I don't know much about greehopper, but I can setup a JIRA dashboard easily
15:18:22 <rafa> MarkG: yes, the filter works
15:19:33 <MarkG> rafa: feel free to set up a dashboard if you think it would be helpful... there is an HFE summary page in jira and some agile functionality, but i don't know exactly what makes something a "dashboard"...
15:20:10 <rafa> MarkG: cool, I'll set it up in a moment
15:27:51 <rafa> MarkG: See https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=11253
15:28:36 <rafa> MarkG: It gives a good overview on what's going on :)
15:33:16 <MarkG> rafa:thanks
15:35:09 *** mseaton has quit IRC
15:35:44 <rafa> MarkG: how about moving unit tests to the api project?
15:36:17 <dkayiwa> that would be 8)
15:39:02 <MarkG> rafa: sure, if you know how things should be reconfigured so that the unit tests are in the api, go ahead and do it... can you create a ticket as well to reference the commit?
15:39:34 <rafa> MarkG: yes, I've done it a few times. I'll create a ticket.
15:41:37 <rafa> MarkG: Can you click Ready for Work for HTML-276? I don't have rights.
15:41:45 <rafa> !ticket HTML-276
15:41:46 <OpenMRSBot> rafa: [#HTML-276] Move tests to API - OpenMRS JIRA - https://tickets.openmrs.org/browse/HTML-276
15:42:42 <MarkG> rafa: done. i set fix version to 1.9
15:42:52 <rafa> MarkG: thx
15:45:22 *** dkayiwa has quit IRC
15:45:22 *** dkayiwa_ has joined #openmrs
15:52:55 *** nribeka has quit IRC
16:00:53 <dkayiwa_> rafa: MarkG do i need to do more than just Eclipse:Team->Commit and Eclipse: Team->Push to Upstream for an svn commit equivalent?
16:02:18 <rafa> dkayiwa_: nope, that should be enough
16:06:02 *** nribeka has joined #openmrs
16:06:02 *** ChanServ sets mode: +v nribeka
16:07:38 <dkayiwa_> rafa: what is the difference between that and what mark wrote under Pushing changes up to GitHub at https://wiki.openmrs.org/display/RES/2012-1-30+HTML+Form+Entry+Sprint?
16:08:17 <dkayiwa_> rafa: MarkG 's instructions are many more than those two steps :)
16:10:26 *** pushkar has quit IRC
16:11:55 <MarkG> right, does that make sense?
16:13:16 <MarkG> dkayiwa_: if you don't create a top branch and work directly off your local master, those two steps should be enough...
16:13:16 <dkayiwa_> MarkG: am wondering why it is more steps than the two step process that rafa is suggesting
16:13:27 <dkayiwa_> MarkG: oh i see
16:14:08 <MarkG> dkayiwa_: i was trying to get people into the good practice of creating topics... :)
16:14:41 <dkayiwa_> MarkG: looks like i will need to do some reading to understand what a topic is :D
16:14:55 <MarkG> also, you may have to do more than those two steps if there have been incoming changes to the code since you started make your changes
16:15:05 *** nribeka has quit IRC
16:15:15 <dkayiwa_> MarkG: ok
16:15:19 <MarkG> dkayiwa_: it is a just a branch you create to work on a particular topic, ie a ticket...
16:15:30 <dkayiwa_> MarkG: ok
16:26:23 *** dkayiwa_ has quit IRC
16:30:06 *** nribeka has joined #openmrs
16:30:06 *** ChanServ sets mode: +v nribeka
16:55:31 <rafa> MarkG: why are test classes packaged in omod?
16:59:42 *** dkayiwa has joined #openmrs
17:07:27 <rafa> MarkG: I mean these lines in pom:
17:07:28 <rafa> <!-- filter the test classes since we dynamically substitute some of the test data filenames based on build profile -->
17:07:28 <rafa> <resource>
17:07:28 <rafa> <directory>src/test/java</directory>
17:07:28 <rafa> <filtering>true</filtering>
17:07:28 <rafa> <targetPath>java</targetPath>
17:07:29 <rafa> </resource>
17:07:31 <MarkG> rafa: not quite sure i understand your question... they are included in the omod because that was the way it was originally set up, but we have concluded that that was wrong... or are you asking something eslse?
17:07:46 <MarkG> okay, do you mean why do we actually package them up?
17:07:54 <rafa> MarkG: yes
17:08:17 <MarkG> ah, okay... i see... hold on...
17:09:13 <MarkG> in order to configure it the module to test against different versions of openmrs, i had to provide alternate versions of the test datasets...
17:09:58 <rafa> MarkG: can you point me to a file example where the substitution takes place?
17:09:59 <MarkG> for instance, there is a regressionTest-data-openmrs-1.10.xml, regressionTest-data-openmrs-1.9.xml, etc...
17:10:07 <MarkG> sure..
17:10:31 <MarkG> i don't think it actually needs to be packaged up, i was just taking advantage of the filtering capabilities...
17:10:37 <MarkG> looking for a file now...
17:11:20 <rafa> MarkG: yes, it's kind of strange to package up java files :)
17:11:56 <rafa> MarkG: but I think I understand what you wanted to achieve that way
17:12:07 <rafa> MarkG: I just can't find an example :)
17:12:49 <MarkG> rafa: yeah, i probably didn't realize it affected packaging...
17:13:21 <MarkG> i think all the dynamic stuff happens in test-datasets.properties
17:13:36 <MarkG> ... in test/resources
17:13:43 <rafa> ahh okay then we don't need to filter java files
17:13:50 <rafa> MarkG: it's enough to filter resources
17:14:42 <MarkG> rafa: that makes sense to me...
17:15:00 <MarkG> rafa: just make sure all the version-specific unit tests still run and we should be good
17:15:10 <rafa> MarkG: good
17:15:34 <rafa> one more quesiton
17:15:37 <rafa> <!-- manually configure tests so we exclude TestUtil testing -->
17:15:37 <rafa> <plugin>
17:15:37 <rafa> <groupId>org.apache.maven.plugins</groupId>
17:15:37 <rafa> <artifactId>maven-surefire-plugin</artifactId>
17:15:37 <rafa> <version>2.9</version>
17:15:38 <rafa> <configuration>
17:15:38 <rafa> <excludes>
17:15:39 <rafa> <exclude>**/TestUtil.java</exclude>
17:15:39 <rafa> </excludes>
17:15:40 <rafa> </configuration>
17:15:40 <rafa> </plugin>
17:15:46 <rafa> MarkG: what is that for?
17:19:06 *** djazayeri has joined #openmrs
17:19:06 *** ChanServ sets mode: +o djazayeri
17:20:04 <MarkG> rafa: it tells maven not to consider TestUtil.java as a set of unit tests it needs to execute
17:20:10 <djazayeri> MarkG: I'll be joining the sprint later today—I still have a bit of complex datatype + form resource stuff to finish up from friday
17:20:59 <MarkG> rafa: i think by default maven tries to execute every class in "test" as a unit test... or maybe it is just every class with "test" in the name... ?
17:21:36 <rafa> MarkG: normally only methods annotated with @Test should be considered as tests to run
17:22:20 <rafa> MarkG: maybe it was true for some old version of junit
17:22:29 <rafa> MarkG: I'm not that old :)
17:26:48 <MarkG> rafa: don't know exactly how maven testing works, but i was definitely having a problem with this after the switch to maven
17:27:29 <MarkG> rafa: the @Test annotation didn't seem to be doing anything when running tests via mvn...
17:27:47 <MarkG> rafa: or, scratch that...
17:28:33 <MarkG> rafa: i think the issue was that mvn was complaining if it found a class in src/test that didn't have any @Test annotations...
17:28:52 <rafa> MarkG: ok thanks
17:29:10 <MarkG> so you have to tell mvn to ignore that class completely... if you know a better way, feel free to change it, but I was running into a problem...
17:31:09 *** mvorobey has joined #openmrs
17:32:09 *** nribeka has quit IRC
17:37:07 *** mvorobey has quit IRC
17:53:47 *** pushkar has joined #openmrs
17:59:32 <dkayiwa> hi rafa
17:59:42 <rafa> hi dkayiwa
17:59:58 <dkayiwa> rafa: how do i tell that my Push to Upstream was successfull?
18:00:05 *** MarkG has quit IRC
18:00:18 *** MarkG has joined #openmrs
18:00:34 <rafa> dkayiwa: it says rejected otherwise
18:00:54 <dkayiwa> rafa: am doing it from eclipse. it did not give any success or failure message
18:01:10 <rafa> dkayiwa: when you do push you see a message Pushed to htmlformentry
18:01:28 <dkayiwa> rafa: i do not see any such message
18:01:31 <rafa> dkayiwa: it's a window with message details that you need to confirm with ok
18:01:45 <pushkar> djazayeri: what is the difference between discontinue date and autoexpiredate in order class??
18:02:14 <rafa> dkayiwa: btw you need to fetch
18:02:18 <djazayeri> pushkar: auto expire date is when the order is *scheduled * to end
18:02:24 <dkayiwa> rafa: oh
18:02:30 <rafa> dkayiwa: I've moved tests to api
18:02:37 <dkayiwa> rafa: ok
18:02:51 <djazayeri> pushkar: discontinue date is when someone stopped the order
18:03:30 <pushkar> so if if i want to stop a drug regime on a particular date in future what should i use ??
18:03:30 *** nribeka has joined #openmrs
18:03:30 *** ChanServ sets mode: +v nribeka
18:03:32 <djazayeri> pushkar: when you create an order, autoExpireDate is optional, but discontinueDate should be null. Later on, you can set a discontinueDate
18:04:05 <djazayeri> pushkar: if you're scheduling it to end in the future, you set autoExpireDate. if you're recording that it was stopped in the past, discontinueDate.
18:04:21 <pushkar> https://tickets.openmrs.org/browse/TRUNK-1962
18:06:34 <pushkar> so instead of auto expire date if i use discontinue date the drug regime wont stop ??
18:07:20 <djazayeri> pushkar: hmm, interesting
18:08:11 <pushkar> thats what happening there we are showing the autoexpire date but while stopping we are updating the discontine date
18:09:17 <pushkar> so thats why the the enddate is not getting displayed
18:10:36 <djazayeri> pushkar: so, I believe the right fix is to change the code that gets run when you click Stop, to set the autoExpireDate, if the date given is in the future.
18:10:44 <djazayeri> currently it always sets discontinueDate
18:11:04 <pushkar> yup should i continue with the bug??
18:11:17 <djazayeri> pushkar: yes.
18:11:50 <pushkar> and what about hte discontinue date ??
18:12:23 <dkayiwa> rafa: i had made some unit test changes (which i have so far failed to commit) so am tying to do an equivalent of svn revert by Team -> Reset (Hard) but it does not seem to revert. Is there anything else i need to do?
18:12:43 <djazayeri> pushkar: change the code so that if you try to stop a regimen in the future, it sets autoExpireDate, but if you stop it now or in the past, it sets discontinueDate, as it's currently doing.
18:13:45 <pushkar> okay
18:15:08 <rafa> dkayiwa: make sure you choose HEAD when doing reset
18:16:38 <dkayiwa> rafa: i do not see anything like head on the window that pops up
18:17:13 <rafa> dkayiwa: do you want to revert changes that you committed or not yet committed?
18:18:02 <dkayiwa> rafa: i committed. but i do not even know if the commit was successful :)
18:18:30 <pushkar> while setting the autoexpire date the discontinued(bool) should be set to true or false ??
18:18:44 <pushkar> djazayeri:
18:18:47 <dkayiwa> rafa: i committed like 10 times :)
18:19:07 <rafa> dkayiwa: there's almost no chance it failed since it's only to your local repository :)
18:19:15 <djazayeri> pushkar: it should be left false
18:19:31 <djazayeri> i.e. you only set discontinued if you're setting a discontinueDate
18:19:31 <rafa> dkayiwa: you can not cause conflicts in your local repository, you're the only one that uses it
18:19:40 <pushkar> djazayeri: okay :-)
18:19:46 <dkayiwa> rafa: i also did Push to Upstream like 10 times :)
18:20:04 <rafa> dkayiwa: okay so it's there
18:20:09 <dkayiwa> rafa: and never got any error message for each of those times
18:20:16 <rafa> dkayiwa: that's good :D
18:20:25 <dkayiwa> rafa: i expected something like, "There are no changes to commit"
18:20:33 <dkayiwa> rafa: atleast after the first time
18:20:47 <rafa> dkayiwa: ohh there should be a message there's nothing to commit or push
18:21:07 <dkayiwa> rafa: thats exactly what i expected to see but am not
18:21:16 <dkayiwa> rafa: maybe i need to do some more reading :)
18:21:24 <rafa> dkayiwa: I have something like: "No changed items were selected. Do you wish to amend the last commit?"
18:22:04 <dkayiwa> rafa: is that for Push to Upstream?
18:22:12 <rafa> dkayiwa: it's for commit
18:22:27 <dkayiwa> rafa: and for Push to Upstream?
18:22:33 <rafa> dkayiwa: push to upstream says up-to-date
18:22:49 <dkayiwa> rafa: it does not give me such a message
18:23:05 <dkayiwa> rafa: let me try update my git plugin
18:23:07 <rafa> dkayiwa: are you using egit or some other plugin?
18:23:22 *** dawn_ has joined #openmrs
18:23:36 <dkayiwa> rafa: egit
18:23:37 *** ChanServ sets mode: +v dawn_
18:24:27 *** pushkar has quit IRC
18:27:05 <rafa> dkayiwa: Make sure it's the latest version then
18:27:13 <rafa> dkayiwa: you can read more about egit here: http://wiki.eclipse.org/EGit/User_Guide
18:27:17 <dkayiwa> rafa: ok thanks :)
18:30:29 <dawn_> !scrumon dawn
18:30:29 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
18:30:51 <dawn_> djazayeri: , rafa , dkayiwa , MarkG , wyclif : hi
18:30:53 <djazayeri> hi
18:30:55 <rafa> hi
18:31:23 <wyclif> hi
18:31:27 <dawn_> Today's order: djazayeri, rafa dkayiwa MarkG , wyclif not sure if judy or Mike are here
18:32:29 <djazayeri> my report
18:32:30 <djazayeri> Friday 27-Jan-2012
18:32:30 <djazayeri> * Do TRUNK-3037 (refactor CustomDatatype/Handler)
18:32:30 <djazayeri> * Almost finished TRUNK-3039 (refactor CustomDatatype/Handler)
18:32:30 <djazayeri> Monday 30-Jan-2012
18:32:31 <djazayeri> * finish TRUNK-3039 (refactor CustomDatatype/Handler)
18:32:31 <djazayeri> * join HTML Form Entry sprint
18:32:32 <djazayeri> * write a recommendation letter
18:33:09 <rafa> djazayeri: blockers?
18:33:10 <djazayeri> no blockers
18:33:16 <rafa> Yesterday:
18:33:17 <rafa> * RESTWS-190: Include a way to get set members and answers for concept
18:33:17 <rafa> https://tickets.openmrs.org/browse/RESTWS-190
18:33:17 <rafa> Today:
18:33:17 <rafa> * HTML-171: Autocomplete values can't be removed if you start typing something
18:33:17 <rafa> https://tickets.openmrs.org/browse/HTML-171
18:33:17 <rafa> * HTML-222: Fix header in 1.8.x
18:33:18 <rafa> https://tickets.openmrs.org/browse/HTML-222
18:33:18 <rafa> * HTML-127: HTML Form Entry date field should enforce a four-digit year
18:33:19 <rafa> https://tickets.openmrs.org/browse/HTML-127
18:33:19 <rafa> * HTML-276: Move tests to API
18:33:20 <rafa> https://tickets.openmrs.org/browse/HTML-276
18:33:20 <rafa> * HTML-152: answerConceptIds is picky about mapping format
18:33:21 <rafa> https://tickets.openmrs.org/browse/HTML-152
18:33:21 <rafa> No blockers.
18:33:22 <rafa> NOTE YOU NEED TO FETCH AS I'VE JUST PUSHED A BIG CHANGE :)
18:34:39 <dawn_> dkayiwa: your turn
18:35:08 <dkayiwa> Did some reading of the sprint page and checked out the hmtlformentry module
18:35:10 <dkayiwa> Fixed: unit test getProviderStub_shouldReturnAllProviderStubs(org.openmrs.module.htmlformentry.HtmlFormEntryServiceTest) fails against 1.10.0-SNAPSHOT - HTML-266
18:35:10 <dkayiwa> I have not yet been able to push the fix to github, so in order not to waste more of Rafa's time, i have decided to first properly read: http://wiki.eclipse.org/EGit/User_Guide
18:35:10 <dkayiwa> Blocked on simple egis operations (push, revert, etc)
18:35:39 <dkayiwa> egis = egit
18:36:27 <djazayeri> MarkG: I don't remember, does the wiki page you wrote document the simple git operations?
18:36:52 <wyclif> can i go?
18:36:54 <MarkG> yes, as in that it tells you how to commit your changes...
18:37:24 <djazayeri> dkayiwa: have you read that page too?
18:37:26 <djazayeri> wyclif: yes, go
18:37:42 <wyclif> friday:
18:37:42 <wyclif> * Completed work on SMART-25 - Change how user apps are managed
18:37:42 <wyclif> * Made other change to the module to match the changes in SMART-25
18:37:42 <wyclif> * Fixed a couple of other bugs found during prerelease testing
18:37:42 <wyclif> Monday:
18:37:43 <wyclif> * Fixed a couple of bugs and cleaning up the code to remove unused files
18:37:45 <wyclif> * Update module wiki page
18:37:47 <wyclif> * Release the SMART module
18:37:49 <wyclif> * Code review for the Custom datatype tickets
18:37:51 <wyclif> * Start on HFE sprint tickets
18:37:53 <wyclif> No blockers
18:38:07 <dkayiwa> djazayeri: i read the sprint page. but it deals with a different scenario from mine. :)
18:38:15 <djazayeri> ok
18:38:39 <wyclif> djazayeri, i was unable to release the module before today as i had promised, :)
18:38:54 <dawn_> MarkG: do you have updates you want to list?
18:38:56 <djazayeri> wyclif: any particular blockers we can help with?
18:39:03 <MarkG> i can be quick...
18:39:23 <wyclif> djazayeri, none, am almost set
18:39:25 <MarkG> i need to continue to get all sprint tickets still in "Design" into "Ready To Work"
18:39:46 <MarkG> also in the process of reviewing fixed that have already been committed
18:39:49 <MarkG> no current blockers
18:40:08 <rafa> Ohh I forgot you can add https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=11253 to your favs :)
18:40:21 <MarkG> dkayiwa: what is your issue with pushing up to the repo? i double checked and you do have access to push to git...
18:40:22 <dawn_> Discussion Points: blockers on egit operations
18:40:28 <dawn_> !scrumoff dawn
18:40:28 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
18:41:09 <djazayeri> any discussion points?
18:41:18 <dkayiwa> MarkG: yes you added my account. Let update my egit plugin to the latest as Rafa has advised me and try it again
18:41:44 <dawn_> djazayeri: listed the one daniel mentioned for egit operations
18:41:46 <dawn_> rafa: dj
18:41:49 <dawn_> sorry
18:41:52 <wyclif> MarkG, are you using any git IDE for eclipse?
18:42:07 <dawn_> wyclif: : are we still working on tickets from last week's sprint?
18:42:21 <MarkG> yes, egit i believe... whatever it recommended on the "migrating to git" page
18:46:21 <rafa> MarkG: btw I like profiles you've created for testing with different openmrs versions. We should put something like that in the module wizard.
18:48:28 <MarkG> rafa: go for it... ;)
18:48:43 <MarkG> rafa: i did write a wiki page about it and suggested that others do it as well...
18:49:04 <MarkG> rafa: i've added it to a couple other modules i'm owning... address hierarchy and patient flags...
18:49:42 <rafa> MarkG: I can create a ticket at least. No time to make it happen yet ;)
18:50:06 <djazayeri> rafa: I didn't see an MDS release either
18:50:39 <rafa> djazayeri: that's right. The RESTWS ticket took me much time.
18:54:15 <djazayeri> rafa: okay, what's your strategy?
18:54:22 <djazayeri> how much time will you need to get the last ticket finished/
18:54:23 <djazayeri> ?
18:55:51 *** dkayiwa has quit IRC
18:56:07 <rafa> djazayeri: at least a whole day. I'll try to do some work in evenings, but maybe it'll need to wait for next weekend.
19:04:23 *** dkayiwa has joined #openmrs
19:13:16 <MarkG> rafa: i get a unit test failure after adding your API test refactoring...
19:13:44 <MarkG> rafa: looks like it now trying to execute TestUtil has a unit test.. i.e., it is not picking up that exclude you asked me about
19:14:58 <rafa> MarkG: is it https://tickets.openmrs.org/browse/HTML-277?
19:15:38 *** dkayiwa_ has joined #openmrs
19:15:47 *** dkayiwa has quit IRC
19:15:48 *** dkayiwa_ is now known as dkayiwa
19:16:35 <MarkG> rafa: nope...
19:16:51 *** dawn_ has quit IRC
19:16:53 <rafa> MarkG: what is the error then?
19:17:25 <MarkG> i lost it... i need to run it again... i will attach it to the ticket...
19:17:33 <rafa> MarkG: ok
19:18:01 <MarkG> but it is basically said that it can't initialize TestUtil... which it shouldn't being trying to initialize...
19:18:22 <rafa> MarkG: did you run clean?
19:18:58 <MarkG> rafa: pretty sure i ran a mvn clean package... which defaults to building against 1.6.4
19:19:13 <rafa> MarkG: strange I don't have this error.
19:19:28 <MarkG> rafa: i will try again in a bit...
19:19:37 <rafa> MarkG: ok, thx
19:30:40 *** james_regen has quit IRC
19:35:31 *** bryq has joined #openmrs
19:35:31 *** ChanServ sets mode: +v bryq
19:37:21 <MarkG> djazayeri: can my notifications be changed so i get a message when new HFE tickets are created? i took a look at notifications, but it doesn't look like i have rights to change them. feel free to change me to the project lead if you like...
19:38:30 <djazayeri> MarkG: I just made you the project lead
19:39:12 <MarkG> thanks
19:39:20 <djazayeri> looking at notifications, I see that Issue Created notifies Component Lead.
19:39:26 <djazayeri> hopefully that covers the project lead
19:39:42 <djazayeri> if you're not getting the notifications now, you can add that
19:52:13 <MarkG> is anyone else seeing the errors Rafal is seeing in this ticket? i'm not seeing them...
19:52:17 <MarkG> !html-277
19:52:18 <OpenMRSBot> MarkG: Error: "html-277" is not a valid command.
19:52:26 <MarkG> !ticket html-277
19:52:27 <OpenMRSBot> MarkG: [#HTML-277] PatientTagTest failing for 1.6 and 1.7 - OpenMRS JIRA - https://tickets.openmrs.org/browse/html-277
19:53:32 <MarkG> rafa: i just commented on: !ticket html-276
19:53:38 <MarkG> !ticket html-276
19:53:39 <OpenMRSBot> MarkG: [#HTML-276] Move tests to API - OpenMRS JIRA - https://tickets.openmrs.org/browse/html-276
19:54:36 <rafa> MarkG: ok, I ran maven via eclipse. I've just tested running it via command line and see the same error.
19:54:50 <rafa> MarkG: strange
19:55:13 <MarkG> rafa: do you still see html-277?
19:55:20 <rafa> MarkG: yes
19:55:35 <rafa> MarkG: plus initializaitonError
19:55:58 <rafa> MarkG: now 3 tests in error for me
19:56:06 <MarkG> rafa: strange... i only get the initialization error...
19:56:24 <rafa> MarkG: I don't get it why there are these differences
19:56:56 <rafa> MarkG: I'll look into that
19:57:05 *** slorenz has joined #openmrs
19:57:58 <MarkG> for html-276, it could be that junit is tied into eclipse in some way that you don't get when running at the command line... don't know about the other ones, though...
20:00:10 <rafa> MarkG: http://jira.codehaus.org/browse/SUREFIRE-482
20:00:42 <rafa> MarkG: seem like we just need to change the class name to eliminate the initializaitonError
20:01:18 <rafa> MarkG: it's a surefire bug
20:01:56 <MarkG> rafa: can you try that? the (somewhat) annoying thing is that the class is not named *Test, but Test*
20:02:26 <MarkG> rafa: they are Test utilities--but yet we can't include Test in the class name?
20:04:32 *** nribeka has quit IRC
20:04:33 <MarkG> rafa: took awhile to read through the comments on that surefire ticket...
20:05:11 *** wyclif has quit IRC
20:05:24 <rafa> MarkG: I've just changed the name to TUtil and it worked though I still have the two other errors.
20:05:59 *** wyclif has joined #openmrs
20:06:05 <rafa> MarkG: it's not the best name. do you have a better idea :)
20:06:48 <rafa> MarkG: or else we could say in pom to use the latest version of surefire wihtout this bug
20:07:02 <rafa> MarkG: I think it's what eclipse is enforcing
20:09:35 <rafa> MarkG: okay, adding surefire in version 2.11 fixes the problem.
20:09:36 *** slorenz has quit IRC
20:11:35 <MarkG> rafa: cool... so is it just a matter of changing the pom to make it uses surefire 2.11?
20:11:46 <rafa> MarkG: yes
20:11:52 <rafa> MarkG: I've just committed the change
20:12:11 <rafa> MarkG: the problem from html-277 is still there for me
20:12:30 <MarkG> rafa: thanks. don't know what is up with those other two errors... i will need to look into that more...
20:13:19 <rafa> MarkG: there are strange too. They run fine when I use eclipse Run as -> JUnit.
20:13:49 <rafa> MarkG: maybe we need to declare in pom to use JUnit in the latest version too :)
20:14:00 <rafa> MarkG: I'll try.
20:18:03 <rafa> MarkG: haha interestingly when I used the lastest version of JUnit I got 5 errors :D
20:18:16 *** nribeka has joined #openmrs
20:18:16 *** ChanServ sets mode: +v nribeka
20:18:33 <rafa> MarkG: so it's definitely caused by using different versions of JUnit
20:18:48 <MarkG> rafal: that's not good... at least we can set it explicitly...
20:19:07 <rafa> MarkG: yes, the trick is to figure out which version you're using :)
20:19:21 <MarkG> rafa: where is that configured?
20:19:51 <rafa> MarkG: I think it takes what is already available in your local repo
20:20:03 <rafa> MarkG: so if you go there you should be able to tell
20:20:31 <MarkG> rafa: it would also be interesting to know if it is a straight junit bug, or a junit bug overlapping with something unorthdox we are doing that we really shouldn't be doing...
20:20:52 <MarkG> rafa: i will check my local repo... is there a way we can specify what version of junit to use in the pom?
20:21:14 <rafa> MarkG: yes, just tell me which version to use
20:21:21 <rafa> MarkG: when I used the latest I got java.lang.NoClassDefFoundError: org/junit/Assume$AssumptionViolatedException
20:23:16 <MarkG> rafa: i guess the latest stable version would probably be the best... but using whatever one i am using would be easier since everything passes...
20:23:57 <rafa> MarkG: I'll see what we're using in core
20:24:28 <rafa> 4.8.1
20:24:32 <rafa> I'll try with this one
20:24:55 <MarkG> rafa: in my repo i have 3.8.1, 3.8.2, 4.0, 4.4, 4.8.1, & 4.8.2... :)
20:25:14 <rafa> MarkG: so it probably takes the latest
20:25:19 <MarkG> rafa: i'd say go with 4.8.1 or 4.8.2
20:25:25 <MarkG> yeah
21:00:56 *** nribeka has quit IRC
21:16:00 *** nribeka has joined #openmrs
21:16:00 *** ChanServ sets mode: +v nribeka
21:37:40 *** nribeka has quit IRC
21:59:02 *** wyclif has quit IRC
22:21:40 *** dkayiwa has quit IRC
22:49:40 *** MarkG has quit IRC
23:14:00 *** bryq has quit IRC
23:14:51 *** wyclif has joined #openmrs
23:19:38 *** rafa has quit IRC
23:20:41 *** robbyoconnor has quit IRC
23:21:01 *** robbyoconnor has joined #openmrs
23:21:01 *** ChanServ sets mode: +v robbyoconnor