00:06:49
|
*** misz has joined #openmrs
|
00:07:20
|
<misz> he
|
00:07:22
|
<misz> i
|
00:07:24
|
<misz> hi all
|
00:07:38
|
<misz> anyone around
|
00:07:50
|
<djazayeri> yes
|
00:08:06
|
<misz> am pretty new to openmrs
|
00:08:35
|
<djazayeri> welcome!
|
00:08:38
|
<misz> have followed guidelines on how to deploy it in eclipse but I am having problems
|
00:08:58
|
<misz> dont know where to begin as I googled and cant find a solution
|
00:09:42
|
<djazayeri> What's the error you're seeing?
|
00:09:56
|
<djazayeri> What instructions are you following, and how far did you get?
|
00:10:10
|
<misz> missing artifact com.sun:tools:jar:1.4.2
|
00:10:39
|
<djazayeri> are you using java 7?
|
00:11:07
|
<misz> nope, java 6 update 30
|
00:11:38
|
<djazayeri> okay, so you've checked out the code from svn, and you're trying to do an mvn clean install?
|
00:12:06
|
<djazayeri> (First off, you're intentionally building from source, right?
|
00:12:13
|
<misz> was following from here
|
00:12:13
|
<misz> https://wiki.openmrs.org/display/docs/Step+by+Step+Installation+for+Developers
|
00:12:14
|
<OpenMRSBot> <http://ln-s.net/8_PW> (at wiki.openmrs.org)
|
00:12:19
|
<djazayeri> I.e. you don't actually want to just download a war.
|
00:12:34
|
<djazayeri> ?
|
00:12:50
|
<misz> nope I dont want to just download a war
|
00:14:05
|
<djazayeri> Okay, soâ¦you checked out the code from svn (are you using eclipse?) and did mvn clean install?
|
00:14:22
|
<misz> yes
|
00:14:52
|
<djazayeri> can you paste the whole maven output into pastebin, and give a link here?
|
00:14:58
|
<misz> after I checked out the source code ended up having 7 errors, solved 2 remaining with 5
|
00:15:14
|
<djazayeri> You solved the two errors?
|
00:16:24
|
<misz> yes
|
00:16:37
|
<djazayeri> The trunk code shouldn't have any errors...
|
00:16:58
|
<misz> what do you want me to paste in the pastebin
|
00:17:54
|
<djazayeri> Let's go back a step, actually. What errors were you seeing when checking out trunk?
|
00:18:28
|
<misz> Description Resource Path Location Type Cannot load lifecycle mapping metadata for maven project MavenProject: org.openmrs.web:openmrs-web:1.10.0-SNAPSHOT @ C:\Documents and Settings\Research\workspace\openmrs\web\pom.xml Cause: Cannot parse version range: [0.3) pom.xml /openmrs-web line 1 Maven Project Build Lifecycle Mapping Problem
|
00:18:44
|
<misz> That's the first problem
|
00:19:03
|
<misz> Description Resource Path Location Type Cannot parse lifecycle mapping metadata for maven project MavenProject: org.openmrs.api:openmrs-api:1.10.0-SNAPSHOT @ C:\Documents and Settings\Research\workspace\openmrs\api\pom.xml Cause: Unrecognised tag: 'pluginExeution' (position: START_TAG seen ...<pluginExecutions>\r\n <pluginExeution>... @4:21) pom.xml /openmrs-api line 1 Maven Project Build Lifecycle Mapping Problem
|
00:19:18
|
<djazayeri> Also, to clarify: are you using eclipse? what plugin do you have? did you check out using SCM?
|
00:19:21
|
<misz> The second
|
00:19:35
|
<djazayeri> and what eclipse version?
|
00:19:40
|
<misz> I checked out using scm
|
00:21:33
|
<misz> its eclipse java indigo
|
00:22:22
|
<misz> 3.7
|
00:22:34
|
<djazayeri> and what maven plugin + version?
|
00:22:42
|
<misz> yes I checked out using scm
|
00:25:13
|
<misz> It appears like this... m2e - Maven Integration for Eclipse 1.0.100.20110804-1717
|
00:26:59
|
<misz> is that what you were asking?
|
00:27:39
|
*** rafa has quit IRC
|
00:30:09
|
<djazayeri> yes
|
00:30:14
|
<djazayeri> sorry, checking my own setup
|
00:30:19
|
<djazayeri> (my eclipse crashed)
|
00:30:21
|
<misz> okay
|
00:34:19
|
<djazayeri> still loading
|
00:34:26
|
<djazayeri> anyway, a clean checkout is not supposed to have errors.
|
00:34:42
|
<djazayeri> Also, were those errors shown in Eclipse, or in the consolve when you did the Run As Maven Build?
|
00:35:19
|
<misz> they were in console
|
00:35:45
|
<djazayeri> okay, so in eclipse (e.g. project explorer) it looks right, with no red Xs?
|
00:36:11
|
<misz> I have tried like 3 times and everytime ended with 7 errors
|
00:37:31
|
<misz> there are red X's in pom.xml for api, release-test, and web
|
00:43:17
|
<misz> I getting those errors when following this guideline so I dont know what I am missing
|
00:43:35
|
<misz> https://wiki.openmrs.org/display/docs/Step+by+Step+Installation+for+Developers
|
00:43:36
|
<OpenMRSBot> <http://ln-s.net/8_PW> (at wiki.openmrs.org)
|
00:43:59
|
<djazayeri> so, can you do a mvn clean install, and then pastebin the whole console output?
|
00:44:47
|
<misz> okay
|
00:44:51
|
*** Indu has joined #openmrs
|
00:46:56
|
*** Indu has left #openmrs
|
00:47:07
|
*** Indu has joined #openmrs
|
00:47:33
|
<Indu> Hi all, I am new to openMRS
|
00:47:35
|
<misz> http://pastebin.com/Wdkyxs4C
|
00:48:54
|
<Indu> I get an error "null Unable to complete the startup" when i install openmrs
|
00:54:13
|
<djazayeri> misz: the issue seems to be that there's a bad path somewhere
|
00:54:32
|
<djazayeri> I don't know if it's being constructed by OpenMRS, by Eclipse, or you set it in your sysem
|
00:54:57
|
<djazayeri> misz: C:\Program Files\Java\jre6C:\Program Files\Java\jdk1.6.0_30\lib\tools.jar
|
00:55:07
|
<djazayeri> those seem like they should have a ; or something in between
|
00:55:27
|
<djazayeri> Indu: is there any more info in your logs?
|
00:55:43
|
<misz> where is that error coming from
|
00:56:58
|
<misz> I havent noticed something like that....
|
00:57:42
|
<djazayeri> misz: I saw that in the pastebin you sent me
|
00:57:49
|
<djazayeri> unable to find something at that path
|
00:58:07
|
<misz> okay
|
01:02:53
|
<Indu> It is displayed in UI
|
01:04:24
|
<misz> @djazayeri...remaining with 3 errors now
|
01:04:35
|
<misz> solved that path issue
|
01:07:48
|
<misz> have you ever come across this
|
01:07:51
|
<misz> maven-dependency-plugin (goals "copy-dependencies", "unpack") is not supported by m2e.
|
01:07:56
|
<misz> error
|
01:20:12
|
<misz> hey djazayeri..are you still around?
|
01:33:50
|
<djazayeri> misz: hi
|
01:33:53
|
<djazayeri> I haven't seen that before
|
01:34:04
|
<djazayeri> is that a warning that you can ignore?
|
01:34:58
|
<misz> it's an error
|
01:35:08
|
<djazayeri> in the console?
|
01:35:27
|
<misz> yes
|
01:35:34
|
<djazayeri> Indu: is there a more complete stack trace?
|
01:36:43
|
<misz> what about this error then...
|
01:37:17
|
<misz> Cannot load lifecycle mapping metadata for maven project MavenProject: org.openmrs.web:openmrs-web:1.10.0-SNAPSHOT @ C:\Documents and Settings\Research\workspace\openmrs\web\pom.xml Cause: Cannot parse version range: [0.3)
|
01:38:41
|
<djazayeri> misz: what's the line that error message is coming from? can you open up pom.xml in the eclipse editor and see what line has a red x?
|
01:44:30
|
<misz> in a minute will let u know
|
01:49:06
|
<misz> it's in line 1 of openmrs-web
|
01:54:55
|
<misz> from its pom.xml file
|
01:55:21
|
<djazayeri> that seems odd
|
01:55:56
|
<djazayeri> misz: does "0.3" appear anywhere in that file?
|
01:59:27
|
<misz> yes
|
01:59:42
|
<djazayeri> misz: where? it doesn't in mine
|
02:01:03
|
<misz> had errors before and read from one forum
|
02:01:19
|
<misz> to include plugin management
|
02:01:39
|
<djazayeri> misz: I suggest that now that you've fixed the path problem you do an svn revert back to a clean checkout
|
02:05:16
|
<misz> did u managed to checkout openmrs with no errors at all?
|
02:11:09
|
<misz> can u plz let me know how u did it as I am struggling with them errors
|
02:11:39
|
<djazayeri> misz: the main build error was caused by a bad path, right?
|
02:11:48
|
<djazayeri> now that we've fixed that, a clean checkout should work, shouldn't it?
|
02:12:16
|
<misz> yap
|
02:13:04
|
<misz> but hv these 3 other errors which restricts project from building
|
02:13:26
|
<djazayeri> you said you modified the pom.xml by adding dependencyManagement.
|
02:13:30
|
<djazayeri> You should not do that.
|
02:14:04
|
<djazayeri> have you tried doing (1) svn revert (2) mvn clean install, since fixing the path?
|
02:16:16
|
<misz> how to perform svn revert, never done that b4
|
02:16:32
|
<djazayeri> in eclipse Team -> Revert
|
02:16:43
|
<djazayeri> e.g. right click on your openmrs-trunk project, and to Team -> Revert
|
02:17:31
|
<misz> i included those pluginmanagement some days ago not today
|
02:17:46
|
<djazayeri> misz: and it worked then?
|
02:18:36
|
<misz> some few things i were solved. like maven-java-formatter was solved
|
02:19:30
|
<djazayeri> I highly recommend doing a clean checkout, or reverting your current one. (If you don't want to lose the changes you made, then just do a new clean checkout)
|
02:21:59
|
<misz> okay
|
02:25:14
|
<misz> one things that i dont understnd
|
02:25:48
|
<misz> when i run as maven clean, it is successful, what does that mean?
|
02:26:13
|
<djazayeri> that means it successfully deleted the target directory.
|
02:26:28
|
<djazayeri> so it doesn't mean much
|
02:26:33
|
<misz> okay
|
02:28:41
|
<misz> http://pastebin.com/6kjYPua0
|
02:30:29
|
<misz> can u plz help me check this
|
02:54:01
|
*** Indu has quit IRC
|
04:02:22
|
*** upul` has joined #openmrs
|
04:02:34
|
*** ChanServ sets mode: +v upul`
|
04:56:27
|
*** morristic has joined #openmrs
|
04:57:27
|
*** morristic has quit IRC
|
05:40:53
|
*** morristic has joined #openmrs
|
05:55:38
|
*** morristic has quit IRC
|
06:27:45
|
*** misz has quit IRC
|
06:31:18
|
*** morristic has joined #openmrs
|
06:43:34
|
*** morristic has quit IRC
|
06:51:42
|
*** bryq has joined #openmrs
|
06:51:42
|
*** ChanServ sets mode: +v bryq
|
06:57:28
|
*** bryq has quit IRC
|
08:05:28
|
*** pusakat has joined #openmrs
|
08:10:48
|
*** pusakat has quit IRC
|
09:23:36
|
*** rafa has joined #openmrs
|
09:23:36
|
*** ChanServ sets mode: +v rafa
|
10:46:09
|
*** bryq has joined #openmrs
|
10:46:09
|
*** ChanServ sets mode: +v bryq
|
11:35:55
|
*** upul` has quit IRC
|
11:46:16
|
*** robbyoconnor has quit IRC
|
12:05:38
|
*** james_regen has joined #openmrs
|
12:05:38
|
*** ChanServ sets mode: +v james_regen
|
12:18:04
|
*** bryq has quit IRC
|
13:00:02
|
*** rafa has quit IRC
|
13:00:18
|
*** morristic has joined #openmrs
|
13:03:07
|
*** rafa has joined #openmrs
|
13:03:07
|
*** ChanServ sets mode: +v rafa
|
13:08:45
|
*** rafa has quit IRC
|
13:09:13
|
*** rafa has joined #openmrs
|
13:09:13
|
*** ChanServ sets mode: +v rafa
|
13:17:53
|
*** dkayiwa has joined #openmrs
|
13:45:55
|
*** morristic has quit IRC
|
13:49:33
|
*** downeym has joined #openmrs
|
13:49:33
|
*** ChanServ sets mode: +o downeym
|
13:49:33
|
*** OpenMRSBot sets mode: +o downeym
|
14:28:37
|
<rafa> hi downeym, did you get any reports about problems with our SVN?
|
14:28:42
|
<rafa> commit -m "IN PROGRESS - issue TRUNK-3041: Fix build on JDK7 ..." D:/workspace/org.openmrs-1.10.x.openmrs/tools/pom.xml
|
14:28:42
|
<rafa> Sending D:/workspace/org.openmrs-1.10.x.openmrs/tools/pom.xml
|
14:28:42
|
<rafa> RA layer request failed
|
14:28:42
|
<rafa> svn: Commit failed (details follow):
|
14:28:42
|
<rafa> svn: Server sent unexpected return value (403 Forbidden) in response to CHECKOUT request for '/!svn/ver/24379/openmrs/trunk/tools/pom.xml'
|
14:29:11
|
<rafa> downeym: seems like it's rejecting my credentials
|
14:29:25
|
<downeym> rafa: hmm ok, just now?
|
14:29:46
|
<rafa> downeym: yeah it has started about 10 minutes ago
|
14:29:53
|
<downeym> rafa: ok stand by
|
14:30:11
|
<rafa> downeym: ok thanks
|
14:30:29
|
*** wyclif has joined #openmrs
|
14:30:51
|
<downeym> rafa: please give it another try now?
|
14:31:35
|
<rafa> downeym: worked :D
|
14:31:40
|
<rafa> downeym: thanks a lot!
|
14:31:51
|
<downeym> rafa: hm, ok ⦠looks like the configuration is not as we were thinking :)
|
14:31:57
|
<downeym> rafa: btw happy birthday!
|
14:32:05
|
<rafa> downeym: thank you!
|
14:33:32
|
<downeym> rafa: when you have a chance pls try it once more time
|
14:34:10
|
<rafa> downeym: does it matter on which branch?
|
14:34:43
|
<downeym> rafa: no i don't think so
|
14:35:13
|
<rafa> downeym: failed again
|
14:35:22
|
<rafa> commit -m "Suppressing warnings." D:/workspace/org.openmrs-1.10.x.openmrs/tools/src/main/java/org/openmrs/tools/doclet/ShouldTaglet.java
|
14:35:22
|
<rafa> Sending D:/workspace/org.openmrs-1.10.x.openmrs/tools/src/main/java/org/openmrs/tools/doclet/ShouldTaglet.java
|
14:35:22
|
<rafa> RA layer request failed
|
14:35:22
|
<rafa> svn: Commit failed (details follow):
|
14:35:22
|
<rafa> svn: Server sent unexpected return value (403 Forbidden) in response to CHECKOUT request for '/!svn/ver/17342/openmrs/trunk/tools/src/main/java/org/openmrs/tools/doclet/ShouldTaglet.java'
|
14:36:00
|
<downeym> rafa: ok i revert it again :)
|
14:37:07
|
<rafa> downeym: ok
|
14:46:02
|
*** bryq has joined #openmrs
|
14:46:02
|
*** ChanServ sets mode: +v bryq
|
14:46:23
|
*** dkayiwa has quit IRC
|
15:05:47
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @johnnyderiggi: The OpenMRS command center at MoH Rwanda http://t.co/yGIGAn2j <http://twitter.com/OpenMRS/statuses/162911595633188865>
|
15:26:55
|
*** robbyoconnor has joined #openmrs
|
15:26:55
|
*** ChanServ sets mode: +v robbyoconnor
|
15:28:33
|
*** shaq34 has joined #openmrs
|
15:28:45
|
<shaq34> Hi there
|
15:28:46
|
<downeym> Hi shaq34 and welcome to the #openmrs IRC channel.
|
15:29:23
|
*** misz has joined #openmrs
|
15:29:27
|
<shaq34> I am trying to setup everything to be able to contribute to the project but I am having some problems
|
15:29:29
|
<downeym> Hi misz and welcome to the #openmrs IRC channel.
|
15:29:35
|
<misz> thanx
|
15:29:42
|
<downeym> shaq34: what kind of problems?
|
15:30:02
|
<shaq34> I have followed the guide https://wiki.openmrs.org/display/docs/Getting+Started+as+a+Developer
|
15:30:03
|
<OpenMRSBot> <http://ln-s.net/8bkO> (at wiki.openmrs.org)
|
15:30:35
|
<misz> http://pastebin.com/GwYw2GSa
|
15:30:49
|
<shaq34> I was able to add all the plugins but I am unable to run and the application
|
15:30:56
|
<misz> I am having problems after the checkout
|
15:31:54
|
<misz> http://pastebin.com/GwYw2GSa
|
15:32:54
|
<downeym> shaq34: what kind of error message are you getting?
|
15:35:10
|
<downeym> rafa wyclif - any ideas on misz error?
|
15:35:17
|
*** shaq34 has quit IRC
|
15:36:19
|
<rafa> misz: hi
|
15:36:31
|
<rafa> misz: you need to point JAVA_HOME to jdk not jre
|
15:36:37
|
<misz> rafa: hi
|
15:36:40
|
<misz> okay
|
15:37:07
|
<rafa> misz: it's what the message says actually :)
|
15:37:55
|
<misz> http://pastebin.com/GwYw2GSa
|
15:38:46
|
<misz> i dont have any errors + 2691 warnings
|
15:39:15
|
<rafa> misz: warnings are ok
|
15:39:51
|
<rafa> misz: so everything works fine now?
|
15:39:57
|
<misz> when I try to run, it stops here: Unable to locate the Javac Compiler in: C:\Program Files\Java\jre6\..\lib\tools.jar
|
15:40:37
|
<rafa> misz: you need to point JAVA_HOME system variable to jdk instead of jre
|
15:40:46
|
<wyclif> misz, which IDE are you using?
|
15:41:07
|
<misz> Eclipse
|
15:41:18
|
<misz> I have done that
|
15:41:46
|
<wyclif> and are you run the build from eclipse or commandline?
|
15:41:58
|
<misz> from eclipse
|
15:43:04
|
<rafa> misz: ok, then you need to go to Window -> Preferences -> Java -> Installed JREs and make sure that there's one pointing to jdk.
|
15:43:09
|
<wyclif> you probably need to edit you build path and point it to the jdk > 1.4
|
15:43:27
|
<wyclif> misz, i will leave rafa to help you out
|
15:43:38
|
<rafa> misz: and remove all the others
|
15:44:10
|
<wyclif> thanks rafa
|
15:44:16
|
*** robbyoconnor has quit IRC
|
15:44:34
|
<rafa> wyclif: ok
|
15:45:22
|
<misz> okay
|
15:47:26
|
<misz> am doing that now
|
15:49:24
|
<misz> thanx wyclif
|
15:50:33
|
*** rafa has quit IRC
|
15:58:18
|
*** rafa has joined #openmrs
|
15:58:18
|
*** ChanServ sets mode: +v rafa
|
15:58:40
|
<rafa> misz: sorry I got disconnected
|
15:59:38
|
<misz> okay
|
15:59:50
|
<rafa> misz: did it help?
|
16:00:37
|
<misz> I have done that change n now am building again (Run As->Maven build)
|
16:01:06
|
<misz> waiting for it to finish
|
16:10:34
|
*** calp has joined #openmrs
|
16:10:42
|
*** calp is now known as Guest21489
|
16:10:48
|
<downeym> Hi Guest21489 and welcome to the #openmrs IRC channel.
|
16:10:53
|
*** downeym has quit IRC
|
16:11:02
|
*** downeym has joined #openmrs
|
16:11:02
|
*** OpenMRSBot sets mode: +o downeym
|
16:11:02
|
*** ChanServ sets mode: +o downeym
|
16:18:01
|
<misz> hey rafa
|
16:18:14
|
<rafa> hi
|
16:18:16
|
<misz> still waiting for it to finish
|
16:19:10
|
<rafa> misz: are tests still running?
|
16:23:40
|
<misz> yes rafa
|
16:36:44
|
<misz> hey rafa
|
16:36:54
|
<rafa> hi
|
16:37:02
|
<misz> one quick question abt openmrs
|
16:37:57
|
<misz> is it possible to connect openmrs with gps devices so that to use location and other information to provide access
|
16:38:01
|
<misz> to the records
|
16:38:54
|
<rafa> misz: you would need to write a module for this task
|
16:40:12
|
<rafa> misz: I don't think anything like that exists already
|
16:40:51
|
<misz> okay
|
16:41:29
|
<misz> so that module will be part of the openmrs?
|
16:43:06
|
<misz> hey rafa....it has finished now
|
16:43:06
|
<rafa> misz: see https://wiki.openmrs.org/display/docs/For+Module+Developers
|
16:43:07
|
<OpenMRSBot> <http://ln-s.net/8cbr> (at wiki.openmrs.org)
|
16:47:52
|
<misz> thanx rafa
|
16:48:02
|
<rafa> misz: you're welcome
|
16:48:52
|
<misz> it has finished with success, how do I run it so that I will be able to have some windows or so?
|
16:50:23
|
<rafa> misz: see https://wiki.openmrs.org/display/docs/Using+the+M2Eclipse+Maven+Plugin+In+Eclipse
|
16:50:24
|
<OpenMRSBot> <http://ln-s.net/8c8D> (at wiki.openmrs.org)
|
16:50:46
|
<rafa> misz: look at How to Run Web Application
|
16:57:43
|
<misz> am doing that now, thanks again
|
17:05:55
|
<misz> rafa: does this mean I need to have jetty server
|
17:15:05
|
<rafa> misz: no just mysql
|
17:15:14
|
<rafa> misz: jetty will be downloaded for you automatically
|
17:17:30
|
<misz> okay
|
17:31:13
|
<misz> rafa
|
17:54:19
|
*** dawn_ has joined #openmrs
|
17:54:29
|
*** r0bby has joined #openmrs
|
17:54:29
|
*** ChanServ sets mode: +v r0bby
|
17:54:49
|
*** ChanServ sets mode: +v dawn_
|
17:57:46
|
*** misz has quit IRC
|
18:00:23
|
<dawn_> !scrumon dawn
|
18:00:23
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
|
18:00:33
|
<dawn_> djazayeri: rafa wyclif : hi
|
18:01:09
|
<rafa> hi dawn_
|
18:01:10
|
<wyclif> hi djazayeri
|
18:01:15
|
<djazayeri> hi all
|
18:01:17
|
<rafa> hi wyclif
|
18:01:20
|
<rafa> hi djazayeri :)
|
18:01:20
|
<djazayeri> I'm first?
|
18:01:28
|
<dawn_> Today's order: djazayeri , rafa , wy
|
18:01:37
|
<djazayeri> Thursday 26-Jan-2012
|
18:01:37
|
<djazayeri> * Developers call
|
18:01:37
|
<djazayeri> * Leadership call
|
18:01:37
|
<djazayeri> * Reviewed TRUNK-3029
|
18:01:37
|
<djazayeri> * Start working on TRUNK-3034 and sub-tasks (refactor CustomDatatype/Handler)
|
18:01:37
|
<djazayeri> ** Committed TRUNK-3035
|
18:01:37
|
<djazayeri> ** Committed TRUNK-3036
|
18:01:38
|
<djazayeri> ** Committed TRUNK-3038
|
18:01:39
|
<djazayeri> Friday 27-Jan-2012
|
18:01:39
|
<djazayeri> * Do TRUNK-3037
|
18:01:40
|
<djazayeri> * Do TRUNK-3039
|
18:01:40
|
<djazayeri> * ?
|
18:01:48
|
<djazayeri> no blockers
|
18:01:55
|
<rafa> Today:
|
18:01:55
|
<rafa> * TRUNK-2815: admin/concepts/localHeader.jsp incorrectly refers to privileges Add Concepts, Edit Concepts, and Delete Concepts
|
18:01:55
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2815
|
18:01:55
|
<rafa> * RESTWS-184: Allow HL7 messages to be submitted as-is via web service
|
18:01:55
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-184
|
18:01:55
|
<rafa> * TRUNK-2700: m2eclipse error: Plugin execution not covered by lifecycle configuration
|
18:01:55
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2700
|
18:01:56
|
<rafa> * TRUNK-3041: Fix build on JDK7
|
18:01:56
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3041
|
18:01:58
|
<rafa> Tomorrow:
|
18:01:58
|
<rafa> * Back to MDS!
|
18:01:58
|
<rafa> Blockers:
|
18:01:59
|
<rafa> * Still confused with RESTWS-190: Include a way to get set members and answers for concept
|
18:01:59
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-190
|
18:02:35
|
<djazayeri> rafa: let's discuss RESTWS-190 after Wyclif's update
|
18:02:58
|
<rafa> djazayeri: cool, I have 20 minutes
|
18:03:11
|
<dawn_> wyclif: you ready?
|
18:03:14
|
<wyclif> thursday:
|
18:03:14
|
<wyclif> * dev call
|
18:03:14
|
<wyclif> * TODOs for SMART-25 - Change how user apps are managed
|
18:03:14
|
<wyclif> * TODOs for SMART-38 - Use username rather than systemId when looking up SMART users
|
18:03:14
|
<wyclif> friday:
|
18:03:16
|
<wyclif> * Finish work on SMART-25 - Change how user apps are managed
|
18:03:20
|
<wyclif> * Release module
|
18:03:46
|
<wyclif> no blockers
|
18:04:09
|
<wyclif> djazayeri, did you get my update about SMART?
|
18:04:10
|
<dawn_> Discussion points: 1) RESTWS-190, 2) how this sprint will get done by monday
|
18:04:28
|
<dawn_> !scrumoff dawn
|
18:04:28
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
18:04:50
|
<djazayeri> wyclif, I got the update about SMART. I haven't followed closely, so if you say you'll release by Monday, that's good enough for me.
|
18:05:54
|
<djazayeri> First, about finishing up the sprint
|
18:05:55
|
<wyclif> djazayeri, what is your progress with the custom datatypes?
|
18:06:27
|
<djazayeri> wyclif: I intend to have them refactored based on our recent conversation by the end of today
|
18:06:48
|
<wyclif> djazayeri, ok
|
18:06:50
|
<dawn_> djazayeri: do you want to work with rafa first. I think rafal said he has 20min til he is done for the day
|
18:07:12
|
<djazayeri> just to clarify
|
18:07:18
|
<djazayeri> Our deliverables for this sprint are intended to be: release SMART 1.0, release RESTWS 1.0, release ATLAS 1.0
|
18:07:19
|
<wyclif> djazayeri, do we have to get RESTW-196 done in this sprint?
|
18:07:20
|
<djazayeri> right?
|
18:07:38
|
<wyclif> djazayeri, correct
|
18:08:04
|
<djazayeri> so, wyclif will take care of SMART
|
18:08:07
|
<djazayeri> and that's on track
|
18:08:29
|
<djazayeri> I don't know about ATLAS. Does anyone know if there's something we need to do (i.e. isn't up to Burke and Michael)?
|
18:09:25
|
<wyclif> djazayeri, burke said the only blocker is ATLAS-31
|
18:09:39
|
<djazayeri> And that's something one of us regular devs can do?
|
18:09:47
|
*** burke has joined #openmrs
|
18:09:47
|
*** ChanServ sets mode: +o burke
|
18:09:53
|
<wyclif> djazayeri, seems fairly simple
|
18:10:04
|
<wyclif> djazayeri, see the comments
|
18:10:29
|
<rafa> !ticket ATLAS-31
|
18:10:30
|
<OpenMRSBot> rafa: [#ATLAS-31] Implementation type shows as undefined within map - OpenMRS JIRA - https://tickets.openmrs.org/browse/ATLAS-31
|
18:10:46
|
<djazayeri> For RESTWS fixVersion=1.0 there are 3 unresolved tickets. Two are in post-commit review, so those just need review. There's also RESTWS-143 which Mykola Vorobey has added a patch for that I didn't notice him add, so I'll look at that.
|
18:11:10
|
<djazayeri> The ticket that Wyclif mentioned is not tagged as 1.0 (it's the one about a provider resource)
|
18:11:35
|
<djazayeri> I would vote for releasing RESTWS 1.0 without that, and we can add that for a 1.1 release simultaneous with OpenMRS 1.9.
|
18:11:55
|
<wyclif> djazayeri, ok
|
18:12:14
|
<djazayeri> Is ATLAS-31 for the module, or the server side?
|
18:12:14
|
<wyclif> djazayeri, let me remove it from the dashboard
|
18:12:30
|
<rafa> djazayeri: RESTWS-190 is for 1.0?
|
18:12:41
|
<djazayeri> wyclif: set its fixVersion to 1.1
|
18:12:45
|
<djazayeri> rafa: I think so
|
18:12:57
|
<djazayeri> rafa: rather it should be.
|
18:12:59
|
<djazayeri> so let's discuss that now.
|
18:13:08
|
<wyclif> djazayeri, i think module
|
18:13:22
|
<wyclif> djazayeri, the description says module
|
18:13:26
|
<djazayeri> okay
|
18:14:14
|
<djazayeri> rafa: so, for RESTWS-190, what Roger is really asking for is to be able to get a concept's answers and set members
|
18:14:15
|
<djazayeri> right?
|
18:14:15
|
<wyclif> djazayeri, who is in charge of releasing ATLAS?
|
18:14:26
|
<djazayeri> wyclif: nobody. :-)
|
18:14:27
|
<rafa> djazayeri: right
|
18:14:36
|
<djazayeri> wyclif: let's discuss that a bit later
|
18:14:42
|
<djazayeri> (since rafal's time is limited)
|
18:14:53
|
<wyclif> djazayeri, sure
|
18:14:56
|
<djazayeri> rafa: is that not currently done in the default and full reps?
|
18:15:07
|
<rafa> djazayeri: no
|
18:15:14
|
<rafa> djazayeri: it was commented out
|
18:15:40
|
<djazayeri> rafa: yeah, I see that in the file now
|
18:16:33
|
<rafa> djazayeri: but it wouldn't work anyway since there's no ConceptSetResource and ConceptAnswerResource
|
18:16:34
|
<djazayeri> so, the easiest fix would be to just include them (as REF) in both default and full
|
18:17:11
|
<djazayeri> rafa: can't we just override getProperty, or have an annotated getter for those, that will just return a concept?
|
18:17:16
|
<rafa> djazayeri: but refs to ConceptSet or Concept?
|
18:17:24
|
<djazayeri> refs to Concept
|
18:17:50
|
<rafa> djazayeri: it's not that easy
|
18:18:00
|
<djazayeri> Well, to return them is pretty easy (I think)
|
18:18:04
|
<djazayeri> though setting them may be harder
|
18:18:13
|
<rafa> djazayeri: correct
|
18:18:44
|
<djazayeri> for ConceptSet the only extra meaningful bit of info is the sortWeight
|
18:18:55
|
<djazayeri> but that can be implied by the order
|
18:19:40
|
<djazayeri> a concept's answers can actually be multiple things (for now concept or drug, but eventually more things)
|
18:20:19
|
<djazayeri> I think it's okay to return a list with mixed types in it
|
18:20:23
|
<djazayeri> for that one
|
18:20:26
|
<rafa> is it concept or/and drug?
|
18:20:30
|
<djazayeri> i.e. some elements are Concept and some or Drug
|
18:20:42
|
<djazayeri> rafa: I think it's xor
|
18:20:49
|
<rafa> ok
|
18:21:14
|
<djazayeri> Handling the POST is trickier
|
18:21:42
|
<djazayeri> Maybe it's okay to just handle the GET case in 1.0?
|
18:22:41
|
<rafa> djazayeri: yeah, I'm okay with that.
|
18:22:59
|
<djazayeri> rafa: okay, so do you know enough to do the GET case?
|
18:23:04
|
<rafa> djazayeri: for the POST I need save method to convey parent right?
|
18:23:05
|
<djazayeri> and create a new ticket for the POST?
|
18:23:12
|
<rafa> djazayeri: yes GET is fine
|
18:24:12
|
<rafa> djazayeri: so in subresource it should be save(Concept parent, Concept instance)
|
18:24:29
|
<rafa> djazayeri: for the POST to be possible
|
18:24:35
|
<djazayeri> rafa: I don't think these should be subresources
|
18:24:39
|
<djazayeri> they should be properties of the resource
|
18:25:03
|
<djazayeri> so if you want to change the order and/or add answers to a concept, you post to the URI of the question
|
18:25:48
|
<rafa> djazayeri: ok
|
18:26:25
|
<djazayeri> rafa: we'd need to write custom handling of the setMembers and answers properties, to convert from Concept, Drug, etc, deal with sortWeight, deal with whatever values are already in the list, etc.
|
18:26:42
|
<djazayeri> So, you can do the GET now, and save the POST for later?
|
18:26:44
|
<rafa> djazayeri: I see then I'll just create a new ticket for the POST
|
18:26:48
|
<djazayeri> I mean: write a ticket for the POST.
|
18:26:49
|
<djazayeri> yes
|
18:26:58
|
<rafa> djazayeri: cool thanks!
|
18:27:09
|
<djazayeri> rafa: ETA on doing the GET?
|
18:27:35
|
<djazayeri> not today, I assume.
|
18:27:37
|
<rafa> djazayeri: over the weekend :)
|
18:27:47
|
<djazayeri> okay, sounds good.
|
18:27:48
|
<rafa> djazayeri: I need to go now
|
18:27:56
|
*** magicaltrout has quit IRC
|
18:27:56
|
<djazayeri> bye, enjoy the evening and weekend
|
18:28:04
|
*** magicaltrout has joined #openmrs
|
18:28:10
|
<rafa> djazayeri: likewise! see you!
|
18:28:25
|
<djazayeri> dawn_, wyclif: I think we need to budget a day for someone to release the modules next week.
|
18:28:44
|
<djazayeri> ideally with ATLAS we'd give victor a chance to be the releaser. (He wrote it, right?)
|
18:28:51
|
<wyclif> djazayeri, modules, module
|
18:29:02
|
<wyclif> djazayeri, yes
|
18:29:12
|
*** rafa has quit IRC
|
18:29:36
|
<wyclif> djazayeri, dawn_ does anyone know Ben's return?
|
18:29:41
|
<djazayeri> I mean, it seems that none of RESTWS, SMART, or ATLAS will be ready to release today.
|
18:29:50
|
<djazayeri> But the code is basically done.
|
18:29:57
|
<djazayeri> I don't know Ben's schedule exactly, no.
|
18:30:14
|
<wyclif> djazayeri, ok
|
18:30:50
|
<wyclif> djazayeri, i plan to have released by monday
|
18:30:57
|
<djazayeri> wyclif: do you have time to do that ATLAS ticket today?
|
18:31:05
|
<djazayeri> I'd prefer to focus on the custom datatype stuff if I can
|
18:31:30
|
<wyclif> djazayeri, i can over the weekend
|
18:31:35
|
<djazayeri> okay
|
18:56:50
|
*** james_regen has left #openmrs
|
18:57:51
|
*** dawn_ has quit IRC
|
19:06:02
|
*** downeym has quit IRC
|
19:10:15
|
*** r0bby has quit IRC
|
19:10:27
|
*** r0bby has joined #openmrs
|
19:10:27
|
*** ChanServ sets mode: +v r0bby
|
19:29:40
|
*** r0bby has quit IRC
|
20:27:42
|
*** burke is now known as burke_away
|
20:37:09
|
*** burke_away is now known as burke
|
20:54:37
|
*** bryq has quit IRC
|
21:18:24
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Reporting Compatibility 1.5.5 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=reportingcompatibility&version=&1.5.5>
|
21:30:24
|
<wyclif> hi djazayeri
|
21:30:44
|
<djazayeri> hi wyclif
|
21:30:58
|
<wyclif> have you dropped a primary key before with liquibases
|
21:31:06
|
<djazayeri> wyclif: I haven't
|
21:31:08
|
<djazayeri> what are we dropping?
|
21:31:10
|
<wyclif> djazayeri, it doesn't seem to work
|
21:31:24
|
<wyclif> apparently, even mysql doesn't allow it
|
21:32:12
|
<wyclif> i adding a primary key column to a table that already has a composite primary key
|
21:32:56
|
<djazayeri> wyclif: maybe you can drop the pk constraint first?
|
21:51:41
|
*** burke_ has joined #openmrs
|
21:53:57
|
*** burke has quit IRC
|
21:55:39
|
<wyclif> djazayeri, and that what cant happen
|
21:56:57
|
<djazayeri> what
|
21:57:03
|
<djazayeri> what's the error message wyclif?
|
21:58:53
|
<wyclif> djazayeri, can't execute the query ALTER table....
|
21:59:09
|
<djazayeri> do you see the full alter table statement?
|
21:59:20
|
<djazayeri> the mysql docs say you can do alter table ⦠drop primary key
|
21:59:30
|
<wyclif> wait a sec
|
22:00:12
|
<wyclif> djazayeri, ALTER TABLE `openmrs`.`smartcontainer_user_hidden_app` DROP PRIMARY KEY,
|
22:00:12
|
<wyclif> ADD CONSTRAINT PRIMARY KEY (`user_id`, `smartcontainer_app_id`);
|
22:00:41
|
<djazayeri> and which is failing? the second?
|
22:01:00
|
<wyclif> thats one query
|
22:01:09
|
<wyclif> djazayeri, thats one query
|
22:01:26
|
<djazayeri> oh, odd
|
22:01:33
|
<djazayeri> why not split it into two?
|
22:01:47
|
<wyclif> djazayeri, it is generated by liquibase
|
22:02:11
|
<djazayeri> alternately, wyclif, since we haven't actually released SMART yet, just change the original liquibase to make the table right
|
22:03:12
|
<wyclif> djazayeri, i feel like am wasting time on this for nothing given that it is unreleased
|
22:03:12
|
<wyclif> ben is the one that doesn't like it
|
22:03:44
|
<djazayeri> wyclif: well, he's not here now. :-)
|
22:04:12
|
<djazayeri> it's an unreleased module, so please don't spend time trying to work around this.
|
22:04:27
|
<wyclif> djazayeri, apparently i have written many changesets that i ididnt have to because am avoiding editing them, and with the liquibase upgrade, it is becoming tricky to get the valid md5sum
|
22:05:30
|
<djazayeri> wyclif: indeed, you don't need to do that for unreleased modules, in general
|
22:05:42
|
<djazayeri> devs can figure out how to do the extra work to drop a table
|
22:06:25
|
<wyclif> djazayeri, that is what i used to do, you need to convince ben about this
|
22:07:34
|
<djazayeri> if it's just adding another md5sum, I agree that it's worth doing that
|
22:07:56
|
<djazayeri> but if it means doing extra work beyond that, it's not worth it.
|
22:08:15
|
<djazayeri> especially for a module where you're literally only costing the time of the 1-2 other module devs
|
22:08:26
|
<djazayeri> anyway, on this ticket, do it the easy way, and I'll discuss with ben later.
|
22:16:17
|
*** magicaltrout is now known as bugg_tb
|
22:16:42
|
*** bugg_tb is now known as magicaltrout
|
22:44:29
|
*** burke has joined #openmrs
|
22:44:29
|
*** ChanServ sets mode: +o burke
|
22:47:37
|
*** gbastien has joined #openmrs
|
22:48:32
|
*** burke_ has quit IRC
|
22:49:11
|
*** burke has quit IRC
|
22:53:35
|
*** gbastien has quit IRC
|
23:51:13
|
*** wyclif has quit IRC
|