| 00:00:48 | *** rafa has quit IRC |
| 00:37:54 | *** deadpool_ has quit IRC |
| 02:11:55 | *** wyclif has joined #openmrs |
| 03:37:54 | *** upul1 has joined #openmrs |
| 03:37:54 | *** ChanServ sets mode: +v upul1 |
| 04:30:57 | *** goutham has joined #openmrs |
| 04:59:27 | *** djazayeri has quit IRC |
| 05:53:54 | *** goutham has quit IRC |
| 06:03:48 | *** goutham has joined #openmrs |
| 06:14:43 | *** djazayeri has joined #openmrs |
| 06:14:43 | *** ChanServ sets mode: +o djazayeri |
| 06:55:06 | *** dkayiwa has joined #openmrs |
| 07:07:38 | *** dkayiwa has quit IRC |
| 07:10:11 | *** dkayiwa has joined #openmrs |
| 07:14:25 | *** mvorobey has joined #openmrs |
| 07:24:14 | *** dkayiwa has quit IRC |
| 07:24:45 | *** dkayiwa has joined #openmrs |
| 07:31:31 | *** opieng has joined #openmrs |
| 07:33:38 | *** opieng1 has quit IRC |
| 07:49:03 | *** opieng1 has joined #openmrs |
| 07:51:22 | *** opieng has quit IRC |
| 07:58:17 | *** bryq has joined #openmrs |
| 07:58:17 | *** ChanServ sets mode: +v bryq |
| 08:18:00 | *** Echidna_ has joined #openmrs |
| 08:18:00 | *** Echidna has quit IRC |
| 08:19:37 | *** sunbiz has joined #openmrs |
| 08:19:37 | *** ChanServ sets mode: +v sunbiz |
| 08:19:49 | *** dkayiwa has quit IRC |
| 08:27:47 | <mvorobey> hi sunbiz |
| 08:35:31 | <sunbiz> hey mvorobey |
| 08:35:50 | <sunbiz> thanks for the fix on atlas-29 |
| 08:36:16 | <mvorobey> sunbiz, can you tell me who is owner of atlas module so I can request partial commit access to it? |
| 08:38:26 | <sunbiz> do you not have commit access to the module?? |
| 08:39:03 | <sunbiz> I can commit it and mention you as the author... atleast that's how I have seen it to be done |
| 08:39:16 | <mvorobey> sunbiz, oh itsn't necessary :), I just committed it |
| 08:40:15 | <mvorobey> sunbiz: sorry for inconveniences, I just thought that I could not do it, but I could :) |
| 08:41:34 | <sunbiz> yes saw that... |
| 08:41:35 | <sunbiz> gr8 |
| 08:43:49 | <sunbiz> mvorobey: thanks for the fix |
| 08:45:08 | <mvorobey> sunbiz: you are welcome, we are taking part in the sprint together :) |
| 08:45:34 | <sunbiz> :) |
| 08:56:50 | *** sunbiz has quit IRC |
| 08:57:36 | *** dkayiwa has joined #openmrs |
| 09:02:30 | <dkayiwa> hi wyclif djazayeri |
| 09:04:30 | *** dkayiwa has quit IRC |
| 09:15:50 | *** morristic has joined #openmrs |
| 09:15:58 | *** morristic has quit IRC |
| 09:24:43 | *** rafa has joined #openmrs |
| 09:24:43 | *** ChanServ sets mode: +v rafa |
| 09:55:07 | *** dkayiwa has joined #openmrs |
| 10:12:55 | *** goutham has quit IRC |
| 10:38:55 | *** dkayiwa has quit IRC |
| 11:00:16 | *** morristic has joined #openmrs |
| 11:02:05 | <OpenMRSBot> Recent updates in the world of openmrs: Shazin Sadakath: A Comparison of CountDownLatch, CyclicBarrier and Semaphore <http://shazsterblog.blogspot.com/2011/12/comparison-of-countdownlatch.html> |
| 11:02:15 | *** sunbiz has joined #openmrs |
| 11:02:15 | *** ChanServ sets mode: +v sunbiz |
| 11:36:13 | *** upul1 has quit IRC |
| 11:48:56 | *** morristic has quit IRC |
| 12:00:54 | *** sunbiz1 has joined #openmrs |
| 12:01:39 | *** sunbiz has quit IRC |
| 12:31:28 | *** james_regen has joined #openmrs |
| 12:31:28 | *** ChanServ sets mode: +v james_regen |
| 13:58:15 | *** dkayiwa has joined #openmrs |
| 14:04:24 | *** flow has joined #openmrs |
| 14:30:45 | *** flow has quit IRC |
| 14:32:56 | <dkayiwa> hi rafa |
| 14:33:32 | <dkayiwa> hi wyclif |
| 14:34:08 | <rafa> hi dkayiwa |
| 14:34:36 | <dkayiwa> rafa: do the unit tests on your checked out trunk fail? |
| 14:35:37 | <rafa> dkayiwa: let me try |
| 14:35:47 | <dkayiwa> rafa: ok thanks |
| 14:38:29 | *** bwolfe has joined #openmrs |
| 14:38:29 | *** ChanServ sets mode: +o bwolfe |
| 14:39:12 | <rafa> dkayiwa: do you want me to update? |
| 14:39:19 | <dkayiwa> rafa: yes :) |
| 14:45:53 | <rafa> dkayiwa: still running... |
| 14:46:06 | <dkayiwa> rafa: ok thanks!!! :) |
| 14:48:47 | <rafa> dkayiwa: they're failing for web |
| 14:48:55 | <dkayiwa> ohhhhhhhh |
| 14:49:06 | <dkayiwa> rafa: strange for they do not fail on mine |
| 14:49:21 | <dkayiwa> rafa: do you mind pastebin for me the log? |
| 14:49:24 | <rafa> dkayiwa: clean install? |
| 14:49:30 | <dkayiwa> rafa: yes |
| 14:49:34 | <rafa> dkayiwa: sure |
| 14:49:42 | <dkayiwa> rafa: thanks :) |
| 14:49:49 | <rafa> dkayiwa: I mean I did clean install, did you? |
| 14:50:01 | <dkayiwa> rafa: yes i did |
| 14:50:10 | <dkayiwa> rafa: can you pastebin for me the log? |
| 14:50:21 | <rafa> http://pastebin.com/p6rRjXXX |
| 14:50:45 | <dkayiwa> rafa: thanks |
| 14:50:59 | <rafa> dkayiwa: seems like easy to fix |
| 14:51:15 | <rafa> dkayiwa: java.lang.IllegalStateException: Annotation-specified bean name 'schedulerFormValidator' for bean class [org.openmrs.scheduler.web.controller.SchedulerFormValidator] conflicts with existing, non-compatible bean definition of same name and class [org.openmrs.validator.SchedulerFormValidator] |
| 14:51:42 | <dkayiwa> rafa: aha |
| 14:52:07 | <dkayiwa> rafa: i wonder why it does not fail on mine |
| 14:52:25 | <rafa> dkayiwa: yeah that's strange |
| 14:57:50 | <dkayiwa> rafa: can you like fix and commit it in a minute? :) |
| 14:58:43 | <bwolfe> is "scheduler" provided by a module? |
| 14:59:28 | <dkayiwa> bwolfe: org.openmrs.validator.SchedulerFormValidator is in core |
| 14:59:39 | <bwolfe> right, but is the other one? |
| 14:59:47 | <bwolfe> org.openmrs.scheduler.web.controller.SchedulerFormValidator |
| 15:00:10 | <dkayiwa> bwolfe: oh i see. your questions makes alot of sense to me now :) |
| 15:02:23 | <dkayiwa> bwolfe: am trying to figure why the unit tests pass on my computer but still fail on CI |
| 15:02:45 | <dkayiwa> bwolfe: i though the commit i made should have fixed them |
| 15:04:51 | *** bwolfe has quit IRC |
| 15:05:20 | *** bwolfe has joined #openmrs |
| 15:05:20 | *** ChanServ sets mode: +o bwolfe |
| 15:05:34 | <dkayiwa> rafa: do you think the duplicate could be coming from a module you have installed? |
| 15:07:08 | <rafa> dkayiwa: no way. I don't install any module to run with unit tests :) |
| 15:07:21 | <dkayiwa> rafa: :D |
| 15:07:26 | <rafa> dkayiwa: both classes are in core |
| 15:07:38 | <dkayiwa> rafa: now this is getting more interesting!!! :) |
| 15:07:41 | <rafa> dkayiwa: the one in web is deprecated and extends the one from api |
| 15:08:13 | <rafa> dkayiwa: we need to find why spring tries to create two beans instead of one |
| 15:08:37 | <dkayiwa> rafa: and also why it does not do it on my laptop :) |
| 15:09:21 | <rafa> dkayiwa: that is what YOU need to figure out. I'll deal with the simple case ;) |
| 15:09:37 | <dkayiwa> rafa: :D |
| 15:09:53 | <rafa> dkayiwa: I'll just rename one of the beans and let them both exist |
| 15:10:09 | <dkayiwa> rafa: ok, then tell me if the unit tests pass |
| 15:13:32 | <bwolfe> you can either do that or use ids on the annotations instead of letting it go by object name |
| 15:14:25 | <rafa> bwolfe: yeah annotations is what I meant |
| 15:18:50 | <rafa> dkayiwa: it helped |
| 15:19:25 | <dkayiwa> rafa: meaning??? |
| 15:20:02 | <rafa> dkayiwa: meaning renaming org.openmrs.scheduler.web.controller.SchedulerFormValidator from schedulerFormValidator to webSchedulerFormValidator |
| 15:20:34 | <dkayiwa> rafa: oh i see. i had thought it helped to make the unit tests pass :) |
| 15:20:41 | <rafa> dkayiwa: I'm still trying to understand why spring creates these two beans |
| 15:20:51 | <rafa> dkayiwa: yes it helped unit tests |
| 15:20:56 | <rafa> dkayiwa: they pass |
| 15:21:05 | <dkayiwa> rafa: and more so, on only your laptop :) |
| 15:21:26 | <rafa> dkayiwa: I didn't commit yet |
| 15:23:21 | <rafa> dkayiwa: bwolfe: does @Handler creates beans? |
| 15:23:57 | <bwolfe> I don't think so |
| 15:24:12 | <bwolfe> beans are only made in the xml files or via annotations |
| 15:24:31 | <dkayiwa> rafa: do you mind comitting |
| 15:25:03 | <rafa> dkayiwa: as soon as I figure out what is the real cause |
| 15:26:28 | <rafa> bwolfe: that is even more strange because it is declared with yet another name <bean id="taskValidator" class="org.openmrs.validator.SchedulerFormValidator" /> |
| 15:27:52 | <bwolfe> I think its the class name that is throwing it if only one of htem has an id |
| 15:28:55 | *** dkayiwa has quit IRC |
| 15:30:50 | <rafa> bwolfe: that might be the case, but it's still unclear to me why the org.openmrs.scheduler.web.controller.SchedulerFormValidator bean is even created |
| 15:35:13 | *** dkayiwa has joined #openmrs |
| 15:39:43 | <rafa> dkayiwa: I'll commit, what ticket # is that? |
| 15:40:15 | <dkayiwa> thanks rafa TRUNK-3002 |
| 15:40:25 | <bwolfe> https://tickets.openmrs.org/browse/TRUNK-3002 |
| 15:40:29 | <bwolfe> shoot, dkayiwa won |
| 15:41:09 | <dkayiwa> :D |
| 15:43:43 | <rafa> cool CI running :D fingers crossed |
| 15:44:00 | <dkayiwa> :) |
| 15:47:57 | <dkayiwa> hi wyclif |
| 15:49:03 | <wyclif> hi dk |
| 15:49:09 | <wyclif> hi dkayiwa |
| 15:49:41 | <dkayiwa> wyclif: can i continue with smart container tickets? |
| 15:49:53 | <bwolfe> dkayiwa, would be better to do rest tickets |
| 15:50:03 | <dkayiwa> bwolfe: like which one? |
| 15:50:09 | <bwolfe> any of them in the sprint. :-) |
| 15:50:17 | * bwolfe hasn't looked at the dashboard yet today though... |
| 15:50:32 | <dkayiwa> bwolfe: only one left (and a non essential one) :) |
| 15:52:13 | <dkayiwa> rafa: :D CI |
| 15:52:41 | <bwolfe> dkayiwa, do the rest one anyway |
| 15:52:49 | <bwolfe> and/or review other people's code in this sprint |
| 15:52:49 | <wyclif> dkayiwa, bwolfe is right, work on REST WS tickets |
| 15:52:57 | <rafa> dkayiwa: good :D |
| 15:53:12 | <dkayiwa> rafa: thanks :) |
| 15:53:36 | <rafa> dkayiwa: np |
| 15:53:51 | <dkayiwa> bwolfe: wyclif would need some more info about it. RESTWS-159 |
| 15:53:54 | <bwolfe> rafa++ |
| 15:54:01 | <bwolfe> !ticket RESTWS-159 |
| 15:54:02 | <OpenMRSBot> bwolfe: [#RESTWS-159] Migration pathway from old REST module - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-159 |
| 15:54:12 | <bwolfe> dkayiwa, like what? |
| 15:54:33 | <wyclif> dkayiwa, there is RESTWS-180 |
| 15:55:16 | <dkayiwa> !ticket RESTWS-180 |
| 15:55:17 | <OpenMRSBot> dkayiwa: [#RESTWS-180] Modify WSDoc annotation to support links - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-180 |
| 15:56:27 | <wyclif> dkayiwa, though it seems not essential to me |
| 15:57:07 | <dkayiwa> wyclif: which of the two is then more non essential? :) |
| 15:58:35 | <wyclif> RESTWS-180 just deosn't seem clear so i say it could be more essential if roger gave more info |
| 16:00:12 | <dkayiwa> wyclif: i seem to be understanding him (Roger) now after his response comments |
| 16:00:57 | <dkayiwa> wyclif: bwolfe but the question is, should i implements all that he suggests? and more? |
| 16:02:09 | <dkayiwa> bwolfe wyclif: in otherwards, can we all agree on the scope of which more i should implement? |
| 16:02:34 | <bwolfe> dkayiwa, add things to the docs that exists |
| 16:02:42 | <bwolfe> the ?tree stuff doesn't exist, so don't add that. :-) |
| 16:02:59 | <bwolfe> the ?patient=121343423 type of links would be helpful to have in the docs |
| 16:03:17 | <bwolfe> the "BTW, is there a way for a module which exposes REST calls to get documented by WSDoc?" comment is another ticket, IIRC |
| 16:03:22 | <bwolfe> did you ever implement that? |
| 16:04:25 | <dkayiwa> bwolfe: are you discussing RESTWS-180 or RESTWS-159 :) |
| 16:05:36 | <wyclif> RESTWS-180 |
| 16:06:43 | <bwolfe> 180 |
| 16:06:48 | <dkayiwa> ok |
| 16:06:51 | <bwolfe> gotta grab lunch |
| 16:06:51 | <bwolfe> bbl |
| 16:31:33 | <dkayiwa> wyclif: are you having lunch or we can talk now? |
| 16:31:53 | <wyclif> we can talk |
| 16:32:11 | <dkayiwa> wyclif: Modify WSDoc annotation to support links - RESTWS-180 |
| 16:32:33 | <dkayiwa> wyclif: is the task simply to Modify WSDoc annotation to support links? |
| 16:35:58 | <wyclif> dkayiwa, i haven't looked at the description of that ticket that well |
| 16:36:21 | <mvorobey> hi bwolfe |
| 16:38:19 | <wyclif> dkayiwa, did you address the todo for SMART-38 |
| 16:39:18 | <dkayiwa> wyclif: from the after scrum discussions yesterday, we were told to halt the smart container work we were doing :) |
| 16:39:24 | <dkayiwa> wyclif: so i did not |
| 16:44:04 | <wyclif> dkayiwa, that is ticket is of high priority\ |
| 16:44:32 | <wyclif> dkayiwa, beccause there is bug introduced |
| 16:44:51 | <dkayiwa> wyclif: so do you suggest i work on it before i resume the web service tickets? |
| 16:45:20 | <wyclif> dkayiwa, we only bumped low priority ticket o the SMART tickets if high priority need to get finished |
| 16:45:37 | <dkayiwa> wyclif: ok let me do that now |
| 16:45:43 | <wyclif> the remaining fixes should take you like 5min |
| 16:45:50 | <dkayiwa> ok |
| 16:46:35 | <wyclif> dkayiwa, just make sure when you call user.getUsername it is not null, if it is, then call getSystemId |
| 16:46:54 | <dkayiwa> wyclif: ok |
| 17:17:18 | <sunbiz1> bwolfe djazayeri: should we also have a Provider resource?? |
| 17:17:33 | <djazayeri> sunbiz1: we'll need this as 1.9 is released |
| 17:17:33 | <sunbiz1> this will give the list of all providers in the system |
| 17:17:43 | <sunbiz1> yes... thats the problem |
| 17:18:01 | <djazayeri> we'll need another module for this... |
| 17:18:19 | <sunbiz1> mayb we do ClassNotFound check |
| 17:18:21 | <sunbiz1> ?? |
| 17:19:39 | <djazayeri> sunbiz1: we can try that |
| 17:20:14 | <sunbiz1> so should I create a ticket to do that... and have it part of the 1.0 release of the module?? |
| 17:42:26 | *** sunbiz1 has left #openmrs |
| 17:42:55 | *** sunbiz has joined #openmrs |
| 17:42:55 | *** ChanServ sets mode: +v sunbiz |
| 17:45:33 | *** jriley has joined #openmrs |
| 18:01:13 | *** sunbiz1 has joined #openmrs |
| 18:01:28 | *** sunbiz1 has left #openmrs |
| 18:01:48 | *** sunbiz1 has joined #openmrs |
| 18:02:18 | *** sunbiz has quit IRC |
| 18:06:36 | <bwolfe> dkayiwa, you should be able to finsih up https://tickets.openmrs.org/browse/TRUNK-2998 |
| 18:07:41 | <dkayiwa> bwolfe: finish by simply closing it? :) |
| 18:07:56 | <bwolfe> confirm wyclif's question, then close, yes. :-) |
| 18:08:04 | <dkayiwa> bwolfe: ok :) |
| 18:12:15 | *** sunbiz1 has left #openmrs |
| 18:12:34 | *** sunbiz has joined #openmrs |
| 18:12:34 | *** ChanServ sets mode: +v sunbiz |
| 18:13:56 | *** mvorobey has quit IRC |
| 18:16:28 | <dkayiwa> bwolfe: do we have people who are seriously using the old REST module? RESTWS-159 |
| 18:17:08 | <djazayeri> dkayiwa: if your real question is "how good do the upgrade-from-REST-to-RESTWS docs need to be?", the answer is "not that good" |
| 18:17:17 | <bwolfe> dkayiwa, a few |
| 18:17:34 | <bwolfe> dkayiwa, djazayeri, there aren't that many functions in the old REST module, so it should be easy. :-) |
| 18:17:39 | <dkayiwa> bwolfe: i have never used it. so looks like before i can write a meaningful migration guide, i need to first learn/use it |
| 18:17:41 | <bwolfe> it was not feature rich |
| 18:17:49 | <bwolfe> it wasn't even feature-almost-rich |
| 18:17:52 | <bwolfe> it was feature poor. :-) |
| 18:18:08 | <djazayeri> bwolfe: is there someone who has used the REST module, who might write or collaborate on those docs? |
| 18:18:14 | <bwolfe> dkayiwa, just read the REST wiki page and run those queries. You'll see what the calls and requests are. :-) |
| 18:18:23 | <djazayeri> okay |
| 18:18:26 | <dkayiwa> :) |
| 18:18:28 | <bwolfe> djazayeri, ampath uses (used?) it ? |
| 18:18:44 | <djazayeri> dkayiwa: you should spend less than a day on it. (bwolfe, do you agree?) |
| 18:18:47 | <bwolfe> I'm blanking on who the other group was |
| 18:18:55 | <bwolfe> yes, definitely |
| 18:20:02 | <dkayiwa> bwolfe: djazayeri any comments for RESTWS-180 ? |
| 18:21:02 | <bwolfe> !ticket RESTWS-180 |
| 18:21:03 | <OpenMRSBot> bwolfe: [#RESTWS-180] Modify WSDoc annotation to support links - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-180 |
| 18:21:58 | <bwolfe> dkayiwa, is the wsdoc stuff used for what is generated on the "help" jsp page insdie the module in openmrs? |
| 18:21:58 | <djazayeri> dkayiwa: I don't actually know how the docs are generated |
| 18:22:21 | <djazayeri> I think Roger's point is that we need to be able to document all accessible methods |
| 18:22:43 | <dkayiwa> djazayeri: which we currently do |
| 18:22:52 | <dkayiwa> djazayeri: is there any method we miss out? |
| 18:23:07 | <djazayeri> dkayiwa: are those pulled from the actual annotated methods on the controller? |
| 18:23:42 | <dkayiwa> djazayeri: yes |
| 18:24:17 | <djazayeri> why does the class-level javadoc on EncounterResource say: |
| 18:24:17 | <djazayeri> * @postDocumentation Post here to do something |
| 18:24:17 | <djazayeri> * asdf |
| 18:24:17 | <djazayeri> * asdf |
| 18:24:17 | <djazayeri> * sadf |
| 18:24:17 | <djazayeri> * sadf |
| 18:24:18 | <djazayeri> ? |
| 18:25:10 | <djazayeri> dkayiwa: so, I think the thing to do is to change the way the urls are formatted to be clearer, and possible allow some method-level javadoc (or method arg level comments) to provide more info |
| 18:25:16 | <djazayeri> e.g. it should say: |
| 18:25:51 | <djazayeri> GET /ws/rest/v1/encounter?patient=[patientUuid] Fetch all ⦠|
| 18:26:37 | <dkayiwa> djazayeri: we scan both the controllers and resource classes |
| 18:26:59 | <dkayiwa> djazayeri: the controllers give us the urls while resource classes give us the operations |
| 18:27:21 | <djazayeri> dkayiwa: my point is that we should be clearer in the way we present thing about how the params should be used |
| 18:27:31 | <dkayiwa> djazayeri: ok |
| 18:27:38 | <djazayeri> "/ws/rest/v1/encounter?patient" isn't taht clear to me |
| 18:27:47 | <dkayiwa> djazayeri: ok |
| 18:28:14 | <djazayeri> and I agree with roger that we shouldn't use " (e.g. in encounter/"uuid") |
| 18:28:30 | <djazayeri> otherwise I agree that there doesn't seem to be much to do. |
| 18:28:34 | <dkayiwa> djazayeri: ok |
| 18:29:23 | <djazayeri> Also, get rid of that bad javadoc in encounterresource.java. :-) |
| 18:29:36 | <dkayiwa> djazayeri: ok :) |
| 18:31:04 | *** james_regen has quit IRC |
| 18:33:39 | <sunbiz> djazayeri bwolfe : can some1 please check RESTWS-192 |
| 18:33:53 | <sunbiz> the example I posted works fine for authentication using Cookies |
| 18:35:12 | <sunbiz> so it works fine... we have also used this through the browser and JavaScript and it works fine... |
| 18:35:15 | <bwolfe> !ticket RESTWS-192 |
| 18:35:16 | <OpenMRSBot> bwolfe: [#RESTWS-192] Using jsessionid authentication doesnt work - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-192 |
| 18:35:39 | <sunbiz> should it be closed as WORKSFORME?? |
| 18:44:30 | <djazayeri> sunbiz: I read through that ticket yesterday, and I'm fine closing as works-for-me (I think it's now called "cannot reproduce") |
| 18:45:46 | *** jriley has left #openmrs |
| 18:48:28 | <sunbiz> djazayeri: okies :) |
| 18:48:51 | <bwolfe> sunbiz, I don't see any diff with what nelson is doing and what your code has |
| 18:49:36 | <sunbiz> hmmm... I agree |
| 18:50:05 | <sunbiz> I've tried with the android 2.1 emulator... and it doesnt authenticate |
| 18:50:10 | <sunbiz> so... mayb its an android thingy |
| 18:50:53 | <djazayeri> that seems worth investigating further |
| 18:51:06 | <djazayeri> perhaps comment to that effect on the ticket, and leave it open? |
| 18:51:28 | *** dawn_ has joined #openmrs |
| 18:51:53 | <djazayeri> or investigate it further now. :-) |
| 18:52:00 | <sunbiz> but it works through curl |
| 18:52:19 | <sunbiz> when I send cookies through curl it works |
| 19:00:53 | <dawn_> !scrumon dawn |
| 19:00:53 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 19:01:07 | <dawn_> bwolfe: djazayeri rafa , dkayiwa wyclif : hi :) |
| 19:01:17 | <bwolfe> hi dawn |
| 19:01:19 | <dawn_> Today's order: bwolfe , djazayeri , rafa , dkayiwa , wyclif |
| 19:01:26 | <rafa> hi |
| 19:02:02 | <djazayeri> hi |
| 19:03:13 | <dawn_> bwolfe: you ready? |
| 19:03:31 | <bwolfe> mine's pretty boring |
| 19:03:34 | <bwolfe> today: |
| 19:03:34 | <bwolfe> lots of emails (and still more to go) |
| 19:03:34 | <bwolfe> fixed 1.6.4 logic |
| 19:03:34 | <bwolfe> commented on sprint tickets |
| 19:03:34 | <bwolfe> review tickets |
| 19:03:34 | <bwolfe> review more tickets |
| 19:03:36 | <bwolfe> set up design call for tmrw |
| 19:03:37 | <wyclif> hi |
| 19:03:58 | * bwolfe still has to resist alt-tabbing... |
| 19:04:24 | <djazayeri> Monday 23-Jan-2012 |
| 19:04:24 | <djazayeri> * Catch up on emails |
| 19:04:24 | <djazayeri> * Fixed RESTWS-193 (getAll GET requests do not work) (required a marathon debugging session) |
| 19:04:24 | <djazayeri> * follow up on Lara's reported failure to use upgrade scripts |
| 19:04:24 | <djazayeri> Tuesday 24-Jan-2012 |
| 19:04:24 | <djazayeri> * Review the release testing helper code that Lara ran into OOM on |
| 19:04:25 | <djazayeri> * Review form resource code (which Jeremy is about to check in) |
| 19:04:25 | <djazayeri> * Check whether REST WS .../catalog works. (It didn't for me yesterday) |
| 19:04:26 | <djazayeri> * Talk to Mark G about next sprint |
| 19:04:26 | <djazayeri> * Prep for University call tomorrow (importing data into OpenMRS) |
| 19:04:42 | <djazayeri> no blockers |
| 19:05:03 | <rafa> Today: |
| 19:05:03 | <rafa> * Helped with https://tickets.openmrs.org/browse/TRUNK-3002 |
| 19:05:03 | <rafa> * Worked on RESTWS-195: Doing a GET on a resource that doesn't exist gives a 404 with HTML body |
| 19:05:03 | <rafa> https://tickets.openmrs.org/browse/RESTWS-195 |
| 19:05:03 | <rafa> * Worked on RESTWS-190: Include a way to get set members and answers for concept |
| 19:05:03 | <rafa> https://tickets.openmrs.org/browse/RESTWS-190 |
| 19:05:03 | <rafa> Tomorrow: |
| 19:05:04 | <rafa> * Continue with REST tickets |
| 19:05:04 | <rafa> Blockers: JUnits in RESTWS don't work for me in Eclipse which slows me down. |
| 19:05:10 | <bwolfe> roger complained about /catalog too, create a ticket for it djazayeri |
| 19:05:20 | <djazayeri> bwolfe: yup, i'll test and create a ticket. |
| 19:05:30 | <dkayiwa> Committed the first fix for unit tests that failed after a commit for: Validation logic for Openmrs Objects in controllers - TRUNK-3002 |
| 19:05:31 | <dkayiwa> Committed response to review comments for: SmartUserService should fetch users by uuid - SMART-38 |
| 19:05:31 | <dkayiwa> Tested and closed: Fonts on the OpenMRS Installation Wizard not consistent - TRUNK-2998 |
| 19:05:31 | <dkayiwa> Now working on: Modify WSDoc annotation to support links - RESTWS-180 |
| 19:05:31 | <dkayiwa> No Blockers |
| 19:05:53 | <wyclif> yesterday: |
| 19:05:53 | <wyclif> * Code review for - TRUNK-2998 SMART-38 worked on by daniel |
| 19:05:53 | <wyclif> * RG meeting |
| 19:05:53 | <wyclif> * SMART-23 - Improved handling of errors when required concept mappings are not found |
| 19:05:53 | <wyclif> * Revisited SMART-41 - Improved handling of SMART app concept sources for required mappings |
| 19:05:54 | <wyclif> Today: |
| 19:05:56 | <wyclif> * code review and going through tickets on sprint dashboard |
| 19:05:58 | <wyclif> * Fix why SMART module event listeners are not registered at start up |
| 19:06:00 | <wyclif> * Update SMART documentation |
| 19:06:02 | <wyclif> * Test the new SMART javascript library Josh emailed to me if it works, i yes i apply it |
| 19:06:04 | <wyclif> * If everything runs fine, i release SMART container module |
| 19:06:06 | <wyclif> Blockers: Module global property listeners cause OpenMRS to fail to start |
| 19:06:28 | <djazayeri> rafa: RESTWS-195 is relatively low-priority, so try to find a solution that doesn't involve a lot of work. |
| 19:06:51 | <rafa> djazayeri: ok |
| 19:07:05 | <bwolfe> sunbiz, you want to report as well? |
| 19:07:41 | <wyclif> has anyone been able to successfully register module global property listeners? |
| 19:08:07 | <rafa> anyone else having troubles with junits in eclipse for restws? :) |
| 19:08:10 | <djazayeri> wyclif: I haven't tried |
| 19:08:18 | <bwolfe> wyclif, I worked on that a little bit ago |
| 19:08:22 | <djazayeri> rafa: I haven't tried that eitehr. |
| 19:08:33 | <bwolfe> wyclif, the MDS module registers one |
| 19:08:47 | <dawn_> !scrumoff dawn |
| 19:08:47 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 19:08:53 | <sunbiz> TRUNK-288 |
| 19:09:01 | <sunbiz> ohhh... I was starting to report!! |
| 19:09:02 | <sunbiz> :( |
| 19:09:06 | <sunbiz> but it ended!! |
| 19:09:07 | <djazayeri> sunbiz: go ahead anyway. :-) |
| 19:09:12 | <dawn_> lol! go for it sunbiz |
| 19:09:13 | <djazayeri> we haven't left yet |
| 19:09:22 | <dkayiwa> :D |
| 19:09:27 | <bwolfe> sunbiz, so close! |
| 19:09:30 | <bwolfe> :-) |
| 19:09:32 | <sunbiz> TRUNK-288, Im looking at now coz my webservice locks me out on a test |
| 19:09:48 | <djazayeri> !ticket trunk-288 |
| 19:09:49 | <OpenMRSBot> djazayeri: [#TRUNK-288] Option to configure how many incorrect password attempts before lock out - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-288 |
| 19:09:59 | <sunbiz> reviewed ATLAS-29 |
| 19:10:33 | <bwolfe> hacked by your own ws test sunbiz? :-) |
| 19:10:35 | <sunbiz> some other webservice tickets closed RESTWS-186 |
| 19:10:37 | <sunbiz> no blockers |
| 19:10:41 | <sunbiz> :P |
| 19:10:47 | <dawn_> thanks, sunbiz :D |
| 19:11:05 | <sunbiz> u r welcome dawn_ |
| 19:11:11 | <bwolfe> discussion point: rafa, ws tests not running for you ? |
| 19:11:17 | <bwolfe> how are you running them? |
| 19:11:33 | <bwolfe> they're working in ci. :-) |
| 19:11:54 | <dkayiwa> they work for me even in eclipse :) |
| 19:12:19 | <sunbiz> BTW dawn_ has the scrum meeting ever last 15min?? |
| 19:12:26 | <sunbiz> like it said in the start?? |
| 19:12:43 | <dkayiwa> less :) |
| 19:12:43 | <sunbiz> WORKSFORME in Netbeans!! :P |
| 19:12:44 | <djazayeri> sunbiz: they used to all go for like 45 minutes |
| 19:13:05 | <sunbiz> how do you guys paste all that together |
| 19:13:05 | <dawn_> sunbiz: they used to be 45min or an hour :D |
| 19:13:10 | <rafa> bwolfe: the problem is only in eclipse when you right click ;) |
| 19:13:11 | <djazayeri> rafa: for me it works in eclipse (at least doing run as -> junit test on omod/src/text/java) |
| 19:13:24 | <sunbiz> is there an etherpad somewhere to keep notes :) and just pasted here?+ |
| 19:13:42 | <djazayeri> sunbiz: I use textedit |
| 19:13:48 | <sunbiz> okies |
| 19:14:13 | <djazayeri> rafa: maybe an eclipse version issue? maybe you need to do project -> clean? |
| 19:14:30 | <djazayeri> wyclif: about your blocker... |
| 19:15:05 | <rafa> djazayeri: they all fail with Failed to load ApplicationContext :/ |
| 19:15:11 | <wyclif> djazayeri, i made a change and testing it |
| 19:15:31 | <djazayeri> rafa: is the stack trace helpful? |
| 19:15:39 | <rafa> djazayeri: tried clean |
| 19:15:44 | <djazayeri> wyclif: okay, ask again if it's still a blocker |
| 19:15:48 | <bwolfe> rafa, sounds like a cleaning issue or an install issue |
| 19:15:56 | <bwolfe> rafa, are you running all or running only one? |
| 19:16:06 | <wyclif> djazayeri, sure |
| 19:16:14 | <bwolfe> and do you have the right version of openmrs installed in your maven repo as well? |
| 19:16:14 | <rafa> bwolfe: fails in each case |
| 19:16:18 | <sunbiz> rafa: this happens to me in Netbeans sometimes... so then I clean and build the OpenMRS |
| 19:16:30 | <sunbiz> with the Failed to load ApplicationContext |
| 19:16:54 | <rafa> bwolfe: what is the right version? |
| 19:17:09 | <sunbiz> and then do a clean and build on rest module (including the API/OMOD)... and then do a test File or test the whole omod proj |
| 19:17:23 | <rafa> bwolfe: when I run with maven they work |
| 19:18:01 | <rafa> sunbiz: I repeated these steps a few times today, but let me try again :) |
| 19:18:02 | <bwolfe> hmm, you're cleaning all rest projects? and doing a clean install of htem? |
| 19:19:15 | <wyclif> djazayeri, i have figure out why it is failing |
| 19:20:44 | <wyclif> apparenty it is because i had static initialization of some fields in the registered listener that were failing due to no application context |
| 19:21:17 | <bwolfe> wyclif, which module is this for? |
| 19:21:24 | <wyclif> smart |
| 19:21:30 | <wyclif> bwolfe, smart |
| 19:22:05 | <wyclif> djazayeri, bwolfe i plan to make the SMART release a 0.9 with no offical API release, does that sound fine to you guy? |
| 19:22:18 | <djazayeri> wyclif: why? what does that gain us? |
| 19:22:45 | <djazayeri> wyclif: I don't see a need to make SMART backwards-compatible to 1.6 (i.e. you can use the new module startup callbacks from 1.7.) |
| 19:23:15 | <wyclif> djazayeri, i just want to be able to change service methods in case need arises after initial testing |
| 19:24:07 | <wyclif> SMART's require verion is 1.7 |
| 19:24:15 | <djazayeri> great |
| 19:24:33 | <bwolfe> why 0.9? what are you waiting for for 1.0? |
| 19:24:41 | <djazayeri> wyclif: do consumers of the SMART module call services? |
| 19:24:44 | <wyclif> i have a feeling i might want to require the version when Ben made a fix to global property listeners |
| 19:24:52 | <djazayeri> I thought the API was defined by SMART, not by us. |
| 19:24:58 | <djazayeri> wyclif: that's fine. |
| 19:25:10 | <wyclif> djazayeri, i mean the API for the module |
| 19:25:13 | <djazayeri> (I mean that requiring a newer version for convenience is fine) |
| 19:25:18 | <rafa> bwolfe: sunbiz helped clean project in eclipse and then clean install in maven :D thanks! |
| 19:25:22 | <wyclif> djazayeri, on |
| 19:25:25 | <djazayeri> wyclif: what public API is the module exposing? |
| 19:25:34 | <wyclif> sorry! djazayeri, ok |
| 19:26:10 | <djazayeri> Anyway, I think we should release it as 1.0. We intentionally haven't called WS 1.0 yet until it got tested in the real world, but that's because WS is all about the public API. |
| 19:26:28 | <djazayeri> for SMART, it's not really about an API that we're exposing, so I'm fine calling the first release SMART 1.0. |
| 19:27:02 | <wyclif> djazayeri, ok |
| 19:27:13 | <bwolfe> agreed |
| 19:28:44 | <wyclif> bwolfe, i have a couple of reviews for you, would be nice if you looked at them before i released |
| 19:29:07 | * bwolfe looks |
| 19:29:15 | <wyclif> look st the needs review widget of the sprint dashboard |
| 19:29:54 | <wyclif> bwolfe, i have a made a couple of changes |
| 19:41:10 | *** dkayiwa has quit IRC |
| 19:41:14 | <sunbiz> rafa: so it worked!! gr8!! |
| 19:42:00 | *** r_friedman has joined #openmrs |
| 19:42:35 | <rafa> sunbiz: yes!! it was annoying me all day long. I must have done the steps in a wrong order :/ |
| 19:42:39 | <rafa> sunbiz: thanks a lot! |
| 19:42:47 | <r_friedman> djazayeri: hey darius, got time for a quick question? where is the log when running under jetty? |
| 19:43:11 | <bwolfe> console |
| 19:44:56 | <r_friedman> bwolfe: tks ben, got it |
| 19:46:01 | <bwolfe> wyclif, commented on both reviews for the smart tickets |
| 19:46:14 | <bwolfe> should be either easy fixes or fixes that were done already and I just couldn't tell |
| 19:48:03 | <wyclif> bwolfe, ok, i have one more for you after i have committed the stuff with the global property listeners, should be ready in the next 15min |
| 19:48:43 | <bwolfe> wyclif, ok |
| 19:49:14 | <wyclif> bwolfe, thanks |
| 19:57:37 | <r_friedman> away debugging |
| 19:58:00 | *** dawn_ has quit IRC |
| 20:17:04 | *** wyclif has quit IRC |
| 20:18:14 | <sunbiz> bwolfe djazayeri : sorry I was using an incorrect sessionId each time to the server |
| 20:18:19 | <sunbiz> it works fine on Android as well |
| 20:18:38 | <bwolfe> sunbiz, post your code for nelson to see |
| 20:18:43 | <sunbiz> Can I close the ticket as cannot reproduce !ticket RESTWS-192 |
| 20:18:46 | <bwolfe> and hten you can close as can't reproduce |
| 20:18:54 | <sunbiz> sure |
| 20:27:08 | <sunbiz> bwolfe: should I create a ticket for adding the provider resource?? |
| 20:27:47 | <sunbiz> it will check for ClassNotFound (Provider) for older versions of OpenMRS |
| 20:28:01 | <bwolfe> sunbiz, yes, definitely |
| 20:28:21 | <bwolfe> (as long as you're not introducing compilation dependencies...not sure how to do that) |
| 20:34:32 | <sunbiz> and for <1.9 should the Provider return users with Role Provider? |
| 20:34:48 | *** Mkop has quit IRC |
| 20:35:02 | <bwolfe> sunbiz, sure, sounds right |
| 20:35:07 | <sunbiz> is the role of Provider part of demo data or all installations? |
| 20:35:42 | *** Mkop has joined #openmrs |
| 20:35:42 | *** ChanServ sets mode: +v Mkop |
| 20:35:47 | <sunbiz> bwolfe: sounds like a hard-coded text?? right?? |
| 20:36:07 | <bwolfe> I think all installs, but not sure |
| 20:36:14 | <bwolfe> yes, hard coding the text is fine |
| 20:39:38 | <sunbiz> !ticket 196 |
| 20:39:39 | <OpenMRSBot> sunbiz: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/196 |
| 20:39:49 | <sunbiz> oops!! |
| 20:39:55 | <sunbiz> !ticket RESTWS-196 |
| 20:39:56 | <OpenMRSBot> sunbiz: [#RESTWS-196] Add ProviderResource and ProviderController - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-196 |
| 21:08:46 | *** bryq has quit IRC |
| 21:22:42 | *** wyclif has joined #openmrs |
| 21:23:38 | <sunbiz> bwolfe: dont u think if a user is locked out... there should be some way for the user to know |
| 21:23:43 | <sunbiz> that they have been lockout |
| 21:23:54 | <sunbiz> and for how much time they'll be lockedout?? |
| 21:24:49 | <bwolfe> sunbiz, no |
| 21:24:53 | <bwolfe> that is done on purpose |
| 21:25:19 | <sunbiz> I see that its been recommended on WASP |
| 21:25:25 | <bwolfe> if someone is trying to hack in they shouldn't know which usernames are valid |
| 21:25:29 | <bwolfe> if we said "you |
| 21:25:39 | <bwolfe> "you're locked out" that tells them they have a valid username |
| 21:25:46 | <sunbiz> but from a usability perspective its probably not useful |
| 21:26:06 | <sunbiz> bwolfe: hmm... ok |
| 21:26:32 | <djazayeri> sunbiz: I agree with you that it's really poor usability. we decided to do it for security |
| 21:26:35 | <djazayeri> maybe we'll revisit at some point |
| 21:26:36 | <sunbiz> should the amount of time locked out be a global property as well... |
| 21:27:10 | <sunbiz> I dont think so... but Im expecting someone will comment in the review :) |
| 21:27:53 | *** wyclif has quit IRC |
| 21:27:54 | <bwolfe> I don't think it needs to be one |
| 21:28:03 | <bwolfe> sunbiz, we could show a message if an IP address is locked out |
| 21:29:16 | <sunbiz> ok |
| 21:53:27 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Address Hierarchy 2.2.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=addresshierarchy&version=&2.2.1> |
| 21:54:15 | <sunbiz> bwolfe: in doc I see lockout mentioned to be 30min |
| 21:54:21 | <sunbiz> but in the code its just 5min |
| 21:54:35 | <sunbiz> change the code (creating a ticket) or the doc?? |
| 21:55:09 | <sunbiz> in code its 300000 millis |
| 21:56:09 | <bwolfe> hmm |
| 21:56:19 | <bwolfe> 5 mins is probably enough |
| 21:58:52 | <sunbiz> seriously?? |
| 21:59:26 | <sunbiz> ok... changing the doc then |
| 22:01:14 | <bwolfe> the point of it is to prevent hacking...not to lock someone out for a long time |
| 22:02:01 | <sunbiz> oops failed tests!! |
| 22:02:45 | *** morristic has joined #openmrs |
| 22:03:35 | <djazayeri> sunbiz: yes, failed tests! |
| 22:03:42 | <djazayeri> boo! :-) |
| 22:06:18 | *** rafa has quit IRC |
| 22:13:33 | <sunbiz> djazayeri: it cant find the global property in the tests |
| 22:13:57 | <sunbiz> and hence throws a NPE |
| 22:14:08 | <djazayeri> sunbiz: so, either you have edit the tests, or to edit your code... |
| 22:14:29 | <djazayeri> does the GP have a default value? and do you fetch it that way? |
| 22:14:39 | <sunbiz> hmmm... I dont see why its not running OpenmrsConstants |
| 22:14:45 | <sunbiz> yes... the GP has a default value |
| 22:15:06 | <djazayeri> sunbiz: I don't think that unit tests autocreate all the GPs (or privs for that matter) |
| 22:15:30 | <djazayeri> I mean that there's an AdministrationService method that will get you a GP value or else a default value if it's not defined. |
| 22:16:06 | <sunbiz> yes... I've defined it in the CORE_GLOBAL_PROPERTIES final List |
| 22:16:10 | <djazayeri> bwolfe: I'm just looking at catalogâI've fixed the error so it's not throwing an exception, but now I get back some oddly-serialized xml by xstream |
| 22:16:11 | <sunbiz> in the OpenmrsConstants |
| 22:16:16 | <sunbiz> these should be run |
| 22:16:17 | <djazayeri> bwolfe: any idea how it's supposed to work? |
| 22:17:44 | <djazayeri> sunbiz: I don't know that "core global properties" are *really* core, or at least we haven't been careful about keeping them to a real, limited, core set. |
| 22:17:46 | <sunbiz> I've seen other places where instead of catching only NumberFormatException, catching just Exception and so the NullPointer is catched and test runs fine |
| 22:18:17 | <djazayeri> sunbiz: best if you make a one-line change in your code so that it doesn't throw an NPE if that GP isn't defined... |
| 22:18:35 | <bwolfe> djazayeri, not sure what you're asking about with the serialized xml |
| 22:19:09 | <sunbiz> djazayeri: but global properties should be set by the tests from OpenmrsConstants... if we want good testing... |
| 22:19:14 | <sunbiz> but thats for later I guess... |
| 22:19:28 | <bwolfe> sunbiz, yeah, thats for another ticket. can you create it? :-) |
| 22:19:45 | <djazayeri> bwolfe: e.g. now that I fixed the bug, doing /catalog gets: <org.openmrs.module.webservices.rest.SimpleObject serialization="custom"><unserializable-parents/><map><default><loadFactor>0.75</loadFactor><threshold>12</threshold></default><int>16</int><int>1</int><string>catalog</string><list><org.openmrs.module.webservices.docs.ResourceDoc><name>Cohort</name><url>http://localhost:8018/openmrs18/ws/rest/v1/cohort</url><operations class=" |
| 22:19:51 | <djazayeri> etc |
| 22:20:00 | <djazayeri> I'm wondering if you know what the output is *supposed* to be |
| 22:20:04 | <djazayeri> I haven't looked at it ever before. |
| 22:20:52 | <bwolfe> I haven't looked at it in a long time. but its supposed to be json of what exists, I though |
| 22:20:56 | <bwolfe> *thought |
| 22:21:09 | <djazayeri> okay, I'll look at the code |
| 22:25:14 | *** wyclif has joined #openmrs |
| 22:31:57 | <sunbiz> !ticket TRUNK-3028 |
| 22:31:58 | <OpenMRSBot> sunbiz: [#TRUNK-3028] BaseContextSensitiveTest does not create Core Global Properties - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3028 |
| 22:45:15 | <djazayeri> bwolfe: the json actually comes back right, it's fetching it in the browser as xml that doesn't work. :-) |
| 22:48:00 | <r_friedman> djazayeri: what about being able to get the fields in each rep for a resource with no objects? |
| 22:48:13 | <djazayeri> r_friedman: haven't gotten that far yet |
| 22:48:25 | <r_friedman> djazayeri: ok, later |
| 22:48:30 | <djazayeri> r_friedman: sorry, what's an example of one of those? |
| 22:49:00 | <djazayeri> the way the code works now it does (DelegatingResource).newInstance() and works with that |
| 22:49:11 | <r_friedman> djazayeri: empty some resource, like delete all the locations |
| 22:49:29 | <r_friedman> then i think it is failing when it tries to make a new instance |
| 22:49:59 | <djazayeri> r_friedman: yes, it was failing because of an NPE trying to get the name of a new concept (which obviously has no name) |
| 22:50:07 | <djazayeri> r_friedman: "delete all locations" isn't a resource |
| 22:50:23 | <djazayeri> location is the resource, and we can get the fields for each rep of that |
| 22:50:39 | <r_friedman> djazayeri: i was getting a different error than you, i failed earlier i think |
| 22:51:10 | <r_friedman> djazayeri: i didn't notice the newInstance, only the getRepresentation |
| 22:51:17 | <r_friedman> djazayeri: so I could be wrong |
| 22:51:20 | <djazayeri> r_friedman: okay, hopefully I'll find yours too. I both added a try/catch block so that a single failure just prints ERROR instead of bombing everything |
| 22:51:34 | <djazayeri> and I also fixed the NPE in the concept one. |
| 22:52:02 | <djazayeri> but I'd like to get the to-xml serialization right so I can do a search for ERROR. :-) |
| 22:52:07 | <r_friedman> djazayeri: is this maybe a larger problem of any resource that has a required sub resource? |
| 22:53:53 | <djazayeri> r_friedman: when we wrote the code, we didn't do any unit testing around what happens when you try to format an empty resource to a rep. |
| 22:54:05 | <djazayeri> we should have caught this with a unit test around creating the doc catalog, actually |
| 22:54:32 | <r_friedman> djazayeri well, better late than never |
| 22:57:21 | *** r_friedman has quit IRC |
| 23:37:19 | <wyclif> hi bwolfe |
| 23:46:31 | *** morristic has quit IRC |
| 23:52:16 | *** sunbiz has left #openmrs |