| 00:37:04 | *** rafa has quit IRC |
| 02:12:45 | *** flow has quit IRC |
| 03:29:27 | *** djazayeri has joined #openmrs |
| 03:29:27 | *** ChanServ sets mode: +o djazayeri |
| 04:13:19 | *** upul has joined #openmrs |
| 04:13:19 | *** ChanServ sets mode: +v upul |
| 04:22:34 | *** upul has left #openmrs |
| 04:23:34 | *** upul` has joined #openmrs |
| 04:23:34 | *** ChanServ sets mode: +v upul` |
| 05:05:49 | *** goutham has joined #openmrs |
| 06:20:06 | *** dkayiwa has joined #openmrs |
| 06:31:20 | *** dkayiwa has quit IRC |
| 07:12:49 | *** morristic has quit IRC |
| 07:14:38 | *** djazayeri has quit IRC |
| 07:18:13 | *** morristic has joined #openmrs |
| 07:30:52 | *** morristic has quit IRC |
| 09:00:15 | *** rafa has joined #openmrs |
| 09:00:15 | *** ChanServ sets mode: +v rafa |
| 09:26:46 | *** dkayiwa has joined #openmrs |
| 10:31:02 | <dkayiwa> hi wyclif |
| 11:00:18 | *** morristic has joined #openmrs |
| 11:09:07 | *** dkayiwa has quit IRC |
| 11:14:18 | *** dkayiwa has joined #openmrs |
| 11:22:02 | *** dkayiwa_ has joined #openmrs |
| 11:22:05 | *** dkayiwa has quit IRC |
| 11:22:18 | *** dkayiwa_ is now known as dkayiwa |
| 11:25:29 | *** upul` has quit IRC |
| 11:35:42 | *** wes__ has joined #openmrs |
| 11:45:34 | *** wes__ has quit IRC |
| 11:48:02 | *** ibewes has joined #openmrs |
| 11:51:07 | *** ibewes is now known as ibewes_ |
| 11:51:58 | *** ibewes_ is now known as ibewes |
| 11:53:42 | *** ibewes has quit IRC |
| 11:53:53 | *** dkayiwa has quit IRC |
| 11:54:03 | *** ibewes has joined #openmrs |
| 11:55:10 | *** ibewes has quit IRC |
| 11:56:06 | *** morristic has quit IRC |
| 11:56:10 | *** ibewes has joined #openmrs |
| 12:02:24 | *** ibewes has quit IRC |
| 12:06:45 | *** james_regen has joined #openmrs |
| 12:06:45 | *** ChanServ sets mode: +v james_regen |
| 12:29:04 | *** james_regen has quit IRC |
| 12:29:45 | *** james_regen has joined #openmrs |
| 12:29:45 | *** ChanServ sets mode: +v james_regen |
| 12:59:28 | *** ibewes has joined #openmrs |
| 13:10:21 | *** goutham has quit IRC |
| 13:24:27 | *** flow has joined #openmrs |
| 13:37:20 | *** dkayiwa has joined #openmrs |
| 13:46:04 | *** wyclif has quit IRC |
| 14:06:02 | *** wyclif has joined #openmrs |
| 14:09:12 | <ibewes> hello! I have a quick question about the OpenMRS project. Do you use an project management software? |
| 14:10:31 | <dkayiwa> ibewes: are you talking about things like the attlassian suite of tools (JIRA, etc) |
| 14:10:31 | *** wyclif has quit IRC |
| 14:10:32 | <dkayiwa> ? |
| 14:11:02 | *** wyclif has joined #openmrs |
| 14:12:44 | *** wyclif has joined #openmrs |
| 14:13:25 | <ibewes> does the attlassian suite handle more than bug management? |
| 14:13:46 | <ibewes> sorry... I'm new to the Java and OSS side of things |
| 14:13:56 | <dkayiwa> ibewes: like what else did you want it to do? |
| 14:14:11 | <dkayiwa> ibewes: code reviews? |
| 14:14:21 | <ibewes> higher-level project management... not down to the code level |
| 14:14:35 | <ibewes> something like MS project, minus the (rather large) suck |
| 14:15:25 | <dkayiwa> ibewes: looks like as speaking as a low level guy :) |
| 14:15:55 | <dkayiwa> ibewes: may be you can ask Dawn or Michael |
| 14:16:22 | <ibewes> do they frequent this room? |
| 14:16:41 | <dkayiwa> ibewes: yes when they wake up |
| 14:16:44 | <dkayiwa> :) |
| 14:16:53 | <ibewes> ah... I'll try again later |
| 14:16:55 | <ibewes> thanks! |
| 14:16:56 | <dkayiwa> ok |
| 14:24:09 | *** flow has quit IRC |
| 14:33:26 | *** dkayiwa has quit IRC |
| 14:35:20 | *** Mkop has joined #openmrs |
| 14:35:20 | *** ChanServ sets mode: +v Mkop |
| 15:01:32 | *** bryq has joined #openmrs |
| 15:01:32 | *** ChanServ sets mode: +v bryq |
| 15:46:18 | *** bryq has quit IRC |
| 15:54:47 | *** Mkop has quit IRC |
| 15:55:15 | *** Mkop has joined #openmrs |
| 15:55:15 | *** Mkop has joined #openmrs |
| 15:55:15 | *** ChanServ sets mode: +v Mkop |
| 15:58:14 | *** djazayeri has joined #openmrs |
| 15:58:14 | *** ChanServ sets mode: +o djazayeri |
| 15:59:39 | <djazayeri> rafa, wyclif, what time is the scrum today? |
| 16:00:24 | <rafa> in 2.5h |
| 16:00:30 | <djazayeri> ok, thx |
| 16:00:33 | <djazayeri> so we switch next week |
| 16:00:38 | <rafa> yes |
| 16:08:31 | *** bwolfe has joined #openmrs |
| 16:08:31 | *** ChanServ sets mode: +o bwolfe |
| 17:00:31 | *** dkayiwa has joined #openmrs |
| 17:19:01 | *** deadpool_ has joined #openmrs |
| 17:20:53 | *** mvorobey has joined #openmrs |
| 17:20:59 | *** surangak has joined #openmrs |
| 17:21:13 | <deadpool_> ls |
| 17:23:33 | <dkayiwa> hi wyclif |
| 17:36:23 | <deadpool_> dkayiwa: you switch to maven yet or still using ant? |
| 17:36:41 | <dkayiwa> deadpool_: depends on what am working on :) |
| 17:36:59 | <dkayiwa> deadpool_: some modules are mavenized and while others use ant |
| 17:37:05 | <deadpool_> dkayiwa: that is true |
| 17:37:14 | <deadpool_> dkayiwa: trying to learn some maven now |
| 17:37:30 | <deadpool_> dkayiwa: does it always download from the repo before it builds? |
| 17:37:51 | <dkayiwa> deadpool_: first time should download |
| 18:03:49 | *** surangak has quit IRC |
| 18:06:06 | *** dawn_ has joined #openmrs |
| 18:06:27 | <dawn_> djazayeri: rafa dkayiwa : ben, wyclif and i are in a town hall meeting |
| 18:06:38 | <dawn_> it won't be finished til 1400 at the earliest |
| 18:06:46 | <dawn_> i can have ben and wy send their updates via email |
| 18:08:42 | *** dawn_ has quit IRC |
| 18:14:45 | *** rafa has quit IRC |
| 18:17:20 | *** dkayiwa has quit IRC |
| 18:17:31 | *** rafa has joined #openmrs |
| 18:17:36 | *** ChanServ sets mode: +v rafa |
| 18:30:21 | *** bwolfemobile has joined #openmrs |
| 18:30:21 | *** ChanServ sets mode: +o bwolfemobile |
| 18:32:13 | <djazayeri> hi bwolfe, bwolfemobile, rafa, wyclif |
| 18:32:33 | <djazayeri> shall we scrum, as much as we can? |
| 18:32:38 | <rafa> hi |
| 18:32:51 | <bwolfemobile> Wyclif and I after in a meeting for another 30 minutes |
| 18:33:14 | <djazayeri> rafa: how's your schedule, need to go now, or can you wait 30 mins? |
| 18:33:27 | <rafa> djazayeri: I can wait |
| 18:33:54 | <bwolfemobile> Perfect, thanks |
| 18:33:57 | <djazayeri> okay, we'll go in 30 then |
| 18:34:12 | <rafa> ok |
| 18:37:50 | *** dkayiwa has joined #openmrs |
| 18:38:57 | <bwolfemobile> Dkayiwa, we're delaying the scrum by 30 minutes. Do you have time/power? |
| 18:39:17 | <dkayiwa> bwolfemobile: yes i do :) |
| 18:41:50 | <dkayiwa> bwolfemobile: am on for at least a minimum of two more hours :0 |
| 18:42:22 | <rafa> dkayiwa: are you back home? :) |
| 18:43:28 | <dkayiwa> rafa: by the time the car was finished. it was a bit late to travel. So i decided to stay. Our road is too narrow to use it safely at night. So not yet back home |
| 18:44:24 | <rafa> dkayiwa: that is a long way home |
| 18:45:03 | <dkayiwa> rafa: the same road had a terrible accident yesterday where 5 people died on the spot, and more are dying. |
| 18:48:12 | <rafa> dkayiwa: That's terrible. Have a safe trip tomorrow. |
| 18:48:28 | <dkayiwa> rafa: thanks so much!!! :) |
| 19:04:17 | <djazayeri> still in the meeting? |
| 19:08:30 | <djazayeri> bwolfe, bwolfemobile? you'll ping us when out of meeting? |
| 19:11:21 | <bwolfemobile> Yeah, still going strong... |
| 19:24:47 | *** ibewes has quit IRC |
| 19:27:35 | <bwolfemobile> Done. 5 minutes to scrum time? |
| 19:27:44 | <djazayeri> fine by me |
| 19:27:58 | <djazayeri> rafa, dkayiwa, wyclif: fyi, scrum in 5 |
| 19:36:06 | <wyclif> ok |
| 19:38:07 | <wyclif> hello |
| 19:38:30 | <wyclif> hi rafa , dkayiwa , bwolfe , djazayeri |
| 19:38:39 | <dkayiwa> hi wyclif |
| 19:38:44 | <rafa> hi |
| 19:38:46 | <wyclif> are we scrumming? |
| 19:39:11 | <rafa> I'm ready |
| 19:39:31 | <bwolfe> ready |
| 19:39:32 | <djazayeri> bwolfe? |
| 19:39:33 | <djazayeri> cool |
| 19:39:36 | <bwolfe> who's up? |
| 19:39:39 | <djazayeri> !scrumon wyclif |
| 19:39:39 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster wyclif- you may begin when ready. |
| 19:39:40 | <bwolfe> err, who is leading? |
| 19:40:16 | <bwolfe> guess its wyclif... |
| 19:40:45 | <wyclif> ok i will |
| 19:41:18 | <wyclif> order rafa , dkayiwa , djazayeri , bwolfe an djazayeri and i will go last |
| 19:41:29 | <rafa> Yesterday: |
| 19:41:29 | <rafa> * META-170: Spliting metadata packages into multiple sub-packages |
| 19:41:29 | <rafa> https://tickets.openmrs.org/browse/META-170 |
| 19:41:29 | <rafa> * Had a call with Joe (a student working on the MDSS) |
| 19:41:29 | <rafa> Today: |
| 19:41:30 | <rafa> * META-170: Spliting metadata packages into multiple sub-packages |
| 19:41:30 | <rafa> https://tickets.openmrs.org/browse/META-170 |
| 19:41:31 | <rafa> I didn't expect this task to be that big and to require so much refactoring :/ |
| 19:41:31 | <rafa> * E-mailed Bonna about enhancing the module management |
| 19:41:32 | <rafa> Tomorrow: |
| 19:41:32 | <rafa> * I'll start working on the current sprint. I'll need more time to finish the MDS stuff, |
| 19:41:33 | <rafa> because I underestimated the time it required so I'll probably go back to that next weekend. |
| 19:41:33 | <rafa> No blockers. |
| 19:42:00 | <dkayiwa> Addressed review comments for: SmartUserService should fetch users by uuid - SMART-38 |
| 19:42:01 | <dkayiwa> Committed: Fonts on the OpenMRS Installation Wizard not consistent - TRUNK-2998 |
| 19:42:01 | <dkayiwa> Committed: Fix validation logic for Openmrs Objects in controllers - TRUNK-3002 |
| 19:42:01 | <dkayiwa> Now working on: Fixing failing unit tests before continuing with: Admins should be able enable/disable apps - SMART-39 |
| 19:42:01 | <dkayiwa> No Blockers |
| 19:42:22 | <wyclif> djazayeri, ? |
| 19:42:50 | <bwolfe> wyclif, is djazayeri going twice ? :-) |
| 19:42:55 | <djazayeri> I'll go now |
| 19:43:01 | <djazayeri> I'm back at regular work today |
| 19:43:02 | <djazayeri> Monday 23-Jan-2012 |
| 19:43:02 | <djazayeri> * Catch up on emails |
| 19:43:02 | <djazayeri> * some sprint tickets, maybe RESTWS-143 (remove unnecessary |
| 19:43:02 | <djazayeri> * follow up on Lara's reported failure to use upgrade scripts |
| 19:43:02 | <djazayeri> Question: dashboard available tickets don't all seem accessible. |
| 19:43:02 | <wyclif> sorry, he will go once |
| 19:43:28 | <djazayeri> I mean that a bunch of those tickets have prereqs, or are really aimed at specific people. |
| 19:43:56 | <djazayeri> bwolfe: ? |
| 19:44:00 | <djazayeri> (your turn, I mean) |
| 19:44:05 | <bwolfe> today: (half day) met with burke, catch up on emails and ticket comments, RG meeting, I'll try to do some reviews later tonight. not too much done. :-/ |
| 19:44:24 | <wyclif> ok, i can go next |
| 19:44:39 | <bwolfe> wyclif, you're the only one left. :-) |
| 19:44:52 | <wyclif> friday(left early to go see DOC): |
| 19:44:52 | <wyclif> * code reviews and going through sprint tickets - Use username rather than systemId when looking up SMART users |
| 19:44:52 | <wyclif> * SMART-37 - Smart container doesn't work with core javascript library (Struggled with getting a work around) |
| 19:44:52 | <wyclif> Today: |
| 19:44:53 | <wyclif> * Code review for -T RUNK-2998 - Fonts on the OpenMRS Installation Wizard not consistent... |
| 19:44:55 | <wyclif> * RG meeting |
| 19:44:57 | <wyclif> * SMART-23 - Improved handling of errors when required concept mappings are not found |
| 19:44:59 | <wyclif> * SMART-42 - Users should be able to refresh a smart app's results |
| 19:45:01 | <wyclif> Blockers: None |
| 19:45:43 | *** dawn_ has joined #openmrs |
| 19:46:26 | <djazayeri> Okay, so any discussion points? |
| 19:46:34 | <bwolfe> wyclif, and what do you think about finishing this week? |
| 19:46:51 | <bwolfe> we need some releases, so programming should be done by tomorrow or wednesday |
| 19:47:11 | <wyclif> i can do my SMART tickets today and daniel finishes his, i think SMART will be ready for releasing tomorrow |
| 19:47:38 | <djazayeri> any word about the atlas module? |
| 19:47:51 | <djazayeri> (I see that Rafal will delay MDS 1.0) |
| 19:48:06 | <wyclif> hmm, i might need to ask burke what he thinks of the status of the module |
| 19:48:32 | <wyclif> i plan to work on some REST WS tickets starting tomorrow |
| 19:48:56 | <djazayeri> wyclif: can you find him in person and check up? |
| 19:49:01 | <wyclif> djazayeri, sure |
| 19:49:03 | <djazayeri> is there anything we can do to help? |
| 19:49:31 | <wyclif> djazayeri, coding may be djazayeri |
| 19:49:43 | <djazayeri> wyclif: I mean that's a question for him. :-) |
| 19:49:53 | <wyclif> i dont know why am adding djazayeri 's twice today |
| 19:50:21 | <wyclif> but yes, i will ask him |
| 19:50:32 | <djazayeri> wyclif: do you know how all the RESTWS tickets are going overall? |
| 19:50:36 | <djazayeri> !scrumoff |
| 19:50:36 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 19:51:03 | <wyclif> djazayeri, there has be less work done in REST WS in general compared to other project |
| 19:51:23 | <djazayeri> wyclif: right, though I think it may actually be higher-priority. |
| 19:51:40 | <wyclif> djazayeri, ye |
| 19:51:53 | <bwolfe> yeah, I'd almost be willing to dump smart tickets for rest tickets |
| 19:51:54 | <djazayeri> I'm just about to comment on RESTWS-193 (getAll GET requests do not work) but this one needs some research. |
| 19:51:59 | <wyclif> my s key is falling out |
| 19:52:02 | <bwolfe> (if the smart tickets are not required anyway) |
| 19:53:37 | <wyclif> actually i might have to drop one of the SMART ticket since it is of low priority |
| 19:53:53 | <rafa> how to find remaining REST tickets? (I see only 3 on the get-it-done dashboard) |
| 19:54:11 | <djazayeri> wyclif: if any of the SMART tickets aren't MUST for 1.0, I'd vote for dropping/delaying them. |
| 19:54:12 | <bwolfe> rafa, RESTWS project? |
| 19:54:50 | <rafa> bwolfe: cool |
| 19:57:54 | *** bryq has joined #openmrs |
| 19:57:54 | *** ChanServ sets mode: +v bryq |
| 19:58:29 | <wyclif> djazayeri, ok |
| 19:58:45 | <bwolfe> dkayiwa, you realize the trunk ci tests are failing? doesn't look like a memory issue |
| 19:59:09 | <dkayiwa> bwolfe: it is not a memory issue |
| 19:59:24 | <bwolfe> ok, just so long as you're aware of it. :-) |
| 19:59:39 | <dkayiwa> bwolfe: working on it now :) |
| 20:00:13 | <bwolfe> great, thanks |
| 20:01:06 | <bwolfe> ok, heading off for a while. will be back on later tonight |
| 20:01:17 | <djazayeri> catch you all later |
| 20:01:20 | <djazayeri> bwolfe: you in indy now? |
| 20:01:36 | <djazayeri> so, to summarize: |
| 20:01:37 | <dkayiwa> yes he seems to be :) |
| 20:01:53 | <bwolfe> yeah. will be working for a few days, then will be on paternity leave later this week. :-) |
| 20:01:54 | <djazayeri> wyclif: deprioritize unnecessary SMART tickets in favor of RESTWS |
| 20:02:03 | <djazayeri> bwolfe: cool! |
| 20:03:09 | <wyclif> djazayeri, there is only 1 which i have already deprioritized |
| 20:03:13 | <djazayeri> okay |
| 20:03:19 | <djazayeri> and we need to review the RESTWS tickets |
| 20:03:36 | <djazayeri> wyclif: maybe you and I can touch base by voice today |
| 20:03:43 | <djazayeri> wyclif: also, ping Burke about Atlas. |
| 20:03:45 | <djazayeri> in person |
| 20:04:04 | <mvorobey> hi, djazayeri |
| 20:04:08 | <wyclif> dkayiwa, you can leave SMART-39 for now |
| 20:04:17 | <wyclif> dkayiwa, it is of low priority |
| 20:04:20 | <dkayiwa> wyclif: ok |
| 20:04:31 | <wyclif> djazayeri, sure |
| 20:04:55 | <wyclif> djazayeri, he is out of his office, but i will once he gets in |
| 20:05:23 | <mvorobey> djazayeri, can you reply on my comment on RESTWS-143? |
| 20:05:31 | <mvorobey> !ticket RESTWS-143 |
| 20:05:32 | <OpenMRSBot> mvorobey: [#RESTWS-143] Observations in the obs property of EncounterResource dont need person or encounter properties - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-143 |
| 20:06:38 | <djazayeri> mvorobey: I'm thinking about that. |
| 20:06:40 | *** bwolfemobile has quit IRC |
| 20:06:58 | <mvorobey> djazayeri, o, that is good :) |
| 20:07:07 | <mvorobey> djazayeri, thanks |
| 20:07:13 | <djazayeri> I have to look at what the code looks like now. :-) |
| 20:07:41 | *** bwolfe has quit IRC |
| 20:09:41 | <djazayeri> mvorobey: that's not quite how we want to do it. |
| 20:10:04 | <djazayeri> The idea is that "custom representation" is something whose definition is provided at run-time |
| 20:10:29 | <mvorobey> djazayeri: what does it mean? |
| 20:10:45 | <djazayeri> for example we'd let the ws client ask for a bunch of encounters, but only ask for "dateCreated" (or something), because it's doing a particular report, and doesn't need the actual data. |
| 20:11:02 | <djazayeri> mvorobey: we haven't actually implemented the plumbing to handle this. |
| 20:11:35 | <djazayeri> so, we don't want to support just a single rep called "custom". |
| 20:12:35 | <djazayeri> so, my suggestion was that we implement that "custom rep" framework functionality, and *then* use that to allow the encounter to include the obs but without the person and encounter properties. |
| 20:13:14 | <mvorobey> djazayeri: but client may also requests any of these redundant fields, does not he? how are you going to handle this via custom rep? |
| 20:13:19 | <djazayeri> mvorobey: this is a nice-to-have feature, rather than a required one, so I'd rather avoid doing something that isn't the right long-term solution. |
| 20:13:59 | <djazayeri> mvorobey: I mean that the same mechanism that a client could use to request a custom rep is the same mechanism we could use to allow encounter to specify that the obs it includes don't need "encounter" properties. |
| 20:14:20 | <mvorobey> djazayeri: Oh, it;s great |
| 20:14:36 | <djazayeri> mvorobey: but we don't have that implemented yet. :-) |
| 20:15:26 | <mvorobey> djazayeri: it seems that it requires a lot of efforts, doe not it? what is you plan for this? |
| 20:15:45 | <mvorobey> djazayeri: it seems that it requires a lot of efforts, does not it? what is you plan for this? |
| 20:15:49 | <djazayeri> mvorobey: that's why I said that it's non-essential for v1. |
| 20:17:10 | <mvorobey> djazayeri: I totally understand it :) thanks for all this clarifications !!! |
| 20:18:22 | <djazayeri> mvorobey: here's what we could do: add a new rep called something like "fullRepresentationWithoutPersonOrEncounter" to obs (similar to what you suggested in your ticket comment, but just do it in the existing getRepresentationDescription method) |
| 20:18:52 | <djazayeri> then have EncounterResource and Person/PatientResource would include obs that way. |
| 20:19:02 | <mvorobey> djazayeri: I was thinking about it |
| 20:19:41 | <djazayeri> mvorobey: the "better" solution would be something like changing EncounterResource's full rep to do |
| 20:21:08 | <djazayeri> description.addProperty("obs", new CustomRepresentation(ObsResource.getRepresentationDescription(FullRepresentation.class).removeProperty("encounter").removeProperty("patient")); |
| 20:21:19 | <djazayeri> and then do the tooling around that |
| 20:21:25 | <djazayeri> I don't think it'd be *that* hard. :-) |
| 20:21:33 | <wyclif> dkayiwa, have you included a unit tet for TRUNK-3002 |
| 20:22:26 | <mvorobey> djazayeri: let me clarify one more thing about that |
| 20:22:33 | <dkayiwa> wyclif: did not include one. it made a good number of other existing tests fail :) |
| 20:22:37 | <djazayeri> mvorobey: ps, my code won't exactly compile as written. :-) |
| 20:23:22 | <wyclif> and do you know to confirm that the change you have made are sematically correct? |
| 20:23:29 | <wyclif> dkayiwa, and do you know to confirm that the change you have made are sematically correct? |
| 20:24:07 | <wyclif> dkayiwa, or do you know how to reproduce the problem that lead to this ticket so that you can test it i taken care of |
| 20:25:04 | <mvorobey> djazayeri: you are saying that we can implement something like a custom representation for encounter resource and then use it inside getRepresentationDescription(...) of EncounterResource method? am I understanding you right? |
| 20:25:17 | <dkayiwa> wyclif: from what i have so far seen, the changes seem to be correct because even the failing tests look like they should fail |
| 20:25:39 | <djazayeri> mvorobey: I'm saying that we add something new to the RESTWS module's framework, i.e. Custom Representations. |
| 20:25:47 | <djazayeri> mvorobey: it's not specific to encounter resource. |
| 20:26:07 | <dkayiwa> wyclif: for instance, saving a patient fails if there is no preferred identifier. shouldn't it be so??? |
| 20:26:43 | <dkayiwa> wyclif: if correct, i wonder why the tests were not failing until now??? |
| 20:27:08 | <mvorobey> mvorobey: ok, and then will use it NEW for representing "obs" property of EncounterResource, for instance |
| 20:27:10 | <djazayeri> mvorobey: I'm looking through the code now |
| 20:27:21 | <djazayeri> mvorobey: yes |
| 20:27:47 | <djazayeri> mvorobey: looks like an important method is BaseDelegatingResource.asRepresentation(T, Representation) |
| 20:28:06 | <djazayeri> mvorobey: currently this calls getRepresentationDescription(rep) |
| 20:28:31 | <djazayeri> mvorobey: and that's an abstract method, overridden by the resources. |
| 20:28:55 | <djazayeri> however instead we'd need to add some logic for "if (rep instanceof CustomRepresentation) ..." |
| 20:29:44 | <wyclif> dkayiwa, the problem was that if i edite a patient address and had an invalid field, the form gets redisplayed but the change to the address have been persisted to the DB which, you need to test that this is nolonge rhappening |
| 20:29:57 | <djazayeri> mvorobey: instead of asking for the resource to get one of its known ones. |
| 20:30:03 | <djazayeri> mvorobey: does this make sense? |
| 20:30:44 | <mvorobey> djazayeri: yes it does for me. And it will allow as to show encounter obs property in custom representation for Full Rep of Encounter, am loving this idea |
| 20:30:55 | <mvorobey> as -> us |
| 20:31:11 | <dkayiwa> wyclif: ok will test it |
| 20:31:18 | <djazayeri> mvorobey: great, can you make a short comment about this on the ticket, and then give it a shot? |
| 20:32:20 | <mvorobey> djazayeri: yes, I can, but probably will be able to start work on it only tomorrow :) is it acceptable? |
| 20:32:46 | <djazayeri> mvorobey: that's fine. if you're able to comment on the ticket now/today summarizing this approach, I can comment on it before you pick up work. |
| 20:33:50 | <mvorobey> djazayeri: Am adding comment now |
| 20:47:32 | *** james_regen has left #openmrs |
| 20:55:33 | <mvorobey> djazayeri: added comment, gotta go, thanks for helping me !!! |
| 20:55:41 | <djazayeri> mvorobey: cool, thanks! |
| 20:55:47 | *** mvorobey has quit IRC |
| 20:56:44 | *** dkayiwa has quit IRC |
| 21:10:42 | *** dawn_ has quit IRC |
| 21:54:09 | *** wyclif has quit IRC |
| 21:54:54 | *** wyclif has joined #openmrs |
| 21:58:12 | *** wyclif has joined #openmrs |
| 22:42:25 | *** bryq has quit IRC |
| 22:48:44 | *** wyclif has quit IRC |
| 22:54:50 | <deadpool_> djazayeri: how do i replicate deploy to web in a maven module? |
| 22:55:04 | <djazayeri> deadpool_: not sure, actually |
| 22:56:19 | <djazayeri> maybe you can add a build.xml, and write that task in ant |
| 23:35:08 | <deadpool_> djazayeri: i will try that |