00:01:30
|
*** lh has quit IRC
|
03:15:55
|
*** upul` has joined #openmrs
|
03:15:55
|
*** ChanServ sets mode: +v upul`
|
03:46:53
|
*** morristic has joined #openmrs
|
04:47:40
|
*** djazayeri has joined #openmrs
|
04:47:40
|
*** ChanServ sets mode: +o djazayeri
|
04:56:36
|
*** pushkar has joined #openmrs
|
05:01:15
|
*** maurya has joined #openmrs
|
05:05:28
|
<maurya> djazayeri: https://tickets.openmrs.org/browse/TRUNK-2704, i have submitted my way of solving it, do you think it's the right way of proceeding
|
05:07:29
|
<djazayeri> hi maurya, are you Sri Kummamuru?
|
05:07:39
|
<maurya> yes
|
05:08:51
|
<djazayeri> maurya: this already happens in a popup, right?
|
05:08:59
|
<maurya> yes
|
05:09:12
|
<maurya> the relationship comes as a popup
|
05:09:25
|
<maurya> i am saying the in the popup i should provide a link
|
05:09:35
|
<maurya> if the person is not there
|
05:09:36
|
<djazayeri> So, in your mockup, you added a link.
|
05:09:43
|
<maurya> i have given the mock up also for it
|
05:09:46
|
<djazayeri> does that take you to a new page?
|
05:09:47
|
<maurya> yes
|
05:09:56
|
<maurya> well thats what we need to decide
|
05:10:08
|
<djazayeri> I think that would not be the right flow.
|
05:10:15
|
<maurya> should it take to a new page or i should create one more pop up
|
05:10:31
|
<djazayeri> But also creating a popup inside the popup is bad. :-)
|
05:10:31
|
<maurya> ok
|
05:10:36
|
<maurya> i know
|
05:10:47
|
<maurya> then how do we create a new person
|
05:11:03
|
<djazayeri> Currently there's an ajax search box, right?
|
05:11:06
|
<djazayeri> for searching for person
|
05:11:09
|
<maurya> there is the method for it
|
05:11:14
|
<maurya> yes
|
05:11:35
|
<maurya> but it only searches the existing person , but it has to be a patient or a user
|
05:11:49
|
<djazayeri> well, it also searches for plain persons, right?
|
05:11:56
|
<maurya> we dont have an option to create only a person
|
05:12:14
|
<maurya> which we should have , the code exists but we are not usig it
|
05:12:23
|
<djazayeri> I would propose that after doing a search in that box, you add a final result at the end of the list like "not found, create new person"
|
05:12:32
|
<maurya> yes , but there is no way to put in plain person through UI
|
05:12:46
|
<djazayeri> i.e. the link would be inside the results, rather than a separate link.
|
05:13:00
|
<maurya> ok
|
05:13:01
|
<djazayeri> but it's okay to add a separate link if doing it at the end of teh search results isn't feasibl.e
|
05:13:22
|
<djazayeri> However instead of having that link take you to a new create person page...
|
05:13:47
|
<maurya> but anyways i have to create a UI to let the admin or the user add a person in the system
|
05:14:34
|
<djazayeri> it should reveal a new div within the popup, which lets you provide the name (separeted into first/middle/last/etc components), the age/birthdate, and the sex
|
05:14:42
|
<maurya> ok
|
05:14:53
|
<djazayeri> you'd do this in-line, and clicking the save or add button would create the person, then create the relationship.
|
05:14:54
|
<maurya> got it
|
05:15:07
|
<djazayeri> can you do another mockup of that?
|
05:15:25
|
<maurya> ok so wihthin the same popup the div should show up if the user wants to create a new person ?
|
05:15:29
|
<maurya> yes
|
05:15:39
|
<maurya> i will send attach it to the ticket
|
05:16:18
|
<djazayeri> great!
|
05:17:25
|
<pushkar> djazayeri: https://tickets.openmrs.org/browse/TRUNK-206
|
05:18:30
|
<pushkar> here should i create a new concept for the patient exit type ??
|
05:24:31
|
<pushkar> djazayeri:
|
05:25:17
|
<djazayeri> pushkar: on phone
|
05:25:43
|
<pushkar> djazayeri: okay
|
05:32:40
|
*** dkayiwa has joined #openmrs
|
05:35:12
|
*** ningosi has joined #openmrs
|
05:42:15
|
<maurya> djazayeri: i have attached the new mockup, should i start working on it,https://tickets.openmrs.org/browse/TRUNK-2704
|
05:43:25
|
<djazayeri> pushkar:
|
05:43:33
|
<djazayeri> pushkar: you should not create a new concept
|
05:44:01
|
<djazayeri> the idea is that the sysadmin of a particular installation needs to create the right concept, and point to it with a global property
|
05:44:03
|
<pushkar> djazayeri: here the type of exit in not getting populated
|
05:44:31
|
<djazayeri> if the GP does not exist, or if it points to a missing concept, or to a concept with no answers, then we should not display the formlet.
|
05:44:35
|
<djazayeri> does that make sense?
|
05:44:44
|
<pushkar> okay
|
05:45:05
|
<djazayeri> maurya: closer, but one more thing...
|
05:45:10
|
<maurya> yes?
|
05:45:13
|
<djazayeri> maurya: where is the regular Save / Add button?
|
05:45:29
|
<maurya> oh, sorry i forgot to mention it
|
05:45:44
|
<djazayeri> the way it should work is that normally you use the regular find person field.
|
05:45:55
|
<maurya> yes.
|
05:46:07
|
<djazayeri> however if you click the create-new-person button, it should hide that field, and replace it with the new ones.
|
05:46:21
|
<maurya> okay
|
05:46:22
|
<djazayeri> (and the create new person link should disappear)
|
05:46:31
|
<maurya> okay
|
05:46:58
|
<djazayeri> in the create-new-person div, there should be a "find existing person" which hides this div and redisplays the other.
|
05:47:12
|
<djazayeri> but they both share a single Save button.
|
05:47:23
|
<djazayeri> cool?
|
05:47:26
|
<djazayeri> I have to go to bed now
|
05:47:27
|
<maurya> okay
|
05:47:29
|
<maurya> done
|
05:47:33
|
<djazayeri> getting to 1am my time
|
05:51:16
|
<dkayiwa> :D
|
06:09:44
|
*** morristic has quit IRC
|
06:11:51
|
<maurya> djazayeri: there?
|
06:21:21
|
*** pushkar has quit IRC
|
06:23:16
|
*** maurya has quit IRC
|
06:48:17
|
*** maurya has joined #openmrs
|
06:48:55
|
*** pushkar has joined #openmrs
|
06:51:22
|
*** djazayeri has quit IRC
|
06:57:23
|
*** pushkar_ has joined #openmrs
|
06:58:54
|
*** noni has joined #openmrs
|
07:04:17
|
*** maurya has quit IRC
|
07:06:43
|
*** maurya has joined #openmrs
|
07:10:25
|
*** noni has quit IRC
|
07:13:08
|
*** ningosi has quit IRC
|
07:25:45
|
*** dkayiwa has quit IRC
|
07:45:39
|
*** noni has joined #openmrs
|
07:48:23
|
*** ningosi has joined #openmrs
|
07:57:11
|
*** pushkar_ has quit IRC
|
07:57:57
|
*** pushkar has quit IRC
|
07:58:43
|
*** maurya has quit IRC
|
08:05:38
|
*** ningosi has quit IRC
|
08:05:49
|
*** ningosi has joined #openmrs
|
08:08:18
|
*** noni has quit IRC
|
08:10:32
|
*** ningosi has quit IRC
|
08:49:27
|
*** ningosi has joined #openmrs
|
09:01:52
|
*** dkayiwa has joined #openmrs
|
09:57:55
|
*** dkayiwa has quit IRC
|
10:20:04
|
*** ningosi has quit IRC
|
10:37:29
|
*** rafa has joined #openmrs
|
10:37:31
|
*** ChanServ sets mode: +v rafa
|
11:01:21
|
*** morristic has joined #openmrs
|
11:32:26
|
*** upul` has quit IRC
|
11:34:44
|
*** ningosi has joined #openmrs
|
11:58:42
|
*** morristic has quit IRC
|
12:05:04
|
*** ningosi has quit IRC
|
12:06:29
|
*** ningosi has joined #openmrs
|
12:21:58
|
*** bryq has joined #openmrs
|
12:21:58
|
*** ChanServ sets mode: +v bryq
|
12:28:56
|
*** ningosi has quit IRC
|
13:00:18
|
*** dkayiwa has joined #openmrs
|
13:00:44
|
*** wyclif has quit IRC
|
13:09:59
|
*** ningosi has joined #openmrs
|
13:18:48
|
*** ningosi has quit IRC
|
13:18:55
|
*** ningosi has joined #openmrs
|
13:37:52
|
*** mvorobey has joined #openmrs
|
13:52:26
|
*** wyclif has joined #openmrs
|
13:58:30
|
*** pushkar has joined #openmrs
|
14:09:03
|
<dkayiwa> hi wyclif
|
14:09:18
|
<wyclif> hi dkayiwa
|
14:09:30
|
<dkayiwa> wyclif: how long is this sprint?
|
14:09:47
|
*** pushkar has quit IRC
|
14:10:14
|
*** ningosi has quit IRC
|
14:12:17
|
<wyclif> dkayiwa, 2weeks
|
14:12:17
|
<wyclif> dkayiwa, still got next week
|
14:12:52
|
<dkayiwa> wyclif: ok. would it be fine to add the remaining Ready for work 1.9 tickets?
|
14:13:19
|
<mvorobey> hi wyclif
|
14:13:40
|
<wyclif> dkayiwa, what do you mean?
|
14:14:14
|
<dkayiwa> wyclif: 1.9 has 9 Ready for work tickets. So am asking, would it be fine to add those tickets to the sprint?
|
14:14:37
|
<wyclif> dkayiwa, am currently caught up in work for the SMART container and it is seeming to be more than i expected, and i see myslelf working on SMART only for this week
|
14:14:49
|
<dkayiwa> wyclif: ok
|
14:15:37
|
<wyclif> dkayiwa, but i will try to spare time for REST and remaining tickets next week, i would say, when we are done with the current tickets, we can always pick up more ready for work as long as they are bugs
|
14:16:09
|
<wyclif> dkayiwa, can you send me a link to those tickets?
|
14:16:29
|
<dkayiwa> wyclif: ok
|
14:16:55
|
<dkayiwa> wyclif: here it is below:
|
14:16:55
|
<dkayiwa> https://tickets.openmrs.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+TRUNK+AND+fixVersion+%3D+%22OpenMRS+1.9%22+AND+status+%3D+%22Ready+for+Work%22+ORDER+BY+priority+DESC&mode=hide
|
14:20:01
|
<wyclif> dkayiwa, TRUNK-2070 was solved i guess by the changes darius made for manual flush mode
|
14:20:10
|
<dkayiwa> wyclif: ok
|
14:20:20
|
<dkayiwa> wyclif: you can comment on it
|
14:23:20
|
<wyclif> TRUNK -222 needs to be included
|
14:23:28
|
<dkayiwa> wyclif: ok
|
14:24:34
|
<wyclif> dkayiwa, not sur about the others, we can talk about this on monday when darius and ben are here
|
14:24:49
|
<dkayiwa> wyclif: ok
|
14:24:52
|
<wyclif> but you can go ahead and comment on them
|
14:25:03
|
<wyclif> dkayiwa, but you can go ahead and comment on them
|
14:25:11
|
<dkayiwa> wyclif: ok
|
14:25:21
|
<wyclif> dkayiwa, to initiate discusssion
|
14:25:25
|
<dkayiwa> ok
|
14:28:16
|
<dkayiwa> wyclif: does SMART-38 also mean adding a new uuid field to the table?
|
14:28:32
|
<dkayiwa> wyclif: that is the smartcontainer_user table
|
14:30:52
|
<dkayiwa> wyclif: i assume so :)
|
14:31:54
|
<wyclif> dkayiwa, hmm
|
14:32:04
|
<wyclif> dkayiwa, no
|
14:32:20
|
<dkayiwa> wyclif: so then where will it get the uuid from?
|
14:32:48
|
<wyclif> it the uuid column is in org.openmrs.User and that is the user we want to fetch
|
14:34:10
|
<dkayiwa> wyclif: isnt that already done by the openmrs core api?
|
14:34:29
|
<dkayiwa> wyclif: as in why would we need the same method in the module?
|
14:37:10
|
<wyclif> dkayiwa, but the method returns a smart user
|
14:37:40
|
<wyclif> dkayiwa, so the query does a join to users table in core to match on username and systemId
|
14:37:53
|
<wyclif> dkayiwa, i personally find this ticket of low priority
|
14:38:02
|
<dkayiwa> wyclif: ok
|
14:38:10
|
<wyclif> dkayiwa, because there is no real benefit to it
|
14:38:33
|
<dkayiwa> wyclif: :)
|
14:39:12
|
<wyclif> dkayiwa, it is only because ben made a comment in a review asking why i we use systemId, i think the quick option tis to pass in username and not systemId since already that methods matches on both
|
14:39:43
|
<dkayiwa> wyclif: ok
|
14:40:00
|
<wyclif> i can edit the ticket to describe this but make it of low priority
|
14:40:12
|
<dkayiwa> wyclif: so do you suggest i revert the small changes i have so far done it and go for another?
|
14:45:26
|
<wyclif> dkayiwa, i have edited the ticket description for SMART-38 to using username
|
14:45:35
|
<dkayiwa> wyclif: ok
|
14:45:52
|
<wyclif> dkayiwa, i think the new description requires way less work
|
14:46:05
|
<wyclif> dkayiwa, am really sorry for this mess
|
14:46:20
|
<wyclif> dkayiwa, i shoudl have figure out this earlier
|
14:46:21
|
<dkayiwa> wyclif: ok no problem. thanks for the work reduction. :)
|
14:46:31
|
<dkayiwa> wyclif: :D
|
14:47:08
|
<wyclif> dkayiwa, there are a few reference to that method, be sure to edit the smartAppForm.jsp to use username
|
14:47:43
|
<dkayiwa> wyclif: ok
|
14:47:55
|
<wyclif> dkayiwa, and i think manageUserHiddenApps
|
14:48:00
|
<wyclif> dkayiwa, and i think manageUserHiddenApps.jsp
|
14:48:25
|
<dkayiwa> wyclif: ok thanks for the ponters!!!
|
14:48:46
|
<wyclif> they might be making DWR calls that pass are were passing in systemId
|
14:48:56
|
<dkayiwa> wyclif: ok
|
14:49:00
|
<wyclif> they might be making DWR calls that were passing in systemId
|
14:49:04
|
<dkayiwa> ok
|
14:49:16
|
<wyclif> dkayiwa, thanks
|
14:49:27
|
<dkayiwa> wyclif: thanks most :)
|
14:53:02
|
<wyclif> dkayiwa, actually the other page is smartUsers.jsp
|
14:53:17
|
<dkayiwa> wyclif: ok thanks alot!!!!
|
14:56:10
|
*** dkayiwa has quit IRC
|
14:59:09
|
<mvorobey> wyclif, hi!
|
15:01:33
|
<wyclif> hi mvorobey
|
15:01:47
|
<mvorobey> wyclif, I've a question
|
15:01:52
|
<mvorobey> wyclif, you said that it will be good if I add unit tests for ConceptResource.java (ticket RESTWS-172), but there are already two methods: ConceptResourceTest.validateDefaultRepresentation() and ConceptResourceTest.validateFullRepresentation(), which are responsible for this
|
15:02:21
|
<mvorobey> wyclif: thus I think we do not need to duplicate them either, since those tests work pretty fine for me with, without failures for new functionality.
|
15:04:23
|
<mvorobey> wyclif: so, do we really need them?
|
15:13:41
|
<wyclif> mvorobey, hmm
|
15:13:46
|
<wyclif> mvorobey, sorry for the delay
|
15:14:48
|
<wyclif> mvorobey, it means add assetions in those testcmethods to ensure that the expected display string is set on the simpleObject
|
15:15:22
|
<wyclif> mvorobey, does that make sense?
|
15:18:18
|
<mvorobey> wyclif: In my opinion, no it does not. Cuz the _display string_ is being checked within _super class_ implementation of those methods
|
15:19:19
|
<wyclif> mvorobey, i dont understand what you mean
|
15:20:44
|
<mvorobey> wyclif, I said that superclass implementation of ConceptResourceTest.java already ensures that the expected display string is set on the concept simpleObject
|
15:21:27
|
<wyclif> mvorobey, you need to edit test methods in ConceptResourceTest to check that the display is what is expected
|
15:22:33
|
<wyclif> mvorobey, i'm saying since you have added logic to ConceptResource that sets a display, you need to add asssertion for youe changes
|
15:22:44
|
<mvorobey> wyclif, ok I totally understand you
|
15:22:45
|
<wyclif> mvorobey, i'm saying since you have added logic to ConceptResource that sets a display, you need to add asssertion for your changes
|
15:23:06
|
<mvorobey> wyclif, you do not need to reply it twice :)
|
15:23:25
|
<wyclif> mvorobey, there was a typo in the first
|
15:24:08
|
<mvorobey> wyclif, np
|
15:25:11
|
<mvorobey> wyclif, will add assertions to test methods
|
15:25:59
|
<mvorobey> wyclif, thanks for help and sorry for inconveniences :)
|
15:42:41
|
*** bryq has quit IRC
|
15:43:15
|
<wyclif> mvorobey, no porblem
|
15:44:43
|
<mvorobey> wyclif, no-no, your support is very helpful for me, am rely on it
|
15:45:17
|
<mvorobey> wyclif, am very new in REST-WS module so I need help with this
|
15:50:23
|
<wyclif> wyclif, ok
|
15:50:32
|
<wyclif> mvorobey, ok
|
17:23:07
|
*** rafa has quit IRC
|
17:23:27
|
*** rafa has joined #openmrs
|
17:23:27
|
*** ChanServ sets mode: +v rafa
|
17:30:11
|
*** bryq has joined #openmrs
|
17:30:11
|
*** ChanServ sets mode: +v bryq
|
18:35:14
|
*** dkayiwa has joined #openmrs
|
18:35:24
|
<rafa> hi wyclif
|
18:35:47
|
<rafa> dkayiwa: hi
|
18:35:54
|
<dkayiwa> hi rafa
|
18:36:21
|
<rafa> dkayiwa: it's just us I guess :)
|
18:36:45
|
<rafa> dkayiwa: how are things going for you?
|
18:36:51
|
<dkayiwa> rafa: hahahaha
|
18:36:56
|
<dkayiwa> rafa: not bad :)
|
18:37:11
|
<rafa> dkayiwa: you're a busy person :D
|
18:37:42
|
<dkayiwa> rafa: oh why? :)
|
18:38:32
|
<rafa> dkayiwa: yeah just based on your availability for scrums
|
18:38:55
|
<rafa> dkayiwa: crazy hours :)
|
18:39:01
|
<dkayiwa> rafa: not busy. it is simply the timing :)
|
18:39:31
|
*** mvorobey has quit IRC
|
18:39:31
|
<dkayiwa> rafa: scrum time is normally that when am not on the computer :)
|
18:40:11
|
<rafa> dkayiwa: I see :)
|
18:40:41
|
<dkayiwa> otherwise if we did it by 5:30 pm Ugandan time, i would attend all scrums :)
|
18:41:23
|
<rafa> dkayiwa: ha I'd like that too :D
|
18:42:29
|
<dkayiwa> rafa: the unfortunate thing is that we are 2 out of 5 in favor of that :(
|
18:43:04
|
<rafa> dkayiwa: yeah, that's how it works :D
|
18:43:45
|
<rafa> dkayiwa: it'll be easier when we're back to the summer time
|
18:44:20
|
<dkayiwa> rafa: oh yes!!!
|
18:44:52
|
<rafa> dkayiwa: I didn't know you don't adjust it in Uganda
|
18:45:27
|
<dkayiwa> rafa: we do not at all
|
18:45:43
|
<dkayiwa> rafa: the equator passes in the middle of Uganda :)
|
18:46:26
|
<rafa> dkayiwa: yeah that makes sense, days are long enough all the time :D
|
18:47:48
|
*** dawn_ has joined #openmrs
|
18:47:48
|
<rafa> dkayiwa: anyway the Indy team is probably having lunch
|
18:47:55
|
<dawn_> hey
|
18:48:01
|
<dkayiwa> rafa: yes thats true
|
18:48:05
|
<dawn_> sorry we're late. the fire alarm was going off
|
18:48:25
|
<rafa> dawn_: I thought it was lunch ;)
|
18:48:41
|
<rafa> hi
|
18:48:42
|
<dawn_> rafa: haha! lunch was part of it, but also the fire alarm
|
18:49:07
|
<dawn_> dkayiwa: i thought you had wedding meeting
|
18:49:14
|
<dawn_> rafa: wyclif is on his way to his cube just now
|
18:49:43
|
<wyclif> hi
|
18:49:58
|
<rafa> hi
|
18:51:04
|
<dkayiwa> dawn_: it was finished earlier than usual :)
|
18:51:13
|
<dawn_> it's just rafa , wyclif , and dkayiwa today
|
18:51:20
|
<dawn_> rafa: you want to go ahead and give your updates?
|
18:51:38
|
<wyclif> ]yesterday:
|
18:51:38
|
<wyclif> * Code reviews for RESTWS-191, RESTWS-176 , RESTWS-172
|
18:51:38
|
<wyclif> * SMART-35 - Show meaningful message when a SMART app encounters an error while in action
|
18:51:38
|
<wyclif> * SMART-36 - Setting a coded value code should not always throw exception when no mapping is found
|
18:51:38
|
<wyclif> today:
|
18:51:39
|
<wyclif> * code review
|
18:51:41
|
<wyclif> * dev call
|
18:51:43
|
<wyclif> * SMART-41 - Improved handling of SMART app concept sources for required mappings
|
18:51:50
|
<wyclif> no blockers
|
18:52:30
|
<rafa> oh wyclif was first :)
|
18:52:32
|
<rafa> but it's okay
|
18:52:45
|
<rafa> I just wanted to say that I hardly worked today. I had a terrible headache. I'll make up on saturday.
|
18:52:56
|
<wyclif> sorry rafa
|
18:53:04
|
<dawn_> rafa: sorry to hear that. hope you feel better soon
|
18:53:14
|
<rafa> dawn_: I'm good already thanks
|
18:55:06
|
<rafa> dawn_: I think that's it :) Daniel gave his update via e-mail
|
18:55:15
|
<dkayiwa> :D
|
18:55:37
|
<dkayiwa> and i have not altered it yet :)
|
18:55:57
|
<dawn_> yeah, that's it guys
|
18:55:58
|
<dawn_> thnx!
|
18:57:51
|
*** dawn_ has quit IRC
|
19:09:13
|
*** Mkop has quit IRC
|
19:09:40
|
*** Mkop has joined #openmrs
|
19:09:40
|
*** ChanServ sets mode: +v Mkop
|
19:49:20
|
*** dkayiwa has quit IRC
|
20:00:50
|
*** dkayiwa has joined #openmrs
|
21:08:17
|
*** dkayiwa has quit IRC
|
21:23:18
|
*** hui_ has joined #openmrs
|
21:25:06
|
<hui_> I got the following error when svn to openmrs repository: RA layer request failed
|
21:25:38
|
<hui_> svn: PROPFIND of '/': Could not read status line: An existing connection was forcibly closed by the remote host.
|
21:25:55
|
<hui_> (http://svn.openmrs.org)
|
21:26:50
|
<hui_> Is there anything wrong with my the URL or my svn client?
|
22:00:43
|
*** wyclif has quit IRC
|
22:36:35
|
*** hui_ has quit IRC
|
22:45:13
|
*** bryq has quit IRC
|
23:38:48
|
*** wyclif has joined #openmrs
|