01:20:07
|
*** wyclif has joined #openmrs
|
02:01:21
|
*** rafa has joined #openmrs
|
02:01:21
|
*** ChanServ sets mode: +v rafa
|
02:01:43
|
*** Echidna_ has joined #openmrs
|
02:01:43
|
*** Echidna has quit IRC
|
02:22:50
|
*** rafa has quit IRC
|
03:37:57
|
*** upul` has joined #openmrs
|
03:37:57
|
*** ChanServ sets mode: +v upul`
|
05:34:00
|
*** ningosi has joined #openmrs
|
05:39:38
|
*** surangak has joined #openmrs
|
06:03:08
|
*** kishoreyekkanti has joined #openmrs
|
06:21:47
|
*** bwolfe has joined #openmrs
|
06:21:47
|
*** ChanServ sets mode: +o bwolfe
|
06:33:31
|
*** dkayiwa has joined #openmrs
|
07:03:57
|
*** bwolfe_ has joined #openmrs
|
07:03:57
|
*** ChanServ sets mode: +o bwolfe_
|
07:07:08
|
*** bwolfe has quit IRC
|
07:07:35
|
*** ningosi has quit IRC
|
08:01:08
|
*** bwolfe__ has joined #openmrs
|
08:02:24
|
*** bwolfe_ has quit IRC
|
08:14:32
|
*** surangak has quit IRC
|
08:17:43
|
*** bryq has joined #openmrs
|
08:17:43
|
*** ChanServ sets mode: +v bryq
|
08:40:25
|
*** bwolfe__ has quit IRC
|
08:46:30
|
*** dkayiwa_ has joined #openmrs
|
08:46:47
|
*** dkayiwa has quit IRC
|
08:46:48
|
*** dkayiwa_ is now known as dkayiwa
|
08:57:25
|
*** bryq has quit IRC
|
09:05:17
|
*** sunbiz has joined #openmrs
|
09:05:17
|
*** ChanServ sets mode: +v sunbiz
|
10:02:49
|
*** pascal` has joined #openmrs
|
10:02:50
|
*** ChanServ sets mode: +v pascal`
|
10:03:03
|
<pascal`> !seen rafa_
|
10:03:03
|
<OpenMRSBot> pascal`: rafa_ was last seen in #openmrs 4 weeks, 5 days, 20 hours, 3 minutes, and 46 seconds ago: <rafa_> bwolfe: okay
|
10:31:55
|
*** bryq has joined #openmrs
|
10:31:55
|
*** ChanServ sets mode: +v bryq
|
10:32:40
|
*** bryq has quit IRC
|
10:51:58
|
*** bwolfe has joined #openmrs
|
10:51:58
|
*** ChanServ sets mode: +o bwolfe
|
11:01:27
|
<pascal`> Hey bwolfe, got a second?
|
11:01:35
|
<bwolfe> sure
|
11:01:56
|
<pascal`> bwolfe, I'm trying to created an indicator with the reporting framework
|
11:02:05
|
<pascal`> bwolfe, I'm starting by creating a cohort
|
11:02:33
|
<pascal`> bwolfe, I want a cohort of patients with a specific coded answer to a specific question
|
11:02:45
|
<pascal`> bwolfe, for some reason I'm not figuring out how to do this. I think I might have the dumb :/
|
11:03:11
|
<pascal`> bwolfe, any ideas? I'm created a new Coded Observation Query
|
11:03:33
|
<bwolfe> pascal`, I've never used the reporting module. so I also have the dumb
|
11:03:51
|
<pascal`> !seen djazayeri
|
11:03:51
|
<OpenMRSBot> pascal`: djazayeri was last seen in #openmrs 11 hours, 34 minutes, and 21 seconds ago: <djazayeri> gnight
|
11:04:03
|
<pascal`> djazayeri, awake yet? :)
|
11:04:41
|
<bwolfe> fat chance of that
|
11:04:49
|
<bwolfe> its 3am in seattle...
|
11:05:36
|
<pascal`> bwolfe, it seems like it should be possible, but it's only giving me the option to choose the modifier (ANY, NO? etc) and not the actual concept.
|
11:06:19
|
<pascal`> bwolfe, oh wait? there's a VALUES field. d'oh. I definitely have the dumb.
|
11:08:46
|
<pascal`> I get an NPE now. Argz0rz.
|
11:11:18
|
*** rafa has joined #openmrs
|
11:11:18
|
*** ChanServ sets mode: +v rafa
|
11:13:02
|
<pascal`> ah, rafa, just who I was looking for
|
11:13:10
|
<rafa> pascal`: hi
|
11:13:48
|
<pascal`> rafa, referring back to this conversation: https://wiki.openmrs.org/display/IRC/2011-12-09+-+OpenMRS#124058
|
11:14:21
|
<rafa> okay
|
11:14:23
|
<pascal`> rafa, I've removed the things you mentioned and I now to the point where I have assess all the concepts to be imported...
|
11:14:50
|
<pascal`> rafa, but now? not of the names of the concepts are being detected, they're all just coming up blank
|
11:15:21
|
<pascal`> rafa, It's probably because I'm trying to import a package from an older OMRS/Metadata Sharing setup? but do you think there's a way around this?
|
11:16:02
|
<rafa> pascal`: what version of mds are you using?
|
11:18:05
|
<pascal`> rafa, the latest now, like you said
|
11:18:40
|
<pascal`> rafa, is there a way to see the version of the export?
|
11:19:17
|
<rafa> pascal`: yes, it's displayed on the first page after you upload a package
|
11:19:31
|
<pascal`> rafa, also it was exported from OMRS 1.6.3 and I'm trying to import into 1.8 (1.9 snapshot I think actually)
|
11:19:52
|
<pascal`> rafa, is it in the xml somewhere?
|
11:20:11
|
<rafa> pascal`: this kind of import from 1.6 to 1.8 won't work with any released version
|
11:20:23
|
<rafa> pascal`: We're working on that during this sprint
|
11:20:36
|
<pascal`> rafa, do you have a version that can do it?
|
11:20:45
|
<rafa> pascal`: it's committed
|
11:20:50
|
<pascal`> rafa, I can send you the package if you have a few minutes to test it out
|
11:20:53
|
<rafa> pascal`: but I haven't tested it yet
|
11:21:35
|
<rafa> cool I can test import to 1.8
|
11:21:56
|
<pascal`> rafa, PM your email addy and I'll send you the package quick
|
11:26:51
|
<pascal`> rafa, you've got mail.
|
11:27:20
|
<rafa> pascal`: yep
|
11:28:52
|
*** noni has joined #openmrs
|
11:32:26
|
*** upul` has quit IRC
|
11:34:38
|
*** bwolfe_ has joined #openmrs
|
11:34:38
|
*** ChanServ sets mode: +o bwolfe_
|
11:38:02
|
*** bwolfe has quit IRC
|
11:38:58
|
<pascal`> rafa, Thanks for taking a look, lmk how it goes (=
|
11:41:28
|
<rafa> pascal`: sure, I need 5 minutes
|
11:45:03
|
*** bryq has joined #openmrs
|
11:45:03
|
*** ChanServ sets mode: +v bryq
|
11:45:15
|
*** bryq has quit IRC
|
11:49:44
|
<rafa> pascal`: nope it's not working yet right
|
11:51:08
|
<rafa> pascal`: we should be ready with that feature with 1.0 release
|
11:51:25
|
<rafa> pascal`: it's scheduled around the end of January
|
11:54:59
|
*** noni has quit IRC
|
12:07:55
|
<pascal`> rafa, can you import into a 1.6 instance?
|
12:08:14
|
<pascal`> rafa, all I really want is the source for the HTML Form
|
12:08:33
|
<pascal`> rafa, I know it's kind of there already in the XML, but it's not quite the same I think
|
12:08:54
|
<rafa> pascal`: okay
|
12:11:35
|
<pascal`> rafa, don't worry about it
|
12:11:51
|
<pascal`> rafa, it's gonna be a mission to match the concept UUID's to my dictionary
|
12:12:02
|
<pascal`> rafa, I'll take care of it :) Thanks for your help though!
|
12:12:07
|
<pascal`> rafa++
|
12:12:30
|
<rafa> pascal`: np
|
12:14:19
|
*** james_regen has joined #openmrs
|
12:14:19
|
*** ChanServ sets mode: +v james_regen
|
12:14:53
|
*** bwolfe__ has joined #openmrs
|
12:18:44
|
*** bwolfe_ has quit IRC
|
12:28:09
|
*** robbyoconnor has quit IRC
|
12:29:08
|
<dkayiwa> hi ra
|
12:29:12
|
<dkayiwa> rafa:
|
12:32:41
|
<rafa> hi dkayiwa
|
12:33:11
|
<dkayiwa> rafa: let me get back to you in a few minutes
|
12:33:24
|
<rafa> dkayiwa: cool
|
12:35:48
|
<dkayiwa> rafa: i have been working on ProgramWorkflowHandlersFunctionalTest. But looks like the save methods in ProgramWorkflowService are not catered for in OpenmrsClassScanner.initServiceSaveMethodsCache
|
12:37:54
|
<rafa> dkayiwa: so is it not working?
|
12:38:31
|
<dkayiwa> rafa: i have hackily added method.getName().startsWith("add") || method.getName().startsWith("create")
|
12:39:29
|
<rafa> dkayiwa: it's not right let me see what's going on
|
12:39:31
|
<dkayiwa> rafa: so after that, ProgramWorkflowService.createWorkflow() is called and it returns successfully
|
12:39:50
|
<dkayiwa> rafa: but still the programworkflow is not persisted
|
12:40:11
|
<rafa> dkayiwa: ergh my eclipse froze :/
|
12:40:21
|
<dkayiwa> rafa: oh sorry
|
12:40:41
|
<dkayiwa> rafa: you can use netbeans in the meantime. :)
|
12:41:13
|
<rafa> dkayiwa: haha with all the problems I have with eclipse I still can't say bye to him ;)
|
12:41:26
|
<dkayiwa> :D
|
12:42:10
|
<rafa> dkayiwa: which means there is still more good than evil in eclipse for me :D
|
12:42:29
|
<dkayiwa> rafa: me too!!! :)
|
12:44:14
|
<dkayiwa> rafa: should i commit what i have for you to see???
|
12:44:19
|
<rafa> dkayiwa: ohh okay I see now what's going on
|
12:44:31
|
<dkayiwa> rafa: aha
|
12:44:36
|
<rafa> dkayiwa: so the thing is that PorgramWorkflow is saved together with Program
|
12:44:43
|
<rafa> dkayiwa: it's a dependency of Program
|
12:44:56
|
<dkayiwa> rafa: ok
|
12:44:57
|
<rafa> dkayiwa: so we should actually be testing saving Program
|
12:45:10
|
<dkayiwa> rafa: oh
|
12:45:18
|
<rafa> dkayiwa: that's my bad
|
12:45:22
|
<rafa> dkayiwa: I'm sorry
|
12:45:34
|
<rafa> dkayiwa: so you need ProgramHandlersFunctionalTest
|
12:45:34
|
<dkayiwa> rafa: no problem :)
|
12:46:02
|
<dkayiwa> rafa: sure thanks. if you had not come online, was going to block on this for more hours. :)
|
12:46:21
|
<dkayiwa> rafa: so i delete ProgramWorkflowHandlersFunctionalTest?
|
12:46:31
|
<rafa> dkayiwa: yes
|
12:46:37
|
<dkayiwa> rafa: ok thanks
|
12:47:27
|
<dkayiwa> rafa: shouldn't i also create concrete tests for the rest of the handlers in org.openmrs.module.metadatasharing.handler.impl?
|
12:47:51
|
<dkayiwa> rafa: eg FormFieldHandler, GlobalPropertiesHandler etc
|
12:48:08
|
<rafa> dkayiwa: you see that's the tricky part
|
12:48:23
|
<rafa> dkayiwa: you can create it for GlobalPropertiesHandler
|
12:48:32
|
<dkayiwa> rafa: ok
|
12:48:32
|
<rafa> dkayiwa: but FormFieldHandler is also for handling dependency
|
12:48:38
|
<dkayiwa> rafa: ok
|
12:48:42
|
<rafa> dkayiwa: and you won't be able to save it all alone
|
12:49:01
|
<rafa> dkayiwa: basically we can only test types that are listed for the user as exportable
|
12:49:02
|
<dkayiwa> rafa: so i will be asking you per class before i create any tests for it :)
|
12:49:10
|
*** bwolfe__ is now known as bwolfe
|
12:50:23
|
<rafa> dkayiwa: you don't need to create any more :)
|
12:50:30
|
<rafa> dkayiwa: it's enough
|
12:50:51
|
<dkayiwa> rafa: so you mean i stop with ProgramHandlersFunctionalTest ?
|
12:51:25
|
<rafa> dkayiwa: yeah you can add for GlobalProperties and it'll be good enough
|
12:51:43
|
<dkayiwa> rafa: ok
|
13:13:55
|
*** wyclif has quit IRC
|
13:15:54
|
*** kishoreyekkanti has quit IRC
|
13:46:25
|
*** bwolfe has quit IRC
|
14:18:25
|
*** wyclif has joined #openmrs
|
14:27:56
|
*** pascal` has quit IRC
|
14:48:28
|
*** downeym has joined #openmrs
|
14:48:28
|
*** ChanServ sets mode: +o downeym
|
14:48:28
|
*** OpenMRSBot sets mode: +o downeym
|
14:48:48
|
<dkayiwa> hi rafa
|
14:48:54
|
<rafa> dkayiwa: hi
|
14:49:21
|
<dkayiwa> rafa: by the way thanks so much for the very quick feedback. :)
|
14:49:35
|
<dkayiwa> rafa: can you throw some more light on this comment: Can we make it List<T> getAllItems() and use it to compare the list in searchHandlerGetItems as well?
|
14:49:37
|
<rafa> dkayiwa: you're welcome. I hope it helps :)
|
14:49:59
|
<dkayiwa> rafa: oh yes it does :)
|
14:50:13
|
<rafa> dkayiwa: it makes sense not ony to compare size but also if items are equal
|
14:50:27
|
<dkayiwa> rafa: oh i see
|
14:50:38
|
<rafa> dkayiwa: in ConceptHandlersFunctionalTest you can call Context.getConceptService().getAllIConcepts();
|
14:50:51
|
<dkayiwa> rafa: ok
|
14:51:16
|
<rafa> dkayiwa: I'll guarantee the right behavior regardless of the underlying dataset
|
14:51:29
|
<dkayiwa> rafa: ok
|
14:58:12
|
*** bwolfe has joined #openmrs
|
14:58:12
|
*** ChanServ sets mode: +o bwolfe
|
14:58:24
|
<dkayiwa> hi rafa
|
14:58:49
|
<rafa> dkayiwa: hi
|
14:59:19
|
<dkayiwa> rafa: in which particular method in BaseHandlersFunctionalTest should we use the getAllItems()?
|
15:00:04
|
<rafa> dkayiwa: searchHandlerGetItemsShouldGetCorrectItems and searchHandlerGetItemsCountShouldGetCorrectItemCount
|
15:00:25
|
<rafa> dkayiwa: in itemsCount you'll have getAllItems().size()
|
15:00:31
|
<dkayiwa> rafa: ok
|
15:01:16
|
<dkayiwa> rafa: as for the searchHandlerGetItemsShouldGetCorrectItems, what should i replace the 9 parameter with? -1?
|
15:01:35
|
<dkayiwa> rafa: that is in the call to Handler.getSearchHandler(item).getItems
|
15:01:39
|
<rafa> dkayiwa: getAllItems().containsAll(items);
|
15:01:50
|
<dkayiwa> rafa: hahahaha :)
|
15:02:03
|
<sunbiz> are ppl able to get on the call??
|
15:02:07
|
<sunbiz> freeconferencing is down for me
|
15:02:26
|
<rafa> sunbiz: try adobe connect then
|
15:03:21
|
<rafa> sunbiz: it's the most reliable :)
|
15:04:09
|
<downeym> sunbiz: I was just using FC
|
15:04:30
|
<bwolfe> sunbiz, rafa, downeym, the FC skype bot is hardly ever online
|
15:04:44
|
<sunbiz> I called it... and it hasnt answered my calls...
|
15:04:46
|
<sunbiz> bad bot!!!
|
15:04:46
|
<bwolfe> I assume they are able to make more money by being down than up
|
15:05:05
|
<downeym> bwolfe sunbiz - i think they have far too few slots for Skype
|
15:05:10
|
<rafa> I ugraded skype and feel stupid because I can't find keypad to enter the code :D
|
15:05:22
|
<bwolfe> sunbiz, using connect.openmrs.org is good. you just have to be on a mac or windows. I run it through a windows vm just fine
|
15:05:23
|
<rafa> that's why I'm using adobe connect
|
15:05:40
|
<bwolfe> rafa, haha, now thats good UI for you!
|
15:05:56
|
<bwolfe> "new and improved! We decided you don't need to use the keypad anymore!"
|
15:06:02
|
<rafa> seriously they removed it!
|
15:06:17
|
<Mkop> it's there
|
15:06:25
|
<Mkop> you just gotta find it
|
15:06:28
|
<rafa> haha
|
15:06:33
|
<Mkop> look for a little tiny button in a corner somewhere
|
15:06:50
|
<rafa> I found x :D
|
15:07:22
|
<rafa> I don't like skype :P
|
15:07:42
|
<Mkop> really? I LOVE it
|
15:07:45
|
<bwolfe> rafa, thats ok, skype doesn't like you either
|
15:07:46
|
<Mkop> hahahaha
|
15:08:17
|
<rafa> haha I don't care :P
|
15:08:27
|
<dkayiwa> :D
|
15:08:30
|
<Mkop> haha skype doesn't care
|
15:08:33
|
*** wyclif has quit IRC
|
15:09:34
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Another great #HFOSS meeting yesterday with @mifos @FrontlineSMS and @Ushahidi ... let us know if you're helping the world with #opensource. <http://twitter.com/OpenMRS/statuses/157475429605847040>
|
15:11:05
|
<rafa> Mkop: haha that's PIECE :D
|
15:21:48
|
*** wyclif has joined #openmrs
|
15:24:21
|
<wyclif> hi rafa
|
15:24:51
|
<rafa> hi wyclif
|
15:27:44
|
<wyclif> rafa, never mind
|
15:28:13
|
<rafa> wyclif: ohh I was so awaitng your question :D
|
15:30:42
|
<wyclif> i had one but figure it out
|
15:30:42
|
<wyclif> rafa, anways did you see my last comment about converting between versions?
|
15:31:00
|
<wyclif> rafa, where converters get registered in the app context and just let the module invoke them
|
15:31:48
|
<rafa> wyclif: oh yes
|
15:31:59
|
<wyclif> rafa, so that each converter is specific to what it is changing instead of handling all situations and avoid vode jamming
|
15:32:12
|
<rafa> wyclif: I haven't heard from anyone that it's needed right now
|
15:32:22
|
<rafa> wyclif: but it would be a nice to have in the future
|
15:32:41
|
<rafa> wyclif: if you have a specific desing in mind you could write it down in a ticket
|
15:32:42
|
<wyclif> rafa, that way i can get rid of that argument for on the convertToXX methods in the version conveter
|
15:33:13
|
<rafa> wyclif: I don't understand
|
15:33:19
|
<rafa> wyclif: how that would help
|
15:34:06
|
<rafa> wyclif: Can't you simply change it to conver(String xml, String fromVersion, String toVersion) ?
|
15:34:16
|
<rafa> wyclif: it's good enough
|
15:34:20
|
<wyclif> rafa the reason i added that argument initially was because i assumed that converter would do otehr conversions e.g from 1.7 to 1.8
|
15:34:58
|
<rafa> wyclif: right so the method I suggest should be general enough
|
15:36:10
|
<wyclif> rafa, right the only problem i have is that it will get clattered with if clauses tryign to juggle versions and the direction
|
15:38:06
|
<rafa> wyclif: that's true, but it won't be that many ifs :) and you'll still have convertConceptFrom16To18 methods to make it less clattered.
|
15:38:10
|
<wyclif> rafa, and that is why i prefer a converter with 2 method but handling a specific conversion say 16 and 17 and and them remove the version number argument as you suggested
|
15:39:16
|
<rafa> wyclif: if you're finished with your tickets, you can try to refactor it as you imagine it
|
15:39:25
|
<rafa> wyclif: I'd say it's good for now
|
15:39:32
|
<wyclif> and this would be the pattern for all converters that we add in future then the module can load invoke these methods without knowledge of the converter nor the logic in it]
|
15:40:11
|
<wyclif> rafa, but yeah i agree for now i can just get rid of the argument since this is only for 1.6 to 17 and 18
|
15:40:31
|
<rafa> wyclif: sounds good
|
15:40:59
|
<wyclif> rafa, thanks
|
15:54:48
|
*** dkayiwa has quit IRC
|
16:03:59
|
<wyclif> hi bwolfe
|
16:04:39
|
<wyclif> bwolfe, can we talk about next week's sprint after today's scrum chat?
|
16:04:40
|
<bwolfe> hi wyclif
|
16:04:46
|
<bwolfe> yeah, sounds perfect
|
16:04:51
|
<wyclif> bwolfe, cool
|
16:08:32
|
*** fred has joined #openmrs
|
16:08:39
|
<downeym> Hi fred and welcome to the #openmrs IRC channel.
|
16:08:58
|
*** fred is now known as Guest35465
|
16:13:40
|
*** bwolfe has quit IRC
|
16:19:43
|
*** wyclif has quit IRC
|
16:21:19
|
*** Guest35465 has quit IRC
|
16:31:44
|
*** wyclif has joined #openmrs
|
16:41:56
|
*** djazayeri has quit IRC
|
16:43:25
|
*** suranga has joined #openmrs
|
16:49:38
|
<wyclif> hi rafa
|
16:49:47
|
<rafa> wyclif: hi
|
16:51:31
|
<wyclif> so when look at the MDS Rest controller(got the code from the revision you included in the ticket comment), you notice if the client requests for text file, it only sends the metadata without the header, is that right, would the module be able to import it without the header?
|
16:51:42
|
<wyclif> sorry ticket desctiption
|
16:52:31
|
<rafa> wyclif: Just the text file is a specific use case for PIH
|
16:52:39
|
<rafa> wyclif: I'm not sure how they use it
|
16:54:08
|
<wyclif> rafa, so thay know how handle it?
|
16:54:11
|
<wyclif> rafa, rafa, so thay know how handle it?
|
16:54:30
|
<wyclif> rafa, ok cool, thanks
|
16:54:54
|
<rafa> wyclif: I suppose. If they put it there :) If you want details you can contact Mike Seaton. He wrote that piece :)
|
16:55:02
|
<wyclif> rafa, ok
|
16:55:50
|
<rafa> wyclif: am I right that META-178 is not a blocker?
|
16:56:06
|
<rafa> wyclif: it's just an error in logs, scripts are still executed right?
|
16:56:34
|
<rafa> wyclif: at least in all my browsers, it's true
|
17:02:06
|
*** downeym has quit IRC
|
17:02:35
|
<wyclif> rafa, i would say it not a blocker, but i wonder why i get the error message in firebug
|
17:02:44
|
<wyclif> rafa, so i agree
|
17:04:47
|
<rafa> wyclif: yes, I get the error as well, but the reason is in core. I've created a ticket for that.
|
17:07:35
|
<rafa> wyclif: I missed one thing
|
17:07:54
|
<rafa> wyclif: can we make the ws url the same as in the web services rest module
|
17:07:55
|
<rafa> ?
|
17:08:02
|
<rafa> wyclif: it should be http:/localhost:8080/openmrs/ws/rest/metadatasharing I think
|
17:11:59
|
<rafa> wyclif: so following the rest best practices the url should look like /ws/rest/metadatasharing/metadata
|
17:12:54
|
*** bwolfe has joined #openmrs
|
17:12:54
|
*** ChanServ sets mode: +o bwolfe
|
17:17:01
|
<wyclif> rafa, ok
|
17:17:12
|
*** suranga has quit IRC
|
17:17:18
|
<wyclif> rafa, i'm off for lunch with the group
|
17:20:37
|
*** djazayeri has joined #openmrs
|
17:20:37
|
*** ChanServ sets mode: +o djazayeri
|
17:21:07
|
<rafa> wyclif: bon appetit :D
|
17:22:48
|
*** maurya has joined #openmrs
|
17:24:54
|
*** bryq has joined #openmrs
|
17:24:54
|
*** ChanServ sets mode: +v bryq
|
17:25:59
|
*** downeym has joined #openmrs
|
17:25:59
|
*** ChanServ sets mode: +o downeym
|
17:25:59
|
*** OpenMRSBot sets mode: +o downeym
|
17:30:31
|
*** bwolfe has quit IRC
|
17:36:54
|
*** bwolfe has joined #openmrs
|
17:36:54
|
*** ChanServ sets mode: +o bwolfe
|
17:40:12
|
*** djazayeri1 has joined #openmrs
|
17:40:12
|
*** ChanServ sets mode: +o djazayeri1
|
17:40:38
|
<djazayeri1> Testing andchat
|
17:41:04
|
<djazayeri1> Seems to work
|
17:41:27
|
*** djazayeri1 has quit IRC
|
17:53:44
|
*** sunbiz has left #openmrs
|
17:55:14
|
<bwolfe> djazayeri, seems to not work?
|
17:55:19
|
<bwolfe> or did you sign off intentionally?
|
17:55:46
|
<djazayeri> signed off intentionally
|
17:56:07
|
<bwolfe> upgrade your garmin phone yet?
|
17:58:08
|
<djazayeri> got a galaxy nexus
|
17:59:12
|
*** maurya has quit IRC
|
18:04:58
|
* rafa thinks wyclif and dawn are still having lunch
|
18:05:41
|
<djazayeri> I have the scrum on my calendar in 30 mins.
|
18:06:03
|
* rafa thinks further and agree with djazayeri :D
|
18:06:49
|
*** bwolfe_ has joined #openmrs
|
18:06:49
|
*** ChanServ sets mode: +o bwolfe_
|
18:07:56
|
*** bwolfe has quit IRC
|
18:08:36
|
*** bwolfe_ is now known as bwolfe
|
18:08:41
|
<bwolfe> djazayeri, wow, quite the upgrade!
|
18:16:16
|
<djazayeri> it's awesome
|
18:27:36
|
*** bwolfe_ has joined #openmrs
|
18:27:36
|
*** ChanServ sets mode: +o bwolfe_
|
18:28:41
|
*** bwolfe has quit IRC
|
18:28:49
|
*** bwolfe_ is now known as bwolfe
|
18:29:25
|
*** suranga has joined #openmrs
|
18:31:28
|
*** suranga_ has joined #openmrs
|
18:31:30
|
<bwolfe> who's feeling scrummy?
|
18:32:15
|
<bwolfe> !scrumon bwolfe
|
18:32:15
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster bwolfe- you may begin when ready.
|
18:32:35
|
<bwolfe> djazayeri, rafa, wyclif, bwolfe
|
18:32:42
|
<bwolfe> (no dkayiwa)
|
18:32:49
|
<rafa> hey
|
18:33:14
|
<djazayeri> hi
|
18:33:34
|
<djazayeri> I'm in a meeting now so I'll be committing the cardinal sin of not watching full-time
|
18:33:40
|
<bwolfe> hmm
|
18:33:48
|
<bwolfe> djazayeri, you're up first
|
18:33:54
|
<bwolfe> (that was the order above)
|
18:34:03
|
<djazayeri> Wednesday 11-Jan-2012
|
18:34:03
|
<djazayeri> * catchup call with TW
|
18:34:03
|
<djazayeri> * design forum
|
18:34:03
|
<djazayeri> * project management call
|
18:34:03
|
<djazayeri> * address review comments on META-181
|
18:34:04
|
<djazayeri> * created META-186
|
18:34:04
|
<djazayeri> * found and fixed META-185 (a small bug with MDS on OpenMRS 1.9). Found another 1.9-related bug and switched to 1.8.
|
18:34:05
|
<djazayeri> Thursday 12-Jan-2012
|
18:34:06
|
<djazayeri> * Dev forum
|
18:34:06
|
<djazayeri> * Observe/advise at an OpenELIS strategy/governance meeting
|
18:34:07
|
<djazayeri> * finish addressing review comments on META-181 (now that I'm unblocked)
|
18:34:07
|
<djazayeri> * do a mockup of a new Configuration page for MDS
|
18:34:08
|
<djazayeri> * plan for a meeting in Boston next week
|
18:34:08
|
<djazayeri> * another MDS ticket? (seems unlikely, it's a packed day)
|
18:34:09
|
<bwolfe> wyclif is probalby still at the indianapolis super-slow dinner
|
18:34:09
|
<djazayeri> no blockers
|
18:34:09
|
<djazayeri> gotta run
|
18:34:11
|
*** suranga has quit IRC
|
18:34:12
|
<bwolfe> err, luch
|
18:34:31
|
<rafa> Today:
|
18:34:31
|
<rafa> * Reviewed and discussed tickets
|
18:34:31
|
<rafa> Our stats:
|
18:34:31
|
<rafa> - 14 tickets closed
|
18:34:31
|
<rafa> - 7 in-progress with 4 no yet reviewed
|
18:34:31
|
<rafa> - 2 MUST tickets not committed yet: META-170 (me), META-176 (me) (decided to wait for everyone to finish work before commiting META-170, will do META-176 tomorrow)
|
18:34:31
|
<rafa> - 2 tickets ready for work (1 should, 1 non-essential)
|
18:34:32
|
<rafa> * Investigated on META-168: Importing Concepts exported from OpenMRS 1.6 to OpenMRS 1.7/1.8
|
18:34:32
|
<rafa> https://tickets.openmrs.org/browse/META-168
|
18:34:33
|
<rafa> * Fixed META-184: Should be allowed to create packages that don't include concepts without configuring a concept source
|
18:34:33
|
<rafa> https://tickets.openmrs.org/browse/META-184
|
18:34:34
|
<rafa> * Closed META-178: Scripts are broken on module jsps
|
18:34:34
|
<rafa> https://tickets.openmrs.org/browse/META-178 and created a followup ticket for core
|
18:34:35
|
<rafa> * Fixed the message.properties problem
|
18:34:35
|
<rafa> Tomorrow:
|
18:34:36
|
<rafa> * META-176
|
18:34:36
|
<rafa> * Final reviews
|
18:34:37
|
<rafa> * Waiting for a sprint hero to pick-up the last should ticket :-)
|
18:34:37
|
<rafa> No blockers.
|
18:36:16
|
<bwolfe> a sprint hero?
|
18:36:20
|
<bwolfe> hehe
|
18:36:40
|
<rafa> bwolfe: you can be one today!
|
18:36:42
|
<rafa> :D
|
18:36:47
|
*** bwolfe has quit IRC
|
18:36:50
|
*** bwolfe_ has joined #openmrs
|
18:36:50
|
*** ChanServ sets mode: +o bwolfe_
|
18:37:28
|
<rafa> bwolfe_: I think you can go before wyclif ;)
|
18:38:52
|
*** bwolfe_ is now known as bwolfe
|
18:39:19
|
<bwolfe> ...if my connection would remain steady enough
|
18:40:14
|
<bwolfe> did it come through before I lost it?
|
18:40:20
|
<rafa> nope
|
18:40:50
|
<bwolfe> today:
|
18:40:51
|
<bwolfe> applied TRUNK-2272, el functions not working
|
18:40:51
|
<bwolfe> applied TRUNK-2818, persian translations
|
18:40:51
|
<bwolfe> applied TRUNK-2305, default locale not working
|
18:40:51
|
<bwolfe> reviewed OCC-10, Automatic Name Mapping page
|
18:40:51
|
<bwolfe> applied TRUNK-2888, retired states on dashboard
|
18:40:59
|
<bwolfe> triaged a bunch of trunk tickets
|
18:41:00
|
<bwolfe> dev call
|
18:41:00
|
<bwolfe> finish up next week's sprint (by passing it off to Wyclif)
|
18:41:00
|
<bwolfe> ldrship call
|
18:41:01
|
<bwolfe> no blockers
|
18:41:08
|
<bwolfe> no wyclif yet?
|
18:41:23
|
<rafa> !ticket TRUNK-2818
|
18:41:24
|
<OpenMRSBot> rafa: [#TRUNK-2818] Persian Translation - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2818
|
18:41:35
|
<rafa> that's interesting :)
|
18:41:43
|
<bwolfe> yeah, first RTL language
|
18:41:54
|
<bwolfe> he said it wasn't too bad
|
18:42:01
|
<rafa> looks awesome :D
|
18:42:12
|
<bwolfe> but I'm sure RTL readers are used to LTR mishaps
|
18:42:41
|
<rafa> yeah, they even can write on facebook using normal letters :D
|
18:42:44
|
<wyclif> hey
|
18:43:04
|
<wyclif> yesterday:
|
18:43:04
|
<wyclif> * design call
|
18:43:04
|
<wyclif> * META-182 - Cannot run Metadata Sharing and REST Web Services modules together
|
18:43:04
|
<wyclif> * Make changes as per pending review comment for META-169 - Exporting metadata packages on-the-fly
|
18:43:04
|
<wyclif> * Wiki documentation of how to use the MDS webservice(exporting metadata packages on the fly)
|
18:43:05
|
<wyclif> * had a couple email/ code review discussions with rafa for META-168 - Importing concepts from 1.6 to 1.7+ and vice versa
|
18:43:08
|
<wyclif> today:
|
18:43:12
|
<wyclif> * dev call
|
18:43:14
|
<wyclif> * META-155 - incomingToExisting map passed to onSave method does not include objects that have previously been mapped to an existing object
|
18:43:16
|
<wyclif> * Discuss with ben about next week's sprint
|
18:43:18
|
<wyclif> * Address comments for all reviewed tickets
|
18:43:36
|
<wyclif> no blockers
|
18:44:58
|
<bwolfe> hmm, ok, I didn't see any comments needing to be discussed
|
18:45:02
|
<bwolfe> soo....
|
18:45:04
|
<bwolfe> !scrumoff
|
18:45:04
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
18:45:13
|
<wyclif> bwolfe, rafa djazayeri have you seen my update?
|
18:45:22
|
<rafa> wyclif: yes :)
|
18:45:27
|
<wyclif> cool
|
18:45:51
|
<wyclif> bwolfe, can we have our discussion 5 min from now
|
18:46:05
|
<bwolfe> wyclif, I have a call in 15 mins
|
18:46:18
|
<wyclif> so when are you available?
|
18:46:25
|
<bwolfe> now. for 15 mins. :-)
|
18:46:43
|
<wyclif> give me a min
|
18:46:48
|
<wyclif> so we will have 14min
|
18:50:44
|
<bwolfe> wyclif, so the TODOs left are:
|
18:51:11
|
<bwolfe> 1) scan through 1.9 open tickets to see what needs done. if they need done, add label get-stuff-done-jan-2012
|
18:51:48
|
<bwolfe> 2) make sure no tickets are in Needs Assessment stage
|
18:52:04
|
<bwolfe> (if they are, assess them or ask someone else ot assess them)
|
18:52:09
|
<bwolfe> 3) review all tickets in the sprint dashboard to make sure the descriptions are well written
|
18:53:13
|
<bwolfe> 4) maybe add a fancy widget to the sprint dashboard like what rafa did (you'd have to copy my dashboard and create a new one...thats fine if you do, just change the sprint wiki page too)
|
18:56:38
|
<wyclif> bwolfe, do you mean the pie chart?
|
18:57:10
|
<bwolfe> or bar graph
|
19:01:38
|
*** suranga has joined #openmrs
|
19:03:17
|
<djazayeri> bwolfe: hamish and I are in a meeting and hamish is answering a question now, so we'll be 5 mins late to the ldrship mtg
|
19:04:20
|
*** suranga_ has quit IRC
|
19:06:49
|
*** morristic has joined #openmrs
|
19:11:35
|
*** suranga has quit IRC
|
19:13:20
|
*** djazayeri has quit IRC
|
19:35:37
|
*** rafa has quit IRC
|
19:42:13
|
*** dkayiwa has joined #openmrs
|
19:45:15
|
*** djazayeri has joined #openmrs
|
19:45:15
|
*** ChanServ sets mode: +o djazayeri
|
19:58:10
|
*** deadpool_ has joined #openmrs
|
19:59:47
|
<deadpool_> hey has anyone tested openmrs on a tablet device?
|
20:04:29
|
*** olliejones has joined #openmrs
|
20:11:00
|
<downeym> deadpool_: several folks on our implementers mailing list have done stuff with tablets
|
20:11:59
|
<deadpool_> ah fair enough i just got a motorola xoom and tried experimenting with it yesturday
|
20:12:31
|
<deadpool_> it was kinda slow and buggy so was wondering if anyone else had done anything
|
20:15:24
|
*** bwolfe has quit IRC
|
20:30:21
|
*** sunbiz1 has joined #openmrs
|
20:30:28
|
*** sunbiz1 has left #openmrs
|
20:39:02
|
<wyclif> hi djazayeri
|
20:39:51
|
<wyclif> djazayeri, are the uuids for exported items the ones from the source dictionary or they are assigned when creating export item?
|
20:44:15
|
*** james_regen has left #openmrs
|
21:05:14
|
*** dkayiwa has quit IRC
|
21:24:13
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @mbuguanjihia: @medafricaorg has openMRS plugged in on the back. #amref #worldvision cc @bobcollymore #firechat <http://twitter.com/OpenMRS/statuses/157563511067770880>
|
21:34:44
|
*** rafa has joined #openmrs
|
21:34:44
|
*** ChanServ sets mode: +v rafa
|
21:39:29
|
*** downeym has quit IRC
|
21:42:52
|
*** rafa has quit IRC
|
21:47:53
|
<djazayeri> wyclif: from source
|
21:48:00
|
<djazayeri> in mds you mean?
|
21:49:15
|
<wyclif> djazayeri, yeah
|
21:49:43
|
<djazayeri> wyclif: uuids are preserved across systems by mds
|
21:50:02
|
<wyclif> djazayeri, and the created importItem in the DB's uuid column is the uuid of the atcual imported item, righr?
|
21:50:22
|
<djazayeri> wyclif: oh i don't know about that
|
21:51:10
|
<wyclif> because metadatasharingservice has a getImportedItem method that takes in a type and uuid
|
21:51:13
|
<djazayeri> i'd guess no, but not sure
|
21:51:22
|
<wyclif> and i was wonderingwhat uuid that is
|
21:52:07
|
<djazayeri> that probably does mean the uuid of the original item
|
21:53:13
|
<wyclif> djazayeri, right, i have just checked and noticed it is the uuid of the original item
|
21:54:19
|
<wyclif> djazayeri, and the imptytype.map only apply to actual concept mapping
|
21:54:51
|
<wyclif> djazayeri, the module has its own mappings between objects that are not necessarily concepts?
|
21:55:12
|
<wyclif> sorry, import.type
|
21:55:14
|
<djazayeri> if you choose to "replace" an incoming item with something you already have, that is preserved
|
21:55:37
|
<wyclif> djazayeri, the existing item replaces the incoming right?
|
21:55:49
|
<djazayeri> yeah
|
21:55:57
|
<wyclif> but an importitem is still created
|
21:56:32
|
<djazayeri> yeah, so if you import again in the future, we can remember the replacement
|
21:56:48
|
<wyclif> djazayeri, and how is the merge handled?
|
21:57:21
|
<wyclif> djazayeri, what takes precendence? field values of existing or incoming
|
21:57:41
|
<wyclif> djazayeri, or you are sent to a page to pick your options
|
21:57:44
|
<djazayeri> wyclif: if you choose "replace" you mean? or in general?
|
21:58:05
|
<wyclif> djazayeri, i mean in the web app i see keep mine, replace
|
21:59:37
|
<djazayeri> wyclif: it depends whether you choose "keep mine" or "overwrite"
|
22:00:02
|
<wyclif> djazayeri, i mean how is merge handled?
|
22:00:04
|
<djazayeri> IIRC all collection properties are merged, but the single-valued properties keep the values of mine or incoming
|
22:00:20
|
<wyclif> djazayeri, ok
|
22:00:55
|
<wyclif> hmm, djazayeri does that mean that the merge import type is only for collections?
|
22:01:06
|
<djazayeri> I don't know about import types
|
22:01:19
|
<wyclif> djazayeri, sorry am asking many questions, am hust trying to get things right for a ticket am working on
|
22:01:24
|
<djazayeri> no, I mean that if you import a concept for example, collections like answers, set members, mappings, are merged
|
22:01:28
|
<djazayeri> what ticket?
|
22:01:37
|
<wyclif> meat-155
|
22:02:13
|
<wyclif> djazayeri, i think the problem is in the same uuid resolver
|
22:03:12
|
<wyclif> sorry! meta-155
|
22:04:47
|
<djazayeri> wyclif: is there code to actually fetch prior saved mappings at all?
|
22:05:06
|
<djazayeri> i.e. is it attempted, but not happening? or was it overlooked?
|
22:05:49
|
<wyclif> djazayeri, none that i can find
|
22:06:09
|
<djazayeri> probably probably nothign to do with the sameuuidresolved then
|
22:06:49
|
<djazayeri> you just need to find all previously-mapped records (if any) for all the items uuids in the package to import
|
22:06:50
|
<wyclif> djazayeri, but the same uuid resolver is the one used to find already imported items by uuid
|
22:06:56
|
<djazayeri> ah okay
|
22:08:16
|
<wyclif> djazayeri, and typically resolvers are the ones used to determine existing items depending on certain sematics
|
22:08:55
|
<wyclif> djazayeri, i will make the changes and let rafa's view
|
22:08:59
|
<wyclif> djazayeri, thanks
|
22:09:33
|
<djazayeri> okay, I'd just assumed that you'd find the previously-mapped records for a set of uuids through a direct service layer call, not through a resolver.
|
22:17:30
|
*** robbyoconnor has joined #openmrs
|
22:17:33
|
*** robbyoconnor has joined #openmrs
|
22:17:33
|
*** ChanServ sets mode: +v robbyoconnor
|
22:35:38
|
*** downeym has joined #openmrs
|
22:35:38
|
*** ChanServ sets mode: +o downeym
|
22:35:38
|
*** OpenMRSBot sets mode: +o downeym
|
22:35:50
|
*** downeym has quit IRC
|
22:43:46
|
*** bryq has quit IRC
|
22:56:09
|
*** wyclif has quit IRC
|
22:58:00
|
*** rafa has joined #openmrs
|
22:58:00
|
*** ChanServ sets mode: +v rafa
|
23:10:20
|
*** rafa has quit IRC
|
23:52:09
|
*** olliejones has left #openmrs
|