| 02:09:46 | *** olliejones has joined #openmrs |
| 02:49:35 | *** pushkar has joined #openmrs |
| 02:52:52 | *** yanokwa has joined #openmrs |
| 02:52:52 | *** ChanServ sets mode: +v yanokwa |
| 03:24:51 | *** upul` has joined #openmrs |
| 03:24:51 | *** ChanServ sets mode: +v upul` |
| 03:31:20 | *** yanokwa has quit IRC |
| 04:55:17 | *** maurya has joined #openmrs |
| 05:30:26 | *** pushkar has quit IRC |
| 05:31:58 | *** maurya has quit IRC |
| 06:10:06 | *** kishoreyekkanti has joined #openmrs |
| 06:24:39 | *** surangak has joined #openmrs |
| 06:29:30 | *** ningosi has joined #openmrs |
| 06:42:29 | *** ningosi has quit IRC |
| 06:52:15 | *** dkayiwa has joined #openmrs |
| 06:58:42 | *** ningosi has joined #openmrs |
| 06:59:14 | *** mvorobey has quit IRC |
| 07:10:51 | *** dkayiwa has quit IRC |
| 07:11:38 | *** dkayiwa has joined #openmrs |
| 07:14:08 | *** ningosi has quit IRC |
| 07:19:28 | *** djazayeri has quit IRC |
| 07:32:36 | *** kishoreyekkanti_ has joined #openmrs |
| 07:34:37 | *** kishoreyekkanti has quit IRC |
| 07:34:37 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 07:38:13 | *** kishoreyekkanti has quit IRC |
| 07:38:32 | *** dkayiwa has quit IRC |
| 07:43:53 | *** dkayiwa has joined #openmrs |
| 07:44:09 | <dkayiwa> sorry i got disconnected after asking :) |
| 07:45:36 | <dkayiwa> am using a pre-maven module |
| 07:46:13 | *** djazayeri has joined #openmrs |
| 07:46:13 | *** ChanServ sets mode: +o djazayeri |
| 08:36:27 | *** bryq has joined #openmrs |
| 08:36:27 | *** ChanServ sets mode: +v bryq |
| 08:38:37 | *** kishoreyekkanti has joined #openmrs |
| 09:02:02 | *** ningosi has joined #openmrs |
| 09:03:11 | *** jmwogi has joined #openmrs |
| 09:07:07 | <jmwogi> dkayiwa, am working on ticket xfrm-42 which needs table widget to be enabled. Checking at the jar file included for GWT, it has the same |
| 09:07:23 | <jmwogi> at what point are you enabling/disabling a widget |
| 09:07:28 | <jmwogi> ? |
| 09:07:58 | *** ningosi has quit IRC |
| 09:08:23 | <dkayiwa> jmwogi: enabling and disabling a widget depends on skip logic or user explicitly specified enabled property value |
| 09:10:23 | <jmwogi> in this case, did you explicitly disable the table widget or how is it placed? |
| 09:26:14 | <dkayiwa> jmwogi: just a moment (15mins) :) |
| 09:26:24 | <jmwogi> :D |
| 09:36:59 | *** mvorobey has joined #openmrs |
| 09:41:35 | *** ningosi has joined #openmrs |
| 09:46:29 | *** ningosi has quit IRC |
| 09:49:35 | *** ningosi has joined #openmrs |
| 09:58:34 | *** bwolfe has joined #openmrs |
| 09:58:34 | *** ChanServ sets mode: +o bwolfe |
| 09:58:55 | *** ningosi has quit IRC |
| 10:01:52 | *** rafa has joined #openmrs |
| 10:01:52 | *** ChanServ sets mode: +v rafa |
| 10:03:24 | *** kishoreyekkanti_ has joined #openmrs |
| 10:03:47 | *** kishoreyekkanti has quit IRC |
| 10:03:58 | *** kishoreyekkanti has joined #openmrs |
| 10:04:27 | *** bwolfe_ has joined #openmrs |
| 10:04:27 | *** ChanServ sets mode: +o bwolfe_ |
| 10:04:33 | *** kishoreyekkanti_ has quit IRC |
| 10:06:46 | *** ningosi has joined #openmrs |
| 10:07:15 | *** bwolfe has quit IRC |
| 10:11:35 | *** ningosi has quit IRC |
| 10:20:27 | <dkayiwa> hi jmwogi |
| 10:41:58 | <dkayiwa> hi rafa |
| 10:43:21 | <rafa> hi dkayiwa |
| 10:43:38 | <dkayiwa> rafa: did you get my email response? :) |
| 10:43:51 | <rafa> dkayiwa: yes, I've just checked |
| 10:43:57 | <dkayiwa> rafa: ok |
| 10:45:03 | <rafa> dkayiwa: your commit looks good |
| 10:45:14 | <dkayiwa> rafa: oh i see |
| 10:45:19 | <rafa> dkayiwa: T should not extend OpenmrsObject |
| 10:45:26 | <dkayiwa> rafa: ok |
| 10:45:30 | <rafa> dkayiwa: it can be anything |
| 10:45:35 | <dkayiwa> rafa: ok |
| 10:45:50 | <rafa> dkayiwa: did you try to run ConceptHandlersFunctionalTest? |
| 10:45:58 | <dkayiwa> rafa: yes |
| 10:46:04 | <rafa> dkayiwa: are the two tests executed? |
| 10:46:09 | <dkayiwa> rafa: yes |
| 10:46:15 | <rafa> dkayiwa: great, I wasn't sure ;) |
| 10:46:24 | <dkayiwa> rafa: ok :) |
| 10:46:39 | <dkayiwa> rafa: but for the second test, am not editing anything :) |
| 10:47:08 | <dkayiwa> rafa: any suggestions? |
| 10:48:26 | <rafa> dkayiwa: You can change uuid :) |
| 10:48:39 | <dkayiwa> ra :D |
| 10:48:50 | <dkayiwa> rafa: will it stay the same object? :) |
| 10:49:02 | <rafa> dkayiwa: ohh sorry right :) |
| 10:49:41 | <rafa> dkayiwa: instead of getExistingItem you can have getUpdatedItem |
| 10:49:55 | <rafa> dkayiwa: in the test save new item first |
| 10:50:00 | <rafa> dkayiwa: then updated item |
| 10:50:03 | <dkayiwa> rafa: oh that is very smart of you!!! :) |
| 10:50:58 | <dkayiwa> rafa: so how would i test of the updated item has been persisted? |
| 10:51:37 | <dkayiwa> rafa: in otherwards, what would the assert test for? |
| 10:52:25 | <rafa> dkayiwa: go ahead and create abstract method assertSameAsUpdated or something |
| 10:52:36 | <dkayiwa> rafa: ok |
| 10:53:44 | <mvorobey> rafa: hi, sorry, I was AFK during yesterday scrum, nevertheless, I didn't have any blockers for that time :) |
| 10:54:10 | <rafa> mvorobey: good :) |
| 11:03:39 | *** surangak has quit IRC |
| 11:10:26 | <rafa> dkayiwa: you don't need to think about any fancy tests, your goal should be to call each method in handlers at least once and make sure it returns or does something without throwing an exception :) |
| 11:10:54 | <dkayiwa> rafa: ok thanks for the tip :) |
| 11:11:02 | <rafa> dkayiwa: you don't need to test "something" if it's not trivial |
| 11:11:14 | <dkayiwa> rafa: ok :) |
| 11:23:44 | <dkayiwa> hi rafa |
| 11:23:52 | <rafa> mvorobey: The thing about a scrum is that it's for you. It's up to you if you join us. If you have any blockers, questions, suggestions, it's your time to speak to the whole team :) |
| 11:23:56 | <rafa> dkayiwa: I'm here |
| 11:24:12 | <dkayiwa> rafa: if T does not extend OpenmrsObject, how will i search for it? |
| 11:24:22 | <dkayiwa> rafa: was using getId and getUUid |
| 11:24:42 | <rafa> dkayiwa: you should use Handlers.getId(object) |
| 11:24:53 | <dkayiwa> rafa: ok |
| 11:33:38 | *** mvorobey has quit IRC |
| 11:33:58 | *** mvorobey has joined #openmrs |
| 11:40:34 | *** upul` has quit IRC |
| 11:46:39 | *** ningosi has joined #openmrs |
| 11:54:55 | *** ningosi has quit IRC |
| 12:02:57 | <dkayiwa> hi rafa |
| 12:03:05 | <rafa> hi |
| 12:03:15 | <dkayiwa> rafa: should i also have a methods like this? typesHandlerGetTypesShouldGetTypes |
| 12:03:24 | <dkayiwa> rafa: that is in BaseHandlersFunctionalTest |
| 12:04:06 | <rafa> dkayiwa: nope skip that one |
| 12:04:14 | <dkayiwa> rafa: ok |
| 12:04:27 | <rafa> dkayiwa: or wait |
| 12:04:33 | <dkayiwa> rafa: ok |
| 12:04:47 | <rafa> dkayiwa: nope skip :) |
| 12:04:55 | <dkayiwa> rafa: ok :) |
| 12:05:39 | *** jmwogi has quit IRC |
| 12:06:17 | <dkayiwa> rafa: do you think it is worth testing methods in MetadataPropertiesHandler ? |
| 12:07:20 | <rafa> dkayiwa: yes, at lest to make sure they don't return null if the javadoc says so |
| 12:07:34 | <dkayiwa> rafa: ok |
| 12:08:29 | <rafa> dkayiwa: you could also check if setters do work :) |
| 12:08:49 | <dkayiwa> rafa: ok :) |
| 12:09:36 | <rafa> dkayiwa: I'm sorry you got this ticket. It's boring but really needed |
| 12:09:59 | <dkayiwa> rafa: :D |
| 12:11:16 | <dkayiwa> rafa: so am testing all setters in MetadataPropertiesHandler ? |
| 12:11:50 | <rafa> dkayiwa: yes |
| 12:11:55 | <dkayiwa> rafa: ok |
| 12:11:56 | <rafa> all three |
| 12:12:18 | <dkayiwa> ok |
| 12:12:37 | <mvorobey> rafa, ok, I got it, thanks :) |
| 12:13:42 | <rafa> mvorobey: np |
| 12:23:34 | <bwolfe_> rafa, what did you want to discuss on the design call today? |
| 12:23:37 | *** bwolfe_ is now known as bwolfe |
| 12:23:52 | <rafa> https://tickets.openmrs.org/browse/META-177 |
| 12:24:01 | <rafa> I'll add a better description in a sec |
| 12:26:42 | <rafa> bwolfe: see now |
| 12:29:19 | <rafa> bwolfe: as well if anyone has a good name for https://tickets.openmrs.org/browse/META-164 |
| 12:30:02 | *** dkayiwa has quit IRC |
| 12:30:12 | <bwolfe> rafa, can you give some more background on META-177? Perhaps what is it now and/or why you want to change it? |
| 12:30:34 | <rafa> bwolfe: good point, I'll add that to the ticket as well :) |
| 12:35:57 | *** dkayiwa has joined #openmrs |
| 12:41:44 | *** kishoreyekkanti has quit IRC |
| 12:47:32 | <rafa> bwolfe: META-177 is ready |
| 12:53:15 | *** wyclif has quit IRC |
| 13:00:41 | *** james_regen has joined #openmrs |
| 13:00:41 | *** ChanServ sets mode: +v james_regen |
| 13:24:48 | <dkayiwa> hi rafa |
| 13:25:03 | <rafa> hi dkayiwa |
| 13:25:24 | <dkayiwa> rafa: as for MetadataPropertiesHandler, is the description also supposed to be NOT NULL? |
| 13:25:39 | <rafa> dkayiwa: yes |
| 13:25:42 | <dkayiwa> rafa: or was it a slip of the keyboard? :) |
| 13:26:03 | <rafa> dkayiwa: haha |
| 13:26:08 | <rafa> dkayiwa: it needs to be not null |
| 13:26:15 | <rafa> dkayiwa: I don't like NPE ;) |
| 13:26:16 | <dkayiwa> rafa: ok |
| 13:26:24 | <dkayiwa> rafa: 8) |
| 13:26:25 | <rafa> dkayiwa: and checking for null all the time ;) |
| 13:26:32 | <dkayiwa> rafa: hahahah |
| 13:26:33 | <dkayiwa> :) |
| 13:26:40 | <rafa> dkayiwa: it's better to see empty string :D |
| 13:26:48 | <dkayiwa> rafa: sure |
| 13:26:59 | <dkayiwa> which will be reset to null :) |
| 13:27:30 | <rafa> dkayiwa: it's only getter |
| 13:27:40 | <dkayiwa> rafa: is the id nullable? |
| 13:27:52 | <rafa> dkayiwa: yes, because it's not always supported |
| 13:27:58 | <dkayiwa> rafa: ok |
| 13:28:14 | <rafa> dkayiwa: no, what I meant is that for new items it must be null :) |
| 13:28:39 | <dkayiwa> rafa: ok. but not for uuid? :) |
| 13:28:50 | <rafa> dkayiwa: uuid must not be null :) |
| 13:28:58 | <dkayiwa> rafa: ok |
| 13:30:10 | <rafa> dkayiwa: if you're not bored too much, you could improve javadocs if it doesn't say so |
| 13:30:29 | <dkayiwa> rafa: ok :) |
| 13:31:40 | *** pushkar has joined #openmrs |
| 13:45:05 | <mvorobey> rafa: saw your comments on review for META-158 |
| 13:45:30 | <mvorobey> rafa: can you clarify me am I wright? |
| 13:45:38 | <rafa> mvorobey: sure |
| 13:45:39 | <mvorobey> rafa: if the first page with concepts has been requested, we just add the concept, that was found by id (case when first == 0). Otherwise (first != 0), we need to decrement by 1 the lower and maximal bounds of concepts result page. |
| 13:46:05 | <mvorobey> to prevent loss of the last concept from first page |
| 13:46:25 | <rafa> mvorobey: if (first != 0) decrement just the lower bound |
| 13:46:29 | <rafa> mvorobey: max should stay the same |
| 13:47:05 | <rafa> mvorobey: you would decrease the higher bound but max stay the same |
| 13:47:09 | <mvorobey> saw, user will be responded with 11 for example concepts? |
| 13:47:34 | <rafa> mvorobey: no it's max so if he says 10 he'll get 10 but starting from first + 1 |
| 13:47:46 | <mvorobey> a-ha ) |
| 13:47:52 | <mvorobey> rafa: thanx |
| 13:48:00 | <mvorobey> max - its a number of results |
| 13:48:05 | <rafa> mvorobey: correct! |
| 13:48:36 | <mvorobey> rafa: I gotta add that fix ASAP |
| 13:48:58 | <rafa> mvorobey: should be easy and you're done :D |
| 13:49:16 | <mvorobey> do I need to update review once more time after that? |
| 13:49:31 | <mvorobey> rafa: ? |
| 13:49:32 | <rafa> mvorobey: no need |
| 13:49:34 | <mvorobey> ok |
| 13:49:40 | <mvorobey> thanx, rafa |
| 13:49:44 | <mvorobey> a lot :) |
| 13:50:01 | <rafa> mvorobey: no problem :) |
| 13:51:12 | <rafa> mvorobey: actually change the name of the variable to maxResults as it's in the interface |
| 13:51:25 | <rafa> mvorobey: it'll be less confusing |
| 13:51:43 | <mvorobey> rafa: ok, it's good :) |
| 13:51:45 | <rafa> mvorobey: and firstResult |
| 13:51:57 | <rafa> mvorobey: you now how to refactor code in eclipse right? |
| 13:52:06 | <mvorobey> yep |
| 13:52:22 | <mvorobey> I lust refactored max results |
| 13:52:26 | <mvorobey> just |
| 13:52:27 | <rafa> mvorobey: good |
| 13:52:29 | <mvorobey> sorry |
| 13:53:04 | *** wyclif has joined #openmrs |
| 14:05:35 | <dkayiwa> hi rafa |
| 14:05:42 | <rafa> hi dkayiwa |
| 14:05:52 | <dkayiwa> rafa: should i test the four methods in the MetadataSearchHandler ? |
| 14:06:04 | <rafa> dkayiwa: yes |
| 14:06:12 | <dkayiwa> rafa: ok thanks |
| 14:06:51 | <rafa> dkayiwa: you're actually testing them already when you save and search if it's saved :) |
| 14:07:07 | <dkayiwa> rafa: ohhhhh |
| 14:07:14 | <rafa> dkayiwa: don't duplicate tests if not needed |
| 14:07:22 | <dkayiwa> rafa: so i should not test them again? |
| 14:07:34 | <rafa> dkayiwa: make sure each method is called at least once |
| 14:07:43 | <dkayiwa> rafa: ok |
| 14:07:47 | <rafa> dkayiwa: so if you called getItem somewhere don't test it again |
| 14:07:54 | <dkayiwa> rafa: ok |
| 14:07:56 | <rafa> dkayiwa: but getItems still needs to be tested |
| 14:08:02 | <dkayiwa> rafa: ok |
| 14:08:52 | <mvorobey> rafa: just FYI: I have already added new patch for META-158 |
| 14:09:22 | <rafa> mvorobey: thanks! |
| 14:10:04 | <mvorobey> rafa: np, proszÄ |
| 14:11:37 | *** maurya has joined #openmrs |
| 14:12:03 | <rafa> mvorobey: do you have commit rights to our svn? |
| 14:13:11 | <mvorobey> rafa: no, I don't have them yet |
| 14:13:33 | <rafa> mvorobey: go ahead and request to be able to commit to the mds module |
| 14:14:08 | *** burke has joined #openmrs |
| 14:14:08 | *** ChanServ sets mode: +o burke |
| 14:14:23 | <burke> I take it there's no OpenMRS University today? |
| 14:15:08 | <rafa> burke: I don't know |
| 14:15:12 | <rafa> mvorobey: https://wiki.openmrs.org/display/docs/Subversion+Code+of+Conduct |
| 14:15:13 | <OpenMRSBot> <http://ln-s.net/97kC> (at wiki.openmrs.org) |
| 14:15:17 | <mvorobey> rafa: ok, will do it |
| 14:16:01 | <rafa> mvorobey: cc me in the e-mail |
| 14:17:25 | <mvorobey> rafa: ok |
| 14:20:33 | *** bwolfe has quit IRC |
| 14:23:44 | *** opieng has joined #openmrs |
| 14:45:50 | <dkayiwa> hi rafa |
| 14:46:08 | <dkayiwa> rafa: do i need to test MetadataPriorityDependenciesHandler ? |
| 14:50:39 | *** kishoreyekkanti has joined #openmrs |
| 14:53:24 | *** mvorobey has quit IRC |
| 15:01:24 | <rafa> dkayiwa: yes, but the method getItemDependencies should return an empty list by default so that one will override it only if needed |
| 15:01:53 | <dkayiwa> rafa: ok |
| 15:02:32 | <dkayiwa> rafa: so the check in the base test class should be to ensure that we get an empty list? |
| 15:03:07 | <rafa> dkayiwa: the check in the base test should ensure that we'll get what getItemDependencies return and it's an empty list by default :) |
| 15:03:55 | *** burke has quit IRC |
| 15:04:15 | <dkayiwa> rafa: ok :) |
| 15:42:37 | *** pushkar has quit IRC |
| 16:13:53 | *** rfriedman has joined #openmrs |
| 16:13:55 | *** dkayiwa has quit IRC |
| 16:14:15 | *** dkayiwa has joined #openmrs |
| 16:14:31 | <rfriedman> djazayeri: hey darius, happy new year, got a minute? |
| 16:15:02 | <djazayeri> rfriedman: in ~30 |
| 16:15:24 | <rfriedman> djazayeri: ok, ping me |
| 16:16:44 | *** dkayiwa_ has joined #openmrs |
| 16:18:21 | *** dkayiwa has quit IRC |
| 16:18:22 | *** dkayiwa_ is now known as dkayiwa |
| 16:29:32 | *** jmwogi has joined #openmrs |
| 16:31:41 | *** maurya has quit IRC |
| 16:38:15 | *** mvorobey has joined #openmrs |
| 16:49:22 | <wyclif> hi rafa |
| 16:49:29 | <djazayeri> hi rfriedman |
| 16:49:40 | <rfriedman> djazayeri: hi darius |
| 16:49:56 | <rfriedman> due to some file corruption, i had to reinstall eclipse |
| 16:50:00 | <djazayeri> okay |
| 16:50:18 | <rfriedman> i still have my old workspace and some modified files i'd like to preserve |
| 16:50:44 | <rfriedman> can i just copy them from the old to the new or do i need to open the new in Eclipse and overlay with the contents of the old? |
| 16:51:03 | <djazayeri> Do you want to preserve your entire old workspace? |
| 16:51:10 | <rafa> hi wyclif |
| 16:51:29 | <rfriedman> djazayeri: well, 80% is the same in both, but yes |
| 16:51:33 | <djazayeri> rfriedman: when you start eclipse (assuming you haven't checked the "always use this one" box) it asks you what workspace you want to open |
| 16:51:50 | <rfriedman> djazayeri: yes, but it can't open the workspace due to the file corruption |
| 16:52:04 | <djazayeri> I see. |
| 16:52:09 | <rfriedman> it's not totally clear whether the project file was bad or whether an add-in got corrupted |
| 16:52:20 | <wyclif> rafa, where is the onSave method referred to for meta-155? |
| 16:52:53 | <djazayeri> rfriedman: I can thtink of two different approaches |
| 16:52:58 | <wyclif> and what resolver handles that |
| 16:53:13 | <djazayeri> 1. import project, to import projects one by one from the old workspace |
| 16:53:16 | <rafa> wyclif: it's a method in an object which is being saved |
| 16:53:23 | <djazayeri> (easier, maybe dangerous if one is bad) |
| 16:53:33 | <rafa> wyclif: HtmlForm class has this method for instance |
| 16:53:50 | <rafa> wyclif: to perform some operations just before the object is saved by the mds |
| 16:54:03 | <djazayeri> rfriedman: 2. at the command line, do an svn diff of each project you want to bring over, and save that as a patch. Then check out the project again in the new workspace and apply the patch |
| 16:54:08 | <djazayeri> (more work) |
| 16:54:43 | <wyclif> rafa, ok |
| 16:54:54 | <djazayeri> rafa: maybe if you point wyclif to where specifically the onSave method is called from? |
| 16:55:07 | <rafa> wyclif: it's called in MetadataSharingServiceImpl#prepareItemsToSave |
| 16:55:15 | <rfriedman> djazayeri: am i going to run into version problems with svn like others have been complaining of? |
| 16:55:40 | <rafa> wyclif: in initIncomingToSave |
| 16:55:49 | <rfriedman> i don't normally install standalone svn as I do maven |
| 16:55:57 | <djazayeri> rfriedman: what have people been complaining of? |
| 16:56:28 | <djazayeri> rfriedman: svn should work fine, regardless of what client you're using. |
| 16:56:33 | <rfriedman> djazayeri: sorry, can't remember, but rafa among others was complaining |
| 16:56:58 | <rafa> rfriedman: don't install the latest one |
| 16:57:17 | <djazayeri> the latest svn client? or eclipse plugin? |
| 16:57:38 | <rfriedman> djazayeri: svn client. the eclipse plugin works ok |
| 16:57:48 | <rafa> djazayeri: both svn client and eclipse plugin they depend on each other |
| 16:58:24 | <rafa> svn 1.7 stores data differently |
| 16:58:27 | <rfriedman> rafa, oh i have had no problems with new subclipse, but i don't have svn installed |
| 16:58:37 | <rafa> it's not backward compatible with 1.6 |
| 16:58:52 | <djazayeri> seriously? |
| 16:58:54 | <djazayeri> meh |
| 16:59:12 | <rafa> yeah I've made that mistake and upgraded |
| 16:59:31 | <rafa> djazayeri: then needed to go back to 1.6 and checkout everything again |
| 17:00:09 | <rafa> djazayeri: OpenMRS 1.6 ant build didn't work for instance |
| 17:01:21 | <rafa> rfriedman: if you use only maven to build you should be fine with the latest though |
| 17:01:46 | <rfriedman> rafa, djazayeri, tks |
| 17:01:50 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: XForms 4.0.9.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=xforms&version=&4.0.9.1> |
| 17:02:16 | <rfriedman> djazayeri: do i need to do the diff separately on the 3 components of the module or just the top level/ |
| 17:02:19 | <rfriedman> level? |
| 17:02:36 | <djazayeri> rfriedman: should be able to do it on the root folder |
| 17:02:42 | <rfriedman> djazayeri: tks |
| 17:02:51 | *** rfriedman has quit IRC |
| 17:02:52 | <djazayeri> I would try import project first, if it were me. |
| 17:23:21 | *** dkayiwa has quit IRC |
| 17:25:14 | <mvorobey> rafa: I tried to commit to svn patch for META-158, but it seems that I still do not have privileges :) |
| 17:25:57 | <rafa> mvorobey: You'll get a message when privileges are granted :) |
| 17:26:50 | *** djazayeri1 has joined #openmrs |
| 17:27:14 | *** djazayeri has quit IRC |
| 17:27:18 | <mvorobey> oh, thanx rafa |
| 17:29:43 | <Mkop> I need to get myself -v'd in here. I don't like the fake appearance of looking like I'm someone people should care about |
| 17:34:03 | *** djazayeri has joined #openmrs |
| 17:34:03 | *** ChanServ sets mode: +o djazayeri |
| 17:37:24 | *** djazayeri1 has quit IRC |
| 17:41:35 | *** dkayiwa has joined #openmrs |
| 17:50:06 | *** bwolfe has joined #openmrs |
| 17:50:06 | *** ChanServ sets mode: +o bwolfe |
| 17:50:28 | <rafa> Mkop: haha |
| 17:50:51 | <rafa> Mkop: I haven't seen you before. Nice to meet you! |
| 17:51:50 | <Mkop> I used to hang out here a couple years ago. applied for GSOC, submitted a couple random patches, didn't get in. since then my only involvement with OpenMRS has been sporadic hanging out in IRC |
| 17:52:18 | <Mkop> now I hang out here sometimes since I work in health informatics, you guys work in health informatics, and maybe I can learn a thing or two |
| 17:52:33 | <bwolfe> Mkop, where are you working? |
| 17:52:59 | <Mkop> I work at Montefiore Medical Center in Bronx, NY |
| 17:53:16 | <Mkop> I am a programmer in the pathology department |
| 17:53:30 | <bwolfe> sounds like a dead end job ;-) |
| 17:53:46 | <Mkop> developing tools on a WAMP stack to supplement the out-of-box LIS |
| 17:53:54 | <Mkop> bwolfe: :-) |
| 17:54:26 | <Mkop> the work is fascinating, but you're right, there isn't much room for formal advancement |
| 17:54:49 | <Mkop> I've only been here for six months but I am enjoying it a lot |
| 17:56:58 | <Mkop> it's amazing how much work can be accomplished by connecting the dots with small tools. in the world where everything is enterprise and takes years to purchase and configure, I can grind out an app in a month or two that beats out current systems in certain ways |
| 17:59:06 | <bwolfe> Mkop, emphasis on DEAD |
| 17:59:23 | <Mkop> oh. didn't catch that joke before |
| 17:59:25 | <djazayeri> bwolfe: I got the joke |
| 17:59:25 | <djazayeri> :-) |
| 17:59:31 | <bwolfe> :-) |
| 17:59:31 | <Mkop> here, pathology dept = lab |
| 17:59:46 | <bwolfe> oh, hmm, less funny then |
| 18:00:03 | <bwolfe> Mkop, and if you build enough of htose small apps you have yourself job security |
| 18:00:12 | <Mkop> 95% of what I do is for clinical pathology, 5% anatomical pathology. of AP, a small fraction is autopsies |
| 18:00:57 | <Mkop> yeah, my coworker who's been here for 5 years has to do more maintenance work than I do :-) |
| 18:02:44 | <rafa> guys we need to pause this discussion for our daily scrum :) |
| 18:03:18 | <rafa> hi bwolfe, djazayeri, wyclif, dkayiwa, mvorobey |
| 18:03:27 | <mvorobey> hello |
| 18:04:11 | *** dawn_ has joined #openmrs |
| 18:04:14 | <djazayeri> hi |
| 18:04:23 | <djazayeri> !scrumon rafa |
| 18:04:23 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster rafa- you may begin when ready. |
| 18:04:24 | <rafa> hi dawn_ :) |
| 18:04:31 | <dkayiwa> hey |
| 18:04:39 | <dawn_> bwolfe: djazayeri rafa dkayiwa wyclif : sorry i'm late and hi |
| 18:04:50 | <rafa> !scrumon dawn_ |
| 18:04:50 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn_- you may begin when ready. |
| 18:04:52 | <rafa> :) |
| 18:05:01 | <dkayiwa> :D |
| 18:05:02 | <dawn_> :D |
| 18:05:27 | <dawn_> Today's order: rafa , dkayiwa , wyclif , bwolfe , djazayeri |
| 18:05:37 | <wyclif> ok |
| 18:05:38 | <rafa> Today: |
| 18:05:38 | <rafa> * My time is leaking somwewhere. I need to manage it better. I felt like I was only reviewing and IRCing today with no actual coding :( |
| 18:05:38 | <rafa> * Reviewed and discussed tickets |
| 18:05:38 | <rafa> Here are our stats: |
| 18:05:38 | <rafa> - 3 tickets ready for work (1 should, 1 could, 1 non-essential) |
| 18:05:38 | <rafa> - 7 tickets closed |
| 18:05:38 | <rafa> - 11 in-progress with only 6 not reviewed yet (4 mine, shame on me) |
| 18:05:39 | <rafa> - 2 MUST tickets not committed yet: META-170 (me), META-176 (me) |
| 18:05:39 | <rafa> * Design call |
| 18:05:40 | <rafa> Tomorrow: |
| 18:05:40 | <rafa> * Back to coding! |
| 18:05:41 | <rafa> No blockers. |
| 18:05:50 | <dkayiwa> Been doing some commits for: Testing handlers - META-160 |
| 18:05:50 | <dkayiwa> Now working on the most recent review comments for META-160 and adding more tests for Privilege, Role, and ProgramWorkflow |
| 18:05:51 | <dkayiwa> No Blockers |
| 18:06:56 | <wyclif> yesterday:(worked half day because i had a biopsy at the DOC appointment) |
| 18:06:56 | <wyclif> * META-168 - Importing concepts from 1.6 to 1.7+ and vice versa |
| 18:06:56 | <wyclif> today: |
| 18:06:56 | <wyclif> * design call |
| 18:06:56 | <wyclif> * META-182 - Cannot run Metadata Sharing and REST Web Services modules together |
| 18:06:57 | <wyclif> * Make changes as per pending review comment for META-169 - Exporting metadata packages on-the-fly |
| 18:06:59 | <wyclif> * Wiki documentation of how to use the MDS webservice(exporting metadata packages on the fly) |
| 18:07:01 | <wyclif> * META-155 - incomingToExisting map passed to onSave method does not include objects that have previously been mapped to an existing object |
| 18:07:04 | <wyclif> Blockers: none |
| 18:07:32 | <bwolfe> !ticket META-182 |
| 18:07:34 | <OpenMRSBot> bwolfe: [#META-182] Cannot run Metadata Sharing and REST Web Services modules together - OpenMRS JIRA - https://tickets.openmrs.org/browse/META-182 |
| 18:08:51 | <bwolfe> interesting. |
| 18:09:03 | <bwolfe> oh, I was sitting here waiting for hte next guy. |
| 18:09:09 | <rafa> :P |
| 18:09:11 | <bwolfe> today: |
| 18:09:12 | <bwolfe> email backlog |
| 18:09:12 | <bwolfe> reviewed TRUNK-37 |
| 18:09:12 | <bwolfe> reviewed OCC-10 |
| 18:09:12 | <bwolfe> reviewed TRUNK-1800 |
| 18:09:12 | <bwolfe> followup to MDS-172 |
| 18:09:14 | <bwolfe> backported TRUNK-2916 |
| 18:09:16 | <bwolfe> set up for design call |
| 18:09:18 | <bwolfe> debug sync with wycliffe |
| 18:09:20 | <bwolfe> design call |
| 18:09:22 | <bwolfe> pm call |
| 18:09:24 | <bwolfe> no blockers |
| 18:09:56 | <wyclif> !ticket TRUNK-37 |
| 18:09:57 | <OpenMRSBot> wyclif: [#TRUNK-37] Add logging table for merged patients - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-37 |
| 18:10:05 | <djazayeri> !ticket occ-10 |
| 18:10:06 | <OpenMRSBot> djazayeri: [#OCC-10] Automatic Name Mapping page - OpenMRS JIRA - https://tickets.openmrs.org/browse/occ-10 |
| 18:10:14 | <djazayeri> !ticket trunk-1800 |
| 18:10:15 | <OpenMRSBot> djazayeri: [#TRUNK-1800] Locale does not work property when using "Become This User" - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-1800 |
| 18:10:27 | <djazayeri> !ticket mds-172 |
| 18:10:28 | <OpenMRSBot> djazayeri: Issue Does Not Exist - OpenMRS JIRA - https://tickets.openmrs.org/browse/mds-172 |
| 18:10:37 | <djazayeri> !ticket meta-172 |
| 18:10:38 | <OpenMRSBot> djazayeri: [#META-172] Preserve IDs between systems - OpenMRS JIRA - https://tickets.openmrs.org/browse/meta-172 |
| 18:11:02 | <djazayeri> ben, you get a thumbs-down for not including some level of summary in your bullets. :-) |
| 18:11:11 | <djazayeri> my turn |
| 18:11:17 | <djazayeri> Tuesday 10-Jan-2012 |
| 18:11:17 | <djazayeri> * discussed a reporting ticket with Mike (for Andy) |
| 18:11:17 | <djazayeri> * plan a meeting in Boston next week |
| 18:11:17 | <djazayeri> * META-181 (warn about module version differences when importing) |
| 18:11:17 | <djazayeri> Wednesday 11-Jan-2012 |
| 18:11:18 | <djazayeri> * catchup call with TW |
| 18:11:18 | <djazayeri> * design forum |
| 18:11:19 | <djazayeri> * project management call |
| 18:11:19 | <djazayeri> * address review comments on META-181 |
| 18:11:20 | <djazayeri> * do a mockup of a new Configuration page for MDS |
| 18:11:20 | <djazayeri> * another MDS ticket? |
| 18:11:21 | <bwolfe> the summary was in white text |
| 18:11:21 | <djazayeri> no blockers |
| 18:12:25 | <djazayeri> That's all |
| 18:12:29 | <dawn_> !scrumoff dawn |
| 18:12:29 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 18:12:31 | <djazayeri> Did anyone have any discussion points? |
| 18:12:49 | <dawn_> I was just about to ask the same :) |
| 18:13:04 | <bwolfe> I just one have comment. not really a discussion point |
| 18:13:12 | <bwolfe> rafa: welcome to the world of running sprints. :-) |
| 18:13:26 | <djazayeri> let's turn that into a discussion: |
| 18:13:31 | <djazayeri> rafa: welcome to the world of running sprints? |
| 18:13:35 | <rafa> bwolfe: haha, yeah how do you code? |
| 18:14:04 | <rafa> I feel like I should close my e-mail and irc for that to happen |
| 18:14:15 | <wyclif> he he he |
| 18:14:35 | <djazayeri> rafa: that's a fair strategy |
| 18:14:51 | <bwolfe> rafa, you sneak it in. |
| 18:14:57 | <djazayeri> the theory is that if you're directing 3-4 others to write code, that'll get more done than just what you write. |
| 18:14:59 | *** suranga has joined #openmrs |
| 18:15:13 | <djazayeri> but if we're not as efficient as you⦠:-) |
| 18:15:20 | <bwolfe> you have to ignore email/irc for a while if you want to get something coded |
| 18:15:31 | <bwolfe> but then again, what darius said |
| 18:16:18 | <rafa> yeah it's a matter of finding a good balance |
| 18:17:03 | <djazayeri> rafa: you ready to lead discussion of the import mode issue on the design forum? |
| 18:17:19 | <wyclif> i think it is worth it when you write less code and ensure that committed code is correct semantically |
| 18:17:32 | <djazayeri> you should probably email the dev list saying we'll discuss that, so interested people know to call in. |
| 18:17:36 | <rafa> djazayeri: yes |
| 18:17:56 | <dawn_> bwolfe: djazayeri rafa : are these bits of info worth including on the "Being a Sprint Leader" page? Maybe a "Time Management Tips" section or something? |
| 18:18:32 | <rafa> djazayeri: err I should have done it earlier |
| 18:18:41 | <djazayeri> or at least something about setting expecations |
| 18:19:05 | <bwolfe> dawn_, you want to start that and we'll add to it? |
| 18:19:21 | <djazayeri> dawn_: sounds like a good idea. rafa, can you make yourself a to-do to review the Being a Sprint Leader page after this sprint is done, and make some changes? |
| 18:19:38 | *** suranga has quit IRC |
| 18:19:46 | <djazayeri> I'm happy to help with wording of anything, but you should have the best perspective on what the page should say. |
| 18:19:52 | <dawn_> bwolfe: I can b/c i'm on the page right now |
| 18:20:56 | <rafa> djazayeri: yeah I'll be happy to write from a newbie perspective |
| 18:21:25 | *** djazayeri has quit IRC |
| 18:21:29 | *** djazayeri1 has joined #openmrs |
| 18:21:47 | *** djazayeri1 is now known as djazayeri |
| 18:21:47 | *** ChanServ sets mode: +o djazayeri |
| 18:22:15 | <djazayeri> why do cheap wireless routers suck? |
| 18:22:27 | <dkayiwa> :D |
| 18:22:38 | <dkayiwa> CHEAP |
| 18:23:38 | <bwolfe> djazayeri, which one do you have? |
| 18:24:07 | <djazayeri> linksys |
| 18:24:23 | <djazayeri> wrt54g2 v1 |
| 18:24:31 | <bwolfe> djazayeri, have you taken the linksys software off of it? its actually a nice piece of hardware |
| 18:24:54 | <bwolfe> try out "tomato" or "ddwrt" (the former being better if they support v1) |
| 18:25:13 | <djazayeri> I haven't done anything but plug wires in. (and then unplug and replug them) |
| 18:25:17 | <djazayeri> maybe i'll try that |
| 18:25:20 | <djazayeri> I meant v2 actually |
| 18:25:32 | <bwolfe> iirc, tomato supports up to v4 or v5 |
| 18:25:33 | <djazayeri> oh, no, v1 is right |
| 18:25:39 | <bwolfe> I have v8, so I have ot use ddwrt :-/ |
| 18:30:01 | <djazayeri> rafa: there's still time to send that dev list email... |
| 18:30:19 | *** bwolfe_ has joined #openmrs |
| 18:30:20 | *** ChanServ sets mode: +o bwolfe_ |
| 18:30:27 | <rafa> djazayeri: it should be there |
| 18:30:35 | <djazayeri> ah, okay, maybe slow delivery |
| 18:32:50 | *** bwolfe has quit IRC |
| 18:33:48 | *** suranga has joined #openmrs |
| 18:35:39 | *** bwolfe_ is now known as bwolfe |
| 18:36:26 | *** dawn_ has quit IRC |
| 18:43:11 | <wyclif> hi rafa: |
| 18:43:15 | <mvorobey> rafa: about !ticket META-183 : may be we need to add link to configure page into that message as follows: "You need to <a href="configure.form" target="_blank">configure</a> your server's public URL before you can publish packages. |
| 18:43:20 | <mvorobey> ? |
| 18:43:34 | <rafa> mvorobey: even better |
| 18:43:39 | <rafa> hi wyclif |
| 18:43:40 | <mvorobey> rafa: ok |
| 18:43:40 | <wyclif> rafa, this is the list, i will be making the following changes to all: |
| 18:43:44 | <wyclif> rafa:ObjectMerger |
| 18:43:44 | <wyclif> ConceptMapper |
| 18:43:44 | <wyclif> ReplaceMethodInovker |
| 18:43:44 | <wyclif> SubscriptionUpdaterImpl |
| 18:43:44 | <wyclif> OpenmrsObjectVisitor |
| 18:43:45 | <wyclif> ExceptionResolver only needs the module id prefix |
| 18:43:48 | <wyclif> All validators iin package: org.openmrs.module.metadatasharing.model.validator |
| 18:43:50 | <wyclif> All resolvers in package: org.openmrs.module.metadatasharing.resolver.impl |
| 18:43:52 | <wyclif> All Serializers in package: org.openmrs.module.metadatasharing.serializer |
| 18:43:54 | <wyclif> All views in package: org.openmrs.module.metadatasharing.web.view |
| 18:44:11 | <rafa> wyclif: yeah go ahead |
| 18:44:26 | <wyclif> rafa, ExceptionResolver only needs a prefix |
| 18:44:31 | <wyclif> rafa, ok |
| 18:52:14 | <wyclif> rafa, ReplaceMethodInovker is miss-spelt |
| 18:52:55 | <rafa> wyclif: good catch refactor |
| 18:53:05 | <bwolfe> Inovker sounds polish. :-) |
| 18:53:10 | <bwolfe> or maybe russian |
| 18:53:11 | <rafa> no no :P |
| 18:54:12 | <rafa> bwolfe: Wywolujacy is polish :D |
| 18:54:24 | <bwolfe> rafa, hhaa |
| 18:54:27 | <bwolfe> haha |
| 18:54:42 | <bwolfe> thank you for not using polish named variables :-) |
| 18:54:51 | <rafa> bwolfe: hahaha |
| 18:58:25 | *** mvorobey has quit IRC |
| 18:59:13 | *** suranga has quit IRC |
| 19:06:34 | *** suranga has joined #openmrs |
| 19:29:10 | *** jmwogi has quit IRC |
| 19:31:26 | *** kishoreyekkanti has quit IRC |
| 19:39:54 | *** dkayiwa has quit IRC |
| 19:41:01 | *** dkayiwa has joined #openmrs |
| 19:52:05 | *** dkayiwa_ has joined #openmrs |
| 19:53:17 | *** dkayiwa has quit IRC |
| 19:53:17 | *** dkayiwa_ is now known as dkayiwa |
| 20:01:44 | *** suranga has quit IRC |
| 20:14:15 | *** dkayiwa has quit IRC |
| 20:16:55 | *** dkayiwa has joined #openmrs |
| 20:53:48 | *** james_regen has left #openmrs |
| 21:07:44 | *** burke has joined #openmrs |
| 21:07:44 | *** ChanServ sets mode: +o burke |
| 21:13:50 | *** bwolfe has quit IRC |
| 21:20:17 | *** dkayiwa has quit IRC |
| 21:35:28 | <rafa> djazayeri: thanks Darius for your help on the call! I fee like I still have a lot to learn on how to shape a solution out of requirements :) |
| 21:35:48 | <rafa> and I wish the call was not that late and my mind was fresh ;) |
| 22:13:49 | *** wyclif has quit IRC |
| 22:22:46 | *** bryq has left #openmrs |
| 22:43:02 | *** burke has quit IRC |
| 22:48:00 | <djazayeri> rafa: I think it would be good to work on some more formal requirements gathering methods |
| 22:48:32 | <djazayeri> where we actually go to the "customer" and ask what they want, then formulate a design based on that. |
| 22:49:01 | <djazayeri> Perhaps for your next sprint we can do this more formally |
| 22:49:08 | <djazayeri> rafa: remind ben and I. :-) |
| 22:49:30 | <rafa> djazayeri: It would be great. I don't have any experience with that. |
| 22:49:37 | <rafa> djazayeri: nothing I've learnt at the university applies in real life :/ |
| 22:50:51 | <djazayeri> MDS has also been a bit tricky, in that I conceived the idea for how I thought it had to work, and brought you in, without doing much formal requirements gathering, and definitely without documenting it. :-) |
| 22:51:29 | <rafa> djazayeri: it was good at that point :) |
| 22:51:48 | <djazayeri> I don't regret it. :-) |
| 22:51:56 | <rafa> djazayeri: but now it would help to have some formalism in place |
| 22:52:25 | <djazayeri> For the specific thing we talked about today, perhaps it's good to write down a bit more formally what the "3 major use cases" are. |
| 22:52:46 | <djazayeri> And do a mockup of what the "asking the 5 question" step will look like |
| 22:53:42 | <djazayeri> gotta run for a bit |
| 22:53:43 | <djazayeri> tty tomorrow |
| 23:24:07 | <djazayeri> rafa: regarding META-181 and your comment "It should be pretty easy to go here through packageItems and search for classes from modules we're not running and add a nicer error than ClassNotFoundException later on"... |
| 23:24:47 | <rafa> djazayeri: yes? |
| 23:25:02 | <djazayeri> you mean I should look at the package names of all the included metadata items, for org.openmrs.module.XYZ? |
| 23:25:16 | <rafa> djazayeri: something like that |
| 23:25:51 | <djazayeri> Okay, I was wondering if you had some other clever idea. |
| 23:25:57 | <djazayeri> I'll do that for now. |
| 23:26:23 | <rafa> djazayeri: well or else we could just display a nicer page for ClassNotFoundException |
| 23:26:42 | <djazayeri> or both |
| 23:27:02 | <rafa> djazayeri: leave it for now as it is |
| 23:27:17 | <rafa> djazayeri: it's not that important |
| 23:27:52 | <djazayeri> well, I'll do a quick regex-based check for org.openmrs.module.(*). and warn about any missing modules there. |
| 23:28:17 | <rafa> djazayeri: cool :) |
| 23:29:22 | <rafa> djazayeri: time for me |
| 23:29:26 | <rafa> good night! |
| 23:29:30 | <djazayeri> gnight |
| 23:30:17 | *** rafa has quit IRC |