IRC Chat : 2012-01-09 - OpenMRS

02:37:25 *** nathanleiby has joined #openmrs
02:55:53 *** morristic has joined #openmrs
04:34:23 *** upul` has joined #openmrs
04:34:23 *** ChanServ sets mode: +v upul`
04:40:54 *** surangak has joined #openmrs
06:24:57 *** bwolfe_ has joined #openmrs
06:24:57 *** ChanServ sets mode: +o bwolfe_
06:27:11 *** nathanleiby has quit IRC
06:33:42 *** r0bby has joined #openmrs
06:33:42 *** ChanServ sets mode: +v r0bby
06:46:16 *** robbyoconnor has quit IRC
06:46:16 *** morristic has quit IRC
06:46:17 *** wyclif has quit IRC
06:49:46 *** morristic has joined #openmrs
06:49:46 *** wyclif has joined #openmrs
07:07:08 *** morristic has quit IRC
07:37:39 *** bryq has joined #openmrs
07:37:39 *** ChanServ sets mode: +v bryq
07:43:07 *** dkayiwa has joined #openmrs
07:57:36 *** bryq has quit IRC
09:25:23 *** rafa has joined #openmrs
09:25:23 *** ChanServ sets mode: +v rafa
09:51:11 <dkayiwa> hi rafa '
09:51:20 <rafa> dkayiwa: hi Daniel!
09:51:27 <rafa> dkayiwa: you're back :)
09:51:29 <dkayiwa> rafa: happy new year!!!!
09:51:33 <rafa> dkayiwa: happy new year!
09:51:34 <dkayiwa> rafa: oh yes
09:51:39 <dkayiwa> thanks
09:51:54 <dkayiwa> rafa: have you ever run metadatasharing module on 1.9 ?
09:51:55 <rafa> dkayiwa: I hope you had a great vacation!
09:52:01 <surangak> happy new year dkayiwa rafa :-)
09:52:01 <rafa> dkayiwa: no
09:52:01 <dkayiwa> rafa: oh yess
09:52:16 <rafa> dkayiwa: I mean yes, but it's not working right
09:52:22 <dkayiwa> surangak: happy new year too :)
09:52:40 <rafa> dkayiwa: maybe we'll have time by the end of this sprint to fix it
09:52:44 <dkayiwa> rafa: ok i thought it was me alone :)
09:53:14 <dkayiwa> rafa: can you atleast save a package on 1.9?
09:53:39 <dkayiwa> rafa: without getting not-null property references a null or transient value: org.openmrs.ConceptMap.conceptReferenceTerm
09:53:54 <rafa> dkayiwa: It won't work for concepts for sure
09:54:04 <rafa> dkayiwa: because they have changed a lot in 1.9
09:54:07 <dkayiwa> rafa: ok
09:54:42 <dkayiwa> rafa: as for META-153, on which screen is this Next to be clicked?
09:54:51 <rafa> !ticket META-153
09:54:52 <OpenMRSBot> rafa: [#META-153] Cannot change the assessment - OpenMRS JIRA - https://tickets.openmrs.org/browse/META-153
09:55:16 <rafa> dkayiwa: Ohh it's when you import a package and need to do assessments
09:55:26 <rafa> dkayiwa: you go through each item one by one
09:55:28 <dkayiwa> rafa: ok thanks
09:55:32 <rafa> dkayiwa: but you can't go back
09:55:38 <rafa> dkayiwa: because of this exception
09:55:41 <dkayiwa> rafa: ok
09:56:05 <rafa> dkayiwa: it should work when you click back in a browser
09:56:11 <dkayiwa> rafa: oh
09:56:17 <rafa> dkayiwa: but also it would be nice to have a back button in the app
09:56:23 <dkayiwa> rafa: ok
09:56:40 <rafa> dkayiwa: simple js window.history(-1) or something is enough
09:56:47 <dkayiwa> rafa: ok
09:56:57 <rafa> dkayiwa: is should be pretty easy to fix
09:56:58 <dkayiwa> rafa: so the browser back is the one that fails?
09:57:05 <rafa> dkayiwa: you just need to make sure that fields are initialized
09:57:09 <rafa> dkayiwa: yes
09:57:12 <dkayiwa> ok
09:58:02 <dkayiwa> rafa: i thought it happens on exporting a package. now let me export a non conept one and try import it to reproduce the error
09:58:40 <dkayiwa> rafa: oh wait, according to the description, looks like it fails only for concepts???
09:59:16 <rafa> dkayiwa: it might be the case since other types do not have names in different tables
09:59:56 <dkayiwa> rafa: are you still talking about META-153 ? :)
10:00:05 <rafa> dkayiwa: yes
10:00:10 <dkayiwa> rafa: ok
10:00:24 <rafa> dkayiwa: the exception is caused by getName throwing thelazily initialization exception
10:00:32 <dkayiwa> rafa: ok
10:01:25 <rafa> dkayiwa: ohh but it's in ConceptDatatype :)
10:01:38 <dkayiwa> rafa: :D
10:08:21 <dkayiwa> rafa: thanks for not mavenizing this module. :)
10:08:32 <rafa> dkayiwa: haha
10:08:48 <rafa> dkayiwa: don't you like ant? :D
10:08:53 <dkayiwa> rafa: doing unit test in our mavenized modules is a pain :(
10:09:07 <rafa> dkayiwa: ohh I think I fixed that :D
10:09:23 <dkayiwa> rafa: oh that would be great!!!! :D
10:09:43 <dkayiwa> rafa: i love ant very very much. just like my auntie :)
10:09:48 <rafa> dkayiwa: I've upgraded the module-wizard to do it properly
10:09:57 <rafa> dkayiwa: haha
10:10:06 <dkayiwa> rafa: oh thats so so cool :)
10:12:41 *** bwolfe_ is now known as bwolfe
10:12:49 <bwolfe> I think unit tests in mavenized modules is easier...
10:12:58 <bwolfe> you just have to know to put them in the omod. :-)
10:13:16 <dkayiwa> bwolfe: hahahaha happy new year Ben!!!!
10:13:29 <bwolfe> rafa, did you change the basicmodule for the tests to work in the api yet? If its an easy patch we should apply that to the popular mavenized modules too
10:13:31 <bwolfe> hi dkayiwa
10:13:33 <bwolfe> happy new year
10:14:07 <dkayiwa> bwolfe: how is Eden, Andy, and Megan?
10:15:38 <bwolfe> they're all doing well
10:15:55 <dkayiwa> oh thats so good!!!
10:20:30 <rafa> bwolfe: I forgot about the basicmodule. I'll do it right now. I don't think we can have a general patch, but it's a matter of copy & paste in pom and moving some files around so pretty straightforward.
10:20:59 <dkayiwa> rafa: is the next button supposed to be on the showImportSummary.form?
10:21:09 <dkayiwa> rafa: META-153
10:21:32 <rafa> dkayiwa: assessImportedItem
10:21:53 <bwolfe> rafa, I was thinking more about just changing the poms for now
10:22:04 <bwolfe> the tests might as well stay where they are for the mavenized modules
10:23:01 <rafa> bwolfe: yeah, we can leave the tests, but still need to move moduleApplicationContext.xml, hbms, properties.
10:23:19 <rafa> bwolfe: create moduleWebApplicationContext.xml if necessary
10:23:53 <bwolfe> I see
10:24:13 *** surangak_ has joined #openmrs
10:24:24 *** surangak has quit IRC
10:24:25 <dkayiwa> rafa: so you also get this error: /WEB-INF/view/module/metadatasharing/import/assessImportedItem.jsp(115,91) Unterminated <utils:printJavaScript tag
10:24:26 *** r0bby is now known as robbyoconnor
10:24:54 <rafa> dkayiwa: are you using 1.9?
10:24:56 <dkayiwa> rafa: that is on clicking the assess action
10:25:02 <dkayiwa> rafa: 1.8
10:25:11 <dkayiwa> rafa: 1.8.1
10:25:44 <rafa> dkayiwa: haven't seen that
10:25:50 <dkayiwa> rafa: ok
10:26:02 <rafa> dkayiwa: properly a not js escaped name
10:26:13 <dkayiwa> rafa: ok
10:30:01 <rafa> bwolfe: can you check if module-wizard works for you now? I don't know if it's a problem with my maven cache but it tries to get an archetype in 1.1 instead of 1.1.0...
10:30:22 * bwolfe has to remember how to use it...
10:30:30 <rafa> mvn module-wizard:generate
10:31:51 <bwolfe> rafa, http://pastebin.com/q82LVKL7
10:31:53 <bwolfe> seems to work...
10:32:12 <rafa> bwolfe: yeah but the problem is later
10:32:16 <rafa> bwolfe: continue
10:35:52 <bwolfe> rafa, ah, yes, error
10:36:16 <rafa> bwolfe: any idea why it tries to fetch non existing version?
10:36:20 <bwolfe> http://pastebin.com/wS3zSFV4
10:36:31 <bwolfe> rafa, one of the pom's archetypes didn't get updated?
10:36:32 <bwolfe> not sure
10:37:55 <rafa> bwolfe: do you have rights to click rebuild metadata on archetype-catalog.xml in the public repo
10:38:06 <rafa> bwolfe: it doesn't look right
10:38:39 <bwolfe> rafa, probably. similar to what matt did before?
10:38:44 <rafa> bwolfe: yes
10:39:50 <rafa> bwolfe: it's just that I don't see that option
10:40:32 <bwolfe> rafa, for which one?
10:40:38 <bwolfe> which one do you want rebuilt?
10:41:05 <rafa> the file in the main directory
10:41:08 <rafa> archetype-catalog.xml
10:41:17 <bwolfe> rafa, the springmvc one doesn't have 1.1.0 in it
10:41:18 <bwolfe> the others do
10:41:23 <bwolfe> rafa, are you sure you published that one?
10:41:30 <rafa> spingmvc is no longer used
10:43:20 <rafa> bwolfe: I think http://mavenrepo.openmrs.org/nexus/service/local/repositories/releases/content/archetype-catalog.xml needs to be updated
10:43:40 <rafa> bwolfe: and http://mavenrepo.openmrs.org/nexus/service/local/repo_groups/public/content/archetype-catalog.xml
10:45:41 <bwolfe> rafa, I've done "rebuild metadata" on everything around there, still looks the same :-/
10:46:25 <rafa> ergh
10:54:52 *** bwolfe has quit IRC
10:58:06 *** bwolfe has joined #openmrs
10:58:06 *** ChanServ sets mode: +o bwolfe
11:00:35 <rafa> bwolfe: I've just tried releasing again, but it didn't change the file
11:00:56 <rafa> bwolfe: It's strange, because when I do install locally, the same file in my local repo is updated
11:01:03 <bwolfe> rafa, but you said springmvc isn't used. so why would http://mavenrepo.openmrs.org/nexus/service/local/repo_groups/public/content/archetype-catalog.xml change?
11:01:32 <rafa> bwolfe: I release again basicmodule-creation
11:01:45 <rafa> bwolfe: so it should have been added there
11:02:08 <rafa> bwolfe: same as service-dao-hibernate-creation
11:02:22 <rafa> bwolfe: I really don't know why this one was added but not the two others :/
11:03:07 <rafa> bwolfe: I don't see any logic in how it behaves
11:03:11 <bwolfe> heh
11:03:14 <bwolfe> I'm sure there is a reason
11:03:16 <bwolfe> or some other place it is
11:03:25 <bwolfe> or some bad config with the springmvc one and so its there
11:03:29 <bwolfe> email matt again and ask him. :-)
11:03:58 <rafa> bwolfe: yeah it's a good idea :D
11:05:14 <dkayiwa> rafa: is this a JIRA permission issue? i do not seem to have a way of workflowing into a post commit state for metadatasharing module
11:05:21 *** surangak_ has quit IRC
11:05:32 <rafa> dkayiwa: you should have all rights
11:05:40 <rafa> dkayiwa: try refreshing the page?
11:05:50 <dkayiwa> rafa: ok
11:06:13 <rafa> dkayiwa: if you mean META-179 you need to claim it first :)
11:06:36 <dkayiwa> rafa: same problem with META-153
11:07:20 <rafa> dkayiwa: you clicked a wrong assign button :)
11:07:26 <dkayiwa> rafa: hahaha
11:07:39 <rafa> dkayiwa: the one that does not change status to In progress from Ready for Work :D
11:07:50 <dkayiwa> rafa: lolllllllll
11:07:51 <rafa> try the one on the right
11:07:56 <dkayiwa> rafa: ok
11:08:55 <dkayiwa> thanks rafa It now WORKETH!!! :)
11:09:41 <rafa> dkayiwa: haha JIRA is so tricky :D
11:09:52 <dkayiwa> rafa: but not for you :)
11:11:52 <bwolfe> dkayiwa, left is wrong. right is right
11:12:20 <dkayiwa> bwolfe: hahahahahahaha
11:12:33 <dkayiwa> :D
11:12:37 <dkayiwa> i love that
11:12:53 <dkayiwa> bwolfe: what a formula!!! :)
11:18:53 <rafa> bwolfe: btw what happened to claim issue?
11:23:44 <bwolfe> rafa, not sure. is it gone for all projects or just yours? bug downeym about it :-)
11:24:53 <rafa> bwolfe: seems like just for mine
11:26:17 <bwolfe> rafa, look in the admin interface for your project. perhaps you need a different "scheme" ?
11:29:25 *** upul` has quit IRC
11:31:23 <dkayiwa> rafa: on the assessImportedItem.form, when i click the next button, it takes me to showImportSummary.form
11:31:48 <rafa> dkayiwa: if there're no more items to assess that is right behavior
11:32:11 <rafa> dkayiwa: i.e. if everything in the summary is green
11:32:21 <dkayiwa> rafa: yes green
11:32:37 <rafa> dkayiwa: so it should work like this
11:33:14 <rafa> dkayiwa: "next" takes you to the next unassessed item
11:34:07 <dkayiwa> rafa: showImportSummary.form has Items: 4
11:34:45 <dkayiwa> rafa: assessImportedItem.form is showing Assessing Item 3 of 4
11:35:02 <dkayiwa> rafa: on clicking next, it takes me to showImportSummary.form
11:35:08 <dkayiwa> rafa: is that correct?
11:35:28 <rafa> dkayiwa: oh yes, that's a confusing message
11:36:04 <dkayiwa> rafa: just to give you some more info, my package has one concept
11:36:13 <rafa> dkayiwa: it shows the position of this item in the package
11:36:20 <rafa> dkayiwa: maybe we should change that
11:36:47 <rafa> dkayiwa: to show how many items are still to assess
11:37:35 <dkayiwa> rafa: let me try exporting more than one concept and see if i can reproduce this error
11:37:53 <rafa> dkayiwa: it's not an error
11:37:59 <dkayiwa> rafa: oh
11:38:06 <rafa> dkayiwa: there're 4 items in the package
11:38:13 <dkayiwa> rafa: i meant the META-153
11:38:17 <rafa> dkayiwa: and you're looking at the third item
11:38:25 <dkayiwa> rafa: i have so far not been able to reproduce META-153
11:38:57 <rafa> ohh because you need a package with items that are not in your system
11:39:05 <rafa> so that they're not automatically assessed
11:39:10 <dkayiwa> rafa: oh i see
11:39:17 <rafa> dkayiwa: the easiest way to fake it is to change uuids in the package
11:39:28 <rafa> dkayiwa: just open the zip file and edit metadata.xml
11:39:29 <dkayiwa> rafa: ok thanks for the tip
11:39:34 <dkayiwa> rafa: ok
11:40:10 *** james_regen has joined #openmrs
11:40:10 *** ChanServ sets mode: +v james_regen
11:55:21 *** kishoreyekkanti has joined #openmrs
11:56:28 *** ningosi has joined #openmrs
11:57:14 <ningosi> hi james
11:57:43 <ningosi> having problems on patient matching module configuration
11:57:56 <dkayiwa> rafa: do you think this is an OpenMRS bug or metadatasharing module? META-180
11:58:11 <james_regen> hi ningosi
11:58:23 <rafa> !ticket META-180
11:58:24 <OpenMRSBot> rafa: [#META-180] NPE when importing a package - OpenMRS JIRA - https://tickets.openmrs.org/browse/META-180
11:58:58 <rafa> dkayiwa: it's a core bug
11:59:06 <dkayiwa> rafa: ok
11:59:08 <rafa> dkayiwa: it was fixed
11:59:21 <rafa> dkayiwa: upgrade
11:59:31 <dkayiwa> rafa: to 1.8.3 ?
11:59:41 <rafa> dkayiwa: it should be in 1.8.3
11:59:49 <dkayiwa> rafa: ok thanks
12:00:01 <james_regen> ningosi: are you still getting empty reports? does catalina.out show any exceptions, and are there any log messages showing the analysis?
12:00:16 <ningosi> have problems on setting up datasource for patient matching module, James
12:01:14 <james_regen> ningosi: is this being used in the web application, or is this being used as a java swing GUI?
12:01:48 <rafa> dkayiwa: ohh sorry I got it wrong
12:01:58 <dkayiwa> rafa: oh
12:02:40 <rafa> dkayiwa: probably you need to open that concept and mark a name as preferred
12:03:00 <dkayiwa> rafa: ok let me do that now
12:03:46 <rafa> dkayiwa: ohh and export from 1.6 to 1.8 doesn't work yet
12:04:01 <dkayiwa> rafa: ok
12:04:11 <rafa> wyclif is working on that :)
12:04:26 <dkayiwa> rafa: ok thanks for the info :)
12:05:09 *** ningosi has quit IRC
12:05:18 <bwolfe> james_regen, its in the module in openmrs at ampath
12:05:28 <bwolfe> james_regen, ningosi == nicholas at ampath
12:05:32 <rafa> wyclif: I feel like you are working on too many tickets in parallel :D
12:05:49 <dkayiwa> :D
12:05:51 <bwolfe> is wyclif awake??
12:05:53 <james_regen> thanks bwolfe
12:06:04 <rafa> bwolfe: yeah it would be strange :D
12:06:11 <bwolfe> rafa, only 4 tickets. dkayiwa has had up to 8 at a time before ;-)
12:06:23 <rafa> bwolfe: haha
12:06:27 <dkayiwa> bwolfe: :D
12:06:38 <rafa> bwolfe: but some are big ones
12:07:07 <dkayiwa> :)
12:07:11 *** ningosi has joined #openmrs
12:10:05 *** akwatuha has joined #openmrs
12:12:51 <akwatuha> Hi guys
12:13:28 *** ningosi has quit IRC
12:13:55 *** ningosi has joined #openmrs
12:14:26 <bwolfe> hi akwatuha
12:14:41 <akwatuha> Hi Ben
12:22:07 <akwatuha> I am working on the Patient Matching module, need some help on configuration
12:25:03 <bwolfe> akwatuha, james_regen is your guy. nicholas was just asking as well. but he seems to be getting on/off a lot
12:25:30 <bwolfe> akwatuha, describe yoru situation as best as possible for james with as many details as possible as to what you've tried, what you're trying to do, etc
12:35:25 <bwolfe> rafa, grr
12:35:28 <bwolfe> boo on hacks!
12:36:00 <rafa> what's up? :)
12:36:09 <bwolfe> rafa, MSSI.saveItem
12:36:18 <bwolfe> if (dependency instanceof ConceptName)
12:36:36 <bwolfe> with that in there my concepts with preserved ids aren't importing
12:37:31 <rafa> argh I somehow knew it won't be that easy
12:37:57 *** rockfruit has joined #openmrs
12:38:06 <rafa> bwolfe: what happens exactly?
12:38:24 <bwolfe> says that concept doesn't exist
12:39:01 <bwolfe> I assume because its trying to save the conceptName early...and it works normally because conceptId is null and so hibernate knows it needs to persist concept first...but when concpet_id is non-null but the concept doesn't exist, hibernate tries to save anyway
12:39:33 <bwolfe> rafa, do you have a regression test for that hack? or a non-hacky way to fix it? :-)
12:40:49 <rafa> bwolfe: I'm afraid no
12:41:08 <rafa> bwolfe: is the exception thrown in dao.saveItem?
12:41:42 <bwolfe> yeah
12:42:24 <bwolfe> rafa, http://pastebin.com/8hP3pyEx
12:43:08 <rafa> bwolfe: I think the problem is slightly different
12:45:17 <rafa> bwolfe: you can try to check and do dao.saveItem only if dependency has no id set
12:45:48 <rafa> bwolfe: because the problem was with update, but we're saving a new Concept
12:45:55 <bwolfe> rafa, ConceptName has no id in my case. I am only trying to persist the concept ids
12:46:01 <rafa> bwolfe: so dao.saveItem should not be needed
12:47:03 <bwolfe> rafa, I'd have to add to the hack and say dependency.getConcept().getConceptId() == null, then do this
12:47:17 <rafa> bwolfe: yes, something like that
12:47:53 <rafa> bwolfe: but actually is should happen when we're doing a merge
12:48:10 <rafa> bwolfe: in case of a merge id will be set
12:48:55 <rafa> bwolfe: so we actually tell somehow that we're preserving ids
12:49:07 <bwolfe> rafa, I'm not following you
12:49:16 <rafa> bwolfe: can you comment out that line and see if any test fails?
12:49:46 <rafa> bwolfe: I mean always do what's in else
12:50:18 <bwolfe> rafa, yeah, I'll try. thats what I did to get it to import
12:59:33 *** chopin has joined #openmrs
12:59:55 *** wyclif has quit IRC
13:14:21 *** kishoreyekkanti has quit IRC
13:16:25 <bwolfe> rafa, as I said before, I don't like ant unit testing. What am I forgetting? eclipse can't find the FuncationalityTest.xml for the FunctionalityTest
13:16:31 <bwolfe> I have compiled the omod and put it into the dist folder
13:17:10 <rafa> bwolfe: try clearing the project?
13:17:47 <akwatuha> Thanks Ben, we got some leads from James. James has provided some guidelines to Nicholas and we will work on his suggestion and get back to him if the need arises.
13:18:17 <bwolfe> akwatuha, ah, ok
13:18:30 <bwolfe> james_regen, I hope you updated your wiki docs to make it easier for the next guy! :-)
13:18:35 <bwolfe> rafa, that did it.
13:18:38 * bwolfe hangs head in shame
13:18:51 * bwolfe did a "clean" instead of a "clear" though. :-)
13:19:18 <rafa> bwolfe: haha how did you know? :P
13:19:49 <james_regen> bwolfe: the wiki page is bad?
13:19:55 *** ningosi has quit IRC
13:20:09 <bwolfe> james_regen, it wasn't clear enough for ningosi and akwatuha apparently. :-)
13:21:42 <james_regen> a few days ago i thought of a feature that would solve a lot of problems . . . wish i'd thought of it sooner. i think it would have helped here
13:21:45 <bwolfe> rafa, ok, all tests still pass with the code commented out
13:22:09 <bwolfe> james_regen, can you explain it in 30 seconds or less?
13:22:16 <rafa> bwolfe: then I guess you can assume you've fixed it
13:22:33 <rafa> bwolfe: my bad if I didn't write a test :/ I can't remember right now
13:22:38 <bwolfe> rafa, haha
13:22:53 <bwolfe> rafa, but you put it there for a reason. I didn't do anything to fix it, just commented out your hack ;-)
13:23:01 <bwolfe> rafa, do you remember how to replicate that in the app maybe?
13:23:54 <james_regen> the strategy screen needs to provide more feedback. it should be possible to estimate the size of the report geenrated before it's run, and it should be possible to validate a strategy as valid before a report is tried to be made. currently, it assumes the strategy is valid and moves forward, and if it isn't, either an empty report is made, or no report.
13:24:16 <bwolfe> ah
13:24:19 <bwolfe> makes sense
13:24:32 <james_regen> i mentioned it to suranga, and he was going to look into how easy this feature would be. i'm afraid to tell ada, because then she might really, really want it
13:24:44 <bwolfe> yes, she def will want it
13:24:50 <bwolfe> don't tell akwatuha either ;-)
13:25:00 <james_regen> i don't think he heard . . .
13:25:26 <rafa> bwolfe: Try exporting a concept then removing one of its names and importing the exported one again. You should see your removed name back.
13:25:26 <bwolfe> yeah, you're right, I typed it pretty softly and he's hard of hearing
13:56:03 *** wyclif has joined #openmrs
13:57:01 *** akwatuha has quit IRC
14:10:38 *** downeym has joined #openmrs
14:10:38 *** OpenMRSBot sets mode: +o downeym
14:10:38 *** chopin has quit IRC
14:10:38 *** ChanServ sets mode: +o downeym
14:11:03 *** Mkop1 has joined #openmrs
14:11:03 *** ChanServ sets mode: +v Mkop1
14:11:11 <downeym> Hi Mkop1 and welcome to the #openmrs IRC channel.
14:12:27 *** pushkar has joined #openmrs
14:12:35 <Mkop1> hi downeym
14:13:46 *** Mkop1 is now known as Mkop
14:14:21 *** rockfruit has left #openmrs
14:16:52 <pushkar> bwolfe: the module creation using Maven Archetype is giving error
14:18:31 <bwolfe> pushkar, yeah, rafa is working on that
14:20:01 <pushkar> okay :-)
14:36:52 *** mvorobey has joined #openmrs
14:36:53 *** chopin has joined #openmrs
14:37:07 <mvorobey> hi, all!
14:40:08 *** bwolfe has quit IRC
14:55:17 <mvorobey> rafa: I'd like you to give me some clarifications about !ticket META-153. I was trying to reproduce it on weekend, spent couple of hours using 1.8.x, but nothing happened :( I tried to reproduce that bug again on 1.6.x, but came with the same result, so I started to think, what I did wrong ... after an hour of unsuccesfull attempts to reproduce that bug, I finally came to idea to check revision history for the ImportController and, surprisingly, found o
14:55:17 <mvorobey> ut that very like that this bug has been already fixed in revision 25113. Seems that it was a temporary fix, wasn't it? Can you comment on this?
14:55:52 <rafa> !ticket META-153
14:55:53 <OpenMRSBot> rafa: [#META-153] Cannot change the assessment - OpenMRS JIRA - https://tickets.openmrs.org/browse/META-153
14:56:00 <rafa> hi mvorobey!
14:56:12 <mvorobey> hello, rafa
14:56:25 <rafa> mvorobey: it's possible that it's been fixed.
14:56:36 <rafa> mvorobey: I see Daniel is working on that right now
14:56:39 <rafa> dkayiwa:
14:57:22 <dkayiwa> rafa:
14:57:22 <rafa> dkayiwa: how is it going, were you able to reproduce it?
14:57:29 <mvorobey> rafa, I see, but it was so interested for me :)
14:57:42 <dkayiwa> a moment
14:58:04 <rafa> dkayiwa: mvorobey has some experience with that :)
15:04:06 <mvorobey> will fe AFK for 10m
15:14:46 <dkayiwa> hi rafa
15:15:11 <rafa> dkayiwa: hi
15:15:12 <dkayiwa> hi mv
15:15:34 <dkayiwa> rafa: sorry was talking to someone here. but so far failed to reproduce it
15:15:51 <rafa> dkayiwa: all right
15:16:01 <rafa> dkayiwa: then you can cancel it
15:16:10 <dkayiwa> mvorobey: sorry for duplicating your efforts
15:16:10 <rafa> mvorobey: couldn't reproduce it either
15:16:27 <dkayiwa> rafa: could you confirm that you cannot reproduce it too
15:16:36 <rafa> mvorobey: You should comment on a ticket if you have any problems with reproducing it or you need clarifications. There's no reason for you to be blocked for that long. If you don't move forward for more than an hour, it's definitely time to ask :) Your dev time is too valuable for us to waste it :)
15:17:09 <rafa> dkayiwa: sure, I'll try it with the next opportunity :D
15:17:17 <dkayiwa> rafa: ok
15:17:25 <rafa> dkayiwa: I'm in the middle of something right now
15:17:38 <dkayiwa> rafa: no problem :)
15:19:00 <dkayiwa> mvorobey: can you claim the next ticket you are investigating/working on such that i do not hijack you again? :)
15:24:55 <mvorobey> dkayiwa, rafa, am back again :)
15:25:08 <mvorobey> yep, I can comment on that itcket
15:25:19 <mvorobey> ticket, sorry :)
15:25:47 <dkayiwa> mvorobey: since you did more work on it, you can unassign me and reassign yourself :)
15:26:30 <mvorobey> am not sure, dkayiwa, is it necessary?
15:27:15 <dkayiwa> mvorobey: may be
15:27:35 <mvorobey> dkayiwa, ok, np
15:28:44 <dkayiwa> mvorobey: no big deal though for this ticket
15:29:03 <dkayiwa> mvorobey: but most important for the ticket you are going to work on next :)
15:32:47 <mvorobey> dkayiwa: of sure, its important, may be the most important to get advantage of it, basically, we all have the same goal on sprint :)
15:33:09 <mvorobey> complete it in time :)
15:33:14 <dkayiwa> mvorobey: :D
15:39:03 *** kishoreyekkanti has joined #openmrs
15:39:11 *** dkayiwa has quit IRC
15:45:40 *** dkayiwa has joined #openmrs
15:56:26 *** pushkar has quit IRC
15:59:27 <mvorobey> rafa, dkayiwa, just FYI: I have already reassigned that ticket and commented on it
15:59:52 <rafa> mvorobey: good thanks!
16:00:00 <dkayiwa> mvorobey: ok thanks alot. :)
16:00:27 <mvorobey> np :) it was not so difficult :)
16:00:49 <mvorobey> for me
16:01:18 <dkayiwa> mvorobey: :D
16:06:42 <mvorobey> rafa, do get me wrong, but what do you think about this: to backport changes from ImportController from rev:21153, and try out again with them, or is this total waste of time yet? and it's really more better to start work on next ticket?
16:08:49 <rafa> mvorobey: no need to backport changes, the module has only one life ;) go start with a next ticket
16:09:15 <mvorobey> ok, thanx, I'm just worrying to do all more better :)
16:10:06 <mvorobey> rafa, what can you say about !ticket META-158
16:10:16 <mvorobey> !ticket META-158
16:10:43 <rafa> !ticket META-158
16:10:45 <OpenMRSBot> rafa: [#META-158] Allow search for concepts by uuid or conceptId - OpenMRS JIRA - https://tickets.openmrs.org/browse/META-158
16:11:01 <rafa> lol why it doesn't listen to you :)
16:11:12 <mvorobey> :)
16:11:29 <mvorobey> I will ask him in private chat :)
16:11:39 <rafa> mvorobey: haha
16:11:52 <rafa> mvorobey: This is tricky.
16:12:35 <rafa> mvorobey: Basically adding OR to a search makes it really slow for let's say 40 000 concepts
16:12:52 <mvorobey> rafa, yep, I read
16:12:55 <mvorobey> it
16:13:23 <rafa> mvorobey: so a good idea might be to do two searches instead
16:13:30 <rafa> mvorobey: and merge results
16:14:10 <rafa> mvorobey: but merging may get slow as well
16:14:37 <rafa> mvorobey: well not if you search for a complete UUID as I did or ID
16:14:55 <rafa> mvorobey: since it'll always return one item
16:15:11 <mvorobey> rafa, truly, its not the best practice to search something by id, but nevertheless, Ellen wants it to be done as I understand?
16:15:23 <rafa> mvorobey: yes, we want it to be done :)
16:15:44 <rafa> mvorobey: the thing is you do a simple search by id and add it to the beginning of the list of results
16:16:28 <rafa> mvorobey: same for uuid (only exact match)
16:16:49 <mvorobey> rafa: ok, I understand, will try to investigate into it
16:17:00 <rafa> mvorobey: cool
16:17:36 <mvorobey> rafa, sure, will have a questions
16:18:33 <rafa> mvorobey: sure, you can commet on the ticket / IRC / e-mail them :)
16:18:42 <rafa> mvorobey: whatever works for you
16:18:55 <mvorobey> :)
16:20:13 <rafa> mvorobey: and we will want to display ids in search results
16:20:35 <mvorobey> will add it
16:21:30 <mvorobey> do not know how, but I'll take care of it :)
16:57:45 *** dkayiwa has quit IRC
17:07:17 *** dkayiwa has joined #openmrs
17:12:24 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @agnesbinagwaho: @jblaya @ghdonline We appreciate your contribution w @OpenMRS in #Rwanda. It will help health sector management. #Mi ... <http://twitter.com/OpenMRS/statuses/156412671279898624>
17:16:19 *** dkayiwa has quit IRC
17:18:25 *** suranga has joined #openmrs
17:26:23 *** djazayeri1 has joined #openmrs
17:27:14 *** suranga_ has joined #openmrs
17:30:35 *** suranga has quit IRC
17:36:53 *** dkayiwa has joined #openmrs
17:50:22 <wyclif> hi dkayiwa
17:50:35 <dkayiwa> hey wyclif
17:50:37 <wyclif> dkayiwa, does the standalone work with 1.6?
17:51:08 <dkayiwa> wyclif: yes
17:51:15 <wyclif> cool, thanks
18:01:09 *** ningosi has joined #openmrs
18:02:10 *** bwolfe has joined #openmrs
18:02:10 *** ChanServ sets mode: +o bwolfe
18:11:13 *** djazayeri1 has quit IRC
18:11:17 *** djazayeri has joined #openmrs
18:11:17 *** ChanServ sets mode: +o djazayeri
18:17:23 *** suranga has joined #openmrs
18:20:03 *** dawn_ has joined #openmrs
18:21:00 *** suranga_ has quit IRC
18:21:50 <dkayiwa> hi rafa
18:25:19 <dkayiwa> rafa: how do you run your metadatasharing unit tests from eclipse?
18:29:20 *** bryq has joined #openmrs
18:29:20 *** ChanServ sets mode: +v bryq
18:30:38 <dawn_> !scrumon dawn
18:30:38 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready.
18:31:04 <dawn_> bwolfe: djazayeri rafa dkayiwa wyclif: Hi and Happy New Year :)
18:31:14 <djazayeri> hi all!
18:31:14 <rafa> dawn_: welcome back :) happy new year!
18:31:16 <dkayiwa> happy new year dawn_ :)
18:31:21 <rafa> hi
18:31:23 <djazayeri> happy everything
18:31:27 <dkayiwa> :)
18:31:44 <dawn_> Today's order: bwolfe , djazayeri , rafa , dkayiwa , and wyclif
18:32:23 <wyclif> hi
18:32:45 <dawn_> let's kick bwolfe to the end since he hasn't responded yet.
18:32:54 <dawn_> djazayeri: can you go first?
18:32:59 <bwolfe> today:
18:32:59 <bwolfe> reviewed ticket TRUNK-2888
18:32:59 <bwolfe> triaged bugs
18:32:59 <bwolfe> committed TRUNK-2818
18:32:59 <bwolfe> MDS-172
18:33:01 <bwolfe> MDS-174
18:33:02 <bwolfe> tomorrow:
18:33:04 <bwolfe> more sprint tickets
18:33:06 <bwolfe> setup for next week's sprint
18:33:08 <bwolfe> (hi dawn, welcome back)
18:33:12 <bwolfe> no blockers
18:33:29 <rafa> Today:
18:33:29 <rafa> * Code-reviews
18:33:29 <rafa> * Worked on META-170: Spliting metadata packages into multiple sub-packages
18:33:29 <rafa> https://tickets.openmrs.org/browse/META-170 (still testing and fixing problems)
18:33:29 <rafa> * Updated the basicmodule to the latest module archetype
18:33:30 <rafa> * Investigated on the archetype not being installed properly to our repo
18:33:30 <rafa> Later today:
18:33:31 <rafa> * Will do a big commit so everyone should commit changes early or else prepare for conflicts :-)
18:33:31 <rafa> Tomorrow:
18:33:32 <rafa> * META-176: Resuming import https://tickets.openmrs.org/browse/META-176
18:33:32 <rafa> No blockers.
18:33:48 <djazayeri> My turn
18:33:51 <djazayeri> Monday 9-Jan-2012 (Back from 2 weeks vacation)
18:33:51 <djazayeri> * catch up on email
18:33:51 <djazayeri> * maybe do a META ticket
18:33:51 <djazayeri> * look into the form resource ticket status
18:33:51 <djazayeri> * plan a meeting in Boston next week
18:33:59 <djazayeri> no blockers yet, except my now-massive inbox
18:34:11 <bwolfe> rafa, when is your big commit coming?
18:34:25 <rafa> bwolfe: later today or tomorrow morning
18:34:35 * bwolfe hurries up with his ticket
18:34:38 <rafa> bwolfe: I can postpone if needed
18:34:50 <djazayeri> rafa: I take it the unit testing framework isn't there yet?
18:35:10 <rafa> bwolfe is working on that
18:35:18 <dawn_> dkayiwa: your turn :)
18:35:22 <dkayiwa> Read some technical details and user's guide for the metadatasharing module
18:35:23 <dkayiwa> Committed: Cannot assess metadata import - META-179
18:35:23 <dkayiwa> Created: NPE when importing a package - META-180
18:35:24 <dkayiwa> Looked into and failed to reproduce: Cannot change the assessment - META-153
18:35:24 <dkayiwa> Looked into and failed to reproduce: Concept mappings get deleted while overwriting - META-130
18:35:24 <dkayiwa> Now working on: Testing handlers - META-160
18:35:24 <dkayiwa> No Blockers
18:35:25 <dkayiwa> :)
18:36:12 <dawn_> wyclif: your turn :)
18:36:21 <wyclif> friday:
18:36:22 <wyclif> * META-169 - Exporting metadata packages on-the-fly
18:36:22 <wyclif> * META-168 - Importing Concepts exported from OpenMRS 1.6 to OpenMRS 1.7/1.8
18:36:22 <wyclif> monday:
18:36:22 <wyclif> * Complete and Test Importing Concepts exported to/from OpenMRS 1.6 to OpenMRS 1.7/1.8(Testing how the concept name tag mappings work out)
18:36:23 <wyclif> * Review TODOs for META-169 - Exporting metadata packages on-the-fly
18:37:22 <djazayeri> !ticket meta-168
18:37:23 <OpenMRSBot> djazayeri: [#META-168] Importing Concepts exported from OpenMRS 1.6 to OpenMRS 1.7/1.8 - OpenMRS JIRA - https://tickets.openmrs.org/browse/meta-168
18:38:49 <dawn_> bwolfe: djazayeri : what do we need to do to get caught up on the doc sprint?
18:38:53 <dawn_> !scrumoff dawn
18:38:53 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
18:39:20 <bwolfe> dawn_, what do you mean by get caught up?
18:39:29 <bwolfe> what is the goal we are catching? :-)
18:40:53 <djazayeri> dawn_: I need to look back and see
18:41:17 <djazayeri> I wrote some book snippets just before xmas, but I don't remember how complete they are, or how good
18:42:57 <dawn_> bwolfe: yes, when are we trying to complete those tickets? I see we're on Metadata Sharing til 15 Jan
18:43:29 <djazayeri> dawn_: weren't a bunch of those tickets "nice to have", i.e. if they weren't completed in the sprint, we're still "done"?
18:43:46 <bwolfe> dawn_, we hadn't planned on finishing those that weren't done
18:43:57 <bwolfe> most of the wiki things were "maybes"
18:48:39 <dawn_> djazayeri: bwolfe : so are you saying we're just leaving it as is?
18:49:01 <djazayeri> dawn_: need to look at the book tickets and get those done for 1.9 release still
18:49:13 <djazayeri> but wiki edits aren't "musts"
18:53:15 *** ningosi has quit IRC
18:56:09 <dawn_> djazayeri: k
18:58:56 *** dawn_ has quit IRC
19:06:27 *** downeym has quit IRC
19:09:14 *** downeym has joined #openmrs
19:09:14 *** OpenMRSBot sets mode: +o downeym
19:09:14 *** ChanServ sets mode: +o downeym
19:10:10 *** kishoreyekkanti has quit IRC
19:14:56 <bwolfe> rafa, deleted names are reappearing with or without the hack in there
19:15:30 <rafa> bwolfe: then it's not needed anymore
19:16:29 <bwolfe> hmm
19:16:30 <bwolfe> ok
19:16:39 <bwolfe> so I can safely remove it?
19:16:46 <bwolfe> feels strange to me
19:16:52 <bwolfe> but I like removing hacks...
19:17:18 <rafa> bwolfe: then leave it in a comment :)
19:18:19 <rafa> bwolfe: what happens if <generator class="org.openmrs.api.db.hibernate.NativeIfNotAssignedIdentityGenerator" /> is not there?
19:19:40 <bwolfe> rafa, for the concept?
19:19:45 <bwolfe> I haven't changed anything in core yet
19:19:55 <bwolfe> I was not trying to persist the conceptnameid, only the concept ids
19:20:32 <rafa> bwolfe: I don't think conceptNameId needs to be persisted
19:20:44 <rafa> bwolfe: I was wondering about classes or datatypes
19:20:50 <bwolfe> I havne't tried those yet
19:20:56 <bwolfe> was working out the general bugs first ;-)
19:21:00 <rafa> bwolfe: ok
19:21:19 <rafa> bwolfe: probably we'll need to make preserving ids optional
19:21:37 <bwolfe> rafa, I've made it a GP
19:21:45 <rafa> bwolfe: good :)
19:21:46 <bwolfe> users can list out the classes they want to persist
20:00:28 <bwolfe> rafa, for some reason I'm getting a stalestateexception whenever trying to import conceptclasses with their ids. (both with and without hte nativeifnotassignedgenerator in the core hbm)
20:02:05 <rafa> bwolfe: can you try saving a ConceptClass with an id?
20:02:08 *** djazayeri has quit IRC
20:02:23 <rafa> bwolfe: in a simple test
20:02:57 <rafa> bwolfe: also is it when you're running the app or in unit tests?
20:03:21 <rafa> bwolfe: in unit tests for that to work you'll need to replace the core jar I guess
20:03:35 <rafa> bwolfe: if you add the nativeifnotassignedgenerator
20:03:49 <bwolfe> rafa, in the app
20:03:57 * bwolfe writes a test in core
20:04:45 *** djazayeri has joined #openmrs
20:04:45 *** ChanServ sets mode: +o djazayeri
20:09:10 <bwolfe> rafa, @#&%@#
20:09:24 <rafa> bwolfe: sounds like a problem
20:09:27 <bwolfe> I missed the unsaved-value="undefined" part of the concept hbm. :-(
20:09:36 <bwolfe> copying that over to the conceptclass hbm fixed it
20:09:44 <rafa> bwolfe: that's good :)
20:10:35 <bwolfe> rafa, good for this ticket getting done, but bad for me. I would have been done an hour ago if I had seen that...
20:11:16 <rafa> bwolfe: well it's a dev's life :D
20:11:34 <bwolfe> yes, just doubly annoying when its done at 11pm at night!
20:12:21 <rafa> bwolfe: is that late? I though we're almost in the same timezone
20:12:49 <rafa> bwolfe: you're two hours ahead
20:13:24 <bwolfe> do you honor DST? if so, we used to be only 1 hour ahead a few months back
20:13:54 <rafa> bwolfe: all this time I thought you're getting up that early :D
20:14:27 <rafa> bwolfe: yes, we do
20:15:05 <rafa> bwolfe: I thought it was an hour too
20:28:32 *** downeym has quit IRC
20:30:13 <bwolfe> ok, bedtime for me. got up too early this morning...
20:30:21 <bwolfe> I'll have to commit the testing stuff tomorrow
20:30:34 <bwolfe> rafa, you can go ahead and commit your big change. I'm cleared out now. :_)
20:30:36 <bwolfe> :-)
20:31:08 *** chopin has quit IRC
20:31:14 *** chopin has joined #openmrs
20:31:27 <rafa> bwolfe: okay, good night
20:34:45 *** robbyoconnor has quit IRC
20:38:14 *** dkayiwa has quit IRC
20:39:19 *** suranga has quit IRC
20:40:58 *** dkayiwa has joined #openmrs
20:46:16 *** james_regen has quit IRC
20:48:45 *** downeym has joined #openmrs
20:48:45 *** OpenMRSBot sets mode: +o downeym
20:48:45 *** ChanServ sets mode: +o downeym
20:53:36 *** dkayiwa_ has joined #openmrs
20:54:55 *** dkayiwa has quit IRC
20:54:55 *** dkayiwa_ is now known as dkayiwa
20:56:08 *** bwolfe has quit IRC
21:17:55 <wyclif> hi djazayeri
21:18:13 <djazayeri> hi wyclif
21:18:42 <wyclif> what extension piont s used to replace the index page?
21:18:54 <wyclif> it has the id org.openmrs.navigation.homepage
21:21:00 <wyclif> djazayeri, ??
21:26:38 *** mvorobey has quit IRC
21:28:52 <wyclif> hi dkayiwa
21:28:59 <dkayiwa> hi wyclif
21:29:22 <wyclif> dkayiwa, which is the extension point for the homepage
21:29:32 <dkayiwa> wyclif: am not sure
21:30:02 <wyclif> i found the id but not the class to extend, and they dont seem to be all documented
21:30:13 <wyclif> dkayiwa, i found the id but not the class to extend, and they dont seem to be all documented
21:30:22 <dkayiwa> wyclif: ok
21:30:58 *** rafa has quit IRC
21:49:38 *** chopin has quit IRC
21:52:03 *** dkayiwa has quit IRC
21:55:49 *** dkayiwa has joined #openmrs
21:57:55 *** downeym has quit IRC
22:01:15 *** robbyoconnor has joined #openmrs
22:01:15 *** ChanServ sets mode: +v robbyoconnor
22:15:49 *** wyclif has quit IRC
22:18:04 *** wyclif has joined #openmrs
22:18:52 *** wyclif has joined #openmrs
22:23:35 *** wyclif has quit IRC
22:24:08 *** bryq has quit IRC
22:27:33 *** dkayiwa has quit IRC
22:57:10 *** robbyoconnor has quit IRC
23:07:39 *** robbyoconnor has joined #openmrs
23:07:39 *** ChanServ sets mode: +v robbyoconnor