| 00:48:33 | *** robbyoconnor has joined #openmrs |
| 00:48:33 | *** ChanServ sets mode: +v robbyoconnor |
| 02:26:54 | *** kishoreyekkanti has joined #openmrs |
| 03:17:54 | *** upul` has joined #openmrs |
| 03:17:54 | *** ChanServ sets mode: +v upul` |
| 04:20:06 | *** kishoreyekkanti has quit IRC |
| 05:12:05 | *** surangak has joined #openmrs |
| 05:40:37 | *** ningosi has joined #openmrs |
| 06:04:35 | *** kishoreyekkanti has joined #openmrs |
| 06:29:50 | *** kishoreyekkanti has quit IRC |
| 06:30:06 | *** kishoreyekkanti has joined #openmrs |
| 06:46:16 | *** jmwogi has joined #openmrs |
| 07:00:10 | *** kishoreyekkanti_ has joined #openmrs |
| 07:02:15 | *** kishoreyekkanti has quit IRC |
| 07:02:15 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 07:47:37 | *** bryq has joined #openmrs |
| 07:47:37 | *** ChanServ sets mode: +v bryq |
| 08:03:09 | *** mwalo has joined #openmrs |
| 08:06:17 | *** kishoreyekkanti_ has joined #openmrs |
| 08:08:23 | *** kishoreyekkanti has quit IRC |
| 08:08:23 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 08:16:09 | *** mwalo has quit IRC |
| 09:24:42 | *** kishoreyekkanti_ has joined #openmrs |
| 09:25:02 | *** kishoreyekkanti_ has quit IRC |
| 09:25:09 | *** kishoreyekkanti has quit IRC |
| 09:25:14 | *** kishoreyekkanti has joined #openmrs |
| 09:29:37 | *** rafa has joined #openmrs |
| 09:29:37 | *** ChanServ sets mode: +v rafa |
| 09:32:38 | *** bryq has quit IRC |
| 09:49:08 | *** ningosi has joined #openmrs |
| 09:55:59 | *** ningosi has quit IRC |
| 09:57:59 | *** ningosi has joined #openmrs |
| 10:05:08 | *** ningosi has quit IRC |
| 10:05:41 | *** ningosi has joined #openmrs |
| 10:10:42 | *** bwolfe has joined #openmrs |
| 10:10:42 | *** ChanServ sets mode: +o bwolfe |
| 10:19:01 | *** ningosi has quit IRC |
| 10:20:34 | *** ningosi has joined #openmrs |
| 10:27:15 | *** ningosi has quit IRC |
| 10:29:01 | *** ningosi has joined #openmrs |
| 10:49:20 | *** maurya has joined #openmrs |
| 10:57:40 | <bwolfe> rafa, we need to change the basic module to have your changes as well. |
| 10:57:48 | <bwolfe> (the ones you did to the maven archetype) |
| 10:58:15 | <rafa> bwolfe: you mean basic module in svn? |
| 10:58:20 | <bwolfe> yeah |
| 10:58:24 | *** ningosi has quit IRC |
| 10:58:37 | <rafa> bwolfe: cool |
| 10:59:01 | *** pushkar has joined #openmrs |
| 11:00:24 | <rafa> bwolfe: I'll do it tomorrow. |
| 11:00:31 | <bwolfe> np |
| 11:01:03 | *** ningosi has joined #openmrs |
| 11:02:08 | <maurya> we are trying to install openmrs but we are getting an error "Unable to start openmrs as Daemon" |
| 11:04:26 | <maurya> can anybody help please... |
| 11:04:45 | <bwolfe> maurya, what version of openmrs and how are you trying to install it? |
| 11:05:32 | <maurya> we downloaded the latest version from the trunk |
| 11:06:21 | <maurya> i'm following the step by step guide.. |
| 11:12:41 | <maurya> bwolfe: what do we do? |
| 11:12:52 | <bwolfe> maurya, which step are you on? |
| 11:13:29 | <maurya> initial setup |
| 11:15:26 | <bwolfe> maurya, you've done what though? mvn jetty:run ? are you looking at the init wizard in the browser? or did you go through the init wizard? What all did you choose in the init wizard? which steps did you take? etc. :-) |
| 11:17:12 | <maurya> mvn jetty:run:yes...then completed the initial setup wizard at last it got stuck on update database |
| 11:17:28 | <maurya> so i manually executed the demo.sql script |
| 11:17:47 | <maurya> then when i tried to log in i'm getting the error |
| 11:19:00 | <bwolfe> what was the error when it got stuck on the update? |
| 11:19:54 | <maurya> it did not give any error but it got stuck |
| 11:20:11 | <bwolfe> are you sure it was stuck? or was it just taking a long time? :-) |
| 11:20:18 | <ningosi> have created a .OpenMRS folder and give relevant rights? |
| 11:20:18 | <ningosi> maurya? |
| 11:20:34 | <maurya> no no i waited for almost two hours |
| 11:20:42 | <maurya> yes |
| 11:21:22 | <maurya> ningosi: no |
| 11:21:40 | <maurya> it was nowhere mentioned in the steps |
| 11:23:40 | *** bwolfe_ has joined #openmrs |
| 11:23:40 | *** ChanServ sets mode: +o bwolfe_ |
| 11:26:50 | *** maurya_ has joined #openmrs |
| 11:27:01 | *** bwolfe has quit IRC |
| 11:27:47 | <maurya_> bwolfe_: sorry i got disconnected |
| 11:27:59 | *** bwolfe_ is now known as bwolfe |
| 11:28:20 | *** maurya has quit IRC |
| 11:28:28 | *** upul` has quit IRC |
| 11:28:53 | *** ningosi has quit IRC |
| 11:30:53 | *** ningosi has joined #openmrs |
| 11:36:17 | *** ningosi has quit IRC |
| 11:47:23 | *** maurya has joined #openmrs |
| 11:48:16 | *** maurya_ has quit IRC |
| 11:53:01 | <maurya> bwolfe: hey,thanks guys..we got it..:) |
| 11:53:17 | <bwolfe> maurya, great. sorry I wasn't more help. what was it? |
| 11:53:40 | <maurya> nothing just corrupted my demo.sql |
| 11:53:53 | <maurya> did thentire process again and got it |
| 11:57:44 | *** surangak has quit IRC |
| 11:58:29 | *** surangak has joined #openmrs |
| 12:01:00 | *** james_regen has joined #openmrs |
| 12:01:00 | *** ChanServ sets mode: +v james_regen |
| 12:01:38 | *** bwolfe has quit IRC |
| 12:02:18 | *** bwolfe has joined #openmrs |
| 12:02:18 | *** ChanServ sets mode: +o bwolfe |
| 12:03:50 | *** surangak has quit IRC |
| 12:04:22 | *** surangak has joined #openmrs |
| 12:05:08 | *** maurya has quit IRC |
| 12:05:31 | *** pushkar has quit IRC |
| 12:22:09 | *** kishoreyekkanti has quit IRC |
| 12:22:38 | *** robbyoconnor has quit IRC |
| 12:39:38 | *** jmwogi has quit IRC |
| 12:59:40 | *** kishoreyekkanti has joined #openmrs |
| 13:00:41 | *** bwolfe_ has joined #openmrs |
| 13:00:41 | *** ChanServ sets mode: +o bwolfe_ |
| 13:02:33 | <surangak> hi james_regen |
| 13:02:41 | <surangak> good morning, r u there ? |
| 13:02:41 | *** bwolfe has quit IRC |
| 13:02:49 | <james_regen> surangak: hi |
| 13:03:13 | <surangak> james_regen, let me give you a proper update :-) |
| 13:03:22 | <james_regen> ok |
| 13:03:47 | <surangak> so firsly, I got maven working for patientmatching module, and then did the following.... |
| 13:03:51 | <surangak> 1. Users can create new strategies on the Create New Strategy page |
| 13:03:51 | <surangak> 2. these strategies are stored in the xml file. |
| 13:03:51 | <surangak> 3. data displayed on the 'create new strategy' page is represented by the PatientMatchingConfiguration class. |
| 13:03:51 | <surangak> 4. Basically, the fields in the PatientMatchingConfiguration class are those that the user is allowed to edit. |
| 13:03:55 | <surangak> 5. I have mavenized the PatientMatchingConfiguration class, and am writing these parameters into the db. |
| 13:03:57 | <surangak> 6. When an user clicks on 'save' it will write the configuration into the xml file, then also save it into the db. |
| 13:04:00 | <surangak> 7. Each PatientMatchingConfiguration contains many COnfigurationEntries. |
| 13:04:02 | <surangak> 8. I have mavenized the configurationEntries to store these data. (one-to-many relationship) |
| 13:04:04 | <surangak> 9. Now working on retreiving PatientMatchingConfigurations 'by name'. (I need to set up the configurationEntries objects based on some parameters) |
| 13:04:09 | <surangak> Also need to |
| 13:04:11 | <surangak> 1. Clean up code |
| 13:04:13 | <surangak> 2. Test that storage / retreval is working well |
| 13:04:15 | <surangak> 3. Test that entire dedup report works as before |
| 13:04:17 | <surangak> At the end of this step we will be able to |
| 13:04:19 | <surangak> 1. Store / detele / edit / retreive new strategies in the database |
| 13:04:25 | <surangak> ----------- |
| 13:04:27 | <surangak> steps 1-9 what I did |
| 13:04:29 | <surangak> 1-3 (need to be done) |
| 13:05:44 | *** maurya has joined #openmrs |
| 13:05:52 | <james_regen> surangak: ok, sounds like good progress. was there any surprises about the process compared to what you were expecting? |
| 13:06:10 | <surangak> james_regen, a few mionr hiccups.. |
| 13:06:32 | <surangak> I had a few false starts before I hit on using the patientmatchingconfiguration class |
| 13:06:41 | <surangak> *minor hiccups |
| 13:06:57 | <surangak> right now im happy with the design of what i've done |
| 13:07:27 | <surangak> the complication seems to be that some stuff in the file are somewhat hard coded, so dont really need to be stored in a db... |
| 13:07:35 | <surangak> so I have to figure out which is which as I go |
| 13:08:25 | <james_regen> surangak: ok, i can explain the parameters if you can't figure them out, and i can guess what is hard coded. the matching sotware has a lot more features than the module uses |
| 13:10:52 | <surangak> james_regen, actually, I came up with one conflict a short while ago.. the configurationEntry class needs to be linked with some data in the MatchingConfigRow class (for example, the 'block order' field) |
| 13:11:18 | <surangak> should I hibernize the MatchingConfigRow class, or try to move these parameters into the configurationEntry class ? |
| 13:11:43 | <surangak> (sorry, this is a very generalized question, dont know how familiar you are with these classes right now :-) |
| 13:12:44 | <james_regen> i would guess move them into configurationEntry class. most of the stuff MatchingConfigRow needs is hard coded, i think |
| 13:13:11 | <james_regen> if going from configurationEntry -> MatchingConfigRow is trivial, then i don't think we need to store both |
| 13:13:29 | <surangak> james_regen, I had the same thought :-) |
| 13:13:57 | <surangak> james_regen, so right now its trial and error until I figure out the hard coded stuff etc. |
| 13:14:21 | <surangak> plus i also need to , |
| 13:14:22 | <surangak> 1. Clean up code |
| 13:14:23 | <surangak> 2. Test that storage / retreval is working well |
| 13:14:23 | <surangak> 3. Test that entire dedup report works as before |
| 13:16:17 | <james_regen> surangak: ok. i think shaun and ada might be interested in this progress. it sounds really great |
| 13:16:41 | <surangak> james_regen :-) |
| 13:16:58 | <surangak> james_regen, lets wait till we run the tests first :P |
| 13:17:33 | <james_regen> ok |
| 13:18:57 | <surangak> james_regen, I guess once this step is tested, we can commit it.. |
| 13:20:36 | <james_regen> surangak: i think the next step would then be moving the reports to the database. i think there's more opportunity to think of different solutions for that, or at least less code to rewrite |
| 13:25:17 | *** kishoreyekkanti has quit IRC |
| 13:39:57 | *** bryq has joined #openmrs |
| 13:39:57 | *** ChanServ sets mode: +v bryq |
| 13:49:30 | *** bwolfe_ has quit IRC |
| 13:57:12 | *** ningosi has joined #openmrs |
| 14:01:09 | *** wyclif has quit IRC |
| 14:01:09 | *** wluyima has quit IRC |
| 14:07:42 | *** ningosi has quit IRC |
| 14:17:47 | *** downeym has joined #openmrs |
| 14:17:47 | *** OpenMRSBot sets mode: +o downeym |
| 14:17:47 | *** ChanServ sets mode: +o downeym |
| 14:33:22 | *** wyclif has joined #openmrs |
| 14:33:58 | *** wyclif has quit IRC |
| 14:56:55 | *** surangak has quit IRC |
| 14:58:26 | *** kishoreyekkanti has joined #openmrs |
| 15:01:18 | *** rafa has quit IRC |
| 15:48:48 | *** jriley has joined #openmrs |
| 15:51:33 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Remote FormEntry 2.9.7 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=remoteformentry&version=&2.9.7> |
| 16:13:01 | *** james_regen has quit IRC |
| 16:16:22 | *** james_regen has joined #openmrs |
| 16:16:22 | *** ChanServ sets mode: +v james_regen |
| 16:27:30 | *** james_regen has quit IRC |
| 16:33:50 | *** wyclif has joined #openmrs |
| 16:33:59 | *** james_regen has joined #openmrs |
| 16:33:59 | *** ChanServ sets mode: +v james_regen |
| 16:36:06 | *** kishoreyekkanti has quit IRC |
| 17:26:14 | *** rafa has joined #openmrs |
| 17:26:14 | *** ChanServ sets mode: +v rafa |
| 17:30:31 | *** kishoreyekkanti has joined #openmrs |
| 17:30:43 | <wyclif> hi rafa |
| 17:30:50 | <rafa> hi |
| 17:32:47 | *** pushkar has joined #openmrs |
| 17:33:00 | <downeym> Hi pushkar and welcome to the #openmrs IRC channel. |
| 17:33:34 | <pushkar> downeym: hello..:-) |
| 17:42:50 | <rafa> wyclif: You're working on concept mappings. The priority is to make it work with OpenMRS 1.8 and earlier. |
| 17:43:29 | <rafa> wyclif: It has greatly changed in 1.9 right? |
| 17:43:49 | <wyclif> rafa, ok |
| 17:44:06 | <wyclif> rafa, i will test againat older versions |
| 17:44:14 | <wyclif> rafa, i was running off trunk |
| 17:44:47 | <rafa> wyclif: okay, thanks |
| 17:45:14 | <rafa> wyclif: sorry I haven't stated it more clearly (I've just left a note on the sprint page) |
| 17:47:07 | <wyclif> rafa, ok |
| 17:47:23 | *** bwolfe has joined #openmrs |
| 17:47:23 | *** ChanServ sets mode: +o bwolfe |
| 17:47:26 | <wyclif> rafa, apparently you have already answered the other question i had |
| 17:47:27 | *** pushkar has quit IRC |
| 17:47:41 | <rafa> :) |
| 17:47:44 | <wyclif> rafa about changes in concept mappings in 1.9 |
| 17:48:35 | <rafa> wyclif: I'll have to learn more about these changes |
| 17:48:48 | <rafa> wyclif: Eventually we'll need to make it work with 1.9 |
| 17:49:04 | <rafa> wyclif: but I don't think there will be enough time during this sprint |
| 17:50:36 | <wyclif> rafa, i agree |
| 17:59:12 | *** maurya_ has joined #openmrs |
| 17:59:23 | <downeym> Hi maurya_ and welcome to the #openmrs IRC channel. |
| 18:02:41 | <bwolfe> !scrumon rafa |
| 18:02:41 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster rafa- you may begin when ready. |
| 18:02:47 | *** maurya has quit IRC |
| 18:03:04 | <rafa> hi bwolfe, jriley, wyclif |
| 18:03:27 | <bwolfe> hi rafa |
| 18:04:13 | <wyclif> hi |
| 18:04:52 | <rafa> today's order wyclif, bwolfe, rafa, jriley? |
| 18:05:28 | <wyclif> just a sec |
| 18:06:34 | <wyclif> can some go before me |
| 18:06:43 | <rafa> bwolfe: :) |
| 18:06:56 | <bwolfe> hmm, I suppose |
| 18:07:00 | <bwolfe> one sec :-p |
| 18:07:09 | <rafa> haha |
| 18:07:13 | <bwolfe> today: |
| 18:07:13 | <bwolfe> ticket comments |
| 18:07:13 | <bwolfe> triaged ERR tickets |
| 18:07:13 | <bwolfe> started MDS-172 |
| 18:07:13 | <bwolfe> design call |
| 18:07:14 | <bwolfe> pm call (maybe?) |
| 18:07:30 | <bwolfe> no blockers yet. might have questions on deserializing later |
| 18:07:51 | <rafa> okay |
| 18:07:59 | <rafa> Today: |
| 18:08:00 | <rafa> * Continued with META-170: Spliting metadata packages into multiple sub-packages |
| 18:08:00 | <rafa> https://tickets.openmrs.org/browse/META-170 |
| 18:08:00 | <rafa> Tomorrow: |
| 18:08:00 | <rafa> * Complete META-170: Spliting metadata packages into multiple sub-packages |
| 18:08:00 | <rafa> https://tickets.openmrs.org/browse/META-170 |
| 18:08:00 | <rafa> * Update the basic module to changes in archetypes |
| 18:08:01 | <rafa> No blockers. |
| 18:08:26 | <rafa> wyclif: ... |
| 18:09:20 | <wyclif> yesterday: |
| 18:09:20 | <wyclif> * Getting familiar with the module and code base |
| 18:09:20 | <wyclif> * partially Worked on Finish META-173(waiting on more info) - Finding matching Concepts based on mappings |
| 18:09:20 | <wyclif> * META-171 - Allow to disable adding concept mappings while exporting |
| 18:09:20 | <wyclif> today: |
| 18:09:21 | <wyclif> * investigated a javacript issue on some pages and created bug ticket for it |
| 18:09:23 | <wyclif> * Finish-173 - Finding matching Concepts based on mappings |
| 18:09:27 | <wyclif> * design review call |
| 18:09:29 | <wyclif> * pick more sprint tickets |
| 18:10:05 | <rafa> bwolfe, wyclif I'll repeat please use OpenMRS 1.8 or earlier for development and testing |
| 18:10:20 | <wyclif> rafa, ok |
| 18:10:24 | <bwolfe> boo |
| 18:11:07 | <rafa> !ticket META-171 |
| 18:11:08 | <OpenMRSBot> rafa: [#META-171] Allow to disable adding concept mappings while exporting - OpenMRS JIRA - https://tickets.openmrs.org/browse/META-171 |
| 18:11:34 | <rafa> wyclif: is META-173 clear now? |
| 18:11:40 | <rafa> !ticket META-173 |
| 18:11:42 | <OpenMRSBot> rafa: [#META-173] Finding matching Concepts based on mappings - OpenMRS JIRA - https://tickets.openmrs.org/browse/META-173 |
| 18:11:59 | <wyclif> rafa, yes |
| 18:12:04 | <rafa> cool |
| 18:12:10 | <rafa> then we're done |
| 18:12:13 | <rafa> !scrumoff |
| 18:12:13 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 18:12:28 | <rafa> bwolfe: do you want to discuss now? |
| 18:12:50 | <bwolfe> rafa, about deserializing? I meant after I tried it. :-) |
| 18:13:01 | <rafa> bwolfe: oh :D |
| 18:13:18 | <rafa> okay |
| 18:13:19 | <bwolfe> rafa, I'm not liking the idea of having to analyze the incoming string to find the object and then find the id just to see if the id+uuid already exists :-/ |
| 18:13:54 | <rafa> bwolfe: you won't have to do that |
| 18:13:58 | <wyclif> rafa, ok i have removed META-178 from the sprint dashboard |
| 18:14:51 | <bwolfe> rafa, the class/method you pointed to in the ticket makes it seem that way |
| 18:14:53 | <rafa> bwolfe: in OpenmrsObjectConverter in deserialize you can access already deserialized object |
| 18:15:26 | <rafa> bwolfe: you can use what super.unmarshal returns |
| 18:15:49 | <rafa> bwolfe: before leaving the unmarshal method |
| 18:17:06 | *** maurya_ has quit IRC |
| 18:18:40 | <jriley> Nothing to scrum - I forgot I was in chat and got lunch |
| 18:18:43 | <rafa> bwolfe: the problem is only that the search handler has just getItem by uuid, but you can add getItem by id :) |
| 18:19:25 | *** kishoreyekkanti has quit IRC |
| 18:19:26 | <bwolfe> I don't see that as a problem. :-) |
| 18:19:30 | <bwolfe> rafa, thanks, I'll look into it |
| 18:26:09 | *** rafa has quit IRC |
| 18:32:15 | *** rafa has joined #openmrs |
| 18:32:15 | *** ChanServ sets mode: +v rafa |
| 18:36:48 | <bwolfe> rafa, hmm, seems I was looking at an unmarshal the wrong class. that should be fine |
| 18:38:31 | <rafa> bwolfe: very well |
| 18:39:12 | <bwolfe> rafa, I assume that if id exists and uuids are the same its ok, right? Or should I null out the id if the id exists regardless? |
| 18:39:49 | <rafa> bwolfe: if uuids are the same its ok |
| 18:40:28 | <rafa> bwolfe: if you null them they will be matched later anyway |
| 18:41:14 | <rafa> bwolfe: sorry no I take back the last statement ;) |
| 18:41:26 | <rafa> bwolfe: nevermind |
| 18:41:59 | <rafa> bwolfe: do you know well the sync module? |
| 18:42:18 | <bwolfe> rafa, well enough |
| 18:42:41 | <rafa> bwolfe: can you have a look at https://tickets.openmrs.org/browse/META-174 later? |
| 18:43:43 | <bwolfe> ah yes. I remember writing something like this for sync. then darius thought up something even fancier and implemented that. |
| 18:43:58 | <rafa> bwolfe: ohh it was Darius :) |
| 18:43:58 | <bwolfe> I can do that one next, assign it to me |
| 18:44:02 | <rafa> bwolfe: I liked it a lot |
| 18:44:32 | <rafa> bwolfe: done |
| 18:46:15 | <bwolfe> rafa, are modules meant to implement their own metadata sharing handlers? |
| 18:56:59 | <rafa> bwolfe: that's right |
| 18:57:10 | <rafa> bwolfe: but you're safe to modify them at this point |
| 18:57:23 | <rafa> bwolfe: no one really used this feature so far |
| 18:58:01 | <rafa> bwolfe: well Mike experimented with that :) |
| 18:58:19 | <bwolfe> rafa, ok, well my comment was more that you should put a base abstract class in front of hte interface so that you can safely change the interface in future versions without worrying that you're breaking every module |
| 18:58:30 | <bwolfe> if you don't have that, then as soon as you change the interface all modules break |
| 18:58:42 | *** downeym has quit IRC |
| 18:58:54 | <rafa> bwolfe: or I can add a new interface :) |
| 18:59:09 | <rafa> bwolfe: instead of modifying |
| 18:59:17 | *** suranga has joined #openmrs |
| 18:59:41 | <bwolfe> I suppose you could, since you're using components to find the implemented handlers |
| 18:59:51 | <bwolfe> but that naming would get annoying after just a few |
| 18:59:52 | <bwolfe> :-) |
| 19:00:28 | <rafa> bwolfe: the trick is someone can implement all interfaces in one class if he wants |
| 19:00:31 | *** downeym has joined #openmrs |
| 19:00:31 | *** ChanServ sets mode: +o downeym |
| 19:00:31 | *** OpenMRSBot sets mode: +o downeym |
| 19:00:37 | <rafa> bwolfe: with abstract classes it's not possible |
| 19:00:56 | <rafa> bwolfe: actually I do that as well :) |
| 19:01:21 | <rafa> bwolfe: see ConceptHandler for instance |
| 19:02:03 | <bwolfe> because you have 5 interfaces? :-) |
| 19:02:23 | <rafa> yhy :D |
| 19:02:33 | <rafa> but not all are always needed |
| 19:05:30 | <rafa> bwolfe: no worries interfaces will be very mature with the 1.0 release ;) |
| 19:05:55 | <rafa> bwolfe: perfect :D |
| 19:09:51 | *** burke has joined #openmrs |
| 19:09:51 | *** ChanServ sets mode: +o burke |
| 19:13:08 | <r_friedman> bwolfe: hi ben, got a minute? |
| 19:14:27 | <bwolfe> sure |
| 19:14:53 | <r_friedman> could you explain to me when you have to use a getter and when you can use a local variable directly? |
| 19:15:23 | <bwolfe> in rest? |
| 19:15:34 | <r_friedman> in general, i'd say, in a pojo |
| 19:15:54 | <r_friedman> well, a DB backing pojo |
| 19:16:25 | <bwolfe> so from the hibernate mapping? or from another java method/class ? |
| 19:16:42 | <r_friedman> one created from the hibernate mapping |
| 19:18:22 | <r_friedman> bwolfe: my doubt arises from the code in baseopenmrsobject |
| 19:19:08 | <bwolfe> meaning when do you have to call "getId()" vs just "id" in the same object? |
| 19:19:15 | <r_friedman> there is a comment i think in hashcode that it has to use getuuid rather than merely access the uuid local variable |
| 19:19:17 | <r_friedman> yes |
| 19:20:19 | <wyclif> http://wiki.chip.org/smart-project/index.php/Developers_Documentation:_SMART_Container_Javascript_Libraries |
| 19:20:20 | <wyclif> bwolfe, http://wiki.chip.org/smart-project/index.php/Developers_Documentation:_SMART_Container_Javascript_Libraries |
| 19:20:24 | <OpenMRSBot> <http://ln-s.net/9VUa> (at wiki.chip.org) |
| 19:20:25 | <OpenMRSBot> <http://ln-s.net/9VUa> (at wiki.chip.org) |
| 19:20:42 | <bwolfe> "getId()" should be favored for most things in case there is hibernate lazy loading |
| 19:21:39 | <r_friedman> bwolfe: so what if you have a local variable containing the locale, that's not filled by hibernate and therefore can be used directly? |
| 19:22:33 | <bwolfe> r_friedman, but usually hibernate doesn't lazy load the basic properties (string, date, int, boolean, etc). those are never lazy loaded by default. but things like getIdnetifierType(), getEncounters() etc, those are loaded lazily. so just using the property might return you null whereas the getter returns the actual db values |
| 19:23:12 | <bwolfe> r_friedman, yes, you can use it directly |
| 19:23:16 | *** burke has quit IRC |
| 19:23:20 | <r_friedman> bwolfe: thanks, clear |
| 19:23:37 | <wyclif> bwolfe, http://sandbox.smartplatforms.org/ |
| 19:28:40 | *** rafa has quit IRC |
| 19:31:44 | <wyclif> https://tickets.openmrs.org/browse/SMART-36 |
| 19:34:35 | *** suranga has quit IRC |
| 19:58:56 | *** wyclif has quit IRC |
| 20:11:34 | <jriley> I've opened TRUNK-3014 and submitted a fix. I can't change status to code review requested. Could someone push it out of Needs Assessment? |
| 20:11:38 | <jriley> !ticket TRUNK-3014 |
| 20:11:39 | <OpenMRSBot> jriley: [#TRUNK-3014] Encounter.addObs doesnt propogate attrs to obs.groupMembers - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3014 |
| 20:12:25 | *** wyclif has joined #openmrs |
| 20:26:16 | *** jriley has quit IRC |
| 20:34:55 | *** james_regen has left #openmrs |
| 20:50:52 | *** robbyoconnor has joined #openmrs |
| 20:50:52 | *** ChanServ sets mode: +v robbyoconnor |
| 21:04:57 | *** bwolfe has quit IRC |
| 21:22:05 | *** lh has joined #openmrs |
| 22:15:55 | <downeym> hi lh :) |
| 22:16:21 | <lh> downeym: how are you? |
| 22:16:30 | <downeym> lh: fantastic - happy new year. :) |
| 22:16:47 | <downeym> lh: s/year/start/ |
| 22:17:14 | <lh> downeym: thank you. :) |
| 22:24:22 | *** bryq has quit IRC |
| 22:51:29 | *** downeym has quit IRC |
| 23:11:00 | *** wyclif has quit IRC |
| 23:52:06 | *** r0bby has joined #openmrs |
| 23:52:06 | *** ChanServ sets mode: +v r0bby |
| 23:52:09 | *** robbyoconnor|2 has joined #openmrs |
| 23:52:09 | *** ChanServ sets mode: +v robbyoconnor|2 |
| 23:52:13 | *** r0bby has quit IRC |
| 23:52:13 | *** robbyoconnor|2 has quit IRC |