| 00:37:57 | *** wyclif has joined #openmrs |
| 00:41:13 | *** djazayeri has joined #openmrs |
| 00:41:13 | *** ChanServ sets mode: +o djazayeri |
| 00:52:32 | <deadpool> djazayeri: if i am using the ant deploy web module how do i set the ${env.CATALINA_HOME} |
| 00:53:58 | <djazayeri> deadpool: I think you can create a custom build.properties file somewhere |
| 00:54:24 | <djazayeri> deadpool: alternately you can edit the build.xml file and manually put in the value. (I used to do that because I couldn't bother to remember where to set it otherwise.) |
| 00:54:37 | <deadpool> djazayeri: the latter is what i want to do |
| 00:54:41 | <deadpool> what do i put in that |
| 00:54:59 | <deadpool> do i point it to where the module is being deployed? |
| 00:56:43 | <djazayeri> look for "deploy-web-darius" here: https://source.openmrs.org/browse/Modules/htmlformentry/build.xml?r2=9028&r1=8333 |
| 00:57:00 | <djazayeri> deadpool: hacky, and now deleted, but it gets the idea across. :-) |
| 00:59:16 | <deadpool> djazayeri: what if i am using jetty instead of tomcat? |
| 01:02:11 | <djazayeri> deadpool: look here: https://source.openmrs.org/browse/Modules/reporting/trunk/build.xml?r2=18993&r1=18201 |
| 01:10:04 | <deadpool> djazayeri: not using trunk either? |
| 01:10:23 | <deadpool> i have deployed openmrs 1.8 using jetty standalone |
| 01:11:21 | <djazayeri> deadpool: if you're doing active development, why not just use mvn jetty:run? |
| 01:12:15 | <deadpool> djazayeri: for core that is what i use for module development i use stable |
| 01:12:16 | <djazayeri> are you developing a module, or core? |
| 01:12:19 | <deadpool> version |
| 01:12:25 | <deadpool> djazayeri: doing both |
| 01:12:46 | <djazayeri> deadpool: okay, you could also check out the 1.8.2 tag from svn, for example, and do jetty:run from there. |
| 01:12:56 | <djazayeri> regardless, with jetty standalone, somewhere there's a WEB-INF folder for the webapp you have deployed |
| 01:13:27 | <djazayeri> if you're developing a module, you need to make sure that deploy-web writes to WEB-INF/view/module/${moduleId} |
| 01:13:37 | <deadpool> djazayeri: gotcha will do |
| 01:39:27 | <deadpool> djazayeri: found it thanks |
| 01:39:41 | <deadpool> apparently jetty dynamically creates the directory |
| 02:20:30 | <deadpool> djazayeri: thanks i got it working |
| 02:20:45 | <djazayeri> col |
| 02:20:46 | <djazayeri> cool |
| 02:45:50 | *** deadpool has quit IRC |
| 03:02:23 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @edjez: @InstEDD's Channe Suy (@s_channe) from iLab in Southeast Asia on @OpenMRS meeting @s_channe http://t.co/Laq09ZiY cc @pbiondic ... <http://twitter.com/OpenMRS/statuses/149310220596817920> |
| 03:42:59 | *** bwolfe__ has joined #openmrs |
| 03:46:43 | *** bwolfe_ has quit IRC |
| 05:11:23 | *** kishoreyekkanti has joined #openmrs |
| 05:19:49 | *** rafa has quit IRC |
| 05:28:17 | *** morristic has quit IRC |
| 05:34:46 | <kishoreyekkanti> djazayeri: Hi Darius. From today, I got 2 other people working with me for release tests. Can you tell me the priority among 1. Fixing the existing trunk release tests 2. Writing the release tests for HTMLFormEntry module. |
| 05:37:48 | <djazayeri> kishoreyekkanti: fix existing ones first |
| 05:38:04 | *** surangak has joined #openmrs |
| 05:38:53 | <kishoreyekkanti> djazayeri: Sure, Thank you! For showcasing some thing for the module developers on how to write release tests in the module we already have the formentry module as an example |
| 05:39:19 | <djazayeri> Sounds good. |
| 05:39:24 | <djazayeri> off to bed now. |
| 05:39:25 | <djazayeri> tty tomorrow |
| 05:40:21 | <kishoreyekkanti> djazayeri: cool have a good night :) |
| 05:40:40 | *** Mani has joined #openmrs |
| 05:40:50 | *** Mani is now known as Guest66044 |
| 05:42:54 | *** shobana has joined #openmrs |
| 05:56:44 | *** surangak_ has joined #openmrs |
| 06:38:20 | *** djazayeri has quit IRC |
| 07:12:30 | *** bryq has joined #openmrs |
| 07:12:30 | *** ChanServ sets mode: +v bryq |
| 07:29:01 | *** Boby has joined #openmrs |
| 07:30:35 | <Boby> Anybody know what is Rule out and History of when "Add Problem" in field "Modifier" ? |
| 07:30:45 | <Boby> Can you explain me ? |
| 07:33:05 | *** shobana has quit IRC |
| 07:34:10 | <Boby> Anybody can help me ? |
| 07:37:09 | *** Guest66044 has quit IRC |
| 07:45:39 | *** dkayiwa has joined #openmrs |
| 08:08:44 | *** Guest66044 has joined #openmrs |
| 08:17:28 | *** shobana has joined #openmrs |
| 08:18:49 | *** bwolfe__ is now known as bwolfe |
| 08:18:54 | <bwolfe> Boby, I think there is a wiki page for it |
| 08:18:55 | <bwolfe> one sec |
| 08:19:51 | <bwolfe> Boby, hmm, seems the page doesn't say :-/ https://wiki.openmrs.org/display/docs/Allergy+and+Problem+Lists |
| 08:31:36 | <Boby> the page https://wiki.openmrs.org/display/docs/Allergy+and+Problem+Lists doesn't say :( |
| 08:32:39 | <bwolfe> sad |
| 08:32:50 | <bwolfe> Boby, if I describe them here, will you add them to the wiki page? |
| 08:33:50 | <Boby> yes |
| 08:38:01 | <Boby> Can you get any infomation about it ? |
| 08:38:08 | <Boby> Can you share me? |
| 08:38:53 | <bwolfe> Boby, "Rule Out" is used when a doc is going through and listing off problems that they have determined to not be the case |
| 08:39:10 | <bwolfe> Boby, "history of" is when someone is just getting the history of a patient and any problems they have had in the past |
| 08:41:04 | *** rafa has joined #openmrs |
| 08:41:04 | *** ChanServ sets mode: +v rafa |
| 08:55:17 | *** dkayiwa_ has joined #openmrs |
| 08:58:13 | *** dkayiwa has quit IRC |
| 08:58:13 | *** dkayiwa_ is now known as dkayiwa |
| 09:06:38 | <surangak_> bwolfe, thanks for wrapping up 1763 yesterday.. im stuck with some ampath stuff, and frankly, not feeling too well either :( |
| 09:23:25 | *** deepa has joined #openmrs |
| 09:28:27 | <deepa> hey please guys help me out |
| 09:28:31 | <deepa> any one there |
| 09:28:38 | <deepa> i have a question |
| 09:28:55 | <deepa> what do i do to capture the social hisorty |
| 09:29:16 | <deepa> i have created a form , where i have addes the concepts in it |
| 09:29:41 | <deepa> now i have created an encounter and associated the form with it to the patient |
| 09:30:09 | <deepa> these forms can be used to enter data ? if yes how do i enter data |
| 09:35:19 | <dkayiwa> deepa: which formentry module are you using? |
| 09:36:01 | <dkayiwa> deepa: formentry, htmlformentry, or xforms module? |
| 09:36:50 | <deepa> i have only form entry |
| 09:37:15 | <deepa> should i download htmlformentry |
| 09:37:29 | <dkayiwa> deepa: formentry uses microsoft infopath |
| 09:37:29 | <deepa> coz i need to capture data online |
| 09:37:52 | <deepa> should i download htmlformentry |
| 09:37:54 | <dkayiwa> deepa: if you do not want to use microsoft infopath, you may try htmlformentry or xforms modules |
| 09:37:55 | <deepa> dkayiwa: |
| 09:38:02 | <deepa> ok |
| 09:38:13 | <dkayiwa> deepa: whichever you find easier of the them |
| 09:38:16 | <deepa> so can i upload the data using the website |
| 09:38:36 | <dkayiwa> deepa: yes for htmlformentry or xforms modules |
| 09:38:55 | <deepa> oh great : ) |
| 09:40:03 | <deepa> should i create a form also using html form entry ? |
| 09:40:23 | <dkayiwa> deepa: it depends on which one you find easier to use |
| 09:40:40 | <dkayiwa> deepa: you can read some information on the wiki about each module and what it requires |
| 09:40:48 | <deepa> i have created a form using forms |
| 09:41:08 | <deepa> coz i need to use the concept as questions |
| 09:41:25 | <deepa> but want to enter data using html form entry |
| 09:41:28 | <deepa> is it possible |
| 09:41:55 | <dkayiwa> deepa: have you read the wiki page on how to use the module? |
| 09:42:01 | <deepa> no |
| 09:42:03 | <deepa> i will |
| 09:51:05 | *** deepa has quit IRC |
| 10:07:34 | *** Boby has quit IRC |
| 10:11:44 | *** surangak_ has quit IRC |
| 10:12:09 | *** surangak_ has joined #openmrs |
| 10:12:30 | *** surangak has quit IRC |
| 10:12:40 | *** surangak_ has quit IRC |
| 10:12:45 | *** surangak_ has joined #openmrs |
| 10:19:27 | *** deepa has joined #openmrs |
| 10:19:52 | <deepa> dkayiwa: the html form entry module is giving me error while createing a new HTML form |
| 10:26:05 | *** surangak__ has joined #openmrs |
| 10:28:19 | *** bryq has left #openmrs |
| 10:39:55 | *** deepa has quit IRC |
| 11:00:12 | *** surangak_ has quit IRC |
| 11:00:38 | *** surangak__ has quit IRC |
| 11:04:29 | *** shobana has quit IRC |
| 11:25:12 | <kishoreyekkanti> bwolfe: dkayiwa : Any idea why this build got failed https://ci.openmrs.org/browse/JUNIT-TRUNK-JOB1-1769/log |
| 11:25:36 | <dkayiwa> kishoreyekkanti: could be a memory problem |
| 11:25:37 | <bwolfe> kishoreyekkanti, is there the text "Killed" in there somewhere? |
| 11:25:46 | <bwolfe> kishoreyekkanti, looks like "yes" |
| 11:25:57 | <bwolfe> so as dkayiwa says, its an OOM on the server |
| 11:25:58 | <kishoreyekkanti> do you want me to retrigger the build |
| 11:26:20 | <bwolfe> yes, either recommit or go on CI and rebuild it |
| 11:26:32 | <kishoreyekkanti> cool, lemme try rebuilding it |
| 11:27:39 | *** shobana has joined #openmrs |
| 11:30:08 | <kishoreyekkanti> i guess i don't have enough rights to re trigger the build |
| 11:30:50 | <kishoreyekkanti> bwolfe dkayiwa can any one of you re trigger for me |
| 11:32:01 | <dkayiwa> kishoreyekkanti: i do not know how to do that :) |
| 11:32:46 | <kishoreyekkanti> dkayiwa: I guess here https://ci.openmrs.org/browse/JUNIT-TRUNK under Actions you will have an option to retrigger tbe build |
| 11:34:17 | <dkayiwa> ok |
| 11:39:04 | <kishoreyekkanti> dkayiwa I guess the url should be https://ci.openmrs.org/browse/JUNIT-TRUNK-JOB1-1769 instead of the previous one |
| 11:39:42 | *** rkmani has joined #openmrs |
| 11:41:26 | *** Guest66044 has quit IRC |
| 11:41:36 | <dkayiwa> kishoreyekkanti: i do not see action |
| 11:43:48 | <bwolfe> dkayiwa, you can retrigger on the main page too. http://ci.openmrs.org . click the play button next to junit --> trunk |
| 11:53:29 | *** kishoreyekkanti_ has joined #openmrs |
| 11:55:23 | *** kishoreyekkanti has quit IRC |
| 11:55:25 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 11:56:15 | *** shobana has quit IRC |
| 12:24:19 | *** james_regen has joined #openmrs |
| 12:24:19 | *** ChanServ sets mode: +v james_regen |
| 12:27:31 | *** kishoreyekkanti has quit IRC |
| 12:27:44 | *** dkayiwa has left #openmrs |
| 12:28:09 | *** rkmani has left #openmrs |
| 12:43:27 | *** mimi has quit IRC |
| 12:44:17 | *** mimi has joined #openmrs |
| 12:49:10 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Release Testing Helper 1.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=releasetestinghelper&version=&1.0> || OpenMRS Modules: Release Testing Helper 1.0-SNAPSHOT uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=releasetestinghelper&version=&1.0-SNAPSHOT> |
| 13:07:31 | *** bryq has joined #openmrs |
| 13:07:31 | *** ChanServ sets mode: +v bryq |
| 13:11:09 | *** wyclif has quit IRC |
| 13:16:15 | *** r3friedman has joined #openmrs |
| 13:16:22 | *** r3friedman is now known as r_friedman |
| 13:16:30 | <r_friedman> bwolfe: morning ben, are you there? |
| 13:17:30 | <r_friedman> rafa: hi rafa, are you there? |
| 13:17:43 | *** rafa has quit IRC |
| 13:18:24 | *** r_friedman has quit IRC |
| 13:36:34 | *** r3friedman has joined #openmrs |
| 13:36:41 | *** r3friedman is now known as r_friedman |
| 13:37:18 | <r_friedman> bwolfe: ben, good morning, are you really there |
| 13:50:15 | *** dkayiwa has joined #openmrs |
| 13:53:57 | *** wyclif has joined #openmrs |
| 13:58:34 | *** wyclif has quit IRC |
| 13:58:45 | <dkayiwa> hi bwolfe |
| 14:01:03 | <r_friedman> hi dkayiwa |
| 14:01:10 | <dkayiwa> hi r_friedman |
| 14:01:28 | <r_friedman> dkayiwa: i have reopened trunk-2884 |
| 14:01:50 | <dkayiwa> ok |
| 14:02:08 | <r_friedman> dkayiwa: it may be fixed in 1.9, but it's broken in 1.8.2(?) |
| 14:02:14 | <dkayiwa> ok |
| 14:02:37 | <r_friedman> dkayiwa: we need to have some way to identify what version a war is without running it |
| 14:02:47 | <dkayiwa> ok |
| 14:03:11 | <r_friedman> maybe have a version file that contains text (perhaps dependencies?) |
| 14:03:26 | <dkayiwa> ok |
| 14:04:27 | *** downeym has joined #openmrs |
| 14:04:27 | *** OpenMRSBot sets mode: +o downeym |
| 14:04:27 | *** ChanServ sets mode: +o downeym |
| 14:05:38 | *** djazayeri has joined #openmrs |
| 14:05:38 | *** ChanServ sets mode: +o djazayeri |
| 14:11:19 | *** wyclif has joined #openmrs |
| 14:31:43 | *** dkayiwa_ has joined #openmrs |
| 14:35:22 | *** dkayiwa has quit IRC |
| 14:35:23 | *** dkayiwa_ is now known as dkayiwa |
| 14:40:27 | *** jriley has joined #openmrs |
| 14:43:46 | *** burke has joined #openmrs |
| 14:43:46 | *** ChanServ sets mode: +o burke |
| 15:03:25 | *** r_friedman has quit IRC |
| 15:09:46 | <wyclif> hi dkayiwa |
| 15:09:56 | <dkayiwa> hi wyclif |
| 15:10:23 | <wyclif> when are you releasing? |
| 15:10:33 | <dkayiwa> wyclif: today :) |
| 15:14:22 | *** burke has quit IRC |
| 15:19:51 | <wyclif> dkayiwa, have you seen the devlist comments on TRUNK-2884 |
| 15:20:20 | <wyclif> dkayiwa, i guess you would want to check if that is right in 1.9.x |
| 15:20:48 | <djazayeri> dkayiwa, wyclif: I believe Roger's problem is solved, but that may need to be backported. |
| 15:20:56 | <djazayeri> Also, we need to decide about form resources. |
| 15:21:49 | <dkayiwa> !ticket trunk-2884 |
| 15:21:51 | <djazayeri> My take is that I'm sure Jeremy won't be able to write all that code today |
| 15:21:51 | <OpenMRSBot> dkayiwa: [#TRUNK-2884] OpenMRS cannot find runtime properties - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2884 |
| 15:22:18 | <djazayeri> so I think we should release the beta without it, but know that we're going to have to do more testing between beta and RC as he adds it. |
| 15:22:21 | <dkayiwa> wyclif: yes i saw it |
| 15:22:39 | <dkayiwa> wyclif: should i create another tag to include it? |
| 15:24:01 | <dkayiwa> djazayeri: more testing my the end users or release manager? |
| 15:24:06 | <dkayiwa> my = by |
| 15:28:23 | <djazayeri> dkayiwa: probably internal testing by us |
| 15:28:39 | <dkayiwa> djazayeri: ok |
| 15:29:06 | <djazayeri> dkayiwa: does the thing from TRUNK-2884 need to be backported? |
| 15:31:55 | *** jriley has quit IRC |
| 15:34:09 | <dkayiwa> djazayeri: it is already in 1.9.x |
| 15:36:36 | <djazayeri> dkayiwa: so the current tag is good, then? |
| 15:37:54 | <dkayiwa> djazayeri: yes |
| 15:38:34 | *** morristic has joined #openmrs |
| 15:46:35 | <djazayeri> downeym: for TRUNK-2884 I just did Cancel Issue and said "Fixed" but it shows up as "Won't Fix". |
| 15:46:41 | <djazayeri> I tried this twice in a row. |
| 15:46:42 | <djazayeri> thoughts? |
| 15:46:55 | <downeym> !ticket TRUNK-2884 |
| 15:46:57 | <OpenMRSBot> downeym: [#TRUNK-2884] OpenMRS cannot find runtime properties - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2884 |
| 15:47:35 | *** wyclif has quit IRC |
| 15:47:46 | *** wyclif has joined #openmrs |
| 15:49:21 | <downeym> djazayeri: If you cancelled the issue, how could you have fixed it? |
| 15:49:51 | <djazayeri> downeym: ben fixed it, roger reopened it incorrectly, so I wanted to just close it again |
| 15:50:03 | <downeym> djazayeri: ah |
| 15:50:24 | <wyclif> hi dkayiwa, i want to pick up the non essential ticket in the sprint and see if i can have them included in the beta but you dont have to wait for |
| 15:50:43 | <djazayeri> try doing Reopen Issue -> Continue Work -> Cancel Issue, and choose "Fixed" in the dropdown. |
| 15:50:48 | <djazayeri> you'll see that it comes out as "Won't Fix" |
| 15:50:54 | <djazayeri> downeym: (at least it did for me twice) |
| 15:51:28 | <djazayeri> wyclif: I believe that dkayiwa has already tagged the beta revision |
| 15:51:47 | <wyclif> oh |
| 15:51:53 | <wyclif> djazayeri, thanks |
| 15:52:09 | <dkayiwa> djazayeri: correct |
| 15:53:35 | <downeym> djazayeri: I'll add something like a re-close from the reopened state to handle something like that |
| 15:54:18 | <djazayeri> downeym: okay, but do you know why it's showing a Fixed option for resolution, but ignoring it? |
| 15:54:24 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @ekrub: Did you know that @OpenMRS University provides bi-weekly Q sessions to answer your dev questions? https://t.co/eraixT3I <http://twitter.com/OpenMRS/statuses/149504570811351040> |
| 15:54:48 | <downeym> djazayeri: because you cancelled it from work in progress, meaning you were working on the issue but declined to finish it. :) |
| 15:55:34 | <djazayeri> downeym: okay, I'd argue that if it's going to show a dropdown letting me choose the resolution, it should not ignore it |
| 15:56:08 | *** djazayeri has left #openmrs |
| 15:56:20 | *** djazayeri has joined #openmrs |
| 15:56:21 | *** ChanServ sets mode: +o djazayeri |
| 15:56:49 | *** dkayiwa has quit IRC |
| 16:27:57 | *** mimi has quit IRC |
| 16:53:06 | *** suranga has joined #openmrs |
| 17:07:57 | *** deadpool_ has joined #openmrs |
| 17:15:11 | *** bwolfe has quit IRC |
| 17:39:52 | *** bwolfe has joined #openmrs |
| 17:39:52 | *** ChanServ sets mode: +o bwolfe |
| 17:41:59 | *** deepa has joined #openmrs |
| 17:42:21 | <deepa> hey guys i am going beserk trying to use html form entry module |
| 17:42:55 | <deepa> java.lang.NoSuchFieldError: INTEGER at org.openmrs.module.htmlformentry.db.hibernate.HibernateHtmlFormEntryDAO.getUsersAsPersonStubs(HibernateHtmlFormEntryDAO.java:79) |
| 17:42:56 | <deepa> every time i try to create an Html form i get this error |
| 17:43:02 | <deepa> what should i do |
| 17:43:30 | <deepa> html form entry module 1.7.3 |
| 17:43:36 | <deepa> openmrs 1.10 |
| 17:43:46 | <bwolfe> deepa, I assume you are using trunk code? |
| 17:43:46 | <deepa> these are the versions which i am using |
| 17:43:54 | <deepa> yes |
| 17:43:55 | <bwolfe> deepa, I think you need trunk code of htmlformentry too |
| 17:44:03 | <deepa> i tried even with 1.8.2 |
| 17:44:15 | <deepa> i didnt get you bwolfe |
| 17:44:19 | <bwolfe> I don't think the fix in htmlformentry has been released yet. but check with djazayeri |
| 17:44:31 | <bwolfe> it has been found and committed to htmlformentry. |
| 17:44:36 | <bwolfe> but not released as an omod |
| 17:44:53 | <bwolfe> so you have to check out the htmlformentry code (from git) and compile/package the omod yourself |
| 17:44:57 | <deepa> so should i build it |
| 17:45:06 | <deepa> ok i will try that |
| 17:46:30 | *** r3friedman has joined #openmrs |
| 17:46:39 | *** r3friedman is now known as r_friedman |
| 17:46:41 | <deepa> i am creating a form in OpenMRS , whenever a patient fills that form the data should migrate from my adaptor to cOS (clinical operating system ) |
| 17:46:54 | <r_friedman> djazayeri: hey darius, got a minute? |
| 17:47:21 | <djazayeri> r_friedman: no, not right now. in 45 mins. |
| 17:47:35 | <r_friedman> djazayeri: ok, ping me then pls |
| 17:47:42 | <deepa> so can you tell me which method does that so i can use AOP to get the data |
| 17:48:30 | <djazayeri> sorry, gotta run for a bit , deepa, hopefully someone else can answer |
| 17:48:45 | <bwolfe> deepa, you'd probably want to AOP around Encounter.saveEncounter() |
| 17:50:21 | <deepa> oh so does the form data get stored within the encounter |
| 17:50:33 | <deepa> coz in the form i am using the concepts |
| 17:50:37 | *** dawn_ has joined #openmrs |
| 17:50:39 | <deepa> to ask questions |
| 17:51:13 | <bwolfe> the encounter has 0 to n observations (obs) associated to it |
| 17:51:24 | <bwolfe> each obs.concept_id is the concept_id from the question on the form |
| 17:53:42 | <deepa> oh thanks so much bwolfe you are a life saver |
| 17:53:48 | <deepa> cheers |
| 17:54:59 | <bwolfe> :-) |
| 17:58:18 | *** deepa has quit IRC |
| 18:00:10 | <dawn_> !scrumon dawn |
| 18:00:10 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 18:00:32 | <dawn_> djazayeri: wyclif , bwolfe : hi |
| 18:00:39 | <dawn_> small group today |
| 18:00:48 | <dawn_> Today's order: djazayeri , wyclif , bwolfe |
| 18:01:37 | <bwolfe> what?!? I'm last? ;-) |
| 18:03:03 | <djazayeri> hi |
| 18:03:07 | <dawn_> bwolfe: you will always give me a hard time no matter where you are in the order :P |
| 18:03:09 | <djazayeri> trade ya :-) |
| 18:03:22 | <bwolfe> dawn_, of course |
| 18:03:48 | <bwolfe> trade accepted |
| 18:03:53 | <bwolfe> today: |
| 18:03:53 | <bwolfe> reviewed tickets in sprint |
| 18:03:53 | <bwolfe> added to 1.8-1.9 migration page |
| 18:03:53 | <bwolfe> set up for design forum/call |
| 18:03:53 | <bwolfe> cleaned up and added dev documentation pages |
| 18:03:55 | <bwolfe> design forum conf call |
| 18:03:57 | <bwolfe> pm call |
| 18:03:59 | <bwolfe> no blockers |
| 18:04:53 | <djazayeri> wyclif? |
| 18:05:27 | <wyclif> yesterday: |
| 18:05:27 | <wyclif> -TRUNK-2994 - Patient search on find or create patient page is broken |
| 18:05:27 | <wyclif> -TODOs and back porting code for TRUNK-2993 - Fix return type of ConceptDAO.getCountOfConceptReferenceTerms |
| 18:05:27 | <wyclif> -TODOs and back porting code for TRUNK-2273 - Avoid Duplicate Rows in Patient_State Table |
| 18:05:27 | <wyclif> today: |
| 18:05:28 | <djazayeri> Okay, I'll go next |
| 18:05:29 | <wyclif> -TRUNK-198 - Small fixes for newpatient.form |
| 18:05:31 | <wyclif> -TRUNK-2912 - Active visit portlet on dashboard should show date + time in a prettier way |
| 18:05:33 | <wyclif> -TRUNK-1551 - Add Option for Tasks to Skip Execution if one is running already |
| 18:05:35 | <wyclif> -design call |
| 18:06:30 | <dawn_> wyclif: any blockers? |
| 18:06:38 | <wyclif> no blockers |
| 18:06:50 | <djazayeri> Tuesday 20-Dec-2011 |
| 18:06:50 | <djazayeri> * Committed HTML-221 |
| 18:06:50 | <djazayeri> * Point release of reporting module 0.7.0.1 for the 1.9 beta release |
| 18:06:50 | <djazayeri> * Write a wiki page describing how to get user types to work across Hibernate 3.2.5 and 3.6. |
| 18:06:50 | <djazayeri> * Reviewed some edits to book from doc sprint |
| 18:06:50 | <djazayeri> * Talk to Rafal about MDS sprint if he has time (but I don't see him onlineâ¦) |
| 18:06:50 | <djazayeri> * Discussed Logic 2.0 with Mike |
| 18:06:51 | <djazayeri> * (Randomly) talked to a consultant about the structure of the US EMR market. (Nothing relevant.) |
| 18:06:52 | <djazayeri> Wednesday 21-Dec-2011 |
| 18:06:52 | <djazayeri> * University call |
| 18:06:53 | <djazayeri> * Discussed reporting with Mike |
| 18:06:53 | <djazayeri> * Design call |
| 18:06:54 | <djazayeri> * Project Management call |
| 18:06:54 | <djazayeri> * Write some documentation content for the book |
| 18:07:15 | *** rafa has joined #openmrs |
| 18:07:15 | *** ChanServ sets mode: +v rafa |
| 18:07:16 | <djazayeri> (err, didn't talk to Rafal about MDS yesterday) |
| 18:07:57 | <djazayeri> no blockers |
| 18:08:30 | <dawn_> rafa: we went through the updates, so you can go now :) |
| 18:09:05 | <rafa> that was fast :) |
| 18:09:06 | <rafa> hi |
| 18:09:07 | <rafa> Today: |
| 18:09:07 | <rafa> * Committed META-161: Speedup searching for Concepts |
| 18:09:07 | <rafa> https://tickets.openmrs.org/browse/META-161 |
| 18:09:07 | <rafa> * Investigated on auto-incremented ids |
| 18:09:07 | <rafa> * Design call |
| 18:09:08 | <rafa> Tomorrow: |
| 18:09:08 | <rafa> * Implementers forum |
| 18:09:09 | <rafa> No blockers. |
| 18:10:06 | <djazayeri> rafa: make sure you've read up on the AMPATH use case for MDS, and you're set to lead a conversation about MDS the first half of the design call |
| 18:10:24 | <dawn_> bwolfe: doc print updateâ¦.how are we going to finish this one time? :) |
| 18:10:29 | <dawn_> *sprint |
| 18:10:37 | <dawn_> !scrumoff dawn |
| 18:10:37 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 18:10:43 | <rafa> djazayeri: yes, I've read that |
| 18:11:05 | <djazayeri> rafa: I'm happy to have a preliminary discussion if you want |
| 18:11:12 | <djazayeri> otherwise we can just discuss on the design call |
| 18:11:14 | <bwolfe> dawn_, depends what our goals are. :-) |
| 18:11:26 | <dawn_> bwolfe: can we flesh those out on the project management call today? |
| 18:11:42 | <bwolfe> the goals? sure |
| 18:11:50 | <bwolfe> probably should have done that /before/ the sprint ;-) |
| 18:12:08 | <dawn_> djazayeri: let me know the specifics on the "write some documentation content for the book" will be good to let jan and dana know |
| 18:12:27 | <dawn_> djazayeri: also know you need to chat with rafal for MDS |
| 18:12:43 | <djazayeri> bwolfe: we had goals, it just appears that they we were misinformed about what people would be able to do... |
| 18:13:06 | <djazayeri> dawn_: I looked at the "OpenMRS Information Model" section and I see that nothing was added about the new 1.9 features. |
| 18:13:10 | <dawn_> bwolfe: i think ti's straight forward, but we need people who actually understand some of the topics on the tickets to fill in the gaps. i think the tech writers are more in a stage of editing |
| 18:13:28 | <djazayeri> So I intend to go through the book and add some 1.9 content. |
| 18:13:54 | <downeym> another possibility is to kind of "teach" the writers what should be in the book, then let them write |
| 18:14:10 | <dawn_> djazayeri: thnx |
| 18:14:10 | <djazayeri> dawn_, bwolfe: going into the sprint, I thought that the technical writers would be able to help convert "stuff that Burke and I said" into a first draft of new content. |
| 18:14:16 | <rafa> djazayeri: yes, I've got a question. Is there anything else besides a need to preserve ids in the AMPATH use case? |
| 18:14:35 | <rafa> djazayeri: I understood it's the most important point |
| 18:14:38 | <djazayeri> dawn_: I didn't realize they weren't comfortable with that until yesterday. |
| 18:14:52 | <bwolfe> djazayeri, but how much was said? I saw that the first call did go through the 1.9 features...but now you say those aren't really written about? |
| 18:14:56 | <djazayeri> dawn_, downeym: so I don't know how to approach that. |
| 18:15:03 | <dawn_> downeym: that's what djazayeri and burke tried last wednesday it sounds like, but it didn't have the end result we envisioned |
| 18:15:09 | <downeym> hm |
| 18:15:24 | <downeym> were we explicit about our expectations as to what'd happen after that meeting? |
| 18:15:26 | <dawn_> djazayeri: i agree that was the intent and that's what came across in our first meeting. so i think we need to reorganize given what we know now |
| 18:15:30 | <bwolfe> more teaching than a 30 min phone call? |
| 18:15:59 | <djazayeri> we spent ~ 45 minutes describing what we thought was necessary to write down about the new features. Someone took notes (I forget if it was Jan or Dana) and I'd love to see those notes. |
| 18:16:24 | <djazayeri> But AFAIK none of that stuff actually got written up beyond taht. |
| 18:16:32 | <dawn_> downeym: djazayeri bwolfe : I think that this point it would take more time to teach ,ask ppl to write, for us to double check it and then edit it for the final copyâ¦..but we can weigh the pros and cons in our project management meeting |
| 18:17:04 | <djazayeri> as a meta point, we need to actually have daily catchups on a sprint like this |
| 18:17:25 | <djazayeri> so we can realize things like this and change course earlier. |
| 18:17:41 | <dawn_> djazayeri: completely agree |
| 18:17:44 | <djazayeri> rafa: I only know about preserving concept_ids so far. |
| 18:17:50 | <downeym> +1 |
| 18:18:20 | <djazayeri> rafa: I'm just reading jeremy's wiki page |
| 18:18:25 | <dawn_> djazayeri: bwolfe : did speak with jan, dana, and janet today. they're organizing the documentation area of the wiki for the users/implementers |
| 18:19:15 | <rafa> djazayeri: I thought the sync module does not preserve ids... |
| 18:19:23 | <djazayeri> rafa: it doesn't |
| 18:19:34 | <djazayeri> to be clear, I think they are playing with fire here. |
| 18:19:46 | <rafa> djazayeri: and AMPATH seems to use it |
| 18:19:50 | <djazayeri> they're not using sync now. |
| 18:19:54 | <djazayeri> partly for that reason. |
| 18:19:57 | <djazayeri> What they really need to do is stop depending on primary keys. |
| 18:20:13 | <rafa> djazayeri: okay it's what the big picture says |
| 18:20:46 | <djazayeri> But that's going to take work, because they have lots of hand-written SQL queries that rely on concept_id and encounter_id, I guess. |
| 18:21:03 | <djazayeri> the bottom picture shows sync, the top one shows remote form entry. |
| 18:21:08 | <bwolfe> djazayeri, formentry depends on primary keys, and they depend on formentry for now |
| 18:21:52 | <djazayeri> bwolfe: if it were just formentry, I'd say "fix form entry then" |
| 18:22:07 | <djazayeri> it's also a bunch of other stuff (SQL queries mainly, I guess) |
| 18:22:17 | <bwolfe> queries seems like it too |
| 18:22:35 | <bwolfe> but those should move to reporting widgets ;-) (instead of sas scripts) |
| 18:22:59 | <djazayeri> So, rafa, I'm not opposed to adding an advanced setting for "try to preserve primary keys" if we can do it without breaking other things. |
| 18:23:28 | <rafa> djazayeri: I'm not opposed either. I just don't have any idea how to do that :) |
| 18:23:33 | <bwolfe> djazayeri, iirc they just want to be able have multiple concept+form dev teams |
| 18:24:32 | *** Echidna has quit IRC |
| 18:24:40 | <djazayeri> bwolfe: I think they're trying to do a bunch of different things, some of which require maintaining concept_id, some of which don't. |
| 18:25:13 | <djazayeri> MDS currently lets you create concepts in different places. |
| 18:25:27 | <djazayeri> they don't *just* want that. :-) |
| 18:25:47 | <djazayeri> rafa: do you know how you'd pass along the PK with the MDS package? |
| 18:25:48 | *** Echidna has joined #openmrs |
| 18:25:48 | *** ChanServ sets mode: +v Echidna |
| 18:26:05 | <rafa> djazayeri: yes, it's trivial to pass it along |
| 18:26:38 | <djazayeri> If you look at Concept.hbm.xml in core, you'll see this: |
| 18:26:38 | <djazayeri> <generator class="org.openmrs.api.db.hibernate.NativeIfNotAssignedIdentityGenerator" /> |
| 18:27:49 | <djazayeri> so, specifically for concepts, if you do "new Concept(); c.setConceptId(76543); saveConcept(c);" , the requested PK should be preserved. |
| 18:28:24 | <rafa> djazayeri: is it working? |
| 18:28:25 | <djazayeri> We'd need to add this to other hbm.xml files too. And we'd need to make sure it's still working. :-) |
| 18:29:01 | <djazayeri> rafa: it worked in 1.4. :-) I don't know for sure if it works since the hibernate upgrade. And I don't know for sure if it was working in 1.8 either. |
| 18:29:01 | <bwolfe> theres a unit test for it, so it should still be working. :-) |
| 18:29:21 | <bwolfe> and I think there is a ticket to add this to everything else. not sure if it was every applied |
| 18:29:23 | <djazayeri> I did notice that Chris Z did touch that file. |
| 18:29:27 | *** ball has joined #openmrs |
| 18:29:42 | <bwolfe> he touched all the hbm files. just changed the header |
| 18:29:52 | <djazayeri> I mean that he edited the generator. |
| 18:30:23 | <djazayeri> That hasn't been applied everywhere. Particularly it's not applied to ncounter |
| 18:30:28 | <djazayeri> â¦to EncounterType |
| 18:31:05 | <rafa> bwolfe: Where to look for that unit test? |
| 18:31:19 | <rafa> bwolfe: or else I just write one ;) |
| 18:31:29 | <djazayeri> probably ConceptServiceTest |
| 18:32:25 | <djazayeri> rafa: saveConcept_shouldGenerateIdForNewConceptIfNoneIsSpecified() |
| 18:32:35 | <djazayeri> rafa: saveConcept_shouldKeepIdForNewConceptIfOneIsSpecified() |
| 18:37:08 | <djazayeri> rafa: I actually have a different use case that I'm interested in discussing. Not necessarily right now. |
| 18:38:49 | <djazayeri> Maybe we talked about this before. |
| 18:39:38 | <djazayeri> But let's say I choose that "I trust the MVP concept mapping" |
| 18:40:28 | <djazayeri> if every concept in my dictionary has a mapping to MVP, and I want to import a MDS package where all concepts have a mapping to MVP, we should be able to do this automatically and safely, with no human intervention, right? |
| 18:41:33 | <rafa> djazayeri: right |
| 18:42:34 | <djazayeri> rafa: is that in the current sprint? |
| 18:42:40 | <djazayeri> (I assume not...) |
| 18:43:09 | <rafa> djazayeri: it's not |
| 18:43:30 | <djazayeri> rafa: is there a fixVersion or label for the sprint tickets in jira now? |
| 18:43:38 | <rafa> djazayeri: not yet |
| 18:43:53 | <rafa> djazayeri: I still need to create them |
| 18:44:16 | <djazayeri> okay, do you have them documented (even as bullets) somewhere? |
| 18:45:18 | <rafa> yes it's: + testing framework + importing concepts from 1.6 to 1.7 + subpackaging + creting packages on the fly + safe import mode |
| 18:45:38 | <djazayeri> What's safe import mode? |
| 18:46:11 | <rafa> djazayeri: do not modify existing data unless they have same uuids (it's upgrade) |
| 18:47:13 | <djazayeri> rafa: who's asking for that? (What kind of thing used to be modified, but now won't be?) |
| 18:47:47 | <rafa> djazayeri: it's for more automated imports that Jonathan asked |
| 18:48:09 | <rafa> djazayeri: no overwriting will happen |
| 18:48:17 | <djazayeri> okay, so maybe relevant to the ampath use case too |
| 18:48:42 | <djazayeri> I'd suggest you have at least bullet points of these, including the motivation, for the call in 12 minutes. :-) |
| 18:49:30 | <rafa> right :) |
| 19:05:41 | *** morristic has quit IRC |
| 19:07:21 | *** dawn_ has quit IRC |
| 19:15:33 | *** bwolfe has quit IRC |
| 20:32:25 | *** james_regen has left #openmrs |
| 20:37:28 | *** morristic has joined #openmrs |
| 20:46:18 | *** suranga has quit IRC |
| 21:10:48 | *** burke has joined #openmrs |
| 21:10:48 | *** ChanServ sets mode: +o burke |
| 21:12:34 | *** rafa has quit IRC |
| 21:31:51 | *** jriley has joined #openmrs |
| 21:53:35 | *** bryq has quit IRC |
| 21:59:41 | *** jriley has left #openmrs |
| 22:09:55 | <r_friedman> djazayeri: darius, are you there? |
| 22:10:03 | <djazayeri> hi r_friedman |
| 22:10:06 | <djazayeri> yup |
| 22:10:09 | <r_friedman> is this a good time? |
| 22:10:19 | <djazayeri> if I can have 5 minutes to make a sandwich, that would be better |
| 22:10:24 | <r_friedman> no problem |
| 22:22:15 | *** wyclif has quit IRC |
| 22:22:26 | <r_friedman> djazayeri: u back? |
| 22:24:47 | <djazayeri> hi r_friedman |
| 22:25:01 | <djazayeri> sorry, I really have to reassess how long it takes me to make a sandwich |
| 22:25:02 | <r_friedman> 14 mins = 2.8 sandwiches |
| 22:25:03 | <djazayeri> anyway, I'm back |
| 22:25:25 | <r_friedman> could you take a look at this? http://pastebin.com/Xdu3eegP |
| 22:26:20 | <djazayeri> ok |
| 22:26:56 | <r_friedman> so it seems like spring couldn't find base crud controller |
| 22:27:16 | <r_friedman> so i added the lines at the bottom to the web app context |
| 22:27:20 | <r_friedman> but no joy |
| 22:28:02 | <r_friedman> LabInstrumentController is just a placeholder at the moment, it extends BaseCrudController but has no code |
| 22:28:33 | <r_friedman> or instance variables to be injected by spring |
| 22:28:49 | <r_friedman> so i don't understand what the problem is |
| 22:30:20 | <djazayeri> hmm |
| 22:30:40 | <djazayeri> is this the first thing that you have extending a WS module class? |
| 22:31:00 | <r_friedman> yes |
| 22:32:10 | <djazayeri> have you looked at how mike did this in his example for the reporting module? |
| 22:32:39 | <r_friedman> no |
| 22:32:49 | <r_friedman> does reporting module use rest? |
| 22:33:02 | <djazayeri> I mean this: https://wiki.openmrs.org/display/docs/Adding+a+Web+Service+Step+by+Step+Guide+for+Module+Developers |
| 22:33:22 | <r_friedman> the 3 lines i stole from ws itself, changing the third to reference my package |
| 22:34:03 | <djazayeri> the relevant example linked to is probably the idgenws module |
| 22:35:06 | <djazayeri> r_friedman: did you declare the dependencies to the ws.rest module in your pom.xml? |
| 22:35:31 | <r_friedman> djazayeri: yes |
| 22:35:38 | <r_friedman> djazayeri: all found find |
| 22:35:51 | <r_friedman> never mind |
| 22:35:54 | <r_friedman> not relevant |
| 22:36:00 | <r_friedman> this is all mike has: |
| 22:36:02 | <r_friedman> <context:component-scanbase-package="@MODULE_PACKAGE@"/> |
| 22:36:25 | <r_friedman> his is not mavenized |
| 22:36:34 | <djazayeri> the idgenws module is mavenized |
| 22:36:38 | <djazayeri> but that's all it has too |
| 22:37:03 | <djazayeri> also, in pom.xml: <dependency> |
| 22:37:03 | <djazayeri> <groupId>org.openmrs.module</groupId> |
| 22:37:03 | <djazayeri> <artifactId>webservices.rest-api</artifactId> |
| 22:37:03 | <djazayeri> <version>1.0-SNAPSHOT</version> |
| 22:37:03 | <djazayeri> <type>jar</type> |
| 22:37:03 | <djazayeri> </dependency> |
| 22:37:04 | <djazayeri> <dependency> |
| 22:37:05 | <djazayeri> <groupId>org.openmrs.module</groupId> |
| 22:37:05 | <djazayeri> <artifactId>webservices.rest</artifactId> |
| 22:37:06 | <djazayeri> <version>1.0-SNAPSHOT</version> |
| 22:37:06 | <djazayeri> <type>jar</type> |
| 22:37:07 | <djazayeri> </dependency> |
| 22:38:34 | <r_friedman> djazayeri: yeah,we've been through this |
| 22:38:39 | <r_friedman> the version is not 1.0 |
| 22:38:47 | <r_friedman> or 1.0-SNAPSHOT |
| 22:38:49 | <djazayeri> okay, so put the right version... |
| 22:38:55 | <djazayeri> but you have that already? |
| 22:39:12 | <r_friedman> also the new mavenized form is webservices.rest-api and -omod |
| 22:39:26 | <r_friedman> right, all that has been addressed |
| 22:39:35 | <r_friedman> certainly no complaints on clean install |
| 22:40:23 | <djazayeri> and your module declares a dependency on the webservices.rest module in its config.xml, right? |
| 22:42:32 | <r_friedman> djazayeri: looks like no, but this is not the same config.xml i saw yesterday, let me check some more |
| 22:43:48 | <r_friedman> this is more like it, but still no dependencies in there |
| 22:44:04 | <r_friedman> is this another file built by wizard? |
| 22:44:40 | <r_friedman> djazayeri: or maven? |
| 22:44:54 | <r_friedman> it's in target, that's dynamic, right? |
| 22:45:22 | <djazayeri> it should be in (module)/omod/src/main/resources |
| 22:46:17 | <r_friedman> yep, that's where i'm looking |
| 22:47:02 | <r_friedman> it's funny, in some cases the mapping files content is a variable, in omod/src/main/resources its text |
| 22:48:00 | <r_friedman> djazayeri: ${omodHbmConfig} |
| 22:49:47 | <djazayeri> hmm, okay |
| 22:50:05 | <djazayeri> anyway, does the config.xml file have a require_module tag (or something like that) for ws.rest? |
| 22:50:20 | <r_friedman> but if you think i should wale away at config.xml in the omod/resources directory i will |
| 22:50:25 | <r_friedman> there's no required tag |
| 22:51:47 | <djazayeri> r_friedman: you need require_modules like here: http://svn.openmrs.org/openmrs-modules/idgenws/trunk/omod/src/main/resources/config.xml |
| 22:52:51 | <r_friedman> ok. which of the context:component-scan lines do i need? |
| 22:53:02 | <djazayeri> only your own module |
| 22:53:23 | <r_friedman> ok. tks, I will give it whirl |
| 22:54:20 | <djazayeri> good luck |
| 22:54:41 | <r_friedman> djazayeri: we now return you to your previously scheduled sandwiches |
| 22:55:10 | *** r_friedman has quit IRC |
| 23:18:38 | *** burke has quit IRC |
| 23:19:12 | *** downeym has quit IRC |