| 00:12:25 | *** wyclif has joined #openmrs |
| 00:25:06 | *** mimi has quit IRC |
| 01:20:38 | *** djazayeri1 has joined #openmrs |
| 01:20:39 | *** djazayeri has quit IRC |
| 01:30:21 | *** deadpool has quit IRC |
| 01:35:50 | *** djazayeri has joined #openmrs |
| 01:35:50 | *** ChanServ sets mode: +o djazayeri |
| 01:37:35 | *** djazayeri1 has quit IRC |
| 02:09:07 | <djazayeri> wyclif: do you remember what the obscure failure case is for the HTML Form Entry module after providers get added in 1.9? |
| 02:09:54 | <djazayeri> oh, I know, it's that you can have a user whose Role is Provider (so he shows up as an option in the providers dropdown) but that doesn't have a Person that's a provider. |
| 02:11:21 | *** galinganmd has joined #openmrs |
| 02:12:21 | <galinganmd> hi does anybody know how to identify checkbox elements in the view of the form? |
| 02:12:35 | <galinganmd> this is in html form |
| 02:22:26 | <djazayeri> galinganmd: you mean at the javascript level? what are you trying to do? |
| 02:23:37 | *** morristic has joined #openmrs |
| 02:37:44 | *** galinganmd has quit IRC |
| 06:06:47 | *** r0bby_ has joined #openmrs |
| 06:06:51 | *** ChanServ sets mode: +v r0bby_ |
| 06:16:39 | *** surangak has joined #openmrs |
| 06:20:22 | *** bwolfe has joined #openmrs |
| 06:20:22 | *** ChanServ sets mode: +o bwolfe |
| 07:21:39 | *** rafa has joined #openmrs |
| 07:21:39 | *** ChanServ sets mode: +v rafa |
| 07:26:43 | *** bryq has joined #openmrs |
| 07:26:51 | *** ChanServ sets mode: +v bryq |
| 07:29:19 | *** dkayiwa has joined #openmrs |
| 08:15:47 | * surangak creeps in |
| 08:15:50 | <surangak> suranga-- |
| 08:15:57 | <surangak> mm.. bwolfe , r u there ? |
| 08:16:06 | <bwolfe> no |
| 08:16:13 | *** rafa has quit IRC |
| 08:16:30 | <surangak> ;9 |
| 08:16:39 | <surangak> SORRY, i mean :-( |
| 08:33:43 | *** dkayiwa has left #openmrs |
| 08:40:02 | *** dkayiwa has joined #openmrs |
| 08:44:47 | *** bryq has quit IRC |
| 08:54:12 | *** bwolfe_ has joined #openmrs |
| 08:54:12 | *** ChanServ sets mode: +o bwolfe_ |
| 08:57:33 | *** bwolfe has quit IRC |
| 09:19:57 | <surangak> hi dkayiwa mmm r u there :-) |
| 09:20:06 | <dkayiwa> surangak: yes iam :) |
| 09:20:21 | <surangak> dkayiwa, am wondering if u can advice me on something... |
| 09:20:25 | <dkayiwa> ok |
| 09:21:11 | <surangak> dkayiwa, here goes :-) |
| 09:21:13 | <surangak> I was merging bit by bit from branch to trunk yesterday (there were a lot of stuff to merge) |
| 09:21:13 | <surangak> Well, I rechecked my work today, and seems I have made some terrible mistakes |
| 09:21:13 | <surangak> SO I was worried that I might have to actually roll back all the commits I made yesterday (Terrble !) |
| 09:21:13 | <surangak> when I got a better idea. The mistakes I made were in the merged files only (not in any of the updated / deleted ones) so |
| 09:21:13 | <surangak> If I identify which classes I had merged and repair them only, I am ok |
| 09:21:15 | <surangak> SO what I did was take a clean checkout, and reverted to local copy all the changes that I had done yesterday. |
| 09:21:18 | <surangak> Now looking at the log, I see stuff like, |
| 09:21:20 | <surangak> Deleted: D:\Workspace\1\obs-codes-expanded\obs\webapp\src\main\webapp\images\back_button.png |
| 09:21:24 | <surangak> Updated: D:\Workspace\1\obs-codes-expanded\obs\webapp\src\main\webapp\openmrs.css |
| 09:21:26 | <surangak> Reverse merging 25002 through 24999: D:\Workspace\1\obs-codes-expanded\obs |
| 09:21:28 | <surangak> so I think that the 'reverse merge' class given here is an actual merge (as opposed to update / delete) |
| 09:21:30 | <surangak> If I were to identify all of the'merged' and repair them would I have solved my problem ?? :-( |
| 09:21:32 | <surangak> :-( |
| 09:25:06 | <dkayiwa> oh sorry about that |
| 09:32:38 | <surangak> mmm dkayiwa, what would u advice |
| 09:32:53 | <surangak> im too ashamed to show this to bwolfe_ actually :( |
| 09:33:01 | <bwolfe_> too late ;-) |
| 09:33:15 | *** bwolfe_ is now known as bwolfe |
| 09:33:54 | <dkayiwa> ;) |
| 09:34:28 | <surangak> bwolfe, it seems in my feverd delirum yesterday, I had mesed up some |
| 09:34:44 | <bwolfe> surangak, I see |
| 09:34:51 | <surangak> (lesson of the storry is, dont commit when u r running a fever :( |
| 09:35:08 | <bwolfe> a good lesson indeed |
| 09:38:20 | *** mimi has joined #openmrs |
| 09:43:43 | *** morristic has quit IRC |
| 10:02:08 | <surangak> mm... bwolfe .. any idea ? :-) |
| 10:02:25 | <bwolfe> surangak, any ideas on how to dig out? |
| 10:02:44 | <surangak> bwolfe, I explained my plan above (up) |
| 10:03:02 | <surangak> it also contains how im thinking of solving it (thats why iz so long) |
| 10:03:08 | <bwolfe> I didn't really understand your plan above. :-) |
| 10:03:41 | <bwolfe> merging is usually easy, do you know where you went wrong? |
| 10:04:04 | <bwolfe> surangak, use the eclipse compare with --> each other to see all differences between your code and trunk |
| 10:04:54 | <surangak> bwolfe, aha, so after that, I can simply do a clean up and commit right ? greattt |
| 10:05:17 | <bwolfe> something like that |
| 10:09:42 | <surangak> bwolfe, mm.. seems that its disabled on my eclipse :(. let me check it out... |
| 10:10:05 | <bwolfe> surangak, you have to click on trunk, then control-click on your branch. then right click on either one |
| 10:11:12 | <surangak> bwolfe, oh, so for this u need to check out code for both branch and trunk I see ... |
| 10:11:25 | <bwolfe> yeah |
| 10:15:30 | <bwolfe> dkayiwa, did you start a "upgrading for devs" type of wiki page yet? |
| 10:15:44 | <dkayiwa> bwolfe: no |
| 10:16:14 | <bwolfe> hmph |
| 10:30:24 | *** surangak_ has joined #openmrs |
| 10:30:25 | *** surangak has quit IRC |
| 10:32:00 | *** surangak has joined #openmrs |
| 10:32:29 | *** surangak_ has quit IRC |
| 10:36:50 | <bwolfe> surangak, what was your plan for TRUNK-1763 ? |
| 10:36:54 | <bwolfe> !ticket TRUNK-1763 |
| 10:36:55 | <OpenMRSBot> bwolfe: [#TRUNK-1763] Make delete more obvious on global property page - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-1763 |
| 10:37:14 | <surangak> mm.. bwolfe that ticket was solved, right ? |
| 10:37:18 | * surangak goes to look |
| 10:37:26 | * bwolfe rereads the ticket... |
| 10:37:36 | * bwolfe waits for surangak to reread it first |
| 10:38:50 | <surangak> bwolfe, mm.. so it was fixed right ? u had said to ignore your comment ? mmm |
| 10:40:00 | <surangak> wait, theres some mention of a ticket 438 ? |
| 10:41:29 | <surangak> bwolfe, im a bit muddled up, you say "This ticket should now both add back in the ability to delete a property and make it obvious that its happening, similar to how you had done it in here the first time." |
| 10:42:07 | <bwolfe> surangak, I think I just need to reapply your patch and look at the "advanced settings" page instead of the "settings" page |
| 10:42:10 | <bwolfe> I'll get to that later today |
| 10:42:43 | <surangak> bwolfe, anything to add from my end (bit muddled up) |
| 10:45:44 | <bwolfe> I don't think so |
| 10:45:48 | <bwolfe> I'll let you know :-) |
| 10:45:54 | <bwolfe> bbl |
| 10:46:00 | <surangak> (thumbs up) |
| 10:50:27 | *** bwolfe has quit IRC |
| 10:56:11 | *** surangak has quit IRC |
| 10:56:54 | *** rafa has joined #openmrs |
| 10:56:54 | *** ChanServ sets mode: +v rafa |
| 12:07:10 | *** james_regen has joined #openmrs |
| 12:07:10 | *** ChanServ sets mode: +v james_regen |
| 13:30:37 | <rafa> dkayiwa: do you remember what was our page to shorten links? |
| 13:33:52 | <dkayiwa> rafa: meaning? |
| 13:34:17 | <rafa> dkayiwa: a way to shorten links |
| 13:34:34 | <rafa> dkayiwa: well okay I used perm links from wiki |
| 13:34:38 | <rafa> dkayiwa: good enough |
| 13:34:50 | <dkayiwa> :) |
| 13:35:23 | <rafa> dkayiwa: are there any new tickets for 1.9 I should look at now? |
| 13:35:42 | <dkayiwa> rafa: let me see..... |
| 13:36:44 | <rafa> dkayiwa: it'd be good to mark them with the 1.9-beta2 label |
| 13:37:00 | <rafa> dkayiwa: they should show up on our dashboard then :) |
| 13:37:13 | <dkayiwa> rafa: correct :) |
| 13:37:20 | *** r5friedman has joined #openmrs |
| 13:37:28 | <dkayiwa> rafa: how about this RELTEST-18 ? |
| 13:37:31 | *** r5friedman is now known as r_friedman |
| 13:37:44 | <rafa> dkayiwa: yeah I've never published anything |
| 13:37:50 | <dkayiwa> :) |
| 13:38:04 | <dkayiwa> rafa: may be a good time for you to start :) |
| 13:38:20 | <rafa> dkayiwa: ohh it's just to our module repo |
| 13:38:26 | <rafa> dkayiwa: I though it's to maven repo ;) |
| 13:38:36 | <rafa> dkayiwa: then I'm pretty experienced ;) |
| 13:38:39 | <dkayiwa> rafa: for users to download |
| 13:38:40 | <dkayiwa> :) |
| 13:38:46 | <dkayiwa> version 1.0 :) |
| 13:38:55 | <rafa> but there's a ticket still open |
| 13:38:59 | <rafa> RELTEST-17 |
| 13:39:13 | <dkayiwa> rafa: looks like wyclif is almost done with it |
| 13:39:21 | <dkayiwa> we can safely assume so |
| 13:40:02 | <rafa> well I can wait :) |
| 13:40:43 | <dkayiwa> hahaha :) |
| 13:41:00 | <rafa> I'll just claim the ticket so that no one steals fun from me :D |
| 13:41:04 | <dkayiwa> then looks like wyclif is now the one blocking the beta release :) |
| 13:41:25 | <dkayiwa> we cannot release beta before ELTEST-18 |
| 13:41:30 | <dkayiwa> RELTEST-18 |
| 13:41:33 | <rafa> really? |
| 13:41:44 | <dkayiwa> rafa: thats what i was told |
| 13:42:02 | <r_friedman> dkayiwa: no xmas for wyclif til it's cleared |
| 13:42:05 | <dkayiwa> rafa: before wyclif is done, we can release version 0.9 |
| 13:42:23 | <rafa> I bet he'll do it today |
| 13:42:23 | <dkayiwa> rafa: and that way he can enjoy christmas :) |
| 13:42:42 | <dkayiwa> rafa: then in that case we can just release RELTEST-18 as 0.9 |
| 13:43:00 | <dkayiwa> rafa: after that, i will tag and release beta |
| 13:43:06 | <dkayiwa> for 1.9 |
| 13:43:24 | <r_friedman> dkayiwa: daniel, got a minute? |
| 13:43:32 | <rafa> dkayiwa: there's one more important thing to backport |
| 13:43:41 | <dkayiwa> rafa: which one |
| 13:43:51 | <dkayiwa> r_friedman: yes |
| 13:44:10 | <r_friedman> dkayiwa: i am trying to start my module. i get the message messages-fr.properties is missing |
| 13:44:16 | <rafa> dkayiwa: TRUNK-2919 |
| 13:44:32 | <dkayiwa> !ticket TRUNK-2919 |
| 13:44:33 | <OpenMRSBot> dkayiwa: [#TRUNK-2919] Updating concept words takes too long after upgrade form 1.6 to 1.9 - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2919 |
| 13:44:49 | <r_friedman> i have that file but it's got a black snowflake in its icon, dkayiwa |
| 13:44:57 | <dkayiwa> rafa: can you back port it? |
| 13:45:13 | <rafa> dkayiwa: yes, I'll do it in a few minutes |
| 13:45:21 | <dkayiwa> r_friedman: is that in your custom module? |
| 13:45:29 | <dkayiwa> rafa: thanks alot!!! :) |
| 13:45:33 | <r_friedman> dkayiwa: yes |
| 13:45:47 | <dkayiwa> r_friedman: have you made any changes to that file? |
| 13:46:01 | <r_friedman> yes, it was empty so I put in one line |
| 13:46:11 | <rafa> dkayiwa: anyway we should wait for scrum to make sure there are no more outstanding things to back port |
| 13:46:56 | <r_friedman> dkayiwa: also made a messages-en.properties and put in a corresponding line |
| 13:47:11 | <dkayiwa> rafa: do you mean wait for scrum time before i tag 1.9 beta? |
| 13:47:11 | <r_friedman> messages-en has a blue question mark on its icon |
| 13:47:21 | <rafa> dkayiwa: yeah :) |
| 13:47:38 | <dkayiwa> r_friedman: can you try copying any from an existing working module and see if you get the same problem? |
| 13:47:53 | <rafa> dkayiwa: but you're the boss, I just suggest :D |
| 13:47:53 | <dkayiwa> rafa: will be patient and go with your advice. :) |
| 13:48:14 | <dkayiwa> rafa: hahaha boss who does not listen to others is a bad one :) |
| 13:48:46 | <r_friedman> dkayiwa: yes, or is under pressure from a bad higher boss :) |
| 13:49:09 | <dkayiwa> r_friedman: hahahahha :D |
| 13:49:45 | <dkayiwa> r_friedman: so that becomes bad by inheritance :) |
| 13:50:28 | <r_friedman> dkayiwa: eventually team becomes bad by inheritance as well :) |
| 13:50:44 | <dkayiwa> r_friedman: hahahahaha :D |
| 13:52:07 | <dkayiwa> rafa: are you done with the back porting. am going to do a final round of testing :) |
| 13:52:27 | <rafa> dkayiwa: nope, I'll let you know |
| 13:52:35 | <r_friedman> dkayiwa: is right place inside target dir? |
| 13:52:38 | <dkayiwa> rafa: 8) |
| 13:52:46 | <dkayiwa> r_friedman: no |
| 13:53:52 | <dkayiwa> r_friedman: target dir is autogenerated. so it will be automatically deleted every time you do mvn clean |
| 14:05:54 | <r_friedman> dkayiwa: ok, moved it to the resources directory with messages.properties and all is well |
| 14:06:10 | <dkayiwa> r_friedman: oh good!!! :) |
| 14:06:24 | <rafa> dkayiwa: all what was on me is back ported |
| 14:06:45 | <dkayiwa> oh thanks rafa let me update and test again :) |
| 14:39:47 | <wyclif> hi dkayiwa |
| 14:39:57 | <dkayiwa> hey wyclif |
| 14:40:44 | <wyclif> dkayiwa, is it RELTEST-18 blocking the beta release? |
| 14:41:08 | <dkayiwa> wyclif: blocking 1.0 version of the module |
| 14:41:37 | *** james_regen1 has joined #openmrs |
| 14:41:53 | <wyclif> dkayiwa, i thought the ticket is just releaseing the module and not really a bug |
| 14:42:42 | <dkayiwa> wyclif: bolocker is the ticket it depends on |
| 14:46:35 | *** robbyoconnor has joined #openmrs |
| 14:46:35 | *** ChanServ sets mode: +v robbyoconnor |
| 14:50:06 | *** james_regen has quit IRC |
| 14:50:06 | *** rafa has quit IRC |
| 14:50:06 | *** r0bby_ has quit IRC |
| 14:50:06 | *** djazayeri has quit IRC |
| 14:50:45 | *** rafa has joined #openmrs |
| 14:50:45 | *** djazayeri has joined #openmrs |
| 14:50:45 | *** zelazny.freenode.net sets mode: +vo rafa djazayeri |
| 15:09:03 | <dkayiwa> thanks wyclif for closing RELTEST-17 :) |
| 15:32:20 | <wyclif> dkayiwa, is there any script we use to back port to un mavenized braches? |
| 15:32:36 | <dkayiwa> wyclif: am not sure |
| 15:36:10 | <wyclif> dkayiwa, am still back porting some changes |
| 15:36:18 | <dkayiwa> wyclif: ohhh :) |
| 15:36:19 | <wyclif> to 1.9.x |
| 15:36:24 | <dkayiwa> ok |
| 15:36:39 | <wyclif> dkayiwa, am trying to be done in the 15-20min |
| 15:36:49 | <dkayiwa> wyclif: ok thanks :) |
| 15:38:00 | <wyclif> hi djazayeri |
| 15:38:08 | <djazayeri> hi wyclif |
| 15:38:45 | <wyclif> djazayeri, have you back ported to an un mavenized branch before? |
| 15:39:02 | <djazayeri> I've always done it manually |
| 15:39:09 | <wyclif> djazayeri, hmm |
| 15:39:15 | <wyclif> djazayeri, ok thanks |
| 15:51:16 | *** bwolfe has joined #openmrs |
| 15:51:16 | *** ChanServ sets mode: +o bwolfe |
| 15:52:24 | <dkayiwa> wyclif: will you notify me when you are done with the backporting? |
| 15:54:35 | <wyclif> dkayiwa, yes |
| 15:54:51 | <dkayiwa> wyclif: thanks :( |
| 15:55:07 | <dkayiwa> i meant this :) |
| 15:55:15 | <dkayiwa> :D |
| 15:56:16 | <wyclif> ok |
| 16:24:09 | *** jriley has joined #openmrs |
| 16:40:09 | <r_friedman> dkayiwa: daniel, are there 1 or 2 copies of config.xml? of the module's Activator routine? |
| 16:40:39 | <dkayiwa> r_friedman: one |
| 16:41:01 | <r_friedman> where does the 2nd one in the project tree come from |
| 16:42:30 | <dkayiwa> r_friedman: what locations for each? |
| 16:43:34 | *** olliejones has joined #openmrs |
| 16:43:39 | <r_friedman> dkayiwa: activator is in the top of both api and omod |
| 16:45:05 | <r_friedman> dkayiwa: config is in resources in main project and omod |
| 16:45:24 | *** olliejones has quit IRC |
| 16:45:59 | <dkayiwa> r_friedman: is that for only yo module or even others |
| 16:56:45 | <r_friedman> dkayiwa: yes, others as well |
| 16:57:15 | <dkayiwa> r_friedman: then thats fine |
| 16:58:03 | <r_friedman> dkayiwa: i am trying to rename the activator and its method but the second copy is causing problems |
| 16:59:25 | <r_friedman> dkayiwa: but i should stop obsessing about this and do something useful |
| 16:59:47 | <dkayiwa> r_friedman: rename the one in the api project |
| 17:00:10 | <r_friedman> dkayiwa: tks will give it one last try |
| 17:11:00 | *** deadpool has joined #openmrs |
| 17:14:58 | <deadpool> rafa that ant trick you showed me you set it for windows how do i set it if i am using linux? |
| 17:21:16 | <wyclif> hi dkayiwa |
| 17:21:30 | <dkayiwa> hi wyclif |
| 17:23:08 | <wyclif> dkayiwa, does the patient search on the find/create patient page work for you in trunk? |
| 17:23:27 | <wyclif> dkayiwa, which ofcourse should affect 1.9 |
| 17:24:12 | <dkayiwa> wyclif: yes |
| 17:24:33 | <wyclif> type in mal and make sure u get all the results |
| 17:24:47 | <wyclif> assuming u have demo data with 5k patients |
| 17:24:49 | <dkayiwa> wyclif: ok |
| 17:25:01 | <dkayiwa> wyclif: no i have the default wizard demo data |
| 17:25:31 | <dkayiwa> wyclif: but can try out the demo data insertion of the 5k patients |
| 17:25:46 | <wyclif> dkayiwa, ok try that |
| 17:25:54 | <dkayiwa> wyclif: ok |
| 17:29:57 | *** suranga has joined #openmrs |
| 17:30:20 | <dkayiwa> wyclif: for mal i get 10 results |
| 17:32:30 | <wyclif> dkayiwa, but do u notice that there a message that says loading 49 |
| 17:34:02 | <dkayiwa> wyclif: i do not see that |
| 17:35:03 | <wyclif> ok go to the find patients page on the admin page |
| 17:35:15 | <wyclif> dkayiwa, and do the same search |
| 17:37:27 | <dkayiwa> wyclif: it works as expected |
| 17:37:49 | <dkayiwa> with less than 3 character searches experiencing some delays as designed |
| 17:39:59 | <wyclif> dkayiwa, u are getting 10 on both pages? |
| 17:40:15 | <dkayiwa> wyclif: which pages? |
| 17:41:50 | *** rafa has quit IRC |
| 17:43:12 | <wyclif> dkayiwa, you need to search at http://localhost:8080/openmrs/findPatient.htm and http://localhost:8080/openmrs/admin/patients/index.htm |
| 17:46:02 | <dkayiwa> wyclif: they both behave the same |
| 17:47:10 | <dkayiwa> wyclif: although: m=2 results, ma=0 results, mal=10 results |
| 17:47:24 | <wyclif> for mal' |
| 17:47:30 | <wyclif> dkayiwa, for mal |
| 17:47:42 | <wyclif> dkayiwa, where same is what? |
| 17:47:45 | <wyclif> 10? |
| 17:47:50 | <dkayiwa> wyclif: o wait |
| 17:48:08 | <dkayiwa> wyclif: trying again |
| 17:49:15 | <dkayiwa> wyclif: the second link returns 49 results for mal |
| 17:51:34 | <wyclif> dkayiwa, that is |
| 17:51:42 | <wyclif> dkayiwa, so there is a bug on the first one |
| 17:51:50 | <wyclif> dkayiwa, and i have just seen it |
| 17:51:51 | <dkayiwa> wyclif: correct |
| 17:51:59 | <dkayiwa> wyclif: very keen eye :) |
| 17:52:04 | <wyclif> dkayiwa, the fix to min is what broke that page |
| 17:52:13 | <dkayiwa> wyclif: oh i see |
| 17:52:21 | <dkayiwa> wyclif: is it easy to fix? |
| 17:53:16 | <wyclif> dkayiwa, and if you notice on the first page there a bold msg nest to the search input saying loading 49 that never disappears |
| 17:53:48 | <wyclif> dkayiwa, i think i have just seen what introduced the bug |
| 17:54:08 | <dkayiwa> wyclif: are you fixing it? |
| 17:55:34 | <wyclif> dkayiwa, yeah |
| 17:55:45 | <dkayiwa> wyclif: cool thanks :) |
| 17:55:58 | <wyclif> dkayiwa, are you the one that added that logic inside the search handler? |
| 17:56:06 | <wyclif> dkayiwa, what was the purpose |
| 17:56:16 | <dkayiwa> wyclif: which line? |
| 17:56:16 | <wyclif> dkayiwa, it is also breaking something else |
| 17:56:25 | <wyclif> starting from 187 |
| 17:56:30 | <dkayiwa> wyclif: and which file? |
| 17:56:45 | <wyclif> dkayiwa, findPatient.jsp |
| 17:57:25 | <dkayiwa> wyclif: the portlet? |
| 17:57:49 | <dkayiwa> wyclif: or the non portlet |
| 17:58:49 | <dkayiwa> wyclif: if portlet, yes am the one who added it |
| 17:59:01 | <dkayiwa> wyclif: there is a comment about what it does |
| 17:59:15 | <dkayiwa> wyclif: or am i looking at a different file? |
| 18:00:24 | <wyclif> dkayiwa, yeah the one with the comment because that is causing 2 bugs |
| 18:01:24 | <dkayiwa> wyclif: lolllllllllll |
| 18:01:38 | <wyclif> the one we have just seen and also when the user changes the number to display per page, it is broken, it doesnt change |
| 18:02:14 | <dkayiwa> wyclif: i wonder how it is causing the bug :( |
| 18:04:40 | <wyclif> dkayiwa, for the first bug it is because it setting a wrong value for the startIndex when calling the DWR method |
| 18:05:38 | <wyclif> dkayiwa, for the second bug, it is because you are checking if the text is the same yet that method is supposed to be called multiple times by the widgets to fetch more results for the same text input |
| 18:05:39 | <dkayiwa> wyclif: so is the bug caused by that code, or just exposed by that code? |
| 18:05:48 | <wyclif> it is caused by that code |
| 18:06:06 | <dkayiwa> wyclif: for the first where startindex is wrong? |
| 18:06:23 | <wyclif> dkayiwa, that code should be inside the search widget javascript file and check for the button that was pressed |
| 18:06:37 | <dkayiwa> wyclif: ok |
| 18:07:06 | <wyclif> dkayiwa, it is setting start index to opts.length instead of opts.start, see the previous revision |
| 18:07:41 | <dkayiwa> wyclif: i do not see startindex in that section of code |
| 18:07:42 | <wyclif> dkayiwa, but i have corrected that startIndex one |
| 18:07:56 | <wyclif> the dwr methods takes in the start argument for paging |
| 18:08:05 | <dkayiwa> ok |
| 18:08:06 | <wyclif> and you are setting it to the length |
| 18:08:27 | <wyclif> dkayiwa, it is DWRPatientService.findCountAndPatients(text, opts.start, opts.length, getMatchCount, resultHandler); |
| 18:08:53 | <dkayiwa> wyclif: i did not touch that method :) |
| 18:08:56 | <wyclif> dkayiwa, but u set i to DWRPatientService.findCountAndPatients(text, opts.length, opts.length, getMatchCount, resultHandler); |
| 18:09:18 | <dkayiwa> wyclif: only did from 187 - 193 :) |
| 18:09:32 | <wyclif> dkayiwa, but it changed in your revision, it could have been just a mistake |
| 18:09:45 | <dkayiwa> wyclif: oh i see |
| 18:09:59 | <wyclif> dkayiwa, compare your revision 24658 in fisheye |
| 18:10:06 | <dkayiwa> ok |
| 18:12:11 | <wyclif> dkayiwa, sorry, u never changed that |
| 18:12:19 | <wyclif> i have seen the revision number |
| 18:12:27 | <dkayiwa> ok |
| 18:12:52 | <wyclif> dkayiwa, it is the check for if the test is the same that is breaking it because more results are not getting fetched |
| 18:13:11 | <dkayiwa> wyclif: makes alot of sense!!! |
| 18:13:25 | <dkayiwa> wyclif: and very good catch :) |
| 18:13:28 | <wyclif> the function is supposed to be called multiple times for the same text for paging |
| 18:13:40 | <dkayiwa> wyclif: oh i see |
| 18:14:24 | <wyclif> dkayiwa, so am going to revert that changeset and create a ticket to fix what you were trying to fix with that code |
| 18:14:49 | <dkayiwa> wyclif: how about just storing the startindex too |
| 18:15:01 | <dkayiwa> and then compare both the text and startindex? |
| 18:15:07 | <wyclif> but it has taken me so long to notice because i thought the problem was in the widgets |
| 18:15:25 | <dkayiwa> wyclif: oh sorry |
| 18:16:10 | <wyclif> dkayiwa, that logic should be inside the widgets see line 262 in openmrssearch.js |
| 18:16:25 | <dkayiwa> wyclif: ok |
| 18:16:29 | <wyclif> just add that keys to those |
| 18:17:03 | <dkayiwa> wyclif: it will be safer if you added it since you are very good at catching such bugs :) |
| 18:17:20 | <wyclif> i can fix it, when do you plan to release |
| 18:17:30 | <dkayiwa> wyclif: today |
| 18:17:58 | <wyclif> dkayiwa, darius added comments to another ticket and i need to back port them |
| 18:18:16 | <dkayiwa> ok |
| 18:18:31 | <djazayeri> dkayiwa: you got the new HTML Form Entry omod from Mark? |
| 18:18:48 | <wyclif> i can try to beat 2:30 indy time i.e 20 after the scrum chat |
| 18:18:49 | <djazayeri> dkayiwa: we also need one for reporting. I can build this, since Mike didn't volunteer. :-) |
| 18:19:05 | <dkayiwa> djazayeri: not yet. the one i have was from published module repo |
| 18:19:19 | <dkayiwa> djazayeri: thanks for building it :) |
| 18:19:31 | <djazayeri> dkayiwa: you should have gotten one by email 1-2 hours ago from Mark. |
| 18:19:40 | <dkayiwa> djazayeri: not yet |
| 18:20:48 | <dkayiwa> wyclif: that will be excellent :) |
| 18:20:54 | <djazayeri> 9:13am (18:13 for you), subject line = Review 2 commits, and release a new HTML Form Entry, to = dkayiwa@openmrs |
| 18:21:11 | <wyclif> djazayeri, i think my TODOs for trunk-2273 are blockers right |
| 18:21:23 | <dkayiwa> djazayeri: oh let me recheck :) |
| 18:21:31 | <wyclif> dkayiwa, actually i could do them now before the scrum chat |
| 18:21:47 | <dkayiwa> wyclif: that will be awesome!!! |
| 18:21:50 | <wyclif> dkayiwa, i still have time, i thought it was at 1:30 |
| 18:22:04 | <dkayiwa> wyclif: :D |
| 18:22:07 | <djazayeri> wyclif: the ones related to @shoulds that should not be, are blockers |
| 18:22:10 | <wyclif> dkayiwa, do i need to create tickets? |
| 18:22:16 | <djazayeri> refactoring the code isn't a blocker for the beta release. |
| 18:22:30 | <wyclif> djazayeri, ok |
| 18:22:43 | <dkayiwa> wyclif: may be yes for documentation purposes |
| 18:27:15 | *** suranga_ has joined #openmrs |
| 18:30:25 | *** suranga has quit IRC |
| 18:31:25 | *** suranga has joined #openmrs |
| 18:32:42 | *** suranga__ has joined #openmrs |
| 18:34:17 | *** suranga_ has quit IRC |
| 18:36:18 | *** suranga has quit IRC |
| 18:36:44 | *** galinganmd has joined #openmrs |
| 18:37:36 | <galinganmd> hi i'm using checkboxes to hide sections of my form from this website: https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module+Javascript |
| 18:37:37 | <OpenMRSBot> <http://ln-s.net/9Biw> (at wiki.openmrs.org) |
| 18:37:57 | <galinganmd> the problem occurs when viewing the form |
| 18:38:17 | <galinganmd> The checkboxes become [X] |
| 18:38:34 | <galinganmd> and I can't hide the sections |
| 18:39:03 | <galinganmd> How did you solve this? |
| 18:40:46 | *** dawn_ has joined #openmrs |
| 18:50:17 | <djazayeri> galinganmd: what is the condition that causes them to be hidden/shown? |
| 18:50:35 | <djazayeri> Can you use the <includeIf> / <excludeIf> tags in HTML Form Entry? |
| 18:56:44 | <galinganmd> I just copied the javascript. I think this is the condition that needs to be modified: if(group.children("#trigger").find(":checkbox:first").attr("checked") == false) { disableFn(); } |
| 18:58:10 | <galinganmd> I need an OR condition to satisfy the change to [X] |
| 19:00:31 | <dawn_> !scrumon dawn |
| 19:00:31 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 19:01:06 | <dawn_> bwolfe: djazayeri dkayiwa , jriley , wyclif : aloha! 8) |
| 19:01:22 | <djazayeri> bonjour! |
| 19:01:39 | <dkayiwa> aloha! :) |
| 19:01:48 | <dawn_> Today's order: bwolfe , djazayeri , dkayiwa , jriley , wyclif |
| 19:02:21 | <bwolfe> dawn_, hmm, now I'm always the bride? |
| 19:02:31 | <bwolfe> or am I just supposed to set a good example? |
| 19:02:32 | <djazayeri> bwolfe: teaches you to be careful what you ask for |
| 19:02:44 | <bwolfe> seriously |
| 19:02:51 | <bwolfe> although I never really asked...just complained. :-) |
| 19:02:54 | <bwolfe> today: |
| 19:02:54 | <bwolfe> reviewed testing 1.9.x backport |
| 19:02:54 | <bwolfe> tracked down reason for openmrs not starting with reporting module TRUNK-2992 |
| 19:02:54 | <bwolfe> reviewed and backported sprint tickets |
| 19:02:54 | <bwolfe> cleaned out completed/reviewed sprint tickets |
| 19:02:55 | <bwolfe> wsrest debugging with ampath devs |
| 19:02:56 | <dkayiwa> bwolfe: alphabetical order :) |
| 19:02:56 | <bwolfe> global property deleting patch + backport |
| 19:02:58 | <bwolfe> no blockers |
| 19:03:17 | <bwolfe> dkayiwa, true |
| 19:03:31 | <djazayeri> My turn |
| 19:03:35 | <bwolfe> dkayiwa, or based on descreasing height |
| 19:03:45 | <dkayiwa> bwolfe: :) |
| 19:03:57 | <djazayeri> Monday 19-Dec-2011 |
| 19:03:57 | <djazayeri> * Created and fixed HTML-267 |
| 19:03:57 | <djazayeri> * Finished HTML-221 but couldn't commit because I lacked privileges |
| 19:03:57 | <djazayeri> * Discussed git with Mark |
| 19:03:57 | <djazayeri> * Committed REPORT-309, awaiting Mike's review |
| 19:03:57 | <djazayeri> Tuesday 20-Dec-2011 |
| 19:03:58 | <djazayeri> * Committed HTML-221 |
| 19:03:58 | <djazayeri> * Point release of reporting module 0.7.0.1 for the 1.9 beta release |
| 19:04:00 | <djazayeri> * Write a wiki page describing how to get user types to work across Hibernate 3.2.5 and 3.6. |
| 19:04:00 | <djazayeri> * Review edits to book from doc sprint |
| 19:04:00 | <djazayeri> * Talk to Rafal about MDS sprint if he has time (but I don't see him onlineâ¦) |
| 19:04:07 | <bwolfe> dkayiwa, or based on decreasing intelligence :-D |
| 19:04:14 | <djazayeri> no blockers |
| 19:04:37 | <djazayeri> dkayiwa: what wiki page should I write hints for module authors about upgrading to 1.9 on? |
| 19:04:43 | <dkayiwa> Did some code review |
| 19:04:43 | <dkayiwa> Back ported and closed some tickets |
| 19:04:43 | <dkayiwa> Committed: Error when generating test data - RELTEST-19 |
| 19:04:43 | <dkayiwa> Done some more rudimentary testing of the most recent back ported features and other general things |
| 19:04:44 | <dkayiwa> Working on Publish 1.0 of Release Testing Helper - RELTEST-18 |
| 19:04:44 | <djazayeri> (that's my question for later) |
| 19:04:44 | <dkayiwa> No Blockers |
| 19:05:04 | <dkayiwa> djazayeri: feel free to start one :) |
| 19:05:34 | <djazayeri> dkayiwa: are there any wiki pages about upgrading to 1.9? Or just the 1.9 alpha release notes? |
| 19:05:48 | <dawn_> jriley: do you have any updates you want to share? :) |
| 19:05:51 | <dkayiwa> djazayeri: only release notes |
| 19:06:05 | <jriley> decreasing height? are you saying I'm short? |
| 19:06:05 | <jriley> Yesterday: |
| 19:06:05 | <jriley> moved some pages in from the archive |
| 19:06:05 | <jriley> Today: added links to Implementers guide |
| 19:06:06 | <jriley> I'm going to move non-playground pages around |
| 19:06:06 | <jriley> Blockers: the links to the etherpad notes from Implementers conference don't work |
| 19:06:24 | <bwolfe> djazayeri, lets chat about that after. I have input(s) |
| 19:06:37 | <bwolfe> jriley, you're taller than wyclif! :-) (apparently) |
| 19:06:37 | <djazayeri> bwolfe: ok |
| 19:06:41 | *** rafa has joined #openmrs |
| 19:06:48 | <jriley> well, that's a consolation |
| 19:06:51 | *** ChanServ sets mode: +v rafa |
| 19:06:54 | <dawn_> wyclif: you're next, then rafa |
| 19:07:04 | <jriley> non-working implementer session notes are on https://wiki.openmrs.org/display/RES/2011+Implementers+Meeting+Schedule |
| 19:07:09 | <jriley> implementer session notes LINKS |
| 19:07:12 | <rafa> hi |
| 19:07:14 | <rafa> okay |
| 19:07:22 | <jriley> done |
| 19:07:32 | <bwolfe> rafa, way to scoot in just in time! |
| 19:07:35 | <bwolfe> jriley, any blockers? |
| 19:07:50 | <jriley> the non-working links - I'd like to point to some of the session notes |
| 19:07:52 | <bwolfe> (lets discuss your nonworking links after) |
| 19:07:56 | <bwolfe> ok |
| 19:08:01 | <wyclif> monday: |
| 19:08:01 | <wyclif> -TRUNK-2991 - Back port the code for including the test installation option to 1.9.x branch |
| 19:08:01 | <wyclif> -back porting approved tickets to affected maintenance branches |
| 19:08:01 | <wyclif> -TODO for RELTEST-17 - Add an authentication handler method to TestController |
| 19:08:01 | <wyclif> -Make changes to TRUNK-2986 in relation to changes in RELTEST-17 above |
| 19:08:02 | <wyclif> -TRUNK-2993 - Fix return type of ConceptDao.getCountOfConceptReferenceTerms |
| 19:08:04 | <wyclif> today: |
| 19:08:06 | <wyclif> -TRUNK-2994 - Patient search on find or create patient page is broken |
| 19:08:08 | <wyclif> -TODOs back porting code for TRUNK-2993 - Fix return type of ConceptDAO.getCountOfConceptReferenceTerms |
| 19:08:10 | <wyclif> -TODOs back porting code for TRUNK-2273 - Avoid Duplicate Rows in Patient_State Table |
| 19:08:12 | <wyclif> -1.10 tickets |
| 19:08:14 | <wyclif> No blockers: back porting to an unmavenized branch |
| 19:08:32 | <bwolfe> huh? |
| 19:08:43 | <bwolfe> is that a "no blocker" blocker wyclif? :-) |
| 19:08:58 | <wyclif> bwolfe, it is wlowing me down a little |
| 19:09:01 | <wyclif> slowing |
| 19:09:14 | <bwolfe> ah |
| 19:09:24 | <bwolfe> we can discuss strategy after the scrum |
| 19:09:27 | <dawn_> rafa: ready when you are |
| 19:09:30 | <wyclif> bwolfe, cool |
| 19:09:30 | <rafa> Today: |
| 19:09:30 | <rafa> * Committed and back ported TRUNK-2919: Updating concept words takes too long after upgrade form 1.6 to 1.9 |
| 19:09:30 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2919 |
| 19:09:30 | <rafa> * Closed TRUNK-2874: Improved error message when you try to install in testing mode, and the Release Testing Support module is not installed |
| 19:09:30 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2874 |
| 19:09:31 | <rafa> Tomorrow: |
| 19:09:31 | <rafa> * Again try to review and create tickets for the MDS sprint |
| 19:09:32 | <rafa> * Will work on some trivial MDS tickets and release a new version before my demo on Thursday |
| 19:09:32 | <rafa> No blockers. |
| 19:10:25 | <djazayeri> rafa: one of my bullets today was: * Talk to Rafal about MDS sprint if he has time (but I don't see him onlineâ¦) |
| 19:10:28 | <dawn_> Sprint Update: Talked to Dana today. She and Jan have gone through and made edits to the current version of the Implementers Manual. They're going to start going through the wiki today. Showed them the JIRA tickets and they'll work from that list |
| 19:10:45 | <rafa> djazayeri: can we do it tomorrow? |
| 19:10:47 | <bwolfe> dawn_, do they want more specific tickets? |
| 19:10:51 | <dawn_> !scrumoff dawn |
| 19:10:51 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 19:10:53 | <jriley> dawn - Will they and I be stepping on each other? |
| 19:11:30 | <dawn_> jriley: right now they just took tickets that were not yet assigned, so we should be okay. or you and i can chat about what you're presently work on and figure out if there is overlap |
| 19:11:39 | <rafa> djazayeri: I've got guests today |
| 19:11:42 | <rafa> sorry |
| 19:11:43 | <jriley> dawn_ - actually, one of mine got assigned to Dana |
| 19:11:48 | <jriley> (*yoink!*) |
| 19:11:49 | <wyclif> bwolfe, which is the easier way to merge to 1.7.x |
| 19:11:54 | <dawn_> bwolfe: they are good on tickets, but most they don't feel capable of completing thoroughly since they aren't content experts |
| 19:12:16 | <dawn_> jriley: which one was it? I just spoke with Dana and she said she assigned one to herself on accident. :) |
| 19:12:23 | <djazayeri> rafa: okay, let's discuss tomorrow or another way then |
| 19:12:23 | <bwolfe> dawn_, right. how can we best use their skills then? |
| 19:12:51 | <jriley> I'm focusing on outlining the material and making links to relevant stuff. |
| 19:13:05 | <jriley> I notice that it really is an outline - I'm not summarizing, or saying why something is important |
| 19:13:05 | <djazayeri> rafa: do you have a notes page or wiki page about future MDS design? I have an idea in mind that I'd like to write down somewhere, and I don't know where. |
| 19:13:27 | <rafa> djazayeri: not yet. you can start one |
| 19:13:28 | <jriley> I don't know if they could help smooth it out a bit |
| 19:13:45 | <jriley> they could definitely provide a reality check -- "an outsider would have no idea what this means" |
| 19:13:48 | <dawn_> bwolfe: it seems they would predominately edit existing material, not add to itâ¦.so the sooner we have tickets completed to fill in missing info, the better we can use their skills |
| 19:13:52 | <dawn_> bwolfe: does that help? |
| 19:14:24 | <bwolfe> dawn_, haha, so we need to write 10x more so they can edit/clean? :-) |
| 19:14:32 | <dawn_> jriley: i think the outlining is perfect. jan and dana are going through to edit pages right now (grammar, punctuation, clean up any broken links). |
| 19:14:49 | <jriley> dawn_ - then they'll be very busy :) |
| 19:14:54 | <dawn_> bwolfe: so we need to finish tickets so they can read the contentâ¦i think burke was dubbed the "content expert" for those :) |
| 19:15:19 | <dawn_> jriley: haha! :) what can i do to help them sync with you so they don't bump into what you're currently doing? |
| 19:15:19 | * bwolfe pictures Jan+Dana as those little cleaner fish going over the wiki. ...or that little crab-like guy in Finding Nemo. :-) |
| 19:15:23 | <djazayeri> dawn_: I am not a "content expert" but I can play one on TV. Or for this sprint. |
| 19:16:16 | <jriley> Well, what's the part they feel they can work on without being expert on the product? You said they're focusing on editing the prose? |
| 19:16:31 | *** james_regen1 has left #openmrs |
| 19:16:50 | <dawn_> jriley: yes editing is their focus right now |
| 19:16:53 | <djazayeri> bwolfe, dkayiwa: thoughts about where to put documentation for module devs, related to upgrades and compatibiilty? |
| 19:16:55 | *** bryq has joined #openmrs |
| 19:16:55 | *** ChanServ sets mode: +v bryq |
| 19:17:49 | <dawn_> djazayeri: bwolfe jriley : for example, tickets like TRUNK-2930 "review book for historical errors" or TRUNK-2935 "add section about providers" those are tickets that dana and jan don't want to take right now since they aren't as familiar as we may be |
| 19:18:08 | <jriley> dawn_ - ok. Hmm. I'm going to be offline this afternoon, so I won't be editing the wiki |
| 19:18:11 | <dawn_> djazayeri: we may need your content expertise there ;) |
| 19:18:11 | <bwolfe> djazayeri, there is a very nice page that hibernate has with links for uprading 3.2-->3.3, 3.3-->3.4, 3.4-->3.5, etc |
| 19:18:18 | <jriley> and offline a chunk of the next couple days |
| 19:18:49 | <dawn_> jriley: okayâ¦.what i can do then is touch base with jan and dana on what they have made edits to on the wiki and share that with you. would that be helpful? |
| 19:18:50 | <bwolfe> djazayeri, I'd like us ot have something like that that we can just add to. and a predescribed place where /as we commit/ something to trunk and are thinking about "this might break modules" we can go and add it |
| 19:19:13 | *** suranga__ has quit IRC |
| 19:19:15 | <djazayeri> dawn_: does that mean that the content we discussed on the call last Wednesday made it in, or not? |
| 19:19:20 | <djazayeri> (e.g about providers) |
| 19:19:26 | <dkayiwa> djazayeri: bwolfe sounds great!!! |
| 19:19:33 | <djazayeri> bwolfe: I agree with that. |
| 19:19:47 | <jriley> Do they have ideas about what they'd like to do with the pages? Should I have a short call with them? I'm not sure how best to work together |
| 19:20:13 | <bwolfe> dkayiwa, djazayeri, http://community.jboss.org/wiki/Hibernate3MigrationGuides |
| 19:20:18 | <OpenMRSBot> <http://ln-s.net/9TMM> (at community.jboss.org) |
| 19:20:30 | <djazayeri> bwolfe, dkayiwa: maybe we put it under https://wiki.openmrs.org/display/docs/For+Module+Developers ? |
| 19:20:31 | <OpenMRSBot> <http://ln-s.net/8cbr> (at wiki.openmrs.org) |
| 19:20:52 | <djazayeri> or a separate topic under Developer Guide? |
| 19:21:23 | <dawn_> djazayeri: what do you mean? content that made it into tickets? |
| 19:21:43 | <dkayiwa> djazayeri: bwolfe and include the link in the release notes? |
| 19:21:50 | <djazayeri> dawn_: Burke and I talked about what Providers (etc) were. Someone took notes. |
| 19:22:16 | <djazayeri> dawn_: you said that they didn't feel comfortable doing TRUNK-2935. |
| 19:22:18 | <dawn_> jriley: we just spoke about going through pages and making grammar & punctuation updates and fixing links, but i would say if you're organizing the pages, you could give them direction on where to startâ¦.might help them piece things together in terms of understanding the content |
| 19:23:00 | <dawn_> djazayeri: ah, gotcha. I only spoke to Dana today, and she did not seem comfortable adding that information. i'm not sure about jan as we missed her today |
| 19:23:28 | <djazayeri> dawn_: okay, so I should check the book edits to see if that stuff made it in at all. |
| 19:24:33 | <djazayeri> bwolfe: amusingly, none of those hibernate migration guides say anything about the non-backwards-compatible changes we found. |
| 19:24:39 | <dawn_> djazayeri: if you have time, yes. just send an email out to that same list (jan, dana, bwolfe, me, janet, etc) to let us know |
| 19:24:52 | *** deadpool has quit IRC |
| 19:25:13 | <djazayeri> bwolfe: but I agree about the structure. |
| 19:25:31 | <djazayeri> dkayiwa: definitely we'll include the link in the release notes. |
| 19:25:42 | <dkayiwa> ok |
| 19:26:04 | <djazayeri> bwolfe, dkayiwa: should this be its own page under Developer Documentation? Or should it go under For Module Developers? |
| 19:26:42 | <dkayiwa> djazayeri: bwolfe i feel it should be its only page |
| 19:26:56 | <dkayiwa> djazayeri: bwolfe maybe with a link from there too |
| 19:27:28 | <dkayiwa> djazayeri: bwolfe something similar to the hibernate link Ben sent. module migration guides |
| 19:28:15 | <dawn_> jriley: do you want to try and have a quick call this week with jan, dana, and me? |
| 19:28:35 | <jriley> Yes, is there a time tomorrow morning before 10:30 that would work? |
| 19:29:04 | *** rafa has quit IRC |
| 19:29:15 | <dawn_> jriley: for me yes. i'll write jan and dana now with you included to see what availability they have tomorrow |
| 19:29:23 | <jriley> thanks |
| 19:29:38 | <jriley> or late tomorrow afternoon ( > 2:30) |
| 19:30:01 | *** bwolfe has quit IRC |
| 19:30:49 | *** bwolfe has joined #openmrs |
| 19:30:49 | *** ChanServ sets mode: +o bwolfe |
| 19:31:31 | <dkayiwa> djazayeri bwolfe does any of you have any objections about tagging the 1.9 beta now? |
| 19:32:06 | <djazayeri> dkayiwa: I haven't looked closely. If you think it's ready to release the beta as-is, then go ahead. |
| 19:32:13 | <djazayeri> When do we put in the bundled modules? |
| 19:32:19 | <djazayeri> also, can you use the maven release plugin for this? |
| 19:32:28 | <dkayiwa> djazayeri: before tagging :) |
| 19:32:29 | <djazayeri> and if so, will that tag it automatically? |
| 19:32:57 | <dkayiwa> djazayeri: i have never used anything else apart from the maven release plugin :) |
| 19:33:04 | <djazayeri> oh, great |
| 19:33:31 | <dkayiwa> djazayeri: just remembered, you are blocking me on the reporting module :) |
| 19:34:01 | <djazayeri> dkayiwa: I emailed you that just before the scrum. |
| 19:34:08 | <djazayeri> it's ~3.5 MB. |
| 19:34:14 | <dkayiwa> djazayeri: hahhaaa thanks :) |
| 19:34:15 | <djazayeri> I can just check it into svn if you prefer. |
| 19:35:09 | <bwolfe> he'll need to download it either way |
| 19:35:37 | <dkayiwa> :) |
| 19:35:40 | <djazayeri> yeah, but one way he also has to upload it. |
| 19:35:43 | <djazayeri> dkayiwa: your call |
| 19:36:00 | <dkayiwa> djazayeri: got it from the email |
| 19:38:57 | <dkayiwa> wyclif: are you about to be done with TRUNK-2994 ? |
| 19:40:34 | <wyclif> dkayiwa, am already done |
| 19:40:35 | <dawn_> jriley: got it :) sending the email here in a sec |
| 19:40:54 | <wyclif> dkayiwa, u can review and close the changeset i added in the comment |
| 19:41:08 | <dkayiwa> wyclif: ok thanks |
| 19:41:14 | <wyclif> dkayiwa, am now working on TODO sfor TRUNK-2273 |
| 19:41:29 | <dkayiwa> wyclif: ok |
| 19:44:48 | <dkayiwa> wyclif: did you commit only the revert |
| 19:45:10 | <dkayiwa> wyclif: rev:25075 |
| 19:47:55 | *** olliejones has joined #openmrs |
| 19:48:12 | *** dawn_ has quit IRC |
| 19:48:33 | <olliejones> can anyone answer a newbie workflow question, please? |
| 19:48:36 | <wyclif> dkayiwa, yeah |
| 19:48:45 | <olliejones> I just put a patch onto https://tickets.openmrs.org/browse/TRUNK-2776 |
| 19:48:52 | <olliejones> and set it to Code Review.... |
| 19:48:58 | <olliejones> is that all I have to do for now? |
| 19:49:22 | *** jriley has left #openmrs |
| 19:49:36 | <wyclif> dkayiwa, i have recalled that in the widgets i intentionally ignored catching delete and back space because they are actually legal depending on the position of the cursor in the input box |
| 19:51:13 | <wyclif> dkayiwa, the user could be probably be inserting a space to search against multiple strings e.g for concepts |
| 19:55:19 | *** dawn_ has joined #openmrs |
| 20:04:29 | *** olliejones has left #openmrs |
| 20:07:17 | <dkayiwa> wyclif: so how do we fix the ticket whose commit we have reverted? |
| 20:07:25 | <dkayiwa> wyclif: any proposals? |
| 20:08:44 | <wyclif> dkayiwa, that ticket wa meant to fix something else to do min search characters |
| 20:08:59 | <wyclif> dkayiwa, and not catching control keys |
| 20:09:21 | <dkayiwa> wyclif: should we have created another ticket for it? |
| 20:11:00 | <dkayiwa> wyclif: can you look at TRUNK-222 ? |
| 20:13:23 | <wyclif> dkayiwa, dkayiwa i have seen it but i think that changeset was fixing something a little different |
| 20:13:54 | <dkayiwa> wyclif: it actually fixes the delete thing |
| 20:14:44 | <wyclif> dkayiwa, i'm personally fine to have the search triggered when backspace is pressed because the cursor could be in the middle of the text |
| 20:15:26 | *** morristic has joined #openmrs |
| 20:15:34 | <dkayiwa> wyclif: can you look at your comment on 2011-06-02 16:50:53 EDT |
| 20:15:39 | <wyclif> dkayiwa, i dont recall making the search widgets track the last entered text |
| 20:15:59 | <wyclif> dkayiwa, ok |
| 20:17:06 | <wyclif> dkayiwa, am trying to ignore that comment, because i hadnt imagined if the cursor is in the middle |
| 20:17:17 | <wyclif> dkayiwa, same for space bar |
| 20:17:44 | <wyclif> dkayiwa, i doubt if i can fix that today, it seems tricky and it is trivial to hold back releasing the beta |
| 20:17:50 | <dkayiwa> wyclif: ok. can you comment these thoughts on that ticket? |
| 20:18:01 | <wyclif> are reopening it? |
| 20:18:09 | <wyclif> dkayiwa, are u reopening it? |
| 20:18:44 | <dkayiwa> wyclif: i do not think we should reopen it |
| 20:18:59 | <wyclif> ok, create a new one? |
| 20:19:11 | <dkayiwa> wyclif: maybe |
| 20:19:29 | <wyclif> ok |
| 20:21:22 | *** dawn_ has quit IRC |
| 20:24:38 | *** dawn_ has joined #openmrs |
| 20:25:07 | <robbyoconnor> hey dawn_! |
| 20:26:24 | *** dawn_ has quit IRC |
| 20:38:06 | *** r_friedman has quit IRC |
| 20:43:12 | <djazayeri> bwolfe, dkayiwa: first pass: https://wiki.openmrs.org/display/docs/Migration+Guides+for+Developers |
| 20:43:22 | <dkayiwa> ok |
| 20:43:26 | <djazayeri> (and I'm not planning a second pass at the moment) |
| 20:43:42 | <dkayiwa> :) |
| 20:47:25 | <wyclif> dkayiwa, ok, am committing changes for TRUNK-2273 in the next 10min after running unit tests |
| 20:47:42 | <dkayiwa> wyclif: ok thanks |
| 21:11:23 | <wyclif> dkayiwa, am done, you only need to ensure that djazayeri has approved the changes |
| 21:12:16 | <dkayiwa> wyclif: ok thanks |
| 21:13:08 | <djazayeri> wyclif: that's not quite right |
| 21:13:33 | <djazayeri> well, maybe |
| 21:14:02 | <djazayeri> I would say that only *one* PatientState in a workflow (and its state must be initial) can have a null date. |
| 21:14:17 | <djazayeri> I guess you're testing a subset of that. |
| 21:14:53 | <djazayeri> So it's okay, I guess. |
| 21:14:57 | <wyclif> djazayeri, i thought there should always be an initial state |
| 21:14:58 | <djazayeri> I'll take a further look in a second. |
| 21:15:10 | <djazayeri> wyclif: true, there should always be an initial state (if there are any states) |
| 21:15:41 | <djazayeri> I think the logic would make a lot more sense if you were explicitly looking at a sorted list of PatientStates within a single workflow |
| 21:17:11 | <wyclif> djazayeri, i would assume that the program work flow should be able to tell us the order or states |
| 21:17:27 | <wyclif> djazayeri, though i cant seem to find methods on it to do that for me |
| 21:17:50 | <djazayeri> wyclif: in my comment I suggesting adding a method on PatientProgram to do this |
| 21:17:53 | <djazayeri> it would be generally useful. |
| 21:18:07 | <djazayeri> ProgramWorkflow is metadata, it wouldn't be there. |
| 21:19:12 | *** bwolfe_ has joined #openmrs |
| 21:19:12 | *** ChanServ sets mode: +o bwolfe_ |
| 21:19:29 | <wyclif> djazayeri, i think getPossibleNextStates should have done that instead of sortng by concept names |
| 21:20:25 | <djazayeri> wyclif: that method was intended to be replaced when we added an actual state enging |
| 21:20:39 | <djazayeri> but the point is that PatientProgram has a List<PatientState> |
| 21:20:55 | <wyclif> djazayeri, ok |
| 21:21:17 | *** bwolfe has quit IRC |
| 21:21:23 | <djazayeri> you ought be able to say patientProgram.getStates(ProgramWorkflow), or patientProgram.getStatesByWorkflow() -> Map<ProgramWorkflow, List<PatientState>, but these methods don't exist. |
| 21:21:34 | <djazayeri> Seems worthwhile to add them and refactor the validator. |
| 21:21:39 | <djazayeri> But I don't think we need to block the beta for that. |
| 21:22:24 | <wyclif> djazayeri, i agree the validator logic will get simpler once that the program work flow can get us the states in order |
| 21:22:39 | <wyclif> djazayeri, so is that coe ready to be released in the beta? |
| 21:22:45 | <wyclif> djazayeri, so is that code ready to be released in the beta? |
| 21:23:26 | <wyclif> djazayeri, i will create a ticket for adding the convenience method to program work flow |
| 21:24:02 | <djazayeri> and don't close this ticket yet, since the to-do is to refactor the validator. (though if you really want you can close this and open another.) |
| 21:26:02 | <wyclif> djazayeri, will see what to do, so dkayiwa you are set to release the beta |
| 21:27:52 | <dkayiwa> wyclif: yes and thanks alot |
| 21:28:27 | *** dkayiwa has quit IRC |
| 21:33:02 | <wyclif> running off shortly |
| 22:06:09 | *** bryq has quit IRC |
| 22:41:36 | *** djazayeri has quit IRC |
| 23:04:55 | *** wyclif has quit IRC |
| 23:13:27 | *** bwolfe_ has quit IRC |
| 23:13:30 | *** bwolfe_ has joined #openmrs |
| 23:13:30 | *** ChanServ sets mode: +o bwolfe_ |
| 23:17:38 | *** bwolfe_ has quit IRC |
| 23:17:53 | *** bwolfe_ has joined #openmrs |
| 23:17:53 | *** ChanServ sets mode: +o bwolfe_ |
| 23:29:47 | *** rafa has joined #openmrs |
| 23:29:47 | *** ChanServ sets mode: +v rafa |
| 23:39:59 | *** deadpool has joined #openmrs |
| 23:44:39 | *** galinganmd has quit IRC |