| 00:28:49 | *** jriley has joined #openmrs |
| 00:30:40 | <jriley> @Djazayeri, I have a question about your comment re: test case name |
| 00:30:48 | <djazayeri> yes? |
| 00:30:56 | <jriley> You said I didn't need to submit a patch, but I need to remove a comment |
| 00:31:02 | <jriley> if I don't submit a patch, the comment doesn't get removed |
| 00:31:05 | <jriley> the //unignore comment |
| 00:31:12 | <jriley> So ... ? I have a patch |
| 00:31:18 | <jriley> and am poised to comment on the thread |
| 00:31:24 | <jriley> I don't believe I have commit access |
| 00:31:27 | <jriley> to svn |
| 00:31:52 | <djazayeri> a patch is fine, I just figured that it wouldn't be worth the trouble. |
| 00:32:01 | <djazayeri> We should get you svn commit access. |
| 00:32:02 | <jriley> too late :) |
| 00:33:30 | <jriley> I haven't tested the access question. I could take a shot at it |
| 00:33:48 | <jriley> It's like a big red button ... svn commit ... so tempting |
| 00:56:51 | *** jriley has quit IRC |
| 01:58:42 | *** robbyoconnor has joined #openmrs |
| 01:58:42 | *** ChanServ sets mode: +v robbyoconnor |
| 02:08:07 | *** ball has quit IRC |
| 02:28:57 | *** chopin has joined #openmrs |
| 02:50:47 | *** rafa has joined #openmrs |
| 02:50:47 | *** ChanServ sets mode: +v rafa |
| 03:08:27 | *** robbyoconnor has quit IRC |
| 04:31:47 | *** wyclif has quit IRC |
| 04:43:09 | *** wyclif has joined #openmrs |
| 04:52:09 | *** bwolfe_ has quit IRC |
| 06:06:25 | *** surangak has joined #openmrs |
| 06:06:52 | *** bwolfe has joined #openmrs |
| 06:06:52 | *** ChanServ sets mode: +o bwolfe |
| 06:19:42 | *** Echidna has quit IRC |
| 06:19:54 | *** Echidna has joined #openmrs |
| 06:19:54 | *** ChanServ sets mode: +v Echidna |
| 06:33:44 | *** kishoreyekkanti has joined #openmrs |
| 07:07:35 | *** surangak has quit IRC |
| 07:11:59 | *** rafa has quit IRC |
| 07:28:39 | *** dkayiwa has joined #openmrs |
| 07:28:50 | *** surangak has joined #openmrs |
| 07:41:54 | *** kishoreyekkanti_ has joined #openmrs |
| 07:43:38 | *** kishoreyekkanti has quit IRC |
| 07:44:24 | *** kishoreyekkanti has joined #openmrs |
| 07:46:19 | *** kishoreyekkanti_ has quit IRC |
| 08:21:05 | *** dkayiwa has quit IRC |
| 08:25:50 | *** dkayiwa has joined #openmrs |
| 09:16:27 | *** robbyoconnor has joined #openmrs |
| 09:16:27 | *** ChanServ sets mode: +v robbyoconnor |
| 09:18:54 | *** bwolfe has quit IRC |
| 09:20:04 | *** bwolfe has joined #openmrs |
| 09:20:04 | *** ChanServ sets mode: +o bwolfe |
| 09:22:26 | *** kishoreyekkanti_ has joined #openmrs |
| 09:24:37 | *** kishoreyekkanti has quit IRC |
| 09:24:38 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 09:38:00 | *** r0bby has joined #openmrs |
| 09:38:00 | *** ChanServ sets mode: +v r0bby |
| 09:41:45 | *** robbyoconnor has quit IRC |
| 09:46:51 | *** bwolfe_ has joined #openmrs |
| 09:46:51 | *** ChanServ sets mode: +o bwolfe_ |
| 09:47:06 | *** bwolfe has quit IRC |
| 10:26:56 | *** upul` has joined #openmrs |
| 10:26:56 | *** ChanServ sets mode: +v upul` |
| 10:46:14 | *** rafa has joined #openmrs |
| 10:46:14 | *** ChanServ sets mode: +v rafa |
| 10:52:37 | *** bwolfe_ has quit IRC |
| 10:58:58 | *** surangak has quit IRC |
| 11:33:11 | *** upul` has quit IRC |
| 12:10:20 | *** kishoreyekkanti has quit IRC |
| 12:18:51 | *** james_regen has joined #openmrs |
| 12:18:51 | *** ChanServ sets mode: +v james_regen |
| 13:06:10 | *** dkayiwa has quit IRC |
| 13:10:42 | *** dkayiwa has joined #openmrs |
| 13:34:14 | *** ball has joined #openmrs |
| 14:02:25 | *** bwolfe_ has joined #openmrs |
| 14:02:25 | *** ChanServ sets mode: +o bwolfe_ |
| 14:02:53 | <dkayiwa> hi bwolfe_ |
| 14:04:02 | <dkayiwa> bwolfe_: is your standalone mvn install working? |
| 14:08:34 | <bwolfe_> dkayiwa, it should be |
| 14:08:38 | <bwolfe_> svn update agin |
| 14:08:40 | <bwolfe_> *again |
| 14:08:45 | <bwolfe_> dkayiwa, I broke it with the first commit |
| 14:08:47 | *** bwolfe_ is now known as bwolfe |
| 14:08:55 | <dkayiwa> bwolfe: ok thanks |
| 14:14:07 | *** dkayiwa has quit IRC |
| 15:09:17 | *** kishoreyekkanti has joined #openmrs |
| 15:30:46 | *** magicaltrout is now known as gnackenson1 |
| 15:31:39 | *** gnackenson1 is now known as gnackenson2 |
| 15:31:53 | *** gnackenson2 is now known as magicaltrout |
| 15:50:14 | *** kishoreyekkanti has quit IRC |
| 16:34:08 | <rafa> bwolfe: how can I use Context in a separate thread? |
| 16:47:08 | <rafa> bwolfe: nevermind :) |
| 16:48:42 | *** deadpool_ has joined #openmrs |
| 16:50:26 | <deadpool_> rafa: what was that jsp trick to edit without always compiling again? |
| 16:51:15 | <rafa> deadpool_: you mean what to add to the ant script? |
| 16:51:26 | <deadpool_> yeah |
| 16:52:59 | <rafa> deadpool_: see http://pastebin.com/BJZDcUfd |
| 16:53:48 | <deadpool_> rafa thanks |
| 16:54:01 | <rafa> deadpool_: no problem |
| 17:24:12 | *** suranga has joined #openmrs |
| 17:34:29 | *** rafa has quit IRC |
| 17:41:24 | <suranga> howdy james_regen ... |
| 17:41:40 | <james_regen> suranga: hi |
| 17:42:04 | <suranga> james_regen, this is embarassing.. but im afraid I couldnt do much today |
| 17:42:34 | <suranga> I got Ada to comment on the ticket, but I have a deadline for friday, so things have been rather hectic |
| 17:42:41 | <suranga> james_regen, :-( |
| 17:42:54 | <james_regen> suranga: that's ok. did ada give any more feedback than what she changed on the ticket? |
| 17:43:16 | <suranga> james_regen, yep, she had got Win to comment on it as well |
| 17:43:28 | <suranga> apparenlty that ticket is wins idea... |
| 17:47:15 | <james_regen> i think we should get more feedback first. i'm not clear, at least, on how it should behave after the changes. |
| 17:48:18 | *** wyclif has joined #openmrs |
| 17:54:43 | <suranga> james_regen, I could probaly talk to win about this (I should have) but it was a rather hectic day.. |
| 17:54:54 | <suranga> james_regen, things will be back to normal by friday... |
| 17:55:10 | <suranga> we are having a series of pre-christmas deadlines |
| 17:55:47 | <james_regen> suranga: it's no problem if other things take priority. you're doing good work and you're very helpful. it's hard to complain when other things come up that you need to devote time and attention towards |
| 17:57:22 | *** suranga_ has joined #openmrs |
| 17:59:20 | <suranga_> james_regen, oh, its my please to help out |
| 17:59:40 | <suranga_> actually, Im not sure if I can get back to you regarding this tomorrow even... |
| 17:59:46 | <suranga_> I hope to be in a better position by friday :-) |
| 18:00:09 | *** suranga has quit IRC |
| 18:00:26 | <james_regen> suranga_: ok. i'll be here friday. |
| 18:01:06 | <suranga_> james_regen, wait, sorry, make it thursday |
| 18:01:33 | <james_regen> i'll be here thursday, too! |
| 18:01:49 | <suranga_> james_regen, awesome :-) |
| 18:02:04 | <suranga_> sorry about all this, see you on thursday... |
| 18:02:16 | <james_regen> ok, good luck with your other deadlines |
| 18:16:13 | *** suranga has joined #openmrs |
| 18:19:38 | *** suranga_ has quit IRC |
| 18:20:57 | *** suranga_ has joined #openmrs |
| 18:21:27 | *** suranga has quit IRC |
| 18:26:23 | *** rafa has joined #openmrs |
| 18:26:23 | *** ChanServ sets mode: +v rafa |
| 18:45:57 | *** suranga_ has quit IRC |
| 18:51:43 | *** dawn_ has joined #openmrs |
| 18:51:53 | *** ChanServ sets mode: +v dawn_ |
| 19:00:32 | <dawn_> !scrumon dawn |
| 19:00:32 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 19:00:44 | <dawn_> bwolfe: djazayeri rafa wyclif : hi |
| 19:00:52 | <djazayeri> hi dawn_ |
| 19:00:52 | *** james_regen has left #openmrs |
| 19:01:02 | <dawn_> Today's order: rafa , djazayeri , bwolfe , wyclif |
| 19:01:08 | <dawn_> ready when you are :) |
| 19:01:37 | <rafa> hi |
| 19:01:41 | <rafa> Today: |
| 19:01:41 | <rafa> * Closed https://tickets.openmrs.org/browse/TRUNK-2319 and released my second module that is the Validation Module :) |
| 19:01:41 | <rafa> Tomorrow: |
| 19:01:41 | <rafa> * I need ticket suggestions :) |
| 19:01:41 | <rafa> No blockers. |
| 19:02:32 | <djazayeri> me |
| 19:02:37 | <djazayeri> Monday 12-Dec-2011 |
| 19:02:37 | <djazayeri> * Kickoff doc sprint meeting |
| 19:02:37 | <djazayeri> * Applied review comments on TRUNK-2588 |
| 19:02:37 | <djazayeri> * Review: CR-TRUNK-611 |
| 19:02:37 | <djazayeri> * Review: CR-CONTRIB-66 |
| 19:02:37 | <djazayeri> * Review: CR-TRUNK-604 |
| 19:02:38 | <djazayeri> * Applied & Reviewed: TRUNK-2664, TRUNK-2928 (setting preferred name for concept) |
| 19:02:38 | <djazayeri> * (unexpected half-day, my apologies) |
| 19:02:39 | <djazayeri> Tues 13-Dec-2011 |
| 19:02:40 | <djazayeri> * Pizzigati prize judging call |
| 19:02:40 | <djazayeri> * Write documentation snippets about new 1.9 features. |
| 19:02:41 | <djazayeri> * Backport TRUNK-2588 to 1.9.x |
| 19:02:41 | <djazayeri> * ? |
| 19:02:42 | <djazayeri> Discussion point: Validators for customizables (e.g. Visit, Location, Provider) are problematic unless you're in MANUAL flushMode. E.g. new VisitValidator().validate(visitWithNewAttribute) will throw an exception due to premature flush. |
| 19:03:03 | <djazayeri> no blockers |
| 19:03:56 | <dawn_> bwolfe: you ready? |
| 19:04:43 | <bwolfe> today: |
| 19:04:43 | <bwolfe> reviewed only a few tickets for sprint |
| 19:04:43 | <bwolfe> reviewed notes from doc call |
| 19:04:43 | <bwolfe> committed hibernate upgrade |
| 19:04:43 | <bwolfe> fixed standalone readme |
| 19:04:44 | <bwolfe> repackaged 1.8.3 |
| 19:05:55 | <bwolfe> (no blockers) |
| 19:06:08 | <djazayeri> tomorrow? |
| 19:06:47 | <djazayeri> bwolfe: ^^ |
| 19:07:05 | <bwolfe> hmm, tomorrow: |
| 19:07:34 | <bwolfe> create more doc tickets, review sprint tickets, design call, pm call |
| 19:07:40 | <bwolfe> nothing new an exciting ;-) |
| 19:07:54 | <bwolfe> (sorry, committed cardinal sin of alt-tabbing away) |
| 19:07:58 | * bwolfe hangs head in shame |
| 19:08:30 | <djazayeri> shame |
| 19:08:34 | <dawn_> wyclif: your turn 8) |
| 19:08:35 | <djazayeri> who's next? |
| 19:08:58 | <wyclif> yesterday: |
| 19:08:59 | <wyclif> -Made some fixes as per review comments for TRUNK-412, backported them and closed it |
| 19:08:59 | <wyclif> -Wiki documentation for the jquery search widgets at https://wiki.openmrs.org/display/docs/Adding+a+jquery+OpenMRS+search+widget+to+a+jsp |
| 19:08:59 | <wyclif> -TRUNK-2954 - Rename configure URL, jsp, controller and related files |
| 19:08:59 | <wyclif> -SMART-30 - Fix unit tests in SmartProblemHandlerTest |
| 19:09:00 | <wyclif> today: |
| 19:09:02 | <wyclif> -TRUNK-2956 - Row highlight fails on verbose row when home/end/pageup/pagedown keys are used |
| 19:09:04 | <wyclif> -FORM-130 - Need to use the new provider API to get the list of providers |
| 19:09:06 | <wyclif> -Wiki documentation for additional attributes added to concept mappings and related GPs |
| 19:09:08 | <wyclif> -other sprint tickets |
| 19:09:10 | <wyclif> blockers: none |
| 19:09:57 | <wyclif> Ooops! am just realising bug when saving user during validation |
| 19:10:13 | <djazayeri> btw, if you do FORM-130, you might consider a copy-paste job to solve the equivalent HTML Form Entry ticket. |
| 19:10:30 | <bwolfe> not sure how copy-pastable that is... |
| 19:10:32 | <wyclif> djazayeri, do you know the ticket number? |
| 19:10:39 | <bwolfe> is that HTML ticket in the sprint djazayeri? |
| 19:10:55 | <bwolfe> ...must...resist...alt-ab... |
| 19:11:00 | <bwolfe> *alt-tab |
| 19:11:08 | <djazayeri> I'll look at the the ticket number |
| 19:11:11 | <djazayeri> it's not in the sprint now |
| 19:11:16 | <dawn_> !scrumoff dawn |
| 19:11:16 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 19:11:22 | <djazayeri> I just thought of it when Wyclif mentioned that other one |
| 19:12:00 | <dawn_> wyclif: bwolfe djazayeri : i have a questionâ¦for the "2012 Q4 roadmap clean up" are you saying that sprint is finishing the tickets for 1.9beta 2 sprint? |
| 19:12:09 | <bwolfe> dawn_, yes |
| 19:12:14 | <bwolfe> and SMART tickets |
| 19:12:17 | <bwolfe> and sync release |
| 19:12:24 | <dawn_> bwolfe: so why are we making new tickets? |
| 19:12:25 | <bwolfe> and maintenance releases |
| 19:12:28 | <bwolfe> and burke's thing |
| 19:12:36 | <bwolfe> new tickets for doc sprint |
| 19:12:43 | <djazayeri> wyclif: HTML-221 |
| 19:12:48 | <bwolfe> dawn_, or are you asking about the HTML one? |
| 19:13:37 | <dawn_> bwolfe: i'm looking at the dashboard for Dec 2011 Doc Sprint that has 2 tickets in progress and wondering why we're adding more right now. i think we need to get the present ones assigned to the technical writers, janet, ellen, and other ppl who want to contribute |
| 19:13:49 | <dawn_> bwolfe: because some are dependent on others, yes? |
| 19:14:09 | <bwolfe> dawn_, are they waiting for us to assign those? what have they been doing? |
| 19:14:57 | <wyclif> dawn_, also if we find bugs that need to be fixed for 1.9 we add them |
| 19:15:19 | <dawn_> bwolfe: i don't think anyone was clear yesterday how to start, so michael jamie and i divided it by wiki documentation and book documentation: https://docs.google.com/a/openmrs.org/spreadsheet/ccc?pli=1&key=0AjkycZp8TCPOdGZiRU1yZnYxaGFncFNXMUV5bGhyZEE&hl=en_US#gid=0 |
| 19:15:23 | <OpenMRSBot> <http://ln-s.net/9RW_> (at docs.google.com) |
| 19:16:00 | <dawn_> bwolfe: sent that out yesterday, but if i need to be more specific then i can |
| 19:16:08 | <bwolfe> dawn_, you start how sprints always start. pick out tickets that aren't assigned and claim them :-p |
| 19:16:26 | <bwolfe> dawn_, did you explain jira to them? |
| 19:16:42 | <bwolfe> did they say they would be in touch? or did you say we would be in touch with them? |
| 19:16:49 | <bwolfe> was burke on your call? |
| 19:17:31 | <djazayeri> burke was on the call |
| 19:17:37 | <dawn_> bwolfe: i understand that but if they're giving us help, we need to be more specific. they're on the learning curve of how we operate and in a sprint, i don't think there is time to giveâ¦esp with the holidays |
| 19:17:43 | <djazayeri> What they were going to do first was review the existing book. |
| 19:17:54 | <djazayeri> to get up to speed |
| 19:18:06 | <bwolfe> ok |
| 19:18:10 | <djazayeri> and they'll email the group with questions. |
| 19:18:57 | <bwolfe> ok, did you brief them on jira? Or at least give relevant links? |
| 19:19:05 | <dawn_> bwolfe: i think it would be beneficial to narrow down the tickets so they know which ones to focus their talents on |
| 19:19:19 | <dawn_> bwolfe: no, it was a short call, but i believe from the previous discussion jan is familiar with it |
| 19:19:48 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Validation Module 1.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=validation&version=&1.0> |
| 19:19:56 | <dawn_> bwolfe: as the sprint leaders and someone more familiar with JIRA than ma, can you connect with them? |
| 19:20:15 | <dawn_> djazayeri: haven't forgotten your discussion point. just trying to find ways to make this efficient with jan and dana on board. :) |
| 19:20:26 | <djazayeri> no worries |
| 19:21:22 | <djazayeri> I think that once they've finished the initial read-through, we should have a scrum-like call with them, and point out the use of jira briefly there |
| 19:21:40 | <dawn_> djazayeri: there is a call with them on wednesday, right? |
| 19:22:11 | <djazayeri> yes, I think so |
| 19:22:56 | <djazayeri> yes, there is |
| 19:23:00 | <djazayeri> we can use that time for it |
| 19:23:46 | <dawn_> djazayeri: that's perfect! i see it on burke's calendar so i'll hop on too but let you guys lead :) |
| 19:23:55 | <dawn_> k, that's enough time on that topic i think |
| 19:24:01 | <dawn_> Discussion point: Validators for customizables (e.g. Visit, Location, Provider) are problematic unless you're in MANUAL flushMode. E.g. new VisitValidator().validate(visitWithNewAttribute) will throw an exception due to premature flush. |
| 19:24:32 | <bwolfe> aren't all the validator calls surrounded with manual flushmode calls? |
| 19:24:56 | <djazayeri> rafal's fix was to do that in the automatic validate before a save. |
| 19:25:18 | <djazayeri> but not if you do validation in the controller as far as I know. |
| 19:25:45 | <djazayeri> But maybe this is just a unit testing issue, and in the controller it's still manual flush mode, until you've done a save call. |
| 19:26:10 | <djazayeri> here's the code snippet |
| 19:26:13 | <djazayeri> @Test |
| 19:26:13 | <djazayeri> // This test will throw org.hibernate.PropertyValueException: not-null property references a null or transient value: org.openmrs.VisitAttribute.valueReference |
| 19:26:13 | <djazayeri> // This is a general problem, i.e. that validators on Customizable can't really be called unless you set Hibernate's flushMode to MANUAL. |
| 19:26:13 | <djazayeri> // Once we figure it out, this test can be un-Ignored |
| 19:26:13 | <djazayeri> @Ignore |
| 19:26:13 | <djazayeri> public void validate_shouldFailIfAnAttributeIsBad() throws Exception { |
| 19:26:13 | <djazayeri> Visit visit = service.getVisit(1); |
| 19:26:14 | <djazayeri> visit.addAttribute(makeAttribute(new Date())); |
| 19:26:14 | <djazayeri> visit.addAttribute(makeAttribute("not a date")); |
| 19:26:15 | <djazayeri> Collection<VisitAttribute> activeAttributes = visit.getActiveAttributes(); |
| 19:26:15 | <djazayeri> Errors errors = new BindException(visit, "visit"); |
| 19:26:16 | <djazayeri> new VisitValidator().validate(visit, errors); |
| 19:26:16 | <djazayeri> Assert.assertEquals(true, errors.hasFieldErrors("attributes")); |
| 19:26:17 | <djazayeri> } |
| 19:27:17 | <djazayeri> I'll check whether this is just a unit test issue. |
| 19:27:27 | <djazayeri> I haven't had a chance to try out the trunk code recently |
| 19:28:24 | <rafa> djazayeri: yeah my solution doesn't cover this case |
| 19:29:02 | <bwolfe> my guess is still that it has to do with the transactions moving from the service interface to the dao impl |
| 19:29:43 | <djazayeri> rafa: do you remember when hibernate changes the flushmode? |
| 19:30:02 | <djazayeri> is it when you first call a method with @Transactional // readOnly=false ? |
| 19:30:14 | <rafa> djazayeri: yes |
| 19:30:30 | <djazayeri> okay, so as long as you don't do a service.saveSomething() before the validate call, it's okay |
| 19:30:38 | <djazayeri> maybe not a problem then, i'll test out what's going on in production |
| 19:31:12 | <djazayeri> okay, other discussion points? |
| 19:31:17 | <djazayeri> rafa: doesn't have a ticket |
| 19:31:21 | <djazayeri> wyclif: found a bug in user validation? |
| 19:31:55 | <rafa> yes I need tickets :) |
| 19:31:56 | <wyclif> i figured out why, because super user has no sex |
| 19:32:24 | <wyclif> so the validator was complaining since it was empty |
| 19:32:29 | <djazayeri> (yeah, sysadmins don't get out that much...) |
| 19:32:37 | <wyclif> djazayeri, he he he |
| 19:32:48 | <rafa> haha |
| 19:32:48 | <wyclif> djazayeri, ok, no gender |
| 19:33:02 | <djazayeri> wyclif: we just started validating things more thoroughly than we have been before |
| 19:33:16 | <wyclif> djazayeri, but i still noticed something else related |
| 19:33:17 | <bwolfe> djazayeri, lol |
| 19:33:18 | <djazayeri> so we might start seeing things (correctly) fail validation, which was permitted before |
| 19:33:24 | <djazayeri> but when are you saving the superuser? |
| 19:33:37 | <wyclif> djazayeri, when editing user options |
| 19:33:45 | <djazayeri> ah, okay |
| 19:34:02 | <djazayeri> Is Person.sex required? |
| 19:34:12 | <bwolfe> so I think we probably want to add a gender to that user with a changeset |
| 19:34:24 | <bwolfe> gender is non-null I think |
| 19:34:42 | <djazayeri> I think the db column is nullable, but the Validators for Patient and Person require it. |
| 19:34:48 | <wyclif> so the other issue is that editing user options doesn't really update certain things about the authenticated user |
| 19:35:05 | <djazayeri> wyclif: you mean that it should refresh the authenticated user in the context? |
| 19:35:06 | <wyclif> and i mentioned this before, when roles are eidted |
| 19:35:13 | <wyclif> djazayeri, yeah |
| 19:36:01 | <wyclif> forinstance when i call authenticatedUser.getProficientLocales, it fails if i just edited user options |
| 19:36:13 | <djazayeri> okay, so create a ticket about this general problem |
| 19:36:38 | <djazayeri> any time you edit something that may affect the currently authenticated user, you need to call Context.refreshAuthentciatedUser() |
| 19:36:53 | <djazayeri> e.g. edit roles, edit user |
| 19:37:45 | <wyclif> djazayeri, i think this needs to be done after calling saveUser, it should check if it is the authenticated user, if yes, refresh the authenticated user |
| 19:38:03 | <wyclif> rather than devs doing it manually in their code |
| 19:38:16 | <djazayeri> save role too? |
| 19:38:25 | <wyclif> yeah |
| 19:38:42 | <djazayeri> I can see the argument for that |
| 19:38:54 | <djazayeri> I'm also fine just doing this in the controllers for edit user and edit role. |
| 19:40:24 | <djazayeri> Has anyone else noticed that when you start Eclipse with the standalone project open it gives you a Heap Space error when building automatically? |
| 19:41:26 | <wyclif> so the bug am running into is that when i edit the user options e.g show retired and include verbose, when i go to the concept search page, it fails because the authenticatedUser.getProficientLocales fails |
| 19:42:00 | <wyclif> djazayeri, yes |
| 19:42:44 | <djazayeri> wyclif: so, you know how to fix this, right? |
| 19:43:13 | <wyclif> djazayeri, no, i just turned off auto building for the particular project |
| 19:43:19 | <bwolfe> djazayeri, because eclipse tries to "package" the standalone and that packaging is running/sourcing the demo data now |
| 19:43:24 | <djazayeri> oh, I meant your user refresh issue |
| 19:43:39 | <bwolfe> wyclif, in my eclipse its either all or none for auto build. :-/ |
| 19:43:49 | <djazayeri> bwolfe, wyclif: should we change this so it doesn't happen during package? |
| 19:43:50 | <wyclif> bwolfe, right |
| 19:43:59 | <djazayeri> but instead we add a special maven target? |
| 19:44:06 | <bwolfe> I like htat idea |
| 19:44:23 | <wyclif> i would say we should package when clean install |
| 19:44:41 | <wyclif> packaging should when mvn package is invoked |
| 19:45:32 | <bwolfe> wyclif, huh? |
| 19:45:52 | <djazayeri> I agree that it *should* happen during package. |
| 19:45:54 | <wyclif> sorry, 'clean install' shouldn't actually package the standalone, it should instead be 'mvn package' |
| 19:46:51 | <wyclif> djazayeri, thanks for struggling to read through my typos, bwolfe didn't, :) |
| 19:47:39 | <djazayeri> bwolfe: do you know how to solve this? |
| 19:48:36 | <bwolfe> djazayeri, I'm not that versed in maven. but I know one way would be to require the user to input a param in order to activate the packaging |
| 19:49:12 | <bwolfe> e.g: mvn clean package -Dreallypackage |
| 19:49:40 | <bwolfe> -Dopenmrs.version is already required though... |
| 19:49:45 | <bwolfe> djazayeri, when was the last time you updated? |
| 19:50:08 | <bwolfe> its possible I accidentally implemented this already in the last few days |
| 19:50:27 | <djazayeri> Haven't updated in a while |
| 19:50:43 | <djazayeri> We could have it only happen when you build in a particular profile, right? |
| 19:50:54 | <bwolfe> djazayeri, yes |
| 19:51:07 | <djazayeri> perhaps that would be "correct" |
| 19:51:15 | <bwolfe> but packaging stops right now if you don't tell it which version to run against |
| 19:51:25 | <bwolfe> so I think the latest standalone should be ok for you |
| 19:52:08 | <djazayeri> okay, I'll update |
| 19:55:15 | <djazayeri> okay, are we done for today? |
| 19:56:36 | <bwolfe> I'm almost done for today... |
| 19:58:22 | <djazayeri> I mean this conversation. :-) |
| 20:26:00 | *** dawn_ has quit IRC |
| 21:08:58 | *** mnunez__ has joined #openmrs |
| 21:13:52 | *** mnunez__ has quit IRC |
| 21:16:21 | *** dkayiwa has joined #openmrs |
| 21:28:03 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @pbiondich: @OpenMRS has a growing implementer community in the Cameroon. Exciting to see these popping up all over the place! http: ... <http://twitter.com/OpenMRS/statuses/146691614901932032> |
| 22:05:22 | *** rafa has quit IRC |
| 22:06:25 | <dkayiwa> hi bwolfe |
| 22:07:14 | *** dkayiwa has left #openmrs |
| 22:34:03 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @pbiondich: Project Viola is born! Stay tuned @OpenMRS community and the warmest welcome to our partners @twthoughts! http://t.co/HF ... <http://twitter.com/OpenMRS/statuses/146704056314896384> |
| 23:26:15 | *** ball has quit IRC |
| 23:34:23 | *** bwolfe has quit IRC |