| 00:50:21 | *** morristic has joined #openmrs |
| 01:37:04 | *** robbyoconnor has quit IRC |
| 01:43:38 | *** burke has joined #openmrs |
| 01:43:38 | *** ChanServ sets mode: +o burke |
| 02:43:52 | *** deadpool has joined #openmrs |
| 03:01:19 | *** upul` has joined #openmrs |
| 03:01:19 | *** ChanServ sets mode: +v upul` |
| 03:22:25 | *** deadpool has quit IRC |
| 03:22:37 | *** robbyoconnor has joined #openmrs |
| 03:22:37 | *** ChanServ sets mode: +v robbyoconnor |
| 03:38:55 | *** r0bby has joined #openmrs |
| 03:38:55 | *** ChanServ sets mode: +v r0bby |
| 03:39:27 | *** robbyoconnor has quit IRC |
| 04:11:05 | *** r0bby has quit IRC |
| 04:22:56 | *** r0bby has joined #openmrs |
| 04:22:56 | *** ChanServ sets mode: +v r0bby |
| 04:29:25 | *** bwolfe has joined #openmrs |
| 04:29:25 | *** ChanServ sets mode: +o bwolfe |
| 04:31:57 | *** r0bby has quit IRC |
| 04:32:31 | *** morristic has quit IRC |
| 04:33:34 | *** mfjim23 has joined #openmrs |
| 04:40:42 | *** mfjim23 has quit IRC |
| 05:29:10 | *** surangak has joined #openmrs |
| 05:31:50 | *** kishoreyekkanti has joined #openmrs |
| 05:32:49 | *** magicaltrout has quit IRC |
| 05:37:03 | *** magicaltrout has joined #openmrs |
| 05:37:52 | *** kishoreyekkanti_ has joined #openmrs |
| 05:39:55 | *** kishoreyekkanti has quit IRC |
| 05:39:56 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 05:52:36 | *** burke has quit IRC |
| 06:10:45 | *** bwolfe has quit IRC |
| 06:11:30 | *** r0bby has joined #openmrs |
| 06:11:30 | *** ChanServ sets mode: +v r0bby |
| 06:26:00 | *** kishoreyekkanti_ has joined #openmrs |
| 06:27:53 | *** kishoreyekkanti has quit IRC |
| 06:27:53 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 06:50:08 | *** kishoreyekkanti_ has joined #openmrs |
| 06:51:40 | *** bwolfe has joined #openmrs |
| 06:51:49 | *** ChanServ sets mode: +o bwolfe |
| 06:52:10 | *** kishoreyekkanti has quit IRC |
| 06:52:10 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 07:05:32 | *** dkayiwa has joined #openmrs |
| 07:16:38 | *** r0bby has quit IRC |
| 07:16:56 | *** r0bby has joined #openmrs |
| 07:16:56 | *** ChanServ sets mode: +v r0bby |
| 07:37:37 | *** surangak has quit IRC |
| 07:37:42 | *** surangak has joined #openmrs |
| 07:52:09 | <bwolfe> dkayiwa, what are you working on this morning? |
| 07:52:27 | <dkayiwa> bwolfe: TRUNK-2914 |
| 07:52:44 | <bwolfe> ok |
| 07:54:14 | <dkayiwa> bwolfe: did you have a ticket in mind for me? :) |
| 07:54:30 | <bwolfe> just wondering why the blocker and must tickets haven't been picked up by your or rafa yet. ;-) |
| 07:54:55 | <dkayiwa> bwolfe: am finishing this very quickly and pick one of the blockers :) |
| 07:55:11 | <bwolfe> perfect, thanks |
| 07:55:15 | <dkayiwa> bwolfe: i love mixing tough and simple ones :) |
| 09:01:49 | *** bwolfe_ has joined #openmrs |
| 09:01:49 | *** ChanServ sets mode: +o bwolfe_ |
| 09:04:47 | *** bwolfe has quit IRC |
| 09:11:01 | *** bwolfe__ has joined #openmrs |
| 09:11:17 | *** bwolfe_ has quit IRC |
| 09:12:29 | *** surangak has quit IRC |
| 09:12:44 | *** surangak has joined #openmrs |
| 09:20:08 | <surangak> hi bwolfe__ mm... I was wondering, this is approaching mid -december right ? so rightfully, there should be at least 1-2 potentioal GSOC 2012 students turning up on JIRA ? |
| 09:23:12 | *** rafa has joined #openmrs |
| 09:23:12 | *** ChanServ sets mode: +v rafa |
| 09:51:09 | *** bwolfe_ has joined #openmrs |
| 09:51:09 | *** ChanServ sets mode: +o bwolfe_ |
| 09:51:10 | *** bwolfe__ has quit IRC |
| 09:58:55 | <bwolfe_> surangak, haha, only if they want to be like you |
| 09:58:56 | *** bwolfe_ is now known as bwolfe |
| 09:59:00 | <bwolfe> (which is a good thing) |
| 09:59:22 | <surangak> bwolfe, I am a master of long term planning :P |
| 09:59:53 | <surangak> bwolfe, but actually, I havent seen anyone much turning up, (which is why im somewat concerned :-( |
| 10:12:14 | <rafa_> bwolfe: hey |
| 10:12:59 | <rafa_> bwolfe: shall I back port TRUNK-2921 to 1.8 as well? |
| 10:13:15 | <bwolfe> !ticket TRUNK-2921 |
| 10:13:16 | <OpenMRSBot> bwolfe: [#TRUNK-2921] ConceptValidator should not compare names of a retired concept against the names of other concepts - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2921 |
| 10:13:28 | <rafa_> bwolfe: ohh okay Darius already added that to fix versions |
| 10:13:28 | <bwolfe> rafa: yes |
| 10:13:30 | <rafa_> 1.7 as well |
| 10:13:39 | <bwolfe> maybe 1.7 |
| 10:13:53 | <bwolfe> actually, yes, 1.7 got the new concept validators |
| 10:13:53 | <rafa_> cool |
| 10:14:00 | *** surangak has quit IRC |
| 10:14:13 | *** surangak has joined #openmrs |
| 10:52:23 | *** surangak has quit IRC |
| 11:03:24 | <bwolfe> rafa, you closed CR-TRUNK-606 without a summary reason. are you going to close out the ticket too? Or just leave it open? |
| 11:03:31 | <bwolfe> https://tickets.openmrs.org/browse/TRUNK-2015 |
| 11:03:57 | <rafa_> bwolfe: you said it's ok right? |
| 11:04:26 | <bwolfe> rafa, yes closing it is fine. you just need to say "closing this after ben's review. no changes requested. I'll close hte ticket too" |
| 11:04:34 | <bwolfe> (preferrably spelling everything correctly though) |
| 11:04:37 | <rafa_> I see :) |
| 11:04:45 | <rafa_> I'll add it under the ticket |
| 11:29:44 | *** upul` has quit IRC |
| 11:33:56 | <bwolfe> rafa, have you given up on the MVP dictionary ticket? |
| 11:34:08 | <bwolfe> should I just compile 1.8.3 standalone without that in it? |
| 11:35:11 | <rafa_> bwolfe: basically yes, it won't be possible to finish it this week |
| 11:35:20 | <rafa_> I'm still running validators |
| 11:35:20 | <bwolfe> ok, thanks |
| 11:35:37 | <rafa_> around 15 000 concepts left |
| 11:36:04 | <rafa_> anyway I'll need Andy's help to resolve all issues |
| 11:36:49 | <bwolfe> ok |
| 11:36:51 | <bwolfe> ha |
| 11:37:02 | <bwolfe> thats a reaaaally slow validator |
| 11:37:05 | <bwolfe> someone should fix htat :-; |
| 11:37:07 | <bwolfe> :-p |
| 11:37:19 | <rafa_> haha yeah someone :D |
| 12:16:09 | *** ningosi has joined #openmrs |
| 12:30:59 | *** ningosi has quit IRC |
| 12:33:51 | *** rajiv_ has joined #openmrs |
| 12:34:52 | *** kishoreyekkanti_ has joined #openmrs |
| 12:35:12 | *** kishoreyekkanti_ has joined #openmrs |
| 12:35:12 | *** kishoreyekkanti has quit IRC |
| 12:35:13 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 12:35:29 | *** rajiv_ has quit IRC |
| 13:00:07 | *** wyclif has quit IRC |
| 13:02:47 | *** kishoreyekkanti_ has joined #openmrs |
| 13:03:28 | *** kishoreyekkanti has quit IRC |
| 13:03:42 | *** kishoreyekkanti has joined #openmrs |
| 13:11:56 | *** r0bby has quit IRC |
| 13:20:37 | *** kishoreyekkanti has quit IRC |
| 13:25:27 | *** dkayiwa has quit IRC |
| 13:32:29 | *** dkayiwa has joined #openmrs |
| 13:49:03 | *** burke has joined #openmrs |
| 13:49:03 | *** ChanServ sets mode: +o burke |
| 13:55:32 | *** wyclif has joined #openmrs |
| 14:42:44 | *** morristic has joined #openmrs |
| 14:57:18 | *** burke_ has joined #openmrs |
| 14:57:57 | *** r9friedman has joined #openmrs |
| 14:58:06 | *** r9friedman is now known as r_friedman |
| 14:58:16 | *** pascal` has joined #openmrs |
| 14:58:16 | *** ChanServ sets mode: +v pascal` |
| 14:58:38 | <pascal`> That freeconferencing user is never online when I need them to be :) |
| 14:59:05 | <r_friedman> burke_: hey burke, in concept we have fields short_name, description, form_text. I know the first two are deprecated, what about the third? |
| 14:59:34 | *** burke has quit IRC |
| 15:01:00 | <bwolfe> r_friedman, form_text? if thats not from a module then thats left over from pre 1.0! |
| 15:01:15 | *** burke has joined #openmrs |
| 15:01:15 | *** ChanServ sets mode: +o burke |
| 15:01:41 | *** burke_ has quit IRC |
| 15:14:40 | *** Echidna_ has quit IRC |
| 15:16:24 | *** Echidna has joined #openmrs |
| 15:16:24 | *** ChanServ sets mode: +v Echidna |
| 15:27:06 | *** dkayiwa has quit IRC |
| 15:32:39 | <djazayeri> rafa: are the validators done running on all concepts yet? |
| 15:33:00 | <rafa_> djazayeri: nope: 33027/48275, errors: 112 |
| 15:33:37 | <djazayeri> What are a few of those errors? |
| 15:34:04 | <rafa_> org.openmrs.api.APIException: '140705' failed to validate with reason: Only one fully specifies name is allowed for each locale at |
| 15:34:14 | <rafa_> org.openmrs.api.DuplicateConceptNameException: 'Pruritus' is a duplicate name in locale 'en' |
| 15:34:23 | <rafa_> org.openmrs.api.DuplicateConceptNameException: 'gastritis' is a duplicate name in locale 'es' |
| 15:34:34 | <rafa_> org.openmrs.api.APIException: '131' failed to validate with reason: Only one fully specifies name is allowed for each locale |
| 15:34:53 | <rafa_> org.openmrs.api.DuplicateConceptNameException: 'Hereditary Nephritis' is a duplicate name in locale 'en' |
| 15:35:29 | <rafa_> still mostly duplicate names but not that many :) |
| 15:40:27 | <djazayeri> None of these are in my copy of the dictionary. Maybe I'll load up the most recent version. |
| 15:42:29 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Address Hierarchy 2.1.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=addresshierarchy&version=&2.1.3> |
| 15:57:05 | <pascal`> r_friedman, at Rinkwavu, patient registration is done directly on a live system. |
| 15:57:19 | <pascal`> r_friedman, were you referring to registration or clinical encounter? |
| 15:57:41 | <r_friedman> pascal`: i went to the MVP site |
| 15:57:54 | *** burke has quit IRC |
| 15:57:56 | <r_friedman> pascal`: everything was post-entry there |
| 15:58:15 | <pascal`> r_friedman, Okay I see. At Rinkwavu they definitely to "live" registration. |
| 15:58:30 | <pascal`> *do |
| 15:59:12 | <r_friedman> pascal`: are you doing anything to reduce the traffic from requesting patient records from the exchange for every patient? |
| 15:59:28 | <r_friedman> pascal`: in particular, are you limiting by date or site? |
| 16:00:20 | <pascal`> r_friedman, not yet, but I know that patient records which are already contained locally won't be fetched. |
| 16:00:35 | <pascal`> r_friedman, I'll ask ryan. |
| 16:01:07 | <r_friedman> pascal`: thanks. please send my congrats to all, gotta get on another call |
| 16:02:12 | *** burke has joined #openmrs |
| 16:02:12 | *** ChanServ sets mode: +o burke |
| 16:03:02 | *** burke_ has joined #openmrs |
| 16:05:48 | *** darius has joined #openmrs |
| 16:06:40 | *** burke has quit IRC |
| 16:14:32 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @ekrub: Getting psyched about a documentation sprint for #OpenMRS next week with the help of technical writers donated by the #CDC <http://twitter.com/OpenMRS/statuses/144804847240216578> |
| 16:15:35 | *** rafa has quit IRC |
| 16:15:41 | *** rafa has joined #openmrs |
| 16:15:41 | *** ChanServ sets mode: +v rafa |
| 16:20:07 | *** kishoreyekkanti has joined #openmrs |
| 16:27:51 | *** wyclif has quit IRC |
| 16:28:10 | *** pascal` has quit IRC |
| 16:40:30 | *** burke_ is now known as burke__away |
| 16:51:29 | *** burke__away is now known as burke_ |
| 17:10:09 | *** morristic has quit IRC |
| 17:13:42 | *** morristic has joined #openmrs |
| 17:18:36 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Reporting 0.7.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=reporting&version=&0.7.0> || OpenMRS Modules: HTML Widgets 1.6.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlwidgets&version=&1.6.0> |
| 17:18:41 | *** burke_ has quit IRC |
| 17:23:40 | *** suranga has joined #openmrs |
| 17:24:46 | *** morristic has quit IRC |
| 17:50:38 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @WHI_Harvard: was really impressed to learn about the work of @OpenMRS last night @PIH; can't wait for an open source system for e-me ... <http://twitter.com/OpenMRS/statuses/144824549970673664> |
| 18:07:52 | *** wyclif has joined #openmrs |
| 18:07:54 | *** dawn_ has joined #openmrs |
| 18:07:55 | *** ChanServ sets mode: +v dawn_ |
| 18:12:08 | *** wyclif has quit IRC |
| 18:19:47 | *** rafa has quit IRC |
| 18:20:51 | *** rafa has joined #openmrs |
| 18:20:51 | *** ChanServ sets mode: +v rafa |
| 18:25:01 | *** wyclif has joined #openmrs |
| 18:30:06 | <dawn_> !scrumon dawn |
| 18:30:06 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 18:30:18 | <dawn_> bwolfe: djazayeri rafa , wyclif : hi |
| 18:30:21 | <djazayeri> I'm leaving for the airport in 2 minutes, so I'm going to go first now |
| 18:30:23 | <djazayeri> Here's my update |
| 18:30:25 | <djazayeri> Wednesday 7-Dec-2011 |
| 18:30:25 | <dawn_> k |
| 18:30:25 | <djazayeri> * University call |
| 18:30:25 | <djazayeri> * Design call |
| 18:30:25 | <djazayeri> * Project management call |
| 18:30:25 | <djazayeri> * TW catchup call |
| 18:30:26 | <djazayeri> * addressed a few code review comments |
| 18:30:26 | <djazayeri> * reviewed a bunch of tickets. (TRUNK-422, TRUNK-2903, TRUNK-2674, TRUNK-2273, TRUNK-37, STAND-35, TRUNK-2921, STAND-31, RELTEST-12, RELTEST-2, TRUNK-2910) |
| 18:30:27 | <djazayeri> * followup fix to TRUNK-2910 (UI of add/edit Visit page) |
| 18:30:28 | <djazayeri> Thursday 8-Dec-2011 |
| 18:30:28 | <djazayeri> * Dev call |
| 18:30:29 | <djazayeri> * Prepare for TW meeting on Friday |
| 18:30:29 | <djazayeri> * fly to Chicago |
| 18:30:32 | <rafa_> hi |
| 18:30:37 | <bwolfe> haha |
| 18:30:37 | <djazayeri> no blockers |
| 18:30:40 | <bwolfe> nice |
| 18:30:48 | <bwolfe> the blocker hopefully isn't "traffic" |
| 18:30:51 | <dawn_> bwolfe: your turn. chop chop! |
| 18:30:54 | <rafa_> :) |
| 18:30:56 | <djazayeri> hopefully not on the light rail. :-) |
| 18:31:03 | <bwolfe> that'd be ticky |
| 18:31:06 | <dawn_> rafa: you are after ben :) |
| 18:31:06 | <bwolfe> *tricky |
| 18:31:29 | <dawn_> djazayeri: safe travels, man |
| 18:31:39 | <bwolfe> does that mean I'm next? |
| 18:31:45 | <dawn_> bwolfe: yes |
| 18:31:51 | <dawn_> bwolfe: it is your turn |
| 18:31:52 | <bwolfe> oh goodie |
| 18:32:04 | <bwolfe> today: |
| 18:32:05 | <bwolfe> add design forum comments to tickets |
| 18:32:05 | <bwolfe> created tickets from design forum call |
| 18:32:05 | <bwolfe> sprint reviews |
| 18:32:05 | <bwolfe> removed MVP calls in standalone |
| 18:32:05 | <bwolfe> dev call |
| 18:32:07 | <bwolfe> leadership call |
| 18:32:21 | *** suranga_ has joined #openmrs |
| 18:32:21 | <bwolfe> blocker: demo dataset that wyclif made in the standalone |
| 18:32:52 | <dawn_> bwolfe: noted |
| 18:32:54 | <wyclif> yesterday: |
| 18:32:54 | <wyclif> -Complete SMART-22 - Simplify mapping of concepts to terminologies(have a blocker) |
| 18:32:54 | <wyclif> -TRUNK-2923 - Fix concept reference term to use randomly generated UUIDs |
| 18:32:54 | <wyclif> -Design call |
| 18:32:54 | <wyclif> today: |
| 18:32:54 | <wyclif> -TRUNK-2923 - Fix concept reference term to use randomly generated UUIDs |
| 18:32:56 | <wyclif> -Address all the tickets that need rework from reviews |
| 18:32:58 | <wyclif> -dev call |
| 18:33:00 | <wyclif> blockers:Handling concept mappings in SMART to support changes in mapping attributes |
| 18:33:14 | *** djazayeri has quit IRC |
| 18:33:35 | <wyclif> code review |
| 18:33:54 | *** kishoreyekkanti has quit IRC |
| 18:34:04 | <dawn_> rafa: ready when you are |
| 18:34:12 | <rafa_> Today: |
| 18:34:12 | <rafa_> * Still running Concept Validators on MVP :) |
| 18:34:12 | <rafa_> * Reopened, fixed and back ported TRUNK-422: Edit / View of previous forms should merge into a single interface paradigm |
| 18:34:12 | <rafa_> https://tickets.openmrs.org/browse/TRUNK-422 |
| 18:34:12 | <rafa_> * Addressed review comments on TRUNK-2821: Merge Patients page should be displayed on a separate pop-up screen |
| 18:34:12 | <rafa_> https://tickets.openmrs.org/browse/TRUNK-2821 |
| 18:34:12 | <rafa_> * Back ported TRUNK-2015: Move some functionality from SaveHandlers to hibernate interceptors |
| 18:34:13 | <rafa_> https://tickets.openmrs.org/browse/TRUNK-2015 |
| 18:34:13 | <rafa_> * Back ported TRUNK-2921: ConceptValidator should not compare names of a retired concept against the names of other concepts |
| 18:34:14 | <rafa_> https://tickets.openmrs.org/browse/TRUNK-2921 |
| 18:34:14 | <rafa_> Tomorrow: |
| 18:34:15 | <rafa_> * Validators should complete and I'll send results to Andy |
| 18:34:15 | <rafa_> * Test out RELTEST-14: Fetching data did not work on OpenMRS 1.6 |
| 18:34:16 | <rafa_> https://tickets.openmrs.org/browse/RELTEST-14 |
| 18:34:16 | <rafa_> No blockers. |
| 18:34:37 | <dawn_> cool. |
| 18:34:55 | <dawn_> Yesterday: 9 available issues, 18 tickets in code review |
| 18:35:06 | <dawn_> Today: 4 available issues, 11 tickets in code review, and still 4 unassigned |
| 18:35:27 | *** suranga has quit IRC |
| 18:36:09 | <dawn_> Discussion points: 1) Ben: blocker on demo dataset that wyclif made in standalone 2) Wyclif: blocker: handling concept mappings in SMART to support changes in mapping attributes |
| 18:36:35 | <dawn_> wyclif: when do you expect this sprint to be finished (what day)? |
| 18:37:08 | <wyclif> ideally should be friday but DEVS have to sunday to be done |
| 18:37:36 | <wyclif> i.e if anything is has review comments to review, have that done by monday |
| 18:37:47 | <wyclif> i.e if anything is has review comments to address, have that done by monday |
| 18:38:19 | <dawn_> wyclif: can we say to have the done by end of the day tomorrow? i don't know all the complexities, but seems it shouldn't take the entire weekend for what's remaining |
| 18:38:24 | <wyclif> i personally have about 5 like that, that need minor changes, but i plan to address them today |
| 18:38:49 | <dawn_> bwolfe: do you think this can be done by end of the day friday? |
| 18:38:57 | <dawn_> rafa: you can add your thoughts too |
| 18:38:58 | <dawn_> :) |
| 18:39:06 | <bwolfe> maybe |
| 18:39:07 | <wyclif> dawn_, most seem to have less complex issues besides one |
| 18:39:09 | <dawn_> just want to make sure we're all on the same page |
| 18:39:13 | * bwolfe looks at the jira dashboard |
| 18:39:54 | <wyclif> bwolfe, it is the Daemon/Interceptor issues that might am most concerned about getting done in time |
| 18:40:07 | <bwolfe> daemon should be easy |
| 18:40:15 | <bwolfe> interceptor should be solved by daemon |
| 18:40:18 | <dawn_> !scrumoff dawn |
| 18:40:18 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 18:40:22 | *** suranga_ has quit IRC |
| 18:40:38 | *** suranga has joined #openmrs |
| 18:42:19 | <dawn_> so sounds like finishing by end of the day friday is a possibility, and finishing by sunday is 100% certain |
| 18:42:47 | <dawn_> i think it would be good to get to the point where people don't spend their entire weekend trying to get a sprint finished :) |
| 18:43:46 | <bwolfe> ha |
| 18:43:57 | <bwolfe> yes, true |
| 18:44:06 | <wyclif> bwolfe, true |
| 18:44:06 | <bwolfe> we shall see |
| 18:44:17 | <dawn_> i don't expect that to happen right away, but would be good to work toward it |
| 18:44:18 | <bwolfe> no darius to code review today, so things will stall a bit later |
| 18:44:25 | <dawn_> word |
| 18:44:30 | <bwolfe> dawn_, the goal is to have a sprint done EARLY |
| 18:44:37 | <bwolfe> so that we can do housekeeping things afterwards |
| 18:44:39 | <dawn_> bwolfe: what is "early"? |
| 18:44:42 | <bwolfe> but we always put too much into the sprints. :-) |
| 18:44:48 | <bwolfe> wednesdayish |
| 18:44:54 | <dawn_> aaaahâ¦.k then |
| 18:45:10 | <dawn_> bwolfe: will keep that in mind with the documentation sprint coming up |
| 18:45:12 | <wyclif> i plan on having all my tickets back into review by end of today |
| 18:45:22 | <dawn_> cool cool |
| 18:45:24 | <wyclif> so i will time tomorrow to have them closed |
| 18:45:30 | <dawn_> kâ¦you guys have 2 blockers to discuss now |
| 18:45:32 | <wyclif> so i will have time tomorrow to have them closed |
| 18:45:43 | <dawn_> Ben: blocker on demo dataset that wyclif made in standalone 2) Wyclif: blocker: handling concept mappings in SMART to support changes in mapping attributes |
| 18:45:56 | <wyclif> so currently we want to use smart in 1.9 and earlier versions |
| 18:46:21 | <wyclif> and FYI modules creating concept mapping are going to break in 1.9 |
| 18:46:31 | <wyclif> i have tested this with smart |
| 18:47:14 | <wyclif> reason being we dont accept creating concept reference terms on the fly while saving a concept |
| 18:47:14 | <bwolfe> right, because the datamodel changed |
| 18:47:57 | <wyclif> bwolfe, for my work on the concept mapping page, i dont support 1.9 |
| 18:48:25 | <bwolfe> wyclif, huh? |
| 18:48:36 | <wyclif> am showing an error messages telling the user to do create the mappings manually from the concept form |
| 18:48:56 | <wyclif> bwolfe, or i have to manually create them for them |
| 18:49:07 | <wyclif> bwolfe, which i wanted to avoid |
| 18:49:25 | <bwolfe> you mean the smartcontainer concept mapping page? |
| 18:49:44 | <wyclif> bwolfe, i have nearly rewritten the controller and the mappings page |
| 18:49:51 | <wyclif> bwolfe, yeah |
| 18:50:48 | <wyclif> i tired building on the existing and it wasted my time so i got rid of most of it if i were to address your last 2 comments |
| 18:50:59 | <bwolfe> ok |
| 18:51:45 | <wyclif> bwolfe, so are you fine with not supporting concept mapping in smart for 1.9? |
| 18:52:17 | <wyclif> or i should create the terms? |
| 18:53:27 | <bwolfe> I'd rather you create the terms |
| 18:53:36 | <bwolfe> does this mean smart will only work on 1.9 ? |
| 18:53:47 | <bwolfe> or how are you making it work for 1.8 and below? |
| 18:53:50 | <wyclif> bwolfe, yes |
| 18:54:07 | <wyclif> am making only the mapping page work fot 1.8 and below |
| 18:54:15 | <wyclif> the rest is supportd |
| 18:54:32 | <wyclif> in 1.9 besides mapping |
| 18:56:01 | *** dawn_ has quit IRC |
| 18:56:37 | <wyclif> bwolfe, if i am to support mapping in 1.9, it would be via reflection and i dont wanted this as a TODO |
| 18:56:57 | <wyclif> bwolfe, sorry, i wanted to leave it as s TODO |
| 18:57:10 | *** dawn_ has joined #openmrs |
| 18:57:10 | *** ChanServ sets mode: +v dawn_ |
| 18:57:31 | <bwolfe> wyclif, what does it mean that its not supported? does it mean the module doesn't work or that the user just has to do it manually? |
| 18:58:11 | <wyclif> bwolfe, the module works in 1.9 but the concept mappings page doesn't |
| 18:58:33 | <bwolfe> if that page doesn't work for a user, what does that mean for them? |
| 18:59:00 | <wyclif> bwolfe, it means they have to go and create the mapping from the concept form |
| 18:59:09 | <bwolfe> ok, fine, leave it as a TODO |
| 18:59:15 | <wyclif> and not from the module's page |
| 19:00:05 | <wyclif> that is the end of what i wanted discuss |
| 19:00:12 | <wyclif> that is the end of what i wanted to discuss |
| 19:01:28 | <bwolfe> wyclif, ok, question for you from me |
| 19:01:45 | <wyclif> bwolfe, sure |
| 19:01:47 | <bwolfe> wyclif, how did you create this Demo-1.8.sql file in the standalone dir? |
| 19:02:14 | <wyclif> i downloaded it from demo data download page |
| 19:02:22 | <dawn_> bwolfe: meeting time |
| 19:02:25 | <dawn_> :) |
| 19:02:45 | <wyclif> bwolfe, probably that should be done my maven and just pass in the download url |
| 19:02:47 | <bwolfe> wyclif, no changes to it? |
| 19:03:04 | <wyclif> bwolfe, i made some changes to it via liquibase |
| 19:03:17 | <wyclif> bwolfe, the changelog file changes in 2.0.x |
| 19:03:24 | <bwolfe> no, but to the sql file |
| 19:03:36 | <bwolfe> its a straight download? |
| 19:03:39 | <wyclif> bwolfe, no change in the sql file |
| 19:03:49 | <wyclif> bwolfe, what's wrong? |
| 19:04:22 | <bwolfe> its not running right with 1.8.x |
| 19:04:34 | <wyclif> bwolfe, i know that burke made changes to it |
| 19:04:49 | <wyclif> bwolfe, but changes the copy on the download page |
| 19:04:55 | <wyclif> bwolfe, what is the problem |
| 19:04:58 | *** burke has joined #openmrs |
| 19:04:58 | *** ChanServ sets mode: +o burke |
| 19:05:25 | <bwolfe> burke made changes to the file when? |
| 19:05:44 | <wyclif> bwolfe, oh yes, i need to make a version change so that it doesn't change the liquibasechangelog file for 1.8 and less versions |
| 19:06:12 | <bwolfe> wyclif, theres that, but I just commented that out for now |
| 19:06:29 | <wyclif> bwolfe, what error are you getting? |
| 19:08:09 | <bwolfe> error about updating |
| 19:08:18 | <bwolfe> hmm, seems like it finished this time |
| 19:08:32 | <bwolfe> an mvn clean does not seem to be actually cleaning |
| 19:08:53 | <bwolfe> the dbs are still there and dirty from the last run |
| 19:09:01 | <bwolfe> deleting the target dir got it working for me again |
| 19:10:28 | <wyclif> bwolfe, you are right, those scripts dont delete the database directories |
| 19:10:56 | <wyclif> and i dont like that |
| 19:11:09 | <wyclif> though i liked it during development |
| 19:11:38 | <wyclif> since it would mean i dont have generate the database for each rerun since they take a while to complete |
| 19:12:46 | <wyclif> wyclif, i think you have to call 'mvn clean package' to have them deleted by maven |
| 19:13:08 | <bwolfe> I always run mvn clean package |
| 19:13:16 | <bwolfe> if you run mvn package it shouldn't rebuild |
| 19:13:18 | <bwolfe> but mvn clean |
| 19:13:18 | <wyclif> and that never deleted it |
| 19:13:28 | <bwolfe> err, but mvn clean should delete them |
| 19:13:43 | <wyclif> right, and it isn't? |
| 19:13:49 | <bwolfe> it is not |
| 19:13:53 | <wyclif> hmmm |
| 19:14:22 | <wyclif> bwolfe, i guess it is because you might have those mysqld still running from previous runs |
| 19:14:55 | <wyclif> bwolfe, and that i guess would file because of the mysql.lock file |
| 19:15:00 | <wyclif> fail |
| 19:15:09 | <bwolfe> maybe |
| 19:15:19 | <wyclif> bwolfe, i was killing those manually |
| 19:15:33 | <wyclif> because if a build fails prematurely, they stay running |
| 19:15:49 | <wyclif> should have a ticket to make sure thay are always killed |
| 19:16:40 | *** dawn_ has quit IRC |
| 20:06:08 | *** burke has quit IRC |
| 20:18:15 | *** suranga has quit IRC |
| 20:30:53 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Name Phonetics 1.3.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=namephonetics&version=&1.3.1> |
| 20:34:08 | *** bwolfe has quit IRC |
| 20:40:43 | *** r0bby has joined #openmrs |
| 20:40:43 | *** ChanServ sets mode: +v r0bby |
| 20:58:28 | *** r0bby has quit IRC |
| 21:03:32 | *** r_friedman has quit IRC |
| 22:27:28 | *** yanokwa has joined #openmrs |
| 22:27:28 | *** ChanServ sets mode: +v yanokwa |
| 22:51:44 | *** yanokwa has quit IRC |
| 23:39:53 | *** wyclif has quit IRC |
| 23:44:41 | *** daragh-farrell has joined #openmrs |
| 23:45:00 | <daragh-farrell> hi there |
| 23:45:36 | <daragh-farrell> just finished installing software, about to try and check out OpenMRS... |