| 00:49:01 | *** morristic has quit IRC |
| 01:05:52 | *** morristic has joined #openmrs |
| 01:30:59 | *** morristic has left #openmrs |
| 01:45:32 | *** morristic has joined #openmrs |
| 02:01:03 | *** rafa has joined #openmrs |
| 02:01:03 | *** ChanServ sets mode: +v rafa |
| 02:04:48 | *** rafa has quit IRC |
| 02:04:49 | *** morristic has quit IRC |
| 02:10:27 | *** morristic has joined #openmrs |
| 03:03:54 | *** r_friedman has joined #openmrs |
| 03:04:26 | <r_friedman> djazayeri1: hi darius |
| 03:05:21 | <r_friedman> wyclif: did you turn the background pink? |
| 03:17:30 | <wyclif> hi r_friedman |
| 03:17:38 | <wyclif> what is that? |
| 03:17:44 | <r_friedman> hiclif |
| 03:18:05 | <r_friedman> the irc screen is all of a sudden pink |
| 03:18:20 | <r_friedman> maybe for breast cancer? |
| 03:18:54 | <r_friedman> wyclif, do you have access to our maven repository? |
| 03:22:47 | <wyclif> r_friedman, i think so |
| 03:23:07 | <r_friedman> can you find out what rev of the restws module is out there? |
| 03:27:50 | *** upul` has joined #openmrs |
| 03:27:50 | *** ChanServ sets mode: +v upul` |
| 04:12:55 | *** surangak has joined #openmrs |
| 04:17:06 | *** r0bby has joined #openmrs |
| 04:17:06 | *** ChanServ sets mode: +v r0bby |
| 04:17:14 | *** robbyoconnor has quit IRC |
| 04:19:20 | *** bwolfe has joined #openmrs |
| 04:19:20 | *** ChanServ sets mode: +o bwolfe |
| 04:20:17 | *** surangak_ has joined #openmrs |
| 04:20:17 | *** surangak has quit IRC |
| 04:28:11 | *** r0bby is now known as robbyoconnor |
| 04:41:13 | <surangak_> bwolfe, good morning !!! |
| 04:41:23 | <surangak_> bwolfe, I got my tee shirts yesteray !!!!! |
| 04:41:25 | <surangak_> awesomeeeeeeeeeeee |
| 05:00:25 | <djazayeri1> hi r_friedman |
| 05:09:21 | *** surangak__ has joined #openmrs |
| 05:09:28 | *** surangak_ has quit IRC |
| 05:15:15 | *** surangak has joined #openmrs |
| 05:15:17 | *** surangak__ has quit IRC |
| 05:17:20 | <bwolfe> surangak, that was pretty quick. 2 weeks or so? |
| 05:17:25 | *** surangak has quit IRC |
| 05:17:35 | *** surangak has joined #openmrs |
| 05:50:44 | *** morristic has quit IRC |
| 06:26:18 | *** rafa has joined #openmrs |
| 06:26:18 | *** ChanServ sets mode: +v rafa |
| 06:42:49 | *** rafa has quit IRC |
| 07:10:01 | *** r_friedman has quit IRC |
| 07:26:31 | *** dkayiwa has joined #openmrs |
| 07:41:37 | *** robbyoconnor has quit IRC |
| 07:41:59 | *** robbyoconnor has joined #openmrs |
| 07:41:59 | *** ChanServ sets mode: +v robbyoconnor |
| 07:43:25 | *** dkayiwa_ has joined #openmrs |
| 07:43:53 | *** dkayiwa has quit IRC |
| 07:43:54 | *** dkayiwa_ is now known as dkayiwa |
| 07:58:20 | *** pascal` has joined #openmrs |
| 07:58:20 | *** ChanServ sets mode: +v pascal` |
| 07:59:24 | *** Echidna has quit IRC |
| 07:59:38 | *** dkayiwa has quit IRC |
| 07:59:57 | *** dkayiwa has joined #openmrs |
| 08:00:30 | *** Echidna has joined #openmrs |
| 08:00:30 | *** ChanServ sets mode: +v Echidna |
| 08:02:35 | *** surangak_ has joined #openmrs |
| 08:03:09 | *** surangak has quit IRC |
| 08:07:39 | *** rafa has joined #openmrs |
| 08:07:39 | *** ChanServ sets mode: +v rafa |
| 08:10:29 | <pascal`> hey bwolfe |
| 08:10:51 | <pascal`> bwolfe, do you know if there a repository of maternal health forms or reports anywhere? (I know MCL has the concepts) |
| 08:11:01 | <bwolfe> don't know |
| 08:11:09 | <bwolfe> the only one I know of is the "Form Bank" on the wiki |
| 08:14:23 | <pascal`> bwolfe, yeah, no maternal health forms on there :/ |
| 08:22:36 | <surangak_> bwolfe, thanks for the shirts !! they are awesomeeee |
| 08:22:49 | <surangak_> Im wearing the Regenstrief tee shirt today !!! |
| 08:23:00 | <bwolfe> surangak_, great! I never even saw them, so you'll have to blog about it with you in the shirts |
| 08:23:21 | <surangak_> thanks Ben, they are awesomeee |
| 08:24:01 | <bwolfe> surangak_, you should do something with photo stiching: set the camera on a stand. take 3 diff pics with you in the 3 shirts in differnet places in the room. then stitch the pics together so it looks like there are 3 of you in diff shirts :-D |
| 08:24:05 | <bwolfe> ada would love that |
| 08:24:40 | <surangak_> bwolfe, let me try that :P |
| 08:25:16 | <bwolfe> which rg shirt is it? |
| 08:25:37 | <pascal`> bwolfe, aparently AMPATH has some maternal care forms. Interested in sharing? (= |
| 08:26:39 | <surangak_> the blue/gray one :-) |
| 08:26:40 | <bwolfe> pascal`, I don't deal with ampath anymore. I'd suggest emailing the impl list to ask. :-) I can forward it on to the peeps so I know they see your request |
| 08:26:52 | <bwolfe> pascal`, htmlforms? infopath? xforms? |
| 08:27:23 | <pascal`> bwolfe, preferably htmlforms, since I'm setting up a pilot for MSF on their Debian server. |
| 08:31:56 | <pascal`> bwolfe, you've got mail. |
| 08:32:11 | <bwolfe> I always have mail... |
| 08:50:16 | *** bwolfe has quit IRC |
| 08:50:34 | *** bwolfe has joined #openmrs |
| 08:50:34 | *** ChanServ sets mode: +o bwolfe |
| 08:51:31 | *** rafa_ has joined #openmrs |
| 08:51:31 | *** ChanServ sets mode: +v rafa_ |
| 09:00:02 | *** dkayiwa has quit IRC |
| 09:16:54 | *** robbyoconnor has quit IRC |
| 09:17:13 | *** robbyoconnor has joined #openmrs |
| 09:17:13 | *** ChanServ sets mode: +v robbyoconnor |
| 09:21:12 | <pascal`> bwolfe, is the reporting framework a core module in the later versions of OpenMRS (1.8 / 1.9)? |
| 09:24:48 | <pascal`> Ah, I see from the release notes that it is. |
| 09:38:02 | <bwolfe> pascal`, its a bundled module |
| 09:38:07 | <bwolfe> bundled and core are different |
| 09:38:23 | <bwolfe> https://wiki.openmrs.org/display/docs/Core+Modules vs https://wiki.openmrs.org/display/docs/Bundling+Modules |
| 09:38:26 | <OpenMRSBot> <http://ln-s.net/9Dc7> (at wiki.openmrs.org) |
| 10:05:41 | <surangak_> mm... hi bwolfe am in need of some patientMatching advice :-) |
| 10:11:34 | <bwolfe> surangak_, ok |
| 10:11:53 | <surangak_> its like this, patientMatching urrently works on ant |
| 10:12:03 | <surangak_> so I was planning to move it to maven |
| 10:12:23 | <surangak_> so problem is, Im a total newbie yo ant. so can u advise me on, |
| 10:12:35 | <surangak_> 1. is it possible to switch an openmrs module from ant to maven |
| 10:13:02 | <surangak_> 2. does it involve just writing a working pom file, or are there structural changes we need to make to the file structure |
| 10:13:13 | <surangak_> 3. is it very hard to make this switch ? :-) |
| 10:13:31 | <bwolfe> surangak_, its a 5 min task |
| 10:13:41 | <surangak_> bwolfe, :-O |
| 10:13:44 | <bwolfe> https://wiki.openmrs.org/display/docs/Converting+old+code+to+Maven |
| 10:13:45 | <OpenMRSBot> <http://ln-s.net/9-5f> (at wiki.openmrs.org) |
| 10:13:50 | <surangak_> bwolfe, wow |
| 10:14:17 | <bwolfe> you might have to get cygwin running on your wincrap computer to run the shell scripts though :-) |
| 10:14:34 | <surangak_> :-( |
| 10:15:29 | <surangak_> bwolfe, awesome documentation though... thanks |
| 10:18:35 | <bwolfe> surangak_, do you have an ubuntu vm working? |
| 10:18:53 | <surangak_> bwolfe, not really, Im considering the options right now :P |
| 10:19:17 | <surangak_> here at office and uni, we're pretty much windows people |
| 10:19:21 | <surangak_> office-- |
| 10:19:36 | <bwolfe> windows-- |
| 10:19:50 | <bwolfe> you could still run a vm and just use ubuntu all the time |
| 10:19:55 | <bwolfe> windows would just become a shell ;-) |
| 10:21:22 | <surangak_> I dont think our MIS would like it when they find out :P hmmm........ |
| 10:21:47 | <bwolfe> why would they care? |
| 10:21:58 | <bwolfe> just get them to install virtualbox for you and you're done |
| 10:37:11 | *** cta has joined #openmrs |
| 10:37:17 | <cta> hello |
| 10:38:20 | <bwolfe> hi taras |
| 10:38:42 | <cta> bwolfe: I agree with you, Ben, about using getUnrunChnages() method in that place, sorry, it was my fault |
| 10:39:35 | <cta> I think that it will be better if we do this stuff within method updatesRequired() of DatabaseUpdater class. What do you think about? |
| 10:40:01 | <bwolfe> np |
| 10:40:01 | <bwolfe> its tricky where to put things in the startup/db/unlock/etc |
| 10:41:39 | *** rafa_ has quit IRC |
| 10:41:58 | <cta> bwolfe: ok, I will create a patch for this to prevent adding of unnecessary revs and after you'll approve it, i'll commit changes into trunk, ok? |
| 10:42:33 | <bwolfe> cta, ok |
| 10:42:49 | <bwolfe> yeah, that method sounds more correct. but make sure you're only calling unrunupdates once |
| 10:50:19 | <cta> ok |
| 10:52:38 | *** surangak_ has quit IRC |
| 11:00:05 | *** rafa_ has joined #openmrs |
| 11:00:05 | *** ChanServ sets mode: +v rafa_ |
| 11:05:30 | *** pascal` has quit IRC |
| 11:06:07 | <cta> bwolfe: ben, I've already created a review for that, please, see https://source.openmrs.org/cru/CR-TRUNK-608 |
| 11:08:38 | *** pascal` has joined #openmrs |
| 11:13:59 | *** cta has quit IRC |
| 11:22:01 | *** pascal` has quit IRC |
| 11:28:11 | *** upul` has quit IRC |
| 11:38:37 | *** kishoreyekkanti has joined #openmrs |
| 12:11:28 | *** robbyoconnor has quit IRC |
| 12:26:49 | *** kishoreyekkanti_ has joined #openmrs |
| 12:28:40 | *** kishoreyekkanti has quit IRC |
| 12:28:40 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 12:30:02 | <rafa> bwolfe: are you around? |
| 12:30:24 | <rafa> bwolfe: should I go with https://tickets.openmrs.org/browse/STAND-36 or something else? |
| 12:31:14 | *** gagaman has joined #openmrs |
| 12:31:25 | <bwolfe> hmm, rafa, wyclif's labels didn't cover any of the STAND tickets |
| 12:31:32 | <gagaman> nick mnunez_ |
| 12:31:40 | *** gagaman is now known as mnunez_ |
| 12:31:45 | <bwolfe> are there other stand tickets? |
| 12:32:14 | <mnunez_> Hi everyone! |
| 12:32:29 | <bwolfe> hi marcos |
| 12:32:44 | <rafa> https://tickets.openmrs.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+STAND+AND+status+%3D+%22Ready+for+Work%22+ORDER+BY+priority+DESC&mode=hide |
| 12:32:46 | <rafa> bwolfe: |
| 12:33:22 | <rafa> but only this one is marked for 1.9 beta |
| 12:34:55 | *** kishoreyekkanti_ has joined #openmrs |
| 12:34:55 | *** wyclif has quit IRC |
| 12:35:16 | <bwolfe> rafa, ok |
| 12:35:33 | <bwolfe> both dkayiwa and wyclif have looked at that MVP one |
| 12:36:24 | <rafa> bwolfe: I fear that there will be a lot of invalid concepts |
| 12:36:35 | <bwolfe> heh possibly |
| 12:36:39 | <rafa> bwolfe: at least it was the case the last time I ran validators on MVP |
| 12:36:44 | <bwolfe> although andy keeps his dictionary pretty clean |
| 12:36:51 | <bwolfe> oh |
| 12:37:12 | <rafa> bwolfe: I'll get the latest version from Andy and see |
| 12:37:16 | <bwolfe> was that before the slight adjustment to the validation? I think wyclif backed off on some things (like synonyms can be the same as short names...or something like that) |
| 12:37:41 | *** kishoreyekkanti has quit IRC |
| 12:37:42 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 12:37:47 | <rafa> bwolfe: yeah it was some time ago (probably before wyclif's changes) |
| 12:38:30 | <mnunez_> bwolfe: Sorry to bother, but what's the function that returns addresses in form fields? patient.getAddress()? |
| 12:38:43 | <rafa> bwolfe: I can test it out easily trying to export the entire dictionary with MDS :) |
| 12:38:47 | <bwolfe> probably patient.getPersonAddress() |
| 12:38:56 | <rafa> bwolfe: it doesn't allow to export invalid concepts |
| 12:39:06 | <rafa> bwolfe: but I'm not sure if it works with 1.9 ;) |
| 12:39:47 | <bwolfe> mnunez_, yeah, getPersonAddress() |
| 12:39:58 | <bwolfe> mnunez_, http://resources.openmrs.org/doc/org/openmrs/Patient.html |
| 12:40:03 | <bwolfe> and see it in the "methods inherited from ...." |
| 12:40:24 | <mnunez_> bwolfe: Thanks! |
| 12:40:32 | <bwolfe> mnunez_, use http://doc.openmrs.org for the openmrs api/javadocs that you can use in forms |
| 12:43:04 | *** james_regen has joined #openmrs |
| 12:43:04 | *** ChanServ sets mode: +v james_regen |
| 12:43:40 | <rafa> bwolfe: do you know if changes to validators made by wyclif were back ported to 1.8? |
| 12:43:53 | <bwolfe> I'm not sure |
| 12:43:56 | <bwolfe> I would assume so |
| 12:44:05 | <bwolfe> they shoudl have been backported to 1.7 since thats where they were added |
| 12:49:51 | <bwolfe> rafa I'd rather you polish up the tickets you have open already |
| 12:49:59 | <bwolfe> I bounced TRUNK-2588 back to you |
| 12:50:32 | <bwolfe> oh wait, I'm thinking of a diff one |
| 12:50:58 | <bwolfe> but that one is still "In Progress", so its waiting on the assignee to do something with it... |
| 12:52:36 | <rafa> bwolfe: I've just assigned it to Darius. He'll update the patch. |
| 12:52:46 | <bwolfe> maybe he will ;-) |
| 13:06:44 | *** dkayiwa has joined #openmrs |
| 13:06:45 | *** dkayiwa has left #openmrs |
| 13:09:02 | *** kishoreyekkanti_ has joined #openmrs |
| 13:11:08 | *** kishoreyekkanti has quit IRC |
| 13:11:08 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 13:24:45 | *** dkayiwa has joined #openmrs |
| 13:26:16 | *** morristic has joined #openmrs |
| 13:37:27 | *** wyclif has joined #openmrs |
| 13:38:08 | *** mnunez_ has quit IRC |
| 14:45:56 | <wyclif> hi bwolfe |
| 14:51:46 | *** downeym has joined #openmrs |
| 14:51:46 | *** ChanServ sets mode: +o downeym |
| 14:51:46 | *** OpenMRSBot sets mode: +o downeym |
| 14:53:09 | *** kishoreyekkanti_ has joined #openmrs |
| 14:54:53 | *** kishoreyekkanti has quit IRC |
| 14:54:53 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 14:55:17 | <wyclif> are u there bwolfe ? |
| 15:21:14 | *** kishoreyekkanti has quit IRC |
| 15:45:03 | *** wyclif has quit IRC |
| 15:45:35 | *** wyclif has joined #openmrs |
| 15:51:47 | *** wyclif has quit IRC |
| 16:01:22 | *** burke has joined #openmrs |
| 16:01:22 | *** ChanServ sets mode: +o burke |
| 16:05:42 | *** wyclif has joined #openmrs |
| 16:18:20 | *** kimando has joined #openmrs |
| 16:20:33 | *** wyclif has quit IRC |
| 16:20:47 | *** wyclif has joined #openmrs |
| 16:22:38 | *** robbyoconnor has joined #openmrs |
| 16:22:38 | *** ChanServ sets mode: +v robbyoconnor |
| 16:37:27 | *** kimando has quit IRC |
| 16:57:59 | *** robbyoconnor has quit IRC |
| 16:58:38 | *** robbyoconnor has joined #openmrs |
| 16:58:38 | *** ChanServ sets mode: +v robbyoconnor |
| 17:02:11 | *** suranga has joined #openmrs |
| 17:10:23 | *** magicaltrout is now known as gnackenson |
| 17:11:09 | *** gnackenson is now known as magicalgnackenso |
| 17:11:16 | *** magicalgnackenso is now known as magicaltrout |
| 17:12:00 | *** kishoreyekkanti has joined #openmrs |
| 17:16:19 | *** robbyoconnor has quit IRC |
| 17:16:24 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Congrats to #OpenMRS community! Martin Were @jblaya & @isaacholeman each win #mHealth Top 11 in '11! http://t.co/SEYN3HEV #mHS11 <http://twitter.com/OpenMRS/statuses/143735021579145217> |
| 17:16:40 | *** robbyoconnor has joined #openmrs |
| 17:16:48 | *** robbyoconnor has joined #openmrs |
| 17:16:48 | *** ChanServ sets mode: +v robbyoconnor |
| 17:19:15 | *** burke is now known as burke_away |
| 17:20:42 | *** robbyoconnor has quit IRC |
| 17:21:05 | *** robbyoconnor has joined #openmrs |
| 17:21:05 | *** ChanServ sets mode: +v robbyoconnor |
| 17:32:57 | *** burke_away is now known as burke |
| 17:49:32 | * suranga returns |
| 17:49:41 | <suranga> james_regen, heloo... |
| 18:00:31 | <james_regen> suranga: hi |
| 18:01:10 | *** dawn_ has joined #openmrs |
| 18:01:10 | *** ChanServ sets mode: +v dawn_ |
| 18:01:41 | *** dawn_ has left #openmrs |
| 18:01:59 | *** dawn_ has joined #openmrs |
| 18:04:10 | *** sgrannis has joined #openmrs |
| 18:04:16 | <downeym> Hi sgrannis and welcome to the #openmrs IRC channel. |
| 18:04:21 | *** ChanServ sets mode: +v sgrannis |
| 18:04:33 | <sgrannis> suranga - are u there? |
| 18:04:47 | <bwolfe> wyclif, do you still need me? |
| 18:06:34 | *** robbyoconnor has quit IRC |
| 18:09:12 | <wyclif> nope bwolfe |
| 18:10:49 | *** burke has quit IRC |
| 18:18:09 | *** rafa_ has quit IRC |
| 18:19:09 | *** djazayeri1 has quit IRC |
| 18:19:38 | *** djazayeri has joined #openmrs |
| 18:19:38 | *** ChanServ sets mode: +o djazayeri |
| 18:27:30 | *** rafa_ has joined #openmrs |
| 18:27:30 | *** ChanServ sets mode: +v rafa_ |
| 18:30:09 | <bwolfe> dawn_, you sent that email out just in time :-p |
| 18:30:10 | <dawn_> !scrumon dawn |
| 18:30:10 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster dawn- you may begin when ready. |
| 18:30:18 | <bwolfe> shoot |
| 18:30:39 | *** suranga has quit IRC |
| 18:30:39 | <bwolfe> I was just typing that! |
| 18:30:41 | <bwolfe> rafa, wyclif, djazayeri, dkayiwa, dawn_ |
| 18:30:46 | <djazayeri> can we scrumon dawn_ ? |
| 18:31:02 | <dawn_> djazayeri: ready when you guys are :) |
| 18:31:06 | <dawn_> which is now |
| 18:31:20 | <djazayeri> bring it. :-) |
| 18:31:20 | *** kishoreyekkanti has quit IRC |
| 18:31:30 | <bwolfe> kishore could not bring it apparently |
| 18:31:32 | <rafa> hi |
| 18:31:36 | <wyclif> hi |
| 18:31:44 | <bwolfe> order of the day dawn_? |
| 18:31:48 | <bwolfe> random drawing of numbers? |
| 18:31:52 | <dawn_> Today's order: rafa: bwolfe , wyclif , djazayeri , then dkayiwa |
| 18:32:19 | <bwolfe> rafa wins! |
| 18:32:21 | <rafa> Today: |
| 18:32:21 | <rafa> * Committed TRUNK-2821: Merge Patients page should be displayed on a separate pop-up screen |
| 18:32:21 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2821 |
| 18:32:21 | <rafa> * Started with STAND-36: Automatically create MVP/CIEL dictionary-based dataset as part of the standalone build process |
| 18:32:21 | <rafa> https://tickets.openmrs.org/browse/STAND-36 |
| 18:32:22 | <rafa> Tomorrow: |
| 18:32:22 | <rafa> * Continue with STAND-36 |
| 18:32:23 | <rafa> No blockers. |
| 18:32:56 | <bwolfe> rafa, you've been on STAND-36 most of the day, any hangups yet? |
| 18:33:27 | <rafa> bwolfe: I've just managed to install 1.8 and MVP |
| 18:33:36 | <rafa> bwolfe: am ready to run validators |
| 18:33:56 | <rafa> bwolfe: I'll update then to 1.9 |
| 18:34:15 | <rafa> bwolfe: contact Andy in case of any nontrivial invalid concepts |
| 18:34:38 | <djazayeri> rafa: of course make sure to coordinate with wyclif since he's working on STAND-35. |
| 18:34:52 | <rafa> !ticket STAND-35 |
| 18:34:54 | <OpenMRSBot> rafa: [#STAND-35] Automatically create demo dataset as part of the standalone build process - OpenMRS JIRA - https://tickets.openmrs.org/browse/STAND-35 |
| 18:35:28 | <djazayeri> I mean: these are identical tickets, but one is for the demo DB, and the other is for MVP. |
| 18:35:36 | <rafa> djazayeri: yes, that's helpful |
| 18:35:50 | <dawn_> bwolfe: you ready? |
| 18:35:50 | <rafa> wyclif: hope you'll finish first :) |
| 18:36:17 | <bwolfe> wyclif, rafa, discuss it after the scrum |
| 18:36:19 | <wyclif> rafa, does your ticket depend on mine? |
| 18:36:22 | <bwolfe> def coordinate |
| 18:36:24 | *** suranga has joined #openmrs |
| 18:36:36 | <bwolfe> today: applied small restws patch - RESTWS-188 |
| 18:36:40 | <bwolfe> finally created review for one of my commits last week - accidental voiding of patient - TRUNK-2674 |
| 18:36:40 | <bwolfe> emails |
| 18:36:40 | <bwolfe> fixed hibnerateenumtype - TRUNK-2907 |
| 18:36:40 | <bwolfe> cleaned up sprint schedule wiki page |
| 18:36:40 | <bwolfe> sync fix for newer hibernate version |
| 18:36:40 | <bwolfe> random comments and reviews of sprint tickets |
| 18:36:41 | <bwolfe> hibernate upgrade patch |
| 18:36:47 | <bwolfe> no blockers |
| 18:37:03 | <bwolfe> tomorrow: more of the same |
| 18:37:23 | <dawn_> wyclif: you're up |
| 18:37:36 | <wyclif> friday: |
| 18:37:36 | <wyclif> -STAND-31 - Quick first pass of a one-time prompt for standalone configuration on initial startup |
| 18:37:36 | <wyclif> -Preparing tickets and jira dashboard for this week's sprint |
| 18:37:36 | <wyclif> -Started on STAND-35 - include daemo data in standalone (managed to load demo data via liquibase maven plugin) |
| 18:37:36 | <wyclif> today: |
| 18:37:38 | <wyclif> -STAND-35 - Fixing the plugin to include the demo data and testing the entire build process. |
| 18:37:40 | <wyclif> - more sprint tickets |
| 18:38:21 | <wyclif> blocker: when building the standalone, i can't connect to the DB |
| 18:38:45 | <bwolfe> ok, lets discuss that after |
| 18:39:00 | <dawn_> djazayeri: your turn |
| 18:39:03 | <bwolfe> (after the scrum) |
| 18:39:03 | <bwolfe> who was next? |
| 18:39:11 | <dkayiwa> djazayeri: |
| 18:39:14 | <djazayeri> wyclif: if the build fails you occasionally need to manually kill the mysql process that's running on 3326 |
| 18:39:22 | <djazayeri> Friday 2-Dec-2011 |
| 18:39:22 | <djazayeri> * Call with a TW BA |
| 18:39:22 | <djazayeri> * Call with CDC documenters |
| 18:39:22 | <djazayeri> * Working on a project proposal |
| 18:39:22 | <djazayeri> * (only a half-day today) |
| 18:39:22 | <djazayeri> Monday 5-Dec-2011 |
| 18:39:23 | <djazayeri> * Update patch and commit TRUNK-2588 |
| 18:39:23 | <djazayeri> * Some code reviews |
| 18:39:24 | <djazayeri> * Discuss current sprint tickets with Wyclif |
| 18:39:24 | <djazayeri> * Review tickets created by TW BA |
| 18:39:25 | <djazayeri> * Prepare for TW meeting on Friday |
| 18:39:34 | <wyclif> djazayeri, let me try that |
| 18:39:46 | <wyclif> let's continue with scrum updates |
| 18:39:53 | <djazayeri> no blockers on my end |
| 18:40:06 | <bwolfe> djazayeri-- for not fixing your copy/paste about friday ;-) |
| 18:40:26 | <djazayeri> well, it *was* only a half-day. |
| 18:40:30 | <bwolfe> !TRUNK-2588 |
| 18:40:31 | <OpenMRSBot> bwolfe: Error: "TRUNK-2588" is not a valid command. |
| 18:40:42 | <dawn_> dkayiwa: your turn :) |
| 18:40:42 | <bwolfe> !ticket TRUNK-2588 |
| 18:40:42 | <djazayeri> !ticket TRUNK-2588 |
| 18:40:43 | <OpenMRSBot> bwolfe: [#TRUNK-2588] Generic mechanism for doing Attributes and Attribute Types on many classes. (Review code, and Refactor.) - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2588 |
| 18:40:44 | <OpenMRSBot> djazayeri: [#TRUNK-2588] Generic mechanism for doing Attributes and Attribute Types on many classes. (Review code, and Refactor.) - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2588 |
| 18:40:48 | <dkayiwa> Did a code review for: Patient is unintentionally deleted while replacing his/her drug regimen from the regimen tab of the dashboard - TRUNK-2674 |
| 18:40:49 | <dkayiwa> Back ported to 1.9.x and closed: Should not allow deleting of a started task - TRUNK-2790 |
| 18:40:49 | <dkayiwa> Committed: AuditableInterceptor fails with a NPE at startup if there are scheduled tasks to run at startup - TRUNK-2903 |
| 18:40:49 | <dkayiwa> Committed: Settings page does not work in OpenMRS 1.6 - RELTEST-13 |
| 18:40:50 | <dkayiwa> Committed response to review comments for: Add a settings page for the release testing module - RELTEST-2 |
| 18:40:50 | <dkayiwa> About to pick another ticket - ??? |
| 18:40:50 | <dkayiwa> No Blockers |
| 18:41:19 | <bwolfe> when did you commit 2903 dkayiwa? |
| 18:41:30 | <dkayiwa> bwolfe: today |
| 18:41:31 | <dawn_> what about TRUNK-2903? |
| 18:41:34 | <dawn_> k |
| 18:41:44 | <bwolfe> what time though? |
| 18:41:55 | <dkayiwa> bwolfe: let me check |
| 18:41:58 | <bwolfe> nm, I just did an svn update and I see some scheduler stuff come through |
| 18:42:10 | <bwolfe> (I was hitting the NPE and wondering where the fix was...) :-) |
| 18:42:11 | <dkayiwa> bwolfe: a couple of hours ago |
| 18:42:21 | <bwolfe> perfect |
| 18:42:25 | <bwolfe> thanks! :-) |
| 18:42:36 | <dkayiwa> bwolfe: immediately before i broke the build :) |
| 18:42:43 | <bwolfe> ha |
| 18:42:44 | <dkayiwa> CI |
| 18:43:02 | <bwolfe> I couldn't tell. it was lost in the middle of all the other nonsense CI emails |
| 18:43:05 | * bwolfe looks at downeym |
| 18:43:12 | <dkayiwa> :) |
| 18:43:34 | <downeym> should have been at the end, not the middle. |
| 18:43:50 | <dkayiwa> yes i broke it last :) |
| 18:43:53 | <djazayeri> So, wyclif put together the sprint dashboard: https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=11156 |
| 18:43:54 | <dkayiwa> as for today |
| 18:44:14 | <dawn_> !scrumoff |
| 18:44:14 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 18:44:15 | <djazayeri> wyclif: any comments on this? Is it "complete" i.e. if we were to finish all these tickets would we be set to release 1.9 beta? |
| 18:44:42 | <wyclif> i basicaaly got or un c losed tickets from the last spring |
| 18:44:50 | <wyclif> sprint |
| 18:45:17 | <wyclif> so some of the tickets require code review |
| 18:45:37 | <wyclif> djazayeri, so i would say yes |
| 18:45:38 | <djazayeri> wyclif: okay, I think that we should step through the whole process, though, and make sure we're satisfied with it end-to-end. |
| 18:45:48 | <djazayeri> or did you do that? |
| 18:46:06 | <wyclif> djazayeri, it is the bundled modules that am not certain about |
| 18:46:24 | <djazayeri> wyclif: such as? |
| 18:46:28 | <wyclif> djazayeri, i also need to chat with daneil just to get his feeling about releasing the beta |
| 18:46:44 | <wyclif> djazayeri, reporting |
| 18:46:56 | <wyclif> formentry |
| 18:47:01 | <djazayeri> wyclif: what is it that you're not certain about with them? |
| 18:47:06 | <djazayeri> just that they haven't been looked at/ |
| 18:47:09 | <djazayeri> ? |
| 18:47:33 | *** burke has joined #openmrs |
| 18:47:33 | *** ChanServ sets mode: +o burke |
| 18:48:02 | <wyclif> am assuming that the versions released with the alpha are the ones to include in the beta and that modules developers think they production worthy |
| 18:48:18 | <djazayeri> wyclif: well, I think those are the versions to include |
| 18:48:29 | <djazayeri> I don't think they've been fully-updated yet |
| 18:49:14 | <wyclif> djazayeri, then we only need to release an alpha for the release testing helper and SMART |
| 18:50:57 | <bwolfe> djazayeri, wyclif, formentry needs to be updated to work with 1.9 if we're bundling that. (I don't think it was bundled in the alpha) |
| 18:51:08 | <djazayeri> correct, not bundled yet |
| 18:51:19 | <wyclif> then we need to have that figured out |
| 18:51:29 | <djazayeri> html form entry also has minor inconsistencies with 1.9 that will need to be fixed for the final release. |
| 18:51:53 | <wyclif> djazayeri, so will the fix be in 1.9 or formentry |
| 18:52:06 | <wyclif> i understand it also had a problem with 1.8 |
| 18:52:07 | <djazayeri> formentry and htmlformentry I think |
| 18:53:43 | <djazayeri> okay, I'm off to do TRUNK-2588 |
| 18:53:48 | <djazayeri> s/do/finish |
| 18:53:57 | <dkayiwa> !ticket TRUNK-2588 |
| 18:53:58 | <OpenMRSBot> dkayiwa: [#TRUNK-2588] Generic mechanism for doing Attributes and Attribute Types on many classes. (Review code, and Refactor.) - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2588 |
| 18:54:15 | *** burke has quit IRC |
| 18:54:17 | <rafa> wyclif: Ben said you've loosened validator constraints recently, have you back ported it to 1.8? |
| 18:54:19 | *** burke has joined #openmrs |
| 18:54:19 | *** ChanServ sets mode: +o burke |
| 18:54:49 | <wyclif> dkayiwa, do you mind going through all the other unresolved bug tickets for 1.9 and see if you can pickout those you might want us to fix furing this sprint |
| 18:55:02 | <dkayiwa> wyclif: ok |
| 18:55:16 | <djazayeri> rafa: btw, the ideal solution would involve having the standalone build scripts take as input the latest available version of the MVP dictionary downloaded from Andy. |
| 18:55:36 | <wyclif> dkayiwa, i know some of them have been left out, if you come across any that you fill should be include, add the 1.9-beta2 label |
| 18:55:42 | <wyclif> dkayiwa, or comment |
| 18:55:48 | <dkayiwa> wyclif: ok |
| 18:56:01 | <djazayeri> rafa: i.e. better to start from that .sql file somehow, so whenever we're going to release a new standalone, we just download the latest MVP dictionary for it. |
| 18:56:47 | <djazayeri> rafa: this means that any concepts that don't pass validation need to be fixed in Andy's original (1.6?) dictionary and we need a new export from him. |
| 18:57:00 | <wyclif> djazayeri, bwolfe i have asked daniel to go though some of the other 1.9 tickets and see if he find any bug tickets that rrequire small fixes that should be fixed in the beta |
| 18:57:05 | <rafa> djazayeri: there's an export from 1.8.x |
| 18:57:23 | <djazayeri> rafa: is that provided by Andy? or by someone else? |
| 18:57:36 | <wyclif> djazayeri, bwolfe because i think some bug tickets were left out |
| 18:57:39 | <rafa> djazayeri: hmm I found it in Andy's dropbox |
| 18:57:48 | <bwolfe> isn't dkayiwa going on holiday now? |
| 18:58:04 | <dkayiwa> bwolfe: next week |
| 18:58:28 | <bwolfe> oh good :-) |
| 18:59:11 | <dkayiwa> bwolfe: can push it some few days forwards if i need to :) |
| 18:59:30 | <dawn_> djazayeri: wyclif bwolfe rafa if you're taking holiday this month or next share it with the group (me included) so we can plan accordingly |
| 18:59:49 | *** sgrannis has left #openmrs |
| 18:59:52 | <dawn_> plz :) |
| 18:59:53 | <djazayeri> rafa: looking at his dropbox I see 1.6.4 from 18-nov, and 1.8.2 from 29-july |
| 19:00:02 | <bwolfe> dawn_, you want it all here now or over email? :-) |
| 19:00:45 | <dawn_> you can tell me now b/c i'll just put it into my calendar |
| 19:01:04 | <bwolfe> I'm off the 23rd-30th of this month |
| 19:01:09 | <wyclif> i only plan to take off monday the 26th of DEC, 2011 |
| 19:01:16 | <rafa> djazayeri: so do you suggest to use 1.6.4? |
| 19:01:27 | <wyclif> dawn_, i only plan to take off monday the 26th of DEC, 2011 |
| 19:01:30 | <djazayeri> rafa: I think so. Andy isn't maintaining the 1.8.x ones himself |
| 19:01:58 | <bwolfe> and jan 23rd - feb 6th (ish) for paternity leave |
| 19:02:40 | <djazayeri> dawn_: I'm off for most of Dec 26 - Jan 6, but I haven't decided exactly what part. |
| 19:02:47 | <rafa> djazayeri: okay thanks |
| 19:04:43 | <rafa> dawn_: I don't plan any days off. |
| 19:05:09 | <dawn_> bwolfe: rafa djazayeri : got it. thanks! |
| 19:05:36 | <dawn_> wyclif: just saw yoursâ¦thnx! |
| 19:06:12 | <dawn_> wyclif: we have that day off anyway :P |
| 19:07:05 | <wyclif> djazayeri, are you saying we have 26th off? |
| 19:07:26 | <wyclif> dawn_, i will come over to your cube |
| 19:08:29 | <wyclif> dawn_, actually then i might not take any day off |
| 19:09:06 | <djazayeri> wyclif: depends on IU/RI |
| 19:09:42 | <wyclif> i think IU |
| 19:09:54 | <wyclif> if IU closed, RI closed too |
| 19:10:05 | <downeym> wyclif: the 26th is a Regenstrief paid holiday |
| 19:11:00 | <wyclif> the UI/RG stuff gives me a headache to figure out |
| 19:11:38 | <downeym> wyclif: holiday schedule is posted on the RI intranet :) |
| 19:12:50 | <dawn_> wyclif: you can come to work on the 26th, but you will be the only one here :D |
| 19:19:26 | *** Echidna has quit IRC |
| 19:19:35 | *** Echidna has joined #openmrs |
| 19:19:35 | *** ChanServ sets mode: +v Echidna |
| 19:24:23 | <djazayeri> rafa_: do you know what revision the 2588 patch is from? |
| 19:24:36 | <rafa> see my comment |
| 19:25:08 | <rafa> djazayeri: TRUNK-2588_trunk-rev24282.patch |
| 19:25:43 | <djazayeri> oh, ha, I was looking at the one at the bottom of the list |
| 19:25:53 | <djazayeri> why doesn't it sort them by date? :-) |
| 19:25:56 | <djazayeri> thanks |
| 19:31:35 | <bwolfe> djazayeri, by default it sorts by name. (why?!). at least you can change it to sort by date with the newest jira |
| 19:31:52 | <djazayeri> fun factoid, thanks |
| 19:35:41 | *** dawn_ has quit IRC |
| 19:37:00 | *** dawn_ has joined #openmrs |
| 19:37:32 | *** dawn__ has joined #openmrs |
| 19:37:32 | *** dawn_ has quit IRC |
| 19:37:33 | *** dawn__ is now known as dawn_ |
| 19:40:19 | *** dawn_ has quit IRC |
| 19:49:18 | *** dawn_ has joined #openmrs |
| 19:49:45 | *** dawn__ has joined #openmrs |
| 19:49:45 | *** dawn_ has quit IRC |
| 19:49:45 | *** dawn__ is now known as dawn_ |
| 19:49:49 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @evanjmwaters: @PIH looking for #Linux #SysAdmin to design, implement systems for @OpenMRS in #Haiti #Rwanda #Malawi #Lesotho http:// ... <http://twitter.com/OpenMRS/statuses/143773982334791680> || On Twitter: OpenMRS: RT @evanjmwaters: @PIH looking for #UX #UI Designer to create intuitive interfaces for @OpenMRS in #Haiti #Rwanda #Lesotho #Malawi http: ... <http://twitter.com/OpenMRS/statuses/143772470258843648> |
| 20:04:24 | *** suranga has quit IRC |
| 20:04:35 | *** downeym_ has joined #openmrs |
| 20:04:35 | *** ChanServ sets mode: +o downeym_ |
| 20:07:52 | *** downeym has quit IRC |
| 20:07:53 | *** downeym_ is now known as downeym |
| 20:14:30 | *** dawn_ has quit IRC |
| 20:16:38 | *** bwolfe has quit IRC |
| 20:22:19 | *** burke has quit IRC |
| 20:38:39 | *** chopin_ has joined #openmrs |
| 20:39:07 | <chopin_> hey guys, can you think of an example in core of filling an extension point with HTML from a JSP page? |
| 20:41:52 | <chopin_> no? |
| 21:02:40 | *** james_regen has quit IRC |
| 21:27:45 | <wyclif> hi djazayeri |
| 21:28:43 | <wyclif> is the 'NO_CHANGES' db meant to refer to the one with DEMO data |
| 21:28:48 | <wyclif> djazayeri, is the 'NO_CHANGES' db meant to refer to the one with DEMO data |
| 21:29:32 | <djazayeri> hi wyclif |
| 21:29:50 | <djazayeri> NO_CHANGES is intended to mean: "do not change the database, just leave what's there" |
| 21:29:53 | <djazayeri> add a comment or rename it if that's unclear |
| 21:30:08 | <wyclif> ok, thanks |
| 21:31:02 | <wyclif> djazayeri, so it is different? |
| 21:31:21 | <djazayeri> wyclif: what class was this again? |
| 21:31:33 | <wyclif> djazayeri, MainFRame |
| 21:32:24 | <djazayeri> wyclif: you need to add an option for DEMO_DATABASE |
| 21:32:36 | <djazayeri> and rafa_ will need to add one for MVP_DATABASE |
| 21:32:40 | <wyclif> djazayeri, djazayeri, in the UI there is no button for NO CHANGE |
| 21:32:46 | <djazayeri> or maybe we call it STARTER_DATABASE |
| 21:33:12 | <wyclif> djazayeri, in the UI there starter(with MVP), Demo and EMPTY |
| 21:33:16 | <djazayeri> wyclif: NO_CHANGES was supposed to be the "cancel" option |
| 21:33:44 | <wyclif> djazayeri, ok, i will create the ticket to fix that on the UI |
| 21:33:53 | <wyclif> djazayeri, did you see the last changed i made in the UI |
| 21:34:19 | <djazayeri> wyclif: I haven't looked at what the new UI looks like yet. |
| 21:34:26 | <wyclif> djazayeri, would be nice if you looked at them, i added snapshots too |
| 21:34:31 | <djazayeri> wyclif: what would the ticket to fix be? |
| 21:34:32 | <wyclif> see STAND-31 |
| 21:34:50 | <djazayeri> wyclif: I think it's fine to leave NO_CHANGES in the API but not explicitly expose it via a button in the UI. |
| 21:35:27 | <wyclif> djazayeri, the ticket is to add a cancel option and and to map the appriate action listener |
| 21:35:37 | <wyclif> djazayeri, ok |
| 21:35:53 | <djazayeri> wyclif: isn't there already an [x] to cancel in the top-right corner of the dialog? |
| 21:36:00 | <djazayeri> wyclif: I don't see snapshots on STAND-31 |
| 21:36:46 | <wyclif> djazayeri, check again |
| 21:37:39 | *** chopin_ has quit IRC |
| 21:38:00 | <wyclif> djazayeri, you can change the icons to anything else |
| 21:38:30 | <djazayeri> wyclif: is there a way to put the explanatory text on the button? |
| 21:38:37 | <djazayeri> like in the final mockups in STAND-17? |
| 21:39:30 | <wyclif> djazayeri, i can, but i dont like the the long buttons |
| 21:39:45 | <djazayeri> wyclif: yeah, I'll want to change the icons for Demo and Starter, but I haven't thought about exactly what yet. |
| 21:40:21 | *** downeym has quit IRC |
| 21:40:25 | <wyclif> djazayeri, but i can't add the arrow on the extreme right |
| 21:40:37 | <wyclif> djazayeri, because a JButton can only have one image and text |
| 21:41:15 | <djazayeri> wyclif: okay, that's fine then. |
| 21:41:22 | <wyclif> ok |
| 21:41:31 | <djazayeri> wyclif: I take it you couldn't figure out how to make the buttons red, yellow, and green, either? |
| 21:41:32 | <wyclif> heading home, talk to u later |
| 21:41:36 | <djazayeri> ok, bye |
| 21:41:38 | <wyclif> djazayeri, i did |
| 21:41:50 | <djazayeri> but decided against it? |
| 21:41:56 | <wyclif> djazayeri, but at the expense of the borders |
| 21:42:07 | *** burke has joined #openmrs |
| 21:42:07 | *** ChanServ sets mode: +o burke |
| 21:42:16 | <wyclif> djazayeri, we have to choose either the bg color or borders |
| 21:42:28 | <djazayeri> wyclif: bg color definitely |
| 21:42:41 | <wyclif> djazayeri, i will do that and add new snapshots |
| 21:42:49 | <djazayeri> I only colored the border because in my first pass I couldn't figure out how to color the background |
| 21:42:59 | <wyclif> djazayeri, ok |
| 21:43:11 | <djazayeri> also, note the wrong line break in "depending on <br/> your needs" |
| 21:43:32 | <wyclif> djazayeri, yes |
| 21:43:38 | <wyclif> djazayeri, i will remove it |
| 21:44:21 | *** burke has quit IRC |
| 21:44:23 | <wyclif> djazayeri, i will be back online in about 30min, ttyl |
| 21:44:27 | <djazayeri> bye |
| 21:44:28 | *** burke has joined #openmrs |
| 21:44:28 | *** ChanServ sets mode: +o burke |
| 21:50:05 | *** wyclif has quit IRC |
| 21:57:11 | *** dkayiwa has left #openmrs |
| 21:59:44 | *** ada_ has joined #openmrs |
| 22:00:22 | <ada_> anyone knows how to turn on the form processor? |
| 22:08:31 | *** ada_ has quit IRC |
| 22:53:48 | *** rafa has quit IRC |
| 22:57:42 | *** wyclif has joined #openmrs |
| 23:05:04 | *** rafa_ has quit IRC |
| 23:13:04 | <djazayeri> wyclif: do you know who fixed the authenticatedUser == null bug? |
| 23:13:49 | <wyclif> djazayeri, daniel |
| 23:14:17 | <djazayeri> darn, I was hoping it was you. :-) |
| 23:14:25 | <wyclif> djazayeri, why? |
| 23:14:40 | <djazayeri> I've hit a related bug after applying the TRUNK-2588 code |
| 23:15:06 | <wyclif> !ticket TRUNK-2588 |
| 23:15:07 | <OpenMRSBot> wyclif: [#TRUNK-2588] Generic mechanism for doing Attributes and Attribute Types on many classes. (Review code, and Refactor.) - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2588 |
| 23:15:33 | <wyclif> djazayeri, and you haven'y yet updated to include his changes? |
| 23:15:36 | <djazayeri> it happens during performWebStartOfModules -> saveToMemento (from scheduler, I think) -> AuditableInterceptor NPE for setting changedBy = null |
| 23:16:22 | <djazayeri> Looks like there's some other scenario when things get saved and it doesn't go through Daemon user. |
| 23:16:34 | <wyclif> djazayeri, correct |
| 23:16:43 | <wyclif> djazayeri, i noticed that |
| 23:17:19 | <wyclif> djazayeri, i did alot of investigation on that bug, and i think the fix daniel committed is not fully inclusive of the scenarios i imagined |
| 23:17:49 | <djazayeri> any idea what "boolean setNullOnly" is in AduitableInterceptor.setValue? |
| 23:19:07 | <wyclif> djazayeri, my assumption is because the same methods is used when setting created and changes |
| 23:19:10 | <wyclif> djazayeri, my assumption is because the same methods is used when setting created and changed |
| 23:21:07 | <wyclif> djazayeri, that setValue methods seems strange |
| 23:21:44 | <djazayeri> wyclif: I don't know why this problem just popped up for me (I'm trying to do a clean install and new db, with my new code) |
| 23:22:36 | <wyclif> djazayeri, i honestly don't get it why he has setNullOnly |
| 23:23:07 | <djazayeri> wyclif: but it looks like the problem here is that during WebModuleUtil.refreshWAC, we get a call to TimerSchedulerServiceImpl.saveToMemento that doesn't come from a daemon thread. and it's not authenticated either. |
| 23:23:23 | <djazayeri> burke: ping |
| 23:23:38 | <djazayeri> you're the one with strongest opinions about daemons. :-) |
| 23:24:09 | <wyclif> djazayeri, correct, samething when saving the last execution date an when scheduling a task at stssrtup |
| 23:24:23 | <djazayeri> wyclif: do you know how it got fixed in that case? |
| 23:24:31 | <wyclif> djazayeri, and daniel's changeset only fixes setting last execution date |
| 23:24:33 | <djazayeri> was it just making sure the task was scheduled by the daemon thread? |
| 23:24:44 | <djazayeri> or was it a hack specifically for setting that value? |
| 23:24:53 | <wyclif> djazayeri, i talked about this with burke |
| 23:25:47 | <wyclif> djazayeri, and the solution is to make sure that all calls to the API at startup that need to run on the daemon thread |
| 23:27:29 | <wyclif> djazayeri, the changeset to me is only solving a smaller portion of the bigger problem |
| 23:27:37 | <djazayeri> wyclif: yup |
| 23:28:20 | <wyclif> djazayeri, the change has to be with both the daemon thread and the Listener |
| 23:28:58 | <djazayeri> wyclif: yeah, so the problem I'm seeing is that not everything happening at startup is a scheduled task |
| 23:29:03 | <djazayeri> or a service startup |
| 23:29:16 | <wyclif> djazayeri, i.e the listener has to be able to call the Daemon thread to run the scheduler service to start tasks at startip |
| 23:30:29 | <djazayeri> wyclif: but the Daemon knows how to execute tasks, so that's generally a solvable problem |
| 23:30:47 | <djazayeri> we just need to be saying Daemon.executeTask(task) instead of task.execute() |
| 23:31:03 | <wyclif> djazayeri, the daemon thread knows how to start a task but not how to shedule a task |
| 23:31:21 | <wyclif> djazayeri, right now start logic schedules tasks and not start them |
| 23:31:30 | <djazayeri> ah, interesting |
| 23:32:14 | <wyclif> djazayeri, so some of the questions that come up are, do we want the daemon thread to schedule tasks? |
| 23:32:50 | <wyclif> djazayeri, do we want to pass a task instance to the daemon to start(NOT GOOD AT ALL) |
| 23:33:22 | <djazayeri> The simple solution would just be to allow Daemon.runInNewDaemonThread(Runnable) to be used whenever you want. |
| 23:33:35 | <djazayeri> But burke has forbidden this. |
| 23:34:01 | <wyclif> djazayeri, or the listener registers tasks at start up and calls the daemon thread, passed to it the task id, the daemons looks in the registered task for its existence and than scehdules it |
| 23:35:09 | <wyclif> djazayeri that would mean i can start a destructive runnable instance using the daemon |
| 23:35:18 | <wyclif> djazayeri, from a module |
| 23:35:39 | <djazayeri> wyclif: yeah, but modules can be arbitrarily destructive if they're malicious anyway. |
| 23:37:14 | <wyclif> djazayeri, yeah |
| 23:38:04 | <djazayeri> wyclif: okay, I think I'm going to put a hack in place for now, and deal with it during code review or scrum tomorrow |
| 23:39:31 | <wyclif> djazayeri, agreed |
| 23:56:04 | <djazayeri> wyclif: btw, the sprint dashboard really should have an "available tickets" widget at the top leftâwe've all gotten used to looking there, I assume. |
| 23:56:32 | <wyclif> djazayeri, ok |
| 23:57:28 | <wyclif> i copied the 1.9 beta dashboard |