IRC Chat : 2011-11-30 - OpenMRS

00:24:38 *** jriley has joined #openmrs
00:33:55 *** batkinson has quit IRC
02:16:28 *** djazayeri has quit IRC
03:53:07 *** jriley has quit IRC
03:54:06 *** bwolfe has joined #openmrs
03:54:06 *** ChanServ sets mode: +o bwolfe
04:14:52 *** srinivasa has joined #openmrs
04:16:55 <srinivasa> bwolfe: we are trying to write test cases for our module .Its using ant build tool..and we would like to add unit testing code..could you please let us the appropriate directory structure for tests source code.
04:22:22 <bwolfe> srinivasa, its easier if you use a mavenized module
04:22:34 <bwolfe> srinivasa, check out the formentry module branch "1.7-compatible"
04:22:44 <bwolfe> I think that is an ant based one that has unit tests
04:22:52 <bwolfe> srinivasa, and there is a wiki page for module unit testing
04:22:57 <bwolfe> gotta run, bbl
04:23:59 <srinivasa> bwolfe: thanks
05:18:55 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Form Flowsheet 1.2.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=htmlformflowsheet&ampversion=&amp1.2.2>
05:26:34 *** chopin_ has joined #openmrs
05:27:04 *** chopin has joined #openmrs
05:28:49 *** kishoreyekkanti has joined #openmrs
05:33:45 *** chopin has quit IRC
06:06:22 *** jwishnie has quit IRC
06:16:19 *** djazayeri has joined #openmrs
06:16:19 *** ChanServ sets mode: +o djazayeri
07:10:46 *** srinivasa has quit IRC
07:20:47 *** kishoreyekkanti_ has joined #openmrs
07:23:25 *** kishoreyekkanti has quit IRC
07:23:25 *** kishoreyekkanti_ is now known as kishoreyekkanti
08:02:39 *** dkayiwa has joined #openmrs
08:50:39 *** rafa has joined #openmrs
08:50:39 *** ChanServ sets mode: +v rafa
09:29:22 *** dkayiwa_ has joined #openmrs
09:30:55 *** dkayiwa has quit IRC
09:30:56 *** dkayiwa_ is now known as dkayiwa
09:41:42 *** jwishnie has joined #openmrs
09:47:39 *** dkayiwa_ has joined #openmrs
09:49:24 *** dkayiwa has quit IRC
09:49:25 *** dkayiwa_ is now known as dkayiwa
09:56:55 *** kishoreyekkanti_ has joined #openmrs
09:58:56 *** kishoreyekkanti has quit IRC
09:58:56 *** kishoreyekkanti_ is now known as kishoreyekkanti
10:03:03 *** kishoreyekkanti_ has joined #openmrs
10:05:08 *** kishoreyekkanti has quit IRC
10:05:08 *** kishoreyekkanti_ is now known as kishoreyekkanti
10:15:46 <dkayiwa> hi rafa
10:15:56 <rafa> hi Daniel
10:16:03 <dkayiwa> rafa: how is it going?
10:16:11 <rafa> good :)
10:16:15 <dkayiwa> good
10:19:39 <rafa> dkayiwa: do you know if we backport tickets right away to 1.9 or at the end of this sprint?
10:20:52 <dkayiwa> rafa: after a ticket is ready to close (reviewed and OKed), we backport immediately before closing it.
10:21:27 <rafa> dkayiwa: I see
10:21:32 <dkayiwa> yes
10:22:44 *** jwishnie has quit IRC
10:22:53 <bwolfe> you can backport before being reviewed if you want...but if there are changes it just means an extra commit
10:23:55 <dkayiwa> bwolfe: why would you hurry (what advantage) to backport before review? :)
10:25:04 <bwolfe> if you have confidence there won't be any suggested changes then you don't have to go back and look at hte ticket or have to get the patch off of crucible...you can just generate the patch from svn right before committing and then apply to the other project
10:25:21 <dkayiwa> oh i see!!!
10:25:44 <dkayiwa> i remember having done the same for a ticket i was very sure of :)
10:37:03 <bwolfe> dkayiwa, you need to pick up the pace. You can't have rafa committing and commenting before you all the time. ;-) (re: TRUNK-2889)
10:37:24 <dkayiwa> bwolfe: very very true :D
10:37:40 <dkayiwa> bwolfe: maybe he has a better connection :)
10:38:09 <rafa> dkayiwa: haha
10:38:25 <rafa> dkayiwa: mine is 10 Mbs :D
10:38:27 <bwolfe> well you can count on that
10:38:31 <bwolfe> yeah, see
10:38:42 <bwolfe> what do you have dkayiwa? .5 Mbs?
10:38:53 <bwolfe> rafa, how much do you pay a month for that?
10:39:10 <rafa> bwolfe: around $20
10:39:16 <dkayiwa> bwolfe: 3.7 Mbs
10:39:23 <bwolfe> #&@#*
10:39:40 <bwolfe> wow, dkayiwa, thats a lot faster than I thought you'd have !
10:40:00 <dkayiwa> bwolfe: lollllllll
10:40:05 <bwolfe> I pay $30 to $35 for 512kpbs >:O
10:40:43 <rafa> bwolfe: well but you have better weather :D
10:40:49 <dkayiwa> hahahahahahah
10:41:04 <dkayiwa> in the US or Kenya? :)
10:41:52 <bwolfe> rafa, its cold and rainy here this month
10:42:10 <dkayiwa> rainy here but not cold :)
10:42:14 <bwolfe> between 65 and 70 F
10:42:26 <rafa> bwolfe: that's not cold :P
10:43:16 <bwolfe> its cold for here. rest of the time its a perfect 75 to 85 F
10:43:17 <bwolfe> :-D
10:44:14 <rafa> bwolfe: yeah from my perspective 70 is like nice summer :D
10:45:33 <rafa> bwolfe: I'd give away at least 8 Mbs for your weather ;)
10:47:57 <bwolfe> rafa, ok, you send me some Mbs and I'll send you some degrees
10:48:49 <dkayiwa> :D
10:49:03 <dkayiwa> what an exchange!!! :)
10:49:38 <bwolfe> yeah, I think I'm getting the better end of that deal
10:55:01 *** rafa has quit IRC
10:59:15 *** dkayiwa has quit IRC
11:01:53 *** dkayiwa has joined #openmrs
11:05:08 *** dkayiwa_ has joined #openmrs
11:06:35 *** dkayiwa has quit IRC
11:06:35 *** dkayiwa_ is now known as dkayiwa
11:52:27 <bwolfe> ah, where did rafal go ??
11:52:28 <bwolfe> :-/
11:53:06 <dkayiwa> maybe for lunch :)
11:53:25 <bwolfe> hmm, maybe
11:53:32 <bwolfe> is he 3 hours behind us? or just 2?
11:53:39 <dkayiwa> i have no idea
11:53:42 <bwolfe> dkayiwa, http://buea.openmrs.org:8080/openmrs/openmrs-standalone-1.8.3.zip
11:53:56 <bwolfe> I built that ON buea with just darius' maven stuff
11:54:03 <dkayiwa> bwolfe: how big? :)
11:54:29 <dkayiwa> oh that is so so so cool!!!
11:54:38 <bwolfe> dkayiwa, ah yes, you have faster internet but are speed capped...
11:54:47 <dkayiwa> lolllllllllll
11:54:54 <bwolfe> looks like its 222 MB
11:55:00 <dkayiwa> lolllllllllllll
11:55:44 <bwolfe> aren't they only 150MB when you build them?? :-/
11:57:09 <dkayiwa> bwolfe: yes when they have no bundled modules apart from logic and when they have the default demo data created by the setup wizard
12:00:16 <bwolfe> oh wait, looks like it packaged in an extra war file I had in there
12:00:20 <bwolfe> I can trim that by 40MB easily :-)
12:00:32 <dkayiwa> lollllllll :)
12:04:50 <bwolfe> dkayiwa, ok, now that link has it at 183MB
12:05:10 <dkayiwa> bwolfe: that now makes alot of sense in size. :)
12:23:08 *** kishoreyekkanti_ has joined #openmrs
12:25:14 *** kishoreyekkanti has quit IRC
12:25:14 *** kishoreyekkanti_ is now known as kishoreyekkanti
12:29:27 *** james_regen has joined #openmrs
12:29:27 *** ChanServ sets mode: +v james_regen
13:17:35 *** wyclif has quit IRC
13:23:11 *** kishoreyekkanti_ has joined #openmrs
13:25:03 *** kishoreyekkanti has quit IRC
13:25:04 *** kishoreyekkanti_ is now known as kishoreyekkanti
13:39:00 *** chopin has joined #openmrs
13:45:30 *** dkayiwa has quit IRC
13:45:33 *** dkayiwa_ has joined #openmrs
14:09:11 *** wyclif has joined #openmrs
14:14:38 *** downeym has joined #openmrs
14:14:38 *** OpenMRSBot sets mode: +o downeym
14:14:38 *** ChanServ sets mode: +o downeym
14:28:08 *** kishoreyekkanti has quit IRC
14:34:19 *** bwolfe has quit IRC
14:57:09 <djazayeri> downeym: Dave sent me the presentation via skype, so I showed it that way
14:57:25 <djazayeri> Is the youtube url a permanent one?
14:57:46 <downeym> djazayeri: hi, good, yes it's permanent although i need to do some other things with it still
14:57:58 <djazayeri> okay, but I can paste the url in the call notes
14:58:03 <downeym> djazayeri: yeah sure
14:58:09 <djazayeri> great, thanks!
14:59:31 *** kishoreyekkanti has joined #openmrs
15:00:04 *** jriley has joined #openmrs
15:01:04 *** jwishnie has joined #openmrs
15:14:05 *** dkayiwa_ has quit IRC
15:15:59 *** robbyoconnor has quit IRC
15:17:23 *** dkayiwa has joined #openmrs
15:18:42 <wyclif> hi djazayeri
15:18:51 <djazayeri> hi wyclif
15:19:10 <wyclif> can a patient_state have no start date?
15:19:30 <wyclif> djazayeri, sorry! this is the first time i have had to work on anything to do with programs
15:19:56 <djazayeri> wyclif: I think that's allowed. that would mean the state started when the program enrollment started
15:20:07 <djazayeri> or, if that's null also, "at the beginning of time"
15:21:16 <wyclif> djazayeri, thanks
15:25:42 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Spreadsheet Import 0.4 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=spreadsheetimport&ampversion=&amp0.4>
16:16:20 *** nribeka has joined #openmrs
16:16:20 *** ChanServ sets mode: +v nribeka
16:36:15 *** rafa has joined #openmrs
16:36:15 *** ChanServ sets mode: +v rafa
16:39:42 <kishoreyekkanti> djazayeri: Hey darius i have some changes in InitializationFilter and Listener too. These changes are around creating the openmrs-test-runtime.properties if we are running in functional testing mode
16:40:57 <djazayeri> kishoreyekkanti: if it doesn't break anything else, you can commit it for post-commit review
16:41:20 <kishoreyekkanti> djazayeri: sure i'll do that
16:42:05 *** magicaltrout is now known as bugg_tb
16:43:37 *** bugg_tb is now known as magicaltrout
17:12:42 *** rafa has quit IRC
17:23:24 *** dkayiwa has quit IRC
17:49:43 *** bwolfe has joined #openmrs
17:49:43 *** ChanServ sets mode: +o bwolfe
17:52:40 *** r_friedman has joined #openmrs
17:52:55 <downeym> Hi r_friedman and welcome to the #openmrs IRC channel.
17:53:33 <r_friedman> bwolfe, hi ben, i think i found my problem, i needed to add universe to my sources.list file
17:53:53 <bwolfe> r_friedman, why wasn't it there already?
17:54:11 <r_friedman> bwolfe, don't know, doc says it should be but it wasn't
17:56:05 *** rafa has joined #openmrs
17:56:05 *** ChanServ sets mode: +v rafa
18:03:27 *** dawn_ has joined #openmrs
18:03:38 *** ChanServ sets mode: +v dawn_
18:04:20 *** robbyoconnor has joined #openmrs
18:04:20 *** ChanServ sets mode: +v robbyoconnor
18:06:29 <dawn_> bwolfe: djazayeri wyclif rafa : scrum time
18:07:01 <bwolfe> yeah, lets scrum it
18:07:38 *** r0bby has joined #openmrs
18:07:38 *** ChanServ sets mode: +v r0bby
18:08:01 <rafa> Hi, I've got a system failure. I'm on my mobile :/
18:08:09 <dawn_> bwolfe: you want to go first?
18:08:09 <wyclif> hi
18:08:49 <bwolfe> dawn_, didn't I go "first" yesterday? :-p
18:09:03 <dawn_> bwolfe: no, kayiwa went first :P
18:09:05 <bwolfe> dkayiwa beat me to it...looks like he's not here to jump in front of me today
18:09:11 <dawn_> :)
18:10:04 <bwolfe> today was a lot like yesterday. a lot of sprint reviews, applied some patches, backported a few things. I got the standalone to compile finally
18:10:19 *** robbyoconnor has quit IRC
18:10:20 <rafa> I'll be back later guys or email my update.
18:10:21 <bwolfe> I still have 4 hours of work left today too :-/
18:10:36 <bwolfe> rafa, sad. hdd crash?
18:10:58 <bwolfe> rafa, you don't want to type out your update from your phone?
18:11:12 <rafa> No seems like os
18:11:15 <bwolfe> compiled standalone is here: darius/dawn/wyclif, want to test it out for me? buea.openmrs.org:8080/openmrs/openmrs-standalone-1.8.3.zip
18:11:24 <bwolfe> rafa, well, time to upgrade it!
18:11:28 <bwolfe> ubuntu here you come!
18:12:41 <dawn_> wyclif: you want to go next?
18:13:02 <wyclif> bwolfe, did you use the plugin darius put together?
18:13:43 <djazayeri> hi all
18:13:50 <djazayeri> sorry, misread my calendar
18:14:39 <djazayeri> rafa: hopefully all your code is checked in, or saved in patches
18:14:39 <bwolfe> wyclif, yeah. built it at command line on the buea server
18:14:55 <bwolfe> but saved in patches not on that computer...
18:14:56 <wyclif> bwolfe, cool
18:15:00 <wyclif> yesterday:
18:15:00 <wyclif> -TRUNK-2844 - Auto-created visits populate end time (took me longer than i expected)
18:15:00 <wyclif> today:
18:15:00 <wyclif> -TRUNK-2273 - Avoid Duplicate Rows in Patient_State Table
18:15:00 <wyclif> -Other sprint tickets if any
18:15:36 <bwolfe> djazayeri, is the standalone stuff you wrote at a point you're comfortable releasing as 1.8.3? Or should we still manually create it?
18:15:51 <bwolfe> wyclif, also check to make sure you don't have any reviews outstanding
18:16:12 <djazayeri> bwolfe: well, the choose method is still quite ugly, and has the word TO DO in a couple places
18:16:16 <wyclif> bwolfe, i looked at them
18:16:17 <djazayeri> so at the very lease we should fix that up
18:16:31 <djazayeri> bwolfe: also, it doesn't include the demo data that we've been packaging with standalone.
18:17:11 <djazayeri> so…not ideal yet
18:17:23 <djazayeri> but the alternative is pretty painful
18:17:49 <djazayeri> bwolfe: maybe we should address the really obvious issues (i.e. get rid of the TO DO comments and the inactive button)
18:18:05 <bwolfe> djazayeri, right. the alternative is someone else has to do it...because I can't even get the 30mb war file uploaded from here. dies somewhere in the middle
18:19:23 <djazayeri> bwolfe: you okay releasing just the version with schema-only (e.g. "empty database") and expert mode?
18:19:46 *** r0bby has quit IRC
18:20:19 *** r0bby has joined #openmrs
18:20:19 *** ChanServ sets mode: +v r0bby
18:20:21 <bwolfe> I suppose...but only if we plan on having a 1.8.4 out within a few months. 1.8.2 has been out for 6+ months, so I don't want a lame 1.8.3 around for a long time too
18:20:41 <djazayeri> bwolfe: the improved version of standalone is going to need to be ready for 1.9-release.
18:20:44 <djazayeri> so, sure.
18:21:57 <dawn_> djazayeri: you ready to give your updates?
18:22:14 <wyclif> bwolfe, how ofte do we intend to make minor releases?
18:22:25 <bwolfe> wyclif, as often as needed
18:22:31 <djazayeri> wyclif: note that if you're looking for tickets to work on, I'd ignore the non-essential ones in this sprint, and find something higher-priority to do with the standalone
18:22:57 <djazayeri> bwolfe, wyclif: it'll be much easier when this is all just mvn release
18:23:00 <djazayeri> dawn_: sure
18:23:29 <wyclif> djazayeri, no problem
18:23:36 <djazayeri> Tuesday 29-Nov-2011
18:23:37 <djazayeri> * Working on a project proposal
18:23:37 <djazayeri> * Comment on a few sprint tickets
18:23:37 <djazayeri> * Thoughtworks Code Jam
18:23:37 <djazayeri> Wednesday 30-Nov-2011
18:23:37 <djazayeri> * Working on a project proposal
18:23:38 <djazayeri> * University Call
18:23:38 <djazayeri> * Design Call
18:23:39 <djazayeri> * Project Management Call
18:23:39 <djazayeri> no blockers
18:24:03 <wyclif> djazayeri, sure
18:26:07 <wyclif> djazayeri, bwolfe, when soon do you think you can review CR-TRUNK-602 - auto closing visits, i guess i could have implemented things differently somewhere
18:26:08 *** dkayiwa has joined #openmrs
18:26:28 <wyclif> djazayeri, bwolfe, sorry! how soon?
18:27:02 <djazayeri> at some point
18:27:06 <djazayeri> kind of slammed now
18:28:01 <bwolfe> I can look at it now wyclif
18:28:16 <wyclif> bwolfe, great
18:28:17 <bwolfe> dkayiwa, your update?
18:30:31 <wyclif> bwolfe, djazayeri i guess my question is, is the task supposed to close all active visits or just the ones that were opened that day
18:30:32 <dkayiwa> Committed: Unable to find patients if their name is less than 3 characters - TRUNK-222
18:30:32 <dkayiwa> Did some ticket administration (back porting, applying patches, and checking on ticket status)
18:30:33 <dkayiwa> Thinking of choosing one of the remaining non essential tickets to work on next
18:30:33 <dkayiwa> No Blockers
18:31:11 <djazayeri> dkayiwa: instead of the non-essential tickets, I recommend finding something to do related to the standalone
18:31:16 <bwolfe> wyclif, all active visits of the given visit type. if the task is run daily then it will turn out to be only ones opened that day :-p
18:31:37 <wyclif> bwolfe, ok
18:31:41 <dkayiwa> djazayeri: do you have any in mind?
18:31:53 <djazayeri> One thing (that needs a ticket) is to find a scripted way to create the -with-demo-data database
18:32:28 <djazayeri> one option is to create a liquibase script based on the demo dataset. (Not just the 2-patient one, but the hundreds-of-patients one)
18:32:43 <djazayeri> I haven't considered other options
18:33:00 <djazayeri> dkayiwa: then we could have building the standalone create both emptydatabase.zip and demodatabase.zip
18:33:18 <dkayiwa> djazayeri: ok
18:33:36 <djazayeri> Another option: make the choose-installation-mode dialog in the standalone be less ugly
18:33:40 <dawn_> rafa: do you want to send your updates via email when you have a chance?
18:33:41 <wyclif> djazayeri, do you have these tasks ticketed yet
18:33:45 <djazayeri> e.g. add images instead of the ugly color I've got.
18:34:02 <djazayeri> wyclif: the demo data one is not ticketed yet
18:34:02 <wyclif> djazayeri, would be nice if you did
18:34:39 <djazayeri> wyclif: I can paste what I just typed here into a ticket, yes. :-)
18:35:15 <wyclif> djazayeri, that would be great
18:36:32 <rafa> dawn_: yes, I'll email my update when I recover
18:37:58 *** downeym_ has joined #openmrs
18:37:58 *** ChanServ sets mode: +o downeym_
18:38:13 *** downeym has quit IRC
18:38:13 *** downeym_ is now known as downeym
18:39:41 <djazayeri> bwolfe: you got the standalone building with 64-bit binaries?
18:39:49 <djazayeri> or how did you solve the build-on-buea problem?
18:40:35 <bwolfe> djazayeri, yeah, I don't know what was going on. I did two things: changed the pom.xml to point at 5.0.12 instead of 5.0.11.
18:40:35 *** rafa has quit IRC
18:40:43 <bwolfe> but I also found an oddity with where it was building
18:41:34 <bwolfe> it was putting emptydatabase into the root dir instead of in target.
18:41:34 <bwolfe> so I renamed the one in root and then it started using a new (correct) one in target.
18:41:34 <bwolfe> from then on it worked fine
18:41:56 <djazayeri> hmm, okay
18:43:16 <djazayeri> bwolfe: did you make a version-free splash png?
18:43:33 <djazayeri> if so, can you close https://tickets.openmrs.org/browse/STAND-21
18:43:43 <bwolfe> I did, and I think I committed it...
18:43:43 * bwolfe checks
18:45:13 <bwolfe> djazayeri, the Help Link part of that isn't done, is it?
18:45:30 <djazayeri> no idea
18:48:15 *** r0bby has quit IRC
18:53:15 <kishoreyekkanti> djazayeri: for a review on formentry module, who can be the reviewers?
18:53:29 <djazayeri> jeremy keiper, ben wolfe
18:53:35 <kishoreyekkanti> djazayeri: thank you
18:56:20 <djazayeri> dkayiwa: do you know why rafa has 5 tickets In Progress?
18:56:30 <djazayeri> during this sprint
18:56:34 <dkayiwa> djazayeri: let me check
18:56:36 *** suranga has joined #openmrs
18:58:13 <suranga> hi james_regen
18:58:13 <suranga> r u there ?
18:58:46 *** r0bby has joined #openmrs
18:58:46 *** ChanServ sets mode: +v r0bby
18:58:56 <bwolfe> djazayeri, a lot of them I have thrown back to him after review for backporting
18:59:44 <djazayeri> bwolfe: since he's got a blocker ticket (trunk-2588) and he's having computer trouble, perhaps someone else should pick up those tickets for backporting.
18:59:54 <djazayeri> wyclif, dkayiwa: ^^
19:00:07 <dkayiwa> djazayeri: ok
19:03:43 *** wyclif has quit IRC
19:05:27 <bwolfe> @#@$ you freeconferencing
19:09:11 *** r_friedman has quit IRC
19:09:14 *** nribeka has quit IRC
19:10:02 *** kishoreyekkanti has left #openmrs
19:15:41 *** wyclif has joined #openmrs
19:17:26 <bwolfe> dawn_, whats the status of getting a better replacement for freeconferencing?
19:17:41 <downeym> bwolfe: replacement = $
19:17:48 *** dkayiwa_ has joined #openmrs
19:17:50 <bwolfe> yes, I realize that
19:18:15 <bwolfe> but we won't get any good involvement on calls from non-us-based devs until we have something we can count on
19:18:29 *** dkayiwa has quit IRC
19:18:29 *** dkayiwa_ is now known as dkayiwa
19:18:34 <bwolfe> freeconf skype is now down more often than it is up
19:19:50 <downeym> bwolfe: what's the latest status of adobe connect voice compatibility with linux?
19:20:26 <bwolfe> downeym, crappy
19:20:31 <bwolfe> works with 32 bit I think
19:20:41 <bwolfe> I've yet to get it to work on my system though
19:21:03 <downeym> bwolfe: let me check with them on the upgrade date
19:21:45 *** dawn_ has quit IRC
19:23:53 <downeym> bwolfe: actually, supposedly there is a 64-bit .deb that works with 8.1. http://www.connectusers.com/news/index.php?cmd=display_news&id=2702
19:23:59 <OpenMRSBot> <http://ln-s.net/9OVX> (at www.connectusers.com)
19:24:14 <downeym> bwolfe: i'm not sure that's accurate, though
19:24:29 *** nribeka has joined #openmrs
19:24:29 *** ChanServ sets mode: +v nribeka
19:27:11 <bwolfe> downeym, I have that one already
19:27:23 <downeym> bwolfe: i have a feeling they just wrote their docs poorly
19:28:16 <bwolfe> which docs?
19:28:38 <james_regen> suranga: hi, i'm here
19:29:13 <suranga> james_regen, hi,aorry for the delay
19:29:32 <suranga> james_regen, Ada has asked me to help with anothet AMOPATH installatiion ?
19:29:33 <downeym> bwolfe: "This Add-in is not required for Adobe Connect 8 SP2 and is completely optional." I took that to mean starting with SP2 it wasn't necessary. But instead it seems that it means you can still use SP2 without it.
19:31:10 <james_regen> suranga: did she? which email was that in?
19:32:15 <suranga> james_regen, hmm.. I see you are not cc'd :(
19:32:49 <suranga> its for the Port Victoria HCT OpenMRS installation
19:35:06 <james_regen> suranga: using the patient matching module there?
19:49:35 *** suranga has quit IRC
19:57:18 *** rafa has joined #openmrs
19:57:18 *** ChanServ sets mode: +v rafa
20:25:20 *** rafa has quit IRC
20:25:49 *** james_regen has quit IRC
20:26:55 *** rafa has joined #openmrs
20:26:55 *** ChanServ sets mode: +v rafa
20:35:06 <wyclif> hi bwolfe
20:36:02 <bwolfe> hi wyclif
20:37:23 <wyclif> bwolfe, saw your comments for TRUNK-2844
20:38:33 <wyclif> i have added a comment to the coed review and i'm waiting for your view
20:44:52 *** r0bby has quit IRC
20:58:49 *** downeym_ has joined #openmrs
20:58:49 *** ChanServ sets mode: +o downeym_
20:59:08 *** jriley has quit IRC
20:59:30 *** downeym has quit IRC
20:59:30 *** downeym_ is now known as downeym
21:00:06 <wyclif> hi djazayeri
21:00:13 <djazayeri> hi wyclif
21:01:10 <wyclif> djazayeri, do you prefer that i invoke the patientprogram validator before calling save or inside the save method?
21:02:36 <wyclif> currently i only see reference to save method in the controller and the dwr service
21:02:44 <wyclif> djazayeri, currently i only see reference to save method in the controller and the dwr service
21:05:36 <djazayeri> wyclif: soon rafal will be calling it automatically
21:06:04 <djazayeri> so you don't need to do it in the service
21:06:16 <wyclif> djazayeri, will that be part of 1.9?
21:06:20 <djazayeri> wyclif: yes
21:07:34 <wyclif> djazayeri, i guess now the question should still invoke it in the web controller?
21:07:41 <djazayeri> wyclif: yes
21:07:46 <wyclif> ok thanks
21:08:02 <djazayeri> in the web controller you should call the validator manually, and display error messages nicely.
21:08:22 <djazayeri> wyclif: in DWR I don't think it's necessary
21:09:01 <djazayeri> or rather, you can write a reusable util method that will use validateUtil, and prettify the output error for DWR
21:09:41 <wyclif> ok, do you of any place which use the patientprograms portlet
21:10:15 <djazayeri> wyclif: the dashboard
21:10:56 <wyclif> the dashboard has programs and not patient programs
21:11:36 <wyclif> i always assumed patient programswas a subclass of program
21:13:23 *** burke has joined #openmrs
21:13:23 *** ChanServ sets mode: +o burke
21:35:50 *** rafa has quit IRC
21:37:22 *** rafa has joined #openmrs
21:37:22 *** ChanServ sets mode: +v rafa
21:40:04 <wyclif> djazayeri, am looking at <prop key="admin/programs/patientProgram.form">patientProgramFormController</prop>
21:40:28 <wyclif> djazayeri, i think there is something wrong with this mapping
21:40:48 <djazayeri> wyclif: on a call now. i don't know what that admin page is offhand
21:40:56 *** dkayiwa has quit IRC
21:41:01 <wyclif> djazayeri, ok
21:41:03 <wyclif> hi bwolfe
21:41:16 <bwolfe> hi
21:41:30 *** chopin has quit IRC
21:42:53 <djazayeri> wyclif: what is that controller used for?
21:42:56 <djazayeri> how do you get to it?
21:43:12 <wyclif> djazayeri, what do you mean
21:43:34 <djazayeri> wyclif: is that an administrative page that is no longer accessible from anywhere?
21:43:58 <wyclif> seems to me
21:44:26 <wyclif> i see Program being used in places where i expected PatientProgram
21:44:51 <wyclif> the portlet is called a patientprograms portlet but it is programportlet
21:45:55 <bwolfe> wyclif, patientprograms are the mapping from patient to program
21:46:06 <bwolfe> so its how you define which programs a patient is in
21:46:19 <bwolfe> so the portlet ot control the patient's programs is called patientProgram.jsp
21:46:40 <wyclif> bwolfe, got you
21:50:20 <wyclif> bwolfe, then we that url mapping in web.xml seems to be unsed
21:50:26 <wyclif> bwolfe, unused
21:50:34 <bwolfe> what url?
21:55:02 <wyclif> <prop key="admin/programs/patientProgram.form">patientProgramFormController</prop>
21:55:26 <bwolfe> thats not in web.xml
21:55:35 <wyclif> sorry openmrs-servelt
21:55:38 <bwolfe> thats in openmrs-servlet?
21:55:39 <wyclif> sorry openmrs-servlet
21:55:41 <bwolfe> ok
21:57:07 <bwolfe> why is it not used?
22:05:15 <wyclif> probably it is but it doesn't work for me
22:07:59 *** nribeka has quit IRC
22:13:59 *** mnunez has joined #openmrs
22:15:16 *** burke has quit IRC
22:27:04 *** wyclif has quit IRC
22:38:38 *** rafa has quit IRC
22:44:25 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Near San Francisco, California? Check out the next Bay Area Open Source Code Jam and help #OpenMRS: http://t.co/y0taKAf8 <http://twitter.com/OpenMRS/statuses/142004505611993088>
23:16:31 *** downeym has quit IRC
23:26:36 *** wyclif has joined #openmrs