| 02:38:57 | *** srinivasa has quit IRC |
| 03:29:21 | *** upul` has joined #openmrs |
| 03:29:21 | *** ChanServ sets mode: +v upul` |
| 03:44:44 | *** djazayeri has quit IRC |
| 03:51:12 | *** mathiasl_ has joined #openmrs |
| 04:06:39 | *** robbyoconnor has quit IRC |
| 04:16:57 | *** robbyoconnor has joined #openmrs |
| 04:16:57 | *** ChanServ sets mode: +v robbyoconnor |
| 04:32:21 | *** mathiasl_ has quit IRC |
| 04:32:32 | *** surangak has joined #openmrs |
| 04:32:43 | *** mathiaslin has joined #openmrs |
| 05:16:51 | *** djazayeri has joined #openmrs |
| 05:16:51 | *** ChanServ sets mode: +o djazayeri |
| 05:46:59 | *** srinivasa has joined #openmrs |
| 05:49:06 | <srinivasa> djazayeri: Do we need to create a new branch for populating active lists module or just commit to the trunk |
| 05:57:12 | <djazayeri> srinivasa: A module shouldn't require any commits to trunk |
| 05:57:39 | <djazayeri> you would commit it to the openmrs-modules section of our svn repo |
| 07:18:19 | *** bryq has joined #openmrs |
| 07:18:19 | *** ChanServ sets mode: +v bryq |
| 07:21:16 | *** dkayiwa has joined #openmrs |
| 07:35:14 | *** srinivasa has quit IRC |
| 07:45:10 | *** Echidna_ has quit IRC |
| 07:45:42 | *** Echidna has joined #openmrs |
| 07:45:42 | *** ChanServ sets mode: +v Echidna |
| 07:53:49 | *** mathiaslin has quit IRC |
| 07:57:48 | *** dkayiwa has quit IRC |
| 08:04:22 | *** bryq has left #openmrs |
| 08:06:09 | *** dkayiwa has joined #openmrs |
| 08:25:26 | <OpenMRSBot> Recent updates in the world of openmrs: Shazin Sadakath: Java Source Code Hiding <http://shazsterblog.blogspot.com/2011/11/java-source-code-hiding.html> |
| 08:28:58 | *** rafa has joined #openmrs |
| 08:28:58 | *** ChanServ sets mode: +v rafa |
| 08:39:02 | <dkayiwa> hi rafa |
| 08:39:10 | <rafa> hi djazayeri |
| 08:39:12 | <rafa> hi dkayiwa |
| 08:39:13 | <rafa> :) |
| 08:39:18 | <dkayiwa> :D |
| 08:39:37 | <dkayiwa> rafa: when deleting a visit, is delete reason supposed to be optional? |
| 08:40:18 | <rafa> you mean voiding? |
| 08:40:24 | <dkayiwa> rafa: yes |
| 08:40:38 | <rafa> dkayiwa: probably it shouldn't be |
| 08:40:42 | <dkayiwa> ok |
| 08:40:48 | <rafa> dkayiwa: as all our voiding reasons :) |
| 08:41:00 | <dkayiwa> rafa: sure :) |
| 08:41:29 | <dkayiwa> rafa: by the way, how far are you with the other fix which took me close to a whole day and still failed? |
| 08:41:39 | <dkayiwa> rafa: about autocomplete widget |
| 08:41:41 | <dkayiwa> :) |
| 08:41:55 | <rafa> dkayiwa: yeah, I fought with it for a while, but with no avail either |
| 08:42:07 | <rafa> dkayiwa: it's tricky |
| 08:42:12 | <dkayiwa> rafa: am very interested in the solution for am sure it will ashame me :) |
| 08:42:19 | <dkayiwa> oh i see |
| 08:42:35 | <rafa> dkayiwa: it's no one-liner from what I see :( |
| 08:42:48 | <dkayiwa> ohhhhhhh |
| 08:43:32 | <rafa> dkayiwa: a real select needs to be triggered for the default value |
| 08:43:50 | <dkayiwa> rafa: ok |
| 08:44:02 | <rafa> dkayiwa: instead of the faked method we have which sets only field values |
| 08:44:29 | <dkayiwa> rafa: ok, makes sense |
| 08:45:04 | <rafa> dkayiwa: I need to work on a higher priority ticket today |
| 08:45:17 | <dkayiwa> rafa: which one is that? |
| 08:45:52 | <rafa> dkayiwa: TRUNK-2588 and TRUNK-2015 |
| 08:45:58 | <dkayiwa> ok |
| 08:46:13 | <rafa> dkayiwa: they're connected |
| 08:46:17 | <dkayiwa> ok |
| 08:46:46 | <rafa> dkayiwa: anyway I'll try TRUNK-2889 again when I'm free again |
| 08:47:13 | <dkayiwa> rafa: ok :) |
| 10:04:31 | *** dkayiwa has quit IRC |
| 10:12:10 | *** dkayiwa has joined #openmrs |
| 10:17:40 | *** rafa has quit IRC |
| 10:30:29 | *** rafa has joined #openmrs |
| 10:30:37 | *** ChanServ sets mode: +v rafa |
| 10:46:14 | *** dkayiwa_ has joined #openmrs |
| 10:46:32 | *** dkayiwa has quit IRC |
| 10:46:32 | *** dkayiwa_ is now known as dkayiwa |
| 10:55:54 | *** robbyoconnor has quit IRC |
| 10:59:39 | *** surangak has quit IRC |
| 12:08:28 | *** dkayiwa has quit IRC |
| 12:16:42 | *** pascal` has joined #openmrs |
| 12:16:42 | *** ChanServ sets mode: +v pascal` |
| 12:17:01 | <pascal`> rafa, did you ever solve this: https://wiki.openmrs.org/display/IRC/2011-08-19+-+OpenMRS#124603 ? |
| 12:19:12 | <rafa> pascal`: I think bryq was using wrong package |
| 12:19:50 | <rafa> pascal`: I mean forms exported with 0.8.x are not compatible with 0.10.x |
| 12:20:16 | *** james_regen has joined #openmrs |
| 12:20:16 | *** ChanServ sets mode: +v james_regen |
| 12:21:16 | <pascal`> rafa, I'm trying to import the "HIV Adult" from here: https://wiki.openmrs.org/display/RES/Form+Bank |
| 12:22:12 | <pascal`> rafa, I'm running 1.6.1.12909, metadata 0.8.1.8, htmlformentry 1.7.3.999 and serialization 0.2.5. |
| 12:22:23 | <rafa> pascal`: you need to use versions of htmlform and mds listed in the last column |
| 12:22:53 | <rafa> pascal`: 1.7.3 might no longer include the shareablehtmlfform class |
| 12:23:41 | <pascal`> rafa, Okay, I'll try with 1.7.2. |
| 12:24:16 | <rafa> pascal`: you could also ask Ellen to export the form with the latest mds and htmlformentry :) |
| 12:25:20 | <pascal`> pascal`, I don't think I'll have time for that. In any case, I'm working from a clone of a prod system, so it's not easy to just change things out. |
| 12:27:27 | <rafa> pascal`: if you at least can update mds it's easy to convert the package manually to a newer version |
| 12:28:57 | <pascal`> rafa, Installing 1.7.2 solved the first issue, now I have http://pastebin.com/du7CU2Ax when I click import (to confirm). |
| 12:28:58 | *** kishoreyekkanti has joined #openmrs |
| 12:30:11 | <rafa> pascal`: it's a bug in OpenMRS |
| 12:30:26 | <rafa> pascal`: it was fixed in later rev |
| 12:30:39 | *** wyclif has quit IRC |
| 12:31:47 | <pascal`> rafa, Okay, thanks. |
| 12:45:41 | *** upul` has quit IRC |
| 12:57:33 | *** pascal` has quit IRC |
| 13:26:25 | *** wyclif has joined #openmrs |
| 13:58:23 | *** jriley has joined #openmrs |
| 14:17:09 | *** kishoreyekkanti_ has joined #openmrs |
| 14:18:55 | *** kishoreyekkanti has quit IRC |
| 14:18:55 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 14:19:54 | *** downeym has joined #openmrs |
| 14:19:54 | *** ChanServ sets mode: +o downeym |
| 14:19:54 | *** OpenMRSBot sets mode: +o downeym |
| 14:51:07 | *** kishoreyekkanti_ has joined #openmrs |
| 14:53:18 | *** kishoreyekkanti has quit IRC |
| 14:53:18 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 14:55:37 | *** kishoreyekkanti_ has joined #openmrs |
| 14:57:40 | *** kishoreyekkanti has quit IRC |
| 14:57:40 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 15:07:34 | *** kishoreyekkanti has quit IRC |
| 15:13:38 | *** gasore has joined #openmrs |
| 15:13:50 | <downeym> Hi gasore and welcome to the #openmrs IRC channel. |
| 15:15:08 | <gasore> thx d |
| 15:16:11 | *** rafa has quit IRC |
| 15:28:23 | *** gasore has quit IRC |
| 16:01:39 | <magicaltrout> hih guys, i've got some details from gretchen about starting up a openmrs instance that she wants to use for getting openmrs working nicely with pentaho, anyway the instructions I have are nice and detailed but i cant get it to register (as i'm a newb) |
| 16:01:54 | <magicaltrout> she told me to paste a load of stuff into the implementation boxes |
| 16:01:57 | <magicaltrout> and i get |
| 16:02:19 | <magicaltrout> Implementation ID could not be set. |
| 16:02:20 | <magicaltrout> org.openmrs.api.APIException: Your implementation id is in use by another installation. Please choose another source key or enter the valid passphrase for this source id. Note: The server stored description of the given passphrase is: |
| 16:03:20 | <magicaltrout> any pointers? :) |
| 16:06:46 | *** burke has joined #openmrs |
| 16:06:46 | *** ChanServ sets mode: +o burke |
| 16:06:53 | *** burke has left #openmrs |
| 16:07:08 | *** burke has joined #openmrs |
| 16:07:08 | *** ChanServ sets mode: +o burke |
| 16:19:59 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: We're excited to welcome our newest #OpenMRS sites in #Douala and Mfou, #Cameroon - congratulations! http://t.co/QT5I2n8u #HealthIT #ICT4D <http://twitter.com/OpenMRS/statuses/141183274318958594> |
| 16:26:03 | *** pascal` has joined #openmrs |
| 16:26:03 | *** ChanServ sets mode: +v pascal` |
| 16:26:41 | <pascal`> djazayeri, ever seen this: You must include either conceptId or conceptIds in an obs tag |
| 16:26:55 | *** jriley has left #openmrs |
| 16:27:30 | <pascal`> djazayeri, I downgraded from htmlforms from 1.7.3.999 to 1.7.2 so that I could use metadata sharing and now (I suppose not surprisingly) my existing forms are b0rked =\ |
| 16:35:05 | <pascal`> for those interested in a solution, "conceptId" is case sensitive in htmlforms 1.7.2. |
| 16:35:14 | <djazayeri> pascal`: ah, yes |
| 16:36:36 | * pascal` googles regex replace in mysql column (: |
| 16:38:30 | *** dkayiwa has joined #openmrs |
| 16:44:46 | *** kishoreyekkanti has joined #openmrs |
| 16:47:05 | *** rafa has joined #openmrs |
| 16:47:05 | *** ChanServ sets mode: +v rafa |
| 17:02:15 | <pascal`> for the logs: pdate htmlformentry_html_form set xml_data = replace(xml_data, 'conceptid', 'conceptId'); |
| 17:02:34 | <pascal`> update htmlformentry_html_form set xml_data = replace(xml_data, 'conceptid', 'conceptId'); |
| 17:04:36 | <kishoreyekkanti> downeym: Hi how are you |
| 17:22:00 | <kishoreyekkanti> downeym: I have done a 20 min screen cast on how to use intellij and github with OpenMRS. Its around 75mb. I want that to be uploaded under OpenMRS channel in youtube |
| 17:22:18 | <downeym> hi kishoreyekkanti :) |
| 17:22:29 | <kishoreyekkanti> downeym: hey hi :) |
| 17:22:41 | <downeym> kishoreyekkanti: that's fantastic. give me a moment and i'll get you an upload link |
| 17:22:55 | <kishoreyekkanti> downeym: sure |
| 17:32:07 | <downeym> kishoreyekkanti: let me know once it's done :) |
| 17:33:26 | *** burke is now known as burke_away |
| 17:42:18 | <kishoreyekkanti> downeym: just now its done |
| 17:44:11 | <kishoreyekkanti> downeym: let me know if you need the decryption password |
| 17:51:47 | *** pascal` has quit IRC |
| 17:54:53 | *** suranga has joined #openmrs |
| 18:11:56 | *** wyclif has quit IRC |
| 18:15:47 | <downeym> kishoreyekkanti: yeah will need it |
| 18:16:10 | *** dawn_ has joined #openmrs |
| 18:16:11 | *** ChanServ sets mode: +v dawn_ |
| 18:20:06 | *** burke_away is now known as burke |
| 18:21:00 | *** wyclif has joined #openmrs |
| 18:21:18 | *** wyclif has joined #openmrs |
| 18:22:19 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @psbrandt: CDN.G fait des journaux avec leur implémentations #OpenMRS dans #Cameroun (photo) http://t.co/ificFC0S #ICT4D <http://twitter.com/OpenMRS/statuses/141213603398299649> || On Twitter: OpenMRS: RT @psbrandt: The CDN.G makes news with their #OpenMRS implementations in their home country (pic) http://t.co/9BnJO2I0 #Cameroon #ICT4D <http://twitter.com/OpenMRS/statuses/141213449245040640> |
| 18:22:51 | *** suranga has quit IRC |
| 18:24:11 | *** suranga has joined #openmrs |
| 18:30:39 | *** bwolfe has joined #openmrs |
| 18:30:39 | *** ChanServ sets mode: +o bwolfe |
| 18:30:51 | <bwolfe> scrum time ? |
| 18:31:03 | <bwolfe> dkayiwa, wyclif, djazayeri, rafa? |
| 18:31:08 | <djazayeri> hi all |
| 18:31:09 | <djazayeri> yup |
| 18:31:19 | <bwolfe> djazayeri, you look a lot more awake for this scrum... |
| 18:31:51 | <djazayeri> feel it too |
| 18:32:13 | <bwolfe> you get your workout in this morning? |
| 18:32:42 | <wyclif> hi |
| 18:32:47 | <djazayeri> nope, but somday. :-) |
| 18:33:03 | <djazayeri> I can give my update quickly |
| 18:33:09 | <djazayeri> Wednesday last week: |
| 18:33:12 | <djazayeri> * Lots of calls |
| 18:33:21 | <djazayeri> * a very small bit of code review and ticket management |
| 18:33:28 | <djazayeri> Today: |
| 18:33:39 | <djazayeri> * working on a project proposal |
| 18:33:47 | <djazayeri> * scoring some applications |
| 18:34:03 | <djazayeri> * only doing anything scrum-related if absolutely necessary, and someone pings me |
| 18:34:07 | <djazayeri> no blockers |
| 18:34:24 | <bwolfe> which project and what applications? |
| 18:34:58 | <djazayeri> project: about OpenMRS as Application |
| 18:35:16 | <djazayeri> applications: for pizzigati prize |
| 18:35:21 | *** suranga_ has joined #openmrs |
| 18:35:32 | *** burke is now known as burke_away |
| 18:37:12 | <rafa> hi |
| 18:38:40 | <bwolfe> djazayeri, I'd like your thoughts on the issue I posted about building the standalone |
| 18:39:01 | <djazayeri> bwolfe: okay |
| 18:39:11 | *** suranga has quit IRC |
| 18:40:16 | <djazayeri> bwolfe: can you check and see if that directory exists? |
| 18:40:18 | <djazayeri> and/or file? |
| 18:40:28 | <djazayeri> ah, you say that it does |
| 18:40:59 | <djazayeri> you've checked privileges? |
| 18:41:51 | <bwolfe> djazayeri, I ran it as root with the same error |
| 18:43:34 | <dkayiwa> bwolfe: what operating system? |
| 18:43:45 | <bwolfe> ubuntu server |
| 18:43:51 | <dkayiwa> 32 bit? |
| 18:46:48 | <rafa> shall we move on? :) |
| 18:48:18 | <suranga_> james_regen, helllooo |
| 18:48:23 | <suranga_> james_regen, r u there ? |
| 18:48:49 | <djazayeri> bwolfe: if it's a 64-bit OS on the server, that's probably the issue |
| 18:48:58 | <djazayeri> there's a way to do a custom build for this, I think. |
| 18:49:09 | <djazayeri> rafa: sure, you go next |
| 18:49:30 | <rafa> Thursday/Friday: |
| 18:49:30 | <rafa> * Fixed TRUNK-2879: Cannot add new visit when my locale is English (United States) |
| 18:49:30 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2879 |
| 18:49:30 | <rafa> * Tried to fix TRUNK-2889: Autocomplete widgets should not lose initial value on losing focus |
| 18:49:30 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2889 (gave up after a few hours since it's not trivial and there's a higher priority ticket on me TRUNK-2588) |
| 18:49:31 | <rafa> Today: |
| 18:49:31 | <rafa> * Worked on TRUNK-2015: Move some functionality from SaveHandlers to hibernate interceptors |
| 18:49:32 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2015 and TRUNK-2588: Generic mechanism for doing Attributes and Attribute Types on many classes. (Review code, and Refactor.) |
| 18:49:32 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2588 |
| 18:49:33 | <rafa> Blockers: |
| 18:49:33 | <rafa> * org.openmrs.api.impl.PersonServiceImpl.savePersonAttributeType(PersonAttributeType) lines 197-200 show a problem with TRUNK-2015 as a new approach for TRUNK-2588. A trick with bypassing hibernate's cache to get an old value is not working since things may be already flushed to the db. No solution in mind yet. |
| 18:49:49 | <james_regen> suranga_: hi, i'm here |
| 18:50:24 | <suranga_> james_regen, so how were the holidays ? I think ada is still missing though.. she has not commented on any of the bugs :-) |
| 18:51:21 | *** bwolfe has quit IRC |
| 18:51:31 | *** bwolfe has joined #openmrs |
| 18:51:31 | *** ChanServ sets mode: +o bwolfe |
| 18:51:45 | <james_regen> suranga_: hoidays were great. it's a bit difficult to remember what was happening a week ago after not worrying about it for a while |
| 18:51:56 | <suranga_> james_regen, :D |
| 18:52:02 | <bwolfe> dkayiwa, its a 64bit ubuntu 10.04 system |
| 18:52:14 | <suranga_> james_regen, dont worry, the bugs will find you, they always will...... |
| 18:52:28 | <djazayeri> rafa: might it work if you get the saved name before the call to PS.getAllPErsonAttributeTypes() a few lines up? |
| 18:52:59 | <dkayiwa> bwolfe: like darius says, that will not work with the default standalone where we bundled only 32 bit mysql |
| 18:53:18 | <djazayeri> dkayiwa: do you know the solution to this? I think you wrote about it in the readme.txt |
| 18:53:42 | <dkayiwa> djazayeri: yes it is in the readme |
| 18:53:50 | <djazayeri> bwolfe: look at the readme. :-) |
| 18:53:54 | <rafa> djazayeri: tried that, it's flushed before |
| 18:54:24 | <djazayeri> rafa: presumably in the validator? |
| 18:54:32 | <rafa> djazayeri: yeah :) |
| 18:54:33 | <djazayeri> since that's what's changed? |
| 18:54:49 | <suranga_> james_regen, today not much to report, am basically waiting to hear it I can help out with certain bugs or not (due to access restrictions on AMPATH) |
| 18:55:31 | <djazayeri> rafa: one ugly solution is to add a @SkipAutomaticValidation annotation, put it on this method, and have this method fetch that data, and *then* validate |
| 18:55:34 | <djazayeri> very ugly though |
| 18:55:39 | <james_regen> suranga_: ada's mentioned moving the report output to the database. have you thought of how you would do that? i think the information that we need to store is pretty simple |
| 18:55:44 | <bwolfe> djazayeri, dkayiwa, but it works on my personal machine. its 64 bit linux as well... |
| 18:56:18 | <suranga_> james_regen, basically we would need to write each text file into an DB instead, right ? |
| 18:56:34 | <suranga_> james_regen, Im thinking, first we will need to adopt hibernate ? :-) |
| 18:56:46 | <bwolfe> dkayiwa, nothing in the readme about 32 or 64 bit... |
| 18:57:37 | <dkayiwa> bwolfe: i think we just need to make it clearer :) At the bottom with this heading: Details on how to add or remove platform specific databases can be found at: |
| 18:58:14 | <james_regen> suranga_: i wonder if we can just store fewer fields, like a group ID, score, patient ID 1, patient ID 2. the output file stores the values for the fields, but that information is in the database already |
| 18:58:27 | <djazayeri> dkayiwa, bwolfe: I think the issue is that we could make it automatic (to add more architectures) but that makes the standalone bigger and bigger |
| 18:58:39 | <dkayiwa> yes |
| 18:58:58 | <djazayeri> we'd previously discussed making separate packages for linux, osx, and windows, which is probably a good idea |
| 18:59:12 | <suranga_> james_regen, I have not gone into the DB that deep yet, but u are probably right... |
| 18:59:30 | <suranga_> james_regen, maybe (on an unrelated note) we should switch from ant to maven also ? |
| 18:59:44 | *** burke_away is now known as burke |
| 19:00:27 | <dkayiwa> bwolfe: this link could be helpful too: |
| 19:00:28 | <dkayiwa> http://blog.teamlazerbeez.com/2011/10/03/embedded-mysql-on-java-with-connectormxj-and-64-bit-linux/ |
| 19:00:32 | <OpenMRSBot> <http://ln-s.net/9NyO> (at blog.teamlazerbeez.com) |
| 19:00:42 | <wyclif> are we still scrumming |
| 19:00:51 | <dkayiwa> bwolfe: am not 100% sure that is the cause, but i suspect so :) |
| 19:01:00 | <james_regen> suranga_: i don't know if the text file of the report is parsed and displayed, or if the demobraphics' values are pulled from the DB. the first way would explain how the choice of what emographics to show is made. |
| 19:01:14 | <djazayeri> wyclif: yes |
| 19:01:18 | <djazayeri> want to report? |
| 19:02:09 | <djazayeri> dkayiwa, bwolfe: could be that I didn't add the binary dependencies in the dependencies inside the maven plugin? |
| 19:03:11 | <suranga_> james_regen, I think its done the first way... |
| 19:03:40 | <dkayiwa> djazayeri: how that can lead to: /home/bwolfe/standalone/emptydatabase/bin/mysqld": java.io.IOException: error=2, No such file or directory |
| 19:03:47 | <wyclif> yees |
| 19:03:48 | <wyclif> yes |
| 19:03:49 | <suranga_> james_regen, but maybe we should plan for a call if we are going to move ahead with this, that way we could set some sort of goals.... |
| 19:03:57 | <djazayeri> dkayiwa: dunno, speculating wildly |
| 19:04:10 | <dkayiwa> djazayeri: would be interesting. but at this stage, i would try out anything :) |
| 19:04:15 | <wyclif> my report: |
| 19:04:17 | <wyclif> wednesday: |
| 19:04:18 | <wyclif> -TRUNK-2003(Can no longer reproduce) - InvalidPropertyException on long patient form when user adds new name or address or identifier |
| 19:04:18 | <wyclif> -TRUNK-2332 - Fix EncounterService.getCountOfEncounters() and getEncounters(String, Integer, Integer, Boolean) |
| 19:04:18 | <wyclif> -TRUNK-2886 - Wrong number of vists gets displayed on the visit tab of the patient dashboard |
| 19:04:19 | <james_regen> suranga_: yeah, we should do anything without a call and planning |
| 19:04:19 | <wyclif> -design review call |
| 19:04:21 | <wyclif> today: |
| 19:04:23 | <wyclif> -TRUNK-2891 - Edit visit page should support vertical scrolling |
| 19:04:25 | <wyclif> -TRUNK-2887 - Add a label for encounters not assigned to any visit on the visit tab on the patient dashboard |
| 19:04:28 | <wyclif> -TRUNK-2892 - After saving a visit, pressing cancel should take you to patient dashboard instead of admin screen |
| 19:04:31 | <wyclif> -TRUNK-2844 - Auto-created visits populate end time |
| 19:04:33 | <wyclif> -other sprint tickets |
| 19:04:35 | <wyclif> blockers: none |
| 19:04:46 | *** burke has quit IRC |
| 19:04:49 | <djazayeri> wyclif: do you know what to do for TRUNK-2844? |
| 19:04:54 | <djazayeri> were you on the design call? I forget |
| 19:06:34 | <suranga_> james_regen, but we should probably move to hibernate, I guess |
| 19:06:47 | <suranga_> and also maven :-) |
| 19:07:10 | <wyclif> djazayeri, i just picked it |
| 19:07:36 | <djazayeri> wyclif: were you on the design call? |
| 19:07:45 | <wyclif> djazayeri, i haven't yet looked at the details, i guess it requires not setting the end datetime |
| 19:07:54 | <djazayeri> wyclif: there's more than that |
| 19:07:57 | <djazayeri> were you on the design call? |
| 19:08:16 | <djazayeri> (I had said I would write up the to-dos based on that, but I didn't. Ben did it very quickly in a comment.) |
| 19:08:33 | <djazayeri> (but you should clarify that before starting the ticket) |
| 19:08:35 | <wyclif> djazayeri, is that on the ticket? |
| 19:08:38 | <james_regen> suranga_: can you desscribe the hibernate and maven changes in an emal, and include a guess as to how long they'd take, and what would be involved? |
| 19:09:03 | <djazayeri> wyclif: it's partly described in the final ticket comment, but needs to be fleshed out a bit more |
| 19:09:18 | <wyclif> djazayeri, but i recall the discussion around it during the call |
| 19:09:27 | <djazayeri> wyclif: so you were on the design call? |
| 19:09:34 | <wyclif> djazayeri, i will ask you just in case |
| 19:09:39 | <wyclif> djazayeri, yes |
| 19:09:45 | <suranga_> james_regen, sure |
| 19:09:46 | <djazayeri> okay, then you heard it all |
| 19:10:05 | <djazayeri> wyclif: basically we should have an option for auto-setting the end time (a GP, should default to false) |
| 19:10:17 | <suranga_> james_regen, but I'm fighing a few deadlines the comming week, so I might be a bit slow in getting this done :-( |
| 19:10:24 | <djazayeri> and we should add a scheduled "auto-close open visits task" |
| 19:10:38 | <wyclif> djazayeri, ok |
| 19:10:48 | <djazayeri> that task should be configured by two GPs: what visit types it operates on, and what time it runs |
| 19:11:12 | <wyclif> djazayeri, is the priority set for the ticket correct? |
| 19:11:15 | <james_regen> suranga_: that's okay, it won't be a problem |
| 19:11:30 | *** kishoreyekkanti has quit IRC |
| 19:13:02 | <wyclif> thanks djazayeri |
| 19:13:06 | <djazayeri> wyclif: what's the priority now? |
| 19:13:11 | <wyclif> could |
| 19:13:15 | <wyclif> djazayeri, could |
| 19:13:22 | <djazayeri> wyclif: it's a should/must |
| 19:13:35 | <wyclif> djazayeri, ok, will change that |
| 19:13:51 | <wyclif> djazayeri, how about that program state ticket? |
| 19:14:16 | <djazayeri> wyclif: which ticket? |
| 19:14:22 | <wyclif> djazayeri, i think there were a couple of discussions/comments but it still remains alittle unclear to me |
| 19:14:37 | <wyclif> djazayeri, just a sec |
| 19:15:16 | <wyclif> djazayeri, TRUNK-2273 |
| 19:15:25 | <djazayeri> !ticket trunk-2273 |
| 19:15:26 | <OpenMRSBot> djazayeri: [#TRUNK-2273] Avoid Duplicate Rows in Patient_State Table - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2273 |
| 19:15:33 | <bwolfe> this is why all devs should be on the design calls wyclif ;-) |
| 19:16:31 | *** rafa has quit IRC |
| 19:16:51 | <wyclif> bwolfe, i think i was on vacation may be when TRUNK-2273 was discussed |
| 19:16:51 | <djazayeri> wyclif: trunk-2273 isn't required for the beta. In my comment I described what we should do: i.e. add a PatientProgramValidator class, and use it. |
| 19:16:58 | <djazayeri> what's unclear? |
| 19:17:14 | <wyclif> djazayeri, just the clear cut TODOs |
| 19:17:39 | <bwolfe> wyclif, sorry, I was referring to TRUNK-2844 |
| 19:18:11 | <djazayeri> bwolfe: he was on the design call, he just didn't answer that question the first 8 times I asked. ;-) |
| 19:19:00 | <wyclif> bwolfe, i think i know the TODOs for TRUNK-2844, i just hadn't yet related that discussion to the ticket yet |
| 19:19:21 | <djazayeri> wyclif: for 2273, I think there are higher-priority tickets for this sprint, no? |
| 19:19:26 | <wyclif> bwolfe, but after reading the comments, i figured |
| 19:19:50 | <wyclif> djazayeri, ok |
| 19:20:20 | <suranga_> james_regen, Ill look into what we've discussed, and maybe have an initial go.. will keep u updated on this... |
| 19:20:36 | <suranga_> james_regen, its kinda late over here, so i was about to sign off for the day ... :-) |
| 19:21:59 | <james_regen> suranga_: alright, thanks for checking in |
| 19:23:10 | <wyclif> djazayeri, did you see my last comment for TRUNK-2892? |
| 19:23:18 | <djazayeri> !ticket trunk-2892 |
| 19:23:19 | <OpenMRSBot> djazayeri: [#TRUNK-2892] After saving a visit, pressing cancel should take you to patient dashboard instead of admin screen - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2892 |
| 19:23:56 | <djazayeri> wyclif: I think the default should be to go back to the patient dashboard |
| 19:24:06 | <djazayeri> wyclif: ideally we'd also have a returnUrl parameter or something |
| 19:26:55 | <dkayiwa> djazayeri: wyclif actually when i was doing testing, with clicking cancel, i hated it to always go back to the admin screen and then do the patient search again. for i was doing a number of manual tests via the cancel path |
| 19:27:24 | <djazayeri> dkayiwa: where do you want it to go on cancel then? |
| 19:27:35 | <wyclif> dkayiwa, the visit portlet was changed |
| 19:27:36 | <dkayiwa> djazayeri: to the patient dashboard |
| 19:27:47 | <dkayiwa> not the admin screen |
| 19:27:49 | <djazayeri> I agree |
| 19:28:35 | <dkayiwa> to me cancel is like stop this and go back to the screen before |
| 19:29:03 | <djazayeri> dkayiwa, wyclif: the idea behavior is to have save or cancel go back to the page you arrived at Edit Visit from |
| 19:29:09 | <wyclif> dkayiwa, that's how it was before the portlet was redone |
| 19:29:23 | <dkayiwa> ok |
| 19:29:26 | <djazayeri> Defaulting to the dashboard is fine |
| 19:29:26 | <wyclif> dkayiwa, so i agree it needs to fix, i just hadn't noticed the change |
| 19:29:32 | <dkayiwa> ok |
| 19:29:43 | <djazayeri> Actually, I don't love the Edit Visit administrative page |
| 19:29:53 | <djazayeri> could we make it look more like our regular pages? |
| 19:30:07 | <djazayeri> (I'm not looking at it now, but I recall it needs more boxHeader decorations, or something |
| 19:30:14 | <wyclif> dkayiwa, djazayeri it should only go to the admin screen if there is patient assoaciated nor a patientId |
| 19:30:37 | <wyclif> sorry no patient and patientId parameter |
| 19:30:43 | <dkayiwa> wyclif: when i come from patient dashboard, that means i have a patient |
| 19:30:44 | <wyclif> djazayeri, dkayiwa sorry no patient and patientId parameter |
| 19:31:13 | <wyclif> dkayiwa, correct, as long you come from the patient dashboard those should be present |
| 19:31:13 | *** suranga_ has quit IRC |
| 19:31:22 | <dkayiwa> ok |
| 19:31:36 | <wyclif> will fix that |
| 19:31:36 | <dkayiwa> djazayeri: to me the visits tab contents look very ugly :) |
| 19:31:49 | <wyclif> dkayiwa, me too |
| 19:31:58 | <dkayiwa> :) |
| 19:32:22 | <dkayiwa> i wonder how we can make it better! |
| 19:32:29 | <wyclif> FYI when you have multiple pages, it gets screwed |
| 19:32:29 | <djazayeri> dkayiwa, wyclif: I have a deadline in 30 minutes, but after that I'm happy to discuss UI. |
| 19:32:42 | <dkayiwa> ok |
| 19:33:02 | <dkayiwa> now my update |
| 19:33:05 | <dkayiwa> Committed response to review comments for: Automatically convert empty string properties on OpenmrsObjects to null before persisting in the database - TRUNK-2680 |
| 19:33:05 | <dkayiwa> Committed response to review comments for: Encounters should not be assigned to visits which stopped before the encounter date - TRUNK-2814 |
| 19:33:06 | <dkayiwa> Committed: Field widgets that use autocomplete should show a visual indication of invalid entry - TRUNK-2870 |
| 19:33:06 | <dkayiwa> Created some new tickets. |
| 19:33:06 | <dkayiwa> Reviewed, tested and committed some patches. |
| 19:33:06 | <dkayiwa> Did some small ticket administration. |
| 19:33:06 | <dkayiwa> Now thinking of a ticket to pick next. :) |
| 19:33:07 | <dkayiwa> No Blockers. |
| 19:33:09 | <wyclif> dkayiwa, ok |
| 19:41:03 | *** dkayiwa has quit IRC |
| 19:42:32 | *** bryq has joined #openmrs |
| 19:42:32 | *** ChanServ sets mode: +v bryq |
| 19:52:38 | *** rafal87 has joined #openmrs |
| 19:52:49 | <downeym> Hi rafal87 and welcome to the #openmrs IRC channel. |
| 19:56:03 | *** rafal87 has quit IRC |
| 19:56:38 | *** rafa_ has joined #openmrs |
| 19:57:03 | *** rafa_ is now known as Guest31822 |
| 19:59:14 | *** james_regen has quit IRC |
| 20:01:41 | *** dkayiwa has joined #openmrs |
| 20:05:19 | <djazayeri> wyclif: could you add a screenshot to TRUNK-2893 ? |
| 20:06:27 | <wyclif> djazayeri, sure |
| 20:06:48 | <djazayeri> wyclif: generally speaking, you're creating a lot of little UI tickets like this, which is good |
| 20:06:55 | <djazayeri> but it'd be better if they all had screenshots. :-) |
| 20:07:08 | <wyclif> djazayeri, ok |
| 20:26:24 | *** bwolfe has quit IRC |
| 20:53:02 | <wyclif> smb://rii;jkeiper@172.31.3.15/timecard/bmamlin/jkeiper |
| 20:53:13 | <wyclif> smb://rii;jkeiper@172.31.3.15/timecard/bmamlin |
| 20:53:52 | *** burke has joined #openmrs |
| 20:53:52 | *** ChanServ sets mode: +o burke |
| 20:57:08 | <downeym> o.O |
| 20:57:15 | *** dawn_ has quit IRC |
| 21:03:11 | *** dawn_ has joined #openmrs |
| 21:03:11 | *** ChanServ sets mode: +v dawn_ |
| 21:15:53 | *** burke is now known as burke_away |
| 21:22:24 | *** rafa has joined #openmrs |
| 21:22:24 | *** ChanServ sets mode: +v rafa |
| 21:24:17 | *** rafa has quit IRC |
| 21:24:37 | *** rafa has joined #openmrs |
| 21:24:37 | *** ChanServ sets mode: +v rafa |
| 21:26:39 | *** dawn_ has quit IRC |
| 21:26:40 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: New video for developers: Using #OpenMRS with #GitHub and #IntelliJ IDEA - http://t.co/UjwwJsr2 <http://twitter.com/OpenMRS/statuses/141257470000627712> |
| 21:45:32 | *** burke_away is now known as burke |
| 21:50:11 | *** bryq has left #openmrs |
| 21:59:39 | *** wyclif has quit IRC |
| 22:05:06 | *** dkayiwa has quit IRC |
| 22:08:07 | *** downeym has quit IRC |
| 22:59:38 | *** burke is now known as burke_away |
| 23:09:00 | *** burke_away is now known as burke |
| 23:26:16 | *** burke is now known as burke_away |
| 23:28:07 | *** srinivasa has joined #openmrs |
| 23:28:39 | *** burke_away is now known as burke |
| 23:31:44 | *** wyclif has joined #openmrs |