00:04:00
|
*** r0bby_ has quit IRC
|
00:04:22
|
*** r0bby_ has joined #openmrs
|
00:04:22
|
*** ChanServ sets mode: +v r0bby_
|
00:06:25
|
*** robbyoconnor has joined #openmrs
|
00:06:25
|
*** ChanServ sets mode: +v robbyoconnor
|
00:08:47
|
*** r0bby_ has quit IRC
|
00:13:25
|
*** robbyoconnor has quit IRC
|
00:13:34
|
*** Echidna has quit IRC
|
00:14:48
|
*** srinivasa has joined #openmrs
|
00:16:24
|
<srinivasa> bwolfe: Hi
|
00:18:09
|
*** Echidna has joined #openmrs
|
00:18:09
|
*** ChanServ sets mode: +v Echidna
|
00:33:00
|
*** jriley has joined #openmrs
|
01:59:52
|
*** bwolfe has quit IRC
|
02:00:08
|
*** bwolfe has joined #openmrs
|
02:00:08
|
*** ChanServ sets mode: +o bwolfe
|
02:11:27
|
*** jriley has quit IRC
|
02:25:15
|
<srinivasa> bwolfe: hi
|
02:59:02
|
*** srinivasa has quit IRC
|
03:05:24
|
*** upul` has joined #openmrs
|
03:05:33
|
*** ChanServ sets mode: +v upul`
|
03:38:06
|
*** morristic has joined #openmrs
|
04:29:49
|
*** sunbiz has joined #openmrs
|
04:29:49
|
*** ChanServ sets mode: +v sunbiz
|
04:30:48
|
*** bwolfe has quit IRC
|
05:22:00
|
*** surangak has joined #openmrs
|
05:49:57
|
*** bwolfe has joined #openmrs
|
05:49:57
|
*** ChanServ sets mode: +o bwolfe
|
06:10:26
|
*** morristic has quit IRC
|
06:52:07
|
*** sunbiz has quit IRC
|
06:53:28
|
*** sunbiz has joined #openmrs
|
06:53:28
|
*** ChanServ sets mode: +v sunbiz
|
07:21:25
|
*** dkayiwa has joined #openmrs
|
08:15:41
|
*** bryq has joined #openmrs
|
08:15:41
|
*** ChanServ sets mode: +v bryq
|
08:56:47
|
*** robbyoconnor has joined #openmrs
|
08:56:47
|
*** ChanServ sets mode: +v robbyoconnor
|
09:47:21
|
*** surangak_ has joined #openmrs
|
09:48:30
|
*** surangak has quit IRC
|
10:22:06
|
*** bryq has quit IRC
|
10:44:28
|
*** rafa has joined #openmrs
|
10:44:28
|
*** ChanServ sets mode: +v rafa
|
10:50:56
|
*** sunbiz has quit IRC
|
10:51:16
|
*** sunbiz has joined #openmrs
|
10:51:16
|
*** ChanServ sets mode: +v sunbiz
|
10:51:35
|
*** sunbiz has left #openmrs
|
11:02:26
|
*** morristic has joined #openmrs
|
11:03:44
|
*** surangak_ has quit IRC
|
11:11:30
|
*** morristic has quit IRC
|
11:37:12
|
*** upul` has quit IRC
|
12:37:28
|
*** wyclif has quit IRC
|
13:01:17
|
*** mnunez has joined #openmrs
|
13:02:17
|
<mnunez> @djazayeri: Hi there! OMRS University on today?
|
13:02:41
|
<mnunez> djazayeri: Hi there! OMRS University on today?
|
13:11:17
|
*** mnunez has quit IRC
|
13:12:16
|
*** mnunez has joined #openmrs
|
13:14:24
|
<dkayiwa> hi rafa
|
13:14:31
|
<rafa> hi Daniel
|
13:14:36
|
<dkayiwa> TRUNK-2879
|
13:15:12
|
<rafa> any hints?
|
13:15:19
|
<dkayiwa> rafa: try switch to a different locale and paste here the date value in your textbox
|
13:15:38
|
<dkayiwa> that is for the visit start date and closing the popup calender
|
13:15:46
|
<rafa> dkayiwa: it's always the same format
|
13:16:00
|
<dkayiwa> rafa: how do you switch your locale?
|
13:16:34
|
<rafa> dkayiwa: using windows via control panel - clock, language and region
|
13:16:46
|
<dkayiwa> hhahahaha :D
|
13:16:54
|
<rafa> dkayiwa: I tested it in chrome and firefox
|
13:17:20
|
<dkayiwa> rafa: i think i need to add more description and explicitly say openmrs locale switch facility :)
|
13:17:32
|
<rafa> dkayiwa: Ohh :)
|
13:17:37
|
<dkayiwa> below near the status bar for the openmrs window
|
13:17:45
|
<rafa> dkayiwa: okay
|
13:17:47
|
<rafa> let me try that
|
13:17:50
|
<dkayiwa> ok
|
13:18:48
|
<rafa> dkayiwa: hmm still works fine :/
|
13:19:00
|
<rafa> dkayiwa: but it is displayed differently 11/24/2011 02:17 PM
|
13:19:11
|
<dkayiwa> and paste the other
|
13:19:37
|
<rafa> the other is 24/11/2011 14:17
|
13:20:06
|
<rafa> so it's even translated correctly
|
13:20:17
|
<dkayiwa> rafa: and are you on trunk?
|
13:20:24
|
<rafa> dkayiwa: yes
|
13:20:35
|
<rafa> dkayiwa: let me switch now system locale to something different than us
|
13:20:43
|
<dkayiwa> ok
|
13:23:03
|
<dkayiwa> rafa: which locale did you switch to in openmrs?
|
13:23:22
|
<rafa> dkayiwa: I chose English (United States)
|
13:23:35
|
<dkayiwa> rafa: can you try all the listed locales?
|
13:24:35
|
*** wyclif has joined #openmrs
|
13:24:39
|
<rafa> dkayiwa: it seems to work with all
|
13:24:46
|
<dkayiwa> hahahahaha
|
13:24:59
|
<dkayiwa> rafa: it is failing on mine even now
|
13:25:16
|
<rafa> dkayiwa: I guess you will need to take over this ticket then
|
13:25:32
|
<rafa> dkayiwa: maybe it's a linux thing
|
13:25:43
|
<dkayiwa> rafa: fails for italiano too
|
13:26:10
|
<rafa> dkayiwa: strange
|
13:26:26
|
<rafa> dkayiwa: italiano has he same format as UK
|
13:26:45
|
<dkayiwa> rafa: could it have anything to do with time zone?
|
13:27:03
|
<dkayiwa> rafa: mine is East Africa
|
13:27:04
|
<rafa> dkayiwa: it's unlikely
|
13:27:37
|
<rafa> dkayiwa: but try
|
13:27:53
|
<dkayiwa> wyclif can you help us test this too?
|
13:28:07
|
<wyclif> hi dkayiwa
|
13:28:13
|
<wyclif> dkayiwa, what?
|
13:28:33
|
<dkayiwa> wyclif: can you switch to locale English (United States) and then try add a new visit?
|
13:29:47
|
<rafa> wyclif: using OpenMRS bottom bar
|
13:30:25
|
<dkayiwa> yes for locale switch
|
13:31:29
|
<wyclif> dkayiwa, sure
|
13:35:01
|
<wyclif> dkayiwa, rafa, worked for me
|
13:35:40
|
<dkayiwa> wyclif: what value does it put in start date time for each locale?
|
13:36:00
|
<wyclif> dkayiwa, the one i entered in the datetime picker
|
13:36:13
|
<dkayiwa> wyclif: can you paste here
|
13:36:21
|
<wyclif> dkayiwa, what do you mean each locale
|
13:36:42
|
<wyclif> dkayiwa, 11/23/2001 08:33 am
|
13:37:00
|
<dkayiwa> wyclif: after switching to english united states
|
13:37:06
|
<wyclif> dkayiwa, yeah
|
13:37:19
|
<dkayiwa> wyclif: and for uk?
|
13:37:38
|
<wyclif> dkayiwa, i went to add visit page, switched the locale firt and then entered values and then saved
|
13:38:06
|
<dkayiwa> wyclif: i would love to see both start dates
|
13:38:19
|
<dkayiwa> wyclif: if you can paste here
|
13:38:44
|
<wyclif> dkayiwa, even for UK it worked
|
13:39:01
|
<dkayiwa> wyclif: can you paste here the dates
|
13:39:03
|
<wyclif> dkayiwa, 23/11/2011 08:37
|
13:39:16
|
<wyclif> no AM
|
13:39:33
|
<dkayiwa> now am wondering whatsup with me!!!!
|
13:39:39
|
<wyclif> dkayiwa, i guess that is fine
|
13:39:55
|
<dkayiwa> it fails for me
|
13:40:08
|
<dkayiwa> wyclif: thanks for trying it out
|
13:40:17
|
<dkayiwa> let me look more into it
|
13:41:55
|
<wyclif> dkayiwa, but i can see that for US, it uses 24hr while for Uk it uses 12hr clock
|
13:42:23
|
<dkayiwa> wyclif: correct. i wonder why it fails on mine
|
13:42:33
|
<wyclif> dkayiwa, may be it has to do with your system timezone
|
13:42:36
|
<dkayiwa> TRUNK-2879
|
13:42:42
|
<dkayiwa> wyclif: maybe
|
13:43:54
|
<wyclif> dkayiwa, because i noticed for US there is no PM/AM but it works for me either way
|
13:44:05
|
<dkayiwa> ok
|
13:44:13
|
<wyclif> dkayiwa, can you set your timezone to US and see if it works
|
13:44:26
|
<dkayiwa> wyclif: let me try that now
|
13:44:31
|
<rafa> dkayiwa: feel free to take over the ticket
|
13:44:37
|
<dkayiwa> ok
|
13:45:27
|
<rafa> I've got a different time zone but it works for me
|
13:45:35
|
<dkayiwa> ok
|
13:45:56
|
<rafa> dkayiwa: what browser and os are you using?
|
13:46:16
|
<wyclif> rafa, browsers and most OSs default to US
|
13:46:36
|
<wyclif> rafa, so i guess your may be using US by default without setting it
|
13:46:40
|
<dkayiwa> rafa: firefox 3.6.6 mac ox 10.6.7
|
13:47:01
|
<rafa> wyclif: nope, I use PL ;)
|
13:47:45
|
<wyclif> rafa, it might be working for PL eitherway but not for what daniel is using
|
13:48:15
|
<wyclif> rafa, dkayiwa in US they start with month and then date and if you notice that is what the widget is doing when formatting the date
|
13:48:39
|
<wyclif> rafa, dkayiwa and i guess that is what is causing issues for daniel
|
13:48:45
|
<dkayiwa> ok
|
13:49:22
|
<rafa> wyclif: when I change locales the widget converts different formats properly for me
|
13:50:28
|
<rafa> dkayiwa: what is your system locale?
|
13:51:20
|
<dkayiwa> rafa: just switched to us as wyclif told me
|
13:51:25
|
<wyclif> rafa, dkayiwa, i have reproduced your error with a hack
|
13:51:35
|
<dkayiwa> oh howww
|
13:52:13
|
<wyclif> dkayiwa, if you have noticed your widget is not setting the AM/PM bit and that is the problem
|
13:52:38
|
<wyclif> dkayiwa, so i removed it from the entered value on my machine and i got the same error
|
13:52:44
|
*** jriley has joined #openmrs
|
13:52:47
|
<wyclif> dkayiwa, that is for US
|
13:53:02
|
<dkayiwa> wyclif: interesting
|
13:54:07
|
<wyclif> dkayiwa, this happens when you select date and not use now, you have to explicitly use the time cliders for it to work
|
13:54:23
|
<dkayiwa> let me see
|
13:54:25
|
<wyclif> dkayiwa, sliders for the widget to set the AM in US
|
13:54:58
|
<wyclif> dkayiwa, so it a just a problem with the way the widget works
|
13:55:29
|
<dkayiwa> wyclif: haahahaha. you are correct :)
|
13:55:52
|
<wyclif> hi rafa, can you try selecting a date without using the now button for US locale
|
13:56:03
|
<wyclif> rafa, you will reproduce the problem
|
13:57:00
|
<wyclif> rafa, dkayiwa i would say it is not a bug but a limitation of the widget not set am or pm by default, i guess there must be a way to configure the default
|
13:57:04
|
<dkayiwa> wyclif: when i touch the sliders as you say, the it saves well
|
13:57:42
|
<rafa> wyclif: hmm it displays am for me all the time
|
13:57:46
|
*** downeym has joined #openmrs
|
13:57:46
|
*** ChanServ sets mode: +o downeym
|
13:57:46
|
*** OpenMRSBot sets mode: +o downeym
|
13:57:51
|
<rafa> wyclif: at least using chrome
|
13:57:57
|
<rafa> let me try with firefox
|
13:58:03
|
<dkayiwa> rafa: you need to go back to the patient dashboard
|
13:58:03
|
<wyclif> dkayiwa, the ticket to file should be that either we fix the config of the widget to set the default AM vs PM or let our custom date property editor set that
|
13:58:28
|
<dkayiwa> then add a visit and do not touch the sliders (when your locale is English United states) ara
|
13:58:42
|
<rafa> dkayiwa: okay got it
|
13:58:44
|
<dkayiwa> wyclif: ok
|
13:58:49
|
<wyclif> rafa, i mean, you need to select only date and donot touch the sliders for US
|
13:59:05
|
<rafa> wyclif: it works right if you edit the date
|
13:59:15
|
<dkayiwa> :)
|
13:59:15
|
<rafa> wyclif: the problem is just the first time the date is entered
|
13:59:49
|
<wyclif> rafa, what do u mean?
|
14:00:23
|
<wyclif> rafa, i can reproduce it as long i only click on a date and no time sliders
|
14:00:43
|
<rafa> wyclif: if you have am/pm once entered then you can edit the date without using time sliders and it's fine
|
14:01:17
|
<wyclif> rafa, am concerned about if i havent touched the AM, PM bit
|
14:01:39
|
<dkayiwa> rafa: thats correct
|
14:02:08
|
<rafa> it should be a quick fix
|
14:02:20
|
<rafa> it's a js thing
|
14:02:31
|
<wyclif> rafa, i agree it not really a bug
|
14:02:34
|
<dkayiwa> rafa: can you take the ticket again?
|
14:02:36
|
<dkayiwa> :)
|
14:02:39
|
<wyclif> rafa, i agree it is not really a bug
|
14:02:39
|
<rafa> dkayiwa: sure :)
|
14:02:46
|
<dkayiwa> thanks
|
14:03:13
|
<dkayiwa> wyclif: i have failed to reproduce TRUNK-2870
|
14:03:23
|
<dkayiwa> wyclif: do you know what the problem is?
|
14:03:41
|
<rafa> thanks guys for helping to figure this out :)
|
14:03:53
|
<dkayiwa> rafa: thanks too :)
|
14:04:26
|
<dkayiwa> wyclif: when i enter an invalid value in any autocomplete widget, if i change focus, it is cleared. But Darius says it stays. Is that the same for you wyclif ?
|
14:04:30
|
<wyclif> rafa, no problem
|
14:04:47
|
<wyclif> dkayiwa, not really
|
14:05:12
|
<dkayiwa> wyclif: meaning you get the same behavior as Darius?
|
14:05:19
|
<wyclif> dkayiwa, no
|
14:06:05
|
<dkayiwa> thanks for trying it out wyclif :)
|
14:06:15
|
<wyclif> dkayiwa, unless i use esc button
|
14:06:21
|
<dkayiwa> ohhhhhhh
|
14:06:35
|
<wyclif> dkayiwa, may be that is what darius meant
|
14:06:44
|
<dkayiwa> ok
|
14:07:28
|
<dkayiwa> wyclif: esc is not working for me. (as in focus stays on the widget)
|
14:07:31
|
*** bryq has joined #openmrs
|
14:07:31
|
*** ChanServ sets mode: +v bryq
|
14:07:38
|
<wyclif> dkayiwa, you might want to ask him more because there is some other stuff he included that i failed to reproduce
|
14:07:49
|
<dkayiwa> ok
|
14:08:10
|
<wyclif> dkayiwa, esc only hides the widget for me
|
14:08:21
|
<dkayiwa> ok
|
14:09:18
|
<dkayiwa> wyclif: yes it hides the widget and leaves the invalid value. but when you go to the next widget, the invalid value is cleared
|
14:09:24
|
<dkayiwa> thats is what i see
|
14:11:09
|
<wyclif> dkayiwa, me too
|
14:11:15
|
<dkayiwa> ok
|
14:11:24
|
<wyclif> dkayiwa, and i'm personally fine with that
|
14:11:37
|
<dkayiwa> me too
|
14:11:43
|
<wyclif> dkayiwa, the bug am aware of with those widgets is that you cannot clear a value
|
14:12:25
|
<dkayiwa> wyclif: how?
|
14:12:46
|
<djazayeri> mnunez: yes, there is a university call now
|
14:13:21
|
<wyclif> dkayiwa, go to an existing visit that has an indication concept, u are aware that is option, imagine you want to remove and make blank, try that and see if you can
|
14:13:41
|
<mnunez> Now?
|
14:13:47
|
<djazayeri> yes
|
14:14:05
|
<mnunez> grrr Summer time!
|
14:14:05
|
<dkayiwa> wyclif: let me try that
|
14:15:38
|
<dkayiwa> wyclif: hahaha. you are very correct
|
14:16:47
|
<wyclif> dkayiwa, the problem is that the hidden field is not actually reset, i created a ticket a while ago to add a clear button that is optional to be visible, you might want to add to this sprint
|
14:17:07
|
<dkayiwa> wyclif: ticket number?
|
14:17:17
|
<wyclif> dkayiwa, let try to look it up
|
14:17:43
|
<dkayiwa> ok
|
14:17:55
|
<wyclif> dkayiwa, TRUNK-2301
|
14:18:04
|
<dkayiwa> wyclif: ok thanks
|
14:18:26
|
<djazayeri> dkayiwa, wyclif: right the *hidden* field is not reset
|
14:18:45
|
<dkayiwa> correct
|
14:19:21
|
<dkayiwa> wyclif: you created this as a new feature and hence cant add it after alpha is out. Should i change i to a bug? :)
|
14:19:37
|
<dkayiwa> djazayeri: your view too?
|
14:19:43
|
<wyclif> dkayiwa, djazayeri how do you feel about including this in 1.9
|
14:19:53
|
<djazayeri> ask me after university call
|
14:19:56
|
<dkayiwa> wyclif: i feel ok about it
|
14:19:58
|
<wyclif> djazayeri, sure
|
14:20:00
|
<dkayiwa> :D
|
14:20:09
|
<wyclif> dkayiwa, i personally think it is a bug
|
14:20:15
|
<dkayiwa> wyclif: me too
|
14:20:24
|
<dkayiwa> its not a new feature
|
14:20:48
|
<wyclif> dkayiwa, the developer of the form should be able to show the clear button since they would know a required Vs optional field
|
14:20:59
|
<dkayiwa> ok
|
14:21:18
|
<wyclif> dkayiwa, it is not necessary if it is a required field
|
14:21:24
|
<dkayiwa> ok
|
14:34:58
|
<wyclif> dkayiwa, rafa am looking at the visit tab on the patient dashboard and it looks kind of strange
|
14:35:22
|
<rafa> wyclif: what's wrong?
|
14:35:54
|
<dkayiwa> wyclif: i wanted to say that long time ago. it looks ugly :)
|
14:35:55
|
<wyclif> dkayiwa, rafa it showing 1 to 5 of 5 entries
|
14:36:02
|
<wyclif> dkayiwa, rafa it is showing 1 to 5 of 5 entries
|
14:36:39
|
<wyclif> dkayiwa, but there only have 2 visits, 4 encounters in total
|
14:37:05
|
<wyclif> so am not sure about the 5 entries it means
|
14:37:21
|
<rafa> wyclif: is there one visit with no encounters?
|
14:37:40
|
<rafa> wyclif: it refers to number of displayed rows
|
14:37:49
|
<wyclif> i would also like to see the encounters not assigned to a visit to come either last or first and not randonly placed
|
14:38:18
|
<wyclif> rafa, i thin it should be saying the number of visits because i can tell it is counting blank rows
|
14:38:46
|
<rafa> wyclif: encounters not assigned to a visit are placed based on their dates
|
14:38:54
|
<wyclif> rafa, since it is a visit tab, it shpuld be counting visits and not rows otherwise it is including blank ones
|
14:39:43
|
<wyclif> rafa, i mean i have 2 visits and they are listed in between the two visit so initially i thought they belonged either to the top or bottom one, so i was confused
|
14:39:44
|
<rafa> wyclif: hmm I don't have a strong opinion here
|
14:40:03
|
<wyclif> rafa, after looking at the page i noticed it was grouping
|
14:40:24
|
<rafa> wyclif: yes grouping was the idea :)
|
14:40:51
|
<wyclif> rafa, grouping if sine but it should be saying the number of visits
|
14:41:07
|
<wyclif> rafa, not to confuse the user
|
14:41:45
|
<rafa> wyclif: I don't think it's that easy to change :)
|
14:41:58
|
<rafa> wyclif: we're using datatables
|
14:42:14
|
<rafa> wyclif: it's inherent behavior
|
14:42:42
|
<wyclif> rafa, ok, how about having the unassigned encounters group together with a label clearly showing that they are unassigned
|
14:43:06
|
<rafa> wyclif: that's doable
|
14:43:12
|
<wyclif> rafa, i think you can override that showing piece of text when adding the widget
|
14:44:05
|
<wyclif> rafa, you can change it to anything you want and set the number of visits
|
14:44:08
|
<rafa> wyclif: yeah you can do everything, it's just a matter of how much effort do you want to put in that :)
|
14:44:43
|
<wyclif> rafa, it is just like one line to change that text, think it is a widget property
|
14:45:10
|
<rafa> I'm fine with your change :)
|
14:45:20
|
<wyclif> rafa, i agree that this is low priority
|
14:46:44
|
<mnunez> dkayiwa: Hi! Have a sec for a simple question with a hopefully simple answer?
|
14:48:37
|
<wyclif> rafa, you can set this property of the datatables 'sLengthMenu' to be something else
|
14:49:06
|
<wyclif> rafa, that way you set the actual number of visits
|
14:49:55
|
<wyclif> rafa, i will create a ticket for it
|
14:49:58
|
<rafa> wyclif: it's not this one. It's for displaying select of how many rows to display
|
14:51:18
|
<dkayiwa> mnunez: ok
|
14:51:29
|
<dkayiwa> mnunez: if you can ask in one minute
|
14:51:41
|
<mnunez> dkayiwa: First, area text boxes in repeat sections are shown in different order in the Design view and in the Preview.
|
14:52:03
|
<dkayiwa> mnunez: did you give them a tab index other than zero?
|
14:52:13
|
<mnunez> dkayiwa: No
|
14:52:24
|
<dkayiwa> mnunez: as in give each a different tab index and it will fix it
|
14:52:56
|
*** dawn_ has joined #openmrs
|
14:53:21
|
<mnunez> dkayiwa: Excelent, I'll give it a try. Second: date widgets do not allow you to switch to other widgets, even if a date is already set. That's in Chrome, not Firefox.
|
14:53:41
|
<mnunez> dkayiwa: workaround?
|
14:53:43
|
*** ChanServ sets mode: +v dawn_
|
14:53:49
|
<dkayiwa> mnunez: does it work well in firefox?
|
14:54:01
|
<mnunez> dkayiwa: It does.
|
14:54:07
|
<dkayiwa> mnunez: even after pressing enter?
|
14:54:14
|
<dkayiwa> does it still fail in chrome?
|
14:54:48
|
<mnunez> dkayiwa: Checking
|
14:56:07
|
<mnunez> dkayiwa: Yes, even after pressing enter. The little calendar just wont close.
|
14:56:41
|
<dkayiwa> mnunez: create a ticket for it
|
14:56:52
|
<dkayiwa> will be back later in a few hours
|
14:57:08
|
<mnunez> dkayiwa: Allright. Bye!
|
15:02:01
|
*** dkayiwa has quit IRC
|
15:06:47
|
<djazayeri> wyclif, rafa, bwolfe: are we changing our scrum time starting today?
|
15:07:29
|
<wyclif> not sure
|
15:07:32
|
<rafa> I'm ready to go regular time today :)
|
15:07:37
|
<wyclif> me too
|
15:07:41
|
<dawn_> i figure we can change to the new times next week
|
15:07:44
|
<djazayeri> looks like dkayiwa just signed off
|
15:07:54
|
<djazayeri> oh well, let's go now
|
15:09:53
|
<djazayeri> rafa?
|
15:10:16
|
<rafa> Today:
|
15:10:16
|
<rafa> * Did some preps for the MDS Server
|
15:10:16
|
<rafa> * Started with TRUNK-2879: Cannot add new visit when my locale is English (United States)
|
15:10:16
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2879 (Daniel and Wyclif helped to finally identifiy the problem)
|
15:10:16
|
<rafa> * Design Call
|
15:10:17
|
<rafa> Tomorrow:
|
15:10:17
|
<rafa> * Finish TRUNK-2879: Cannot add new visit when my locale is English (United States)
|
15:10:18
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2879 (Daniel and Wyclif helped to finally identifiy the problem)
|
15:10:18
|
<rafa> * Hopefully go back to TRUNK-2588: Generic mechanism for doing Attributes and Attribute Types on many classes. (Review code, and Refactor.)
|
15:10:19
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2588
|
15:10:22
|
<rafa> No blockers.
|
15:10:54
|
<djazayeri> OKay.
|
15:11:00
|
<djazayeri> Did TRUNK-2879 turn out to be very big?
|
15:11:22
|
<rafa> djazayeri: no, it's js thing
|
15:11:27
|
<rafa> djazayeri: I couldn't reproduce it at first
|
15:11:49
|
<rafa> djazayeri: now I know what to fix, but it behaves strangely
|
15:12:11
|
<rafa> djazayeri: I mean it's an external widget
|
15:12:20
|
<rafa> djazayeri: maybe we'll need to update it
|
15:12:35
|
<djazayeri> Okay. We are in no way tied to using that particular date picker.
|
15:12:37
|
<djazayeri> time picker, I mean
|
15:13:00
|
<djazayeri> I think it's pretty terrible from a usability perspective (though I haven't really seen better ones)
|
15:13:44
|
<djazayeri> the main point is that it attaches to the existing jquery datepicker, and lets us have date and time in a single input field.
|
15:13:44
|
<rafa> djazayeri: okay I'll look around for an alternative
|
15:16:30
|
<wyclif> if we can't do it in the widget, then we can try either spitting out the date in the date editor os append AM by default
|
15:16:39
|
<wyclif> or
|
15:17:35
|
<djazayeri> Okay, wyclif, your report?
|
15:17:52
|
<wyclif> yesterday:
|
15:17:52
|
<wyclif> -TRUNK-2847- Delete Forever error should have better language
|
15:17:52
|
<wyclif> -TRUNK-2885 - Align delete buttons on visit form to the left side
|
15:17:52
|
<wyclif> -TRUNK-2064 - cannot use multiple globalproperties portlets on a single page
|
15:17:53
|
<wyclif> -Investigated about TRUNK-2840 and closed it as cant reproduce - Update wizard should not display language selection page during database upgrade
|
15:17:55
|
<wyclif> -Tested if TRUNK-2716 is working as expected(with xform) - Cannot submit an encounter form
|
15:17:57
|
<wyclif> -code review and closing old reviews
|
15:17:59
|
<wyclif> today:
|
15:18:01
|
<wyclif> -TRUNK-2003 - InvalidPropertyException on long patient form when user adds new name or address or identifier
|
15:18:04
|
<wyclif> -TRUNK-2332 - Fix EncounterService.getCountOfEncounters() and getEncounters(String, Integer, Integer, Boolean)
|
15:18:07
|
<wyclif> -other sprint tickets
|
15:18:09
|
<wyclif> blockers: none
|
15:19:16
|
<djazayeri> wyclif: okay, note that you currently have 5 tickets assigned to you in the current sprint
|
15:20:37
|
<wyclif> djazayeri, they are in code review status
|
15:21:14
|
<djazayeri> wyclif: https://tickets.openmrs.org/secure/IssueNavigator.jspa?reset=true&mode=hide&jqlQuery=project+%3D+TRUNK+AND+fixVersion+%3D+%221.9+Beta+Sprint%22+AND+status+in+%28%22In+Progress%22%2C+Reopened%29+AND+resolution+%3D+Unresolved+AND+assignee+%3D+wyclif
|
15:21:15
|
<wyclif> djazayeri, or waiting for more info
|
15:21:27
|
<djazayeri> 5 "In Progress" tickets.
|
15:21:36
|
<djazayeri> At least one I code reviewed.
|
15:22:15
|
<djazayeri> wyclif: ^^
|
15:22:17
|
<djazayeri> Okay, my report:
|
15:22:21
|
<djazayeri> Yesterday:
|
15:22:25
|
<djazayeri> * reviewed a few tickets
|
15:22:40
|
<djazayeri> * call about pentaho project
|
15:22:49
|
<djazayeri> * call with a thoughtworks BA
|
15:22:56
|
<djazayeri> Today:
|
15:23:00
|
<djazayeri> * University call
|
15:23:02
|
<djazayeri> * Design call
|
15:23:17
|
<djazayeri> * Thoughtworks catchup call
|
15:23:20
|
<djazayeri> * review some tickets
|
15:23:40
|
<djazayeri> * working in a project proposal
|
15:23:41
|
<djazayeri> no blockers
|
15:24:58
|
<djazayeri> by the way, I will not be at scrums tomorrow or Friday, due to it being a holiday in the US.
|
15:25:19
|
<djazayeri> rafa: you can dkayiwa should catch up, and see if bwolfe is there
|
15:25:43
|
<rafa> djazayeri: okay
|
15:27:16
|
<rafa> djazayeri: btw do you know anything about metadata-sharing-server branch in svn?
|
15:27:38
|
<djazayeri> rafa: is it in openmrs-contrib?
|
15:27:42
|
*** mnunez has left #openmrs
|
15:27:47
|
<rafa> yes
|
15:28:40
|
<djazayeri> rafa: back around the time of your first summer of code, I wrote a quick grails app, which was intended to allow people to do centralized sharing of MDS packages
|
15:28:58
|
<djazayeri> It's the same idea as the current MDS Server project.
|
15:29:07
|
<rafa> djazayeri: it's what I suspected :)
|
15:29:13
|
<rafa> djazayeri: can we take it over?
|
15:29:17
|
<djazayeri> I have no recollection of how far I got with it before realizing that the time wasn't right
|
15:29:35
|
<djazayeri> you can even delete it if you want, so you can reclaim the name "metadata-sharing-server"
|
15:30:00
|
<rafa> djazayeri: cool. I'll see how it looks like right now and decide
|
15:30:14
|
<rafa> djazayeri: thanks
|
15:33:38
|
*** rafa has quit IRC
|
15:33:44
|
*** downeym_ has joined #openmrs
|
15:33:44
|
*** ChanServ sets mode: +o downeym_
|
15:36:02
|
*** downeym has quit IRC
|
15:36:02
|
*** downeym_ is now known as downeym
|
15:37:54
|
*** jriley has left #openmrs
|
15:50:38
|
*** dawn_ has quit IRC
|
16:03:02
|
*** r-friedman has joined #openmrs
|
16:03:25
|
<r-friedman> djazayeri: hi darius, got a minute?
|
16:03:45
|
<djazayeri> yeah
|
16:03:50
|
<r-friedman> tks
|
16:04:03
|
<r-friedman> i've got several objects whose names are kept in concepts
|
16:04:42
|
<r-friedman> it seems very painful to get their names by calling conceptservice.getname()
|
16:05:06
|
<r-friedman> can i put that in the pojo?
|
16:06:02
|
*** kishoreyekkanti has joined #openmrs
|
16:06:28
|
<djazayeri> r-friedman: presumably your object has a concept as a property too, right?
|
16:06:34
|
<r-friedman> yes
|
16:07:09
|
<djazayeri> doing something like this is fine: public String getName() { return getConcept().getPreferredName(Context.getLocale()).getName(); }
|
16:07:48
|
<r-friedman> in the pojo?
|
16:07:53
|
<djazayeri> yeah
|
16:08:03
|
<r-friedman> ok tks
|
16:29:11
|
*** kishoreyekkanti has quit IRC
|
16:42:04
|
*** morristic has joined #openmrs
|
16:47:06
|
*** rafa has joined #openmrs
|
16:47:06
|
*** ChanServ sets mode: +v rafa
|
17:00:22
|
*** rafa has quit IRC
|
17:04:09
|
*** jriley has joined #openmrs
|
17:12:21
|
*** suranga has joined #openmrs
|
17:22:10
|
*** suranga_ has joined #openmrs
|
17:22:47
|
*** suranga has quit IRC
|
17:30:39
|
*** suranga has joined #openmrs
|
17:34:18
|
*** suranga_ has quit IRC
|
17:36:08
|
*** suranga has quit IRC
|
17:40:41
|
*** suranga has joined #openmrs
|
18:15:35
|
*** robbyoconnor has quit IRC
|
18:17:41
|
*** kishoreyekkanti has joined #openmrs
|
18:22:32
|
*** suranga has quit IRC
|
18:35:51
|
*** rafa has joined #openmrs
|
18:35:51
|
*** ChanServ sets mode: +v rafa
|
18:39:18
|
*** rafa has quit IRC
|
18:53:14
|
*** jriley has quit IRC
|
18:58:40
|
*** rafa has joined #openmrs
|
18:58:40
|
*** ChanServ sets mode: +v rafa
|
19:05:17
|
*** chopin has joined #openmrs
|
19:09:13
|
<chopin> hhhhhhey
|
19:09:34
|
<chopin> so ... is there any way i can write hql against the role_role table?
|
19:10:02
|
<downeym> haay
|
19:11:52
|
<bwolfe> chopin, for what purpose?
|
19:12:21
|
<chopin> bwolfe, to find a role's parents in the dao instead of api methods
|
19:12:28
|
<chopin> bwolfe, it looks complicated :-/
|
19:12:39
|
* chopin is trying to finish TRUNK-2503
|
19:15:19
|
<chopin> bwolfe, s/parents/descendants (same difference)
|
19:15:50
|
<bwolfe> I think you have to do it through role
|
19:16:12
|
<bwolfe> chopin, "from Role r where r.role = newRoleObject"
|
19:16:57
|
<chopin> hmmm ... but r.role is a string, no?
|
19:17:33
|
<chopin> Role has inheritedRoles
|
19:17:35
|
<bwolfe> oh wait
|
19:18:04
|
<bwolfe> "from Role r where r.inheritedRoles = newRoleObject" or something
|
19:18:36
|
<chopin> i wish could do "contains"
|
19:19:22
|
<bwolfe> it might do that with the equals by knowing that inheritiedRoles is a collection
|
19:19:23
|
<chopin> what i really want is "from Role r where theOneImTesting in r.inheritedRoles
|
19:21:57
|
<chopin> also, Role.getAllParentRoles() is a recursive automagical thing ... and the only way to make a Role know its descendants is to add childRoles as a property (similar to inheritedRoles) and write similar code for finding the descendants
|
19:48:07
|
*** kishoreyekkanti has left #openmrs
|
19:48:49
|
*** dkayiwa has joined #openmrs
|
19:53:51
|
*** rafa has quit IRC
|
20:22:17
|
*** wyclif has quit IRC
|
20:35:05
|
*** wyclif has joined #openmrs
|
20:56:41
|
<djazayeri> dkayiwa: it has 2.0.1
|
20:56:50
|
<djazayeri> I'll try doing a clean build and see if that fixes things.
|
20:56:58
|
<dkayiwa> ok
|
20:58:25
|
*** downeym_ has joined #openmrs
|
20:58:25
|
*** ChanServ sets mode: +o downeym_
|
21:02:07
|
*** downeym has quit IRC
|
21:02:07
|
*** downeym_ is now known as downeym
|
21:04:09
|
*** chopin has quit IRC
|
21:05:06
|
*** rafa has joined #openmrs
|
21:05:06
|
*** ChanServ sets mode: +v rafa
|
21:13:08
|
*** rafa has quit IRC
|
21:43:59
|
*** bwolfe has quit IRC
|
21:46:11
|
*** wyclif has quit IRC
|
21:46:57
|
*** bwolfe has joined #openmrs
|
21:46:57
|
*** ChanServ sets mode: +o bwolfe
|
21:52:41
|
*** bryq has quit IRC
|
21:56:30
|
*** djazayeri has quit IRC
|
22:00:06
|
*** dkayiwa has left #openmrs
|
22:15:32
|
*** bwolfe has quit IRC
|
22:23:56
|
*** rafa has joined #openmrs
|
22:23:56
|
*** ChanServ sets mode: +v rafa
|
22:29:06
|
*** wyclif has joined #openmrs
|
22:38:17
|
*** djazayeri has joined #openmrs
|
22:38:17
|
*** ChanServ sets mode: +o djazayeri
|
22:41:10
|
*** djazayeri has quit IRC
|
22:43:45
|
*** downeym has quit IRC
|
23:40:28
|
*** rafa has quit IRC
|