| 00:38:19 | *** wyclif has joined #openmrs |
| 02:33:48 | *** jriley has quit IRC |
| 03:04:46 | *** upul` has joined #openmrs |
| 03:04:46 | *** ChanServ sets mode: +v upul` |
| 03:24:33 | *** surangak has joined #openmrs |
| 04:03:08 | *** bwolfe has joined #openmrs |
| 04:03:08 | *** ChanServ sets mode: +o bwolfe |
| 04:04:46 | <surangak> greetings early bird :P |
| 04:06:23 | *** sunbiz has joined #openmrs |
| 04:06:23 | *** ChanServ sets mode: +v sunbiz |
| 04:13:35 | *** surangak_ has joined #openmrs |
| 04:13:35 | *** surangak has quit IRC |
| 05:36:20 | <bwolfe> surangak_, am I the early bird you are referring to? |
| 05:36:30 | <surangak_> bwolfe, yeahhh |
| 05:36:43 | <surangak_> bwolfe, u r really early.. mm are u still in Kenya ? |
| 05:37:07 | <bwolfe> yeah |
| 06:01:02 | *** surangak_ has quit IRC |
| 06:01:02 | *** surangak__ has joined #openmrs |
| 06:09:05 | *** sunbiz has quit IRC |
| 06:41:37 | *** dkayiwa has joined #openmrs |
| 07:02:10 | *** dkayiwa has quit IRC |
| 07:02:49 | *** dkayiwa has joined #openmrs |
| 07:30:14 | <surangak__> mmm hi guys, if I'm right, google code-in started yesterday right ? |
| 07:30:30 | <surangak__> but I didnt see any new students comming this way yet ? |
| 07:30:41 | <surangak__> (just being curious.. and curioser...) |
| 07:30:50 | <bwolfe> surangak__, link? |
| 07:30:55 | <bwolfe> do we have any code-in-ers? |
| 07:31:18 | <surangak__> bwolfe, http://google-opensource.blogspot.com/2011/11/and-were-off-google-code-in-contest.html |
| 07:31:20 | <OpenMRSBot> <http://ln-s.net/9MTj> (at google-opensource.blogspot.com) |
| 07:31:48 | <surangak__> bwolfe, since we got selected to participate, there should be kids comming this way, right ? |
| 07:31:56 | <bwolfe> I dunno |
| 07:32:09 | <surangak__> :( |
| 07:32:34 | <surangak__> I waz looking forward to seeing someone junior to me around :D |
| 07:32:39 | <surangak__> never mind... :) |
| 08:08:59 | <bwolfe> surangak__, we're not in gci: http://www.google-melange.com/gci/accepted_orgs/google/gci2011 |
| 08:10:37 | <surangak__> bwolfe, :( |
| 08:10:45 | <surangak__> bwolfe, teribly sorry, my mistake |
| 08:11:02 | <surangak__> I had automatically assumed that we'd be in code-in :( |
| 08:11:15 | <bwolfe> no worries |
| 08:15:53 | *** bryq has joined #openmrs |
| 08:15:53 | *** ChanServ sets mode: +v bryq |
| 08:22:54 | *** lh has joined #openmrs |
| 08:38:30 | *** dkayiwa_ has joined #openmrs |
| 08:38:40 | *** dkayiwa has quit IRC |
| 08:38:40 | *** dkayiwa_ is now known as dkayiwa |
| 08:53:59 | *** bryq has quit IRC |
| 09:02:18 | *** dkayiwa_ has joined #openmrs |
| 09:03:24 | *** dkayiwa has quit IRC |
| 09:03:24 | *** dkayiwa_ is now known as dkayiwa |
| 09:03:49 | *** r0bby has joined #openmrs |
| 09:03:49 | *** ChanServ sets mode: +v r0bby |
| 10:45:46 | *** surangak__ has quit IRC |
| 10:59:35 | *** bwolfe has quit IRC |
| 11:16:27 | *** upul` has left #openmrs |
| 12:10:58 | *** rafa has joined #openmrs |
| 12:10:58 | *** ChanServ sets mode: +v rafa |
| 12:13:44 | *** james_regen has joined #openmrs |
| 12:13:44 | *** ChanServ sets mode: +v james_regen |
| 12:16:52 | *** dkayiwa has quit IRC |
| 13:02:10 | *** mnunez has joined #openmrs |
| 13:31:36 | *** jriley has joined #openmrs |
| 14:13:46 | *** dawn_ has joined #openmrs |
| 14:13:47 | <dawn_> r |
| 14:14:07 | *** ChanServ sets mode: +v dawn_ |
| 14:32:05 | *** mnunez has left #openmrs |
| 14:32:16 | *** jriley has quit IRC |
| 14:34:11 | *** jriley has joined #openmrs |
| 14:34:41 | *** jriley_ has joined #openmrs |
| 14:34:41 | *** jriley has quit IRC |
| 14:34:42 | *** jriley_ is now known as jriley |
| 14:35:21 | *** jriley_ has joined #openmrs |
| 14:35:21 | *** jriley has quit IRC |
| 14:35:22 | *** jriley_ is now known as jriley |
| 14:35:41 | *** jriley has quit IRC |
| 14:35:58 | *** jriley has joined #openmrs |
| 14:44:03 | *** jriley_ has joined #openmrs |
| 14:45:49 | *** jriley has quit IRC |
| 14:45:52 | *** jriley_ is now known as jriley |
| 15:04:27 | <djazayeri> hi rafa, wyclif, dawn_ |
| 15:04:43 | <rafa> hi |
| 15:04:44 | <djazayeri> no bwolfe or dkayiwa now... |
| 15:05:23 | <dawn_> hi |
| 15:05:35 | <dawn_> haven't heard/seen ben online at all this morning |
| 15:06:42 | <wyclif> hi |
| 15:06:54 | <djazayeri> should we wait for one of them to scrum? |
| 15:06:57 | <djazayeri> or just go now? |
| 15:08:03 | <dawn_> let's just go nowâ¦.maybe they can update us on here later or send an email with updates |
| 15:08:18 | *** r0bby has quit IRC |
| 15:08:26 | <djazayeri> alright |
| 15:08:30 | <djazayeri> rafa: want to go first? |
| 15:08:35 | <rafa> sure :) |
| 15:08:42 | <rafa> Today: |
| 15:08:42 | <rafa> * Worked on TRUNK-2588: Generic mechanism for doing Attributes and Attribute Types on many classes. (Review code, and Refactor.) |
| 15:08:42 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2588 (will upload a patch later today) |
| 15:08:42 | <rafa> Tomorrow: |
| 15:08:42 | <rafa> * Design call (my solution for TRUNK-2588 needs to be discussed) |
| 15:08:42 | <rafa> * TRUNK-2588: Generic mechanism for doing Attributes and Attribute Types on many classes. (Review code, and Refactor.) |
| 15:08:42 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2588 |
| 15:08:43 | <rafa> No blockers. |
| 15:09:34 | <djazayeri> rafa: do you have work to continue doing until the design call? |
| 15:09:58 | <rafa> ohh yes, I meant TRUNK-2879: Cannot add new visit when my locale is English (United States) |
| 15:09:59 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2879 for tomorrow |
| 15:10:37 | <djazayeri> rafa: okay, great. It didn't seem like you needed to work on TRUNK-2588 straight through until the discussion |
| 15:11:10 | <djazayeri> rafa: please send an email to the dev list summarizing the question to discuss on the design call. |
| 15:11:21 | <rafa> djazayeri: cool |
| 15:11:39 | <djazayeri> regarding the can't add visit in locale en_us, did you verify that it's broken specifically for that locale? |
| 15:12:34 | <rafa> djazayeri: I wasn't able to reproduce it yet |
| 15:12:34 | <djazayeri> rafa: ^^ |
| 15:12:46 | <djazayeri> rafa: haven't tried? or tried and couldn't? |
| 15:13:02 | <rafa> djazayeri: tried and couldn't |
| 15:13:16 | <rafa> djazayeri: but I'll try again tomorrow |
| 15:13:49 | <djazayeri> Interesting. Please comment that you couldn't, and ask Daniel to provide better instructions. |
| 15:14:00 | <djazayeri> wyclif: your turn |
| 15:14:02 | <rafa> okay |
| 15:15:32 | <wyclif> yesterday: |
| 15:15:32 | <wyclif> -TRUNK-2866 - Error when adding a second identifier |
| 15:15:32 | <wyclif> -TRUNK-2853 - Worked on but it was taking up much of my time to get to the root cause and get it fixed |
| 15:15:32 | <wyclif> -Fix review comments for TRUNK-2838 and created follow up tickets |
| 15:15:32 | <wyclif> -Closing pending review and tickets from last sprint |
| 15:15:33 | <wyclif> -Testing the new module config file DTD |
| 15:15:35 | <wyclif> today: |
| 15:15:37 | <wyclif> -TRUNK-2716 - Cannot submit an encounter form |
| 15:15:39 | <wyclif> -other sprint tickets |
| 15:15:41 | <wyclif> blockers: none |
| 15:16:44 | <djazayeri> !ticket TRUNK-2853 |
| 15:16:45 | <OpenMRSBot> djazayeri: [#TRUNK-2853] Fix the progress bars on the progess page for the test installation - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2853 |
| 15:16:54 | <djazayeri> !ticket TRUNK-2838 |
| 15:16:55 | <OpenMRSBot> djazayeri: [#TRUNK-2838] Initialization Wizard should let you test a username and password for fetching production data via the Release Testing Helper module - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2838 |
| 15:18:14 | <djazayeri> wyclif: thanks for getting the last-sprint tickets off your place |
| 15:18:18 | <djazayeri> place -> plate. |
| 15:18:32 | <wyclif> ok |
| 15:18:53 | <djazayeri> wyclif: why is TRUNK-2838 in Pre-commit review? |
| 15:19:06 | <djazayeri> can you fix the ticket status? |
| 15:19:50 | <wyclif> sure |
| 15:20:54 | <djazayeri> Okay. My report is that I reviewed several needs-review tickets for the current sprint |
| 15:21:32 | <djazayeri> and I'm doing some planning / proposal writing for some OpenMRS application work. |
| 15:21:47 | <djazayeri> no blockers |
| 15:23:07 | <wyclif> djazayeri, great |
| 15:23:19 | <djazayeri> I will do some more reviews. |
| 15:23:31 | <djazayeri> okay everyone, that was a quick sprint, since we're missing half the team. |
| 15:24:01 | <djazayeri> wyclif, rafa: do you feel like you have a good handle on what you're supposed to be working on? |
| 15:24:12 | <djazayeri> given the "rolling sprint transition"? |
| 15:24:49 | <wyclif> i would be good to fix any unfinished tickets from the last sprint in this sprint if we get done with the higher priority ones in time since that work is typically part of a.9 |
| 15:25:15 | <rafa> djazayeri: yeah I'm fine |
| 15:25:16 | *** jriley has quit IRC |
| 15:25:38 | *** ada_ has joined #openmrs |
| 15:25:41 | <wyclif> djazayeri, i'm picking high priority tickets from the dashboard, if i need more info, i will get in tuch |
| 15:25:50 | <wyclif> touch |
| 15:25:51 | <djazayeri> wyclif, rafa: once you've cleared the in-progress tickets from last sprint (which you've both done), then pick tickets from the current sprint. |
| 15:26:00 | <wyclif> djazayeri, sure |
| 15:26:23 | <djazayeri> we'll move things from last sprint's fixVersion to this one as needed. |
| 15:26:25 | <djazayeri> cool. |
| 15:26:28 | <djazayeri> scrum finished |
| 15:26:30 | <djazayeri> thanks! |
| 15:26:38 | <wyclif> ttyl |
| 15:27:06 | *** ada__ has joined #openmrs |
| 15:29:44 | <dawn_> thnx |
| 15:35:44 | *** dawn_ has quit IRC |
| 15:39:04 | *** ada_ has quit IRC |
| 15:45:34 | *** dkayiwa has joined #openmrs |
| 15:48:03 | *** dawn_ has joined #openmrs |
| 15:48:03 | *** ChanServ sets mode: +v dawn_ |
| 15:48:06 | *** james_regen has quit IRC |
| 16:10:07 | <wyclif> hi djazayeri , FYI i never fixed TRUNK-2853 |
| 16:10:53 | <wyclif> djazayeri, it has a strange problem which i didnt want to spend on much time |
| 16:11:49 | <wyclif> djazayeri, though i think it is from the clientside/scripts |
| 16:13:20 | <djazayeri> !ticket trunk-2853 |
| 16:13:21 | <OpenMRSBot> djazayeri: [#TRUNK-2853] Fix the progress bars on the progess page for the test installation - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2853 |
| 16:13:41 | <djazayeri> wyclif: better not to waste time on it. |
| 16:13:45 | <djazayeri> good choice |
| 16:14:25 | <wyclif> djazayeri, sorry! i should have included this detailed info in my report |
| 16:14:49 | <djazayeri> np, I noticed that you unassigned yourself from the ticket |
| 16:27:07 | *** dawn_ has quit IRC |
| 16:38:17 | *** james_regen has joined #openmrs |
| 16:38:17 | *** ChanServ sets mode: +v james_regen |
| 16:54:57 | *** suranga has joined #openmrs |
| 17:05:06 | *** james_regen has quit IRC |
| 17:06:20 | *** gauravpaliwal has joined #openmrs |
| 17:06:20 | *** ChanServ sets mode: +v gauravpaliwal |
| 17:13:47 | *** suranga_ has joined #openmrs |
| 17:14:48 | *** suranga has quit IRC |
| 17:16:12 | *** suranga_ has quit IRC |
| 17:16:14 | *** suranga has joined #openmrs |
| 17:21:26 | *** james_regen has joined #openmrs |
| 17:21:26 | *** ChanServ sets mode: +v james_regen |
| 17:23:06 | *** rafa has quit IRC |
| 17:29:46 | <suranga> james_regen, helooo |
| 17:29:53 | <suranga> james_regen, r u there :) |
| 17:36:35 | *** gauravpaliwal has left #openmrs |
| 17:41:06 | *** james_regen has quit IRC |
| 17:52:30 | *** suranga has quit IRC |
| 17:57:31 | *** bryq has joined #openmrs |
| 17:57:31 | *** ChanServ sets mode: +v bryq |
| 17:58:18 | *** jriley has joined #openmrs |
| 18:00:05 | *** bwolfe has joined #openmrs |
| 18:00:05 | *** ChanServ sets mode: +o bwolfe |
| 18:14:26 | *** james_regen has joined #openmrs |
| 18:14:26 | *** ChanServ sets mode: +v james_regen |
| 18:15:05 | *** suranga has joined #openmrs |
| 18:15:38 | *** kishoreyekkanti has joined #openmrs |
| 18:20:45 | *** dawn_ has joined #openmrs |
| 18:20:45 | *** ChanServ sets mode: +v dawn_ |
| 18:28:20 | <bwolfe> wyclif, are you reallying working on the "openmrs cannot start" ticket ? |
| 18:29:36 | *** rafa has joined #openmrs |
| 18:29:36 | *** ChanServ sets mode: +v rafa |
| 18:29:53 | <bwolfe> wyclif.... |
| 18:31:28 | <bwolfe> ok, stealing the ticket from you |
| 18:31:31 | <bwolfe> :-D |
| 18:32:44 | <jriley> I have a question about running openmrs from eclipse with jetty |
| 18:33:02 | <jriley> When I started it up, it went looking for an openmrs-properties file, and seemed to find my "production" installation |
| 18:33:28 | <jriley> fortunately my db was offline. That would have been ugly. |
| 18:33:43 | <jriley> How can I ensure it doesn't touch the wrong database? |
| 18:33:51 | *** suranga has quit IRC |
| 18:34:13 | <djazayeri> jriley: one option is to go into pom.xml and change the webapp.name to something other than "openmrs" |
| 18:34:16 | <djazayeri> e.g. "openmrsjetty" |
| 18:34:38 | <djazayeri> then it will deploy as localhost/openmrsjetty, and also look for an openmrsjetty-runtime.properties instead of just openmrs-runtime.properties |
| 18:35:15 | <jriley> If it doesn't find one, it'll go through an installation, correct? |
| 18:35:21 | <djazayeri> jriley: yup |
| 18:35:46 | <dkayiwa> jriley: i think another option is that you could put a runtime properties file under the webapp project |
| 18:35:46 | <djazayeri> bwolfe: did I break the unit tests? or does it have to do with the webapp-testing merge? |
| 18:35:52 | <jriley> Sweet. So, some overhead the first time, and then it'll keep doing the right thing |
| 18:36:06 | <bwolfe> djazayeri, it was your commit last night that started it |
| 18:36:17 | <djazayeri> bwolfe: okay, I'll check, thanks for the pointer. |
| 18:36:28 | <bwolfe> djazayeri, the webapp testing merge only broke the openmrs startup. the code changes for it were insignificant and didn't affect tests |
| 18:36:55 | <bwolfe> jriley, it asks you if you want to update too |
| 18:37:15 | <bwolfe> the reason we put that in there was because it autoupdated a dev's db that he didn't want to update one time! :-/ |
| 18:37:19 | <jriley> Ah, I thought it ran the update scripts automatically |
| 18:37:37 | <bwolfe> djazayeri, I only sent that to you because I know you ignore all the ci emails now :-p |
| 18:37:38 | <jriley> I'm feeling less and less paranoid |
| 18:37:57 | <jriley> ( speaking of which, this is a fine time for a backup) |
| 18:38:23 | <bwolfe> jriley, you can tell it to do that if you want. there is a runtime property you can set in your file to have it do that...but we don't rec it for this exact reason unless you know what you're doing. (our demo site uses the "run all updates" rp) |
| 18:39:20 | <jriley> I turned that off a long time ago. :) But when I run the OpenMRS API with scripts, it will go through liquibase updates |
| 18:40:55 | *** suranga has joined #openmrs |
| 18:44:03 | <wyclif> hi bwolfe |
| 18:44:18 | <wyclif> bwolfe, i already have it fixed |
| 18:44:31 | <bwolfe> wyclif, no, I already fixed it... |
| 18:44:32 | <wyclif> bwolfe, i just hadn't yet committed it |
| 18:44:37 | <bwolfe> ah |
| 18:44:42 | <bwolfe> well, u2slow |
| 18:44:47 | <bwolfe> :-D |
| 18:45:13 | <bwolfe> I committed it already. I don't like leaving trunk in an unacceptable state for long. so things like that should be fixed as quickly as possible |
| 18:45:39 | <wyclif> ok |
| 18:51:39 | <wyclif> djazayeri, i have successfully upgraded from 1.6 to 1.9 thought this was with demo data, took so long even on this small database |
| 18:52:05 | <djazayeri> wyclif: after committing a fix for the bug I found? Or are you saying that my bug doesn't apply to all data? |
| 18:52:57 | *** suranga has quit IRC |
| 18:54:18 | *** suranga has joined #openmrs |
| 18:54:21 | <djazayeri> bwolfe: committed a fix for my bad commit earlier. (The test ran right in eclipse. sigh.) Thanks for pointing it out. |
| 18:58:54 | <wyclif> it was off trunk with your bug fix, but i believe it would apply to some datasets, i just thought there were other issues you were aware of that would make it fail |
| 19:00:15 | *** suranga_ has joined #openmrs |
| 19:02:24 | *** suranga__ has joined #openmrs |
| 19:03:09 | *** suranga_ has quit IRC |
| 19:03:52 | *** suranga has quit IRC |
| 19:04:03 | <james_regen> suranga__: hi i'm here now |
| 19:08:15 | *** suranga has joined #openmrs |
| 19:11:03 | <wyclif> djazayeri, it was off trunk with your bug fix, but i believe it would apply to some datasets, i just thought there were other issues you were aware of that would make it fail |
| 19:11:32 | *** suranga__ has quit IRC |
| 19:14:25 | *** suranga_ has joined #openmrs |
| 19:14:53 | <suranga_> hi james_regen , sorry I was away |
| 19:15:26 | <james_regen> suranga_: no problem. i was at lunch earlier |
| 19:15:31 | <suranga_> james_regen, I was looking at https://tickets.openmrs.org/browse/PTM-32 |
| 19:15:43 | <suranga_> which Ada had asked if we can fix |
| 19:16:19 | <suranga_> it seems that the change needed to fix this must be done in the trunk, and not our patient matching module |
| 19:16:33 | <suranga_> (to the mergepatientsform.jsp page) |
| 19:16:58 | <suranga_> so im wondering If ada can use this change even if I were to fix it... |
| 19:17:35 | *** suranga has quit IRC |
| 19:17:58 | <james_regen> suranga_: i don't know how easily they can upgrade their system. if it's important they might upgrade |
| 19:18:28 | <suranga_> james_regen, wooops, I will ask ada about that.. |
| 19:18:42 | <suranga_> and I also need to ask her if some other changes we made r working |
| 19:19:18 | <james_regen> suranga_: thanks for helping out so much, i've been busy with a few other things |
| 19:19:31 | <james_regen> i also spoke to shaun, he should be getting in touch about the MI calculations |
| 19:20:50 | <suranga_> james_regen, sure, no problem... |
| 19:21:19 | <suranga_> and by the way, I just realized the significance of your nickname... all these days I was thinking that 'regen' was your middle name :-) |
| 19:22:35 | <james_regen> yup, not very creative |
| 19:25:05 | <suranga_> james_regen, I'll be going offline for a while now (home work assignment to finish) shall I see you on monday again ? |
| 19:25:56 | *** jwishnie has quit IRC |
| 19:26:02 | *** suranga has joined #openmrs |
| 19:29:25 | *** suranga_ has quit IRC |
| 19:31:36 | <james_regen> suranga: yup, i'll be here monday |
| 19:37:10 | <suranga> james_regen, awesomee.. will do.. |
| 19:40:01 | *** kishoreyekkanti has quit IRC |
| 19:40:42 | *** jwishnie has joined #openmrs |
| 20:03:44 | *** lh has quit IRC |
| 20:05:04 | *** james_regen has quit IRC |
| 20:05:17 | *** suranga has quit IRC |
| 20:53:03 | <djazayeri> jriley: |
| 20:53:11 | <jriley> Yes? |
| 20:53:17 | <djazayeri> regarding TRUNK-2846 (Delete vs Void) |
| 20:53:29 | <djazayeri> do you have time to go through and change most instances of Void to Delete? |
| 20:53:43 | <djazayeri> if so, that's what I'd prefer to see happen. |
| 20:54:02 | <djazayeri> if not, we can just change "Delete Visit" -> "Void Visit" |
| 20:54:14 | <jriley> So the correct language is Delete ---> Delete Forever, and Void ---> Delete everywhere? |
| 20:54:49 | <djazayeri> Purge -> Delete Forever |
| 20:55:17 | <djazayeri> If we've currently used Delete anywhere, I think it requires checking whether that's actually doing a Void or a Purge |
| 20:57:00 | <jriley> I'd prefer to work on TRUNK-2664 |
| 20:57:16 | <djazayeri> !ticket trunk-2664 |
| 20:57:17 | <OpenMRSBot> djazayeri: [#TRUNK-2664] Change the priority when setting a preferred name for a concept - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2664 |
| 20:57:41 | <jriley> This calls for grep |
| 20:57:47 | <djazayeri> ok |
| 20:58:34 | <djazayeri> want to do the quick-fix for the Delete/Void ticket, which is to change the terminology in Visit from Delete -> Void. (I.e. ugly, but consistent) |
| 20:58:45 | <jriley> yes, and take more time to be thorough with the full fix |
| 20:58:50 | <djazayeri> yup |
| 20:59:59 | <jriley> Is there a way to see what changeset a patch file was applied in? Is that something tracked automatically, or is it up to the applier to make a comment? |
| 21:00:35 | <djazayeri> if the ticket number is mentioned in the commit (which it should be, but isn't 100% of the time) you can see that commit in the Source tab. |
| 21:00:45 | <djazayeri> nothing specifically tracks the patch it came from |
| 21:00:53 | <djazayeri> gotta take a call now |
| 21:01:51 | <jriley> k, thanks |
| 21:44:03 | *** dawn_ has quit IRC |
| 21:52:27 | *** jwishnie has quit IRC |
| 21:54:44 | *** bryq has quit IRC |
| 22:03:02 | *** jwishnie has joined #openmrs |
| 22:03:39 | *** jwishnie has joined #openmrs |
| 22:11:06 | *** jwishnie has quit IRC |
| 22:22:25 | *** jriley has quit IRC |
| 22:25:56 | <djazayeri> hi dkayiwa |
| 22:26:04 | <dkayiwa> hi djazayeri |
| 22:26:15 | <djazayeri> I just read your comment on TRUNK-2878,. |
| 22:26:19 | <dkayiwa> ok |
| 22:26:32 | <djazayeri> Are you testing this by upgrading a <=1.8 database? |
| 22:26:47 | <dkayiwa> djazayeri: no |
| 22:26:54 | <dkayiwa> doing a brand new install |
| 22:27:04 | <dkayiwa> djazayeri: which also has the same problem |
| 22:27:07 | <djazayeri> because I believe that if you do a brand new install, this changeset will not get hit due to its precondition. |
| 22:27:24 | <dkayiwa> djazayeri: ok |
| 22:27:41 | <dkayiwa> djazayeri: so that means we need to fix also for the brand new install |
| 22:28:05 | <djazayeri> dkayiwa: if you look at id="20110301-1030b" |
| 22:28:07 | <dkayiwa> djazayeri: all boolean default values are removed for brand new install |
| 22:28:27 | <djazayeri> hmm |
| 22:28:29 | <djazayeri> interesting |
| 22:28:47 | <djazayeri> we need to figure out if that's caused by one of Saptarshi's plugins, or if that's a bug in liquibase 2.x |
| 22:28:51 | <dkayiwa> djazayeri: and its all because of the defaultValue changing from "0" to "false" |
| 22:29:09 | <dkayiwa> djazayeri: when we take it back to "0" it works |
| 22:29:14 | <djazayeri> ah |
| 22:29:36 | <djazayeri> so, if you're doing a brand-new install, you're not going to hit the changeset 20110301-1030b-fix |
| 22:29:42 | <dkayiwa> ok |
| 22:29:44 | <djazayeri> at least I don't think you will |
| 22:29:49 | <dkayiwa> ok makes sense |
| 22:29:55 | <djazayeri> actuallyâ¦it doesn't have a precondition |
| 22:30:01 | <dkayiwa> ok |
| 22:30:12 | <djazayeri> but I can imagine that it might not hit that code because the column is already of that given type. |
| 22:30:31 | <dkayiwa> ok |
| 22:32:26 | <dkayiwa> djazayeri: for the changeset am hitting, could you be knowing why defaultValue is null? |
| 22:32:50 | <djazayeri> dkayiwa: do you need to be looking at defaultValueBoolean? |
| 22:33:34 | <dkayiwa> djazayeri: let me try that] |
| 23:04:46 | <dkayiwa> djazayeri: thanks for the pointer. It led me to the actual solution. :) |
| 23:05:20 | <djazayeri> great! |
| 23:24:31 | *** rafa has quit IRC |
| 23:35:14 | *** dkayiwa has quit IRC |
| 23:59:59 | *** r0bby_ has joined #openmrs |
| 23:59:59 | *** ChanServ sets mode: +v r0bby_ |