| 00:00:06 | <djazayeri> r-friedman: that's the problem that I just ran into while trying to do the same thing. |
| 00:00:07 | <r-friedman> +1 for that |
| 00:00:15 | <djazayeri> I'm not sure if you're stuck on exactly the same thing or something differen.t |
| 00:00:50 | <r-friedman> if i haven't screwed up my POMs by editing them too many times, i think we're at the same place |
| 00:00:52 | <djazayeri> would you mind emailing the dev list and say that you weren't able to build a module that depends on webservices.rest because the jars aren't published to the openmrs maven repo, and ask for it to be done? |
| 00:01:02 | <djazayeri> I've gotta run now, but someone should do this next week. |
| 00:01:06 | <r-friedman> do you need me to write up a ticket about it |
| 00:01:56 | <djazayeri> Sure, write up a ticket in the RESTWS project, and include a link to it in your email. |
| 00:02:01 | <djazayeri> gotta run |
| 00:02:06 | <r-friedman> tks have fun |
| 00:02:24 | <djazayeri> (the method I mentioned above should probably work, but will be a bit tediousâcopy, rename, manually install as jar) |
| 00:04:06 | *** jwishnie has joined #openmrs |
| 00:42:25 | *** burke has quit IRC |
| 02:37:50 | *** r-friedman has quit IRC |
| 02:43:45 | *** jwishnie has quit IRC |
| 03:22:57 | *** upul` has joined #openmrs |
| 03:22:57 | *** ChanServ sets mode: +v upul` |
| 05:27:00 | *** surangak has joined #openmrs |
| 05:39:15 | *** jwishnie has joined #openmrs |
| 06:55:45 | *** bryq has joined #openmrs |
| 06:55:45 | *** ChanServ sets mode: +v bryq |
| 06:59:12 | *** bryq has quit IRC |
| 07:27:16 | *** dkayiwa has joined #openmrs |
| 08:07:33 | *** lh has joined #openmrs |
| 08:13:23 | *** sunbiz has joined #openmrs |
| 08:13:23 | *** ChanServ sets mode: +v sunbiz |
| 08:24:50 | *** jmwogi has joined #openmrs |
| 08:41:15 | *** jwishnie has quit IRC |
| 09:01:05 | *** surangak_ has joined #openmrs |
| 09:01:05 | *** surangak has quit IRC |
| 09:08:29 | *** robbyoconnor has quit IRC |
| 09:09:01 | *** r0bby has joined #openmrs |
| 09:09:01 | *** ChanServ sets mode: +v r0bby |
| 09:11:15 | *** surangak__ has joined #openmrs |
| 09:11:15 | *** surangak_ has quit IRC |
| 09:17:00 | *** sunbiz has quit IRC |
| 10:20:56 | *** bwolfe has joined #openmrs |
| 10:20:56 | *** ChanServ sets mode: +o bwolfe |
| 10:22:23 | <dkayiwa> hi bwolfe |
| 10:33:16 | <bwolfe> hi dkayiwa |
| 10:33:41 | <dkayiwa> welcome back bwolfe how did it go? |
| 10:34:30 | <bwolfe> it went well. the judge agreed to give us a travel order. so now we just need to get the us to agree and grant a temp visa for eden |
| 10:34:50 | <dkayiwa> oh thats nice. :) |
| 10:35:06 | <bwolfe> although there is a slim chance we might be done with the adoption before jan, so we might not even need the travel order! (but its good to have as a backup) |
| 10:35:21 | <dkayiwa> ok |
| 10:37:22 | <dkayiwa> bwolfe: is there any way i tell which openmrs version am running, from a module? |
| 10:41:44 | <bwolfe> dkayiwa, OpenmrsConstants.VERSION |
| 10:41:47 | <bwolfe> or something |
| 10:42:00 | <bwolfe> jmwogi, I'm around now. did you get your questions answered? |
| 10:43:02 | <dkayiwa> ok |
| 10:45:43 | *** kishoreyekkanti has joined #openmrs |
| 10:47:01 | <kishoreyekkanti> bwolfe: Hey Ben, I've created the ticket TRUNK-2881 for merging webapp testing branch to Trunk. Once you complete this I can work on TRUNK-2654. |
| 10:47:19 | <kishoreyekkanti> !ticket-TRUNK-2881 |
| 10:47:20 | <OpenMRSBot> kishoreyekkanti: Error: "ticket-TRUNK-2881" is not a valid command. |
| 10:47:34 | <kishoreyekkanti> !ticket TRUNK-2881 |
| 10:47:35 | <OpenMRSBot> kishoreyekkanti: [#TRUNK-2881] Merge Webapp testing branch with Trunk - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2881 |
| 10:47:54 | <kishoreyekkanti> !ticket TRUNK-2654 |
| 10:47:55 | <OpenMRSBot> kishoreyekkanti: [#TRUNK-2654] Add ability to test bundled modules in APPTEST - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2654 |
| 10:54:03 | <bwolfe> kishoreyekkanti, ok |
| 10:54:24 | <kishoreyekkanti> bwolfe: tq :) |
| 11:02:50 | *** surangak__ has quit IRC |
| 11:33:29 | *** upul` has quit IRC |
| 11:44:07 | <jmwogi> When a person(patient) is created in a remote site that uses RemoteFormEntry module to transmit data to central server, is the person UUID same in both servers? |
| 11:45:38 | <bwolfe> jmwogi, it should be. the uuid should be in the infopath data that comes back. If for some reason the uuid is not in the forms, then the person will get a new uuid (and that is really bad) |
| 11:46:04 | <bwolfe> jmwogi ^^ |
| 11:46:35 | <jmwogi> I need to be sure on this because Household module uses person UUID and its getting rolled out to remote sites |
| 11:48:26 | <jmwogi> Ben, does the registration module generate xmls for processing in the central server? |
| 11:49:01 | <bwolfe> jmwogi, I'm not sure how it works. I never worked on that one. |
| 11:49:35 | <bwolfe> does it create a "dummy" form ? |
| 11:49:46 | <bwolfe> check that dummy form to make sure it has a spot for person.uuid in its xml |
| 12:02:50 | <jmwogi> ok |
| 12:05:38 | *** kishoreyekkanti_ has joined #openmrs |
| 12:05:53 | *** kishoreyekkanti has quit IRC |
| 12:05:53 | *** kishoreyekkanti_ has quit IRC |
| 12:06:12 | *** kishoreyekkanti has joined #openmrs |
| 12:22:46 | *** james_regen has joined #openmrs |
| 12:22:46 | *** ChanServ sets mode: +v james_regen |
| 12:34:58 | <jmwogi> bwolfe, has uuid |
| 12:35:07 | <jmwogi> i.e. dummy form |
| 12:35:18 | <jmwogi> so my problem solved |
| 12:35:43 | <bwolfe> jmwogi, what was your problem?> |
| 12:35:52 | *** wyclif has quit IRC |
| 12:36:33 | <jmwogi> Recreation of patients from remote sites to central - do they have same uuid? Yes it does |
| 12:38:29 | <bwolfe> jmwogi, did you test it? jeremy found a weird occurance this week with your data showing that a lot of patients that should have the same uuid have diff uuids... |
| 13:01:01 | <bwolfe> dkayiwa, I'm off for a while. bbl tonight |
| 13:01:08 | <dkayiwa> ok |
| 13:02:15 | <jmwogi> i checked a dummy form |
| 13:22:50 | *** kishoreyekkanti has quit IRC |
| 13:23:51 | *** kishoreyekkanti has joined #openmrs |
| 13:26:23 | *** kishoreyekkanti_ has joined #openmrs |
| 13:27:52 | *** lh has quit IRC |
| 13:28:04 | *** kishoreyekkanti has quit IRC |
| 13:28:04 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 13:29:57 | *** wyclif has joined #openmrs |
| 13:34:45 | *** dawn_ has joined #openmrs |
| 13:58:17 | *** ChanServ sets mode: +v dawn_ |
| 14:02:28 | *** jmwogi has quit IRC |
| 14:07:47 | *** jriley has joined #openmrs |
| 14:08:00 | *** downeym has joined #openmrs |
| 14:08:00 | *** ChanServ sets mode: +o downeym |
| 14:08:00 | *** OpenMRSBot sets mode: +o downeym |
| 14:08:59 | <jriley> dkayiwa, TRUNK-2678 can be closed as As Designed. I don't have an option to close the bug |
| 14:10:16 | <dkayiwa> ok thank jriley |
| 14:10:23 | <jriley> Has anyone triaged TRUNK-2866 ? |
| 14:10:35 | <jriley> https://tickets.openmrs.org/browse/TRUNK-2866 |
| 14:10:35 | *** magicaltrout has quit IRC |
| 14:10:43 | <jriley> I want to make sure it's on the radar |
| 14:11:15 | <dkayiwa> not sure |
| 14:12:46 | *** magicalt1out has joined #openmrs |
| 14:12:58 | <downeym> Hi magicalt1out and welcome to the #openmrs IRC channel. |
| 14:16:33 | *** sunbiz has joined #openmrs |
| 14:16:33 | *** ChanServ sets mode: +v sunbiz |
| 14:23:26 | <dkayiwa> so jriley are you saying it was introduced in 1.9? |
| 14:23:57 | <jriley> Yes, because it wasn't reproducible on the 1.8.x on demo.openmrs.org |
| 14:24:24 | <dkayiwa> jriley: on then let me add it to this week's sprint |
| 14:25:59 | <jriley> great |
| 14:26:55 | <dkayiwa> thanks so much jriley for notifying me |
| 14:27:02 | <dkayiwa> done |
| 14:27:37 | <jriley> My pleasure. How's 1.9 going? I could spend a couple hours on it in the next few days |
| 14:28:02 | <dkayiwa> jriley: oh that would be fantastic!!!! |
| 14:28:11 | <dkayiwa> you are very welcome :) |
| 14:28:46 | <jriley> What do you need? |
| 14:29:17 | <dkayiwa> jriley: can you participate in the sprint? |
| 14:29:36 | <jriley> I'm not sure I understand the code well enough |
| 14:29:39 | <jriley> got the link for the sprint handy? |
| 14:29:44 | <jriley> I'll look at the tickets |
| 14:30:18 | *** nribeka has joined #openmrs |
| 14:30:18 | *** ChanServ sets mode: +v nribeka |
| 14:30:55 | <dkayiwa> https://wiki.openmrs.org/display/RES/2011-11-21+Development+Sprint |
| 14:40:47 | <jriley> https://tickets.openmrs.org/browse/TRUNK-2848 Visit > Add encounter explanatory text is cut off - this looks like it will be a trivial HTML change to the length of the input field. Would you agree? |
| 14:41:21 | <jriley> TRUNK-256 Preferred Patient Identifier should be required - the comments say the fix is committed and it needs a unit test. I can write unit tests |
| 14:42:27 | <dkayiwa> jriley: yes i agree |
| 14:42:28 | <jriley> dkayiwa, can I get your opinion on that? Trunk-2848? |
| 14:42:34 | <jriley> Ok. I'll take those two |
| 14:42:51 | <dkayiwa> excellent!!!! :) |
| 14:43:23 | <jriley> Assigned them to myself |
| 14:43:40 | <jriley> I'm going to get some tea while Eclipse downloads the latest from trunk |
| 14:44:39 | *** rafa has joined #openmrs |
| 14:44:39 | *** ChanServ sets mode: +v rafa |
| 14:45:56 | <dkayiwa> jriley: oh yes |
| 14:46:01 | <dkayiwa> assign to yourself |
| 14:59:17 | *** kishoreyekkanti has quit IRC |
| 15:07:05 | <djazayeri> good morning all |
| 15:07:23 | <djazayeri> hi bwolfe, rafa, dkayiwa, wyclif |
| 15:07:35 | <djazayeri> hi jriley, great to have you on board for a ticket or two |
| 15:08:50 | <wyclif> hi |
| 15:08:58 | <djazayeri> ready to scrum? |
| 15:09:07 | <dawn_> scrum time :) |
| 15:11:29 | <rafa> hi |
| 15:11:37 | <djazayeri> I'll go firs |
| 15:11:41 | <djazayeri> first |
| 15:11:42 | <djazayeri> Friday: |
| 15:11:54 | <djazayeri> * Lots of code reviews |
| 15:12:27 | <djazayeri> * Tried to go through Standalone + Release Testing workflow end-to-end. |
| 15:12:34 | <djazayeri> * Created a bunch of tickets |
| 15:13:08 | <djazayeri> * Created blocker TRUNK-2878 |
| 15:13:11 | <djazayeri> Today: |
| 15:13:20 | <djazayeri> * A ticket or two |
| 15:13:41 | <djazayeri> blockers: can't upgrade 1.6 because of TRUNK-2878. (I see that dkayiwa claimed this) |
| 15:14:20 | <dkayiwa> yes |
| 15:14:26 | <djazayeri> okay, cool |
| 15:14:29 | <djazayeri> next? |
| 15:14:32 | <dkayiwa> Looked into: Ended visit still appears in patient dashboard header list of active visits - TRUNK-2678 |
| 15:14:32 | <dkayiwa> Created an investigated: Cannot add new visit when my locale is English (United States) - TRUNK-2879 |
| 15:14:32 | <dkayiwa> Looked into and failed to reproduce: During the test install method, the wizard should allow user/password for another user other than root - TRUNK-2851 |
| 15:14:33 | <dkayiwa> Now investigating potential solution as suggested by sunbiz for: Cannot upgrade from 1.8 to 1.9 with error message "Field 'retired' doesn't have a default value" - TRUNK-2878 |
| 15:14:33 | <dkayiwa> No blockers |
| 15:16:03 | <djazayeri> dkayiwa: there are two tickets leftover from last sprint assigned to you (TRUNK-2824 and RELTEST-2) |
| 15:16:37 | <djazayeri> and they're "in progress" |
| 15:16:48 | <djazayeri> make sure to get those closed out asap. |
| 15:16:54 | <dkayiwa> !ticket RELTEST-2 |
| 15:16:55 | <OpenMRSBot> dkayiwa: [#RELTEST-2] Add a settings page for the release testing module - OpenMRS JIRA - https://tickets.openmrs.org/browse/RELTEST-2 |
| 15:17:07 | <dkayiwa> !ticket TRUNK-2824 |
| 15:17:08 | <OpenMRSBot> dkayiwa: [#TRUNK-2824] Create a project for the release testing module - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2824 |
| 15:17:18 | <dkayiwa> djazayeri: TRUNK-2824 is done |
| 15:17:46 | <djazayeri> Okay, are my comments from 11/7 addressed? |
| 15:17:53 | <dkayiwa> i should also respond to the small comments on RELTEST-2 |
| 15:18:04 | <dkayiwa> djazayeri: whats 11/7 ? |
| 15:18:05 | <dkayiwa> :) |
| 15:18:08 | <djazayeri> november 7 |
| 15:18:14 | <djazayeri> :-) |
| 15:18:17 | <dkayiwa> on which ticket? |
| 15:18:22 | <djazayeri> TRUNK-2824 |
| 15:18:33 | <dkayiwa> oh let me check |
| 15:19:01 | <rafa> may I go next? |
| 15:19:12 | <djazayeri> dkayiwa: you can check after the scrum. My main point is that I reopened those two as "Rework Needed" |
| 15:19:20 | <dkayiwa> djazayeri: ok |
| 15:19:28 | <djazayeri> so make sure to close them (either commit something, or else decide that it's fine as-is.) |
| 15:19:31 | <djazayeri> rafa: sure |
| 15:19:39 | <dkayiwa> ok |
| 15:19:39 | <rafa> Friday: |
| 15:19:39 | <rafa> * Unplanned day off. Had no power :/ |
| 15:19:39 | <rafa> Today: |
| 15:19:39 | <rafa> * Cleared my code-review list |
| 15:19:39 | <rafa> * Started with TRUNK-2879: Cannot add new visit when my locale is English (United States) |
| 15:19:40 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2879 |
| 15:19:40 | <rafa> Tomorrow: (since I'm again in CET) |
| 15:19:41 | <rafa> * Finish TRUNK-2879 |
| 15:19:41 | <rafa> * Apply my solution to TRUNK-2588: Generic mechanism for doing Attributes and Attribute Types on many classes. (Review code, and Refactor.) |
| 15:19:42 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2588 |
| 15:19:42 | <rafa> No blockers. |
| 15:20:24 | <rafa> djazayeri: no need for you to create a new patch I guess |
| 15:20:25 | <djazayeri> rafa: are you back in poland now? |
| 15:20:39 | <rafa> djazayeri: I can go back to the previous revision, apply the patch and update |
| 15:20:45 | <rafa> djazayeri: yes! |
| 15:21:07 | <djazayeri> hopefully your flight back had fewer delays than your one here! |
| 15:21:26 | <rafa> djazayeri: it was nice & smooth :) |
| 15:21:46 | <djazayeri> good! |
| 15:21:50 | <djazayeri> rafa: I would focus exclusively on TRUNK-2588 |
| 15:22:02 | <djazayeri> I suspect it won't be easy. |
| 15:22:38 | <rafa> djazayeri: okay, I'll start with it tomorrow morning so that we can look at it when you wake up |
| 15:22:45 | <djazayeri> ok |
| 15:24:21 | <djazayeri> next? |
| 15:24:24 | <djazayeri> wyclif, bwolfe? |
| 15:24:57 | <wyclif> friday: |
| 15:24:57 | <wyclif> -TRUNK-2869 - The user selected language should be persisted in test installation |
| 15:24:57 | <wyclif> -TRUNK-2853 - Fix the progress bars on the progess page for the test installation |
| 15:24:57 | <wyclif> -Need to replace the occurences of 'production' to 'remote' for the test installation wizard |
| 15:24:57 | <wyclif> -reverted the encryption stuff |
| 15:24:58 | <wyclif> -code review and cleaning up finished tickets |
| 15:25:00 | <wyclif> today: |
| 15:25:02 | <wyclif> -TRUNK-2866 - Error when adding a second identifier |
| 15:25:04 | <wyclif> -Spend the last hour finishing and closing open tickets from last sprint |
| 15:25:06 | <wyclif> -More sprint tickets |
| 15:25:08 | <wyclif> blockers: none |
| 15:25:51 | *** r-friedman has joined #openmrs |
| 15:26:31 | <djazayeri> wyclif: I see you still have two in-progress issues from last sprint |
| 15:26:53 | <djazayeri> TRUNK-2853 and TRUNK-2838 |
| 15:27:13 | <djazayeri> You should either unassign them or get them done today. |
| 15:27:32 | <wyclif> djazayeri, in my report i have said i will get them finished in the last hour today |
| 15:27:46 | <djazayeri> oh, I understood that as you *spent* the last hour. |
| 15:27:47 | <djazayeri> :-) |
| 15:28:04 | <djazayeri> wyclif: finish those before TRUNK-2866. |
| 15:28:16 | <djazayeri> (at least that's my suggestion) |
| 15:28:23 | <wyclif> djazayeri, ok |
| 15:28:26 | <djazayeri> (do them in the first hour rather than the last) |
| 15:28:27 | *** magicalt1out is now known as magicaltrout |
| 15:28:34 | <dkayiwa> :) |
| 15:29:25 | <djazayeri> downeym: btw, looks like you have a to do on TRUNK-299. (Or maybe wyclif needs to open an ITSM ticket for this?) |
| 15:29:36 | <downeym> !ticket TRUNK-299 |
| 15:29:37 | <OpenMRSBot> downeym: [#TRUNK-299] WebModuleUtil should handle DWR tags in dwr section of config.xml - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-299 |
| 15:29:50 | <djazayeri> downeym: see the last comment |
| 15:30:48 | <djazayeri> jriley: I see you picked up TRUNK-256. Thanks! |
| 15:30:56 | <jriley> np |
| 15:30:57 | <downeym> djazayeri: hm |
| 15:31:17 | <downeym> wyclif: is config-1.2.1 the same file or a different file |
| 15:34:00 | *** jwishnie has joined #openmrs |
| 15:34:33 | <djazayeri> wyclif? |
| 15:34:40 | <djazayeri> also, bwolfe, your turn |
| 15:34:56 | *** dawn_ has quit IRC |
| 15:35:30 | <r-friedman> think bw's @ dinner |
| 15:35:39 | <djazayeri> probably |
| 15:36:07 | *** rafa has quit IRC |
| 15:36:46 | <djazayeri> okay, scrum over. |
| 15:37:10 | <djazayeri> wyclif: please let downeym what you want him to do for TRUNK-299 |
| 15:37:16 | <djazayeri> talk to you all later. |
| 15:39:03 | *** r-friedman has quit IRC |
| 15:42:04 | <wyclif> djazayeri, ok |
| 15:42:42 | *** dawn_ has joined #openmrs |
| 15:42:42 | *** ChanServ sets mode: +v dawn_ |
| 15:48:33 | *** ju has joined #openmrs |
| 15:48:39 | <downeym> Hi ju and welcome to the #openmrs IRC channel. |
| 15:59:30 | <jriley> I'd like to deploy my changes to the 1.9.x standalone . The standalone shows openmrs ok, but doesn't show a page when I go to localhost:8081/manager/html |
| 15:59:44 | <jriley> what am I missing? |
| 16:00:24 | <dkayiwa> jriley: by deploying your changes, do you mean simply another war file? |
| 16:00:48 | <jriley> Yes. I built the 1.9 trunk, and I want to deploy the war file |
| 16:01:05 | <jriley> Actually this is a sanity check - I haven't even saved my changes yet, I just want to make sure it all works |
| 16:02:45 | <dkayiwa> jriley: 1) stop the standalone |
| 16:03:30 | <dkayiwa> jriley: 2) delete all files and folders in standalonefolder/tomcat/webapps |
| 16:03:49 | <dkayiwa> jriley: 3) copy the new war file into standalonefolder/tomcat/webapps |
| 16:03:57 | <jriley> Ah! there it is |
| 16:04:06 | <jriley> and I can keep the original war in another folder. Sweet |
| 16:04:08 | <dkayiwa> jriley: 4) make sure that it has the same name as the previously deleted war file |
| 16:04:29 | <dkayiwa> jriley: 5) Then start the standalone |
| 16:04:56 | <dkayiwa> jriley: you could also just run the web app from eclipse without first having to compile the war file |
| 16:05:57 | <jriley> How? I've never tried it |
| 16:06:16 | <jriley> what keyword shall I search in the wiki? |
| 16:06:41 | <jriley> promising results ... |
| 16:06:46 | <jriley> there we are |
| 16:06:59 | <dkayiwa> https://wiki.openmrs.org/display/docs/Using+the+M2Eclipse+Maven+Plugin+In+Eclipse |
| 16:07:00 | <OpenMRSBot> <http://ln-s.net/8c8D> (at wiki.openmrs.org) |
| 16:07:09 | <jriley> bingo |
| 16:07:10 | <jriley> thank you |
| 16:07:37 | <dkayiwa> jriley: you can even run it in debug mode |
| 16:07:49 | <dkayiwa> and step over, etc |
| 16:08:36 | <wyclif> hi djazayeri, bwolfe |
| 16:09:45 | <wyclif> djazayeri, bwolfe am looking at liquibase changeset '201109301703' and that precondition seems to confuse me |
| 16:09:53 | <wyclif> hi dkayiwa |
| 16:10:01 | <dkayiwa> hi wyclif |
| 16:10:13 | <wyclif> can have a look at liquibase changeset 201109301703 |
| 16:10:23 | <dkayiwa> ok |
| 16:10:49 | <wyclif> dkayiwa, do you know what that precondition is doing, i seem to be confused |
| 16:10:56 | <dkayiwa> ok |
| 16:11:19 | *** r0bby has quit IRC |
| 16:11:23 | <wyclif> dkayiwa, and for some reason i think it ever fails |
| 16:11:30 | <dkayiwa> ok |
| 16:11:35 | <wyclif> dkayiwa, so that changeset i dont think it gets run |
| 16:11:46 | <dkayiwa> ok |
| 16:17:13 | <dkayiwa> wyclif: it is complicating. am still trying to assimilate it :) |
| 16:17:44 | <wyclif> dkayiwa, it looks incorrect to me |
| 16:17:59 | <wyclif> dkayiwa, not the syntax but the logic |
| 16:18:05 | <OpenMRSBot> Recent updates in the world of openmrs: Shazin Sadakath: Arduino Google Voice Activated Servo Motor Controlling using Android <http://shazsterblog.blogspot.com/2011/11/arduino-google-voice-activated-servo.html> || OpenMRS Modules: Logic 0.5.0.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=logic&version=&0.5.0.1> |
| 16:21:34 | <dkayiwa> wyclif: the first sqlCheck makes sense |
| 16:22:18 | <wyclif> dkayiwa, correct, but the not or tags are the problem |
| 16:23:25 | <dkayiwa> wyclif: looks like it updates the address only if none of the addresses of the listed contries exists |
| 16:23:39 | <wyclif> dkayiwa, yeah |
| 16:23:54 | <wyclif> dkayiwa, but i have just noticed it never updates it |
| 16:24:01 | <dkayiwa> oh |
| 16:24:46 | <dkayiwa> wyclif: and what is the value for your layout.address.format property? |
| 16:25:43 | <wyclif> it is xml text |
| 16:26:43 | <wyclif> dkayiwa, and those sql statements seem like they expect plain text like spain, rwanda etc. |
| 16:27:04 | <dkayiwa> yes |
| 16:27:04 | <dkayiwa> wyclif: in that case it was supposed to update it |
| 16:27:28 | <dkayiwa> wyclif: oh may be it found one of those countries and then updated? |
| 16:27:51 | <dkayiwa> wyclif: but that property value, i thought it is supposed to have country key instead of the xml |
| 16:27:56 | <dkayiwa> wyclif: not so??? |
| 16:28:08 | <wyclif> dkayiwa, i guess my point is that he is selecting the template and not really the country |
| 16:28:32 | <dkayiwa> selecting = setting ? |
| 16:28:35 | <wyclif> dkayiwa, so those preconditions always return false |
| 16:29:08 | <wyclif> dkayiwa, am looking at the preconditions, he checking againt country but selecting xml template for the address |
| 16:29:24 | <wyclif> dkayiwa, am looking at the preconditions, he is checking against country but selecting xml template for the address |
| 16:29:30 | <dkayiwa> ok |
| 16:29:45 | <dkayiwa> wyclif: is layout.address.format supposed to store country or the template xml? |
| 16:30:28 | <wyclif> dkayiwa, so literally his logic is doing this if ('spain' == '<addressTemplae>...</addressTemplate>'), which will always be false |
| 16:30:43 | <dkayiwa> oh i see |
| 16:31:20 | <dkayiwa> wyclif: that is true if your layout.address.format has the template xml |
| 16:31:22 | <wyclif> djazayeri, but i recall there a property that used to store the country |
| 16:31:35 | <dkayiwa> wyclif: but for those that have country, then his logic makes sense |
| 16:32:03 | <wyclif> dkayiwa, or i think we should check in a 1.8 database |
| 16:32:09 | <wyclif> dkayiwa, his logic could be right |
| 16:32:13 | *** dawn_ has quit IRC |
| 16:32:14 | <dkayiwa> ok |
| 16:32:30 | <wyclif> dkayiwa, because we are looking the values after the changeset has been run |
| 16:33:14 | <wyclif> dkayiwa, but i wonder why it set the xml with the 'addressTemplate' as the tag instead of the fully qualified java class name |
| 16:33:33 | <dkayiwa> i have no idea why |
| 16:34:53 | <dkayiwa> wyclif: i have looked at my 1.6 database, layout.address.format is supposed to have the country |
| 16:34:58 | <dkayiwa> instead of the template xml |
| 16:35:41 | <dkayiwa> wyclif: here is the global property's description: |
| 16:35:42 | <dkayiwa> Format in which to display the person addresses. Valid values are general, kenya, rwanda, usa, and lesotho |
| 16:35:47 | <dkayiwa> :) |
| 16:36:12 | <dkayiwa> i do not see the xml listed as a valid value :) |
| 16:36:13 | <wyclif> dkayiwa, then the precondtions are correct |
| 16:36:36 | <dkayiwa> yes it is the update statement which is probably incrorrect |
| 16:36:40 | <wyclif> dkayiwa, can you run the web app? |
| 16:36:52 | <dkayiwa> wyclif: i have it running |
| 16:37:06 | <wyclif> dkayiwa, try too edit an patient |
| 16:37:14 | <wyclif> dkayiwa, try to edit an patient |
| 16:37:21 | <wyclif> dkayiwa, try to edit a patient |
| 16:37:24 | <dkayiwa> wyclif: webapp for which version? |
| 16:37:28 | <dkayiwa> i have many versions :) |
| 16:37:32 | <wyclif> 1.9 dkayiwa |
| 16:37:37 | <dkayiwa> trunk? |
| 16:37:46 | <wyclif> even trunk is fine |
| 16:37:51 | <dkayiwa> ok |
| 16:38:05 | <wyclif> there is bug where that xml template is not getting deserialized |
| 16:38:30 | <dkayiwa> wyclif: how will i see the bug? |
| 16:38:33 | <wyclif> and the reason is that my xml for the template has an invalid tag |
| 16:38:47 | <wyclif> just view the patient form |
| 16:39:04 | <wyclif> dkayiwa, and check if the address gets displayed |
| 16:39:05 | <dkayiwa> wyclif: short or long? |
| 16:39:10 | <wyclif> dkayiwa, any |
| 16:39:56 | <dkayiwa> wyclif: oh yessss |
| 16:39:58 | <dkayiwa> got it |
| 16:40:25 | <wyclif> dkayiwa, is the address displayed? |
| 16:40:39 | <dkayiwa> Error while deserializing address layout template. |
| 16:40:48 | <dkayiwa> good catch :) |
| 16:41:07 | <dkayiwa> wyclif: looks like we need a beta ticket for it |
| 16:41:39 | <wyclif> dkayiwa, do you the cause of that? |
| 16:41:46 | <jriley> Wyclif, are you working on the no second patient identifier bug? |
| 16:42:02 | <wyclif> any james_regen |
| 16:42:06 | <wyclif> jriley, any |
| 16:42:08 | <dkayiwa> wyclif: are you asking about knowing the cause of it? |
| 16:42:15 | <wyclif> sorry james_regen |
| 16:42:23 | <jriley> I haven't followed all of your discussion. I filed that bug. I also added my own address template with the new address layout management feature. I don't recall if I filed that bug before or after adding my own |
| 16:42:29 | <jriley> but i can check |
| 16:42:39 | <wyclif> jriley, yes i was but the bug is caused by something else |
| 16:42:55 | <wyclif> jriley, see the last comment i added to the ticket you created |
| 16:43:13 | <jriley> I see you mentioned address formats |
| 16:43:39 | <wyclif> jriley, when you fix the address layout, the bug is gone |
| 16:43:54 | *** ju has quit IRC |
| 16:44:17 | <jriley> And I fix the address layout by changing the initial tag, did you say? |
| 16:44:29 | <wyclif> so dkayiwa am wondering why that changeset is setting an invalid tag name |
| 16:44:48 | <wyclif> jriley, i have a feeling something never got backported to 1.9.x |
| 16:44:58 | <jriley> ok |
| 16:44:58 | <wyclif> dkayiwa, , i have a feeling something never got backported to 1.9.x |
| 16:45:12 | <dkayiwa> wyclif: in which version was it fixed? |
| 16:45:34 | <wyclif> jriley, you have to edit the opening and closing tags |
| 16:46:13 | <wyclif> dkayiwa, i think a later commit was made to fix the tag in trunk after you created 1.9.x branch |
| 16:46:31 | <dkayiwa> ok |
| 16:47:18 | <wyclif> dkayiwa, but it seems fine in 1.9.x |
| 16:47:29 | <dkayiwa> oh |
| 16:48:15 | <wyclif> dkayiwa, i have a feeling this is not a problem in 1.9.0 alpha |
| 16:48:25 | <dkayiwa> i can test it |
| 16:48:28 | <wyclif> dkayiwa, could be just in dev databases |
| 16:48:38 | <dkayiwa> wyclif: let me check |
| 16:51:49 | <dkayiwa> wyclif: alpha is fine |
| 16:52:33 | <wyclif> dkayiwa, so i think this nothing to worry about |
| 16:52:41 | <wyclif> dkayiwa, so i think this is nothing to worry about |
| 16:53:17 | <dkayiwa> wyclif: if its on trunk, isnt that a problem? |
| 16:55:19 | <wyclif> dkayiwa, it is not even in trunk |
| 16:55:30 | <dkayiwa> wyclif: oh so where is it??? |
| 16:55:42 | <wyclif> the problem is that our test data has an invalid value for the address |
| 16:55:57 | <wyclif> dkayiwa, and this is why i said it is nothing to worry about |
| 16:56:31 | <dkayiwa> wyclif: i have it in one of my databases |
| 16:56:31 | <wyclif> dkayiwa, but just to be sure i will do a fresh install and an update and make sure the bug doesn't exist |
| 16:56:55 | <wyclif> dkayiwa, i.e in trunk |
| 16:56:55 | <dkayiwa> wyclif: i think it must be a bug somewhere |
| 16:57:18 | <dkayiwa> wyclif: i have it in a database which is an upgrade from 1.6 |
| 16:57:21 | <wyclif> dkayiwa, that is why i said i will do a fresh install to see if i can find it |
| 16:57:32 | <wyclif> when did you upgrade? |
| 16:57:40 | <dkayiwa> wyclif: today |
| 16:58:22 | <wyclif> hmmm, using which war file? |
| 16:58:32 | <dkayiwa> wyclif: war file from trunk |
| 16:58:33 | <wyclif> dkayiwa, off trunk? |
| 16:58:38 | <dkayiwa> wyclif: yes |
| 16:58:44 | <wyclif> dkayiwa, then there is a bug somewhere |
| 16:58:49 | <dkayiwa> yes |
| 16:59:34 | <wyclif> dkayiwa, i think it is because even before you could specify an address template instead of a country |
| 16:59:58 | <wyclif> dkayiwa, meaning that the changeset should rename the tag for that case |
| 17:00:05 | <dkayiwa> wyclif: maybe. not sure of the actual cause |
| 17:00:10 | <dkayiwa> still looking |
| 17:00:15 | <wyclif> dkayiwa, that is it |
| 17:00:44 | <dkayiwa> wyclif: the changeset itself looks fine |
| 17:00:58 | <wyclif> dkayiwa, it is not complete |
| 17:01:33 | *** james_regen has quit IRC |
| 17:01:36 | <dkayiwa> wyclif: that does it miss? |
| 17:01:46 | <wyclif> dkayiwa, it needs to check if the property value is xml and replace the tag name for people who had an xml value as the property value |
| 17:02:12 | <dkayiwa> ok |
| 17:02:30 | <wyclif> dkayiwa, i will have to ask ben if in prior versions users were allowed to enter xml instead of country for the GP |
| 17:02:55 | <wyclif> dkayiwa, if yes then the changeset needs to take care of that |
| 17:03:12 | <dkayiwa> wyclif: correct |
| 17:03:28 | <wyclif> dkayiwa, thanks for your time |
| 17:03:36 | <dkayiwa> yo welcome |
| 17:04:06 | <wyclif> hi bwolfe, djazayeri |
| 17:10:34 | <dkayiwa> by the way wyclif |
| 17:10:47 | <dkayiwa> wyclif: do you think you can get me a t-mobile unlock code? |
| 17:13:15 | *** wyclif has quit IRC |
| 17:16:45 | *** r-friedman has joined #openmrs |
| 17:17:12 | <r-friedman> bwolfe: hi ben, got a minute? |
| 17:19:23 | <djazayeri> hi wyclfi |
| 17:19:26 | <djazayeri> oops, missed him |
| 17:20:15 | *** kishoreyekkanti has joined #openmrs |
| 17:20:16 | <r-friedman> wyclfi is the plural |
| 17:21:53 | <r-friedman> brb |
| 17:25:16 | *** wyclif has joined #openmrs |
| 17:26:27 | <r-friedman> wyclif: darius was looking for you |
| 17:29:28 | <wyclif> thanks r-friedman |
| 17:30:07 | <djazayeri> Actually I thought wyclif was looking for me. :-) |
| 17:30:16 | *** jriley has quit IRC |
| 17:30:48 | <r-friedman> irc tag |
| 17:32:08 | *** dawn_ has joined #openmrs |
| 17:32:08 | *** ChanServ sets mode: +v dawn_ |
| 17:32:30 | <wyclif> djazayeri, ? |
| 17:32:35 | <wyclif> djazayeri, i was |
| 17:33:22 | <djazayeri> okay, do you have a question? |
| 17:33:32 | <wyclif> djazayeri, before we moved the address lay out templates to the DB, would a user ve allowed to enter xm for the layout.address.format GP |
| 17:33:41 | <wyclif> be |
| 17:33:53 | <djazayeri> wyclif: no |
| 17:34:10 | <djazayeri> You used to have to specify a name of an existing one |
| 17:34:12 | <wyclif> djazayeri, only country was allowed? |
| 17:34:39 | <djazayeri> the GP was the name of one of the pre-defined layouts in openmrs-servlet.xml (usa, kenya, rwanda, lesotho, ...) |
| 17:34:59 | <wyclif> djazayeri, can you check what your value is in the DB? |
| 17:35:05 | <wyclif> djazayeri, for that GP |
| 17:36:03 | <djazayeri> for what database? |
| 17:36:32 | *** sunbiz has left #openmrs |
| 17:37:42 | <djazayeri> in a 1.6 -> "general" |
| 17:38:01 | <djazayeri> in a trunk -> it's xml |
| 17:38:05 | <djazayeri> 7 |
| 17:38:19 | <djazayeri> 1.7 and 1.7 -> "general" |
| 17:38:52 | <djazayeri> wyclif: ^^ |
| 17:40:03 | *** james_regen has joined #openmrs |
| 17:40:03 | *** ChanServ sets mode: +v james_regen |
| 17:40:37 | <wyclif> djazayeri, |
| 17:41:35 | <wyclif> djazayeri, what is the name of the root tag for the xml in trunk? |
| 17:41:59 | <djazayeri> <org.openmrs.layout.web.address.AddressTemplate> |
| 17:44:34 | <downeym> wyclif: re: TRUNK-299 does config-1.2.1.dtd need to replace config-1.2.dtd or should both exist. |
| 17:45:42 | <wyclif> i wonder why some have just addressTemplate |
| 17:46:09 | <wyclif> downeym, they should both exist |
| 17:46:41 | <wyclif> downeym, because some module developers might still be using the old one |
| 17:47:00 | <downeym> wyclif: but they are the identical content? |
| 17:47:10 | <wyclif> downeym, no they dont |
| 17:47:29 | <wyclif> downeym, we added a new tag to the DTD |
| 17:48:03 | <downeym> wyclif: ok, please create a ticket with the new file so we can track the change https://tickets.openmrs.org/secure/CreateIssue.jspa?pid=10062&issuetype=6&Create=Create |
| 17:50:50 | <djazayeri> wyclif: the issue about addressTemplate is that originally suho was doing something hacky to allow the shortened xml element names, but I disapproved of it in code review |
| 17:51:03 | <djazayeri> so we ought to have undone that. |
| 17:53:52 | <djazayeri> wyclif: <addressTemplate> should not be valid anymore |
| 17:56:27 | <wyclif> downeym, ITSM-2145 |
| 17:56:37 | <wyclif> djazayeri, so where is it coming from? |
| 17:56:43 | <downeym> wyclif: are you waiting for their answer before i should proceed? |
| 17:56:58 | <djazayeri> wyclif: for a while the code shortened it like that. but we removed that part of the code. |
| 17:57:03 | <djazayeri> it was never released, afaik |
| 17:57:17 | <wyclif> downeym, yes |
| 17:57:23 | <downeym> wyclif: ok |
| 17:57:28 | <wyclif> downeym, thanks |
| 17:57:54 | <wyclif> djazayeri, so this is only in our dev dbs |
| 17:58:04 | <djazayeri> wyclif: yeah |
| 17:59:19 | <djazayeri> wyclif: regarding the dtd, what did it used to be called? |
| 17:59:20 | <wyclif> djazayeri, this is the reason the new identifiers couldnot get added to a patient |
| 17:59:24 | <djazayeri> what are you asking? |
| 17:59:41 | <wyclif> djazayeri, it was s continuation |
| 17:59:44 | *** r-friedman has quit IRC |
| 17:59:44 | <djazayeri> Are you asking if it should be 1.2.1 or 1.3? |
| 17:59:52 | <wyclif> djazayeri, yes |
| 18:00:07 | <djazayeri> ah. is this a bugfix or feature? |
| 18:00:28 | <wyclif> new feature, we added the init tag |
| 18:00:36 | <djazayeri> okay, 1.3 |
| 18:01:57 | <dkayiwa> djazayeri: what do you mean by: Need to clean up the AdminList extension. TRUNK-2824 |
| 18:03:47 | <djazayeri> dkayiwa: did you look at the code review? (I don't remember) |
| 18:03:55 | <djazayeri> I think it was a localization issue, maybe? |
| 18:04:15 | <dkayiwa> ok |
| 18:07:47 | *** suranga has joined #openmrs |
| 18:09:05 | *** bryq has joined #openmrs |
| 18:09:05 | *** ChanServ sets mode: +v bryq |
| 18:15:07 | *** suranga_ has joined #openmrs |
| 18:18:23 | *** suranga has quit IRC |
| 18:28:16 | *** kishoreyekkanti has quit IRC |
| 18:28:39 | <dkayiwa> djazayeri: is crucible running? |
| 18:29:17 | <dkayiwa> wyclif: is crucible running for you? |
| 18:29:50 | <wyclif> dkayiwa, let me check |
| 18:29:54 | <dkayiwa> ok |
| 18:30:49 | <djazayeri> down for me |
| 18:30:58 | <downeym> dkayiwa: did you break it? :D |
| 18:31:13 | *** kishoreyekkanti has joined #openmrs |
| 18:31:18 | <dkayiwa> downeym: lollllllll no :D |
| 18:31:24 | <djazayeri> dkayiwa: by the way, there's a website for this: http://www.downforeveryoneorjustme.com/ |
| 18:31:35 | <dkayiwa> oh thanks |
| 18:31:51 | *** suranga has joined #openmrs |
| 18:32:44 | <downeym> dkayiwa: also http://status.openmrs.org/190785 |
| 18:32:53 | <dkayiwa> oh thanks |
| 18:34:12 | *** suranga_ has quit IRC |
| 18:36:14 | <downeym> dkayiwa: it's back up. :) |
| 18:36:27 | <dkayiwa> thanks downeym :) |
| 18:37:22 | <dkayiwa> wyclif: do you think you can get me a t-mobile unlock code? |
| 18:39:50 | <wyclif> dkayiwa, code? |
| 18:40:04 | <dkayiwa> wyclif: yes sim unlock code |
| 18:40:10 | <dkayiwa> android htc g2 |
| 18:40:30 | <wyclif> dkayiwa, i dont have it |
| 18:40:39 | <dkayiwa> :D |
| 18:40:39 | <wyclif> dkayiwa, i don't know how to do it |
| 18:40:51 | <dkayiwa> will ask bwolfe :) |
| 18:41:07 | <wyclif> dkayiwa, i doubt if they work for more than one phone |
| 18:41:26 | <dkayiwa> wyclif: they send one for each phone |
| 18:41:58 | <wyclif> dkayiwa, i guess |
| 18:42:03 | <dkayiwa> yup |
| 18:42:11 | <wyclif> dkayiwa, because they gave me one which i lost |
| 18:42:19 | <dkayiwa> oh i seee :) |
| 18:42:25 | *** Echidna has quit IRC |
| 18:43:37 | *** Echidna has joined #openmrs |
| 18:43:37 | *** ChanServ sets mode: +v Echidna |
| 18:48:03 | <bwolfe> dkayiwa, wyclif: support.t-mobile.com/community/chat you can ask for an unlock code every 3 months |
| 18:48:22 | <bwolfe> wyclif, the key is to tell them that you just bought the phone and you were planning to use it overseas and so need the code |
| 18:48:53 | <bwolfe> I had one person ask t-mo for the code and t-mo said "no, because it hasn't been used on your account". but sylvia did it successfully for me, so I don't know what hte deal is |
| 18:51:18 | <wyclif> bwolfe, , dkayiwa i recall they gave me mine after 3 months |
| 18:51:36 | <dkayiwa> ok |
| 18:52:23 | <bwolfe> wyclif, so if its been 3 months since you last asked for one, you should be ok |
| 18:54:25 | <dkayiwa> :) |
| 18:54:35 | <wyclif> i didnt know |
| 18:54:51 | <wyclif> i didnt know that i could ask for it again |
| 18:55:47 | <dkayiwa> :) |
| 18:58:43 | *** dawn_ has quit IRC |
| 19:04:10 | *** kishoreyekkanti has quit IRC |
| 19:04:48 | <djazayeri> dkayiwa: only one comment on the review for TRUNK-2824: are "testing.title" and "testing.settings" already in the messages.properties? |
| 19:05:52 | <dkayiwa> djazayeri: i had committed those some time back |
| 19:06:06 | <djazayeri> okay, then I approve. go ahead and close the review and the ticket |
| 19:06:09 | <dkayiwa> so they are already there |
| 19:06:13 | <dkayiwa> ok |
| 19:06:17 | <djazayeri> and they get picked up automatically? |
| 19:06:24 | <dkayiwa> yes i tested it |
| 19:06:43 | <djazayeri> I mean: it's okay to just return "testing.settings", from AdminExt? You don't have to call MessageSourceService? cool. |
| 19:06:48 | <djazayeri> (I didn't know that.) |
| 19:07:05 | <dkayiwa> djazayeri: yes it just works magically :) |
| 19:07:13 | <dkayiwa> maybe bwolfe did that :) |
| 19:07:21 | <djazayeri> nice |
| 19:07:51 | <bwolfe> correct, its passed through a <spring:messagecode="x"/> that will default to the string you entered if the code doesn't exist |
| 19:08:25 | <djazayeri> great! |
| 19:16:12 | <downeym> bwolfe: My request for more memory for the bamboo server has been denied |
| 19:17:06 | <bwolfe> because of cost? |
| 19:17:11 | <bwolfe> or because of the server its on? |
| 19:17:57 | <downeym> bwolfe: neither |
| 19:18:07 | <djazayeri> where is that hosted, btw? |
| 19:18:12 | <downeym> djazayeri: IU |
| 19:20:53 | <downeym> meanwhile I am trying to bounce apps when they start leaking |
| 19:23:08 | <bwolfe> is there an app for that? |
| 19:23:17 | <bwolfe> how do you know if they're leaking? random checks? |
| 19:24:08 | <downeym> bwolfe: so far that's it |
| 19:25:34 | *** suranga has quit IRC |
| 19:41:03 | *** r-friedman has joined #openmrs |
| 19:41:23 | <r-friedman> bwolfe: hi ben, got a minute? |
| 19:43:45 | <bwolfe> maybe 2 r-friedman |
| 19:43:49 | <r-friedman> tks ben |
| 19:43:59 | <r-friedman> i have a couple of questions re restws |
| 19:44:24 | <r-friedman> when you use the method call to get the property, where should the method be put? in the resource? |
| 19:45:27 | <bwolfe> yeah |
| 19:45:35 | <r-friedman> good |
| 19:46:11 | <r-friedman> and why does the model resource do the if on representation type rather than override asFull, asDefault, etc. |
| 19:47:25 | <bwolfe> you mean "what does" ? |
| 19:47:35 | <bwolfe> and what does "do the if" mean ? |
| 19:47:37 | <bwolfe> :-) |
| 19:48:01 | <r-friedman> well, I'm not really sure when the routine with the if gets called. Before the ases/ |
| 19:48:41 | <r-friedman> I'm concerned that if I don't have a field with the name the as routines are looking for, the whole thing will bomb |
| 19:49:11 | <bwolfe> if the methods don't exist it will default to the next one down the line |
| 19:49:17 | <bwolfe> I can't remember the order off hand |
| 19:49:30 | <bwolfe> I think I documented it somewhere in the rest wiki docs |
| 19:50:23 | <r-friedman> so metadatadelegatingcrudmeister is looking for a name field. what is there is no name field? |
| 19:50:46 | <r-friedman> is -.> if |
| 19:52:08 | <r-friedman> does that mean i can't use metadatadelegatingcrudmeister, i have to build my own version? |
| 19:54:13 | <bwolfe> r-friedman, if hte method doesn't exist it looks like it throws a ConversionException |
| 19:54:52 | <r-friedman> i'm sorry, i have changed the subject |
| 19:55:08 | <r-friedman> i'm now talking about the string,rep or string,string,rep form of the call |
| 19:55:51 | <bwolfe> if those don't exist then it continues on silently |
| 19:56:01 | <r-friedman> cool |
| 19:56:36 | <r-friedman> and why is the name field presented as a ref rep? it's usually just text |
| 20:02:08 | <r-friedman> bwolfe: tks, gotta run, seeya |
| 20:02:14 | *** r-friedman has quit IRC |
| 20:06:47 | *** mnunez_ has joined #openmrs |
| 20:07:19 | <mnunez_> Hi dkayiwa! Hi everyone! |
| 20:07:25 | <dkayiwa> hi mnunez_ |
| 20:09:42 | <mnunez_> dkayiwa: testing the modifications to the concept widget. I'm getting a "omsgs is not defined" error |
| 20:10:04 | <dkayiwa> mnunez_: oh yes i also get that but not for the first time |
| 20:10:10 | <dkayiwa> so will fix it |
| 20:10:18 | <mnunez_> dkayiwa: It happens when I write something, the widget suggest concepts, and then I delete whats written |
| 20:10:41 | <dkayiwa> mnunez_: do you also get it when trying to fill the form after selecting a patient? |
| 20:10:41 | <mnunez_> sorry "what is written" |
| 20:11:07 | <dkayiwa> ok |
| 20:14:37 | <mnunez_> dkayiwa: No. Only in Designer Preview |
| 20:14:43 | <dkayiwa> ok |
| 20:14:51 | <mnunez_> dkayiwa: that's odd. |
| 20:15:11 | <dkayiwa> since you have given me the steps for consistently reproducing it, that helps me alot and thanks :) |
| 20:15:24 | <dkayiwa> mnunez_: does it load any faster than before? |
| 20:15:30 | <mnunez_> dkayiwa: It works smoothly now. Awesome! |
| 20:15:37 | <dkayiwa> ok good |
| 20:16:07 | <mnunez_> dkayiwa: Filtering by concept class is not possible now, is it? |
| 20:16:32 | <dkayiwa> mnunez_: am working on it and you will have it shortly |
| 20:16:34 | <mnunez_> dkayiwa: No fancy selects and inner joins now? |
| 20:16:46 | <dkayiwa> no more of that stuff |
| 20:17:19 | <mnunez_> dkayiwa: Haha good! Updating wiki. |
| 20:17:40 | <dkayiwa> i trust you on that. thanks so so much!!!! :) |
| 20:17:42 | <mnunez_> dkayiwa: Good thing though is that both systems are available |
| 20:17:47 | <dkayiwa> oh yes |
| 20:23:26 | <mnunez_> dkayiwa: sorry, last one: filtering by locale is possible right? Changing user's locale preference should do |
| 20:24:00 | <dkayiwa> mnunez_: am not sure i get you correctly |
| 20:24:33 | *** rafa has joined #openmrs |
| 20:24:33 | *** ChanServ sets mode: +v rafa |
| 20:24:35 | <mnunez_> dkayiwa: in my implementation concepts are suggested both in english and spanish |
| 20:24:47 | <mnunez_> dkayiwa: suggestions are based on user's profile? |
| 20:24:58 | <dkayiwa> mnunez_: oh yes that should work |
| 20:28:51 | <djazayeri> downeym: where is the public view of the dtds we're talking about? |
| 20:31:21 | *** wyclif has quit IRC |
| 20:36:27 | <downeym> djazayeri: http://resources.openmrs.org/doctype/config-1.3.dtd |
| 20:36:51 | *** rafa has quit IRC |
| 20:39:56 | <djazayeri> downeym: soâ¦do *not* upload the dtd in that ITSM ticket |
| 20:40:36 | <downeym> djazayeri: ok.. |
| 20:41:27 | <downeym> djazayeri: fyi ⦠1303 Jun 17 2009 config-1.3.dtd |
| 20:42:49 | <djazayeri> downeym: from a cursory look it looks like (1) wyclif didn't notice that there's a 1.3, and started from 1.2, (2) long ago, whoever made 1.3 added one feature (mandatory, but lost one (dwr init). |
| 20:42:55 | *** bwolfe has quit IRC |
| 20:43:03 | <djazayeri> Is 1.3 the latest one? |
| 20:43:35 | <downeym> djazayeri: it is the highest named one. however config-1.2.dtd was replaced on 19-May of this year. There was another 1.2.dtd from 16-Jan-2009 (which I have saved) |
| 20:43:45 | <djazayeri> Anyway, I'll comment this on the ticket, the to-dos are for other people. |
| 20:43:46 | <downeym> djazayeri: i.e.: 1253 Jan 16 2009 config-1.2.dtd.20110519 |
| 20:44:08 | *** wyclif has joined #openmrs |
| 20:45:34 | <djazayeri> downeym: ah, that explains everything. |
| 20:46:02 | <downeym> djazayeri: if you say so. :) |
| 20:46:07 | <djazayeri> can you peek at that 2009-era 1.2 file, and verify that it has a line: <!ELEMENT dwr (allow, signatures?)> |
| 20:46:16 | <downeym> djazayeri: stand by |
| 20:46:22 | <djazayeri> i.e. it should not have <!ELEMENT dwr (init?, allow?, signatures?)> |
| 20:46:45 | <downeym> it has <!ELEMENT dwr (allow, signatures?)> |
| 20:47:21 | <djazayeri> okay, so as part of TRUNK-299, someone uploaded a "new" copy of config-1.2.dtd |
| 20:47:35 | <downeym> djazayeri: yes, i did. :) |
| 20:47:47 | <downeym> djazayeri: via ITSM-1234 |
| 20:47:54 | <djazayeri> I assume someone told you to do it, and it's that other person's fault. |
| 20:48:32 | <djazayeri> This was wrong in two ways: (1) we shouldn't have overwritten the existing 1.2 dtd, (and 2) they should have actually made 1.4 starting from 1.3. |
| 20:48:45 | <downeym> djazayeri: what's the best path forward |
| 20:48:52 | <downeym> i can restore 1.2 if helpful |
| 20:49:05 | <djazayeri> yes, please do that |
| 20:49:16 | <downeym> djazayeri: what about the existing "new" 1.2? |
| 20:49:22 | <djazayeri> trash it |
| 20:49:28 | <downeym> djazayeri: ok. |
| 20:49:29 | <djazayeri> the change is trivial |
| 20:50:14 | <downeym> djazayeri: ok, that much is done. |
| 20:50:28 | <djazayeri> you can revert the 1.2 dtd now |
| 20:50:36 | <downeym> done |
| 20:50:45 | <downeym> should this new file then become 1.4? |
| 20:50:47 | <djazayeri> sorry, my window didn't scroll. :-) |
| 20:50:53 | <djazayeri> no, don't use the 1.2.1 file |
| 20:51:01 | <djazayeri> it has two errors in it. |
| 20:51:25 | <downeym> djazayeri: ok |
| 20:58:28 | <djazayeri> downeym: thanks for catching this |
| 20:58:35 | *** james_regen has quit IRC |
| 21:07:04 | <downeym> djazayeri: no problem |
| 21:11:43 | *** nribeka has quit IRC |
| 21:34:46 | *** jriley has joined #openmrs |
| 21:46:13 | *** wyclif has quit IRC |
| 21:49:58 | *** downeym has quit IRC |
| 21:50:27 | *** mnunez_ has quit IRC |
| 22:01:21 | <djazayeri> dkayiwa: |
| 22:01:28 | <dkayiwa> djazayeri: |
| 22:01:50 | <djazayeri> per TRUNK-2686, is there a list of "things to ask for implementer opinions on during the 1.9 pre-release cycle"? |
| 22:02:28 | <dkayiwa> !ticket trunk-2686 |
| 22:02:29 | <OpenMRSBot> dkayiwa: [#TRUNK-2686] Provider Identifiers should be unique - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2686 |
| 22:02:47 | <dkayiwa> djazayeri: not any that am aware of |
| 22:03:03 | <djazayeri> Okay, you should make that list. :-) |
| 22:03:27 | <dkayiwa> djazayeri: what should it be composed of? :) |
| 22:04:01 | <djazayeri> At least the question "how should provider identifiers work?" |
| 22:04:14 | <dkayiwa> ok |
| 22:04:28 | <djazayeri> "(do we need something sophisticated like patient_identifier? is just having a unique string enough?" |
| 22:04:49 | <djazayeri> I'm asking because I want to close that ticket (for now) and it seems like it was left open waiting for that question to be written somewhere. |
| 22:05:29 | <dkayiwa> ok |
| 22:05:44 | <djazayeri> dkayiwa: can you record that question somewhere so that you'll remember to ask it during a dev call or email? |
| 22:05:57 | <dkayiwa> ok |
| 22:05:59 | <djazayeri> And then please close TRUNK-2686. |
| 22:06:04 | <dkayiwa> ok |
| 22:06:09 | <djazayeri> thanks! |
| 22:22:50 | *** rafa has joined #openmrs |
| 22:22:50 | *** ChanServ sets mode: +v rafa |
| 22:38:39 | *** dkayiwa has quit IRC |
| 22:56:51 | *** rafa has quit IRC |
| 23:06:17 | *** bryq has quit IRC |