00:39:39
|
*** wyclif has joined #openmrs
|
01:52:51
|
<djazayeri> wyclif: you there?
|
01:53:00
|
<djazayeri> I've just come across two reviews of yours that weren't started.
|
01:53:04
|
<djazayeri> At the first one I assumed you forgot.
|
01:53:13
|
<djazayeri> But at the second I'm wondering if it's a crucible bug.
|
01:59:38
|
*** rafa has joined #openmrs
|
01:59:38
|
*** ChanServ sets mode: +v rafa
|
02:04:25
|
*** rafa has quit IRC
|
02:06:07
|
<wyclif> hi djazayeri
|
02:06:18
|
<djazayeri> hi
|
02:15:52
|
*** r-friedman has joined #openmrs
|
02:16:23
|
<r-friedman> djazayeri: darius, got a minute?
|
02:16:34
|
<djazayeri> hi r-friedman
|
02:16:37
|
<r-friedman> hi
|
02:16:41
|
<djazayeri> I have until monica gets back from work, which may be <5 mins.
|
02:16:48
|
<r-friedman> very quick
|
02:16:54
|
<r-friedman> in the discussion about logic service
|
02:17:07
|
<r-friedman> you said that instead of using getLogicSerice
|
02:17:25
|
<r-friedman> they would have to use getService(getLogicService))
|
02:17:30
|
<r-friedman> or something like that
|
02:17:40
|
<r-friedman> the new way bcs logic would be in a module
|
02:17:50
|
<r-friedman> cld you tell me the new way?
|
02:18:14
|
<djazayeri> r-friedman: the new way is Context.getService(LogicService.class)
|
02:18:34
|
<djazayeri> Actually all of the Context.getXyzService() are just shortcuts for Context.getService(XyzService.class)
|
02:18:57
|
<r-friedman> perfect, thanks, say hi to monica for me, tell her i'll meet her in bogota
|
02:19:19
|
<djazayeri> my point about the future logic changes is that the current implementation of logic would no longer be core, hence you'll have to ask for its service by class.
|
02:19:21
|
<djazayeri> thanks!
|
02:19:22
|
<djazayeri> ttyl
|
02:58:54
|
*** sunbiz has joined #openmrs
|
02:58:54
|
*** ChanServ sets mode: +v sunbiz
|
03:05:52
|
*** robbyoconnor has quit IRC
|
03:11:39
|
*** rafa has joined #openmrs
|
03:11:39
|
*** ChanServ sets mode: +v rafa
|
03:15:28
|
*** rafa has quit IRC
|
03:23:01
|
*** robbyoconnor has joined #openmrs
|
03:23:01
|
*** ChanServ sets mode: +v robbyoconnor
|
03:51:20
|
<r-friedman> hi sunbiz
|
03:52:34
|
*** r-friedman has quit IRC
|
03:54:47
|
<sunbiz> hi r-friedmam
|
04:26:41
|
*** deadpool has quit IRC
|
04:31:38
|
*** deadpool has joined #openmrs
|
05:50:41
|
*** deadpool has quit IRC
|
06:08:01
|
*** deadpool has joined #openmrs
|
07:26:42
|
*** deadpool has quit IRC
|
08:00:52
|
*** sunbiz has quit IRC
|
08:16:10
|
*** bryq has joined #openmrs
|
08:16:10
|
*** ChanServ sets mode: +v bryq
|
09:51:19
|
*** djazayeri has quit IRC
|
09:55:16
|
*** sunbiz has joined #openmrs
|
09:55:16
|
*** ChanServ sets mode: +v sunbiz
|
10:20:03
|
*** sunbiz has quit IRC
|
10:21:41
|
*** sunbiz has joined #openmrs
|
10:21:41
|
*** ChanServ sets mode: +v sunbiz
|
12:04:18
|
*** sunbiz has quit IRC
|
13:37:07
|
*** sunbiz has joined #openmrs
|
13:37:07
|
*** ChanServ sets mode: +v sunbiz
|
14:11:28
|
*** sunbiz has left #openmrs
|
15:30:17
|
*** deadpool has joined #openmrs
|
15:40:57
|
*** r-friedman has joined #openmrs
|
15:41:31
|
<r-friedman> bwolfe: hi ben got a minute?
|
16:27:10
|
*** rafa_ has joined #openmrs
|
16:27:10
|
*** ChanServ sets mode: +v rafa_
|
17:12:51
|
*** deadpool has quit IRC
|
17:27:02
|
*** djazayeri has joined #openmrs
|
17:27:02
|
*** ChanServ sets mode: +o djazayeri
|
17:35:55
|
*** rafa_ has quit IRC
|
17:51:37
|
*** deadpool has joined #openmrs
|
18:01:49
|
*** bwolfe has quit IRC
|
18:03:58
|
*** bwolfe has joined #openmrs
|
18:03:58
|
*** ChanServ sets mode: +o bwolfe
|
18:06:11
|
<bwolfe> r-friedman, you still around?
|
18:53:28
|
*** bwolfe has quit IRC
|
18:54:32
|
*** bwolfe has joined #openmrs
|
18:54:32
|
*** ChanServ sets mode: +o bwolfe
|
19:38:04
|
*** dkayiwa has joined #openmrs
|
19:44:08
|
*** bwolfe has quit IRC
|
19:44:22
|
*** dkayiwa has quit IRC
|
19:44:32
|
*** bwolfe has joined #openmrs
|
19:44:32
|
*** ChanServ sets mode: +o bwolfe
|
19:56:46
|
*** djazayeri has quit IRC
|
20:03:28
|
*** bwolfe has quit IRC
|
20:30:54
|
*** lh has joined #openmrs
|
20:56:12
|
*** rafa has joined #openmrs
|
20:56:12
|
*** ChanServ sets mode: +v rafa
|
20:58:24
|
*** djazayeri has joined #openmrs
|
20:58:24
|
*** ChanServ sets mode: +o djazayeri
|
21:00:16
|
*** rafa has quit IRC
|
21:18:06
|
<r-friedman> djazayeri: hi darius, got a few minutes?
|
21:38:02
|
*** lh has quit IRC
|
21:42:37
|
*** lh has joined #openmrs
|
21:45:44
|
*** lh has quit IRC
|
21:49:39
|
*** bryq has quit IRC
|
22:04:50
|
*** djazayeri has quit IRC
|
23:26:07
|
* r-friedman is testing connectivity
|
23:46:35
|
*** djazayeri has joined #openmrs
|
23:46:35
|
*** ChanServ sets mode: +o djazayeri
|
23:50:10
|
<djazayeri> hi r-friedman
|
23:50:24
|
<r-friedman> hi darius
|
23:50:36
|
<djazayeri> still have a question?
|
23:50:46
|
<r-friedman> i'm trying to figure out the relation between the service level and the DAO level
|
23:51:17
|
<r-friedman> is every service call required to use DAO level functions?
|
23:51:32
|
<djazayeri> no
|
23:51:44
|
<djazayeri> The idea is that DAO is pure dumb data access
|
23:51:57
|
<djazayeri> e.g. get X from data store, by parameters Y and Z
|
23:52:05
|
<djazayeri> Service should be higher-level than that
|
23:52:39
|
<r-friedman> so if an object needs a parameterized get, that could be at either level?
|
23:52:42
|
<djazayeri> though Service also has to (and most service methods in OpenMRS are like this) expose methods that are just wrappers around the dao methods.
|
23:52:57
|
<r-friedman> that's what I was getting at
|
23:53:11
|
<djazayeri> Generally, if you're starting from scratch, you'd have an extremely-parameterized get method in the DAO
|
23:53:26
|
<djazayeri> e.g. able to fetch based on all the different possible parameters
|
23:53:30
|
<r-friedman> particularly wrt rest resource providers
|
23:53:45
|
<r-friedman> can they use DAO methods or should they use service methods delegated to the DAO level?
|
23:53:55
|
<djazayeri> then you'd have several service methods that let you search for particular combinations of parameters that make business sense.
|
23:54:20
|
<djazayeri> The technically correct answer is that since it's a module, you can do whatever you want.
|
23:54:36
|
<djazayeri> But the best practice is that only the service layer talks to the DAO
|
23:54:47
|
<r-friedman> great
|
23:54:58
|
<djazayeri> if you have a parameterized get in the DAO, you need to have a copy of that method in the service that delegates to the DAO.
|
23:55:10
|
<r-friedman> now should the object pojo have any utility methods?
|
23:55:33
|
<r-friedman> or make that stronger, useful methods normally found in the DAO?
|
23:55:41
|
<r-friedman> for example, the order object have a save method
|
23:55:59
|
<r-friedman> that should really be in DAO, right?
|