| 00:05:18 | *** wyclif has joined #openmrs |
| 01:40:47 | *** rafa has joined #openmrs |
| 01:40:47 | *** ChanServ sets mode: +v rafa |
| 02:10:42 | *** rafa has quit IRC |
| 02:53:38 | *** upul` has joined #openmrs |
| 02:53:38 | *** ChanServ sets mode: +v upul` |
| 03:29:38 | *** r-friedman has joined #openmrs |
| 03:32:09 | <r-friedman> djazayeri: hi darius, got a minute? |
| 03:32:17 | <djazayeri> hi r-friedman |
| 03:32:25 | <djazayeri> sure |
| 03:32:29 | <r-friedman> i've got a stupid java question |
| 03:32:39 | <r-friedman> I have a class, LabTestPanel |
| 03:32:49 | <r-friedman> 3 other classes reference it |
| 03:32:57 | <r-friedman> 2 of the classes work fine |
| 03:33:05 | <r-friedman> 1 can't resolve the reference |
| 03:33:18 | <r-friedman> all the classes are together in the project |
| 03:33:36 | <r-friedman> when i say "work", i mean have no errors |
| 03:33:39 | <djazayeri> they're all in the API project? |
| 03:33:44 | <r-friedman> yes |
| 03:34:02 | <djazayeri> Step 1: Project -> Clean |
| 03:34:41 | <djazayeri> If it's still an error, Step 2: does the class have the "public" modifier? |
| 03:35:16 | <djazayeri> Step 0: you did Control-Shift-O (organize imports) already, surely |
| 03:37:32 | <r-friedman> i just did step 0 but doesn't matter i don't think because they're all in the same brnach (jsslab.db) |
| 03:37:46 | <r-friedman> step 2 i checked |
| 03:37:59 | <djazayeri> r-friedman: sometimes eclipse just gets confused and you have to do Project -> Clean |
| 03:38:13 | <r-friedman> oh, this is not maven clean? |
| 03:38:31 | <djazayeri> no, Project (menu) -> Clean |
| 03:39:15 | <r-friedman> and that did the trick!! |
| 03:39:19 | <r-friedman> thanks much |
| 03:39:21 | <djazayeri> np |
| 03:39:26 | <djazayeri> enjoy the code |
| 03:39:32 | <r-friedman> haha |
| 03:39:46 | <r-friedman> at least the pure drudgery is over |
| 03:40:48 | <djazayeri> stepping away, type djazayeri if you need me |
| 03:41:00 | <r-friedman> tks, am going to bed |
| 03:41:24 | *** r-friedman has quit IRC |
| 04:21:16 | *** surangak has joined #openmrs |
| 04:42:09 | *** rafa has joined #openmrs |
| 04:42:09 | *** ChanServ sets mode: +v rafa |
| 04:44:30 | *** rafa has quit IRC |
| 04:54:49 | *** surangak_ has joined #openmrs |
| 04:54:49 | *** surangak has quit IRC |
| 05:24:50 | *** robbyoconnor has joined #openmrs |
| 05:24:50 | *** ChanServ sets mode: +v robbyoconnor |
| 05:29:22 | *** surangak has joined #openmrs |
| 05:30:16 | *** surangak_ has quit IRC |
| 07:13:01 | *** dkayiwa has joined #openmrs |
| 07:17:30 | *** surangak has quit IRC |
| 07:20:47 | *** surangak has joined #openmrs |
| 07:35:46 | <bwolfe> dkayiwa, you around? |
| 07:35:53 | <dkayiwa> yes bwolfe |
| 07:39:42 | <bwolfe> dkayiwa, ok, are you making tickets based on the etherpad yet? |
| 07:39:51 | <bwolfe> or is there something else more pressing that you are working on? |
| 07:40:07 | <dkayiwa> bwolfe: was still checking mail :) |
| 07:40:33 | <bwolfe> ha, ok. |
| 07:40:42 | <bwolfe> one of those mails is darius asking you to do that... |
| 07:40:54 | <dkayiwa> sure. :) |
| 07:52:40 | *** wyclif has quit IRC |
| 08:12:25 | *** bryq has joined #openmrs |
| 08:12:25 | *** ChanServ sets mode: +v bryq |
| 08:25:45 | *** wyclif has joined #openmrs |
| 08:30:25 | <dkayiwa> hi bwolfe |
| 08:31:19 | <bwolfe> hey |
| 08:31:34 | <dkayiwa> bwolfe: are we bundling formentry for 1.9 beta? |
| 08:32:26 | <bwolfe> dkayiwa, only if we can fix the problem with it |
| 08:32:34 | <dkayiwa> ok |
| 08:32:35 | <bwolfe> put that formentry ticket in the sprint if you can |
| 08:32:45 | <bwolfe> (or make a new ticket in trunk that links to the other) |
| 08:33:16 | <dkayiwa> bwolfe: doesnt that ticket depend on adding support for multiple providers at the hl7 level? |
| 08:34:38 | <dkayiwa> bwolfe: and which we are not doing during the beta sprint |
| 08:35:05 | <bwolfe> dkayiwa, why is that required? |
| 08:35:16 | <bwolfe> its just a matter of changing it so that its provider_id instead of user_id, right ? |
| 08:35:24 | <dkayiwa> ok |
| 08:37:51 | *** kishoreyekkanti has joined #openmrs |
| 08:39:49 | <kishoreyekkanti> bwolfe: Hi Ben |
| 08:41:00 | <kishoreyekkanti> dkayiwa: Hey you there |
| 08:41:11 | <dkayiwa> kishoreyekkanti: yes iam |
| 08:41:30 | <kishoreyekkanti> dkayiwa: cool. does http://demo.openmrs.org/openmrs/ always run the latest trunk code |
| 08:42:22 | <dkayiwa> kishoreyekkanti: no |
| 08:42:39 | <dkayiwa> kishoreyekkanti: i think should be the latested released stable version |
| 08:42:55 | <dkayiwa> kishoreyekkanti: so NOT trunk |
| 08:43:09 | <kishoreyekkanti> dkayiwa ohh ok. tq |
| 08:43:14 | <dkayiwa> kishoreyekkanti: why? |
| 08:43:29 | <dkayiwa> kishoreyekkanti: did you wanna use it for trunk? |
| 08:43:51 | <kishoreyekkanti> dkayiwa I have some release tests, I wanted to run them with trunk |
| 08:44:13 | <dkayiwa> kishoreyekkanti: how about setting that up locally? |
| 08:44:42 | <kishoreyekkanti> Yeah I've did that locally. I was thinking how we can run it in openmrs bamboo |
| 08:44:52 | <dkayiwa> ok |
| 08:44:57 | <kishoreyekkanti> dkayiwa: Ok.. here's a bit of context |
| 08:45:01 | <dkayiwa> ok |
| 08:45:39 | <kishoreyekkanti> dkayiwa: say we have some jbehave release tests in all of the moduels |
| 08:45:57 | <kishoreyekkanti> dkayiwa: ex: formentry have some rt and htmlformentry have some rt |
| 08:46:40 | <kishoreyekkanti> dkayiwa: Say if trunk is bundled with formentry and htmlformentry i wanted to run these release tests on the openmrs trunk instance which have above two modules installed. |
| 08:47:11 | <dkayiwa> ok |
| 08:47:46 | <kishoreyekkanti> dkayiwa: Presently i'm at a stage where i have release tests in the modules. Only thing left is to run all of them on a core openmrs instance which have these modules installed |
| 08:48:00 | <dkayiwa> ok |
| 09:11:28 | <surangak> bwolfe, helooo |
| 09:33:23 | *** surangak has quit IRC |
| 09:42:48 | <bwolfe> hmm, missed surangak :-/ |
| 09:52:54 | *** ningosi has joined #openmrs |
| 09:53:12 | <ningosi> hi guys |
| 09:53:42 | <dkayiwa> hi ningosi |
| 09:53:56 | <ningosi> I have a liitle confusion on how to include logic dependancy |
| 09:54:20 | <ningosi> am including logic module into my pom files |
| 09:54:41 | <ningosi> is it like this |
| 09:54:42 | <ningosi> <groupId>org.openmrs.module.logic</groupId> |
| 09:54:55 | <ningosi> or |
| 09:55:13 | <ningosi> <groupId>org.openmrs.module</groupId> |
| 09:59:29 | <bwolfe> ningosi, it changed recently |
| 09:59:39 | <bwolfe> I can't remember which one it is now :-/ |
| 09:59:48 | <bwolfe> my guess woudl be the second one |
| 10:02:48 | <ningosi> ok |
| 10:03:48 | <ningosi> ben this how i set in my main pom |
| 10:03:51 | <ningosi> <dependency> <groupId>org.openmrs.module</groupId> <artifactId>logic-api</artifactId> <version>0.5-SNAPSHOT</version> <type>jar</type> <scope>provided</scope> </dependency> |
| 10:04:13 | <bwolfe> do you have 0.5-SNAPSHOT in your local repository? |
| 10:04:21 | <bwolfe> if not, then you need to use 0.5 so that it is downloaded |
| 10:04:47 | <ningosi> yes |
| 10:04:51 | <ningosi> i have it |
| 10:05:11 | <ningosi> problem is my api pom file |
| 10:05:38 | <ningosi> it throws this error |
| 10:05:40 | <ningosi> Project build error: 'dependencies.dependency.version' for org.openmrs.module:logic-api:jar is missing. |
| 10:10:25 | *** kishoreyekkanti_ has joined #openmrs |
| 10:11:55 | *** kishoreyekkanti has quit IRC |
| 10:11:55 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 10:21:50 | <dkayiwa> hi bwolfe |
| 10:28:43 | <bwolfe> hi dkayiwa |
| 10:29:04 | <dkayiwa> bwolfe: are you able to successfully run mvn install on the latest standalone? |
| 10:29:20 | <bwolfe> ningosi, I don't know what that error means. what does google say? |
| 10:29:37 | <bwolfe> dkayiwa, no, getting some error about the liquibase version difference |
| 10:30:04 | <dkayiwa> bwolfe: do you get this: Caused By: Illegal mix of collations (latin1_swedish_ci,IMPLICIT) and (utf8_general_ci,COERCIBLE) for operation '=' |
| 10:30:14 | <bwolfe> oh, not that |
| 10:30:36 | <bwolfe> dkayiwa, isn't there something in the faq of the standalone wiki page (or readme?) that says something about that? |
| 10:31:00 | <dkayiwa> bwolfe: i do not remember anything like that |
| 10:31:15 | <bwolfe> I saw it recent I think |
| 10:31:21 | <bwolfe> or something similar anyway |
| 10:33:19 | <dkayiwa> bwolfe: you must be thinking of my review comment. :) Even after that, am still getting the same error. Possibly i need to look into this a bit more. |
| 10:35:13 | <bwolfe> server.collation-server This sets the collation of the database server. If you do not set it to this value, you will |
| 10:35:14 | <bwolfe> get problems running the openmrs liquibase files. This is because the defaul |
| 10:35:14 | <bwolfe> t value is swedish |
| 10:35:14 | <bwolfe> collation yet openmrs uses utf8 |
| 10:35:17 | <bwolfe> dkayiwa ^^ |
| 10:35:21 | <bwolfe> thats from the readme.txt |
| 10:36:10 | <dkayiwa> bwolfe: looks like the maven process is not using the connection string in the pom |
| 10:36:49 | <bwolfe> dkayiwa, did you make sure to kill your old mysql process? |
| 10:37:00 | <bwolfe> ps aux |
| 10:37:07 | <bwolfe> sudo pkill -f 3326 |
| 10:37:34 | <dkayiwa> bwolfe: let me check |
| 10:38:48 | <dkayiwa> bwolfe: hahahahaha. You are a magician :) |
| 10:39:47 | <bwolfe> :-D |
| 10:39:49 | <bwolfe> bwolfe++ |
| 10:39:49 | <OpenMRSBot> bwolfe: Error: You're not allowed to adjust your own karma. |
| 10:39:59 | <dkayiwa> :D |
| 10:40:01 | <bwolfe> openmrsbot-- |
| 10:40:25 | <upul`> bwolfe++ |
| 10:40:33 | <dkayiwa> i can do it for you. :) bwolfe ++ |
| 10:41:28 | <bwolfe> double the karma! woot! |
| 10:41:31 | <bwolfe> :-) |
| 10:42:16 | <dkayiwa> a triple would also not hurt. considering the pain you have saved me. :) bwolfe++ |
| 10:42:51 | <bwolfe> dkayiwa, I can only save you this pain because I went through it myself this morning |
| 10:43:04 | <dkayiwa> lollllllllllllllllllllllll |
| 10:43:11 | <bwolfe> luckily darius updated the readme with the "if things fail, kill off anything on port 3326" |
| 10:43:19 | <bwolfe> so djazayeri++ |
| 10:43:25 | <dkayiwa> oh i seeeeee |
| 10:43:46 | <dkayiwa> ok minus one karma :) bwolfe-- |
| 10:44:23 | <bwolfe> haha |
| 10:44:28 | <bwolfe> !karma |
| 10:44:28 | <OpenMRSBot> bwolfe: Highest karma: "bwolfe" (100), "dkayiwa" (43), and "groovy" (30). Lowest karma: "emacs" (-10), "[INFO] ----------------------------------------------------------------------" (-8), and "windows" (-7). You (bwolfe) are ranked 1 out of 302. |
| 10:44:44 | <bwolfe> only 100 ? who has been negating me?? |
| 10:44:49 | <bwolfe> !karma bwolfe |
| 10:44:49 | <OpenMRSBot> bwolfe: Karma for "bwolfe" has been increased 128 times and decreased 28 times for a total karma of 100. |
| 10:44:52 | <dkayiwa> lollllllllllll |
| 10:44:59 | <dkayiwa> must be pascal :) |
| 10:45:07 | <bwolfe> ha |
| 10:46:57 | <bwolfe> dkayiwa, in other news, I have darius' standalone script working for 1.8.x. I put in 3 hours of debugging/work on it just to save myself 2 hours of running/setting up the standalone. :-D |
| 10:47:19 | <dkayiwa> lolllllllll :D |
| 10:47:38 | <bwolfe> now I just need a maven guru to know how to make those things switch back and forth |
| 10:48:09 | <dkayiwa> may be now Matthew, sunbiz, etc can come in :) |
| 10:48:34 | <dkayiwa> Since those hours save not just yourself but me too, then bwolfe++ :) |
| 10:51:55 | <bwolfe> dkayiwa, how do I change the graphic to say 1.8.3 instead of 1.9.0-alpha? |
| 10:52:29 | <dkayiwa> bwolfe: do you already have the 1.8.3 graphic? |
| 10:52:52 | <dkayiwa> if yes, just replace splashscreen-loading |
| 10:52:58 | <dkayiwa> .png |
| 10:53:03 | <bwolfe> no, I don't have it |
| 10:53:19 | <bwolfe> I'd propose we either leave the version off of it or overlay using text somehow |
| 10:53:40 | <dkayiwa> talk to Michael and he will send you one in 5mins :) |
| 10:54:04 | <bwolfe> he's asleep |
| 10:54:09 | <bwolfe> he probably won't do it in 5 mins |
| 10:54:16 | <bwolfe> but its a waste of resources |
| 10:54:19 | <bwolfe> we just need a basic one |
| 10:54:26 | <dkayiwa> i completely agree |
| 10:54:34 | <bwolfe> the splashscreen was up for about 2 seconds on mine. just long enough for me to see the version... |
| 10:54:40 | <dkayiwa> that would be a more sustainable solution |
| 10:54:43 | <bwolfe> ok good, I'll replace it with a basic one then :-D |
| 10:54:49 | <dkayiwa> sure |
| 10:56:21 | *** ningosi has quit IRC |
| 11:21:03 | <bwolfe> dkayiwa, whats the runtime property I add in so that the db password is changed from test at startup in the standalone? |
| 11:21:32 | <dkayiwa> bwolfe: reset_connection_password |
| 11:22:06 | <dkayiwa> bwolfe: remember to set it to true only before you zip |
| 11:32:31 | *** kishoreyekkanti has quit IRC |
| 11:32:50 | *** upul` has left #openmrs |
| 11:33:25 | *** kishoreyekkanti has joined #openmrs |
| 11:52:39 | *** nribeka has quit IRC |
| 12:21:13 | *** james_regen has joined #openmrs |
| 12:21:13 | *** ChanServ sets mode: +v james_regen |
| 12:34:30 | *** rafa has joined #openmrs |
| 12:34:30 | *** ChanServ sets mode: +v rafa |
| 12:36:45 | *** rafa has quit IRC |
| 13:01:52 | *** muthah has joined #openmrs |
| 13:14:40 | *** wyclif has quit IRC |
| 13:20:04 | *** kishoreyekkanti_ has joined #openmrs |
| 13:20:04 | *** kishoreyekkanti has quit IRC |
| 13:20:05 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 13:51:21 | *** nribeka has joined #openmrs |
| 13:51:21 | *** ChanServ sets mode: +v nribeka |
| 13:59:39 | <dkayiwa> hi bwolfe |
| 14:03:41 | *** wyclif has joined #openmrs |
| 14:04:08 | *** downeym has joined #openmrs |
| 14:04:08 | *** ChanServ sets mode: +o downeym |
| 14:04:08 | *** OpenMRSBot sets mode: +o downeym |
| 14:14:26 | *** nribeka has quit IRC |
| 14:19:55 | *** muthah has quit IRC |
| 14:25:20 | *** muthah has joined #openmrs |
| 14:53:08 | *** chopin_ has joined #openmrs |
| 14:53:32 | <chopin_> hi |
| 14:54:45 | <chopin_> is there something magic i am supposed to do for an object's save method to replicate that save to a collection of related objects in one of its parameters? |
| 14:54:47 | *** lh has joined #openmrs |
| 14:55:26 | <chopin_> e.g. an IntegrityCheck has a list of IntegrityCheckColumns, and when I save an IntegrityCheck i want those columns to be saved as well |
| 14:57:57 | *** ada_ has joined #openmrs |
| 14:58:11 | *** dawn_ has joined #openmrs |
| 14:58:12 | <downeym> Hi ada_ and welcome to the #openmrs IRC channel. |
| 14:58:24 | *** ChanServ sets mode: +v dawn_ |
| 14:58:33 | <ada_> Hi, MD, how's the do-nuts? |
| 14:59:24 | <downeym> ( o ) |
| 14:59:34 | <downeym> (o) |
| 15:00:08 | <downeym> the first one was voodoo doughnut texas challenge |
| 15:02:13 | *** nribeka has joined #openmrs |
| 15:02:13 | *** ChanServ sets mode: +v nribeka |
| 15:02:52 | <djazayeri> hi all |
| 15:03:03 | <djazayeri> hi bwolfe, dkayiwa, wyclif, rafa |
| 15:03:05 | <djazayeri> (no rafa) |
| 15:04:31 | <dkayiwa> hi |
| 15:07:55 | *** ada_ has quit IRC |
| 15:08:06 | <djazayeri> scrum time? |
| 15:08:19 | *** ada_ has joined #openmrs |
| 15:08:40 | <wyclif> hi djazayeri |
| 15:10:44 | <djazayeri> hi wyclif |
| 15:12:11 | <djazayeri> dkayiwa: update? |
| 15:12:46 | <djazayeri> kishoreyekkanti: I'll be free to talk in about 30 mins |
| 15:13:11 | <kishoreyekkanti> djazayeri: Sure darius. Will speak to you in 30 mins |
| 15:13:47 | <dkayiwa> Done some ticket administration for the sprint |
| 15:13:47 | <dkayiwa> Committed review comments for: Test install fails during the running of sql dump file - TRUNK-2865 |
| 15:13:48 | <dkayiwa> Looking into: During the test install method, the wizard should allow user/password for another user other than root - TRUNK-2851. |
| 15:14:30 | <dkayiwa> But so far have failed to reproduce the problem in TRUNK-2851. |
| 15:17:13 | <djazayeri> dkayiwa: have you gone through the wiki page of testing feedback for 1.9 alpha and added those tickets to the beta sprint? |
| 15:17:49 | <dkayiwa> djazayeri: do you mean the etharpard link? |
| 15:18:18 | <djazayeri> yes, sorry, I mean the etherpad |
| 15:18:26 | <dkayiwa> djazayeri: yes i did |
| 15:19:47 | <djazayeri> okay, so that added about 7 tickets to the sprint since my email yesterday? |
| 15:19:55 | <dkayiwa> yes |
| 15:21:47 | <djazayeri> okay |
| 15:22:50 | <djazayeri> dkayiwa: I'm looking at TRUNK-2868 |
| 15:22:55 | <djazayeri> !ticket TRUNK-2868 |
| 15:22:56 | <OpenMRSBot> djazayeri: [#TRUNK-2868] Advanced setup install method should use default values in existing runtime properties file - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2868 |
| 15:23:16 | <djazayeri> It doesn't seem to be working |
| 15:23:23 | <djazayeri> actually, let me svn update and check |
| 15:23:29 | <djazayeri> I think I forget to svn update trunk... |
| 15:23:55 | *** magicaltrout has quit IRC |
| 15:24:30 | <djazayeri> dkayiwa: is that the ticket about not letting the user change the database config if they're running under the standalone? |
| 15:24:35 | <djazayeri> or is that a different one? |
| 15:24:39 | *** magicaltrout has joined #openmrs |
| 15:25:03 | *** dkayiwa has quit IRC |
| 15:27:14 | <djazayeri> ah, lost dkayiwa |
| 15:27:22 | <djazayeri> bwolfe: got a report? |
| 15:29:01 | <djazayeri> wyclif? |
| 15:32:44 | <wyclif> yesterday: |
| 15:32:44 | <wyclif> -Fixed some bugs with the encryption tickets when run from standalone |
| 15:32:44 | <wyclif> -End-to-end testing of the test installation process - Looks good |
| 15:32:44 | <wyclif> -Created/worked on TRUNK-2871 - Modules are not copied to the correct directory for the test installation in the standalone |
| 15:32:44 | <wyclif> -Created/worked on RELTEST-10 - Add privileges to TestingService.generateTestDataSet(Note yet committed) |
| 15:32:46 | <wyclif> -Dev call |
| 15:32:48 | <wyclif> today: |
| 15:32:52 | <wyclif> -TRUNK-2869 - The user selected language should be persisted in test installation |
| 15:32:54 | <wyclif> -TRUNK-2853 - Fix the progress bars on the progess page for the test installation |
| 15:32:56 | <wyclif> -Need to replace the occurences of 'production' to 'remote' for the test installation wizard |
| 15:32:58 | <wyclif> -sprint tickets |
| 15:33:00 | <wyclif> blockers: none |
| 15:34:11 | <djazayeri> wyclif: I don't think the wording describing the "Testing" option in the install wizard is accurate anymore. |
| 15:34:49 | <djazayeri> let me create a ticket, I guess. |
| 15:34:58 | <djazayeri> My report |
| 15:35:02 | <djazayeri> yesterday: |
| 15:35:07 | <djazayeri> * lots of calls |
| 15:35:29 | <djazayeri> * reorganized, commented on, edited lots of tickets for next week's sprint |
| 15:35:33 | <djazayeri> * emails |
| 15:35:43 | <djazayeri> * committed code for standalone-build-support maven module |
| 15:35:47 | <djazayeri> today: |
| 15:35:57 | <djazayeri> * end to end testing of standalone + testing releases module |
| 15:36:04 | <djazayeri> * (lots of) code reviews for this sprint |
| 15:36:08 | *** kishoreyekkanti_ has joined #openmrs |
| 15:36:13 | <downeym> Hi kishoreyekkanti_ and welcome to the #openmrs IRC channel. |
| 15:36:19 | <djazayeri> no blocekrs |
| 15:36:22 | <djazayeri> no blockers |
| 15:36:26 | <wyclif> djazayeri, what do you have in mind? |
| 15:36:44 | <wyclif> djazayeri, for the testing option? |
| 15:36:45 | <djazayeri> it says "Install to a VM or different machineâ¦" |
| 15:37:00 | <wyclif> djazayeri, we need to edit that |
| 15:37:01 | <djazayeri> It says "Ensure that the database executables for the test server are on the system path" |
| 15:37:16 | <djazayeri> it says "This can take several hour or minutes if you have a fairly large database" |
| 15:37:25 | <wyclif> djazayeri, that was before changes in this sprint |
| 15:37:30 | <djazayeri> yes, exactly |
| 15:37:56 | *** kishoreyekkanti has quit IRC |
| 15:37:56 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 15:58:55 | *** lh has quit IRC |
| 16:01:50 | <djazayeri> bwolfe, dkayiwa, wyclif, rafa: I just did my first end-to-end test. It doesn't work on 1.6. |
| 16:01:54 | <djazayeri> I created several tickets. |
| 16:03:33 | <wyclif> what are some of the reasons? |
| 16:03:39 | <wyclif> djazayeri, what are some of the reasons? |
| 16:03:54 | <wyclif> djazayeri, bugs |
| 16:04:05 | <djazayeri> doesn't work in 1.6 |
| 16:04:12 | <djazayeri> and some wording fixes |
| 16:04:41 | <djazayeri> the blocker is that my 1.6 server log says: org.springframework.web.bind.MissingServletRequestParameterException: Required java.lang.String parameter 'username' is not present |
| 16:06:22 | *** lh has joined #openmrs |
| 16:07:54 | <djazayeri> okay all, scrum is over |
| 16:08:05 | <djazayeri> let's get to work on tickets, and finishing off the sprint! |
| 16:20:36 | <djazayeri> bwolfe: you there? |
| 16:20:43 | <bwolfe> I am now |
| 16:20:55 | <djazayeri> can I add you to a skype call with kishoreyekkanti? |
| 16:21:00 | <djazayeri> about webapp release testing? |
| 16:21:05 | <djazayeri> and merging the branch? |
| 16:21:37 | <bwolfe> sure, I'm here with eden, so you'll hear her in the background |
| 16:21:41 | <djazayeri> np |
| 16:53:22 | *** wyclif has quit IRC |
| 17:00:43 | *** dawn_ has quit IRC |
| 17:04:26 | *** kishoreyekkanti has quit IRC |
| 17:06:31 | *** wyclif has joined #openmrs |
| 17:21:05 | *** ada_ has quit IRC |
| 17:31:52 | *** suranga has joined #openmrs |
| 17:33:15 | <suranga> hi bwolfe |
| 17:33:33 | <suranga> bwolfe, can you lend me some processing power for a while :-) |
| 17:42:59 | <djazayeri> wyclif: have you actually run the whole release testing thing end-to-end? |
| 17:43:21 | <bwolfe> suranga, what do you need to process? |
| 17:43:34 | <djazayeri> wyclif: I get an out-of-memory error trying to do the encryption |
| 17:43:51 | <djazayeri> and I have tomcat running with -Xmx512m and permsize=256m |
| 17:44:05 | <suranga> bwolfe, hi... I have an AMPATH stack trace :P |
| 17:44:40 | <djazayeri> wyclif: (Also, as a side-note, the encryption is useless.) |
| 17:44:59 | <suranga> I need to figure it out whats wrong, since this seems to be an ampath specific buggie, and I have no way of recreating or debugging..... |
| 17:46:29 | <bwolfe> suranga, ok. fire away. pastebin link for hte stacktrace? |
| 17:46:57 | <wyclif> djazayeri, why is the encryption useless? |
| 17:47:33 | <djazayeri> wyclif: if they're using ssl, encryption is already done. if they're not running ssl, we're sending the password and salt in plain-text in the request |
| 17:47:38 | <suranga> sure :-) |
| 17:47:50 | <suranga> so to giv you the background...in patient matching, a table called persisitreportdata gets created via the sqldiff.xml file |
| 17:48:16 | <suranga> however, it seems that an error is throws any time someone stried to input data into this table... |
| 17:48:38 | <suranga> to meet it seems like a permission issue... let me pastebin :) |
| 17:48:39 | <wyclif> djazayeri, the password and salt are not sent as part of the response and also they are encoded, they are not plain text |
| 17:49:15 | <djazayeri> wyclif: they're hashed reversibly. if someone is actually eavesdropping on the wire, the encryption we're doing is useless. |
| 17:49:28 | <djazayeri> because they can see the request and the response |
| 17:49:45 | <djazayeri> (and they have access to the code) |
| 17:50:03 | <wyclif> djazayeri, i agree |
| 17:50:15 | <djazayeri> the only thing we're accomplishing is obfuscating the sqldump so that if someone glances at it, they don't see it |
| 17:50:23 | <djazayeri> but we don't need to use password-based-encryption for this |
| 17:50:43 | <bwolfe> I still think it is a waste of time to encrypt it. just my 2 cents... |
| 17:51:01 | <djazayeri> I completely agree bwolfe. |
| 17:51:02 | <wyclif> djazayeri, so it could have been just encoding the txt? |
| 17:51:17 | <djazayeri> Yeah, we could just do the same Base64. |
| 17:51:23 | <suranga> bwolfe, this is the stack trace |
| 17:51:32 | <suranga> http://pastebin.com/nWnHCFtn |
| 17:51:45 | <suranga> as u can seen, it failes to insert anything :-) |
| 17:52:20 | <djazayeri> wyclif: I'll create a ticket |
| 17:52:31 | <djazayeri> it's for both trunk and the module. :-( |
| 17:52:34 | <djazayeri> oh well |
| 17:53:30 | <wyclif> djazayeri, i can have that fixed before end of today as part of the open tickets and just edit their descriptions and summary |
| 17:53:42 | <wyclif> djazayeri, rather than having separate tickets |
| 17:53:53 | <djazayeri> wyclif: I'm creating the tickets anyway, you can just close those too when you finish them. |
| 17:54:00 | <wyclif> djazayeri, ok |
| 17:54:21 | <wyclif> djazayeri, so we should do Base64 encoding |
| 17:54:23 | *** dawn_ has joined #openmrs |
| 17:54:23 | *** ChanServ sets mode: +v dawn_ |
| 17:54:37 | <djazayeri> wyclif: if it makes you feel more comfortable, we can. |
| 17:54:44 | <djazayeri> I agree with bwolfe that it's not necessary. |
| 17:56:14 | <wyclif> djazayeri, or you are suggesting we get rid of both the encoding and encryption |
| 17:56:28 | <djazayeri> wyclif: I would prefer to just get rid of both |
| 17:56:34 | <djazayeri> I'm fine encoding the password |
| 17:56:46 | <djazayeri> but I don't see the need to encode the sqldump |
| 17:57:24 | <wyclif> djazayeri, the benefit of getting rid of both is that we don't have to use that string buffer which actually is likely yo cause memory issues |
| 17:57:31 | <djazayeri> yes |
| 17:57:48 | <wyclif> djazayeri, i will just revert my changesets |
| 17:58:20 | <djazayeri> wyclif: I assigned you RELTEST-15 |
| 17:58:25 | <wyclif> ok |
| 17:58:38 | <bwolfe> suranga, yes, its a db user permissions issue. its nothing on your end |
| 17:58:42 | <bwolfe> the way ampath is set up: |
| 17:58:50 | <djazayeri> wyclif: if you did the encryption and nothing else in a couple changesets, you can just revert them |
| 17:58:55 | <suranga> bwolfe, ooops |
| 17:59:13 | <bwolfe> a production server that reads/writes every table. a "research" server that can read every table but only write to some of them. |
| 17:59:24 | *** mnunez has joined #openmrs |
| 17:59:31 | <bwolfe> so someone at ampath needs to get the amrs_webuser user permissions to modify that table |
| 17:59:44 | <suranga> bwolfe, oooh... I see |
| 18:00:02 | <bwolfe> its restricted on the research server because data is copied from production to research in real time using mysql replication. mysql doesn't like it when you modify the table and then it tries to write to it |
| 18:00:14 | <bwolfe> shoudl be a very quick fix. I don't know why ada didn't know this... :-/ |
| 18:00:56 | <suranga> bwolfe, m... so u mean that this issue may be working in the research server itself ? |
| 18:01:06 | <bwolfe> bad news: I really want some ice cream right now. but we have none in the house. :-( |
| 18:01:21 | <suranga> bwolfe, oh sorry, i ment its working on the production server itself ? |
| 18:01:31 | <bwolfe> suranga, yes, it should work fine on the production server |
| 18:01:32 | <wyclif> djazayeri, there nothing else |
| 18:01:41 | <wyclif> djazayeri, there was nothing else |
| 18:01:46 | <djazayeri> okay, well, maybe you'll get to mark off extra tickets for free. |
| 18:01:54 | <bwolfe> ha |
| 18:01:56 | <suranga> bwolfe, Ice cream ??? at this hour ? |
| 18:01:59 | <bwolfe> pump up those stats wyclif! |
| 18:02:12 | <bwolfe> at 9pm? when else should I have ice cream? |
| 18:02:32 | <mnunez> Hi everybody! |
| 18:02:46 | <suranga> ooops, sorry I keep forgetting... its midnight here :-( |
| 18:03:13 | <wyclif> bwolfe, ? |
| 18:03:26 | <bwolfe> wyclif, the closed tickets stats |
| 18:03:51 | <mnunez> bwolfe: summer's coming, 3 o'clock here with 27ºC... ice cream sounds like a good supper |
| 18:04:35 | <suranga> bwolfe, thanks for the help with this... I'll pass it on to Ada... and she'll say Im so smart to have fixed this so soooon :D |
| 18:04:52 | <mnunez> ha! Went to buy some I guess |
| 18:05:16 | <djazayeri> wyclif: I also assigned you TRUNK-2875 |
| 18:05:29 | <bwolfe> mnunez, I wish |
| 18:05:37 | <wyclif> djazayeri, ok |
| 18:05:41 | *** dawn_ has quit IRC |
| 18:06:04 | *** dawn_ has joined #openmrs |
| 18:06:04 | *** ChanServ sets mode: +v dawn_ |
| 18:07:14 | *** suranga_ has joined #openmrs |
| 18:09:44 | *** suranga has quit IRC |
| 18:10:25 | *** suranga has joined #openmrs |
| 18:11:33 | *** suranga_ has quit IRC |
| 18:13:38 | <mnunez> General question: will the MVP Dictionary will eventually be included in the next standalone? |
| 18:17:37 | *** dawn__ has joined #openmrs |
| 18:17:37 | *** ChanServ sets mode: +v dawn__ |
| 18:17:37 | *** dawn_ has quit IRC |
| 18:17:37 | *** dawn__ is now known as dawn_ |
| 18:18:11 | <bwolfe> mnunez, yes, eventually that is the goal |
| 18:20:06 | *** dawn__ has joined #openmrs |
| 18:20:06 | *** ChanServ sets mode: +v dawn__ |
| 18:20:06 | *** dawn_ has quit IRC |
| 18:20:07 | *** dawn__ is now known as dawn_ |
| 18:20:13 | <mnunez> bwolfe: it might be good to be sure the OpenMRS modules can handle that amount of concepts. XForms in 1.8+ can get pretty stuck with 30K concepts |
| 18:21:25 | <bwolfe> mnunez, then we need to complain to the xforms author then. :-) |
| 18:21:41 | <bwolfe> does xforms use drop downs for concepts or searching widgets? |
| 18:21:50 | <bwolfe> or is it in the designing stage that it gets stuck? |
| 18:21:51 | <mnunez> bwolfe: yeah! Lets! ;) |
| 18:23:41 | <mnunez> bwolfe: it uses incremental search for the widgets with external sources. |
| 18:24:46 | <mnunez> bwolfe: but I understand it does not use the same algorithm used for dictionary or patient search, for example. |
| 18:25:45 | <mnunez> bwolfe: and no jQuery |
| 18:28:18 | *** chopin_ has quit IRC |
| 18:30:24 | *** muthah has quit IRC |
| 18:30:32 | *** muthah has joined #openmrs |
| 18:32:37 | *** suranga_ has joined #openmrs |
| 18:33:05 | *** suranga__ has joined #openmrs |
| 18:34:31 | *** suranga has quit IRC |
| 18:36:40 | *** muthah has quit IRC |
| 18:37:01 | *** suranga_ has quit IRC |
| 18:38:53 | *** suranga has joined #openmrs |
| 18:41:40 | *** suranga__ has quit IRC |
| 18:48:47 | *** suranga_ has joined #openmrs |
| 18:52:31 | *** suranga has quit IRC |
| 19:01:06 | *** dawn_ has quit IRC |
| 19:02:34 | <djazayeri> wyclif: you reverted the encryption changes in the module and trunk? |
| 19:04:03 | <wyclif> djazayeri, yes |
| 19:04:11 | <djazayeri> cool, i'll update and retry |
| 19:04:20 | <wyclif> djazayeri, was about to say that |
| 19:04:28 | <djazayeri> wyclif: The unit tests don't pass for me. |
| 19:04:30 | <djazayeri> on the module |
| 19:04:33 | <djazayeri> let me try a clean build |
| 19:05:24 | <djazayeri> wyclif: Tests in error: |
| 19:05:24 | <djazayeri> generateTestDataSet_shouldPassIfTheAuthenticatedUserIsASuperUser(org.openmrs.module.testing.api.TestingServiceTest): Unexpected exception, expected<org.hibernate.exception.SQLGrammarException> but was<java.lang.NullPointerException> |
| 19:05:37 | <wyclif> djazayeri, am fixinf that test |
| 19:06:12 | <wyclif> can switch that Systm.out instead of null in the unit test |
| 19:06:14 | <djazayeri> wyclif: boo for not running the unit tests before committing. :-) |
| 19:06:16 | <wyclif> djazayeri, can switch that Systm.out instead of null in the unit test |
| 19:06:36 | <djazayeri> wyclif: I haven't looked at the test, I just did a mvn package |
| 19:06:52 | <wyclif> djazayeri, i actually saw that but wanted to keep the reverting clean |
| 19:06:59 | <wyclif> am fixing it |
| 19:12:36 | <djazayeri> okay, stepping away for a bit, will be back in 20 |
| 19:31:10 | *** wyclif has quit IRC |
| 19:33:01 | *** lh has quit IRC |
| 19:33:11 | *** wyclif has joined #openmrs |
| 19:42:32 | <djazayeri> wyclif: back |
| 19:42:36 | <djazayeri> is that committed yet? |
| 19:42:48 | <wyclif> djazayeri, yes |
| 19:43:52 | <djazayeri> thx |
| 19:47:27 | *** dawn_ has joined #openmrs |
| 19:47:27 | *** ChanServ sets mode: +v dawn_ |
| 19:47:40 | *** suranga_ has quit IRC |
| 19:50:30 | <djazayeri> wyclif: I just got org.springframework.web.bind.MissingServletRequestParameterException: Required java.lang.String parameter 'u' is not present |
| 19:50:39 | <djazayeri> I *think* I properly updated everything. |
| 19:50:56 | <djazayeri> Is it possible that you didn't revert everything consistently? |
| 19:52:20 | <wyclif> djazayeri, you have not updated trunk well |
| 19:52:32 | <wyclif> djazayeri, you have not updated the module |
| 19:52:46 | <wyclif> djazayeri, sorry! you have not updated the module |
| 19:53:00 | <djazayeri> I definitely updated the module, because the unit test now passed... |
| 19:53:03 | <djazayeri> but maybe I forgot to deploy... |
| 19:53:08 | <wyclif> djazayeri, yeah |
| 19:53:10 | <djazayeri> ah, that's it. :-) |
| 19:53:21 | *** suranga has joined #openmrs |
| 20:05:45 | *** lh has joined #openmrs |
| 20:19:28 | *** mnunez has quit IRC |
| 20:21:21 | *** james_regen has quit IRC |
| 20:31:57 | <wyclif> hi djazayeri |
| 20:32:07 | <djazayeri> hi wyclif |
| 20:32:24 | <wyclif> looking RELTEST-14, is it failing because of that changeset? |
| 20:32:42 | <djazayeri> Yes. I just put in a debugging line |
| 20:32:42 | <wyclif> looking at RELTEST-14, is it failing because of that changeset? |
| 20:32:49 | <djazayeri> it's the first concept_name I hit |
| 20:33:05 | <djazayeri> it has voided=0 and voided_by=null |
| 20:33:08 | <wyclif> i think you have no user with userId 1 |
| 20:33:16 | <djazayeri> the line of code is: |
| 20:33:16 | <djazayeri> pStmt.setInt(7, (conceptName.isVoided() && userId != null) ? userId : null); |
| 20:33:23 | *** suranga has quit IRC |
| 20:33:24 | <wyclif> djazayeri, i think you have no user with userId 1 |
| 20:33:43 | <wyclif> djazayeri, or u have no users in the database |
| 20:33:51 | <djazayeri> nope, I do have an admin user with id=1 |
| 20:33:53 | *** mnunez has joined #openmrs |
| 20:34:09 | <djazayeri> It's odd, I don't understand how that line of code can be throwing a nPE |
| 20:34:20 | <wyclif> djazayeri, am also wondering |
| 20:34:27 | <wyclif> actually it cant be useris null |
| 20:34:41 | <wyclif> actually it cant be a null user_id |
| 20:35:06 | <djazayeri> actually... |
| 20:35:27 | <djazayeri> the method sig is java.sql.PreparedStatement.setInt(int, int) |
| 20:35:33 | <djazayeri> so the second can't be null. |
| 20:35:58 | <djazayeri> but it will be in the case of non-voided names |
| 20:36:06 | *** suranga has joined #openmrs |
| 20:36:25 | <wyclif> djazayeri, the only line that can throw a NPE is: |
| 20:36:30 | <djazayeri> how has this ever worked before? |
| 20:36:31 | <wyclif> djazayeri, pStmt.setString(1, conceptName.getLocale().toString()); |
| 20:36:47 | <wyclif> djazayeri, assuming the concept name has no locale |
| 20:37:00 | <mnunez> bwolfe: Eclipse question. I'm doing a fresh run of OMRS 1.8, yet it asks for the runtime.properties. Isn't it supposed to make it automatically the first time? |
| 20:37:14 | <djazayeri> wyclif: nope, the line I pasted is actually throwing the NPE. |
| 20:37:22 | <djazayeri> sunbiz changed it in September. |
| 20:37:23 | <wyclif> djazayeri, can you confirm that, otherwise the logs are deceptive, you might have to try again |
| 20:37:41 | <bwolfe> mnunez, it looks for the runtime props and if it can't find it then it just loads up the initialization wizard |
| 20:37:52 | <bwolfe> go to localhost:8080/openmrs to go through the wizard to create the runtime props |
| 20:37:58 | <djazayeri> I have verified that the method signature for that method takes an int (not an Integer) and we're trying to set it to null. |
| 20:38:08 | <djazayeri> that will throw an NPE when it tries to autobox |
| 20:39:05 | <mnunez> localhost:8080/openmrs does not activate the wizard, it shows this http://pastebin.com/EaDjGect |
| 20:39:27 | <djazayeri> the line used to be something hacky, so I guess I can understand why sunny wanted to change it. |
| 20:39:28 | <djazayeri> Before: pStmt.setString(7, (conceptName.isVoided() && userId != null) ? userId.toString() : null); |
| 20:39:52 | <mnunez> bwolfe: localhost:8080/openmrs does not activate the wizard, it shows this http://pastebin.com/EaDjGect |
| 20:40:07 | <djazayeri> wyclif: thanks for the help, I've got it figured out. |
| 20:41:25 | <wyclif> djazayeri, you need to change it to either call setNull if the the if clause is false |
| 20:41:41 | <wyclif> djazayeri, can you create a ticket for that |
| 20:42:03 | <djazayeri> wyclif: cool! I didn't know there was a setNull method |
| 20:42:04 | <bwolfe> mnunez, make sure mysql is running |
| 20:42:16 | *** downeym has quit IRC |
| 20:42:28 | <djazayeri> wyclif: I'll make the commit as part of TRUNK-1925 (saptarshi's big ticket) |
| 20:51:54 | *** downeym has joined #openmrs |
| 20:51:54 | *** OpenMRSBot sets mode: +o downeym |
| 20:51:54 | *** ChanServ sets mode: +o downeym |
| 20:53:59 | <mnunez> bwolfe: It is running. I rebuilt and rerun but still the same |
| 20:54:12 | <bwolfe> mnunez, 1.8.x branch? |
| 20:54:23 | <mnunez> bwolfe: yeap |
| 20:54:35 | <bwolfe> how recently did you update? |
| 20:55:02 | <bwolfe> mnunez, check the logs, it should say somewhere if its finding a runtime properties file |
| 20:55:07 | <bwolfe> perhaps you have a stray one lying around? |
| 20:57:58 | <bwolfe> sorry mnunez, I'm out of time. but I'm out of ideas too. ping some other guys in here if you can't get it with those suggestions. gnight! |
| 20:57:59 | <mnunez> bwolfe: OpenmrsUtil.getRuntimeProperties(2274) |2011-11-18 17:52:59,976| Unable to find a runtime properties file at /home/marcos/OMRSWorkspace/openmrs/webapp/openmrs-runtime.properties |
| 20:58:21 | <mnunez> bwolfe: no problem. Good night! |
| 20:59:11 | *** suranga has quit IRC |
| 21:15:22 | *** mnunez has quit IRC |
| 21:33:52 | *** dawn_ has quit IRC |
| 21:34:01 | *** nribeka has quit IRC |
| 21:34:57 | *** lh has quit IRC |
| 22:12:01 | *** dawn_ has joined #openmrs |
| 22:12:01 | *** ChanServ sets mode: +v dawn_ |
| 22:12:13 | *** dawn_ has quit IRC |
| 22:14:27 | *** bryq has quit IRC |
| 22:46:10 | *** wyclif has quit IRC |
| 23:16:41 | *** deadpool has joined #openmrs |
| 23:34:26 | *** downeym has quit IRC |
| 23:50:27 | *** deadpool has quit IRC |
| 23:50:52 | *** deadpool has joined #openmrs |