| 00:30:38 | *** burke has joined #openmrs |
| 00:30:39 | *** ChanServ sets mode: +o burke |
| 00:41:39 | *** morristic has joined #openmrs |
| 00:41:40 | <morristic> hello everyone |
| 00:41:47 | <morristic> I narrowed down the error I was having a little |
| 00:42:02 | <morristic> is djazayeri around? |
| 00:42:09 | <djazayeri> hi morristic |
| 00:43:19 | <morristic> Hey! |
| 00:44:00 | <morristic> I found out the the error is not just affected by the date fields, I receive the error if the html form encounter being edited is attempted to be saved without any changes being made |
| 00:44:18 | <morristic> If I make any changes I don't get the error. |
| 00:44:29 | <djazayeri> This happens for your specific html form, but you can't replicate it on the demo server? |
| 00:44:34 | <djazayeri> or for all your forms? |
| 00:44:37 | <djazayeri> or could you replicate it? |
| 00:44:54 | <morristic> I could not replicate this on the demo server |
| 00:45:11 | <morristic> I'm not sure what is different in my forms, except that I use lots of jquery |
| 00:46:07 | <djazayeri> hmm |
| 00:46:25 | <djazayeri> are you hiding something with jquery that's required to submit? |
| 00:46:35 | <djazayeri> (though I can't imagine that would make a difference) |
| 00:52:26 | <morristic> I don't believe so |
| 00:52:34 | *** srinivasa has quit IRC |
| 00:52:43 | <morristic> and query doesn't cause any issues on the initial submission |
| 00:52:52 | <morristic> I am hiding value=null content |
| 00:53:02 | <morristic> but I don't know why that would be required to submit |
| 00:53:14 | <morristic> and not sure how changing anything in the form would make it work. |
| 00:53:16 | <djazayeri> but hidden fields are still submitted in html anyway |
| 00:53:21 | <morristic> right |
| 00:53:37 | <djazayeri> morristic: Is that the full stack trace that you posted? |
| 00:53:45 | <djazayeri> I feel like there must be another level of "caused by" |
| 00:53:46 | <morristic> hrm no |
| 00:53:58 | <morristic> let me see if I can get the full one, sorry about that |
| 00:54:16 | <djazayeri> actually, never mind, I just didn't look closely enough. |
| 00:54:37 | <djazayeri> morristic: which HFE version? |
| 00:55:45 | <morristic> 7.3999 |
| 00:56:02 | <morristic> it says 62 lines missing |
| 00:56:06 | <morristic> or additional |
| 00:56:07 | <djazayeri> oh right, I gave you a custom build |
| 00:56:11 | <morristic> but I don't know how to get them |
| 00:56:26 | <djazayeri> You're editing an existing form... |
| 00:56:37 | <djazayeri> and I assume you're not using any of the create-patient tags? |
| 00:57:03 | <morristic> That's correct |
| 00:57:40 | <morristic> I am using patient attributes |
| 00:57:44 | <morristic> through lookup |
| 00:58:27 | <djazayeri> It's oddâthe stack trace says that it's doing savePerson() |
| 00:58:52 | <djazayeri> which I don't think is necessary, and in fact there's a comment in the code asking why savePerson is being called in all cases. |
| 00:59:02 | <djazayeri> But the actual error is about Obs.dateCreated. |
| 00:59:21 | <djazayeri> And the person/patient object shouldn't have any Obs attached to it. |
| 01:00:38 | <morristic> would it help to see the form html? |
| 01:00:50 | <djazayeri> probably not |
| 01:01:47 | <morristic> it uses the typical encounter details and demographic information code |
| 01:01:59 | <morristic> nothing else even uses a date |
| 01:02:02 | <morristic> obs type |
| 01:02:12 | <djazayeri> it doesn't really have anything to do with dates |
| 01:02:16 | <morristic> ah ok |
| 01:02:24 | <morristic> OH |
| 01:02:33 | <morristic> I think I know what could be causing it... |
| 01:02:36 | <djazayeri> Obs.dateCreated is an internal field for bookkeeping |
| 01:03:16 | <djazayeri> what openmrs version are you using? |
| 01:03:19 | <morristic> I changed the date created database entry to only include date and not hhmmss |
| 01:03:22 | <morristic> 1.8.2 |
| 01:03:29 | <morristic> think that's the culprit? |
| 01:03:35 | <djazayeri> not sure |
| 01:03:44 | <djazayeri> what do you mean that you changed the date created db entry? |
| 01:04:36 | <morristic> in the obs table |
| 01:04:50 | <djazayeri> you mean that you changed the value of an existing row? |
| 01:04:55 | <djazayeri> or you altered the column definition? |
| 01:05:37 | <morristic> bs_datetime |
| 01:05:42 | <morristic> obs_datetime |
| 01:05:43 | <morristic> yes |
| 01:06:05 | <djazayeri> which? altered the column definition? or just changed the value in one row? |
| 01:06:25 | <morristic> I changed it to type date instead of datetime |
| 01:06:38 | <djazayeri> that sounds like a terrible idea... |
| 01:06:41 | <morristic> haha :D |
| 01:06:53 | <morristic> then that's probably my problem! |
| 01:07:13 | <morristic> I changed it because I am using velocity to generate a patient summary |
| 01:07:30 | <morristic> and one of the things that I want is the date, but I didn't want all of the time values |
| 01:07:46 | <djazayeri> surely you can format a date with velocity... |
| 01:08:00 | <morristic> that's probably a better idea |
| 01:08:19 | <djazayeri> see, for example, DataExportFunctions.java in OpenMRS |
| 01:08:28 | <morristic> but I am not so familiar with velocity. I'll change that back and start reading more :) |
| 01:08:28 | <morristic> ok |
| 01:08:59 | <morristic> I am sure that's my problem causing the error |
| 01:09:23 | <morristic> I am running out to dinner, but will get back to you later on it. sorry for being a silly user 8) |
| 01:09:24 | <djazayeri> i.e. you'd create a class with some java functions you want access to. All you need is a simple one to do the proper date formatting |
| 01:09:44 | <djazayeri> then you do velocityContext.put("fn", new YourFunctions()); |
| 01:09:52 | <djazayeri> and in the template you can do fn.formatDate(...) |
| 01:09:56 | <djazayeri> enjoy dinner |
| 01:10:43 | <morristic> Thanks! |
| 01:11:04 | <morristic> I'll work on it later tonight. |
| 01:11:33 | <morristic> I may have some more questions regarding power of velocity over the weekend if your around. |
| 01:11:40 | *** morristic has quit IRC |
| 01:11:58 | <djazayeri> I hate velocity, but will answer what I can. |
| 01:12:13 | <djazayeri> Groovy templates are infinitely better. :-) |
| 01:59:29 | <wyclif> hi djazayeri |
| 02:01:17 | <wyclif> djazayeri, i have been working on the login page and just noticed you closed the ticket |
| 02:01:28 | <wyclif> djazayeri, what is the new approach? |
| 02:03:07 | <djazayeri> wyclif: see https://wiki.openmrs.org/display/RES/Improved+release+testing+by+loading+partial+production+data+into+a+Standalone |
| 02:05:46 | <djazayeri> I put the ticket number in there |
| 02:06:54 | <wyclif> so TRUNK-2838 kind of duplicates the ticket you closed for adding a login page? |
| 02:07:09 | <wyclif> djazayeri, because i think they are similar in a way |
| 02:07:29 | <djazayeri> !trunk-2838 |
| 02:07:30 | <OpenMRSBot> djazayeri: Error: "trunk-2838" is not a valid command. |
| 02:07:37 | <djazayeri> !ticket trunk-2838 |
| 02:07:38 | <OpenMRSBot> djazayeri: [#TRUNK-2838] Initialization Wizard should let you test a username and password for fetching production data via the Release Testing Helper module - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2838 |
| 02:08:02 | <djazayeri> wyclif: I decided to close and create a new ticket, rather than edit the description |
| 02:09:24 | <wyclif> djazayeri, ok |
| 02:09:32 | <djazayeri> but yeah, basically it's the same ticket |
| 02:09:57 | <wyclif> djazayeri, so i will claim since i have some code written for ogin |
| 02:10:03 | <djazayeri> great! |
| 02:10:17 | <wyclif> djazayeri, i still have a concern around login |
| 02:10:23 | <djazayeri> what's that? |
| 02:10:48 | <djazayeri> what's the concern, I mean? |
| 02:10:52 | <wyclif> i have edited TRUNK-2834 |
| 02:11:10 | <wyclif> djazayeri, basically the auth code goes to the servlet |
| 02:11:34 | <djazayeri> wyclif: in the first pass, let's simplify things |
| 02:11:44 | <djazayeri> don't use any persisted authorization, with tokens, or sessions |
| 02:12:08 | <wyclif> it doesn't involve them |
| 02:12:14 | <djazayeri> instead, just let the two specific pages we need (download-sqldump and download-modules) take username and password parameters |
| 02:12:26 | <djazayeri> That will take 2 seconds. |
| 02:12:36 | <djazayeri> And they can be regular pages. |
| 02:13:06 | <djazayeri> At some future point we may try to incorporate Burke's OAuth-like approach, but honestly we should be spending zero time on this now. |
| 02:13:15 | <djazayeri> Step 1 is to get this working end-to-end. |
| 02:13:23 | <wyclif> djazayeri, then it means it is not right to say in the description of TRUNK-2838 that once the wizard has verified the login crendentials |
| 02:13:34 | <wyclif> becacause it actually never does for now |
| 02:13:44 | <wyclif> that is why i was getting a little confused |
| 02:13:56 | <djazayeri> Well, you can add a 3rd controller method for verifying the login credentials. :-) |
| 02:14:10 | <djazayeri> But really I guess there's no need to *verify* them. |
| 02:14:20 | <djazayeri> Just use them to do the download. If it doesn't work, ask again. |
| 02:15:31 | <wyclif> djazayeri, a controller isnt a good approach |
| 02:15:47 | <wyclif> djazayeri, controller return views |
| 02:15:52 | <wyclif> or view names |
| 02:16:36 | <djazayeri> wyclif: actually controllers can write directly to the response if you need them to. |
| 02:16:45 | <wyclif> djazayeri, and the possible views we could employ were introduced in 1.8 yet we want to support earlier versions |
| 02:17:19 | <wyclif> djazayeri, then that would work |
| 02:17:24 | <djazayeri> In this case we want two controllers that let you download files, right? |
| 02:17:33 | <wyclif> djazayeri, anyways i will try to ignore that for now |
| 02:17:39 | <djazayeri> okay. :-) |
| 02:48:04 | *** morristic has joined #openmrs |
| 02:49:12 | *** chopin has joined #openmrs |
| 02:49:12 | *** ChanServ sets mode: +v chopin |
| 03:08:51 | *** upul` has joined #openmrs |
| 03:08:51 | *** ChanServ sets mode: +v upul` |
| 03:29:37 | *** burke has quit IRC |
| 03:32:27 | *** surangak has joined #openmrs |
| 03:32:43 | <djazayeri> wyclif: you there? |
| 03:32:52 | <djazayeri> how do the different versions of the standalone get created? |
| 03:33:04 | <djazayeri> i.e. is there a db file for an empty database, and one for demo data? |
| 03:33:53 | <wyclif> djazayeri, yes |
| 03:33:59 | <djazayeri> where are those? |
| 03:34:17 | <wyclif> no |
| 03:34:36 | <wyclif> you run the install wizard and choose no data |
| 03:34:40 | <wyclif> OR |
| 03:35:36 | <wyclif> you start the install wizard, select simple for quick installation, import demo data, restart the standalone and reset the password to Admin123 |
| 03:35:47 | <wyclif> djazayeri, pretty length |
| 03:35:47 | <djazayeri> oy, that's annoying |
| 03:35:49 | <wyclif> djazayeri, pretty lengthy |
| 03:35:54 | <djazayeri> okay, I'm going to work on cleaning that up. |
| 03:36:04 | <wyclif> djazayeri, may be daniel does something else |
| 03:36:12 | <wyclif> djazayeri, but that is how i do it |
| 03:39:21 | <djazayeri> wyclif: when I run the standalone jar file that's included in the temporary test folder that gets built by packagezip.sh, I get this error |
| 03:39:32 | <djazayeri> it goes to this url (and doesn't find it obviously) http://localhost:8081/.svn/ |
| 03:39:34 | <djazayeri> have you seen this? |
| 03:39:50 | <wyclif> hmmm |
| 03:40:01 | <wyclif> that is quite strange |
| 03:40:10 | <wyclif> is that when u are running the standalone |
| 03:40:29 | <djazayeri> I'm just trying to test quickly as I modify things. |
| 03:40:36 | <djazayeri> If you haven't seen it, now worries. |
| 03:44:52 | <djazayeri> wyclif: have you already checked in the change to 1.9.x that re-enables the 3rd option in the installer? |
| 03:44:57 | <djazayeri> or just trunk? |
| 03:45:11 | <wyclif> yesh |
| 03:45:19 | <wyclif> trunk onlhy |
| 03:45:23 | <wyclif> trunk only |
| 03:45:26 | <djazayeri> ok |
| 03:45:45 | <wyclif> djazayeri, are we backporting the code in this sprint to 1.9? |
| 03:46:00 | <djazayeri> We'll have to, but I think we can do it at the end. |
| 03:57:20 | *** r0bby has joined #openmrs |
| 03:57:20 | *** ChanServ sets mode: +v r0bby |
| 04:34:07 | *** r0bby is now known as robbyoconnor |
| 04:37:05 | *** chopin has quit IRC |
| 06:30:57 | *** surangak has quit IRC |
| 06:31:10 | *** surangak has joined #openmrs |
| 06:45:12 | *** dkayiwa has joined #openmrs |
| 06:46:59 | <dkayiwa> hi surangak |
| 06:47:09 | <surangak> hello Daniel ! |
| 06:47:14 | <surangak> good morning ! |
| 06:47:25 | <dkayiwa> good morning to you too. :) |
| 06:47:48 | <dkayiwa> Did you get an email about 1.9 release on the implementers list (not developers one)? |
| 06:48:06 | <surangak> dkayiwa, yep :P |
| 06:48:14 | <dkayiwa> oh strange |
| 06:48:18 | <surangak> oh, wait a minute to check that |
| 06:48:22 | <dkayiwa> i did not get it on my implementers one |
| 06:48:31 | <dkayiwa> i got it on my dev one |
| 06:48:47 | <surangak> dkayiwa, me too |
| 06:48:55 | <surangak> I did not receive it from Impl list.... |
| 06:49:15 | <dkayiwa> strange!!! |
| 06:49:25 | <dkayiwa> will ask those who are not on both |
| 06:49:39 | <surangak> dkayiwa, mm.. I dont understand... |
| 06:49:46 | <dkayiwa> me tooo |
| 06:49:54 | <surangak> if they r not on both lists, how can they get our mails anyway ? |
| 06:50:26 | <dkayiwa> let me hope the mail server does not just do tricks of avoiding duplicates for those on both :) |
| 06:50:49 | <surangak> dkayiwa, I just checked the nabble list, apparently u have mailed both lists :) |
| 06:51:10 | <dkayiwa> oh thanks for checking that. :D |
| 06:55:33 | *** upul` has quit IRC |
| 06:59:25 | *** kishoreyekkanti has joined #openmrs |
| 07:12:16 | *** upul` has joined #openmrs |
| 07:12:16 | *** ChanServ sets mode: +v upul` |
| 08:10:55 | *** dkayiwa has quit IRC |
| 08:12:44 | *** dkayiwa has joined #openmrs |
| 09:06:03 | <surangak> dkayiwa, hi, may I ask a question ? :) |
| 09:07:54 | <dkayiwa> oh yes |
| 09:14:37 | <surangak> dkayiwa, Im wondering, If I wasnt a crash course on concepts, what should I read ? :) |
| 09:14:52 | <surangak> I mean medical concepts, like the stuff in out concept dictionary.. |
| 09:16:46 | <dkayiwa> surangak: have you read all the concept dictionary wiki pages? |
| 09:17:49 | <surangak> dkayiwa, actually, I m intrested in the basic idea behind concepts, and not 'openmrs concepts' |
| 09:18:11 | <surangak> im wondering if there is a good 'non openmrs specific' document on concepts :) |
| 09:19:19 | <dkayiwa> surangak: i do not think concepts is a medical term :) |
| 09:19:35 | <dkayiwa> surangak: i think it is Paul and Burke's concept :) |
| 09:19:42 | <surangak> dkayiwa, oh... but other EHR systems, use them, right ? |
| 09:19:56 | <surangak> I mean, theres the MVP dictionary also ? |
| 09:19:58 | <dkayiwa> surangak: never seen any using it |
| 09:20:12 | <dkayiwa> mvp is based on openmrs |
| 09:20:40 | <surangak> dkayiwa, oops, I didnt realize that concepts were Dr. Burkes invention :) |
| 09:21:28 | <dkayiwa> :) |
| 09:28:04 | <surangak> dkayiwa, sorry, another question, u can answer when u r free ... Is there a way in openmrs for a super user to restrict the observations that another use can see ? as in " show user X some observations of patient A, but None of patient B " ? |
| 09:28:19 | <surangak> is that what restrict by role module does ? :) |
| 09:37:08 | *** surangak_ has joined #openmrs |
| 09:37:11 | *** surangak has quit IRC |
| 09:38:16 | <dkayiwa> surangak_: i do not think that i possible at the moment |
| 09:38:49 | <surangak_> oh, I see.. thanks :) |
| 09:44:59 | <kishoreyekkanti> dkayiwa: whats the single command devs used to run openmrs in premaven world. |
| 09:45:23 | <kishoreyekkanti> dkayiwa: like mvn jetty:run now. which populates the db, starts the server etc,. |
| 09:45:38 | <kishoreyekkanti> dkayiwa: do we have any single ant target which will do this? |
| 09:46:16 | <dkayiwa> kishoreyekkanti: we used to have a build.xml which had a deploy target |
| 09:47:28 | <kishoreyekkanti> dkayiwa: oh awesome. Will try that once. |
| 09:52:58 | <dkayiwa> kishoreyekkanti: we also used to sometimes run it directly from eclipse as per https://wiki.openmrs.org/display/archive/Developer+How-To+Use+Eclipse+Guide |
| 09:53:17 | <dkayiwa> under section: How to Debug a Web Application with Eclipse |
| 09:54:24 | <kishoreyekkanti> dkayiwa: ohh good. Actually i'm looking at how to migrate concept related data from 1.6 to 1.7 |
| 09:54:36 | <dkayiwa> oh i see |
| 10:04:11 | *** upul` has left #openmrs |
| 10:44:17 | *** deadpool has quit IRC |
| 10:45:20 | *** Carlos has joined #openmrs |
| 10:45:45 | *** Carlos is now known as Guest26338 |
| 10:47:02 | <Guest26338> Hi, i want to attach (word,excel,...) a document to a form. I do not find it in the docs. I have found that there is a type 'Document' that seems to be refered to but i did not find the way to use it. |
| 10:56:09 | *** morristic has quit IRC |
| 11:07:01 | *** surangak_ has quit IRC |
| 11:53:58 | <dkayiwa> hi Guest26338 |
| 12:16:07 | <Guest26338> hi |
| 12:16:24 | <dkayiwa> Guest26338: what does the document contain? |
| 12:18:52 | <Guest26338> The doc could be whatever, a note, an excel file, ... Some you could attach to an encounter for example. If it could be done to a program too it could be a great idea |
| 12:20:59 | *** james_regen has joined #openmrs |
| 12:20:59 | *** ChanServ sets mode: +v james_regen |
| 12:44:30 | <dkayiwa> Guest26338: have you tried complex obs? |
| 12:48:40 | <Guest26338> I am trying but not find a good example. do you have some or url? |
| 13:13:52 | *** kishoreyekkanti has quit IRC |
| 13:38:06 | *** dawn_ has joined #openmrs |
| 13:42:06 | *** wyclif has quit IRC |
| 13:53:03 | *** chopin has joined #openmrs |
| 13:53:03 | *** ChanServ sets mode: +v chopin |
| 13:53:50 | *** raff has joined #openmrs |
| 13:54:16 | *** raff is now known as Guest24187 |
| 13:57:13 | *** Guest24187 is now known as rafa__ |
| 13:59:48 | *** jriley has joined #openmrs |
| 14:10:54 | *** downeym has joined #openmrs |
| 14:10:54 | *** ChanServ sets mode: +o downeym |
| 14:10:54 | *** OpenMRSBot sets mode: +o downeym |
| 14:31:27 | *** wyclif has joined #openmrs |
| 14:32:34 | *** dkayiwa has quit IRC |
| 14:52:28 | <wyclif> hi rafa__ , are you still blocked on some tickets |
| 14:53:10 | <wyclif> rafa__, i know we still have to add the prompts for connecting to the test database |
| 14:55:32 | <rafa__> wyclif: it seems I'm fine now |
| 14:55:58 | <rafa__> wyclif: I'm trying to import a test data set |
| 14:56:49 | <rafa__> wyclif: though I haven't run the code you wrote yet |
| 14:57:02 | <rafa__> wyclif: how are you testing it? |
| 14:57:28 | <rafa__> wyclif: simply deleting properties to trigger the wizard? |
| 14:58:13 | *** kishoreyekkanti has joined #openmrs |
| 14:59:01 | <rafa__> InitializationFilter is messy :/ |
| 15:02:09 | <wyclif> rafa__, am running the standalone as the production system and trunk as the test installation |
| 15:02:26 | <wyclif> rafa__, what is wrong with the InitializationFilter |
| 15:09:51 | <djazayeri> good morning rafa__, wyclif |
| 15:10:05 | <djazayeri> Is bwolfe traveling now? |
| 15:10:22 | <djazayeri> Anyone know where dkayiwa is? |
| 15:10:40 | <rafa__> morning djazayeri |
| 15:11:19 | <wyclif> monring djazayeri |
| 15:11:38 | *** Guest26338 has quit IRC |
| 15:11:41 | <djazayeri> sorry I'm late, University call ran over |
| 15:11:43 | <djazayeri> scrum time. |
| 15:11:57 | <wyclif> djazayeri, i think ben jets in today, not sure about time |
| 15:12:12 | <wyclif> djazayeri, no problem |
| 15:14:02 | <dawn_> ben gets into Indy late this afternoon/early evening |
| 15:14:15 | <djazayeri> okay, so he must be airborn now. |
| 15:14:53 | <dawn_> are we waiting for kayiwa to start the scrum? |
| 15:15:35 | *** dkayiwa has joined #openmrs |
| 15:15:41 | <djazayeri> dawn_: no, we should be starting now |
| 15:15:47 | <djazayeri> ah, dkayiwa, hi |
| 15:15:51 | <dkayiwa> :) |
| 15:15:56 | <dkayiwa> hi djazayeri |
| 15:15:56 | <djazayeri> perfect timing. |
| 15:15:58 | <dawn_> perfect timing dkayiwa |
| 15:15:59 | <dkayiwa> oh yes |
| 15:16:02 | <dkayiwa> lollll |
| 15:16:05 | <djazayeri> Alright, scrum time |
| 15:16:17 | <djazayeri> first, Daniel, contracts on getting the alpha out the door! |
| 15:16:31 | <dkayiwa> oh thanks for all the help you gave me. :) |
| 15:17:45 | <djazayeri> Moving on, who wants to give their report first? |
| 15:18:27 | <rafa__> I can go first :-) |
| 15:18:35 | <djazayeri> Okay rafa__, you're up |
| 15:18:36 | <dkayiwa> as usual :) |
| 15:18:45 | <rafa__> Yesterday: Committed first pass for https://tickets.openmrs.org/browse/TRUNK-2830 (exports just one table) Today: Will work on TRUNK-2826: Installation wizard should download a SQL dump file and use it to generate a test dataset https://tickets.openmrs.org/browse/TRUNK-2826 (to actually test if we can import) No blockers. |
| 15:20:49 | <djazayeri> I'll go next |
| 15:20:58 | <djazayeri> Tuesday: |
| 15:20:58 | <djazayeri> * Documented the goals for the sprint at https://wiki.openmrs.org/x/gYqmAQ |
| 15:20:58 | <djazayeri> * Worked on STAND-31 |
| 15:20:58 | <djazayeri> * Worked on reorganizing standalone to use maven build process (should create ticket) |
| 15:20:58 | <djazayeri> Today: |
| 15:20:58 | <djazayeri> * Continue STAND-31 and reorganizing standalone build process |
| 15:20:59 | <djazayeri> * University call |
| 15:20:59 | <djazayeri> * Design call |
| 15:21:00 | <djazayeri> * Project Management call |
| 15:21:14 | <wyclif> !STAND-31 |
| 15:21:15 | <OpenMRSBot> wyclif: Error: "STAND-31" is not a valid command. |
| 15:21:22 | <wyclif> !ticket STAND-31 |
| 15:21:23 | <OpenMRSBot> wyclif: [#STAND-31] Quick first pass of a one-time prompt for standalone configuration on initial startup - OpenMRS JIRA - https://tickets.openmrs.org/browse/STAND-31 |
| 15:21:35 | <djazayeri> dkayiwa, rafa__, wyclif, please look at that link, and make sure you understand and agree with the workflow we're working on |
| 15:22:59 | <dkayiwa> ok |
| 15:23:12 | <djazayeri> No blockers for me. |
| 15:23:15 | <rafa__> djazayeri: is there a particular reason why 9 is before 10 (sounds funny, but you know what I mean ;-) |
| 15:23:31 | <djazayeri> I need to learn more about how the embedded db works. I'll ask dkayiwa about this after scrum |
| 15:23:37 | <wyclif> djazayeri, the work flow looka fine to me |
| 15:24:19 | <djazayeri> rafa__: first we should load up a database from the production server we're copying, *then* we should update it to 1.9.0-alpha (or whatever the latest schema is) |
| 15:24:20 | <djazayeri> right? |
| 15:24:24 | <wyclif> rafa__, do you step 9 in the workflow? |
| 15:24:56 | <rafa__> djazayeri: right |
| 15:25:04 | <rafa__> wyclif: yes |
| 15:25:13 | <wyclif> djazayeri, how are you telling the wizard that we are running the standalone and how are you passing the database connection details to it? |
| 15:25:40 | <djazayeri> wyclif: I haven't done it yet, but I'm assuming I can do this via the runtime.properties file |
| 15:25:54 | <dkayiwa> wyclif: doesnt the wizard already read database connection from runtime properties file? |
| 15:26:07 | <dkayiwa> wyclif: that is how 1.9 does it |
| 15:26:27 | <dkayiwa> if it finds a runtime properties file, it uses its values as default for things like connection.url |
| 15:27:02 | <djazayeri> dkayiwa: great! |
| 15:27:11 | <wyclif> djazayeri, how about passing parameters via the url the standalone enters into the browser, then the startup filter gets and keeps them in memory |
| 15:27:32 | <wyclif> djazayeri, hmm, i think your approach is better |
| 15:27:36 | <djazayeri> wyclif: I feel like going through the runtime props is better |
| 15:27:42 | <djazayeri> since it's already there, and partly working |
| 15:27:50 | <djazayeri> okay, who's up next? |
| 15:27:50 | <wyclif> djazayeri, am fine with that |
| 15:27:52 | <wyclif> me |
| 15:28:09 | <rafa__> djazayeri: one more question: do we test it running the module on 1.8 and the server on 1.9? |
| 15:28:47 | <djazayeri> rafa__: before this is done we should test as far back as 1.6->1.9 |
| 15:29:10 | <wyclif> yesterday: |
| 15:29:10 | <wyclif> -TRUNK-2838 - Initialization Wizard should let you test a username and password for fetching production data via the Release Testing Helper module |
| 15:29:10 | <wyclif> -TRUNK-2835 - Add a page to the installation wizard that prompts for a url to a production system |
| 15:29:10 | <wyclif> -Had a couple of discussions about the sprint tickets on IRC with darius |
| 15:29:10 | <wyclif> today: |
| 15:29:12 | <wyclif> -Moved some tickets to release testing helper project |
| 15:29:13 | <djazayeri> for day-to-day testing purposes, pointing at whatever you have is fine. |
| 15:29:14 | <wyclif> -Code review sprint tickets |
| 15:29:16 | <wyclif> -TRUNK-2827 - Installation wizard should request for all modules from the production server |
| 15:29:18 | <wyclif> -Fixing the TestController to actually return the zip file now that daniel has implemented the service layer |
| 15:29:21 | <wyclif> -more Sprint tickets |
| 15:29:23 | <wyclif> no blockers |
| 15:29:51 | <rafa__> djazayeri: ok |
| 15:30:33 | <djazayeri> wyclif: I see you moved tickets into the new RELTEST project, which is good. |
| 15:30:49 | <djazayeri> It's probably broken the sprint dashboard, until Ben gets back online and can fix this. |
| 15:31:00 | <djazayeri> So everyone, just be aware of that. |
| 15:31:05 | <djazayeri> dkayiwa: you're up |
| 15:31:11 | <wyclif> djazayeri, yes |
| 15:31:16 | <dkayiwa> Committed my changes for: Add DAO layer to release testing module - TRUNK-2829 |
| 15:31:17 | <dkayiwa> Committed my changes for: Add Service layer to release testing module - TRUNK-2828 |
| 15:31:17 | <dkayiwa> Had a hard time with the same exact problem as reported on: TRUNK-2822 and then worked with Saptarshi to resolve it. (My part was just testing his solution. :) ) |
| 15:31:17 | <dkayiwa> Now working on: Add a settings page for the release testing module - TRUNK-2831 |
| 15:31:17 | <dkayiwa> No Blockers |
| 15:31:40 | <rafa__> !ticket TRUNK-2828 |
| 15:31:42 | <OpenMRSBot> rafa__: [#RELTEST-6] Add Service layer to release testing module - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2828 |
| 15:32:04 | <djazayeri> !ticket trunk-2822 |
| 15:32:06 | <OpenMRSBot> djazayeri: [#TRUNK-2822] openmrs-tools cannot be built in JDK7 or OpenJDK - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2822 |
| 15:32:21 | <wyclif> djazayeri, i have sent an email to all you sprinters with the link to the moved tickets |
| 15:32:56 | <djazayeri> wyclif: if you want practice, you could create a new sprint dashboard, with edited versions of the jira filters. :-) |
| 15:34:04 | <djazayeri> wyclif, dkayiwa, rafa__: everyone is set on what they're working on now? |
| 15:34:13 | <rafa__> i'm fine |
| 15:34:14 | <dkayiwa> yes |
| 15:34:20 | <djazayeri> great |
| 15:34:29 | <djazayeri> dkayiwa: I have some quick questions for you. |
| 15:34:34 | <dkayiwa> ok |
| 15:34:57 | <wyclif> dkayiwa, TRUNK-2838 depends on 2831 in a way |
| 15:35:01 | <djazayeri> We eventually want a workflow like what's described in https://tickets.openmrs.org/browse/STAND-17 |
| 15:35:16 | <dkayiwa> ok |
| 15:35:25 | *** srinivasa has joined #openmrs |
| 15:35:37 | <djazayeri> I.e. we want to have three different databases packaged with the standalone: (a) empty, (b) MVP dictionary, (c) demo data |
| 15:35:49 | <dkayiwa> ok |
| 15:35:51 | <wyclif> dkayiwa, i.e to check if the module ins installed, we are hitting its settings page |
| 15:36:00 | <dkayiwa> ok |
| 15:36:43 | <djazayeri> dkayiwa: I'm thinking that we can just distribute three different data-xyz.zip files |
| 15:37:01 | <dkayiwa> djazayeri: yes that should work |
| 15:37:10 | <djazayeri> and when the user chooses to switch, we wipe out the /database/data folder, and unzip one of the data-xyz.zip files into it. |
| 15:37:23 | <dkayiwa> correct |
| 15:37:56 | <djazayeri> Great, I'll try doing that approach. |
| 15:38:00 | <dkayiwa> ok |
| 15:38:45 | *** Nalaka has joined #openmrs |
| 15:38:54 | <downeym> Hi Nalaka and welcome to the #openmrs IRC channel. |
| 15:39:07 | <djazayeri> alright everyone, scrum is over, catch you all throughout the day. |
| 15:39:34 | <djazayeri> Let's see if we can get a simple end-to-end demo working in the next couple of days |
| 15:39:40 | <dkayiwa> ok |
| 15:39:51 | <wyclif> dkayiwa, have you ensured that bundled modules get included? |
| 15:40:05 | <dkayiwa> wyclif: very good catch :) |
| 15:40:36 | <dkayiwa> wyclif: i did not include them, let me add them before proceeding with my current ticket |
| 15:40:57 | <dkayiwa> wyclif: can i assume that bundled modules will already be in the war file we are about to run? |
| 15:41:03 | <wyclif> dkayiwa, i would probably be relevant if the bundled modules differ in production and test version |
| 15:41:41 | <wyclif> dkayiwa, becomes am assuming modules will be already bundled in the production war file and also in the test war file |
| 15:41:52 | <wyclif> dkayiwa, so i see us having two copies |
| 15:42:01 | <dkayiwa> correct |
| 15:42:11 | <dkayiwa> wyclif: do we have a way of knowing if a user uninstalled a bundled module they do not want? |
| 15:42:15 | *** carlos_a has joined #openmrs |
| 15:42:20 | <wyclif> dkayiwa, a new bundled module was added to the lot |
| 15:42:26 | <downeym> Hi carlos_a and welcome to the #openmrs IRC channel. |
| 15:42:30 | <djazayeri> wyclif, dkayiwa: if you ask for "give me all modules you are running" then you should get all *started* modules, regardless of whether they're in the war or in the filesystem folder |
| 15:42:56 | <dkayiwa> djazayeri: that seems like solves our problem |
| 15:43:05 | <djazayeri> i.e. in case a bundled module is *removed* between releases, we want to make sure it gets brought over from the production system. |
| 15:43:23 | <djazayeri> In practice this won't be an issue for 1.9, because we haven't ever unbundled a module yet. |
| 15:43:48 | <carlos_a> hi all again, does somebody an example of adding a complex_obs? I did not found one |
| 15:43:55 | <dkayiwa> apart from the alpha djazayeri |
| 15:44:00 | <dkayiwa> which does not have formentry |
| 15:44:10 | <djazayeri> oh, right! |
| 15:44:14 | <wyclif> dkayiwa, how is your logic in getZipModules |
| 15:44:18 | <dkayiwa> but its not a full release anyway |
| 15:44:23 | <djazayeri> okay, so this is particularly relevant today! |
| 15:44:32 | <wyclif> dkayiwa, i see as though it fetches those on the applicationd ata directory |
| 15:44:36 | <djazayeri> but yeah, we'll need to re-include that as bundled in the beta |
| 15:44:39 | <wyclif> dkayiwa, instead of asking for running modules |
| 15:44:43 | <dkayiwa> wyclif: jyes |
| 15:44:49 | <wyclif> dkayiwa, as djazayeri suggets |
| 15:44:52 | <djazayeri> Definitely we shouldn't include omods for modules that aren't started. |
| 15:44:59 | <wyclif> dkayiwa, and this is why i was getting concerned |
| 15:45:07 | <dkayiwa> wyclif: ok |
| 15:45:16 | <dkayiwa> will change it |
| 15:45:20 | <djazayeri> If it turns out to be hard to get the bundled (and started) modules from the war, I don't mind if we skip those for now. |
| 15:45:25 | <djazayeri> okay, I've gotta run for a bit. |
| 15:45:32 | *** Nalaka is now known as Nazz |
| 15:45:34 | <dkayiwa> ok |
| 15:45:34 | <djazayeri> carlos_a: it is possible to create complex obs, yes. |
| 15:45:58 | <djazayeri> carlos_a: gotta run for a bit now, but if you ask the question more specifically, someone else can probably help |
| 15:46:12 | <wyclif> dkayiwa, meaning if we get a list of running modules, then your logic should instead look them p from application data dir and bundled module folder one by one |
| 15:46:23 | <wyclif> dkayiwa, does that sound correct? |
| 15:46:36 | <dkayiwa> wyclif: that sounds very very correct. Thanks :) |
| 15:47:29 | <wyclif> dkayiwa, i know things might seem right to say but might not work |
| 15:47:39 | <dkayiwa> lolllllllllll |
| 15:47:47 | <dkayiwa> wyclif: lets see how that goes :) |
| 15:47:55 | <wyclif> dkayiwa, ok |
| 15:48:03 | <dkayiwa> 8) |
| 15:48:24 | *** lh has joined #openmrs |
| 15:48:40 | <dkayiwa> wyclif: did you recieve alpha release notification on the implementers list? |
| 15:48:59 | <dkayiwa> wyclif: i only saw it on the dev list |
| 15:49:18 | *** Nazz has quit IRC |
| 15:49:22 | <dkayiwa> yet i sent on both |
| 15:49:46 | <srinivasa> darius: hi... |
| 15:49:46 | <wyclif> dkayiwa, let me check |
| 15:49:53 | <dkayiwa> ok |
| 15:50:04 | <dkayiwa> downeym: do you have an idea about that? |
| 15:50:15 | <wyclif> dkayiwa, by the way congrats on getting 1.9 out of the door!! |
| 15:50:23 | <wyclif> dkayiwa, by the way congrats on getting 1.9 alpha out of the door!! |
| 15:50:31 | <dkayiwa> wyclif: oh thank you guys for helping me out |
| 15:51:16 | <downeym> dkayiwa: let me take a look |
| 15:51:22 | <dkayiwa> ok |
| 15:51:42 | <downeym> dkayiwa: https://groups.google.com/a/openmrs.org/group/implementers/browse_thread/thread/47b9e27597874bda |
| 15:51:46 | <OpenMRSBot> <http://ln-s.net/9JK1> (at groups.google.com) |
| 15:52:33 | <dkayiwa> oh thanks downeym |
| 15:53:00 | <dkayiwa> i think it just tries to be smart and not send duplicates for one on both lists :) |
| 15:58:01 | *** dawn_ has quit IRC |
| 15:58:57 | *** dkayiwa_ has joined #openmrs |
| 15:59:57 | *** dkayiwa has quit IRC |
| 15:59:57 | *** dkayiwa_ is now known as dkayiwa |
| 16:03:59 | *** dkayiwa has quit IRC |
| 16:26:39 | <carlos_a> \quit |
| 16:38:27 | *** carlos_a has quit IRC |
| 16:44:28 | <djazayeri> hi srinivasa |
| 16:50:35 | *** lh has quit IRC |
| 17:06:23 | *** suranga has joined #openmrs |
| 17:20:24 | *** deadpool has joined #openmrs |
| 17:29:01 | *** jriley has quit IRC |
| 17:40:48 | *** srinivasa has quit IRC |
| 17:50:07 | *** james_regen has quit IRC |
| 17:51:48 | <rafa__> djazayeri, wyclif do we get rid of the current code for creating test installation? Methods like org.openmrs.web.filter.initialization.InitializationFilter.createTestInstallation() for instance? |
| 17:52:11 | <djazayeri> I don't know what that code is so I'll give wyclif a first shot at answering. |
| 17:55:26 | <rafa__> djazayeri: in the meantime question for you :) If I export locations I need to export users who created them. Can we export all users? |
| 17:55:37 | <djazayeri> rafa__: yes |
| 17:55:39 | <djazayeri> all users |
| 17:55:51 | <djazayeri> (and their underlying persons) |
| 17:57:02 | <rafa__> so basically we dump almost everything |
| 17:57:11 | <rafa__> except "patient data" |
| 17:58:58 | <djazayeri> yes |
| 17:59:09 | <rafa__> okay thanks |
| 17:59:12 | <djazayeri> And the main reasoning there is that "patient data" gets too big |
| 17:59:15 | <rafa__> wyclif: |
| 18:00:51 | *** robbyoconnor has quit IRC |
| 18:01:23 | <djazayeri> rafa__, wyclif: do you know if there's a way to create the whole database (by running the liquibase-schema-only scripts) from an ant or maven task? |
| 18:02:01 | <rafa__> http://www.liquibase.org/manual/maven ? |
| 18:02:12 | <djazayeri> looking there, just wondering if you know offhand. :-) |
| 18:02:31 | <rafa__> nope |
| 18:16:11 | *** burke has joined #openmrs |
| 18:16:11 | *** ChanServ sets mode: +o burke |
| 18:18:32 | *** dawn_ has joined #openmrs |
| 18:21:14 | *** dawn_ has quit IRC |
| 18:23:06 | <rafa__> wyclif: ping :-) |
| 18:24:07 | *** dawn_ has joined #openmrs |
| 18:24:35 | *** james_regen has joined #openmrs |
| 18:24:35 | *** ChanServ sets mode: +v james_regen |
| 18:24:58 | *** dawn_ has quit IRC |
| 18:25:16 | <suranga> james_regen, Helllo !! |
| 18:25:59 | <james_regen> suranga: hi |
| 18:26:25 | <suranga> james_regen, seems that report is still not running for Ada |
| 18:26:43 | <suranga> did u see the latest mail ? it looks like she has gone out of memory |
| 18:27:00 | <suranga> (as Jer reports) |
| 18:27:30 | <james_regen> suranga: yeah, it's possible the module did that if too many pairs were made, i think |
| 18:27:43 | <james_regen> assuming that our module caused the error |
| 18:29:03 | <suranga> james_regen, Is it possible for me to set up an amrs environment in my own local machine ? |
| 18:29:07 | <suranga> so that I can test it out |
| 18:29:52 | <suranga> Without that, I cant even debug the problem |
| 18:30:19 | <suranga> maaybe if I can get my hands on an empty amrs db script ? |
| 18:32:48 | *** suranga_ has joined #openmrs |
| 18:33:06 | <suranga_> james_regen, sorry, I got cut off.. did u say anything ? :( |
| 18:33:52 | <james_regen> suranga_: no, didn't say anything. i'm not sure how easily it'd be to replicate the amrs environment for you. i don't know what differences there are |
| 18:34:02 | *** dawn_ has joined #openmrs |
| 18:34:34 | <wyclif> hi rafa__ |
| 18:35:22 | *** suranga has quit IRC |
| 18:37:35 | <rafa__> wyclif: so do you know the answer? |
| 18:37:39 | *** suranga__ has joined #openmrs |
| 18:37:56 | <wyclif> rafa__, djazayeri , we still need InitializationFilter.createTestInstallation() as a utility methods because my assumption is that the wizard will invoke it to download the sql file and modules |
| 18:38:21 | <djazayeri> wyclif: isn't that code moved to the Release Test Helper module? |
| 18:38:31 | <wyclif> rafa__, djazayeri but we will need to edit to look in the right places as per our workflow |
| 18:38:50 | <rafa__> wyclif: it's easier to get rid of them if you don't mind :) |
| 18:38:52 | <wyclif> djazayeri, that is why i said we need to refactor it |
| 18:39:07 | <wyclif> rafa__, it is ok to get rid of it |
| 18:39:18 | <rafa__> cool |
| 18:39:19 | <rafa__> thanks |
| 18:39:31 | <wyclif> rafa__, if you wish to rewrite things from scratch |
| 18:39:54 | <wyclif> in any case it isnt that much code |
| 18:40:16 | <wyclif> about 42 lines |
| 18:40:16 | <rafa__> wyclif: it's not from scratch, it's just that these old methods do completely different things ;-) |
| 18:40:17 | <suranga__> james_regen, hmmm... maybe we can get Win or Jer to dig the stack trace for us ? |
| 18:40:38 | <suranga__> if they find the problem, then I can fix it... |
| 18:41:07 | <james_regen> suranga__: if it happens again, then we can probably get the error message |
| 18:41:15 | *** suranga_ has quit IRC |
| 18:41:33 | <wyclif> rafa__, i'm just not sure how you are going to make the progress bar work properly thought this is a minor thing |
| 18:41:42 | <wyclif> rafa__, get rid of it |
| 18:41:50 | <suranga__> james_regen, great ! :) |
| 18:42:00 | <downeym> djazayeri: ping |
| 18:42:02 | <djazayeri> burke, kishoreyekkanti, downeym: can we figure out the maven naming thing now? |
| 18:42:38 | <wyclif> rafa__, please get rid of the useless methods in TestInstallUtil too if you can |
| 18:42:49 | <djazayeri> downeym points out that OpenMRS really should just be one "organization". |
| 18:42:51 | <djazayeri> Which is fair |
| 18:42:58 | <kishoreyekkanti> djazayeri: do you mean git repo naming thing |
| 18:43:07 | <djazayeri> um, yes. :-) |
| 18:43:18 | <kishoreyekkanti> djazayeri: ok :) |
| 18:43:27 | <rafa__> wyclif: that can be done later since they do not break things :) |
| 18:43:40 | <djazayeri> so, downeym believes that OpenMRS should be just one maven organization. |
| 18:43:52 | <downeym> s/maven/github/g |
| 18:43:57 | <djazayeri> doh! |
| 18:44:01 | <rafa__> I'll mark for deletion what I feel is not needed |
| 18:44:01 | <djazayeri> one github organization |
| 18:44:07 | <djazayeri> github, github, github |
| 18:44:22 | <kishoreyekkanti> djazayeri: ok.. As we discussed, we'll have some noise of different modules and trunk over there |
| 18:44:34 | <djazayeri> right, that was my main concern |
| 18:44:40 | *** nribeka has joined #openmrs |
| 18:44:40 | *** ChanServ sets mode: +v nribeka |
| 18:44:52 | <djazayeri> that there will be hundreds of things under /OpenMRS, of which one is by far the most important |
| 18:44:56 | <djazayeri> how much does that matter? |
| 18:45:13 | <nribeka> hi |
| 18:45:18 | <downeym> djazayeri: do people really browse much? |
| 18:45:19 | <kishoreyekkanti> what will normally goes on top is the latest checked in module/trunk code |
| 18:45:34 | <djazayeri> also, is the idea that it's github.com/Organization/repository ? |
| 18:45:37 | <kishoreyekkanti> so we can't really gurantee that always trunk goes on top |
| 18:46:08 | <kishoreyekkanti> djazayeri: Yeah! that was the normal convention |
| 18:46:59 | <djazayeri> I might argue that only core/bundled/supported modules should go under the OpenMRS organization. |
| 18:47:23 | <downeym> djazayeri: i think that's what the consensus was in Kigali |
| 18:47:26 | <kishoreyekkanti> Yeah! that also is a good idea |
| 18:47:37 | <downeym> djazayeri: the other projects would be under individuals or other orgs who own them |
| 18:47:58 | <djazayeri> Okay, so that means there's going to be much less stuff under /OpenMRS/... |
| 18:48:23 | <kishoreyekkanti> yeah! so that should be the trunk and the other 4 or 5 bundled modules |
| 18:48:34 | <djazayeri> which means that I'm a lot less worried about having trunk disappear into the chaos. |
| 18:49:29 | <djazayeri> so, given that, is it necessary for repository names to include a hint that they're modules? |
| 18:49:30 | <burke> so all of the other modules will go under the account of whomever happens to be "owning" them at the time? |
| 18:49:46 | <burke> so, OpenMRS will have core, bundled modules, and unsupported modules? |
| 18:49:56 | <downeym> djazayeri: btw, the repo search is pretty fast for long lists of repos, e.g. https://github.com/mongodb |
| 18:50:11 | <djazayeri> burke: I wouldn't include unsupported modules. |
| 18:50:25 | <burke> where do they go? |
| 18:50:37 | <djazayeri> if we need to put them somewhere we can create an organization called NotSupportedByOpenMRS |
| 18:50:38 | <djazayeri> :-) |
| 18:51:12 | <djazayeri> I prefer github.com/OpenMRS-not-supported/hacks |
| 18:51:12 | <kishoreyekkanti> :) |
| 18:51:13 | <burke> I suppose we could have a openmrs-abandoned user |
| 18:51:26 | <downeym> if they're unsupported, why not just leave them in svn |
| 18:51:37 | <burke> there will be unsupported in git too. |
| 18:51:54 | <burke> there will be things that are bundled and later are not bundled & vice-versa |
| 18:51:56 | <djazayeri> we don't need to *create* git repos for unsupported modules. |
| 18:52:03 | <djazayeri> yes, things may become unsupported over time. |
| 18:52:18 | <djazayeri> though I doubt that we would delete it from /OpenMRS at that point... |
| 18:52:30 | <kishoreyekkanti> If leaving unsupported modules will not cost us any effort, i think leaving them in svn would be better |
| 18:52:30 | <burke> we need to carry on the source. as long as svn is up & running, we don't need them in git. |
| 18:52:43 | <djazayeri> okay, back to the main question then |
| 18:52:57 | <djazayeri> should it be github.com/OpenMRS/htmlformentry |
| 18:53:02 | <djazayeri> or github.com/OpenMRS/htmlformentry-module |
| 18:53:14 | <djazayeri> or github.com/OpenMRS/modules/htmlformentry |
| 18:53:22 | <djazayeri> or github.com/OpenMRS/modules-htmlformentry |
| 18:53:24 | <burke> so, the groovy module will be github.com/bmamlin/groovy? |
| 18:53:51 | <djazayeri> burke: seems like you'd want some hint at OpenMRS there no? Or is that not necessary? |
| 18:54:07 | <downeym> ./bmamlin/openmrs-module-groovy |
| 18:54:18 | <djazayeri> Offhand I like http://github.com/OpenMRS/htmlformentry-module (but my knowledge of git conventions is zero) |
| 18:54:42 | <nribeka> i like openmrs-module-reporting better |
| 18:54:47 | <nribeka> and openmrs-core |
| 18:54:47 | <burke> why not github.com/openmrs/openmrs-module-htmlformentry |
| 18:55:04 | <downeym> "openmrs-module-foobar" is a nice progression of broad to specific |
| 18:55:09 | <kishoreyekkanti> i don't think we have any real conventions over there. But this look good for me as modules come first while reading the url . github.com/OpenMRS/modules-htmlformentry |
| 18:55:18 | <downeym> or even "module-foobar" |
| 18:55:27 | <djazayeri> burke, downeym: I feel like "openmrs" is implied |
| 18:55:30 | <nribeka> openmrs-standalone |
| 18:55:36 | <burke> i would rather have one convention instead of one thing for OpenMRS and something else for everybody else |
| 18:55:39 | <downeym> djazayeri: unless it's in some other individual or organization |
| 18:55:40 | <djazayeri> I'd prefer "module-xyz" rather than "openmrs-module-xyz", given that it's under /OpenMRS |
| 18:55:55 | <burke> boo for two different conventions |
| 18:55:59 | <djazayeri> fine |
| 18:56:21 | <downeym> so by such a model PIH team or jembi might have an org, too, right? |
| 18:56:30 | <downeym> or raxa-jss |
| 18:56:30 | <djazayeri> yes |
| 18:56:53 | <djazayeri> e.g. github.com/PIH/openmrs-module-simplelabentry |
| 18:56:54 | <burke> so we end up with github.com/organizationoruser/openmrs-[core|module|contrib]-foobar? |
| 18:57:09 | <downeym> that seems the most future proof that i can think of at the moment |
| 18:57:28 | <burke> then we'll need to evolve a convention for README.txt |
| 18:57:28 | <djazayeri> what does core actually look like under that scheme? |
| 18:57:38 | <downeym> openmrs-core ? |
| 18:57:45 | <burke> github.com/openmrs/openmrs-core/ |
| 18:58:13 | <downeym> then if kishoreyekkanti forks it would be github.com/kishoreyekkanti/openmrs-core/ |
| 18:58:16 | <djazayeri> So that other orgs can duplicate openmrs-core and not have it just called "core"? |
| 18:58:16 | <djazayeri> fine. |
| 18:58:22 | <djazayeri> sounds right. |
| 18:58:38 | <burke> yup |
| 18:58:40 | <kishoreyekkanti> yes! |
| 18:58:41 | <downeym> i suppose we can't force the convention :) |
| 18:58:46 | <downeym> but at least i trust kishoreyekkanti :) |
| 18:58:55 | <kishoreyekkanti> :) ha ha |
| 18:58:56 | <burke> just hack into github and enforce away. :) |
| 18:59:20 | <burke> ok. i'll delete openmrs-modules & openmrs-contrib orgs |
| 18:59:59 | <djazayeri> great |
| 19:00:34 | <downeym> is someone gonna document this momentous decision? |
| 19:00:36 | <kishoreyekkanti> downeym: yeah! we can't enforce the convention as once a guy forks then openmrs-core is his project and he can change its name to what ever he wants :) |
| 19:00:40 | <downeym> (besdies OpenMRSBot ) |
| 19:01:06 | <burke> openmrs-modules & openmrs-contrib orgs are history |
| 19:04:13 | <downeym> fwiw, the other positive about this convention is it makes sure all openmrs work shows up in a github search |
| 19:06:48 | *** deadpool has quit IRC |
| 19:07:31 | *** deadpool has joined #openmrs |
| 19:09:34 | <downeym> what if we renamed the /OpenMRS/ org to something like "OpenMRS Core Team" |
| 19:09:38 | <djazayeri> burke: joining design call? |
| 19:09:47 | <djazayeri> downeym: I don't like that |
| 19:10:27 | <burke> "OpenMRS Core Team"? Yuck. How about "OpenMRS Elite... go away!" instead. :-) |
| 19:10:34 | <kishoreyekkanti> downeym: This org name goes into the URL so it would not look good |
| 19:10:48 | <kishoreyekkanti> downeym: and its tough to remember for general audience |
| 19:11:20 | <downeym> yeah i'm not sure i do either -- i'm talking about the descriptive name though and not the ID/URL |
| 19:21:32 | <kishoreyekkanti> so, do we agree for renaming "HTML-Form-Entry" to "module-htmlformentry" under current openmrs org? |
| 19:22:38 | <downeym> module-htmlformentry or openmrs-module-htmlformentry ? |
| 19:23:36 | <kishoreyekkanti> 'http://github.com/openmrs/openmrs-module-htmlformentry' is that fine? |
| 19:26:18 | <kishoreyekkanti> if we wanted to maintain consistency across org(as burke said) then we can go with openmrs-module-htmlformentry. But both of them looks fine for me [:) |
| 19:26:47 | <burke> openmrs-module-htmlformentry |
| 19:26:54 | <burke> for everyone, openmrs included. |
| 19:27:20 | <burke> so, the proposed convention is to preface openmrs modules with openmrs-modules- within git |
| 19:29:58 | *** kishoreyekkanti has left #openmrs |
| 19:36:12 | <burke> so, within gitbu.com/Openmrs/ we are going to rename "HTML-Form-Entry" to "htmlformentry" and rename "modulerepository" to "openmrs-contrib-modulerepository"? Correct? |
| 19:36:39 | <burke> is someone else going to do this? or shall I? |
| 19:38:14 | <downeym> burke: i renamed modrepo since i made it originally :) |
| 19:38:46 | <wyclif> hi rafa__ |
| 19:39:01 | <burke> cule. i'd like to give kishoreyekanti the chance to rename htmlformentry to openmrs-module-htmlformentry |
| 19:39:07 | <wyclif> responding to your ticket about the connection credentials |
| 19:39:52 | <wyclif> rafa__, how does the wizard know how to connect to the test database if you are not running the standalone |
| 19:42:47 | *** dkayiwa has joined #openmrs |
| 19:46:56 | *** Echidna_ has quit IRC |
| 19:49:32 | <wyclif> hi rafa__ \ |
| 19:49:35 | <wyclif> hi rafa__ |
| 19:50:11 | *** dkayiwa has quit IRC |
| 19:51:57 | *** dkayiwa has joined #openmrs |
| 19:54:03 | *** Echidna has joined #openmrs |
| 19:54:03 | *** ChanServ sets mode: +v Echidna |
| 20:00:03 | *** wluyima has joined #openmrs |
| 20:00:20 | *** wluyima has joined #openmrs |
| 20:00:23 | *** wyclif has quit IRC |
| 20:01:44 | *** downeym has quit IRC |
| 20:01:53 | *** downeym has joined #openmrs |
| 20:01:53 | *** ChanServ sets mode: +o downeym |
| 20:01:53 | *** OpenMRSBot sets mode: +o downeym |
| 20:10:06 | *** suranga__ has quit IRC |
| 20:10:31 | *** Test has joined #openmrs |
| 20:10:42 | <downeym> Hi Test and welcome to the #openmrs IRC channel. |
| 20:10:56 | *** Test has quit IRC |
| 20:11:18 | <downeym> heh. |
| 20:23:21 | <burke> not a lot happening in the design forum at the moment... |
| 20:27:27 | <wluyima> hi rafa__ |
| 20:28:43 | <rafa__> hey |
| 20:29:02 | <rafa__> wluyima: |
| 20:30:21 | <wluyima> rafa__, have seen RELTEST-2 |
| 20:30:28 | *** james_regen has quit IRC |
| 20:30:39 | <rafa__> !ticket RELTEST-2 |
| 20:30:40 | <OpenMRSBot> rafa__: [#RELTEST-2] Add a settings page for the release testing module - OpenMRS JIRA - https://tickets.openmrs.org/browse/RELTEST-2 |
| 20:30:58 | <wluyima> i think you wrote code that should have been belonging to it in TRUNK-2826 |
| 20:31:07 | <wluyima> rafa__, and |
| 20:31:12 | <rafa__> wluyima: I just added an empty page |
| 20:31:22 | <rafa__> wluyima: to test import |
| 20:31:37 | <wluyima> rafa__, can please notify daniel about |
| 20:31:48 | <wluyima> rafa__, so that he doesnt add another |
| 20:32:02 | <rafa__> wluyima: sure |
| 20:32:03 | <wluyima> rafa__, you can comment on the ticket if you cant get him on IRC |
| 20:32:08 | <wluyima> rafa__, thanks |
| 20:32:08 | <dkayiwa> am around :) |
| 20:32:30 | *** lh has joined #openmrs |
| 20:32:33 | <wluyima> dkayiwa, rafa__ rafa has added a blank settings page, you might consider using that |
| 20:32:40 | <dkayiwa> oh definately |
| 20:32:51 | <dkayiwa> thanks for the notification wluyima |
| 20:33:18 | <wluyima> rafa__, from which page are you capturing cerdeantials for test database? |
| 20:33:21 | <dkayiwa> wluyima: has he committed it yet? |
| 20:33:28 | <wluyima> dkayiwa, yes he did |
| 20:33:33 | <dkayiwa> oh cool |
| 20:33:55 | <wluyima> rafa__, am trying to find it |
| 20:34:53 | <rafa__> wluyima: note TESTING_AUTHENTICATION_SETUP step redirects to DATABASE_SETUP |
| 20:35:48 | <rafa__> so it uses the existing workflow |
| 20:37:41 | <wluyima> rafa__, i wasnt sure if we wanted to go to that page suring test install |
| 20:39:48 | <wluyima> rafa__, i have seen that you change to logic to go to the database setup page, no problem |
| 20:40:07 | <wluyima> rafa__, great |
| 20:40:24 | <rafa__> wluyima: good, but the import is not working yet :( |
| 20:40:40 | <rafa__> wluyima: I'm having some hard times with that |
| 20:41:46 | <wluyima> rafa__, so did you edit the rewiew.vm page to display the summary differently for the test installaation? |
| 20:41:55 | <rafa__> wluyima: nope |
| 20:41:58 | <wluyima> rafa__, what is the problem? |
| 20:42:04 | <wluyima> rafa__, never mind i will |
| 20:42:05 | <rafa__> wluyima: that still needs to be done |
| 20:42:23 | <rafa__> wluyima: okay |
| 20:42:57 | <rafa__> wluyima: the problem is that executing queries one-by-one doesn't respect turning off foreign key constraints |
| 20:43:11 | <rafa__> wluyima: I think I need to either import tables in the right order |
| 20:43:14 | <wluyima> rafa__, hmm.. |
| 20:43:29 | <rafa__> wluyima: or use mysql binary directly to import the dump |
| 20:43:44 | <wluyima> rafa__, ben talked of using liquibase to load the data but am not sure how this is done |
| 20:44:31 | <wluyima> rafa__, are there any downsides to using mysql binary that you are aware of? |
| 20:46:04 | <rafa__> wluyima: we need to know the path if it is not setup right in runtime variables in the os we're running |
| 20:46:55 | <rafa__> wluyima: but other than that it should work in most cases |
| 20:48:00 | <wluyima> rafa__, the quick pass would be to assume that the user has it on the OS path, just for you not to get blocked |
| 20:48:07 | *** dawn_ has quit IRC |
| 20:48:41 | <rafa__> wluyima: I agree it's a fair assumption :) |
| 20:48:44 | <wluyima> rafa__, then you can create a ticket to add a property in the runtime file incase of the standalone |
| 20:49:29 | <rafa__> wluyima: yeah the path is easy to guess in case of the standalone :) |
| 20:49:37 | *** lh has quit IRC |
| 20:49:53 | <wluyima> rafa__, if we are not running the standalone and the user doesnt have it on the path, then display an error message that asks them to do so |
| 20:50:41 | <rafa__> cool |
| 20:50:47 | <wluyima> rafa__, but dont worry about it for now |
| 20:51:12 | <rafa__> yeah the priority is to make it work :) |
| 20:56:21 | <wluyima> rafa__, correct |
| 20:57:10 | <wluyima> rafa__, we will have to edit the step numbering in the init wizard depending on the install methods the user selects |
| 20:57:38 | <rafa__> wluyima: maybe we should put the two new steps at the end :) |
| 20:57:50 | <wluyima> rafa__, because now when i get to the database setup page, i see step 1 of 5 but these are minor isssues for now |
| 20:57:52 | <rafa__> wluyima: it's easier than renumbering |
| 20:58:12 | <wluyima> rafa__, which ones? |
| 20:58:36 | <wluyima> rafa__, i mean which steps to remove |
| 20:58:36 | <rafa__> production_url being 6 and authentication being 7 |
| 20:58:59 | <wluyima> rafa__, will see |
| 20:59:16 | <rafa__> yeah whatever is easier :) |
| 21:00:27 | <wluyima> rafa__, and the other thing is that for the test install methods, after database setup, review page is next |
| 21:00:51 | <wluyima> rafa__, i will fix these, so dont worry about them, just letting you know |
| 21:01:10 | <rafa__> wluyima: good, thx |
| 21:03:24 | *** dawn_ has joined #openmrs |
| 21:04:30 | <wluyima> rafa__, so how are you doing the import, because when i ran things looks like am going through the normal installation instead of importing data and run updates? |
| 21:05:13 | <wluyima> rafa__, or you haven't yet put all the pieces together, if you need help with these, i can |
| 21:05:18 | <rafa__> before running the normal installation it actually tries to import data, but it fails |
| 21:05:27 | <wluyima> rafa__, ok |
| 21:05:34 | <rafa__> and continues with normal installation |
| 21:06:33 | <rafa__> I should probably stop the installation at this point |
| 21:07:45 | <wluyima> rafa__, let me commit the fix to redirecting to rewiew page after database setup |
| 21:07:49 | *** dkayiwa has quit IRC |
| 21:28:30 | *** wyclif has joined #openmrs |
| 21:36:57 | <wluyima> rafa__, i thi k i know why you are not getting to the import stages |
| 21:37:25 | <wluyima> rafa__, let clean up some of the filter's variables |
| 21:37:43 | <wluyima> rafa__, because the code is actually failing to connect to the test database |
| 21:38:40 | <rafa__> wluyima: but it works for me... |
| 21:39:03 | <wluyima> hmm, may be you have not yet committed some of your changes |
| 21:39:03 | <rafa__> wluyima: have you updated recently? |
| 21:39:14 | <wluyima> lat try again |
| 21:39:25 | <rafa__> wluyima: all seems to be committed |
| 21:39:25 | <wluyima> let me try again after svn update |
| 21:40:25 | <rafa__> wluyima: it fails for me with Error executing sql: CREATE TABLE `concept` ( `concept_id` int(11) NOT NULL AUTO_INCREMENT, `retired` smallint(6) N |
| 21:40:32 | <rafa__> but that is all right |
| 21:41:15 | <rafa__> since the import doesn't work yet |
| 21:42:08 | *** jriley has joined #openmrs |
| 21:43:36 | *** jriley has left #openmrs |
| 21:50:34 | *** dawn_ has quit IRC |
| 21:52:31 | <wluyima> rafa__, even after updating, it still fails for me |
| 21:52:36 | <wluyima> at this line InitializationFilter.verifyConnection(799) |
| 21:53:10 | *** chopin has quit IRC |
| 21:53:31 | <wluyima> rafa__, and the reason is because the test databae user name is blank and this is why i said i need to cleanup the variables in the filter |
| 21:53:33 | <rafa__> wluyima: hmmm do you have the module running? |
| 21:54:14 | <wluyima> yes |
| 21:54:25 | <rafa__> wluyima: that is strange |
| 21:54:25 | <wluyima> but it is connecting to my local datatase |
| 21:54:36 | <wluyima> am connecting well to the database |
| 21:55:00 | <wluyima> rafa__, but when i look at the code, i surely expect this error |
| 21:55:16 | <wluyima> rafa__, so am wondering why you are not getting this error |
| 21:55:29 | <wluyima> rafa__, are you you have no local changed in your working copy? |
| 21:55:32 | <wluyima> sure |
| 21:56:25 | <rafa__> no local changes but let me update |
| 21:58:17 | <rafa__> wluyima: you haven't committed anything right? |
| 22:01:14 | <rafa__> lol it definitely works for me |
| 22:01:26 | <wluyima> rafa__, no |
| 22:01:37 | <rafa__> it even enters the breakpoint |
| 22:01:54 | <wluyima> rafa__, but in the code base i see why it should fail because it is what am fixing |
| 22:02:13 | <rafa__> wluyima: okay go ahead and commit your fix |
| 22:02:27 | <rafa__> wluyima: I hope it'll still work for me :-) |
| 22:08:33 | *** jwishnie has joined #openmrs |
| 22:09:27 | <wluyima> rafa__, i will let you know when i commit |
| 22:10:05 | <wluyima> rafa__, am fixing the wizardcomplete page and wizard not to show irrelevant pages for test install |
| 22:21:25 | *** finbrein has joined #openmrs |
| 22:21:48 | *** nribeka has quit IRC |
| 22:26:11 | *** lh has joined #openmrs |
| 22:37:17 | <wluyima> rafa__, why mine is failing is because actually the wizard uses the username/password entered from the create user page which in my working copy i have skipped and we are actually supposed to skip it |
| 22:37:27 | <wluyima> rafa__, this is why it works for you and not me |
| 22:38:11 | <rafa__> wluyima: ha! |
| 22:38:36 | <rafa__> wluyima: why are we skipping this? |
| 22:41:01 | <wluyima> rafa__, there is a contradiction here, probably instead of skipping it, i will just hide just portions on the create user page |
| 22:41:36 | <wluyima> rafa__, some info on that page is irrelevant to ask for the test install methods except for creaing an openmrs user |
| 22:42:02 | <wluyima> rafa__, so am thinking that the test install methd should not skip the create user task |
| 22:42:21 | <rafa__> wluyima: agre |
| 22:42:35 | <rafa__> wluyima: but it should skip adding demo data :) |
| 22:43:20 | <wluyima> rafa__, so i wll just hide some fields on that page instead of skipping the page |
| 22:43:32 | <rafa__> yeah sounds good |
| 22:48:25 | <wluyima> rafa__, have you added the code for installing modules? |
| 22:48:53 | <wluyima> rafa__, just want to know so that i dont do it again |
| 22:49:15 | <rafa__> wluyima: no |
| 22:49:16 | <wluyima> rafa__, it is already in trunk in TestInstallUtil |
| 22:49:19 | <wluyima> rafa__, ok |
| 22:54:19 | *** burke is now known as burke_away |
| 23:11:24 | <wluyima> hi rafa__ |
| 23:11:36 | <wluyima> rafa__, what do you use this variable for wizardModel.importTestData |
| 23:11:51 | <wluyima> rafa__, other than checking if we need to do a test installation |
| 23:12:52 | <wluyima> rafa__, how i did it before is that in Completion task |
| 23:13:20 | *** rafa__ has quit IRC |
| 23:13:32 | <wluyima> you check for the install method if it is testing and then add the tasks to execute |
| 23:19:24 | *** downeym has quit IRC |
| 23:22:54 | *** finbrein has quit IRC |
| 23:23:10 | *** finbrein has joined #openmrs |
| 23:38:14 | *** burke_away is now known as burke |