| 00:28:32 | *** lh has joined #openmrs |
| 00:54:20 | *** robbyoconnor has joined #openmrs |
| 00:54:20 | *** ChanServ sets mode: +v robbyoconnor |
| 02:09:58 | *** lh has quit IRC |
| 02:09:59 | *** lh has joined #openmrs |
| 02:39:22 | *** lh has quit IRC |
| 02:47:04 | *** lh has joined #openmrs |
| 03:09:28 | *** lh has quit IRC |
| 03:09:41 | *** lh has joined #openmrs |
| 03:39:03 | *** surangak has joined #openmrs |
| 04:54:20 | *** srinivasa has joined #openmrs |
| 05:33:45 | *** bwolfe has joined #openmrs |
| 05:33:45 | *** ChanServ sets mode: +o bwolfe |
| 05:48:09 | <surangak> good morning bwolfe |
| 05:48:19 | <surangak> only me and thee today :) |
| 05:49:50 | <bwolfe> surangak, orly? |
| 05:50:09 | <surangak> mm... orly ?? mm..... |
| 05:50:31 | <surangak> oh, I mean out of our regular 'gang' of morning ppl... :D |
| 05:50:59 | <bwolfe> "oh really" |
| 05:51:10 | <bwolfe> yeah, ok. seems we have the regular lurkers though :-) |
| 06:39:44 | *** dkayiwa has joined #openmrs |
| 06:44:17 | *** surangak has quit IRC |
| 06:46:52 | *** surangak has joined #openmrs |
| 06:48:22 | *** morristic has quit IRC |
| 06:53:14 | <dkayiwa> hi bwolfe |
| 06:53:18 | <bwolfe> hey |
| 06:53:21 | <bwolfe> good morning |
| 06:53:32 | <dkayiwa> good morning to you too |
| 06:53:43 | <dkayiwa> bwolfe: do we have a sprint going on this week? |
| 06:53:49 | <bwolfe> yes |
| 06:53:55 | <bwolfe> is the sprint schedule not up to date? |
| 06:54:21 | <dkayiwa> bwolfe: checking... |
| 06:54:53 | <bwolfe> looks like its up to date, just no links for this week! |
| 06:55:04 | <dkayiwa> ok |
| 06:55:43 | <bwolfe> wyclif emailed us this link: https://tickets.openmrs.org/browse/TRUNK/fixforversion/14200 |
| 06:55:47 | <bwolfe> did you see that email from him yesterday? |
| 06:56:10 | <dkayiwa> i do not remember having read it |
| 06:59:25 | <dkayiwa> bwolfe: on another note, i was about to send an email about my intentions to have a vacation from Nov 21 to Dec 2. But i see Nov 21 - Dec 4 about beta release and being the release manager, looks like i should be around during those dates. So do you think i should reschedule the vacation? |
| 07:00:15 | <bwolfe> hmm, yes, that would be bad timing |
| 07:00:28 | <bwolfe> is it possible to reschedule your vacation, or do you have strict plans? |
| 07:00:41 | <dkayiwa> bwolfe: i can reschedule |
| 07:00:45 | <bwolfe> that sprint is more about bug fixing, etc |
| 07:00:54 | <dkayiwa> ok |
| 07:01:06 | <bwolfe> so you could miss the first half of it |
| 07:01:21 | <bwolfe> but apparently you are required for the packaging, etc (mainly for the standalone...) |
| 07:01:35 | <dkayiwa> ok |
| 07:06:53 | <srinivasa> bwolfe:hi..I have seen your mail...we will create a doc of what we have done...and regarding the code...our code is being reviewed by our class mates ..we are making the appropriate changes...we will commit the code once we are done with it.. |
| 07:09:08 | <bwolfe> ok |
| 07:09:12 | <bwolfe> commit to where srinivasa? |
| 07:13:49 | *** dkayiwa has quit IRC |
| 07:14:35 | *** dkayiwa has joined #openmrs |
| 07:20:14 | <bwolfe> srinivasa, ok, done with my review |
| 07:20:23 | <dkayiwa> bwolfe: is the sprint consisting of only those six tickets in the link you sent me? |
| 07:20:23 | <bwolfe> overall it looks pretty good! just a few minor corrections |
| 07:20:41 | <bwolfe> dkayiwa, I saw a lot more tickets fly by my inbox... |
| 07:21:26 | <bwolfe> dkayiwa, I see 10 in that link |
| 07:21:38 | <bwolfe> although all are in "needs assessment" :-/ |
| 07:21:48 | <bwolfe> darius was supposed to review them last night in prep for today |
| 07:22:35 | <dkayiwa> ok. was looking at the summary tab :) |
| 07:23:24 | *** srinivasa has quit IRC |
| 07:25:54 | <surangak> bwolfe, im wondeing, how many patients in the AMPATH database ? Im running a report with 10,000 patients, and its taking some time... |
| 07:26:30 | <bwolfe> surangak, 180000 patients I think |
| 07:26:37 | <bwolfe> but over 100 million obs |
| 07:26:46 | <bwolfe> your report will take a while :-p |
| 07:26:49 | <surangak> bwolfe, ooops, I really hope that thjey have a powerful server :) |
| 07:26:58 | <bwolfe> surangak, it is |
| 07:27:21 | <bwolfe> dkayiwa, so did you pick out one to work on, or do you need advise? what have you been doing so far today? |
| 07:27:47 | <dkayiwa> bwolfe: am looking into them to pick a juicy one. :) |
| 07:28:49 | <bwolfe> nice |
| 07:39:38 | <bwolfe> dkayiwa, the first step is probably to actually create the module. did he make a ticket about htat? |
| 07:39:53 | <dkayiwa> yes |
| 07:39:57 | <bwolfe> if not, use the module maven archetype thing and create a new module asap |
| 07:40:09 | <dkayiwa> ok |
| 07:57:36 | <dkayiwa> bwolfe: do you have a better name of the module other than test ? |
| 07:57:57 | <bwolfe> dkayiwa, I like "testing", as I put in a comment on your ticket |
| 07:58:06 | <dkayiwa> ok |
| 07:58:07 | <bwolfe> or maybe "releasetesting" if you want to be more specific |
| 07:58:12 | <dkayiwa> ok |
| 07:59:02 | <dkayiwa> gone with testing :) |
| 08:24:47 | <dkayiwa> bwolfe: adding the maven project to the module repository is a but confusing to the newbie like me. Do i add the three projects? :) |
| 08:25:25 | <bwolfe> dkayiwa, just check it in like normal |
| 08:25:30 | <bwolfe> check in at the "module" level |
| 08:25:33 | <bwolfe> the top one |
| 08:26:00 | <dkayiwa> bwolfe: meaning i check in only the top level project? Am using subclipse |
| 08:28:19 | <bwolfe> yes, top level |
| 08:28:22 | <bwolfe> and it will check in the others |
| 08:28:24 | <dkayiwa> ok |
| 08:28:48 | <bwolfe> the top level is just a copy of the other two. or rather the other two are a copy/symlink to the api/omod projects in the top one |
| 08:28:56 | <dkayiwa> ok |
| 09:51:21 | <dkayiwa> bwolfe: as for the testing module, what is the use of getPatientWithMostEncounters and getPatientWithMostObs ? |
| 09:59:06 | <bwolfe> dkayiwa, thats so that patient can be included in the test data |
| 09:59:28 | <bwolfe> dkayiwa, you know our scrum is happening at 6pm instead of 5pm today, right ? |
| 09:59:33 | <dkayiwa> bwolfe: i thought we included more than one patient (as in many) |
| 09:59:42 | <dkayiwa> oh i did not know |
| 09:59:48 | <bwolfe> yes, a lot of random patients...and that one main patient |
| 09:59:48 | <dkayiwa> thanks for the reminder :) |
| 10:00:05 | <dkayiwa> bwolfe: whats the use of the main patient? |
| 10:00:46 | <bwolfe> you mean the patient with most encounters and obs? |
| 10:00:52 | <dkayiwa> both |
| 10:00:54 | <dkayiwa> bwolfe: |
| 10:01:11 | <bwolfe> just so that that patient is in the test data for the new version |
| 10:01:30 | <bwolfe> its just a way to make sure that we aren't selecting all crap patients |
| 10:01:36 | <dkayiwa> ok |
| 10:01:56 | <bwolfe> because its hard to test with someone that has 1 or 0 encounters |
| 10:01:56 | <bwolfe> (can't test reports, patient dashboard, editing of encounters, editing of obs, etc) |
| 10:02:12 | <dkayiwa> ok |
| 10:18:52 | *** mnunez has joined #openmrs |
| 10:22:42 | *** kishoreyekkanti has joined #openmrs |
| 10:36:55 | *** mnunez has quit IRC |
| 10:37:07 | *** kishoreyekkanti has quit IRC |
| 10:42:30 | <surangak> im going offline for a while guys... back in a few hours.... |
| 10:42:40 | *** surangak has quit IRC |
| 10:46:05 | *** mnunez has joined #openmrs |
| 10:47:28 | *** mnunez has quit IRC |
| 10:50:42 | *** mnunez has joined #openmrs |
| 10:51:38 | <mnunez> Morning! |
| 10:54:01 | <bwolfe> hi marcos |
| 11:39:18 | <mnunez> dkayiwa: I'm trying to use Xforms to modify encounters. Is there a way to make the repeat sections load all of the observations, not just the last one? |
| 11:45:16 | *** dkayiwa has quit IRC |
| 11:46:14 | *** dkayiwa has joined #openmrs |
| 12:02:04 | *** mnunez has quit IRC |
| 12:02:19 | *** mnunez has joined #openmrs |
| 12:05:41 | *** james_regen has joined #openmrs |
| 12:05:41 | *** ChanServ sets mode: +v james_regen |
| 12:24:48 | <mnunez> dkayiwa: any thoughts? Is it possible? |
| 12:25:07 | <dkayiwa> mnunez: ?? |
| 12:25:25 | <mnunez> Ah, you where offline |
| 12:25:28 | <mnunez> dkayiwa: I'm trying to use Xforms to modify encounters. Is there a way to make the repeat sections load all of the observations, not just the last one? |
| 12:26:08 | <dkayiwa> mnunez: it is supposed to load the ones you entered |
| 12:29:11 | <mnunez> dkayiwa: I'll test it again, but it's displaying only the last entered observation and an empty one. |
| 12:29:20 | <dkayiwa> ok |
| 12:30:03 | <mnunez> dkayiwa: I'm not home right now, but I'll make a test on the demo server. |
| 12:30:12 | <dkayiwa> ok |
| 12:31:13 | <mnunez> dkayiwa: also, as promised, I added the use cases to the wiki. Hope I got it right :) |
| 12:31:28 | <dkayiwa> oh that is so sweet of you!!! :) |
| 12:41:01 | *** bwolfe has quit IRC |
| 12:43:58 | *** bwolfe has joined #openmrs |
| 12:43:58 | *** ChanServ sets mode: +o bwolfe |
| 12:48:19 | *** bwolfe has quit IRC |
| 12:50:42 | *** bwolfe has joined #openmrs |
| 12:50:42 | *** ChanServ sets mode: +o bwolfe |
| 12:50:57 | *** kishoreyekkanti has joined #openmrs |
| 12:52:30 | <dkayiwa> bwolfe: do you have any clue as to why my service is not found when i run a unit test? org.openmrs.api.APIException: Service not found: interface org.openmrs.module.testing.TestingService |
| 12:52:45 | <bwolfe> dkayiwa, are you extending BaseModuleContextSensitiveTest ? |
| 12:52:55 | <dkayiwa> bwolfe: yes |
| 13:16:01 | *** mnunez_ has joined #openmrs |
| 13:17:43 | <mnunez_> dkayiwa: Daniel, I'm having a Javascript error while adding a ConvSet to a form. Could you try this? Try adding de convset CONVSET TEST to this form schema http://demo.openmrs.org/openmrs/admin/forms/formEdit.form?formId=18 |
| 13:17:43 | <OpenMRSBot> <http://ln-s.net/9G4L> (at demo.openmrs.org) |
| 13:18:08 | <dkayiwa> mnunez_: oh yes thats an openmrs bug |
| 13:18:26 | <dkayiwa> mnunez_: you may need to create a brand new one as a workaround |
| 13:18:29 | <mnunez_> dkayiwa: It seems that the convset can only be added one: the first time the convset is created. |
| 13:18:34 | <dkayiwa> as in new conv set |
| 13:18:52 | <dkayiwa> mnunez_: yes i got the same bug while doing 1.9 release testing |
| 13:20:39 | <dkayiwa> mnunez_: do the convset members have descriptions? |
| 13:20:58 | <mnunez_> dkayiwa: Nop. Are they needed? |
| 13:21:11 | <dkayiwa> i think thats what causes the bug |
| 13:21:35 | <mnunez_> dkayiwa: Excelent. Giving it a shot. |
| 13:22:12 | <dkayiwa> mnunez_: https://tickets.openmrs.org/browse/TRUNK-2810 |
| 13:23:36 | <mnunez_> dkayiwa: by the way, when I load an encounter using XForms, the repeat sections load all the observations, but display only the last. |
| 13:24:24 | <mnunez_> dkayiwa: Say I add three findings. It displays three rows of the repeat section, but the last two are empty. |
| 13:24:46 | <dkayiwa> mnunez_: are you doing that on the demo server? |
| 13:26:02 | <mnunez_> dkayiwa: Nop, since I can not add the ConvSet ;( |
| 13:26:20 | <dkayiwa> create a new one and add it |
| 13:28:58 | <mnunez_> dkayiwa: Ok |
| 13:33:36 | *** wyclif has quit IRC |
| 13:37:18 | <mnunez_> dkayiwa: http://demo.openmrs.org/openmrs/admin/forms/formEdit.form?formId=18 |
| 13:37:18 | <OpenMRSBot> <http://ln-s.net/9G4L> (at demo.openmrs.org) |
| 13:38:30 | <mnunez_> dkayiwa: XForm Designer does not load the set as a repeat box. Maybe is related to the XForm version. |
| 13:39:51 | <dkayiwa> mnunez_: you had not put the conv set in the obs section |
| 13:39:54 | <dkayiwa> just corrected it |
| 13:41:56 | <mnunez_> dkayiwa: pfffff... adding that to the wiki. Demo page is already set to modify encounters with XForms. See what happens when editing an encounter with many observations? |
| 13:42:35 | <dkayiwa> mnunez_: give an example encounter. url? |
| 13:47:07 | <mnunez_> dkayiwa: demo page's XForm has the old bug you corrected (empty "Unexpected Failure" error wile pressing "add new" on a repeat box). Do you have update privileges? |
| 13:47:52 | <dkayiwa> mnunez_: i do not have the privileges, but just ignore the error by clicking ok and continue. it will still save |
| 13:49:06 | *** nribeka has joined #openmrs |
| 13:49:06 | *** ChanServ sets mode: +v nribeka |
| 13:51:22 | <mnunez_> dkayiwa: Damn. It's working on the demo page |
| 13:51:29 | <dkayiwa> :) |
| 13:51:51 | <mnunez_> dkayiwa: http://demo.openmrs.org/openmrs/admin/encounters/encounter.form?encounterId=48845 |
| 13:51:56 | *** downeym has joined #openmrs |
| 13:51:56 | *** OpenMRSBot sets mode: +o downeym |
| 13:51:56 | *** ChanServ sets mode: +o downeym |
| 13:52:57 | <mnunez_> dkayiwa: see that? I only see the first one in my implementation. The other two are shown, but empty |
| 13:53:42 | <dkayiwa> mnunez_: can you reproduce it in your implementation? |
| 14:01:36 | <mnunez_> dkayiwa: The problem "is" in my implementation. When I tried to reproduce it in the demo, it worked just fine. |
| 14:02:32 | <dkayiwa> mnunez_: can you reproduce the problem in your implementation by try create a new throw away form from there? |
| 14:02:51 | <mnunez_> dkayiwa: Doing that |
| 14:05:15 | *** r1friedman has joined #openmrs |
| 14:05:29 | *** r1friedman is now known as rfriedman |
| 14:06:14 | <rfriedman> bwolfe: hi ben, got a minute for a quick eclipse question? |
| 14:07:36 | <rfriedman> dkayiwa: daniel, got a minute for a quick eclipse question? |
| 14:07:54 | <dkayiwa> rfriedman: i can try |
| 14:08:23 | <rfriedman> dkayiwa: thanks. Last night, my eclipse was showing colors for different types of references and warning/errors in the right column |
| 14:08:34 | <rfriedman> this morning it's not. What do I need to turn on and how? |
| 14:09:03 | <dkayiwa> rfriedman: can i see a screenshot of how the colors look like? |
| 14:09:18 | <rfriedman> dkayiwa: no colors at all now |
| 14:09:29 | <rfriedman> last night, the local variables were in blue |
| 14:11:01 | *** james_regen has quit IRC |
| 14:11:01 | *** dkayiwa has quit IRC |
| 14:11:05 | *** raff has joined #openmrs |
| 14:11:31 | *** raff is now known as Guest29059 |
| 14:11:37 | *** james_regen has joined #openmrs |
| 14:11:37 | *** ChanServ sets mode: +v james_regen |
| 14:11:40 | *** Guest29059 is now known as rafa__ |
| 14:13:12 | *** r1friedman has joined #openmrs |
| 14:13:35 | *** r1friedman is now known as rfriedman_ |
| 14:13:42 | *** bwolfe has quit IRC |
| 14:13:58 | *** bwolfe has joined #openmrs |
| 14:13:58 | *** ChanServ sets mode: +o bwolfe |
| 14:14:01 | *** robbyoconnor has quit IRC |
| 14:14:14 | *** rfriedman has quit IRC |
| 14:14:26 | *** rfriedman_ is now known as rfriedman |
| 14:14:39 | *** nribeka has quit IRC |
| 14:14:40 | <rfriedman> bwolfe: hi ben, got a minute for an eclipse question? |
| 14:14:57 | <rfriedman> daniel was trying to help but we both got lost |
| 14:15:39 | * rfriedman is checking connectivity |
| 14:17:27 | *** dkayiwa has joined #openmrs |
| 14:17:44 | *** nribeka has joined #openmrs |
| 14:17:44 | *** ChanServ sets mode: +v nribeka |
| 14:18:57 | <rfriedman> dkayiwa: hi daniel |
| 14:19:00 | *** dawn_ has joined #openmrs |
| 14:19:00 | *** ChanServ sets mode: +v dawn_ |
| 14:19:06 | <dkayiwa> hi rfriedman |
| 14:19:14 | <rfriedman> what's the last thing you heard? |
| 14:19:24 | <rfriedman> there is no color this morning except comments are blue |
| 14:19:35 | <dkayiwa> rfriedman: last night, the local variables were in blue |
| 14:19:51 | *** robbyoconnor has joined #openmrs |
| 14:19:51 | *** ChanServ sets mode: +v robbyoconnor |
| 14:20:13 | <rfriedman> right, and errors were underlined in red and there were gold, red and blu rectangles on the right slider showing warnings, errors and todos |
| 14:20:25 | <dkayiwa> ok |
| 14:20:37 | <rfriedman> i'd like to get them back |
| 14:21:20 | <dkayiwa> rfriedman: have you tried closing and reopening eclipse? |
| 14:22:20 | <rfriedman> no joy |
| 14:29:11 | *** wyclif has joined #openmrs |
| 14:29:55 | *** chopin has joined #openmrs |
| 14:29:55 | *** ChanServ sets mode: +v chopin |
| 14:34:58 | <rfriedman> dkayiwa: added a new class and now the colors are back |
| 14:35:13 | <dkayiwa> rfriedman: interesting!!! |
| 14:35:20 | *** jriley has joined #openmrs |
| 14:36:18 | *** mnunez_ has quit IRC |
| 14:39:30 | *** dawn_ has quit IRC |
| 14:42:24 | <wyclif> hi bwolfe |
| 14:42:56 | *** dawn_ has joined #openmrs |
| 14:42:56 | *** ChanServ sets mode: +v dawn_ |
| 14:43:06 | <wyclif> bwolfe, thanks for creating the jira dashboard and updating the wiki pages, i was green about creating the dashboard |
| 14:46:43 | <kishoreyekkanti> bwolfe: Hey Ben you there |
| 14:51:15 | <chopin> kishoreyekkanti: bwolfe might be packing bags ... traveling tomorrow |
| 14:55:11 | <dkayiwa> hi wyclif |
| 14:55:34 | <dkayiwa> wyclif: does TestingServiceImpl.generateTestDataSet() get all data in the database? |
| 14:56:05 | <wyclif> dkayiwa, nope |
| 14:56:22 | <wyclif> dkayiwa, we need to come up with an algorithm |
| 14:56:52 | <dkayiwa> wyclif: so that means in wait on that method untill when we come up with the algorithm? |
| 14:57:05 | <wyclif> dkayiwa, it should get all metadata, and then about 2000 patient including all their encounters and obs |
| 14:57:15 | <dkayiwa> ok |
| 14:57:16 | <wyclif> dkayiwa, correct |
| 14:57:19 | <kishoreyekkanti> chopin: Ohh ok :) |
| 14:57:23 | <dkayiwa> ok |
| 14:57:44 | <wyclif> dkayiwa, for the sake of getting forward, for now do the first 2000 |
| 14:57:51 | <dkayiwa> ok |
| 14:57:59 | <wyclif> dkayiwa, all all metadata |
| 14:58:07 | <dkayiwa> wyclif: do we have a sample dataset format? |
| 14:58:15 | <wyclif> dkayiwa, we can talk about this during the scrum |
| 14:58:19 | <dkayiwa> ok |
| 14:58:42 | <wyclif> dkayiwa, we also need to deside if we are using a sql dump or xml |
| 14:58:48 | <dkayiwa> ok |
| 14:59:53 | <dkayiwa> wyclif: have you ever got this error when trying to run a module unit test? org.openmrs.api.APIException: Service not found: interface org.openmrs.module.testing.TestingService |
| 15:01:59 | <wyclif> dkayiwa, hmm |
| 15:02:09 | <wyclif> can you try mvn clean install |
| 15:02:24 | <dkayiwa> wyclif: i tried and it still failed |
| 15:02:41 | <wyclif> did you register the service in the module application context |
| 15:03:45 | <dkayiwa> wyclif: do you mean in the moduleApplicationContext.xml ? |
| 15:03:51 | <dkayiwa> wyclif: if so, YES |
| 15:03:55 | <wyclif> dkayiwa, i guess you have way more expertise than i when it comes to modules |
| 15:04:04 | <dkayiwa> lollllllllllll |
| 15:05:40 | *** djazayeri has joined #openmrs |
| 15:05:40 | *** ChanServ sets mode: +o djazayeri |
| 15:06:02 | <djazayeri> hi bwolfe, dawn_, dkayiwa, rafa__, wyclif |
| 15:06:13 | <dkayiwa> hi |
| 15:06:21 | <dawn_> hi |
| 15:06:34 | *** mnunez has quit IRC |
| 15:06:52 | <rafa__> hi |
| 15:06:53 | *** mnunez has joined #openmrs |
| 15:07:01 | <wyclif> hi djazayeri |
| 15:07:14 | <downeym> hi * |
| 15:07:21 | <djazayeri> wyclif: thanks for putting together tickets for this sprint |
| 15:07:40 | <djazayeri> I meant to review them all yesterday and comment, but I couldn't, so my apologies for that. |
| 15:08:10 | *** robbyoconnor has quit IRC |
| 15:08:23 | <djazayeri> To start off, let's get an update on the status of 1.9 alpha |
| 15:08:42 | <djazayeri> dkayiwa: you sent out some links that I was going to test, but haven't yet. I'll do that now if it's still relevant. |
| 15:08:56 | <djazayeri> Is there anything else standing in the way? |
| 15:09:05 | <wyclif> djazayeri, no problem |
| 15:09:19 | <dkayiwa> no |
| 15:09:37 | <kishoreyekkanti> Can I access any bundled module services from the API? Ex: If i have an external application which uses OpenMRS API alone and I want to use the IdGen module services through API |
| 15:09:52 | <wyclif> djazayeri, bwolfe did review and cleanup some tickets |
| 15:10:05 | <djazayeri> dkayiwa: okay, do you have the URLs offhand, or should I look for your email? |
| 15:10:23 | <dkayiwa> djazayeri: look at the email |
| 15:10:41 | <djazayeri> dkayiwa: are they on the sourceforge site, or elsewhere? |
| 15:11:02 | <dkayiwa> djazayeri: sourceforge |
| 15:12:01 | <djazayeri> Okay, I'll try those out. |
| 15:12:46 | <djazayeri> bwolfe, dkayiwa, wyclif, rafa__: to be clear, getting 1.9 alpha out the door is still priority #1. |
| 15:13:09 | <djazayeri> And a question: why were we not able to get this out last week? |
| 15:13:10 | <dkayiwa> ok |
| 15:13:18 | <djazayeri> Is it because packaging the standalone is too much of a manual process? |
| 15:13:36 | <djazayeri> and only Daniel knows how to do it 100%? |
| 15:13:36 | <dkayiwa> djazayeri: yes |
| 15:14:19 | <djazayeri> okay, so one ticket during this sprint is going to be to fix that. |
| 15:14:26 | <dkayiwa> ok |
| 15:14:36 | <dkayiwa> that will be great |
| 15:14:45 | <wyclif> dkayiwa, i thought you fixed the problem |
| 15:15:07 | <djazayeri> I mean to fix the issue that it's a manual process. |
| 15:15:17 | <dkayiwa> correct |
| 15:15:23 | <wyclif> got you |
| 15:16:23 | <djazayeri> Okay, "with-no-demo-data" worked for me. |
| 15:16:30 | <djazayeri> going to try "with" next |
| 15:16:31 | <wyclif> cool |
| 15:16:48 | <wyclif> hi rafa, can you test on windows? |
| 15:16:58 | <dkayiwa> perfect wyclif |
| 15:16:59 | <wyclif> let me try on my xp in the VM |
| 15:17:57 | <rafa__> wyclif: I'm downloading it right now |
| 15:18:16 | <wyclif> cool |
| 15:18:33 | <dkayiwa> some one to also test on linux? |
| 15:19:04 | <bwolfe> kishoreyekkanti, no, bundled modules act like any other module. your module must declare that as a dependency...or you have to do some classloading trickery to get the methods, etc for it |
| 15:19:59 | <djazayeri> bwolfe: does that mean I can't do Context.getService(CohortDefinitionService.class)? |
| 15:20:05 | <djazayeri> from API code? |
| 15:20:14 | <bwolfe> djazayeri, correct |
| 15:20:39 | <bwolfe> you could do c = Context.loadClass("org.openmrs.module....CohortDefService"); Context.getService(c) |
| 15:20:39 | <djazayeri> even if I've built against a compile-time dependency of the reporting module's jar? |
| 15:20:40 | *** mnunez has quit IRC |
| 15:20:47 | <bwolfe> but then calling of methods would also be reflection |
| 15:20:53 | *** nribeka has quit IRC |
| 15:21:03 | <bwolfe> we don't put the modules' api on the classpath |
| 15:21:56 | <djazayeri> okay |
| 15:21:58 | <bwolfe> so did I miss the actual scrum? or was your comment about 1.9 alpha the start of it darius? |
| 15:22:08 | <djazayeri> bwolfe: that was a pre-scrum discussion |
| 15:22:34 | <djazayeri> alternately, it's the beginning of the scrum |
| 15:22:43 | <bwolfe> ok, cause I need this to be a 5 min discussion...because since I'm in one of the countries that DOESN'T do DST, its dinnertime now |
| 15:22:45 | <bwolfe> :-) |
| 15:22:46 | <kishoreyekkanti> bwolfe: So, I can safely assume that, from outside the webapp I can never access the module services(htmlformentry, idgen etc,) through plain vanila API(though the modules are bundled and API is generated afterwards) |
| 15:23:13 | <bwolfe> define "outside the webapp" |
| 15:23:22 | <bwolfe> rafa__, you go first, you're always ready it seems. :-) |
| 15:23:29 | *** rmorales has joined #openmrs |
| 15:23:32 | <rafa__> Friday: * Worked on https://tickets.openmrs.org/browse/TRUNK-2588 Today: * Correct TRUNK-2711: Change active visits in header https://tickets.openmrs.org/browse/TRUNK-2711 * Continue with TRUNK-2588 Blocker: * No working solution for TRUNK-2588 in mind |
| 15:23:39 | <downeym> Hi rmorales and welcome to the #openmrs IRC channel. |
| 15:23:54 | <bwolfe> !ticket TRUNK-2588 |
| 15:23:55 | <OpenMRSBot> bwolfe: [#TRUNK-2588] Generic mechanism for doing Attributes and Attribute Types on many classes. (Review code, and Refactor.) - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2588 |
| 15:24:11 | <kishoreyekkanti> bwolfe: "outside the webapp" Just using the API jar file but nothing else in my own project |
| 15:24:21 | <rmorales> hello everyone |
| 15:24:27 | <djazayeri> rafa__: Perhaps when bwolfe gets back from dinner we can have a group brainstorm about trunk-2588 |
| 15:24:44 | <bwolfe> kishoreyekkanti, ah. then you are right, you cannot access modules except for how I hacked out to djazayeri |
| 15:25:03 | <rafa__> djazayeri: it would help |
| 15:25:06 | <rmorales> can help with a question? |
| 15:25:12 | <kishoreyekkanti> bwolfe: awesome thank you! |
| 15:25:22 | <bwolfe> rmorales, go ahead |
| 15:25:32 | <bwolfe> sure, we can brainstorm later, I'll be on at some point |
| 15:25:43 | <rmorales> which is the concept of "tribe" |
| 15:25:44 | <bwolfe> rafa__, ready to focus on testing today for a while? |
| 15:26:00 | <djazayeri> okay, in the meantime, let's focus on "release/testing process" |
| 15:26:00 | <bwolfe> the next sprint is on the 1.9 beta, so I'm sure that'll fit in there |
| 15:26:12 | <bwolfe> dkayiwa, are you ready to list your day? and wyclif, you're on deck |
| 15:26:12 | <rafa__> bwolfe: sure |
| 15:26:21 | <djazayeri> The dashboard is: https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=10953 |
| 15:26:30 | <wyclif> ok |
| 15:26:30 | <bwolfe> rmorales, tribe has its own table I think |
| 15:26:42 | <bwolfe> rmorales, and I think the table is called "tribe". :_) |
| 15:26:44 | <bwolfe> :-) |
| 15:26:55 | <djazayeri> dkayiwa: you've created the project already? |
| 15:27:05 | <djazayeri> i.e. the test module? |
| 15:27:12 | <djazayeri> and committed to svn? |
| 15:27:50 | <dkayiwa> Committed Create a project for the test module - TRUNK-2824 |
| 15:27:50 | <dkayiwa> Now working on: Add DAO layer to Testing module - TRUNK-2829 |
| 15:27:50 | <dkayiwa> and Add Service layer to Testing module - TRUNK-2828 |
| 15:27:51 | <dkayiwa> Blocker: Cant run unit tests on testing module because of error: org.openmrs.api.APIException: Service not found: interface org.openmrs.module.testing.TestingService |
| 15:28:06 | <rmorales> ¡"tribe" is only one ethnic characteristic? |
| 15:28:12 | <dkayiwa> djazayeri: yes |
| 15:28:24 | <rmorales> aahh ok |
| 15:28:37 | <rmorales> thanks! :) |
| 15:28:38 | <djazayeri> rmorales: "tribe" was originally included in the data model because OpenMRS's first install was in Kenya |
| 15:28:48 | <bwolfe> dkayiwa, do the tests extend BaseModuleContextSensitiveTest ? |
| 15:28:49 | <djazayeri> we later moved it to a module. |
| 15:28:55 | <dkayiwa> bwolfe: yes |
| 15:29:05 | <bwolfe> dkayiwa, all of them? |
| 15:29:07 | <djazayeri> rmorales: so, you can use "tribe" for that purpose if you want. |
| 15:29:14 | <dkayiwa> bwolfe: i just have one so far |
| 15:29:19 | <rmorales> ahh thanks djazayeri |
| 15:29:24 | <bwolfe> and do you have the right things in the poms? compare against something like formentry, its tests work. (or htmlformentry now) |
| 15:29:29 | <dkayiwa> bwolfe: and its the one failing on Context.getService |
| 15:29:34 | *** kishoreyekkanti has quit IRC |
| 15:29:47 | <bwolfe> rmorales, tribe is a module you can install. other characteristics should be in Person Attributes (and Person Attribute Types) |
| 15:29:55 | <bwolfe> wyclif, are you ready? |
| 15:30:03 | <dkayiwa> bwolfe: am wondering what the right things are :) |
| 15:30:08 | <bwolfe> dkayiwa, hmm, I can't remember what the other common failure is. |
| 15:30:10 | <wyclif> Friday: |
| 15:30:10 | <wyclif> -Worked on packaging and uploading the standalones though it didnt' workout |
| 15:30:10 | <wyclif> -Create tickets for the release testing sprint |
| 15:30:10 | <wyclif> -Fixed old comment for TRUNK-2686 - Provider Identifiers should be unique |
| 15:30:10 | <wyclif> Today: |
| 15:30:11 | <wyclif> - Sprint tickets |
| 15:30:13 | <wyclif> no blockers |
| 15:30:27 | <bwolfe> dkayiwa, djazayeri can take a look at it for you since he's sprint leader this week ;-) |
| 15:30:55 | <rmorales> thanks, was identifying the features and was confused with that |
| 15:30:57 | <dkayiwa> bwolfe: so should i first commit my test for him to look at? |
| 15:30:57 | <djazayeri> indeed |
| 15:31:11 | <bwolfe> dkayiwa, probably |
| 15:31:16 | <dkayiwa> ok |
| 15:31:25 | <bwolfe> and djazayeri, we need to set up this module in CI as soon as the tests are working |
| 15:31:28 | <djazayeri> dkayiwa: is the test in the omod project, or the api one? |
| 15:31:38 | <dkayiwa> djazayeri: in the api |
| 15:31:53 | <bwolfe> oh, thats the problem! |
| 15:31:56 | <bwolfe> omod only right now |
| 15:32:00 | <dkayiwa> lollllll |
| 15:32:05 | <dkayiwa> strange!!! |
| 15:32:06 | <djazayeri> I believe that we've got something broken in our standard setup, so the unit tests have to be in the omod project, even though they shouldn't have to be. |
| 15:32:15 | <dkayiwa> ok |
| 15:32:37 | <bwolfe> djazayeri, you have a report? |
| 15:34:10 | <djazayeri> Friday: |
| 15:34:10 | <djazayeri> * more meetings |
| 15:34:10 | <djazayeri> * apply code review comments from TRUNK-2588 |
| 15:34:10 | <djazayeri> Today: |
| 15:34:10 | <djazayeri> * organize sprint |
| 15:34:10 | <djazayeri> * work on sprint |
| 15:34:27 | <djazayeri> As of today I'm back in Seattle, and will be on a more regular schedule. |
| 15:35:00 | <bwolfe> nice, I'm going to be on a super irregular schedule starting tomorrow |
| 15:35:15 | <djazayeri> good timing then. |
| 15:35:44 | <bwolfe> I'll be traveling for a week, then I'll be regular again |
| 15:36:13 | <djazayeri> bwolfe: did you give a report? |
| 15:36:17 | <bwolfe> my report: sprint ticket setups, maintenance release branch setup, sync module finalization (just waiting on maintenance branches release first), code reviews, a few more tickets for sprint |
| 15:36:57 | <djazayeri> okay |
| 15:36:58 | <wyclif> dkayiwa, i think djazayeri 'scomment above is the solution to the error you are getting for the unit tests |
| 15:37:22 | <bwolfe> ok, dinner time. I'll be back on later |
| 15:37:28 | <djazayeri> ttyl |
| 15:37:33 | <wyclif> bye |
| 15:37:54 | <djazayeri> wyclif, dkayiwa, rafa__: so, on to the sprint |
| 15:38:21 | <djazayeri> what is everyone working on right now? |
| 15:39:04 | <djazayeri> and who needs a pointer to a ticket? |
| 15:39:45 | <wyclif> i pla to work on tickets in the init wizard |
| 15:39:52 | <wyclif> i plan to work on tickets in the init wizard |
| 15:40:05 | <djazayeri> wyclif: you created them all, so do you know offhand which are the first ones to pick up? |
| 15:40:16 | *** rmorales has quit IRC |
| 15:41:14 | <wyclif> djazayeri, the module tickets should technically come fast |
| 15:41:20 | <wyclif> djazayeri, the module tickets should technically come first |
| 15:41:45 | <djazayeri> okay |
| 15:41:46 | <wyclif> because the init wizard will depend on it |
| 15:42:30 | <djazayeri> wyclif: will the init wizard still happen without user intervention? |
| 15:42:46 | <wyclif> i think i need to add a LoginController or servlet for the test module |
| 15:42:46 | <djazayeri> Currently, when I start up the standalone for the first time, I don't see the wizard, just the login page. |
| 15:43:07 | *** mnunez has joined #openmrs |
| 15:43:14 | <wyclif> djazayeri, correct, that is something we need to change when packaging the standalone |
| 15:43:44 | <wyclif> djazayeri, or we need to have a third distribution of the standalone with no database and runtime properties file |
| 15:44:32 | <djazayeri> wyclif: ultimately I think we're going to unify all our standalone distros, into a single larger download, where you choose what setup you want. |
| 15:44:39 | <wyclif> djazayeri, actually no database but with a propertied file |
| 15:45:26 | <wyclif> djazayeri, ok |
| 15:45:56 | <djazayeri> See the mockups on STAND-17. |
| 15:46:33 | <djazayeri> dkayiwa, wyclif: how does the standalone work now? Does it pre-create a runtime properties file, so that the init wizard is skipped? or what? |
| 15:46:56 | <djazayeri> Also, dkayiwa: the version with demo data fails for me. |
| 15:47:19 | <downeym> mac version on SF.net w/demo data installed and ran ok for me this morning. |
| 15:47:35 | <djazayeri> Okay, didn't work for me, let me re-download and be sure |
| 15:47:36 | *** dawn_ has quit IRC |
| 15:48:28 | <wyclif> djazayeri, if you delete the database directory, you go through the init wizard, the runtime properties file has to be present at all times |
| 15:48:31 | *** dawn_ has joined #openmrs |
| 15:48:31 | *** ChanServ sets mode: +v dawn_ |
| 15:49:03 | <djazayeri> okay, wyclif, so is there some parameter passed telling the init wizard not to start? or what? |
| 15:49:31 | <wyclif> djazayeri, the presence/absence of the database directory is what determines that |
| 15:49:41 | <djazayeri> okay |
| 15:49:57 | <wyclif> dkayiwa, correct me if i'm wrong |
| 15:51:22 | <djazayeri> dkayiwa: will you commit a restructured version of the module to svn soon? i.e. with things moved around so the unit tests work? |
| 15:51:27 | <djazayeri> (or maybe just move the unit tests) |
| 15:52:05 | <wyclif> dkayiwa, am setting some vsn :ignores on the target diectories |
| 15:52:29 | <wyclif> FYI, with demo data works for me on XP in the VM |
| 15:52:45 | *** kishoreyekkanti has joined #openmrs |
| 15:53:01 | *** dkayiwa has quit IRC |
| 15:54:06 | *** dkayiwa has joined #openmrs |
| 15:54:15 | <dkayiwa> djazayeri: sorry i got disconnected |
| 15:54:44 | <dkayiwa> djazayeri: what error message does it give on failing? |
| 15:54:56 | <djazayeri> dkayiwa: I just re-downloaded and will run at a command prompt to see |
| 15:55:11 | <dkayiwa> djazayeri: did you also properly stop the previously run one (the one with no demo data) |
| 15:55:24 | <djazayeri> dkayiwa: define "properly stop" |
| 15:55:36 | <dkayiwa> :) |
| 15:55:43 | <djazayeri> at first I started with that one still running, and things failed |
| 15:55:48 | <dkayiwa> djazayeri: just close the window and wait for it to go away |
| 15:55:51 | <djazayeri> then I stopped, deleted, re-unzipped, and tried again, and it failed too. |
| 15:56:10 | <dkayiwa> djazayeri: do you have any mysqld process running? |
| 15:56:33 | <djazayeri> dkayiwa: indeed |
| 15:56:39 | <djazayeri> 111107 7:56:14 [ERROR] Can't start server : Bind on unix socket: Address already in use |
| 15:56:39 | <djazayeri> 111107 7:56:14 [ERROR] Do you already have another mysqld server running on socket: /tmp/mysql.sock ? |
| 15:56:39 | <djazayeri> 111107 7:56:14 [ERROR] Aborting |
| 15:56:51 | <dkayiwa> djazayeri: can you stop it and try again |
| 15:57:17 | <djazayeri> the mysqld that's running is my standard non-standalone one though |
| 15:57:34 | <dkayiwa> djazayeri: you can leave that one running |
| 15:57:58 | <djazayeri> well, I see two running, and don't know which is which |
| 15:57:59 | <djazayeri> :-) |
| 15:58:12 | <downeym> djazayeri: https://wiki.openmrs.org/display/docs/Troubleshooting+MySQL#TroubleshootingMySQL-ConnectingwithmultipleMySQLinstancesonasinglesystem |
| 15:58:57 | <djazayeri> dkayiwa: I've always had mysql running when using a standalone |
| 15:59:08 | *** dawn_ has quit IRC |
| 15:59:13 | <dkayiwa> djazayeri: can you try remove &server.socket=/tmp/mysql.sock from the connection string in the runtime properties file |
| 15:59:19 | <dkayiwa> and see if there is any difference |
| 15:59:31 | <dkayiwa> it is at the end of the connection string |
| 16:00:13 | <rafa__> djazayeri: can you please once again update a patch for TRUNK-2588 after your changes? |
| 16:01:07 | *** mnunez has quit IRC |
| 16:01:30 | *** chopin has quit IRC |
| 16:01:48 | <djazayeri> dkayiwa: that worked |
| 16:02:01 | <djazayeri> why did this differ in with-demo-data and with-no-demo-data though? |
| 16:02:37 | <dkayiwa> djazayeri: yes i just noticed that was the difference |
| 16:02:48 | <dkayiwa> although it should not fail |
| 16:02:54 | <dkayiwa> because it works on mine very well |
| 16:03:37 | <dkayiwa> djazayeri: infact you need that parameter when you want to dirrectly connect to the standalone mysql instance to do some sql commands say using mysqld |
| 16:04:02 | <wyclif> djazayeri, so we have decided that wer are using a sql dump instead of xml for now |
| 16:04:08 | *** dawn_ has joined #openmrs |
| 16:04:34 | *** mnunez has joined #openmrs |
| 16:04:56 | <dkayiwa> djazayeri: so i suspect your previously running mysqld instance locked it |
| 16:05:30 | <dkayiwa> otherwise after stopping it, you should not have had more than one mysqld process running. djazayeri |
| 16:06:28 | <djazayeri> wyclif: yes |
| 16:07:30 | <downeym> dkayiwa: isn't /tmp/mysql.sock the standard socket |
| 16:07:35 | <wyclif> dkayiwa, standalone with demo data works for me on linux |
| 16:07:53 | <wyclif> amd not testing with no demodata |
| 16:08:00 | <dkayiwa> downeym: am not sure |
| 16:08:03 | <wyclif> am now testing with no demodata |
| 16:08:15 | <djazayeri> downeym: apparently not, because changing that fixed things for me |
| 16:08:16 | <dkayiwa> downeym: but i think we should remove it |
| 16:08:37 | <downeym> dkayiwa: i think that's normally used by any other existing mysql instance, so standalone should use something unique, or otherwise there'd be a conflict |
| 16:08:52 | <dkayiwa> downeym: makes sense |
| 16:09:09 | <downeym> dkayiwa: maybe something more like /tmp/mysql-openmrs-standalone.sock |
| 16:09:36 | <dkayiwa> djazayeri: if you change to what downeym is suggesting, does it work for you? |
| 16:09:46 | <djazayeri> testing |
| 16:09:49 | <dkayiwa> ok |
| 16:11:12 | <djazayeri> dkayiwa, downeym: that worke |
| 16:11:15 | <djazayeri> worked |
| 16:11:32 | <dkayiwa> i think we should go with that |
| 16:11:37 | *** nribeka has joined #openmrs |
| 16:11:37 | *** ChanServ sets mode: +v nribeka |
| 16:11:55 | *** gauravpaliwal has joined #openmrs |
| 16:11:55 | *** ChanServ sets mode: +v gauravpaliwal |
| 16:12:17 | <djazayeri> So, we'd need to change that in both versions, and re-upload? |
| 16:12:26 | <dkayiwa> djazayeri: yes |
| 16:12:37 | <djazayeri> Others can do that too, right? |
| 16:12:50 | <dkayiwa> yes they can just rezip |
| 16:12:54 | <djazayeri> i.e. download, unzip, change that one line in runtime properties, re-zip, and upload? |
| 16:13:00 | <dkayiwa> yes |
| 16:13:08 | <djazayeri> but we need sourceforge upload privs |
| 16:13:15 | <djazayeri> who has those? |
| 16:13:19 | <dkayiwa> downeym: |
| 16:13:26 | <downeym> you both have them. |
| 16:14:15 | <djazayeri> downeym: via OpenID through OpenMRS or something? |
| 16:14:28 | <downeym> djazayeri: through your sourceforge account. |
| 16:14:36 | <djazayeri> hmm, okay, gotta try to find that |
| 16:14:37 | <downeym> that's how dkayiwa was able to upload them. :) |
| 16:15:19 | <dkayiwa> :) |
| 16:15:35 | <downeym> djazayeri: it's djazayeri |
| 16:16:22 | <djazayeri> downeym: got it reset |
| 16:17:18 | <djazayeri> so dkayiwa, I'm going to edit and re-zip and upload |
| 16:17:24 | <dkayiwa> djazayeri: yes |
| 16:17:40 | <djazayeri> downeym: does OSX create funky zip files in its default mode? |
| 16:17:46 | <djazayeri> e.g. with a .MacOSX folder or something? |
| 16:17:51 | <dkayiwa> yes |
| 16:18:06 | <djazayeri> how do I avoid that? |
| 16:19:02 | <wyclif> dkayiwa, without demo data works for me both on linux and XP in VM |
| 16:19:15 | <dkayiwa> ok |
| 16:19:17 | <djazayeri> wyclif: can you try one more thing... |
| 16:19:29 | <wyclif> djazayeri, sure |
| 16:19:35 | <wyclif> djazayeri, what is that? |
| 16:19:45 | <downeym> djazayeri: i've not seen that personally |
| 16:19:57 | <djazayeri> after quitting the standalone, try changing the connect string in the runtime props, so that the socket is: /tmp/mysql-openmrs-standalone.sock |
| 16:20:02 | <djazayeri> and make sure that still works for you. |
| 16:20:28 | <downeym> djazayeri: but then again i normally use zip from command line |
| 16:21:01 | <wyclif> ok |
| 16:21:17 | *** chopin has joined #openmrs |
| 16:21:17 | *** ChanServ sets mode: +v chopin |
| 16:21:47 | *** gauravpaliwal has left #openmrs |
| 16:24:38 | <wyclif> dkayiwa, however authentication of openmrs_user fails and i think the standalone defeaults to openmrs test |
| 16:27:57 | *** kishoreyekkanti has quit IRC |
| 16:29:07 | <djazayeri> dkayiwa: connection.url should be identical for the two packages, right? |
| 16:30:44 | <dkayiwa> yes |
| 16:31:20 | <wyclif> djazayeri, bwolfe rafa__ dkayiwa, i prefer having the tickets for the test module not being in the trunk project |
| 16:31:29 | <dkayiwa> wyclif: is that when you are creating a standalone? |
| 16:31:32 | <dkayiwa> the yes was to djazayeri |
| 16:31:50 | <djazayeri> wyclif: why did you put them in trunk in the first place? Did bwolfe suggest it? |
| 16:31:50 | <wyclif> dkayiwa, this is off topic |
| 16:32:09 | <wyclif> djazayeri, bwolfe suggested that initially |
| 16:32:10 | <dkayiwa> wyclif: i agree |
| 16:32:38 | <wyclif> djazayeri, because we had no test projec at that time |
| 16:32:50 | <wyclif> djazayeri, am going to move them |
| 16:32:54 | <djazayeri> wyclif: wait |
| 16:32:57 | <djazayeri> you'll break the sprint dashboard |
| 16:33:28 | <djazayeri> wyclif: is the problem with having them in trunk that (1) they don't belong, and (2) you can't create reviews right? |
| 16:35:24 | *** dkayiwa_ has joined #openmrs |
| 16:35:31 | *** chopin has quit IRC |
| 16:36:31 | <djazayeri> downeym: any idea what happens on sourceforge if I upload a file with the same name as an existing one? does it overwrite? |
| 16:36:34 | *** dkayiwa has quit IRC |
| 16:36:39 | <wyclif> djazayeri, i haven't yet run into any of those |
| 16:36:42 | <djazayeri> (otherwise I'll find out in 95% of a large file) |
| 16:37:00 | *** dkayiwa_ is now known as dkayiwa |
| 16:37:00 | <downeym> djazayeri: through the web ui, never tried it. |
| 16:37:08 | <wyclif> djazayeri, but i it will mess up things in crucible/fisheye |
| 16:37:12 | <downeym> djazayeri: you should probably trash the current one first to be sure |
| 16:37:13 | <djazayeri> downeym: okay, we'll see |
| 16:37:25 | <djazayeri> downeym: I did that for one, but forgot for the other. :-) |
| 16:37:31 | <downeym> djazayeri: science! |
| 16:37:46 | <djazayeri> natural experiment |
| 16:38:07 | <djazayeri> wyclif: so, go ahead and move them to the appropriate project, that's fine. |
| 16:38:07 | <downeym> wyclif: what will be messed up in fe/cru ? |
| 16:38:08 | <dkayiwa> djazayeri: i thin you can delete |
| 16:38:24 | <djazayeri> but wyclif: make sure you fix the sprint dashboard so that it works |
| 16:39:01 | <djazayeri> (might be a problem because ben is the owner…at least verify how he'll need to change the queries to work across multiple projects) |
| 16:40:00 | *** mnunez has quit IRC |
| 16:40:04 | *** chopin has joined #openmrs |
| 16:40:04 | *** ChanServ sets mode: +v chopin |
| 16:40:46 | <wyclif> downeym, having tickets for a module in trunk |
| 16:41:38 | *** suranga has joined #openmrs |
| 16:41:52 | <suranga> hi james_regen |
| 16:41:55 | <suranga> james_regen, r u there ? |
| 16:42:30 | <djazayeri> wyclif, rafa__, dkayiwa: you all have tickets to start/work on now? |
| 16:42:47 | *** suranga has quit IRC |
| 16:42:57 | *** suranga has joined #openmrs |
| 16:42:58 | <djazayeri> (wyclif, you're re-organizing) |
| 16:43:22 | <suranga> james_regen, sorry, got cut off again... |
| 16:43:28 | *** mnunez has joined #openmrs |
| 16:43:35 | *** rafa__ has quit IRC |
| 16:45:20 | *** suranga_ has joined #openmrs |
| 16:46:57 | *** suranga__ has joined #openmrs |
| 16:47:01 | *** suranga_ has quit IRC |
| 16:47:37 | <wyclif> djazayeri, might need to create a jira project for the module |
| 16:47:51 | <wyclif> djazayeri, i see a testing project, is it different? |
| 16:48:06 | *** suranga has quit IRC |
| 16:48:10 | <djazayeri> wyclif: probably different |
| 16:48:20 | <downeym> wyclif: https://wiki.openmrs.org/display/RES/JIRA+Issue+Tracking+System |
| 16:48:20 | <OpenMRSBot> <http://ln-s.net/925N> (at wiki.openmrs.org) |
| 16:48:39 | <djazayeri> okay, gotta run for a bit |
| 16:48:42 | <djazayeri> files still uploading |
| 16:49:13 | *** dkayiwa has quit IRC |
| 16:49:44 | *** Gagaman has joined #openmrs |
| 16:50:15 | *** mnunez has quit IRC |
| 16:52:24 | *** raff has joined #openmrs |
| 16:52:44 | *** raff is now known as rafa__ |
| 16:54:02 | *** dawn_ has quit IRC |
| 16:54:08 | *** nribeka has quit IRC |
| 16:54:26 | *** chopin has quit IRC |
| 16:54:34 | *** Gagaman has quit IRC |
| 16:55:22 | *** suranga__ has quit IRC |
| 16:55:55 | <rafa__> wyclif: both standalones worked for me on win7 :-) |
| 16:56:26 | *** kishoreyekkanti has joined #openmrs |
| 16:58:31 | *** suranga has joined #openmrs |
| 17:00:35 | <kishoreyekkanti> djazayeri: Hey Darius, is the git migration for htmlformentry is taken care by rowan? |
| 17:00:40 | *** deadpool has joined #openmrs |
| 17:03:55 | *** suranga has quit IRC |
| 17:07:58 | *** suranga has joined #openmrs |
| 17:10:49 | *** chopin has joined #openmrs |
| 17:10:49 | *** ChanServ sets mode: +v chopin |
| 17:12:19 | *** suranga_ has joined #openmrs |
| 17:12:19 | *** suranga has quit IRC |
| 17:14:01 | *** suranga has joined #openmrs |
| 17:16:52 | *** suranga_ has quit IRC |
| 17:16:56 | <wyclif> rafa__, me too on XP |
| 17:17:09 | <wyclif> downeym, what is the Test project |
| 17:17:15 | *** gauravpaliwal has joined #openmrs |
| 17:17:15 | *** ChanServ sets mode: +v gauravpaliwal |
| 17:17:38 | <downeym> wyclif: ? |
| 17:19:02 | *** gauravpaliwal has left #openmrs |
| 17:19:08 | <djazayeri> kishoreyekkanti: yes |
| 17:19:21 | <djazayeri> rowan did the migration |
| 17:19:22 | <wyclif> i see a Test Project, is that different from the Testing project we are working on in the current sprint |
| 17:19:41 | <djazayeri> I don't really like "testing" as a module name |
| 17:19:52 | *** dkayiwa has joined #openmrs |
| 17:20:01 | <kishoreyekkanti> djazayeri: Awesome.. I got little confused by the big mail chain :) |
| 17:20:13 | <djazayeri> wyclif: can you test out one of these, one one OS, just to make sure I didn't break things? |
| 17:20:14 | <djazayeri> https://sourceforge.net/projects/openmrs/files/prereleases/OpenMRS_1.9.0_Alpha/? |
| 17:20:25 | <djazayeri> one non-OSX OS |
| 17:21:35 | <wyclif> djazayeri, ok |
| 17:21:40 | <downeym> wyclif: it's a test jira project |
| 17:22:04 | <wyclif> so it is different downeym |
| 17:22:59 | <djazayeri> the quickest approach is to create a JIRA Project for "testing module" |
| 17:23:08 | <djazayeri> better might be to rename the module, and call it something else. |
| 17:26:03 | *** suranga_ has joined #openmrs |
| 17:27:04 | *** dkayiwa has quit IRC |
| 17:27:58 | <wyclif> djazayeri, still works on linux |
| 17:28:14 | <djazayeri> great, then I think we're set to release |
| 17:28:20 | <djazayeri> oops, dkayiwa isn't there. |
| 17:28:53 | <djazayeri> wyclif: can you throw it in the VM too and test with winxp? |
| 17:28:58 | <djazayeri> just one is fine |
| 17:29:01 | *** suranga has quit IRC |
| 17:29:44 | <wyclif> am doing that |
| 17:30:28 | *** dkayiwa has joined #openmrs |
| 17:32:15 | *** suranga has joined #openmrs |
| 17:33:35 | *** suranga_ has quit IRC |
| 17:36:30 | *** suranga_ has joined #openmrs |
| 17:37:08 | <djazayeri> dkayiwa: almost ready to release? |
| 17:37:24 | <djazayeri> wyclif is just testing my upload on windows. It's already worked on linux and osx. |
| 17:37:34 | <dkayiwa> ok |
| 17:40:48 | *** suranga has quit IRC |
| 17:42:36 | <djazayeri> wyclif: status update on that? |
| 17:46:54 | *** bwolfe has quit IRC |
| 17:48:08 | *** dawn_ has joined #openmrs |
| 17:48:52 | *** bwolfe has joined #openmrs |
| 17:48:52 | *** ChanServ sets mode: +o bwolfe |
| 17:48:58 | *** robbyoconnor has joined #openmrs |
| 17:48:58 | *** ChanServ sets mode: +v robbyoconnor |
| 17:50:45 | <james_regen> suranga_: hi, i'm back from lunch |
| 17:50:53 | <downeym> wyclif: does this module simply create test data or does it do testing? |
| 17:50:56 | <suranga_> james_regen, howdy ! |
| 17:51:13 | <suranga_> james_regen, I just sent ada the latest omod |
| 17:51:22 | *** dkayiwa has quit IRC |
| 17:51:31 | <wyclif> djazayeri, both work fine on XP |
| 17:51:43 | <suranga_> james_regen, I fixed an issue where the patient matching report was not being executed.... |
| 17:51:53 | <djazayeri> wyclif: great! unfortunately whenever you say something works, dkayiwa is offline. :-) |
| 17:52:13 | <downeym> +cc djazayeri on above comment |
| 17:52:17 | <suranga_> james_regen, did u understand what I had done ? is that ok ? |
| 17:52:23 | <james_regen> suranga_: i saw. so the error was caused by there not being any blocking columns? |
| 17:52:46 | <suranga_> james_regen, yep, the class was getting blocking cloumns and useing them to ORDER BY |
| 17:52:53 | <wyclif> djazayeri, he he he |
| 17:53:10 | <suranga_> if there were no blocking columns, the sql ended with XXXXXXX.. 'order by' |
| 17:53:34 | <suranga_> so Now I check if there are any blocking columns, and add the order by only if there is.... |
| 17:53:59 | <james_regen> suranga_: i think we'll need to make sure that doesn't happen. the module forms pairs based on those blocking columns, and if there aren't any, it'll probably run into problems later. it probably wouldn't return meaningful results |
| 17:54:19 | <suranga_> james_regen, ooops |
| 17:54:42 | <suranga_> james_regen, u mean that there cant be an event where there are no blocking columns ? |
| 17:55:16 | <suranga_> as in " there must always be blocking columns" ? |
| 17:55:22 | *** dkayiwa has joined #openmrs |
| 17:55:46 | <james_regen> suranga_: yes, currently there must always be blocking columns |
| 17:56:24 | <james_regen> suranga_: i think the GUI has a check to see if the user created a valid run, but not the module |
| 17:56:42 | <suranga_> james_regen, If im using the web interface, where would I specifically select blocking columns |
| 17:56:48 | <suranga_> james_regen, yep, thats right :) |
| 17:56:49 | <djazayeri> dkayiwa: we're set to release 1.9 alpha |
| 17:57:00 | <djazayeri> I tested my new uploads on osx, wyclif tested on linux and winxp |
| 17:57:30 | <james_regen> suranga_: blocking columns are the "must match" columns. include columns are "should match." we got feedback that using "block" and "include" weren't very helpful, and that "must match" and "should match" were better |
| 17:59:55 | *** dkayiwa has quit IRC |
| 18:00:04 | * suranga_ goes to look.... |
| 18:00:19 | <djazayeri> bwolfe, wyclif: let's think of a better name for the "testing" module. |
| 18:00:26 | <downeym> SITUATe |
| 18:00:40 | <wyclif> what is it now? |
| 18:00:42 | <djazayeri> downeym: I don't think that's a good name. ;-P |
| 18:00:55 | <downeym> System Integration Test / User Acceptance Test Enabler |
| 18:01:05 | <djazayeri> wyclif: I believe it's called "testing" |
| 18:01:17 | *** dawn_ has quit IRC |
| 18:01:33 | <wyclif> and what do you want it to be? |
| 18:02:02 | <djazayeri> The point is that this module allows the standalone and install wizard to pull data from an existing system, to make it easier to test new releases. |
| 18:02:23 | <djazayeri> before fully upgrading |
| 18:02:35 | <downeym> who's doing the testing? |
| 18:02:40 | <suranga_> james_regen, I see what u mean |
| 18:04:00 | *** suranga has joined #openmrs |
| 18:04:01 | *** gauravpaliwal has joined #openmrs |
| 18:04:01 | *** ChanServ sets mode: +v gauravpaliwal |
| 18:04:04 | *** gauravpaliwal has left #openmrs |
| 18:04:18 | *** suranga_ has quit IRC |
| 18:04:29 | <suranga> terribly sorry james_regen I got cut off, did I miss anything u said ? :) |
| 18:05:23 | <james_regen> suranga: nope, didn't miss anything |
| 18:05:30 | <djazayeri> downeym: primary goal is to allow easier testing by actual implementers |
| 18:06:03 | <djazayeri> e.g. let AMPATH test 1.9 alpha with just a few of their patients, but all their config and modules, so they can get it set up quickly. |
| 18:06:04 | <downeym> djazayeri: so that sounds more like user acceptance testing more than anything |
| 18:06:07 | <james_regen> suranga: i can email ada and let her know to add at least one blocking column, and mention that in the future we'll do something to make sure the code checks that condition before running |
| 18:07:38 | <djazayeri> downeym: well, the primary goal is to support that. |
| 18:08:00 | *** suranga has quit IRC |
| 18:08:04 | <djazayeri> Though the module is only part of that process. |
| 18:08:07 | *** suranga has joined #openmrs |
| 18:08:12 | <downeym> djazayeri: right |
| 18:08:24 | <djazayeri> Also, a key point is that this exposes data from your setup (behind a password, but still) that you wouldn't typically want to expose. |
| 18:08:26 | <suranga> james_regen, sorry, got cut off again :( |
| 18:08:40 | <suranga> james_regen, did I miss anything again :( |
| 18:08:43 | <james_regen> suranga: i can email ada and let her know to add at least one blocking column, and mention that in the future we'll do something to make sure the code checks that condition before running |
| 18:08:53 | <djazayeri> downeym: So you don't really want this running most of the time. It'd be nice if our name made that clear. |
| 18:09:07 | <djazayeri> perhaps "exposetestdata" |
| 18:09:08 | *** dawn_ has joined #openmrs |
| 18:09:23 | <suranga> james_regen, sure, no problem, and Ill also look into putting in some sort of check... |
| 18:09:32 | <suranga> to fix that issue... |
| 18:09:44 | <downeym> djazayeri: just wondered if it needed to be more broad than just the test data, to accommodate other stuff in the future |
| 18:09:55 | <james_regen> suranga: ok, that'll be great |
| 18:10:07 | <suranga> james_regen, a quick question, is ConfigurationSimpleFormController the controller for configform.jsp ? |
| 18:10:28 | <djazayeri> downeym: I hope we don't expand this to include *both* exposing your data, *and* doing something else useful. :-) |
| 18:10:51 | <james_regen> suranga: actually, i don't know. i've somehow managed to not have to work with that code |
| 18:10:54 | <djazayeri> alternately "testnextreleasesupport" |
| 18:12:28 | *** raff has joined #openmrs |
| 18:12:47 | <suranga> james_regen, righto, I;ll check it out then... |
| 18:12:54 | *** raff is now known as Guest25337 |
| 18:13:00 | *** rafa__ has quit IRC |
| 18:13:03 | *** Guest25337 is now known as rafa__ |
| 18:13:19 | <suranga> james_regen, I will look into this first thing tomorrow... :) |
| 18:13:50 | <james_regen> suranga: that'll be fine, once ada changes her strategy, she shouldn't have any problems, and this extra check can wait a bit |
| 18:17:13 | <suranga> james_regen, there were two more issues that she wanted me to look at, I'll finish those instead then :) |
| 18:17:24 | <suranga> james_regen, and Ill report back tomorrow :P |
| 18:19:22 | <james_regen> ok |
| 18:24:43 | *** nribeka has joined #openmrs |
| 18:24:43 | *** ChanServ sets mode: +v nribeka |
| 18:30:27 | *** Srinivasa has joined #openmrs |
| 18:32:34 | *** dkayiwa has joined #openmrs |
| 18:34:20 | *** suranga_ has joined #openmrs |
| 18:34:47 | *** nribeka has quit IRC |
| 18:35:12 | <Srinivasa> bwolfe: Hi..May I know where you have posted your review..so that we can work based on it.. |
| 18:35:18 | *** bwolfe has quit IRC |
| 18:36:05 | *** suranga has quit IRC |
| 18:37:47 | *** kishoreyekkanti has quit IRC |
| 18:38:00 | <Srinivasa> exit |
| 18:38:16 | *** Srinivasa has quit IRC |
| 18:44:14 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: We're currently working on an availability problem for openmrs.org. It will be back up soon! <http://twitter.com/OpenMRS/statuses/133596291778347008> |
| 18:44:52 | *** dkayiwa has quit IRC |
| 18:47:22 | *** nribeka has joined #openmrs |
| 18:47:22 | *** ChanServ sets mode: +v nribeka |
| 18:57:42 | *** dawn_ has quit IRC |
| 18:59:26 | <rafa__> djazayeri: are you around? |
| 18:59:30 | <djazayeri> yes |
| 18:59:57 | <rafa__> can you please update the patch for trunk-2588? |
| 19:00:15 | <djazayeri> rafa__: does it not apply after my recent commits? |
| 19:00:15 | <rafa__> I've got a solution, but can't easily update after your changes |
| 19:00:30 | <djazayeri> Okay, I'll get to that in a second. |
| 19:00:38 | <rafa__> thanks |
| 19:00:49 | <djazayeri> Generally, though, it's time to switch over to the release/testing process sprint |
| 19:01:22 | <djazayeri> and we can take some time (or lots of time) on Wednesday's design call to discuss the transactional issue. |
| 19:01:57 | <rafa__> okay |
| 19:02:20 | <rafa__> then nevermind ;-) |
| 19:03:10 | <djazayeri> but if you've already solved it, even better. |
| 19:03:36 | <djazayeri> alternately, you could svn update back to an earlier revision, make the one small change, see if it works, and file that knowledge away for next sprint. |
| 19:05:33 | <rafa__> it's a lot of small changes, so I'll leave it for now. |
| 19:05:37 | *** dkayiwa has joined #openmrs |
| 19:05:39 | <djazayeri> okay |
| 19:08:48 | *** bwolfe has joined #openmrs |
| 19:08:48 | *** ChanServ sets mode: +o bwolfe |
| 19:20:00 | *** dawn_ has joined #openmrs |
| 19:21:40 | <chopin> wyclif: to customize patient lookup results to include the patient's location, is there something simple (like a GP to change) or should i use a module to override findPatient.htm and modify the search constructor? |
| 19:22:07 | <wyclif> chopin, hmm |
| 19:22:09 | <djazayeri> chopin: out of curiosity what is "the patient's location"? |
| 19:22:10 | *** ChanServ sets mode: +v dawn_ |
| 19:22:16 | <djazayeri> Is that a GP? an ever-had-encounter-at? |
| 19:22:46 | <chopin> djazayeri: good question ... i assume we are talking about clinic |
| 19:22:48 | <wyclif> chopin, patient look up by location is not supported |
| 19:22:56 | <chopin> djazayeri: but might reference preferred address |
| 19:23:05 | *** lh_ has joined #openmrs |
| 19:23:09 | <djazayeri> sorry, by GP I meant person_attribute. :-) |
| 19:23:11 | <chopin> wyclif: i just want it displayed in the list, to help decide on the right patient |
| 19:23:13 | <wyclif> chopin, you would have to change the search ogic |
| 19:23:28 | <chopin> wyclif: i don't want to search it |
| 19:23:42 | <chopin> wyclif: just want to show it in the results as a column |
| 19:23:45 | <wyclif> chopin, so you just want to display it in the search widgets? |
| 19:23:53 | <wyclif> chopin, that is simple |
| 19:23:56 | <chopin> wyclif: yes, and specifically just the one on that page |
| 19:24:06 | <chopin> wyclif: right ... that's what i was hoping for hahahahaha |
| 19:24:09 | <wyclif> chopin, but you have to do it programmatically |
| 19:24:20 | <chopin> wyclif: right, in the constructor for the search widget right? |
| 19:24:21 | <wyclif> chopin, that is the ugly bit of it |
| 19:24:25 | <wyclif> yeah |
| 19:24:36 | <wyclif> chopin, wait a minute |
| 19:24:46 | <chopin> k |
| 19:24:55 | <chopin> djazayeri: what's the latest on custom datatypes? ;-) |
| 19:24:59 | <wyclif> where location is what, encounter location or what? |
| 19:25:06 | <wyclif> chopin, where location is what, encounter location or what? |
| 19:25:19 | <chopin> wyclif: most likely it refers to preferred address |
| 19:25:24 | <djazayeri> chopin: rafa__ has almost figured out how to get tests passing again. |
| 19:25:31 | <chopin> wyclif: i'll clarify with the requester via email |
| 19:25:32 | <wyclif> chopin, hmm... |
| 19:25:38 | <djazayeri> probably won't be finishing it off until 2 weeks from now though. |
| 19:25:42 | <rafa__> dkayiwa: are you working on TRUNK-2828? |
| 19:25:59 | <chopin> djazayeri: ah ok, i just think releasing 1.9 without adding back in form resources is a baad idea |
| 19:26:02 | <wyclif> chopin, the way those widgets work, the property you are adding should be in the dwr list item |
| 19:26:16 | <chopin> wyclif: ohhhh hrm |
| 19:26:20 | <djazayeri> chopin: yeah, we'll release the alpha without, but the beta has to include it. |
| 19:26:29 | <wyclif> chopin, so you would also need to make sure there is way you can reference the address on the PatientListItem |
| 19:26:30 | <djazayeri> dkayiwa: you there? |
| 19:27:05 | <chopin> wyclif: personlistitem has address1 and address2 |
| 19:27:16 | <wyclif> chopin, correct |
| 19:27:24 | <chopin> so, i hope it would be one of those |
| 19:27:40 | <chopin> wyclif: ok thanks, i'll take that info back to the requester. |
| 19:28:08 | <wyclif> chopin, so just add those to the constructor of the search widgets |
| 19:28:40 | <chopin> wyclif: ok, thanks :-D |
| 19:29:28 | *** dkayiwa has quit IRC |
| 19:30:37 | <chopin> wyclif: unfortunately the PersonListItem(Person) constructor does not fill those fields in, so it is just a holder ... can I give the constructor for person search a method to use when searching for people? i could possibly use my own dwr service (in a module) to populate those properties ... |
| 19:32:07 | *** dawn_ has quit IRC |
| 19:32:19 | <wyclif> chopin, why not set those in the constructor? |
| 19:32:31 | <chopin> wyclif: i would have to override PersonListItem then |
| 19:33:03 | <chopin> wyclif: trying to do this as a module customization rather than changing core |
| 19:33:32 | <wyclif> chopin, i mean in the constructor, cant you just call setAddress1 on personListItem |
| 19:33:53 | <wyclif> patientlistitem calls super before settings its other fields |
| 19:34:01 | <wyclif> chopin, oh |
| 19:34:30 | <wyclif> chopin, can't u use reflection to set the fields? |
| 19:34:43 | <wyclif> chopin, sorry! that wont work |
| 19:35:26 | <wyclif> chopin, i would say you might have to hack the PatientListItem |
| 19:36:18 | <wyclif> chopin, you might have to loop over the fields |
| 19:36:28 | <chopin> wyclif: yeah, i think i would just end up mimicking the current search methods in my own dwr service with my own list items that extend patientlistitem and have a custom constructor |
| 19:36:33 | <wyclif> chopin, you might have to loop over the patients and set the address |
| 19:36:38 | *** dawn_ has joined #openmrs |
| 19:36:38 | *** ChanServ sets mode: +v dawn_ |
| 19:37:39 | <wyclif> chopin, why not create your own ListItem in the module |
| 19:37:58 | <wyclif> chopin, and set all the fields you want |
| 19:38:03 | <chopin> wyclif: that's what i mean, but i may as well just extend PatientListItem, call its constructor and just add the address data |
| 19:38:10 | <rafa__> can someone please add a short description to https://wiki.openmrs.org/display/RES/2011-11-07+Development+Sprint of what the testing module is supposed to do? |
| 19:38:29 | <chopin> rafa__: hi |
| 19:38:34 | <rafa__> the basic workflow |
| 19:38:42 | <rafa__> hi chopin |
| 19:38:46 | <djazayeri> rafa__: yes, we need to write that up |
| 19:38:49 | <djazayeri> do you know the general idea? |
| 19:38:55 | <chopin> oO i wonder if i should participate in this one |
| 19:38:55 | <wyclif> chopin, where will you get them, it sounds to me like you will need access to the underlying person object |
| 19:39:28 | <rafa__> djazayeri: I'm guessing |
| 19:39:51 | <wyclif> chopin, which you you have no access to from the patient and person list items, unless you want to fetch it from the service layer using the person id which will make your widgets slow |
| 19:39:55 | <djazayeri> rafa__: the idea is that we want to make it easier for implementers to test out the pre-release on their real data |
| 19:39:57 | <chopin> wyclif: exactly ... i plan to mimic the existing DWRPatientService search method, but instead of creating a List<PatientListItem> it'll be one of my own kind .... |
| 19:40:29 | <wyclif> chopin, that sounds fine |
| 19:40:36 | <rafa__> so the module supposed to export data from a server it's running on as an sql dump |
| 19:40:49 | <djazayeri> rafa__: we'll be adding a step to the standalone + install wizard that lets you fetch a subset of data from an existing production system. |
| 19:40:55 | <chopin> djazayeri, rafa__ : is this sprint meant to explore those options and create tickets, then act on those tickets? |
| 19:41:39 | <djazayeri> rafa__: the "testing" module (badly named) will provide a back door (with password, of course) into the production system, to let the standalone + install wizard fetch the relevant data |
| 19:41:54 | <djazayeri> i.e. omods of active modules, all metadata, all data for ~100 patients |
| 19:42:25 | <rafa__> okay, then I was guessing right :-) |
| 19:42:47 | <rafa__> djazayeri: thanks |
| 19:42:53 | <djazayeri> np |
| 19:43:10 | <djazayeri> chopin: this sprint is intended to build the workflow I just described. |
| 19:44:03 | <chopin> djazayeri: ah. REST-ful? |
| 19:44:54 | <djazayeri> chopin: no, hacky |
| 19:45:28 | <chopin> o |
| 19:47:48 | *** lh_ has quit IRC |
| 19:48:19 | *** suranga_ has quit IRC |
| 19:53:01 | <rafa__> djazayeri: is there a way to add tests to api instead of omod? |
| 19:53:39 | <djazayeri> rafa__: I believe that is broken in our standard mavenized module setup |
| 19:54:06 | <djazayeri> I don't know why, I haven't researched. But with the current setup, you have to put all context-sensitive tests in the omod project. |
| 19:55:43 | <rafa__> djazayeri: it feels like resources are in a wrong place |
| 19:55:50 | <rafa__> djazayeri: they should be moved to api instead of omod |
| 19:56:12 | *** dkayiwa has joined #openmrs |
| 19:56:23 | <chopin> the module omod project holds the context resources required for making itself known to the context |
| 19:57:02 | <djazayeri> rafa__: I completely agree that the setup is wrong |
| 19:57:27 | <djazayeri> can you send a short email to the dev list about it? (but then proceed with the current incorrect approach in this sprint for now) |
| 19:57:53 | <rafa__> okay |
| 20:00:19 | *** james_regen has left #openmrs |
| 20:06:18 | *** dkayiwa has quit IRC |
| 20:13:26 | *** dkayiwa has joined #openmrs |
| 20:21:13 | *** jriley has quit IRC |
| 20:40:54 | *** nribeka has quit IRC |
| 20:44:07 | *** robbyoconnor has quit IRC |
| 20:45:04 | *** dkayiwa has quit IRC |
| 21:00:54 | *** bwolfe has quit IRC |
| 21:22:43 | *** downeym_ has joined #openmrs |
| 21:22:43 | *** ChanServ sets mode: +o downeym_ |
| 21:24:25 | *** dawn_ has quit IRC |
| 21:26:20 | *** downeym has quit IRC |
| 21:26:20 | *** downeym_ is now known as downeym |
| 21:26:30 | *** mccallumg has joined #openmrs |
| 21:26:30 | *** ChanServ sets mode: +v mccallumg |
| 21:27:56 | <rafa__> djazayeri, wyclif: how do we decide what data to include in the sql dump? |
| 21:28:39 | <djazayeri> rafa__: we want to include (a) all metadata, (and b) data for 100 (set by GP) patients |
| 21:28:55 | <djazayeri> um, if you see an emoticon, that's ( a ) all metadata |
| 21:29:22 | <rafa__> no emoticon :) |
| 21:29:27 | <djazayeri> It occurred to me earlier that we may have to special-case things like global_property |
| 21:30:01 | <djazayeri> well, rather, if someone is running sync, things could get complicated |
| 21:30:04 | <chopin> djazayeri, rafa__: do we plan on allowing the implementations to test modules? if so, might need anything that connects. |
| 21:30:16 | *** dawn_ has joined #openmrs |
| 21:30:16 | *** ChanServ sets mode: +v dawn_ |
| 21:30:20 | *** dawn_ has left #openmrs |
| 21:30:47 | <djazayeri> yes, we want to test modules too, so we may need to copy module data too. |
| 21:30:52 | <djazayeri> basically, all modules get complicated... |
| 21:31:22 | <chopin> djazayeri: maybe an opt-in for modules to say what tables / rows should be included? |
| 21:31:52 | <chopin> sorry, gotta run ... cyas later |
| 21:32:09 | <wyclif> rafa__,i think it supposed to be about 1/3 from the earliest, 1/3 from the middle and the other 1/3 should be the latest plus patient with max encounters plus patient with max obs |
| 21:32:38 | *** dkayiwa has joined #openmrs |
| 21:33:24 | <djazayeri> I have a different counter-proposal, which is to fetch all patient_ids from the db (sorted) and take 100 evenly-distributed ones in the patient_id space. |
| 21:36:09 | <djazayeri> But as long as you're getting a variety of patients from different times in the age of the installation, it doesn't matter quite how |
| 21:36:43 | *** chopin has quit IRC |
| 21:37:10 | <djazayeri> rafa__: I would suggest you start by getting just core tables to work in the first pass |
| 21:37:59 | <rafa__> djazayeri: yes, it's what I was thinking about |
| 21:38:27 | <djazayeri> rafa__: yes, let's be agile. |
| 21:38:36 | <rafa__> djazayeri: I'll start with one table :) |
| 21:38:51 | <djazayeri> how about two. :-) |
| 21:38:57 | <djazayeri> one data, one md |
| 21:39:04 | <rafa__> fair enough ;-) |
| 21:40:14 | <rafa__> djazayeri: do you think I can borrow dump logic from sync? |
| 21:40:34 | <djazayeri> wyclif: do you know of some sqldump logic already written? |
| 21:40:47 | <djazayeri> rafa__: yes, you could borrow from sync. You can borrow from anywhere. |
| 21:40:53 | <wyclif> in logic module |
| 21:41:05 | <wyclif> djazayeri, sorry!, in sync module |
| 21:41:15 | <djazayeri> And if there's a way to do this that's quicker than sqldump, we could look at that also |
| 21:41:17 | *** downeym_ has joined #openmrs |
| 21:41:17 | *** ChanServ sets mode: +o downeym_ |
| 21:41:19 | <wyclif> i also wrote some in TestUtils djazayeri |
| 21:41:25 | <djazayeri> but sqldump is probably easiest |
| 21:41:55 | <wyclif> djazayeri, TestInstallUtil |
| 21:42:06 | <djazayeri> okay, rafa__ check that out |
| 21:42:13 | <djazayeri> wyclif: in trunk? |
| 21:42:45 | <rafa__> it actually calls mysqldump |
| 21:42:48 | <wyclif> djazayeri, yes |
| 21:42:55 | <rafa__> I'm not sure if we want that |
| 21:43:19 | <wyclif> rafa__, djazayeri they use mysqldump command |
| 21:43:34 | <wyclif> rafa__, what do u have in mind? |
| 21:43:40 | <rafa__> wyclif: sync do not use mysqldump |
| 21:43:51 | <rafa__> wyclif: TestInstallUtil does |
| 21:44:03 | <djazayeri> rafa__: I think I originally "wrote" that sync code. (i.e. I copied it from the web) |
| 21:44:17 | <djazayeri> seems like a fine approach to programmatically create a sqldump file, gives us better control. |
| 21:44:25 | <djazayeri> and we're not dealing with reams of data. |
| 21:44:37 | <rafa__> djazayeri: yeah it seems right |
| 21:45:19 | *** downeym has quit IRC |
| 21:45:20 | *** downeym_ is now known as downeym |
| 21:45:21 | <wyclif> rafa__, have a look at HibernateSyncDao.generateDataFile |
| 21:45:38 | *** downeym has quit IRC |
| 21:45:59 | <rafa__> wyclif: yes, I've seen that |
| 21:52:37 | *** dkayiwa has quit IRC |
| 22:04:20 | *** wyclif has quit IRC |
| 22:14:38 | *** rfriedman has quit IRC |
| 22:17:05 | *** wyclif has joined #openmrs |
| 22:24:44 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Are you on Google+? Check out #OpenMRS, +1 us, and add us to your circles! http://t.co/6v7nNirs #ICT4D #eHealth #HealthIT <http://twitter.com/OpenMRS/statuses/133658287559286784> |
| 22:30:41 | *** mccallumg has quit IRC |
| 22:32:23 | <wyclif> djazayeri, what module name have we decided on? |
| 22:32:38 | <wyclif> we need it to create the module project page in jira |
| 22:38:27 | <wyclif> hi djazayeri |
| 22:43:46 | *** wyclif has quit IRC |
| 23:16:29 | <djazayeri> hi wyclif |
| 23:16:32 | <djazayeri> doh, missed him |
| 23:22:20 | *** rafa__ has quit IRC |
| 23:28:01 | *** wyclif has joined #openmrs |