00:47:09
|
*** dguderian has joined #openmrs
|
01:15:49
|
*** chopin has joined #openmrs
|
01:15:49
|
*** ChanServ sets mode: +v chopin
|
02:07:21
|
*** jriley has joined #openmrs
|
02:21:11
|
*** dguderian has quit IRC
|
02:57:36
|
*** jriley has quit IRC
|
02:58:36
|
*** chopin has quit IRC
|
03:26:40
|
*** Boby has joined #openmrs
|
03:33:37
|
<Boby> Does anybody know how to use Webservices.rest Module ?
|
03:34:09
|
<Boby> Please Can you instruct to me ?
|
03:37:43
|
<Boby> Does anybody know it ?
|
03:44:24
|
*** Boby has left #openmrs
|
04:43:53
|
*** surangak has joined #openmrs
|
06:40:57
|
*** djazayeri has quit IRC
|
06:43:18
|
*** surangak_ has joined #openmrs
|
06:44:15
|
*** surangak has quit IRC
|
06:51:13
|
*** bryq has joined #openmrs
|
06:51:13
|
*** ChanServ sets mode: +v bryq
|
06:51:42
|
*** surangak_ has quit IRC
|
06:51:42
|
*** surangak has joined #openmrs
|
07:26:03
|
*** r0bby has joined #openmrs
|
07:26:03
|
*** ChanServ sets mode: +v r0bby
|
07:32:33
|
*** pascal` has joined #openmrs
|
07:32:33
|
*** ChanServ sets mode: +v pascal`
|
07:46:26
|
<pascal`> Hey bwolfe
|
07:47:35
|
*** pascal` has quit IRC
|
07:47:36
|
*** bwolfe has quit IRC
|
07:48:47
|
*** pascal` has joined #openmrs
|
07:48:53
|
*** ChanServ sets mode: +v pascal`
|
08:14:03
|
*** dkayiwa has joined #openmrs
|
08:31:35
|
<surangak> dkayiwa, good morning !
|
08:31:47
|
<surangak> IRC is pretty lonely today :-(
|
08:31:51
|
<dkayiwa> morning surangak
|
08:32:07
|
<dkayiwa> lollllllll :)
|
08:32:10
|
<surangak> dkayiwa, no rafa, no Bwolfe :-(
|
08:32:28
|
<dkayiwa> rafa is in the US so sleeping :)
|
08:32:46
|
<surangak> ah, I see
|
08:32:53
|
<surangak> I didnt know he was still there
|
08:33:15
|
<dkayiwa> he is now in Indianapolis
|
08:33:23
|
<dkayiwa> next week he will go to Boston
|
08:33:59
|
<surangak> dkayiwa, Is he attending a particluar event in US ?
|
08:34:06
|
<surangak> a meeting or something ?
|
08:34:24
|
<dkayiwa> just visiting :)
|
08:34:28
|
<dkayiwa> but while working
|
08:34:39
|
<surangak> dkayiwa, ah, being the tourist, like me :-)
|
08:34:49
|
<dkayiwa> yes :)
|
08:34:57
|
<surangak> Im still uploading the 1500+ photoes I took :-)
|
08:35:05
|
<dkayiwa> lolllllllll
|
08:38:02
|
*** pascal` has quit IRC
|
08:39:44
|
<dkayiwa> surangak: ever since i was born, i have never seen anyone takes as many photos on camera as you did :D
|
08:40:08
|
<surangak> dkayiwa, it was my first tim out of Sri Lanka, so it was a great experiance to me :)
|
08:40:16
|
<surangak> I even missed my flight going home :P
|
08:40:25
|
<dkayiwa> lolllllllllllll :D
|
08:41:18
|
<surangak> dkayiwa, u should have a fb profile.. :-)
|
08:41:18
|
*** pascal` has joined #openmrs
|
08:41:18
|
*** ChanServ sets mode: +v pascal`
|
08:41:25
|
<surangak> then we can tag you on pictures
|
08:41:54
|
<dkayiwa> i do not have time for facebook (i use that time for other things) :)
|
08:44:36
|
*** batkinson has joined #openmrs
|
08:57:53
|
*** bryq has quit IRC
|
09:32:55
|
*** ruwanego has joined #openmrs
|
09:37:27
|
<surangak> ruwanego, looong time Dude
|
09:39:18
|
<ruwanego> :)
|
09:47:27
|
*** Boby_ has joined #openmrs
|
09:48:19
|
<Boby_> Does anybody know how to use Webservices.rest Module ?
|
09:48:34
|
<Boby_> Please Can you instruct to me ?
|
09:49:24
|
*** batkinson has quit IRC
|
09:49:46
|
<Boby_> Does anybody know it ?
|
09:49:57
|
<Boby_> Please help me :(
|
09:54:33
|
*** Boby_ has quit IRC
|
09:58:13
|
*** dkayiwa has quit IRC
|
09:59:24
|
*** dkayiwa has joined #openmrs
|
10:21:50
|
*** ruwanego has quit IRC
|
11:04:25
|
*** surangak has quit IRC
|
11:13:23
|
*** dkayiwa has quit IRC
|
11:30:43
|
*** bwolfe has joined #openmrs
|
11:30:43
|
*** ChanServ sets mode: +o bwolfe
|
11:31:48
|
*** bwolfe_ has joined #openmrs
|
11:31:48
|
*** ChanServ sets mode: +o bwolfe_
|
11:32:26
|
<pascal`> ohai bwolfe
|
11:34:16
|
*** bwolfe has quit IRC
|
11:38:31
|
*** bwolfe_ is now known as bwolfe
|
11:38:34
|
<bwolfe> hi pascal`
|
11:55:45
|
<pascal`> bwolfe, I hope the OCC tickets I've assigned to Hannes are okay
|
11:55:59
|
<bwolfe> I saw one patch go through
|
11:56:15
|
<bwolfe> all tickets on occ are fair game right now
|
11:57:22
|
<pascal`> bwolfe, okay cool, I'm investigating an NPE I'm getting at the moment during upload.
|
11:58:03
|
<pascal`> bwolfe, it looks like one my concepts gets serialized just as <concept reference="1085"/> which is causing the NPE when the occmodule tries to do some funky stuff.
|
11:59:32
|
<bwolfe> does that id=1085 exist in the upload package? the ref/id stuff is assigned so that a concpet isn't inserted multiple times into the xmlo
|
11:59:34
|
<bwolfe> *xml
|
12:01:06
|
<pascal`> bwolfe, upload package?
|
12:01:16
|
<bwolfe> the xml
|
12:02:02
|
<pascal`> bwolfe, it's a top level concept in the concepts tree in the XML
|
12:02:29
|
<pascal`> bwolfe, I'm just clicking "sync all concepts" and this seemingly empty concept is serialized in somhow
|
12:03:25
|
<bwolfe> right, but look in the xml to see if there is an id="1085" somewhere
|
12:03:34
|
<bwolfe> maybe as an answer to somethign else?
|
12:04:17
|
<pascal`> bwolfe, yeah, there's an answerConcept with that id
|
12:04:38
|
<bwolfe> so is the parsing not going down the tree first?
|
12:04:41
|
<bwolfe> is that the problem?
|
12:05:17
|
<pascal`> This is all happening when the service is trying to set the hl7 code and original uuid attributes (just fyi)
|
12:06:44
|
<pascal`> bwolfe, it looks like it's only looking at the top level concepts in the <concepts> tree.
|
12:07:03
|
<pascal`> OccServiceImpl.doUpload
|
12:07:11
|
<pascal`> NPE on line 225
|
12:10:03
|
<bwolfe> odd
|
12:10:13
|
<bwolfe> so the fix is to make it crawl the tree?
|
12:11:11
|
<pascal`> bwolfe, I'm not sure.
|
12:11:53
|
<pascal`> bwolfe, I'm trying to understand how the serialization works and if it makes sense to have that basically blank concept serialized into the top level of the tree.
|
12:12:04
|
<pascal`> bwolfe, I mean, what does that even mean? Does it give us anything useful?
|
12:12:18
|
*** robbyoconnor has quit IRC
|
12:12:41
|
*** dkayiwa has joined #openmrs
|
12:12:54
|
<bwolfe> the blank concept means "look in the other concepts that have already be deserialized for one with serialization-id of 1085".
|
12:14:08
|
<pascal`> bwolfe, well, fine I guess.
|
12:14:28
|
<pascal`> bwolfe, but wouldn't it make more sense to first set the HL7 code and UUID before serialization?
|
12:14:55
|
<pascal`> bwolfe, instead of serializing, the processing the serialized string and inserting the attributes?
|
12:19:56
|
<pascal`> it would save a whole bunch of unecessary tree parsing and caching code I'd think
|
12:21:34
|
<pascal`> or wait, if a top level concept has a reference attribute, then we could just getOccConceptByCreatedConceptId using that reference value, couldn't we?
|
12:21:45
|
<bwolfe> pascal`, is the NPE on the server side or the client side?
|
12:22:12
|
<bwolfe> is the reference id the conceptId? I didn't think it was...
|
12:22:14
|
<pascal`> bwolfe, client, in the occ module, setting the HL7 code and UUID just before sending up to the server
|
12:22:45
|
<pascal`> bwolfe, oh right, it's not the reference id != concept id.
|
12:24:34
|
<bwolfe> the setting of hl7 code and uuid does not necessarily need to deserialize. it could just edit the text to insert manually
|
12:26:32
|
<pascal`> bwolfe, yeah, that's what it does
|
12:29:43
|
<pascal`> bwolfe, it doesn't look like that code was implemented to handle strange arrangements of concepts in the tree
|
12:33:10
|
<pascal`> bwolfe, here's an example
|
12:34:31
|
*** jriley has joined #openmrs
|
12:34:35
|
<pascal`> bwolfe, http://pastie.org/2761727
|
12:36:37
|
<pascal`> See how line 225 here can cause an NPE when it tries to analyze line 399 of the pastie: https://source.openmrs.org/browse/Modules/occmodule/trunk/api/src/main/java/org/openmrs/module/occmodule/impl/OccServiceImpl.java?hb=true
|
12:36:42
|
<OpenMRSBot> <http://ln-s.net/9FmV> (at source.openmrs.org)
|
12:50:08
|
<pascal`> bwolfe, where should the HL7/UUID be set? In the <concept> tree which contains the conceptId?
|
12:50:54
|
<bwolfe> its the overall hl7 code, right? so it should be a separate element in the upload xml
|
12:51:20
|
*** hannesv has joined #openmrs
|
12:52:33
|
<pascal`> bwolfe, it seems to be a per concept hl7 code
|
12:53:04
|
<pascal`> bwolfe, hence the breath first (and only at a depth of 1) traversal of the tree
|
13:00:02
|
*** djazayeri has joined #openmrs
|
13:00:02
|
*** ChanServ sets mode: +o djazayeri
|
13:08:55
|
<jriley> Could someone with JIRA powers assign https://tickets.openmrs.org/browse/IDC-4 to me?
|
13:09:28
|
*** hannesv has quit IRC
|
13:10:48
|
<dkayiwa> jriley: i think its because the ticket is not Ready for Work
|
13:10:57
|
<jriley> I can't make it Ready for Work
|
13:11:07
|
<jriley> but the work is done. I have a patch
|
13:11:30
|
*** chopin has joined #openmrs
|
13:11:30
|
*** ChanServ sets mode: +v chopin
|
13:12:01
|
*** burke has joined #openmrs
|
13:12:01
|
*** ChanServ sets mode: +o burke
|
13:12:04
|
<dkayiwa> jriley: i think you could in the meantime attach the patch
|
13:16:57
|
<pascal`> jriley, it's assigned to you
|
13:17:11
|
<jriley> Like magic! thank you
|
13:17:46
|
<pascal`> I'd love to take the credit, but it was dkayiwa :)
|
13:17:49
|
<pascal`> dkayiwa++
|
13:17:56
|
*** downeym has joined #openmrs
|
13:17:56
|
*** OpenMRSBot sets mode: +o downeym
|
13:17:56
|
*** ChanServ sets mode: +o downeym
|
13:17:58
|
<dkayiwa> :D
|
13:25:30
|
*** ChanServ changes topic to "OpenMRS: open source medical record systems for the developing world - http://openmrs.org/ - IRC info & logs: http://go.openmrs.org/irc - Can't find the answer here? Try http://answers.openmrs.org/"
|
13:52:53
|
*** r0bby has quit IRC
|
13:53:08
|
*** r0bby has joined #openmrs
|
13:53:08
|
*** ChanServ sets mode: +v r0bby
|
13:53:48
|
*** r0bby__ has joined #openmrs
|
13:53:48
|
*** ChanServ sets mode: +v r0bby__
|
13:54:17
|
*** r0bby__ has quit IRC
|
13:54:40
|
*** r0bby__ has joined #openmrs
|
13:54:41
|
*** ChanServ sets mode: +v r0bby__
|
13:55:34
|
*** rafa has joined #openmrs
|
13:55:34
|
*** ChanServ sets mode: +v rafa
|
13:57:25
|
*** r0bby has quit IRC
|
14:19:22
|
<djazayeri> hi bwolfe, dkayiwa, rafa
|
14:19:38
|
<rafa> hi djazayeri
|
14:19:46
|
<dkayiwa> hi djazayeri
|
14:20:02
|
*** jriley has left #openmrs
|
14:20:08
|
*** jriley has joined #openmrs
|
14:20:38
|
<djazayeri> I need to go pretty soon, so let's do an abbreviated scrum
|
14:20:49
|
<dkayiwa> :D
|
14:20:54
|
<djazayeri> specifically: what is a blocker now for releasing 1.9 alpha
|
14:21:03
|
<djazayeri> dkayiwa: want to lead off?
|
14:21:45
|
<dkayiwa> djazayeri: the blocker is getting time together to select among the uncomplete new features, which are to actually block the alpha release
|
14:21:49
|
<bwolfe> https://tickets.openmrs.org/secure/IssueNavigator.jspa?mode=hide&requestId=10951 is what dkayiwasent earlier
|
14:21:54
|
<OpenMRSBot> <http://ln-s.net/9Fnm> (at tickets.openmrs.org)
|
14:22:35
|
<djazayeri> we should remove the post-commits from that list, since they're already in.
|
14:22:48
|
<djazayeri> and we aren't required to complete the code review before the alpha
|
14:22:59
|
<dkayiwa> oh i see
|
14:23:15
|
<djazayeri> That leaves us with 11
|
14:23:30
|
*** r0bby__ has quit IRC
|
14:23:41
|
<rafa> I don't see TRUNK-2711 on this list
|
14:23:53
|
<rafa> it's what I'm working on right now
|
14:23:58
|
<djazayeri> this list includes just "new feature"
|
14:24:02
|
<djazayeri> and not "bug"
|
14:24:08
|
<rafa> it's a new feature ;)
|
14:24:22
|
<djazayeri> Is it marked that way? :-)
|
14:24:26
|
<bwolfe> !ticket TRUNK-2711
|
14:24:27
|
<OpenMRSBot> bwolfe: [#TRUNK-2711] Change active visits in header - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2711
|
14:24:33
|
<djazayeri> ah, it's a sub-task
|
14:24:50
|
<djazayeri> Sometimes JIRA annoys me.
|
14:25:12
|
<dkayiwa> djazayeri: does this also block the alpha? TRUNK-2795
|
14:25:20
|
<rafa> ohh right it's a sub-task of a bug task that should actually be new feature
|
14:26:11
|
<rafa> I don't think there's a way to fix that :/
|
14:26:12
|
<djazayeri> dkayiwa: are you unable to save visits with attributes, ever?
|
14:26:29
|
<djazayeri> rafa: if it's a blocker for the release, change its priority to blocker
|
14:26:38
|
<djazayeri> that'll get it on this list. :-)
|
14:26:46
|
<rafa> djazayeri: I'll do that
|
14:27:56
|
<djazayeri> rafa: in retrospect I don't think we should consider that a blocker for 1.9 alpha
|
14:28:07
|
<djazayeri> but if you're mostly done, go ahead and finish it
|
14:28:13
|
<rafa> it's almost done
|
14:28:28
|
<dkayiwa> djazayeri: shall we bundle the formentry module before it can be able to save any encounter?
|
14:28:43
|
<dkayiwa> https://tickets.openmrs.org/browse/FORM-129
|
14:28:50
|
<djazayeri> dkayiwa: no
|
14:28:54
|
<dkayiwa> ok
|
14:29:04
|
<djazayeri> do xforms and htmlformentry work?
|
14:29:26
|
<djazayeri> HFE must, since I tried it in the demo today.
|
14:29:26
|
<dkayiwa> htmlformentry works when you select the correct provider :)
|
14:29:32
|
<djazayeri> okay, good enough for alpha
|
14:29:52
|
<bwolfe> ha, meaning if the user_id happens to be in the provider table ?
|
14:29:55
|
<dkayiwa> when you select a provider who is not in the new provider table, it fails
|
14:30:02
|
<dkayiwa> yes bwolfe
|
14:30:02
|
<bwolfe> I'd say that means it doesn't make it
|
14:30:16
|
<bwolfe> I'd prefer we fix formentry/hfe and put them in the alpha (or at least hfe)
|
14:30:22
|
<bwolfe> the formentry one should be a quick fix
|
14:30:26
|
<dkayiwa> same problem with xforms
|
14:30:28
|
<dkayiwa> :)
|
14:31:17
|
<djazayeri> I think that since we're already going to be 2 weeks behind schedule releasing the alpha, I would prefer to release it ASAP, even if bundled modules don't work right
|
14:31:34
|
<dkayiwa> ok
|
14:31:36
|
<djazayeri> It's an alpha after all
|
14:31:38
|
<bwolfe> ha
|
14:31:52
|
<bwolfe> it's submitting bad data though, thats worse than just not working
|
14:32:05
|
<bwolfe> if you want to move ahead asap, lets only release it with xforms then
|
14:32:10
|
<djazayeri> that's fine
|
14:32:16
|
<dkayiwa> not being able to submit a from from formentry module makes it useless to bundle
|
14:32:18
|
<djazayeri> or even releasing it with no bundled modules
|
14:32:54
|
<djazayeri> If xforms is already fixed to work with 1.9, yes, let's just bundle that.
|
14:33:00
|
<dkayiwa> ok
|
14:33:14
|
<djazayeri> That said, shouldn't there be a deprecated method that makes HFE and FE continue to work?
|
14:33:30
|
<dkayiwa> djazayeri: thats what i was pushing for :)
|
14:33:40
|
<dkayiwa> but looks like the vote was not in my favor :)
|
14:33:51
|
<bwolfe> the problem is htat its doing a user search
|
14:33:55
|
<bwolfe> instead of a provider search
|
14:34:07
|
<bwolfe> if we had had a provider widget from the get-go then the modules wouldn't need to change
|
14:34:26
|
<dkayiwa> bwolfe: thats for one of the two problems for the formentry module
|
14:34:59
|
<bwolfe> oh, whats the other? the xslt one?
|
14:35:05
|
<dkayiwa> yes
|
14:35:20
|
<dkayiwa> thats the one where i was pushing for a deprecation without exception
|
14:35:23
|
<bwolfe> ah yes. well, it was broken when we tried to have it forward before. so we opted to just make it break earlier
|
14:35:35
|
<dkayiwa> :)
|
14:35:45
|
<djazayeri> HTML Form Entry is doing: encounter.setProvider(person)
|
14:35:59
|
<djazayeri> I don't see why this would create bad data
|
14:36:15
|
<dkayiwa> for bad data, it would throw an exception
|
14:36:46
|
<dkayiwa> that is when the selected provider is not in the new provider table
|
14:37:06
|
<djazayeri> So, if you choose a provider out of the list, and that provider doesn't have a Provider row (because they've never been an encounter.provider before in the db) it'll throw an exception?
|
14:37:15
|
<djazayeri> Seems fine to bundle (in the alpha) to me
|
14:37:19
|
<dkayiwa> yes
|
14:37:45
|
<bwolfe> ah ok, thats diff than the formentry bug with providers. I agree its probably ok to bundle
|
14:37:47
|
<djazayeri> It'll either work correctly, or fail. But it won't create bad data.
|
14:37:59
|
<djazayeri> okay, so getting back to Daniel's list
|
14:38:42
|
<djazayeri> new version: https://tickets.openmrs.org/secure/IssueNavigator.jspa?mode=hide&requestId=10952
|
14:38:48
|
<OpenMRSBot> <http://ln-s.net/9Fo5> (at tickets.openmrs.org)
|
14:38:50
|
<djazayeri> looking at this list:
|
14:39:10
|
<djazayeri> trunk-2674 is a bug, and it exists as far back as 1.6.
|
14:39:17
|
<djazayeri> It should not block the alpha
|
14:39:26
|
<djazayeri> trunk-2782 seems like a blocker
|
14:40:07
|
<djazayeri> trukn-2784: rafa can finish it off today
|
14:40:29
|
<djazayeri> trunk-2589: I'll apply the patch today
|
14:40:53
|
<djazayeri> trunk-420: if this isn't ready to apply now, it's definitely getting bumped. How close is it dkayiwa?
|
14:41:56
|
<djazayeri> (Looking at trunk-420, it seems that there are only some very minor changes needed, so we could do these, and apply)
|
14:42:23
|
<dkayiwa> ok
|
14:42:58
|
<djazayeri> trunk-2055: IIRC from wyclif, the problem is that the changes to messages.properties files in taras's patch have garbled accents, but we can apply everything but the messages.properties changes
|
14:43:10
|
<djazayeri> actually it's a branch, not a patch
|
14:43:35
|
<djazayeri> So, this seems pretty significant to do without wyclif around, who's already looked at it
|
14:43:48
|
<djazayeri> let's put it last on the list
|
14:43:54
|
<dkayiwa> ok
|
14:46:19
|
<djazayeri> trunk-37: dkayiwa commented about not being able to apply the patch. seems to me that it does apply to the api project (with fuzziness=1)
|
14:46:50
|
<djazayeri> though the test class doesn't apply cleanly, that one file can be done manually
|
14:46:53
|
<djazayeri> I think we should apply it.
|
14:47:26
|
<dkayiwa> ok
|
14:47:29
|
<djazayeri> trunk-17: bump to 1.10
|
14:47:36
|
<dkayiwa> ok
|
14:48:11
|
<djazayeri> trunk-2004: bump to 1.10
|
14:48:24
|
<dkayiwa> ok
|
14:48:32
|
<djazayeri> trunk-2731: not a blocker
|
14:48:55
|
<djazayeri> trunk-2585: not a blocker
|
14:51:38
|
<djazayeri> so, to summarize:
|
14:51:38
|
<djazayeri> blocker: trunk-2782
|
14:51:39
|
<djazayeri> to finish today:
|
14:51:39
|
<djazayeri> rafa: trunk-2784
|
14:51:39
|
<djazayeri> djazayeri: trunk-2589
|
14:51:40
|
<djazayeri> to apply:
|
14:51:40
|
<djazayeri> trunk-420 with very small changes
|
14:51:41
|
<djazayeri> trunk-37 with manual fix on test class
|
14:51:42
|
<djazayeri> probably bump:
|
14:51:42
|
<djazayeri> trunk-2055 (wyclif)
|
14:52:08
|
<djazayeri> trunk-2782, trunk-420, and trunk-37 need owners
|
14:53:58
|
<djazayeri> also, when demoing today, visit stuff did not work for me
|
14:54:23
|
<djazayeri> the visit tab on the dashboard wasn't grouping things right, and was showing wrong end dates
|
14:54:24
|
*** pascal` has quit IRC
|
14:54:30
|
<rafa> djazayeri: yeah, I introduced a bug yesterday. It's fixed now.
|
14:54:41
|
<djazayeri> and entering a form failed to create a visit
|
14:54:51
|
<djazayeri> or maybe it's just the display bug
|
14:55:09
|
<djazayeri> rafa: how long will your current ticket take?
|
14:55:35
|
<rafa> about 2 hours
|
14:55:44
|
<rafa> djazayeri: but I need to figure out why tests are failing too :/
|
14:55:49
|
*** downeym_ has joined #openmrs
|
14:55:49
|
*** ChanServ sets mode: +o downeym_
|
14:56:02
|
<rafa> when I run them separately they seem to work
|
14:57:25
|
<dkayiwa> djazayeri: will this also block the alpha release? https://tickets.openmrs.org/browse/TRUNK-2796
|
14:57:56
|
*** downeym has quit IRC
|
14:57:56
|
*** downeym_ is now known as downeym
|
14:58:01
|
<djazayeri> dkayiwa: do you get this in the UI? or in code?
|
14:58:10
|
<dkayiwa> djazayeri: in the UI
|
14:58:12
|
<rafa> have you seen java.lang.IllegalStateException: Already value [org.springframework.orm.hibernate3.SessionHolder@153112e8] for key [org.hibernate.impl.SessionFactoryImpl@9761d26] bound to thread [main] before?
|
14:58:23
|
<dkayiwa> i created standalone version which am testing
|
14:58:37
|
<dkayiwa> as per the code which was committed by today morning
|
14:59:31
|
<djazayeri> dkayiwa: hmm, that's related to the tricky problem that I ran into in Kigali.
|
14:59:38
|
<dkayiwa> ok
|
14:59:46
|
<djazayeri> where trying to do validation causes a flush
|
14:59:54
|
<dkayiwa> yes
|
15:00:08
|
<djazayeri> I think the solution to that is not going to be quick, so we should release even with that bug unfixed.
|
15:00:15
|
<dkayiwa> ok
|
15:01:12
|
<djazayeri> rafa: do you know the -D variable I need to set to tell jetty to use a different webapp name than the one in pom.xml?
|
15:01:56
|
<djazayeri> bwolfe: do you have time today to handle trunk-2782 or to apply trunk-420 or trunk-37?
|
15:02:17
|
<rafa> djazayeri: I'd try with -Dwebapp.name
|
15:03:29
|
<rafa> djazayeri: what I started doing recently is giving -Duser.home
|
15:03:52
|
<djazayeri> rafa: is that so it finds a different runtime properties file?
|
15:03:52
|
<rafa> djazayeri: it let's me to have a separate module folder as well
|
15:04:39
|
<rafa> yes if you change the webapp.name it'll look for a different properties file
|
15:04:58
|
<djazayeri> yeah, though it didn't seem to pick up -Dwebapp.name
|
15:05:34
|
<djazayeri> okay, so to summarize, rafa has a ticket to finish, I have a patch, and there are 3 more
|
15:05:53
|
<djazayeri> so, whoever has time today (bwolfe, dkayiwa, rafa, djazayeri) should do: trunk-2782, trunk-420, trunk-37
|
15:06:01
|
<dkayiwa> ok
|
15:06:05
|
<rafa> cool
|
15:06:07
|
<djazayeri> and perhaps tomorrow daniel can do packaging and testing?
|
15:06:11
|
<djazayeri> I've gotta run.
|
15:06:16
|
<dkayiwa> ok
|
15:09:56
|
<bwolfe> I can look at those during the calls later tonight at 15% speed. :-p
|
15:10:00
|
<djazayeri> okay
|
15:10:01
|
<bwolfe> heading to dinner now though
|
15:10:03
|
<bwolfe> bbl
|
15:41:56
|
*** r0bby has joined #openmrs
|
15:41:56
|
*** ChanServ sets mode: +v r0bby
|
15:44:52
|
*** r0bby__ has joined #openmrs
|
15:44:52
|
*** ChanServ sets mode: +v r0bby__
|
15:47:13
|
* downeym slaps lulu.com around a bit with a large trout
|
15:50:21
|
*** r0bby__ has quit IRC
|
15:50:21
|
*** r0bby has quit IRC
|
15:50:42
|
*** rafa has quit IRC
|
15:50:43
|
*** r0bby has joined #openmrs
|
15:50:43
|
*** ChanServ sets mode: +v r0bby
|
15:57:59
|
*** r0bby has quit IRC
|
15:58:02
|
*** r0bby__ has joined #openmrs
|
15:58:02
|
*** ChanServ sets mode: +v r0bby__
|
15:58:13
|
*** r0bby__ has quit IRC
|
15:58:22
|
*** r0bby__ has joined #openmrs
|
15:58:22
|
*** ChanServ sets mode: +v r0bby__
|
16:00:24
|
*** bwolfe has quit IRC
|
16:05:39
|
<djazayeri> dkayiwa: when you do a clean installation (e.g. you start the standalone with 1.9.x) it loads?
|
16:05:58
|
<djazayeri> I just tried creating a new database with demo data, and I get org.hibernate.PropertyNotFoundException: field [valueReference] not found on org.openmrs.ProviderAttribute
|
16:06:17
|
<dkayiwa> djazayeri: yes it loads
|
16:06:32
|
<djazayeri> (and indeed BaseAttribute doesn't have a "valueReference", it has a "persistedValue"
|
16:06:40
|
<dkayiwa> djazayeri: but i last tested that last week
|
16:06:54
|
<dkayiwa> djazayeri: so something could have happened between last week and now
|
16:07:04
|
<djazayeri> This would have happened in Kigali.
|
16:07:22
|
<dkayiwa> djazayeri: i did all my tests in kigali
|
16:07:32
|
<dkayiwa> djazayeri: i can do one again just now
|
16:07:41
|
<djazayeri> if you can try that quickly, it'd help
|
16:07:45
|
<dkayiwa> djazayeri: i meant after kigali
|
16:07:49
|
<dkayiwa> not in kigali
|
16:07:58
|
<dkayiwa> djazayeri: let me do it just now
|
16:08:34
|
<djazayeri> As far as I can tell, I just did a clean checkout of the trunk code, and it fails to create a database.
|
16:08:57
|
<dkayiwa> djazayeri: i last updated today morning (Ugandan time)
|
16:09:16
|
<dkayiwa> djazayeri: so should i start by updating now and then recompile?
|
16:10:05
|
<djazayeri> I just deployed the war as "openmrsclean" and it failed to start after creating the database.
|
16:10:14
|
<djazayeri> But I don't see how it can run at all even if you're not doing a clean install
|
16:11:02
|
<djazayeri> e.g. ProviderAttribute.hbm.xml mentions a valueReference property, but that doesn't exist on BaseAttribute in trunk
|
16:11:10
|
<djazayeri> so even just try running the codeâ¦doesn't that fail?
|
16:11:45
|
<dkayiwa> unless that was done today. mine has always been running fine
|
16:12:10
|
<djazayeri> oh, hmm, there are getters and setters for valueReference, even though the underlying field has a different name
|
16:12:19
|
<djazayeri> hmm, not sure why it's breaking then, let me investigate.
|
16:19:55
|
<dkayiwa> djazayeri: after svn update, running trunk from eclipse is fine on my side
|
16:20:03
|
<djazayeri> okay, i'll investigate a bit more
|
16:39:20
|
*** dkayiwa has quit IRC
|
16:57:03
|
*** lh_ has joined #openmrs
|
16:58:32
|
*** lh_ is now known as lh
|
17:04:52
|
*** Boby_ has joined #openmrs
|
17:05:51
|
<Boby_> Does anybody know how to use Webservices.rest Module ?
|
17:06:01
|
<Boby_> Please Can you instruct to me ?
|
17:23:39
|
<jriley> Boby, all I know is the module home page is at https://wiki.openmrs.org/display/docs/Webservices.rest+Module .
|
17:23:40
|
<OpenMRSBot> <http://ln-s.net/92SZ> (at wiki.openmrs.org)
|
17:38:58
|
*** burke is now known as burke_away
|
17:44:54
|
*** bwolfe has joined #openmrs
|
17:44:54
|
*** ChanServ sets mode: +o bwolfe
|
17:53:26
|
*** dkayiwa has joined #openmrs
|
17:58:05
|
*** kishoreyekkanti has joined #openmrs
|
17:59:24
|
*** burke_away is now known as burke
|
18:03:29
|
<bwolfe> dkayiwa, is freeconferencing working for you on skype?
|
18:03:45
|
<dkayiwa> bwolfe NOOOOOO
|
18:04:18
|
<bwolfe> ugh
|
18:05:25
|
<kishoreyekkanti> djazayeri: Hi Darius, have you got any thing else for code jam apart from metadata sharing module?
|
18:05:55
|
<djazayeri> hi kishoreyekkanti: writing you an email now that includes a lot of MDS stuff
|
18:06:02
|
<djazayeri> won't be able to send it till later
|
18:06:36
|
<kishoreyekkanti> djazayeri: Sure no problem. Anyways i'll look it only tomorrow morning :)
|
18:06:53
|
<djazayeri> okay, cool
|
18:07:26
|
<djazayeri> bwolfe: yo, you joining the design call?
|
18:07:45
|
<bwolfe> I was hoping freeconf would start working...
|
18:07:48
|
<bwolfe> how are you calling in?
|
18:08:16
|
* bwolfe remembers the connect site
|
18:08:31
|
<dkayiwa> :D
|
18:17:53
|
*** kishoreyekkanti has quit IRC
|
18:21:20
|
*** Boby_ has quit IRC
|
18:23:01
|
*** suranga has joined #openmrs
|
18:25:00
|
*** robbyoconnor has joined #openmrs
|
18:25:00
|
*** ChanServ sets mode: +v robbyoconnor
|
18:29:07
|
*** suranga_ has joined #openmrs
|
18:32:47
|
*** suranga has quit IRC
|
18:36:47
|
*** bryq has joined #openmrs
|
18:36:47
|
*** ChanServ sets mode: +v bryq
|
18:39:38
|
*** pascal` has joined #openmrs
|
18:39:38
|
*** ChanServ sets mode: +v pascal`
|
19:06:47
|
*** robbyoconnor has quit IRC
|
19:09:50
|
*** robbyoconnor has joined #openmrs
|
19:09:50
|
*** ChanServ sets mode: +v robbyoconnor
|
19:21:15
|
*** suranga_ has quit IRC
|
19:26:22
|
*** rafa has joined #openmrs
|
19:26:22
|
*** ChanServ sets mode: +v rafa
|
19:27:53
|
*** r0bby__ has quit IRC
|
19:28:03
|
*** r0bby__ has joined #openmrs
|
19:28:03
|
*** ChanServ sets mode: +v r0bby__
|
19:46:48
|
*** robbyoconnor has quit IRC
|
19:52:26
|
*** pascal` has quit IRC
|
19:53:43
|
*** pascal` has joined #openmrs
|
19:56:09
|
<rafa> dkayiwa: hey
|
19:56:16
|
<dkayiwa> hey
|
19:56:24
|
<rafa> dkayiwa: https://tickets.openmrs.org/browse/TRUNK-2718
|
19:56:38
|
<rafa> how to get to the "Edit Metadata" screen
|
19:57:23
|
<rafa> dkayiwa: is it still a valid ticket?
|
19:57:29
|
<dkayiwa> rafa: was fixed by jeremy's revert
|
19:57:37
|
<rafa> dkayiwa: cool
|
19:57:44
|
<dkayiwa> the screen is the one you get to after selecting a form
|
19:58:18
|
<rafa> dkayiwa: okay
|
19:58:43
|
<rafa> dkayiwa: are there any high priority tickets left?
|
19:59:24
|
<dkayiwa> rafa: the ones on the url we shared during the scrum
|
19:59:33
|
<dkayiwa> if those are done, then we are good to go
|
20:00:27
|
<rafa> dkayiwa: seems like only https://tickets.openmrs.org/browse/TRUNK-2731 is free
|
20:00:32
|
<rafa> shall I start with that?
|
20:01:09
|
<dkayiwa> no
|
20:01:17
|
<dkayiwa> that is not hight priority
|
20:01:25
|
<rafa> okay
|
20:05:05
|
<djazayeri> bwolfe: waiting for you on freeconferencing
|
20:05:17
|
<bwolfe> orly?
|
20:05:42
|
<djazayeri> orly?
|
20:11:10
|
<bwolfe> rly.
|
20:14:55
|
*** lh has quit IRC
|
20:18:32
|
*** r0bby__ has quit IRC
|
20:18:40
|
*** chopin has quit IRC
|
20:21:51
|
*** rafa has quit IRC
|
20:30:45
|
*** r0bby has joined #openmrs
|
20:30:45
|
*** ChanServ sets mode: +v r0bby
|
20:48:07
|
*** r0bby has quit IRC
|
20:48:08
|
*** r0bby__ has joined #openmrs
|
20:48:08
|
*** ChanServ sets mode: +v r0bby__
|
20:49:55
|
*** r0bby has joined #openmrs
|
20:49:55
|
*** ChanServ sets mode: +v r0bby
|
20:53:17
|
*** r0bby__ has quit IRC
|
20:59:11
|
*** r0bby__ has joined #openmrs
|
20:59:11
|
*** ChanServ sets mode: +v r0bby__
|
21:00:16
|
*** r0bby__ has quit IRC
|
21:00:16
|
*** r0bby has quit IRC
|
21:03:00
|
<downeym> djazayeri noirin et al, I cleaned up all HTML and formatting in the book. Seems to be clean now. http://objavi.booki.cc/books/openmrsguide-en-2011.10.26-20.41.16.pdf
|
21:03:04
|
<OpenMRSBot> <http://ln-s.net/9FsV> (at objavi.booki.cc)
|
21:03:12
|
<djazayeri> nice
|
21:03:48
|
*** r0bby has joined #openmrs
|
21:03:48
|
*** ChanServ sets mode: +v r0bby
|
21:10:08
|
*** lh has joined #openmrs
|
21:19:59
|
*** bryq has quit IRC
|
21:27:06
|
*** burke is now known as burke_away
|
21:29:36
|
<noirin> downeym: Sweet :-) Did you get Lulu sorted?-
|
21:30:10
|
*** r0bby has quit IRC
|
21:30:37
|
<downeym> noirin: Yes, finally. No clue why it had so many troubles. http://www.lulu.com/product/paperback/openmrs-implementers-guide/18420224
|
21:30:50
|
<OpenMRSBot> <http://ln-s.net/9Fsm> (at www.lulu.com)
|
21:32:28
|
*** burke_away is now known as burke
|
21:36:02
|
*** downeym_ has joined #openmrs
|
21:36:02
|
*** ChanServ sets mode: +o downeym_
|
21:40:56
|
*** downeym has quit IRC
|
21:40:56
|
*** downeym_ is now known as downeym
|
21:53:51
|
*** dkayiwa has quit IRC
|
21:57:06
|
*** Echidna has quit IRC
|
22:09:16
|
*** r0bby has joined #openmrs
|
22:09:16
|
*** ChanServ sets mode: +v r0bby
|
22:10:11
|
*** robbyoconnor has joined #openmrs
|
22:10:11
|
*** ChanServ sets mode: +v robbyoconnor
|
22:14:52
|
*** downeym has quit IRC
|
22:18:07
|
*** robbyoconnor has quit IRC
|
22:31:01
|
*** r0bby has quit IRC
|
22:34:52
|
*** burke has quit IRC
|
22:46:49
|
*** r0bby has joined #openmrs
|
22:46:49
|
*** ChanServ sets mode: +v r0bby
|
22:50:38
|
*** Echidna has joined #openmrs
|
22:50:38
|
*** ChanServ sets mode: +v Echidna
|
23:32:28
|
*** r0bby has quit IRC
|