00:46:08
|
*** lh has quit IRC
|
00:48:00
|
*** wyclif has quit IRC
|
00:54:53
|
*** burke has joined #openmrs
|
00:55:07
|
*** ChanServ sets mode: +o burke
|
02:11:46
|
*** jriley has joined #openmrs
|
02:37:58
|
*** jriley has quit IRC
|
02:44:30
|
*** surangak has joined #openmrs
|
02:51:02
|
*** wyclif has joined #openmrs
|
03:13:27
|
*** upul` has joined #openmrs
|
03:13:27
|
*** ChanServ sets mode: +v upul`
|
03:31:34
|
*** burke has quit IRC
|
03:53:57
|
*** jriley has joined #openmrs
|
04:50:59
|
*** bryq has joined #openmrs
|
04:50:59
|
*** ChanServ sets mode: +v bryq
|
04:51:49
|
*** chughgaurav has joined #openmrs
|
04:58:13
|
*** bryq has left #openmrs
|
05:12:18
|
*** finbrein has quit IRC
|
05:15:27
|
*** bwolfe has quit IRC
|
05:45:16
|
*** chughgaurav has quit IRC
|
05:45:31
|
*** finbrein has joined #openmrs
|
06:09:39
|
*** bwolfe has joined #openmrs
|
06:09:39
|
*** ChanServ sets mode: +o bwolfe
|
06:27:02
|
*** bwolfe has quit IRC
|
06:27:03
|
*** bwolfe_ has joined #openmrs
|
06:27:03
|
*** ChanServ sets mode: +o bwolfe_
|
06:27:52
|
*** jriley has quit IRC
|
06:41:09
|
*** dkayiwa has joined #openmrs
|
06:46:07
|
*** bwolfe_ has quit IRC
|
07:03:25
|
*** bwolfe_ has joined #openmrs
|
07:03:25
|
*** ChanServ sets mode: +o bwolfe_
|
07:11:10
|
*** andtorg has joined #openmrs
|
07:15:07
|
*** rafa has joined #openmrs
|
07:15:07
|
*** ChanServ sets mode: +v rafa
|
07:20:52
|
*** muthah has joined #openmrs
|
07:36:49
|
*** jriley has joined #openmrs
|
07:45:36
|
*** jriley has quit IRC
|
07:48:48
|
*** jriley has joined #openmrs
|
07:49:03
|
*** bwolfe_ has quit IRC
|
08:01:06
|
*** bwolfe_ has joined #openmrs
|
08:01:06
|
*** ChanServ sets mode: +o bwolfe_
|
08:30:42
|
*** jriley has quit IRC
|
08:32:06
|
<dkayiwa> hi bwolfe_
|
08:39:07
|
<robbyoconnor> hi dkayiwa
|
08:39:12
|
<robbyoconnor> hi bwolfe_
|
08:39:15
|
<dkayiwa> hi robbyoconnor
|
08:39:23
|
<robbyoconnor> meh
|
09:11:17
|
<dkayiwa> hi rafa
|
09:11:24
|
<rafa> hi dkayiwa
|
09:12:01
|
<dkayiwa> do you know how i can always get reviews attached to tickets without googling? :)
|
09:12:36
|
<rafa> dkayiwa: what I do is open a ticket and click source tab and create review
|
09:13:45
|
<dkayiwa> rafa when i just want to review other people's tickets
|
09:14:11
|
<rafa> dkayiwa: ohh that I don't know
|
09:14:26
|
<dkayiwa> ok
|
09:15:22
|
<rafa> bwolfe_: is a master of JIRA ;)
|
09:15:49
|
<dkayiwa> not Michaeln :)
|
09:16:07
|
<rafa> dkayiwa: too
|
09:16:27
|
<dkayiwa> who is more :D
|
09:16:50
|
<rafa> dkayiwa: it's like asking what was first egg or chicken ;)
|
09:17:03
|
<dkayiwa> hhahahahah :D
|
09:17:26
|
<dkayiwa> God created chicken :)
|
09:18:00
|
<rafa> dkayiwa: or egg ;P
|
09:18:19
|
<dkayiwa> chicken :)
|
09:18:33
|
<rafa> egg
|
09:18:34
|
<dkayiwa> then it layed eggs
|
09:18:46
|
<dkayiwa> who would hatch the egg
|
09:18:56
|
<dkayiwa> without chicken
|
09:19:31
|
<rafa> haha you just resolved unresolved dilemma :D
|
09:19:40
|
<dkayiwa> :D
|
09:19:42
|
<rafa> clever guy :P
|
09:19:59
|
<dkayiwa> lollllll. i just read the Bible :)
|
09:21:14
|
<rafa> dkayiwa: okay so go figure out who is better at JIRA now ;)
|
09:21:28
|
<dkayiwa> hahahahah :D
|
09:22:03
|
<dkayiwa> unfortunately cant get that from Bible :(
|
09:23:45
|
<dkayiwa> by the way rafa when do u get to kigali
|
09:24:12
|
<rafa> dkayiwa: ohh I don't
|
09:24:26
|
<dkayiwa> u dont know
|
09:24:42
|
<rafa> dkayiwa: I didn't manage it this time
|
09:25:05
|
<dkayiwa> why
|
09:25:56
|
<rafa> dkayiwa: It's pretty complicated to get there from here and there was not enough time to fulfill all formalities
|
09:26:08
|
<dkayiwa> oh sorry
|
09:26:08
|
<rafa> foremost I need VISA to enter Rwanda
|
09:26:16
|
<rafa> and I can only get one in Berlin
|
09:26:19
|
<dkayiwa> you can buy on arrival
|
09:26:38
|
<surangak> rafa, I myself got an on arrival visa
|
09:26:58
|
<surangak> rafa, they sent me a letter saying, "you can pick up visa when u arrive here"
|
09:27:13
|
<rafa> ohh yes?
|
09:27:26
|
<dkayiwa> yes u can
|
09:27:40
|
<dkayiwa> in Africa things are simpler
|
09:27:54
|
*** darius_ has joined #openmrs
|
09:27:54
|
<rafa> there was nothing about it on the embassy website :/
|
09:28:01
|
*** darius_ is now known as djazayeri
|
09:28:04
|
<dkayiwa> not many people would love to stay here :)
|
09:28:15
|
*** ChanServ sets mode: +o djazayeri
|
09:28:28
|
<rafa> hi djazayeri
|
09:28:34
|
<djazayeri> hi rafa
|
09:28:53
|
<djazayeri> This wiki page took 5 minutes to load, but is working now. :-)
|
09:28:54
|
<rafa> welcome to our time zone ;)
|
09:29:18
|
<rafa> happy to hear
|
09:29:23
|
<dkayiwa> no more early morning waking up :)
|
09:29:29
|
<surangak> djazayeri, yep, so u finally decided to move to the 'better' time zone
|
09:29:40
|
<surangak> djazayeri, this time zone rocks :-)
|
09:29:47
|
<dkayiwa> but late night sleep :)
|
09:30:12
|
<dkayiwa> surangak: have you ever worked for an advertising company? :)
|
09:30:27
|
<djazayeri> indeed
|
09:31:01
|
<dkayiwa> the weather rocks more than the time zone :)
|
09:31:08
|
<surangak> dkayiwa, sorry, didnt understand you ?
|
09:31:17
|
<surangak> dkayiwa, advertising company ?
|
09:31:27
|
<dkayiwa> surangak: you have advertising words:)
|
09:31:44
|
<dkayiwa> now advertising for time zone :)
|
09:31:56
|
<surangak> dkayiwa, I used to write political stuff for the news some time back
|
09:31:56
|
<rafa> djazayeri: would you have any objections if I splitted the table with views from TRUNK-2710 in two?
|
09:32:07
|
<dkayiwa> oh i seee
|
09:32:07
|
<surangak> dkayiwa, maybe its spreading :-)
|
09:32:15
|
<rafa> djazayeri: one with visits and empty visits and the other with unasiggned encounters
|
09:32:15
|
<dkayiwa> surangak: lollllllllll :)
|
09:32:28
|
<rafa> djazayeri: it's because there's no full outer join in hiberante
|
09:32:34
|
<surangak> rafa, that form u wanted is http://www.migration.gov.rw/singleform.php
|
09:34:17
|
<rafa> surangak: Thanks. I'll use it next year :)
|
09:34:45
|
<dkayiwa> rafa: next year will not be Kigali :)
|
09:35:43
|
*** bwolfe_ has quit IRC
|
09:35:49
|
<rafa> dkayiwa: ahh right
|
09:36:11
|
<dkayiwa> rafa: next yeat will be Kampala :)
|
09:36:45
|
<rafa> dkayiwa: you're well informed :D
|
09:37:04
|
*** djazayeri has quit IRC
|
09:37:09
|
<dkayiwa> lollllllllll Dawn is my cousin :D
|
09:37:39
|
<rafa> dkayiwa: ha! I didn't know. Nice :D
|
09:37:48
|
<dkayiwa> :)
|
09:38:46
|
<surangak> dkayiwa, I didnt know that either....
|
09:39:27
|
<dkayiwa> lolllllllllllllll
|
09:39:52
|
<dkayiwa> but please do not tell her :)
|
09:41:53
|
<rafa> dkayiwa: hahaha doesn't she know either?
|
09:42:43
|
<dkayiwa> no she does not :)
|
09:43:15
|
<rafa> that's cool :D
|
09:43:25
|
<dkayiwa> :D
|
09:46:36
|
*** darius_ has joined #openmrs
|
09:46:46
|
*** darius_ is now known as djazayeri
|
09:47:05
|
*** ChanServ sets mode: +o djazayeri
|
09:47:14
|
<djazayeri> rafa: sorry, internet went down
|
09:47:21
|
*** finbrein has quit IRC
|
09:47:23
|
<djazayeri> what was that ticket number
|
09:47:23
|
<djazayeri> ?
|
09:47:36
|
<rafa> !ticket TRUNK-2710
|
09:47:36
|
<djazayeri> UI-wise, it really needs to be one table.
|
09:47:37
|
<OpenMRSBot> rafa: [#TRUNK-2710] Create Encounters by Visit portlet - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2710
|
09:48:15
|
<djazayeri> can you do a UNION or something?
|
09:48:26
|
<rafa> djazayeri: union is not supported either
|
09:48:46
|
<rafa> djazayeri: I could do subselects but it might not perform very well
|
09:49:34
|
<djazayeri> rafa: there won't be a ton of visits/encounters for a single patient
|
09:49:55
|
<djazayeri> so ignore the performance worries for now.
|
09:50:06
|
<rafa> okay
|
09:54:54
|
<djazayeri> rafa: question from Lara who's sitting next to me about MDS. Since MDS 0.9 "ProgramWorkflow" doesn't show up in the list of exportable classes, and they aren't included in the export package.
|
09:55:29
|
<djazayeri> any idea why that could be?
|
09:55:35
|
<djazayeri> and how to fix it?
|
09:56:59
|
<rafa> djazayeri: I'm not sure why this happens. I promised to look into that, but I haven't found time yet.
|
09:57:47
|
<rafa> djazayeri: maybe today when I'm done with TRUNK-2710
|
10:00:08
|
<rafa> djazayeri: there's no way to save ProgramWorkflow alone so it's not displayed, but Program should be displayed
|
10:00:45
|
<rafa> djazayeri: but from what Lara says it doesn't include ProgramWorkflows for some reason
|
10:01:39
|
<djazayeri> rafa: okay, mark is looking into it now
|
10:01:47
|
<djazayeri> (he's sitting on the other side of me)
|
10:02:44
|
<rafa> haha you've got nice company all around :D
|
10:02:48
|
<djazayeri> rafa: could it be because there's no saveProgramWorkflow method in ProgramWorkflowService?
|
10:03:06
|
<rafa> yes, that's why it is not displayed
|
10:03:17
|
<rafa> but it should be saved with Program
|
10:03:34
|
<rafa> saveProgram
|
10:04:35
|
<djazayeri> rafa: i'll have them check whether the dependency gets exported or not. thanks
|
10:05:01
|
<djazayeri> once mark has a potential solution, he'll ask you if it's okay
|
10:05:42
|
<rafa> djazayeri: cool there's a ticket for that https://tickets.openmrs.org/browse/META-147
|
10:10:20
|
*** finbrein has joined #openmrs
|
10:29:30
|
*** djazayeri has quit IRC
|
10:43:24
|
*** darius_ has joined #openmrs
|
10:43:34
|
*** darius_ is now known as djazayeri
|
10:43:41
|
*** ChanServ sets mode: +o djazayeri
|
10:47:58
|
<dkayiwa> hi rafa
|
10:48:16
|
<rafa> hi
|
10:48:18
|
<dkayiwa> rafa: is TRUNK-1993 waiting only for review?
|
10:48:27
|
<rafa> !ticket trunk-1993
|
10:48:28
|
<OpenMRSBot> rafa: [#TRUNK-1993] UUID used by equals and hashCode in OpenmrsObject - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-1993
|
10:48:43
|
*** magoo_ has joined #openmrs
|
10:49:15
|
<rafa> dkayiwa: I think it is waiting for being committed
|
10:49:29
|
<dkayiwa> oh by who?
|
10:49:50
|
<rafa> ohh sorry this one is committed
|
10:50:01
|
<dkayiwa> yes thats what i also thought
|
10:50:13
|
<dkayiwa> rafa: do you think its ready to close?
|
10:51:05
|
<rafa> dkayiwa: yes, it's a painless change
|
10:51:27
|
<rafa> dkayiwa: the child ticket is more complex TRUNK-2362
|
10:51:54
|
<dkayiwa> ok
|
10:52:58
|
*** djazayeri has quit IRC
|
10:57:18
|
*** surangak has quit IRC
|
11:06:45
|
*** darius_ has joined #openmrs
|
11:07:08
|
*** darius_ is now known as djazayeri
|
11:07:16
|
*** ChanServ sets mode: +o djazayeri
|
11:15:56
|
*** james_regen has joined #openmrs
|
11:15:56
|
*** ChanServ sets mode: +v james_regen
|
11:20:56
|
*** bryq has joined #openmrs
|
11:20:56
|
*** ChanServ sets mode: +v bryq
|
11:25:05
|
*** magoo_ has quit IRC
|
11:25:36
|
*** djazayeri has quit IRC
|
11:26:12
|
*** upul` has left #openmrs
|
11:47:11
|
*** andtorg has quit IRC
|
12:16:12
|
*** andtorg has joined #openmrs
|
12:19:25
|
*** finbrein has quit IRC
|
12:28:16
|
*** pusakat has joined #openmrs
|
12:35:36
|
*** andtorg has quit IRC
|
12:38:50
|
*** wyclif has quit IRC
|
12:46:03
|
*** jriley has joined #openmrs
|
12:50:20
|
*** andtorg has joined #openmrs
|
12:56:18
|
*** pusakat has quit IRC
|
13:27:09
|
*** downeym has joined #openmrs
|
13:27:09
|
*** ChanServ sets mode: +o downeym
|
13:27:09
|
*** OpenMRSBot sets mode: +o downeym
|
13:29:14
|
*** wyclif has joined #openmrs
|
13:29:37
|
*** r0bby has joined #openmrs
|
13:29:37
|
*** ChanServ sets mode: +v r0bby
|
13:34:06
|
*** upul` has joined #openmrs
|
13:34:06
|
*** ChanServ sets mode: +v upul`
|
13:39:54
|
*** robbyoconnor has quit IRC
|
13:45:49
|
*** upul` has quit IRC
|
13:51:24
|
*** r0bby__ has joined #openmrs
|
13:51:24
|
*** ChanServ sets mode: +v r0bby__
|
13:51:36
|
*** r0bby__ has quit IRC
|
13:52:19
|
*** r0bby__ has joined #openmrs
|
13:52:19
|
*** ChanServ sets mode: +v r0bby__
|
13:54:08
|
*** r0bby has quit IRC
|
13:54:28
|
*** r0bby__ is now known as r0bby
|
14:01:46
|
*** andtorg has quit IRC
|
14:04:54
|
<rafa> dkayiwa: wyclif hey guys!
|
14:05:16
|
<dkayiwa> hey
|
14:06:33
|
<rafa> scrum or not yet?
|
14:06:56
|
<dkayiwa> yes we can. maybe wait for wyclif
|
14:07:50
|
<rafa> was the university call today?
|
14:08:48
|
<dkayiwa> was cancelled
|
14:10:08
|
<rafa> cool I thought it's still on and that's why others are missing
|
14:10:19
|
<wyclif> hey
|
14:10:25
|
<rafa> hey wyclif :)
|
14:10:53
|
<rafa> ready for take off?
|
14:10:55
|
<rafa> let's scrum
|
14:11:54
|
<rafa> dkayiwa: do your duty :D
|
14:12:10
|
<dkayiwa> rafa: you have already innitiated :)
|
14:12:22
|
<dkayiwa> you can start with your update
|
14:12:46
|
<rafa> *** Rafal ***
|
14:12:46
|
<rafa> Today:
|
14:12:46
|
<rafa> * Continued to work on TRUNK-2710: Create Encounters by Visit portlet
|
14:12:46
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2710 (finally got the logic right, now fighting with js and css to make it look cool)
|
14:12:46
|
<rafa> Tomorrow:
|
14:12:46
|
<rafa> * Will hopefully finish TRUNK-2710.
|
14:12:47
|
<rafa> * Move on to TRUNK-2711
|
14:12:47
|
<rafa> No blockers. (Blocked for a while due to Hibernate lacking full outer join and union, but managed to get similar effect with two queries)
|
14:13:40
|
<dkayiwa> !ticket trunk-2711
|
14:13:41
|
<OpenMRSBot> dkayiwa: [#TRUNK-2711] Change active visits in header - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2711
|
14:14:10
|
<dkayiwa> rafa did u do a union?
|
14:14:44
|
<rafa> dkayiwa: well not possible with hibernate, but I did some kind of union in java
|
14:14:57
|
<dkayiwa> ok
|
14:15:15
|
<rafa> dkayiwa: the problem was that I still wanted to use hibernate's iteration over results
|
14:15:25
|
<dkayiwa> oh i see
|
14:15:55
|
<rafa> dkayiwa: it was tricky and took me most of my day, but Darius insisted
|
14:16:02
|
<dkayiwa> lolllllll
|
14:16:03
|
<dkayiwa> :)
|
14:18:12
|
<dkayiwa> Closed some tickets
|
14:18:12
|
<dkayiwa> Done some code reviews
|
14:18:13
|
<dkayiwa> Done some application testing and created some new bug tickets
|
14:18:13
|
<dkayiwa> Pinged some devs about their pending tickets and reviews
|
14:18:13
|
<dkayiwa> Now continuing to work on my earlier tickets starting with: Ignore blank person addresses on the patient forms - TRUNK-2004
|
14:18:13
|
<dkayiwa> No Blockers
|
14:18:46
|
<rafa> !ticket TRUNK-2004
|
14:18:47
|
<OpenMRSBot> rafa: [#TRUNK-2004] Ignore blank person addresses on the patient forms - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2004
|
14:19:06
|
<dkayiwa> that one is a non essential ticket
|
14:19:22
|
<rafa> dkayiwa: yeah, why are you decided to work on that?
|
14:19:30
|
<dkayiwa> but its a new feature and i was told that all new features should be done before alpha
|
14:19:33
|
*** wyclif has quit IRC
|
14:19:44
|
<rafa> dkayiwa: ohh I see
|
14:19:44
|
*** wyclif has joined #openmrs
|
14:19:53
|
<dkayiwa> but i could be wrong :)
|
14:19:59
|
<dkayiwa> about having to work on it
|
14:20:07
|
<dkayiwa> just wanted your views :)
|
14:20:14
|
<rafa> dkayiwa: maybe we should get rid off blockers first at least ;)
|
14:20:23
|
<dkayiwa> ok
|
14:20:28
|
<dkayiwa> sounds nice
|
14:21:01
|
<dkayiwa> in that case i will chose a blocker and leave that in the meantime
|
14:21:15
|
<dkayiwa> though it will increase my threading from 4 to 5 :)
|
14:21:28
|
<dkayiwa> multiple threading
|
14:21:39
|
<rafa> haha
|
14:22:46
|
<rafa> dkayiwa: By chance did you have a look at http://notes.openmrs.org/Testing-Feedback?
|
14:23:15
|
<dkayiwa> thanks for the reminder
|
14:23:32
|
<dkayiwa> looked at it some time back. but i think i now need to look again
|
14:23:43
|
<rafa> dkayiwa: I think not all is covered with tickets yet
|
14:23:56
|
<dkayiwa> ok
|
14:24:17
|
<dkayiwa> by the way, all formentry module dont work with 1.9
|
14:24:26
|
<dkayiwa> as in the cannot submit forms
|
14:24:39
|
<dkayiwa> because of the provider change
|
14:24:47
|
<rafa> hmm I had no problems using htmlformentry lately
|
14:25:09
|
<dkayiwa> rafa, were you able to submit a form? and when was that?
|
14:25:30
|
<rafa> dkayiwa: I can test right now
|
14:25:36
|
<dkayiwa> please do
|
14:25:44
|
<dkayiwa> that will help sort me out
|
14:25:53
|
<dkayiwa> because i failed and only got errors
|
14:26:12
|
<dkayiwa> thanks in advance :)
|
14:28:07
|
<rafa> dkayiwa: worked but with some problems
|
14:28:16
|
<dkayiwa> which problems?
|
14:28:24
|
<rafa> dkayiwa: I needed to remove all visits before it worked
|
14:28:30
|
<dkayiwa> oh
|
14:28:45
|
<rafa> dkayiwa: I got an exception saying that an encounter must be within visit start and end time
|
14:28:46
|
<dkayiwa> which user did you chose as provider?
|
14:29:00
|
<dkayiwa> did you try super user?
|
14:29:01
|
<rafa> dkayiwa: I got super user
|
14:29:20
|
<dkayiwa> are you working on current trunk?
|
14:29:25
|
<rafa> dkayiwa: yes
|
14:29:30
|
<rafa> dkayiwa: what exception do you get?
|
14:29:38
|
<rafa> dkayiwa: maybe I had that one but I resolved it
|
14:29:42
|
<rafa> I don't remember
|
14:29:46
|
<dkayiwa> let me show you the ticket number
|
14:31:51
|
<dkayiwa> TRUNK-2716
|
14:32:07
|
<rafa> !ticket TRUNK-2716
|
14:32:08
|
<OpenMRSBot> rafa: [#TRUNK-2716] Cannot submit an encounter form - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2716
|
14:32:35
|
<dkayiwa> maybe wyclif fixed it :)
|
14:33:28
|
<rafa> it says committed
|
14:34:06
|
<wyclif> made a partial fix to unblick you
|
14:34:14
|
<wyclif> we need to redo the add/remove providers
|
14:34:42
|
<wyclif> the ajax staff doesn't work for new encounter since it has no id
|
14:34:44
|
<dkayiwa> wyclif: did u just remove the validation?
|
14:35:10
|
<wyclif> i had to remove it because that was based on the old form which had a provider field
|
14:35:31
|
<wyclif> now we have to do it differently, so i will have to add it back
|
14:35:47
|
<dkayiwa> ok
|
14:36:07
|
<wyclif> i just wanted to remove the blocker, and i was waiting for more info if other devs agreed to my view
|
14:36:33
|
<dkayiwa> wyclif: Ben said that trunk had no problem
|
14:36:39
|
<wyclif> i.e it should be on form submission like the visit page is now
|
14:36:48
|
<dkayiwa> he instead say problem is with modules
|
14:37:00
|
<rafa> wyclif: Is it a different ticket?
|
14:37:03
|
<wyclif> which ticket are talking about?
|
14:37:10
|
<dkayiwa> sending user or person id instead o provider_id
|
14:37:26
|
<dkayiwa> TRUNK-2716
|
14:38:11
|
<dkayiwa> wyclif: are we discussing the same ticket? :)
|
14:38:16
|
<wyclif> either way, we have to change it to confirm to the new style of multiple providers
|
14:38:45
|
<dkayiwa> ok
|
14:39:04
|
<wyclif> these encounter form tickets are related
|
14:39:31
|
<wyclif> their problems revolve around the fact that we changed to multiple providers
|
14:39:53
|
<wyclif> so fixing how to add/remove encounters will all of them
|
14:40:08
|
<dkayiwa> ok
|
14:40:35
|
<wyclif> except TRUNK-2715
|
14:41:08
|
<dkayiwa> !ticket TRUNK-2715
|
14:41:09
|
<OpenMRSBot> dkayiwa: [#TRUNK-2715] Cannot duplicate Basic Form - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2715
|
14:41:50
|
<dkayiwa> wyclif: do you have any idea on what is messing up TRUNK-2715?
|
14:44:20
|
<wyclif> yes
|
14:45:03
|
<wyclif> it is a clash between the objectsavehandler and the getters/setters for xslt and template in Form
|
14:45:21
|
<dkayiwa> ohhhhh
|
14:45:54
|
<wyclif> there is some kind of strange API logic baked in the getters/setters which i think was bad but probably there was no option
|
14:46:03
|
<dkayiwa> ok
|
14:46:35
|
<wyclif> am still tryin gto find a work around
|
14:46:42
|
<dkayiwa> ok
|
14:46:52
|
<dkayiwa> good detective work :)
|
14:47:44
|
<wyclif> so as the handler tries to do its thing on the string for xslt and template, it blows up
|
14:47:56
|
<dkayiwa> oh now i seeee
|
14:48:00
|
<wyclif> let em give my scrum report
|
14:48:05
|
<dkayiwa> cool
|
14:48:44
|
<wyclif> yesterday:
|
14:48:44
|
<wyclif> TRUNK-2712 - Encounter form is broken(This still requires more work)
|
14:48:44
|
<wyclif> TRUNK-2716 - Cannot submit an encounter form
|
14:48:44
|
<wyclif> TRUNK-2715 - Cannot duplicate Basic Form(Dug into it but not resolved yet)
|
14:48:44
|
<wyclif> today:
|
14:48:45
|
<wyclif> - TRUNK-2712 - Encounter form is broken - we need to chanage adding/removing providers from being ajax based
|
14:48:48
|
<wyclif> - Complete TRUNK-2715 - Cannot duplicate Basic Form, this duplicates - TRUNK-2718
|
14:48:50
|
<wyclif> - other Sprint tickets
|
14:48:52
|
<wyclif> no blockers
|
14:49:45
|
<dkayiwa> ok
|
14:50:49
|
<dkayiwa> by the way wyclif about the other ticket of more than one user running the setup wizard
|
14:51:09
|
<wyclif> it might be a pain to deal with xslt/template worse case, i wil add those annotations for the fields
|
14:51:13
|
<dkayiwa> wyclif: i sort of failed to understand how i should test it
|
14:51:47
|
<wyclif> just run the wizard in separate windows
|
14:52:20
|
<wyclif> i.e start it in one and see if you trying to start it again in another, you get the message saying it is already running and you see the progress
|
14:52:40
|
<dkayiwa> wyclif: i think adding the AllowEmptyStrings annotation will be the quckest fix
|
14:53:11
|
<dkayiwa> wyclif: i tried that and the second window just shows the same progress as the first
|
14:53:18
|
<wyclif> yead, because xslt and templates are not your ordinary string properties, they are now associations
|
14:53:27
|
<dkayiwa> ok
|
14:53:48
|
<wyclif> that they are now form resources that are referenced from the form and not string fields
|
14:54:20
|
<wyclif> so the handler sees the getters/setters and thinks it can operate on them
|
14:54:44
|
<dkayiwa> yes thats correct
|
14:56:13
|
<dkayiwa> wyclif: about multiple installer windows
|
14:56:49
|
<dkayiwa> at what wizard step should they give error message wyclif
|
14:58:28
|
<dkayiwa> wyclif: or should i leave you to be the one to test it?
|
15:02:23
|
<wyclif> hey
|
15:02:29
|
<dkayiwa> hey
|
15:02:33
|
<wyclif> dkayiwa, sorry for the delay
|
15:02:37
|
<dkayiwa> ok
|
15:03:04
|
<dkayiwa> wyclif: at what wizard step should they give error message
|
15:03:25
|
<wyclif> the correct behaviour should be that which ever page you visit in the init wizard, should redirect you to the progress page with an informative message that someone else already started it
|
15:03:58
|
<wyclif> unless it is not yet started by anyone else
|
15:04:21
|
<dkayiwa> wyclif: that does not happen for me
|
15:04:46
|
<dkayiwa> wyclif: am on the page Which type of installation do you want?
|
15:04:56
|
<wyclif> the last time i tested it, i ran into the same problem, so i think it stil needs work
|
15:05:34
|
<dkayiwa> wyclif: and no error message is shown on the first setup page
|
15:05:41
|
*** darius has joined #openmrs
|
15:05:54
|
<wyclif> i recall reviewing the code and something didnt seem right in the patch
|
15:05:55
|
<downeym> Hi darius and welcome to the #openmrs IRC channel.
|
15:06:10
|
<dkayiwa> wyclif: and yet i have many setup page windows open
|
15:06:25
|
<wyclif> well, probably mark it as rework needed
|
15:06:27
|
*** darius is now known as djazayeri
|
15:06:32
|
<wyclif> will look at it
|
15:06:35
|
*** ChanServ sets mode: +o djazayeri
|
15:06:43
|
<dkayiwa> ok
|
15:07:41
|
<wyclif> dkayiwa, the problem a gsoc student did that and i doubt if he is still available, so we might have to make it work
|
15:07:51
|
<dkayiwa> ok
|
15:08:03
|
<dkayiwa> wyclif: should we unassign him
|
15:09:00
|
<djazayeri> which ticket is that?
|
15:09:11
|
<wyclif> he hangs around sometimes, i would say yes, but add a comment asking him if he still wants to work on it
|
15:09:35
|
<dkayiwa> ok thanks
|
15:10:03
|
<dkayiwa> wyclif: do u remember that ticket number? :)
|
15:10:06
|
<djazayeri> dkayiwa: do you know the ticket number for the issue about deleting a regimen group -> deletes the patient?
|
15:10:10
|
*** r0bby__ has joined #openmrs
|
15:10:10
|
*** ChanServ sets mode: +v r0bby__
|
15:10:20
|
<dkayiwa> djazayeri: no
|
15:10:51
|
<djazayeri> In case that ticket doesn't say to backport to 1.6, 1.7, and 1.8, we should add that
|
15:12:42
|
<r0bby__> hai
|
15:13:36
|
*** r0bby has quit IRC
|
15:14:05
|
<dkayiwa> djazayeri: did you mean TRUNK-2674 ?
|
15:16:13
|
<djazayeri> dkayiwa: don't know, takes forever to load
|
15:16:16
|
<djazayeri> !ticket TRUNK-2674
|
15:16:17
|
<OpenMRSBot> djazayeri: [#TRUNK-2674] Patient is unintentionally deleted while replacing his/her drug regimen from the regimen tab of the dashboard - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2674
|
15:16:41
|
<djazayeri> dkayiwa: yes, that one.
|
15:17:38
|
<dkayiwa> djazayeri: is needs backporting
|
15:17:44
|
<dkayiwa> is=it
|
15:19:43
|
*** r0bby__ has quit IRC
|
15:20:53
|
<dkayiwa> so djazayeri should i still add it?
|
15:23:12
|
*** djazayeri has quit IRC
|
15:27:36
|
*** r0bby has joined #openmrs
|
15:27:36
|
*** ChanServ sets mode: +v r0bby
|
15:29:03
|
*** r0bby__ has joined #openmrs
|
15:29:03
|
*** ChanServ sets mode: +v r0bby__
|
15:32:31
|
*** r0bby has quit IRC
|
15:36:32
|
*** bryq has quit IRC
|
15:43:15
|
*** muthah has quit IRC
|
15:51:39
|
*** dkayiwa has quit IRC
|
16:00:41
|
*** rafa has quit IRC
|
16:00:44
|
*** r0bby__ has quit IRC
|
16:03:47
|
*** dkayiwa has joined #openmrs
|
16:04:44
|
*** jriley has quit IRC
|
16:08:04
|
*** downeym has quit IRC
|
16:11:55
|
*** darius has joined #openmrs
|
16:12:14
|
*** darius is now known as djazayeri
|
16:12:22
|
*** ChanServ sets mode: +o djazayeri
|
16:35:35
|
*** goutham has joined #openmrs
|
16:46:55
|
*** wyclif has quit IRC
|
16:47:54
|
*** wyclif has joined #openmrs
|
17:11:48
|
<wyclif> djazayeri, dkayiwa do we still that dojo stuff on the encounter form?
|
17:11:52
|
<wyclif> need
|
17:12:04
|
<wyclif> i plan to remove it
|
17:12:22
|
<dkayiwa> i would second it
|
17:13:17
|
<djazayeri> wyclif: what dojo stuff?
|
17:13:31
|
<djazayeri> If there's dojo that can be replaced by jquery, do that.
|
17:16:04
|
<wyclif> i will
|
17:22:01
|
*** bryq has joined #openmrs
|
17:22:01
|
*** ChanServ sets mode: +v bryq
|
17:22:47
|
*** andtorg has joined #openmrs
|
17:23:47
|
*** r0bby has joined #openmrs
|
17:23:47
|
*** ChanServ sets mode: +v r0bby
|
17:28:14
|
*** andtorg has joined #openmrs
|
17:56:22
|
*** Suranga has joined #openmrs
|
17:57:00
|
*** rafa has joined #openmrs
|
17:57:00
|
*** ChanServ sets mode: +v rafa
|
17:59:10
|
<Suranga> james_regen, helllo...
|
17:59:20
|
<Suranga> james_regen, r u there ? :-)
|
18:00:31
|
<james_regen> hi Suranga i'm here
|
18:00:48
|
<Suranga> james_regen, afraid I dont have much to report back today
|
18:01:06
|
<Suranga> james_regen, I did up the wiki page with the algorithem
|
18:02:02
|
<Suranga> james_regen, and worked on the MIS scoring a bit... Right now im up to the part where I can generate pairwise column results
|
18:02:25
|
<Suranga> james_regen, and spent the rest of day running about getting ready for the flight ...
|
18:03:04
|
<james_regen> that sounds like good progress. are things making sense as far as the code? i'll have to defer questions about math until shaun gets back, probably
|
18:03:46
|
<Suranga> james_regen, I'm hunting up some math happy friends too
|
18:04:45
|
<Suranga> james_regen, so far I did not get hit by any problems in the code... things seem ok...
|
18:05:01
|
<james_regen> that's good. when are you travelling?
|
18:06:11
|
<Suranga> Sunday morning
|
18:06:18
|
<Suranga> will get there by nightfall...
|
18:06:28
|
<Suranga> I think Dr. Shaun will be there at Kigali...
|
18:09:24
|
<james_regen> i didn't know that. i know things might get busy before travelling, so it won't be a problem if it gets more difficult to find time to code tomorrow or Friday. i'll still be here to answer any questions, though
|
18:11:36
|
<james_regen> i'll be on holiday october 24th to 28th, though, and won't be responding to emails or IRC that week. i'll try to help as much as i can the next 2.5 weeks
|
18:12:47
|
<Suranga> james_regen, sure, no problem
|
18:13:01
|
<Suranga> james_regen, james_regen, Im hoping to get my classs etc. sketched out as soon as possible... (preferably before I leave)
|
18:13:23
|
<Suranga> james_regen, I will try pinging Dr. Shaun while you are away...
|
18:14:27
|
<james_regen> ok
|
18:16:42
|
<Suranga> james_regen, did you have a look at my wiki page ? In addition to the math, ive tried to explain how Im finding the matches....
|
18:17:01
|
*** bwolfe has joined #openmrs
|
18:17:01
|
*** ChanServ sets mode: +o bwolfe
|
18:19:57
|
<james_regen> i've looked at it quickly. after the example data, it gives "Occurrences (John,male) = 5" i'm not seeing where the 5 came from
|
18:20:48
|
<james_regen> oh, maybe it's not supposed to be directly from the table.
|
18:21:35
|
*** andtorg has quit IRC
|
18:22:38
|
<Suranga> james_regen, you're right
|
18:22:56
|
<Suranga> james_regen, I gave those two values as an example to better explain my point
|
18:23:42
|
<Suranga> james_regen, Im not sure if 'my idea' is 'pretty stupid', 'stupid' or just 'mildly misguided' :-)
|
18:25:15
|
<james_regen> my guess is that we'll need to include the frequencies for (John, female) also
|
18:25:22
|
*** chughgaurav has joined #openmrs
|
18:26:49
|
<Suranga> james_regen, mmm
|
18:26:52
|
<james_regen> Suranga: i would think that (John,M)=5 and (John,F)=1 is different than just (John,M) = 4, and (John,M)=3, (John,F) = 1 is different from (John,M)=4, (John,F)=3
|
18:28:02
|
<Suranga> james_regen, sorry, didnt really understand you there, im afraid :-(
|
18:28:38
|
<james_regen> i would think the math would take frequencies of all combinations when calculating it's result. the wiki page makes it seem like we'll be reducing or simplifying the frequencies before we hand it over to MI
|
18:29:39
|
<Suranga> james_regen, ah, so u r meaning that we should not reject any data as 'noise' as I have done
|
18:30:15
|
<Suranga> basically, u mean that we must consider all possible frequency combinations ?
|
18:30:27
|
<james_regen> Suranga: yeah. i wouldn't want to do that without making sure that's what's needed, and i'm not that sure
|
18:31:45
|
<james_regen> Suranga: maybe. or at least, all the ones we observe. if it's noise, then MI will hopefully let us know, and hopefully give us a number of how noisy it is
|
18:32:48
|
<Suranga> james_regen, let me write up your idea, once its on paper, I gues it'll be easier to comtemplate on... :-)
|
18:34:07
|
<james_regen> Suranga: ok. and i'm also ignorant of the math and the details, so i might be mistaken, too.
|
18:38:06
|
<Suranga> james_regen, I will talk to Dr. Grannis once he returns..
|
18:38:29
|
<Suranga> james_regen, any idea when he is returning ?
|
18:40:36
|
<james_regen> Suranga: not sure. if he's going to kigali, that's next week, right? if so, then you might see him before i do. i'm sure he'll be more responsive to email next week, though
|
18:40:58
|
<Suranga> james_regen, Sorry, thats my mistake, looks like hes not comming
|
18:41:15
|
<Suranga> james_regen, he's not on the participants list https://wiki.openmrs.org/display/RES/2011+Implementers+Meeting+Participants
|
18:41:15
|
<OpenMRSBot> <http://ln-s.net/9CUR> (at wiki.openmrs.org)
|
18:43:06
|
<james_regen> Suranga: hopefully he'll be back monday
|
18:45:05
|
<Suranga> james_regen, Dawn says Dr. Grannis will be at Kigali, so I'll be meeting him first :-)
|
18:46:41
|
<james_regen> great. he should be able to spend a lot of time talking about patient matching if you and he have the time
|
18:47:58
|
<Suranga> james_regen, I may give him a hard time with it... :-D
|
19:03:14
|
*** downeym has joined #openmrs
|
19:03:14
|
*** ChanServ sets mode: +o downeym
|
19:03:14
|
*** OpenMRSBot sets mode: +o downeym
|
19:19:17
|
*** bwolfe_ has joined #openmrs
|
19:19:17
|
*** ChanServ sets mode: +o bwolfe_
|
19:22:47
|
*** bwolfe has quit IRC
|
19:49:13
|
*** andtorg has joined #openmrs
|
19:53:02
|
*** elliott_w has joined #openmrs
|
19:53:02
|
*** ChanServ sets mode: +o elliott_w
|
19:59:08
|
*** finbrein has joined #openmrs
|
19:59:38
|
*** james_regen has quit IRC
|
19:59:48
|
*** finbrein has quit IRC
|
20:00:00
|
*** finbrein has joined #openmrs
|
20:02:38
|
*** Suranga has quit IRC
|
20:37:26
|
*** goutham has quit IRC
|
20:41:21
|
*** elliott_w has quit IRC
|
20:43:01
|
*** finbrein has quit IRC
|
21:09:25
|
*** wyclif has quit IRC
|
21:14:51
|
*** elliott_w has joined #openmrs
|
21:14:51
|
*** ChanServ sets mode: +o elliott_w
|
21:16:04
|
*** dkayiwa has quit IRC
|
21:18:07
|
*** bwolfe_ has quit IRC
|
21:19:12
|
*** r0bby has quit IRC
|
21:19:47
|
*** bryq has quit IRC
|
21:22:09
|
*** downeym has quit IRC
|
21:25:55
|
*** r0bby has joined #openmrs
|
21:25:55
|
*** ChanServ sets mode: +v r0bby
|
21:54:50
|
*** r0bby is now known as robbyoconnor
|
21:59:45
|
*** andtorg has quit IRC
|
22:00:14
|
*** andtorg has joined #openmrs
|
22:01:11
|
*** andtorg has quit IRC
|
22:06:23
|
*** rafa has quit IRC
|
22:17:59
|
*** elliott_w has quit IRC
|
23:01:54
|
*** r0bby__ has joined #openmrs
|
23:01:54
|
*** ChanServ sets mode: +v r0bby__
|
23:05:10
|
*** robbyoconnor has quit IRC
|
23:07:24
|
*** djazayeri has quit IRC
|
23:07:59
|
*** r0bby__ has quit IRC
|
23:11:57
|
*** chughgaurav has quit IRC
|
23:23:34
|
*** nickwilkie has joined #openmrs
|
23:27:10
|
*** jriley has joined #openmrs
|
23:28:43
|
*** jriley has quit IRC
|
23:34:52
|
*** finbrein has joined #openmrs
|
23:57:04
|
*** burke has joined #openmrs
|
23:57:04
|
*** ChanServ sets mode: +o burke
|