IRC Chat : 2011-09-27 - OpenMRS

00:10:05 *** dkayiwa has joined #openmrs
00:23:55 *** r0bby has joined #openmrs
00:23:55 *** ChanServ sets mode: +v r0bby
00:31:51 *** r0bby__ has joined #openmrs
00:31:51 *** ChanServ sets mode: +v r0bby__
00:32:16 *** r0bby has quit IRC
00:36:01 *** r0bby__ has quit IRC
00:37:24 *** r0bby__ has joined #openmrs
00:37:24 *** ChanServ sets mode: +v r0bby__
00:37:41 *** dkayiwa has quit IRC
00:53:00 *** r0bby__ has quit IRC
01:04:47 *** r0bby has joined #openmrs
01:04:59 *** ChanServ sets mode: +v r0bby
01:19:06 *** gbastien has quit IRC
01:25:29 *** lh has quit IRC
01:32:59 *** chopin has joined #openmrs
01:32:59 *** ChanServ sets mode: +v chopin
01:54:18 *** downeym has joined #openmrs
01:54:18 *** OpenMRSBot sets mode: +o downeym
01:54:18 *** ChanServ sets mode: +o downeym
02:03:58 *** jwishnie has quit IRC
02:10:42 *** robbyoconnor has joined #openmrs
02:10:42 *** ChanServ sets mode: +v robbyoconnor
02:56:27 *** upul` has joined #openmrs
02:56:27 *** ChanServ sets mode: +v upul`
02:56:37 *** downeym has quit IRC
03:11:20 *** jwishnie has joined #openmrs
03:31:20 *** jriley_ has joined #openmrs
03:34:15 *** jriley has quit IRC
03:34:15 *** jriley_ is now known as jriley
03:46:52 *** Mkop1 has joined #openmrs
03:46:53 *** ChanServ sets mode: +v Mkop1
03:52:57 *** chopin has quit IRC
03:56:09 *** jwishnie has quit IRC
03:59:24 *** r0bby has quit IRC
04:12:45 *** chopin has joined #openmrs
04:12:45 *** ChanServ sets mode: +v chopin
04:31:56 *** Mkop1 has quit IRC
04:38:50 *** chopin has quit IRC
05:01:16 *** surangak has joined #openmrs
05:04:07 <surangak> surangak, prods djazayeri
05:04:15 <surangak> djazayeri, hi, r u really here ?
05:17:26 <djazayeri> surangak: here
05:17:35 <surangak> djazayeri, :)
05:17:46 <surangak> djazayeri, so the good news is that i'll be seeing you soon !
05:17:54 <surangak> comming to Kigaliiiiiiiiii
05:18:16 <surangak> I'll have to cough up half the cash, but im comming !
05:21:26 <surangak> djazayeri, I see that you've been doing a lot of work refactoring your attribues
05:21:42 <surangak> djazayeri, I've been keeping tabs
05:22:01 <djazayeri> surangak: cool!
05:22:01 <surangak> djazayeri, these days i've started work on another module, - patientMatching
05:22:18 <surangak> djazayeri, so we will alll finally meet
05:22:27 <djazayeri> I noticed you asked about that module
05:22:43 <surangak> djazayeri, I'm going to do some work for Dr. Grannis :-)
05:22:54 <surangak> djazayeri, hopefully it will go well..
05:23:11 <djazayeri> cool
05:23:20 <djazayeri> That's one module I hope to see more people using someday.
05:24:21 <surangak> djazayeri, we'll be adding some new stuff to improve on it...
05:24:48 <surangak> but I'll keep tabs on the attributes, and pick up once everyone agrees on the best design :-)
05:25:33 <djazayeri> Should happen soon! Time is running short for us to decide. :-)
05:25:36 <djazayeri> okay, gotta run now
05:25:37 <djazayeri> gnight
05:25:42 <djazayeri> (or good day)
05:26:05 <surangak> djazayeri, good night Darius.. :p
05:29:43 <robbyoconnor> surangak: are you in africa?
05:29:57 <surangak> hi robbyoconnor nopz, im in asia
05:30:06 <robbyoconnor> surangak: how are you funding this?!
05:30:09 <robbyoconnor> it's mega expensive
05:30:11 <robbyoconnor> :/
05:30:19 <surangak> robbyoconnor, gsoc funds :D
05:30:31 <robbyoconnor> jesus
05:32:19 <robbyoconnor> djazayeri: With the snags you guys hit...and the fact I'd literally have to be exposed to a zillion things for vaccinations...I don't think I can swing it :/
05:32:31 <robbyoconnor> Should I withdraw?
05:32:34 * robbyoconnor is unsure :(
05:33:12 <surangak> robbyoconnor, r u comming too ?
05:34:00 <robbyoconnor> I was hoping to
05:34:10 <robbyoconnor> but the fact they waited so long to decide and hit the snags they did
05:34:16 <robbyoconnor> I can't afford travel expenses
05:34:45 <robbyoconnor> if they decide on Friday
05:34:57 <robbyoconnor> I'd be in Africa in a week
05:35:22 <robbyoconnor> and that's not enough time to get all the vaccinations and shit...
05:36:01 <robbyoconnor> I'm kinda curious if I would've been selected -- so part of me wants to just stay in
05:36:10 <robbyoconnor> and pending the timing
05:36:10 <surangak> oh, I see
05:36:17 <surangak> robbyoconnor, I dont even have a visa yet
05:36:30 <robbyoconnor> better hurry up LOL
05:36:33 <surangak> robbyoconnor, I will hav to work reeeeeeeeely fast :D
05:37:09 * robbyoconnor sighs
05:44:13 <surangak> robbyoconnor, Im sure everyone will love to have capn'RObby around !
05:44:42 <robbyoconnor> heh I'd love to go
05:44:49 <robbyoconnor> http://wwwnc.cdc.gov/travel/destinations/rwanda.htm
05:44:54 <robbyoconnor> That's what I have to get
05:44:57 <OpenMRSBot> <http://ln-s.net/9BUI> (at wwwnc.cdc.gov)
05:45:00 <robbyoconnor> a week isn't enough time
05:45:05 <robbyoconnor> I don't think
05:45:16 <robbyoconnor> I seeked paul/burke's advice
05:45:20 <robbyoconnor> no answer :
05:45:22 <robbyoconnor> :|
05:45:35 <surangak> robbyoconnor, OMG all these ?
05:45:47 <surangak> robbyoconnor, the disadvantates of living in a developed country :-)
05:48:23 <robbyoconnor> surangak: yeh
05:48:34 <robbyoconnor> I'd prefer to live
05:48:41 <robbyoconnor> and not die when i come home
05:48:54 <robbyoconnor> plus i'm slightly sick right now
05:49:36 <surangak> robbyoconnor, there's a very limited chance of getting these illnessess robbie
05:49:55 <surangak> i think they may have similar directives for sri lanka, and look, we're fine :-)
05:50:07 <robbyoconnor> heh
05:50:10 <robbyoconnor> malaria?
05:50:20 <robbyoconnor> Yellow Fever is required tho
05:50:25 <surangak> robbyoconnor, noooo wayy
05:50:28 <robbyoconnor> apparently
05:50:34 <robbyoconnor> look at it
05:50:46 <robbyoconnor> it kinda has cross over tho >= 9 months
05:50:56 <surangak> we only have occasional Dengue.. and thats very rareeeee
05:50:59 <robbyoconnor> ALSO crosses over >= 1 year
05:51:01 <robbyoconnor> LOL
05:51:25 <robbyoconnor> so one could read that as optional
05:51:49 <robbyoconnor> djazayeri: leave my app in sorry to annoy you
05:51:51 <robbyoconnor> Have fun!
05:51:54 <robbyoconnor> working
05:52:26 <robbyoconnor> surangak: I like living in a 1st world country :P
05:52:44 <robbyoconnor> I made a joke w/ some indian gsoc students I met in lisbon
05:52:52 <robbyoconnor> 2.5 world country :P
05:52:55 <robbyoconnor> ^^ india LOL
05:53:12 <surangak> robbyoconnor, I hope they didnt kill you :D
05:53:21 <surangak> indians == very patriotic :D
05:53:23 <robbyoconnor> no they didn't LOL
05:53:39 <robbyoconnor> they knew me LOL
05:54:58 <surangak> robbyoconnor, where do u rank sri lanka ?
05:55:48 *** goutham has joined #openmrs
05:56:50 <robbyoconnor> IIRC upul` is from there too
05:56:57 <robbyoconnor> so I'd have TWO people gang up on me :P
05:57:33 <robbyoconnor> no comemnt
05:57:39 <robbyoconnor> if I go I don't want you to kill me
05:57:43 <robbyoconnor> :P
06:00:29 <robbyoconnor> ...something tells me I won't be going -- if they're having funding issues -- they're gonna go with the cheapest and I'm FAR from cheap to fund
06:00:43 <robbyoconnor> maybe next year
06:00:51 <robbyoconnor> but there's still hope
06:57:25 *** jriley has quit IRC
07:01:24 *** rafa has joined #openmrs
07:01:24 *** ChanServ sets mode: +v rafa
07:03:59 *** jriley has joined #openmrs
07:28:50 *** andtorg has joined #openmrs
07:42:04 *** dkayiwa has joined #openmrs
08:16:28 *** goutham has quit IRC
08:24:27 *** bryq has joined #openmrs
08:24:27 *** ChanServ sets mode: +v bryq
08:39:24 <surangak> dkayiwa, helloo Daniel
08:39:30 <surangak> I aammmmmmmm cominngggggggggggggggg
08:39:38 <dkayiwa> hahahhahhhhhhhhhaaaa
08:39:44 <dkayiwa> Praise God!!!!
08:39:45 <surangak> to Kigaliiiiiiiii
08:39:52 <dkayiwa> AM so so so so happy for you!!!!
08:39:59 <surangak> :D
08:40:00 <dkayiwa> Just cant wait to meet you men!!!!!
08:40:04 <dkayiwa> :D
08:40:09 <surangak> so we will all be finally meeting
08:40:15 <dkayiwa> oh yes!!!!!
08:40:15 <surangak> after one year !
08:40:19 <dkayiwa> hahahahahah
08:40:29 <dkayiwa> not one year, but a full year :)
08:40:32 <surangak> dkayiwa, just applied for my passport :D
08:40:48 <dkayiwa> oh thats great do it quickly :)
08:54:33 *** sunbiz has joined #openmrs
08:54:33 *** ChanServ sets mode: +v sunbiz
09:19:45 *** bwolfe has joined #openmrs
09:20:27 *** ChanServ sets mode: +o bwolfe
09:24:36 <surangak> helo bwolfe
09:24:42 <bwolfe> yo
09:24:43 <surangak> bwolfe, Im comming to Kigaliiiiiii
09:24:52 <surangak> yayyyyyyyyyyyy
09:24:55 <bwolfe> I saw your tweet.
09:25:04 <bwolfe> and I hope you know Kigali only has one i. ;-) :-D
09:25:13 <surangak> bwolfe, :D
09:25:15 <bwolfe> are you boooked already?
09:25:18 <bwolfe> *booked
09:25:22 <surangak> i've also realized I dont have a passport
09:25:31 <surangak> bwolfe, I can get one quickly :D
09:25:35 <surangak> need to book
09:25:46 <bwolfe> coming from India?
09:26:05 <surangak> I think so, there are no Air france or KLM flights from Sri Lanka
09:26:06 <surangak> :(
09:26:16 <surangak> bwolfe, did u book yet ?
09:26:22 <bwolfe> suranga, are you coming in early for the hackathon? We'll be getting there on saturday noon
09:26:35 <bwolfe> I don't book. I have people book things for me. :-D
09:26:42 <bwolfe> (but yes, they have booked my flights already)
09:27:01 <surangak> bwolfe, Im not very sure, managing flights is gioing to be a major problem to me :P
09:27:10 <surangak> I'll try to make it .. :-)
09:27:16 <bwolfe> have you flown before?
09:27:27 <surangak> bwolfe, dont tell anybody, but no
09:27:32 <surangak> :-(
09:27:36 <bwolfe> if you try to come early let djazayeri or someone know. I'm not sure how they are managing hotel rooms for hte hackathon
09:27:40 <bwolfe> oooo, fun!
09:27:45 <bwolfe> your first flight and its a long one!
09:27:50 <surangak> bwolfe, :D
09:27:52 <bwolfe> (or series of long ones)
09:28:06 <surangak> I hope I dont get air plane sick :D
09:28:30 <bwolfe> meh, people only get sick on planes when they get scared. they aren't that upsetting to the stomach (not like ships)
09:28:35 <jriley> bwolfe, will the hackathon still be going on Monday?
09:28:44 <bwolfe> jriley, yeah, sat/sun/mon for sure
09:28:55 <jriley> sweet :)
09:28:57 <bwolfe> jriley, when do you arrive?
09:29:11 <jriley> bwolfe, I should stagger off the plane around 5PM sunday
09:29:31 <bwolfe> surangak, we fly from NBO to Kigali on Saturday morning at 830 on Kenya Airways
09:29:46 <bwolfe> jriley, fun. you're coming from where? AKA: how jet lagged will you be?
09:29:53 <surangak> bwolfe, arnt we supposed to use AIr frnce or KLM ?
09:29:59 <jriley> bwolfe - Cambodia . Six hours ahead, I think
09:30:07 <jriley> So I'll be ready to start REALLY REALLY EARLY on Monday
09:30:09 <surangak> or can we use the cheapest that we can find ?:-)
09:30:13 <jriley> "Hey, guys! Guys, wake up! ... guys?"
09:30:20 <jriley> "Bueller? Anyone?"
09:30:23 <bwolfe> thats not too bad. you'll be ready to crash and then be awake by 9am for some hacking!
09:30:35 <jriley> I'll be awake at 3AM :)
09:30:54 <bwolfe> surangak, yeah, use the cheapest you find. Kenya Airwyas is the cheapest from Kenya to Rwanda
09:30:59 <bwolfe> jriley, thats not so much fun. :-p
09:31:06 <jriley> I found good prices through skyscanner
09:31:11 <jriley> and also .. looking it up...
09:31:17 <bwolfe> jriley, I'll leave tickets out for you to hack on so you don't bug me at 3am :-D
09:31:35 <bwolfe> surangak, I like both KLM and Air France. both are good options
09:31:59 <surangak> bwolfe, are they the cheapest ? i'll be spending some GSoc money on the flights :P
09:32:07 <jriley> bwolfe, I try to keep my circadian clock problems to myself
09:32:21 <bwolfe> surangak, be sure to sign up for a Frequent Flyer number on whichever one you fly on. then be sure your tickets have that FF # on it before you fly. its free and you might use the miles later.
09:32:35 <bwolfe> surangak, use the site jriley pointed you to
09:32:42 <bwolfe> or kayak.com maybe
09:32:44 <jriley> Ah, I found a good fare on momondo.com . Couldn't get anything decent from KLF
09:32:48 <jriley> in fact, couldn't get their site to work
09:33:13 <bwolfe> definitely DO NOT buy directly from the airlines. they are usually the most expensive!
09:33:17 <jriley> Skyscanner worked out better than kayak. Skyscanner pulled up something else, which redirected me to momondo, which was much cheaper than the others I saw
09:34:23 <bwolfe> sounds like momondo is a winner then
09:48:43 <jriley> WHUMP! That was the sound of frequent flier miles being accrued
09:51:45 <surangak> lets hope I get to spend my FF miles one day :D
09:52:41 <jriley> Ah grasshopper, you're taking your first step into a larger world. And not your last.
09:52:53 <jriley> Oo, can I mix kung fu movies with Star Wars?
09:56:06 <surangak> :D
10:00:09 <bwolfe> jriley, no, absolutely not. under no circumstances are you allowed to mix those two
10:00:25 <bwolfe> black holes will open. characters will be sacrificed. forces will be lost
10:03:41 <surangak> oh wow bwolfe u mean that these sites r cheaper than established airlines ?
10:03:43 <surangak> :-O
10:03:55 <bwolfe> yeah. they buy from the airlines in bulk
10:04:01 <bwolfe> and in bulk at a set low prices
10:04:12 <bwolfe> the airlines change their prices multiple times a day depending on how many seats are left
10:05:05 <surangak> I guess u globetrotters know best :-)
10:08:20 <bwolfe> :-)
10:08:24 <bwolfe> I love my FF miles
10:09:30 <bwolfe> they've given me 2 free flights to Africa (for my wife and daughter), a free flight to New Orleans, and a free flight to Pittsburgh. and I still have enough left over for 2 more roundtrip flights to africa. :-D
10:09:43 <bwolfe> lunch time
10:09:44 <bwolfe> bbl
10:10:09 *** jriley has quit IRC
10:10:09 <surangak> One day I will catch up with you all ! :-P
10:14:04 *** bwolfe has quit IRC
10:56:39 *** sunbiz has left #openmrs
11:04:36 *** bwolfe has joined #openmrs
11:04:36 *** ChanServ sets mode: +o bwolfe
11:04:37 *** bwolfe has quit IRC
11:05:12 *** bwolfe has joined #openmrs
11:05:21 *** ChanServ sets mode: +o bwolfe
11:10:09 <surangak> bwolfe, may I ask wht type of visa you applied to get into ruwanda ?
11:10:27 <bwolfe> I do not have to get one as a US citizen
11:10:37 <surangak> bwolfe, lucky u
11:10:44 <bwolfe> surangak, but I would suggest applying for a holiday visa. don't apply for a work one, those usually take longer
11:10:57 <bwolfe> but if you are going as a visitor on holiday to see the gorillas then you should be ok
11:11:03 <bwolfe> just a 1 or 2 week one is sufficient
11:11:07 <surangak> bwolfe, :D
11:11:13 <surangak> let me try that out :P
11:11:25 <bwolfe> but I'm not sure how the rwandan gov't looks on visa applications
11:11:41 <bwolfe> I just know that thats the advice people get when going to the US. the "work" visa for conferences is harder
11:11:50 <bwolfe> so don't mention conference and instead just say you're visiting
11:12:11 <surangak> bwolfe, I guess it's always easier to get tourist visas into any country :-)
11:17:35 *** bwolfe has quit IRC
11:29:38 *** bwolfe has joined #openmrs
11:29:38 *** ChanServ sets mode: +o bwolfe
11:36:55 *** surangak has quit IRC
11:38:11 *** upul` has quit IRC
11:51:01 *** andtorg has quit IRC
11:53:59 *** dkayiwa has quit IRC
11:57:08 *** dkayiwa has joined #openmrs
12:07:11 *** dkayiwa has quit IRC
12:08:48 *** chopin has joined #openmrs
12:08:48 *** ChanServ sets mode: +v chopin
12:09:52 *** andtorg has joined #openmrs
12:11:06 *** dkayiwa has joined #openmrs
12:22:22 <bwolfe> rafa, where's you rev:XX comment on https://tickets.openmrs.org/browse/TRUNK-2440 ? :-/
12:22:42 <bwolfe> rafa-- for forcing me to click on both the reviews and source tabs to find out whats going on :-/
12:23:05 <rafa> bwolfe: I'm sorry ;)
12:23:23 <bwolfe> rafa, and if you could paste the link to the review in your comments I wouldn't be unhappy. :-D
12:23:47 <rafa> bwolfe: it's my normal practice, I forgot
12:25:42 <rafa> bwolfe: better now? :)
12:26:15 <bwolfe> rafa++
12:26:38 *** gbastien has joined #openmrs
12:28:35 * rafa loves eclipse on dual display
12:29:23 <bwolfe> you just have it spanning two screens?
12:29:34 <rafa> yes
12:29:39 <rafa> it's really cool
12:30:17 <rafa> I can deattach tabs and move it to the other screen :D
12:31:19 <bwolfe> nifty
12:31:29 * bwolfe wonders if he can use his phone as a second display
12:31:36 <rafa> haha
12:32:26 <rafa> bwolfe: I found an old 15" lcd ;)
12:32:33 <bwolfe> "found" ?
12:32:34 <bwolfe> :-p
12:32:43 <rafa> bwolfe: haha on my sisters desk :D
12:33:31 <rafa> bwolfe: but she doesn't use it anymore
12:34:42 <bwolfe> well NOW she doesn't!
12:36:58 <rafa> bwolfe: well ;)
12:43:59 *** bwolfe has quit IRC
12:46:21 *** bwolfe has joined #openmrs
12:46:21 *** ChanServ sets mode: +o bwolfe
12:51:12 *** bwolfe_ has joined #openmrs
12:51:12 *** ChanServ sets mode: +o bwolfe_
12:52:25 *** bwolfe has quit IRC
12:52:33 *** bwolfe_ has quit IRC
12:52:51 *** bwolfe_ has joined #openmrs
12:52:51 *** ChanServ sets mode: +o bwolfe_
13:04:45 *** rafa has quit IRC
13:05:10 *** rafa has joined #openmrs
13:05:40 *** ChanServ sets mode: +v rafa
13:07:58 *** gbastien has quit IRC
13:17:01 *** bwolfe_ has quit IRC
13:19:06 *** upul` has joined #openmrs
13:19:06 *** ChanServ sets mode: +v upul`
13:19:37 *** gbastien has joined #openmrs
13:24:47 *** upul` has quit IRC
13:33:51 *** bwolfe_ has joined #openmrs
13:33:51 *** ChanServ sets mode: +o bwolfe_
13:39:27 *** dkayiwa has quit IRC
13:53:33 <rafa> bwolfe_: what was the util class for Date comparisons?
13:54:13 <rafa> wyclif: djazayeri :)
13:55:20 <rafa> nevermind
13:56:42 <bwolfe_> rafa, huh? OpenmrsUtil ?
13:56:43 *** bwolfe_ is now known as bwolfe
13:56:59 <rafa> yes, it's what I meant
14:00:04 <bwolfe> coo
14:00:07 <bwolfe> rafa, OpenmrsUtil
14:00:12 <bwolfe> :-D
14:01:48 <djazayeri> good mornin
14:01:50 <djazayeri> g
14:02:16 <rafa> morning
14:03:26 <djazayeri> bwolfe, rafa, wyclif, (dkayiwa): scrum time?
14:04:13 <bwolfe> uh, sure, I will have to cut out early, so I can go first
14:04:39 <bwolfe> today: help with dev training here in eldoret plus code reviews when I wasn't talking.
14:04:45 <bwolfe> tomorrow: more of exactly the same
14:05:09 <djazayeri> okay, exciting
14:05:51 <djazayeri> Me:
14:06:12 <bwolfe> who will be addressing the providers branch comments?
14:06:17 <djazayeri> Monday
14:06:17 <djazayeri> * Code reviews
14:06:18 <djazayeri> * Reviewed Mike's progress on row-per-xyz reporting
14:06:18 <djazayeri> * Merge providers branch into trunk (this did take all day)
14:06:18 <djazayeri> * Reply to some emails from about attribute framework
14:06:18 <djazayeri> Today
14:06:19 <djazayeri> * Back to working on refactoring attributes (_must_ get the design agreed to)
14:06:19 <djazayeri> * Code reviews
14:06:20 <djazayeri> * Talk to Daniel about thinking about the alpha release
14:06:29 <djazayeri> I will either address them or delegate.
14:07:51 <djazayeri> my only blocker is that we haven't yet agreed to a design for refactoring attributes
14:07:54 <rafa> djazayeri: hurray svn :P we should switch to mercurial ;)
14:08:05 <djazayeri> or git. :-P
14:08:16 <rafa> djazayeri: mercurial :P
14:08:25 <rafa> djazayeri: it has better support for eclipse :D
14:08:46 <djazayeri> I think we must draw a line in the sand saying that we must agree to the attribute design by the end of tomorrow's design call.
14:08:50 <rafa> djazayeri: and is windows friendly
14:09:30 <bwolfe> windows what?
14:10:00 <rafa> bwolfe: just to tease you :P
14:10:34 <djazayeri> rafa: your turn
14:10:40 <rafa> *** Rafal ***
14:10:40 <rafa> Today:
14:10:40 <rafa> * Committed TRUNK-2295: Voiding a visit should ask for confirmation, and show how many dependent object will be deleted
14:10:40 <rafa> https://tickets.openmrs.org/browse/TRUNK-2295 (fixing now after review)
14:10:40 <rafa> * Finished reviewing CR-TRUNK-529 Merged providers branch into trunk
14:10:40 <rafa> Tomorrow:
14:10:41 <rafa> * TRUNK-438: Add a "Settings" page and Rename Manage Global Properties page
14:10:41 <rafa> https://tickets.openmrs.org/browse/TRUNK-438
14:10:42 <rafa> No blockers.
14:13:00 <djazayeri> rafa: you also have trunk-2440 assigned to you
14:13:06 <djazayeri> and "in progress"
14:13:12 <rafa> !ticket trunk-2440
14:13:13 <OpenMRSBot> rafa: [#TRUNK-2440] Add method for getting HL7InQueue by its uuid - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2440
14:13:22 <rafa> ohh that's committed
14:13:33 <djazayeri> after ben's review?
14:13:43 <rafa> ohh right missed that
14:13:54 <djazayeri> happy to help. :-)
14:14:03 <rafa> thank you :)
14:16:06 <wyclif> hi
14:16:15 *** bwolfe has quit IRC
14:17:04 <djazayeri> hi wyclif
14:17:06 <djazayeri> your turn
14:17:22 <rafa> hi wyclif
14:17:25 <wyclif> give me a sec
14:22:56 <wyclif> yesterday:
14:22:56 <wyclif> - TRUNK-1956
14:22:56 <wyclif> - fixed the problem i had with TRUNK-2686
14:22:56 <wyclif> - started on TRUNK-2271(are there any pending discussions on this)
14:22:56 <wyclif> today:
14:22:57 <wyclif> - merge localization of init wizard into trunk
14:22:59 <wyclif> - complete TRUNK-2271
14:23:01 <wyclif> - 1.9 tickets
14:23:03 <wyclif> - blockers:none
14:23:09 <djazayeri> !ticket trunk-1956
14:23:10 <OpenMRSBot> djazayeri: [#TRUNK-1956] Fix tests with @Ignore in ConceptServiceTest - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-1956
14:23:17 <djazayeri> !ticket trunk-2686
14:23:18 <OpenMRSBot> djazayeri: [#TRUNK-2686] Provider Identifiers should be unique - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2686
14:23:24 <djazayeri> !ticket trunk-2271
14:23:25 <OpenMRSBot> djazayeri: [#TRUNK-2271] Add Provider-related methods to EncounterService - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2271
14:25:02 <djazayeri> wyclif, rafa: FYI I have merged the providers branch
14:25:13 <djazayeri> so any further provider-related stuff should happen in trunk
14:25:28 <wyclif> yes
14:27:55 <djazayeri> wyclif: btw, have you looked back at the http://notes.openmrs.org/Testing-Feedback page at all?
14:28:07 <wyclif> djazayeri, yes
14:28:13 <djazayeri> recently?
14:28:41 <wyclif> not this week, but i know there are things to do from there
14:28:49 <djazayeri> okay, we need to turn those into tickets
14:29:34 <wyclif> i will look at them later today
14:29:45 <djazayeri> okay, we can do it collaboratively if you want
14:29:58 <djazayeri> i.e. if you want to discuss whether specific points become tickets or not
14:31:54 <wyclif> ok
14:32:45 <wyclif> djazayeri, djazayeri, do you think we need to add getEncountersByProvider to EncounterService
14:33:21 <djazayeri> wyclif: there's already a getEncounters(…, List<Provider>, ...)
14:33:50 <djazayeri> so I don't think so.
14:33:55 <djazayeri> Is there a specific use case you have in mind?
14:34:35 <wyclif> not really, i think the other one is sufficient
14:34:40 <djazayeri> ok
14:34:50 <wyclif> so am going to close the ticket
14:35:21 <wyclif> though i have added a comment to it and will wait for any further comments before i can close it
14:37:16 <djazayeri> wyclif: did I say on the ticket to consider making that method?
14:38:05 <wyclif> djazayeri, you added a comment that whoever works on the ticket should ask for whether we need it
14:38:30 <djazayeri> Okay. I see.
14:39:08 <djazayeri> oh, hmm, the issue is that the getEncounters(…) version of the method doesn't let you specify encounter role
14:39:15 <djazayeri> so maybe that needs to be implemented
14:40:14 <djazayeri> I mean: maybe we need to put that in the getEncounters(…) method
14:40:34 <djazayeri> i.e. change the Collection<Provider> to a Map<EncounterRole, Provider> in the long-form method
14:40:49 <djazayeri> wyclif: in any case, this isn't the highest-priority ticket now
14:41:09 <djazayeri> maybe we can discuss that method briefly on design forum tomorrow
14:42:39 <djazayeri> wyclif: ^^
14:43:31 <djazayeri> btw, if there are no tickets left in the sprint, then we should create tickets from the notes page and work on regular 1.9 tickets.
14:45:02 <wyclif> djazayeri, ok
14:45:47 <wyclif> i think i have a few ticket to whose reviews have comments to fix but i will do this in the morning and do that in the afternno
14:46:04 <wyclif> djazayeri, did you see Ben's comment for TRUNK-2686?
14:46:17 <djazayeri> wyclif: not yet
14:46:33 <djazayeri> hmm, I see his comment, but I disagree with him
14:47:00 <djazayeri> if you want to store overlapping identifiers, you need to prefix them like AMPATH-123 vs RWINK-123
14:47:27 <wyclif> i agree with that
14:48:06 <wyclif> i think we will discuss it too on tomorrow' call and the issue of allowing duplicate for retired rows
14:56:36 <djazayeri> sure
14:56:46 <djazayeri> We should make a list of these things. :-)
14:57:30 *** chopin has quit IRC
15:01:01 *** jwishnie has joined #openmrs
15:10:47 *** chopin has joined #openmrs
15:10:47 *** ChanServ sets mode: +v chopin
15:11:06 *** jkeiper has joined #openmrs
15:11:06 *** ChanServ sets mode: +v jkeiper
15:11:41 *** chopin has quit IRC
15:14:14 <jkeiper> hey rafa , bryq :-)
15:18:02 <jkeiper> rafa: when you report that a concept has a duplicate name, is that a direct copy of what the ConceptValidator gives you?
15:18:16 * jkeiper needs to run some queries on his data to clean it up and generate a package
15:28:57 <bryq> jkeiper: Hi
15:29:10 <rafa> jkeiper: yes, it's exactly what ConceptValidator returns
15:30:09 <jkeiper> rafa: ok, thx ... wyclif gave me a query to run a while ago to figure out what concepts should be in error, but I'm getting a very large list right now and it doesn't equate with what wyclif suggested
15:30:10 <jkeiper> :-/
15:30:24 <jkeiper> i think there is something essentially wrong with ConceptValidator
15:31:20 <djazayeri> jkeiper: wouldn't surprise me—the logic is complex, and I don't think it was well-specified before the code was written
15:31:31 <djazayeri> a unit test showing misbehavior would be nice
15:31:40 <jkeiper> for instance, i realize that there are two ConceptNames with "BACK" as the name, and both are FULLY_SPECIFIED and not voided, but one's concept is retired.
15:32:09 <jkeiper> there must be something hanging on to the retired concept
15:32:14 <jkeiper> some reference in some form ...
15:33:12 <jkeiper> rafa: perhaps a minor improvement to the reporting of errors would show a backtrace of how that concept was connected to items in the package (i.e. Form #23 -> FormField #17238172 -> Concept #572)
15:33:50 <jkeiper> rafa: are "retired" metadata automatically ignored, or are they included when you "select all"?
15:34:09 <jkeiper> djazayeri: i'd love to write a test, just can't find a consistent cause
15:35:50 <rafa> jkeiper: retired metadata are included
15:36:39 <rafa> jkeiper: I just added a feature to handlers that will allow us to exclude them, but it's not yet visible in the UI
15:36:42 <jkeiper> rafa, djazayeri: i think retired concepts are failing the conceptvalidator, since new concepts have their names
15:36:53 <jkeiper> rafa: ah, good ... i'll probably use it in the future :-)
15:37:26 <rafa> the concept validator should ignore retired concept names
15:38:04 <jkeiper> in 1.8.x it is not
15:38:08 <jkeiper> not sure about trunk
15:38:23 <djazayeri> rafa: I'm not sure it should ignore retired names
15:38:27 <jkeiper> rafa: i just verified, a retired concept with the same name as a current concept causes the error
15:38:30 <djazayeri> retired != deleted
15:38:44 <djazayeri> sound worthwhile for dev list discussion
15:38:45 <jkeiper> but attempting to export the non-retired concept works
15:38:47 <jkeiper> yep
15:38:54 * jkeiper fires it off
15:41:23 *** andtorg has quit IRC
15:46:45 <jkeiper> bryq: thanks for that patch ... making things work here :-)
15:47:16 <jkeiper> i'm definitely interested in the proxy object patch for pulling metadata from hibernate without loading a bunch of large properties into memory (blobs)
15:47:29 <jkeiper> it'll seriously help my Form Entry XSN issue
15:47:49 <jkeiper> for now, i'll settle on getting my entire dictionary into a package :-)
15:47:53 <bryq> jkeiper: Good to hear this :)
15:49:57 <bryq> jkeiper: If you have some more issues that block work with MDS module, please tell me that. I could look on this if I had some free time
15:50:32 <jkeiper> bryq: right now just trying to get past these ConceptValidator issues
15:50:36 <jkeiper> and the random xstream error
15:50:36 <jkeiper> :-)
15:50:46 <jkeiper> it always helps to reboot though
15:50:50 <jkeiper> at least we have a workaround for that one
15:51:29 <bryq> jkeiper: The random xstream error seems interesting to me :)
15:51:37 <bryq> jkeiper: How often does it occur?
15:52:04 <jkeiper> bryq: not very ... just after i have created a few packages, and even then it's still random
15:52:17 <jkeiper> bryq: the amount of data going into the package when i get the error is not much
15:52:24 <jkeiper> bryq: so i don't think it is related to that
15:53:16 <bryq> jkeiper: The worst thing is that this issue is hard to reproduce
15:53:23 <jkeiper> exactly
15:53:32 <bryq> jkeiper: Is there any ticket with stacktrace?
15:54:02 <jkeiper> bryq: i think i have an email with a stacktrace in it ... /me looks
15:56:46 <jkeiper> bryq: just sent you what i sent to the dev list
15:57:02 <wyclif> jkeiper, that is a devlist discussion if we duplicate names that are retired
15:57:36 <bryq> jkeiper: Good, I'll look on this
15:57:53 <wyclif> i know that the validator wont let you duplicate a name whether retired if its concept is not retired
15:57:56 <jkeiper> wyclif: i wrote to the dev list
15:57:59 <wyclif> jkeiper, i know that the validator wont let you duplicate a name whether retired if its concept is not retired
15:59:13 <jkeiper> rafa: does MDS try to _save_ the concept to be exported?
15:59:33 <wyclif> jkeiper, it would be good if we clarified this now and include it in the 1.9 release, i ran into the same thing with provider identifiers
15:59:49 <jkeiper> bryq: it just happened again! for some reason the stacktrace does not go to the log, only to the browser
16:00:00 <jkeiper> wyclif: ah, ok ... well, it's on the dev list
16:00:23 <bryq> jkeiper: The stacktrace is the same?
16:00:32 <jkeiper> bryq: yep
16:00:37 * jkeiper restarts
16:01:11 *** andtorg has joined #openmrs
16:03:20 <jkeiper> wyclif: do you see my email or is it still not there?
16:03:54 <bryq> jkeiper: Yes, I've got the mail
16:04:49 <jkeiper> bryq: i was referring to a devlist email ... for some reason those take forever to go through
16:12:23 <jkeiper> bryq, rafa: does it seem strange to you when you have 500 items set as "keep mine" and 1 as "overwrite" for MDS to take forever to process the final step of the import? it seems to me that "keep mine" is akin to "ignore" and should require zero processing at that point, no?
16:14:48 <bryq> jkeiper, rafa: I think we are saving some info about imported items, aren't we? This causes 'waste' of time.
16:16:00 <jkeiper> ah hmm
16:16:07 <jkeiper> not bad to have an audit trail ;-)
16:16:47 <jkeiper> bryq, rafa: are we not keeping the same ID of objects from one instance to the other? just the UUID?
16:17:08 <bryq> jkeiper: Just the UUID
16:17:39 <jkeiper> bryq: and that's on purpose, right?
16:17:48 <jkeiper> same thing happens for concepts?
16:18:36 <bryq> jkeiper: For concepts it is more complicated
16:18:55 <bryq> jkeiper: Rafa will know this for sure
16:19:02 <jkeiper> ok
16:19:03 <jkeiper> thanks bryq
16:19:09 <bryq> jkeiper: I'm not the master of this part of MDS
16:19:11 <jkeiper> hahaha
16:19:13 <jkeiper> understood
16:28:08 *** upul` has joined #openmrs
16:28:08 *** ChanServ sets mode: +v upul`
16:29:53 *** upul` has left #openmrs
17:05:30 *** arane has joined #openmrs
17:05:38 *** arane has left #openmrs
17:07:30 *** andtorg has quit IRC
17:08:13 *** jkeiper has quit IRC
17:15:08 <wyclif> djazayeri, is it fine if we change getEncountersByVisit(visit, includeVoided) to return encounters not assigned to a visit when visit is null
17:16:08 <wyclif> djazayeri, then i can remove the logic in patientVisitsPortletController that gets these visits
17:16:10 <djazayeri> wyclif: I think so, yes. Make sure you describe that in the javadoc
17:16:36 <djazayeri> because this is *not* like what we usually do
17:16:45 <djazayeri> where null means ignore the constraint
17:17:16 <wyclif> djazayeri, i think i want to take this back
17:18:30 <wyclif> because it will return all encounters in the table that have no visits yet we want those for a particular patient
17:18:39 <djazayeri> oh, right
17:18:49 <wyclif> so i will check getENcounters with many arguments
17:19:02 <wyclif> and see what it does if the arguments are null
17:19:11 <djazayeri> wyclif: that's not going to do what you want
17:19:30 <djazayeri> i.e. that's surely going to have null -> no constraint on visit in query
17:20:29 <wyclif> then i will have to add a new method like getEncountersByPatientAndVisit
17:20:51 <djazayeri> wyclif: I think that is probably a good idea.
17:20:53 <wyclif> ok
17:20:59 <djazayeri> But taking a step back: is this strictly required for 1.9 alpha?
17:21:00 <wyclif> djazayeri, thanks
17:21:12 <djazayeri> wyclif: is the code already working correctly now, just that the controller should have some logic refactored out?
17:21:13 <wyclif> i think so because
17:21:41 <wyclif> we want to avoid loading many encounters on the patient dashboard that are not assigned to a visit
17:21:56 <wyclif> i can get this done within an hr or less
17:21:58 <djazayeri> Anyway, if this is quick, then sure, fix it now. But if it's going to take more than 30 minutes, we can delay this until after the alpha.
17:21:59 <djazayeri> okay.
17:22:07 <wyclif> unless i run into issues
17:22:18 <wyclif> ok
17:24:23 *** jkeiper has joined #openmrs
17:24:23 *** ChanServ sets mode: +v jkeiper
18:06:22 <djazayeri> jkeiper: hey, at AMPATH, are users accustomed to referring to providers by ID?
18:06:36 <djazayeri> and if so, what id is that? (system-id? user-id?)
18:07:05 *** bwolfe has joined #openmrs
18:07:05 *** ChanServ sets mode: +o bwolfe
18:36:26 *** Suranga has joined #openmrs
18:50:05 *** andtorg has joined #openmrs
19:27:32 *** Suranga_ has joined #openmrs
19:29:49 *** Suranga has quit IRC
19:43:22 *** Suranga_ has quit IRC
19:53:01 *** andtorg has quit IRC
19:56:17 *** dkayiwa has joined #openmrs
20:05:01 *** chughgaurav has joined #openmrs
20:28:22 *** andtorg has joined #openmrs
20:43:25 <djazayeri> jkeiper: ^^?
20:44:02 <djazayeri> wyclif: hopefully the "an hour or less" thing is done now. Did you get a chance to review the etherpad of testing comments?
20:45:30 <wyclif> djazayeri, i havent yet looked at the ether pad, i will in the next 20min
20:46:00 <wyclif> worked on some TODO on past tickets first
20:46:10 <djazayeri> np
20:46:18 <wyclif> about to commit the one hour thing
20:46:29 <wyclif> needed to make some changed to the scripts
20:46:40 *** chughgaurav has quit IRC
20:46:50 <wyclif> because we need to fetch them when the use clicsks show/hide
20:48:08 <djazayeri> wyclif: fair enough, but for the next bit of time we need to be better about focusing on only what's required to release 1.9 alpha. :-)
20:48:47 <wyclif> ok
20:56:04 *** chughgaurav has joined #openmrs
21:02:12 *** bwolfe has quit IRC
21:06:17 *** bryq has quit IRC
21:33:40 *** chughgaurav has quit IRC
21:46:26 *** jkeiper has quit IRC
22:04:56 *** andtorg has quit IRC
22:31:51 *** rafa has quit IRC
22:51:16 *** djazayeri has quit IRC
23:02:13 *** dkayiwa has quit IRC
23:06:12 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Household Module 1.0.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=household&ampversion=&amp1.0.0>
23:26:46 *** nwilkie has joined #openmrs
23:27:06 *** Guest24627 has joined #openmrs
23:27:32 *** Guest24627 is now known as Nick_Wilkie
23:28:05 *** Nick_Wilkie is now known as nickwilkie
23:31:18 *** nwilkie has quit IRC