| 00:32:59 | *** chopin has quit IRC |
| 01:11:03 | *** downeym has joined #openmrs |
| 01:11:03 | *** ChanServ sets mode: +o downeym |
| 01:11:03 | *** OpenMRSBot sets mode: +o downeym |
| 01:37:48 | *** jriley has joined #openmrs |
| 02:05:37 | *** jportela has joined #openmrs |
| 02:05:37 | *** ChanServ sets mode: +v jportela |
| 02:06:45 | *** jportela has left #openmrs |
| 02:37:28 | *** downeym has quit IRC |
| 02:39:32 | *** jriley has quit IRC |
| 02:58:13 | *** chopin has joined #openmrs |
| 02:58:13 | *** ChanServ sets mode: +v chopin |
| 02:59:49 | *** gbastien has quit IRC |
| 03:27:07 | *** chopin has quit IRC |
| 03:33:14 | *** deadpool_ has joined #openmrs |
| 03:34:39 | *** zeke has joined #openmrs |
| 03:37:00 | * zeke abc |
| 03:55:25 | <deadpool_> djazayeri: are you asleep? |
| 04:16:46 | *** zeke has quit IRC |
| 04:19:39 | *** upul` has joined #openmrs |
| 04:19:39 | *** ChanServ sets mode: +v upul` |
| 04:54:15 | *** surangak has joined #openmrs |
| 04:54:23 | <deadpool_> upul`: can you help me on htmlforms? |
| 04:55:39 | <upul`> deadpool_: I haven't used that module, if you just type the problem may be jazayeri or anybody could reply |
| 04:58:03 | <deadpool_> i think he is asleep right now |
| 04:58:20 | <deadpool_> but i will try later |
| 05:33:26 | <djazayeri> deadpool_: I'm awake |
| 05:33:31 | <djazayeri> what's up? |
| 05:35:37 | <deadpool_> djazayeri: i am trying to use the tag for text area for html form entry but when displaying it the area size still stays the same |
| 05:35:37 | <deadpool_> so i am using this <obs conceptId="7132" labelText="Notes" style="textarea" row="30" col="200"/> |
| 05:36:14 | <djazayeri> row -> rows, col -> cols |
| 05:36:19 | <djazayeri> deadpool_: ^^ |
| 05:36:28 | <deadpool_> ah man really |
| 05:36:31 | <deadpool_> so stupid |
| 05:36:33 | <deadpool_> i am |
| 05:38:01 | <deadpool_> djazayeri: yeah it works thanks a bunch |
| 05:41:07 | <djazayeri> np |
| 05:45:16 | *** bwolfe has joined #openmrs |
| 05:45:16 | *** ChanServ sets mode: +o bwolfe |
| 06:18:25 | *** pascal` has joined #openmrs |
| 06:26:54 | *** pascal` has quit IRC |
| 06:40:38 | *** deadpool_ has quit IRC |
| 06:43:20 | *** pascal` has joined #openmrs |
| 06:43:35 | *** rafa has joined #openmrs |
| 06:43:35 | *** ChanServ sets mode: +v rafa |
| 07:02:26 | *** dkayiwa has joined #openmrs |
| 07:03:15 | *** bryq has joined #openmrs |
| 07:03:15 | *** ChanServ sets mode: +v bryq |
| 07:10:36 | *** dkayiwa has quit IRC |
| 07:12:50 | *** dkayiwa has joined #openmrs |
| 07:14:56 | *** rafa_ has joined #openmrs |
| 07:14:56 | *** ChanServ sets mode: +v rafa_ |
| 07:15:52 | *** deadpool_ has joined #openmrs |
| 07:18:58 | *** rafa has quit IRC |
| 07:37:10 | *** rafa_ has quit IRC |
| 07:53:11 | *** chughgaurav has joined #openmrs |
| 08:08:26 | *** chughgaurav has quit IRC |
| 08:31:54 | <surangak> howdy bwolfe |
| 08:32:07 | <bwolfe> hey |
| 08:51:12 | <surangak> bwolfe, :-) |
| 09:24:41 | *** rafa has joined #openmrs |
| 09:24:56 | *** ChanServ sets mode: +v rafa |
| 09:32:06 | *** deadpool_ is now known as deadpool |
| 09:52:39 | *** mnunez has joined #openmrs |
| 10:06:06 | <mnunez> Good morning everyone! (good afternoon dkayiwa)! |
| 10:06:17 | <dkayiwa> good afternoon mnunez |
| 10:06:23 | <dkayiwa> :) |
| 10:06:41 | <dkayiwa> its also an afternoon for Benjamin :) |
| 10:21:06 | <mnunez> djazayeri: Quick question regarding the drug regimen tab in the dashboard: How do I modify the default "reasons to stop medication"? |
| 10:21:28 | <mnunez> djazayeri: XML to modify somewhere? |
| 10:21:32 | *** surangak_ has joined #openmrs |
| 10:21:39 | *** surangak has quit IRC |
| 10:21:47 | <bwolfe> mnunez, I don't think djazayeri is awake yet |
| 10:22:02 | <bwolfe> mnunez, but it might be a concept with concept answers that you can modify |
| 10:22:05 | * bwolfe can't remember |
| 10:22:23 | <mnunez> bwolfe: right, he's on my side of the world ;) |
| 10:22:37 | <bwolfe> even farther really |
| 10:22:50 | <bwolfe> another 4 hours and he'll be awake |
| 10:26:14 | <mnunez> bwolfe: All right, I'll ask in a few hours. |
| 10:27:41 | <mnunez> bwolfe: Am I the only one loading drugs from the dashboard? It seems strange it's not documented and yet it's like the most intuitive way of adding drugs. What do other implementers normally use? |
| 10:28:19 | <mnunez> bwolfe: by loading drugs I ment adding a drug to a patient regime. |
| 10:28:43 | <bwolfe> mnunez, creating hte regimens is usually a one-time thing |
| 10:28:50 | <bwolfe> and I'm sure a lot of people use the defaults |
| 10:28:57 | <bwolfe> the users just pick regimens (usually) |
| 10:32:06 | *** bwolfe_ has joined #openmrs |
| 10:32:06 | *** ChanServ sets mode: +o bwolfe_ |
| 10:32:10 | *** bwolfe has quit IRC |
| 10:33:10 | *** bwolfe__ has joined #openmrs |
| 10:36:31 | *** bwolfe_ has quit IRC |
| 10:44:53 | *** surangak__ has joined #openmrs |
| 10:44:53 | *** surangak_ has quit IRC |
| 10:47:38 | *** surangak_ has joined #openmrs |
| 10:47:38 | *** surangak__ has quit IRC |
| 10:55:14 | *** surangak__ has joined #openmrs |
| 10:55:15 | *** surangak_ has quit IRC |
| 10:59:36 | *** bryq has quit IRC |
| 11:09:46 | *** deadpool has quit IRC |
| 11:22:17 | *** deadpool has joined #openmrs |
| 11:42:38 | *** upul` has quit IRC |
| 12:54:21 | *** wyclif has joined #openmrs |
| 12:54:34 | *** jriley has joined #openmrs |
| 13:00:18 | *** surangak__ has quit IRC |
| 13:00:47 | *** surangak has joined #openmrs |
| 13:05:27 | <bwolfe__> boo dkayiwa |
| 13:05:28 | *** bwolfe__ is now known as bwolfe |
| 13:05:32 | *** ChanServ sets mode: +o bwolfe |
| 13:05:45 | <dkayiwa> :) |
| 13:05:52 | <bwolfe> ci fail |
| 13:06:30 | <dkayiwa> oh so so mannyyyy |
| 13:06:30 | *** chopin has joined #openmrs |
| 13:06:30 | *** ChanServ sets mode: +v chopin |
| 13:10:36 | *** downeym has joined #openmrs |
| 13:10:36 | *** OpenMRSBot sets mode: +o downeym |
| 13:10:36 | *** ChanServ sets mode: +o downeym |
| 13:16:26 | *** bwolfe has quit IRC |
| 13:16:53 | <mnunez> Implementing question: I have a concept I'd like to make numeric, but it's actually a frequency. It's name is "Epilepsy crysis frequency". It ranges from once a year (lucky epileptic) to once every hour (unlucky epileptic). How would you save it? As numeric? Coded? |
| 13:17:21 | <dkayiwa> Coded |
| 13:17:34 | <mnunez> Structured numerics would be an excelent solution, but as far as I know it's not ready yet, is it? |
| 13:18:09 | *** bwolfe has joined #openmrs |
| 13:18:09 | *** ChanServ sets mode: +o bwolfe |
| 13:22:32 | *** mnunez has left #openmrs |
| 13:28:26 | *** deadpool has quit IRC |
| 13:28:56 | *** mnunez has joined #openmrs |
| 13:33:09 | *** Gagaman has joined #openmrs |
| 13:33:11 | *** mnunez has quit IRC |
| 13:35:34 | <dkayiwa> hi bwolfe |
| 13:36:00 | <bwolfe> hi dkayiwa |
| 13:36:45 | <dkayiwa> bwolfe: for the failing tests, they were putting empty strings for non nullable database columns. should i change the tests to put non empty values? |
| 13:38:06 | <bwolfe> what did you do to fix them already? |
| 13:38:53 | <dkayiwa> just commented out the line which sets empty strings to null for now until when the tests pass on my local machine. :) |
| 13:40:44 | *** upul` has joined #openmrs |
| 13:40:44 | *** ChanServ sets mode: +v upul` |
| 13:44:09 | *** pascal` has quit IRC |
| 13:45:32 | *** goutham has joined #openmrs |
| 13:47:47 | *** pascal` has joined #openmrs |
| 13:50:15 | <dkayiwa> bwolfe: these are my findings for all the failling unit tests |
| 13:50:42 | <bwolfe> dkayiwa, what are the fields that its doing that to? |
| 13:50:42 | <bwolfe> if the tests depend on the empty strings than its an argument against what djazayeri wants |
| 13:51:25 | <dkayiwa> bwolfe: 1) Person.hbm.xml has gender field as not-null="true" yet database allows null |
| 13:52:20 | <dkayiwa> 2) standardTestDataSet.xml has some <person_attribute entried with value="" |
| 13:52:52 | *** gbastien has joined #openmrs |
| 13:52:55 | <bwolfe> yes, person_attributes need to be dealt with. these are the exception to the rule that I brought up in the email thread |
| 13:53:34 | <dkayiwa> bwolfe: changing: 1) to not-null="false" and 2) changing to value = "NULL" fixes all the failing tests |
| 13:54:34 | <dkayiwa> bwolfe: the tests for person attributes did not depend on value having to be an empty string, they just did not bother set it |
| 13:55:03 | <dkayiwa> bwolfe: the tests assumed the the standardDataSet.xml already set the value |
| 13:56:22 | <dkayiwa> bwolfe: so as a way forward, should i do those two changes, or just wait for some further discussions? |
| 14:01:15 | <bwolfe> gender should be nullable |
| 14:01:23 | <dkayiwa> ok |
| 14:01:23 | <bwolfe> and standard test dataset fixes are good too |
| 14:01:27 | <bwolfe> but the app needs to be tested |
| 14:01:35 | <dkayiwa> ok |
| 14:01:40 | <bwolfe> (with setting and then unsetting patient attributes) |
| 14:01:46 | <dkayiwa> ok |
| 14:02:05 | <dkayiwa> bwolfe: what do you mean by unsetting? |
| 14:02:32 | <bwolfe> clearing the value |
| 14:02:35 | <bwolfe> and saving the patient |
| 14:02:49 | <dkayiwa> ok |
| 14:04:17 | <dkayiwa> bwolfe: ok let me test that. if it works, i will commit and then send you the changeset |
| 14:05:55 | <djazayeri> hi |
| 14:06:16 | <dkayiwa> bwolfe: why don't we just fix the api by removing empty person attributes on save? |
| 14:06:31 | <dkayiwa> bwolfe: as in what would be the value of saving attributes with no value? |
| 14:06:38 | <bwolfe> dkayiwa, theres another ticket for that somewhere |
| 14:06:43 | <dkayiwa> ok |
| 14:07:18 | <djazayeri> bwolfe, dkayiwa, what ticket are you talking about now? |
| 14:07:57 | <dkayiwa> djazayeri: two tickets :) |
| 14:08:36 | <dkayiwa> djazayeri: the one that bwolfe is calls the other ticket, and the one we have been discussing about TRUNK-2680 |
| 14:08:40 | <bwolfe> djazayeri, your automagic nullifier ticket |
| 14:08:46 | <dkayiwa> :) |
| 14:09:58 | <djazayeri> what's the other one? |
| 14:10:09 | <djazayeri> trunk-2004? |
| 14:10:10 | <dkayiwa> bwolfe: knows :) |
| 14:10:23 | <djazayeri> oh, is it the one about empty person attributes? |
| 14:10:36 | <bwolfe> yeah |
| 14:10:39 | * chopin hates person attributes |
| 14:10:41 | <bwolfe> from a while ago |
| 14:10:51 | <bwolfe> person attributes hate chopin |
| 14:10:58 | <chopin> there are also loads of redundant person attributes in DBs for ppl who use RFE |
| 14:11:03 | <dkayiwa> :D |
| 14:11:18 | <bwolfe> its all dkayiwa's fault. without him we never would have had them ;-) |
| 14:11:22 | <djazayeri> Okay, so for what it's worth, I intentionally did *not* make trunk-2680 part of the current sprint |
| 14:11:29 | <dkayiwa> hahahahahaha |
| 14:11:41 | <dkayiwa> what a history :) |
| 14:11:44 | <djazayeri> It counts as a bugfix. :-) |
| 14:11:57 | <djazayeri> i.e. something that we can address after 1.9 alpha is released. |
| 14:12:06 | <djazayeri> oh well, it's committed now |
| 14:12:49 | * bwolfe missed that memo |
| 14:12:57 | <djazayeri> but, per my email, let's make sure we focus on tickets are strictly necessary for 1.9 alpha. |
| 14:13:26 | <chopin> djazayeri, can non-sprinters focus on others? ;_) |
| 14:13:43 | <dkayiwa> djazayeri: you could take it further by removing the non strictly necessary tickets from the sprint :) |
| 14:13:47 | * chopin is a lumberer |
| 14:13:47 | <djazayeri> chopin: you're allowed to do whatever you want |
| 14:13:50 | <chopin> yay! |
| 14:13:51 | <dkayiwa> djazayeri: then we do not get tempted :) |
| 14:14:24 | <bwolfe> dkayiwa, I put that ticket in the sprint this morning, it wasn't darius. |
| 14:14:25 | <djazayeri> dkayiwa: yes, but I didn't put this ticket in the sprint. Well, I did, then immediately removed it. Blame bwolfe for putting it back. :-P |
| 14:14:43 | <djazayeri> anyway, it doesn't matter now. |
| 14:14:57 | <dkayiwa> djazayeri: like the non essentials that i can still see in the sprint :) |
| 14:14:58 | <djazayeri> so, bwolfe, rafa, wyclif, dkayiwa: scrum? |
| 14:15:11 | <bwolfe> lets scrum away |
| 14:15:23 | <chopin> scrum a dum dum |
| 14:15:28 | <dkayiwa> ok |
| 14:15:29 | <rafa> :) |
| 14:16:02 | <dkayiwa> Committed: Javascript error on left and right arrow keys when creating new concept - TRUNK-2473 |
| 14:16:02 | <dkayiwa> Committed response to review comments for: You shouldn't be allowed to add an encounter to a visit if the encounter's datetime is not within the date range of the visit - TRUNK-2568 |
| 14:16:02 | <dkayiwa> Committed: Automatically convert empty string properties on OpenmrsObjects to null before persisting in the database - TRUNK-2680 |
| 14:16:03 | <dkayiwa> Looked into: Dashboard > Visits > edit encounter gives null pointer exception - TRUNK-2677 |
| 14:16:03 | <dkayiwa> Looked into review comments for: Data Entry Statistics Module - Includes voided encountres and obs - TRUNK-2381 |
| 14:16:03 | <dkayiwa> No Blockers |
| 14:16:48 | <wyclif> hi |
| 14:17:20 | <dkayiwa> oh two blockers :) |
| 14:17:24 | <djazayeri> what did you end up doing with trunk-2381? |
| 14:17:38 | <djazayeri> is it trivially easy to show encounters with no obs? |
| 14:17:41 | <djazayeri> or would that take time? |
| 14:17:58 | <dkayiwa> waiting for responses from the TRUNK-2381 and TRUNK-2677 |
| 14:18:27 | <dkayiwa> djazayeri: i found that it could take me more time |
| 14:19:24 | <wyclif> ok |
| 14:19:26 | <djazayeri> yes, just go ahead and upload with this change, but create a new ticket for the bug |
| 14:19:37 | <djazayeri> !ticket trunk-2677 |
| 14:19:39 | <OpenMRSBot> djazayeri: [#TRUNK-2677] Dashboard > Visits > edit encounter gives null pointer exception - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2677 |
| 14:20:26 | <dkayiwa> ok |
| 14:20:38 | <djazayeri> for the second one, I haven't reproduced it myself, but it seems like Wyclif did. |
| 14:20:54 | <djazayeri> You need to have an encounter created by the HTML Form Entry module, and try to open that one. |
| 14:21:02 | <dkayiwa> djazayeri: i tried that |
| 14:21:10 | <dkayiwa> but still failed to reproduce it on trunk |
| 14:21:36 | <djazayeri> wyclif: did you reproduce that error that jriley reported? |
| 14:21:43 | <djazayeri> did you change anything to fix it? |
| 14:22:48 | <wyclif> which one djazayeri |
| 14:22:55 | <dkayiwa> trunk-2677 |
| 14:23:00 | <wyclif> hmmm |
| 14:23:01 | <djazayeri> !ticket trunk-2677 |
| 14:23:02 | <OpenMRSBot> djazayeri: [#TRUNK-2677] Dashboard > Visits > edit encounter gives null pointer exception - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2677 |
| 14:23:51 | <wyclif> i investigated it |
| 14:24:03 | <wyclif> and i noticed it is a bug i think in html formentry |
| 14:24:14 | <djazayeri> wyclif: dkayiwa says he cannot reproduce it |
| 14:24:15 | *** Gagaman has quit IRC |
| 14:24:31 | <dkayiwa> wyclif: i failed to reproduce it on trunk |
| 14:24:37 | <wyclif> he needs to create an encounter from html formentry |
| 14:24:45 | <dkayiwa> wyclif: i did |
| 14:24:51 | <djazayeri> dkayiwa: I will try to reproduce now |
| 14:24:55 | <dkayiwa> HTML Form Entry 1.7.3 |
| 14:25:01 | <dkayiwa> ok |
| 14:25:06 | <wyclif> am not sure which version she used |
| 14:25:13 | <wyclif> may be from trunk |
| 14:25:16 | <wyclif> of the module |
| 14:25:38 | <dkayiwa> just tested again on my trunk |
| 14:25:39 | <dkayiwa> http://localhost:8080/openmrs/module/htmlformentry/htmlFormEntry.form?encounterId=87&mode=EDIT |
| 14:25:49 | <djazayeri> I just reproduced it on the sprint1 server |
| 14:25:51 | <wyclif> but i couldn't reproduce it with core and xforms encounters |
| 14:25:53 | <dkayiwa> and it displays the html form without any NPE |
| 14:26:01 | <djazayeri> go here: http://sprint1.openmrs.org:8080/openmrs/patientDashboard.form?patientId=2&phrase=horatio |
| 14:26:04 | <OpenMRSBot> <http://ln-s.net/9AvI> (at sprint1.openmrs.org:8080) |
| 14:26:18 | <wyclif> me too i reproduced it on sprint1 server |
| 14:26:21 | <djazayeri> and open up the Random Visit, and click on the Weight encounter |
| 14:26:32 | <djazayeri> Maybe it's a tomcat vs jetty issue |
| 14:26:36 | <dkayiwa> wyclif: any reason why user names and password are not admin test |
| 14:26:40 | <wyclif> hmm |
| 14:26:49 | <dkayiwa> i keep forgetting them |
| 14:26:54 | <dkayiwa> wyclif: |
| 14:26:56 | <wyclif> i just created that user for testing purposes |
| 14:27:06 | <djazayeri> dkayiwa: it's because we don't want to give admin privileges on this machine to the whole world |
| 14:27:12 | *** goutham has quit IRC |
| 14:27:16 | <djazayeri> since it's not locked down to prevent installing modules |
| 14:27:16 | <dkayiwa> oh i see |
| 14:27:21 | <dkayiwa> ok |
| 14:27:27 | <djazayeri> anyway, dkayiwa this error is reproducible on sprint1 |
| 14:27:32 | <djazayeri> and it's pretty obvious what the error is. |
| 14:27:54 | *** surangak_ has joined #openmrs |
| 14:27:57 | <dkayiwa> let me look into it and get back to you after scrum |
| 14:28:02 | <djazayeri> I'm assuming that (someone) wrote code like: "${ editUrl }?encounterId=${ encounterId }" |
| 14:28:10 | <dkayiwa> ok |
| 14:28:10 | *** surangak has quit IRC |
| 14:28:12 | <djazayeri> You just have to replace that with using a <c:url> as I commented |
| 14:28:13 | <wyclif> dkayiwa, i will try to reproduce it in my dev environment |
| 14:28:17 | <dkayiwa> ok |
| 14:28:49 | <wyclif> djazayeri, but that would cause a problem even for xforms |
| 14:29:37 | <djazayeri> wyclif, dkayiwa: the current patientEncounters portlet works just fine with all formentry modules. So just copy the url-construction logic from there... |
| 14:29:46 | <dkayiwa> ok |
| 14:29:53 | <djazayeri> alright, next up? |
| 14:29:54 | <djazayeri> wyclif? |
| 14:30:31 | <dkayiwa> djazayeri: do i click the edit button on the visit? |
| 14:30:38 | <djazayeri> click the view button |
| 14:30:46 | <wyclif> yesterday: |
| 14:30:46 | <wyclif> - Looked into concept validation failures |
| 14:30:46 | <wyclif> - Dev call |
| 14:30:46 | <wyclif> - Global Health Meeting |
| 14:30:46 | <wyclif> - TRUNK-2595 |
| 14:30:47 | <wyclif> - investigated about TRUNK-2677 |
| 14:30:49 | <wyclif> - created TRUNK-2684 |
| 14:30:51 | <wyclif> today: |
| 14:30:53 | <wyclif> - sprint and 1.9 tickets |
| 14:30:55 | <wyclif> blockers: none |
| 14:31:10 | <djazayeri> !ticket trunk-2595 |
| 14:31:10 | <wyclif> ii changed things a little djazayeri |
| 14:31:11 | <OpenMRSBot> djazayeri: [#TRUNK-2595] Redo UI of Add/Edit Provider page - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2595 |
| 14:31:23 | <djazayeri> wyclif: I noticed. I don't like the "piece of paper" icon. |
| 14:31:25 | <wyclif> i added a view encounters icon instead of a row click |
| 14:31:43 | <djazayeri> We need to find an icon that is intuitively recognizable as "open/close" |
| 14:31:50 | <wyclif> clicking the row was a problem if you also clicked the edit icon |
| 14:32:10 | <djazayeri> !ticket trunk-2677 |
| 14:32:11 | <OpenMRSBot> djazayeri: [#TRUNK-2677] Dashboard > Visits > edit encounter gives null pointer exception - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2677 |
| 14:32:16 | <wyclif> i agree with changing the icon djazayeri |
| 14:32:25 | <djazayeri> !ticket trunk-2684 |
| 14:32:26 | <OpenMRSBot> djazayeri: [#TRUNK-2684] Harmonize getProviders and getProvidersCount methods in the DAO layer - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2684 |
| 14:32:49 | <djazayeri> dkayiwa: btw, you also should add/remove tickets from this sprint |
| 14:32:57 | <dkayiwa> ok |
| 14:32:58 | <djazayeri> you're the release manager for 1.9, and this sprint is about getting 1.9 alpha out the door. |
| 14:33:03 | <downeym> djazayeri: did you check noun project? |
| 14:33:04 | <dkayiwa> ok |
| 14:33:16 | <djazayeri> so if there are tickets you think are not necessary for the alpha, you can remove them |
| 14:33:25 | <djazayeri> and if there are tickets that _are_ necessary, you can add them. |
| 14:33:30 | <djazayeri> downeym: noun? |
| 14:33:46 | <downeym> djazayeri: sorry i'm a beat too late, http://thenounproject.com/ |
| 14:33:51 | <djazayeri> oh |
| 14:34:35 | <djazayeri> I hadn't seen that before, but it's cool |
| 14:35:21 | <djazayeri> wyclif: any blockers? |
| 14:36:21 | <wyclif> no |
| 14:36:55 | <djazayeri> bwolfe: missing you on a call |
| 14:37:23 | <bwolfe> I was on 5 mins ago but no one else was, so I hung up...then forgot |
| 14:38:05 | <wyclif> djazayeri, are provider names supposed to be unqiue? |
| 14:38:12 | <djazayeri> wyclif: no |
| 14:38:15 | <wyclif> ok |
| 14:38:19 | <djazayeri> ids should be |
| 14:38:30 | <wyclif> ok |
| 14:38:36 | <wyclif> oh |
| 14:38:40 | <wyclif> actually i meant ids |
| 14:38:46 | <wyclif> right i created a duplicate |
| 14:38:51 | <wyclif> i will create a ticket for this |
| 14:38:55 | <djazayeri> don't allow duplicate ids, okay |
| 14:39:01 | <wyclif> ok |
| 14:43:30 | <rafa> my turn |
| 14:43:34 | <rafa> *** Rafal *** |
| 14:43:34 | <rafa> Today: |
| 14:43:34 | <rafa> * Worked on META-4. It's slightly more work than I expected. I'll work over the weekend to finish that since I was absent yesterday and was not productive in a train due to a lovely company ;-) (mission accomplished, got my VISA). I plan to implement all what is needed for the reporting module and let Michael test it and debug if necessary since I need to move on to 1.9 tickets starting from Monday. |
| 14:43:34 | <rafa> Weekend: |
| 14:43:34 | <rafa> * META-4 |
| 14:43:34 | <rafa> Monday: |
| 14:43:35 | <rafa> * 1.9 tickets |
| 14:43:35 | <rafa> No blockers. |
| 14:43:52 | <bwolfe> rafa, did you get her number? |
| 14:44:02 | <downeym> o.O |
| 14:44:19 | <rafa> bwolfe: well she lives too far away anyway |
| 14:44:29 | <bwolfe> weak sauce |
| 14:44:41 | <rafa> bwolfe: but yep got her facebook :P |
| 14:47:31 | <djazayeri> rafa: good work |
| 14:47:41 | <djazayeri> (it's important to know that your priorities are correct) |
| 14:48:13 | <djazayeri> rafa: per my email, starting monday, even if this MDS isn't done, you've got to switch back to the 1.9 sprint. |
| 14:49:01 | <rafa> djazayeri: yes, I understand |
| 14:49:05 | <djazayeri> cool |
| 14:49:47 | <djazayeri> my report |
| 14:49:49 | <djazayeri> Thursday |
| 14:49:49 | <djazayeri> * Implementers forum |
| 14:49:49 | <djazayeri> * Developers forum |
| 14:49:49 | <djazayeri> * Leadership call |
| 14:49:49 | <djazayeri> * Worked on TRUNK-2588 (review and refactor new attribute framework) |
| 14:49:50 | <djazayeri> * bunch of code reviews (not enough though) |
| 14:49:51 | <djazayeri> Today |
| 14:49:51 | <djazayeri> * Finish sprint code reviews |
| 14:49:52 | <djazayeri> * Send an email about TRUNK-2588 (review and refactor new attribute framework) |
| 14:49:52 | <djazayeri> * Another ticket (maybe look at merging providers branch?) |
| 14:49:53 | <djazayeri> no blockers |
| 14:53:35 | *** pascal` has quit IRC |
| 14:56:28 | *** upul` has quit IRC |
| 14:58:54 | <dkayiwa> hi bwolfe |
| 14:59:42 | <bwolfe> hi dkayiwa |
| 14:59:47 | <dkayiwa> bwolfe: as for TRUNK-2680 editing person throws not-null property references a null or transient value: org.openmrs.PersonAttribute.value for attributes without empty strings |
| 14:59:56 | <bwolfe> downeym, not impressed with the nounproject's icons |
| 14:59:59 | <bwolfe> they need more |
| 15:00:00 | <dkayiwa> bwolfe: that is from the web interface |
| 15:00:11 | <downeym> bwolfe: it's open source, patches welcome :P |
| 15:01:10 | <bwolfe> dkayiwa, right, I figured that would happen |
| 15:01:16 | <dkayiwa> :) |
| 15:01:21 | <bwolfe> so person_attributes need to change before you can commit |
| 15:01:32 | <dkayiwa> bwolfe: so should i work on the other ticket? |
| 15:01:41 | <bwolfe> probably: not saving ones with empty string + voiding the old one |
| 15:02:11 | <dkayiwa> bwolfe: the one which you said modifies the the api not to save attributes with empty strings? |
| 15:02:18 | <dkayiwa> bwolfe: do you know the ticket number? |
| 15:03:06 | <bwolfe> dkayiwa, no, but I'd know if if I saw it |
| 15:03:14 | <dkayiwa> ok |
| 15:03:39 | <dkayiwa> bwolfe: assuming i have seen it, how do i void the existing attribute with an empty string? |
| 15:03:49 | <dkayiwa> bwolfe: because it will still not save |
| 15:05:10 | <bwolfe> dkayiwa, if an empty string is being saved and there is already an attr with that key for that patient, void the previous but don't save the empty string one |
| 15:05:28 | <chopin> if ConceptWord does not extend BaseOpenmrsObject, will it not get an autoincrement identifier? |
| 15:05:49 | <dkayiwa> ok |
| 15:06:16 | <dkayiwa> bwolfe: so the previous one is non empty? |
| 15:06:45 | <bwolfe> right |
| 15:06:49 | <dkayiwa> ok |
| 15:07:02 | <bwolfe> dkayiwa, and you need to make a changeset to delete all person attrs with an empty value |
| 15:07:06 | <bwolfe> chopin, huh? |
| 15:07:11 | <dkayiwa> ok |
| 15:07:24 | <bwolfe> my (late) update: |
| 15:07:24 | <bwolfe> 10am: reviewed TRUNK-362, TRUNK-2616, sync docs |
| 15:07:25 | <bwolfe> 11am: sync docs, trunk ticket reviews |
| 15:07:25 | <bwolfe> 12pm: cleaned up sprint tickets, TRUNK-389 |
| 15:07:25 | <bwolfe> 1pm: lunch |
| 15:07:25 | <bwolfe> 2pm: SYNC-233, committed TRUNK-389, other sprint reviews |
| 15:07:26 | <bwolfe> 3pm: sprint reviews |
| 15:07:28 | <bwolfe> 4pm: sprint reviews, sync troubleshooting with ampath |
| 15:07:30 | <bwolfe> 5pm: irc help, SYNC-234, scrap reports |
| 15:07:32 | <bwolfe> 6pm: scrum, call planning call |
| 15:09:33 | <djazayeri> !ticket trunk-362 |
| 15:09:35 | <OpenMRSBot> djazayeri: [#TRUNK-362] HL7 message routing improvements - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-362 |
| 15:09:44 | <djazayeri> !ticket trunk-2616 |
| 15:09:45 | <OpenMRSBot> djazayeri: [#TRUNK-2616] Add regex validation to PersonNameValidator - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2616 |
| 15:09:46 | <chopin> bwolfe, concept_word has autoincrement on the column definition ... but I get MySQLIntegrityConstraintViolationException: Column 'concept_name_id' cannot be null ... when importing using MDS |
| 15:11:13 | <chopin> ... and i assume the saving of ConceptWord is done automatically when saving a concept name |
| 15:11:30 | <dkayiwa> bwolfe: did you mean TRUNK-2004 ? |
| 15:11:49 | <djazayeri> bwolfe: I don't like your new format |
| 15:12:04 | <dkayiwa> :) |
| 15:12:05 | *** bwolfe_ has joined #openmrs |
| 15:12:05 | *** ChanServ sets mode: +o bwolfe_ |
| 15:12:10 | <djazayeri> was nicer when you had ticket descriptions |
| 15:12:57 | <chopin> just include ! before each ticket in your report |
| 15:13:19 | *** lh has joined #openmrs |
| 15:13:59 | *** lh has joined #openmrs |
| 15:16:22 | *** bwolfe has quit IRC |
| 15:18:03 | *** dkayiwa has left #openmrs |
| 15:18:52 | <chopin> wyclif, is there a reason you didn't use saveOrUpdate() in HibernateConceptDAO.updateConceptWord()? |
| 15:19:32 | <wyclif> chopin, i didnt wirte that, u need to ask ben |
| 15:19:41 | <chopin> ah thx wyclif |
| 15:19:49 | <chopin> bwolfe, is there a reason you didn't use saveOrUpdate() in HibernateConceptDAO.updateConceptWord()? |
| 15:20:50 | <wyclif> chopin, i gues is that concept words are never update but rather replaced |
| 15:21:08 | <wyclif> i.e rebuild them each time |
| 15:21:25 | <wyclif> so it would make sense to call saveOrUpdate |
| 15:21:32 | <wyclif> sorry! wouldnt |
| 15:21:42 | <chopin> wyclif, ok ... just wondering how one could be getting by with concept_word_id set to null and not autogenerated |
| 15:21:46 | <wyclif> so i agree with save |
| 15:28:32 | *** surangak_ has quit IRC |
| 15:34:36 | <chopin> wyclif, i agree with evict+save, just trying to understand how a ConceptWord with id=null could slip by and actually cause a MySQL error like I saw above |
| 15:56:44 | *** jriley has quit IRC |
| 16:00:56 | *** rafa has quit IRC |
| 16:05:21 | <bwolfe_> chopin, is there a null in your db? |
| 16:05:23 | *** bwolfe_ is now known as bwolfe |
| 16:05:51 | <bwolfe> bbl |
| 16:27:33 | *** rafa has joined #openmrs |
| 16:27:33 | *** ChanServ sets mode: +v rafa |
| 16:43:19 | <chopin> bwolfe, looking ... |
| 16:54:43 | <chopin> bwolfe, nope |
| 16:59:49 | *** rafa has quit IRC |
| 17:18:24 | <djazayeri> wyclif: why did you make TRUNK-2330 part of the current sprint? |
| 17:18:52 | <djazayeri> Is it strictly required for 1.9 alpha? (I left it out because I think it's a bugfix that can be dealt with post-alpha) |
| 17:19:27 | <downeym> does anyone know the size limit of a hosted project on code.google.com? |
| 17:19:41 | <wyclif> djazayeri, ok |
| 17:19:56 | <wyclif> djazayeri, removed it |
| 17:25:42 | <djazayeri> np |
| 17:39:56 | *** gbastien has quit IRC |
| 17:45:08 | *** rafa has joined #openmrs |
| 17:45:08 | *** ChanServ sets mode: +v rafa |
| 17:52:17 | <bwolfe> downeym, over 9000!!!!!!!! |
| 17:52:27 | <downeym> 9kb isn't bad |
| 17:53:11 | <downeym> after all bill gates said 640k ought to be enough for anybody |
| 17:53:44 | <downeym> we are more efficient these days |
| 18:20:36 | *** morristic has joined #openmrs |
| 18:37:35 | *** bwolfe has quit IRC |
| 18:43:08 | *** gbastien has joined #openmrs |
| 18:48:20 | *** bwolfe has joined #openmrs |
| 18:48:20 | *** ChanServ sets mode: +o bwolfe |
| 18:49:24 | <robbyoconnor> any updates? |
| 18:57:13 | <chopin> rafa, do you have time to look at a package that doesn't seem to be working for me? |
| 18:58:09 | <rafa> chopin: Not now, but you could file a ticket and attach your package. I'll look at it over the weekend. |
| 18:58:29 | <chopin> rafa, ok will do ... thx |
| 18:58:59 | <chopin> what kills me is that it is fine when i import it to my local, blank instance |
| 18:59:34 | <rafa> chopin: ohh that might be hard to reproduce for me |
| 19:01:17 | <chopin> yep |
| 19:01:21 | <chopin> arrgh |
| 19:19:16 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #OpenMRS is excited to participate in the @GSoC Doc Summit next month! Read more: http://t.co/rT7L1seL <http://twitter.com/OpenMRS/statuses/117311635324026880> |
| 19:30:16 | *** mnunez has joined #openmrs |
| 19:36:42 | *** r0bby has joined #openmrs |
| 19:36:42 | *** ChanServ sets mode: +v r0bby |
| 19:36:47 | <r0bby> hai |
| 20:36:16 | <mnunez> Gentlemen, I'm a little scared right now |
| 20:36:49 | <mnunez> I confirm the deletion of a patient by replacing his/hers standard drug regimen |
| 20:37:17 | <bwolfe> mnunez, huh? |
| 20:37:27 | <bwolfe> is it asking you to delete the patient when you do that? |
| 20:38:25 | <mnunez> There seems to be a bug that deletes the whole patient (or at least hides it) while replacing his standard drug regimen from the regimens tab |
| 20:38:40 | <mnunez> Done it with the demo aswell |
| 20:39:08 | <bwolfe> mnunez, can you give me a step by step of how to repeat it on demo? |
| 20:39:22 | <bwolfe> (I'm 99.9% sure the patient isn't getting deleted...)_ |
| 20:39:43 | <mnunez> Says "Patient has been deleted" on top of the screen... |
| 20:39:57 | <mnunez> And I can't find it with the search tool... |
| 20:40:14 | <mnunez> Adding it to the ticket I posted. |
| 20:41:49 | <bwolfe> very strange |
| 20:41:59 | <bwolfe> mnunez, can you link me to your ticket? |
| 20:42:21 | <bwolfe> fyi: "deleted" usually means "voided box checked" for the patient |
| 20:43:01 | <mnunez> Sure bwolfe. Posting screenshot |
| 20:43:31 | <bwolfe> downeym, is demo running behind apache? |
| 20:43:37 | <bwolfe> or is tomcat serving directly? |
| 20:43:57 | <downeym> bwolfe: the former |
| 20:44:15 | <bwolfe> modjk running? |
| 20:44:27 | <bwolfe> do you know if mod_deflate is used for gzipping, etc? |
| 20:45:51 | <downeym> bwolfe: mod_proxy_ajp, not mod_jk |
| 20:46:10 | <downeym> bwolfe: and yes |
| 20:46:24 | <bwolfe> coo |
| 20:46:28 | <bwolfe> downeym++ |
| 20:47:06 | <downeym> bwolfe: however you didn't ask if we're using mod_deflate, which we aren't |
| 20:47:41 | <bwolfe> huh? I did ask.. |
| 20:48:54 | *** chopin has quit IRC |
| 20:49:17 | <bwolfe> mnunez, whoa, I see the error now |
| 20:49:25 | <bwolfe> it is voiding the patient apparently |
| 20:49:32 | <bwolfe> when you click the "stop this category" button |
| 20:51:41 | *** chughgaurav has joined #openmrs |
| 20:53:08 | <mnunez> bwolfe: https://tickets.openmrs.org/browse/TRUNK-2674?focusedCommentId=175970#comment-175970 |
| 20:53:13 | <OpenMRSBot> <http://ln-s.net/9AzB> (at tickets.openmrs.org) |
| 20:54:32 | <bwolfe> mnunez, ok, I see the bug |
| 20:54:35 | <bwolfe> very very very strange |
| 20:54:36 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Patient Flags 1.3.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=patientflags&version=&1.3.0> |
| 20:56:38 | <robbyoconnor> hey bwolfe: you're on the leadership team right? Any updates...trying to not pester :/ |
| 20:58:41 | <bwolfe> an update on scholarships I assume? I have none |
| 20:58:49 | <robbyoconnor> yeh |
| 20:59:13 | <robbyoconnor> I'm trying to be patient...if i *DO* get funded...I need to get vaccinations...and those need time... :/ |
| 20:59:55 | <bwolfe> meh, vaccinations shmaccinations |
| 21:00:42 | <robbyoconnor> yeh let me bring back diseases |
| 21:01:42 | *** lh has quit IRC |
| 21:10:35 | <robbyoconnor> bwolfe: I don't know about you...but I don't wanna bring back anything :P |
| 21:10:50 | <downeym> yellow fever isn't that bad :) |
| 21:11:10 | <robbyoconnor> I like being healthy |
| 21:12:16 | <downeym> yeah, suppose that is preferable |
| 21:12:37 | *** r0bby has quit IRC |
| 21:13:36 | <bwolfe> malaria is the new weight loss program |
| 21:30:33 | *** bwolfe has quit IRC |
| 21:45:37 | * robbyoconnor sighs |
| 21:48:04 | *** rafa has quit IRC |
| 22:17:37 | *** chopin has joined #openmrs |
| 22:17:37 | *** ChanServ sets mode: +v chopin |
| 22:29:16 | *** chopin has quit IRC |
| 22:34:19 | *** wyclif has quit IRC |
| 22:40:35 | *** chopin has joined #openmrs |
| 22:40:35 | *** ChanServ sets mode: +v chopin |
| 22:55:46 | *** chughgaurav has quit IRC |
| 23:34:30 | *** wyclif has joined #openmrs |
| 23:39:34 | *** downeym has quit IRC |