00:03:58
|
*** wyclif has joined #openmrs
|
00:06:51
|
*** gbastien has quit IRC
|
00:20:05
|
*** gbastien has joined #openmrs
|
01:28:47
|
*** chopin has joined #openmrs
|
01:35:13
|
*** wyclif has quit IRC
|
02:09:59
|
*** chopin has quit IRC
|
02:22:13
|
*** gbastien has quit IRC
|
02:30:58
|
*** r0bby has joined #openmrs
|
02:30:58
|
*** ChanServ sets mode: +v r0bby
|
02:41:35
|
*** gbastien has joined #openmrs
|
02:58:24
|
*** upul` has joined #openmrs
|
02:58:24
|
*** ChanServ sets mode: +v upul`
|
03:26:16
|
*** wyclif has joined #openmrs
|
03:35:27
|
*** lh_ has joined #openmrs
|
03:35:27
|
*** lh_ has joined #openmrs
|
03:35:27
|
*** lh has quit IRC
|
03:35:27
|
*** lh_ is now known as lh
|
03:41:58
|
*** r0bby is now known as robbyoconnor
|
03:57:58
|
*** gbastien has quit IRC
|
04:05:26
|
*** lh has quit IRC
|
04:05:48
|
*** lh has joined #openmrs
|
04:39:37
|
*** surangak has joined #openmrs
|
05:13:34
|
*** deadpool_ has joined #openmrs
|
05:22:04
|
*** deadpool_ has quit IRC
|
05:35:06
|
*** deadpool_ has joined #openmrs
|
05:44:21
|
*** Echidna has quit IRC
|
05:44:38
|
*** Echidna has joined #openmrs
|
05:44:38
|
*** ChanServ sets mode: +v Echidna
|
05:49:37
|
*** vsharma has joined #openmrs
|
05:50:39
|
<vsharma> Hey guys ... There is a module called sockethl7listener ... https://modules.openmrs.org/modules/view.jsp?module=sockethl7listener
|
05:50:45
|
<OpenMRSBot> <http://ln-s.net/9:9+> (at modules.openmrs.org)
|
05:51:11
|
<vsharma> Description says - Accepts and processes hl7 messages into openmrs objects by listening on a port
|
05:51:34
|
<vsharma> Was anyone able to make this work? I am getting errors after uploading it
|
05:52:35
|
<vsharma> deadpool_: lh surangak wyclif Echidna robbyoconnor upul` - ?
|
05:54:11
|
<deadpool_> vsharma: sorry i haven't used that module before
|
05:54:18
|
<deadpool_> what is the error?
|
05:54:40
|
<surangak> hi vsharma afraid I have not used it either... :-(
|
05:55:03
|
<vsharma> deadpool_: the error is .... Error while trying to start module Not all required modules are started: org.openmrs.module.chirdlutil 1.0.6. Module: sockethl7listener ** org.openmrs.module.ModuleFactory.startModuleInternal(ModuleFactory.java:464) ** org.openmrs.api.context.Daemon$1.run(Daemon.java:56)
|
05:56:00
|
<surangak> vsharma, you need to install these modules before trying to install the sockethl7 listener
|
05:56:55
|
<surangak> vsharma, see https://modules.openmrs.org/modules/view.jsp?module=chirdlutil
|
05:57:00
|
<OpenMRSBot> <http://ln-s.net/9:9A> (at modules.openmrs.org)
|
05:57:02
|
<vsharma> surangak: you mean there is a module "chirdlutil" which I need to install?
|
05:57:09
|
<deadpool_> yeah
|
05:57:15
|
<deadpool_> surangak: is right
|
05:57:30
|
<vsharma> Oh ok... Let me try deadpool_ surangak .. thanks guys
|
05:58:04
|
<surangak> vsharma, im sure installing this module should get rid of that error message... :-)
|
05:58:53
|
<vsharma> Hopefully, surangak :-) ...
|
06:01:33
|
<vsharma> deadpool_: surangak ...OK.. So, the pessimist in me was right :-( ..
|
06:01:48
|
<vsharma> Installing chirdlutil also fails
|
06:01:58
|
<vsharma> different errors though
|
06:02:07
|
<deadpool_> what error do you get there?
|
06:02:10
|
<surangak> can u show us the error message ?
|
06:02:22
|
<deadpool_> if it is big use pastebin.com
|
06:03:16
|
<vsharma> Error while trying to start module Error while running sql: INSERT INTO scheduler_task_config (`name`, `schedulable_class`, `start_time`, `start_time_pattern`, `repeat_interval`, `start_on_startup`, `started`, `created_by`, `date_created`) SELECT 'Cron job archiving Tomcat log files','org.openmrs.module.chirdlutil.LogArchiveCron', NOW(), 'MM/dd/yyyy HH:mm:ss', 604800, 1, 0, 1, NOW() FROM (s
|
06:03:33
|
<vsharma> Sorry - haven't used pastebin so far
|
06:04:40
|
<deadpool_> you should because there is more to the error
|
06:06:02
|
<vsharma> deadpool_: Setting up account now
|
06:06:16
|
<deadpool_> vsharma: you don't need to setup an account
|
06:06:45
|
<vsharma> http://pastebin.com/k59Jfkrh
|
06:12:48
|
*** deadpool_ has quit IRC
|
06:14:47
|
<vsharma> Any luck with the errors on http://pastebin.com/k59Jfkrh?
|
06:16:24
|
<vsharma> Both these modules are by tmdugan .. Any idea how I can get in touch with him/her?
|
06:25:39
|
*** deadpool_ has joined #openmrs
|
06:28:02
|
<deadpool_> vsharma: seems like an sql error you should send an email to the dev group to see if they can solve it
|
06:33:31
|
<vsharma> deadpool_: Is there a mailer list or an email id for the dev group?
|
06:33:51
|
<deadpool_> yeah dev@openmrs.org
|
06:34:04
|
<vsharma> OK.. Thanks// deadpool_
|
06:34:59
|
*** rafa has joined #openmrs
|
06:34:59
|
*** ChanServ sets mode: +v rafa
|
07:01:53
|
*** deadpool_ has quit IRC
|
07:09:06
|
*** dkayiwa has joined #openmrs
|
07:14:54
|
*** deadpool_ has joined #openmrs
|
07:25:57
|
*** bwolfe has joined #openmrs
|
07:25:57
|
*** ChanServ sets mode: +o bwolfe
|
07:38:17
|
*** pascal` has joined #openmrs
|
07:42:38
|
*** pascal` has quit IRC
|
07:58:26
|
*** pascal` has joined #openmrs
|
08:08:34
|
<surangak> bwolfe, howdy, can i talk about https://tickets.openmrs.org/browse/SYNC-66
|
08:27:50
|
*** deadpool_ has quit IRC
|
08:35:57
|
*** lh_ has joined #openmrs
|
08:35:57
|
*** lh_ has joined #openmrs
|
08:35:57
|
*** lh has quit IRC
|
08:35:57
|
*** lh_ is now known as lh
|
08:40:24
|
*** deadpool_ has joined #openmrs
|
08:41:04
|
*** bryq has joined #openmrs
|
08:41:04
|
*** ChanServ sets mode: +v bryq
|
09:05:57
|
*** lh has quit IRC
|
09:05:57
|
*** lh_ has joined #openmrs
|
09:05:57
|
*** lh_ is now known as lh
|
09:33:34
|
*** deadpool_ has quit IRC
|
09:45:38
|
*** deadpool_ has joined #openmrs
|
09:54:30
|
<pascal`> bwolfe, what could cause this: Caused by: org.openmrs.api.APIException: Service not found: interface org.openmrs.module.patientflags.api.FlagService ?
|
09:54:33
|
*** ChanServ sets mode: +v pascal`
|
09:54:45
|
*** rafa has quit IRC
|
09:54:52
|
<pascal`> bwolfe, the module is up and running.
|
10:20:27
|
<bwolfe> pascal`, could be your module doesn't have patientflags listed in the config.xml file?
|
10:26:19
|
<pascal`> bwolfe, this is happening when the patient dashboard loads.
|
10:26:39
|
<pascal`> bwolfe, but if i go to the management pages, it finds the service fine.
|
10:26:48
|
<bwolfe> surangak, we can talk now if you want
|
10:27:03
|
<pascal`> bwolfe, further, if i stop and start the module then it's fine
|
10:27:25
|
<bwolfe> strange
|
10:27:33
|
<bwolfe> how/where is the call happening? from a scriptlet?
|
10:27:35
|
<bwolfe> or from a controller?
|
10:28:19
|
<pascal`> bwolfe, I'm not entirely sure. It's the when it's trying to determine the flags for a patient.
|
10:29:16
|
<pascal`> bwolfe, http://pastie.org/2536612
|
10:31:32
|
<bwolfe> can you glance at the patientflags portlet to see how its doing it?
|
10:33:11
|
<pascal`> bwolfe, http://pastie.org/2536620
|
10:33:33
|
<bwolfe> so must be int he controller for its portlet then?
|
10:33:37
|
<bwolfe> that should be 100% fine :-/
|
10:34:39
|
<pascal`> bwolfe, I know :\
|
10:34:59
|
<pascal`> bwolfe, the stack trace doesn't look like it's coming from the controller though, which is weird.
|
10:35:27
|
<pascal`> bwolfe, at the moment this is all in my dev environment, but I'll test in pre-prod later today.
|
10:35:54
|
<pascal`> bwolfe, I hope Patient Flags is robust enough for production (esp since I've put some work into customizing it)
|
10:36:13
|
<bwolfe> pih has been using it for a long time
|
10:36:16
|
<bwolfe> and so has james in haiti
|
10:36:23
|
<bwolfe> I'm sure there are others, its a pretty neat module
|
10:37:08
|
<pascal`> bwolfe, it's great, well except for:
|
10:37:12
|
<pascal`> !ticket FLAG-4
|
10:37:13
|
<OpenMRSBot> pascal`: [#FLAG-4] Problem creating Custom Evaluators for Patient Flags - OpenMRS JIRA - https://tickets.openmrs.org/browse/FLAG-4
|
10:37:47
|
<pascal`> bwolfe, but otherwise it's really nice and extensible... although I would like the ability to create dynamic flag messages :).
|
10:38:08
|
<pascal`> bwolfe, I hope the problems I'm having are just environmental.
|
10:38:13
|
<bwolfe> right, but thats not its fault, right?
|
10:39:06
|
*** deadpool_ has quit IRC
|
10:40:12
|
<surangak> hi bwolfe , i was looking at https://tickets.openmrs.org/browse/SYNC-66
|
10:40:25
|
<surangak> I have to add 'delete' function to parent servers
|
10:40:43
|
<surangak> looking at the code, its seems to be that delete parent server is just as same as delete child server
|
10:40:55
|
<surangak> so looks like i can re use the same ol' code
|
10:41:44
|
<surangak> but assuing tht later on someone may need to do something differnt for parent servers, should I re use, or just go ahead and add and else if {}
|
10:41:45
|
<surangak> :-)
|
10:42:10
|
<pascal`> bwolfe, right. The module is great, I just need to sort out the issues I'm having.
|
10:42:43
|
<bwolfe> surangak, yes, you'll need to test deleting after it has run for a few sessions
|
10:42:48
|
<bwolfe> and maybe make it a double warning
|
10:42:50
|
<bwolfe> :-)
|
10:43:30
|
<surangak> bwolfe, double warning ? u mean to give a more serious sounding 'warning mesage' ?
|
10:44:02
|
<bwolfe> yes
|
10:44:13
|
<bwolfe> an 'are you sure' warning
|
10:44:18
|
<bwolfe> and the an "are you really sure" warning
|
10:44:19
|
<bwolfe> :-0
|
10:44:20
|
<bwolfe> :-)
|
10:45:01
|
<surangak> bwolfe, righto, ill start on it :-)
|
10:47:27
|
<surangak> bwolfe, sorry, did u also mean that I should duplicate the same code or generlize exising controller class code so that it would support both parent and child server deletion :-)
|
10:47:44
|
<bwolfe> reusing code is always a better option
|
10:48:17
|
<surangak> bwolfe, thanks, will do...
|
10:52:38
|
*** deadpool_ has joined #openmrs
|
11:25:22
|
*** deadpool_ has quit IRC
|
11:27:59
|
*** bryq1 has joined #openmrs
|
11:28:45
|
*** ningosi has joined #openmrs
|
11:28:58
|
*** bryq has quit IRC
|
11:30:51
|
<pascal`> bwolfe, I can't seem to shake this issue.
|
11:31:02
|
<pascal`> bwolfe, is it normal that it says this: ERROR - errorhandler_jsp._jspService(72) |2011-09-15 13:29:39,283| Error on page /openmrs/errorhandler.jsp
|
11:31:34
|
<bwolfe> I don't think so
|
11:31:42
|
<bwolfe> whats your env pascal`?
|
11:32:29
|
*** rafa has joined #openmrs
|
11:32:29
|
*** ChanServ sets mode: +v rafa
|
11:32:30
|
<pascal`> bwolfe, ubuntu, tomcat6, sun java 1.6
|
11:32:44
|
<pascal`> bwolfe, slightly customized 1.7.x
|
11:32:59
|
<bwolfe> strange
|
11:33:55
|
<pascal`> bwolfe, tell me about it.
|
11:34:38
|
<pascal`> bwolfe, how is it possible that it finds the service when i'm on the module's admin pages, but not when i'm on the dashboard
|
11:36:40
|
<pascal`> bwolfe, it's happening here in the module: at org.openmrs.module.patientflags.extension.html.FlagPatientDashboardHeaderExt.getOverrideContent(FlagPatientDashboardHeaderExt.java:34)
|
11:36:45
|
<bwolfe> not sure
|
11:36:52
|
<bwolfe> do you have two of hte module loaded?
|
11:36:58
|
<bwolfe> or a diff module coming in?
|
11:37:02
|
<bwolfe> what all moduels are you running?
|
11:37:15
|
<bwolfe> you can try removing yours or other ones that might be causing the issue
|
11:37:22
|
<bwolfe> just run with patientflags for a bit and nothing else
|
11:38:02
|
*** upul` has quit IRC
|
11:38:25
|
<pascal`> bwolfe, i'm running a few, some of which I need, but i'll give it a try
|
11:38:53
|
<pascal`> bwolfe, also, that dashboard extension class is in the web/src folder, which I haven't seen before.
|
11:41:27
|
*** irfn has joined #openmrs
|
11:42:56
|
<surangak> hmm.. I have set up patient and child servers, and am trying to syncronize, but it keeps saying 'sending 0 items to parent...
|
11:44:39
|
<bwolfe> surangak, update to latest again
|
11:44:50
|
<pascal`> bwolfe, stopped everything besides HTML Form Entry and Patient Flags.
|
11:44:58
|
<surangak> bwolfe, oooh, thanks ;-)
|
12:03:54
|
*** ningosi has quit IRC
|
12:10:30
|
*** vsharma has quit IRC
|
12:19:26
|
*** dkayiwa has quit IRC
|
12:26:13
|
*** wyclif has quit IRC
|
12:28:55
|
*** irfn has quit IRC
|
12:34:23
|
<pascal`> I'm consistently getting this issue bwolfe, any ideas how I might be able to debug this?
|
12:37:35
|
<bwolfe> you're getting it with just htmlformentry and patientflags installed? (and logic) ?
|
12:40:23
|
<pascal`> bwolfe, haha, I've getting it in pre-prod even when the module is stopped now!
|
12:40:33
|
<pascal`> (and yes)
|
12:40:48
|
<bwolfe> pascal`, must be your setup
|
12:40:52
|
<bwolfe> what have you done to tomcat?
|
12:40:54
|
<bwolfe> any caching?
|
12:40:57
|
<pascal`> haha
|
12:41:08
|
<pascal`> i removed the module and it's still happening
|
12:41:14
|
<pascal`> must be caching, let me restart tomcat
|
12:42:47
|
<pascal`> bwolfe, all I've done to the module is create a few custom evaluators and I'm programmatically adding some flags (and tags and priorities) in the activator.
|
12:45:05
|
*** dkayiwa has joined #openmrs
|
12:45:13
|
<dkayiwa> hi bwolfe
|
12:45:18
|
<bwolfe> hey
|
12:46:31
|
<dkayiwa> bwolfe: when the test fails in a spawned thread, the parent junit test thread is not considered as failed (it passes) SYNC-200
|
12:46:49
|
<bwolfe> boo
|
12:47:20
|
<bwolfe> so you need to set a variable that both threads can read and then check that var at the end of the parent unit test
|
12:48:12
|
<dkayiwa> bwolfe: i even tried to sleep in the parent thread to ensure that it exists only when the spawned thread has returned. it still passed despite the fact that the spawned thread had failed the assertion
|
12:48:24
|
<dkayiwa> bwolfe: thanks for the tip. let me try that
|
12:54:55
|
<bwolfe> dkayiwa, did you implement by suggestion of how to run them both at the same time ?
|
12:56:34
|
<dkayiwa> bwolfe: i first wanted to get rid of the problem where failing of a spawned thread does not make the parent thread fail
|
12:58:26
|
<bwolfe> you mean DOES make the parent thread fail?
|
12:58:54
|
*** chopin has joined #openmrs
|
12:58:55
|
<dkayiwa> bwolfe: DOES NOT
|
12:59:30
|
<dkayiwa> bwolfe: when the assertion fails in the spawned thread, the test passes
|
13:01:56
|
*** sunbiz has joined #openmrs
|
13:01:56
|
*** ChanServ sets mode: +v sunbiz
|
13:03:12
|
*** chopin has quit IRC
|
13:06:09
|
*** lh has quit IRC
|
13:06:20
|
*** lh has joined #openmrs
|
13:06:20
|
*** lh has joined #openmrs
|
13:16:10
|
*** chopin has joined #openmrs
|
13:16:42
|
*** wyclif has joined #openmrs
|
13:38:20
|
*** MarkG has joined #openmrs
|
13:44:08
|
<MarkG> fwiw, with the sync trunk, SyncUserTest_shouldSyncUserPropertyRemove is failing for me when run via maven, though it passes when run via junit
|
13:45:21
|
<bwolfe> ugh. looks like ci should have reported that to us except its hung on last nights nightly build :-/
|
13:45:40
|
<MarkG> correction... it is shouldSyncUserPropertyUpdate that is failing...
|
13:45:51
|
<bwolfe> MarkG, with the latest latest update ?
|
13:46:01
|
<bwolfe> I have all tests passing in mine only a few minutes ago
|
13:46:12
|
<MarkG> yep
|
13:46:19
|
<MarkG> but note, it was working with me via junit
|
13:46:53
|
<MarkG> so i don't think it's an actual error... just a problem with mvn tests... either everywhere, or just on my machine, if it works for you...
|
13:49:14
|
<pascal`> Hey MarkG
|
13:50:25
|
<MarkG> hey pascal`
|
13:51:15
|
<MarkG> bwolfe: maybe since the mvn clean install i ran didn't complete, my junit was running off old code?
|
13:51:30
|
<MarkG> bwolfe: looks like it might just be an assertFalse that should be an assertTrue...
|
13:52:07
|
<MarkG> bwolfe: it is failing on SyncUserTest:243. looks like that should be true, no?
|
13:53:28
|
<MarkG> bwolfe: yep, did a mvn -DskipTests clean install and now the junit test fails... but it looks like it's just a mistake in the test
|
13:53:56
|
<bwolfe> USER_PROPERTY_CHANGE_PASSWORD is set to false in the test
|
13:53:59
|
<bwolfe> so it shoudl be doing an assertFalse
|
13:54:10
|
<MarkG> bwolfe: whoops, ignore my last line... :)
|
13:54:20
|
<bwolfe> MarkG, are you using a modified version of sync?
|
13:54:24
|
<bwolfe> with wyclif's patch perhaps?
|
13:55:16
|
<wyclif> i didnt commit the patch
|
13:55:36
|
<bwolfe> I know, but he might have applied it to his local copy
|
13:56:16
|
<wyclif> ok
|
13:56:43
|
<wyclif> the patch only has changes in one file, the interceptor
|
13:56:46
|
<MarkG> bwolfe: nope
|
13:57:07
|
<MarkG> bwolfe: it's not wyclif's patch... stop trying to blame him... :)
|
13:57:47
|
<bwolfe> bummer, was hoping to have a whipping boy
|
13:57:48
|
*** pascal` has quit IRC
|
13:57:48
|
<bwolfe> :-D
|
13:59:47
|
<MarkG> bwolfe: yep, sorry, the test looks correct...
|
13:59:54
|
<MarkG> bwolfe: and it is working for me in junit
|
14:00:04
|
<MarkG> bwolfe: let me try maven again...
|
14:00:21
|
<bwolfe> ha
|
14:02:37
|
<MarkG> bwolfe: so if you run mvn clean install from sync-parent all tests pass? it is still failing for me... might be something wonky on my windows machine... i can live with it if the junit version passes...
|
14:02:59
|
*** gbastien has joined #openmrs
|
14:04:01
|
* bwolfe runs it again. this time with clean
|
14:12:12
|
*** chopin has quit IRC
|
14:25:01
|
*** wyclif has quit IRC
|
14:25:52
|
*** wyclif has joined #openmrs
|
14:26:11
|
<MarkG> bwolfe: of course, i just applied Wyclif's patch b\c i wanted to test it out, and it looks like all my tests passed this time...
|
14:28:06
|
*** chopin has joined #openmrs
|
14:28:06
|
<wyclif> bwolfe, MarkG, SyncUtilTransmissionTest seems like sometimes it can fail or pass, some a changes was made to it
|
14:28:22
|
<wyclif> some were changes were made to it
|
14:28:31
|
<wyclif> some changes were made to it
|
14:29:06
|
<bwolfe> if think thats the one dkayiwa is working on
|
14:30:44
|
*** pascal` has joined #openmrs
|
14:35:34
|
*** wyclif has quit IRC
|
14:36:20
|
*** chopin has quit IRC
|
14:36:23
|
<dkayiwa> correct
|
14:40:16
|
<bwolfe> dkayiwa, if you don't figure it out today, just forget it. a test is not work 3 days of your time !
|
14:40:26
|
<bwolfe> just add @Ignore back on it and move on
|
14:40:37
|
<dkayiwa> ok
|
14:43:53
|
*** pascal` has quit IRC
|
14:47:52
|
*** wyclif has joined #openmrs
|
14:57:05
|
<dkayiwa> is freeconferencing on?
|
14:58:01
|
<bwolfe> dkayiwa, no, freeconf's skype connection is dead
|
14:58:08
|
<bwolfe> dkayiwa, you have to listen through connect.openmrs.org
|
14:58:08
|
<dkayiwa> ok
|
14:58:09
|
*** chopin has joined #openmrs
|
14:58:12
|
<dkayiwa> ok
|
14:58:17
|
*** pascal` has joined #openmrs
|
15:06:20
|
*** lh has quit IRC
|
15:06:35
|
*** lh has joined #openmrs
|
15:06:35
|
*** lh has joined #openmrs
|
15:10:53
|
*** surangak has quit IRC
|
15:16:19
|
<wyclif> bwolfe,with sync what happens if i upgrade one server to a later Openmrs version and make some changes and try to sync before i upgrade the other servers
|
15:16:31
|
<bwolfe> wyclif, bad things
|
15:16:40
|
<bwolfe> (potentially)
|
15:17:23
|
<wyclif> bwolfe, so are we assuming that the admins will know this and will always ensure they upgrade servers at the sametime or before they sync
|
15:17:31
|
<bwolfe> if a record fails to run on a child no other changes can run
|
15:17:39
|
<bwolfe> the parent will continue to try sending it
|
15:17:49
|
<bwolfe> wyclif, yes, admins should know this
|
15:18:01
|
<wyclif> i saw a database version property somewhere
|
15:18:06
|
<wyclif> i assumed this was its use
|
15:18:29
|
<wyclif> i.e if a sync record has a database version higher than that of the server where it is being applied
|
15:18:39
|
<wyclif> then it will be put on hold
|
15:18:51
|
<wyclif> until that server is installed
|
15:18:52
|
<wyclif> right
|
15:19:03
|
<bwolfe> wyclif, it isn't in use yet
|
15:19:15
|
<bwolfe> wyclif, theres a ticket+patch I made to make this a requirement
|
15:19:22
|
<wyclif> i haven't looked at the sync ingest code
|
15:19:30
|
<wyclif> but i would guess so
|
15:19:32
|
<bwolfe> but have not applied it yet because its possible to have slightly different versions but it still runs ok
|
15:19:43
|
<wyclif> i guess so
|
15:20:24
|
<wyclif> then in i would say if the database versions are different, then admin is prompted to hold it or apply it immediately
|
15:21:14
|
<wyclif> that way we assume they are aware of what database versions are compartible in respect to the object being synced
|
15:21:50
|
<wyclif> by the way, my child servers still cant sync to the parent
|
15:22:14
|
<bwolfe> wyclif, mine are able to
|
15:22:16
|
<bwolfe> wyclif, did you update?
|
15:23:31
|
<wyclif> yes
|
15:24:08
|
<bwolfe> wyclif, most sync'ing will happen via the interent in a scheduled task
|
15:24:16
|
<bwolfe> so admins won't be there to "confirm"
|
15:24:29
|
*** mnunez has joined #openmrs
|
15:25:12
|
<bwolfe> wyclif, did you do a clean build?
|
15:26:09
|
*** MarkG has quit IRC
|
15:34:53
|
<mnunez> djazayeri: Thanks for the drug regimens reply. I'm studing the XML tags right know. Is it possible that the wiki is down?
|
15:35:20
|
<rafa> mnunez: yes, the wiki is down
|
15:36:03
|
<bwolfe> mnunez, http://status.openmrs.org
|
15:36:09
|
*** sunbiz has left #openmrs
|
15:36:47
|
<mnunez> bwolfe, nice monitor, thanks
|
15:39:23
|
<mnunez> Aaaaaand... its back :)
|
15:43:48
|
*** chopin has quit IRC
|
15:43:52
|
*** goutham has joined #openmrs
|
15:44:34
|
*** wyclif has quit IRC
|
15:46:49
|
<djazayeri> bwolfe, rafa, scrum time?
|
15:47:02
|
<rafa> djazayeri: sure
|
15:47:38
|
*** MarkG has joined #openmrs
|
15:47:50
|
<djazayeri> rafa: you go first
|
15:47:56
|
<rafa> *** Rafal ***
|
15:47:57
|
<rafa> Yesterday:
|
15:47:57
|
<rafa> * Missed yesterday's scrum
|
15:47:57
|
<rafa> * Reopened and fixed SYNC-30: Add Jump to First Error link on Sync History page
|
15:47:57
|
<rafa> https://tickets.openmrs.org/browse/SYNC-30
|
15:47:57
|
<rafa> * Worked on SYNC-160: Concepts saved out of order.
|
15:47:57
|
<rafa> https://tickets.openmrs.org/browse/SYNC-160 but didn't find a way to resolve it.
|
15:47:58
|
<rafa> Today:
|
15:47:58
|
<rafa> * Started to work on META-4: Metadata Sharing doesn't know how to handle classes that are persisted in a non-standard way
|
15:47:59
|
<rafa> https://tickets.openmrs.org/browse/META-4
|
15:47:59
|
<rafa> * Devs call
|
15:48:00
|
<rafa> Tomorrow:
|
15:48:00
|
<rafa> * Will continue with META-4
|
15:48:01
|
<rafa> No blockers.
|
15:48:43
|
<djazayeri> I saw the slew of emails about MDS tickets when I woke up this morning
|
15:48:57
|
<rafa> djazayeri: :)
|
15:49:36
|
<rafa> djazayeri: only interfaces are committed now
|
15:49:46
|
<djazayeri> okay, I'll look at those now
|
15:50:04
|
<rafa> djazayeri: I linked them under META-4
|
15:51:00
|
<rafa> djazayeri: I have an idea to package interfaces in a separate jar
|
15:51:17
|
<djazayeri> why?
|
15:51:30
|
<rafa> djazayeri: you should be able to use this jar while developing a module, but you don't have to include it in the omod
|
15:52:34
|
<rafa> djazayeri: they will be included in the mds omod
|
15:52:48
|
<djazayeri> not sure that's a good idea
|
15:53:09
|
<djazayeri> why not just include the mds omod in your lib-common during development?
|
15:53:12
|
<djazayeri> of the other module
|
15:53:28
|
<djazayeri> if you use the jar while developing, you might as well just require the mds module
|
15:54:21
|
<rafa> djazayeri: hmmm okay
|
15:54:34
|
<djazayeri> Okay
|
15:54:35
|
<djazayeri> my report
|
15:54:38
|
<djazayeri> Wednesday
|
15:54:38
|
<djazayeri> * University call
|
15:54:38
|
<djazayeri> * Weekly thought works call
|
15:54:38
|
<djazayeri> * Design call
|
15:54:38
|
<djazayeri> * Project Management call
|
15:54:39
|
<djazayeri> * started TRUNK-2588 (review and refactor new attribute framework)
|
15:54:40
|
<djazayeri> Today
|
15:54:40
|
<djazayeri> * Developers call
|
15:54:41
|
<djazayeri> * 1.9 ticket prioritization call
|
15:54:41
|
<djazayeri> * Leadership call
|
15:54:42
|
<djazayeri> * continue TRUNK-2588 (review and refactor new attribute framework)
|
15:54:42
|
<djazayeri> * look at new MDS interfaces for Rafal
|
15:55:20
|
<djazayeri> no blockers
|
15:57:25
|
<dkayiwa> Worked on review comments on my earlier tickets.
|
15:57:25
|
<dkayiwa> Did some code review
|
15:57:25
|
<dkayiwa> Committed: No Child to Parent syncing happens with current trunk build of Sync Module - sync-223
|
15:57:25
|
<dkayiwa> Continuing to work on review comments from my remaining two tickets. SYNC-200 and SYNC-184
|
15:57:25
|
<dkayiwa> No Blockers
|
15:57:49
|
<djazayeri> What was the issue that caused SYNC-223?
|
15:58:01
|
<djazayeri> Why didn't we catch that in a unit test?
|
15:58:14
|
<dkayiwa> i created the unit test
|
15:58:44
|
<dkayiwa> it did not have a test before
|
15:58:48
|
<djazayeri> I mean, how did we allow a previous commit to completely break sync?
|
15:58:52
|
*** wyclif has joined #openmrs
|
15:59:02
|
<djazayeri> aren't there a bunch of unit tests of different sync scenarios?
|
15:59:08
|
<djazayeri> shouldn't those have broken?
|
15:59:36
|
<dkayiwa> they are there, but do not cover all that can be broken
|
15:59:57
|
<djazayeri> rafa: I think it's better for handlers to be registered via Spring configuration.
|
16:00:23
|
<djazayeri> that way they're automatically registered/unregistered when spring is restarted
|
16:00:27
|
<djazayeri> (on module reloads)
|
16:00:36
|
<djazayeri> dkayiwa: okay
|
16:00:54
|
<rafa> djazayeri: good point!
|
16:02:02
|
<djazayeri> rafa: I hadn't thought of splitting the handler into dependencies/save/search/display, but I like it
|
16:02:50
|
<djazayeri> the generic typing on getDependencies seems backwards to me
|
16:03:06
|
<djazayeri> and on saveItem...
|
16:03:42
|
*** goutham has quit IRC
|
16:04:35
|
<djazayeri> rafa: shouldn't handler<T> only be able to take Class<T> as the parameter?
|
16:04:42
|
<djazayeri> Actually, why are you passing in the class anyway?
|
16:05:12
|
<djazayeri> if I have ConceptSaveHandler implements MetadataSaveHandler<Concept>, why don't I just write saveItem(Concept)?
|
16:05:53
|
<rafa> djazayeri: the problem is that you sometimes might get a subclass and you need to know which superclass is Hibernate entity you need to use to save it
|
16:09:22
|
*** dkayiwa has quit IRC
|
16:09:44
|
<rafa> djazayeri: in other words you might get SuperForm that you don't know how to persist, but you can persist it with Form. You either need to traverse the inheritance tree to discover that or simply be told.
|
16:09:55
|
<rafa> I chose the latter.
|
16:10:44
|
<djazayeri> but doesn't the framework already have to traverse the inheritance tree to find the most suitable handler?
|
16:11:32
|
<rafa> djazayeri: again good point :)
|
16:11:44
|
<djazayeri> e.g. getDisplayHandler(SuperForm.class) will realize it has nothing for SuperForm, so it already has to look at the superclass
|
16:11:46
|
<rafa> djazayeri: I'll get rid of that
|
16:14:03
|
<djazayeri> rafa: I'm pretty excited about what we'll be able to do with MetadataDisplayHandler
|
16:15:02
|
<rafa> djazayeri: yeah, it should allow us to get rid off the hacky code for concept datatypes and classes
|
16:15:34
|
<rafa> djazayeri: we'll be able to display even trees of properties
|
16:15:35
|
<djazayeri> also it will allow us to display all an object's properties
|
16:15:39
|
<djazayeri> exactly
|
16:16:48
|
<djazayeri> cool, aside from those comments, looks good
|
16:23:51
|
<mnunez> djazayeri: I have some questions regarding the XML tags of the drug regimens file. Any chance we could gave them a quick look?
|
16:24:07
|
<djazayeri> sure
|
16:25:12
|
<djazayeri> ask away
|
16:25:36
|
<mnunez> http://pastebin.com/zX3DL47n
|
16:26:04
|
<mnunez> <canReplace>
|
16:26:17
|
<mnunez> What would it show?
|
16:28:14
|
<djazayeri> mnunez: I believe the idea is that the regimens are grouped by types
|
16:29:01
|
<djazayeri> and you can do things like "replace all ANTIRETROVIRAL DRUGS" with this new one.
|
16:29:57
|
<djazayeri> I'm not certain whether that's supposed to be the name of a concept
|
16:30:45
|
<mnunez> djazayeri: not in my dictionary at least
|
16:31:00
|
<MarkG> question: i'm upgrading the mdr-tb module to 1.8, so i need to include the jars for 1.8. Where can I get those? Is there a way i can do a maven build that gives me the build number in the jars, not just "
|
16:31:05
|
<MarkG> SNAPSHOT"
|
16:31:22
|
<djazayeri> mnunez: I'm looking at the code
|
16:31:32
|
<mnunez> djazayeri: could you link it?
|
16:31:35
|
<MarkG> or should I just do a mvn build and then rename the jars?
|
16:33:25
|
<djazayeri> mnunez: do you have openmrs core code checked out?
|
16:34:51
|
<mnunez> djazayeri: I've been wandering a bit the trunk, yes. But I get a little lost with FishEye
|
16:35:04
|
<djazayeri> Yeah, I'm looking at the code I have checked out locally
|
16:36:42
|
<djazayeri> it ended up taking me to patientRegimen.js
|
16:37:27
|
<djazayeri> where I see that canReplace is used in calls like DWROrderService.voidCurrentDrugSet(${model.patientId}, '${standardRegimen.canReplace}', ...
|
16:38:20
|
<MarkG> i guess the answer is to just mavenize mdr-tb, huh?
|
16:38:59
|
<djazayeri> mnunez: looking at that method, and tracing the code, I see that canReplace is processed with "getConceptByIdOrName"
|
16:39:36
|
<mnunez> djazayeri: meaning it has to exist a concept with that name?
|
16:39:37
|
<djazayeri> i.e. it can be the name or conceptId of a concept set that represents a group of related drug concepts which may be stopped or edited together
|
16:39:44
|
<djazayeri> mnunez: yeah
|
16:40:03
|
<mnunez> Good. Maybe that's why I've been getting some javascript errors.
|
16:40:04
|
<djazayeri> mnunez: let me find a server where I can show you that code working as intended
|
16:40:10
|
<djazayeri> it'll be clearer that way
|
16:40:38
|
<djazayeri> MarkG: you want the openmrs 1.8 jars?
|
16:40:59
|
<MarkG> djazayeri: yeah
|
16:41:34
|
<MarkG> but i also want all the various libraries used by 1.8... so, short of downloading them all, i'm probably better off switching to maven
|
16:41:46
|
<djazayeri> MarkG: yeah, if you want all the libraries, you're better off using maven
|
16:42:02
|
<djazayeri> if you want specific versions of the OpenMRS jars, you can look in
|
16:42:02
|
<djazayeri> http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs
|
16:42:08
|
<djazayeri> e.g. http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/api/openmrs-api/1.8.0/
|
16:42:08
|
<OpenMRSBot> <http://ln-s.net/9:L2> (at mavenrepo.openmrs.org)
|
16:42:10
|
<OpenMRSBot> <http://ln-s.net/9:L3> (at mavenrepo.openmrs.org)
|
16:42:23
|
<MarkG> djazayeri: yeah, we just looked there, but could only find the api jar
|
16:42:46
|
<djazayeri> web jar is at http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/web/openmrs-web/1.8.0/
|
16:42:48
|
<OpenMRSBot> <http://ln-s.net/9:L4> (at mavenrepo.openmrs.org)
|
16:42:53
|
<djazayeri> dependencies aren't necessarily all there though
|
16:43:08
|
*** morristic has joined #openmrs
|
16:43:13
|
<djazayeri> tests at http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/test/openmrs-test/1.8.0/
|
16:43:14
|
<djazayeri> etc
|
16:43:15
|
<OpenMRSBot> <http://ln-s.net/9:L5> (at mavenrepo.openmrs.org)
|
16:44:12
|
*** rafa has quit IRC
|
16:44:26
|
<djazayeri> mnunez: meet me here: http://breeze.iu.edu/openmrsdev/
|
16:45:11
|
<mnunez> djazayeri: ok
|
16:45:50
|
<djazayeri> you can log in as a guest
|
16:51:32
|
<MarkG> thanks djazayeri
|
17:00:45
|
*** morristic has quit IRC
|
17:06:36
|
*** lh has quit IRC
|
17:07:13
|
*** lh has joined #openmrs
|
17:07:13
|
*** lh has joined #openmrs
|
17:10:34
|
*** dkayiwa has joined #openmrs
|
17:27:54
|
<mnunez> djazayeri: Do you know what does it mean when I use the drugSuggestion tag like this?
|
17:27:56
|
<mnunez> <drugSuggestion reference="../../../regimenSuggestion[3]/drugComponents/drugSuggestion"/>
|
17:28:59
|
<mnunez> djazayeri: Is regimenSuggestion[3] the third regimenSuggestion tag in my XML file?
|
17:33:58
|
*** dkayiwa_ has joined #openmrs
|
17:34:56
|
*** dkayiwa has quit IRC
|
17:34:56
|
*** dkayiwa_ is now known as dkayiwa
|
17:40:55
|
<djazayeri> mnunez: that's xpath. it's the third (or 4th, I don't know if it's 0- or 1-indexed) regimen suggestion tag if you go "up" 3 tags from where you're at now
|
17:41:40
|
<djazayeri> probably going up 3 tags does take you to the root of the xml, though
|
17:41:43
|
<djazayeri> so it's probably what you said
|
17:42:25
|
<mnunez> djazayeri: Great, thanks
|
17:52:43
|
<mnunez> djazayeri: I'm getting javascript errors that redirect me to the "server log". The server log accessible from the Admin page is empty. Any idea of where are this errors logged?
|
17:52:56
|
<mnunez> these
|
17:54:57
|
*** chopin has joined #openmrs
|
17:56:02
|
<djazayeri> mnunez: last time I looked at the server log on my admin page it was empty too. I didn't investigate why.
|
17:56:10
|
<bwolfe> mnunez, if running tomcat its tomcathome/logs/catalina.out or stdout.log
|
17:56:19
|
<djazayeri> (I believe it's possible for a single module with a badly-written log4j.xml to mess up all logging there.)
|
17:56:27
|
<djazayeri> But yeah, what bwolfe said.
|
17:56:33
|
<bwolfe> djazayeri, mnunez, if a module has a log4j.xml in it that defines a new "root" element, the server log is empty
|
17:56:50
|
<bwolfe> *the server log in the webapp* is empty
|
17:56:57
|
<djazayeri> bwolfe: we should verify that none of the bundled modules have this.
|
17:57:01
|
<bwolfe> the one on the filesystem in your tomcat folder will always have a bunch of stuff
|
17:57:03
|
<djazayeri> But I bet some do.
|
17:57:11
|
<bwolfe> djazayeri, the xstream module did at one point
|
17:57:40
|
<mnunez> djazayeri, bwolfe, is the dashboard a module?
|
17:58:00
|
*** dkayiwa has quit IRC
|
17:58:51
|
<bwolfe> mnunez, no, but some of the tabs on it are provided by modules
|
18:05:11
|
<mnunez> bwolfe, djazayeri: Thanks, I found it. It's a lovely 7,1 MB log file.
|
18:06:38
|
*** lh has quit IRC
|
18:06:51
|
*** lh has joined #openmrs
|
18:15:33
|
*** Echidna has quit IRC
|
18:17:05
|
*** Echidna has joined #openmrs
|
18:17:05
|
*** ChanServ sets mode: +v Echidna
|
18:25:53
|
<MarkG> okay, so i mavenized the mdr-tb module. what do i do for other openmrs module dependencies that are not yet in the maven repo? do i have to add them somehow?
|
18:27:12
|
<bwolfe> MarkG, https://wiki.openmrs.org/display/docs/Requiring+another+module+in+your+module
|
18:27:12
|
<OpenMRSBot> <http://ln-s.net/9-5b> (at wiki.openmrs.org)
|
18:28:22
|
<MarkG> bwolfe: thanks
|
18:31:53
|
<chopin> ahhhhhhhhhhhhhhh
|
18:32:39
|
<chopin> bwolfe, not that you can do anything about this, but using MDS to export a single form is taking -forever-, and I see this kind of log entry for what I assume is each concept involved: http://pastebin.com/6Ra7d6tJ
|
18:33:21
|
<bwolfe> why is a concpet being saved during EXPORT ??
|
18:33:39
|
<chopin> _exactly_
|
18:33:47
|
* chopin ... is ... confused.
|
18:33:54
|
* bwolfe looks at djazayeri
|
18:34:09
|
* bwolfe wants to look at rafal, but he's gone missing
|
18:34:24
|
<djazayeri> remind me to look at this when not on a call
|
18:34:26
|
<chopin> between each of those is another 10-15 shouldSynchronize logs
|
18:34:42
|
<djazayeri> in 26 minutes
|
18:34:55
|
* chopin waits to see if this package even finishes rendering
|
18:36:14
|
<mnunez> djazayeri: I've been playing around a bit with the drug regimes in the demo page. The standard drug regimes of the demo seem to be outdated, (there is no drug with drugId of 11 error), and besides, after choosing one of these regimes for the patient, it is not immediately added to the current list of drugs. Updating the page seems to do the trick.
|
18:37:45
|
<mnunez> djazayeri: should I make an intro ticket of this?
|
18:39:42
|
*** dkayiwa has joined #openmrs
|
18:42:05
|
*** dkayiwa_ has joined #openmrs
|
18:44:43
|
*** dkayiwa has quit IRC
|
18:47:35
|
*** dkayiwa_ is now known as dkayiwa
|
18:51:35
|
*** dkayiwa has quit IRC
|
19:04:26
|
*** dkayiwa has joined #openmrs
|
19:05:08
|
<djazayeri> mnunez: to fix the global property on the demo server?
|
19:05:22
|
<djazayeri> or the no-change-until-refresh issue?
|
19:05:40
|
<djazayeri> I know there's a ticket about something similar-sounding, but I forget what
|
19:06:01
|
<djazayeri> chopin: actually I'm not going to look at that code. I'll wait for Rafal to look at it tomorrow.
|
19:06:35
|
<mnunez> djazayeri: I'm more concerned about the latter
|
19:07:47
|
<djazayeri> mnunez: this?
|
19:07:47
|
<djazayeri> https://tickets.openmrs.org/browse/TRUNK-2619
|
19:08:17
|
<djazayeri> Can you see if you can replicate that issue, and see if it happens 100% of the time, or only in certain circumstances?
|
19:09:45
|
<mnunez> djazayeri: That's the one. I'll also attach my latest log entries, there are some javascript errors involved I believe.
|
19:19:41
|
<djazayeri> cool
|
19:22:55
|
*** dkayiwa has quit IRC
|
19:24:10
|
*** downeym has joined #openmrs
|
19:24:10
|
*** ChanServ sets mode: +o downeym
|
19:24:10
|
*** OpenMRSBot sets mode: +o downeym
|
19:30:40
|
*** bryq1 has quit IRC
|
19:34:29
|
*** dkayiwa has joined #openmrs
|
19:41:06
|
*** dkayiwa has quit IRC
|
19:52:40
|
*** dkayiwa has joined #openmrs
|
19:53:35
|
<mnunez> dkayiwa: Hi! Question: have you ever had problems with tabulation indexes on an XForm?
|
20:02:40
|
<wyclif> hi bwolfe
|
20:04:00
|
<bwolfe> hi wyclif
|
20:06:19
|
<wyclif> i have revisited the ticket for splitting web and file sync record limits
|
20:06:29
|
<wyclif> and...
|
20:07:07
|
<wyclif> the way am doing it right now is that i have removed the limiting in the service layer
|
20:07:20
|
<wyclif> hmm...
|
20:07:25
|
<wyclif> no
|
20:07:52
|
<bwolfe> why are you revisiting it? were there more than minor suggestings?
|
20:08:09
|
* bwolfe can't remember..
|
20:08:18
|
<wyclif> yes, in the service and DAO layer i no longer enforce the limit because these methods are used both when generating a response and a when sending
|
20:08:56
|
<wyclif> and it doesn't make sense it limit it on the response, should i or not
|
20:09:58
|
<wyclif> i.e when calling createSyncTransimission when generating a response, should we limit recor or not?
|
20:10:05
|
<wyclif> records
|
20:13:01
|
<bwolfe> yes, the limit is necessary there
|
20:17:18
|
*** dkayiwa_ has joined #openmrs
|
20:18:37
|
*** dkayiwa has quit IRC
|
20:18:37
|
*** dkayiwa_ is now known as dkayiwa
|
20:19:34
|
*** mnunez has quit IRC
|
20:19:41
|
*** mnunez has joined #openmrs
|
20:21:30
|
<wyclif> this is likely to make things alittle weird
|
20:22:11
|
<bwolfe> why?
|
20:22:31
|
<bwolfe> the response is the content of whats changed on the local server
|
20:22:34
|
<bwolfe> it shoudl be limited
|
20:22:36
|
<wyclif> imagine a situation where i have 50 as the limit, and i have 70 synced records that are not yet confirmed and the when i the response is generated, onlly 50 get confirmed due to the limit
|
20:22:43
|
<bwolfe> otherwise it would try to send back 100K records
|
20:23:00
|
<wyclif> the other 10 will stay unconfirmed unitl the next time synchronization is don
|
20:23:17
|
<bwolfe> the response contains the "acks" the confirmations as you said, and the new sync_records. the limit shoudl only apply to sync_records
|
20:23:24
|
<wyclif> this is only likely to to happen for the auto synching
|
20:25:29
|
<wyclif> if it includes both, then why limit on it
|
20:26:06
|
<wyclif> since it wil always include both synced and to be synced
|
20:26:38
|
<wyclif> anyways, i will do it limit the response records but i find it strange
|
20:30:55
|
<bwolfe> there are two things int he response wyclif
|
20:31:18
|
<wyclif> i get it
|
20:31:22
|
<bwolfe> 1) the sync records from local changes. those should be limited. 2) the acks/confirmations about what has been recieved successfully. those should not be limited
|
20:34:14
|
<wyclif> though when i look at the SyncTransmissionResponse class
|
20:35:04
|
<wyclif> it only has a list of SyncImportRecords
|
20:41:43
|
<wyclif> sorry, i have seen that it includes a SyncTransmission too
|
20:44:12
|
*** downeym_ has joined #openmrs
|
20:44:12
|
*** ChanServ sets mode: +o downeym_
|
20:46:55
|
*** downeym has quit IRC
|
20:46:56
|
*** downeym_ is now known as downeym
|
20:49:50
|
*** dkayiwa has quit IRC
|
20:56:50
|
*** chopin has quit IRC
|
20:57:17
|
*** dkayiwa has joined #openmrs
|
21:04:13
|
*** bwolfe has quit IRC
|
21:06:55
|
*** lh has quit IRC
|
21:07:08
|
*** lh has joined #openmrs
|
21:16:34
|
*** downeym has quit IRC
|
21:38:19
|
<djazayeri> MarkG: sorry about that HFE bug...
|
21:38:35
|
<MarkG> djazayeri: no worries...
|
21:38:42
|
<MarkG> thank cordt for finding it
|
21:38:51
|
<djazayeri> looks like it's just "answerConcepts" -> "answerConceptIds"?
|
21:39:11
|
<MarkG> yes, i changed that and it fixed it, at least from Cordt's testing...
|
21:39:24
|
<MarkG> wanted to push it out quickly, so i haven't written a unit test yet, but i can...
|
21:39:59
|
<MarkG> you probably want to give that rev a closer look tho...
|
21:42:34
|
<djazayeri> Makes sense that you pushed it out before writing the test
|
21:43:03
|
<djazayeri> Given how central HFE is to all our work, it seems like we should dedicate some time to building some fairly large integration tests of it
|
21:49:03
|
*** dkayiwa_ has joined #openmrs
|
21:50:55
|
<mnunez> djazayeri: Extremely dumb question: how do I edit a messages_es.properties from FishEye? I'd like to do add some spanish translations.
|
21:51:13
|
<djazayeri> you can't edit it from fisheye
|
21:51:32
|
*** dkayiwa has quit IRC
|
21:51:49
|
<djazayeri> If you're going to be doing more development than just that, you should check out the OpenMRS source code from svn
|
21:52:03
|
*** dkayiwa_ is now known as dkayiwa
|
21:52:42
|
<djazayeri> if you just want to edit this one file, you could download just the one file out of subversion, edit it, and then you'd need to do a diff between what you downloaded and your edited file
|
21:53:02
|
<djazayeri> That you'd attach that diff as a "patch" on a ticket, and someone with privileges would apply it.
|
21:53:44
|
<mnunez> djazayeri: I've no extensive training as a developer, I'm a Biomedical Engineering student. I'll be working as an implementer, helping wherever I can.
|
21:54:42
|
<djazayeri> mnunez: what operating system?
|
21:55:10
|
<mnunez> djazayeri: Ubuntu, but of course ;)
|
21:55:20
|
<djazayeri> that's easier. :-)
|
21:56:05
|
<djazayeri> Any chance you have an IDE like Eclipse or Netbeans installed?
|
21:56:13
|
<djazayeri> (not necessary if you don't)
|
21:56:47
|
<mnunez> djazayeri: Eclipse I use. I've been watching the videos you made for the developer install.
|
21:57:15
|
<mnunez> djazayeri: Maven allows me to build proyects, but not to upload code, does it?
|
21:57:23
|
<djazayeri> svn would allow that
|
21:57:35
|
<djazayeri> but you don't have privileges for that (yet...)
|
21:58:23
|
<mnunez> djazayeri: Nevermind. I'll see what I can do with those translations.
|
21:58:28
|
<djazayeri> So, if you've been through all the instructions and installed the relevant eclipse plugins + downloaded the code...
|
21:58:46
|
<djazayeri> then you would open up the messages_es.properties file in Eclipse
|
21:58:50
|
<djazayeri> then you'd make your edits
|
21:59:08
|
<djazayeri> finally you'd right-click on the file and say Team -> Create Patch
|
21:59:20
|
<djazayeri> then save that file and upload it to a ticket
|
21:59:30
|
<djazayeri> (we can create a ticket like "improve spanish translation"
|
21:59:38
|
*** dkayiwa has quit IRC
|
21:59:58
|
<mnunez> djazayeri: Excelent. I'll do that.
|
22:00:09
|
<djazayeri> If you haven't gotten the dev environment to that point yet, you can do this is textpad (or whatever)
|
22:01:46
|
*** dkayiwa has joined #openmrs
|
22:03:37
|
<mnunez> djazayeri: I think I'll try the Eclipse solution. I'd like to get used to it. My programming skills are pretty basic (we use it mostly for signal processing and the kind), but I'd like to improve them. I've been devouring the Training Material, wich is awsome, by the way.
|
22:03:59
|
<djazayeri> Great
|
22:04:12
|
<djazayeri> ask around here if you have any questions getting up and running
|
22:07:08
|
*** lh has quit IRC
|
22:07:17
|
*** lh has joined #openmrs
|
22:07:17
|
*** lh has joined #openmrs
|
22:08:04
|
*** mnunez has quit IRC
|
22:13:56
|
*** dkayiwa has quit IRC
|
22:21:52
|
*** dkayiwa has joined #openmrs
|
22:25:28
|
*** dkayiwa_ has joined #openmrs
|
22:28:23
|
*** dkayiwa has quit IRC
|
22:28:23
|
*** dkayiwa_ is now known as dkayiwa
|
22:29:18
|
*** wyclif has quit IRC
|
22:37:08
|
*** lh has quit IRC
|
22:37:25
|
*** lh has joined #openmrs
|
22:37:25
|
*** lh has joined #openmrs
|
22:41:38
|
*** dkayiwa has quit IRC
|
22:48:46
|
*** dkayiwa has joined #openmrs
|
23:08:23
|
*** MarkG has quit IRC
|
23:16:54
|
*** wyclif has joined #openmrs
|