00:11:14
|
*** lh has quit IRC
|
00:36:52
|
*** djazayeri has joined #openmrs
|
00:36:52
|
*** ChanServ sets mode: +o djazayeri
|
00:47:54
|
*** firc has joined #openmrs
|
00:48:47
|
<firc> hey guys
|
00:48:50
|
<firc> anyone around?
|
00:53:51
|
*** lh has joined #openmrs
|
01:19:14
|
<sunbiz> hi firc
|
01:19:19
|
<sunbiz> what brings you areound here..
|
01:19:22
|
<firc> hi sunbiz
|
01:19:24
|
<sunbiz> ??
|
01:19:39
|
<firc> Well, I had a query about OpenMRS
|
01:19:46
|
<firc> Kinda generic, though.
|
01:19:51
|
<sunbiz> please ask
|
01:20:10
|
<firc> About the access control mechanism in OpenMRS. It is role based right?
|
01:20:55
|
<sunbiz> yes... there are roles and these have privileges and each view has a privilege on who can view/manage
|
01:20:56
|
<firc> A professor in my university has another model of security, which he was wondering could be implemented in OpenMRS. He wanted me to work on it, but I was not sure how difficult this task would be.
|
01:21:31
|
<firc> So any pointers, on where I could read more about the current implementation?
|
01:21:33
|
<sunbiz> ok... a
|
01:21:38
|
<sunbiz> what kind of new model??
|
01:22:07
|
<sunbiz> https://wiki.openmrs.org/display/docs/Access+Control+in+OpenMRS
|
01:22:16
|
<OpenMRSBot> <http://ln-s.net/9-dc> (at wiki.openmrs.org)
|
01:23:24
|
<firc> this http://ccs.cs.stonybrook.edu/cip/workshop/slides/8-stoller.pdf
|
01:23:28
|
<OpenMRSBot> <http://ln-s.net/9-dd> (at ccs.cs.stonybrook.edu)
|
01:24:59
|
<firc> err, that is kinda generic I guess. The prof has made an API of sorts, that would prolly intercept the requests before any action is taken. Something like SELinux, at least thats what he said. I'm not to well versed myself.
|
01:28:33
|
<firc> Ok yep. I think it does give a bit on an idea
|
01:36:00
|
*** sunbiz has left #openmrs
|
02:10:09
|
*** chopin has joined #openmrs
|
02:11:04
|
* robbyoconnor throws a water balloon at wyclif again
|
02:11:09
|
* robbyoconnor giggles
|
02:11:21
|
* robbyoconnor drops one on chopin
|
02:11:22
|
<robbyoconnor> :D
|
02:40:07
|
* chopin wakes up
|
02:46:19
|
*** gbastien has quit IRC
|
02:49:59
|
*** finbrein has joined #openmrs
|
02:54:48
|
*** finbrein has quit IRC
|
02:55:01
|
*** upul` has joined #openmrs
|
02:55:01
|
*** ChanServ sets mode: +v upul`
|
03:01:31
|
*** morristic has joined #openmrs
|
03:08:36
|
*** chopin has quit IRC
|
03:31:00
|
*** morristic has quit IRC
|
03:34:33
|
*** deadpool has joined #openmrs
|
03:58:40
|
*** djazayeri has quit IRC
|
04:13:45
|
*** goutham has joined #openmrs
|
04:26:12
|
*** surangak has joined #openmrs
|
04:29:33
|
*** djazayeri has joined #openmrs
|
04:29:33
|
*** ChanServ sets mode: +o djazayeri
|
04:35:34
|
*** goutham has quit IRC
|
04:58:23
|
*** deadpool has quit IRC
|
04:58:45
|
*** Echidna has quit IRC
|
05:01:14
|
*** surangak_ has joined #openmrs
|
05:04:12
|
*** robbyoconnor has quit IRC
|
05:04:15
|
*** wyclif has quit IRC
|
05:04:16
|
*** djazayeri has quit IRC
|
05:04:16
|
*** surangak has quit IRC
|
05:06:08
|
*** deadpool_ has joined #openmrs
|
05:06:08
|
*** Echidna_ has joined #openmrs
|
05:06:08
|
*** djazayeri has joined #openmrs
|
05:06:08
|
*** surangak has joined #openmrs
|
05:06:08
|
*** wyclif has joined #openmrs
|
05:06:08
|
*** robbyoconnor has joined #openmrs
|
05:06:08
|
*** zelazny.freenode.net sets mode: +ov djazayeri robbyoconnor
|
05:06:29
|
*** gauravpaliwal has joined #openmrs
|
05:06:29
|
*** ChanServ sets mode: +v gauravpaliwal
|
05:26:10
|
*** firc has quit IRC
|
05:27:53
|
*** bwolfe has joined #openmrs
|
05:27:53
|
*** ChanServ sets mode: +o bwolfe
|
05:58:03
|
*** deadpool_ has quit IRC
|
05:58:39
|
*** deadpool_ has joined #openmrs
|
06:01:06
|
*** dkayiwa has joined #openmrs
|
06:04:34
|
*** deadpool_ has quit IRC
|
06:06:08
|
<dkayiwa> goodmorning bwolfe
|
06:11:48
|
*** robbyoconnor has quit IRC
|
06:12:05
|
*** robbyoconnor has joined #openmrs
|
06:12:05
|
*** ChanServ sets mode: +v robbyoconnor
|
06:17:28
|
*** deadpool_ has joined #openmrs
|
06:24:50
|
*** pascal` has joined #openmrs
|
06:33:39
|
*** deadpool_ is now known as deadpool
|
06:36:27
|
*** pascal` has quit IRC
|
06:37:59
|
*** gauravpaliwal has quit IRC
|
06:56:36
|
*** rafa has joined #openmrs
|
06:56:36
|
*** ChanServ sets mode: +v rafa
|
06:59:43
|
<deadpool> how easy is it to export data in from lets say an excel sheet to the openmrs table
|
06:59:44
|
<deadpool> ?
|
07:00:53
|
<deadpool> has anyone done it?
|
07:08:40
|
*** mathiaslin has joined #openmrs
|
07:10:31
|
<dkayiwa> deadpool: how does the data look like in excel?
|
07:14:34
|
*** bryq has joined #openmrs
|
07:14:34
|
*** ChanServ sets mode: +v bryq
|
07:16:48
|
*** pascal` has joined #openmrs
|
07:17:55
|
<deadpool> dkayiwa: i have it in columns and rows that i want to enter it in
|
07:18:32
|
<deadpool> it looks exactly like it would in the mysql database
|
07:19:40
|
<dkayiwa> deadpool: like which mysql database table?
|
07:20:08
|
<deadpool> so i created a new table for my module it is for an inventory system
|
07:20:43
|
<deadpool> but it has a foreign key
|
07:21:08
|
<deadpool> i want to enter the old inventory into the database
|
07:21:47
|
<dkayiwa> deadpool: am not aware if any module which does that
|
07:23:08
|
<deadpool> dkayiwa: no i was wondering how easy it would be to write a python script to do that and was wondering if anyone had done that before
|
07:26:45
|
<dkayiwa> oh i see
|
07:28:00
|
*** Echidna_ has quit IRC
|
07:28:58
|
*** Echidna has joined #openmrs
|
07:28:58
|
*** ChanServ sets mode: +v Echidna
|
07:30:39
|
*** vsharma has joined #openmrs
|
07:33:16
|
<vsharma> hi
|
07:35:07
|
<dkayiwa> hi
|
07:35:22
|
<dkayiwa> vsharma:
|
07:39:04
|
<vsharma> I am totally new to OpenMRS so needed some help
|
07:39:14
|
<dkayiwa> ok
|
07:39:47
|
<vsharma> I wanna be able to send HL7 messages from Mirth to OpenMRS
|
07:42:03
|
<vsharma> I am looking at https://wiki.openmrs.org/display/docs/Custom+HL7+Handlers ....
|
07:42:06
|
<vsharma> Any idea who could help me out?
|
07:42:09
|
<OpenMRSBot> <http://ln-s.net/9-jv> (at wiki.openmrs.org)
|
07:44:12
|
<dkayiwa> how does the hl7 message look like from Mirth?
|
07:45:47
|
<vsharma> ORU_R01 format
|
07:46:03
|
<vsharma> MSH|^~\&|FORMENTRY|AMRS|HL7LISTENER|AMRS|20060809121931||ORU^R01|formentry-20060809121931|P|2.5|1||||||||2^AMRS-ELDORET^http://schema.openmrs.org/2006/FormEntry/formId^URI PID|||3^^^^||Patient^John^D|| PV1||O|1^Unknown||||2^Ima Doc (2-6)|||||||||||||||||||||||||||||||||||||20060807|||||||V ORC|RE||||||||20060807161605|1^Super User OBR|1|||1238^MEDICAL RECORD OBSERVATIONS^99DCT OBX|1|NM|5089^WEIGHT (KG)^99DCT||70|||||||||20060807 OBR
|
07:47:07
|
<vsharma> What I wanted to know was ... How to setup the Mirth <--> OpenMRS communication
|
07:48:36
|
<vsharma> I came across https://wiki.openmrs.org/display/docs/Mirth+Messaging+Module
|
07:48:38
|
<dkayiwa> can mirth connect to a web service?
|
07:48:38
|
<OpenMRSBot> <http://ln-s.net/9-k5> (at wiki.openmrs.org)
|
07:49:08
|
<vsharma> The problem with Mirth Messaging module is that it is one way communication
|
07:49:08
|
<dkayiwa> openmrs accepts hl7 messages through a rest web service
|
07:49:35
|
<dkayiwa> meaning?
|
07:50:12
|
<vsharma> Currently it only allows message to be sent to Mirth, not recieved form Mirth.
|
07:50:25
|
<vsharma> Source: https://modules.openmrs.org/modules/view.jsp?module=mirthmessaging
|
07:50:30
|
<OpenMRSBot> <http://ln-s.net/9-k+> (at modules.openmrs.org)
|
07:52:23
|
<dkayiwa> oh i see
|
07:52:54
|
<vsharma> I wanna be able to Save data to OpenMRS and later retrieve it
|
07:52:56
|
<dkayiwa> so you want to send data into openmrs from mirth?
|
07:54:01
|
<vsharma> Yes. Save operation would be from Mirth to OpenMRS
|
07:54:05
|
<vsharma> and Retrieve Operation would be from OpenMRS to Mirth
|
07:54:50
|
<dkayiwa> just to be sure: so mirth only accepts messages but does not send?
|
07:56:12
|
<vsharma> :-)
|
07:56:29
|
<vsharma> Let me explain
|
07:56:51
|
<vsharma> The flow should be like this...
|
08:00:33
|
<vsharma> SAVE OPERATION
|
08:00:41
|
<vsharma> Step 1: MY_SYSTEM sends a custom message to MIRTH
|
08:00:55
|
<vsharma> Step 3: A Mirth channel does the mapping and creates a HL7 message
|
08:01:09
|
<vsharma> Step 3: That has to be sent to OpenMRS which should save it
|
08:02:46
|
<dkayiwa> ok
|
08:02:49
|
<vsharma> for RETRIEVE OPERATION, the saved data should be able to be sent from OpenMRS to Mirth
|
08:03:11
|
<vsharma> Do you know how this can be done?
|
08:03:49
|
<dkayiwa> step 3: can mirth send the hl7 message to openmrs?
|
08:05:16
|
<vsharma> Should Mirth create a webservice client and POST it to OpenMRS?
|
08:05:35
|
<dkayiwa> yes
|
08:07:14
|
<vsharma> I am looking at https://wiki.openmrs.org/display/docs/HL7
|
08:07:46
|
<vsharma> It says .... Posting an HL7 message to url /remotecommunication/postHl7.form will insert the message into the hl7 in queue.
|
08:09:01
|
<dkayiwa> ok
|
08:09:27
|
<dkayiwa> the recommendation way now is post to the rest web service
|
08:11:09
|
<vsharma> ok.. Are there any tutorial or documentation on this?
|
08:12:49
|
<dkayiwa> https://wiki.openmrs.org/display/docs/REST+Web+Services+API
|
08:12:51
|
<OpenMRSBot> <http://ln-s.net/8zTB> (at wiki.openmrs.org)
|
08:13:38
|
<dkayiwa> https://wiki.openmrs.org/display/docs/Webservices.rest+Module
|
08:13:39
|
<OpenMRSBot> <http://ln-s.net/92SZ> (at wiki.openmrs.org)
|
08:16:38
|
<vsharma> So, I should be setting up this module, right? https://modules.openmrs.org/modules/view.jsp?module=webservices.rest
|
08:16:39
|
<OpenMRSBot> <http://ln-s.net/8zpU> (at modules.openmrs.org)
|
08:17:30
|
<vsharma> I think I will go through and come back for any further questions
|
08:17:34
|
<vsharma> Thanks for your time
|
08:17:46
|
<dkayiwa> ok
|
08:17:54
|
<dkayiwa> yo welcome
|
08:17:57
|
<vsharma> Ttyl
|
08:46:23
|
*** mathiaslin has left #openmrs
|
08:48:34
|
*** deadpool has quit IRC
|
08:49:01
|
*** deadpool has joined #openmrs
|
09:02:33
|
<surangak_> hello guys, I have a small question....
|
09:05:07
|
<dkayiwa> ok
|
09:06:48
|
<surangak_> hi dkayiwa I was trying to set up the child parent servers again :-)
|
09:07:07
|
<surangak_> so ive got my usual trunk running on jetty, with a mysql db
|
09:07:17
|
<surangak_> im wondering about how to set up the second machine
|
09:07:55
|
<surangak_> if i were to use a war via tomcat, wont it still look at my appdata file and use the same db ?
|
09:09:09
|
<rafa> surangak: you need to rename the war to openmrs-child.war or something
|
09:09:26
|
<rafa> surangak: this way you will access your app through localhost:8080/openmrs-child
|
09:09:39
|
<surangak_> aha, but wont it still try to use the same db ? :-(
|
09:10:02
|
<surangak_> rafa, do i need to have two sets of APP DATA folders ?
|
09:10:09
|
<rafa> surangak: the db properties will be stored in openmrs-child-runtime.properties
|
09:10:37
|
<rafa> surangak: otherwise it is openmrs-runtime.properties
|
09:10:47
|
<surangak_> rafa, oh i seee
|
09:10:54
|
<surangak_> that maks sense
|
09:11:04
|
<surangak_> rafa, thanks, let me try that :-)
|
09:11:16
|
<rafa> surangak: and make sure that your tomcat runs on a different port than jetty
|
09:11:43
|
<rafa> surangak: i.e. do not use 8080 for both
|
09:16:02
|
*** cta has joined #openmrs
|
09:16:06
|
<cta> hello
|
09:38:33
|
<surangak_> hello Taras :-)
|
09:41:11
|
*** mathiaslin has joined #openmrs
|
09:45:15
|
<vsharma> Hi there
|
09:45:25
|
<vsharma> anyone?
|
09:45:37
|
*** goutham has joined #openmrs
|
09:46:43
|
*** bona has joined #openmrs
|
09:50:19
|
<bona> Hi guys, i realized i have assigned myself a ticket by mistake how do i unassign myself from it, please help
|
09:52:31
|
* vsharma Hi dkayiwa
|
09:53:07
|
<rafa> bona: just click assign and choose assignee: Unassigned
|
09:53:22
|
<dkayiwa> hi vsharma
|
09:54:25
|
<vsharma> Quick question - There are 2 module "REST Module" and "REST Web Services API" - Are they the same or different?
|
09:54:41
|
<dkayiwa> different
|
09:54:53
|
<dkayiwa> use REST Web Services Module
|
09:55:18
|
<vsharma> I uploaded "REST Module" but its not responding for the URLs listed on the wiki
|
09:55:33
|
<dkayiwa> use REST Web Services Module
|
09:56:01
|
<bona> +rafa thanks i will try that
|
09:58:02
|
<rafa> bona: actually there's an unassign button as well :)
|
09:58:55
|
<vsharma> https://modules.openmrs.org/modules/view.jsp?module=webservices.rest right? Will try it. Thanks dkayiwa
|
09:58:55
|
<OpenMRSBot> <http://ln-s.net/8zpU> (at modules.openmrs.org)
|
09:58:58
|
* rafa rarely unassign his tickets ;)
|
09:59:39
|
<dkayiwa> yes vsharma
|
10:06:19
|
<dkayiwa> hi rafa
|
10:06:56
|
<dkayiwa> rafa: in the sync sqldiff.xml file, where did you get the 0.975 from?
|
10:07:48
|
<rafa> dkayiwa: hi
|
10:07:51
|
<rafa> dkayiwa: from pom.xml
|
10:07:58
|
<rafa> dkayiwa: it's the current build version
|
10:08:01
|
<dkayiwa> oh i see
|
10:09:15
|
<rafa> dkayiwa: I'm not sure if it's a pattern to follow though
|
10:09:30
|
<bona> +rafa, i can not find the ticket from the introductory ticket list.
|
10:09:36
|
<dkayiwa> ok
|
10:10:47
|
<rafa> bona: you mean this: https://tickets.openmrs.org/browse/TRUNK-2497
|
10:12:02
|
<bona> +rafa, imean this: https://wiki.openmrs.org/display/docs/Getting+Started+as+a+Developer,
|
10:12:20
|
<bona> however i will check the other link
|
10:12:56
|
<rafa> bona: but which ticket are you searching?
|
10:13:41
|
<bona> +rafa, sorry its that ticket yes
|
10:13:52
|
<rafa> bona: cool
|
10:14:33
|
<bona> +rafa,kool
|
10:31:57
|
*** bona has quit IRC
|
10:40:24
|
*** goutham has quit IRC
|
10:52:27
|
<surangak_> howdy bwolfe
|
10:53:03
|
<surangak_> bwolfe, I was wondering, todays design call, its more forcussed on visit / person attributes than complex obs, is it ?
|
10:54:00
|
<dkayiwa> by the way surangak_ when is the design call? :)
|
10:54:05
|
<dkayiwa> as in what time?
|
10:54:33
|
<surangak_> dkayiwa, its at Wednesday 6-8pm UTC
|
10:54:53
|
<surangak_> thats about 7 hours from now, right ?
|
10:55:03
|
<dkayiwa> oh i see
|
10:55:14
|
<surangak_> the university call starts in about 2 hours
|
10:55:54
|
<dkayiwa> surangak_: so its 4 hours after the university?
|
10:56:57
|
<surangak_> dkayiwa, based on my calculations, yes :-)
|
10:57:10
|
<dkayiwa> ok :)
|
10:59:52
|
<bwolfe> surangak_, correct. its on the attributes
|
11:00:09
|
<surangak_> bwolfe, aha
|
11:00:19
|
<surangak_> bwolfe, but i'll listen in anyway :-)
|
11:01:19
|
<vsharma> Hi People ... I need some help with the Webservices.rest Module
|
11:03:19
|
<vsharma> Anyone?
|
11:03:29
|
<bwolfe> surangak_, good. and you can provide suggestions when you come up with them. :-)
|
11:03:44
|
<bwolfe> vsharma, just go ahead and ask your question. someone will answer. :-)
|
11:04:01
|
<vsharma> OK. Here it goes :-)
|
11:04:32
|
<vsharma> I have installed the Webservices.rest Module on the stand alone Open MRS with sample patient data
|
11:05:27
|
*** surangak_ has quit IRC
|
11:05:31
|
<vsharma> the Rest URL ws/rest/v1/catalog returns the catalog as mentioned on https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources
|
11:05:32
|
<OpenMRSBot> <http://ln-s.net/8z-a> (at wiki.openmrs.org)
|
11:05:33
|
*** surangak has quit IRC
|
11:06:28
|
<vsharma> On OPenMRS main page, I am able to search for a Patient called John D
|
11:06:50
|
<vsharma> I would like to know how the REST WS can give me the same info
|
11:07:18
|
*** deadpool has quit IRC
|
11:07:44
|
<vsharma> the urls have something called "uuid"
|
11:08:13
|
<vsharma> how can I find out that if I know the patient id?
|
11:08:54
|
<vsharma> I tried /ws/rest/patient?q
|
11:09:10
|
<vsharma> but I get Resource not found :-(
|
11:10:52
|
<vsharma> OK, looks like I am chatting with myself
|
11:10:57
|
<vsharma> :)
|
11:13:14
|
<dkayiwa> vsharma: do you just want to get the patient uuid?
|
11:14:33
|
<bwolfe> vsharma, to get people's attention in irc, say their username. it will cause a blink/alert action in our clients.
|
11:14:34
|
<vsharma> The patient id is 100-8 ...
|
11:14:56
|
<bwolfe> vsharma, what is the exact query/url that you used? and where did you copy it from? the one you have there doesn't have the "v1" in it
|
11:15:02
|
<vsharma> This is the 1st time I'm using IRC
|
11:15:31
|
<bwolfe> vsharma, ah, you are a new geek then. welcome to the ultimate geekdom. :-D
|
11:15:45
|
<vsharma> bwolfe - I got it from https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources
|
11:15:46
|
<OpenMRSBot> <http://ln-s.net/8z-a> (at wiki.openmrs.org)
|
11:15:49
|
<bwolfe> !refer vsharma [tabcomplete]
|
11:15:50
|
* OpenMRSBot refers vsharma to "tabcomplete" --- Most IRC clients let you easily write someone's nickname in the channel using tab completion. Just type the first few letters, then <tab>, and voila!
|
11:16:17
|
<vsharma> bwolfe: I am getting better
|
11:16:20
|
<vsharma> :)
|
11:17:07
|
<vsharma> On that URL I just sent, look up the URLs under Patient
|
11:18:43
|
<bwolfe> hmm, none of those have the v1 in them. I blame that on dkayiwa. ;-)
|
11:19:00
|
<dkayiwa> lolllllllllllll
|
11:19:03
|
<bwolfe> try putting the v1 in there like you did for the catelog vsharma
|
11:19:32
|
*** goutham has joined #openmrs
|
11:19:49
|
<vsharma> Tried that just now - Gives me 404
|
11:19:58
|
*** bryq has quit IRC
|
11:20:20
|
*** deadpool has joined #openmrs
|
11:20:47
|
<vsharma> sorry bwolfe dkayiwa - It works
|
11:21:04
|
<bwolfe> vsharma, cool
|
11:21:18
|
<bwolfe> vsharma, when you call the catalog, is it giving you the right url with the v1 in it ?
|
11:21:35
|
<vsharma> ws/rest/v1/patient?q=John returned the same info as from OpenMRS interface
|
11:21:52
|
<bwolfe> nice
|
11:22:09
|
<bwolfe> and in that info there should be a link for more info about the patient, right ?
|
11:23:44
|
<vsharma> yes.. there is .. gives me more details
|
11:24:20
|
<vsharma> In the catalog XML, it seems to have V1 in the URL
|
11:24:59
|
<bwolfe> ok good, so its just the wiki page that is out of date.
|
11:25:05
|
<vsharma> Yup
|
11:25:22
|
<bwolfe> dkayiwa, do you remember how you generated that page? is it a 5 min thing to re-do that off the code or will it require a lot of manual tweaks?
|
11:25:37
|
*** deadpool has quit IRC
|
11:25:50
|
<dkayiwa> bwolfe: let me cross check
|
11:27:09
|
<vsharma> Thanks guys! ttyl when I get stuck again :)
|
11:28:04
|
*** upul` has quit IRC
|
11:30:07
|
<bwolfe> vsharma, well, then, I hope to not talk to you again. :-D
|
11:35:00
|
<vsharma> bwolfe: I doubt that :-)
|
11:39:24
|
*** deadpool has joined #openmrs
|
11:42:17
|
*** dkayiwa has quit IRC
|
11:44:49
|
*** dkayiwa has joined #openmrs
|
12:12:34
|
*** deadpool has quit IRC
|
12:22:38
|
*** downeym has joined #openmrs
|
12:22:38
|
*** OpenMRSBot sets mode: +o downeym
|
12:22:38
|
*** ChanServ sets mode: +o downeym
|
12:26:24
|
*** vsharma has quit IRC
|
12:26:51
|
<dkayiwa> bwolfe: whenever you get a minute, could you take a quick look at this page and advise me if i have made any mistake: https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources
|
12:26:52
|
<OpenMRSBot> <http://ln-s.net/8z-a> (at wiki.openmrs.org)
|
12:26:55
|
*** vsharma has joined #openmrs
|
12:27:02
|
<downeym> Hi vsharma and welcome to the #openmrs IRC channel.
|
12:30:03
|
*** wyclif has quit IRC
|
12:43:51
|
*** chopin has joined #openmrs
|
12:47:46
|
<pascal`> bwolfe, any idea what might be causing this: org.hibernate.LazyInitializationException: failed to lazily initialize a collection of role: org.openmrs.Concept.names, no session or session was closed?
|
12:48:12
|
<downeym> pascal`: on an unrelated note, https://www.facebook.com/OpenMRS/posts/10150273309866362
|
12:48:17
|
<OpenMRSBot> <http://ln-s.net/9-rT> (at www.facebook.com)
|
12:48:19
|
<bwolfe> your hibernate session/openmrs session is not open when you are calling ${concept} or concept.getName() or such
|
12:48:33
|
<pascal`> bwolfe, my code: cs.getConcept(i).getName() in my activator's started() method.
|
12:49:18
|
<bwolfe> is that in a session?
|
12:50:18
|
<pascal`> bwolfe, no idea. About the started() method from the wiki: Called after a module is started, the application context has been refreshed and the module's service methods are ready to be called. This is called once per module per time it is started.
|
12:50:29
|
<pascal`> Thanks downeym, I'll look into it.
|
12:53:15
|
<pascal`> Any idea how I can work around this bwolfe? I need to create some metadata (flags to be specific) when I install my module.
|
12:53:35
|
*** cta has quit IRC
|
12:53:40
|
<bwolfe> pascal`, I'm not sure why that is happening
|
12:53:45
|
<bwolfe> any errors before/after that in the logs?
|
12:53:53
|
<bwolfe> perhaps something is causing a rollback+close of the session
|
12:54:05
|
<bwolfe> check another module that uses the activator to add things
|
12:54:13
|
<bwolfe> see if they have to context.open/closesession
|
12:55:58
|
<pascal`> bwolfe, full trace: http://pastie.org/2531629
|
12:56:19
|
<bwolfe> anything before that in a separate trace though?
|
12:57:18
|
<pascal`> bwolfe, nope, logs look fine except for that
|
13:05:23
|
*** gbastien has joined #openmrs
|
13:10:55
|
<pascal`> bwolfe, I take out the call to concept.getName() and everything works fine.
|
13:12:44
|
*** cta has joined #openmrs
|
13:15:18
|
*** cta_ has joined #openmrs
|
13:16:10
|
<vsharma> thanks downeym
|
13:16:40
|
<bwolfe> pascal`, do you have other calls in there?
|
13:17:54
|
*** cta has quit IRC
|
13:18:03
|
<pascal`> bwolfe, yeah a bunch, to both core and module services and they all seem to work fine
|
13:19:13
|
<bwolfe> weird
|
13:19:51
|
<bwolfe> is there anythign weird going on in concpet.getnames ?
|
13:19:58
|
<bwolfe> what version are you using pascal`?
|
13:20:25
|
*** chopin has quit IRC
|
13:20:26
|
<pascal`> bwolfe, 1.7.0 RC (with a few minor cosmetic customizations)
|
13:22:35
|
<bwolfe> hmm
|
13:22:46
|
<bwolfe> I blame it on your customizations then ;-)
|
13:22:57
|
<bwolfe> and/or the fact that its an old version and an RC to boot
|
13:22:58
|
<bwolfe> :-D
|
13:24:06
|
<pascal`> bwolfe, can't I programatically disable lazy loading somehow? Just in my activator?
|
13:25:44
|
<bwolfe> not that I know of
|
13:26:28
|
*** wyclif has joined #openmrs
|
13:34:49
|
*** MarkG has joined #openmrs
|
13:36:44
|
*** chughgaurav has joined #openmrs
|
13:37:22
|
*** cta_ has quit IRC
|
13:38:06
|
<chughgaurav> does this if (reason != null && reason != ' ') , work same ,as if (reason != null && reason != " ") ?
|
13:38:07
|
*** cta_ has joined #openmrs
|
13:39:31
|
*** chopin has joined #openmrs
|
13:45:03
|
*** dkayiwa_ has joined #openmrs
|
13:47:09
|
*** dkayiwa has quit IRC
|
13:47:10
|
*** dkayiwa_ is now known as dkayiwa
|
13:48:30
|
*** vsharma has quit IRC
|
13:51:01
|
*** robbyoconnor has quit IRC
|
13:58:12
|
<bwolfe> chughgaurav, yes, mostly. I think ' ' in java means a char whereas " " means a string...but in js its the same
|
13:58:28
|
<bwolfe> chughgaurav, the better option is to use !StringUtils.isBlank(reason)
|
13:58:29
|
<pascal`> chopin, use this: http://commons.apache.org/lang/api-2.5/org/apache/commons/lang/StringUtils.html#isEmpty%28java.lang.String%29
|
13:58:34
|
<OpenMRSBot> <http://ln-s.net/9-tZ> (at commons.apache.org)
|
13:58:49
|
* bwolfe is 2 seconds faster than pascal` ;-)
|
13:59:06
|
<bwolfe> but pascal`++ for finding the library link
|
13:59:23
|
<pascal`> bwolfe, you're actual also more correct, isBlank() is the correct function to use.
|
13:59:31
|
<pascal`> bwolfe++
|
13:59:57
|
*** rafa has quit IRC
|
14:00:03
|
<pascal`> bwolfe, chughgaurav, I think Java is 'kind' enough to allow those both to work for Strings (i.e. it will auto cast/convert).
|
14:00:38
|
*** ChanServ sets mode: +v pascal`
|
14:00:54
|
*** chughgaurav_ has joined #openmrs
|
14:01:07
|
<downeym> Hi chughgaurav_ and welcome to the #openmrs IRC channel.
|
14:01:32
|
*** chughgaurav_ has quit IRC
|
14:02:24
|
*** cta_ has quit IRC
|
14:02:49
|
<chughgaurav> bwolfe , it was for js , thanks
|
14:03:06
|
*** cta_ has joined #openmrs
|
14:03:49
|
<bwolfe> chughgaurav, ok, then ignore our suggestions for the library method call. :-D
|
14:05:13
|
<chughgaurav> bwolfe , :D
|
14:05:18
|
<pascal`> or, create a JS method called isBlank() (=
|
14:06:47
|
<bwolfe> heh
|
14:06:52
|
<bwolfe> and a library called StringUtils
|
14:08:41
|
<chughgaurav> bwolfe , it was for this issue http://bit.ly/nIs4Mc , someone fixed this to http://bit.ly/p6k6NZ
|
14:09:02
|
*** goutham has quit IRC
|
14:09:35
|
<chughgaurav> bwolfe , I have one more query
|
14:10:29
|
<chughgaurav> bwolfe , how do I add the openmrs dailog box , as was added in this issue ?
|
14:13:21
|
<bwolfe> chughgaurav, which one?
|
14:13:38
|
<bwolfe> I can't tell what your links are because they're bit.ly'd
|
14:13:45
|
<chughgaurav> bwolfe , like this $j("#relationship_empty_reason").show();
|
14:14:05
|
<bwolfe> chughgaurav, what issue are you talkign about?
|
14:14:17
|
<bwolfe> dkayiwa, wyclif, djazayeri. scrum?
|
14:14:27
|
<wyclif> hi
|
14:14:40
|
<djazayeri> I'll be 10 minutes later, but you can start without me
|
14:15:07
|
<dkayiwa> ok
|
14:15:12
|
<pascal`> bwolfe, now I'm just getting random session loss -> http://pastie.org/2531994 :S
|
14:15:24
|
<bwolfe> uh
|
14:15:28
|
<chughgaurav> bwolfe , TRUNK-2590
|
14:15:50
|
<bwolfe> server issue pascal`?
|
14:16:01
|
<bwolfe> dkayiwa or wyclif, one of you ready now?
|
14:16:08
|
<bwolfe> !ticket TRUNK-2590
|
14:16:10
|
<OpenMRSBot> bwolfe: HTTP Error 503: Service Temporarily Unavailable - https://tickets.openmrs.org/browse/TRUNK-2590
|
14:16:27
|
<bwolfe> downeym?
|
14:16:31
|
<bwolfe> jira down? :-/
|
14:16:34
|
<pascal`> bwolfe, Its my dev machine. I guess I'll try and reboot.
|
14:16:47
|
<dkayiwa> Committed: Allow for the ability to make batch changes from the History of Changes page - SYNC-184
|
14:16:47
|
<dkayiwa> Committed: Have org.openmrs.notification.Alert ignored by default when syncing - SYNC-220
|
14:16:48
|
<dkayiwa> Working on review comments from earlier tickets
|
14:16:48
|
<dkayiwa> No Blockers
|
14:16:49
|
<downeym> bwolfe: wait 30 seconds
|
14:17:04
|
<bwolfe> downeym, unacceptable
|
14:17:11
|
<downeym> bwolfe: ok, try it now, then
|
14:17:14
|
<bwolfe> 30 seconds is a lifetime
|
14:17:27
|
<bwolfe> ok, wyclif?
|
14:17:41
|
<bwolfe> downeym, forced restart? you add some fancy-new-feature ?
|
14:18:31
|
<bwolfe> chughgaurav, its just "alert('whatever you want to say here')" in js just like the ticket suggests. :-)
|
14:19:05
|
*** pascal` has quit IRC
|
14:19:59
|
<bwolfe> wyclif?
|
14:20:07
|
<bwolfe> I guess I can go before him
|
14:20:08
|
<bwolfe> today:
|
14:20:08
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @thetobster Definitely! <http://twitter.com/OpenMRS/statuses/113970005015658496>
|
14:20:08
|
<bwolfe> sync reviews
|
14:20:08
|
<bwolfe> emails
|
14:20:09
|
<bwolfe> sync repair with ampath
|
14:20:09
|
<bwolfe> h323 testing (and failing)
|
14:20:09
|
<bwolfe> design call setup
|
14:20:11
|
<bwolfe> univ call
|
14:20:13
|
<bwolfe> design call
|
14:20:15
|
<bwolfe> proj mngment call
|
14:20:17
|
<bwolfe> tomorrow:
|
14:20:19
|
<bwolfe> calls, sync, etc
|
14:20:21
|
<bwolfe> no blockers
|
14:20:45
|
*** chopin has quit IRC
|
14:22:11
|
<wyclif> yesterday:
|
14:22:11
|
<wyclif> - created TRUNK-2658
|
14:22:11
|
<wyclif> - SYNC-173(a couple of tests are still failing)
|
14:22:11
|
<wyclif> today:
|
14:22:12
|
<wyclif> - SYNC-173(i dont want to spend much time to day on this today is i cant the tests to pass)
|
14:22:12
|
<wyclif> - TODOs after reviews from current sprint tickets
|
14:22:14
|
<wyclif> - 1.9 Roadmap tickets
|
14:22:16
|
<wyclif> no blockers
|
14:22:39
|
<wyclif> sorry about the many todays
|
14:23:24
|
<djazayeri> !ticket trunk-2658
|
14:23:25
|
<OpenMRSBot> djazayeri: [#TRUNK-2658] Javascript errors on patient dashboard in firefox - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2658
|
14:23:33
|
<djazayeri> !ticket sync-173
|
14:23:34
|
<OpenMRSBot> djazayeri: [#SYNC-173] Sync creates sync record for failed API call - OpenMRS JIRA - https://tickets.openmrs.org/browse/sync-173
|
14:24:30
|
<djazayeri> wyclif, is it behaving correctly in-real-life?
|
14:24:53
|
<wyclif> i haven't tested in real life
|
14:25:02
|
<wyclif> i have bee using unit tests
|
14:25:12
|
<djazayeri> okay
|
14:25:47
|
<djazayeri> So, do you know what to do next with that?
|
14:26:32
|
<wyclif> basically when i save the sync record from afterTransactionCompletion, the changes are not visible to subsequet calls
|
14:27:09
|
<djazayeri> So perhaps they're not actually being written to the db?
|
14:27:11
|
*** cta_ has quit IRC
|
14:28:05
|
<chughgaurav> bwolfe , How can I add an alert box which looks similar to the dialog box , in this image http://imagebin.org/172412
|
14:28:09
|
*** cta_ has joined #openmrs
|
14:28:50
|
<djazayeri> wyclif: maybe the problem is that since you're no longer within a transaction you need to explicitly create one?
|
14:29:04
|
<djazayeri> or maybe there's something odd in the unit test framework
|
14:29:30
|
<djazayeri> To verify that, you would run a test in-real-life with your new code and see if it works.
|
14:30:25
|
<wyclif> , let me try that
|
14:30:42
|
<wyclif> i.e running them in real life
|
14:31:26
|
<bwolfe> chughgaurav, the orange box in that pic is built by jquery
|
14:31:30
|
<bwolfe> its a jquery "dialog" box
|
14:31:43
|
<bwolfe> look for htat keyword in our code and in the jquery docs for how to do it. its pretty simple
|
14:31:50
|
<bwolfe> but in this case a simple "alert" in js would do
|
14:32:06
|
<bwolfe> just a message to the user and prevents them from submitting (returns false)
|
14:32:23
|
<chughgaurav> bwolfe , ok thanks :)
|
14:33:22
|
<chughgaurav> bwolfe , can u look at the patch for the issue , https://source.openmrs.org/cru/CR-TRUNK-504/downloadpatch/449/relationshipreason.txt
|
14:33:26
|
<OpenMRSBot> <http://ln-s.net/9-ub> (at source.openmrs.org)
|
14:33:49
|
<bwolfe> chughgaurav, what am I looking for?
|
14:33:59
|
<bwolfe> wyclif, report back on the ticket with what you find
|
14:34:06
|
<bwolfe> (because I'll probalby be offline when you figure it out)
|
14:34:11
|
<bwolfe> djazayeri, do you have an update?
|
14:34:32
|
<wyclif> ok, i plan to attach the patch to the ticket before commiting it
|
14:34:56
|
<bwolfe> chughgaurav, put an alert popup with a message in your else before "$j("#relationship_empty_reason").show();"
|
14:35:02
|
<djazayeri> my update
|
14:35:09
|
<djazayeri> Tuesday
|
14:35:09
|
<djazayeri> * Discussed row-per-xyz reporting with Mike
|
14:35:09
|
<djazayeri> * Discussed metadatasharing+formentry with Jeremy
|
14:35:09
|
<djazayeri> * Talked to Andy about Pentaho + Data Warehousing
|
14:35:09
|
<djazayeri> * a few code reviews
|
14:35:09
|
<djazayeri> * Struggled with fisheye/crucible
|
14:35:09
|
<djazayeri> * Recorded a screencast on creating a module with the archetype
|
14:35:10
|
<djazayeri> * Thoughtworks code-jam (looked into Solr for OCC with mandersen)
|
14:35:11
|
<djazayeri> Today
|
14:35:11
|
<djazayeri> * University call
|
14:35:12
|
<djazayeri> * Design call
|
14:35:12
|
<djazayeri> * call with Gretchen and Andy about Pentaho and data warehousing
|
14:35:13
|
<djazayeri> * a ticket, I hope
|
14:35:15
|
<bwolfe> wyclif, yeah, thats probably good. so that mark can check it out and apply it and test it too
|
14:35:24
|
<bwolfe> wyclif, and so we can release a sync module after this sprint is done
|
14:35:28
|
*** pascal` has joined #openmrs
|
14:35:28
|
*** ChanServ sets mode: +v pascal`
|
14:36:08
|
<chughgaurav> it uses if(reason != null && reason != '') { } else {alret();} , shouldn't it be if if(reason != null && reason != ''){}else if(reason != null || reason != ''){alert();}
|
14:36:16
|
*** chopin has joined #openmrs
|
14:36:16
|
<wyclif> ok
|
14:36:54
|
<chughgaurav> bwolfe , it uses if(reason != null && reason != '') { } else {alret();} , shouldn't it be if if(reason != null && reason != ''){}else if(reason != null || reason != ''){alert();}
|
14:38:03
|
<bwolfe> chughgaurav, no. its right
|
14:38:14
|
<chughgaurav> bwolfe , ok
|
14:40:41
|
*** downeym_ has joined #openmrs
|
14:40:41
|
*** ChanServ sets mode: +o downeym_
|
14:41:55
|
<chughgaurav> bwolfe , can you please look at it again http://pastebin.com/VZzfucCU :P
|
14:42:12
|
<bwolfe> dkayiwa, thanks for fixing the rest ws page. I take it that it was simple?
|
14:42:18
|
<chughgaurav> bwolfe , I am sorry for disturbing you again for this
|
14:42:54
|
<bwolfe> chughgaurav, why are you asking about this?
|
14:43:02
|
<bwolfe> why do you not like the "else" ?
|
14:43:06
|
<dkayiwa> bwolfe: yes i just did run the doc creator test (just made a few additions that you had added on the page)
|
14:43:13
|
*** downeym has quit IRC
|
14:43:13
|
*** downeym_ is now known as downeym
|
14:43:21
|
<bwolfe> dkayiwa, awesome
|
14:43:24
|
<bwolfe> dkayiwa++
|
14:43:29
|
<dkayiwa> :)
|
14:43:37
|
<djazayeri> dkayiwa: we should look at the 1.9 tickets, btw
|
14:43:43
|
<dkayiwa> yes
|
14:43:53
|
<chughgaurav> bwolfe , I thought ,it shouldn't be done that way
|
14:44:52
|
*** sunbiz has joined #openmrs
|
14:44:53
|
*** ChanServ sets mode: +v sunbiz
|
14:45:21
|
<chughgaurav> bwolfe, it will give an alert only when both null & empty space exist , shouldn't it check for the null as well as for empty space when giving alert
|
14:46:36
|
<bwolfe> chughgaurav, the statement in english is: "if reason is empty do this. otherwise, do this:"
|
14:47:12
|
<bwolfe> err
|
14:47:22
|
<bwolfe> "if the reason is NOT empty, do this. otherwise do this"
|
14:47:49
|
<bwolfe> reason is NOT empty is defined as "reason != null && reason != ''"
|
14:48:02
|
<bwolfe> chughgaurav, if you want, you can switch the order so it reads a little easier:
|
14:48:10
|
<bwolfe> "if reason is empty, do this. otherwise do this"
|
14:51:40
|
*** cta_ has quit IRC
|
14:52:34
|
*** cta_ has joined #openmrs
|
14:52:37
|
*** mnunez has joined #openmrs
|
14:53:04
|
<chughgaurav> bwolfe , I think it does- if (reason is null & space) do this , else alert() . I think what it should be - if (reason is null & space) do this , else if reason (null || space) alert().
|
14:54:13
|
<bwolfe> chughgaurav, its if (reason is not null and not a space) ...
|
14:54:17
|
<bwolfe> chughgaurav, trust me on this
|
14:54:23
|
<bwolfe> just try it out and see :-)
|
14:54:49
|
<chughgaurav> bwolfe , ok , I 'll do :D
|
15:01:20
|
<wyclif> djazayeri, i have tested in real life and i think the reason is that no further commits are made because i guess the transcation is already done, but i think figure out what to do next
|
15:01:28
|
*** chughgaurav has quit IRC
|
15:01:30
|
<djazayeri> okay
|
15:01:35
|
<djazayeri> (meaning it doesn't work in real life either?)
|
15:01:54
|
<wyclif> djazayeri, the name of the method is very clear afterTransactionCompletion, i should have noticed this right away
|
15:01:58
|
<wyclif> yes
|
15:02:33
|
<wyclif> but i believe there i can try to come with a work around or an alternative
|
15:02:52
|
<djazayeri> okay
|
15:08:07
|
*** chughgaurav has joined #openmrs
|
15:08:43
|
*** pascal` has quit IRC
|
15:17:55
|
*** cta_ has quit IRC
|
15:22:31
|
<chughgaurav> sunbiz :hello
|
15:22:56
|
<chughgaurav> sunbiz : can you please look at tomcat logs , http://pastebin.com/xRGaCDJW
|
15:26:38
|
*** downeym has quit IRC
|
15:27:11
|
*** downeym has joined #openmrs
|
15:27:11
|
*** OpenMRSBot sets mode: +o downeym
|
15:27:11
|
*** ChanServ sets mode: +o downeym
|
15:30:19
|
*** chopin has quit IRC
|
15:31:38
|
*** cta_ has joined #openmrs
|
15:34:44
|
*** chopin has joined #openmrs
|
15:34:53
|
*** ChanServ sets mode: +v chopin
|
16:06:11
|
<chughgaurav> when I deploy openmers.war , it says openmrs is not able to start http://pastebin.com/xRGaCDJW
|
16:06:45
|
<djazayeri> chughgaurav: there is no error message there
|
16:06:55
|
<djazayeri> it says "Server startup in 11211 ms"
|
16:07:36
|
<chughgaurav> djazayeri:strange , but in the browser it says "Error occurred while trying to get the updates needed for the database. Unable to get a connection to the database. Please check your openmrs runtime properties file and make sure you have the correct connection.username and connection.password set "
|
16:07:58
|
<djazayeri> did you do that?
|
16:08:07
|
<djazayeri> (i.e. check your runtime properties?)
|
16:08:20
|
<chughgaurav> djazayeri: yes , but it didn't work
|
16:08:49
|
<chughgaurav> so ,I deleted the database & deleted the rutime properties file as well
|
16:09:07
|
<djazayeri> and?
|
16:09:42
|
<chughgaurav> again installed tomcat 6 , then deployed war file
|
16:11:09
|
<djazayeri> and?
|
16:11:15
|
<djazayeri> What error message do you see?
|
16:11:57
|
<sunbiz> djazayeri: does it bomb for u?? the clashing checksums??
|
16:12:16
|
<chughgaurav> I see the the following , http://pastebin.com/Bav9fLcx
|
16:12:31
|
<djazayeri> sunbiz: I haven't updated to trunk yet
|
16:12:42
|
<djazayeri> will try now
|
16:13:06
|
<sunbiz> I dont think adding dbms="" or preconditions cause any change in checksum
|
16:13:13
|
<sunbiz> thats all the changes I've done
|
16:13:22
|
<sunbiz> and its not bombing for me...
|
16:13:29
|
<sunbiz> I tried upgrading from the 1.7 database
|
16:13:29
|
<djazayeri> chughgaurav: it has found a runtime properties file, and that's pointing to the openmrs database
|
16:13:32
|
<sunbiz> 1.8 database
|
16:13:37
|
<sunbiz> and new installs
|
16:13:39
|
<djazayeri> which doesn't exist
|
16:13:54
|
<djazayeri> so, chughgaurav you'll need to delete the runtime properties file
|
16:14:07
|
<djazayeri> if you look at the logging output at startup, that should tell you what runtime properties file it is using.
|
16:14:28
|
<chughgaurav> done deletion of runtime file
|
16:15:16
|
*** gauravpaliwal has joined #openmrs
|
16:15:16
|
*** ChanServ sets mode: +v gauravpaliwal
|
16:17:27
|
<chughgaurav> djazayeri , i still gives the same error
|
16:17:44
|
<djazayeri> chughgaurav: that means you haven't deleted the right runtime properties file
|
16:17:59
|
<djazayeri> watch the logging output at startup to see exactly what runtime properties file it is using.
|
16:18:50
|
<chughgaurav> djazayeri: I deleted the file openmrs-runtime.properties , at C:\Application Data\OpenMRS
|
16:19:01
|
<djazayeri> watch the logging output at startup to see exactly what runtime properties file it is using
|
16:20:14
|
*** cta_ has quit IRC
|
16:25:56
|
<chughgaurav> djazayeri , it says that it cannot find the file , then why doesn't the installer appear ? http://pastebin.com/F4ThzFZf
|
16:26:55
|
<djazayeri> It actually looks in ~5 different places for the runtime properties file
|
16:27:09
|
<djazayeri> It's supposed to print out all those places that it's looking, but that's apparently not happening
|
16:27:17
|
<djazayeri> Can you search for openmrs-runtime.properties on your machine?
|
16:29:29
|
<djazayeri> or look at OpenmrsUtil.java around line 2316 to see exactly where it looks for runtime properties
|
16:33:52
|
<chughgaurav> where is the file OpenmrsUtil.java located ?
|
16:34:22
|
<djazayeri> https://source.openmrs.org/browse/OpenMRS/trunk/api/src/main/java/org/openmrs/util/OpenmrsUtil.java?hb=true
|
16:34:28
|
<OpenMRSBot> <http://ln-s.net/9-x-> (at source.openmrs.org)
|
16:36:41
|
<djazayeri> chughgaurav: check whether you have an OPENMRS_RUNTIME_PROPERTIES_FILE environment variable
|
16:39:18
|
<chughgaurav> djazayeri : I did not find it in the path ,temp & other environment variables . I never added the variables , & it used to work 2 days back
|
16:39:59
|
<djazayeri> can you search your computer for openmrs-runtime.properties?
|
16:40:25
|
<sunbiz> chughgaurav: that is if... the war file is called openmrs.war
|
16:40:49
|
<sunbiz> if its called abc.war then it should create the file abc-runtime.properties
|
16:41:18
|
<chughgaurav> djazayeri: I searhced , I found one file , I deleted , still not working . So, continuing the search
|
16:41:59
|
<chughgaurav> sunbiz:the name was openmrs.war
|
16:42:54
|
<chughgaurav> djazayeri :finally deleted all of them , , and installation page is back
|
16:43:05
|
<chughgaurav> thanks djazayeri & sunbiz
|
16:48:12
|
<sunbiz> djazayeri: for preconditions or dbms changes, checksums are not changed
|
16:48:45
|
<djazayeri> sunbiz: I'm running now to check, but I believe when joel did Show Annotation (I was standing next to him) we saw a modified line.
|
16:49:27
|
<djazayeri> Indeed, trunk won't run for me
|
16:49:29
|
<djazayeri> ERROR - Listener.contextInitialized(154) |2011-09-14 09:49:01,590| Got exception while starting up:
|
16:49:29
|
<djazayeri> java.lang.RuntimeException: Error occurred while trying to get the updates needed for the database. Validation Failed:
|
16:49:29
|
<djazayeri> 4 change sets check sum
|
16:49:29
|
<djazayeri> liquibase-update-to-latest.xml::20090122-0853::bwolfe is now: 3:500ce2e46732bad3a7b2e617a25a3710
|
16:49:29
|
<djazayeri> liquibase-update-to-latest.xml::20090214-2247::isherman is now: 3:8e95edd3fc7ba6c9f124b0e14536bd4b
|
16:49:30
|
<djazayeri> liquibase-update-to-latest.xml::20090414-0806::bwolfe is now: 3:46e865d5f231b1c47a42adfff35ffbe6
|
16:49:30
|
<djazayeri> liquibase-update-to-latest.xml::20090414-0809::bwolfe is now: 3:af01d8cb20b6aa801e969d0e5f76a2f9
|
16:49:59
|
<sunbiz> hmm... nad this is trunk??
|
16:50:08
|
*** dkayiwa has quit IRC
|
16:50:12
|
<djazayeri> yes
|
16:50:58
|
<djazayeri> looking at the first one of those, in rev:23315 you touched lines: 229, 238, and 242 (all of which are the actual content of the changeset, not the id or precondition)
|
16:53:51
|
<sunbiz> djazayeri: ok... so how do we go back??
|
16:54:05
|
<djazayeri> what are the changes to those lines?
|
16:54:08
|
<djazayeri> were they necessary?
|
16:54:47
|
<djazayeri> one option is to just add the two valid checksums, (see the link I sent earlier to our wiki)
|
16:54:49
|
<sunbiz> rev:23315?? 229 is like extra tabs
|
16:54:58
|
<sunbiz> for formatting
|
16:55:01
|
<djazayeri> the other option is to undo the formatting changes
|
16:55:14
|
<djazayeri> undoing the formatting changes is better, I think
|
17:02:21
|
*** gauravpaliwal has left #openmrs
|
17:02:22
|
<wyclif> i already added the sprint label to the ticket that project is based on
|
17:02:26
|
<wyclif> djazayeri, i already added the sprint label to the ticket that project is based on
|
17:04:32
|
<djazayeri> okay
|
17:06:30
|
<sunbiz> djazayeri: can u send me ur databse please??
|
17:06:34
|
<sunbiz> email me??
|
17:06:42
|
<sunbiz> before the thing bombed??
|
17:08:23
|
<sunbiz> djazayeri: how many revisions did u update now??
|
17:09:29
|
*** dkayiwa has joined #openmrs
|
17:22:01
|
*** wyclif has quit IRC
|
17:28:19
|
*** lh has joined #openmrs
|
17:29:24
|
*** rafa has joined #openmrs
|
17:29:24
|
*** ChanServ sets mode: +v rafa
|
17:29:35
|
<sunbiz> djazayeri: ??
|
17:29:46
|
<djazayeri> rafa: btw, chopin wants to ask you questions about formentry-MDS
|
17:29:49
|
<djazayeri> sunbiz: sorry, got distracted
|
17:30:20
|
<sunbiz> can u send me??
|
17:30:27
|
<sunbiz> ur earlier database
|
17:30:33
|
<sunbiz> before the bombing happened?? :D
|
17:30:39
|
<djazayeri> there's no earlier/later database
|
17:30:42
|
<rafa> djazayeri: Hi
|
17:30:42
|
<djazayeri> I did an svn update
|
17:30:48
|
<rafa> djazayeri: thanks for the info
|
17:30:51
|
<sunbiz> from what to what rev??
|
17:31:00
|
<rafa> djazayeri: I've e-mailed him already
|
17:31:18
|
<djazayeri> okay, it would probably be instructive for that conversation to happen on the dev list
|
17:31:47
|
<djazayeri> sunbiz: unfortunately I restarted eclipse, so I don't have the svn log anymore
|
17:31:52
|
<djazayeri> I just updated a few revisions
|
17:31:53
|
<sunbiz> djazayeri: I think I figured why its working for me... because I think have a new liquibase 2.0 checksum with 1.7 and 1.8 and hence the upgrade went well
|
17:31:54
|
<MarkG> is there some place i can get the jars for the latest 1.6.x release and corresponding logic jar released with it?
|
17:32:15
|
<sunbiz> *I didnt have the new checksums
|
17:32:23
|
<MarkG> i'm working on a module that uses logic and it looks like something is screwed up because the 1.6 jars and the logic jar that I am using aren't in sync...
|
17:32:24
|
<djazayeri> sunbiz: I had done my prior svn update <24 hours before
|
17:32:47
|
<MarkG> ... looks like some method signatures changed in LogicContext...
|
17:33:01
|
<sunbiz> yes... so it gives us an opportunity to change as much as we like... without any issues because with liquibase 2.0 the checksums have changed
|
17:33:02
|
<djazayeri> MarkG: did you check the release notes page for the last 1.6 release (1.6.3 I think)?
|
17:33:20
|
<sunbiz> but if u are already in 2.0 cehcksum and things have changed... then it bombs
|
17:33:25
|
<MarkG> djazayeri: good point
|
17:33:42
|
<djazayeri> MarkG: before 1.6.3 it was logic 0.4.?
|
17:33:48
|
<djazayeri> from 1.6.3 it's logic 0.5
|
17:33:58
|
<MarkG> djazayeri: Mike told me he didn't think it was there... :)
|
17:34:01
|
*** Suranga has joined #openmrs
|
17:34:21
|
<MarkG> djazayeri: thanks... that was basically the question i needed answered...
|
17:34:41
|
<sunbiz> djazayeri: makes sense??
|
17:34:55
|
<sunbiz> so should I rampantly make changes... left and right??
|
17:35:09
|
*** wyclif has joined #openmrs
|
17:35:19
|
<sunbiz> without worry that no1 is doing an svn update since moving to liquibase v2.0 :P
|
17:35:50
|
<djazayeri> sunbiz: you're saying that this issue is only going to affect devs who have trunk checked out and update it regularly?
|
17:36:09
|
<djazayeri> (in this case I imagine the last time jtellez updated was a week before, and he was hit by this)
|
17:36:09
|
<sunbiz> yes... because with v2.0 it has changed checksums
|
17:36:27
|
<sunbiz> yes... he probably had liquibase v2.0 checksums
|
17:36:31
|
<djazayeri> sunbiz: how about if you just don't make whitespace changes to existing changesets? :-)
|
17:36:41
|
<sunbiz> djazayeri: :(
|
17:36:59
|
<sunbiz> there is opportunity to fix some changesets
|
17:37:21
|
<djazayeri> This is not an opportunity to make unnecessary changes to those changesets
|
17:37:33
|
<djazayeri> There are already 2 devs who cannot run trunk now because of this
|
17:37:37
|
<sunbiz> like isherman's changeset... which could do without another changeset and just have a modifySQL for mssql
|
17:38:04
|
<sunbiz> you can run trunk... just make all the checksums in liquibasechangelog to null
|
17:38:07
|
<djazayeri> dkayiwa: prioritizing tickets for 1.9
|
17:38:13
|
<sunbiz> and it will regenerate for those devs
|
17:38:14
|
<dkayiwa> ok
|
17:38:20
|
<djazayeri> can we talk now?
|
17:38:28
|
<djazayeri> I only have ~ 15 minutes before the design call
|
17:38:38
|
<dkayiwa> let me get my microphone
|
17:38:41
|
<djazayeri> not sure if you're planning to be on that or not
|
17:38:58
|
<djazayeri> but Jena would like to discuss the 1.9 ticket list with you
|
17:39:03
|
<dkayiwa> am planning to be on the design call djazayeri
|
17:39:13
|
<djazayeri> okay, let's see what we can do now
|
17:39:17
|
<dkayiwa> ok
|
17:39:20
|
<djazayeri> can you log onto skype?
|
17:39:25
|
<dkayiwa> ok
|
17:40:52
|
<dkayiwa> djazayeri: am on skype now
|
17:45:14
|
<chopin> hi rafa
|
17:45:20
|
<chopin> (we've been emailing)
|
17:45:25
|
<rafa> hi chopin
|
17:45:46
|
<rafa> chopin: I answered you
|
17:45:52
|
<chopin> rafa, do you have plans to mavenize MDS?
|
17:45:56
|
<chopin> rafa, yes, got the email
|
17:46:12
|
<rafa> chopin: it's not a priority at the moment
|
17:46:24
|
<rafa> chopin: would it help you?
|
17:46:52
|
<chopin> rafa, just need to get it into my maven project so i can depend on it. looking at how to do that now.
|
17:47:31
|
<rafa> chopin: Ohh that should be pretty easy
|
17:47:51
|
<rafa> chopin: you can configure a mvn repository within your project
|
17:48:05
|
<rafa> chopin: next you'll only need to install mds jar there
|
17:48:22
|
<rafa> chopin: I can find you an example
|
17:48:58
|
<chopin> rafa, ok
|
17:49:10
|
<downeym> rafa: ping
|
17:49:10
|
<chopin> rafa, are you opposed to hosting it in the openmrs nexus repo?
|
17:49:21
|
<rafa> chopin: no it's not needed
|
17:50:19
|
<rafa> chopin: see http://pastebin.com/mpTmbgZA
|
17:51:00
|
<rafa> chopin: does it make sense to you?
|
17:51:21
|
<rafa> chopin: but we can host it in the openmrs nexus repo too
|
17:51:39
|
<chopin> rafa, ah ok ... i'll do this for now :-D
|
17:51:42
|
<chopin> until you mavenize it
|
17:52:09
|
<rafa> chopin: cool
|
17:59:59
|
*** Suranga_ has joined #openmrs
|
18:03:55
|
*** Suranga has quit IRC
|
18:04:49
|
*** Suranga__ has joined #openmrs
|
18:09:04
|
*** Suranga_ has quit IRC
|
18:16:37
|
*** Echidna has quit IRC
|
18:17:06
|
*** Echidna has joined #openmrs
|
18:17:06
|
*** ChanServ sets mode: +v Echidna
|
18:17:53
|
*** robbyoconnor has joined #openmrs
|
18:17:53
|
*** ChanServ sets mode: +v robbyoconnor
|
18:24:03
|
<chopin> rafa, i see HandlerFactory is autowired into the service but i don't see a bean for it ... where is it created and how do i register a new handler?
|
18:25:41
|
<robbyoconnor> HAI
|
18:26:51
|
<downeym> ohai
|
18:27:44
|
<chopin> nvm, i'll try HandlerFactory.getInstance()
|
18:34:11
|
*** lh has quit IRC
|
18:34:26
|
*** lh has joined #openmrs
|
18:44:02
|
*** chughgaurav has quit IRC
|
18:47:46
|
<rafa> chopin: It seems this part is messed up. We've got two instances of HandlerFactory.
|
18:48:26
|
<rafa> chopin: One managed by Spring and one managed by HandlerFacotry as a singleton
|
18:48:59
|
<rafa> chopin: You'll be safe registering your handler in both
|
18:49:27
|
<chopin> heh ok
|
18:52:39
|
<bwolfe> wyclif, you know you have 4 open tickets in this sprint right now, right ?
|
18:54:23
|
<sunbiz> bwolfe: if u go here: https://wiki.openmrs.org/display/RES/Events
|
18:55:01
|
<sunbiz> on 4th Sunday... u will see OpenMRS Trunk 1.9 Roadmap Sprint 3 showing
|
18:55:21
|
<sunbiz> I was confused to see if the 1.9 sprint had begun
|
18:55:43
|
<bwolfe> ha
|
18:55:53
|
<downeym> o.O
|
18:55:58
|
<bwolfe> that was sprint 3
|
18:56:03
|
<bwolfe> and I think that was the end of it
|
18:56:15
|
<bwolfe> sprint 4 is the one starting on monday
|
18:56:35
|
<sunbiz> ok...
|
18:56:50
|
<bwolfe> perhaps we need fancy names for our sprints so we can remember them. perhaps naming them after, say, wild cats
|
18:56:59
|
<sunbiz> :D
|
18:57:07
|
* bwolfe doesn't know how that calendar is populated
|
18:57:10
|
<downeym> OpenMRS Tomcat
|
18:57:11
|
<downeym> err
|
18:57:30
|
<downeym> bwolfe: it shows all releases in TRUNK
|
18:57:43
|
<bwolfe> ah
|
18:57:55
|
<downeym> so it's based on the release date for each version
|
18:57:57
|
<downeym> in the project
|
18:59:05
|
<sunbiz> djazayeri: can you do an svn update and see if things are still failing...
|
18:59:35
|
<sunbiz> or I can download a rev before I started... and then create a database and start playing from there on...
|
19:00:24
|
<wyclif> bwolfe, yes, they have i will get the TODOs done today
|
19:00:43
|
<wyclif> bwolfe, yes, i will get the TODOs done today
|
19:01:00
|
<bwolfe> wyclif, awesome, ok
|
19:03:26
|
*** rafa has quit IRC
|
19:05:00
|
<djazayeri> sunbiz: I'm getting address already in use
|
19:05:21
|
<sunbiz> djazayeri: sorry?? when deploying??
|
19:05:31
|
<djazayeri> when doing jetty:run
|
19:05:33
|
<djazayeri> I'm on a call now
|
19:05:37
|
<djazayeri> can't research further
|
19:05:38
|
<sunbiz> jetty/tomcat might b already running
|
19:05:49
|
*** nribeka has joined #openmrs
|
19:05:49
|
*** ChanServ sets mode: +v nribeka
|
19:06:57
|
<djazayeri> sunbiz: yeah, two were. (?)
|
19:06:57
|
<sunbiz> djazayeri: nevermind... Im downloading the trunk till rev:23162
|
19:06:58
|
<djazayeri> it started fine
|
19:07:11
|
<sunbiz> I'll test from here onwards now...
|
19:07:20
|
<sunbiz> instead of from 1.8
|
19:09:21
|
*** bryq has joined #openmrs
|
19:09:21
|
*** ChanServ sets mode: +v bryq
|
19:11:24
|
<sunbiz> bwolfe, djazayeri, dkayiwa - look https://jira.atlassian.com/browse/CONF-20386
|
19:11:50
|
<sunbiz> they are using maven site :D for the documentation
|
19:12:23
|
<downeym> http://docs.atlassian.com/atlassian-core/4.5.9/project-info.html
|
19:12:28
|
<OpenMRSBot> <http://ln-s.net/9:0V> (at docs.atlassian.com)
|
19:12:34
|
<downeym> other projects at the root of that site
|
19:13:51
|
<sunbiz> yes... that built with maven on bottom left corner is nice
|
19:14:16
|
<downeym> that's probably not the best example on that server, there are quite a few :)
|
19:14:48
|
<sunbiz> dkayiwa: https://tickets.openmrs.org/browse/RESTWS-148 is "Ready for Work"
|
19:15:44
|
<sunbiz> ??
|
19:15:59
|
<dkayiwa> sunbiz: do u wanna take it up?
|
19:16:25
|
<chopin> should i set the scope of a dependent module to "compile" in my module's pom? for some reason when i install my module that depends on others, the context is getting thrown out of whack
|
19:17:39
|
<sunbiz> I want to make it as a maven site :)
|
19:17:51
|
<sunbiz> but not before I finish the TRUNK-1925
|
19:19:27
|
<bwolfe> chopin, theres a wiki page for what to set it to
|
19:19:58
|
<bwolfe> https://wiki.openmrs.org/display/docs/Requiring+another+module+in+your+module
|
19:19:59
|
<OpenMRSBot> <http://ln-s.net/9-5b> (at wiki.openmrs.org)
|
19:20:07
|
<chopin> o
|
19:20:24
|
<chopin> best part: i figured this out before
|
19:20:26
|
<chopin> thanks
|
19:22:15
|
<sunbiz> chopin: BTW, whats the generate tests plugin that u replied in that email
|
19:22:48
|
<sunbiz> chopin: did u mean this: https://wiki.openmrs.org/display/docs/Generate+Test+Case+Plugin
|
19:22:48
|
<chopin> sunbiz, there's a plugin for eclipse that generates tests for @should annotations
|
19:22:48
|
<OpenMRSBot> <http://ln-s.net/8zPd> (at wiki.openmrs.org)
|
19:22:51
|
<chopin> yes
|
19:22:57
|
<chopin> we need that in nb
|
19:23:04
|
<chopin> there's a version for IDEA
|
19:23:49
|
<bwolfe> chopin, yeah, that wiki page was written from your suggestions
|
19:24:02
|
<sunbiz> ohh... nice :D
|
19:24:18
|
<sunbiz> I wondered why the test methods had just weird long names
|
19:24:28
|
<sunbiz> and I thought djazayeri introduced that convention
|
19:24:39
|
<sunbiz> when actually it was that plugins convention
|
19:25:02
|
<bwolfe> we wrote the plugin to follow our convention
|
19:25:23
|
<sunbiz> does everyone use that plugin??
|
19:25:36
|
<sunbiz> and have test methods to that convention??
|
19:25:47
|
<bwolfe> they should
|
19:25:56
|
<bwolfe> https://wiki.openmrs.org/display/docs/Testing
|
19:26:03
|
<bwolfe> https://wiki.openmrs.org/display/docs/Unit+Testing+with+at+should+annotation
|
19:30:24
|
<sunbiz> nice
|
19:47:10
|
*** robbyoconnor has quit IRC
|
19:53:49
|
<sunbiz> bwolfe: why do u say the mysql is not required??
|
19:54:01
|
<sunbiz> *dbms="mysql"
|
19:54:30
|
<sunbiz> I dont want new installations to run all those changesets
|
19:56:18
|
*** chughgaurav has joined #openmrs
|
19:56:18
|
<bwolfe> sunbiz, they won't because their will be an entry in the liquibasechangelog table for new installations because the new schema-only file will write to the liquibasechangelog table for each changeset in update-to-latest
|
19:56:27
|
<bwolfe> sunbiz, same as I said in the ticket, no?
|
19:57:21
|
<sunbiz> but even for new installations it will run the update-to-latest right??
|
19:57:37
|
<sunbiz> sorry... I wanted to clarify what u meant in the ticket
|
19:57:46
|
<bwolfe> yes, it will. but only chagnesets that are not listed in the liquibasechangelog table are run
|
19:58:03
|
<bwolfe> and thats why I say you write to the liquibasechangelog
|
19:58:09
|
<bwolfe> to prevent those from running for new installs
|
19:58:23
|
<sunbiz> hmm... but they should have the same ids
|
19:58:25
|
<bwolfe> because you're taking them past the update-to-latest you can write those
|
19:58:40
|
<bwolfe> what do you mean by same ids?
|
19:58:42
|
<bwolfe> who should?
|
19:59:20
|
<sunbiz> how do I write to liquibasechangelog
|
19:59:32
|
<bwolfe> same way you write to any other table
|
19:59:33
|
<sunbiz> do u mean using a manual insert statement??
|
19:59:34
|
<bwolfe> I think
|
19:59:51
|
<bwolfe> I think thats your only option. I haven't seen an xml tag for it
|
20:01:41
|
<chopin> arrrrrrrrrrgh
|
20:02:51
|
*** MarkG has quit IRC
|
20:02:52
|
*** Echidna has quit IRC
|
20:02:52
|
*** mnunez has quit IRC
|
20:02:52
|
*** sunbiz has quit IRC
|
20:02:53
|
*** wyclif has quit IRC
|
20:02:57
|
*** lh has quit IRC
|
20:02:58
|
*** bwolfe has quit IRC
|
20:03:00
|
*** nribeka has quit IRC
|
20:03:00
|
*** Suranga__ has quit IRC
|
20:03:00
|
*** downeym has quit IRC
|
20:03:00
|
*** djazayeri has quit IRC
|
20:03:02
|
*** gbastien has quit IRC
|
20:03:05
|
*** Gretchie has quit IRC
|
20:03:51
|
*** nribeka has joined #openmrs
|
20:03:51
|
*** lh has joined #openmrs
|
20:03:51
|
*** Echidna has joined #openmrs
|
20:03:51
|
*** Suranga__ has joined #openmrs
|
20:03:51
|
*** wyclif has joined #openmrs
|
20:03:51
|
*** downeym has joined #openmrs
|
20:03:51
|
*** mnunez has joined #openmrs
|
20:03:51
|
*** sunbiz has joined #openmrs
|
20:03:51
|
*** zelazny.freenode.net sets mode: +vvov nribeka Echidna downeym sunbiz
|
20:03:51
|
*** MarkG has joined #openmrs
|
20:03:51
|
*** gbastien has joined #openmrs
|
20:03:51
|
*** bwolfe has joined #openmrs
|
20:03:51
|
*** Gretchie has joined #openmrs
|
20:03:51
|
*** djazayeri has joined #openmrs
|
20:03:51
|
*** zelazny.freenode.net sets mode: +oo bwolfe djazayeri
|
20:03:51
|
*** OpenMRSBot sets mode: +o downeym
|
20:04:48
|
<sunbiz> bwolfe: so... if I understand u correctly - u are suggesting that instead of doing dbms="mysql", I should at the end of the schema-only, create a changeset that will insert rows representing the changesets from update-to-latest??
|
20:06:11
|
<bwolfe> yep
|
20:06:38
|
<sunbiz> bwolfe: thanks!!
|
20:07:11
|
<bwolfe> !karam sunbiz
|
20:07:11
|
<OpenMRSBot> bwolfe: Error: "karam" is not a valid command.
|
20:07:19
|
<bwolfe> !karma sunbiz
|
20:07:19
|
<OpenMRSBot> bwolfe: Karma for "sunbiz" has been increased 1 time and decreased 1 time for a total karma of 0.
|
20:08:05
|
<Suranga__> djazayeri, howdy
|
20:08:49
|
<Suranga__> djazayeri, want me to look into anything ?
|
20:09:25
|
<sunbiz> bwolfe++
|
20:14:42
|
<sunbiz> what is the encryption.vector and encryption.key in the runtime properties... they were supposed to be commented... but are not in new installations now
|
20:14:45
|
<Suranga__> Asian internet connections--
|
20:15:18
|
*** gbastien has quit IRC
|
20:15:33
|
*** gbastien has joined #openmrs
|
20:15:53
|
* bwolfe tells sunbiz to look at chopin
|
20:16:02
|
<sunbiz> at least it was supposed to be committed as of: https://wiki.openmrs.org/display/docs/Overriding+OpenMRS+Default+Runtime+Properties
|
20:16:03
|
<OpenMRSBot> <http://ln-s.net/8c91> (at wiki.openmrs.org)
|
20:16:54
|
<chopin> umm
|
20:17:08
|
<sunbiz> chopin: wait... lemme ask this on answers.opennmrs.org
|
20:17:14
|
<sunbiz> and u get some points for it!!
|
20:17:14
|
<chopin> heh ok
|
20:17:15
|
<sunbiz> ok??
|
20:17:38
|
<bwolfe> *cough* karma whores *cough*
|
20:17:43
|
<chopin> heh
|
20:18:13
|
<sunbiz> chopin: u weren't asnwering... so I thought lemme put some dough down!!
|
20:18:45
|
<chopin> hah
|
20:18:48
|
*** Gretchie has quit IRC
|
20:18:52
|
<chopin> i'm easily distracted :-)
|
20:19:58
|
<sunbiz> https://answers.openmrs.org/questions/240/what-is-the-encryptionvector-and-encryptionkey-in-the-runtime-properties
|
20:20:07
|
<OpenMRSBot> <http://ln-s.net/9:1q> (at answers.openmrs.org)
|
20:27:13
|
*** bryq has quit IRC
|
20:30:18
|
<chopin> thx sunbiz, cya all o/
|
20:31:14
|
<mnunez> Hi! Quick question: I'm getting a javascript error while adding and changing drug regimes in OpenMRS. Where is the error log supposed to be?
|
20:33:36
|
*** Suranga__ has quit IRC
|
20:36:45
|
*** chopin has quit IRC
|
21:04:36
|
*** lh has quit IRC
|
21:04:39
|
*** mnunez has left #openmrs
|
21:04:40
|
*** lh_ has joined #openmrs
|
21:04:53
|
*** lh_ has joined #openmrs
|
21:08:58
|
*** mnunez has joined #openmrs
|
21:11:37
|
*** nribeka has quit IRC
|
21:13:38
|
*** sunbiz has left #openmrs
|
21:25:33
|
*** bwolfe has quit IRC
|
21:31:08
|
<MarkG> sync blocker:
|
21:31:11
|
<MarkG> !sync-223
|
21:31:12
|
<OpenMRSBot> MarkG: Error: "sync-223" is not a valid command.
|
21:31:18
|
<djazayeri> !ticket sync-233
|
21:31:19
|
<OpenMRSBot> djazayeri: Issue Does Not Exist - OpenMRS JIRA - https://tickets.openmrs.org/browse/sync-233
|
21:31:29
|
<djazayeri> !ticket sync-223
|
21:31:30
|
<OpenMRSBot> djazayeri: [#SYNC-223] No Child to Parent syncing happens with current trunk build of Sync Module - OpenMRS JIRA - https://tickets.openmrs.org/browse/sync-223
|
21:31:38
|
<MarkG> i'll figure it out one of these days... :)
|
21:32:08
|
<djazayeri> wyclif, dkayiwa, any comments?
|
21:32:30
|
<wyclif> djazayeri, do you mean random comments?
|
21:32:38
|
<djazayeri> About sync-223
|
21:32:50
|
<wyclif> hmm..
|
21:33:35
|
<wyclif> the last time i tried it, it worked
|
21:33:37
|
<djazayeri> MarkG: in FLAG-4, are you using Context.loadClass(className)?
|
21:33:45
|
<wyclif> will check later today and comment on the ticket
|
21:33:52
|
<djazayeri> wyclif: any recent commits that might have done something bad?
|
21:34:16
|
<wyclif> i have committed anything personally in the today and yesterday to sync module
|
21:34:24
|
<wyclif> sorry today
|
21:34:30
|
<wyclif> havent
|
21:34:33
|
<djazayeri> okay
|
21:34:49
|
<wyclif> what i worked on i just created a patch and attached to the ticket
|
21:35:10
|
<wyclif> but..
|
21:35:21
|
<wyclif> i ran a unit test that failed for me
|
21:35:22
|
<MarkG> djazayeri: I changed Patient Flags today to do this: OpenmrsClassLoader.getInstance().loadClass(evaluator).newInstance()
|
21:35:37
|
<wyclif> the SyncUtilTransmissionTest
|
21:35:43
|
<djazayeri> MarkG: does that fix the problem?
|
21:36:00
|
<djazayeri> I think you should be doing Context.loadClass(evaluator).newInstance()
|
21:36:13
|
<djazayeri> But I don't know if that'll work or not.
|
21:36:21
|
<MarkG> I haven't actually tested the issue...
|
21:36:28
|
<djazayeri> (I'm emailing the dev list spurred by flag-4
|
21:36:30
|
<djazayeri> gotcha
|
21:36:43
|
<MarkG> Pascal said that it still wouldn't work, but i haven't tested it myself...
|
21:36:53
|
<MarkG> i just wanted to make sure i captured Pascal's issue
|
21:36:54
|
<djazayeri> what did you change _from_?
|
21:37:43
|
<MarkG> Class.forName(evaluator).newInstance()
|
21:37:52
|
*** lh_ is now known as lh
|
21:38:02
|
*** lh is now known as lh_roaming
|
21:38:05
|
<MarkG> basically, Pascal told me yesterday that it wasn't working because I wasn't using the class loader...
|
21:38:43
|
<MarkG> but that even if we changed it to use the class loader, it wouldn't work unless the module was listed as a dependency...
|
21:39:14
|
<MarkG> i should have added something to the ticket says that this needs to be confirmed...
|
21:39:25
|
<djazayeri> ok, thx
|
21:39:43
|
<MarkG> so it may not be worth raising on the dev list yet...
|
21:43:42
|
*** dkayiwa has quit IRC
|
21:57:42
|
*** downeym has quit IRC
|
21:59:47
|
*** MarkG has quit IRC
|
22:05:52
|
*** wyclif has quit IRC
|
22:34:40
|
*** chughgaurav has quit IRC
|
22:37:02
|
*** mnunez has quit IRC
|
23:34:58
|
*** lh has joined #openmrs
|
23:34:58
|
*** lh has joined #openmrs
|
23:34:58
|
*** lh_roaming has quit IRC
|