| 00:05:35 | <sunbiz> djazayeri: shouldAllowTwoTasksInitMethodsToRunConcurrently(org.openmrs.scheduler.SchedulerServiceTest) which was failing for judy |
| 00:05:44 | <sunbiz> seems like a time-bound test that's failing |
| 00:05:48 | <djazayeri> probably true |
| 00:12:19 | <sunbiz> djazayeri: do u know why we have a column as both primary key and unique key?? |
| 00:12:40 | <sunbiz> concept_word_id is one of thos columns |
| 01:04:36 | *** mathiaslin has joined #openmrs |
| 02:23:13 | *** gbastien has quit IRC |
| 02:31:26 | *** bryq1 has joined #openmrs |
| 03:12:36 | *** sunbiz has left #openmrs |
| 03:20:13 | *** upul` has joined #openmrs |
| 03:20:13 | *** ChanServ sets mode: +v upul` |
| 03:38:26 | *** surangak has joined #openmrs |
| 03:55:03 | *** jriley has quit IRC |
| 04:09:01 | *** muthah has joined #openmrs |
| 04:16:17 | *** surangak_ has joined #openmrs |
| 04:16:17 | *** surangak has quit IRC |
| 04:19:17 | *** surangak_ has quit IRC |
| 04:19:30 | *** surangak_ has joined #openmrs |
| 04:39:20 | *** mathiaslin has quit IRC |
| 05:05:06 | *** muthah has quit IRC |
| 05:08:28 | *** sunbiz has joined #openmrs |
| 05:08:28 | *** ChanServ sets mode: +v sunbiz |
| 05:08:56 | <sunbiz> wyclif: why did ur tests pass and mine did not?? |
| 05:09:06 | <sunbiz> I didnt even make a change to the src files!! :P |
| 05:09:14 | <wyclif> hmmm |
| 05:09:14 | <sunbiz> not fair!!! :P |
| 05:09:18 | <wyclif> not sure why |
| 05:09:44 | <wyclif> sunbiz, sometimes it is the build process that fails |
| 05:10:00 | <wyclif> but subsequent builds might pass |
| 05:10:18 | <wyclif> there were no test failures for your commit |
| 05:10:40 | <wyclif> at times it is out of memory issues on CI |
| 05:10:40 | <sunbiz> yes, I saw that!! |
| 05:10:49 | <sunbiz> it just killed itself... suicide!! |
| 05:10:54 | <sunbiz> and blamed it on me |
| 05:10:58 | <wyclif> hmm |
| 05:11:10 | <wyclif> it s annoying |
| 05:14:13 | *** finbrein has quit IRC |
| 05:14:33 | <surangak_> sunbiz, seems that Ci has done that several times |
| 05:14:40 | <sunbiz> lets see... another one triggered |
| 05:14:54 | <sunbiz> surangak_: yes... :P |
| 05:15:04 | <surangak_> sunbiz, few days ago also guys were complaining, that tests get killed :D |
| 05:15:11 | <sunbiz> yes |
| 05:15:22 | *** mathiaslin has joined #openmrs |
| 05:16:18 | <sunbiz> another one triggered... Im watching it!! :D |
| 05:17:01 | <sunbiz> looks like a failure!! |
| 05:17:12 | <sunbiz> noooooooooo >:o |
| 05:17:32 | <sunbiz> the ci hates me... Im sure now!!! |
| 05:19:53 | <surangak_> ci is a real mean guy, it hates most of us :-( |
| 05:33:01 | *** finbrein has joined #openmrs |
| 05:56:28 | *** bwolfe has joined #openmrs |
| 05:56:28 | *** ChanServ sets mode: +o bwolfe |
| 06:04:03 | *** robbyoconnor has joined #openmrs |
| 06:04:04 | *** ChanServ sets mode: +v robbyoconnor |
| 06:19:04 | *** morristic has joined #openmrs |
| 06:20:29 | *** morristic has left #openmrs |
| 06:20:39 | *** deadpool has joined #openmrs |
| 06:24:58 | *** morristic has joined #openmrs |
| 06:27:02 | *** deadpool has quit IRC |
| 06:27:19 | *** morristic has quit IRC |
| 06:34:33 | *** pascal` has joined #openmrs |
| 06:39:46 | *** deadpool has joined #openmrs |
| 07:05:58 | *** deadpool has quit IRC |
| 07:17:19 | *** rafa has joined #openmrs |
| 07:17:19 | *** ChanServ sets mode: +v rafa |
| 07:19:36 | *** deadpool has joined #openmrs |
| 07:23:50 | <rafa> hi bwolfe |
| 07:23:58 | <bwolfe> rafa, you're alive! |
| 07:24:04 | <rafa> :) |
| 07:24:12 | <bwolfe> feeling better today? |
| 07:24:18 | <rafa> yeah, much butter |
| 07:24:19 | <rafa> thanks |
| 07:24:45 | <bwolfe> great. now get back to work. |
| 07:24:49 | <bwolfe> :-D |
| 07:25:00 | *** dkayiwa has joined #openmrs |
| 07:25:00 | <rafa> haha so where are we standing? :D |
| 07:25:12 | <rafa> there's one ticket left for me? |
| 07:25:14 | <bwolfe> I'm sitting |
| 07:25:22 | <bwolfe> you don't have any tickets? |
| 07:25:37 | <rafa> nothing claimed |
| 07:25:48 | <bwolfe> yeah, claim that last one rafal |
| 07:25:57 | <bwolfe> its basically putting code back in and making it optional |
| 07:26:15 | <rafa> good |
| 07:26:28 | <rafa> I only don't entirely understand your last comment |
| 07:26:34 | <rafa> about setting auto_increment |
| 07:26:44 | <rafa> is it part of this ticket? |
| 07:27:43 | <rafa> bwolfe: |
| 07:28:40 | * bwolfe goes to look |
| 07:31:48 | <bwolfe> rafa, the autoincrement thing is something that will have to go in the documentation, not in your code |
| 07:32:04 | <bwolfe> rafa, the problem. (aka why I made the autoincrement comment): |
| 07:32:15 | <rafa> bwolfe: yes, I understand the problem |
| 07:32:23 | <rafa> bwolfe: just wasn't sure if I need to code it up |
| 07:32:27 | <bwolfe> oh, ok |
| 07:32:35 | <rafa> bwolfe: thanks |
| 07:32:42 | <bwolfe> good then, I won't write up a huge thing on why its needed :-) |
| 07:32:59 | <bwolfe> rafa, part of the ticket is to document what it is, how it works, what the impl needs to do, etc |
| 07:33:04 | <bwolfe> (and why you might want to do it) |
| 07:33:11 | <bwolfe> the default shoudl be that concept_ids are NOT preserved |
| 07:33:27 | <rafa> bwolfe: all right |
| 07:34:37 | <rafa> bwolfe: in retrospect you could write a huge thing, I would just copy & paste :P |
| 07:35:02 | <bwolfe> nah |
| 08:05:57 | *** rafa has quit IRC |
| 08:44:08 | <surangak_> bwolfe, howdy |
| 08:44:19 | <surangak_> bwolfe, i just saw your comments regarding my changeset |
| 08:44:27 | <surangak_> bwolfe, not quite understanding... |
| 08:44:38 | <surangak_> u mean the latest after i did the corrections ? |
| 09:03:59 | *** deadpool has quit IRC |
| 09:16:57 | <bwolfe> surangak_, yes |
| 09:17:03 | <bwolfe> there is a review attached to the ticket already |
| 09:17:17 | <bwolfe> you can go in there and edit the review to add more commits |
| 09:17:31 | <surangak_> bwolfe, I updated the modified files |
| 09:17:51 | <surangak_> they were saying 'file outdated' on top. |
| 09:19:42 | <bwolfe> surangak_, click the plus on the left side to add commits |
| 09:23:11 | <surangak_> bwolfe, i added my latest commites to it |
| 09:23:18 | <surangak_> bwolfe, how does it look now ? |
| 09:23:37 | <bwolfe> link? |
| 09:23:43 | <bwolfe> (so I don't have to go find the review) |
| 09:24:03 | <surangak_> oh, sorry |
| 09:24:42 | <surangak_> im new to all this :P https://source.openmrs.org/cru/CR-MOD-303 |
| 09:29:04 | <bwolfe> surangak_, yeah, looks right |
| 09:29:08 | <bwolfe> I'll look at it later tonight |
| 09:29:19 | <surangak_> bwolfe, sure, no problem :-) |
| 09:30:24 | <bwolfe> surangak_, and be sure to put the ticket in post commit review again by clicking the "committed code" button on the ticket |
| 09:36:10 | <surangak_> bwolfe, just did that |
| 10:02:13 | *** bwolfe has quit IRC |
| 10:03:52 | *** rafa has joined #openmrs |
| 10:03:52 | *** ChanServ sets mode: +v rafa |
| 10:09:03 | *** dkayiwa has quit IRC |
| 10:12:07 | *** pascal` has quit IRC |
| 10:16:31 | *** dkayiwa has joined #openmrs |
| 10:21:12 | *** magoo_ has joined #openmrs |
| 10:27:33 | *** pascal` has joined #openmrs |
| 10:47:25 | *** deadpool has joined #openmrs |
| 10:54:25 | <deadpool> does any one know why i am getting an errno 121 in one instance of openmrs while another one is fine? |
| 10:54:25 | <deadpool> this is for trying to create the table in mysql |
| 11:08:37 | *** surangak_ has quit IRC |
| 11:08:49 | <pascal`> deadpool, what does the innodb status report say? |
| 11:09:24 | <deadpool> pascal`: where is that located |
| 11:09:32 | <pascal`> mysql> show innodb status; |
| 11:10:17 | <pascal`> You have to do it right after the error happens though, then scroll up to LATEST FOREIGN KEY ERROR. |
| 11:11:40 | <deadpool> yeah i see it is says foreign key constraint already exists |
| 11:12:02 | <deadpool> but what doesn't make sense to me is that it works on my build machine and it gives me an error on the deployment machine |
| 11:12:50 | *** rafa_ has joined #openmrs |
| 11:12:50 | *** ChanServ sets mode: +v rafa_ |
| 11:14:28 | *** rafa has quit IRC |
| 11:16:54 | <deadpool> pascal`: i am also using tomcat6.0.28 and quite frequently getting out of memory error is there a way to bypass that? |
| 11:17:18 | <pascal`> !oom |
| 11:17:19 | <OpenMRSBot> pascal`: "oom" --- (#1) moo backwards, or (#2) https://wiki.openmrs.org/display/docs/Troubleshooting+Memory+Errors |
| 11:17:38 | <deadpool> pascal`: i have done that |
| 11:17:48 | <deadpool> i get an out of memory error like every day |
| 11:17:53 | <deadpool> i increased it to 1gb |
| 11:18:17 | <deadpool> and still getting in a hospital environment that is not a good idea to have to restart the server every now and then |
| 11:22:33 | *** upul` has quit IRC |
| 11:24:39 | <deadpool> pascal`: thanks i got the errno fixed |
| 11:25:02 | <pascal`> deadpool, Good. |
| 11:25:49 | *** mathiaslin has quit IRC |
| 11:29:43 | *** mathiaslin has joined #openmrs |
| 11:30:27 | *** mathiaslin has quit IRC |
| 11:35:51 | *** pascal`` has joined #openmrs |
| 11:36:14 | *** magoo_ has quit IRC |
| 11:37:13 | *** pascal` has quit IRC |
| 11:42:01 | *** bwolfe has joined #openmrs |
| 11:42:01 | *** ChanServ sets mode: +o bwolfe |
| 11:53:41 | *** magoo_ has joined #openmrs |
| 12:07:39 | *** pascal`` is now known as pascal` |
| 12:07:52 | *** ChanServ sets mode: +v pascal` |
| 12:12:11 | *** bwolfe has quit IRC |
| 12:12:30 | *** chughgaurav has joined #openmrs |
| 12:12:45 | *** bwolfe has joined #openmrs |
| 12:12:45 | *** ChanServ sets mode: +o bwolfe |
| 12:15:39 | <chughgaurav> I am trying to fix ticket ( https://tickets.openmrs.org/browse/TRUNK-2590) , shall I add a normal HTML alert dialog box ? |
| 12:17:28 | *** wyclif has quit IRC |
| 12:17:50 | *** wyclif has joined #openmrs |
| 12:26:23 | <pascal`> chughgaurav, it's probably best to look at how similar things are done elsewhere in the system. |
| 12:26:28 | *** chughgaurav has quit IRC |
| 12:31:01 | *** chughgaurav has joined #openmrs |
| 12:35:16 | *** chughgaurav has quit IRC |
| 12:47:13 | *** bwolfe has quit IRC |
| 12:54:51 | *** dkayiwa has quit IRC |
| 12:59:42 | *** dkayiwa has joined #openmrs |
| 13:01:18 | *** magoo_ has quit IRC |
| 13:10:02 | *** deadpool has quit IRC |
| 13:15:50 | *** chopin has joined #openmrs |
| 13:15:56 | *** ChanServ sets mode: +v chopin |
| 13:16:03 | <chopin> pascal`++ coffee++ |
| 13:16:48 | <pascal`> hey chopin |
| 13:16:51 | <pascal`> chopin++ |
| 13:16:57 | <pascal`> coffee++ |
| 13:16:59 | <chopin> :-) |
| 13:17:53 | *** gbastien has joined #openmrs |
| 13:33:06 | <sunbiz> chopin: are u looking at: https://tickets.openmrs.org/browse/TRUNK-2621 |
| 13:33:48 | <sunbiz> chopin: sorry.. I mean SEARCH-10 (https://tickets.openmrs.org/browse/SEARCH-10) is dependent on TRUNK-2621 |
| 13:34:19 | <sunbiz> ahhh... TRUNK-2621 is dependent on SEARCH-10 |
| 14:07:45 | <djazayeri> hi all |
| 14:07:59 | <rafa_> hi Darius |
| 14:08:02 | <djazayeri> hi rafa_, dkayiwa, wyclif |
| 14:08:04 | *** rafa_ is now known as rafa |
| 14:08:05 | <djazayeri> no bwolfe, I see |
| 14:08:11 | <dkayiwa> hi |
| 14:08:12 | <wyclif> hi |
| 14:08:45 | <djazayeri> looks like he'll be late |
| 14:09:10 | <djazayeri> we should probably wait for him, as I haven't been following the sync tickets |
| 14:32:25 | <chopin> sunbiz: putting out fires atm, hope to get SEARCH-10 done soon |
| 14:32:57 | <djazayeri> chopin: hey, btw, what's the status of AMPATH rolling out sync? (I was asked this by Hamish and Alvin) |
| 14:34:21 | <chopin> djazayeri: sync is running ... and not running very well right now. timing was off rendering the remotes and now we have to go back and start over again :( |
| 14:34:38 | <djazayeri> "timing was off"? |
| 14:34:58 | <chopin> db snapshot taken before creating the remotes in the db |
| 14:35:07 | <chopin> in a few cases, a week ahead |
| 14:35:12 | <chopin> even though sync was installed and running |
| 14:35:39 | <chopin> so ... have some db updates to do so we can get the sync records set up for the remotes from the right starting time |
| 14:35:41 | <chopin> confusing |
| 14:35:51 | <chopin> but ben says he knows the answer |
| 14:36:54 | <djazayeri> okay |
| 14:37:01 | <djazayeri> how about the performance issue with hl7 queue? |
| 14:37:04 | <djazayeri> did that get resolved? |
| 14:37:10 | <djazayeri> (you didn't send me another snapshot) |
| 14:38:22 | <chopin> yeah, i had to write a new processor to look for particular HL7s to process them first ... and that's going to skew the results. i started getting 5-6 HL7s per second with the UUID map, and that's a much better situation |
| 14:38:55 | <chopin> I also found an issue with our c3p0 pooling; mysql was set at the default (150) and we had a hibernate setting in our properties file setting it to 250 |
| 14:39:09 | <chopin> after a while the connection was killed but hibernate tried to keep using it |
| 14:39:18 | <djazayeri> that's in the general openmrs install? or a custom ampath config file? |
| 14:39:20 | <chopin> seemed to happen a lot with the HL7 processor task's connection |
| 14:39:23 | <chopin> custom |
| 14:39:36 | <chopin> so, i upped mysql's max_connections to 255 |
| 14:39:39 | <chopin> and it seems to be doing well now |
| 14:39:41 | <chopin> :-) |
| 14:43:31 | <chopin> seems like we maxed out at 3 HL7s / sec today |
| 14:43:46 | <chopin> if we could average 5-10, i think we'd be happy |
| 14:43:57 | <chopin> (also depends on the rate of HL7 creation ... not sure what that is) |
| 14:44:03 | <djazayeri> What's the impact of processing only 3/sec? |
| 14:44:08 | <djazayeri> That during the day formentry gets backed up? |
| 14:44:13 | <chopin> yes |
| 14:44:13 | <djazayeri> and it catches up at night? |
| 14:44:16 | <chopin> yep |
| 14:44:31 | <chopin> but there are a few forms that need to have "instant" results |
| 14:44:47 | <chopin> i.e. the form data needs to be present to print off a reminder card |
| 14:44:52 | <djazayeri> People are entering >3 forms per second? |
| 14:45:05 | <chopin> probably not, but we do have labs coming in at the same time |
| 14:45:13 | <chopin> so that's the other question: what's the rate of incoming HL7s |
| 14:45:18 | <chopin> i really need to just time the processing |
| 14:45:20 | <chopin> to see what it is |
| 14:45:25 | <chopin> although it will add to the time |
| 14:45:29 | <chopin> (logging the time) |
| 14:45:34 | <chopin> s/time/speed |
| 14:48:24 | <djazayeri> chopin: anyway, let me know if you want me to look at another snapshot, e.g. the one for non-lab hl7 results |
| 14:48:50 | *** MarkG_ has joined #openmrs |
| 14:49:20 | <djazayeri> But if things are really being slowed down by labs specifically, maybe you really do want to introduce a priority mechanism purely to process those last. |
| 14:49:34 | <djazayeri> or else create them as encounters rather than a bunch of obs. :-) |
| 14:49:41 | <chopin> exactly, hoping to do both :-D |
| 14:50:42 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @pbiondich: I support mHealth Alliance's selection of @PattyMechael for ED. We (me and @OpenMRS) are behind your desire to standardi ... <http://twitter.com/OpenMRS/statuses/113618792688521216> |
| 14:51:39 | <djazayeri> chopin: because (especially as we add "visits" to the data model) encounters are really supposed to represent data entry transactions like that. |
| 14:53:44 | <MarkG_> sync people: do we want to set the Alert class as one that is not sync'ed by default, since we seem to be using Alerts now within the sync module? |
| 14:55:05 | <djazayeri> MarkG_: that's an interesting point |
| 14:55:25 | <djazayeri> wyclif: any thoughts? |
| 14:56:51 | <MarkG_> we installed a recent version of the sync module last night and now I have 325 Alerts that it is trying to sync... :) |
| 14:57:18 | *** pascal` has quit IRC |
| 14:57:49 | *** dkayiwa has quit IRC |
| 14:58:51 | <djazayeri> yeah, synchronizing those seems bad |
| 14:58:59 | <djazayeri> are GPs already not synchronized? |
| 14:59:53 | <MarkG_> yeah... |
| 15:00:04 | <djazayeri> so I think alerts shouldn't be either |
| 15:00:17 | <MarkG_> i agree... i will write up a ticket |
| 15:00:29 | <djazayeri> also, I wouldn't recommend building sync from source in mid-sprint... |
| 15:01:21 | <djazayeri> rafa, wyclif, dkayiwa: looks like ben is much later than I expected |
| 15:01:24 | <djazayeri> let's give our reports now |
| 15:01:29 | <wyclif> am fine with not syncing them |
| 15:02:18 | <wyclif> daniel seems offline too |
| 15:02:27 | <rafa> I'm here |
| 15:02:33 | <rafa> and ready |
| 15:02:37 | <djazayeri> okay, rafa, go first |
| 15:02:44 | <rafa> *** Rafal *** |
| 15:02:44 | <rafa> Today: |
| 15:02:45 | <rafa> * Worked on SYNC-160: Concepts saved out of order. |
| 15:02:45 | <rafa> https://tickets.openmrs.org/browse/SYNC-160, testing now... |
| 15:02:45 | <rafa> Tomorrow: |
| 15:02:45 | <rafa> * Complete SYNC-160 |
| 15:02:45 | <rafa> * Start working on MDS |
| 15:02:46 | <rafa> No blockers. |
| 15:04:55 | <djazayeri> okay |
| 15:05:05 | <djazayeri> wyclif: your turn |
| 15:05:51 | <wyclif> yesterday: |
| 15:05:51 | <wyclif> - created and fixed SYNC-218 |
| 15:05:51 | <wyclif> - Investigated about SYNC-173 |
| 15:05:51 | <wyclif> - Code review for TRUNK-2298 |
| 15:05:51 | <wyclif> - Helped Judy with some OpenMRS installation issues |
| 15:05:52 | <wyclif> - Made a partial commit to TRUNK-2605 and added snapshots |
| 15:05:54 | <wyclif> today: |
| 15:05:56 | <wyclif> - SYNC-173(still haven't yet firgured out the best way to handle this) |
| 15:05:58 | <wyclif> - Respond to Ben's comment on SYNC-157 |
| 15:06:00 | <wyclif> - Other SYNC- tickets if any otherwise 1.9 sprint tickets |
| 15:06:07 | <djazayeri> !ticket sync-218 |
| 15:06:08 | <OpenMRSBot> djazayeri: [#SYNC-218] NullPointerException when Jump to next error is clicked - OpenMRS JIRA - https://tickets.openmrs.org/browse/sync-218 |
| 15:06:18 | <djazayeri> !ticket sync-173 |
| 15:06:19 | <OpenMRSBot> djazayeri: [#SYNC-173] Sync creates sync record for failed API call - OpenMRS JIRA - https://tickets.openmrs.org/browse/sync-173 |
| 15:06:35 | <djazayeri> !ticket trunk-2289 |
| 15:06:37 | <OpenMRSBot> djazayeri: [#TRUNK-2289] Widget decorator should be able to include a "refresh" button - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2289 |
| 15:06:45 | <djazayeri> !ticket trunk-2298 |
| 15:06:46 | <OpenMRSBot> djazayeri: [#TRUNK-2298] Add includedVoided argument to EncounterService.getEncountersByVisit - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2298 |
| 15:06:51 | <MarkG_> @djazayeri: yeah, good point re: installing mid-sprint; i just needed one of the fixes i added... |
| 15:07:00 | <djazayeri> !ticket trunk-2605 |
| 15:07:01 | <OpenMRSBot> djazayeri: [#TRUNK-2605] Redo Visit tab on patient dashboard to show grouped encounters - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2605 |
| 15:07:05 | <djazayeri> !ticket sync-173 |
| 15:07:06 | <OpenMRSBot> djazayeri: [#SYNC-173] Sync creates sync record for failed API call - OpenMRS JIRA - https://tickets.openmrs.org/browse/sync-173 |
| 15:07:11 | <djazayeri> !ticket sync-157 |
| 15:07:12 | <OpenMRSBot> djazayeri: [#SYNC-157] Split "Max Sent Records" into "Max Sent Records via File" and "Max Sent Records via Web" - OpenMRS JIRA - https://tickets.openmrs.org/browse/sync-157 |
| 15:07:45 | <djazayeri> any blockers? |
| 15:07:54 | <wyclif> not really |
| 15:08:14 | <wyclif> does any of you have suggestions for how to handle SYNC-173 |
| 15:08:22 | <wyclif> MarkG_, |
| 15:09:53 | <wyclif> wondering if hibernate has some form of rollback event or listener |
| 15:10:40 | <MarkG_> wyclif: unfortunately, i don't know... |
| 15:10:43 | <djazayeri> wyclif: I suppose the problem is that the code sync runs is in a different transaction than the one that we actually save? |
| 15:11:03 | <MarkG_> i'm looking into some hibernate stuff today so i will see if i find anything |
| 15:12:06 | <djazayeri> If the hibernate interceptor had access to the spring bean for the transaction manager, perhaps it could programmatically participate in that transaction |
| 15:12:37 | <djazayeri> or at least wait for the transaction to be committed before doing its thing? |
| 15:16:03 | <rafa> if things are executed in different threads I don't think it's possible to make them work within the same transaction. |
| 15:16:16 | <wyclif> i think we need to add extra logic in the methods afterTransactionCompletion(Transaction tx) |
| 15:16:22 | <djazayeri> is the interceptor a different thread? |
| 15:16:32 | <djazayeri> that makes sense |
| 15:17:03 | <djazayeri> So, presumably the thing to do would be to have the interceptor wait until the tx is actually committed before it does its thing, right? |
| 15:17:14 | <wyclif> yes |
| 15:17:24 | <djazayeri> hopefully that doesn't break anything else. |
| 15:17:35 | <wyclif> that is we can mark things in onSave but save them in afterTransactionCompletion(Transaction tx) |
| 15:17:41 | <djazayeri> UnitTests++ |
| 15:17:56 | <djazayeri> That would be my first approach wyclif |
| 15:19:21 | <wyclif> ok |
| 15:19:31 | <djazayeri> Me |
| 15:19:33 | <djazayeri> Monday |
| 15:19:33 | <djazayeri> * Talk to Daniel about 1.9 release managing |
| 15:19:33 | <djazayeri> * Talk with a Thoughtworks BA about helping with 1.9 release management |
| 15:19:33 | <djazayeri> * Long talk with Gretchen about Pentaho-OpenMRS-integration project |
| 15:19:33 | <djazayeri> * More organizing of 1.9 tickets |
| 15:19:33 | <djazayeri> Today |
| 15:19:34 | <djazayeri> * More code reviews |
| 15:19:34 | <djazayeri> * Do a ticket, any ticket |
| 15:19:35 | <djazayeri> * Prepare this week's OpenMRS University screencast |
| 15:19:35 | <djazayeri> * Read some documents about plans for OpenMRS hospital systems |
| 15:22:49 | <djazayeri> no blockers |
| 15:23:08 | <djazayeri> (but I find that when I'm not writing any code, I'm much less productive, and more easily-distracted) |
| 15:23:20 | <djazayeri> (I don't know if that counts as a blocker...) |
| 15:26:54 | <wyclif> hmmm |
| 15:27:22 | <wyclif> i think you guys are doing a a great job with managing sprints and code reviews |
| 15:27:50 | <wyclif> so i understand and i'm if you are doing less coding |
| 15:28:23 | <wyclif> i'm fine |
| 15:30:23 | <djazayeri> wyclif: in general, yes, that's the point, I'm just observing that if I don't do any coding for a few days, I end up wasting more time with every-2-minute email checks :-) |
| 15:43:22 | <chopin> rafa, did you enable metadata sharing in htmlformentry? |
| 15:43:51 | <MarkG_> fwiw, the "jump to error" link is still not working for me, even with the latest build... i know it was working for rafal, so i still have a to do to see if i can find a way for others to reproduce it |
| 15:45:09 | <rafa> chopin: what do you mean? |
| 15:45:47 | <rafa> chopin: it should be working fine |
| 15:46:03 | <chopin> rafa, yes but i was wondering if you wrote the code |
| 15:46:36 | <rafa> chopin: oh that was me and Mark |
| 15:47:05 | <chopin> cool, i need to do the same for formentry ... just wondered how it all worked |
| 15:47:31 | <chopin> rafa: did you just need to create the ___Exporter class and add a few methods to HtmlForm? |
| 15:48:03 | <rafa> chopin: basically yes |
| 15:48:16 | <chopin> i don't see where they are registered in the MDS module ... is it automatic? |
| 15:48:19 | <MarkG_> did we add any documentation about this to the HtmlFormEntry or Metadata Sharing wiki? |
| 15:48:35 | <rafa> chopin: yes, it gets picked up automatically |
| 15:48:49 | <rafa> chopin: you don't have to depend on the mds code |
| 15:49:02 | *** lh has joined #openmrs |
| 15:49:43 | <chopin> ah great .... hopefully this will go quickly :-) |
| 15:49:46 | <rafa> chopin: did you have a look at https://wiki.openmrs.org/display/docs/Technical+Details+for+Metadata+Sharing+Module? |
| 15:49:53 | <OpenMRSBot> <http://ln-s.net/9-Tl> (at wiki.openmrs.org) |
| 15:50:06 | <rafa> chopin: see the serializer part |
| 15:51:33 | <chopin> rafa, yes ... read through it but didn't see specifics, figured your implementation would be easier to follow |
| 15:52:02 | <rafa> chopin: good point. I'll put in there some example code |
| 15:54:45 | <rafa> MarkG_: Are you sure you've got erorrs in your history? |
| 15:55:00 | <rafa> MarkG_: they're marked with red |
| 15:55:05 | <MarkG_> rafa: yes |
| 15:55:34 | <MarkG_> rafal: even though it is somewhat strange... b/c it looks like sometimes they change from errors to non-errors without anything happening... |
| 15:56:37 | <rafa> MarkG_: it does sound strange |
| 15:57:22 | <rafa> MarkG_: the code is pretty simple, I don't know what can go wrong there |
| 15:57:43 | <rafa> MarkG_: and it seems to work fine whenever I test it |
| 15:58:06 | <MarkG_> rafal: yeah, i just haven't had much time to look into it b/c whenever i end up with errors, it is looking into the errors that becomes my priority, not figuring out why the jump isn't working... :) |
| 15:58:30 | <MarkG_> i need to clean some stuff out and then hopefully i can look into it |
| 15:58:42 | <rafa> MarkG_: haha makes sense :D |
| 16:00:26 | <rafa> chopin: If you code formentry up, please let me review it for you. |
| 16:01:21 | <rafa> chopin: mail me a patch or add to a code-review whatever works for you |
| 16:03:39 | *** pascal` has joined #openmrs |
| 16:06:20 | *** pascal` has quit IRC |
| 16:16:03 | *** wyclif has quit IRC |
| 16:16:25 | *** wyclif has joined #openmrs |
| 16:26:10 | *** pascal` has joined #openmrs |
| 16:34:31 | <sunbiz> have an issue with the insert statements in our liquibase data |
| 16:35:06 | <sunbiz> users and scheduler_task_config we don't do id inserts |
| 16:35:14 | <sunbiz> for all others we do id inserts |
| 16:35:58 | <sunbiz> djazayeri: any suggestion on how I can add these exceptions identity-insert liquibase extension that I've written?? |
| 16:36:31 | <djazayeri> sunbiz: I need more background |
| 16:38:22 | <sunbiz> ok... do u know we have an identity-insert extension |
| 16:38:54 | <djazayeri> no |
| 16:39:07 | <djazayeri> what's an example of a liquibase changeset we're talking about here? |
| 16:39:22 | <sunbiz> that wraps ALTER TABLE <tablename> SET IDENTITY ON; <insertstatements> ALTER TABLE <tablename> SET IDENTITY OFF; |
| 16:39:50 | <sunbiz> insert data fro demo data and core-data liquibase |
| 16:40:35 | <sunbiz> so... for inserts we have the id mentioned for IDENTITY columns... and this is not allowed in SQL Server 2000+ unless we SET IDENTITY_INSERT ON |
| 16:40:37 | <sunbiz> ok?? |
| 16:41:03 | <djazayeri> give me an actual example of a line of xml from the core-data |
| 16:41:25 | <sunbiz> ufff |
| 16:41:40 | <sunbiz> <insert tableName="field_type"> |
| 16:41:40 | <sunbiz> <column name="field_type_id" valueNumeric="1"/> |
| 16:41:40 | <sunbiz> <column name="name" value="Concept"/> |
| 16:41:40 | <sunbiz> <column name="description" value=""/> |
| 16:41:40 | <sunbiz> <column name="is_set" valueBoolean="false"/> |
| 16:41:41 | <sunbiz> <column name="creator" valueNumeric="1"/> |
| 16:41:41 | <sunbiz> <column name="date_created" valueDate="2005-02-22"/> |
| 16:41:42 | <sunbiz> </insert> |
| 16:42:19 | <djazayeri> but that has its id column included, right? |
| 16:42:36 | <sunbiz> so... I've written a liquibase extension that wraps the generated insert statement with ALTER TABLE <tablename> SET IDENTITY_INSERT ON; <insertstatements> ALTER TABLE <tablename> SET IDENTITY_INSERT OFF; |
| 16:42:58 | <sunbiz> that is a problem... for SQL Server... in which u cant insert into identity columns |
| 16:43:22 | <sunbiz> all inserts are fine with my extension... because they set on and off |
| 16:43:23 | <sunbiz> ok?? |
| 16:43:32 | <djazayeri> Go back a step. What would be wrong with running that field_type insert you just gave, without the extension? |
| 16:43:59 | <sunbiz> https://tickets.openmrs.org/browse/TRUNK-2631 |
| 16:44:32 | <djazayeri> okay |
| 16:45:13 | <djazayeri> so what's the question…whether this is okay? |
| 16:45:26 | <sunbiz> but the users table and scheduler_task_config don't do id inserts |
| 16:45:40 | <sunbiz> so... I want to add exceptions... |
| 16:45:45 | <djazayeri> what's the insert into the users table look like? |
| 16:45:50 | <sunbiz> I can add it in the extension itself |
| 16:46:22 | <sunbiz> <insert tableName="users"> |
| 16:46:23 | <sunbiz> <column name="system_id" value="daemon"/> |
| 16:46:23 | <sunbiz> <column name="username" value="daemon"/> |
| 16:46:23 | <sunbiz> <column name="creator" valueNumeric="1"/> |
| 16:46:23 | <sunbiz> <column name="date_created" valueDate="2010-04-26T13:25:00"/> |
| 16:46:23 | <sunbiz> <column name="retired" valueNumeric="0"/> |
| 16:46:24 | <sunbiz> <column name="uuid" value="A4F30A1B-5EB9-11DF-A648-37A07F9C90FB"/> |
| 16:46:24 | <sunbiz> </insert> |
| 16:46:48 | <sunbiz> user_id is not inserted |
| 16:46:55 | <djazayeri> it's auto-generated? |
| 16:47:10 | <djazayeri> okay, and that fails with your extension enabled? |
| 16:47:14 | <sunbiz> yes |
| 16:47:21 | <djazayeri> it fails in ms-sql only? |
| 16:47:25 | <sunbiz> yes |
| 16:47:31 | <sunbiz> that extension only runs for mssql |
| 16:47:45 | <sunbiz> ArrayList<String> exceptionTables = new ArrayList<String>(); |
| 16:47:45 | <sunbiz> exceptionTables.add("users"); |
| 16:47:45 | <sunbiz> exceptionTables.add("scheduler_task_config"); |
| 16:47:56 | <sunbiz> I've done this in the extension... but looks hard-coded |
| 16:48:42 | <MarkG_> pascal: did you get your patient flags question from yesterday answered? |
| 16:49:39 | <djazayeri> sunbiz: Yeah, that's not great. Because I can imagine some other changeset that adds users or scheduler_task_config and does give an id. |
| 16:50:16 | <sunbiz> djazayeri: we shouldn't have a changeset like that though... |
| 16:50:25 | <sunbiz> but still... |
| 16:50:46 | <djazayeri> because those tables already have data? |
| 16:50:51 | <sunbiz> yes |
| 16:51:09 | <djazayeri> the alternative would be to have a ms-sql-specific changeset to insert the user |
| 16:51:22 | <sunbiz> nope... that'll b bad |
| 16:51:25 | <MarkG_> pascal`: did you get your patient flags question from yesterday answered? |
| 16:51:31 | <djazayeri> and have that changeset somehow explicitly tell the plugin not to activate |
| 16:52:02 | <djazayeri> sunbiz: is it possible at least to set that list of exception tables as a configuration parameter passed from openmrs to your plugin? |
| 16:52:59 | <sunbiz> djazayeri: I was thinking like that |
| 16:53:19 | <sunbiz> but how?? in the pom.xml?? |
| 16:53:19 | <djazayeri> that'd be better, so at least your plugin isn't hardcoded to OpenMRS specifically |
| 16:53:36 | <sunbiz> I mean when the dependency is included?? |
| 17:03:09 | <chopin> rafa, i certainly will :-) |
| 17:03:12 | <sunbiz> is this page opening for others: https://github.com/liquibase |
| 17:05:25 | <sunbiz> djazayeri: https://tickets.openmrs.org/browse/TRUNK-2652?focusedCommentId=174987&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-174987 do u agree?? |
| 17:05:31 | <OpenMRSBot> <http://ln-s.net/9-VV> (at tickets.openmrs.org) |
| 17:06:00 | <pascal`> Hi MarkG_ |
| 17:06:22 | <djazayeri> sunbiz: is that just a fairly-recent revision? |
| 17:06:22 | <MarkG_> hey pascal` |
| 17:06:27 | <djazayeri> or meaningful in some other way? |
| 17:06:33 | <sunbiz> the last one |
| 17:06:35 | <MarkG_> Ben said you had a question about patient flags? |
| 17:06:39 | <pascal`> MarkG_, I had to create my custom evaluator due to a limitation in the way classes can be loaded from other modules. |
| 17:06:41 | *** finbrein has quit IRC |
| 17:06:55 | <pascal`> *create my custom evaluator inside the PF module |
| 17:06:55 | <sunbiz> djazayeri: thats the last one with changes to the updates-to-latest.xml |
| 17:07:04 | <djazayeri> sunbiz: sounds like the right approach to me. |
| 17:07:10 | <sunbiz> djazayeri: thanks |
| 17:07:29 | <sunbiz> djazayeri: do u mind lots of small commits?? |
| 17:07:31 | <djazayeri> though, tangentially, if you edited that changeset, don't you also need to add a new hash? |
| 17:07:46 | <sunbiz> DVCS type |
| 17:07:53 | <djazayeri> or did you change the name, so it's not necessary? |
| 17:08:10 | <MarkG_> ah, i could see that... i never tried creating a custom evaluator from another module. that is annoying though... no workarounds that we know of? |
| 17:08:42 | <djazayeri> sunbiz: I don't mind lots of small commits. (You mean like one commit per changeset, right?) |
| 17:09:07 | <djazayeri> MarkG_, pascal`: is the issue that if you specified a custom alert class by classname, than patientflags wasn't able to load it? |
| 17:09:32 | <djazayeri> becuase patientflags doesn't depend on your other module? |
| 17:11:18 | <MarkG_> pascal`: what was the error that you got? |
| 17:11:22 | <sunbiz> djazayeri: yes |
| 17:11:39 | <pascal`> MarkG_, just that it couldn't instantiate it. |
| 17:11:52 | <pascal`> MarkG_, it's because you use Class.forName instead of the OpenMRS class loader |
| 17:12:01 | <sunbiz> djazayeri: I changed the name of the changeset and made the old changeset dbms="mysql" |
| 17:12:17 | <pascal`> MarkG_, even if you used the OpenMRS class loader though, your module would have to declare my module as a dependency to have access to class |
| 17:12:24 | <pascal`> MarkG_, which doesn't really help =S |
| 17:13:19 | <sunbiz> djazayeri: though I fear that I may trigger too many CI failures :) |
| 17:13:26 | <MarkG_> pascal`,djazayeri: we could change patient flags to use the classloader; djazayeri, do you know if there is a way around the dependency issue? |
| 17:13:30 | <sunbiz> and lot of spam to ppls inboxes |
| 17:14:18 | <djazayeri> sunbiz: don't let the broken CI emails make you less productive |
| 17:14:32 | <chopin> rafa, did you register a custom handler for HtmlForm or is that already in MDS module? |
| 17:14:38 | <chopin> or is that not even happening? |
| 17:14:46 | <djazayeri> downeym: btw, who is actively looking into fixing the broken CI issue? |
| 17:15:17 | <MarkG_> pascal`: if the evaluator you wrote is general in some way and might be used by others, adding it to Patient Flags might make sense... but if it is entirely implementation specific, it doesn't really... |
| 17:15:34 | <djazayeri> chopin: in most cases, you just need to implement a couple specially-named methods on your OpenmrsMetadata class, without registering/implementing anything |
| 17:16:14 | <djazayeri> In the HFE case it was easy because HtmlForm was its own metadata class |
| 17:16:16 | <MarkG_> pascal`,djazayeri: going to get some food, back in 15-30 mins |
| 17:16:38 | <chopin> djazayeri, right, just concerned that Form isn't controlled by FormEntry ... but FormEntryXsn is |
| 17:16:46 | <chopin> so i think i'll just set that up ... |
| 17:16:48 | <djazayeri> chopin: in your case it may be trickier because (of what you just said) |
| 17:17:08 | <djazayeri> two options off the top of my head: |
| 17:17:22 | <djazayeri> 1. make FormEntryXsn implement OpenmrsMetadata |
| 17:17:50 | <djazayeri> (Though I don't know if that's good enough, because the underlying Form still won't reference it. So never mind.) |
| 17:18:05 | <chopin> the underlying form won't reference it but it references the underlying form |
| 17:19:04 | <djazayeri> yeah, so you could have the user say: I want to add one specific XSN to the metadata package. And that'll bring the form and the associated form fields, concepts, etc. |
| 17:19:24 | <chopin> right, that's what i was thinking ... what's the second? custom Handler? |
| 17:20:01 | <djazayeri> option 2. Introduce a new class ("InfopathForm" for example) that implements OpenmrsMetadata, and you have a service with getAllInfopathForms() etc, but it only gives you the latest xsn for each form. |
| 17:21:26 | <djazayeri> that class can handle the import/export of converting the xsn into bytes, and it can list the form as a dependency. |
| 17:22:37 | <chopin> (and all of the connected FormFields, Fields and Concepts) |
| 17:22:37 | <djazayeri> chopin: Or maybe you can do (1) in such a way that it only allows people to pick the most recent xsn for any form |
| 17:22:51 | <djazayeri> chopin: you should only have to declare the form, I think. the rest happens automatically |
| 17:23:10 | <chopin> if I can list the XSN with custom representation in MDS, I'd rather do that |
| 17:23:25 | <chopin> e.g. list an XSN with the form name, version, etc |
| 17:24:14 | <djazayeri> MDS automatically finds all OpenmrsMetadata, and looks through all OpenmrsService to find getAllXyz and getXyzByUuid methods. |
| 17:24:53 | <djazayeri> You may be able to override exactly how it calls those service methods, but that probably requires requiring the MDS module. |
| 17:25:24 | <chopin> oh, interesting |
| 17:27:42 | <chopin> so, if FormEntryXsn extends OpenmrsMetadata and i have getAllFormEntryXsn and getFormEntryXsnByUuid methods in FormEntryService ... I'm good to go? (kinda don't want to be loading all XSNs ... ever ... though) |
| 17:27:51 | <chopin> i think your second option is the right thing |
| 17:28:21 | <djazayeri> chopin, maybe it looks for a search method by name |
| 17:29:16 | <chopin> heheh ok |
| 17:30:27 | <chopin> as it stands, FormEntryXsn implements BaseOpenmrsObject |
| 17:30:48 | <djazayeri> you don't need to change that in scenario 2 |
| 17:31:19 | <djazayeri> MDS can also handle OpenmrsObject, though it doesn't do those by default |
| 17:31:22 | <chopin> yep, think i'll do it |
| 17:31:28 | * chopin tries it out |
| 17:31:59 | <djazayeri> actually in scenario 2 you might be able to just have your custom object declare one dependency, on the xsn, and everything else will come automatically |
| 17:32:01 | <djazayeri> good luck |
| 17:32:32 | <chopin> thanks! hah |
| 17:32:40 | <djazayeri> shouldn't be hard actually |
| 17:33:10 | <chopin> yep |
| 17:41:14 | <sunbiz> sorry... another question |
| 17:41:33 | <sunbiz> do we use Windows or Unix Line endings?? |
| 17:41:48 | <sunbiz> this XML formatting is irritating!! |
| 17:42:16 | <djazayeri> sunbiz: I don't know what we do |
| 17:42:28 | <sunbiz> can I reformat the XML |
| 17:42:41 | <sunbiz> djazayeri: pretty pleaseeee!! |
| 17:43:14 | <djazayeri> I would prefer that you don't reformat the XML |
| 17:43:17 | <chopin> it would be fantastic if we could split the xml by minor version, and if we do that you could just reformat the latest file |
| 17:43:31 | *** finbrein has joined #openmrs |
| 17:43:43 | <sunbiz> chopin: what is minor version?? |
| 17:44:22 | <chopin> major.minor |
| 17:44:31 | <chopin> 1.5 vs 1.6 vs 1.7 ... |
| 17:44:43 | *** wyclif has quit IRC |
| 17:44:55 | <chopin> so all 1.6-related updates are in one file |
| 17:45:14 | <sunbiz> hmm... ok that way!! |
| 17:45:16 | <chopin> heh |
| 17:45:21 | <chopin> not sure how that would work w/ backports |
| 17:45:34 | <chopin> (i assume it wouldn't be too difficult) |
| 17:45:44 | <sunbiz> chopin: yes that will help :) |
| 17:46:06 | <sunbiz> though the current mission is to make the liquibase shema only file to b 1.9 ?? |
| 17:46:22 | <chopin> right, i guess that's the same thing |
| 17:46:23 | <sunbiz> so... new installs start with 1.9 schema directly |
| 17:47:14 | *** bwolfe has joined #openmrs |
| 17:47:14 | *** ChanServ sets mode: +o bwolfe |
| 18:05:47 | <chopin> djazayeri, rafa: does a sharable metadata object need to be persisted? can i use this proxy object to reference other persisted objects? |
| 18:06:49 | <djazayeri> chopin: I haven't looked at the code since Rafal and Mark made a relatively big change to how those things are represented, so I'm not sure. |
| 18:07:49 | <djazayeri> I believe that as long as you have a service with correctly-named methods, it's fine if the things it returns are transient objects constructed on the fly |
| 18:08:05 | <djazayeri> and definitely the shareable version doesn't have to be persisted |
| 18:08:54 | <chopin> that's what i was thinking ... but i wondered how the objects are sought out on the second server ... by UUID i assume, so if i reference an existing Form's UUID i should be fine? |
| 18:09:03 | <djazayeri> Yes, by uuid |
| 18:11:00 | <djazayeri> though you just have to return the form itself in the getDependencies(), right? |
| 18:11:15 | <chopin> right ... i think :-D |
| 18:11:20 | <chopin> hahaha |
| 18:11:47 | <djazayeri> My idea is that the saveXyz method for this new fake object does a No-Op |
| 18:12:24 | <chopin> ah, but the onSave does the work |
| 18:12:35 | <djazayeri> My thought is that you don't even need that |
| 18:12:45 | <chopin> heh |
| 18:12:49 | <chopin> um |
| 18:12:50 | <djazayeri> i.e. this fake object declares one dependency, the FormEntryXsn. |
| 18:12:58 | <chopin> right, but has to pick the right Xsn |
| 18:13:12 | <djazayeri> Yes, so on export you declare a dependency to the right xsn. |
| 18:13:44 | <chopin> mmkay, but the uuid of the proxy object should match the uuid of an existing form? |
| 18:13:45 | <djazayeri> on import you don't do anything, but since the package also includes the xsn (and transitively also the form, fields, concepts) everything else is automaic |
| 18:13:50 | <chopin> or is that pointless? |
| 18:13:57 | <chopin> ohhhh ok |
| 18:14:05 | <chopin> so the export and import of the object itself is null |
| 18:14:12 | <chopin> but the dependencies get handled properly |
| 18:14:19 | <chopin> mmkay |
| 18:14:29 | * chopin keeps going |
| 18:14:34 | <djazayeri> I guess it'd make sense for the uuid of the proxy object to be consistent, e.g. to be the uuid of either the form or the xsn |
| 18:14:54 | <djazayeri> though really we should ask rafa, since he knows more about how this will behave when you then re-import a newer version of the form |
| 18:15:04 | <djazayeri> e.g. with bryq1's publish/subscribe work |
| 18:19:08 | <chopin> right, that was my concern ... since it's not persisted. |
| 18:20:18 | *** pascal` has quit IRC |
| 18:30:17 | *** finbrein has quit IRC |
| 18:32:18 | <djazayeri> It is annoyingly difficult to backport small fixes |
| 18:32:41 | <djazayeri> spaces seem to be kryptonite for svn |
| 18:32:51 | <chopin> especially to ant-based releases :| |
| 18:33:12 | <djazayeri> I'm trying to backport from trunk to 1.8.x... |
| 18:33:21 | <bwolfe> djazayeri, have you used the "guess" button in the upper right when applying a patch? |
| 18:34:25 | <djazayeri> yes |
| 18:35:26 | <djazayeri> It often doesn't work |
| 18:36:31 | <djazayeri> the other issue is that if the patch doesn't apply cleanly, I find the eclipse tool absolutely useless for letting me figure out how to manually apply the unmatched parts. |
| 18:37:16 | <djazayeri> In this case I first tried by merging a revision. That somehow causes hundreds of lines to be reformatted, even though they weren't touched by the revision. Meh. |
| 18:38:50 | *** finbrein has joined #openmrs |
| 18:39:46 | <chopin> i wonder how much of that is caused by the checkstyle plugin |
| 18:48:27 | <bwolfe> or the maven plugin |
| 18:49:33 | <chopin> er right |
| 18:51:50 | <djazayeri> wow, I just hit a truly annoying fisheye bug |
| 18:52:01 | <djazayeri> bwolfe or someone, can you verify this for me? |
| 18:52:45 | <bwolfe> what am I verifying? |
| 18:52:50 | <djazayeri> 2 secs |
| 18:53:14 | <djazayeri> okay, look at https://source.openmrs.org/changelog/OpenMRS?cs=22422 |
| 18:53:18 | <OpenMRSBot> <http://ln-s.net/9-YK> (at source.openmrs.org) |
| 18:53:19 | <djazayeri> changset 22422 |
| 18:53:58 | <djazayeri> verify that this changeset modifies the test dataset with "userNotAPatient" in the name, but that it does not touch the one with "usersWhoArePatients". |
| 18:54:11 | <djazayeri> Now, click on View as Patch on this changeset |
| 18:54:32 | <djazayeri> the patch it shows you *does* modify "usersWhoArePatients" |
| 18:54:34 | <chopin> djazayeri, rafa: i think the proxy object may not work ... looking at the MDS code, it is directly querying the db for a given class type in getItems() ... so if I don't persist the data, MDS won't find it. |
| 18:55:49 | <chopin> is there a difference since r15075? |
| 18:55:52 | <djazayeri> No |
| 18:56:05 | <chopin> perhaps there is a previous ... hrm |
| 18:56:30 | <bwolfe> djazayeri, the line "Index: trunk/api/src/test/resources/org/openmrs/api/include/PatientServiceTest-usersWhoArePatients.xml" means that it is modifying the usersWhoArePatients |
| 18:56:58 | <bwolfe> but the view shows it on the userNotAPatient class |
| 18:57:08 | <bwolfe> err, file |
| 18:57:13 | <bwolfe> is that why its not applying for you? |
| 18:57:35 | <djazayeri> that part of the patch applied "cleanly", but the unit tests failed after I applied it. :-) |
| 18:57:55 | <djazayeri> I wonder if this commit was done via intellij, and it's clever about somehow saying that the one file was created by copying the other? |
| 18:57:57 | <bwolfe> heh |
| 18:58:26 | <djazayeri> And if I look in trunk, that file was *not* modified, even though the patch view implies it is |
| 18:59:55 | <sunbiz> djazayeri: I've seen that a few times with fisheye's diff thing... something assumes that the file rename has happened or has come from another file |
| 19:00:20 | <djazayeri> perhaps I should mention it to downeym as a fisheye bug. |
| 19:01:05 | <djazayeri> So, how do I get a revision as a patch file, if I can't trust fisheye? |
| 19:01:10 | <sunbiz> kdiff3 does a uch better job |
| 19:01:20 | <sunbiz> from the code commit... and not fisheye |
| 19:01:40 | <bwolfe> djazayeri, or you can merge it directly to 1.8.x |
| 19:01:55 | <djazayeri> bwolfe: I tried that already and it didn't work right |
| 19:02:19 | <djazayeri> I want it as a patch so I can apply it manually and see why it's changing lots of whitespaces. |
| 19:03:29 | <bwolfe> djazayeri, there is a "give me a diff file" checkbox when merging |
| 19:04:20 | <djazayeri> bwolfe: tangential question: my workspace's 1.8.x project has a bunch of .classpath and .project files that aren't in svn |
| 19:04:28 | <djazayeri> should those be svn:ignored? or should I commit them? |
| 19:04:35 | <bwolfe> svn:ignored |
| 19:08:00 | <djazayeri> bwolfe: actually that checkbox doesn't exist anymore, with the set of eclipse plugins I have |
| 19:08:24 | <chopin> netbeans++ ;-) |
| 19:08:49 | <chopin> although i can't figure out how to selectively commit from the top level of the project |
| 19:08:51 | <chopin> :| |
| 19:09:36 | *** lh is now known as lh_tacos |
| 19:10:06 | <djazayeri> bwolfe: when I try to svn merge just the one revision, I get one conflicted file, and it has a ton of whitespace changes. |
| 19:10:08 | <sunbiz> chopin: u cannot... only per project commits |
| 19:10:29 | <bwolfe> sunbiz, thats really annoying |
| 19:10:29 | <djazayeri> Is there a url I can go to on svn.openmrs.org to show me a specific changeset, as a patch? |
| 19:10:39 | <bwolfe> not that I know of djazayeri |
| 19:12:03 | <djazayeri> maybe svn diff at the command line... |
| 19:12:26 | <sunbiz> bwolfe: yes.. but I do the commits from tortoise |
| 19:12:51 | <bwolfe> netbeans-- |
| 19:12:59 | <bwolfe> windows-- |
| 19:13:10 | <bwolfe> but tortoise was nice when I used it: tortoise++ |
| 19:17:10 | <djazayeri> so, I got the patch by doing svn diff at the command line, and: (1) fisheye produces an incorrect diff, (2) eclipse (or our maven scripts) are introducing a whole bunch more changes than are actually in that diff |
| 19:18:26 | <bwolfe> djazayeri, did you make sure the file on your 1.8.x was unchanged before trying to apply? When and how was eclipse/maven/etc getting in the way? |
| 19:18:41 | <djazayeri> that file is unchanged before trying to apply |
| 19:18:55 | <djazayeri> When I do the merge it tells me that file is conflicted |
| 19:20:08 | <djazayeri> when I open that file in Team -> Edit Conflicts it shows hundreds of lines being changed (mostly without conflict) that have nothing to do with the changeset. |
| 19:20:23 | <djazayeri> (actually I wonder if the built-in tool is off by one revision or something) |
| 19:20:55 | <djazayeri> (nah, that's not it) |
| 19:21:37 | *** finbrein has quit IRC |
| 19:21:55 | <djazayeri> actually the Team -> Edit Conflicts view seems to be showing me the current file in 1.8.x compared to some revision of the file from trunk |
| 19:22:04 | <djazayeri> which has a whole bunch of unrelated stuff going on. |
| 19:22:11 | <djazayeri> anyway, I'm just going to manually apply the patch |
| 19:22:14 | <djazayeri> but gotta run to lunch now |
| 19:22:31 | <bwolfe> strange |
| 19:27:00 | <sunbiz> bwolfe: eclipse-- |
| 19:27:14 | <sunbiz> !karma netbeans |
| 19:27:14 | <OpenMRSBot> sunbiz: Karma for "netbeans" has been increased 4 times and decreased 3 times for a total karma of 1. |
| 19:27:21 | *** dkayiwa has joined #openmrs |
| 19:27:22 | <sunbiz> !karma eclipse |
| 19:27:22 | <OpenMRSBot> sunbiz: Karma for "eclipse" has been increased 2 times and decreased 2 times for a total karma of 0. |
| 19:27:33 | <chopin> boom |
| 19:28:01 | <sunbiz> the karma shows that both the IDEs are doing pretty badly... |
| 19:28:05 | <sunbiz> !karma bwolfe |
| 19:28:05 | <OpenMRSBot> sunbiz: Karma for "bwolfe" has been increased 123 times and decreased 28 times for a total karma of 95. |
| 19:30:29 | <bwolfe> double boom |
| 19:30:40 | <sunbiz> bwolfe: FTW |
| 19:31:16 | <sunbiz> bwolfe: if I add a changeset in liquibase-schema-only.xml it will b executed for all na?? |
| 19:31:28 | <bwolfe> sunbiz, only for new users |
| 19:31:44 | <sunbiz> only new users?? |
| 19:31:46 | <sunbiz> how?? |
| 19:31:52 | <sunbiz> okies... from the UpdateFilter |
| 19:31:55 | <bwolfe> thats the only time openmrs points at it |
| 19:32:07 | <sunbiz> ok... yes, I changed that file recently |
| 19:32:08 | <bwolfe> not the updatefilter, the initializationfilter |
| 19:32:08 | <sunbiz> :D |
| 19:32:19 | <sunbiz> yes.. initializationfilter |
| 19:33:12 | <sunbiz> bwolfe: so I cna name the changeset anything I want :D |
| 19:33:25 | <bwolfe> yes, if you must |
| 19:33:32 | <sunbiz> or timestamp?? |
| 19:33:57 | <sunbiz> ?? |
| 19:34:11 | <bwolfe> anythign really. just has to be unique inside that file |
| 19:34:19 | <sunbiz> :P |
| 19:35:45 | <sunbiz> whoever created these xmls... used bad formatting |
| 19:35:58 | * sunbiz CRIBS!! |
| 19:36:18 | * sunbiz hates 8-space tabs |
| 19:36:48 | * sunbiz thinks why can we use spaces!!!!!!!!!!!!!!!!! |
| 19:37:11 | * sunbiz is talking to himself... and cribbing!! |
| 19:37:12 | *** wyclif has joined #openmrs |
| 20:02:08 | <sunbiz> chopin: I just found out that you can select multiple projects and do the commit command |
| 20:02:22 | <sunbiz> and then u will b able to see the changes in all the projects |
| 20:02:31 | <chopin> oO nice |
| 20:02:56 | <chopin> sunbiz, in eclipse, i could select and deselect files from the commit ... can that be done in netbeans too? |
| 20:03:07 | <sunbiz> yes |
| 20:03:11 | <chopin> oooh nice |
| 20:03:31 | <sunbiz> and u can fill the correct issue in JIRA |
| 20:03:35 | <sunbiz> with the commit msg |
| 20:03:39 | <chopin> yeah i saw that one too :-) |
| 20:04:05 | <sunbiz> so... u dont have to type the commit in the ticket |
| 20:06:53 | *** lh_tacos is now known as lh |
| 20:07:11 | * bwolfe hopes lh bought him a taco |
| 20:07:20 | * bwolfe misses mexican food |
| 20:07:25 | <sunbiz> bwolfe: u have take ur -- back for netbeans |
| 20:07:32 | <lh> bwolfe: sorry, tacos are not as portable as they ought to be. |
| 20:07:40 | <bwolfe> blast! |
| 20:08:02 | <bwolfe> lh, if only you had gotten burritos... |
| 20:08:40 | <lh> bwolfe: that may have helped slightly. |
| 20:09:24 | <bwolfe> sunbiz, you mean take back this one? netbeans-- |
| 20:10:15 | <sunbiz> netbeans++ |
| 20:10:18 | <sunbiz> netbeans++ |
| 20:10:25 | <sunbiz> ok... done!! :P |
| 20:15:59 | *** finbrein has joined #openmrs |
| 20:18:21 | *** lh has quit IRC |
| 20:19:27 | *** muthah has joined #openmrs |
| 20:34:08 | *** dkayiwa has quit IRC |
| 20:53:49 | *** finbrein has quit IRC |
| 20:54:25 | *** mnunez has joined #openmrs |
| 21:00:08 | *** bwolfe has quit IRC |
| 21:02:32 | *** rafa has quit IRC |
| 21:07:38 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Community, not tech solves problems. RT @ryanbuch Wikipedia is a community, not a website. People educating the world. @jimmy_wales at #ET11 <http://twitter.com/OpenMRS/statuses/113711724254863360> |
| 21:10:24 | <mnunez> Hi! I've found the "Access Logging Module", but once installed in my OMRS 1.8 it crashes. Any idea if this module has ever been deployed in the latest version? |
| 21:13:55 | *** lh has joined #openmrs |
| 22:01:23 | <MarkG_> mnunez: I'm pretty sure the Access Logging Module has not been installed in 1.8. |
| 22:01:37 | <djazayeri> i.e. it hasn't been tested |
| 22:01:40 | *** mnunez has quit IRC |
| 22:01:47 | <djazayeri> so your crash report would be interesting info for the author |
| 22:01:58 | <djazayeri> (although not necessarily actionable.) |
| 22:03:17 | <MarkG_> mnunez: you might want to check out the Usage Statistics module... I think it is more widely used. |
| 22:03:39 | <MarkG_> i wrote the access logging module as my first Openmrs module, and, honestly, I don't know if anyone uses it... :) |
| 22:04:01 | <djazayeri> MarkG_: Ha! I thought he was talking about Rowan's module. :-) |
| 22:04:05 | <MarkG_> I suspended developing on it b/c I believe the usage statistic module covered our needs |
| 22:04:33 | <MarkG_> mnunez: fyi, Rowen's module is the Usage Statistics module |
| 22:05:47 | *** MarkG_ has quit IRC |
| 22:13:36 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Name Phonetics 1.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=namephonetics&version=&1.3> |
| 22:15:59 | *** bryq1 has quit IRC |
| 22:17:43 | <djazayeri> chopin: have you ever used the module maven archetype through eclipse? |
| 22:18:07 | *** chopin has quit IRC |
| 22:21:49 | *** muthah has quit IRC |
| 22:40:15 | <sunbiz> djazayeri: do we need the tribe table |
| 22:40:19 | <sunbiz> for new schemas?? |
| 22:40:23 | <djazayeri> no |
| 22:40:29 | <sunbiz> thanks |
| 22:44:12 | <sunbiz> and the tribe column in patient?? |
| 22:44:28 | <sunbiz> for new schema?? |
| 22:44:36 | <sunbiz> required... or not required?? |
| 22:45:36 | <sunbiz> djazayeri: probably required... will be easier for people to move from MySQL to whatever new database... because that column has not been removed |
| 22:48:59 | <djazayeri> Gretchie: you're in chicago, right |
| 22:51:10 | *** lh has quit IRC |
| 23:03:28 | *** morristic has joined #openmrs |
| 23:05:35 | *** lh has joined #openmrs |
| 23:12:56 | *** wyclif has quit IRC |
| 23:30:58 | *** morristic has quit IRC |
| 23:46:29 | *** wyclif has joined #openmrs |
| 23:50:10 | *** djazayeri has quit IRC |