| 00:07:28 | *** gbastien has quit IRC |
| 01:30:36 | *** gbastien has joined #openmrs |
| 02:12:16 | *** sunbiz has left #openmrs |
| 02:34:58 | *** gbastien has quit IRC |
| 02:43:27 | *** morristic has joined #openmrs |
| 02:48:04 | *** morristic has quit IRC |
| 02:55:33 | *** upul` has joined #openmrs |
| 02:55:33 | *** ChanServ sets mode: +v upul` |
| 03:51:05 | *** surangak has joined #openmrs |
| 04:08:02 | *** robbyoconnor has joined #openmrs |
| 04:08:02 | *** ChanServ sets mode: +v robbyoconnor |
| 05:15:00 | *** djazayeri has quit IRC |
| 05:20:32 | *** djazayeri has joined #openmrs |
| 05:20:32 | *** ChanServ sets mode: +o djazayeri |
| 05:35:49 | *** sunbiz has joined #openmrs |
| 05:35:49 | *** ChanServ sets mode: +v sunbiz |
| 05:39:48 | *** pascal` has quit IRC |
| 05:53:57 | *** bwolfe has joined #openmrs |
| 05:53:57 | *** ChanServ sets mode: +o bwolfe |
| 06:06:24 | *** rafa has joined #openmrs |
| 06:06:24 | *** ChanServ sets mode: +v rafa |
| 06:24:07 | *** dkayiwa has joined #openmrs |
| 06:35:21 | *** pascal` has joined #openmrs |
| 06:39:07 | *** rafa has quit IRC |
| 06:40:32 | *** pascal` has quit IRC |
| 06:41:21 | *** pascal` has joined #openmrs |
| 06:42:42 | *** dkayiwa has quit IRC |
| 06:43:12 | *** pascal` has quit IRC |
| 06:44:28 | <surangak> bwolfe, hi |
| 06:44:36 | <surangak> bwolfe, can I commit to sync ? :-) |
| 06:45:19 | *** dkayiwa has joined #openmrs |
| 06:47:00 | <bwolfe> surangak, yes |
| 06:47:08 | <surangak> bwolfe, wow |
| 06:47:11 | <surangak> will do... |
| 06:53:38 | *** dkayiwa has quit IRC |
| 06:54:53 | *** dkayiwa has joined #openmrs |
| 06:55:13 | *** deadpool has joined #openmrs |
| 07:02:07 | *** surangak_ has joined #openmrs |
| 07:03:25 | *** pascal` has joined #openmrs |
| 07:03:25 | *** surangak_ has quit IRC |
| 07:03:42 | *** surangak_ has joined #openmrs |
| 07:05:15 | *** surangak has quit IRC |
| 07:11:06 | *** dkayiwa_ has joined #openmrs |
| 07:13:08 | *** dkayiwa has quit IRC |
| 07:13:09 | *** dkayiwa_ is now known as dkayiwa |
| 07:15:01 | *** bryq has joined #openmrs |
| 07:15:01 | *** ChanServ sets mode: +v bryq |
| 07:17:11 | *** dkayiwa has quit IRC |
| 07:18:35 | <bwolfe> surangak_, good job on the review. only thing to do diff for hte future is to copy the ticket title to the review title. (and keep the ticket id in it as you have it too) |
| 07:21:01 | *** lh has quit IRC |
| 07:21:01 | *** lh has joined #openmrs |
| 07:35:22 | *** dkayiwa has joined #openmrs |
| 07:51:37 | <bwolfe> dkayiwa, why do you keep taking on more tickets when you have some in "ready for work" state already? |
| 07:51:48 | <bwolfe> dkayiwa, you're currently at 4 tickets ! |
| 07:52:25 | <dkayiwa> bwolfe: i had committed all of them. And had none to work on, so i picked another :) |
| 07:52:46 | <dkayiwa> bwolfe: and on one of them, i have a pending question |
| 07:52:58 | <dkayiwa> that you have not yet answered |
| 07:53:37 | <bwolfe> hmm, ok |
| 07:53:40 | * bwolfe looks again |
| 07:54:35 | <dkayiwa> bwolfe: SYNC-207 |
| 07:54:51 | *** deadpool has quit IRC |
| 07:55:33 | *** rafa has joined #openmrs |
| 07:55:33 | *** ChanServ sets mode: +v rafa |
| 07:57:03 | <bwolfe> dkayiwa, two of them I had reviewed yesterday...but didn't you pick up that new one this morning? |
| 07:57:44 | <bwolfe> dkayiwa, the reason I'm bugging you about it is because we don't want to prevent work from getting done. if you're working on 1 ticket but have 4 assigned to you, thats 3 tickets that could be worked on by other people |
| 07:58:06 | <bwolfe> so try to keep a max of only a few open tickets to your name |
| 07:58:06 | <dkayiwa> bwolfe: i picked the last one SYNC-184 yesterday |
| 07:58:24 | <dkayiwa> bwolfe: i completely agree with you |
| 07:58:32 | <bwolfe> ok, np then |
| 07:59:05 | <dkayiwa> bwolfe: i think what caused it is that the other tickets were not reviewed yet when i had finished them all |
| 07:59:58 | <dkayiwa> bwolfe: what i will do is that instead of picking another when i have committed all, i will first ask someone to review and see if they can make comments that i can immeditely start responding on |
| 08:00:23 | <bwolfe> dkayiwa, sounds like a good plan |
| 08:01:00 | <dkayiwa> ok |
| 08:02:53 | <dkayiwa> bwolfe: do you have some pointers for how i can make the unit test for SYNC-200 ? |
| 08:03:11 | <dkayiwa> bwolfe: or some existing example i can look at and borrow ideas |
| 08:03:53 | <dkayiwa> bwolfe: that is as per the review: https://source.openmrs.org/cru/CR-MOD-299 |
| 08:04:22 | <bwolfe> !ticket SYNC-200 |
| 08:04:23 | <OpenMRSBot> bwolfe: [#SYNC-200] running sync manually from the sync/status.list?mode=SEND_WEB page should check to see if a sync process is currently running and return message to wait if so - OpenMRS JIRA - https://tickets.openmrs.org/browse/SYNC-200 |
| 08:07:30 | *** deadpool has joined #openmrs |
| 08:13:21 | <bwolfe> dkayiwa, you should be able to do it with a standard unit test, not even a sync one |
| 08:13:30 | <bwolfe> just call the method twice in a row |
| 08:13:33 | <dkayiwa> ok |
| 08:13:41 | <bwolfe> (from a diff thread probably) |
| 08:13:50 | <dkayiwa> ok |
| 08:14:15 | <rafa> bwolfe: congrats on fixing unit tests :D |
| 08:14:22 | <dkayiwa> :) |
| 08:14:48 | <bwolfe> rafa, heh, thanks |
| 08:15:08 | <bwolfe> turned out one was just a bad unit test, the other, well, I can't figure that one out so I just marked it as Ignore! |
| 08:15:17 | <bwolfe> (it works alone, just not in maven batches) |
| 08:16:05 | <rafa> bwolfe: hmm tough beasts |
| 08:16:39 | <bwolfe> rafa, yeah |
| 08:16:57 | <bwolfe> but I did fix one true bug: You couldn't purge/delete patients before |
| 08:17:00 | <bwolfe> now you can |
| 08:19:45 | <rafa> bwolfe: Hibernate is not nice when you start playing with its guts |
| 08:21:04 | <bwolfe> rafa, heh |
| 08:21:14 | <bwolfe> we're just trying to clone its guts though :-) |
| 08:21:43 | <rafa> bwolfe: interesting ;) |
| 08:34:44 | <rafa> bwolfe: when are you coming back to the U.S.? |
| 08:35:03 | <dkayiwa> coming back or going back :) |
| 08:35:44 | <rafa> dkayiwa: which is right? |
| 08:35:55 | <dkayiwa> depends on where you are |
| 08:36:03 | <dkayiwa> if you are in the US, then coming back |
| 08:36:11 | <dkayiwa> if you are not, then going back :) |
| 08:36:43 | <rafa> dkayiwa: then coming back doesn't make sense to me ;) |
| 08:36:52 | <dkayiwa> lollllllllllllll |
| 08:37:06 | <dkayiwa> but will a few weeks from now :D |
| 08:37:08 | <dkayiwa> not so? |
| 08:38:12 | <rafa> bwolfe: I wonder if we meet. |
| 08:38:54 | <bwolfe> rafa, I don't think we will |
| 08:39:01 | <bwolfe> I won't be back to the US before Nov |
| 08:43:17 | <rafa> bwolfe: I see. I'll be stlll there in Nov, but in Boston. |
| 08:44:03 | <bwolfe> boo |
| 08:44:12 | <bwolfe> I might not be home until Dec |
| 08:44:36 | <rafa> bwolfe: yeah even BOOO |
| 08:46:27 | <bwolfe> guess that means I'll have to stop by europe. :-D |
| 08:46:50 | <bwolfe> rafa, find us a tech conference to go to. I have money each year to put towards conferences |
| 08:48:02 | *** bryq has quit IRC |
| 08:50:49 | <rafa> bwolfe: you mean in Europe? :D |
| 08:52:11 | <rafa> bwolfe: It'd be cool. |
| 08:52:51 | <rafa> bwolfe: we've got some great Java conferences in Poland, but mostly in polish ;) |
| 08:53:40 | <rafa> bwolfe: but it's still Java, you'd understand :D |
| 08:56:09 | *** yekkanti has joined #openmrs |
| 08:57:36 | *** sunbiz has quit IRC |
| 09:08:21 | *** dkayiwa has quit IRC |
| 09:27:11 | <bwolfe> rafa, haha, it'd have to be a mainly-english conf |
| 09:27:57 | <bwolfe> I'm serious though. if theres a conf we can both go to we should try |
| 09:28:06 | <bwolfe> somewhere in europe would be fairly cheap for me to fly to |
| 09:28:12 | <bwolfe> and very cheap for you to get to |
| 09:35:05 | <rafa> bwolfe: Awesome! There's nothing interesting I'm aware of on the horizon within next few months though. The conference season here is something between March and July. |
| 09:35:32 | <bwolfe> rafa, it'd have to be about then anyway |
| 09:36:02 | <bwolfe> My wife is due the end of january...so she wouldn't want me to travel for a few months after that. :-) |
| 09:36:38 | <rafa> bwolfe: Oh nice :) |
| 09:37:51 | <rafa> bwolfe: I'll let you know the moment anything interesting is announced. |
| 09:39:42 | <rafa> bwolfe: Have you ever been to Europe before? |
| 09:42:41 | *** deadpool has quit IRC |
| 09:53:56 | <surangak_> may i intrest you in hong kong ? http://bhi2012.embs.org/ |
| 09:56:46 | *** deadpool has joined #openmrs |
| 10:38:17 | *** yekkanti has quit IRC |
| 11:01:24 | *** surangak_ has quit IRC |
| 11:28:42 | *** dkayiwa has joined #openmrs |
| 11:29:02 | <dkayiwa> hi bwolfe |
| 11:30:04 | <bwolfe> hi daniel |
| 11:30:56 | <dkayiwa> bwolfe: just confirming that am on the right track. as for SYNC-200, my unit test is subclassing SyncBaseTest |
| 11:31:08 | *** upul` has quit IRC |
| 11:31:52 | <dkayiwa> bwolfe: because somewhere during the call SyncUtilTransmission.doFullSynchronize, there are calls like Context.getService(SyncService.class) |
| 11:33:04 | <rafa> dkayiwa: mine tickets are so boring comparing to yours |
| 11:33:15 | <dkayiwa> rafa: lolllllll |
| 11:33:24 | <dkayiwa> rafa: i could give you some of them :) |
| 11:34:23 | <dkayiwa> rafa: have you done any sync unit tests that subclass SyncBaseTest? |
| 11:35:08 | <rafa> dkayiwa: no, I'm stuck in the UI |
| 11:35:11 | <bwolfe> dkayiwa, the syncbasetest is if you want to test between child/parent/otherchild |
| 11:35:25 | <bwolfe> dkayiwa, you might be able to just base it on the basecontextsensitivetest |
| 11:36:37 | <dkayiwa> bwolfe: let me try basecontextsensitivetest |
| 11:37:38 | <dkayiwa> bwolfe: but this SyncUtilTransmission.doFullSynchronize() is a call from child to parent. doesn't that fit in the usecase for SyncBaseTest? |
| 11:39:04 | <bwolfe> dkayiwa, syncbasetest tests the actually transfer of sync records |
| 11:39:12 | <bwolfe> you're not doing that |
| 11:39:32 | <dkayiwa> ok |
| 11:39:36 | <bwolfe> I think syncbasetest expects a "run this on child" portion and then a "test this on parent" portion |
| 11:39:43 | <dkayiwa> ok |
| 11:48:59 | <dkayiwa> looks like am forgetting something here. am getting this exception while running my sync unit test |
| 11:49:00 | <dkayiwa> org.openmrs.api.APIException: Service not found: interface org.openmrs.module.sync.api.SyncService |
| 11:49:46 | <bwolfe> oh, I think you need to extend baseMODULEcontextsensitivetest |
| 11:50:07 | <dkayiwa> oh thanks. let me try it |
| 11:50:37 | <dkayiwa> bwolfe: my base class is already BaseModuleContextSensitiveTest |
| 11:50:50 | <bwolfe> oh, hmm |
| 11:51:59 | <bwolfe> dkayiwa, did you try extending syncbasetest too? |
| 11:52:13 | <dkayiwa> yes and got the same exception |
| 11:57:47 | <bwolfe> grr |
| 11:57:55 | <bwolfe> is this running it alone or as a batch? |
| 12:03:46 | *** naho has joined #openmrs |
| 12:10:53 | *** bryq has joined #openmrs |
| 12:10:53 | *** ChanServ sets mode: +v bryq |
| 12:11:18 | *** downeym has joined #openmrs |
| 12:11:18 | *** ChanServ sets mode: +o downeym |
| 12:11:18 | *** OpenMRSBot sets mode: +o downeym |
| 12:16:58 | *** naho has quit IRC |
| 12:18:25 | <dkayiwa> was running it alone |
| 12:19:14 | <dkayiwa> bwolfe: looks like it does not want to be in the sync-api project. putting it in the sync project works. |
| 12:21:42 | <bwolfe> ah ha! |
| 12:23:58 | *** rafa has quit IRC |
| 12:24:21 | *** bryq has quit IRC |
| 12:25:26 | *** rafa has joined #openmrs |
| 12:25:26 | *** ChanServ sets mode: +v rafa |
| 12:29:18 | *** wyclif has quit IRC |
| 12:45:49 | *** bryq has joined #openmrs |
| 12:45:49 | *** ChanServ sets mode: +v bryq |
| 12:56:48 | *** naho has joined #openmrs |
| 12:57:03 | <naho> @bwolfe, im using archetype as per ur advice, but im getting this error on omod pom:http://pastebin.com/TCsyfT0K. can u shade me some light on this please |
| 12:57:17 | <rafa> bwolfe: how is the db pass encrypted in openmrs-runtime.properties? |
| 12:57:26 | <bwolfe> rafa, its not |
| 12:57:56 | <rafa> bwolfe: strange, I can't connect to my db |
| 12:58:30 | <bwolfe> is mysql running?> |
| 12:58:57 | <rafa> bwolfe: yes, the other instance of openmrs connects with no problem |
| 12:58:59 | <downeym> in that case you'd better go catch it :) |
| 12:59:04 | <downeym> (sorry, couldn't resist) |
| 12:59:35 | <downeym> bad english joke |
| 12:59:40 | <bwolfe> rafa, are you modifying the right runtime properties file? |
| 12:59:49 | <bwolfe> naho, are you running in online mode or offline? |
| 13:00:10 | <naho> ioffline |
| 13:00:39 | <rafa> bwolfe: yeah |
| 13:00:57 | <rafa> bwolfe: it's so strange that I'll restart my pc ;) |
| 13:00:58 | <bwolfe> naho, you need to do it online so it can download that plugin from openmrs's maven repo |
| 13:01:30 | <bwolfe> rafa, always a good practice on a regular basis with your windows machine ;-) |
| 13:02:20 | <naho> bwolfe sorry about that im actually online and tried updating project configurations |
| 13:02:23 | <rafa> bwolfe: haha don't insult my windows ;P |
| 13:03:04 | <bwolfe> naho, can you pastebin your entire maven build output? |
| 13:05:36 | <naho> bwolfe but it catually says build success, only i was curious about this in case i run into problems later:http://pastebin.com/dcfwD9aX |
| 13:06:14 | <naho> and i have uploaded it in my openmrs installation |
| 13:06:49 | *** rafa has quit IRC |
| 13:07:11 | *** rafa has joined #openmrs |
| 13:07:11 | *** ChanServ sets mode: +v rafa |
| 13:08:50 | *** naho has quit IRC |
| 13:09:02 | *** gauravpaliwal has joined #openmrs |
| 13:09:02 | *** ChanServ sets mode: +v gauravpaliwal |
| 13:09:18 | *** naho has joined #openmrs |
| 13:10:16 | <rafa> bwolfe: the restart didn't help, but proved I'm an idiot :D |
| 13:10:37 | <rafa> bwolfe: I edited key instead of password :D |
| 13:10:54 | <dkayiwa> :) |
| 13:11:20 | <rafa> bwolfe: the conclusion is windows still rocks ;P |
| 13:11:32 | <dkayiwa> rafa: do you have an idea on how to assert from a thread launched from a unit test? |
| 13:11:58 | <rafa> dkayiwa: I don't know what you mean |
| 13:12:04 | <dkayiwa> :) |
| 13:12:39 | <rafa> dkayiwa: ohh I got you now, tricky |
| 13:12:54 | <dkayiwa> rafa: i have a unit test, which launches another thread |
| 13:13:11 | <bwolfe> dkayiwa, do it the other way around. spawn the thread but then make the assert |
| 13:14:10 | <dkayiwa> bwolfe: am supposed to assert on the return value from the spawned thread |
| 13:15:04 | <rafa> dkayiwa: yeah you need to wait for the thread to finish and do your asserts |
| 13:15:05 | <bwolfe> no, spawn the thread to do the call. then make the call again in the current thread. can you check against the call there? |
| 13:15:56 | <dkayiwa> bwolfe: oh i seee |
| 13:16:59 | <rafa> bwolfe: that's a good option too ;) |
| 13:26:24 | *** yekkanti has joined #openmrs |
| 13:27:20 | *** wyclif has joined #openmrs |
| 13:31:32 | *** gbastien has joined #openmrs |
| 13:37:04 | *** gauravpaliwal has quit IRC |
| 13:37:31 | *** dkayiwa has quit IRC |
| 13:40:24 | *** MarkG has joined #openmrs |
| 13:41:48 | *** yekkanti has quit IRC |
| 13:42:07 | <naho> guys: what do i include in my jsp to solve the ' unknown tag spring:message' prob(tags not recognized) |
| 13:49:10 | <bwolfe> naho, include the openmrs header file or the openmrs include file |
| 13:49:14 | <bwolfe> both are in the template folder |
| 13:50:40 | *** wyclif has quit IRC |
| 13:52:53 | *** dkayiwa has joined #openmrs |
| 13:53:20 | <naho> bwolfe, they are all included e.g 'WEB-INF/template/include.jsp' probably the problem is the WEB-INF folder, its not in my file system |
| 13:56:53 | <naho> bwolfe, how do u think i should proceed? |
| 13:58:22 | <bwolfe> naho, are you running tomcat or jetty? |
| 13:58:55 | <naho> bwolfe, tomcat |
| 13:59:14 | <bwolfe> naho, and there is no tomcathome/webapps/openmrs/WEB-INF folder ?? |
| 14:01:46 | *** downeym has quit IRC |
| 14:02:49 | *** wyclif has joined #openmrs |
| 14:04:23 | <naho> bwolfe, what i did i imported the project into the eclipse framework, and yes there is that folder so i will go ahead and use the file thanks |
| 14:05:03 | <bwolfe> dkayiwa, rafa, wyclif, djazayeri, ready for a scrum? |
| 14:05:11 | <djazayeri> yes |
| 14:05:11 | <rafa> bwolfe: no :P |
| 14:05:17 | <bwolfe> and perhaps MarkG if you're still working on the sync sprint... |
| 14:05:24 | <bwolfe> rafa, wha?!?! |
| 14:05:31 | <dkayiwa> :) |
| 14:05:38 | <rafa> bwolfe: just kidding ;) |
| 14:05:49 | <bwolfe> phew! my world was almost turned upside down! |
| 14:05:49 | <dkayiwa> ofcourse :) |
| 14:05:59 | <bwolfe> rafa, ready to go first? |
| 14:06:09 | <rafa> bwolfe: no ;) |
| 14:06:22 | <MarkG> we scrum via irc? |
| 14:06:28 | <bwolfe> hmm, ok. |
| 14:06:31 | <bwolfe> MarkG, yep |
| 14:06:34 | <bwolfe> dkayiwa, are you ready? |
| 14:06:42 | <MarkG> sure, i can sit in |
| 14:06:57 | <dkayiwa> getting ready |
| 14:07:14 | <MarkG> i'm doing things tangentially related to the sync sprint right now... |
| 14:07:21 | <rafa> bwolfe: okay I'm ready |
| 14:07:39 | <bwolfe> ok, rafa, you can go then |
| 14:07:41 | <rafa> *** Rafal *** |
| 14:07:41 | <rafa> Today: |
| 14:07:41 | <rafa> * SYNC-191: there should be an indication of last ingest success/failure on parent server for each sync_server |
| 14:07:41 | <rafa> https://tickets.openmrs.org/browse/SYNC-191 |
| 14:07:41 | <rafa> * SYNC-20: record origin w/ sync records |
| 14:07:42 | <rafa> https://tickets.openmrs.org/browse/SYNC-20 |
| 14:07:42 | <rafa> * Is about to commit SYNC-212: Manage Synchronization link on the help page is broken |
| 14:07:43 | <rafa> https://tickets.openmrs.org/browse/SYNC-212 |
| 14:07:43 | <rafa> Modnay: |
| 14:07:44 | <rafa> * who knows? |
| 14:07:44 | <rafa> No blockers. |
| 14:08:31 | *** downeym has joined #openmrs |
| 14:08:31 | *** ChanServ sets mode: +o downeym |
| 14:08:31 | *** OpenMRSBot sets mode: +o downeym |
| 14:08:43 | <bwolfe> rafa, I assume it will be cleanup from these tickets...but if not, it will be sync 1.9 focused tickets. |
| 14:08:50 | <bwolfe> I don't plan on adding more sync tickets |
| 14:09:07 | <djazayeri> are we nearly done with all the sync tickets bwolfe? |
| 14:09:07 | <rafa> bwolfe: cool |
| 14:09:12 | <bwolfe> rafa, you also might be able to steal a ticket from either maros or chopin. they seem busy. :-) |
| 14:09:16 | <rafa> djazayeri: I took the last one ;) |
| 14:09:25 | <bwolfe> djazayeri, no unclaimed tickets currently |
| 14:09:28 | <djazayeri> and by "sync 1.9 focused tickets" do you mean just "1.9 focused tickets"? |
| 14:09:50 | <bwolfe> djazayeri, ha, yes, sorry. |
| 14:10:01 | <djazayeri> Okay, that makes more sense. :-) I'll have some ready. |
| 14:11:19 | <MarkG> want me to go? |
| 14:11:24 | <djazayeri> Sure |
| 14:11:43 | <bwolfe> rafa, I'll ping jeremy and maros to make sure they have the bandwidth to focus on them next week. otherwise you can start taking tickets from djazayeri's sprint page |
| 14:11:47 | <MarkG> Working on: |
| 14:11:48 | <MarkG> https://tickets.openmrs.org/browse/NP-1 |
| 14:11:51 | <MarkG> Blocker: |
| 14:11:59 | <MarkG> https://tickets.openmrs.org/browse/TRUNK-1930 |
| 14:12:13 | <MarkG> (tho I might just take the AuditableInterceptor out of 1.6.x as a workaround) |
| 14:12:29 | <djazayeri> !ticket NP-1 |
| 14:12:30 | <OpenMRSBot> djazayeri: [#NP-1] Modify Name Phonetics module to work wtih Sync - OpenMRS JIRA - https://tickets.openmrs.org/browse/NP-1 |
| 14:12:35 | <djazayeri> !ticket TRUNK-1930 |
| 14:12:36 | <OpenMRSBot> djazayeri: [#TRUNK-1930] Update dateChanged and changedBy fields on Auditable objects through a hibernate interceptor - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-1930 |
| 14:12:51 | * bwolfe really wants a ticket called NP-complete |
| 14:12:59 | *** downeym has quit IRC |
| 14:13:20 | <MarkG> I also noticed that this doesn't seem to be working properly for me, have we confirmed that it works? : |
| 14:13:23 | <djazayeri> Is a hard ticket in the name phonetics module called NP-hard? |
| 14:13:25 | <MarkG> !ticket SYNC-30 |
| 14:13:26 | <OpenMRSBot> MarkG: [#SYNC-30] Add Jump to First Error link on Sync History page - OpenMRS JIRA - https://tickets.openmrs.org/browse/SYNC-30 |
| 14:13:44 | <bwolfe> MarkG, see my email from 5 mins ago? I can't see a reason for it either. I'd also suggest just reverting the changedby in the aop method and forgetting about the interceptor |
| 14:14:09 | <bwolfe> MarkG, I think that was rafal's ticket |
| 14:14:20 | <bwolfe> rafa, yes? no? SYNC-30 ? |
| 14:14:24 | <rafa> bwolfe: yes |
| 14:14:35 | <rafa> bwolfe: what's wrong with that? |
| 14:14:53 | <bwolfe> MarkG thinks it might not be working correctly |
| 14:14:55 | <MarkG> bwolfe: didn't see your email, but sounds good |
| 14:15:18 | <MarkG> sync-30: it doesn't appear to jump anywhere when i click the link... |
| 14:15:36 | <MarkG> i wasn't using the latest omod, however... was going to wait until I could test it against that before... |
| 14:15:45 | <MarkG> ... I wrote an email, but figure I'd mention it here |
| 14:15:51 | <MarkG> what does the link consider "an error"? |
| 14:15:57 | <bwolfe> MarkG, are you running trunk? perhaps it was broken by a later commit (namely the one by suranga that adds the ability to change the size) |
| 14:16:13 | <MarkG> is an "awaiting confirmation (multiple tries)" considered any error? |
| 14:16:25 | <rafa> MarkG: let me test sync-30 |
| 14:17:36 | <MarkG> i will test it more later today, just figured i'd mention it... i noticed it didn't work on our production machine (which i updated a day or two ago)... didn't want to |
| 14:17:52 | <MarkG> upgrade production again, so i need to set up a test on my dev server |
| 14:18:10 | <bwolfe> ok, dkayiwa? |
| 14:18:27 | <dkayiwa> Been battling with a unit test for: running sync manually from the sync/status.list?mode=SEND_WEB page should check to see if a sync process is currently running and return message to wait if so - SYNC-200 |
| 14:18:27 | <dkayiwa> Reached a point where am confused as to whether i just have a poorly written test, or the code that is tested is the incorrect one. |
| 14:18:33 | <rafa> MarkG: it works for me |
| 14:19:02 | <MarkG> rafa: cool, i will test out more... is "awaiting confirmation (multiple tries)" considered an error? |
| 14:19:28 | <rafa> MarkG: I don't think so |
| 14:19:49 | <MarkG> rafal: okay... i will write an email later in the day and let you know what i find... |
| 14:20:19 | <bwolfe> dkayiwa, can you commit what you have with an @ignore on it and we can have a look? |
| 14:20:34 | <dkayiwa> bwolfe: let me do so straight away |
| 14:22:57 | <bwolfe> I assume wyclif is not back from the fire drill yet. djazayeri, are you ready? |
| 14:23:02 | <djazayeri> Yes |
| 14:23:03 | <djazayeri> Thursday |
| 14:23:04 | <djazayeri> * Implementers call, Developers call, Leadership call |
| 14:23:04 | <djazayeri> * Call with Gretchen about Pentaho |
| 14:23:04 | <djazayeri> * Organize tickets for 1.9 alpha push |
| 14:23:04 | <djazayeri> Today |
| 14:23:04 | <djazayeri> * Organize tickets for 1.9 alpha push |
| 14:23:05 | <djazayeri> * Backlog of code reviews |
| 14:23:05 | <djazayeri> * Try again to record last week's OpenMRS University screencast |
| 14:23:09 | <djazayeri> blockers: none |
| 14:23:17 | <wyclif> am here |
| 14:23:43 | <bwolfe> MarkG, is the reference to TRUNK-190 right on NP-1 ? |
| 14:24:08 | <bwolfe> ok, are you ready with your update wyclif? or should I go first? |
| 14:24:15 | <wyclif> i can go |
| 14:24:17 | <wyclif> yesterday: |
| 14:24:17 | <wyclif> - worked on SYNC-157 |
| 14:24:17 | <wyclif> - review comments for SYNC-41 and SYNC-49 |
| 14:24:17 | <wyclif> - dev call |
| 14:24:17 | <wyclif> - created SYNC-212 |
| 14:24:18 | <wyclif> today: |
| 14:24:20 | <wyclif> - respond to any pending review comments |
| 14:24:22 | <wyclif> - work on sprint tickets if any otherwise other roadmap tickets |
| 14:24:23 | *** lh has quit IRC |
| 14:25:11 | <MarkG> bwolfe: good catch... TRUNK-1930 |
| 14:25:47 | <MarkG> actually, should link to my new ticket as well... |
| 14:26:15 | <bwolfe> !ticket SYNC-157 |
| 14:26:16 | <OpenMRSBot> bwolfe: [#SYNC-157] Split "Max Sent Records" into "Max Sent Records via File" and "Max Sent Records via Web" - OpenMRS JIRA - https://tickets.openmrs.org/browse/SYNC-157 |
| 14:29:03 | <dkayiwa> bwolfe: Committed the unit test at rev:23247 |
| 14:29:52 | <bwolfe> ok, thanks |
| 14:29:59 | <bwolfe> !changeset 23247 |
| 14:29:59 | <OpenMRSBot> bwolfe: Details of changeset 23247 should be available at http://source.openmrs.org/qsearch?q=23247 |
| 14:30:36 | <bwolfe> hmm, not a clean link, but gets me there I suppose |
| 14:30:49 | <dkayiwa> :) |
| 14:31:42 | *** wyclif has quit IRC |
| 14:32:04 | <bwolfe> ok, my update: |
| 14:32:12 | <bwolfe> today: |
| 14:32:13 | <bwolfe> created sprint ticket |
| 14:32:13 | <bwolfe> debugged auditable issue |
| 14:32:13 | <bwolfe> emails, forum help, etc |
| 14:32:13 | <bwolfe> 5 crucible reviews for sync sprint |
| 14:32:13 | <bwolfe> monday: |
| 14:32:15 | <bwolfe> sync code reviews |
| 14:32:17 | <bwolfe> no blockers |
| 14:33:10 | <bwolfe> dkayiwa, perhaps its running too fast? is there a way you can add in some sort of delay or a large number of records to process so that you're sure the first is still in progress when you call it a second time? |
| 14:34:09 | <dkayiwa> bwolfe: let me first see how the other sync tests add records |
| 14:34:35 | <bwolfe> dkayiwa, easiest way would be to use dbunit xml like any other test |
| 14:34:48 | <dkayiwa> ok |
| 14:43:18 | *** wyclif has joined #openmrs |
| 14:49:31 | *** naho has quit IRC |
| 14:51:03 | *** pascal` has quit IRC |
| 15:01:18 | <bwolfe> MarkG, is dave around this week? |
| 15:01:27 | <bwolfe> MarkG, or more importantly, is he around email this week? |
| 15:02:08 | <MarkG> don't know... i noticed him online on skype this week, but haven't heard from him |
| 15:02:55 | <MarkG> bwolfe: yeah, Ellen says she emailed him a couple times this week and haven't heard back |
| 15:03:19 | <bwolfe> ok, if he's ignoring ellen then I don't have a prayer |
| 15:03:20 | <bwolfe> :-) |
| 15:03:50 | *** wyclif has quit IRC |
| 15:04:42 | <bwolfe> is jira/crucible slow for everyone now, or is it just my connection? |
| 15:07:38 | <bwolfe> dkayiwa, did you update your wiki page after the changes in SYNC-167 |
| 15:09:19 | <dkayiwa> no |
| 15:12:35 | *** wyclif has joined #openmrs |
| 15:12:57 | <dkayiwa> bwolfe: are there any changes for me to make on it? |
| 15:17:41 | *** dkayiwa has quit IRC |
| 15:29:39 | <djazayeri> rafa: once the last sync sprint tickets are finished off, are you ready to start working on the metadata-sharing-support-for-reporting issue? |
| 15:29:41 | *** bryq1 has joined #openmrs |
| 15:30:15 | <rafa> djazayeri: absolutely! |
| 15:31:40 | *** bryq has quit IRC |
| 15:31:52 | <djazayeri> Okay, so plan for that to be your first post-sync ticket. Perhaps we can get it done next week "for free" in the extra time from finishing this sprint early. |
| 15:34:11 | *** wyclif has quit IRC |
| 15:34:55 | <rafa> djazayeri: Ok |
| 15:46:27 | *** wyclif has joined #openmrs |
| 15:52:02 | *** pascal` has joined #openmrs |
| 15:57:21 | *** upul` has joined #openmrs |
| 15:57:21 | *** ChanServ sets mode: +v upul` |
| 15:57:30 | *** deadpool has quit IRC |
| 16:04:54 | *** pascal` has quit IRC |
| 16:08:25 | *** lh has joined #openmrs |
| 16:10:31 | *** deadpool has joined #openmrs |
| 16:17:23 | <MarkG> just wanted to say that i like the new "incoming" and "outgoing" distinction in the history of changes... |
| 16:20:37 | *** pascal` has joined #openmrs |
| 16:27:33 | *** rafa has quit IRC |
| 16:29:11 | *** burke has joined #openmrs |
| 16:29:11 | *** ChanServ sets mode: +o burke |
| 16:31:51 | *** downeym has joined #openmrs |
| 16:31:51 | *** ChanServ sets mode: +o downeym |
| 16:31:51 | *** OpenMRSBot sets mode: +o downeym |
| 16:38:40 | <djazayeri> bwolfe: looking at the etherpad notes from design call |
| 16:38:54 | <djazayeri> I see that this has strikeout: TODO: next week's design forum will discuss attribute types. Publicize, and review SoC work. - Ben |
| 16:39:00 | <djazayeri> Is that done? |
| 16:41:23 | *** upul` has quit IRC |
| 16:57:29 | *** burke has quit IRC |
| 17:09:34 | *** yekkanti has joined #openmrs |
| 17:09:45 | *** yekkanti has quit IRC |
| 17:42:15 | <djazayeri> downeym: I've noticed that since you put that switchboard page at connect.openmrs.org, that's now my preferred way of finding our weekly meeting pages. |
| 17:42:35 | <downeym> djazayeri: yeah, i started thinking the same thing |
| 17:42:40 | <djazayeri> Perhaps it's a failure on my part to use bookmarks, but maybe we should consider meetings.openmrs.org |
| 17:43:09 | <djazayeri> or something like that |
| 17:43:13 | <downeym> hmm, maybe so |
| 17:43:27 | <djazayeri> anyway, just wanted to throw that out there. |
| 17:44:04 | <downeym> we should check on the page views in a week or two and see how much uptake it gets |
| 17:44:27 | <djazayeri> the connect one? |
| 17:44:33 | <downeym> right |
| 17:44:53 | <djazayeri> well, that gets uptake just because people are used to going to connect.openmrs.org for meetings (or else we're used to telling them to go there) |
| 17:45:10 | <djazayeri> it hasn't been publicized, has it? |
| 17:45:25 | <downeym> no |
| 17:45:38 | <downeym> although afaik each meeting's page has a direct link to the meeting room, rather than to that page |
| 17:45:45 | <djazayeri> it has both |
| 17:45:53 | <downeym> true |
| 17:45:57 | <djazayeri> one column is to the page, one column is to breeze |
| 17:46:17 | <downeym> anyhow we can see what people are clicking on and hopefully make the popular path simpler |
| 17:49:00 | *** asgoyal has joined #openmrs |
| 17:49:13 | <downeym> hey ankur :) |
| 17:56:04 | <bwolfe> djazayeri, I struck that out on there because I put it onto the topic list for next week's call |
| 17:56:11 | <djazayeri> ah, okay |
| 17:56:18 | <djazayeri> still need to publicize. :-) |
| 17:57:10 | <bwolfe> yes, its still in my open tabs so I remember to send the email |
| 17:57:35 | <bwolfe> I wanted to find the notes from the last time we discussed this, but the page and/or notes seem to have been lost to reorganization :-/ |
| 17:57:54 | <asgoyal> downeym: HI! :) |
| 17:59:38 | *** gbastien has quit IRC |
| 17:59:57 | *** chughgaurav has joined #openmrs |
| 18:00:45 | *** rafa has joined #openmrs |
| 18:00:45 | *** ChanServ sets mode: +v rafa |
| 18:12:59 | *** Gretchie has joined #openmrs |
| 18:13:05 | <downeym> Hi Gretchie and welcome to the #openmrs IRC channel. |
| 18:13:16 | *** upul` has joined #openmrs |
| 18:13:16 | *** ChanServ sets mode: +v upul` |
| 18:13:24 | <Gretchie> hello |
| 18:13:30 | <djazayeri> hi |
| 18:13:56 | <Gretchie> I'm wondering if there are known issues with the reporting module when openMRS is deployed to Tomcat 6.x? |
| 18:14:19 | <djazayeri> Not that I'm aware of. Are you seeing one? |
| 18:15:11 | <Gretchie> I was having installation issues with the documented versions of the modules to download - so I took the omods from the demo deployment. Now I am seeing NPEs when attempting to preview or save a cohort query |
| 18:15:13 | *** bwolfe has quit IRC |
| 18:16:10 | <Gretchie> The two different areas where the NPEs were thrown were on a getParameters() method call in different definitions... i was hoping maybe I've just missed a common step? |
| 18:16:58 | *** mnunez has joined #openmrs |
| 18:17:07 | <djazayeri> You're creating cohort queries, I take it? |
| 18:17:37 | <Gretchie> yes... I tried a simple age, then gender query.. same results, different classes |
| 18:18:04 | <djazayeri> One issue could be if you make something a parameter, and you leave it null. |
| 18:18:15 | <djazayeri> But are you using parameters yet, or just setting fixed values? |
| 18:18:36 | <Gretchie> As far as I know I didn't make anything a a parameter intentionally... where would I check this? |
| 18:19:01 | <djazayeri> When you're creating the cohort query, for each attribute you can choose "fixed value" or "parameter" |
| 18:20:27 | <djazayeri> downeym: on demo.openmrs.org I get an error when trying to view a Reporting page. |
| 18:20:27 | <djazayeri> http://demo.openmrs.org/openmrs/module/reporting/definition/manageDefinitions.form?type=org.openmrs.module.reporting.cohort.definition.CohortDefinition |
| 18:20:29 | <Gretchie> In my gender query for example, all three possible values are fixed, true, false and false for an all male query. Although the two lower values were pre-set. Let me try forcing them set |
| 18:20:33 | <OpenMRSBot> <http://ln-s.net/9+Lz> (at demo.openmrs.org) |
| 18:20:33 | <djazayeri> This seems familiar |
| 18:21:24 | <djazayeri> downeym: i.e. I vaguely remember us seeing this before and it turned out not to be a code problem, but reloading the module or something. (but I could be wrong) |
| 18:21:43 | * downeym redeploys the site to start checking |
| 18:21:56 | <Gretchie> forcing made no difference... org.openmrs.module.reporting.web.controller.QueryParameterFormController.processForm(QueryParameterFormController.java:80) |
| 18:22:56 | <djazayeri> Gretchie: that's an NPE, and it comes from trying to save a simple cohort query? (a gender query?) |
| 18:23:17 | <Gretchie> yes... unfortunately the stack trace isn't anymore helpfult han that |
| 18:24:59 | <djazayeri> let me try locally |
| 18:25:53 | <Gretchie> Note that I have my own MySQL server running and I am deployyed to Tomcat 6.0.29 - I can run a demo server locally with the same version of hte modules and the queries save and preview fine... that's why I am questioning the app server, or a misconfiguration |
| 18:26:35 | <djazayeri> I vaguely recall a problem with tomcat 6.0.28 |
| 18:26:42 | <djazayeri> and the solution was to upgrade to 6.0.32 |
| 18:26:48 | <djazayeri> but I could have those numbers wrong |
| 18:27:17 | <Gretchie> I haven't had any previous deployment issues until loading the reporting modules.. I can try 6.0.32 a bit later |
| 18:28:09 | <djazayeri> yeah, looking at that page I don't see how you could possible have done anything "wrong" |
| 18:28:25 | <downeym> djazayeri: seems to work now |
| 18:29:01 | <djazayeri> odd |
| 18:29:08 | <Gretchie> OK, don't burn time on it, I will re-deploy to a newer Tomcat and let you know my results. If the issue persists, should I report it through the application, is that the proper channel? |
| 18:29:22 | <djazayeri> sure |
| 18:29:40 | <Gretchie> thanks.. I have to break for a moment and will pop in later |
| 18:30:12 | *** Gretchie has quit IRC |
| 18:39:34 | *** deadpool has quit IRC |
| 18:40:41 | <wyclif> hi djazayeri |
| 18:40:52 | <djazayeri> hi wyclif |
| 18:40:59 | <wyclif> djazayeri, quick question |
| 18:42:35 | <djazayeri> okay |
| 18:43:31 | <wyclif> djazayeri, do you know the reason why it 'they' chose chose to define things like module privileges and global properties by hardcoding them in the config.xml rather than having a configuration interface/abstract class that modules can implement to return a list of these |
| 18:43:40 | <wyclif> this has some benefits |
| 18:44:49 | <wyclif> i.e they extend a given abstract class that has methods like getPrivileges() and then they define this in the config file just liek the activator |
| 18:44:57 | <wyclif> probably this could be in the activator |
| 18:45:11 | <djazayeri> at the time that Ben was writing that code, it seemed like a good idea to allow these things to be created via XML |
| 18:45:12 | *** gbastien has joined #openmrs |
| 18:45:25 | <wyclif> but you get my idea |
| 18:45:37 | <djazayeri> In retrospect I agree that doing it via code in the activator's post-startup method would be better. |
| 18:45:48 | <wyclif> am sending an email about this |
| 18:46:07 | <wyclif> i have added the some benefits to using a class |
| 18:46:12 | <djazayeri> alternately, pretty much everything we're doing in our module config.xml would be better done via Spring |
| 18:46:27 | <wyclif> something like that |
| 18:47:53 | <wyclif> sorry about my typos |
| 18:59:59 | *** rafa has quit IRC |
| 19:11:29 | *** upul` has quit IRC |
| 19:22:33 | *** rafa has joined #openmrs |
| 19:22:33 | *** ChanServ sets mode: +v rafa |
| 19:40:43 | *** mnunez has quit IRC |
| 19:45:24 | *** chughgaurav has quit IRC |
| 19:47:13 | *** Suranga has joined #openmrs |
| 20:10:13 | *** asgoyal has quit IRC |
| 20:13:34 | *** lh has quit IRC |
| 20:25:30 | *** chughgaurav has joined #openmrs |
| 20:31:07 | *** Suranga has quit IRC |
| 20:31:18 | *** bryq1 has quit IRC |
| 20:39:31 | *** lh has joined #openmrs |
| 21:21:57 | *** MarkG has quit IRC |
| 21:29:10 | *** chughgaurav has quit IRC |
| 21:58:46 | *** wyclif has quit IRC |
| 22:05:07 | *** mnunez has joined #openmrs |
| 22:09:15 | *** downeym has quit IRC |
| 22:09:18 | *** downeym_ has joined #openmrs |
| 22:09:18 | *** ChanServ sets mode: +o downeym_ |
| 22:09:42 | *** downeym has joined #openmrs |
| 22:09:42 | *** OpenMRSBot sets mode: +o downeym |
| 22:09:49 | *** ChanServ sets mode: +o downeym |
| 22:11:14 | *** mnunez has quit IRC |
| 22:13:49 | *** downeym_ has quit IRC |
| 22:30:02 | *** chughgaurav has joined #openmrs |
| 22:33:27 | *** chughgaurav has quit IRC |
| 22:49:40 | *** mnunez has joined #openmrs |
| 22:53:14 | *** downeym has quit IRC |
| 23:09:48 | *** mnunez has quit IRC |
| 23:25:21 | *** sunbiz has joined #openmrs |
| 23:25:21 | *** ChanServ sets mode: +v sunbiz |
| 23:25:30 | *** sunbiz has left #openmrs |
| 23:46:59 | *** morristic has joined #openmrs |
| 23:53:08 | *** gbastien has quit IRC |