| 00:03:37 | *** burke has joined #openmrs |
| 00:03:37 | *** ChanServ sets mode: +o burke |
| 00:24:03 | *** lh has quit IRC |
| 00:31:15 | *** burke has quit IRC |
| 00:31:22 | *** burke has joined #openmrs |
| 00:31:22 | *** ChanServ sets mode: +o burke |
| 01:54:34 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): concept_mappings: Adding concept source select option to the concept reference term form <http://feedproxy.google.com/~r/OMRStrunk/~3/isqHlOnCG_8/OpenMRS> |
| 02:22:20 | *** sunbiz1 has joined #openmrs |
| 02:23:05 | *** sunbiz1 has left #openmrs |
| 02:25:05 | *** sunbiz has quit IRC |
| 02:46:07 | *** burke_ has joined #openmrs |
| 02:50:03 | *** burke has quit IRC |
| 02:50:33 | *** upul` has joined #openmrs |
| 02:50:33 | *** ChanServ sets mode: +v upul` |
| 03:16:34 | *** djazayeri has joined #openmrs |
| 03:16:34 | *** ChanServ sets mode: +o djazayeri |
| 03:16:34 | *** djazayeri has quit IRC |
| 03:18:06 | *** gbastien has joined #openmrs |
| 03:18:44 | *** djazayeri has joined #openmrs |
| 03:18:44 | *** ChanServ sets mode: +o djazayeri |
| 03:34:57 | *** gbastien has quit IRC |
| 04:00:23 | *** surangak has joined #openmrs |
| 04:03:56 | *** sunbiz has joined #openmrs |
| 04:03:56 | *** ChanServ sets mode: +v sunbiz |
| 04:18:17 | *** surangak_ has joined #openmrs |
| 04:42:46 | *** burke_ has quit IRC |
| 05:06:31 | *** djazayeri has quit IRC |
| 06:00:27 | *** bryq has joined #openmrs |
| 06:00:28 | *** ChanServ sets mode: +v bryq |
| 06:14:13 | <surangak_> bryq, heloo |
| 06:14:35 | <bryq> surangak_: Hi :) |
| 06:14:39 | *** dkayiwa has joined #openmrs |
| 06:15:03 | <surangak_> bryq, I was wondering, did u submit that code to gsoc peope ? |
| 06:15:34 | <bryq> surangak_: Yes, I've done it |
| 06:15:57 | <surangak_> bryq, its basicaly a compressed tar file that they need, is it ? |
| 06:16:18 | <surangak_> bryq, can you please tell me the steps u used ? |
| 06:16:43 | <bryq> surangak_: Yes, with *.diff and README files in it |
| 06:16:44 | <surangak_> bryq, Im guessing that I need to do a diff, then create a patch for the diff and compres that ? |
| 06:17:00 | <surangak_> bryq, did u do using windows ? |
| 06:17:16 | <bryq> surangak_: No, I'm on Linux |
| 06:17:32 | <surangak_> oh, i seee.. |
| 06:17:33 | *** mwogi has joined #openmrs |
| 06:17:54 | <surangak_> whats created by the diff ? is it like a patch ? :) |
| 06:18:00 | <bryq> surangak_: Was you working on a separate branch during this GSoC? |
| 06:18:08 | <surangak_> yep |
| 06:18:34 | <bryq> surangak_: Yea, diff is the same as a patch you might have attached sometimes to JIRA |
| 06:18:52 | <bryq> surangak_: Did you merge your branch into trunk? |
| 06:19:05 | <surangak_> bryq, yes, its up to date... |
| 06:19:14 | <bryq> surangak_: Good |
| 06:19:36 | <bryq> surangak_: After merging did you commit some more code? |
| 06:19:42 | <surangak_> so u basically compress and tar a patch file, is it :-) |
| 06:19:53 | <bryq> surangak_: Yes :) |
| 06:20:10 | <surangak_> bryq, great, thanks, let me try it out :P |
| 06:20:36 | <bryq> surangak_: You can get the diff from source.openmrs.org site |
| 06:21:01 | <bryq> surangak_: By selecting the revision where you merge the branch into trunk |
| 06:21:07 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (concept_mappings): Renaming ConceptReferenceMap back to ConceptMap <http://feedproxy.google.com/~r/OMRStrunk/~3/CauuW3dG9qY/OpenMRS> |
| 06:24:22 | *** mwogi_ has joined #openmrs |
| 06:25:19 | *** mwogi has quit IRC |
| 06:27:56 | <surangak_> bryq, im in source.openmrs, and looking at my branch.... how exactly do I get the diff, please :-) |
| 06:28:37 | <bryq> surangak_: Click "View as patch" and save the output |
| 06:30:32 | <surangak_> bryq, im not seeing the 'view as patch' :-( |
| 06:30:35 | <surangak_> im here https://source.openmrs.org/changelog/~br=obs-codes-expanded/OpenMRS |
| 06:30:52 | <OpenMRSBot> <http://ln-s.net/97k-> (at source.openmrs.org) |
| 06:31:42 | <bryq> surangak_: Hmm... But did you merge BRANCH INTO TRUNK or TRUNK INTO BRANCH ? |
| 06:31:56 | *** pascal` has joined #openmrs |
| 06:32:06 | <surangak_> i took latest changes from the tunk and put them into my branch... |
| 06:32:43 | <surangak_> oh i see, thats trunk into branch, is it ? |
| 06:33:11 | <bryq> surangak_: Yes, that's trunk into branch |
| 06:33:30 | <bryq> surangak_: This complicates things a little bit |
| 06:33:38 | <surangak_> bryq, ooops, how do i do the opposite ? i hadint done that :( |
| 06:34:01 | <surangak_> bryq, did u merge to trunk gradually, or all at once ? |
| 06:34:25 | <bryq> surangak_:You must talk with your mentor if the code is mature to be merged into trunk |
| 06:34:39 | <surangak_> bryq, oh i see |
| 06:34:39 | <bryq> surangak_:I've merged all at once |
| 06:34:51 | <surangak_> bryq, do we hav permission to merge into trunk ? |
| 06:34:57 | <surangak_> or do they have to do it ? |
| 06:35:38 | <bwolfe> we have to do it |
| 06:35:47 | <bryq> surangak_:I was commiting to modules and I have permission to all my project "branches, trunk" |
| 06:35:48 | <surangak_> oh, hi Ben |
| 06:36:10 | <surangak_> seems i have not merged branch to tunk, only the other way around :-( |
| 06:36:26 | <bryq> surangak_: But don't worry, you can create the *.diff without merging |
| 06:36:41 | <surangak_> bryq, thats a great relief :) |
| 06:36:57 | <bryq> surangak_: And you can give it to someone who has trunk commit privileges and he will do the merge |
| 06:36:57 | <surangak_> bwolfe, by "we" do u mean u guys, or me :-) |
| 06:37:04 | <bwolfe> hi suranga |
| 06:37:38 | <surangak_> bryq, ah, I get it, u r on modules, let me try that... |
| 06:37:56 | <bwolfe> surangak_, I mean any "full committer". see https://wiki.openmrs.org/display/docs/Subversion+Code+of+Conduct |
| 06:38:02 | <OpenMRSBot> <http://ln-s.net/97kC> (at wiki.openmrs.org) |
| 06:38:27 | <bryq> surangak_:I can give you a short guide how to create the *.diff. Want this? |
| 06:38:27 | <bwolfe> surangak_, but yes, if you have a diff/patch file that applies cleanly to trunk, whomever does the merging over will be very happy with you. :-) |
| 06:38:57 | <surangak_> bryq, unfortunately im on windows :-( |
| 06:39:07 | <bryq> surangak_:That's no problem |
| 06:39:19 | <bryq> surangak_:You will use only Eclipse |
| 06:39:42 | <surangak_> bryq, thats great, can u give me the steps please ? |
| 06:39:49 | <surangak_> thanks awfully |
| 06:39:57 | <bryq> surangak_: Okay |
| 06:40:20 | <bryq> surangak_: Do you have eclipse with "Subversive" plugin? |
| 06:40:29 | <surangak_> bryq, yeps |
| 06:41:17 | <surangak_> is it a compare with branch thing in eclipse ? |
| 06:41:35 | <bryq> surangak_: Good, then switch Eclipse to some fresh workspace and import project "openmrs trunk" |
| 06:41:54 | *** rafa has joined #openmrs |
| 06:41:54 | *** ChanServ sets mode: +v rafa |
| 06:42:01 | <surangak_> ok, and then I would ... |
| 06:42:29 | <bryq> surangak_: I do not know if "compare with branch" is good thing. Follow my steps, which are surely good :) |
| 06:42:40 | <surangak_> bryq, tell me the steps, and ill try them out |
| 06:42:44 | <surangak_> bryq, sure, will do |
| 06:43:29 | <bryq> surangak_: Then after you check out the trunk, right-click on the project and select "Team > Merge" |
| 06:44:21 | <surangak_> bryq, aha, im getting a dialog box with some options :) |
| 06:44:49 | *** muthah has joined #openmrs |
| 06:44:50 | <bryq> surangak_: Good, now wait a moment. I have to look on this dialog |
| 06:45:03 | <surangak_> bryq, sure |
| 06:46:38 | <bryq> surangak_: On the "URL" tab you select browse and select an url to your branch |
| 06:47:18 | <bryq> surangak_: In my example it is: https://svn.openmrs.org/openmrs-modules/metadatasharing/branches/publish-subscribe |
| 06:47:24 | <OpenMRSBot> <http://ln-s.net/97kG> (at svn.openmrs.org) |
| 06:47:45 | <bwolfe> dkayiwa, how goes that visit infinite loop? |
| 06:48:15 | <surangak_> bryq, hmm.. im not getting a "url" tab.. im getting something called a "collabnet merge" |
| 06:48:19 | <dkayiwa> bwolfe: on one of my attributes i had a maxOccurs value of 9999999 |
| 06:48:36 | <bwolfe> dkayiwa, ahahah, so what was it doing? |
| 06:48:36 | <surangak_> bryq, with a list of merge input options |
| 06:48:37 | <dkayiwa> bwolfe: so it was not an infinite loop. it just had not finished :) |
| 06:48:54 | <bwolfe> was it adding 10 million elements to the page? |
| 06:49:00 | <dkayiwa> yes |
| 06:49:00 | <bryq> surangak_: It seems that you have different SVN plugin |
| 06:49:13 | <bryq> surangak_: Can you send me a screenshot of this dialog |
| 06:49:17 | <surangak_> bryq, hmm...I get it |
| 06:49:28 | <surangak_> bryq, I will have to update my stuff a bit I see |
| 06:49:33 | <dkayiwa> bwolfe: so i changed it to a lower value like 5 and all was well :) |
| 06:49:42 | <surangak_> shall I update everything and get back to you later on ? |
| 06:50:10 | <bwolfe> dkayiwa, nice. why'd you set it to 9999999 in the first place?? |
| 06:50:24 | <bryq> surangak_: Wait moment |
| 06:50:52 | <dkayiwa> bwolfe: did not know what maxOccurs is for so i just entered any value. and never knew that it would get back to me :) |
| 06:52:52 | <bryq> surangak_: Yes, update your things :) |
| 06:53:13 | <bryq> surangak_: In particular, get "Subversive" as SVN plugin |
| 06:53:22 | <surangak_> bryq, thanks for your help, Ill have a go and get back to you :-) |
| 06:53:48 | <bryq> surangak_: You can get everything from "Eclipse marketplace" if you have latest Eclipse version |
| 06:54:21 | <bryq> surangak_: Bye now. I'll be available in few hours |
| 06:54:30 | <surangak_> bryq, i seem to be using subclipse... |
| 06:54:35 | <surangak_> bryq, sure, no problem |
| 07:03:53 | <dkayiwa> bwolfe: is today also a public holiday in Kenya? |
| 07:04:01 | <bwolfe> dkayiwa, no, tomorrow is though |
| 07:04:08 | <dkayiwa> oh |
| 07:04:20 | <dkayiwa> bwolfe: IDI? |
| 07:04:39 | <bwolfe> no idea |
| 07:04:45 | <dkayiwa> :) |
| 07:04:49 | <bwolfe> its a muslim holiday though, thats all I know |
| 07:05:09 | <bwolfe> but I follow the US schedule. So I'm taking Monday off for Labor Day |
| 07:05:09 | <dkayiwa> bwolfe: today it is in Uganda :) |
| 07:05:31 | <dkayiwa> bwolfe: oh i see |
| 07:06:04 | <bwolfe> dkayiwa, so are you taking the day off? |
| 07:06:16 | <dkayiwa> bwolfe: yes :) |
| 07:06:25 | <bwolfe> sawa sawa |
| 07:06:48 | *** muthah has quit IRC |
| 07:07:33 | *** muthah has joined #openmrs |
| 07:15:47 | <mwogi_> Is there a way to read connections to the database in openmrs? |
| 07:17:30 | *** muthah has quit IRC |
| 07:17:42 | *** muthah has joined #openmrs |
| 07:24:21 | *** muthah has quit IRC |
| 07:24:59 | *** muthah has joined #openmrs |
| 07:25:08 | *** bryq has quit IRC |
| 07:28:26 | *** muthah_ has joined #openmrs |
| 07:28:26 | *** muthah has quit IRC |
| 07:28:28 | *** muthah_ is now known as muthah |
| 07:32:45 | *** muthah has quit IRC |
| 07:36:52 | *** muthah has joined #openmrs |
| 07:39:02 | *** rafa has quit IRC |
| 07:39:29 | *** bryq has joined #openmrs |
| 07:39:29 | *** ChanServ sets mode: +v bryq |
| 07:41:07 | *** muthah_ has joined #openmrs |
| 07:41:08 | *** muthah has quit IRC |
| 07:41:09 | *** muthah_ is now known as muthah |
| 07:58:07 | <bwolfe> mwogi_, you have to get it from hibernate |
| 07:58:13 | <bwolfe> from the current session |
| 08:03:37 | <mwogi_> so it possible? i needed to implement it through the amrscustomization module |
| 08:04:05 | <bwolfe> mwogi_, yes. its sessionFactory.getCurrentSession().getConnection() or something |
| 08:04:14 | <bwolfe> you might need to create an inner method to be able to use the connection |
| 08:04:27 | <bwolfe> hibernate did something funky with the latest release where they didn't want to just give out the connection |
| 08:13:08 | *** dkayiwa has quit IRC |
| 08:16:55 | *** dkayiwa has joined #openmrs |
| 08:22:11 | <mwogi_> bwolfe, Maybe i will need sometime to study that. :P |
| 08:29:57 | *** pascal` has quit IRC |
| 08:44:31 | <surangak_> bwolfe, hi, i have a small clarification..... |
| 09:03:42 | *** pascal` has joined #openmrs |
| 09:07:14 | *** muthah has quit IRC |
| 09:11:04 | *** pascal` has quit IRC |
| 09:15:16 | <bryq> surangak_: Hi, I'm available for a while. |
| 09:15:32 | <bryq> surangak_: And I've got an idea how to quickly solve your problem |
| 09:15:51 | <surangak_> bryq, what have u got in mind ? :-) |
| 09:15:59 | <bryq> surangak_: I see that you merged trunk into your branch many times |
| 09:16:13 | <bryq> surangak_: So this means that you know how to do it |
| 09:16:14 | <surangak_> yepsssss |
| 09:16:26 | <surangak_> yaaa, thats one thing im good at :P |
| 09:16:41 | <bryq> surangak_: Now you must merge your branch into trunk |
| 09:16:53 | <bryq> surangak_: But you will not commit changes |
| 09:17:15 | <bryq> surangak_: But "Team > Create patch" |
| 09:17:32 | <bryq> surangak_: And this will be your GSoC diff |
| 09:18:06 | <surangak_> bryq, hmmm.... I see what u mean |
| 09:18:17 | <surangak_> bryq, actually that sounds like a cool idea :-) |
| 09:18:29 | <sunbiz> hi bwolfe |
| 09:18:54 | <bryq> surangak_: Yes, it sounds good to me too :) |
| 09:19:41 | <surangak_> bryq, actually i didnt get a chance to try out anything yet |
| 09:19:51 | <surangak_> bryq, bit tied up at office |
| 09:20:08 | <surangak_> bryq, have to wait a few hours to try this out :-) |
| 09:20:21 | <bryq> surangak_: After merging you should resolve all conflicts (I think you know that), run tests and check if everything works. If yes, create the patch and send it to Google and someone who will be able to commit it to the trunk |
| 09:21:04 | <bryq> surangak_: It's no problem for me :) I'm working now too, but have a short break |
| 09:21:35 | <surangak_> bryq, I think your solution should definitely work, I will try that out this evneing... |
| 09:21:58 | <surangak_> bryq, thanks a lot for the help, svn izing has always been my weak point :-) |
| 09:22:19 | <bryq> surangak_: You're welcome |
| 09:28:27 | *** pascal` has joined #openmrs |
| 09:55:39 | *** rafa has joined #openmrs |
| 09:55:39 | *** ChanServ sets mode: +v rafa |
| 10:54:43 | *** bwolfe has quit IRC |
| 11:12:47 | *** james_regen has joined #openmrs |
| 11:12:47 | *** ChanServ sets mode: +v james_regen |
| 11:15:51 | *** dkayiwa has left #openmrs |
| 11:35:51 | *** upul` has quit IRC |
| 11:43:53 | *** mwogi_ has quit IRC |
| 11:51:08 | *** bwolfe has joined #openmrs |
| 11:51:08 | *** ChanServ sets mode: +o bwolfe |
| 11:57:59 | <sunbiz> bwolfe: Hi... |
| 11:58:09 | <bwolfe> hey |
| 11:58:19 | <sunbiz> is there a reason why the OpenMRS formatter doesnt format xml?? |
| 11:58:50 | <sunbiz> because its quiet haphazard at the moment... to look at the xmls |
| 12:01:49 | <bwolfe> the xml should be left along |
| 12:01:51 | <bwolfe> *alone |
| 12:02:07 | <bwolfe> if it formats the xml, then things like the openmrs-servlet.xml gets messed up and spring cna't read it |
| 12:02:28 | <sunbiz> ahh... why is that so?? |
| 12:02:41 | <sunbiz> I can do a Ctrl+Shift+F and do format in my IDE |
| 12:02:44 | <sunbiz> and spring reads fine |
| 12:04:07 | <bwolfe> it didn't use to |
| 12:08:02 | <sunbiz> ohh... so when eclipse formats the xmls... spring fails to read it?? |
| 12:08:20 | <sunbiz> eclipse-- |
| 12:08:37 | <sunbiz> !karma eclipse |
| 12:08:37 | <OpenMRSBot> sunbiz: Karma for "eclipse" has been increased 2 times and decreased 2 times for a total karma of 0. |
| 12:08:42 | <sunbiz> netbeans++ |
| 12:08:46 | <sunbiz> !karma netbeans |
| 12:08:46 | <OpenMRSBot> sunbiz: Karma for "netbeans" has been increased 4 times and decreased 0 times for a total karma of 4. |
| 12:08:53 | <sunbiz> wooohhhhh!!! |
| 12:09:04 | <bwolfe> netbeans-- |
| 12:09:08 | <sunbiz> :( |
| 12:09:49 | <sunbiz> why bwolfe?? |
| 12:10:01 | <bwolfe> because I don't like it |
| 12:10:46 | <sunbiz> bwolfe: u said u'll use the hot deploy... but u didnt |
| 12:10:54 | <sunbiz> its nice... and u'd say ++ as well |
| 12:12:53 | <bwolfe> haha |
| 12:13:03 | <bwolfe> I tried to use it. I hated the interface. and nothing was intuitive |
| 12:13:14 | <bwolfe> I wasted a day trying to get something basic done... |
| 12:14:26 | <sunbiz> u need to give it more than a day... |
| 12:15:39 | <sunbiz> its called the "inertia"... newton's first law |
| 12:16:08 | <bwolfe> the coefficient of static friction / activation energy was too high (depending on if you like physics or chemistry) |
| 12:21:32 | <sunbiz> bwolfe: but seriously?? eclipse has problems formatting xml or the OpenMRS-Formatter?? |
| 12:21:57 | <bwolfe> sunbiz, dunno which one it is |
| 12:36:42 | <surangak_> bwolfe, hi.. mm small question.... even though the pencils down date went by, we're still supposed to update our branches to trunk until it is merged back, right ? |
| 12:37:11 | <bwolfe> surangak_, you can do all the work you want. it just doesn't count towards whether you pass or fail |
| 12:37:13 | <surangak_> bwolfe, otherwise itll be so outdated by the time someones tries to merge it, they'll go crazy :-) |
| 12:37:20 | <bwolfe> (which you already know anyway, since you passed) :-) |
| 12:37:27 | <surangak_> bwolfe, aaaaaaaaah, i get it. Will do |
| 12:37:34 | <surangak_> bwolfe, :D |
| 12:45:09 | *** pascal` has quit IRC |
| 12:56:22 | *** sunbiz1 has joined #openmrs |
| 12:58:39 | *** sunbiz has quit IRC |
| 13:04:19 | *** surangak_ has quit IRC |
| 13:11:18 | *** james_regen has quit IRC |
| 13:17:35 | *** surangak has quit IRC |
| 13:24:26 | *** Gretchie has joined #openmrs |
| 13:37:18 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): TRUNK-2602: Move the "active visit" on the patient dashboard next to the Last Encounter and highlight it a bit less ... <http://feedproxy.google.com/~r/OMRStrunk/~3/iyJ211XzJiw/OpenMRS> |
| 13:39:52 | *** upul` has joined #openmrs |
| 13:39:53 | *** ChanServ sets mode: +v upul` |
| 13:44:52 | *** aja has joined #openmrs |
| 13:50:07 | *** sunbiz has joined #openmrs |
| 13:50:07 | *** ChanServ sets mode: +v sunbiz |
| 13:50:59 | *** sunbiz1 has quit IRC |
| 13:56:29 | *** upul` has left #openmrs |
| 13:59:37 | *** gbastien has joined #openmrs |
| 14:02:00 | <bwolfe> rafa, I'll be back on in 10 mins for the scrum |
| 14:02:09 | <rafa> bryq: cool |
| 14:02:17 | <rafa> bwolfe: cool :) |
| 14:04:43 | *** djazayeri has joined #openmrs |
| 14:04:49 | *** ChanServ sets mode: +o djazayeri |
| 14:04:53 | <djazayeri> hi |
| 14:05:45 | <djazayeri> bwolfe, rafa, dkayiwa, wyclif |
| 14:06:04 | <rafa> hi djazayeri, Ben will be back in 10 mins |
| 14:06:13 | <djazayeri> ok |
| 14:06:16 | <djazayeri> we can wait for him then |
| 14:06:20 | <rafa> sure |
| 14:07:15 | <wyclif> hi |
| 14:07:25 | *** bwolfe has quit IRC |
| 14:08:13 | <rafa> djazayeri: meanwhile can you tell me what calls should interest devs (me) in the new schedule? |
| 14:08:46 | <rafa> djazayeri: there's a buch of them now and I'm not sure what to pick ;) |
| 14:10:17 | <djazayeri> You should definitely be at the Developer Community Forum. I believe the Implementer Forum will be interesting. |
| 14:11:10 | <djazayeri> I would try to sometimes join the Technical Design Forum once in a while, though that's obviously at an inconvenient time. |
| 14:13:04 | <rafa> djazayeri: yes, it's in the evening here |
| 14:13:52 | <rafa> djazayeri: the other two sound good |
| 14:19:52 | *** bwolfe has joined #openmrs |
| 14:19:52 | *** ChanServ sets mode: +o bwolfe |
| 14:20:54 | <djazayeri> hi bwolfe, you back? |
| 14:21:44 | <djazayeri> okay, my turn to step away for 5 mins |
| 14:21:52 | <bwolfe> heh, yes, am back |
| 14:22:02 | <bwolfe> did you guys start without me? or were you delaying>? |
| 14:22:17 | <rafa> we were waiting for you |
| 14:22:56 | <bwolfe> how sweet of you guys |
| 14:23:08 | <rafa> and guess what the waiting game continues ;) |
| 14:23:23 | <rafa> we're waiting for Darius |
| 14:25:12 | *** aja has quit IRC |
| 14:25:39 | <bwolfe> screw darius, lets go ahead without him. :-p |
| 14:26:19 | <rafa> haha how sweet of you :D |
| 14:28:57 | <djazayeri> okay |
| 14:29:03 | <djazayeri> let's go |
| 14:29:45 | <bwolfe> I'll go first |
| 14:29:52 | <bwolfe> (for a change) |
| 14:29:55 | <bwolfe> today: |
| 14:29:56 | <bwolfe> fix the maven setup in the sync module |
| 14:29:56 | <bwolfe> get ci working correctly |
| 14:29:56 | <bwolfe> fixed the 1.6.3 release in the mavenrepo |
| 14:29:56 | <bwolfe> sync overview chat with the ampath devs in prep for next week |
| 14:29:56 | <bwolfe> reviewed SMART-25 for wyclif |
| 14:29:58 | <bwolfe> triaged some tickets for saptarshi |
| 14:30:00 | <bwolfe> release process discussion with vijay |
| 14:30:02 | <bwolfe> tomorrow: |
| 14:30:04 | <bwolfe> actually do a sprint tickets?! |
| 14:30:06 | <bwolfe> (and because I just finished typing it up) |
| 14:30:43 | <rafa> bwolfe: did you find out why ci jobs got killed? |
| 14:30:54 | <bwolfe> no, wasn't looking into that |
| 14:31:02 | <bwolfe> mdowney is on that case |
| 14:31:13 | <bwolfe> I was just on the "why doesn't sync build when pointing at 1.6.2 case" |
| 14:31:23 | <rafa> bwolfe: ohh okay |
| 14:31:24 | <bwolfe> (and then I realized it only supported 1.6.3) |
| 14:31:38 | <bwolfe> so then I was on the "why doesn't sync build with 1.6.3 case" |
| 14:31:38 | <bwolfe> :-) |
| 14:32:03 | <djazayeri> any blockers? |
| 14:33:03 | <bwolfe> no, cleared it up about an hour and a half ago...just enough time to give the overview talk with the guys and then come back here |
| 14:33:34 | <djazayeri> okay |
| 14:33:36 | <djazayeri> I'll go next |
| 14:33:47 | <djazayeri> Monday |
| 14:33:47 | <djazayeri> * sprint-related things (code review, ticket design) |
| 14:33:48 | <djazayeri> * discuss sql indicators for reporting with Mike |
| 14:33:48 | <djazayeri> * discuss sync-related of a PIH pharmacy module with Mike and Justin |
| 14:33:48 | <djazayeri> * a few code reviews |
| 14:33:48 | <djazayeri> Today |
| 14:33:49 | <djazayeri> * discuss row-per-patient (& row-per-xyz) reporting with Mike |
| 14:33:49 | <djazayeri> * record screencast for OpenMRS University |
| 14:33:50 | <djazayeri> * get more tickets ready-for-work |
| 14:33:50 | <djazayeri> * fly back to Seattle |
| 14:33:51 | <djazayeri> * code reviews |
| 14:33:51 | <djazayeri> no blockers |
| 14:35:05 | <djazayeri> rafa? |
| 14:35:17 | <rafa> *** Rafal *** |
| 14:35:18 | <rafa> Today: |
| 14:35:18 | <rafa> * Minor fixes in yesterday's commits |
| 14:35:18 | <rafa> * Worked on TRUNK-2596: Add an Edit Person page |
| 14:35:18 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2596 |
| 14:35:18 | <rafa> Tomorrow: |
| 14:35:18 | <rafa> * Commit TRUNK-2596 |
| 14:35:19 | <rafa> * Pick up a new ticket |
| 14:35:19 | <rafa> No blockers. |
| 14:35:39 | <djazayeri> you went with the Long-form page to copy? |
| 14:35:56 | <rafa> djazayeri: yes |
| 14:36:10 | <rafa> djazayeri: I saw your message |
| 14:36:29 | <rafa> djazayeri: I guess I forgot to respond? |
| 14:36:38 | <djazayeri> you probably responded, I was away from the computer a lot |
| 14:36:48 | <djazayeri> okay |
| 14:36:52 | <djazayeri> wyclif? |
| 14:37:46 | <bwolfe> why do you fly djazayeri? |
| 14:38:35 | <djazayeri> Why fly? As opposed to what? |
| 14:38:46 | <bwolfe> err, when |
| 14:38:48 | <djazayeri> Boston to Seattle is pretty far for any other form of transport. :-) |
| 14:38:52 | <djazayeri> 9pm flight |
| 14:39:05 | <djazayeri> I will really enjoy landing at midnight, and having to lead a 6am call. |
| 14:39:12 | <bwolfe> ahaha |
| 14:39:19 | <bwolfe> poor planning on that one :-( |
| 14:39:31 | <wyclif> yesterday: |
| 14:39:31 | <wyclif> - Added support for users to select a concept source where to search terms to map to when mapping terms |
| 14:39:32 | <wyclif> - renamed concep reference map class back to concept map(required alot of code changes) |
| 14:39:32 | <wyclif> - Fixed a couple of other small bugs |
| 14:39:32 | <wyclif> - cleaned up reviews/tickets from SMART sprint |
| 14:39:32 | <wyclif> - exchanged some emails about some features of the concept mappings |
| 14:39:34 | <wyclif> today: |
| 14:39:36 | <wyclif> - my TODOs depend on 2 decisions |
| 14:39:38 | <wyclif> - i.e if we decide to allow user create terms when mapping concepts |
| 14:39:40 | <wyclif> - if we want to make term to term mappings bidirectional |
| 14:40:23 | <djazayeri> did you do a mockup of create-terms-while-mapping, or any visual aid? |
| 14:40:57 | <wyclif> nope |
| 14:41:52 | <bwolfe> wyclif, yes ,they should be able to create terms that way. I think that was decided long ago. BUT they should not be able to edit them that way I think. (am I remembering that right?) |
| 14:42:01 | <wyclif> but i honestly don't think it worth allowing this\ |
| 14:42:35 | <wyclif> according to burke, implemenations usually import dictionaries where these mapping really exist |
| 14:43:09 | <djazayeri> Well, I think that depends |
| 14:43:12 | <bwolfe> right, but its 100x more annoying to have to FIRST go to another page to make a term, then to map it |
| 14:43:24 | <djazayeri> maybe implementations will do that if we provide a tool for importing dictionaries |
| 14:43:41 | <wyclif> so spending extra time to add something that in most cases is already done for them might not be worth the effort |
| 14:43:53 | <wyclif> there a page for creating terms |
| 14:44:06 | <djazayeri> right now, though, PIH only maps to terminologies opportunistically (i.e. without importing the whole terminology) |
| 14:44:09 | <djazayeri> just as an example |
| 14:44:13 | <wyclif> it is like saying we want users to create concepts on the add obs form |
| 14:44:57 | <wyclif> well, then i will add it back |
| 14:45:06 | <bwolfe> no, not really. its more like the Manage Form / schema editing where we wanted Fields to be created at the same time as FormFields |
| 14:45:08 | <djazayeri> Can you please put a screenshot somewhere that we can look at? |
| 14:45:37 | <wyclif> for the concept form? |
| 14:45:51 | <djazayeri> yes, the place where this is happening |
| 14:46:18 | <djazayeri> The page we're talking about, I mean. |
| 14:46:35 | <wyclif> ok |
| 14:48:21 | <djazayeri> One option that springs to mind is how labeling emails works in gmail: you can apply an existing label without confirmation, but if you want to create a new label, you have to explicitly click on "add new label XYZ" button |
| 14:49:10 | *** lh_ has joined #openmrs |
| 14:49:30 | <wyclif> i have attached a screenshot on https://tickets.openmrs.org/browse/TRUNK-412 |
| 14:50:54 | *** lh_ is now known as lh |
| 14:51:25 | <wyclif> djazayeri, bwolfe i have attached the file to https://tickets.openmrs.org/browse/TRUNK-412 |
| 14:52:14 | <djazayeri> So, the scenario is that you have *already* chosen a source out of the dropdown, right? |
| 14:52:56 | <wyclif> correct! |
| 14:53:22 | <djazayeri> (As a side-note, I'd change "All Sources" to "(Search all sources)" |
| 14:53:29 | <wyclif> ok |
| 14:53:44 | <djazayeri> So, in that case I think it's okay to automatically add it |
| 14:54:07 | <djazayeri> You should also display in the flash message that you have done so. |
| 14:54:37 | <wyclif> i would have to break the code(name) cells and make them separate sothat the user enters both the name and code |
| 14:54:43 | <djazayeri> e.g. in addition to "Concept Saved" also say "Added term Xyz to Abc terminology" |
| 14:54:58 | <djazayeri> there's already a dropdown for the soure |
| 14:55:00 | <djazayeri> source |
| 14:55:12 | <wyclif> yes |
| 14:55:23 | <djazayeri> Oh, sorry, you're saying that the term table has both name and code columns? |
| 14:55:39 | <wyclif> i would have to change it to have both |
| 14:55:45 | <djazayeri> The database table |
| 14:55:48 | <wyclif> yes |
| 14:55:57 | <wyclif> and technically name and code are required |
| 14:56:15 | <wyclif> but in the old concept mappings name wasn't present\ |
| 14:56:20 | <djazayeri> Oh, in that case I would lean towards not allowing this automatically on this page. |
| 14:56:40 | <wyclif> so the existing mappings during upgrades will have to have name the same as the code |
| 14:56:44 | <djazayeri> Personally I think it's annoying that name will now be required |
| 14:56:55 | <djazayeri> ah... |
| 14:56:58 | <wyclif> i think i removed the constraint |
| 14:57:51 | <wyclif> but the suggestion was to make the code the name too |
| 14:59:00 | <djazayeri> For example, if I don't know much about mapping, and someone tells me that the snomed code for weight in kg is abc123, I'd just want to type that in |
| 14:59:09 | <djazayeri> I would have no idea what the name of that snomed term is |
| 14:59:36 | <djazayeri> I'm not sure what benefit we really get from duplicating the code as the name instead of just leaving the name blank. |
| 15:00:19 | <djazayeri> So, my personal preference would be to leave name non-required, and if you type in a new code (after having chosen a source) on the edit concept page, that creates a new term with code, but name=null |
| 15:00:37 | <djazayeri> (I'm not sure if there's a reason that's bad, though.) |
| 15:03:11 | <djazayeri> bwolfe: how does that sound to you? |
| 15:03:31 | <djazayeri> wyclif: do you remember who suggested that we duplicate code as name? |
| 15:04:07 | <wyclif> ben and i think burke |
| 15:04:43 | <wyclif> i think i would be fine with leaving the name blank |
| 15:06:11 | <djazayeri> bwolfe: you gone? |
| 15:06:33 | <djazayeri> wyclif: okay, anyway, you know what I'm proposing. Hopefully Ben gets back soon and we can get him to agree or disagree. |
| 15:06:41 | <djazayeri> about the bidirectional mappings... |
| 15:07:07 | <djazayeri> can you remind me what some of the map types are, for use between terms? |
| 15:07:26 | <wyclif> i think Burke had a good suggestion |
| 15:07:43 | <wyclif> there are 2 forms of mappings |
| 15:08:20 | <wyclif> concept to terms(mappings on the concept form) and then terms to terms(mappings on the reference term form) |
| 15:08:23 | *** rafa has quit IRC |
| 15:08:39 | <djazayeri> Right. |
| 15:08:55 | <wyclif> so my question is mainly about the latter |
| 15:08:58 | <djazayeri> So, I don't think the the first one of those is bidirectional |
| 15:09:03 | <wyclif> correct! |
| 15:09:22 | <djazayeri> And given that, it means we're going to have to have a-is-to-b types for both narrower-than and wider-than (for example) |
| 15:09:37 | <djazayeri> so I think it's better to have them be unidirectional, and force people to create both, for now. |
| 15:10:06 | <wyclif> Burke's suggestion is to add an service methods that returns 'incoming' mappings to a term |
| 15:10:54 | <wyclif> i.e it would be saying 'give me all mappings where am am not a but b' |
| 15:11:13 | <djazayeri> only for the term-to-term mappings though? |
| 15:11:29 | <djazayeri> concepts are always A, right? |
| 15:11:45 | <wyclif> yes, and then list out these on the reference term form as links to the actual terms that have own these mappings |
| 15:12:03 | <wyclif> it is terms |
| 15:12:17 | <wyclif> so both A and b are terms |
| 15:12:31 | <djazayeri> I mean that for concept mappings, the concept is A and the term is B |
| 15:12:39 | <wyclif> correct! |
| 15:12:40 | <djazayeri> for term-to-term mappings, there are A and B terms |
| 15:12:50 | <wyclif> yes |
| 15:13:20 | <djazayeri> So, I agree with burke that we should leave the mappings unidirectional, and have API methods for getting terms that are mapped to a term as A or B. |
| 15:14:14 | <wyclif> just to correct you, the service method shoudl be specific, it gets terms where 'this' term is in the b term |
| 15:14:45 | <wyclif> since already the terms as a collection property containings mappings where it is the A term |
| 15:15:03 | <djazayeri> fine |
| 15:15:07 | <wyclif> sorry! since already the term has |
| 15:15:24 | <wyclif> it sounds fine to me |
| 15:15:40 | <wyclif> so if ben agrees with these, then i can get these done today |
| 15:16:04 | <wyclif> and then i can put the branch into review |
| 15:16:54 | <djazayeri> So, I don't think you need to wait for Ben for the bidirectional thing |
| 15:17:04 | <djazayeri> I'll email him and you my proposal |
| 15:17:30 | <wyclif> ok |
| 15:17:42 | <wyclif> any suggestions for the service methods |
| 15:17:56 | <wyclif> am struggling with getting a proper name for it |
| 15:18:04 | <djazayeri> getTermsMappingToTerm(Term term)? |
| 15:18:10 | <wyclif> ok |
| 15:18:13 | *** gauravpaliwal has joined #openmrs |
| 15:18:13 | *** ChanServ sets mode: +v gauravpaliwal |
| 15:18:14 | <djazayeri> getTermsThatMapTo(Term term) |
| 15:18:27 | <wyclif> can you please copy roger, burke and andy to the emails |
| 15:19:56 | <wyclif> this methods returns the maps and not the terms, right |
| 15:20:02 | <wyclif> methos |
| 15:20:06 | <wyclif> method |
| 15:20:29 | <djazayeri> Yes, because you'd want to know the type, etc |
| 15:20:37 | <djazayeri> so maybe getMappingsTo(Term) |
| 15:21:05 | <wyclif> ok |
| 15:22:25 | <wyclif> thanks |
| 15:39:30 | <djazayeri> email sent |
| 15:51:49 | *** mario__ has joined #openmrs |
| 15:52:19 | *** lh has quit IRC |
| 15:52:37 | <mario__> Hi Darius |
| 15:53:05 | <gauravpaliwal> mario__: say Hi djazayeri |
| 15:54:21 | <mario__> Hi djazayeri |
| 16:02:06 | *** gauravpaliwal has left #openmrs |
| 16:15:53 | *** rafa has joined #openmrs |
| 16:15:53 | *** ChanServ sets mode: +v rafa |
| 16:19:13 | *** lh has joined #openmrs |
| 16:29:53 | *** sunbiz has quit IRC |
| 16:33:19 | <mario__> Hola djazayeri |
| 16:53:49 | *** rafa has quit IRC |
| 17:04:43 | *** wyclif has quit IRC |
| 17:17:07 | *** mario__ has quit IRC |
| 17:55:49 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Less than 2 weeks to register for the next #OpenMRS conference in #Rwanda at early bird rate! http://t.co/QjX4vLL #ICT4D #HealthIT <http://twitter.com/OpenMRS/statuses/108558774482108416> || OpenMRS Modules: Form Entry 4.5.9.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=formentry&version=&4.5.9.3> |
| 17:58:02 | *** wyclif has joined #openmrs |
| 18:01:27 | *** wyclif has joined #openmrs |
| 18:14:59 | *** Suranga has joined #openmrs |
| 18:28:41 | *** sunbiz has joined #openmrs |
| 18:28:41 | *** ChanServ sets mode: +v sunbiz |
| 18:43:42 | *** bryq1 has joined #openmrs |
| 18:45:40 | *** bryq has quit IRC |
| 18:57:02 | *** jriley has joined #openmrs |
| 19:01:54 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @askanter: I am presenting Millennium Villages Global Network and #OpenMRS at VLDB conference in Seattle today at 4PM: http://t.co/jS ... <http://twitter.com/OpenMRS/statuses/108600148548001792> |
| 19:09:23 | *** sunbiz has quit IRC |
| 19:10:11 | *** Gretchie has quit IRC |
| 19:14:10 | *** rafa has joined #openmrs |
| 19:14:10 | *** ChanServ sets mode: +v rafa |
| 19:20:17 | *** bryq1 has quit IRC |
| 19:22:28 | <Suranga> djazayeri, helloo |
| 19:25:24 | *** gbastien has quit IRC |
| 19:36:34 | <wyclif> hi djazayeri |
| 19:37:00 | <wyclif> djazayeri, did you get my response to your email? |
| 19:46:31 | *** gbastien has joined #openmrs |
| 19:46:41 | *** Suranga has quit IRC |
| 20:08:16 | *** Gretchie has joined #openmrs |
| 20:10:41 | *** rafa has quit IRC |
| 20:37:59 | <wyclif> hi djazayeri |
| 20:38:06 | <wyclif> are you getting my emails |
| 20:38:20 | <djazayeri> not really |
| 20:38:23 | <wyclif> in response to the mappings discussion |
| 20:38:23 | <djazayeri> doesn't seem like it |
| 20:38:26 | <djazayeri> in a meeting now |
| 20:38:27 | <wyclif> i wonder why |
| 20:38:36 | <djazayeri> got one from you at some point, but not recently |
| 20:40:18 | <wyclif> djazayeri, did you get the one where is suggested we use a global property |
| 20:41:48 | <wyclif> djazayeri, ? |
| 20:43:29 | <wyclif> djazayeri, ? |
| 20:44:51 | *** jprice has joined #openmrs |
| 20:45:46 | <jprice> does anyone know if openMRS sends an HL7 ack back when it receives and HL7 msg ? |
| 20:47:49 | <wyclif> jprice, no |
| 20:48:06 | <djazayeri> wyclif: yes, i got that. i agree with it |
| 20:48:10 | <djazayeri> did you get my reply email? |
| 20:48:12 | <wyclif> ok |
| 20:48:20 | <djazayeri> from my phone, where I said I agree with using a gp |
| 20:48:28 | <wyclif> djazayeri, am getting delivery failure emails |
| 20:49:26 | <jprice> thanks |
| 20:51:57 | <wyclif> djazayeri, i assumed that all concept mappings are technically pointing to codes in a given source and the source is the one that knows which concept is represented by that code, meaning a map can not exist without a code |
| 20:52:05 | <wyclif> wonder what andy meant by no code |
| 20:52:41 | <wyclif> since he said a code should not be required\ |
| 21:10:12 | *** djazayeri has quit IRC |
| 21:19:03 | *** Gretchie has quit IRC |
| 21:56:05 | *** jriley has left #openmrs |
| 22:43:33 | *** bwolfe has quit IRC |
| 22:44:09 | *** gbastien has quit IRC |
| 22:45:04 | *** wyclif has quit IRC |
| 22:54:13 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Announcements List: Reminder: New OpenMRS Weekly Call Schedule Starts this Week <https://listserv.iupui.edu/cgi-bin/wa-iupui.exe?A2=ind1108&L=openmrs-announce-l&P=2257> |
| 22:54:19 | *** gbastien has joined #openmrs |
| 23:03:19 | *** gbastien has quit IRC |
| 23:05:20 | *** gbastien has joined #openmrs |
| 23:24:26 | *** lh has quit IRC |
| 23:34:49 | *** wyclif has joined #openmrs |
| 23:54:28 | *** Gretchie has joined #openmrs |