00:09:36
|
*** gbastien has quit IRC
|
00:19:55
|
*** Suranga has joined #openmrs
|
00:21:38
|
*** Suranga has quit IRC
|
00:39:57
|
*** jportela has left #openmrs
|
00:43:33
|
*** djazayeri has quit IRC
|
01:12:01
|
*** muthah has quit IRC
|
01:18:14
|
*** muthah has joined #openmrs
|
01:22:12
|
*** wyclif has joined #openmrs
|
01:24:47
|
*** muthah has quit IRC
|
01:27:10
|
*** gbastien has joined #openmrs
|
01:30:57
|
*** muthah has joined #openmrs
|
01:38:36
|
*** burke has joined #openmrs
|
01:38:36
|
*** ChanServ sets mode: +o burke
|
02:21:42
|
*** downeym has joined #openmrs
|
02:21:42
|
*** ChanServ sets mode: +o downeym
|
02:21:42
|
*** OpenMRSBot sets mode: +o downeym
|
02:22:03
|
*** downeym has left #openmrs
|
02:31:24
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.7.x): Arden parser using LogicService to evaluate rules instead of LogicContext - TRUNK-2587... <http://feedproxy.google.com/~r/OMRStrunk/~3/xxkuuB9QoVc/OpenMRS> || New Changeset: OpenMRS (trunk): The fieldGen for String should support an options the displays a textarea instead of a text field - TRUNK-2485... <http://feedproxy.google.com/~r/OMRStrunk/~3/iIv5HERrBk4/OpenMRS>
|
02:33:10
|
*** gbastien has quit IRC
|
02:53:29
|
*** upul` has joined #openmrs
|
02:53:29
|
*** ChanServ sets mode: +v upul`
|
03:00:50
|
<upul`> hey burke
|
03:01:56
|
*** muthah has quit IRC
|
03:53:25
|
*** burke has quit IRC
|
03:53:28
|
*** djazayeri has joined #openmrs
|
03:53:28
|
*** ChanServ sets mode: +o djazayeri
|
04:19:34
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @ScottMuc: It's @OpenMRS code jam time! <http://twitter.com/OpenMRS/statuses/106190920189353984>
|
04:32:05
|
*** surangak has joined #openmrs
|
06:28:26
|
*** dkayiwa has joined #openmrs
|
06:33:01
|
*** bryq has joined #openmrs
|
06:33:01
|
*** ChanServ sets mode: +v bryq
|
06:40:28
|
*** pascal` has joined #openmrs
|
06:40:41
|
*** rafa has joined #openmrs
|
06:40:41
|
*** ChanServ sets mode: +v rafa
|
06:46:39
|
*** pascal` has quit IRC
|
06:53:04
|
*** pascal` has joined #openmrs
|
07:55:14
|
<rafa> hi bwolfe
|
08:06:38
|
*** bryq has quit IRC
|
08:20:00
|
*** bryq has joined #openmrs
|
08:20:00
|
*** ChanServ sets mode: +v bryq
|
08:26:55
|
<dkayiwa> morning bwolfe
|
08:27:34
|
<dkayiwa> bwolfe: do you receive notification mails on build failures from the sprint providers CI ?
|
08:35:19
|
<surangak> dkayiwa, i dont think Bens here
|
08:35:37
|
<dkayiwa> ohhhh
|
08:35:44
|
<surangak> dkayiwa, he was online since very early today too.....
|
08:35:49
|
<dkayiwa> oh i see
|
08:36:04
|
<dkayiwa> thanks surangak :D
|
08:36:09
|
<dkayiwa> how is your today?
|
08:36:23
|
<surangak> dkayiwa, Im famous !
|
08:36:28
|
<dkayiwa> lollllllllllllll
|
08:36:36
|
<dkayiwa> thats so so nice!!! :)
|
08:36:46
|
<surangak> dkayiwa, no really, check out http://fossuser.lk/en/archive/july_2011.pdf
|
08:36:48
|
<surangak> page 12
|
08:36:55
|
<dkayiwa> let me check :)
|
08:36:56
|
<surangak> my first interview :)
|
08:37:28
|
<rafa> hi guys
|
08:37:34
|
<rafa> do you use JRebel?
|
08:37:42
|
<dkayiwa> hey. not me :)
|
08:37:56
|
<surangak> rafa, not really.. but i was thinking of taking it up
|
08:38:09
|
<surangak> rafa, i dont think lot of ppl r using it :(
|
08:38:42
|
<rafa> surangak: I'm using it. It's great. :D It's just that I can't force it to work with modules.
|
08:39:02
|
<dkayiwa> lol :)
|
08:39:04
|
<rafa> surangak: OpenMRS core works perfect with almost no configuration needed
|
08:40:03
|
<surangak> rafa, you've given yourself away ! now that i know you're using it, ill be asking you all the questions on how to start using it :)
|
08:40:20
|
*** gauravpaliwal has joined #openmrs
|
08:40:20
|
*** ChanServ sets mode: +v gauravpaliwal
|
08:40:43
|
<rafa> surangak: sure thing. maybe you'll have more luck with modules :D
|
08:41:14
|
<dkayiwa> lollllllllllll
|
08:41:33
|
<dkayiwa> surangak: is it the page that has Fernando?
|
08:41:44
|
<surangak> dkayiwa, page number 12
|
08:41:59
|
<surangak> dkayiwa, oh, i forgot, its in our native langvage ;-(
|
08:42:05
|
<surangak> but theres a great pic of me :)
|
08:42:15
|
<dkayiwa> yes i saw strange characters
|
08:42:16
|
<dkayiwa> :)
|
08:42:32
|
<dkayiwa> surangak: on which page is your pic?
|
08:42:38
|
<surangak> page 10
|
08:42:51
|
<surangak> dkayiwa,
|
08:42:51
|
<surangak> 2011 July - 1
|
08:42:55
|
<surangak> sorry
|
08:42:56
|
<surangak> 2011 July - 10
|
08:43:17
|
<dkayiwa> page 8?
|
08:43:43
|
<bwolfe> dkayiwa, I have not received any emails on providers yet. its set to only email those that have committed to it
|
08:43:48
|
<bwolfe> are you not getting them?
|
08:43:48
|
<surangak> page 10
|
08:44:08
|
<dkayiwa> surangak: why did you encrypt that very page? :D
|
08:44:20
|
<bwolfe> rafa, theres a wiki page about getting it to work with modules I think
|
08:44:21
|
<dkayiwa> bwolfe: oh i see!!! thanks
|
08:44:27
|
<bwolfe> (it == jrebel)
|
08:44:35
|
<surangak> dkayiwa, ohh.... but the pic is there right ?
|
08:44:38
|
<bwolfe> or maybe its in the module pom.xml file commented out
|
08:45:03
|
<bwolfe> surangak, be sure to follow the wiki page about jrebel first. and if its not helpful then you go to rafa and you both update the wiki page. :-)
|
08:45:17
|
<dkayiwa> surangak: why didn't you encrypt the pic too?
|
08:45:19
|
<dkayiwa> :)
|
08:45:28
|
*** pascal` has quit IRC
|
08:45:44
|
<surangak> bwolfe, sure... will do.. I didnt know you were here Ben
|
08:45:58
|
<surangak> dkayiwa, its a great pic.. too bad i didnt put my e mail too
|
08:46:03
|
<dkayiwa> surangak: he could have just come back :)
|
08:46:06
|
<bwolfe> just sat down
|
08:46:09
|
<bwolfe> I was torrenting last night, so I left my laptop on
|
08:46:19
|
<dkayiwa> lolllllllllll
|
08:46:38
|
<surangak> bwolfe, you too ? I didnt know that Directors used torrent :-)
|
08:46:48
|
<dkayiwa> hhahahahha
|
08:47:03
|
<dkayiwa> then do when in Kenya :)
|
08:47:06
|
<dkayiwa> they
|
08:48:25
|
<bwolfe> I use it when in the States too
|
08:48:40
|
<dkayiwa> hahahah
|
09:01:22
|
<rafa> bwolfe: is it possible to download the latest build from CI?
|
09:02:09
|
<bwolfe> only if its being saved in the artifacts of the build
|
09:02:12
|
<bwolfe> which I don't think it is
|
09:02:48
|
<bwolfe> I only have it saving the test results
|
09:03:13
|
<rafa> bwolfe: I see.
|
09:03:53
|
<dkayiwa> rafa: just having an inquisitive mind :) Why do you wanna get the one from CI?
|
09:05:42
|
<rafa> dkayiwa: I'm a lazy guy trying to find a way not to update and build every time I need 1.6.x or 1.7.x or whatever ;)
|
09:06:54
|
<dkayiwa> oh i see!!! Was reading a book and it said laziness is a good attribute for software developers. It lead to automation :D
|
09:08:28
|
<rafa> dkayiwa: so true :D
|
09:08:37
|
<rafa> dkayiwa: what was the title of that book?
|
09:09:03
|
<dkayiwa> if i remember correctly, it could be "CODE COMPLETE" :)
|
09:09:09
|
<rafa> dkayiwa: I'm always looking for anything worth reading :)
|
09:09:32
|
<dkayiwa> lollll when you go to the US, you will get more than your brain can take up :D
|
09:09:48
|
<bwolfe> he's too lazy to go look it up
|
09:10:10
|
<dkayiwa> hahahahahahaha. now that has not yet got automation :D
|
09:17:47
|
*** pascal` has joined #openmrs
|
09:23:40
|
*** pascal` has quit IRC
|
09:27:55
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): Making patientEncounters portlet display multiple providers - TRUNK-2263 <http://feedproxy.google.com/~r/OMRStrunk/~3/5Ka2LXHDoHw/OpenMRS>
|
09:38:27
|
*** pascal` has joined #openmrs
|
09:53:19
|
*** pascal` has quit IRC
|
09:59:26
|
*** surangak_ has joined #openmrs
|
09:59:26
|
*** surangak has quit IRC
|
10:09:59
|
*** pascal` has joined #openmrs
|
10:12:41
|
*** dkayiwa_ has joined #openmrs
|
10:12:47
|
*** pascal` has joined #openmrs
|
10:13:57
|
*** dkayiwa has quit IRC
|
10:13:57
|
*** dkayiwa_ is now known as dkayiwa
|
10:19:05
|
*** bwolfe has quit IRC
|
10:31:24
|
*** bwolfe has joined #openmrs
|
10:31:24
|
*** ChanServ sets mode: +o bwolfe
|
10:36:01
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): TRUNK-2394: Can we use the search widget to "list all items" too? ... <http://feedproxy.google.com/~r/OMRStrunk/~3/JZ5a_cpmtuc/OpenMRS>
|
10:40:02
|
*** gauravpaliwal has left #openmrs
|
10:40:04
|
*** pascal` has quit IRC
|
10:49:21
|
<bwolfe> rafa, dkayiwa, can you quickly just try to deploy your trunk copies to see if it works? mine isn't and I want to know what perhaps what revision to start hunting for the cause in
|
10:49:42
|
<bwolfe> (and send me what revision you are currently on... svn info at command line)
|
10:50:08
|
<dkayiwa> bwolfe: should we start by updating
|
10:50:09
|
<rafa> bwolfe: I switched to providers branch.
|
10:50:18
|
<bwolfe> no, don't update
|
10:50:24
|
<dkayiwa> ok
|
10:50:27
|
<bwolfe> rafa, you don't keep multiple copies checked out?
|
10:51:18
|
<rafa> bwolfe: I keep only mavenized and non mavenized checked out
|
10:51:28
|
<bwolfe> boo
|
10:51:50
|
<bwolfe> I have trunk, 1.8, 1.7, 1.6, 1.5, approx 23 modules, and a few branches from the recent sprints. :-)
|
10:51:51
|
<rafa> sorry
|
10:52:04
|
<rafa> lol
|
10:52:07
|
<bwolfe> most are closed so that they don't slow down my eclipse
|
10:52:57
|
<rafa> I've got broadband :D
|
10:52:59
|
<dkayiwa> so bwolfe: i should start by doing an mvn install on my already checked out trunk. and then deploy the war?
|
10:55:04
|
<bwolfe> dkayiwa, one sec
|
10:55:10
|
<dkayiwa> ok
|
10:55:11
|
<bwolfe> you reminded me that I'm an idiot
|
10:55:18
|
<bwolfe> I was doing an mvn package
|
10:55:24
|
<dkayiwa> oh!!!
|
10:55:25
|
<bwolfe> and perhaps my api/web jars are just mismatched
|
10:55:51
|
<dkayiwa> then we are all idiots. for we all keep doing the same atleast once in a while
|
10:56:02
|
<bwolfe> argh, yes, working now. thanks dkayiwa!
|
10:56:08
|
<dkayiwa> lollllllllll
|
10:56:10
|
<bwolfe> rafa, no thanks to you! ;-)
|
10:58:44
|
<rafa> bwolfe: you're welcome anyway :P
|
11:00:28
|
*** surangak_ has quit IRC
|
11:22:04
|
*** james_regen has joined #openmrs
|
11:22:04
|
*** ChanServ sets mode: +v james_regen
|
11:27:18
|
*** upul` has quit IRC
|
11:52:50
|
*** pascal` has joined #openmrs
|
12:05:33
|
*** pascal` has quit IRC
|
12:08:22
|
*** pascal` has joined #openmrs
|
12:20:08
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): TRUNK-2566: When you first open the Manage Providers page the search widget should auto-fetch the first page of results ... <http://feedproxy.google.com/~r/OMRStrunk/~3/Hk6M_ynLUvw/OpenMRS> || New Changeset: OpenMRS (providers): TRUNK-2394: Can we use the search widget to "list all items" too? ... <http://feedproxy.google.com/~r/OMRStrunk/~3/cODWnk6fC44/OpenMRS>
|
12:22:18
|
*** jriley has joined #openmrs
|
12:32:13
|
*** wyclif has quit IRC
|
12:47:00
|
*** burke has joined #openmrs
|
12:47:00
|
*** ChanServ sets mode: +o burke
|
12:51:33
|
<dkayiwa> bwolfe: when editing an encounter and you add a new provider to the encounter, do you just select the new provider name or also the encounter role?
|
12:52:20
|
<bwolfe> You probably will need to select both
|
12:52:21
|
*** pascal` has quit IRC
|
12:52:26
|
<dkayiwa> ok
|
12:52:26
|
<bwolfe> so the ui will need to change
|
12:52:33
|
<dkayiwa> ok
|
12:52:41
|
<bwolfe> perhaps something like concept names or concept mappings where you can add new rows
|
12:52:53
|
<bwolfe> and in that you have a dropdown for the role and a box for the name search
|
12:52:55
|
<dkayiwa> ok
|
12:53:02
|
<dkayiwa> ok
|
12:53:17
|
<dkayiwa> thanks for the tips
|
13:10:15
|
*** dkayiwa_ has joined #openmrs
|
13:10:50
|
*** dkayiwa has quit IRC
|
13:10:50
|
*** dkayiwa_ is now known as dkayiwa
|
13:17:03
|
*** gbastien has joined #openmrs
|
13:26:14
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Validate patient name in create form with regular expression property - TRUNK-338... <http://feedproxy.google.com/~r/OMRStrunk/~3/9CE1aIf4tlo/OpenMRS>
|
13:51:09
|
*** wyclif has joined #openmrs
|
13:53:50
|
*** downeym has joined #openmrs
|
13:53:50
|
*** OpenMRSBot sets mode: +o downeym
|
13:53:50
|
*** ChanServ sets mode: +o downeym
|
13:54:12
|
<jriley> Hello, downeym, and welcome to #Openmrs!
|
13:54:36
|
<downeym> Hi jriley and welcome to the #openmrs IRC channel.
|
13:54:39
|
<downeym> :)
|
13:58:26
|
*** dkayiwa has quit IRC
|
13:58:35
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Metadata Sharing 0.10 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=metadatasharing&version=&0.10>
|
13:59:33
|
*** dkayiwa has joined #openmrs
|
14:04:41
|
*** burke has quit IRC
|
14:05:05
|
<bwolfe> djazayeri, ever feel like you're talking to yourself?
|
14:05:14
|
<djazayeri> all the time
|
14:05:35
|
<bwolfe> sad
|
14:05:56
|
<djazayeri> bwolfe, rafa, dkayiwa, wyclif: scrum time
|
14:06:19
|
<bwolfe> scrum it
|
14:06:46
|
<bwolfe> <michaeljackson>just scrum it.....</michaeljackson>
|
14:07:00
|
<dkayiwa> :D
|
14:07:08
|
<downeym> heh
|
14:07:27
|
<dkayiwa> dj benjamin :)
|
14:09:24
|
<djazayeri> I'll go first
|
14:09:54
|
<wyclif> hi
|
14:09:55
|
<djazayeri> Tuesday:
|
14:09:55
|
<djazayeri> * Finished TRUNK-2575 (UI for Location Attributes & refactor Visit Attributes to share code)
|
14:09:56
|
<djazayeri> * helped Mario with openers:format and concept name types
|
14:09:56
|
<djazayeri> * helped James investigate a Logic + HTML Form Entry bug
|
14:09:56
|
<djazayeri> * code review
|
14:09:56
|
<djazayeri> * committed TRUNK-2587 for Mario
|
14:09:56
|
<djazayeri> * committed TRUNK-2587 for Steve
|
14:09:57
|
<djazayeri> * Thoughtworks Code Jam. Got people working on: moving @Transactional to hibernate layer, proof-of-concept of Mockito, spike on Solr
|
14:09:58
|
<djazayeri> Today
|
14:09:58
|
<djazayeri> * Design calls
|
14:09:59
|
<djazayeri> * Plan for next sprint
|
14:09:59
|
<djazayeri> * Code Review
|
14:10:00
|
<djazayeri> * Maybe a sprint ticket
|
14:10:38
|
<bwolfe> you're welcome. you will all now have "Thriller" in your head for the rest of the day. :-D
|
14:10:53
|
<rafa> djazayeri: Is there a ticket for @Transactional thing?
|
14:10:57
|
<bwolfe> djazayeri, any progress on solr spike yet?
|
14:11:06
|
<bwolfe> silly rafa, theres a ticket for everything!
|
14:11:08
|
<bwolfe> (or should be)
|
14:11:21
|
<rafa> djazayeri: yeah, I'm asking for the # :)
|
14:11:41
|
<djazayeri> !ticket trunk-208
|
14:11:42
|
<OpenMRSBot> djazayeri: [#TRUNK-208] Fix Transactions Across Service Methods - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-208
|
14:11:54
|
<rafa> thx
|
14:12:49
|
<djazayeri> no blockers for me
|
14:13:02
|
<bwolfe> ok
|
14:13:05
|
<bwolfe> today:
|
14:13:05
|
<bwolfe> cleaned up smart tickets
|
14:13:05
|
<bwolfe> finished a few pending smart reviews
|
14:13:05
|
<bwolfe> SMART-21, in-app documentation
|
14:13:05
|
<bwolfe> a few trunk reviews
|
14:13:07
|
<bwolfe> design calls
|
14:13:09
|
<bwolfe> applied a few trunk tickets I've had sitting around for a while: TRUNK-338, TRUNK-368
|
14:13:11
|
<bwolfe> (very minor amount of) sync debugging
|
14:13:13
|
<bwolfe> tomorrow:
|
14:13:15
|
<bwolfe> smart reviews, sync ticket review
|
14:14:01
|
<djazayeri> bwolfe: no real progress on solr yet, AFAIK. (I had to leave early, but they were really just getting the whole environment set up.)
|
14:16:22
|
<bwolfe> and no patch/commit by this morning?! sheesh
|
14:16:54
|
<djazayeri> Okayâ¦who's next?
|
14:17:04
|
<dkayiwa> Did some code reviews
|
14:17:04
|
<dkayiwa> Been working on: Edit Encounter page should support multiple providers - TRUNK-2262. Done with displaying the multiple providers. Now finishing the saving and delete
|
14:17:04
|
<dkayiwa> Design Call
|
14:17:04
|
<dkayiwa> No Blockers
|
14:18:40
|
<djazayeri> cool
|
14:18:42
|
<bwolfe> !ticket TRUNK-2262
|
14:18:43
|
<OpenMRSBot> bwolfe: [#TRUNK-2262] Edit Encounter page should support multiple providers - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2262
|
14:18:53
|
<djazayeri> is your code review queue cleared out?
|
14:19:40
|
<djazayeri> dkayiwa: ^^
|
14:19:50
|
<dkayiwa> oh :)
|
14:19:56
|
<dkayiwa> checking....
|
14:20:44
|
<djazayeri> mine isn't, just asking. :-)
|
14:21:04
|
<djazayeri> wyclif?
|
14:21:37
|
<wyclif> yesterday:
|
14:21:37
|
<wyclif> - Code review for SMART-22
|
14:21:37
|
<wyclif> - Completed SMART-11, allergy exceptions
|
14:21:37
|
<wyclif> - started on SMART-25, Change how user apps are managed
|
14:21:38
|
<wyclif> today:
|
14:21:38
|
<wyclif> - complete smart-25
|
14:21:40
|
<wyclif> - work on smart-26, Allow users to hide smart apps from the dashboard
|
14:21:42
|
<wyclif> - code reviews
|
14:22:26
|
<bwolfe> how close are you on 25 wyclif?
|
14:23:42
|
*** dkayiwa has quit IRC
|
14:24:00
|
<wyclif> i have only worked on the under the hood changes
|
14:24:21
|
<wyclif> no UI changes yet
|
14:24:48
|
<bwolfe> ok. I was looking for a number. 25%?
|
14:25:24
|
<wyclif> about 40%
|
14:25:37
|
<bwolfe> cool
|
14:25:43
|
<bwolfe> blockers wyclif?
|
14:26:42
|
<wyclif> no blockers
|
14:27:03
|
<djazayeri> okay
|
14:27:05
|
*** bryq has left #openmrs
|
14:27:07
|
<djazayeri> rafa?
|
14:27:14
|
<rafa> *** Rafal ***
|
14:27:14
|
<rafa> Today:
|
14:27:14
|
<rafa> * Corrected TRUNK-2394: Can we use the search widget to "list all items" too?
|
14:27:14
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2394
|
14:27:14
|
<rafa> * Did TRUNK-2566: When you first open the Manage Providers page the search widget should auto-fetch the first page of results and display them.
|
14:27:15
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2566
|
14:27:15
|
<rafa> * Started with TRUNK-2521: Multiple Program Workflow States with same start date
|
14:27:16
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2521
|
14:27:16
|
<rafa> * Code-reviews
|
14:27:17
|
<rafa> * MDS 0.10 release of Piotr's work
|
14:27:17
|
<rafa> Tomorrow:
|
14:27:18
|
<rafa> * Continue with TRUNK-2521
|
14:27:18
|
<rafa> * Likely pick up a new ticket, but not sure which. Resist to pick up TRUNK-2328 (got no clever idea for the UI improvement, not too much time left).
|
14:27:19
|
<rafa> Blocker:
|
14:27:19
|
<rafa> What do we do with TRUNK-2261: Liquibase script to migrate legacy Encounter.provider data to Encounter.providers
|
14:27:20
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-2261?
|
14:27:50
|
<bwolfe> !ticket TRUNK-2521
|
14:27:51
|
<OpenMRSBot> bwolfe: [#TRUNK-2521] Multiple Program Workflow States with same start date - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2521
|
14:27:59
|
<bwolfe> !ticket TRUNK-2328
|
14:28:00
|
<OpenMRSBot> bwolfe: [#TRUNK-2328] Improve layout of admin page - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2328
|
14:29:01
|
<djazayeri> rafa: TRUNK-438 would be very similar to re-doing what you did in the last 2.x sprint, but in 1.x...
|
14:29:28
|
<djazayeri> regarding TRUNK-2261, you're rightâchangesets always run in order
|
14:29:53
|
<djazayeri> and the purpose of the precondition is if you delete the liquibasechangelog table, it can be rebuilt
|
14:30:30
|
<djazayeri> so offhand I think the precondition for _both_ changesets should be that columnExists(encounter.provider)
|
14:31:40
|
<djazayeri> I think it's still worth breaking into two changesets though.
|
14:31:54
|
<rafa> it's not ideal, but okay if you want two changesets
|
14:32:03
|
<djazayeri> bwolfe: your input welcome
|
14:32:20
|
<bwolfe> this is the same one in the review?
|
14:32:24
|
<djazayeri> Yes
|
14:32:35
|
* bwolfe looks again
|
14:32:58
|
<djazayeri> Executive Summary: rafal wrote a changeset that does "select into" to migrate all data from encounter.provider to the new encounter_provider table, and then drop the encounter.provider column
|
14:33:19
|
<djazayeri> I asked him to break that into two changesets. But it's not clear what the precondition on the first one (i.e. the select into) should be
|
14:34:10
|
*** dkayiwa has joined #openmrs
|
14:35:08
|
<rafa> djazayeri: I take TRUNK-438. It's nice.
|
14:36:09
|
<bwolfe> !ticket TRUNK-438
|
14:36:11
|
<OpenMRSBot> bwolfe: [#TRUNK-438] Add a "Settings" page and Rename Manage Global Properties page - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-438
|
14:36:50
|
<djazayeri> actually, it was wyclif who did that ticket in the 2.x sprint, wasn't it
|
14:36:57
|
<wyclif> yes
|
14:37:25
|
<bwolfe> djazayeri, so you're suggesting splitting each "insert into" into their own?
|
14:37:34
|
<djazayeri> no, there's only one insert into
|
14:37:44
|
<rafa> no there are two :)
|
14:37:45
|
<djazayeri> I mean that "insert into" and "drop column" should be two changesets
|
14:38:13
|
<rafa> first inserts into provider and second into encounter_provider
|
14:38:13
|
<bwolfe> as they are now... ?
|
14:38:16
|
<djazayeri> Sorry, I mean the "select into" and the "drop column"
|
14:38:39
|
<djazayeri> right, so the question is: what's the right precondition for the select into encounter_provider changeset?
|
14:39:19
|
<bwolfe> if you don't have a MARK_RAN on the first one, then any failure will result in the "drop column" not being run
|
14:39:44
|
<bwolfe> what you REALLY want to avoid is dropping someone's column before actually migrating data
|
14:39:53
|
<djazayeri> Agreed.
|
14:40:07
|
<djazayeri> So, switch it to onFail="HALT" (or whatever)?
|
14:40:19
|
<bwolfe> or just leave off the onFail attribute
|
14:41:08
|
<bwolfe> ok, I;m being accosted by kids
|
14:41:09
|
<djazayeri> But that means that if you drop the liquibasechangelog table and restart, it will always halt
|
14:41:13
|
<bwolfe> I'll be back on later
|
14:41:17
|
<djazayeri> that's not right
|
14:41:29
|
<djazayeri> (It _is_ right that you're accosted by kids.)
|
14:41:32
|
<djazayeri> ttyl
|
14:41:40
|
<rafa> :)
|
14:42:03
|
<djazayeri> rafa: I still think you should use the same columnExists precondition for both
|
14:42:32
|
<rafa> djazayeri: I still not necessarily agree ;)
|
14:43:07
|
<rafa> djazayeri: it's safer to have just one changeset
|
14:43:18
|
<bwolfe> back for a sec
|
14:43:21
|
<bwolfe> no, two is better
|
14:43:29
|
<djazayeri> What's safer about it? liquibase doesn't do them atomically.
|
14:43:29
|
<bwolfe> otherwise you might import the data twice
|
14:43:44
|
<bwolfe> now I'm gone again
|
14:43:58
|
<djazayeri> If bwolfe is fine with having one changeset, then I'm okay with it too.
|
14:44:08
|
<djazayeri> He's the one who's always pushing for splitting them. :-)
|
14:44:45
|
<rafa> from what is in docs for liquibase changsets are run in transactions
|
14:44:59
|
<djazayeri> hmm, okay, maybe that's changed since an earlier liquibase
|
14:45:06
|
<djazayeri> rafa: fine, go back to one changeset
|
14:45:19
|
<djazayeri> if nobody has any problem with this during alpha/beta testing, then we don't touch it.
|
14:46:43
|
<djazayeri> so, is that everyone?
|
14:47:31
|
<rafa> djazayeri: I'll test if they are run in a single transaction. It's easy.
|
14:48:05
|
<rafa> Anything that fails after inserts should cause inserts to be rollbacked
|
14:49:09
|
<djazayeri> Okay. (I don't actually see a need to test that. If liquibase says it does them in transactions, and we just upgraded to the newest liquibase, we'll trust them.)
|
14:52:45
|
<wyclif> bwolfe, for the changesets, i just edited the existing ones since this module has never been releases
|
14:53:19
|
<wyclif> instead creating new changesets to overwite the earlier ones
|
14:53:29
|
<rafa> djazayeri: For TRUNK-438 do I need to just copy from UI 2.x what wyclif did?
|
14:53:57
|
<wyclif> djazayeri, so you will have to drop your tables and i will let aja know too
|
14:54:00
|
<djazayeri> rafa: you could. but don't knock yourself out trying to replicate it exactly
|
14:54:15
|
<djazayeri> wyclif: okay, I haven't run the smart module at all
|
14:54:43
|
<rafa> djazayeri: cool.
|
14:54:51
|
<wyclif> djazayeri, sorry, it was supposed to be bwolfe
|
14:56:01
|
<djazayeri> I knowâour names are close. ;-)
|
15:03:51
|
*** gbastien has quit IRC
|
15:09:13
|
<dkayiwa> djazayeri: sorry i got disconnected
|
15:11:23
|
<dkayiwa> djazayeri: my queue has 3, but i think realistically 2 because this looks like was abundoned: https://source.openmrs.org/cru/CR-TRUNK-98
|
15:12:03
|
<djazayeri> gotcha
|
15:23:45
|
*** bryq has joined #openmrs
|
15:23:45
|
*** ChanServ sets mode: +v bryq
|
15:24:14
|
<bryq> rafa, djazayeri: Hi, I've just pre-recorded the presentation :)
|
15:24:53
|
<bryq> rafa, djazayeri: It isn't perfect, but I should start uploading it ASAP
|
15:25:25
|
<rafa> bryq: awesome!
|
15:25:31
|
<djazayeri> Excellent
|
15:25:37
|
<djazayeri> do we have an upload site?
|
15:25:41
|
<djazayeri> (how big is it?)
|
15:26:03
|
<bryq> It's rendering now, I'll know in coulpe minutes
|
15:26:56
|
<downeym> bryq: i'll send you a link
|
15:26:59
|
<bryq> But it shouldn't be so big, because I selected to optimize it for web
|
15:27:19
|
<downeym> bryq: can you messages me with your e-mail address?
|
15:27:24
|
<bryq> downeym: Thanks
|
15:27:27
|
<bryq> downeym: Okay
|
15:28:51
|
<downeym> bryq: link on the way to you
|
15:30:00
|
<bryq> downeym: I'll start upload when rendering will be done (it's 70%)
|
15:31:15
|
<downeym> bryq: cool, let me know when you're done uploading to slashtmp and move it to youtube :)
|
15:34:23
|
*** dkayiwa has quit IRC
|
15:36:34
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @codeforhealth We'd love to figure out a way to help out. DM to set up a time to talk? <http://twitter.com/OpenMRS/statuses/106385442492006400> || On Twitter: OpenMRS: RT @askanter: MVP looking for a Python programmer with #RapidSMS/#OpenMRS experience for placement in Africa: http://t.co/Jpi6Qtd Ask me ... <http://twitter.com/OpenMRS/statuses/106380132859641857>
|
15:49:39
|
*** goutham has joined #openmrs
|
15:53:42
|
*** gbastien has joined #openmrs
|
16:05:17
|
*** bryq has left #openmrs
|
16:13:58
|
*** goutham has quit IRC
|
16:22:25
|
*** bryq has joined #openmrs
|
16:22:25
|
*** ChanServ sets mode: +v bryq
|
16:25:23
|
<bryq> downeym: I'm rendering the presentation one more time, because the program I'm working with has some stiupid default options which caused that screen zoomed randomly. I changed the zoomings to show details and will render in a little bit higher dimension. It should be uploaded in 1-2 hours
|
16:26:38
|
*** dkayiwa has joined #openmrs
|
16:30:22
|
*** dkayiwa has quit IRC
|
16:32:51
|
*** Suranga has joined #openmrs
|
16:47:14
|
*** dkayiwa has joined #openmrs
|
16:52:23
|
*** rafa has quit IRC
|
17:02:26
|
<jriley> Is PatientService.savePatient() an all-or-nothing save when I create a new patient? If I added a ConceptName that was invalid somehow, would the Patient be created?
|
17:03:12
|
<jriley> Is the patient.getId() != 0 a reliable way to check for success?
|
17:03:31
|
*** dkayiwa has quit IRC
|
17:03:44
|
<jriley> assertFalse( 0 == Context.getPatientService().savePatient(myNewPatient).getId() ) ?
|
17:04:26
|
* jriley wonders if ForestService() fails to save a tree and nobody catches the exception, does the tree still exist?
|
17:06:02
|
*** downeym_ has joined #openmrs
|
17:06:02
|
*** ChanServ sets mode: +o downeym_
|
17:06:28
|
*** downeym has quit IRC
|
17:06:28
|
*** downeym_ is now known as downeym
|
17:06:47
|
<djazayeri> jriley: hi
|
17:06:53
|
*** dkayiwa has joined #openmrs
|
17:07:11
|
<djazayeri> usually you can test patient.getId() for null
|
17:07:23
|
<jriley> Cool
|
17:07:36
|
<djazayeri> not sure what ConceptName has to do with Patient.
|
17:07:46
|
<jriley> I'm importing a lot of patients
|
17:07:54
|
<jriley> I need to add things like concept names, addresses, etc etc etc
|
17:08:12
|
<jriley> I want to detect if an import failed, so I can log and re-examine, but not check every last field
|
17:08:49
|
<jriley> if the save will fail if the pieces fail, I'll check that
|
17:08:52
|
<djazayeri> I seeâI'm not sure that you can transitively create a concept by saving a patient though
|
17:08:59
|
<jriley> sorry
|
17:09:01
|
<jriley> PersonName
|
17:09:03
|
<djazayeri> you mean person name?
|
17:09:04
|
<jriley> I've been looking at concepts al ot
|
17:09:08
|
<jriley> yes
|
17:09:09
|
<djazayeri> okay, that's what I figured
|
17:09:20
|
<jriley> I've got concepts on the brain
|
17:09:38
|
<jriley> thanks
|
17:18:45
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.8.x): formatting <http://feedproxy.google.com/~r/OMRStrunk/~3/UyRsprtL0Ug/OpenMRS> || New Changeset: OpenMRS (1.8.x): The fieldGen for String should support an options the displays a textarea instead of a text field - TRUNK-2485... <http://feedproxy.google.com/~r/OMRStrunk/~3/iu72gIsO5J8/OpenMRS> || New Changeset: OpenMRS (1.8.x): svn:ignore module tags <http://feedproxy.google.com/~r/OMRStrunk/~3/YKTPF8O4RvE/OpenMRS> || New Changeset: OpenMRS (trunk): TRUNK-2485 - followup fix from CR-TRUNK-480 <http://feedproxy.google.com/~r/OMRStrunk/~3/MXnO2L2F9pQ/OpenMRS>
|
17:33:39
|
<bryq> downeym: Presentation uploaded :)
|
17:33:54
|
<downeym> bryq: downloading now :)
|
17:41:44
|
<downeym> bryq: http://www.youtube.com/watch?v=BhnURq8psaQ
|
17:45:27
|
*** Suranga has quit IRC
|
17:58:59
|
<bryq> downeym: Thanks so much
|
17:59:25
|
<djazayeri> bryq: very well done. I was assuming you were just going to record a screencast of the demo, but it makes sense to pre-record the entire presentation. Hopefully we can start a trend of everyone doing this, so that we have this content available after the fact too.
|
17:59:27
|
<downeym> bryq: no problem :) good video
|
17:59:59
|
<djazayeri> The fast zoom was a bit disconcerting at times. A bit like Wayne's World.
|
18:01:15
|
<bryq> djazayeri: Maybe I've put too much zoomings, but that was my first time I've seen this feature
|
18:01:40
|
<bryq> djazayeri: So I didn't realise that it is disconcerning
|
18:01:40
|
<djazayeri> Usually it was good. A few of them were too far, too fast.
|
18:02:55
|
<bryq> djazayeri: Any onther short comments befote online presentation? :)
|
18:08:29
|
<djazayeri> (on a call now)
|
18:09:19
|
<djazayeri> (There was one feature you didn't mention, but I forget what it was. I'll have to watch the video again to remember.)
|
18:10:31
|
<downeym> bryq: it already had 14 viewers so you might get some feedback on the video page. :)
|
18:18:50
|
*** rafa has joined #openmrs
|
18:18:51
|
*** ChanServ sets mode: +v rafa
|
18:27:08
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Video: #OpenMRS #GSoC Metadata Sharing project overview http://t.co/cLSn97Q <http://twitter.com/OpenMRS/statuses/106426595299954689>
|
18:32:30
|
*** bryq1 has joined #openmrs
|
18:32:35
|
*** bryq has quit IRC
|
18:48:45
|
*** wyclif has quit IRC
|
18:48:54
|
*** wyclif has joined #openmrs
|
18:51:38
|
<wyclif> bwolfe, if the admin can remove apps from a user and an ordinary user can also hide apps, then don't we need to keep track of who removed the app just in case it was for done for privilege reasons so that a user doesn't always unhide any app
|
18:52:20
|
<bwolfe> wyclif, don't worry about that for now
|
18:52:35
|
<wyclif> ok
|
18:54:46
|
*** james_regen has left #openmrs
|
19:09:11
|
*** jriley has quit IRC
|
19:16:10
|
*** dkayiwa_ has joined #openmrs
|
19:16:55
|
*** dkayiwa has quit IRC
|
19:16:57
|
*** dkayiwa_ is now known as dkayiwa
|
19:44:22
|
*** dkayiwa has quit IRC
|
20:00:29
|
*** jriley has joined #openmrs
|
20:07:46
|
*** gbastien has quit IRC
|
20:17:14
|
<OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (localize-setup-wizard): TRUNK-2055 : Minor changes within installation wizard required by code review <http://feedproxy.google.com/~r/OMRStrunk/~3/c8fW8qamtms/OpenMRS>
|
20:22:34
|
*** bryq1 has left #openmrs
|
21:10:41
|
*** rafa has quit IRC
|
21:12:33
|
*** neal has joined #openmrs
|
21:12:42
|
<downeym> Hi neal and welcome to the #openmrs IRC channel.
|
21:12:51
|
<neal> hi, thanks..
|
21:14:43
|
<neal> i'm in haiti right now working with a friend to provide an openmrs installation set up for a colleague who's overseeing about 500 patients for TB treatment..does anyone know how close to release quality the MDR TB module is? right now it says 2.0 has been in beta since january, and hasn't been tested with OpenMRS v 1.7 or higher
|
21:16:24
|
*** bwolfe has quit IRC
|
21:26:42
|
<downeym> i don't know personally - djazayeri might
|
21:27:05
|
<downeym> i believe the developers at PIH have been working to expand it to TB generally
|
21:33:00
|
<djazayeri> Hi Neal: I know that 2.0 of the MDR module is in use in production in at least two places, probably more.
|
21:33:08
|
<djazayeri> I don't know if it works with 1.8.
|
21:34:17
|
<djazayeri> But the main point is that it's focused on MDR-TB, not plain TB.
|
21:34:50
|
* downeym retracts his statement :)
|
21:37:52
|
*** chughgaurav has joined #openmrs
|
21:43:34
|
*** jportela has joined #openmrs
|
21:43:34
|
*** ChanServ sets mode: +v jportela
|
21:47:17
|
<neal> thanks, both of you
|
21:49:53
|
*** neal has quit IRC
|
21:56:22
|
*** neal-haiti has joined #openmrs
|
21:56:33
|
<downeym> Hi neal-haiti and welcome to the #openmrs IRC channel.
|
22:03:19
|
*** downeym has quit IRC
|
22:34:34
|
*** chughgaurav has quit IRC
|
22:38:45
|
*** jportela has quit IRC
|
22:39:09
|
*** jportela has joined #openmrs
|
22:39:09
|
*** ChanServ sets mode: +v jportela
|
22:41:37
|
<neal-haiti> if i wanted to use OpenMRS to track a TB ward, is this recommended? are there any particular modules i should install? it seems that PIH-EMR 2.0 was used for precisely this but I'm not sure what the analagous installation for OpenMRS would be. thanks!
|
23:05:20
|
*** jriley has quit IRC
|
23:21:26
|
*** wyclif has quit IRC
|
23:35:34
|
*** jportela has quit IRC
|
23:36:00
|
*** jportela has joined #openmrs
|
23:36:00
|
*** ChanServ sets mode: +v jportela
|
23:48:38
|
*** jportela has quit IRC
|
23:49:02
|
*** jportela has joined #openmrs
|
23:49:02
|
*** ChanServ sets mode: +v jportela
|
23:59:28
|
*** jportela has quit IRC
|
23:59:54
|
*** jportela has joined #openmrs
|
23:59:54
|
*** ChanServ sets mode: +v jportela
|