| 00:03:11 | *** gbastien has quit IRC |
| 00:21:22 | *** Echidna has quit IRC |
| 00:22:20 | *** Echidna has joined #openmrs |
| 00:22:20 | *** ChanServ sets mode: +v Echidna |
| 00:53:14 | *** gbastien has joined #openmrs |
| 01:21:30 | *** goutham has joined #openmrs |
| 01:32:46 | *** gbastien has quit IRC |
| 01:54:43 | *** goutham has quit IRC |
| 02:18:39 | *** Suranga has joined #openmrs |
| 02:26:24 | <Suranga> hi djazayeri |
| 02:26:29 | <Suranga> r u really there ? |
| 02:37:00 | *** suho has joined #openmrs |
| 02:37:00 | *** ChanServ sets mode: +v suho |
| 02:45:37 | *** upul` has joined #openmrs |
| 02:45:37 | *** ChanServ sets mode: +v upul` |
| 02:45:47 | <upul`> ./join #harrypotter |
| 02:46:15 | <upul`> oops ignore that |
| 02:46:20 | *** r0bby has joined #openmrs |
| 02:46:20 | *** ChanServ sets mode: +v r0bby |
| 02:47:50 | *** robbyoconnor has quit IRC |
| 02:47:58 | *** r0bby is now known as robbyoconnor |
| 02:49:19 | *** Suranga has quit IRC |
| 02:59:14 | *** Echidna_ has joined #openmrs |
| 02:59:14 | *** Echidna has quit IRC |
| 04:17:37 | *** surangak has joined #openmrs |
| 04:28:07 | <surangak> hi djazayeri |
| 04:28:13 | <surangak> r u really there :) |
| 04:34:21 | *** surangak_ has joined #openmrs |
| 04:34:21 | *** surangak has quit IRC |
| 05:09:37 | *** suho has quit IRC |
| 05:30:38 | *** wyclif has quit IRC |
| 05:47:13 | *** bryq has joined #openmrs |
| 05:47:13 | *** ChanServ sets mode: +v bryq |
| 05:58:14 | *** bryq1 has joined #openmrs |
| 05:59:44 | *** bryq has quit IRC |
| 06:08:36 | *** dkayiwa has joined #openmrs |
| 06:15:30 | *** bwolfe has joined #openmrs |
| 06:15:30 | *** ChanServ sets mode: +o bwolfe |
| 06:59:58 | *** bwolfe has quit IRC |
| 07:01:37 | *** surangak has joined #openmrs |
| 07:01:43 | *** surangak_ has quit IRC |
| 07:02:07 | *** dkayiwa has quit IRC |
| 07:08:21 | *** pascal` has joined #openmrs |
| 07:08:26 | *** surangak has left #openmrs |
| 07:08:54 | *** surangak_ has joined #openmrs |
| 07:08:55 | *** pascal` has quit IRC |
| 07:20:23 | *** bwolfe has joined #openmrs |
| 07:20:23 | *** ChanServ sets mode: +o bwolfe |
| 07:23:52 | *** rafa has joined #openmrs |
| 07:23:52 | *** ChanServ sets mode: +v rafa |
| 07:24:40 | *** pascal` has joined #openmrs |
| 07:34:59 | *** pascal` has quit IRC |
| 07:44:39 | *** pascal` has joined #openmrs |
| 07:55:35 | *** cta has joined #openmrs |
| 07:55:47 | <cta> hello |
| 07:57:54 | <cta> bwolfe: Ben, as for review CR_TRUNK-477. I done the patch in March. A lot of things has changed since that time, so my patch became out-of-dated and in fact I abandoned the review |
| 07:58:21 | <bwolfe> hmm, ok, I see that now |
| 07:58:31 | <bwolfe> is there an updated review? |
| 07:59:53 | <cta> not yet. |
| 08:01:55 | <cta> bwolfe: Ben, I will trying to re-do tickets for CR-TRUNK-477 probably next week. |
| 08:03:01 | <bwolfe> ok |
| 08:03:09 | <bwolfe> but you're merging them into your branch? :-( |
| 08:09:21 | <cta> no, I do not |
| 08:09:45 | <cta> They are luying separetely off my branch |
| 08:10:10 | <bwolfe> ok, good |
| 08:10:35 | <cta> np. |
| 08:11:37 | *** pascal` has quit IRC |
| 08:12:47 | *** pascal` has joined #openmrs |
| 08:59:30 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.6.x): Contribution to messages_fr.properties for reporting - TRUNK-2514... <http://feedproxy.google.com/~r/OMRStrunk/~3/funwI4lxyk0/OpenMRS> || New Changeset: OpenMRS (trunk): Contribution to messages_fr.properties for reporting - TRUNK-2514... <http://feedproxy.google.com/~r/OMRStrunk/~3/a8DnERTI3ZA/OpenMRS> || New Changeset: OpenMRS (1.8.x): Backporting Install from Module Repository feature does not work under maven+jetty - TRUNK-1852 <http://feedproxy.google.com/~r/OMRStrunk/~3/GBUeIl9dg5E/OpenMRS> |
| 09:00:00 | *** pascal` has quit IRC |
| 09:04:21 | *** pascal` has joined #openmrs |
| 09:07:44 | <rafa> Hi bwolfe |
| 09:08:03 | <rafa> Can you please check why I can't close https://tickets.openmrs.org/browse/TRUNK-2260? |
| 09:09:22 | <rafa> bwolfe: I reopened review and closed again hoping that it'll help but with no avail |
| 09:33:33 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): TRUNK-2261: Liquibase script to migrate legacy Encounter.provider data to Encounter.providers ... <http://feedproxy.google.com/~r/OMRStrunk/~3/62Z5Fxn4LNs/OpenMRS> |
| 09:53:57 | <bwolfe> rafa, get that figured out? |
| 09:54:12 | <rafa> bwolfe: yes thanks for the hint |
| 09:54:56 | <rafa> bwolfe: I didn't know that a matching review might be added automatically. |
| 09:55:25 | <rafa> bwolfe: I guess it's based on the revision # included in the other review. |
| 09:56:05 | <bwolfe> usually just based on the title and description I think |
| 09:56:15 | <bwolfe> if they contain the ticket id then it is included |
| 09:56:29 | <rafa> bwolfe: then it shouldn't have been added to that ticket |
| 09:57:53 | <rafa> bwolfe: It seems to be more clever. |
| 10:00:06 | <rafa> bwolfe: It's somewhat confusing, but now I know at least what to check. |
| 10:01:03 | <bwolfe> rafa, I wonder if its because its linked to that other ticket. I'll try removing that and seeing if the linked review goes away |
| 10:01:37 | <bwolfe> hmm, nope |
| 10:02:44 | <bwolfe> although maybe its more complicated than that and goes through all links |
| 10:03:39 | <rafa> bwolfe: I think it looks at the content of the review and see if it includes revisions linked with the ticket. |
| 10:03:58 | <bwolfe> maybe |
| 10:04:28 | <rafa> bwolfe: I added one file committed with TRUNK-2260 to the other review. |
| 10:04:32 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): TRUNK-2394: Can we use the search widget to "list all items" too? ... <http://feedproxy.google.com/~r/OMRStrunk/~3/ufY82yT0kcE/OpenMRS> |
| 10:04:47 | <bwolfe> rafa, is https://tickets.openmrs.org/browse/TRUNK-2583 still valid? |
| 10:05:32 | <rafa> probably |
| 10:05:42 | <rafa> To check it, I would have to remove @Ignored |
| 10:07:00 | <rafa> I didn't fix it myself and haven't heard about others. |
| 10:13:49 | <upul`> bwolfe: have you seen 'money masters'? |
| 10:22:36 | *** magoo has joined #openmrs |
| 10:25:33 | <bwolfe> upul`, no |
| 10:28:32 | <upul`> wow bwolfe it was a documentary made in 1990s |
| 10:29:10 | <upul`> bwolfe: do you know that the federal reserve is a private company? |
| 10:32:18 | <upul`> it's in youtube 3. 1/2 hours every american should watch it and see that they and the whole world are owned and controlled by a few families in europe |
| 10:35:16 | <bwolfe> yes, I knew the federal reserve is outside the government |
| 10:35:26 | <bwolfe> interesting that its just a few families |
| 10:35:30 | * bwolfe queues it up to watch later |
| 11:07:32 | *** surangak_ has quit IRC |
| 11:13:03 | *** james_regen has joined #openmrs |
| 11:13:03 | *** ChanServ sets mode: +v james_regen |
| 11:14:09 | *** pascal` has quit IRC |
| 11:20:33 | *** gauravpaliwal has joined #openmrs |
| 11:20:33 | *** ChanServ sets mode: +v gauravpaliwal |
| 11:28:51 | *** gauravpaliwal has left #openmrs |
| 11:35:11 | *** upul` has quit IRC |
| 12:09:16 | *** goutham has joined #openmrs |
| 12:17:45 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Human Resource Module 0.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=hr&version=&0.1> |
| 12:17:47 | *** magoo has quit IRC |
| 12:24:31 | *** pascal` has joined #openmrs |
| 12:24:32 | *** goutham has quit IRC |
| 12:27:43 | *** jriley has joined #openmrs |
| 12:28:36 | *** muthah has joined #openmrs |
| 12:47:40 | *** pascal` has quit IRC |
| 12:49:16 | *** saimanohar has joined #openmrs |
| 12:49:48 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Stop multiple users from running the installation wizard - TRUNK-2458... <http://feedproxy.google.com/~r/OMRStrunk/~3/1clhKfQ34q0/OpenMRS> |
| 12:56:00 | *** pascal` has joined #openmrs |
| 13:06:17 | <cta> buy guys |
| 13:06:21 | *** cta has quit IRC |
| 13:06:46 | *** chopin has joined #openmrs |
| 13:10:09 | *** jriley has left #openmrs |
| 13:10:20 | *** jriley has joined #openmrs |
| 13:11:53 | *** pascal` has quit IRC |
| 13:30:33 | *** pascal` has joined #openmrs |
| 13:36:11 | *** wyclif has joined #openmrs |
| 13:40:09 | *** gbastien has joined #openmrs |
| 13:40:23 | *** jportela has joined #openmrs |
| 13:40:23 | *** ChanServ sets mode: +v jportela |
| 13:47:29 | *** asgoyal has joined #openmrs |
| 13:57:52 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): HL7 privileges should also be included under the Role Management screen - TRUNK-259... <http://feedproxy.google.com/~r/OMRStrunk/~3/l0yvTe0X0Dc/OpenMRS> |
| 14:02:13 | *** asgoyal has quit IRC |
| 14:04:04 | <djazayeri> hi bwolfe, rafa, wyclif |
| 14:04:06 | *** pascal` has quit IRC |
| 14:04:31 | <djazayeri> no dkayiwa |
| 14:05:51 | <wyclif> hi |
| 14:07:14 | *** pascal` has joined #openmrs |
| 14:07:24 | <rafa> hi |
| 14:09:21 | <djazayeri> I'll start today |
| 14:09:29 | <djazayeri> Monday: |
| 14:09:29 | <djazayeri> * Committed TRUNK-2580 (date attributes stored in locale-dependent format) |
| 14:09:29 | <djazayeri> * Worked on TRUNK-2575 (UI for Location Attributes) |
| 14:09:29 | <djazayeri> * Code reviews |
| 14:09:30 | <djazayeri> Today: |
| 14:09:30 | <djazayeri> * Finish TRUNK-2575 (UI for Location Attributes & refactor Visit Attributes to share code) |
| 14:09:31 | <djazayeri> * code review |
| 14:09:31 | <djazayeri> * Thoughtworks Code Jam |
| 14:09:32 | <djazayeri> * Look at merging Lu's metadata localization branch |
| 14:09:32 | <djazayeri> * Plan for next sprint |
| 14:09:36 | <djazayeri> No blockers |
| 14:11:17 | <djazayeri> rafa? |
| 14:11:24 | <rafa> *** Rafal *** |
| 14:11:24 | <rafa> Today: |
| 14:11:24 | <rafa> * Almost closed: |
| 14:11:24 | <rafa> - TRUNK-2261: Liquibase script to migrate legacy Encounter.provider data to Encounter.providers |
| 14:11:24 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2261 (awaits for a quick look with Darius' eye) |
| 14:11:25 | <rafa> - TRUNK-2260: Add Encounter.providers property and deprecate old Encounter.provider property |
| 14:11:25 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2260 (can't be closed before 2261) |
| 14:11:26 | <rafa> * Worked on: |
| 14:11:26 | <rafa> - TRUNK-2394: Can we use the search widget to "list all items" too? |
| 14:11:27 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2394 (got blocked) |
| 14:11:27 | <rafa> - TRUNK-2566: When you first open the Manage Providers page the search widget should auto-fetch the first page of results and display them. |
| 14:11:28 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2566 |
| 14:11:28 | <rafa> * Reviewed Piotr's work |
| 14:11:29 | <rafa> Tomorrow: |
| 14:11:29 | <rafa> * Finish: |
| 14:11:30 | <rafa> - TRUNK-2394 |
| 14:11:30 | <rafa> - TRUNK-2566 |
| 14:11:31 | <rafa> * Pick up a new ticket (not sure which) |
| 14:11:31 | <rafa> Blockers: |
| 14:11:32 | <rafa> TRUNK-2394 comment in the ticket. |
| 14:12:14 | *** dkayiwa has joined #openmrs |
| 14:12:52 | <djazayeri> !ticket trunk-2261 |
| 14:12:53 | <OpenMRSBot> djazayeri: [#TRUNK-2261] Liquibase script to migrate legacy Encounter.provider data to Encounter.providers - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2261 |
| 14:13:30 | <djazayeri> rafa: I just commented on trunk-2394 |
| 14:13:35 | <djazayeri> you should display all for providers |
| 14:13:38 | <rafa> thanks |
| 14:13:45 | <rafa> what about encounters? |
| 14:14:01 | <djazayeri> none |
| 14:14:33 | <djazayeri> I.e. display none for encounters. |
| 14:15:13 | <rafa> patients none? |
| 14:15:41 | <rafa> I asked because wyclif suggested to display all for those two |
| 14:15:59 | <djazayeri> I say none for those two |
| 14:16:33 | <rafa> wyclif: did you have a particular reason? :) |
| 14:16:55 | *** asgoyal has joined #openmrs |
| 14:17:02 | <wyclif> i don't thinkk i suggested that |
| 14:17:29 | <rafa> wyclif: yes, you did in comments in https://source.openmrs.org/cru/CR-TRUNK-460 |
| 14:18:06 | <rafa> wyclif: but nevermind :) |
| 14:18:51 | <wyclif> hmmm.. |
| 14:19:05 | *** upul` has joined #openmrs |
| 14:19:05 | *** ChanServ sets mode: +v upul` |
| 14:19:11 | <djazayeri> rafa: for trunk-2261, you're waiting for my code review after splitting the changeset? |
| 14:19:25 | <rafa> yes, just have a quick look if it's what you meant |
| 14:20:42 | <djazayeri> did you change the code review, or should I just look at the changeset? |
| 14:21:17 | <rafa> I updated the code review |
| 14:21:31 | <djazayeri> ok |
| 14:21:47 | <djazayeri> I'll look at it now |
| 14:21:49 | <rafa> thanks |
| 14:21:50 | <djazayeri> dkayiwa? |
| 14:22:52 | <djazayeri> you there? |
| 14:22:54 | <dkayiwa> Did some code reviews |
| 14:22:55 | <dkayiwa> Worked on review comments for earlier tickets |
| 14:22:55 | <dkayiwa> Worked on second pass for: patientEncounters portlet should display multiple providers - TRUNK-2263 |
| 14:22:55 | <dkayiwa> Not yet figured out which ticket i should do next |
| 14:22:55 | <dkayiwa> No blockers |
| 14:24:13 | <djazayeri> One option is trunk-2262 |
| 14:24:32 | <dkayiwa> !ticket trunk-2262 |
| 14:24:33 | <OpenMRSBot> dkayiwa: [#TRUNK-2262] Edit Encounter page should support multiple providers - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2262 |
| 14:24:40 | <dkayiwa> ok |
| 14:25:28 | <rafa> djazayeri: aren't the priorities valid? |
| 14:26:28 | <djazayeri> They generally are, but that's the last "providers" ticket, so it'd be nice to complete that. |
| 14:26:42 | <dkayiwa> ok |
| 14:26:51 | <rafa> djazayeri: good |
| 14:32:10 | <wyclif> can i go? |
| 14:32:15 | <djazayeri> yes |
| 14:32:17 | <wyclif> yesterday: |
| 14:32:17 | <wyclif> - Completed SMART-24 |
| 14:32:17 | <wyclif> - revisted SMART-20 to fix review comments |
| 14:32:17 | <wyclif> - Started work on SMART-11 |
| 14:32:17 | <wyclif> today: |
| 14:32:18 | <wyclif> - Done code review for SMART-22 |
| 14:32:20 | <wyclif> - Continue with SMART-11 |
| 14:32:22 | <wyclif> - work on other sprint tickets |
| 14:33:01 | *** pascal` has quit IRC |
| 14:33:03 | <bwolfe> !ticket SMART-11 |
| 14:33:04 | <OpenMRSBot> bwolfe: [#SMART-11] Add/modify SMART data type - Allergy Exception - OpenMRS JIRA - https://tickets.openmrs.org/browse/SMART-11 |
| 14:33:21 | <bwolfe> wyclif, whats your goal for the allergy exceptions? |
| 14:33:30 | <bwolfe> not sure how that gets mapped over... |
| 14:34:13 | <wyclif> i plan to register a GP for concept to be used as the question for no allergy |
| 14:34:35 | <bwolfe> ok |
| 14:34:38 | <wyclif> then obs that have this as the question concept are allergy excecptions |
| 14:35:09 | *** pascal` has joined #openmrs |
| 14:35:10 | <wyclif> then for the response, hmm |
| 14:35:19 | <bwolfe> thats fine. would be nice if we could build that into ActiveList/Allergy somehow. but thats def not for this ticket. :-) |
| 14:36:01 | <bwolfe> what do you mean by response wyclif? |
| 14:36:26 | <wyclif> i.e the answer to for the obs |
| 14:36:36 | <wyclif> sorry! for the created obs |
| 14:38:30 | <wyclif> i think it would be good to add 4 other GPs for the responses i.e to match the 'not food allergies', 'no drug allergies' etc |
| 14:38:36 | <djazayeri> yeah, seems appropriate to initially handle this in the same way as problem added / problem removed |
| 14:38:50 | <wyclif> see the table here http://wiki.chip.org/smart-project/index.php/Developers_Documentation:_SMART_Data_Model#AllergyException_RDF |
| 14:38:51 | <OpenMRSBot> <http://ln-s.net/95ey> (at wiki.chip.org) |
| 14:39:51 | <djazayeri> It's probably worth pinging Burke about that. |
| 14:40:24 | <bwolfe> wyclif, ah. yeah, there are only 4 possible answers |
| 14:40:39 | <wyclif> but will create a ticket support this in core |
| 14:41:00 | <bwolfe> label it with "design-review" |
| 14:41:11 | <djazayeri> Yeah, I'm not convinced about supporting it in core. |
| 14:45:38 | <bwolfe> ok, well, debate for another day |
| 14:45:44 | <bwolfe> my update. today: |
| 14:45:45 | <bwolfe> emails |
| 14:45:45 | <bwolfe> added 2 new smart tickets |
| 14:45:45 | <bwolfe> cleaned up a few smart reviews |
| 14:45:45 | <bwolfe> cleaned up smart wiki docs |
| 14:45:46 | <bwolfe> applied several trunk patches |
| 14:45:49 | <bwolfe> reviewed a few "needs assessment" trunk tickets |
| 14:45:50 | <bwolfe> investigated a sync bug |
| 14:45:52 | <bwolfe> tomorrow: |
| 14:45:54 | <bwolfe> smart reviews, sync ticket review, design calls |
| 14:46:38 | <djazayeri> How is the SMART sprint looking overall? |
| 14:47:26 | <bwolfe> looks like we'll finish the finishable targets |
| 14:47:43 | <djazayeri> Okay, that's good. :-) |
| 14:47:50 | <bwolfe> a few of the objects were removed from the sprint because their a low priority for Josh and we don't have direct analogous objects |
| 14:48:01 | *** dkayiwa has quit IRC |
| 14:48:06 | <bwolfe> I added a few tickets today that will take wyclif a day or so to finish |
| 14:48:14 | <bwolfe> it makes the module a lot more usable |
| 14:49:05 | <djazayeri> Will we be able to release "1.0" of the module? |
| 14:49:44 | <bwolfe> probably |
| 14:50:03 | <wyclif> bwolfe, what priority did you assign to them |
| 14:50:43 | <bwolfe> higher than the tickets there |
| 14:52:15 | <wyclif> my goal is to be done working on sprint tickets by end of thursday(which is enough time), so that friday am only applying code review changes, i want to avoid having partially done tickets by end of sprint |
| 14:53:55 | <bwolfe> a good goal |
| 14:54:22 | <bwolfe> sprint technically goes until sunday night |
| 14:54:32 | <bwolfe> so just don't make weekend plans yet ;-) |
| 14:55:17 | <wyclif> ok |
| 15:00:52 | <wyclif> djazayeri, bwolfe, what is codeprovenance |
| 15:01:02 | <djazayeri> where do you see that? |
| 15:01:10 | <bwolfe> its an accuracy of hte mapping thing |
| 15:01:21 | <djazayeri> provenance = where something comes from |
| 15:01:36 | *** rafa has quit IRC |
| 15:02:55 | <wyclif> bwolfe's description != djazayeri 's description |
| 15:03:14 | *** saimanohar has quit IRC |
| 15:03:17 | <bwolfe> also, a != b |
| 15:03:19 | <djazayeri> ben has more context... |
| 15:03:28 | <djazayeri> so he's probably right |
| 15:04:28 | <bwolfe> see SmartDataHandlerUtil#codedValueProvenanceHelper |
| 15:04:41 | <wyclif> ok |
| 15:04:42 | <bwolfe> it says "this comes from openmrs and is verified to x degree" |
| 15:08:03 | *** mario_ has joined #openmrs |
| 15:08:24 | <mario_> hola Darius buenos dias |
| 15:15:20 | <djazayeri> hola mario |
| 15:15:23 | <djazayeri> mario_ |
| 15:16:10 | <mario_> hola Darius, mepuedes colaborar con una inquietud quetengo de la parte deconcept.tag |
| 15:17:41 | <djazayeri> okay |
| 15:18:19 | *** pascal` has quit IRC |
| 15:19:30 | <mario_> estoy tratando de pasar un parametro de una jsp al tag conept.tag en esta linea : <openmrs_tag:concept nameType="short" conceptId="${allergy.allergen.conceptId}"/> |
| 15:21:45 | <mario_> y enel concept.tag tengo esto: |
| 15:21:46 | <mario_> <%@ attribute name="nameType" required="false" type="java.lang.String"%> <c:setvar="nameType"value="${nameType}"/> |
| 15:22:09 | <mario_> pero no me o esta tomando que puede estar paando? |
| 15:24:15 | <djazayeri> mario_: estas agregando un nuevo attributo nameType? |
| 15:24:30 | <mario_> si |
| 15:24:54 | <mario_> toca modificar algun arhivo adicional para eso? |
| 15:27:05 | <djazayeri> quieres simplemente mostrar el nombre de un concept? |
| 15:30:24 | <mario_> si pero dependiendo del valor que tenga ese atributo |
| 15:31:16 | <djazayeri> Yo sugiero que en vez de hacer esto con concept.tag, seria mejor hacerlo con el FormatTag |
| 15:31:51 | <djazayeri> En este momento, se puede hacer: <openmrs:formatconcept="${allergy.allergen}"/> |
| 15:31:58 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Using the recommended fix for - TRUNK-2459 <http://feedproxy.google.com/~r/OMRStrunk/~3/PoUjWvKi_ic/OpenMRS> |
| 15:32:11 | <djazayeri> Mejor seria <openmrs:formatconcept="${allergy.allergen}"conceptNameType="short"/> |
| 15:32:59 | *** missa has joined #openmrs |
| 15:33:00 | <missa> hi |
| 15:33:29 | <missa> i'm new to openmrs, any help? |
| 15:34:36 | <djazayeri> mario_: para hacer este cambio, hay que agregar "conceptNameTag" en la seccion del format tag en openmrs.tld, y tambien agregar un getter y setter in FormatTag por private String conceptNameType. Y en el metodo printConcept, usar este variable, si tiene valor. |
| 15:34:48 | <djazayeri> missa: do you have a particular question? |
| 15:36:11 | *** missa has quit IRC |
| 15:36:50 | <mario_> Darius eso es para la segunda opcion que me comentas o para la que o te estaba planteando? |
| 15:37:08 | <djazayeri> para la segunda opcion que comente |
| 15:37:49 | <djazayeri> la otra opcion seria hacer algo similar en ConceptTag |
| 15:38:27 | <djazayeri> pero concept.tag y ConceptTag son antiguos, y creo que seria mejor hacer eso con el FormatTag |
| 15:38:45 | *** jportela has left #openmrs |
| 15:39:39 | <mario_> lo trate de hacer en concept tag y modifique el openmrs.tls y el concepttag.java y trabaja bien, pero el problema esta en que no me toma el valor que paso con la sentencia |
| 15:39:44 | <mario_> <openmrs_tag:concept nameType="short" conceptId="${allergy.allergen.conceptId}"/> |
| 15:40:14 | <mario_> Darius esto es lo ue hice y me funciona |
| 15:40:15 | <mario_> <openmrs:conceptconceptId="${conceptId}"var="c"nameVar="n"numericVar="num"nameType="${nameType}"> |
| 15:41:12 | <mario_> cuando valido el valor que debe llegar aparece en blanco |
| 15:41:46 | <djazayeri> Ose del openmrs:concept funziona? |
| 15:42:18 | <mario_> si |
| 15:42:51 | <mario_> no e toma es el valor que le mando con esa instruccion, pero si toma el de conceptId |
| 15:43:17 | <djazayeri> Hay tambien que cambiar openmrs.tld |
| 15:44:06 | <djazayeri> eso indica cuales attributos se pueden usar en el tag |
| 15:44:27 | <mario_> ya lo modifique en la seccion <name>concept</name> <tag-class>org.openmrs.web.taglib.ConceptTag</tag-class> |
| 15:45:46 | <djazayeri> agregaste el <attribute>...</attribute>? |
| 15:46:20 | <mario_> si <attribute> <name>nameType</name> <required>false</required> <rtexprvalue>true</rtexprvalue> <type>java.lang.String</type> </attribute> |
| 15:46:27 | <djazayeri> okay |
| 15:46:35 | <djazayeri> y cambiaste ConceptTag.java? |
| 15:47:31 | <mario_> no se si cuando se utiliza el tag openmrs_tag:concept, halla que configurr algo para los parametros que se envian |
| 15:48:03 | <mario_> si el concepTag tambien, adicone la variable y genere el set y el get |
| 15:49:39 | <mario_> porque al parecer no me lo tomando, solo toma el conceptid |
| 15:49:53 | <djazayeri> y tambien cambiaste lo del "if (nameVar != null) ..."? |
| 15:51:12 | <djazayeri> Osea, si haces lo siguiente, funziona? <openmrs:conceptconceptId="${allergy.allergen.conceptId}"nameType="short"nameVar="n"> ${n} </openmrs:concept> |
| 15:51:38 | <mario_> si |
| 15:53:05 | <djazayeri> okay, solo es que no funziona en <openmrs_tag:concept .../> |
| 15:53:11 | <mario_> claro que lo tengo asi: |
| 15:53:13 | <mario_> <openmrs:conceptconceptId="${conceptId}"var="c"nameVar="n"numericVar="num"nameType="short"> |
| 15:53:49 | <mario_> ya que el concepid viene desdela otra pagina: |
| 15:53:57 | <mario_> <%@ attribute name="conceptId" required="true" type="java.lang.Integer" %> |
| 15:54:29 | <djazayeri> Y agregaste: |
| 15:54:30 | <djazayeri> <%@ attribute name="nameType" required="false" type="java.lang.String" %> |
| 15:55:00 | <mario_> si y ese no me lo toma, queda en blanco |
| 15:55:48 | <mario_> por eso pienso quepuedeserdel openmrs_tag:concept |
| 15:56:45 | <djazayeri> en tu mensaje original, dijiste: <%@ attribute name="nameType" required="false" type="java.lang.String"%> Â <c:setvar="nameType"value="${nameType}"/> |
| 15:56:54 | <djazayeri> el <c:set> no es necesario |
| 15:58:09 | <mario_> ok, lo puse mirando si depronto era eso. |
| 15:58:52 | <mario_> Darius cuando se utiliza el openmrs_tag, el solo carga el archivo.tag o pasa por algun otro lado |
| 15:59:00 | <djazayeri> puedes hacer un patch con todos los cambios de openmrs.tld, ConceptTag.java, y concept.tag? |
| 15:59:08 | <djazayeri> solo el tag |
| 15:59:11 | <mario_> si claro |
| 15:59:26 | <djazayeri> los .tag deben ser muy faciles |
| 16:00:49 | <mario_> creo el patch y lo coloco en un ticket? |
| 16:01:26 | <mario_> o se lo envio al correo |
| 16:01:45 | <djazayeri> enviamelo por correo |
| 16:02:11 | <djazayeri> pero sigo pensando que puedes hacer eso con FormatTag en 10 minutes. |
| 16:03:58 | <mario_> ok, lo voy hacer con FormatTag. Si me funcion no le envio el patch? |
| 16:04:05 | <djazayeri> correcto |
| 16:04:29 | <djazayeri> simplemente agrega un "conceptNameTag" (mejor llamarlo asi) en el openmrs.tld y en FormatTag.java |
| 16:04:36 | <djazayeri> y en el "printConcept", usa este valor |
| 16:05:19 | <djazayeri> Perdon, "conceptNameType" |
| 16:05:25 | <djazayeri> asi, en el futuro podemos agregar algo similar para concept name tag. |
| 16:06:55 | <mario_> listo, voy hacer esos cambios y le envio el patch de esos ambios. |
| 16:07:30 | <djazayeri> En este caso, crea un ticket, y poner el patch alla. |
| 16:07:48 | <mario_> ok |
| 16:08:33 | <mario_> gracias Darius |
| 16:08:38 | <djazayeri> de nada |
| 16:08:41 | <djazayeri> buena suerte |
| 16:08:57 | <mario_> ok |
| 16:18:00 | *** jprice has quit IRC |
| 16:39:30 | *** cta has joined #openmrs |
| 16:46:52 | *** upul` has quit IRC |
| 16:50:26 | *** jkeiper has joined #openmrs |
| 16:53:35 | *** chopin has quit IRC |
| 16:57:26 | *** cta has quit IRC |
| 17:09:41 | *** muthah has quit IRC |
| 17:10:07 | *** muthah has joined #openmrs |
| 17:15:02 | *** muthah has quit IRC |
| 17:16:01 | *** gbastien has quit IRC |
| 17:22:10 | *** Suranga has joined #openmrs |
| 17:26:08 | *** Suranga_ has joined #openmrs |
| 17:28:46 | *** Suranga has quit IRC |
| 17:34:44 | *** mario_ has quit IRC |
| 17:42:40 | *** Suranga_ has quit IRC |
| 17:42:53 | *** Suranga has joined #openmrs |
| 17:44:01 | *** gbastien has joined #openmrs |
| 17:46:21 | *** bwolfe has quit IRC |
| 17:53:58 | *** Suranga has quit IRC |
| 17:54:02 | *** Suranga has joined #openmrs |
| 18:03:11 | *** bwolfe has joined #openmrs |
| 18:03:11 | *** ChanServ sets mode: +o bwolfe |
| 18:07:39 | *** bryq has joined #openmrs |
| 18:07:39 | *** ChanServ sets mode: +v bryq |
| 18:08:50 | *** bryq1 has quit IRC |
| 18:12:16 | <Suranga> the ticket was a great idea djazayeri |
| 18:13:47 | <djazayeri> thanks for updating it |
| 18:14:22 | *** jriley has quit IRC |
| 18:14:55 | <Suranga> djazayeri, no problem |
| 18:15:06 | <Suranga> djazayeri, Obs is my baby now :D |
| 18:16:53 | <Suranga> i will be working on other tickets until we get moving with this one |
| 18:18:43 | <djazayeri> Suranga: cool. We wanted to avoid making any serious design changes or refactorings while you and Jelena were actively working off of this design during SoC. Now it's time to take some lessons learned, and make sure we have an approach that we're really happy with. |
| 18:19:40 | <Suranga> djazayeri, no problem.. I agree |
| 18:19:57 | <Suranga> djazayeri, we'll see this one through |
| 18:36:49 | *** Suranga has quit IRC |
| 18:45:00 | *** jkeiper is now known as chopin |
| 18:45:07 | *** ChanServ sets mode: +v chopin |
| 18:59:44 | *** wyclif has quit IRC |
| 19:06:38 | *** jriley has joined #openmrs |
| 19:08:33 | *** jriley has joined #openmrs |
| 19:11:09 | *** chopin has quit IRC |
| 19:17:52 | *** asgoyal has quit IRC |
| 19:23:05 | *** jriley has quit IRC |
| 19:23:44 | *** jriley has joined #openmrs |
| 19:23:54 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): formatting <http://feedproxy.google.com/~r/OMRStrunk/~3/PklVPMOq8ds/OpenMRS> || New Changeset: OpenMRS (trunk): Location Attributes: UI for LocationAttribute, in the Manage Location page - TRUNK-2575 <http://feedproxy.google.com/~r/OMRStrunk/~3/Q22DsXaDt_A/OpenMRS> |
| 19:34:54 | *** wyclif has joined #openmrs |
| 19:41:03 | *** jportela has joined #openmrs |
| 19:41:03 | *** ChanServ sets mode: +v jportela |
| 19:41:47 | *** dkayiwa has joined #openmrs |
| 19:50:08 | *** muthah has joined #openmrs |
| 19:50:20 | *** bryq has quit IRC |
| 19:53:44 | *** james_regen has quit IRC |
| 20:04:26 | *** jportela has quit IRC |
| 20:06:56 | *** gbastien has quit IRC |
| 20:08:09 | *** muthah has quit IRC |
| 20:08:58 | *** mario_ has joined #openmrs |
| 20:09:50 | <mario_> hola Darius |
| 20:13:03 | *** mario__ has joined #openmrs |
| 20:13:06 | *** jriley has quit IRC |
| 20:13:25 | <mario__> hola Darius |
| 20:14:14 | *** mario_ has quit IRC |
| 20:14:51 | *** muthah has joined #openmrs |
| 20:18:55 | *** jriley has joined #openmrs |
| 20:20:35 | *** jriley has joined #openmrs |
| 20:26:51 | *** mario__ has quit IRC |
| 20:35:31 | *** mario_ has joined #openmrs |
| 20:35:48 | <mario_> Hola Darius |
| 20:39:47 | *** gbastien has joined #openmrs |
| 21:00:14 | *** rafa has joined #openmrs |
| 21:00:14 | *** ChanServ sets mode: +v rafa |
| 21:04:01 | *** dkayiwa has quit IRC |
| 21:05:23 | *** jportela has joined #openmrs |
| 21:05:23 | *** ChanServ sets mode: +v jportela |
| 21:05:28 | <djazayeri> hola mario_ |
| 21:10:39 | *** dkayiwa has joined #openmrs |
| 21:10:59 | <mario_> Darius ya quedo listo la modificacion al formtag, pero tenia un problema con el locale, en la base de datos esta el locale "en" y cuando llamo a context.locale lo toma en_US o en_GB, coloque una validacion y si tiene esos valores y el getName(loc) retorna null, lo cambio por loc.ENGLISH; y vuelvo a consultar el getName(loc) |
| 21:12:00 | <mario_> eso esta bien o hay otra forma de hacerlo? |
| 21:14:34 | <djazayeri> mario_: mirando el codigo, parece que no hay ninguna funcion en Concept que lo hace automaticamente. |
| 21:14:44 | <djazayeri> Tendremos que agregar uno |
| 21:15:23 | <djazayeri> por el momento puedes hacer algo como: |
| 21:15:38 | <djazayeri> ConceptName name = c.getName(locale); |
| 21:15:54 | <djazayeri> if (name == null) name = c.getName(new Locale(locale.getLanguage()); |
| 21:17:35 | <mario_> Darius voy a enviar el patch asi como lo tengo y si algo me dices para cambiarlo |
| 21:17:43 | <djazayeri> bueno |
| 21:17:45 | <djazayeri> has creado un ticket? |
| 21:18:39 | <mario_> no ya lo voy a crear |
| 21:18:50 | <djazayeri> bueno, agregame como "watcher" |
| 21:19:00 | <mario_> ok |
| 21:21:37 | <mario_> Darius en el openmrs-standalone se ejecutael run que trae o como se instala? |
| 21:21:56 | <djazayeri> ejecuta el jar |
| 21:23:53 | <mario_> ok |
| 21:38:32 | *** dkayiwa has quit IRC |
| 21:57:54 | *** rafa has quit IRC |
| 22:12:40 | *** mario_ has quit IRC |
| 22:19:56 | *** jriley has quit IRC |
| 22:47:24 | *** wyclif has quit IRC |
| 23:32:16 | *** muthah has quit IRC |
| 23:37:31 | *** muthah has joined #openmrs |