IRC Chat : 2011-08-22 - OpenMRS

00:25:55 *** wyclif has quit IRC
01:07:26 *** gbastien has quit IRC
01:54:37 *** wyclif has joined #openmrs
01:56:50 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): enumeratedopenmrsmetadata type <http://feedproxy.google.com/~r/OMRStrunk/~3/yDlCMf7yIVs/OpenMRS>
02:22:00 *** jportela has quit IRC
02:29:40 *** gbastien has joined #openmrs
02:51:55 *** muthah has quit IRC
03:02:42 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): enumeratedopenmrsmetadata type <http://feedproxy.google.com/~r/OMRStrunk/~3/wLvFm897nag/OpenMRS> || New Changeset: OpenMRS (improved-person-attribute-type): enumeratedopenmrsmetadata type <http://feedproxy.google.com/~r/OMRStrunk/~3/pW_QmD2gBVk/OpenMRS> || New Changeset: OpenMRS (improved-person-attribute-type): enumeratedopenmrsmetadata type <http://feedproxy.google.com/~r/OMRStrunk/~3/vuegowH3Lhs/OpenMRS> || New Changeset: OpenMRS (improved-person-attribute-type): enumeratedopenmrsmetadata type <http://feedproxy.google.com/~r/OMRStrunk/~3/R-uqOkKtK7w/OpenMRS>
03:07:22 *** upul` has joined #openmrs
03:07:22 *** ChanServ sets mode: +v upul`
03:15:46 *** gbastien has quit IRC
04:09:53 *** surangak has joined #openmrs
04:15:05 *** surangak__ has joined #openmrs
04:15:06 *** surangak has quit IRC
06:07:18 *** bwolfe has joined #openmrs
06:07:18 *** ChanServ sets mode: +o bwolfe
06:10:09 *** djazayeri has quit IRC
06:10:21 *** djazayeri has joined #openmrs
06:10:21 *** ChanServ sets mode: +o djazayeri
06:11:13 <surangak__> hello bwolfe and wellcome to openMRS channel Can't find the answer here? Try http://answers.openmrs.org/
06:11:35 <bwolfe> surangak__, have you turned into a bot now too? :-)
06:11:43 <surangak__> bwolfe, :D
06:11:50 <surangak__> trying out a new job :P
06:18:10 *** Echidna has quit IRC
06:23:20 <bwolfe> we seem to be low in numbers in here today!
06:25:04 <surangak__> bwolfe, only me and thee im afraid. Its monday morning after alll :-)
06:25:24 <bwolfe> heh
06:25:26 <bwolfe> true...
06:26:56 *** dkayiwa has joined #openmrs
06:27:08 <surangak__> dkayiwa, you r right on time :-)
06:27:13 <dkayiwa> hahahah
06:27:32 *** goutham has joined #openmrs
06:32:08 <dkayiwa> surangak__: yes once in a while am right on time :D
06:32:55 <surangak__> dkayiwa, Ben was just saying that we're r low on numbers today, and you turned up a second later :)
06:33:04 <dkayiwa> hahahahahha
06:33:08 <dkayiwa> :)
06:37:07 *** rafa has joined #openmrs
06:37:07 *** ChanServ sets mode: +v rafa
06:55:09 *** bryq has joined #openmrs
06:55:09 *** ChanServ sets mode: +v bryq
06:59:28 *** goutham has quit IRC
07:14:52 *** gauravpaliwal has joined #openmrs
07:14:52 *** ChanServ sets mode: +v gauravpaliwal
07:26:04 <upul`> are you there bwolfe?
07:27:34 <bwolfe> upul`, maybe
07:27:43 <bwolfe> upul`, depends who's asking
07:28:54 <dkayiwa> :)
07:28:54 <upul`> bwolfe: in US addresses 123-45 1st Ave and 12345 1st Ave the same?
07:29:10 <upul`> I mean - / has not meaning
07:29:44 <bwolfe> I've never see 123-45 as an address
07:30:04 <bwolfe> can you paste me the full example? (pm if you want to be discrete)
07:30:22 <upul`> bwolfe: so what happens 12345 splits the land and make 2 buildings?
07:30:58 <bwolfe> if they're apartments it becomes 12345a, 12345b, etc
07:31:12 <bwolfe> look up the address on google maps. they usually translate the address for you
07:31:28 <bwolfe> or go to usps.com and try to create a shipping label from that address. they also correct you
07:31:40 <upul`> bwolfe: ok thanks
07:43:09 <dkayiwa> morning rafa
07:45:07 <dkayiwa> morning bwolfe :)
07:45:18 <dkayiwa> bwolfe: are you working on the providers branch yet?
07:45:29 <bwolfe> hi daniel
07:45:32 <dkayiwa> hi
07:45:34 <bwolfe> no, smart stuff
07:45:37 <dkayiwa> ok
07:55:46 *** Echidna has joined #openmrs
07:55:46 *** ChanServ sets mode: +v Echidna
08:08:27 *** rafa has quit IRC
08:29:40 *** rafa has joined #openmrs
08:29:49 *** ChanServ sets mode: +v rafa
08:29:52 <rafa> morning dkayiwa
08:30:02 <dkayiwa> morning rafa
08:30:59 <dkayiwa> rafa: a liquibase changeset was failing to run for me. i have commented on the ticket
08:40:36 *** bwolfe has quit IRC
08:49:22 <rafa> dkayiwa: ohh sorry for that
08:49:42 <dkayiwa> not problem. but looks like i have broken the build :)
08:51:12 <rafa> dkayiwa: Did it work for you after your change?
08:51:20 <dkayiwa> yes it works
08:54:06 <rafa> dkayiwa: strange that the build fails
08:54:17 <dkayiwa> strange to me too!!!
08:57:57 *** bwolfe has joined #openmrs
08:57:57 *** ChanServ sets mode: +o bwolfe
08:58:38 <rafa> Running org.openmrs.web.servlet.ShowGraphServletTest
08:58:38 <rafa> 22-Aug-2011 04:07:34 Killed
08:58:45 <rafa> dkayiwa: the build was killed :D
08:59:18 <dkayiwa> oh
08:59:27 <dkayiwa> who killed it :D
09:00:36 <rafa> dkayiwa: we need to find the terrorist :D
09:00:51 <rafa> dkayiwa: It builds for me.
09:00:53 <dkayiwa> hahahahahahaha :D :D
09:00:58 <dkayiwa> me too
09:01:00 <dkayiwa> :)
09:01:08 <rafa> dkayiwa: maybe we need to trigger the build again
09:01:22 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): Fixing mysql syntax error for Liquibase script to migrate legacy Encounter.provider data to Encounter.providers - TRUNK-... <http://feedproxy.google.com/~r/OMRStrunk/~3/hAQZCk14uFk/OpenMRS>
09:01:27 <rafa> dkayiwa: with a faked commit
09:01:35 <dkayiwa> hahahahahaha
09:01:48 <dkayiwa> rafa: would it fix the earlier cause of failing?
09:02:15 <rafa> dkayiwa: it's worth a try
09:02:43 <rafa> dkayiwa: maybe it ran out of memory or something
09:02:50 <dkayiwa> oh i seeee
09:04:56 <rafa> dkayiwa: I committed sth. Let's wait for the build.
09:05:05 <dkayiwa> ok
09:05:08 <rafa> dkayiwa: It'll be my fault now :D
09:05:27 <dkayiwa> wish the build luck :)
09:05:39 <rafa> dkayiwa: haha
09:06:09 <dkayiwa> rafa: did you just add empty space in a file and commit :D
09:06:39 <rafa> dkayiwa: I added a comment. I hope it's not that intelligent and it'll trigger the build
09:06:56 <rafa> dkayiwa: it's building...
09:07:10 *** magoo has joined #openmrs
09:07:17 <dkayiwa> ok :)
09:08:25 <magoo> am okay
09:13:11 <rafa> dkayiwa: it's green!
09:13:31 <dkayiwa> rafa: did it send a notification email?
09:13:36 <rafa> dkayiwa: yes
09:13:49 <rafa> dkayiwa: I fixed the build with a comment :D
09:13:55 <dkayiwa> rafa: oh just seen it
09:14:02 <rafa> I'm so good ;)
09:14:08 <dkayiwa> rafa: hahahahahahahah :D :D what a trick!!!
09:14:33 <dkayiwa> rafa: after knowing that, am not not scared of breaking builds :)
09:14:49 <dkayiwa> will just fix always with a comment :)
09:15:01 <rafa> hahaha, you need to be persuasive in your comments :D
09:15:07 <dkayiwa> lollllllllllllll
09:15:59 <rafa> start with something polite "Like dear Build please fix yourself" :D
09:16:19 <dkayiwa> :D hahahahaha :D
09:16:34 <dkayiwa> looks like bribing it with some politeness :)
09:17:05 <dkayiwa> like i talk to my wife when i have wronged her :D
09:17:46 <rafa> haha
09:20:29 *** pascal` has joined #openmrs
09:28:37 *** pascal` has quit IRC
09:42:13 *** bwolfe has quit IRC
09:42:35 *** bwolfe has joined #openmrs
09:42:35 *** ChanServ sets mode: +o bwolfe
09:44:13 *** pascal` has joined #openmrs
09:56:47 *** bwolfe has quit IRC
09:58:00 <rafa> bryq: Hi Piotr
09:58:08 <bryq> rafa: Hi
09:58:30 <rafa> did forms work for you now?
09:59:23 <bryq> rafa: On 1.8.x none form worked
09:59:37 <bryq> rafa: Even on patient dashboard
10:00:20 <bryq> rafa: But just a moment ago I've switched to 1.6.x and the forms you send me in email seems to work
10:00:33 <rafa> bryq: the smaller ones?
10:00:41 <bryq> rafa: At least I see no errors and it looks pretty well
10:00:44 <bryq> rafa: Yes
10:00:57 <rafa> bryq: good, so stay with 1.6
10:01:08 <rafa> bryq: I'll test 1.8 again
10:01:45 <bryq> rafa: Maybe that packages are broken
10:02:02 <rafa> bryq: you need to be very careful while importing them
10:02:33 <rafa> bryq: if you for example replace concept of one datatype with a concept of a different datatype, the form is not likely to work
10:03:27 <rafa> bryq: the most straightforward way is to choose to overwrite or create new items
10:04:58 <bryq> rafa: It could be the reason that I did it wrong
10:05:03 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): TRUNK-2260: Add Encounter.providers property and deprecate old Encounter.provider property ... <http://feedproxy.google.com/~r/OMRStrunk/~3/HMc3jl3t65g/OpenMRS>
10:05:37 <bryq> rafa: But I've tried many combinations (for sure I've been selecting "create new"), and nothing worked
10:05:40 *** magoo has quit IRC
10:06:00 <rafa> bryq: okay, no worries, it's good that you've got 1.6 working.
10:06:12 <rafa> bryq: I'll look into 1.8 again
10:10:06 *** bwolfe has joined #openmrs
10:10:06 *** ChanServ sets mode: +o bwolfe
10:14:07 <bryq> rafa: I've got clean 1.6.x-latest installation with MDS 0.10, htrmlformentry 1.7.3.999, formentry 4.5.4 modules. I've created my own test concept source. Imported Rwanda_HIV_Lab_Results_ebbc3196-7faa-4f75-88c5-843ef125e942.zip and everything worked fine. Now I want to create a new package with this htmlform and I have an exception: http://pastebin.com/j4ZDcWt3
10:14:07 <bryq> Any ideas?
10:14:39 <bryq> rafa: (I've selected "Trust incoming" and "import)
10:16:29 <rafa> bryq: I've seen that too some time ago, but couldn't reproduce it. Can you create a ticket?
10:16:43 <bryq> rafa: Sure
10:16:44 <rafa> bryq: What I did was restarting OpenMRS?
10:16:54 <bryq> rafa: I'm doing it now
10:17:16 <bryq> rafa: (restarting)
10:18:09 *** pascal` has quit IRC
10:18:41 <bryq> rafa: Restart solved the problem :) Uff...
10:19:47 <rafa> bryq: yeah, but the exception is a hard one. What people suggest is to upgrade xstream...
10:20:47 <bryq> rafa: We can try to do this
10:21:05 <rafa> bryq: It's not that easy. XStream is in core.
10:21:19 <bryq> rafa: Oh, I see
10:43:01 *** goutham has joined #openmrs
10:53:41 <gauravpaliwal> rafa: Hi
10:54:07 <rafa> hi gauravpaliwal
10:54:22 <gauravpaliwal> rafa: I forgot the description div id in openmrs, do you remember it ?
10:54:36 <gauravpaliwal> rafa: I mean correct word ?
10:55:17 <rafa> gauravpaliwal: nope sorry
10:55:53 <gauravpaliwal> rafa: no problem , problem solved it was class not ID :(
11:09:32 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (improved-person-attribute-type): enumeratedopenmrsmetadata type location and concept test data adjusted to new data model <http://feedproxy.google.com/~r/OMRStrunk/~3/zJHI47tz1Ew/OpenMRS> || New Changeset: OpenMRS (improved-person-attribute-type): enumeratedopenmrsmetadata type location and concept <http://feedproxy.google.com/~r/OMRStrunk/~3/x_ef4RMHaLY/OpenMRS>
11:15:16 *** surangak__ has quit IRC
11:16:18 *** surangak has joined #openmrs
11:18:18 *** gauravpaliwal has left #openmrs
11:18:47 *** james_regen has joined #openmrs
11:18:47 *** ChanServ sets mode: +v james_regen
11:38:48 *** upul` has quit IRC
11:48:35 *** tinashe has joined #openmrs
11:48:58 <tinashe> Hi Developer and Implementers...
11:49:10 <tinashe> I would like to ask questions about data deletion....
11:49:15 <tinashe> module...
11:49:30 <bwolfe> tinashe, mostly just us devs here. implementers aren't geeky enough to hang out here
11:50:05 <tinashe> bwolfe, okay....hi...have questions about the data deletion module...
11:50:52 <bwolfe> ok, no need to tell us you have questions, just ask your question. :-)
11:51:06 <tinashe> +Developers...
11:51:25 <tinashe> the data deletion module seems not to have any administration functionality...
11:51:37 <tinashe> as in admin links...
11:52:56 <tinashe> to use to select the data to delete from patients to concepts...I have looked onto the documentation, and seems there is no such specifications...
11:53:59 <tinashe> I would particularly want to delete participant encounters...and seems there is no links to do so...
11:55:06 <bwolfe> I haven't used the module myself, so I'm not sure
11:55:14 <bwolfe> what version are you trying to use it on?
11:55:24 <bwolfe> pretty sure there /should/ be admin links
11:55:57 <tinashe> OpenAMS, customized OpenMRS, version 1.7.0 Build 262 (RC)...
11:58:36 <tinashe> Module says requires version 1.6.0, but did not have any errors on module upload...
11:59:00 <tinashe> and module version is 1.0.1...
12:03:59 <tinashe> how can I contact module author however, since I would like to ask more details on participant data deletion...
12:04:48 *** tinashe has left #openmrs
12:05:20 <bwolfe> hmm, tinashe
12:13:39 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Merging Branch to Revision 22725 : 3 <http://feedproxy.google.com/~r/OMRStrunk/~3/nE6U9A51i48/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Merging Branch to Revision 22725 : 2 <http://feedproxy.google.com/~r/OMRStrunk/~3/afecrhH6_60/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Merging Branch to Revision 22725 <http://feedproxy.google.com/~r/OMRStrunk/~3/T8lhZhuYl_U/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Merging Branch to Revision 22705 <http://feedproxy.google.com/~r/OMRStrunk/~3/uMigr7VZy7s/OpenMRS> || OpenMRS Modules: General Feedback Mechanism 1.0.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=feedback&ampversion=&amp1.0.1>
12:20:58 *** surangak has quit IRC
12:21:27 *** surangak has joined #openmrs
12:22:20 *** jportela has joined #openmrs
12:22:20 *** ChanServ sets mode: +v jportela
12:25:18 *** wyclif has quit IRC
12:26:25 *** gauravpaliwal has joined #openmrs
12:26:25 *** ChanServ sets mode: +v gauravpaliwal
12:27:09 <gauravpaliwal> jportela: Dude , Suho has said everything , This is *not fair* , he *haven't left* anything for us (other GSoC'ers) to say :) :D . :d
12:27:21 <gauravpaliwal> ping other GSoCers :d
12:27:47 <surangak> yo, wats up ?
12:28:33 <gauravpaliwal> hi surangak
12:29:31 *** bwolfe_ has joined #openmrs
12:29:31 *** ChanServ sets mode: +o bwolfe_
12:30:14 <gauravpaliwal> seen this : http://openmrs-mailing-list-archives.1560443.n2.nabble.com/Times-up-td6711020.html
12:30:15 *** gbastien has joined #openmrs
12:30:16 <gauravpaliwal> :P
12:30:16 *** bwolfe_ has quit IRC
12:30:21 <OpenMRSBot> <http://ln-s.net/96RR> (at openmrs-mailing-list-archives.1560443.n2.nabble.com)
12:30:31 <gauravpaliwal> he should have left atleast 1-2 lines for us :d
12:30:41 <gauravpaliwal> surangak:
12:30:42 <gauravpaliwal> :d
12:30:50 <surangak> :D
12:31:04 <surangak> are you guys yelling at suho or me :P
12:31:20 <surangak> its totally suhos fault :D
12:32:13 <gauravpaliwal> hah
12:32:15 <gauravpaliwal> :P
12:32:30 *** bwolfe has quit IRC
12:34:51 *** gauravpaliwal has left #openmrs
12:34:55 *** gauravpaliwal has joined #openmrs
12:34:55 *** ChanServ sets mode: +v gauravpaliwal
12:38:10 *** jriley has joined #openmrs
12:38:25 *** jportela has quit IRC
12:38:25 *** gauravpaliwal has left #openmrs
12:41:45 *** bwolfe has joined #openmrs
12:41:45 *** ChanServ sets mode: +o bwolfe
12:46:49 *** bwolfe has quit IRC
12:47:29 *** bwolfe has joined #openmrs
12:47:29 *** ChanServ sets mode: +o bwolfe
12:51:49 *** bwolfe has quit IRC
12:58:56 *** gbastien has quit IRC
13:02:08 <rafa> dkayiwa: I needed to fix my last changeset in liquibase. You might need to do a fresh install of the db if you experience errors.
13:02:59 <dkayiwa> rafa: do you mean i will get liquibase validation failures?
13:03:14 <rafa> dkayiwa: it's possible :(
13:03:26 <rafa> dkayiwa: I didn't know about them
13:03:41 <dkayiwa> will just delete the changesets from my db :)
13:03:55 *** bwolfe has joined #openmrs
13:03:55 *** ChanServ sets mode: +o bwolfe
13:04:02 <rafa> dkayiwa: ohh where are they stored?
13:04:43 <dkayiwa> rafa: in the liquibasechangelog table
13:05:04 <rafa> dkayiwa: I could have guess ;) cool
13:05:09 <rafa> dkayiwa: thanks
13:05:10 <dkayiwa> :)
13:06:11 *** jportela has joined #openmrs
13:06:11 *** ChanServ sets mode: +v jportela
13:21:49 *** upul` has joined #openmrs
13:21:49 *** ChanServ sets mode: +v upul`
13:29:01 *** wyclif has joined #openmrs
13:36:56 *** upul`` has joined #openmrs
13:36:56 *** ChanServ sets mode: +v upul``
13:37:34 *** upul` has quit IRC
13:37:41 *** upul`` is now known as upul`
13:39:54 *** downeym has joined #openmrs
13:39:54 *** ChanServ sets mode: +o downeym
13:39:54 *** OpenMRSBot sets mode: +o downeym
13:43:05 *** upul` has quit IRC
13:46:48 <dkayiwa> hi rafa
13:46:59 <rafa> dkayiwa: yes?
13:47:09 <dkayiwa> rafa: did you drop the uuid field from the encounter_provider table?
13:47:36 <rafa> dkayiwa: I thought I added it.
13:47:56 <rafa> dkayiwa: It wasn't there before.
13:48:26 <rafa> dkayiwa: ohh I forgot to add it in liquibase :/
13:48:30 <dkayiwa> rafa: i have dropped the table, after removing the changeset you changed, and then had liquibase recreate the table for me. but it misses the uuid field
13:48:55 <dkayiwa> ok
13:49:00 <rafa> dkayiwa: you're entirely right
13:49:05 <dkayiwa> ok
13:52:12 <rafa> dkayiwa: is it enought to delete all entries from liquibasechangelog?
13:52:36 <dkayiwa> rafa: that will get you into lots of trouble :)
13:52:44 <rafa> dkayiwa: I thought so :)
13:52:54 <dkayiwa> for it will try recreate the entire database
13:53:36 <rafa> dkayiwa: do you have any sql to delete just last three at hand?
13:53:37 <dkayiwa> rafa: i only delete the validation failed changeset (and if it has created some objects before it got changed, i also delete these objects)
13:54:07 <dkayiwa> rafa: last three changesets?
13:54:17 <rafa> yeah
13:54:41 <dkayiwa> rafa: yes we can build one by first getting the changeset ids
13:54:54 <rafa> dkayiwa: okay, I'll do it manually :)
13:55:02 <dkayiwa> rafa: i use navicat and i just ctrl + f to find the rows
13:55:13 <dkayiwa> and then manually delete them
13:56:11 <rafa> dkayiwa: I'm a console guy ;)
13:56:25 <dkayiwa> rafa: :D hard core guy
13:57:25 <bwolfe> I use both
13:57:33 <dkayiwa> hahahahaha
13:57:33 <bwolfe> but tend towards console
13:57:37 <dkayiwa> lolll
13:57:57 <bwolfe> for a lot of things its silly to use console though. (creating tables, finding rows, modifying single rows, etc)
13:58:00 <dkayiwa> i use console only as last resort :)
14:04:09 <bwolfe> djazayeri, dkayiwa, rafa, wyclif, (aja?): scrum time
14:05:43 <djazayeri> hi
14:05:51 <djazayeri> sure
14:05:59 <wyclif> hi
14:06:55 <djazayeri> dkayiwa, rafa: I believe it's supposed to be safe to delete everything from liquibasechangelo
14:09:09 *** surangak has quit IRC
14:09:17 <bwolfe> /supposed to be/
14:11:48 <bwolfe> wyclif, you want to go first?
14:12:45 <wyclif> ok
14:13:34 <rafa> (dkayiwa: I commited the fix)
14:13:44 <dkayiwa> ok
14:13:50 <dkayiwa> thanjs
14:13:53 <dkayiwa> j=k
14:15:11 <wyclif> yesterday:
14:15:11 <wyclif> - Fixed review comments for reviewed tickets(SMART-7, SMART-19)
14:15:11 <wyclif> - Ceated worked on on SMART-20(progesses well but didnt complete it)
14:15:11 <wyclif> - Had a skype call with Taras and reviewed the project's dodumentation wiki page he wrote
14:15:11 <wyclif> today:
14:15:12 <wyclif> - Finish and commit code for SMART-20
14:15:14 <wyclif> - Work on other sprint tickets
14:15:30 <wyclif> sorry yesterday -> friday
14:16:17 <wyclif> no blockers
14:16:50 <djazayeri> !ticket smart-7
14:16:51 <OpenMRSBot> djazayeri: [#SMART-7] Add/modify SMART data type - Medication - OpenMRS JIRA - https://tickets.openmrs.org/browse/smart-7
14:16:55 <djazayeri> !ticket smart-19
14:16:56 <OpenMRSBot> djazayeri: [#SMART-19] Add unit tests - OpenMRS JIRA - https://tickets.openmrs.org/browse/smart-19
14:17:01 <djazayeri> !ticket smart-20
14:17:02 <OpenMRSBot> djazayeri: [#SMART-20] NPE when uploading invalid app - OpenMRS JIRA - https://tickets.openmrs.org/browse/smart-20
14:18:35 <djazayeri> Okay
14:18:44 <djazayeri> wyclif: how is the spike on oauth going?
14:18:49 <djazayeri> spike->work
14:19:15 <wyclif> completed that last week, am actually coding it now
14:19:34 <wyclif> apparently, am not using oauth
14:19:35 <djazayeri> okay, didn't see it on your report. :-)
14:19:53 <wyclif> had a couple of comments on the ticket
14:19:57 * bwolfe thinks he missed it
14:20:23 *** cta has joined #openmrs
14:20:28 <cta> hello
14:20:29 <wyclif> one thing i forgot to mention is that we are not using oauth as such
14:21:07 <bwolfe> how are we using it then?
14:21:09 <bwolfe> hi taras
14:21:40 <wyclif> because josh didn't since the server and the apps are on running in the same app
14:22:16 <wyclif> i generate and assign tokens
14:22:40 <wyclif> that the apps send back via the authorization header
14:22:59 <wyclif> probaly they could just send it as a request parameter
14:23:04 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): Displaying multiple providers on patientEncounters portlet - TRUNK-2263 <http://feedproxy.google.com/~r/OMRStrunk/~3/2BF279pSMvE/OpenMRS> || New Changeset: OpenMRS (providers): TRUNK-2260: Add Encounter.providers property and deprecate old Encounter.provider property ... <http://feedproxy.google.com/~r/OMRStrunk/~3/hKsvQDv5rsU/OpenMRS>
14:23:31 <bwolfe> wyclif, ok
14:23:36 <bwolfe> wyclif, which ticket is the oauth work?
14:23:43 <bwolfe> (not the oauth spike)
14:23:45 <wyclif> sorry for the typos
14:24:06 <wyclif> SMART 24
14:24:23 <bwolfe> !ticket SMART-24
14:24:24 <OpenMRSBot> bwolfe: [#SMART-24] Limit access to the SMART Rest API to only authenticated apps - OpenMRS JIRA - https://tickets.openmrs.org/browse/SMART-24
14:24:36 <bwolfe> there you go djazayeri
14:24:47 <bwolfe> ok, who's up next?
14:24:59 <bwolfe> actually, I can go
14:25:06 <bwolfe> that way we keep the smart guys together
14:25:09 <bwolfe> :-D
14:25:12 <bwolfe> today:
14:25:13 <bwolfe> emails from the weekend
14:25:13 <bwolfe> trunk reviews
14:25:13 <bwolfe> a few leftover occ reviews
14:25:13 <bwolfe> smart reviews that I somehow missed
14:25:15 <bwolfe> finished up the Smart allergy ticket - SMART-10
14:25:17 <bwolfe> tomorrow:
14:25:19 <bwolfe> smart reviews + ticket?
14:25:21 <bwolfe> blocker: darius, is it you or me for the 1 week occ sprint?
14:25:45 <djazayeri> Let's discuss after this scrum
14:26:13 <bwolfe> noted
14:26:31 <bwolfe> rafa, are you ready?
14:26:49 <rafa> as always
14:26:54 <rafa> *** Rafal ***
14:26:54 <rafa> Today:
14:26:54 <rafa> * Corrected:
14:26:54 <rafa> - TRUNK-2260: Add Encounter.providers property and deprecate old Encounter.provider property
14:26:54 <rafa> https://tickets.openmrs.org/browse/TRUNK-2260
14:26:54 <rafa> - TRUNK-2261: Liquibase script to migrate legacy Encounter.provider data to Encounter.providers
14:26:54 <rafa> https://tickets.openmrs.org/browse/TRUNK-2261
14:26:54 <dkayiwa> :)
14:26:55 <rafa> Tomorrow:
14:26:55 <rafa> * Correct TRUNK-2394: Can we use the search widget to "list all items" too?
14:26:56 <rafa> https://tickets.openmrs.org/browse/TRUNK-2394
14:26:56 <rafa> * Start with TRUNK-2566: When you first open the Manage Providers page the search widget should auto-fetch the first page of results and display them.
14:26:57 <rafa> https://tickets.openmrs.org/browse/TRUNK-2566
14:26:57 <rafa> No blockers.
14:29:13 <bwolfe> 'dems a lot on your plate.
14:29:26 <bwolfe> are you close to finishing those, or are you just blocking off a bunch so that dkayiwa has nothing to work on? ;-)
14:29:34 <dkayiwa> :)
14:29:35 <djazayeri> the ones he's listed for tomorrow aren't that big...
14:29:50 <djazayeri> most of those are "corrected"
14:31:08 <djazayeri> Okay, I'll go
14:31:18 <djazayeri> Friday:
14:31:18 <djazayeri> * Finish TRUNK-2574 (UI for Location Attribute Types)
14:31:18 <djazayeri> * Almost finished TRUNK-2580 (date attributes stored in locale-dependent format)
14:31:18 <djazayeri> * code review
14:31:19 <djazayeri> Today:
14:31:19 <djazayeri> * Do TRUNK-2575 (UI for Location Attributes)
14:31:20 <djazayeri> * Look at merging Lu's metadata localization branch
14:31:20 <djazayeri> * Plan for next sprint
14:31:21 <djazayeri> * Code reviews
14:31:30 <djazayeri> no blockers, besides deciding with ben what the next sprint will look like
14:32:36 <djazayeri> dkayiwa: your turn
14:32:40 <bwolfe> Lu's branch had some fixes that were needed
14:32:54 <bwolfe> mike looked into it at one point. or looked into merging it a little bit longer than I did
14:32:54 <dkayiwa> Did some code review
14:32:55 <dkayiwa> Read my gsoc student documentation and had a chat with him about it
14:32:55 <dkayiwa> Fixed failing liquibase changeset
14:32:55 <dkayiwa> Worked on: patientEncounters portlet should display multiple providers - TRUNK-2263
14:32:56 <dkayiwa> Now working on second pass of this ticket where am to add a global property that controls what encounter roles are displayed on the provider column of this portlet.
14:32:56 <dkayiwa> And i have a question, should i use encounter role ids or names in the global property? e.g 1,2,3 or ROLE 1, ROLE 2, ROLE 3 ?
14:33:06 <bwolfe> djazayeri, you might want to check with him.
14:33:13 <djazayeri> bwolfe: yup, will do, thanks
14:33:38 <bwolfe> djazayeri, merging will be the hardest part. might be easier to get it committed and then update the few things we mentioned in the review
14:34:07 <bwolfe> dkayiwa, use both
14:34:18 <bwolfe> dkayiwa, either should work
14:34:24 <djazayeri> dkayiwa: i.e. you should support "1,My Role,3"
14:34:30 <dkayiwa> oh
14:35:05 <dkayiwa> and try getRoleByName, getRoleById ?
14:35:26 <djazayeri> yes
14:35:33 <dkayiwa> ok
14:36:19 <bwolfe> you should check by id first, then name
14:36:27 <dkayiwa> ok
14:36:29 <bwolfe> so that someone can't screw up and name their role "13"
14:36:33 <dkayiwa> ok
14:37:30 *** wyclif has quit IRC
14:37:32 <bwolfe> was that everyone?
14:37:39 <bwolfe> aja isn't in here for some reason...
14:37:40 <djazayeri> yes
14:38:20 <jriley> If you're done, can I get some help with submitting updates for a contrib project?
14:39:54 * jriley takes the silence for confirmation that you're done
14:39:58 <djazayeri> yes
14:40:10 <djazayeri> (back in 2 minutes though)
14:40:21 <djazayeri> also, ben and I will be cross-talking
14:40:22 *** gbastien has joined #openmrs
14:40:27 <jriley> I've updated contrib/csv-concept-importer to work with 1.7.1
14:41:08 <jriley> It's a PIH project. I talked with Mike Seaton about it a couple weeks ago. He was going to check with cneumann, the original contributor, but thought that would be fine
14:41:15 <bwolfe> jriley, nice.
14:41:21 <jriley> I have ulterior motives :)
14:41:26 <jriley> I have a lot of concepts to import
14:41:29 <jriley> So, the changes I made are:
14:41:30 <bwolfe> who doesn't?
14:41:31 <bwolfe> :-)
14:41:38 <jriley> That's the beauty of open source projects
14:41:41 <jriley> So, the changes I made:
14:41:52 <bwolfe> http://wiki.openmrs.org/display/docs/Code+Repository#CodeRepository-RequestingRepositoryAccess
14:41:53 <OpenMRSBot> <http://ln-s.net/8m_A> (at wiki.openmrs.org)
14:42:08 <jriley> * Updated to 1.7 . The original was written against 1.5 . There were changes with names (name tags no longer work) , and 1.7 uses locales a lot.
14:42:21 <jriley> * Mavenized, because I was adding every jar I could find to the classpath
14:42:38 <bwolfe> djazayeri, I'll probably be leading the sync sprint in a few weeks, so was thinking you were itching to lead a sprint and so wanted the occ 1 weeker. ;-)
14:42:40 <jriley> * Added BaseSensitiveContext unit tests ( a key motive in mavenizing)
14:42:52 *** goutham has quit IRC
14:42:54 <jriley> * ... and a bazillion tests, that test against the standard data
14:43:15 <jriley> * added import functions for mappings, synonyms, and search terms
14:43:30 <jriley> Things left to do:
14:43:57 <jriley> * look at how things are logged to the do-over log -- I realized I need to put them in csv format
14:44:33 <jriley> * I expect to make changes as I finish importing my own data. Hopefully not bugs, but maybe some ways to make it work better as a library
14:44:46 <jriley> * Need to rewrite the readme for users
14:44:55 <jriley> * Need to package it as a standalone that contains all the jars it needs
14:45:19 <jriley> It would be swell to get it under source control before it's perfect and releasable. I back up my machine, but there's nothing like source control to make you sleep well at night
14:46:54 <djazayeri> jriley: Someone should definitely write a final exam question as a multiple choice fill-in-the-blank version of: "there's nothing like ___ to make you sleep well at night"
14:46:56 <jriley> I'll send an email to Mike (and cneumann) to reconfirm they're happy with the change
14:46:59 <djazayeri> (the answer, of course, is source control)
14:47:04 <jriley> no! it's unit tests!
14:47:10 <jriley> wait, wait, it's both!
14:47:18 <jriley> how can I choose?
14:47:36 <djazayeri> Is christian's 1.5-version of the code already in source control?
14:47:42 <jriley> Yes, that's where I got it
14:47:54 <djazayeri> under contrib?
14:47:54 <jriley> So how should this be branched?
14:47:56 <jriley> ues
14:47:57 <jriley> yes
14:48:01 <jriley> csv-concept-importer
14:48:13 <jriley> https://source.openmrs.org/browse/contrib/csv-concept-importer
14:48:17 <OpenMRSBot> <http://ln-s.net/96Se> (at source.openmrs.org)
14:48:40 <djazayeri> When was the last change Christian and/or Mike made to it? (I.e. is their version under active development?)
14:49:01 <bwolfe> I'm guessing it doesn't need to be branched
14:49:17 <djazayeri> It's good style to branch it
14:49:22 <jriley> browsing the top level, dec. 10 for classpath and june/july 2010 for others
14:49:35 <jriley> it's not backwards compatible with OpenMRS < 1.7
14:49:37 <djazayeri> okay, so not much active work going on
14:50:00 <djazayeri> so, what you should really do is:
14:50:09 *** wyclif has joined #openmrs
14:50:11 <djazayeri> 1. create a trunk folder under csv-concept-importer
14:50:21 <djazayeri> 2. move what's currently in svn into that folder
14:50:26 <bwolfe> not active, you've be branching it for a version thats EOL (1.5), and the target audience is someone starting a new impl. very low liklihood of it needing to be branched
14:50:34 <djazayeri> 3. create csv-concept-importer/branches
14:50:39 <bwolfe> why not wait to branch until its really an issue?
14:50:49 <djazayeri> 4. create/branches/1.5-compatible
14:51:05 <djazayeri> (by copying the old trunk to there)
14:51:05 <bwolfe> https://wiki.openmrs.org/display/docs/Module+Branching
14:51:21 <jriley> I'll follow whatever the standard is
14:51:29 <jriley> The old one works with 1.6 as well
14:51:38 <jriley> Ah! Thank you
14:51:39 <djazayeri> 5. then svn switch your code to point to the new trunk folder, and commit
14:52:06 <djazayeri> bwolfe: since her commit is going to make some currently-used code no longer usable by its original author, she should branch.
14:52:24 <djazayeri> jriley: so /branches/1.6-compatible
14:52:32 <djazayeri> actually, nm, call it 1.5-compatible
14:52:38 <djazayeri> because it's 1.5+
14:52:41 <djazayeri> (until 1.7
14:53:32 <djazayeri> bwolfe: so, I can be sprint leader next week, so you can properly prep for the sync sprint
14:53:40 <djazayeri> But the question is what the sprint will focus on.
14:53:54 <djazayeri> Burke and I were playing around with: https://wiki.openmrs.org/display/docs/Road+Map+%28Design+Page%29
14:53:57 <OpenMRSBot> <http://ln-s.net/96Sk> (at wiki.openmrs.org)
14:54:43 <djazayeri> and we noticed that while we intend to release 1.9 alpha in mid-October, we don't have much time allocated to it.
14:54:48 *** mario_ has joined #openmrs
14:54:58 <downeym> Hi mario_ and welcome to the #openmrs IRC channel.
14:55:03 <djazayeri> so we need to "create" some time for that.
14:55:04 <mario_> buenos dias Daruis
14:55:09 <djazayeri> hola mario_
14:55:16 <mario_> como a todo
14:55:17 <bwolfe> djazayeri, and we also need time alloted to getting some trunk code review backlog done
14:55:25 <djazayeri> bwolfe: true
14:56:06 <djazayeri> bwolfe: so, the key question is: if we do a 1 week OCC followup sprint, are we guaranteed to have that code in a workable state, such that we can and _will_ deploy it in production?
14:56:17 <mario_> Darius una pregunta, hay algun modulo o de que forma se puede hace una carga masiva de usuarios y de pacientes en la plataforma
14:56:48 <djazayeri> translation: is there a module or mechanism to do a massive upload of users and patients?
14:56:52 <jriley> Ok. Let me read over all that and get started
14:56:53 <bwolfe> djazayeri, I'd like to think so. but I'd put the chances of that at 70% right now
14:56:56 <jriley> Thanks
14:57:03 <djazayeri> mario_: un momento
14:57:36 <djazayeri> bwolfe: You think we'll be ready to re-release OCC and push people to start using it?
14:57:37 <mario_> ok
14:58:19 <bwolfe> djazayeri, for the simple cases? yes. but the problem is that there will probably be unforeseen bugs and/or highly requested features thereafter
14:58:23 <djazayeri> Tomorrow I plan to talk to one of the thoughtworks guys here to see if someone can do a spike on burke's idea of using solr on the server-side
14:58:43 <bwolfe> ok
14:59:26 <bwolfe> djazayeri, we can also break up sprints and not having everyone on each task
14:59:34 <djazayeri> bwolfe: true.
14:59:42 <bwolfe> e.g, a few of the guys can peel off of sync
14:59:43 *** chopin has joined #openmrs
14:59:48 <chopin> hey ppl
15:00:10 <djazayeri> bwolfe: anyway, I'll take care of planning next week's sprint, and you can properly plan for sync
15:00:12 <djazayeri> hola mario_
15:00:34 <djazayeri> No se si hay un modulo que sirve especificamente para esto
15:00:47 <djazayeri> pero puede ser que la manera mas facil seria usar los web services
15:00:50 <bwolfe> djazayeri, sounds good
15:01:00 <bwolfe> gotta go help make dinner
15:01:01 <bwolfe> bbl
15:01:24 <chopin> did we change something in 1.7 or 1.8 so that forms no longer show a new changedBy when the schema is changed?
15:01:33 <chopin> (same question for question sets with new answers)
15:01:40 <mario_> en el wiki encuntro informaciond e como poderlos utilizar?
15:02:40 <djazayeri> mario_: https://wiki.openmrs.org/display/docs/Webservices.rest+Module
15:02:41 <OpenMRSBot> <http://ln-s.net/92SZ> (at wiki.openmrs.org)
15:03:09 <djazayeri> chopin: I think sometime around there we started setting changedBy and dateChanged through a hibernate interceptor instead of a handler
15:04:37 <mario_> Darius ustedes ya los han utilizado para este proposito?
15:04:50 <djazayeri> mario_: son muy nuevos
15:05:22 <djazayeri> definitamente se puede usarlos para crear pacientes, y usuarios.
15:05:57 <djazayeri> mario_: hay tambien unos modulos que permiten cargar datos en hojas de calculo de excel
15:06:49 <mario_> ok voy a leer la documentacion.
15:07:20 <mario_> Darius pero esos moduloe crean el archivo de excel o del archivo de excel se sube a la plataforma
15:08:21 <mario_> Darius con los datos del archivo de excel se crean los pacientes y los usuarios?
15:11:42 <djazayeri> mario_: se usa los modulos para subir un archivo de excel que creaste con los datos
15:11:56 <djazayeri> pero almenos uno de los modulos necesita mucha customizacion
15:12:45 <chopin> djazayeri: yeah, that was done in 1.8 ... but does that mean i need to do something to notify the interceptor (like implement Auditable)?
15:12:58 <djazayeri> chopin: I don't know
15:13:05 <chopin> foo ... k
15:13:06 <chopin> thanks
15:15:14 <mario_> Daruis cuales serian los modulos?, yo los miro junto con los web service y analizo cual nos serviria mas. Darius Pero usted recomienda mejor utilizar los web service?
15:16:59 <dkayiwa> hi rafa
15:17:09 <rafa> hi
15:17:18 <rafa> more problems? :/
15:17:27 <dkayiwa> hahaha
15:17:32 <rafa> what did I do?
15:17:44 <dkayiwa> rafa: for encounter_provider, did you give uuid a default value?
15:17:57 <rafa> no
15:18:16 <rafa> dkayiwa: It's a new table
15:18:26 <rafa> dkayiwa: There should be any rows there
15:18:31 <rafa> shouldn't be
15:18:31 <dkayiwa> rafa: looks like the insert does not add the uuid
15:19:22 <dkayiwa> rafa: but it does not allow nulls
15:19:23 <rafa> you mean when you call encounterService.saveEncounter?
15:19:44 <dkayiwa> rafa: this changeset provider_id
15:19:57 <djazayeri> mario_: tengo una llamada, espera
15:20:08 <dkayiwa> rafa: am talking of this changeset 20110819-1500-migrate-providers-to-encounter-provider-table
15:20:11 <mario_> ok, no hay problema.
15:20:51 <dkayiwa> rafa: it does not seem to insert a uuid yet it is defined as NOT NULLABLE
15:21:08 <dkayiwa> rafa: so the upgrade fails
15:21:11 <rafa> dkayiwa: I get it now. You're right again
15:23:50 <rafa> dkayiwa: I think I fixed it now, but let me check it from scratch. I forgot to add some data to test it properly the last time.
15:24:00 <dkayiwa> ok
15:28:03 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @ScottMuc: Redid a patch for @OpenMRS (http://t.co/FMw6Cm3). Already a productive coffee and code session. <http://twitter.com/OpenMRS/statuses/105652204215611392> || On Twitter: OpenMRS: RT @joaoppcportela: Hello world, let me introduce you my #GSOC project: http://t.co/vdazTwn here @OpenMRS #fb <http://twitter.com/OpenMRS/statuses/105652165888057344> || New Changeset: OpenMRS (providers): TRUNK-2261: Liquibase script to migrate legacy Encounter.provider data to Encounter.providers... <http://feedproxy.google.com/~r/OMRStrunk/~3/YZSKXWzder8/OpenMRS>
15:46:23 *** upul` has joined #openmrs
15:46:23 *** ChanServ sets mode: +v upul`
15:53:23 <rafa> dkayiwa: I think I got it right now. I'm sorry for your troubles.
15:53:35 <dkayiwa> no problem
15:55:40 <djazayeri> mario_: una opcion es el "Spreadsheet Upload Module". https://wiki.openmrs.org/x/yg4z Eso requiere escribir codigo—puedes ver un ejemplo aqui: http://svn.openmrs.org/openmrs-modules/pihlesothotbupload/web/src/org/openmrs/module/pihlesothotbupload/web/controller/LesothoTbUploadController.java
15:55:46 <OpenMRSBot> <http://ln-s.net/96TR> (at svn.openmrs.org)
15:56:14 <djazayeri> mario_: otra opcion es "Spreadsheet Import Module" https://wiki.openmrs.org/x/eQ8z
15:57:55 <djazayeri> pero puede ser que la solucion mejor es usar web services
15:58:20 <djazayeri> mario_: que exactamente quieren cargar? Paciente+nombre+direccion? O tambien encounters y obs?
16:01:40 <mario_> por el momento solo atributos relacionados con el paciente y usuarios, nombres direccion fehca de nacimiento, etc
16:03:40 *** jportela has left #openmrs
16:04:03 *** Suranga has joined #openmrs
16:05:17 *** upul`` has joined #openmrs
16:05:17 *** ChanServ sets mode: +v upul``
16:05:23 *** upul` has quit IRC
16:13:04 *** upul``` has joined #openmrs
16:13:04 *** ChanServ sets mode: +v upul```
16:13:09 *** upul`` has quit IRC
16:13:12 *** upul``` is now known as upul`
16:13:18 <downeym> Hi upul` and welcome to the #openmrs IRC channel.
16:13:25 *** downeym has quit IRC
16:15:08 <djazayeri> mario_: por ejemplo, este command va crear un paciente con web services:
16:15:17 <djazayeri> echo '{
16:15:18 <djazayeri>   "preferredIdentifier":{
16:15:18 <djazayeri>     "identifier":"abc123ez",
16:15:18 <djazayeri>     "identifierType":"8d79403a-c2cc-11de-8d13-0010c6dffd0f",
16:15:18 <djazayeri>     "location":"Unknown Location"},
16:15:18 <djazayeri>   "preferredName":{
16:15:19 <djazayeri>     "givenName":"Darius",
16:15:19 <djazayeri>     "familyName":"Programmer"},
16:15:20 <djazayeri>   "birthdate":"1978-01-15",
16:15:20 <djazayeri>   "gender":"M"
16:15:21 <djazayeri> }'
16:17:02 <djazayeri> (o algo muy similar)
16:20:19 <mario_> Darius cargria el modulo de ws y ejecutaria ese comando?
16:21:06 <djazayeri> hey que enviar un POST al servidor. lo puedes hacer con curl, o con otro metodo
16:21:13 <djazayeri> depende de donde salen los datos
16:21:44 <mario_> Darius ese ejemplo nos serviria. Darius se podria crear un xml que se lo consuma el servicio y cargue los datos?
16:22:16 <mario_> el xml tendria todos los datos de todos los usuarios a almacenar
16:22:26 <djazayeri> ya tienen en formato xml?
16:22:56 <djazayeri> tendran que escribir el codigo para convertir entre xml y json
16:23:01 <mario_> no tengo que crearlos con los datos que se van a cargar
16:23:21 <djazayeri> (osea, se puede tambien cargar datos como xml, pero no se exactamente cual es el syntax
16:23:48 <djazayeri> una cosa mas, creo que ahora el url es .../openmrs/ws/rest/v1/patient
16:24:29 *** upul` has quit IRC
16:26:27 <mario_> Darius ese url lo cargo local o se puede ver en el demo de openmrs?
16:26:45 <djazayeri> el modulo web services no esta cargado en el dmo
16:26:58 *** upul` has joined #openmrs
16:26:58 *** ChanServ sets mode: +v upul`
16:27:03 <djazayeri> puedes bjar una instalacion standalone
16:27:12 <djazayeri> que ya tiene todo
16:29:53 <mario_> ok, voy hacer eso y a probar como cargar los datos
16:30:14 <mario_> Gracias Darius
16:30:24 <djazayeri> de nada
16:32:44 *** dkayiwa has quit IRC
16:33:52 *** goutham has joined #openmrs
16:38:12 *** upul` has quit IRC
16:38:49 *** rafa has quit IRC
16:41:10 *** gauravpaliwal has joined #openmrs
16:41:10 *** ChanServ sets mode: +v gauravpaliwal
16:41:56 *** dkayiwa has joined #openmrs
16:42:17 <gauravpaliwal> bwolfe: djazayeri: dkayiwa is their any openmrs sample odp/ppt template exists ?
16:42:27 <gauravpaliwal> over the wiki
16:59:32 *** jriley has left #openmrs
17:03:22 *** Suranga has quit IRC
17:05:38 *** pascal` has joined #openmrs
17:08:39 *** pascal` has quit IRC
17:09:28 *** suho has joined #openmrs
17:09:28 *** ChanServ sets mode: +v suho
17:09:49 *** gauravpaliwal has left #openmrs
17:15:53 <suho> hi bwolfe
17:16:08 <suho> I have created a new version of ncd
17:16:44 <suho> since I dont have rights to the repository i have issues in uploading that
17:18:36 <suho> I'm getting this error : "The user 'suho' is not authorized to edit module 'ncd'"
17:22:09 <djazayeri> suho: I granted you permission
17:22:11 <djazayeri> try now
17:22:20 <suho> thanks
17:28:19 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): TRUNK-2261: Liquibase script to migrate legacy Encounter.provider data to Encounter.providers ... <http://feedproxy.google.com/~r/OMRStrunk/~3/0b8wqX-X23Y/OpenMRS> || New Changeset: OpenMRS (providers): TRUNK-2261: Liquibase script to migrate legacy Encounter.provider data to Encounter.providers ... <http://feedproxy.google.com/~r/OMRStrunk/~3/D13QwrBz4PI/OpenMRS>
17:28:35 <suho> thanks djazayeri It works now
17:38:58 *** jriley has joined #openmrs
17:49:03 *** goutham has quit IRC
17:54:45 *** rafa has joined #openmrs
17:54:49 *** ChanServ sets mode: +v rafa
17:54:54 *** downeym has joined #openmrs
17:54:54 *** ChanServ sets mode: +o downeym
17:54:54 *** OpenMRSBot sets mode: +o downeym
17:57:19 <cta> bwolfe: Ben, thank you for review. You comment were really helpful. More over, you have pointed out me to some cagey bug, and its great. So, I went through your comments and made corresponding changes within code, tested them and then committed code into my branch. So, thank you one more time.
17:58:27 <bwolfe> cta, I did 10+ reviews today...which ticket was that? :-)
18:00:23 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: NCD 1.3 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=ncd&ampversion=&amp1.3>
18:00:53 <cta> Ben, sorry, I did not know ;-) I meant comments on review CR-TRUNK-462 (Localize setup wizard).
18:01:09 <cta> bwolfe: ;-) sorry
18:01:17 <bwolfe> ah yes. the remember me parameter ?
18:01:24 <cta> ye
18:02:18 <cta> bwolfe: I made double mistake and, in fact everything worked, but you helped me to fix these mistakes
18:03:27 <bwolfe> it just would have broken later?
18:03:29 <bwolfe> :-)
18:05:38 <cta> bwolfe: yep, if you had not noticed that bug, everything would be broken in future, but now I fixed that, Thanx!
18:08:55 <bwolfe> np. thats one reason for code review.
18:10:15 *** bryq1 has joined #openmrs
18:11:20 *** bryq has quit IRC
18:15:14 *** jportela has joined #openmrs
18:15:14 *** ChanServ sets mode: +v jportela
18:17:51 <djazayeri> downeym: how do we put things on our youtube channel? Specifically, if bryq1 pre-records his demo, where should we put it?
18:21:21 <downeym> djazayeri bryq1 - unfortunately there's no distributed upload but if you can get it to me (i can provide an upload site) i can get it onto youtube in short order
18:21:22 *** mario_ has quit IRC
18:32:31 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): DateAttributeHandler needs to store data in locale-independent format - TRUNK-2580 <http://feedproxy.google.com/~r/OMRStrunk/~3/1vfaRfs9be8/OpenMRS> || New Changeset: OpenMRS (localize-setup-wizard): TRUNK-2055 : fixed last after-review comments (see CR-TRUNK-462) <http://feedproxy.google.com/~r/OMRStrunk/~3/GLvmNevnzZA/OpenMRS>
19:09:04 *** james_regen has left #openmrs
19:18:03 <bryq1> downeym: Thanks, I'll contact you if I pre-record my demo
19:19:15 *** wyclif has quit IRC
19:19:30 <downeym> bryq1: ok, let me know and i'm happy to help :)
19:21:12 <djazayeri> downeym: build failed on the server but worked fine for me when I built locally.
19:26:22 <downeym> djazayeri: did you check out its logs? https://ci.openmrs.org/browse/JUNIT-TRUNK-JOB1-1265/log
19:26:30 <OpenMRSBot> <http://ln-s.net/96Wf> (at ci.openmrs.org)
19:26:39 <downeym> several screens worth of errors, it looks like
19:34:25 <djazayeri> downeym: I did look. Lots of those error messages are "expected"
19:34:35 <djazayeri> (burke has pointed out that this is not good behavior)
19:35:08 <cta> buy, guys
19:35:11 *** cta has quit IRC
19:36:14 <downeym> djazayeri: ok yeah i see that as i look closer - sorry. i kicked off the tests again and they all succeeded ok
19:36:26 <djazayeri> ah, great. I should have just tried that.
19:36:52 <downeym> np
19:37:46 *** wyclif has joined #openmrs
19:45:18 *** pascal` has joined #openmrs
19:48:03 *** pascal` has quit IRC
19:52:14 *** pascal` has joined #openmrs
19:56:34 *** rafa has quit IRC
20:06:45 *** jportela has left #openmrs
20:13:17 *** chopin has quit IRC
20:17:55 *** rafa has joined #openmrs
20:17:55 *** ChanServ sets mode: +v rafa
20:29:57 *** dkayiwa has quit IRC
20:37:35 *** suho has quit IRC
20:41:37 <djazayeri> rafa: bwolfe points out that you can say "require this other changeset" in a precondition
20:41:42 <djazayeri> that's the way to split that one up
20:42:21 <rafa> good
20:42:31 <rafa> thanks
20:43:03 *** pascal` has quit IRC
20:44:33 *** jportela has joined #openmrs
20:44:33 *** ChanServ sets mode: +v jportela
20:47:08 *** downeym_ has joined #openmrs
20:47:08 *** ChanServ sets mode: +o downeym_
20:49:24 *** downeym has quit IRC
20:49:24 *** downeym_ is now known as downeym
20:56:15 *** downeym has quit IRC
21:02:11 *** rafa has quit IRC
21:09:02 *** gbastien has quit IRC
21:27:29 *** bwolfe has quit IRC
21:49:55 *** bryq1 has quit IRC
22:11:16 *** jportela has left #openmrs
22:35:55 *** wyclif has quit IRC
22:45:42 *** gbastien has joined #openmrs
22:48:52 *** gbastien has quit IRC
23:01:41 *** jriley has quit IRC
23:06:20 *** gbastien has joined #openmrs
23:21:24 *** wyclif has joined #openmrs