| 00:33:21 | *** gbastien has joined #openmrs |
| 01:25:15 | *** gagaman has quit IRC |
| 01:31:16 | *** gbastien has quit IRC |
| 01:37:06 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Follow up commit fixing javadocs - TRUNK-2461 <http://feedproxy.google.com/~r/OMRStrunk/~3/yNAHaYrBVc4/OpenMRS> |
| 02:10:02 | *** jriley has quit IRC |
| 02:22:23 | *** wluyima has joined #openmrs |
| 02:22:23 | *** wyclif has quit IRC |
| 02:22:53 | *** wluyima has quit IRC |
| 02:23:13 | *** wyclif has joined #openmrs |
| 02:55:35 | *** upul` has joined #openmrs |
| 02:55:35 | *** ChanServ sets mode: +v upul` |
| 03:20:47 | *** yanokwa has joined #openmrs |
| 03:20:47 | *** ChanServ sets mode: +v yanokwa |
| 03:55:20 | *** surangak has joined #openmrs |
| 03:57:03 | *** gagaman has joined #openmrs |
| 04:05:51 | *** mccallumg has joined #openmrs |
| 04:05:51 | *** ChanServ sets mode: +v mccallumg |
| 04:06:01 | <mccallumg> hi surangak |
| 04:06:09 | <surangak> mccallumg, helooo |
| 04:06:15 | <mccallumg> surangak: how are you doing? |
| 04:06:16 | <surangak> hows it going ? |
| 04:06:26 | <surangak> mmm... pretty much ok... |
| 04:07:15 | <surangak> I had created a ticket regarding some issues in our trunk |
| 04:07:30 | <surangak> https://tickets.openmrs.org/browse/TRUNK-2563 |
| 04:07:50 | <surangak> thease are basically stuff that are broken in the trunk, but are affecting us... |
| 04:08:06 | <mccallumg> surangak: how tough is the fix? |
| 04:08:33 | <surangak> I've finished fixing the two issues i meantioned here |
| 04:08:45 | <surangak> i will be comittting them to my branch today... |
| 04:08:49 | <mccallumg> nice |
| 04:09:18 | <surangak> but, theres another issue apparently :) |
| 04:09:35 | <surangak> I fixed the ImageHandler, so thats working |
| 04:09:37 | <mccallumg> I'm just glad that we can keep finding work for you to do. |
| 04:09:48 | <surangak> but seems that the Texthandler is not working at all :) |
| 04:09:54 | <surangak> :D |
| 04:11:21 | <mccallumg> what happened to the text handler? |
| 04:11:31 | <surangak> the way I see it, text handler stored text files in our app data file |
| 04:11:42 | <mccallumg> ok |
| 04:11:48 | <surangak> the files are getting stored, but they are getting stored with no data inside |
| 04:11:55 | <mccallumg> hmmm... |
| 04:12:00 | <surangak> again, I could fix this problem |
| 04:12:13 | <mccallumg> yes. if you can. |
| 04:12:48 | <surangak> but im wondering if im doing anything wrong, because this is kinda a 'big' issue, and someone should have noticed if it was not working for them :) |
| 04:13:23 | <surangak> I talked to Darius yesterday, but apparently the guy who initially developed the handlers is not with us any more |
| 04:19:12 | <surangak> by 'not with us any more' I dont mean that the developer is dead :D |
| 04:19:42 | <mccallumg> surangak: you don't know that |
| 04:20:08 | <surangak> mccallumg, :D |
| 04:20:23 | <mccallumg> I'm not joking. Who developed it? |
| 04:20:46 | <surangak> mccallumg, actually, Darius had no idea who was involved in it.. |
| 04:20:56 | <surangak> mccallumg, I was going to ask Ben or daniel today.. |
| 04:21:40 | <mccallumg> surangak: ok. this is one regenstrief developer who died a year to two ago. He was young. I don't know the circumstances. |
| 04:21:49 | <mccallumg> _there is_ |
| 04:22:08 | <surangak> oh, Im verry sorry... I had no idea |
| 04:23:09 | <surangak> this is becomming a sensitive topic then... |
| 04:23:09 | <mccallumg> no need to be sorry |
| 04:23:39 | <surangak> should I come up with a 'battle plan' on how the text handler should look ? |
| 04:24:09 | <mccallumg> do we need to change the look of it? |
| 04:24:32 | <surangak> I dont think so... |
| 04:25:08 | <surangak> i needs some back end tweaking... plus changes to how these files will be displayed online |
| 04:25:22 | <mccallumg> ok. it is just a matter of debugging what it is dropping the file contents? |
| 04:25:31 | <surangak> yeps... |
| 04:25:35 | <mccallumg> _why_ |
| 04:25:47 | <surangak> plus need to come up with a way to display these files online |
| 04:25:57 | <mccallumg> how were they displayed before? |
| 04:25:59 | <surangak> they are not getting displayed online right now |
| 04:26:01 | <surangak> :) |
| 04:26:23 | <mccallumg> Can they be rendered via the mime filetype settings of the browser? |
| 04:26:41 | <surangak> I need to check this out..It may be possible |
| 04:27:08 | <surangak> in fact thats a very good idea you've given |
| 04:32:34 | *** muthah has quit IRC |
| 04:45:40 | *** mccallumg has quit IRC |
| 05:06:58 | *** djazayeri has joined #openmrs |
| 05:06:58 | *** ChanServ sets mode: +o djazayeri |
| 05:46:16 | *** yanokwa has quit IRC |
| 06:41:22 | *** pascal` has joined #openmrs |
| 06:49:37 | *** pascal` has quit IRC |
| 06:51:32 | *** pascal` has joined #openmrs |
| 07:07:29 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Follow up to fix test verifies tags - TRUNK-2461 <http://feedproxy.google.com/~r/OMRStrunk/~3/FlgpReMfgWM/OpenMRS> || New Changeset: OpenMRS (trunk): Follow up to remove log.warn and fix javadoc - TRUNK-2329 <http://feedproxy.google.com/~r/OMRStrunk/~3/K0jC7jNh350/OpenMRS> || New Changeset: OpenMRS (trunk): Added validation for patient program outcome - TRUNK-2329 <http://feedproxy.google.com/~r/OMRStrunk/~3/5b4oY8J6-tw/OpenMRS> || New Changeset: OpenMRS (providers): TRUNK-2259,Review for CR-TRUNK-450. Fixed the review comments. <http://feedproxy.google.com/~r/OMRStrunk/~3/7MxiAU5vdaI/OpenMRS> |
| 07:17:06 | *** rafa has joined #openmrs |
| 07:17:06 | *** ChanServ sets mode: +v rafa |
| 07:39:00 | *** bryq has joined #openmrs |
| 07:39:00 | *** ChanServ sets mode: +v bryq |
| 07:45:48 | *** rafa has quit IRC |
| 07:47:07 | *** rafa has joined #openmrs |
| 07:47:07 | *** ChanServ sets mode: +v rafa |
| 08:06:04 | *** gagaman has quit IRC |
| 08:11:34 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): TRUNK-2275,CR-TRUNK-457 - Fixed the review comments. <http://feedproxy.google.com/~r/OMRStrunk/~3/muw_1OVDqDc/OpenMRS> || Shazin Sadakath: Integrating EJB3 Session Bean with Spring Security 3 <http://shazsterblog.blogspot.com/2011/08/integrating-ejb3-session-bean-with.html> || Shazin Sadakath: MIT Problem Set Solution <http://shazsterblog.blogspot.com/2011/08/mit-problem-set-solution.html> || Shazin Sadakath: Java 7 Hands On <http://shazsterblog.blogspot.com/2011/08/java-7-hands-on.html> || Shazin Sadakath: Performance Testing <http://shazsterblog.blogspot.com/2011/08/performance-testing.html> |
| 08:25:00 | *** ChanServ sets mode: +v pascal` |
| 08:48:39 | *** magoo has joined #openmrs |
| 09:04:06 | *** magoo has quit IRC |
| 09:19:38 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Changes to ObsValidator, and controller... <http://feedproxy.google.com/~r/OMRStrunk/~3/-xmVoZ9wYuM/OpenMRS> |
| 09:42:02 | *** gauravpaliwal has joined #openmrs |
| 09:42:02 | *** ChanServ sets mode: +v gauravpaliwal |
| 10:27:40 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Merging Branch to Revision 22512 <http://feedproxy.google.com/~r/OMRStrunk/~3/fkood1wtJww/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Committing merged change previously overlooked <http://feedproxy.google.com/~r/OMRStrunk/~3/6xhMqcaOsxw/OpenMRS> || New Changeset: OpenMRS (providers): TRUNK-2275,CR-TRUNK-457 - Fixed the review comments on EncounterProvider.hbm.xml <http://feedproxy.google.com/~r/OMRStrunk/~3/hvWYnE_tVMk/OpenMRS> |
| 11:00:42 | *** surangak has quit IRC |
| 11:00:45 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: i2b2 Export 1.1.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=i2b2export&version=&1.1.0> |
| 11:01:02 | *** surangak has joined #openmrs |
| 11:08:35 | *** gauravpaliwal1 has joined #openmrs |
| 11:08:36 | *** gauravpaliwal has quit IRC |
| 11:15:32 | *** gagaman has joined #openmrs |
| 11:16:47 | *** james_regen has joined #openmrs |
| 11:16:47 | *** ChanServ sets mode: +v james_regen |
| 11:18:02 | *** gagaman has quit IRC |
| 11:19:12 | *** Gagaman2 has joined #openmrs |
| 11:19:41 | *** Gagaman2 has left #openmrs |
| 11:29:12 | *** ajanthan has joined #openmrs |
| 11:31:19 | *** Gagaman2 has joined #openmrs |
| 11:32:04 | *** gauravpaliwal1 has quit IRC |
| 11:32:08 | <Gagaman2> Hi! Is there anyone I could ask a question regarding XForms design? |
| 11:33:45 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 22572 <http://feedproxy.google.com/~r/OMRStrunk/~3/cMySmpkU0Ng/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 22514 : continued <http://feedproxy.google.com/~r/OMRStrunk/~3/Kbh3oNrz8zE/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 22514 <http://feedproxy.google.com/~r/OMRStrunk/~3/eahHv2viq8o/OpenMRS> |
| 11:36:00 | *** upul` has quit IRC |
| 11:51:35 | *** ajanthan is now known as aja |
| 12:07:47 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 22594 : cleaning up <http://feedproxy.google.com/~r/OMRStrunk/~3/dXKiRKZJZMg/OpenMRS> || New Changeset: OpenMRS (obs-codes-expanded): Updating Branch to Revision 22594 <http://feedproxy.google.com/~r/OMRStrunk/~3/Npkp-aAQwrg/OpenMRS> |
| 12:32:06 | *** wyclif has quit IRC |
| 12:33:33 | *** cta has joined #openmrs |
| 12:33:39 | <cta> hello |
| 12:41:50 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (obs-codes-expanded): Reverting changes from Revision 22594, Because its running into liquibase problems.... <http://feedproxy.google.com/~r/OMRStrunk/~3/tDx8grg3nVU/OpenMRS> |
| 12:43:36 | *** dkayiwa has joined #openmrs |
| 12:53:34 | <Gagaman2> Hi dkayiwa! Could you take a look at the create patient XForm? |
| 12:53:52 | <dkayiwa> hi Gagaman2 |
| 12:54:09 | <dkayiwa> i looked at it but failed to reproduce the error when i click cancel |
| 12:55:20 | <dkayiwa> Gagaman2: am i missing out on something? |
| 12:57:18 | <surangak> design call time, isnt it ? :) |
| 12:57:36 | <Gagaman2> It works know... |
| 12:57:43 | <Gagaman2> I cant believe it... |
| 12:58:05 | <dkayiwa> Gagaman2: may be you were using old version |
| 12:58:31 | <dkayiwa> surangak: i thought so too :) |
| 12:59:03 | <surangak> I shall be a silent observer, Im afraid, my mike is down :D |
| 12:59:16 | <Gagaman2> Nop, I was having the problem with the latest version of XForm... strange |
| 12:59:19 | <dkayiwa> :D |
| 12:59:31 | <Gagaman2> If it happens again, I'll let you know. |
| 12:59:33 | <dkayiwa> Gagaman2: strange indeed |
| 12:59:35 | <dkayiwa> ok |
| 12:59:44 | <Gagaman2> Hopefully it won't, though |
| 12:59:52 | <dkayiwa> :) |
| 13:00:25 | <Gagaman2> I'm having trouble now replacing the Patient Creation default form with the XForms one |
| 13:00:50 | <dkayiwa> Gagaman2: getting any errors? |
| 13:00:52 | <Gagaman2> Do you have an example one somewhere? |
| 13:01:09 | <dkayiwa> did u read the documentation? |
| 13:02:54 | <Gagaman2> Yeap, thorougly. But I still cannot find a way to repeat Patients Identifiers Types and Identifiers |
| 13:03:57 | <Gagaman2> I'd like to emulate the original HTML form in that sense. I'd like to have a repeat section with the Identifier Type listbox and the Identifier tex box to its right |
| 13:04:08 | <Gagaman2> text box |
| 13:04:26 | <dkayiwa> can you show me a screen shot of what you want? |
| 13:06:06 | *** downeym has joined #openmrs |
| 13:06:06 | *** ChanServ sets mode: +o downeym |
| 13:06:06 | *** OpenMRSBot sets mode: +o downeym |
| 13:07:34 | <Gagaman2> http://forum.openmrs.org/viewtopic.php?f=22&t=348 |
| 13:07:41 | <OpenMRSBot> <http://ln-s.net/95D+> (at forum.openmrs.org) |
| 13:08:05 | *** jriley has joined #openmrs |
| 13:08:08 | <Gagaman2> The first picture is the default short-way to create a patient |
| 13:08:27 | <Gagaman2> I can add as many Identifier Types as I need |
| 13:09:01 | <Gagaman2> and the corresponding Identifier number/key at its right |
| 13:10:12 | <Gagaman2> I'd like to emulate that situation on an XForm. I'd like to add as many Identifier Types as I need. (In this case, 3) |
| 13:10:40 | <Gagaman2> Is it possible? |
| 13:12:24 | *** jportela has joined #openmrs |
| 13:12:24 | *** ChanServ sets mode: +v jportela |
| 13:20:13 | *** wyclif has joined #openmrs |
| 13:20:39 | <Gagaman2> dkayiwa: I've been trying to change the type of the Identifier Type to "repeat", but then I loose the possible answers... |
| 13:21:12 | <dkayiwa> Gagaman2: give me your email address and i send you a version to test |
| 13:21:32 | <dkayiwa> if you confirm that it works fine, then i will immediately upload it to the module repository |
| 13:23:46 | <dkayiwa> Gagaman2: so am sending it now. you will need to refresh your patient xforms. this will bring a new field called "Other Identifiers". You will then refresh the design surface and then see a widget which lets you add other identifiers in addition to the existing prefered one |
| 13:24:16 | <dkayiwa> Gagaman2: sent |
| 13:25:26 | <Gagaman2> Thanks! |
| 13:28:49 | <dkayiwa> yo welcome |
| 13:44:12 | *** gbastien has joined #openmrs |
| 13:44:18 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Add check for changelog table when initializing liquibase - TRUNK-1926 <http://feedproxy.google.com/~r/OMRStrunk/~3/6BqLThKJc_E/OpenMRS> || New Changeset: OpenMRS (providers): TRUNK-2394: Can we use the search widget to "list all items" too? ... <http://feedproxy.google.com/~r/OMRStrunk/~3/ZNgJX5xblKI/OpenMRS> || New Changeset: OpenMRS (providers): TRUNK-2394: Can we use the search widget to "list all items" too? ... <http://feedproxy.google.com/~r/OMRStrunk/~3/g9fq5Jw7h5g/OpenMRS> |
| 13:56:00 | <Gagaman2> It works dkayiwa, thanks once again |
| 13:56:23 | <Gagaman2> What did you modify? The schema? |
| 13:58:44 | <Gagaman2> dkayiwa: what did you modify? How can I access the schema for this form? |
| 14:00:56 | <dkayiwa> Gagaman2: what do you mean by it works? |
| 14:01:47 | <Gagaman2> Sorry: I loaded the XForms you sent me, refreshed the form, the new widget appeared |
| 14:02:13 | <dkayiwa> Gagaman2: oh i see. And were you able to add multiple identifiers? |
| 14:04:38 | <Gagaman2> Yes I was |
| 14:05:06 | <Gagaman2> dkayiwa: So the remaining question is: how did you do that? |
| 14:05:22 | <dkayiwa> Gagaman2: ok. so let me upload to the module repository |
| 14:06:34 | <dkayiwa> Gagaman2: i added an new xforms repeat node for adding multiple identifiers. So on submitting the form, i loop through the submitted nodes and add then as non prefered identifiers to the patient |
| 14:06:35 | <surangak> mm... dev call was very intresting |
| 14:06:57 | <surangak> had no idea what Smart apps were |
| 14:07:03 | <dkayiwa> :) |
| 14:07:32 | <dkayiwa> i saw the gsoc presentation and understood them more :) |
| 14:08:22 | <djazayeri> hi |
| 14:09:01 | <surangak> that was very intresting Darius |
| 14:09:16 | <djazayeri> wyclif, dkayiwa, rafa, aja: scrum time |
| 14:09:19 | <Gagaman2> dkyiwa: do you add the node from the form designer? |
| 14:09:44 | <Gagaman2> dkayiwa: do you add the node from the form designer? |
| 14:10:08 | <djazayeri> surangak: what was interesting? |
| 14:10:08 | <dkayiwa> Gagaman2: i automatically create it when creating the default xform |
| 14:10:15 | <surangak> dev call :P |
| 14:10:26 | <surangak> i was a silent listner |
| 14:10:43 | <rafa> hey guys! |
| 14:10:48 | <wyclif> hi |
| 14:10:54 | <dkayiwa> hi |
| 14:10:56 | <Gagaman2> dkayiwa: do administrators have access to this form schema? |
| 14:11:00 | <Gagaman2> hi |
| 14:11:18 | <dkayiwa> Gagaman2: yes from the form designer |
| 14:11:27 | <djazayeri> so, who wants to give their update first? |
| 14:11:55 | <rafa> I'm ready |
| 14:12:19 | <djazayeri> okay, go ahead |
| 14:12:22 | <rafa> *** Rafal *** |
| 14:12:22 | <rafa> Today: |
| 14:12:22 | <rafa> * Did a first pass for TRUNK-2394: Can we use the search widget to "list all items" too? |
| 14:12:23 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2394 (awaits for approval) |
| 14:12:23 | <rafa> * Started with TRUNK-2260: Add Encounter.providers property and deprecate old Encounter.provider property |
| 14:12:23 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2260 |
| 14:12:23 | <rafa> Tomorrow: |
| 14:12:24 | <rafa> * Commit TRUNK-2260/61. |
| 14:12:24 | <rafa> * TRUNK-2566: When you first open the Manage Providers page the search widget should auto-fetch the first page of results and display them. |
| 14:12:25 | <rafa> https://tickets.openmrs.org/browse/TRUNK-2566 |
| 14:12:25 | <rafa> * Devs call |
| 14:12:26 | <rafa> No blockers. |
| 14:12:39 | *** chopin has joined #openmrs |
| 14:13:35 | <djazayeri> Okay, sounds good. |
| 14:13:52 | <djazayeri> Please do keep picking provider-related tickets. |
| 14:14:00 | <djazayeri> It'd be nice to be able to finish that feature off during this sprint. |
| 14:14:49 | <rafa> djazayeri: yeah, Kishore has finished his ticket so I can work on those :) |
| 14:16:33 | <djazayeri> cool |
| 14:16:46 | <djazayeri> okay, who's next |
| 14:16:48 | <djazayeri> dkayiwa? |
| 14:17:11 | <dkayiwa> Worked on a power backup plan to cater for the crazy electricity outages here. |
| 14:17:11 | <dkayiwa> Working on review comments for: "getHydratedObject giving errors for person attributes that are char,int, and float options when put itrying to create a new Patient" - TRUNK-2459 |
| 14:17:11 | <dkayiwa> After that i complete the last parts for:  "UI widgets for selecting a Provider" - TRUNK-2255 |
| 14:17:12 | <dkayiwa> No Blockers |
| 14:17:56 | <djazayeri> Okay |
| 14:18:03 | <wyclif> yesterday: |
| 14:18:03 | <wyclif> Spent sometime setting up and getting familiar to the SMART container code |
| 14:18:03 | <wyclif> Started work on SMART-4(Had to read the Oauth documentation) |
| 14:18:03 | <wyclif> did code review for the localization of init wizard branch |
| 14:18:03 | <wyclif> today: |
| 14:18:04 | <wyclif> code review' rafa's code for TRUNK-2394 this morning |
| 14:18:05 | <djazayeri> Good luck getting that inverter and battery set up |
| 14:18:05 | <wyclif> work on other sprint tickets |
| 14:18:07 | <wyclif> Send email about the workflow for SMART-4 |
| 14:18:15 | <dkayiwa> djazayeri: thanks :) |
| 14:18:51 | <djazayeri> wyclif: any blockers other than the OAUTH workflow? |
| 14:19:29 | <djazayeri> dkayiwa: also, make sure to focus on preparing the xforms/mobile presentation for tomorrow |
| 14:19:36 | <Gagaman2> dkayiwa: I'm confused. Normally to start an XForm, I duplicate a Basic Form, I change its name an modify the schema. Then I design the XForm, with the widgets beautylfully aligned and bound to each concept. But where's the original schema for this Patient Create Form? The widgets are already bound to fields that are not concepts, nor attributes (Other Identifier binding is "other_identifier"), and the bindings are grey, uneditables. |
| 14:20:48 | <djazayeri> wyclif: blockers? |
| 14:20:55 | *** djazayeri sets mode: +v dkayiwa |
| 14:20:57 | *** djazayeri sets mode: +v wyclif |
| 14:21:46 | <wyclif> no blockers |
| 14:22:02 | <djazayeri> okay |
| 14:22:08 | <djazayeri> aja: status? |
| 14:22:23 | <aja> yester day :dicussed with wyclif about SMART-4 and helped him to set up smartcontainer module |
| 14:22:40 | <wyclif> aja |
| 14:22:48 | <aja> fixed slf4j issue with smartcontainer unit test failure |
| 14:23:05 | <aja> finnished smartcontainer module documentation https://wiki.openmrs.org/display/docs/Smart+Container+Module |
| 14:23:11 | <OpenMRSBot> <http://ln-s.net/95Dz> (at wiki.openmrs.org) |
| 14:23:18 | *** ChanServ sets mode: +v chopin |
| 14:23:24 | <aja> today:started to modify technical documentation and continue |
| 14:23:43 | <aja> tomorrow: SMART-13 |
| 14:23:55 | <wyclif> aja, when i installed the module, the global properties for where to look up problems never got created |
| 14:24:13 | <aja> no blockers |
| 14:24:29 | <wyclif> so it took me a while, i actually had to look at the code to know that i had to create and set the global property value to true |
| 14:24:43 | <wyclif> would be good if you added this in the documentation |
| 14:25:02 | <aja> wyclif: ok |
| 14:25:22 | <wyclif> aja, any ticket of higher priority u want me to work on |
| 14:26:54 | <djazayeri> wyclif: seems like SMART-7 is a Must |
| 14:27:08 | *** surangak has quit IRC |
| 14:27:32 | <djazayeri> so I recommend that one. |
| 14:27:44 | <djazayeri> My report |
| 14:27:45 | <djazayeri> Tuesday: |
| 14:27:45 | <djazayeri> * Finished TRUNK-2560 (support visit attribute types with maxOccurs > 1), although the error handling of invalid values is only barely adequate |
| 14:27:45 | <djazayeri> * lots of small-to-medium code reviews |
| 14:27:45 | <djazayeri> * Thoughtworks Code Jam |
| 14:27:45 | <djazayeri> Today: |
| 14:27:45 | <djazayeri> * Commit TRUNK-2560 |
| 14:27:46 | <djazayeri> * Design Calls |
| 14:27:46 | <djazayeri> * More sprint tickets |
| 14:27:47 | <djazayeri> * More sprint code reviews |
| 14:27:59 | <djazayeri> No blockers |
| 14:29:24 | <djazayeri> Okay, sounds like that's all |
| 14:29:45 | <aja> wyclif: i agree on that recommendation. |
| 14:29:50 | <wyclif> cool |
| 14:29:54 | <wyclif> i have claimed it |
| 14:29:58 | <wyclif> thanks djazayeri |
| 14:32:24 | <dkayiwa> Gagaman2: The patient xform is special. It does not have a form schema. So does not use concepts. It saves the entered data using the openmrs savePatient API for patient demorgraphics, person attributes, identifiers, addresses, etc |
| 14:33:38 | <dkayiwa> Gagaman2: so the patient xform just captures data to populate the patient object before passing it over to the OpenMRS API |
| 14:33:48 | <wyclif> aja, it is necessary that a problem concept has to have a mapping to a concept source |
| 14:34:23 | <wyclif> i think you should not throw an exception if no concept mapping if found for a problem' concept\ |
| 14:34:54 | <wyclif> sorry! is it necessary? |
| 14:35:41 | <Gagaman2> dkayiwa: so if I were to add a new widget to another personal attribute I invented (say "second Citizenship"), how would an Administrator do that? |
| 14:36:24 | <djazayeri> wyclif: SMART actually does require that concepts be mapped to the appropriate terminology (SNOMED, LOINC, RXNORM, depending on the datatype) |
| 14:36:46 | <djazayeri> That's what allows all smart apps to work together |
| 14:37:54 | <dkayiwa> Gagaman2: after saving the new person attribute on the openmrs attribute management screen, you open the patient xform in the designer and refresh it (Pull New Items command). This will bring in any new attributes. You can then also refresh the design surface to have a corresponding widget automatically added for you (if you do not want to manually add it) |
| 14:38:56 | <wyclif> djazayeri, got you |
| 14:39:49 | <wyclif> djazayeri, aja, then we need to show the user a more meaningful message |
| 14:40:25 | <djazayeri> I agree. Is there a ticket for that? Or something to do with terminologies? |
| 14:40:39 | <wyclif> djazayeri, aja, because right now nothing gets returned and most of the concepts used for problems in openmrs are never mapped to these sources |
| 14:41:32 | *** rafa has quit IRC |
| 14:42:12 | <djazayeri> wyclif: actually, the mapping is a setup step, to be documented |
| 14:42:33 | <djazayeri> wyclif: I thought you said it threw an exception? |
| 14:42:44 | <Gagaman2> dkayiwa: Got it. Regarding addresses, does the XForms Module can profit from the Address Hierarchy Module? |
| 14:43:06 | <dkayiwa> Gagaman2: not at the moment |
| 14:43:40 | <dkayiwa> Gagaman2: the xforms module uses a different method to accomplish the same |
| 14:44:01 | <djazayeri> Anyway, wyclif, it's not something that the end-user can do anything about |
| 14:44:03 | <dkayiwa> Gagaman2: it uses xforms itemsets |
| 14:44:16 | *** muthah has joined #openmrs |
| 14:44:16 | <djazayeri> the sysadmin needs to make sure that the dictionary has mappings. |
| 14:44:17 | <wyclif> djazayeri, the exception is caught in the code and an empty list is returned |
| 14:44:42 | <wyclif> so the user gets the impression that there are no problems forinstance |
| 14:45:06 | <wyclif> yet the actual truth is that there might be problems but with umapped concepts |
| 14:45:39 | <djazayeri> yes, I'd prefer to throw the exception and fail loudly. |
| 14:45:50 | <djazayeri> gotta run |
| 14:45:57 | <wyclif> ok |
| 14:50:54 | <Gagaman2> dkayiwa: That cannot be made from the Form Designer, can it? |
| 14:51:35 | <dkayiwa> Gagaman2: you can make addresses from the from designer |
| 14:51:45 | <dkayiwa> Gagaman2: that is what the form designer is for |
| 14:52:23 | <Gagaman2> dkayiwa: I'm talking about nearly 2000 cities... that's an awful lot of clicking ;) |
| 14:52:47 | <dkayiwa> Gagaman2: you can put them in a database table |
| 14:53:08 | <dkayiwa> Gagaman2: then the xforms module can look them up using an auto complete widget |
| 14:54:18 | <dkayiwa> Gagaman2: when you look at the form designer's widget properties pane, you will see it has properties like "External Source" "Display Field" and "Value Field" |
| 14:54:42 | *** jportela1 has joined #openmrs |
| 14:54:48 | <dkayiwa> Gagaman2: thats exactly what those properties are for. Autolookup from external sources (like database table) |
| 14:56:26 | <Gagaman2> dkayiwa: Excelent. Thank's a lot. |
| 14:56:33 | <dkayiwa> yo welcome |
| 14:56:49 | *** jportela has quit IRC |
| 14:57:27 | <Gagaman2> dkayiwa: Province, City, ZIP-Code. Three text boxes with three select instructions looking for string on a newly created table, that's it? |
| 15:03:54 | <dkayiwa> Gagaman2: i did not understand you well |
| 15:06:01 | *** pusakat has joined #openmrs |
| 15:07:00 | <Gagaman2> dkayiwa: create a new table, import the Cities, Provinces and ZIP-Codes I have as columns of the table. Then change the Display and Value properties of each box from the Form Designer to the desired SELECT query. |
| 15:07:50 | <dkayiwa> Gagaman2: yes to the desired property values (not SELECT query) |
| 15:08:31 | <dkayiwa> Gagaman2: External Source = table name |
| 15:09:00 | <dkayiwa> Gagaman2: Display Field = display column name |
| 15:09:32 | <dkayiwa> Gagaman2: Value Field = the value to save when user choses this item (City/Province, etc) |
| 15:10:12 | <dkayiwa> Gagaman2: for the non parent items, you will also need to specify the Filter Field |
| 15:10:12 | <Gagaman2> dkayiwa: Mmm... so if I were to restrict the Cities to display based on the Province selected? |
| 15:10:41 | <dkayiwa> Gagaman2: Filter Field = column to filter with |
| 15:11:28 | <dkayiwa> Gagaman2: for that case the Filter Field value will be = province_id (assuming this is the column name for the province identifier |
| 15:12:02 | <Gagaman2> dkayiwa: Excelent. |
| 15:12:06 | <dkayiwa> Gagaman2: so the widget will display cities where the province_id is equal to the selected province |
| 15:14:12 | *** pascal` has quit IRC |
| 15:34:46 | *** jportela1 has quit IRC |
| 15:44:14 | *** pusakat has quit IRC |
| 16:13:56 | *** aja has quit IRC |
| 16:20:37 | *** rafa has joined #openmrs |
| 16:20:37 | *** ChanServ sets mode: +v rafa |
| 16:37:56 | *** daniel_____ has joined #openmrs |
| 16:38:11 | <downeym> Hi daniel_____ and welcome to the #openmrs IRC channel. |
| 16:42:20 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (localize-setup-wizard): Merged trunk into branch localize-setup-wizard rev:22353-rev:22631 <http://feedproxy.google.com/~r/OMRStrunk/~3/Z-4ESi97vQ0/OpenMRS> |
| 16:48:47 | *** rafa has quit IRC |
| 16:52:11 | *** goutham has joined #openmrs |
| 16:57:16 | *** jportela has joined #openmrs |
| 16:57:16 | *** ChanServ sets mode: +v jportela |
| 17:10:46 | *** daniel_____ has quit IRC |
| 17:32:03 | *** lh has joined #openmrs |
| 17:34:03 | *** jportela1 has joined #openmrs |
| 17:35:18 | *** rafa has joined #openmrs |
| 17:35:18 | *** ChanServ sets mode: +v rafa |
| 17:36:27 | *** lh has quit IRC |
| 17:37:27 | *** jportela has quit IRC |
| 17:51:29 | *** bwolfe has joined #openmrs |
| 17:51:29 | *** ChanServ sets mode: +o bwolfe |
| 18:11:21 | *** jportela1 has quit IRC |
| 18:24:58 | <djazayeri> wyclif: do the search widgets already limit to a certain max number of results? |
| 18:26:10 | <djazayeri> i.e. if we did the thing we're discussing with rafa on the code review, and had conceptservice return all results for "", would that just be an enormous workload on the system? |
| 18:26:21 | <djazayeri> Or would it be only return 500 results and stop? |
| 18:28:52 | *** goutham has quit IRC |
| 18:36:21 | <wyclif> djazayeri, hmmm.. |
| 18:36:26 | <wyclif> no |
| 18:36:29 | <wyclif> they fetch all |
| 18:36:42 | <djazayeri> hmm, okay, sounds like we'd want a GP to control this, right? |
| 18:36:44 | <wyclif> but it would be good to limit them not to always fetch all |
| 18:37:00 | <wyclif> so i agree with your suggestion |
| 18:37:16 | <wyclif> and i recall there work around this |
| 18:37:26 | <wyclif> let me check |
| 18:37:40 | <djazayeri> or we can let Rafal check as part of the ticket. |
| 18:39:22 | *** bryq1 has joined #openmrs |
| 18:39:58 | <wyclif> djazayeri, see https://tickets.openmrs.org/browse/TRUNK-2141 |
| 18:40:49 | <wyclif> here is a review for it https://source.openmrs.org/cru/CR-TRUNK-296 |
| 18:40:56 | <djazayeri> ah, okay, cool |
| 18:41:41 | *** bryq has quit IRC |
| 18:41:55 | <wyclif> let link the tickets and add a comment for him to get notified of this ticket |
| 18:42:04 | <wyclif> djazayeri, sorry let me |
| 18:43:17 | <djazayeri> ok, running to grab lunch now |
| 18:43:42 | *** chopin has quit IRC |
| 19:01:15 | *** bryq has joined #openmrs |
| 19:01:15 | *** ChanServ sets mode: +v bryq |
| 19:03:41 | *** bryq1 has quit IRC |
| 19:04:46 | *** rafa has quit IRC |
| 19:08:05 | *** bryq has quit IRC |
| 19:08:37 | <djazayeri> cta: question for you about the orur01 handler location ticket |
| 19:08:48 | <djazayeri> I don't see that you actually changed anything to search for name |
| 19:08:55 | <djazayeri> was this already happening, just not documented? |
| 19:11:07 | <cta> djazayeri: you are not quite right, Darius. I changes construction: return l == null ? null : l.getLocationId(); |
| 19:11:07 | <cta> to if (l != null) |
| 19:11:07 | <cta> + return l.getLocationId(); |
| 19:11:36 | <cta> this allows to make further search by name |
| 19:11:56 | <cta> and also added three unit tests |
| 19:11:59 | <djazayeri> Is that because later on in the code it was already searching by name, but never reaching that? |
| 19:13:35 | <cta> yes |
| 19:15:31 | <djazayeri> I see, I didn't notice that you changed from == to !=. Thanks! :-) |
| 19:17:15 | <cta> np |
| 19:18:05 | <cta> you are welcome |
| 19:23:03 | <cta> I gotta take shuteye, so see you all tomorrow. Bye guys. |
| 19:23:08 | <djazayeri> ciao |
| 19:23:12 | *** cta has quit IRC |
| 19:26:38 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): formatting <http://feedproxy.google.com/~r/OMRStrunk/~3/u-eZTl_1gOI/OpenMRS> || New Changeset: OpenMRS (trunk): Edit Visit should support values of visitAttributeType.maxOccurs different from 1 - TRUNK-2560 <http://feedproxy.google.com/~r/OMRStrunk/~3/8NidmTZ1yTQ/OpenMRS> |
| 19:27:22 | *** bryq has joined #openmrs |
| 19:27:22 | *** ChanServ sets mode: +v bryq |
| 19:45:54 | *** james_regen has quit IRC |
| 20:22:44 | *** bwolfe has quit IRC |
| 20:42:31 | <wyclif> hi djazayeri |
| 20:42:39 | <djazayeri> hi |
| 20:42:43 | <wyclif> i need to clarify something with you |
| 20:43:21 | <wyclif> is discontinuedDate the end date for an order or it is the date when the order was ended |
| 20:44:05 | <djazayeri> autoExpireDate is the "scheduled" end date |
| 20:44:30 | <djazayeri> "discontinuedDate" is the date that you stop the med. |
| 20:44:38 | <djazayeri> (unplanned at prescription time) |
| 20:44:47 | <wyclif> ok |
| 20:45:23 | <wyclif> thanks |
| 20:49:30 | <djazayeri> downeym: confluence is down |
| 20:49:37 | <downeym> djazayeri: i am restarting it |
| 20:50:01 | <downeym> should be back in 1 or 2 min |
| 20:50:57 | *** burke_away has joined #openmrs |
| 20:50:57 | *** ChanServ sets mode: +o burke_away |
| 20:51:04 | <burke_away> wiki wapi? |
| 20:51:16 | <burke_away> wiki back up now! yay! |
| 20:51:19 | <downeym> o.O |
| 20:51:23 | *** burke_away is now known as burke |
| 20:51:35 | * downeym considers no longer paying for monitoring service :P |
| 20:53:32 | <wyclif> djazayeri, there is a frequency field on drug order |
| 20:54:04 | <wyclif> i doubt if we tried to distinguish whether this is daily, weekly |
| 20:54:20 | <wyclif> what is the assumed duration |
| 20:55:11 | <wyclif> is this daily? |
| 20:55:12 | <djazayeri> wyclif: in the current ui, frequency is usually something like "7/week" |
| 20:55:18 | <djazayeri> it's a string right? |
| 20:55:23 | <wyclif> yes |
| 20:55:36 | <burke> we will want/need to move toward coded frequencies |
| 20:55:39 | <burke> at some point |
| 20:55:46 | <djazayeri> yes, that will happen in 1.0 |
| 20:55:48 | <wyclif> djazayeri, burke |
| 20:55:48 | <djazayeri> 1.10 |
| 20:56:20 | <burke> wyclif |
| 20:56:21 | <wyclif> this getting tricky in smart apps since we never enforced this |
| 20:56:35 | <burke> don't do this then. :) |
| 20:56:47 | <djazayeri> I recommend leaving it blank, or always saying "qd" in the first pass at this ticket |
| 20:56:53 | <burke> can we do that instead? |
| 20:57:01 | <wyclif> can we say i throw an exception if it a plain value with no duration |
| 20:57:23 | <wyclif> just like we want to do for concepts with no mappings |
| 20:57:29 | <djazayeri> i.e. do a quick first-pass where you do the obvious fields, and email the dev list and/or we talk in scrum about the tricky fields. |
| 20:57:33 | <wyclif> and ask admins to edit the drug order |
| 20:57:35 | <djazayeri> yes, sure, you can do that. |
| 20:57:52 | <djazayeri> though i'd rather discuss first before you spend much time. |
| 20:57:59 | <wyclif> what i plan to do is to parse the value and look for the text afte 'X/' |
| 20:58:28 | <wyclif> and match it agiant case insenstive constants for weekly, daily, and monthly |
| 20:59:29 | <wyclif> if the value doesn't match these combinations, i throw the exception asking the user first edit the orders just like we did for mappings |
| 20:59:56 | <wyclif> ok, i will send the email |
| 21:00:03 | <wyclif> of my proposed solution |
| 21:04:51 | <burke> wiki fail |
| 21:04:58 | <downeym> working as intended |
| 21:05:20 | <burke> working as intended == "Service Temporarily Unavailable" ? |
| 21:05:22 | <djazayeri> wyclif: sounds good, but don't spend more than 30 minutes writing that code. :-) |
| 21:05:22 | <burke> :p |
| 21:05:23 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): TRUNK-2033 - minor javadoc fix <http://feedproxy.google.com/~r/OMRStrunk/~3/IsCqT2j-_6Q/OpenMRS> |
| 21:05:28 | <downeym> yes |
| 21:05:39 | <burke> wassup? |
| 21:05:41 | <downeym> kill -9 = service stops |
| 21:06:10 | <burke> kill -9 is a bit disruptive. |
| 21:06:14 | <burke> wassup with the wiki? |
| 21:06:39 | <downeym> somehow when you added users to that group we now get mysql constraint violations |
| 21:07:05 | <downeym> aaaand we're back :) |
| 21:07:09 | <wyclif> djazayeri, ok |
| 21:13:11 | <downeym> burke: resolution to your problem found and will be fixed tomorrow. :) |
| 21:13:29 | *** rafa has joined #openmrs |
| 21:13:29 | *** ChanServ sets mode: +v rafa |
| 21:13:43 | <burke> yay! was confluence only set to 2 MB of memory? ;) |
| 21:14:14 | <downeym> 640K ought to be enough for anybody. |
| 21:25:34 | *** rafa has quit IRC |
| 21:26:29 | *** burke has quit IRC |
| 21:32:00 | *** Gagaman2 has quit IRC |
| 21:55:00 | *** dkayiwa has quit IRC |
| 22:12:50 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: XForms 4.0.6 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=xforms&version=&4.0.6> |
| 22:19:51 | *** wyclif has quit IRC |
| 22:24:51 | *** gbastien has quit IRC |
| 22:27:01 | *** jriley has quit IRC |
| 22:45:01 | *** downeym has quit IRC |
| 22:46:53 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): cleaned up imports <http://feedproxy.google.com/~r/OMRStrunk/~3/XYLq3Tbl0_g/OpenMRS> |
| 22:59:52 | *** gbastien has joined #openmrs |
| 23:00:12 | *** bryq has quit IRC |
| 23:09:34 | *** wyclif has joined #openmrs |
| 23:49:59 | *** czakian has joined #openmrs |
| 23:54:59 | <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): TRUNK-2573 - added @since to javadoc <http://feedproxy.google.com/~r/OMRStrunk/~3/JHEdbc7Bepw/OpenMRS> || New Changeset: OpenMRS (trunk): update liquibase and hibernate mappings for Location to support attributes - TRUNK-2578 <http://feedproxy.google.com/~r/OMRStrunk/~3/tavchTEUhkY/OpenMRS> || New Changeset: OpenMRS (trunk): liquibase and hibernate mappings for LocationAttribute - TRUNK-2577 <http://feedproxy.google.com/~r/OMRStrunk/~3/Gq8oSga2OCY/OpenMRS> || New Changeset: OpenMRS (trunk): liquibase and hibernate mappings for LocationAttributeType - TRUNK-2576 <http://feedproxy.google.com/~r/OMRStrunk/~3/e3s2Xv40Wu4/OpenMRS> || New Changeset: OpenMRS (trunk): domain objects for LocationAttributeType, LocationAttribute, and update Location to include LocationAttributes - TRUNK-2... <http://feedproxy.google.com/~r/OMRStrunk/~3/H-imGyDMgtw/OpenMRS> |
| 23:57:59 | <czakian> hey, I am in the situation where I need to refresh the context (like when a module is loaded) but I can't seem to find the method that triggers the refreshing of the context. Would anyone know where that might be? |
| 23:58:37 | <djazayeri> czakian: I don't know where it is, but I'd start looking in WebModuleUtil |
| 23:58:45 | <djazayeri> that must call the method you're looking for. |
| 23:58:57 | <czakian> alright, I will look there, thanks. |
| 23:58:58 | <czakian> :) |