IRC Chat : 2011-08-16 - OpenMRS

00:08:20 *** jriley has quit IRC
00:10:19 <asgoyal> djazayeri: are u busy?
00:12:58 *** gbastien has joined #openmrs
00:15:07 *** jriley has joined #openmrs
00:42:36 *** gbastien has quit IRC
00:47:05 *** asgoyal has quit IRC
01:41:37 *** suhothayan has joined #openmrs
01:41:37 *** ChanServ sets mode: +v suhothayan
01:58:41 *** wyclif has quit IRC
02:00:47 *** dkayiwa has joined #openmrs
02:03:29 *** wyclif has joined #openmrs
02:15:36 *** asgoyal has joined #openmrs
02:35:30 *** deadpool has joined #openmrs
02:44:50 *** asgoyal has quit IRC
02:45:31 <deadpool> dkayiwa: saw your repsonse to gethydrated object sorry didn't reply was without internet for a bit
02:45:41 <dkayiwa> ok
02:45:56 <deadpool> so did you just get rid of the two formats?
02:46:06 <dkayiwa> yes
02:46:11 <deadpool> ah ok
02:46:15 <deadpool> cool
02:47:45 <deadpool> dkayiwa: for the char and int values do you want me submit my patch for it?
02:48:32 <dkayiwa> is it different from my commit
02:48:44 <deadpool> not really
02:48:52 <deadpool> i was just looking at it right now
02:48:59 <dkayiwa> ok
02:49:06 <deadpool> thanks dkayiwa
02:49:17 <dkayiwa> yo welcome
03:03:57 *** upul` has joined #openmrs
03:03:57 *** ChanServ sets mode: +v upul`
03:12:04 *** gagaman has joined #openmrs
03:24:11 *** dkayiwa has quit IRC
03:41:33 *** muthah has quit IRC
03:46:53 *** jriley has quit IRC
03:49:15 *** wyclif has joined #openmrs
03:55:49 *** surangak has joined #openmrs
03:57:23 *** wyclif has quit IRC
03:57:45 *** wyclif has joined #openmrs
05:34:50 *** suhothayan has quit IRC
05:35:09 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): TRUNK-2275 [Vishnu/Sree] Domain, Liquibase and hibernate config for the Encounter Provider. <http://feedproxy.google.com/~r/OMRStrunk/~3/xI_FPZ_y_vY/OpenMRS> || New Changeset: OpenMRS (concept_mappings): Merging trunk to concept_mappings rev:21675 - rev:22557 <http://feedproxy.google.com/~r/OMRStrunk/~3/hXke-eUoLeE/OpenMRS> || New Changeset: OpenMRS (trunk): Saving a Visit Attribute Type should warn you if you enter an invalid configuration - TRUNK-2567 <http://feedproxy.google.com/~r/OMRStrunk/~3/kCXX84Nh3Po/OpenMRS> || New Changeset: OpenMRS (trunk): formatting <http://feedproxy.google.com/~r/OMRStrunk/~3/ddNyqGwG9B0/OpenMRS>
06:03:32 *** bwolfe has joined #openmrs
06:03:32 *** ChanServ sets mode: +o bwolfe
06:06:05 <surangak> good morning everyone
06:08:53 *** muthah has joined #openmrs
06:20:41 <bwolfe> hi surangak
06:20:53 <surangak> bwolfe, helloo
06:21:11 <surangak> only the two of us so far today..
06:22:41 <djazayeri> surangak: yes, although I'll join you on the other side of today eventually
06:22:59 <surangak> :D so u really are there !
06:23:20 <surangak> all this time, we were thinking that you had just left your machine on :D
06:26:45 <bwolfe> he does leave his machine on
06:27:00 <bwolfe> but its getting close to midnight there where he is...so his brain might be off already
06:27:13 <djazayeri> yes, basically
06:27:21 <djazayeri> if you're going to ask something that requires thought, do it fast. :-)
06:28:11 <surangak> over here its 11 am... so im just cruising into altitude..
06:29:52 <surangak> djazayeri, dont have anything to ask you right away im afraid :-) I was just making conversation
06:30:03 <djazayeri> that's okay, same here
06:33:54 *** bryq has joined #openmrs
06:33:54 *** ChanServ sets mode: +v bryq
06:35:20 *** muthah has quit IRC
06:36:08 <djazayeri> alright, bedtime
06:36:45 *** bwolfe has quit IRC
06:37:43 *** dkayiwa has joined #openmrs
06:38:59 <surangak> byyyyyyy Darius
06:53:16 *** rafa has joined #openmrs
06:53:16 *** ChanServ sets mode: +v rafa
06:54:22 *** pascal` has joined #openmrs
06:56:50 *** bwolfe has joined #openmrs
06:56:50 *** ChanServ sets mode: +o bwolfe
07:07:10 *** pascal` has quit IRC
07:08:05 *** pascal` has joined #openmrs
07:09:19 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Register 1.0.4 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=register&ampversion=&amp1.0.4>
07:20:21 *** cta has joined #openmrs
07:39:33 *** rafa has quit IRC
07:43:02 *** rafa has joined #openmrs
07:43:02 *** ChanServ sets mode: +v rafa
07:47:41 *** rafa_ has joined #openmrs
07:47:41 *** ChanServ sets mode: +v rafa_
07:48:33 *** rafa has quit IRC
07:50:23 *** rafa has joined #openmrs
07:50:23 *** ChanServ sets mode: +v rafa
07:52:01 *** rafa_ has quit IRC
08:30:38 <pascal`> Hey bwolfe, around?
08:31:06 <bwolfe> pascal`, for a few minutes, whats up?
08:31:55 <pascal`> bwolfe, Is there a way to grant admin rights instead of just using Context.addProxyPrivilege()?
08:32:25 <bwolfe> if you're in 1.7+ and in an activator or scheduled task, the class runs as the daemon user
08:32:30 <bwolfe> and hte daemon user has all rights
08:32:41 *** surangak has quit IRC
08:33:14 <pascal`> bwolfe, yeah, I'm just in a controller though.
08:34:41 <bwolfe> then you have to use proxy privs
08:34:46 *** surangak has joined #openmrs
08:34:52 <bwolfe> food time
08:34:52 <bwolfe> bbl
08:37:56 <dkayiwa> bwolfe: food at this time????
08:38:57 <pascal`> dkayiwa, bwolfe's stomach is on US time maybe? (=
08:39:08 <dkayiwa> hahahahah :D
08:51:26 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (1.6.x): TRUNK-2537: Module css styles in separate files don't load in Internet Explorer 9 (IE9) ... <http://feedproxy.google.com/~r/OMRStrunk/~3/hwjuHNRMIFo/OpenMRS> || New Changeset: OpenMRS (1.7.x): TRUNK-2537: Module css styles in separate files don't load in Internet Explorer 9 (IE9) ... <http://feedproxy.google.com/~r/OMRStrunk/~3/jylH0sKgCmI/OpenMRS> || New Changeset: OpenMRS (1.8.x): TRUNK-2537: Module css styles in separate files don't load in Internet Explorer 9 (IE9) ... <http://feedproxy.google.com/~r/OMRStrunk/~3/WnNfCdjCFYk/OpenMRS>
09:28:07 <bryq> Does anyone knows how to run openmrs-standalone under JPDA debugger?
09:29:14 *** upul` has quit IRC
09:29:40 *** dkayiwa has quit IRC
09:37:26 <bwolfe> pascal`, yes, still on us time. aka kids-must-eat-before-their-naps time
09:37:48 <bwolfe> so we usually sit down about 11:45 so we can be done by 12:30, get them ready for naps, and put them down for 12:45/1pm naps
09:52:31 *** surangak__ has joined #openmrs
09:52:50 *** surangak has quit IRC
10:02:51 *** surangak has joined #openmrs
10:02:51 *** surangak__ has quit IRC
10:07:25 *** deadpool has quit IRC
10:08:45 *** surangak has quit IRC
10:09:05 *** surangak has joined #openmrs
10:20:20 *** deadpool has joined #openmrs
10:40:48 *** surangak has quit IRC
10:43:10 *** djazayeri has quit IRC
10:43:15 *** surangak has joined #openmrs
10:49:47 *** bwolfe has quit IRC
10:53:48 *** rafa has quit IRC
10:59:43 *** dkayiwa has joined #openmrs
11:05:16 *** dkayiwa has quit IRC
11:12:08 *** bwolfe has joined #openmrs
11:12:08 *** ChanServ sets mode: +o bwolfe
11:14:27 *** james_regen has joined #openmrs
11:14:27 *** ChanServ sets mode: +v james_regen
11:21:43 *** rafa has joined #openmrs
11:21:43 *** ChanServ sets mode: +v rafa
11:29:36 *** djazayeri has joined #openmrs
11:29:47 *** ChanServ sets mode: +o djazayeri
11:33:43 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (providers): TRUNK-2565: Provider search widget doesn't handle partial fragments of provider.name ... <http://feedproxy.google.com/~r/OMRStrunk/~3/IOyoQx2TsqA/OpenMRS> || New Changeset: OpenMRS (providers): TRUNK-2260: Add Encounter.providers property and deprecate old Encounter.provider property ... <http://feedproxy.google.com/~r/OMRStrunk/~3/GrgViuqOG9I/OpenMRS>
11:36:43 <surangak> good morning djazayeri back so quickly ?
11:37:24 *** muthah has joined #openmrs
11:40:45 *** saimanohar has joined #openmrs
11:41:11 <saimanohar> Hi all.
11:41:39 <saimanohar> I have a problem while module upload on the modules page.It says - org.openmrs.module.ModuleException Unable to start module as Daemon
11:41:42 <saimanohar> any ideas?
11:42:33 <bwolfe> saimanohar, check your logs
11:42:38 <bwolfe> any other stacktraces in there?
11:46:40 <saimanohar> The logs folder is empty..I observed that when i added a mven dependency i get this error!!
11:47:29 *** surangak_ has joined #openmrs
11:47:39 *** surangak has quit IRC
11:47:52 <bwolfe> strange
11:48:20 <surangak_> bwolfe, whats strange ?
11:48:27 <bwolfe> saimanohar, if you're runnign at command line then the logs are just in the console
11:50:01 <surangak_> oh sorry, seemes I had jumped in the middle of another conversation :(
11:50:39 <saimanohar> Ya i have pasted the console output here - http://pastebin.com/KegC7KW3
11:55:56 *** deadpool has quit IRC
11:58:44 *** bwolfe has quit IRC
12:16:14 *** bwolfe has joined #openmrs
12:16:14 *** ChanServ sets mode: +o bwolfe
12:16:24 *** muthah has quit IRC
12:17:30 *** muthah has joined #openmrs
12:27:11 *** rafa has quit IRC
12:33:05 *** saimanohar has quit IRC
12:36:44 *** surangak has joined #openmrs
12:37:21 *** surangak has joined #openmrs
12:37:40 *** surangak_ has quit IRC
13:01:04 *** bwolfe has quit IRC
13:01:06 *** bwolfe_ has joined #openmrs
13:01:06 *** ChanServ sets mode: +o bwolfe_
13:01:42 *** bryq has quit IRC
13:07:58 *** rafa has joined #openmrs
13:07:58 *** ChanServ sets mode: +v rafa
13:12:32 *** jriley has joined #openmrs
13:31:10 *** bwolfe_ has quit IRC
13:39:54 *** gbastien has joined #openmrs
13:52:52 *** aja has joined #openmrs
14:03:30 *** gauravpaliwal has joined #openmrs
14:03:30 *** ChanServ sets mode: +v gauravpaliwal
14:04:13 *** surangak has quit IRC
14:08:42 *** cta_ has joined #openmrs
14:09:12 <djazayeri> bwolfe, rafa, dkayiwa, wyclif: hi
14:09:23 <rafa> morning Darius
14:09:26 <wyclif> hi
14:10:00 <rafa> hi wyclif
14:10:51 <djazayeri> si, scrum?
14:10:52 <rafa> wyclif: how is your tooth of wisdom? :)
14:11:02 *** cta has quit IRC
14:11:18 <wyclif> gone?
14:11:24 <wyclif> it's gone
14:12:02 <wyclif> probably i have become more stupid by a tooth
14:13:16 <rafa> wyclif: no worries ;)
14:13:16 <djazayeri> nice
14:13:33 <djazayeri> so wyclif, want to give us your update first, since it will be very fast?
14:13:44 <wyclif> sure
14:15:54 <wyclif> friday:
14:15:54 <wyclif> OCC-71(which is not reviewed yet, will finish up in next occvsprint)
14:15:54 <wyclif> Fixed all review comments for pending tickets in the sprint
14:15:54 <wyclif> today:
14:15:54 <wyclif> picked up TRUNK-2271
14:16:15 <djazayeri> !ticket trunk-2271
14:16:16 <OpenMRSBot> djazayeri: [#TRUNK-2271] Add Provider-related methods to EncounterService - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2271
14:16:22 <wyclif> but am still confused about trunk-2271
14:16:41 <djazayeri> wyclif: I thought you're working on the SMART sprint...
14:17:27 <wyclif> djazayeri, SMART?
14:18:00 <djazayeri> https://wiki.openmrs.org/display/RES/2011-08-15+Development+Sprint
14:18:05 <OpenMRSBot> <http://ln-s.net/94oi> (at wiki.openmrs.org)
14:18:58 <djazayeri> The followup to Aja's summer of code project
14:19:20 <djazayeri> remember the cool demo with the fancy javascript apps running in iframes?
14:19:28 <wyclif> i just thought SMART and 1.9 roadmap was one sprint and mutliple providers is part of 1.9
14:19:45 <djazayeri> we're having two sprints in parallel. You and Ben are working on SMART.
14:19:56 <wyclif> ok
14:20:01 <wyclif> i got no email on this
14:20:04 <djazayeri> Rafal, Daniel, and I are working on the 1.9 one.
14:20:17 <djazayeri> Sorry, I thought that Ben or Dawn would have told you.
14:20:43 <djazayeri> so, go ahead and read up on that while rafa and I give our updates.
14:20:48 <wyclif> nope
14:20:54 <djazayeri> rafa: your turn
14:20:59 <rafa> *** Rafal ***
14:20:59 <rafa> Today:
14:20:59 <rafa> * Backported TRUNK-2537: Module css styles in separate files don't load in Internet Explorer 9 (IE9)
14:20:59 <rafa> https://tickets.openmrs.org/browse/TRUNK-2537
14:20:59 <rafa> * Fixed TRUNK-2565: Provider search widget doesn't handle partial fragments of provider.name
14:20:59 <rafa> https://tickets.openmrs.org/browse/TRUNK-2565
14:21:00 <rafa> * Started with TRUNK-2394: Can we use the search widget to "list all items" too?
14:21:00 <rafa> https://tickets.openmrs.org/browse/TRUNK-2394
14:21:01 <rafa> * Code-reviews
14:21:01 <rafa> Tomorrow:
14:21:02 <rafa> * Continue with TRUNK-2394: Can we use the search widget to "list all items" too?
14:21:02 <rafa> https://tickets.openmrs.org/browse/TRUNK-2394
14:21:03 <rafa> * Hopefully start with
14:21:03 <rafa> - TRUNK-2260: Add Encounter.providers property and deprecate old Encounter.provider property
14:21:04 <rafa> https://tickets.openmrs.org/browse/TRUNK-2260
14:21:04 <rafa> - TRUNK-2261: Liquibase script to migrate legacy Encounter.provider data to Encounter.providers
14:21:05 <rafa> https://tickets.openmrs.org/browse/TRUNK-2261
14:21:05 <rafa> (I'm awaiting for TRUNK-2275 to be corrected)
14:21:06 <rafa> * Design call
14:21:06 <rafa> Blockers:
14:21:07 <rafa> * TRUNK-2275 (Kishore is working on that)
14:21:57 <djazayeri> Cool.
14:22:04 <djazayeri> You may want to talk to Wyclif about trunk-2394
14:22:15 <djazayeri> he thought about that one a bit before.
14:22:29 <djazayeri> I'll ping Kishore about trunk-2275
14:22:39 <djazayeri> meant to do it yesterday, but forgot.
14:22:48 <rafa> djazayeri: 2394 seems clear to me right now.
14:23:00 <wyclif> !ticket trunk-2394
14:23:01 <OpenMRSBot> wyclif: [#TRUNK-2394] Can we use the search widget to "list all items" too? - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-2394
14:23:16 <rafa> djazayeri: I just need to learn more about the js code behind it
14:23:35 <djazayeri> Ah, okay, looks like Wyclif already provided the relevant info as a ticket comment.
14:23:47 <rafa> djazayeri: yes
14:23:57 <rafa> Kishore committed some code yesterday
14:24:05 <rafa> it needs to be fixed though
14:24:08 <djazayeri> okay
14:24:30 <rafa> it's nothing big, 10 minutes of work
14:24:39 <wyclif> rafa, read the last comment i added to the ticket
14:25:12 <rafa> thanks wyclif it explains everything
14:25:27 <wyclif> rafa, the changes in the API might not be that few
14:26:17 <djazayeri> well, those can be done as we go.
14:26:25 <rafa> yeah, 10 minutes of work referred to trunk-2275 :)
14:26:44 <wyclif> ok
14:26:47 *** bwolfe_ has joined #openmrs
14:26:47 *** ChanServ sets mode: +o bwolfe_
14:26:51 <djazayeri> okay, if you're still waiting on that you can just do the 10 minutes of work yourself.
14:26:57 *** asgoyal has joined #openmrs
14:27:01 *** djazayeri sets mode: +v wyclif
14:27:37 <rafa> I'm done for today. If Kishore doesn't find time for that, I'll do it tomorrow :)
14:28:13 *** bwolfe_ is now known as bwolfe
14:28:25 <djazayeri> bwolfe: I thought you were out today?
14:28:31 <bwolfe> tomorrow
14:28:36 <djazayeri> oh, okay
14:28:51 <bwolfe> I was at ampath just now helping with the programmers. and got caught up on my way out, sorry I'm late
14:28:53 <djazayeri> you may want to point wyclif to a SMART ticket.
14:29:13 <bwolfe> is he not able to pick one from the list? :-)
14:29:21 <wyclif> i have found them
14:29:21 <djazayeri> perhaps he can do that
14:31:36 <djazayeri> Okay, my report:
14:31:37 <djazayeri> Monday
14:31:37 <djazayeri> * ~8 code reviews
14:31:37 <djazayeri> * found and fixed TRUNK-2567 (a bug with visit attribute types)
14:31:37 <djazayeri> * started researching TRUNK-2560 (support visit attribute types with maxOccurs > 1)
14:31:38 <djazayeri> Today
14:31:38 <djazayeri> * TRUNK-2560
14:31:39 <djazayeri> * more sprint tickets
14:31:39 <djazayeri> * more code reviews
14:31:40 <djazayeri> * Thoughtworks Code Jam
14:32:44 <djazayeri> no blockers
14:34:10 <rafa> where are guys from thoughtworks located? Seattle?
14:34:24 <djazayeri> Bellevue. It's across the lake from here.
14:34:58 <rafa> Great, I'll remember it's your timezone now :)
14:35:36 <djazayeri> Indeed. The lake actually means the lake. It's not a clever way of referring to the Pacific ocean.
14:36:11 <djazayeri> bwolfe: got an update?
14:36:22 <bwolfe> writing it up, one sec
14:37:21 <bwolfe> today:
14:37:21 <bwolfe> CR-TRUNK-451, dwrvisitservice bug
14:37:21 <bwolfe> a few leftover occ reviews
14:37:21 <bwolfe> updated some smart tickets thanks to josh
14:37:21 <bwolfe> SMART-8, fixing smartproblem to include obs
14:37:21 <bwolfe> looking into occ tickets for the 1 week sprint
14:37:23 <bwolfe> tomorrow:
14:37:25 <bwolfe> holiday
14:37:29 <bwolfe> thurs:
14:37:32 <bwolfe> meetings, smart, etc
14:37:38 <bwolfe> djazayeri, I'll be back by 9 or 10pm our time. so I can join our call then
14:37:52 <djazayeri> okay
14:38:11 *** muthah has quit IRC
14:39:07 <djazayeri> aja?
14:39:34 <aja> yes
14:39:47 <djazayeri> You're also working on SMART now, right?
14:39:54 <djazayeri> Want to give an update?
14:39:58 <aja> yes
14:40:11 <djazayeri> (what you did yesterday/today, what you'll do today/tomorrow, any blockers?)
14:40:47 <wyclif> so i'm new to the SMART module, are there any specical configurations i need to make before running the module?
14:40:53 <djazayeri> (oh, rafa, when you finish trunk-2394, you also get trunk-2566 as bonus)
14:41:06 <aja> yesterday i converted RDF sourses to use PrettyRDFWritter
14:41:38 <rafa> djazayeri: (all right)
14:42:01 <aja> and added patient with obs,encounter..to enable unit testing
14:42:10 <bwolfe> wyclif, read the docs. ;-)
14:42:25 <aja> ..commented on some SMART tickets
14:42:25 <bwolfe> wyclif, and if you find something lacking, tell aja so he can update it.
14:42:42 <rafa> djazayeri: (shall I commit 2394 to providers branch only then?)
14:43:14 <bwolfe> aja, congrats on the way you've split the logic for generating RDFs and converting from openmrs objects to smart objects. it was super easy to add in the obs searching for problems. :-D
14:43:40 <djazayeri> rafa: that's probably easiest
14:43:48 <djazayeri> unless you want to merge trunk to the providers branch. :-)
14:43:53 <bwolfe> aja, during the spring, try to commit in smaller batches so that we don't get huge merges
14:44:13 <bwolfe> aja, wyclif, you should also update your module often, to pick up changes done during hte day (and night)
14:44:17 <aja> today i had lot of lectures at university ,just come to home
14:45:12 <aja> today i am going to start on documentation according to gsoc schedule
14:45:44 <djazayeri> cool
14:46:00 <aja> tomorrow also i am going to work on documentation
14:46:14 <aja> bwolfe: Thanks
14:46:28 <bwolfe> aja, claim that ticket in the sprint then too. :-)
14:46:34 <bwolfe> aja, https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=10550
14:46:34 <OpenMRSBot> <http://ln-s.net/94_C> (at tickets.openmrs.org)
14:48:53 *** sunbiz has joined #openmrs
14:49:56 <sunbiz> hey guys...
14:50:04 <djazayeri> hi sunbiz
14:50:11 <sunbiz> I was reading this old thread which talked about problems with h2 - http://openmrs-mailing-list-archives.1560443.n2.nabble.com/In-memory-database-for-development-mode-td5459996.html
14:50:16 <OpenMRSBot> <http://ln-s.net/94p:> (at openmrs-mailing-list-archives.1560443.n2.nabble.com)
14:50:24 <sunbiz> hey darius
14:50:45 <sunbiz> in this changeset<addColumn tableName="concept_set">
14:50:45 <sunbiz> <column name="concept_set_id" type="int(11)" autoIncrement="true">
14:50:45 <sunbiz> <constraints nullable="false" unique="true" uniqueConstraintName="concept_set_id_unique" />
14:50:45 <sunbiz> </column>
14:50:45 <sunbiz> </addColumn>
14:51:29 <sunbiz> the unit tests give an error because H2 does not support adding primary key columns
14:51:38 <sunbiz> any solutions??
14:52:11 <djazayeri> Why was this able to work before?
14:52:30 *** bwolfe has quit IRC
14:53:28 <sunbiz> I'm not quiet sure... may be something to do with hsql and h2
14:54:17 <sunbiz> I know it wasn't working earlier... when I was trying to install on h2 database in-memory... would give the same error
14:54:37 <sunbiz> but the unit tests always ran fin
14:54:39 <sunbiz> *fien
14:54:44 <sunbiz> **fine
14:55:18 <djazayeri> Is that in the update-to-latest file?
14:55:52 <sunbiz> yes
14:56:16 *** free__ has joined #openmrs
14:57:46 *** pascal` has quit IRC
14:58:09 <djazayeri> So, the solution is probably to redo the liquibase-schema-only and liquibase-core files for 1.9
14:58:26 <djazayeri> thus removing a bunch of changesets (like this one) from the update-to-latest file.
14:58:28 <djazayeri> Right?
14:59:21 <sunbiz> yes... is there a way to deprecate changesets??
15:04:01 <djazayeri> sunbiz: not sure what our strategy is for that...
15:04:57 <sunbiz> but fi we redo the liquibase-schema-only... then some might not get to upgrade from oldest versions of OpenMRS... right??
15:05:11 <djazayeri> sunbiz: yeah, I don't know what our strategy is for this...
15:05:21 *** rafa has quit IRC
15:05:26 *** asgoyal has quit IRC
15:05:42 <djazayeri> Actually we can just leave them in liquibase-update-to-latest, since the changesets all have preconditions
15:06:32 *** gauravpaliwal has left #openmrs
15:08:21 <sunbiz> ok... but the test fails
15:08:46 <sunbiz> djazayeri: what about the failing unit tests
15:09:07 <djazayeri> Unit tests don't run liquibase changesets, do they?
15:09:38 <sunbiz> yes... they do run the liquibase-update-to-latest
15:09:47 <sunbiz> org.openmrs.util.DatabaseUpdaterTest
15:09:54 <djazayeri> ah okay
15:10:45 <djazayeri> Well, the problem is that we're running this test against H2, which doesn't seem to really be a production-worthy DB.
15:11:23 <djazayeri> so the right thing would be to change that unit test so it runs against embedded versions of mysql, postgresql, oracle, etc.
15:11:25 <djazayeri> :-)
15:11:29 <djazayeri> want to do that. ;-)
15:11:57 <sunbiz> :D
15:12:36 <sunbiz> djazayeri: anything other than the drastic ideal??
15:12:42 <djazayeri> is there a way you can try/catch the error with that one changeset and just move on?
15:13:43 <sunbiz> djazayeri: probably... in the unit test... right??
15:13:50 <djazayeri> yes
15:13:59 <sunbiz> change nothing in the liquibase-update-to-latest... right??
15:20:59 <djazayeri> correct
15:21:57 <sunbiz> ok... leme try that
15:39:49 <cta_> djazayeri: Darius, I added new patch that considers with your after-review comments on tickets TRUNK-32. Updated review here https://source.openmrs.org/cru/CR-TRUNK-453
15:41:02 *** dkayiwa has joined #openmrs
15:42:30 *** free__ has quit IRC
15:45:52 *** bryq has joined #openmrs
15:45:52 *** ChanServ sets mode: +v bryq
16:03:20 *** sunbiz has left #openmrs
16:10:13 *** goutham has joined #openmrs
16:13:01 *** gbastien has quit IRC
16:14:46 *** goutham has quit IRC
16:24:35 *** yanokwa has joined #openmrs
16:24:45 *** ChanServ sets mode: +v yanokwa
16:46:51 *** dkayiwa has quit IRC
16:50:52 *** jprice has quit IRC
17:09:02 *** Suranga has joined #openmrs
17:10:27 *** bryq has quit IRC
17:14:20 <Suranga> hi djazayeri
17:14:25 <djazayeri> hi Suranga
17:14:34 <Suranga> djazayeri, can I hav 5 mins please :)
17:14:55 *** jriley has left #openmrs
17:15:03 <Suranga> this is regarding https://tickets.openmrs.org/browse/TRUNK-2563
17:15:04 *** jriley has joined #openmrs
17:15:23 <Suranga> the issues that i pointed out in image handler I have fixed, and will be committing soon...
17:15:42 <Suranga> but now im seeing something very bad with TextHandlers :)
17:15:49 <djazayeri> okay
17:15:51 <djazayeri> and that is?
17:16:07 <Suranga> It seems that texthandlers are saving files in app data folder... but the files themselves are blank
17:16:11 <Suranga> they are totally empty
17:16:25 <Suranga> I tried using txt files and ws word docs...
17:16:55 <Suranga> this too I can fix... only I was curious if this is because im doing something wrong
17:17:06 <djazayeri> actually I've never used complex obs
17:17:12 <djazayeri> so I don't know how exactly it works
17:17:15 <Suranga> ohh, I see
17:17:18 <djazayeri> have you looked at the screenshots/docs on the wiki?
17:17:50 <Suranga> actually theere is no mention on how TextHandlers work on the wiki...
17:18:01 *** bryq has joined #openmrs
17:18:01 *** ChanServ sets mode: +v bryq
17:18:18 <Suranga> whjo should I talk to regarding complex Obs stuff ?
17:19:27 <djazayeri> Not sure, actually. The original author of a lot of the code isn't around anymore.
17:19:55 <djazayeri> I'm sure they're being used somewhere, but I don't know who's an authority.
17:21:39 *** Suranga has quit IRC
17:21:48 *** Suranga_ has joined #openmrs
17:24:30 <OpenMRSBot> Recent updates in the world of openmrs: New Changeset: OpenMRS (trunk): Upgrade to liquibase 2.0.1 - TRUNK-1926 <http://feedproxy.google.com/~r/OMRStrunk/~3/mhi_xG8zXBo/OpenMRS>
17:25:49 <Suranga_> djazayeri, sorry I got cut off.. did u say anything ?
17:26:02 <djazayeri> Not sure, actually. The original author of a lot of the code isn't around anymore.
17:26:02 <djazayeri> djazayeri @ 10:19
17:26:02 <djazayeri> I'm sure they're being used somewhere, but I don't know who's an authority.
17:26:48 <Suranga_> I tried checking irc logs, but they havent got updated yet :(
17:28:10 <Suranga_> djazayeri, no problem... Ill study this.. and jot down my 'battle plan' on the ticket, and go ahead with it...
17:28:12 <Suranga_> djazayeri, thanks for the info
17:31:58 <djazayeri> np
17:32:10 *** rafa has joined #openmrs
17:32:10 *** ChanServ sets mode: +v rafa
17:37:30 *** downeym has joined #openmrs
17:37:30 *** ChanServ sets mode: +o downeym
17:37:30 *** OpenMRSBot sets mode: +o downeym
17:52:40 *** aja has quit IRC
17:54:52 *** gbastien has joined #openmrs
18:01:47 *** Suranga_ has quit IRC
18:05:57 *** yanokwa has quit IRC
18:07:08 *** wyclif has quit IRC
18:15:48 *** cta_ has quit IRC
18:19:18 *** sunbiz has joined #openmrs
18:19:26 *** ChanServ sets mode: +v sunbiz
18:36:15 *** suho has joined #openmrs
18:36:15 *** ChanServ sets mode: +v suho
18:37:26 *** wyclif has joined #openmrs
18:38:42 *** bryq has quit IRC
18:39:05 *** bryq has joined #openmrs
18:39:05 *** ChanServ sets mode: +v bryq
18:45:24 *** rafa has quit IRC
18:51:38 *** downeym has quit IRC
19:39:45 *** rafa_ has joined #openmrs
19:39:48 *** ChanServ sets mode: +v rafa_
19:41:26 *** muthah has joined #openmrs
19:44:26 *** suho has quit IRC
19:46:44 *** james_regen has left #openmrs
20:12:23 *** rafa_ has quit IRC
20:15:40 <sunbiz> djazayeri: do u know if contextConfigLocation in web.xml can be overloaded using a module??
20:15:54 <djazayeri> sunbiz: I don't know. I doubt it
20:16:20 <sunbiz> the filters can be overloaded... so I thought other stuff might be possible as well
20:18:16 <sunbiz> but I can include other bean xml into my moduleApplicationContext.xml ??
20:18:20 <sunbiz> is that possible??
20:19:15 <sunbiz> djazayeri: because in the contextConfigLocation, we already have moduleApplicationContext.xml to be the first entry... but how can I ensure that my module's config is the first one to be loaded
20:23:00 <djazayeri> sunbiz: What would be the mechanism for that if you controlled web.xml?
20:23:18 <sunbiz> I would put it as the first entry
20:23:38 <sunbiz> for the contextConfigLocation
20:33:29 *** yanokwa has joined #openmrs
20:33:29 *** ChanServ sets mode: +v yanokwa
20:33:37 <djazayeri> nothing springs to mind
20:37:35 <sunbiz> djazayeri: okies... nevermind :(
20:47:10 *** szrrizvi has joined #openmrs
20:51:51 <szrrizvi> Hi. I am trying to prevent crash OpenMRS from Context.startup(Properties) method, by a custom exception. Can anyone help please?
20:53:31 <szrrizvi> I'm sorry, I meant: I am trying to crash* OpenMRS from ...
21:00:05 <szrrizvi> My custome exception currently extends RuntimeException. So when I start up OpenMRS by "jetty:run", the exception is thrown and printed on the console, but the OpenMRS webapp still works properly.
21:00:28 <djazayeri> so you *want* to crash?
21:00:34 <szrrizvi> yes
21:02:45 <szrrizvi> I think I just solved my problem. Testing it now.
21:05:39 <szrrizvi> nope. the webapp still loads
21:09:18 <djazayeri> Generally i've noticed that OpenMRS starts up sometimes even when things like core modules don't start
21:09:30 <djazayeri> so it's possible this is a bug in the system
21:12:08 *** szrrizvi has quit IRC
21:16:21 *** szrrizvi has joined #openmrs
21:32:19 *** yanokwa has quit IRC
21:37:40 <szrrizvi> djazayeri: any ideas on how I could get it to crash?
21:38:05 <djazayeri> I haven't ever investigated.
21:38:21 <djazayeri> I would recommend using the debugger, and adding a breakpoint right where you throw the exception
21:38:37 <djazayeri> then, from there, see where it actually gets caught.
21:39:00 <szrrizvi> alright. I'll try that. thank you
21:40:57 *** szrrizvi has quit IRC
21:42:55 *** bryq has quit IRC
21:54:06 *** djazayeri has quit IRC
21:59:55 *** djazayeri has joined #openmrs
21:59:55 *** ChanServ sets mode: +o djazayeri
22:01:11 *** sunbiz has left #openmrs
22:08:30 *** wyclif has quit IRC
22:19:21 *** gbastien has quit IRC
23:15:47 *** jriley has quit IRC
23:17:43 *** djazayeri has quit IRC
23:21:37 *** jriley has joined #openmrs
23:26:06 *** wyclif has joined #openmrs